1 2019-02-12T00:05:40  *** infernix has joined #bitcoin-core-dev
  2 2019-02-12T00:12:56  *** rex4539 has quit IRC
  3 2019-02-12T00:29:45  *** Karyon_ has quit IRC
  4 2019-02-12T00:30:09  *** Karyon_ has joined #bitcoin-core-dev
  5 2019-02-12T00:35:39  *** jb55 has joined #bitcoin-core-dev
  6 2019-02-12T00:46:01  *** jarthur has quit IRC
  7 2019-02-12T00:53:40  *** sipa has joined #bitcoin-core-dev
  8 2019-02-12T00:54:00  *** DeanGuss has joined #bitcoin-core-dev
  9 2019-02-12T00:59:26  *** valwal has joined #bitcoin-core-dev
 10 2019-02-12T00:59:31  *** Jackielove4u has joined #bitcoin-core-dev
 11 2019-02-12T00:59:31  *** hsmiths has joined #bitcoin-core-dev
 12 2019-02-12T00:59:53  *** dongcarl has joined #bitcoin-core-dev
 13 2019-02-12T01:04:52  *** spinza has joined #bitcoin-core-dev
 14 2019-02-12T01:16:28  *** pinheadmz has quit IRC
 15 2019-02-12T01:29:35  *** drexl has joined #bitcoin-core-dev
 16 2019-02-12T01:30:40  *** dviola has joined #bitcoin-core-dev
 17 2019-02-12T01:31:16  *** IGHOR has quit IRC
 18 2019-02-12T01:32:48  *** IGHOR has joined #bitcoin-core-dev
 19 2019-02-12T01:37:28  *** ddustin has quit IRC
 20 2019-02-12T01:50:14  *** spinza has quit IRC
 21 2019-02-12T02:14:58  *** AaronvanW has quit IRC
 22 2019-02-12T02:15:15  *** Karyon_ has quit IRC
 23 2019-02-12T02:15:43  *** Karyon_ has joined #bitcoin-core-dev
 24 2019-02-12T02:16:37  *** _Krayon__ has joined #bitcoin-core-dev
 25 2019-02-12T02:17:41  *** bitcoin-git has joined #bitcoin-core-dev
 26 2019-02-12T02:17:41  <bitcoin-git> [bitcoin] ken2812221 closed pull request #15376: appveyor: ignore functional test failure (master...appveyor-ignore-functional-tests) https://github.com/bitcoin/bitcoin/pull/15376
 27 2019-02-12T02:17:42  *** bitcoin-git has left #bitcoin-core-dev
 28 2019-02-12T02:19:56  *** Karyon_ has quit IRC
 29 2019-02-12T02:32:05  *** harrymm has quit IRC
 30 2019-02-12T02:32:11  *** dviola has quit IRC
 31 2019-02-12T02:36:12  *** _Krayon__ has quit IRC
 32 2019-02-12T02:43:49  *** sipa has quit IRC
 33 2019-02-12T02:44:23  *** dermoth has quit IRC
 34 2019-02-12T02:46:19  *** dermoth has joined #bitcoin-core-dev
 35 2019-02-12T03:05:21  *** DeanGuss has quit IRC
 36 2019-02-12T03:11:24  *** StopAndDecrypt has joined #bitcoin-core-dev
 37 2019-02-12T03:22:10  *** spinza has joined #bitcoin-core-dev
 38 2019-02-12T03:30:38  *** sipa has joined #bitcoin-core-dev
 39 2019-02-12T03:34:22  *** pinheadmz has joined #bitcoin-core-dev
 40 2019-02-12T03:37:21  *** StopAndDecrypt has quit IRC
 41 2019-02-12T03:37:44  *** StopAndDecrypt has joined #bitcoin-core-dev
 42 2019-02-12T03:37:54  *** StopAndDecrypt has quit IRC
 43 2019-02-12T03:37:54  *** StopAndDecrypt has joined #bitcoin-core-dev
 44 2019-02-12T03:43:59  *** Murch has quit IRC
 45 2019-02-12T04:06:34  *** pinheadmz has quit IRC
 46 2019-02-12T04:17:10  *** pinheadmz has joined #bitcoin-core-dev
 47 2019-02-12T04:37:16  *** pinheadmz has quit IRC
 48 2019-02-12T04:39:22  *** spinza has quit IRC
 49 2019-02-12T04:57:51  *** Eagle[TM] has joined #bitcoin-core-dev
 50 2019-02-12T05:00:04  *** EagleTM has quit IRC
 51 2019-02-12T05:02:58  *** ap4lmtree has quit IRC
 52 2019-02-12T05:10:55  *** keymone has quit IRC
 53 2019-02-12T05:11:33  *** keymone has joined #bitcoin-core-dev
 54 2019-02-12T05:12:43  *** ap4lmtree has joined #bitcoin-core-dev
 55 2019-02-12T05:14:32  *** niska has quit IRC
 56 2019-02-12T05:24:39  *** niska has joined #bitcoin-core-dev
 57 2019-02-12T05:35:52  *** spinza has joined #bitcoin-core-dev
 58 2019-02-12T05:37:53  *** pinheadmz has joined #bitcoin-core-dev
 59 2019-02-12T06:05:07  *** niska has quit IRC
 60 2019-02-12T06:15:35  *** niska has joined #bitcoin-core-dev
 61 2019-02-12T06:22:26  *** schmidty_ has joined #bitcoin-core-dev
 62 2019-02-12T06:22:43  *** schmidty has quit IRC
 63 2019-02-12T06:31:04  *** rabidus has quit IRC
 64 2019-02-12T06:31:21  *** rabidus has joined #bitcoin-core-dev
 65 2019-02-12T06:36:16  *** bitcoin-git has joined #bitcoin-core-dev
 66 2019-02-12T06:36:16  <bitcoin-git> [bitcoin] Csi18nAlistairMann opened pull request #15387: docs: add "sections" info to example bitcoin.conf (master...confSections) https://github.com/bitcoin/bitcoin/pull/15387
 67 2019-02-12T06:36:20  *** bitcoin-git has left #bitcoin-core-dev
 68 2019-02-12T06:39:44  *** copumpkin has quit IRC
 69 2019-02-12T07:00:10  *** jtimon has quit IRC
 70 2019-02-12T07:15:03  *** Eagle[TM] has quit IRC
 71 2019-02-12T07:21:11  *** emzy_ has quit IRC
 72 2019-02-12T07:21:12  *** emzy_ has joined #bitcoin-core-dev
 73 2019-02-12T07:21:22  *** emzy_ is now known as Emzy
 74 2019-02-12T07:31:08  *** irecall has joined #bitcoin-core-dev
 75 2019-02-12T07:39:44  *** DeanGuss has joined #bitcoin-core-dev
 76 2019-02-12T07:42:04  *** pinheadmz has quit IRC
 77 2019-02-12T07:56:02  *** wetson has joined #bitcoin-core-dev
 78 2019-02-12T07:59:48  *** wetson has quit IRC
 79 2019-02-12T08:01:03  <wumpus> do we have any code-wide preference for the order of input versus output arguments?
 80 2019-02-12T08:01:24  <wumpus> I don't *think* so, but we probably should
 81 2019-02-12T08:01:49  <wumpus> (this is something I realized while reviewing #13932)
 82 2019-02-12T08:01:51  <gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
 83 2019-02-12T08:02:15  *** promag has joined #bitcoin-core-dev
 84 2019-02-12T08:05:57  <sipa> i don't think we do
 85 2019-02-12T08:06:16  <provoostenator> wumpus: I also noticed it. Initially I was confused, but then found some reasonable arguments in favor of putting outputs first, because the number of input arguments tends to grow over time.
 86 2019-02-12T08:06:27  *** promag has quit IRC
 87 2019-02-12T08:06:42  <provoostenator> But I don't think it's worth making rules around that.
 88 2019-02-12T08:06:43  <wumpus> at the least, I think having methods with different orderings on the same class is confusing
 89 2019-02-12T08:06:44  <gmaxwell> outputs first looks like assignment,  output = input. :)
 90 2019-02-12T08:06:52  <wumpus> I don't have any particular preference I just like consistency
 91 2019-02-12T08:07:13  <sipa> libsecp256k1 has a strict ordering of output first, then inputs, and within each ordered from most-recently-computed to oldest
 92 2019-02-12T08:07:14  <provoostenator> Although in general I often find it hard to tell when I see methods get called. It's more clear in the method definitions.
 93 2019-02-12T08:07:56  <sipa> but imposing such rules on an existing project sounds much more burden than it's worth
 94 2019-02-12T08:07:58  <wumpus> would be better to simply return output arguments, too bad we can't use std::optional
 95 2019-02-12T08:07:58  <provoostenator> Especially with all the references it gets confusing fast.
 96 2019-02-12T08:08:17  <wumpus> sipa: I agree but what about new code?
 97 2019-02-12T08:08:28  <gmaxwell> (also it's a common convention in libc, e.g. memcpy(dest,src,...))
 98 2019-02-12T08:08:42  <provoostenator> std::optional sounds great. Part of c++17 so looking forward to using that in 2023
 99 2019-02-12T08:08:50  *** ap4lmtree has quit IRC
100 2019-02-12T08:08:59  <sipa> c++ stl usually has inputs first, outputs last
101 2019-02-12T08:09:10  <sipa> (different from libc)
102 2019-02-12T08:09:13  *** ap4lmtree has joined #bitcoin-core-dev
103 2019-02-12T08:09:19  <wumpus> yes
104 2019-02-12T08:09:44  <gmaxwell> (sprintf(buf, fmt, vaargs)...)
105 2019-02-12T08:09:54  <wumpus> I don't think c++'s reference syntax made output arguments particularly clearer
106 2019-02-12T08:10:13  <wumpus> at least in C it's usually recognizable because the caller has to take a pointer
107 2019-02-12T08:10:51  <gmaxwell> (to be clear, I don't particularly care, I have a preference for dest first in C, but C++ is already crazy regardless of the order. :P )
108 2019-02-12T08:10:55  <sipa> google c++ only lets you pass const references; if you want something mutable, it needs to be a pointer
109 2019-02-12T08:10:57  <wumpus> in C++ it's sometimes magic 'oh, so this value gets changed'
110 2019-02-12T08:11:04  <wumpus> sipa: I like that
111 2019-02-12T08:11:43  <sipa> (which makes sense syntactically, but semantically is somewhat ridiculous... modern c++ shouldn't need to deal with raw pointers pretty much ever)
112 2019-02-12T08:12:03  <sipa> that was also pre-c++11, i don't know what changed
113 2019-02-12T08:12:31  <sipa> ideally output arguments are actual outputs, and with std::pair/tuple and move semantics that became a lot more reasonable
114 2019-02-12T08:12:42  <wumpus> yea, I don't mean we should do that, but I like that some people thought about this and came to a similar conclusion as me
115 2019-02-12T08:13:10  <sipa> c++17 structured bindings are even nicer
116 2019-02-12T08:13:37  <sipa> auto [a,b,c] = function_returning_3tuple()
117 2019-02-12T08:13:48  <wumpus> yes, nice
118 2019-02-12T08:14:20  * sipa patiently awaits RHEL to adopt GCC 8
119 2019-02-12T08:15:21  *** csknk has joined #bitcoin-core-dev
120 2019-02-12T08:20:11  <wumpus> ideally "output" arguments would only be necessary for "inout" arguments that get modified in place
121 2019-02-12T08:20:25  <wumpus> not for anything that is created anew
122 2019-02-12T08:21:12  *** rex4539 has joined #bitcoin-core-dev
123 2019-02-12T08:21:38  <wumpus> GCC 8 ? that's going to be a long wait I'm afraid
124 2019-02-12T08:23:43  *** csknk has quit IRC
125 2019-02-12T08:23:59  *** csknk has joined #bitcoin-core-dev
126 2019-02-12T08:25:17  <sipa> most of it is in gcc 7
127 2019-02-12T08:26:19  <wumpus> gcc 7 is in ubuntu 18.04 LTS that's good at least
128 2019-02-12T08:32:43  <sipa> gcc 8.2 is in bionic too, it seems: https://packages.ubuntu.com/bionic/gcc-8
129 2019-02-12T08:32:55  <sipa> oh, not sure if that's gcc 8.1 or 8.2
130 2019-02-12T08:33:14  *** csknk has left #bitcoin-core-dev
131 2019-02-12T08:33:51  <sipa> yeah, 8.2
132 2019-02-12T08:33:55  <wumpus> it's possible to install the alternative gcc but I think it is installed next to the normal one
133 2019-02-12T08:34:20  <sipa> yes
134 2019-02-12T08:34:26  <wumpus> which is somewhat annoying to work with with build systems and such, remember having some trouble with this at some point
135 2019-02-12T08:44:47  *** JackH has quit IRC
136 2019-02-12T09:00:01  *** rh0nj has quit IRC
137 2019-02-12T09:00:59  <wumpus> dang I had forgot we have our own Optional<> type wrapping boosts', have suggested using that to avoid this discussion
138 2019-02-12T09:01:09  *** rh0nj has joined #bitcoin-core-dev
139 2019-02-12T09:01:11  *** EagleTM has joined #bitcoin-core-dev
140 2019-02-12T09:09:46  *** cluelessperson has joined #bitcoin-core-dev
141 2019-02-12T09:12:32  *** setpill has joined #bitcoin-core-dev
142 2019-02-12T09:31:56  *** JackH has joined #bitcoin-core-dev
143 2019-02-12T09:32:25  *** promag has joined #bitcoin-core-dev
144 2019-02-12T09:50:13  *** timothy has joined #bitcoin-core-dev
145 2019-02-12T09:53:25  *** owowo has quit IRC
146 2019-02-12T10:00:13  *** prometheus_falli has joined #bitcoin-core-dev
147 2019-02-12T10:03:03  *** kexkey has quit IRC
148 2019-02-12T10:04:34  *** spinza has quit IRC
149 2019-02-12T10:05:27  *** Kevin has joined #bitcoin-core-dev
150 2019-02-12T10:06:20  *** prometheus_falli has quit IRC
151 2019-02-12T10:06:52  *** Kevin has quit IRC
152 2019-02-12T10:14:40  *** shesek has quit IRC
153 2019-02-12T10:15:59  *** booyah has joined #bitcoin-core-dev
154 2019-02-12T10:17:32  *** spinza has joined #bitcoin-core-dev
155 2019-02-12T10:18:48  *** EagleTM has quit IRC
156 2019-02-12T10:19:00  <wumpus> many translators get confused on the " Config setting for %s only applied on %s network when in [%s] section." message
157 2019-02-12T10:19:37  <wumpus> it's unfortunate that we can't use named substitutions like in python
158 2019-02-12T10:52:18  *** EagleTM has joined #bitcoin-core-dev
159 2019-02-12T11:22:51  *** AaronvanW has joined #bitcoin-core-dev
160 2019-02-12T11:26:04  *** Karyon has joined #bitcoin-core-dev
161 2019-02-12T11:26:07  *** Aaronvan_ has joined #bitcoin-core-dev
162 2019-02-12T11:27:02  *** Karyon has quit IRC
163 2019-02-12T11:27:21  *** Karyon has joined #bitcoin-core-dev
164 2019-02-12T11:29:44  *** AaronvanW has quit IRC
165 2019-02-12T11:42:27  *** shesek has joined #bitcoin-core-dev
166 2019-02-12T11:43:40  *** Aaronvan_ has quit IRC
167 2019-02-12T11:51:45  *** Karyon has quit IRC
168 2019-02-12T11:52:13  *** Karyon has joined #bitcoin-core-dev
169 2019-02-12T11:53:13  *** AaronvanW has joined #bitcoin-core-dev
170 2019-02-12T11:56:38  *** Aaronvan_ has joined #bitcoin-core-dev
171 2019-02-12T12:00:08  *** AaronvanW has quit IRC
172 2019-02-12T12:05:36  *** siom has joined #bitcoin-core-dev
173 2019-02-12T12:14:16  *** rockhouse1 has joined #bitcoin-core-dev
174 2019-02-12T12:14:24  *** victorSN9 has joined #bitcoin-core-dev
175 2019-02-12T12:18:11  *** elichai2 has joined #bitcoin-core-dev
176 2019-02-12T12:29:30  *** drexl has quit IRC
177 2019-02-12T12:45:13  *** rex4539 has quit IRC
178 2019-02-12T12:57:38  *** elichai2 has quit IRC
179 2019-02-12T13:17:38  <rafalcpp> LXC vulnerability (used in Gitian).   CVE-2019-5736: runc container breakout   (all versions) https://seclists.org/oss-sec/2019/q1/119
180 2019-02-12T13:17:43  *** bitcoin-git has joined #bitcoin-core-dev
181 2019-02-12T13:17:44  <bitcoin-git> [bitcoin] laanwj closed pull request #15155: test: Support -cli tests using external bitcoin-cli (master...test_external_bcli) https://github.com/bitcoin/bitcoin/pull/15155
182 2019-02-12T13:17:44  *** bitcoin-git has left #bitcoin-core-dev
183 2019-02-12T13:17:58  <rafalcpp> probably not a concern since we run known code inside Gitian LXC container
184 2019-02-12T13:18:01  *** drexl has joined #bitcoin-core-dev
185 2019-02-12T13:18:14  <wumpus> not a concern for gitian but still good to know, thanks
186 2019-02-12T13:18:31  <rafalcpp> unless, someone would trick a person to build for him his PR in Gitian just to test things, and take over account of e.g. a developer
187 2019-02-12T13:19:19  <rafalcpp> wumpus: Gitian is known to not be affected by this?
188 2019-02-12T13:22:42  *** Karyon_ has joined #bitcoin-core-dev
189 2019-02-12T13:23:56  *** Karyon has quit IRC
190 2019-02-12T13:24:45  *** promag has quit IRC
191 2019-02-12T13:31:38  <wumpus> I don't think the gitian system is otherwise hardened against, say, malicious descriptors
192 2019-02-12T13:31:55  <wumpus> so I don't think a possible escape changes much
193 2019-02-12T13:32:03  <wumpus> but anyhow, upgrade if you can
194 2019-02-12T13:33:25  <rafalcpp> before distros are fully update, it is probably good if main developers would run Gitian on separate machine, and sign results on another. Sorry to be pedantic, but it's BTC... :)
195 2019-02-12T13:34:00  *** shesek has quit IRC
196 2019-02-12T13:35:34  *** shesek has joined #bitcoin-core-dev
197 2019-02-12T13:38:17  *** copumpkin has joined #bitcoin-core-dev
198 2019-02-12T13:38:46  <wumpus> FWIW I've always done that
199 2019-02-12T13:39:07  *** promag has joined #bitcoin-core-dev
200 2019-02-12T13:43:22  *** promag has quit IRC
201 2019-02-12T13:45:10  *** math_ has quit IRC
202 2019-02-12T13:50:29  <luke-jr> rafalcpp: it's a concern for anyone who does gitian builds of arbitrary repos
203 2019-02-12T13:51:05  <luke-jr> and yes, my gitian sign script is `true` :P
204 2019-02-12T13:51:29  *** rex4539 has joined #bitcoin-core-dev
205 2019-02-12T13:55:04  *** rh0nj has quit IRC
206 2019-02-12T13:56:07  *** rh0nj has joined #bitcoin-core-dev
207 2019-02-12T13:56:38  <wumpus> right, that ^^ if anyone would be able to sneak a VM escape into the gitian descriptors in one of our main branches things would be really bad
208 2019-02-12T13:57:02  *** shesek` has joined #bitcoin-core-dev
209 2019-02-12T13:57:50  *** shesek has quit IRC
210 2019-02-12T14:00:47  *** Karyon_ has quit IRC
211 2019-02-12T14:01:22  *** Karyon has joined #bitcoin-core-dev
212 2019-02-12T14:15:13  *** Karyon_ has joined #bitcoin-core-dev
213 2019-02-12T14:17:26  *** Karyon has quit IRC
214 2019-02-12T14:28:08  *** bitcoin-git has joined #bitcoin-core-dev
215 2019-02-12T14:28:08  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bc149d05b09...65435701efda
216 2019-02-12T14:28:09  <bitcoin-git> bitcoin/master a99999c MarcoFalke: util: Add SetupHelpOptions()
217 2019-02-12T14:28:09  <bitcoin-git> bitcoin/master 6543570 Wladimir J. van der Laan: Merge #15358: util: Add SetupHelpOptions()
218 2019-02-12T14:28:14  *** bitcoin-git has left #bitcoin-core-dev
219 2019-02-12T14:29:01  *** bitcoin-git has joined #bitcoin-core-dev
220 2019-02-12T14:29:01  <bitcoin-git> [bitcoin] laanwj merged pull request #15358: util: Add SetupHelpOptions() (master...Mf1902-Help) https://github.com/bitcoin/bitcoin/pull/15358
221 2019-02-12T14:29:06  *** bitcoin-git has left #bitcoin-core-dev
222 2019-02-12T14:45:34  *** Victorsueca has quit IRC
223 2019-02-12T14:55:56  *** Karyon_ has quit IRC
224 2019-02-12T15:02:13  *** owowo has joined #bitcoin-core-dev
225 2019-02-12T15:12:16  *** EagleTM has quit IRC
226 2019-02-12T15:14:22  *** pinheadmz has joined #bitcoin-core-dev
227 2019-02-12T15:19:09  *** Karyon has joined #bitcoin-core-dev
228 2019-02-12T15:20:50  *** promag has joined #bitcoin-core-dev
229 2019-02-12T15:23:00  *** Klox has quit IRC
230 2019-02-12T15:25:38  *** Klox has joined #bitcoin-core-dev
231 2019-02-12T15:29:14  <provoostenator> Any idea why "make src/bitcoin-tx" works, but "make src/bitcoin-wallet" returns "No rule to make target"?
232 2019-02-12T15:29:27  <provoostenator> I can't see any obvious differences in Makefile.am
233 2019-02-12T15:31:16  *** pinheadmz has quit IRC
234 2019-02-12T15:32:35  *** pinheadmz has joined #bitcoin-core-dev
235 2019-02-12T15:33:48  *** rex4539 has quit IRC
236 2019-02-12T15:36:24  *** rex4539 has joined #bitcoin-core-dev
237 2019-02-12T15:38:40  <luke-jr> provoostenator: I don't see it in Makefile.am at all?
238 2019-02-12T15:38:41  *** michaels_ has joined #bitcoin-core-dev
239 2019-02-12T15:39:03  <luke-jr> note the relevant Makefile.am is NOT the one in src/
240 2019-02-12T15:41:12  <provoostenator> luke-jr: how so? "bin_PROGRAMS += bitcoin-tx" is in src/Makefile.am too
241 2019-02-12T15:42:29  *** pinheadmz has quit IRC
242 2019-02-12T15:42:51  <provoostenator> Ah but there's no BITCOIN_WALLET_BIN in /Makefile.am, like there is a BITCOIN_TX_BIN
243 2019-02-12T15:43:00  <provoostenator> So there's something missing...
244 2019-02-12T15:43:34  *** owowo has quit IRC
245 2019-02-12T15:44:17  *** owowo has joined #bitcoin-core-dev
246 2019-02-12T15:46:53  *** setpill has quit IRC
247 2019-02-12T15:47:56  *** rex4539 has quit IRC
248 2019-02-12T15:48:06  *** Guyver2 has joined #bitcoin-core-dev
249 2019-02-12T15:48:41  *** promag has quit IRC
250 2019-02-12T15:49:32  <wumpus> I don't get why this code does (Network)1 (Network)2 instead of directly using the NET_* constants: https://github.com/bitcoin/bitcoin/blob/master/src/qt/clientmodel.cpp#L279
251 2019-02-12T15:50:03  *** jtimon has joined #bitcoin-core-dev
252 2019-02-12T15:51:55  <wumpus> provoostenator: yea there needs to be a rule $(BITCOIN_TX_BIN): FORCE
253 2019-02-12T15:51:57  <wumpus>         $(MAKE) -C src $(@F)
254 2019-02-12T15:52:06  <provoostenator> I'll make a PR...
255 2019-02-12T15:52:06  <wumpus> for the wallet tool
256 2019-02-12T15:53:40  <provoostenator> It's either a subset of, or detour from, the headache I'm getting in #15382 because I added a UniValue dependency to system.{h,cpp}
257 2019-02-12T15:53:42  <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | WIP [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
258 2019-02-12T15:54:07  *** Murch has joined #bitcoin-core-dev
259 2019-02-12T15:58:26  *** Karyon has quit IRC
260 2019-02-12T15:58:51  *** michaels_ has quit IRC
261 2019-02-12T16:00:03  *** michaels_ has joined #bitcoin-core-dev
262 2019-02-12T16:03:37  *** bitcoin-git has joined #bitcoin-core-dev
263 2019-02-12T16:03:37  <bitcoin-git> [bitcoin] Sjors opened pull request #15388: [build] Makefile.am: add rule for src/bitcoin-wallet (master...2019/02/wallet_tool_make) https://github.com/bitcoin/bitcoin/pull/15388
264 2019-02-12T16:03:38  *** bitcoin-git has left #bitcoin-core-dev
265 2019-02-12T16:08:31  *** michaels_ has quit IRC
266 2019-02-12T16:09:36  *** michaels_ has joined #bitcoin-core-dev
267 2019-02-12T16:10:52  <wumpus> this is really weird code too "(strProxy == strDefaultProxyGUI.toStdString()) ? ui->proxyReachIPv4->setChecked(true) : ui->proxyReachIPv4->setChecked(false);"   I've never seen a tertiary operator used to switch between imperative statements
268 2019-02-12T16:11:31  <wumpus> (which return void)
269 2019-02-12T16:12:53  <wumpus> especially as they could have simply used ui->proxyReachIPv4->setChecked(strProxy == strDefaultProxyGUI.toStdString()) ?
270 2019-02-12T16:13:05  <luke-jr> wumpus: IIRC, it was contributed by a new dev at the time
271 2019-02-12T16:13:21  <luke-jr> so I wouldn't assume there are good reasons
272 2019-02-12T16:13:36  *** bitcoin-git has joined #bitcoin-core-dev
273 2019-02-12T16:13:37  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65435701efda...03732f8644a4
274 2019-02-12T16:13:37  <wumpus> ok-I'm slightly about about the lack of review then :)
275 2019-02-12T16:13:37  <bitcoin-git> bitcoin/master 1cdb9bb Gregory Sanders: minor p2p_sendheaders fix of height in coinbase
276 2019-02-12T16:13:38  <bitcoin-git> bitcoin/master 03732f8 MarcoFalke: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase
277 2019-02-12T16:13:42  *** bitcoin-git has left #bitcoin-core-dev
278 2019-02-12T16:14:12  *** bitcoin-git has joined #bitcoin-core-dev
279 2019-02-12T16:14:12  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14543: [QA] minor p2p_sendheaders fix of height in coinbase (master...p2p_sendheaders_height) https://github.com/bitcoin/bitcoin/pull/14543
280 2019-02-12T16:14:25  *** bitcoin-git has left #bitcoin-core-dev
281 2019-02-12T16:14:28  <luke-jr> #11491
282 2019-02-12T16:14:32  <gribble> https://github.com/bitcoin/bitcoin/issues/11491 | [gui] Add proxy icon in statusbar by mess110 · Pull Request #11491 · bitcoin/bitcoin · GitHub
283 2019-02-12T16:15:11  *** phwalkr has joined #bitcoin-core-dev
284 2019-02-12T16:15:30  <luke-jr> > Note that the network ids aren't just arbitrary numbers - they have meanings (defined in netaddress.h). -myself :P
285 2019-02-12T16:16:01  <wumpus> heh
286 2019-02-12T16:18:24  *** bitcoin-git has joined #bitcoin-core-dev
287 2019-02-12T16:18:25  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/03732f8644a4...d8794a78a887
288 2019-02-12T16:18:25  <bitcoin-git> bitcoin/master ae892ad Chun Kuan Lee: tests: accept unicode characters on Windows
289 2019-02-12T16:18:26  <bitcoin-git> bitcoin/master 15b3103 Chun Kuan Lee: appveyor: Remove outdated libraries
290 2019-02-12T16:18:26  <bitcoin-git> bitcoin/master d8794a7 MarcoFalke: Merge #13787: Test for Windows encoding issue
291 2019-02-12T16:18:28  *** bitcoin-git has left #bitcoin-core-dev
292 2019-02-12T16:18:43  *** bitcoin-git has joined #bitcoin-core-dev
293 2019-02-12T16:18:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #13787: Test for Windows encoding issue (master...test_u8path) https://github.com/bitcoin/bitcoin/pull/13787
294 2019-02-12T16:18:45  *** bitcoin-git has left #bitcoin-core-dev
295 2019-02-12T16:28:51  *** Victorsueca has joined #bitcoin-core-dev
296 2019-02-12T16:30:22  *** JackH has quit IRC
297 2019-02-12T16:34:43  *** elichai2 has joined #bitcoin-core-dev
298 2019-02-12T16:40:58  *** owowo has quit IRC
299 2019-02-12T16:45:04  *** pinheadmz has joined #bitcoin-core-dev
300 2019-02-12T16:45:23  *** owowo has joined #bitcoin-core-dev
301 2019-02-12T16:46:47  *** jtimon has quit IRC
302 2019-02-12T16:47:58  *** StopAndDecrypt has quit IRC
303 2019-02-12T16:51:05  <wumpus> this is why I sometimes ask in PRs wether all people think their comments were addressed, it can be hard to track
304 2019-02-12T17:00:23  *** spinza has quit IRC
305 2019-02-12T17:05:51  *** JackH has joined #bitcoin-core-dev
306 2019-02-12T17:08:01  *** siom has quit IRC
307 2019-02-12T17:12:55  *** spinza has joined #bitcoin-core-dev
308 2019-02-12T17:17:11  *** StopAndDecrypt has joined #bitcoin-core-dev
309 2019-02-12T17:26:15  *** bitcoin-git has joined #bitcoin-core-dev
310 2019-02-12T17:26:15  <bitcoin-git> [bitcoin] scravy opened pull request #15389: Remove unnecessary const_cast (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15389
311 2019-02-12T17:26:16  *** bitcoin-git has left #bitcoin-core-dev
312 2019-02-12T17:27:48  *** promag has joined #bitcoin-core-dev
313 2019-02-12T17:28:43  <promag> jnewbery: please see my comment in #15153
314 2019-02-12T17:28:46  <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
315 2019-02-12T17:32:51  *** spinza has quit IRC
316 2019-02-12T17:38:13  *** millerti has joined #bitcoin-core-dev
317 2019-02-12T17:40:30  *** spinza has joined #bitcoin-core-dev
318 2019-02-12T17:44:11  *** hebasto has joined #bitcoin-core-dev
319 2019-02-12T17:47:03  <promag> provoostenator: why cpp-subprocess instead of boost::process?
320 2019-02-12T17:50:05  <promag> provoostenator: just saw the comments in the other issue
321 2019-02-12T17:51:48  *** skyikot has joined #bitcoin-core-dev
322 2019-02-12T17:56:28  *** jungly has quit IRC
323 2019-02-12T17:57:06  *** bitcoin-git has joined #bitcoin-core-dev
324 2019-02-12T17:57:06  <bitcoin-git> [bitcoin] jnewbery opened pull request #15390: [wallet] Close bdb when flushing wallet. (master...wallet_flush) https://github.com/bitcoin/bitcoin/pull/15390
325 2019-02-12T17:57:10  *** bitcoin-git has left #bitcoin-core-dev
326 2019-02-12T18:03:36  *** bitcoin-git has joined #bitcoin-core-dev
327 2019-02-12T18:03:36  <bitcoin-git> [bitcoin] practicalswift opened pull request #15391: Add compile time verification of assumptions we're currently making implicitly/tacitly (master...assumptions) https://github.com/bitcoin/bitcoin/pull/15391
328 2019-02-12T18:03:42  *** bitcoin-git has left #bitcoin-core-dev
329 2019-02-12T18:06:02  <promag> could we just enable #13339 for non-win builds for 0.18?
330 2019-02-12T18:06:04  <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
331 2019-02-12T18:06:36  *** Aaronvan_ is now known as AaronvanW
332 2019-02-12T18:10:01  *** promag has quit IRC
333 2019-02-12T18:20:42  * instagibbs just learned about --pdbonfailure, my life is a lie
334 2019-02-12T18:21:35  *** bitcoin-git has joined #bitcoin-core-dev
335 2019-02-12T18:21:35  <bitcoin-git> [bitcoin] jonasschnelli pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/d8794a78a887...7d3f255316fc
336 2019-02-12T18:21:36  <bitcoin-git> bitcoin/master 17abc0f João Barbosa: wallet: Factor out LoadWallet
337 2019-02-12T18:21:36  <bitcoin-git> bitcoin/master ab288b4 João Barbosa: interfaces: Add loadWallet to Node
338 2019-02-12T18:21:37  <bitcoin-git> bitcoin/master 32a8c6a João Barbosa: gui: Add openWallet and getWalletsAvailableToOpen to WalletController
339 2019-02-12T18:21:37  *** bitcoin-git has left #bitcoin-core-dev
340 2019-02-12T18:22:17  *** bitcoin-git has joined #bitcoin-core-dev
341 2019-02-12T18:22:18  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15153: gui: Add Open Wallet menu (master...2019-01-openwallet) https://github.com/bitcoin/bitcoin/pull/15153
342 2019-02-12T18:22:24  *** bitcoin-git has left #bitcoin-core-dev
343 2019-02-12T18:22:37  <provoostenator> promag: the author of cpp-subprocess said he found boost::process implementation unpretty. I haven't studied it in enough detail yet to have a strong opinion. But aren't we trying to nuke Boost?
344 2019-02-12T18:29:28  <luke-jr> provoostenator: we're trying to migrate from boost to C++11; if C++11 doesn't provide it, no reason to avoid boost for it
345 2019-02-12T18:29:43  <luke-jr> (I'm not sure there's much left to migrate at this point either?)
346 2019-02-12T18:30:41  <provoostenator> Ok, sounds like I'll have to study both implementations then :-)
347 2019-02-12T18:30:58  <provoostenator> Assuming Boost does work with Windows that would be a good argument for it.
348 2019-02-12T18:32:20  *** jarthur has joined #bitcoin-core-dev
349 2019-02-12T18:32:56  *** sakalli_ has joined #bitcoin-core-dev
350 2019-02-12T18:34:29  <jnewbery> Great to see #15153 merged. I think it could do with a bit more review (I plan to when I get a chance)
351 2019-02-12T18:34:31  <gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
352 2019-02-12T18:35:19  *** sakalli_ has quit IRC
353 2019-02-12T18:43:20  <luke-jr> has there been any discussion previously about the binary name for bitcoin-wallet? seems strange to me.
354 2019-02-12T18:44:34  *** promag has joined #bitcoin-core-dev
355 2019-02-12T18:45:08  *** promag has joined #bitcoin-core-dev
356 2019-02-12T18:46:33  <promag> provoostenator: what luke-jr said. anyway, I don't have experience with boost::process, just think it's nice by reading the docs.
357 2019-02-12T18:48:27  <provoostenator> luke-jr jnewbery: I was thoroughly confused by this naming today while debugging the Makefile, because that actualy contains "bitcoin-wallet" as an intermediate stage for the wallet itself.
358 2019-02-12T18:49:02  <provoostenator> Might be better to call it wallet-tool
359 2019-02-12T18:49:03  <jnewbery> Was changed from bitcoin-wallet-tool after discussion here: https://github.com/bitcoin/bitcoin/pull/13926#issuecomment-423326338
360 2019-02-12T18:50:11  *** fabianfabian has joined #bitcoin-core-dev
361 2019-02-12T18:50:19  <provoostenator> In this case I actually thing the -tool suffix makes sense, to distinguish it from a live wallet.
362 2019-02-12T18:50:36  <luke-jr> when we split the actual wallet out from the main code, what will we call its binary? :P
363 2019-02-12T18:50:36  <provoostenator> Though I might be suffering from cognitive bias :-)
364 2019-02-12T18:51:33  <provoostenator> luke-jr in #10102 that new binary is called bitcoin-wallet
365 2019-02-12T18:51:37  <gribble> https://github.com/bitcoin/bitcoin/issues/10102 | [experimental] Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
366 2019-02-12T18:51:45  <luke-jr> …but…
367 2019-02-12T18:53:44  <provoostenator> So wallet-tool makes sense for this tool. Or even offline-wallet or something. The live wallet in a split code base, which connects to a node, could then be called bitcoin-wallet.
368 2019-02-12T18:54:20  <jnewbery> ryanofsky: thoughts ^ ?
369 2019-02-12T18:54:46  <provoostenator> Ironically bitcoin-wallet was ryanofsky's idea in that comment :-)
370 2019-02-12T18:55:04  <jnewbery> I currently have no strong opinion one way or the other (but think we should make a decision before 0.18 freeze)
371 2019-02-12T18:55:06  <ryanofsky> i was just thinking that you have one binary called bitcoin-wallet that you use for all wallet stuff
372 2019-02-12T18:55:24  <ryanofsky> not sure what advantage there would be to having separate bitcoin-wallet and bitcoin-wallet-tool binaries
373 2019-02-12T18:56:07  <jnewbery> That seems like a reasonable suggestion to me. Merge wallet tool functionality into the new new bitcoin-wallet when it happens
374 2019-02-12T18:56:30  <ryanofsky> yeah, i already implemented that (though can't remember if i pushed it to 10102 yet)
375 2019-02-12T18:57:03  <provoostenator> Any volunteers for bumping QT to 5.5 as per #13478?
376 2019-02-12T18:57:05  <gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
377 2019-02-12T18:57:18  <jnewbery> so for now, keep the wallet tool as bitcoin-wallet, and when the separated bitcoin-wallet happens the tool commands will continue to work as expected?
378 2019-02-12T18:58:55  *** rex4539 has joined #bitcoin-core-dev
379 2019-02-12T18:59:10  <provoostenator> ryanofsky: that works for me as well. If the Makefile confuses someone again, we can also rename the intermediate bitcoin_wallet step.
380 2019-02-12T19:02:37  <gmaxwell> FWIW, I actually misread PRs related to the wallet tool and thought it was named bitcoin-wallet-tool
381 2019-02-12T19:03:23  <provoostenator> I think appveyor is on strike by the way.
382 2019-02-12T19:04:02  <provoostenator> gmaxwell: it was renamed from bitcoin-wallet-tool to bitcoin-wallet along the way.
383 2019-02-12T19:04:33  *** twistedline_ has joined #bitcoin-core-dev
384 2019-02-12T19:04:35  *** Evel-Knievel has quit IRC
385 2019-02-12T19:04:36  *** Apocalyptic has quit IRC
386 2019-02-12T19:04:36  *** queip has quit IRC
387 2019-02-12T19:04:37  *** rockhouse has quit IRC
388 2019-02-12T19:04:37  *** victorSN has quit IRC
389 2019-02-12T19:04:37  *** profmac has quit IRC
390 2019-02-12T19:04:37  *** twistedline has quit IRC
391 2019-02-12T19:04:37  *** lnostdal has quit IRC
392 2019-02-12T19:04:37  *** luke-jr has quit IRC
393 2019-02-12T19:04:37  *** ccook has quit IRC
394 2019-02-12T19:04:40  *** ccook_ has joined #bitcoin-core-dev
395 2019-02-12T19:04:58  *** profmac has joined #bitcoin-core-dev
396 2019-02-12T19:05:06  *** Evel-Knievel has joined #bitcoin-core-dev
397 2019-02-12T19:05:22  *** tryphe has quit IRC
398 2019-02-12T19:05:22  *** Apocalyptic_ has joined #bitcoin-core-dev
399 2019-02-12T19:05:23  *** Apocalyptic_ is now known as Apocalyptic
400 2019-02-12T19:05:39  *** tryphe has joined #bitcoin-core-dev
401 2019-02-12T19:05:47  *** rockhouse has joined #bitcoin-core-dev
402 2019-02-12T19:05:52  *** luke-jr has joined #bitcoin-core-dev
403 2019-02-12T19:05:54  *** victorSN has joined #bitcoin-core-dev
404 2019-02-12T19:10:44  *** queip has joined #bitcoin-core-dev
405 2019-02-12T19:14:28  *** sakalli_ has joined #bitcoin-core-dev
406 2019-02-12T19:16:48  *** sakalli_ has quit IRC
407 2019-02-12T19:20:01  *** DeanGuss has quit IRC
408 2019-02-12T19:25:33  *** promag has quit IRC
409 2019-02-12T19:30:30  *** bitcoin-git has joined #bitcoin-core-dev
410 2019-02-12T19:30:30  <bitcoin-git> [bitcoin] Sjors opened pull request #15393: Bump minimum Qt version to 5.5.1 (master...2019/02/qt-5_5) https://github.com/bitcoin/bitcoin/pull/15393
411 2019-02-12T19:30:31  *** bitcoin-git has left #bitcoin-core-dev
412 2019-02-12T19:39:51  *** protomar has joined #bitcoin-core-dev
413 2019-02-12T19:47:21  *** promag has joined #bitcoin-core-dev
414 2019-02-12T19:49:23  *** promag has quit IRC
415 2019-02-12T19:59:09  *** protomar has quit IRC
416 2019-02-12T20:03:25  *** promag has joined #bitcoin-core-dev
417 2019-02-12T20:07:38  *** shesek`` has joined #bitcoin-core-dev
418 2019-02-12T20:08:48  *** shesek` has quit IRC
419 2019-02-12T20:20:27  *** Randolf has joined #bitcoin-core-dev
420 2019-02-12T20:20:36  *** lnostdal has joined #bitcoin-core-dev
421 2019-02-12T20:30:19  *** bitcoin-git has joined #bitcoin-core-dev
422 2019-02-12T20:30:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d3f255316fc...ea022d9fd047
423 2019-02-12T20:30:20  <bitcoin-git> bitcoin/master dc3b2cc Ben Carman: tests: Added missing tests for RPC wallet errors
424 2019-02-12T20:30:20  <bitcoin-git> bitcoin/master ea022d9 MarcoFalke: Merge #15378: tests: Added missing tests for RPC wallet errors
425 2019-02-12T20:30:30  *** bitcoin-git has left #bitcoin-core-dev
426 2019-02-12T20:31:15  *** bitcoin-git has joined #bitcoin-core-dev
427 2019-02-12T20:31:15  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15378: tests: Added missing tests for RPC wallet errors (master...tests_missing_tests) https://github.com/bitcoin/bitcoin/pull/15378
428 2019-02-12T20:31:16  *** bitcoin-git has left #bitcoin-core-dev
429 2019-02-12T20:37:41  *** michael__ has joined #bitcoin-core-dev
430 2019-02-12T20:40:03  *** shesek`` has quit IRC
431 2019-02-12T20:40:03  *** michaels_ has quit IRC
432 2019-02-12T20:50:35  *** promag has quit IRC
433 2019-02-12T21:00:14  *** fabianfabian has quit IRC
434 2019-02-12T21:06:10  *** profmac has quit IRC
435 2019-02-12T21:07:42  *** promag has joined #bitcoin-core-dev
436 2019-02-12T21:07:48  *** profmac has joined #bitcoin-core-dev
437 2019-02-12T21:17:12  *** timothy has quit IRC
438 2019-02-12T21:39:46  *** spinza has quit IRC
439 2019-02-12T21:42:44  *** bitcoin-git has joined #bitcoin-core-dev
440 2019-02-12T21:42:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea022d9fd047...d73918447faf
441 2019-02-12T21:42:44  <bitcoin-git> bitcoin/master 8c9b8a3 Hennadii Stepanov: Replace script name with special parameter
442 2019-02-12T21:42:45  <bitcoin-git> bitcoin/master d739184 MarcoFalke: Merge #15216: Scripts and tools: Replace script name with a special parame...
443 2019-02-12T21:42:55  *** bitcoin-git has left #bitcoin-core-dev
444 2019-02-12T21:43:24  *** bitcoin-git has joined #bitcoin-core-dev
445 2019-02-12T21:43:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15216: Scripts and tools: Replace script name with a special parameter (master...20190120-improve-shell-ux) https://github.com/bitcoin/bitcoin/pull/15216
446 2019-02-12T21:43:30  *** bitcoin-git has left #bitcoin-core-dev
447 2019-02-12T21:51:12  <promag> rpc_psbt.py failed https://travis-ci.org/bitcoin/bitcoin/jobs/492345001#L2938
448 2019-02-12T21:51:17  <promag> is this flacky?
449 2019-02-12T21:53:33  <luke-jr> provoostenator: did you make a decision for subprocess mgmt?
450 2019-02-12T21:55:10  *** bitcoin-git has joined #bitcoin-core-dev
451 2019-02-12T21:55:11  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d73918447faf...029d28a7aa56
452 2019-02-12T21:55:11  <bitcoin-git> bitcoin/master 1e7f741 Gregory Sanders: remove some magic mining constants in functional tests
453 2019-02-12T21:55:12  <bitcoin-git> bitcoin/master b651ef7 Gregory Sanders: submitheader: more directly test missing prev block header
454 2019-02-12T21:55:12  <bitcoin-git> bitcoin/master 029d28a MarcoFalke: Merge #15238: [QA] remove some magic mining constants in functional tests
455 2019-02-12T21:55:14  *** bitcoin-git has left #bitcoin-core-dev
456 2019-02-12T21:55:49  *** bitcoin-git has joined #bitcoin-core-dev
457 2019-02-12T21:55:50  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15238: [QA] remove some magic mining constants in functional tests (master...magic_miner) https://github.com/bitcoin/bitcoin/pull/15238
458 2019-02-12T21:55:55  *** bitcoin-git has left #bitcoin-core-dev
459 2019-02-12T22:12:46  *** shesek`` has joined #bitcoin-core-dev
460 2019-02-12T22:25:35  *** elichai2 has quit IRC
461 2019-02-12T22:31:44  *** jtimon has joined #bitcoin-core-dev
462 2019-02-12T22:39:06  *** owowo has quit IRC
463 2019-02-12T22:39:21  *** Guyver2 has quit IRC
464 2019-02-12T22:42:04  *** booyah has quit IRC
465 2019-02-12T22:42:45  *** booyah has joined #bitcoin-core-dev
466 2019-02-12T22:44:05  *** owowo has joined #bitcoin-core-dev
467 2019-02-12T22:45:56  <hebasto> promag: hi! how can I push commit with fixed commit message only? -f does not work.
468 2019-02-12T22:46:29  <promag> hebasto: really?
469 2019-02-12T22:46:29  <dongcarl> hebasto: is the remote correct?
470 2019-02-12T22:47:02  <promag> usually I commit --amend and then push -f
471 2019-02-12T22:47:25  <promag> it works :/ maybe it's what dongcarl asked
472 2019-02-12T22:47:56  <dongcarl> Like check what is considered your upstream, as that is what `push -f` tries to push to
473 2019-02-12T22:48:51  <hebasto> my bad. it's ok now. thank you.
474 2019-02-12T22:49:30  <dongcarl> :-)
475 2019-02-12T22:51:43  <promag> hebasto: please fix pr title too
476 2019-02-12T22:53:32  <hebasto> promag: is it ok now?
477 2019-02-12T22:53:59  <promag> lgtm
478 2019-02-12T22:54:10  <hebasto> thanks
479 2019-02-12T22:55:47  *** hebasto has quit IRC
480 2019-02-12T22:56:15  *** spinza has joined #bitcoin-core-dev
481 2019-02-12T23:15:38  *** michael__ has quit IRC
482 2019-02-12T23:15:46  *** bitcoin-git has joined #bitcoin-core-dev
483 2019-02-12T23:15:46  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15395: test: Remove TODO comments to remove -txindex option (master...Mf1902-qaNoTodo) https://github.com/bitcoin/bitcoin/pull/15395
484 2019-02-12T23:15:47  *** bitcoin-git has left #bitcoin-core-dev
485 2019-02-12T23:19:47  *** bralyclow has joined #bitcoin-core-dev
486 2019-02-12T23:29:43  *** Karyon has joined #bitcoin-core-dev
487 2019-02-12T23:42:04  *** jimmysong_ has quit IRC
488 2019-02-12T23:42:05  *** jimmysong has quit IRC
489 2019-02-12T23:46:46  *** bitcoin-git has joined #bitcoin-core-dev
490 2019-02-12T23:46:46  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/029d28a7aa56...0d1160e42185
491 2019-02-12T23:46:47  <bitcoin-git> bitcoin/master fa0ad4e MarcoFalke: RPCHelpMan: Check default values are given at compile-time
492 2019-02-12T23:46:47  <bitcoin-git> bitcoin/master 0d1160e MarcoFalke: Merge #14918: RPCHelpMan: Check default values are given at compile-time
493 2019-02-12T23:46:51  *** bitcoin-git has left #bitcoin-core-dev
494 2019-02-12T23:47:24  *** bitcoin-git has joined #bitcoin-core-dev
495 2019-02-12T23:47:24  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14918: RPCHelpMan: Check default values are given at compile-time (master...Mf1812-rpcOptionalCompile) https://github.com/bitcoin/bitcoin/pull/14918
496 2019-02-12T23:47:36  *** bitcoin-git has left #bitcoin-core-dev
497 2019-02-12T23:48:37  *** booyah_ has joined #bitcoin-core-dev
498 2019-02-12T23:49:40  *** booyah has quit IRC