12019-03-04T00:14:14  *** bmpvieira12 has joined #bitcoin-core-dev
  22019-03-04T00:18:10  *** d_t has joined #bitcoin-core-dev
  32019-03-04T00:18:36  *** bmpvieira12 has quit IRC
  42019-03-04T00:20:48  *** justanotheruser has quit IRC
  52019-03-04T00:21:05  *** justanotheruser has joined #bitcoin-core-dev
  62019-03-04T00:24:53  *** promag has quit IRC
  72019-03-04T00:28:37  *** d_t has quit IRC
  82019-03-04T00:30:40  *** ap4lmtree has quit IRC
  92019-03-04T00:31:10  *** ap4lmtree has joined #bitcoin-core-dev
 102019-03-04T00:32:21  *** shbot13 has joined #bitcoin-core-dev
 112019-03-04T00:33:02  *** heiler has joined #bitcoin-core-dev
 122019-03-04T00:36:47  *** shbot13 has quit IRC
 132019-03-04T00:38:06  *** heiler has quit IRC
 142019-03-04T00:38:45  *** Guyver2 has quit IRC
 152019-03-04T00:46:50  *** ap4lmtree has quit IRC
 162019-03-04T00:47:11  *** ap4lmtree has joined #bitcoin-core-dev
 172019-03-04T00:50:58  *** ap4lmtree has quit IRC
 182019-03-04T00:52:54  *** Tennis has quit IRC
 192019-03-04T00:53:33  *** fanquake has joined #bitcoin-core-dev
 202019-03-04T00:56:39  *** promag has joined #bitcoin-core-dev
 212019-03-04T00:56:59  *** DeanWeen has quit IRC
 222019-03-04T01:00:13  *** pinheadmz has joined #bitcoin-core-dev
 232019-03-04T01:00:29  *** d_t has joined #bitcoin-core-dev
 242019-03-04T01:00:52  *** promag has quit IRC
 252019-03-04T01:01:11  *** ap4lmtree has joined #bitcoin-core-dev
 262019-03-04T01:01:52  *** zhangzf has joined #bitcoin-core-dev
 272019-03-04T01:03:07  *** EagleTM has quit IRC
 282019-03-04T01:15:33  *** pinheadmz has quit IRC
 292019-03-04T01:23:40  *** jarthur has quit IRC
 302019-03-04T01:24:05  *** jarthur has joined #bitcoin-core-dev
 312019-03-04T01:30:09  *** promag has joined #bitcoin-core-dev
 322019-03-04T01:30:28  *** elichai2 has quit IRC
 332019-03-04T01:33:22  *** d_t has quit IRC
 342019-03-04T01:34:32  *** promag has quit IRC
 352019-03-04T01:35:37  *** pinheadmz has joined #bitcoin-core-dev
 362019-03-04T01:36:04  *** syndikate4 has joined #bitcoin-core-dev
 372019-03-04T01:36:22  *** syndikate4 has quit IRC
 382019-03-04T01:36:23  *** spinza has quit IRC
 392019-03-04T01:45:02  *** pinheadmz has quit IRC
 402019-03-04T01:47:13  *** jarthur has quit IRC
 412019-03-04T01:47:28  *** jarthur has joined #bitcoin-core-dev
 422019-03-04T01:52:50  *** Toshi10 has joined #bitcoin-core-dev
 432019-03-04T01:53:05  *** spinza has joined #bitcoin-core-dev
 442019-03-04T01:53:20  *** Toshi10 has quit IRC
 452019-03-04T02:07:33  *** davec has quit IRC
 462019-03-04T02:09:32  *** davec has joined #bitcoin-core-dev
 472019-03-04T02:11:33  *** xnite has joined #bitcoin-core-dev
 482019-03-04T02:15:12  *** pinheadmz has joined #bitcoin-core-dev
 492019-03-04T02:16:40  *** charims20 has joined #bitcoin-core-dev
 502019-03-04T02:16:42  *** xnite has quit IRC
 512019-03-04T02:21:29  *** charims20 has quit IRC
 522019-03-04T02:23:09  *** olivierjanss has joined #bitcoin-core-dev
 532019-03-04T02:36:23  *** pinheadmz has quit IRC
 542019-03-04T02:40:01  *** rh0nj has quit IRC
 552019-03-04T02:40:55  *** klcant10229 has joined #bitcoin-core-dev
 562019-03-04T02:41:07  *** rh0nj has joined #bitcoin-core-dev
 572019-03-04T02:42:13  *** hyperwang has joined #bitcoin-core-dev
 582019-03-04T02:42:15  *** pinheadmz has joined #bitcoin-core-dev
 592019-03-04T02:43:36  *** klcant10229 has quit IRC
 602019-03-04T02:44:00  *** veikko_28 has joined #bitcoin-core-dev
 612019-03-04T02:48:35  *** veikko_28 has quit IRC
 622019-03-04T02:59:37  *** pinheadmz has quit IRC
 632019-03-04T03:00:09  *** promag has joined #bitcoin-core-dev
 642019-03-04T03:04:21  *** promag has quit IRC
 652019-03-04T03:05:04  *** nssy has joined #bitcoin-core-dev
 662019-03-04T03:07:51  *** EagleTM has joined #bitcoin-core-dev
 672019-03-04T03:09:40  *** nssy has quit IRC
 682019-03-04T03:12:08  *** EagleTM has quit IRC
 692019-03-04T03:16:31  *** kallewoof_ has left #bitcoin-core-dev
 702019-03-04T03:17:35  *** kallewoof has joined #bitcoin-core-dev
 712019-03-04T03:24:37  *** morfin has joined #bitcoin-core-dev
 722019-03-04T03:29:09  *** morfin has quit IRC
 732019-03-04T03:33:20  *** vandox10 has joined #bitcoin-core-dev
 742019-03-04T03:37:32  *** vandox10 has quit IRC
 752019-03-04T03:45:40  *** pinheadmz has joined #bitcoin-core-dev
 762019-03-04T03:48:55  *** OmIkRoNiXz27 has joined #bitcoin-core-dev
 772019-03-04T04:01:35  *** pinheadmz has quit IRC
 782019-03-04T04:09:42  *** EagleTM has joined #bitcoin-core-dev
 792019-03-04T04:13:54  *** EagleTM has quit IRC
 802019-03-04T04:17:08  *** Zen9 has joined #bitcoin-core-dev
 812019-03-04T04:20:16  *** Zen9 has quit IRC
 822019-03-04T04:20:30  *** d_t has joined #bitcoin-core-dev
 832019-03-04T04:27:12  *** pinheadmz has joined #bitcoin-core-dev
 842019-03-04T04:46:08  *** pinheadmz has quit IRC
 852019-03-04T04:47:20  *** MrDHat__8 has joined #bitcoin-core-dev
 862019-03-04T04:48:02  *** isviridov_away9 has joined #bitcoin-core-dev
 872019-03-04T05:08:33  *** EagleTM has joined #bitcoin-core-dev
 882019-03-04T05:13:34  *** EagleTM has quit IRC
 892019-03-04T05:17:20  *** jarthur has quit IRC
 902019-03-04T05:21:06  *** dc24x78716 has joined #bitcoin-core-dev
 912019-03-04T05:21:48  *** fanquake has quit IRC
 922019-03-04T05:23:24  *** klanzill has joined #bitcoin-core-dev
 932019-03-04T05:25:51  *** dc24x78716 has quit IRC
 942019-03-04T05:26:40  *** pinheadmz has joined #bitcoin-core-dev
 952019-03-04T05:35:02  *** harrymm has quit IRC
 962019-03-04T05:36:34  *** harrymm has joined #bitcoin-core-dev
 972019-03-04T06:08:46  *** EagleTM has joined #bitcoin-core-dev
 982019-03-04T06:10:05  *** pinheadmz has quit IRC
 992019-03-04T06:12:57  *** EagleTM has quit IRC
1002019-03-04T06:24:29  *** StopAndDecrypt has quit IRC
1012019-03-04T06:26:37  *** DeanWeen has joined #bitcoin-core-dev
1022019-03-04T06:42:59  *** netman8723 has joined #bitcoin-core-dev
1032019-03-04T06:43:06  *** netman8723 has quit IRC
1042019-03-04T06:47:09  *** vihta24 has joined #bitcoin-core-dev
1052019-03-04T06:48:08  *** hyperwang has left #bitcoin-core-dev
1062019-03-04T06:48:16  *** chuck28 has joined #bitcoin-core-dev
1072019-03-04T06:49:54  *** lif19 has joined #bitcoin-core-dev
1082019-03-04T06:52:34  *** chuck28 has quit IRC
1092019-03-04T06:55:06  *** lif19 has quit IRC
1102019-03-04T06:56:54  *** pestle29 has joined #bitcoin-core-dev
1112019-03-04T06:59:22  *** mmgen has joined #bitcoin-core-dev
1122019-03-04T07:02:35  *** pinheadmz has joined #bitcoin-core-dev
1132019-03-04T07:14:32  *** michalisko27 has joined #bitcoin-core-dev
1142019-03-04T07:15:50  *** bitcoin-git has joined #bitcoin-core-dev
1152019-03-04T07:15:50  <bitcoin-git> [bitcoin] rojarsmith opened pull request #15521: Fixed some times can not remove "$SUFFIX-dirty" on version number cor… (master...master) https://github.com/bitcoin/bitcoin/pull/15521
1162019-03-04T07:15:51  *** bitcoin-git has left #bitcoin-core-dev
1172019-03-04T07:32:07  *** zhangzf has quit IRC
1182019-03-04T07:39:25  *** bafain18 has joined #bitcoin-core-dev
1192019-03-04T07:40:36  *** Emcy has quit IRC
1202019-03-04T07:45:22  *** pinheadmz has quit IRC
1212019-03-04T07:53:34  *** foul_owl has joined #bitcoin-core-dev
1222019-03-04T08:04:45  *** pinheadmz has joined #bitcoin-core-dev
1232019-03-04T08:10:04  *** _Sam-- has quit IRC
1242019-03-04T08:12:40  *** mariusz18 has joined #bitcoin-core-dev
1252019-03-04T08:17:18  *** mariusz18 has quit IRC
1262019-03-04T08:17:52  *** d_t has quit IRC
1272019-03-04T08:20:31  *** jungly has joined #bitcoin-core-dev
1282019-03-04T08:32:47  *** owowo has quit IRC
1292019-03-04T08:37:47  *** pinheadmz has quit IRC
1302019-03-04T08:39:46  *** owowo has joined #bitcoin-core-dev
1312019-03-04T09:05:25  *** mn949588 has quit IRC
1322019-03-04T09:05:44  *** mn949588 has joined #bitcoin-core-dev
1332019-03-04T09:06:12  *** rex4539 has quit IRC
1342019-03-04T09:21:49  *** rex4539 has joined #bitcoin-core-dev
1352019-03-04T09:37:37  *** timothy has joined #bitcoin-core-dev
1362019-03-04T09:38:15  *** gvhoecke_26 has joined #bitcoin-core-dev
1372019-03-04T09:43:20  *** gvhoecke_26 has quit IRC
1382019-03-04T09:46:40  *** ansabr28 has joined #bitcoin-core-dev
1392019-03-04T09:49:27  *** justanotheruser has quit IRC
1402019-03-04T09:52:01  *** TWE76fYU has quit IRC
1412019-03-04T10:04:12  *** setpill has joined #bitcoin-core-dev
1422019-03-04T10:04:37  *** kexkey has quit IRC
1432019-03-04T10:05:19  *** Guyver2 has joined #bitcoin-core-dev
1442019-03-04T10:08:29  *** bhaak17 has joined #bitcoin-core-dev
1452019-03-04T10:09:02  *** House has joined #bitcoin-core-dev
1462019-03-04T10:13:26  *** BruceS has joined #bitcoin-core-dev
1472019-03-04T10:13:30  *** House has quit IRC
1482019-03-04T10:16:20  *** mavhq29 has joined #bitcoin-core-dev
1492019-03-04T10:18:16  *** Lymia28 has joined #bitcoin-core-dev
1502019-03-04T10:18:27  *** BruceS has quit IRC
1512019-03-04T10:18:29  *** murrayn_ has joined #bitcoin-core-dev
1522019-03-04T10:18:46  *** Lymia28 has quit IRC
1532019-03-04T10:19:23  *** murrayn has quit IRC
1542019-03-04T10:19:30  *** mavhq29 has quit IRC
1552019-03-04T10:23:15  *** phwalkr has joined #bitcoin-core-dev
1562019-03-04T10:29:44  *** murrayn_ has quit IRC
1572019-03-04T10:30:01  *** murrayn has joined #bitcoin-core-dev
1582019-03-04T10:33:51  *** schmidty has joined #bitcoin-core-dev
1592019-03-04T10:39:21  *** axhanul has joined #bitcoin-core-dev
1602019-03-04T10:41:16  *** ap4lmtree has quit IRC
1612019-03-04T10:42:30  *** ap4lmtree has joined #bitcoin-core-dev
1622019-03-04T10:44:02  *** axhanul has quit IRC
1632019-03-04T10:48:59  *** spinza has quit IRC
1642019-03-04T10:49:27  *** Guest13633 has joined #bitcoin-core-dev
1652019-03-04T10:51:52  *** Guest13633 has quit IRC
1662019-03-04T10:55:38  *** philroche5 has joined #bitcoin-core-dev
1672019-03-04T10:56:14  *** schmidty has quit IRC
1682019-03-04T10:56:55  *** schmidty has joined #bitcoin-core-dev
1692019-03-04T10:57:00  *** spinza has joined #bitcoin-core-dev
1702019-03-04T11:00:18  *** philroche5 has quit IRC
1712019-03-04T11:01:14  *** schmidty has quit IRC
1722019-03-04T11:06:34  *** Daedbffe25 has joined #bitcoin-core-dev
1732019-03-04T11:11:12  *** Daedbffe25 has quit IRC
1742019-03-04T11:12:14  *** bamvor5 has joined #bitcoin-core-dev
1752019-03-04T11:14:33  *** ap4lmtree has quit IRC
1762019-03-04T11:14:57  *** ap4lmtree has joined #bitcoin-core-dev
1772019-03-04T11:16:50  *** bamvor5 has quit IRC
1782019-03-04T11:20:10  *** rex4539 has joined #bitcoin-core-dev
1792019-03-04T11:25:00  *** DeanWeen has quit IRC
1802019-03-04T11:26:32  *** ap4lmtree has quit IRC
1812019-03-04T11:26:53  *** ap4lmtree has joined #bitcoin-core-dev
1822019-03-04T11:28:43  *** AaronvanW has joined #bitcoin-core-dev
1832019-03-04T11:29:49  *** ap4lmtree has quit IRC
1842019-03-04T11:33:24  *** HeathHayle3 has joined #bitcoin-core-dev
1852019-03-04T11:34:40  *** roflin19 has joined #bitcoin-core-dev
1862019-03-04T11:37:59  *** HeathHayle3 has quit IRC
1872019-03-04T11:39:20  *** roflin19 has quit IRC
1882019-03-04T11:44:42  *** DeanGuss has joined #bitcoin-core-dev
1892019-03-04T11:58:31  <wumpus> i think it's time to do a 0.18.0rc1 soon
1902019-03-04T11:58:31  <jonasschnelli> In IBD we account the maxmempool to the dbache, though, I fail to find the codepart that makes sure we flush the database once in sync with a db-cache not adding the maxmempool
1912019-03-04T11:58:38  <jonasschnelli> wumpus: ack
1922019-03-04T12:01:38  <wumpus> PSA: please don't assign anything to 0.18.0 anymore unless it's a regression that needs to be fixed in a RC, thanks
1932019-03-04T12:02:08  *** Dean_Guss has joined #bitcoin-core-dev
1942019-03-04T12:03:45  *** DeanGuss has quit IRC
1952019-03-04T12:05:38  <wumpus> so is there anything in https://github.com/bitcoin/bitcoin/milestones/0.18.0 that blocks rc1?
1962019-03-04T12:07:25  *** TMA26 has joined #bitcoin-core-dev
1972019-03-04T12:07:50  *** schmidty has joined #bitcoin-core-dev
1982019-03-04T12:10:56  *** bitcoin-git has joined #bitcoin-core-dev
1992019-03-04T12:10:58  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d46f1be0c3c...57acfcb9fd05
2002019-03-04T12:10:58  <bitcoin-git> bitcoin/master fa3148a MarcoFalke: doc: Remove ppa from linux build instructions
2012019-03-04T12:10:58  <bitcoin-git> bitcoin/master 57acfcb Wladimir J. van der Laan: Merge #15518: doc: Remove ppa from linux build instructions
2022019-03-04T12:11:08  *** bitcoin-git has left #bitcoin-core-dev
2032019-03-04T12:11:45  *** bitcoin-git has joined #bitcoin-core-dev
2042019-03-04T12:11:46  <bitcoin-git> [bitcoin] laanwj merged pull request #15518: doc: Remove ppa from linux build instructions (master...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15518
2052019-03-04T12:11:46  *** bitcoin-git has left #bitcoin-core-dev
2062019-03-04T12:12:32  *** schmidty has quit IRC
2072019-03-04T12:12:40  *** TMA26 has quit IRC
2082019-03-04T12:13:45  <wumpus> backporting #15463 seems a bit premature as it's not merged to master yet; let's wait for the final version to do that-#15486 still has ongoing discussion and review-same for #15402
2092019-03-04T12:13:46  <gribble> https://github.com/bitcoin/bitcoin/issues/15463 | rpc: Speedup getaddressesbylabel by promag · Pull Request #15463 · bitcoin/bitcoin · GitHub
2102019-03-04T12:13:48  <gribble> https://github.com/bitcoin/bitcoin/issues/15486 | [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups by sdaftuar · Pull Request #15486 · bitcoin/bitcoin · GitHub
2112019-03-04T12:13:50  <gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
2122019-03-04T12:20:21  <wumpus> so I'm not sure there's anything that should block tagging rc1, say, right now, and getting it out and getting some testing; as for any major release it's extremely likely at least a few RCs will be needed to fix problems that people find along the way
2132019-03-04T12:25:02  <wumpus> should we put the preliminary release notes in the wiki again? I think that worked quite well with earlier major releases?
2142019-03-04T12:25:37  *** m8tion has joined #bitcoin-core-dev
2152019-03-04T12:34:40  *** shesek has quit IRC
2162019-03-04T12:36:23  *** fanquake has joined #bitcoin-core-dev
2172019-03-04T12:36:37  <fanquake> wumpus ack tagging an rc1
2182019-03-04T12:36:48  <fanquake> also ack using the wiki, worked alright
2192019-03-04T12:37:07  <wumpus> yep first need to merge the release note fragments I see
2202019-03-04T12:41:50  *** schmidty has joined #bitcoin-core-dev
2212019-03-04T12:43:27  <wumpus> will do that and then put the release notes on the wiki and tag RC1
2222019-03-04T12:43:42  <fanquake> \o/
2232019-03-04T12:44:07  <fanquake> 0.18.0 release schedule running on time
2242019-03-04T12:45:31  <wumpus> :D
2252019-03-04T12:46:18  <wumpus> "the chainstate database for this release is not compatible with previous releases" this isn't true for 0.18 is it?
2262019-03-04T12:46:27  *** schmidty has quit IRC
2272019-03-04T12:46:55  <fanquake> off the top of my head, I don't think so
2282019-03-04T12:47:20  <fanquake> if there's anything about Windows XP it can probably also be removed
2292019-03-04T12:47:24  <rafalcpp> is anyone working on extracting boost::process to standalone library to be included and provided for platforms where system's libboost lacks ::process ?
2302019-03-04T12:47:39  <wumpus> I know the format changed with 0.15, I don't think we need to mention downgrading to that
2312019-03-04T12:47:44  <wumpus> will keep the upgrade notice for the first time running 0.15 or newer
2322019-03-04T12:48:11  <wumpus> rafalcpp: not that I know of
2332019-03-04T12:49:25  <fanquake> rafalcpp some boost:process related discussion in 15421 and 15382
2342019-03-04T12:58:22  *** spaced0ut has joined #bitcoin-core-dev
2352019-03-04T13:18:16  <rafalcpp> actually, why not just build boost from source code, on platforms where it is older than 1.64
2362019-03-04T13:18:27  <rafalcpp> just compilation time is the concern?
2372019-03-04T13:18:44  <wumpus> convenience of building as well
2382019-03-04T13:19:39  <rafalcpp> wumpus: but the alternative, of using extracted boost::process, will it be much better?
2392019-03-04T13:19:42  <wumpus> the depends system is nice but doesn't really work on every platform (say, BSDs etc)
2402019-03-04T13:20:06  <wumpus> better in what regard?
2412019-03-04T13:20:32  <wumpus> from what I heard boost::process used to be a separate library in the first place
2422019-03-04T13:21:22  *** bitcoin-git has joined #bitcoin-core-dev
2432019-03-04T13:21:22  <bitcoin-git> [bitcoin] practicalswift opened pull request #15522: Document sizeof(size_t) assumptions in assumptions.h (master...size_t-assumptions) https://github.com/bitcoin/bitcoin/pull/15522
2442019-03-04T13:21:23  *** bitcoin-git has left #bitcoin-core-dev
2452019-03-04T13:25:00  <rafalcpp> wumpus: what do you mean it does not work on BSD?  I think the process would be like (I assume) Gitian does it inside:  git clone main boost, then checkout few of submodules (::process and its deps) then b2, make/make install to prefix, and tell autotools to puck that up
2462019-03-04T13:28:55  *** m8tion_ has joined #bitcoin-core-dev
2472019-03-04T13:29:50  <wumpus> there's no reason it wouldn't theoretically work, but just try it out, go to depends and do `make` (excluding qt) on say, OpenBSD, I think it fails somewhere along the way
2482019-03-04T13:30:49  <wumpus> you're welcome to fix that of course! but until we can be *sure* that the depends build works on all the platforms that bitcoind builds on, "just use depends" is not a valid requirement
2492019-03-04T13:31:32  <wumpus> this is why something that builds as part of our own tree is likely a more feasible approach
2502019-03-04T13:32:29  *** m8tion has quit IRC
2512019-03-04T13:32:29  *** shesek has joined #bitcoin-core-dev
2522019-03-04T13:32:29  *** shesek has quit IRC
2532019-03-04T13:32:29  *** shesek has joined #bitcoin-core-dev
2542019-03-04T13:32:29  *** Zenton has quit IRC
2552019-03-04T13:32:29  *** Zenton has joined #bitcoin-core-dev
2562019-03-04T13:32:54  <wumpus> it wouldn't be as much of an issue if 1.64 wasn't so recent making it an unreasonable minimum requirement. Though it might be fine if it's only used for optional functionality (e.g. as detected in configure).
2572019-03-04T13:36:36  <fanquake> wumpus indeed https://gist.github.com/fanquake/3c01f28491417c8b7fa0a18442034b21
2582019-03-04T13:36:48  <luke-jr> "just use depends" is never a valid requirement (outside of obsolete versions) -.-
2592019-03-04T13:37:27  <wumpus> luke-jr: boost 1.64 is thus uncommon it would effectively be the case
2602019-03-04T13:37:50  <rafalcpp> I'm not sure what do you mean by that depends - is this your custom script that downloads some dependencies (curl instead git submodule btw) and builds them?  (from ./depends/)
2612019-03-04T13:37:58  <luke-jr> wumpus: but it's optional, right?
2622019-03-04T13:37:58  <wumpus> fanquake: right, that
2632019-03-04T13:38:10  <wumpus> rafalcpp: yes
2642019-03-04T13:38:16  <rafalcpp> but the problem is that this depends/ method anyway is not working, independant of boost::process
2652019-03-04T13:38:23  <rafalcpp> (*on bsd)
2662019-03-04T13:38:59  <wumpus> that's not a problem at the moment because the version of boost (as well as other dependencies) on various BSDs is recent enough to build bitcoind
2672019-03-04T13:39:02  <rafalcpp> I could make another small script to grab + build enough of boost to have boost::process for Bitcoin
2682019-03-04T13:39:20  <wumpus> sorry if there's anything we don't want, imo it's another dependency-downloading and building script
2692019-03-04T13:39:56  <rafalcpp> ok then what sollution is acceptable?
2702019-03-04T13:40:22  <wumpus> make only *optional* functionality depend on boost 1.64
2712019-03-04T13:40:28  <wumpus> that would be the first step
2722019-03-04T13:40:52  <wumpus> if someone decides to backport boost::process functionality later or something like thta, that'd be great, but it can all start with that
2732019-03-04T13:41:59  <rafalcpp> by backporting you mean OS distros doing that?  I wouldn't count too much on that happening
2742019-03-04T13:42:31  *** m8tion_ has quit IRC
2752019-03-04T13:42:32  <wumpus> no, I mean extracting and backporting it, as you were suggesting only a few messages ago
2762019-03-04T13:43:23  <luke-jr> rafalcpp: include a copy of just boost::process in the Bitcoin source code, used when the system lacks it
2772019-03-04T13:43:25  <rafalcpp> btw, the script is probably  git clone && b2 && make install  and telling automate to use it and that is all
2782019-03-04T13:43:45  <wumpus> this just keeps going back and forth, we already discussed this at one of the meetings too: I'd say just go ahead with whatever requires boost 1.64 and make it optional functionality
2792019-03-04T13:45:43  <wumpus> a lot of people don't build with the wallet, so if say, the new external signing support requires that library then it would be outrageous to require boost 1.64 in all cases
2802019-03-04T13:56:58  *** justanotheruser has joined #bitcoin-core-dev
2812019-03-04T14:07:14  *** booyah has quit IRC
2822019-03-04T14:08:08  *** bitcoin-git has joined #bitcoin-core-dev
2832019-03-04T14:08:08  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15524: [0.18] doc: Remove ppa from linux build instructions (0.18...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15524
2842019-03-04T14:08:11  *** bitcoin-git has left #bitcoin-core-dev
2852019-03-04T14:12:35  *** Emcy has joined #bitcoin-core-dev
2862019-03-04T14:14:11  *** schmidty has joined #bitcoin-core-dev
2872019-03-04T14:14:52  *** rasca has joined #bitcoin-core-dev
2882019-03-04T14:17:46  *** bitcoin-git has joined #bitcoin-core-dev
2892019-03-04T14:17:46  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/742f7dd972fc...b702e3757e1d
2902019-03-04T14:17:46  <bitcoin-git> bitcoin/0.18 b702e37 Wladimir J. van der Laan: doc: Merge release notes fragments
2912019-03-04T14:18:00  *** bitcoin-git has left #bitcoin-core-dev
2922019-03-04T14:19:07  *** schmidty has quit IRC
2932019-03-04T14:19:28  *** rasca has quit IRC
2942019-03-04T14:22:35  <wumpus> 0.18.0 release notes draft up on the wiki: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft
2952019-03-04T14:28:18  *** bitcoin-git has joined #bitcoin-core-dev
2962019-03-04T14:28:19  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/b702e3757e1d...7630301c1628
2972019-03-04T14:28:19  <bitcoin-git> bitcoin/0.18 fa3148a MarcoFalke: doc: Remove ppa from linux build instructions
2982019-03-04T14:28:20  <bitcoin-git> bitcoin/0.18 7630301 Wladimir J. van der Laan: Merge #15524: [0.18] doc: Remove ppa from linux build instructions
2992019-03-04T14:28:24  *** bitcoin-git has left #bitcoin-core-dev
3002019-03-04T14:28:44  *** bitcoin-git has joined #bitcoin-core-dev
3012019-03-04T14:28:44  <bitcoin-git> [bitcoin] laanwj merged pull request #15524: [0.18] doc: Remove ppa from linux build instructions (0.18...1903-docPPA) https://github.com/bitcoin/bitcoin/pull/15524
3022019-03-04T14:28:48  *** bitcoin-git has left #bitcoin-core-dev
3032019-03-04T14:29:43  *** booyah has joined #bitcoin-core-dev
3042019-03-04T14:34:30  *** schmidty has joined #bitcoin-core-dev
3052019-03-04T14:37:46  *** fanquake has quit IRC
3062019-03-04T14:39:17  *** bjorn3 has joined #bitcoin-core-dev
3072019-03-04T14:40:57  *** someara19 has joined #bitcoin-core-dev
3082019-03-04T14:43:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3092019-03-04T14:44:23  *** bjorn3 has quit IRC
3102019-03-04T14:45:30  *** someara19 has quit IRC
3112019-03-04T14:51:00  *** Chris_Stewart_5 has quit IRC
3122019-03-04T14:51:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3132019-03-04T14:52:00  *** bitcoin-git has joined #bitcoin-core-dev
3142019-03-04T14:52:00  <bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc1
3152019-03-04T14:52:07  *** bitcoin-git has left #bitcoin-core-dev
3162019-03-04T14:52:07  <wumpus> ^^
3172019-03-04T14:53:10  *** Chris_Stewart_5 has quit IRC
3182019-03-04T14:53:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3192019-03-04T14:54:35  *** kexkey has joined #bitcoin-core-dev
3202019-03-04T14:55:16  <wumpus> oh crap
3212019-03-04T14:55:40  <wumpus> please hold off building rc1
3222019-03-04T14:55:57  <achow101> was something forgotten?
3232019-03-04T14:56:21  <wumpus> yes we need to set _CLIENT_VERSION_RC now
3242019-03-04T14:56:28  *** bitcoin-git has joined #bitcoin-core-dev
3252019-03-04T14:56:28  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/7630301c1628...6a178e52618d
3262019-03-04T14:56:28  <bitcoin-git> bitcoin/0.18 6a178e5 Wladimir J. van der Laan: build: set RC1
3272019-03-04T14:56:35  *** bitcoin-git has left #bitcoin-core-dev
3282019-03-04T14:57:10  *** bitcoin-git has joined #bitcoin-core-dev
3292019-03-04T14:57:10  <bitcoin-git> [bitcoin] laanwj deleted tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/329381d6ae9a...000000000000
3302019-03-04T14:57:24  *** bitcoin-git has left #bitcoin-core-dev
3312019-03-04T14:58:15  *** bitcoin-git has joined #bitcoin-core-dev
3322019-03-04T14:58:15  <bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc1
3332019-03-04T14:58:20  <wumpus> ok all good now
3342019-03-04T14:58:28  <achow101> \o/
3352019-03-04T14:58:28  *** bitcoin-git has left #bitcoin-core-dev
3362019-03-04T14:59:11  <mmgen> wumpus: you should make a release checklist, to avoid relying on memory for stuff like that every release
3372019-03-04T14:59:42  <wumpus> if you alrady fetched the tag do: git branch -d v0.18.0rc1 && git fetch origin v0.18.0rc1
3382019-03-04T15:00:28  <achow101> mmgen: there is. see doc/release-process.md
3392019-03-04T15:00:43  <wumpus> mmgen: this is on the check list IIRC
3402019-03-04T15:00:51  <wumpus> it's a new step though for this version
3412019-03-04T15:01:23  <wumpus> happy I realized it so soon at least
3422019-03-04T15:02:34  *** elichai2 has joined #bitcoin-core-dev
3432019-03-04T15:05:41  <mmgen> wumpus: ahh, now I see: setting CLIENT_VERSION_RC was added only recently
3442019-03-04T15:07:35  <wumpus> yes, and ==0 happens to be 'final release' so that would be unfortunate
3452019-03-04T15:07:50  *** Deinogalerix21 has joined #bitcoin-core-dev
3462019-03-04T15:07:55  <mmgen> mmgen: indeed!
3472019-03-04T15:08:48  *** Ta1}s0n has joined #bitcoin-core-dev
3482019-03-04T15:09:07  *** Ta1}s0n has quit IRC
3492019-03-04T15:09:23  <mmgen> Sorry, s/mmgen:/wumpus:/
3502019-03-04T15:19:53  *** shesek has quit IRC
3512019-03-04T15:20:11  *** shesek has joined #bitcoin-core-dev
3522019-03-04T15:20:11  *** shesek has quit IRC
3532019-03-04T15:20:11  *** shesek has joined #bitcoin-core-dev
3542019-03-04T15:20:13  <dongcarl> Wondering why all the release schedule issues are marked "good first issue"
3552019-03-04T15:20:50  <wumpus> basically to make it something people stumble over immediately when looking for good first issues
3562019-03-04T15:21:09  *** luke-jr sets mode: -q $~a
3572019-03-04T15:21:14  *** luke-jr sets mode: -o luke-jr
3582019-03-04T15:21:22  <luke-jr> (spambots seem to have stopped for a while now)
3592019-03-04T15:21:35  <wumpus> and no one can pretend not to be aware of the release schedule :)
3602019-03-04T15:21:43  <dongcarl> Ah I see
3612019-03-04T15:22:51  <wumpus> I guess it's somewhat less relevant now that "pinned issues" exist, but it predates that functionality by far
3622019-03-04T15:28:14  *** Guest3042 has joined #bitcoin-core-dev
3632019-03-04T15:32:27  *** Guest3042 has quit IRC
3642019-03-04T15:35:09  *** pinheadmz has joined #bitcoin-core-dev
3652019-03-04T15:35:25  *** dviola has joined #bitcoin-core-dev
3662019-03-04T15:35:32  *** pinheadmz has quit IRC
3672019-03-04T15:44:19  *** jarthur has joined #bitcoin-core-dev
3682019-03-04T15:47:13  *** wuseman22 has joined #bitcoin-core-dev
3692019-03-04T15:51:47  *** wuseman22 has quit IRC
3702019-03-04T15:55:42  <sipa> wumpus: no the latest database change iirc was the txindex in 0.17, and that one is backward compatible even (old nodes just won't see the index created by new nodes)
3712019-03-04T15:56:00  <wumpus> sipa: thanks for confirming
3722019-03-04T15:59:07  *** mmgen has quit IRC
3732019-03-04T15:59:55  *** SFaulken24 has joined #bitcoin-core-dev
3742019-03-04T16:00:41  *** mmgen has joined #bitcoin-core-dev
3752019-03-04T16:02:44  *** Deinogalerix21 has quit IRC
3762019-03-04T16:04:23  *** SFaulken24 has quit IRC
3772019-03-04T16:05:49  *** bitcoin-git has joined #bitcoin-core-dev
3782019-03-04T16:05:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15517: 0.18: rpc: Speedup getaddressesbylabel (0.18...2019-03-backport-15463) https://github.com/bitcoin/bitcoin/pull/15517
3792019-03-04T16:06:04  *** bitcoin-git has left #bitcoin-core-dev
3802019-03-04T16:17:13  *** schmidty has quit IRC
3812019-03-04T16:17:55  *** schmidty has joined #bitcoin-core-dev
3822019-03-04T16:19:53  *** zivl has joined #bitcoin-core-dev
3832019-03-04T16:20:07  *** hebasto has joined #bitcoin-core-dev
3842019-03-04T16:22:46  *** schmidty has quit IRC
3852019-03-04T16:39:15  *** schmidty has joined #bitcoin-core-dev
3862019-03-04T16:41:42  *** harding has quit IRC
3872019-03-04T16:43:47  *** schmidty has quit IRC
3882019-03-04T16:43:53  *** harding has joined #bitcoin-core-dev
3892019-03-04T16:43:59  *** schmidty has joined #bitcoin-core-dev
3902019-03-04T16:43:59  *** schmidty has joined #bitcoin-core-dev
3912019-03-04T16:49:37  *** paranoid20 has joined #bitcoin-core-dev
3922019-03-04T16:52:00  *** pinheadmz has joined #bitcoin-core-dev
3932019-03-04T16:53:56  *** captjakk has joined #bitcoin-core-dev
3942019-03-04T16:54:18  *** captjakk has quit IRC
3952019-03-04T16:54:47  *** dviola has quit IRC
3962019-03-04T16:54:51  *** captjakk has joined #bitcoin-core-dev
3972019-03-04T17:00:13  *** jungly has quit IRC
3982019-03-04T17:01:25  *** sXpher29 has joined #bitcoin-core-dev
3992019-03-04T17:06:09  *** gab3781a has joined #bitcoin-core-dev
4002019-03-04T17:27:18  *** pinheadmz has quit IRC
4012019-03-04T17:27:55  *** pinheadmz has joined #bitcoin-core-dev
4022019-03-04T17:31:36  *** setpill has quit IRC
4032019-03-04T17:41:49  *** owowo has quit IRC
4042019-03-04T17:42:11  *** owowo has joined #bitcoin-core-dev
4052019-03-04T17:44:09  *** lorko123 has joined #bitcoin-core-dev
4062019-03-04T17:44:48  <lorko123> anyone know how to mine bitcoin directly with bitcoin core
4072019-03-04T17:45:19  <lorko123> can i point my asics at my core address to mine for me
4082019-03-04T17:46:41  *** Dizzle has joined #bitcoin-core-dev
4092019-03-04T17:46:51  <Dizzle> lorko123: let's take this to #bitcoin
4102019-03-04T17:52:28  *** hebasto has quit IRC
4112019-03-04T17:56:59  *** promag has joined #bitcoin-core-dev
4122019-03-04T17:59:08  *** spinza has quit IRC
4132019-03-04T18:01:47  *** promag has quit IRC
4142019-03-04T18:05:26  *** Chris_Stewart_5 has quit IRC
4152019-03-04T18:15:02  *** bitcoin-git has joined #bitcoin-core-dev
4162019-03-04T18:15:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 17 commits to master: https://github.com/bitcoin/bitcoin/compare/57acfcb9fd05...45f434f44d0b
4172019-03-04T18:15:04  <bitcoin-git> bitcoin/master 80f52a2 Russell Yanofsky: Remove uses of CheckFinalTx in wallet code
4182019-03-04T18:15:19  <bitcoin-git> bitcoin/master bdc6628 Russell Yanofsky: Remove use of IsRBFOptIn in wallet code
4192019-03-04T18:15:19  <bitcoin-git> bitcoin/master 291276f Russell Yanofsky: Remove use of GetCountWithDescendants in wallet code
4202019-03-04T18:15:19  *** bitcoin-git has left #bitcoin-core-dev
4212019-03-04T18:15:37  *** bitcoin-git has joined #bitcoin-core-dev
4222019-03-04T18:15:37  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15288: Remove wallet -> node global function calls (master...pr/wchain3) https://github.com/bitcoin/bitcoin/pull/15288
4232019-03-04T18:15:38  *** bitcoin-git has left #bitcoin-core-dev
4242019-03-04T18:17:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4252019-03-04T18:18:39  <dongcarl> wumpus: Wondering what should be done about https://github.com/bitcoin/bitcoin/blob/0.18/doc/release-notes/release-notes-pr12255.md ? It seems that at least it should go in the release notes for 0.18, and perhaps removed from the tree?
4262019-03-04T18:19:23  *** spinza has joined #bitcoin-core-dev
4272019-03-04T18:21:28  *** timothy has quit IRC
4282019-03-04T18:22:33  <MarcoFalke> wumpus: Are you going to create the "release schedule for 0.19.0"-issue? :)
4292019-03-04T18:24:48  <wumpus> MarcoFalke: yes, though I think doing so now is overly optimistic :) let's wait for 0.18 to be -final before scheduling it
4302019-03-04T18:25:04  <MarcoFalke> Ah, makes sense
4312019-03-04T18:25:08  <wumpus> dongcarl: huh did I forget one?
4322019-03-04T18:25:58  <wumpus> dongcarl: I don't see it
4332019-03-04T18:26:24  <wumpus> oh, they placed it into the historical release notes directory? what???
4342019-03-04T18:26:38  <MarcoFalke> whoopsie
4352019-03-04T18:26:43  <MarcoFalke> wrong dir
4362019-03-04T18:26:48  <dongcarl> lol
4372019-03-04T18:27:02  <MarcoFalke> dongcarl: blame youself
4382019-03-04T18:27:16  <MarcoFalke> . s/youself/yourself/
4392019-03-04T18:27:17  <wumpus> anyhow: release notes are on the wiki now, please edit them there
4402019-03-04T18:27:22  * dongcarl git blame self
4412019-03-04T18:27:49  <dongcarl> Okay, so I'll add it, and PR to remove the file?
4422019-03-04T18:27:58  <wumpus> yes, thank you
4432019-03-04T18:28:15  <dongcarl> gotcha
4442019-03-04T18:28:56  *** schmidty has quit IRC
4452019-03-04T18:29:48  *** schmidty has joined #bitcoin-core-dev
4462019-03-04T18:33:24  <sipa> wumpus: doc/psbt.md is not new in 0.18 (and it's been hardly touched for 0.18 so far, though i think we need to add deriveaddresses/importmulti/getdescriptorinfo to it before release
4472019-03-04T18:33:34  <sipa> eh
4482019-03-04T18:33:42  <sipa> i'm confusing psbt with descriptors
4492019-03-04T18:33:58  <sipa> we need to add analysepsbt/mergepsbts/utxoupdatepsbt
4502019-03-04T18:34:19  *** schmidty has quit IRC
4512019-03-04T18:39:42  <wumpus> sometimes, things that have been backported to minor releases stick around in the release notes for the major one, but I don't think that's the case here
4522019-03-04T18:40:31  <sipa> wumpus: just pointing out that the release notes wiki now says that doc/psbt.md is new while it's been there since 0.17; i'll improve the text
4532019-03-04T18:40:53  <wumpus> sipa: yes that seems wrong, thanks
4542019-03-04T18:41:20  *** bitcoin-git has joined #bitcoin-core-dev
4552019-03-04T18:41:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45f434f44d0b...14023c966c51
4562019-03-04T18:41:21  <bitcoin-git> bitcoin/master fa45123 MarcoFalke: test: Add .style.yapf
4572019-03-04T18:41:21  <bitcoin-git> bitcoin/master 14023c9 MarcoFalke: Merge #15479: test: Add .style.yapf
4582019-03-04T18:41:27  *** pinheadmz has quit IRC
4592019-03-04T18:41:33  *** bitcoin-git has left #bitcoin-core-dev
4602019-03-04T18:41:59  *** bitcoin-git has joined #bitcoin-core-dev
4612019-03-04T18:42:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15479: test: Add .style.yapf (master...Mf1902-testYapf) https://github.com/bitcoin/bitcoin/pull/15479
4622019-03-04T18:42:01  *** bitcoin-git has left #bitcoin-core-dev
4632019-03-04T18:44:24  *** pinheadmz has joined #bitcoin-core-dev
4642019-03-04T18:49:24  *** schmidty has joined #bitcoin-core-dev
4652019-03-04T18:51:46  <sipa> wumpus: added some todos to the wiki; i'll address them myself when i find the time, if someone doesn't beat me
4662019-03-04T19:01:15  <dongcarl> Anyone know how to push to the wiki? I've got `git@github.com:bitcoin-core/bitcoin-devwiki.wiki.git` as my remote and git tells me permission denied
4672019-03-04T19:02:03  <harding> sipa: the PSBT doc was backported to the 0.17 branch but was not released in 0.17.1 (and there's no 0.17.2 yet).  See MarcoFalke and my discussion about it here: https://github.com/bitcoin/bitcoin/pull/15314#issuecomment-459740847
4682019-03-04T19:05:01  <sipa> harding: what? how did we miss that
4692019-03-04T19:05:19  <sipa> i remember writing that doc for 0.17
4702019-03-04T19:05:50  <sipa> in any case, looks like you're right
4712019-03-04T19:07:51  <sipa> oh, that writeup was in the release notes of 0.17, and was only turned into a separate doc afterwards
4722019-03-04T19:08:11  <sipa> thanks for getting my memory straight
4732019-03-04T19:09:54  <harding> sipa: np.  You did catch a problem in my first release note edits where I didn't catch some backports, which probably helped confuse you.  That was corrected, and I've tried to be more careful since.
4742019-03-04T19:09:54  *** d_t has joined #bitcoin-core-dev
4752019-03-04T19:09:54  *** bitcoin-git has joined #bitcoin-core-dev
4762019-03-04T19:09:55  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15527: doc: Remove pr release notes file in wrong dir (master...1903-docRelPr) https://github.com/bitcoin/bitcoin/pull/15527
4772019-03-04T19:09:59  *** bitcoin-git has left #bitcoin-core-dev
4782019-03-04T19:10:06  <harding> dongcarl: can you edit in the web interface?
4792019-03-04T19:10:43  <dongcarl> harding: it allows me to open web interface editor, haven't tried submitting change tho.
4802019-03-04T19:11:08  <dongcarl> But I'd obviously like to edit in my comfy editor
4812019-03-04T19:11:16  *** lorko123 has quit IRC
4822019-03-04T19:11:27  <harding> dongcarl: maybe try a one-character edit in the web interface to see if it throws some useful error (and then undo your edit).
4832019-03-04T19:12:08  *** shesek has quit IRC
4842019-03-04T19:14:24  <dongcarl> That worked...
4852019-03-04T19:14:26  <dongcarl> Weird
4862019-03-04T19:14:32  <dongcarl> Anyways, I'll just do it on the web then...
4872019-03-04T19:17:44  <MarcoFalke> dongcarl: Sorry, I already submitted that hunk
4882019-03-04T19:17:59  <MarcoFalke> see link in #15527
4892019-03-04T19:18:00  <gribble> https://github.com/bitcoin/bitcoin/issues/15527 | doc: Remove pr release notes file in wrong dir by MarcoFalke · Pull Request #15527 · bitcoin/bitcoin · GitHub
4902019-03-04T19:26:27  <harding> dongcarl: I just tried and it lets me edit via the web interface but git push for the exact same change gives me: remote: Permission to bitcoin-core/bitcoin-devwiki.wiki.git denied to harding.
4912019-03-04T19:27:17  <dongcarl> Hmm... I'm a little confused why we're using the wiki page of an empty repository instead of just a repository...
4922019-03-04T19:27:29  <dongcarl> harding: seems like a bug to me
4932019-03-04T19:27:30  <wumpus> because it works...
4942019-03-04T19:28:28  <wumpus> people can edit it and that seems to work pretty well, no PR overhead
4952019-03-04T19:29:07  <dongcarl> Ah I see, PR overhead
4962019-03-04T19:29:36  *** jarthur has quit IRC
4972019-03-04T19:29:41  *** Dizzle has quit IRC
4982019-03-04T19:29:57  <wumpus> the wiki UI is also slightly more user friendly than editing files in a repository, of course, that doesn't matter if you only want to check it out locally
4992019-03-04T19:32:09  <wumpus> it's an empty repository because that's the only way github will let you set different permissions...
5002019-03-04T19:33:22  <jonasschnelli> gmaxwell: remember when we talked about the 3 rounds of chacha20 required for encrypted messages with less then 64 bytes?
5012019-03-04T19:33:56  <jonasschnelli> you mentioned that reducing it to two may be possible since the first round derives the Poly1305 key and wastes 32bytes of that round
5022019-03-04T19:34:32  <jonasschnelli> But the ChaCha20Poly1305@openssh construct uses two independent keyed cipher instances (main and header)
5032019-03-04T19:35:06  <jonasschnelli> The header-instance encrypts only the packet length..
5042019-03-04T19:35:28  <jonasschnelli> I think by reducing it two minimum two rounds of ChaCha20 (one for the poly1305 key, one for the actual message), we break the following property:
5052019-03-04T19:35:30  <jonasschnelli> "By using an independently-keyed cipher instance to encrypt the length, an active attacker seeking to exploit the packet input handling as a decryption oracle can learn nothing about the payload contents or its MAC"
5062019-03-04T19:43:32  <gmaxwell> we talked about this in here before.
5072019-03-04T19:44:04  <gmaxwell> the mac setup run has extra data in the output, so there is no length overlapping.
5082019-03-04T19:44:48  <sipa> i don't follow; where do the 3 rounds come from?
5092019-03-04T19:45:07  <sipa> oh, one for length, one for data, one for mac
5102019-03-04T19:45:16  *** jcorgan_ has joined #bitcoin-core-dev
5112019-03-04T19:45:23  <gmaxwell> and the mac run has 32 extra bytes that are just thrown away.
5122019-03-04T19:46:11  *** bitcoin-git has joined #bitcoin-core-dev
5132019-03-04T19:46:11  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15528: contrib: Bump gitian descriptors for 0.19 (master...1903-gitian19) https://github.com/bitcoin/bitcoin/pull/15528
5142019-03-04T19:46:12  *** bitcoin-git has left #bitcoin-core-dev
5152019-03-04T19:47:09  <gmaxwell> there was also a mailing list discussion about this, and the way it was done this way IIRC from it was because openssl didn't provide access to the extra bytes.
5162019-03-04T19:47:14  <gmaxwell> e.g. pure compatibility hack.
5172019-03-04T19:47:25  <gmaxwell> no cryptographic justification for that redundancy.
5182019-03-04T19:48:36  *** jcorgan has quit IRC
5192019-03-04T19:50:22  <jonasschnelli> gmaxwell: but what about the two independently-keyed cipher instance?
5202019-03-04T19:51:27  <jonasschnelli> We could drop that and just use a single key with a single ChaCha2 cipher instance and reduce it two minimum two rounds
5212019-03-04T19:52:03  <jonasschnelli> But I'm unsure if this brings disadvantages when the AAD (the length) is encrypted with the same key than the actual payload
5222019-03-04T19:53:06  <jonasschnelli> The current BIP151 way is ECDH_SECRET->HKDF->k1 for AAD encryption, ECDH->HKDF->k2 for the payload encryption
5232019-03-04T19:54:14  <sipa> i think the idea is that there are two independently-keyed chacha20 instances; one for the AAD, and one for the payload, but that the first 32 bytes of the payload one are used for the poly1305 key, instead of using the first 64 bytes (and throwing away the last 32)
5242019-03-04T19:55:42  <jonasschnelli> I see...
5252019-03-04T19:56:39  <jonasschnelli> openssh ChaChaPoly does:   instanceA -> poly1305 key, instanceB -> AAD encryption, instanceA -> payload encryption
5262019-03-04T19:56:40  *** phwalkr has quit IRC
5272019-03-04T19:57:26  <jonasschnelli> we could do: instanceB->poly1305 key & AAD encryption, instanceA->payload encryption
5282019-03-04T19:57:48  <sipa> which means you need one invocation of the AAD instance every 16 messages or so (as you only need 4 bytes from the AAD cipher output for each), and one invocation of the payload instance for every 64 bytes of data (offset by 32 bytes)
5292019-03-04T19:57:56  *** mn949588 has quit IRC
5302019-03-04T19:59:07  <jonasschnelli> sipa: we do derive a poly1305 key per message though
5312019-03-04T19:59:29  <sipa> that seems wasteful
5322019-03-04T19:59:58  <jonasschnelli> well,.. I feel unconfirtable altering the AEAD construct further more
5332019-03-04T20:00:18  <sipa> how fast is out chacha20 code?
5342019-03-04T20:00:57  <sipa> *our
5352019-03-04T20:01:28  <jonasschnelli> Not very optimized,.. I have benchs for the AEAD but not for ChaCha alone
5362019-03-04T20:01:30  <jonasschnelli> # Benchmark, evals, iterations, total, min, max, median
5372019-03-04T20:01:31  <jonasschnelli> CHACHA20POLY1305AEAD_BIG, 5, 340, 3.68279, 0.00215035, 0.00219169, 0.00216025
5382019-03-04T20:01:31  <jonasschnelli> CHACHA20POLY1305AEAD_SMALL, 5, 250000, 1.08673, 8.51516e-07, 8.93585e-07, 8.61119e-07
5392019-03-04T20:01:31  <jonasschnelli> HASH256_BIG, 5, 340, 3.81384, 0.00222589, 0.00226436, 0.00224086
5402019-03-04T20:01:31  <jonasschnelli> HASH256_SMALL, 5, 250000, 1.1305, 8.96669e-07, 9.15482e-07, 9.03866e-07
5412019-03-04T20:02:01  <sipa> what are big and small?
5422019-03-04T20:02:18  <jonasschnelli> 1MB / 256bytes
5432019-03-04T20:02:24  <jonasschnelli> I should have done <64 though for small
5442019-03-04T20:03:02  <sipa> so this means 500 MB/s, or over 1M 256-byte messages per second
5452019-03-04T20:03:16  <jonasschnelli> And thats for the 3-rounds @openssh version with no asm optimisation
5462019-03-04T20:04:03  <jonasschnelli> I think aprox. the same performance as the current 4byte sha256 checksum
5472019-03-04T20:04:22  <sipa> how much of this is due to the poly1305?
5482019-03-04T20:04:33  <jonasschnelli> I just asked that myself...
5492019-03-04T20:04:35  <sipa> can you run the benchmark with the poly1305 code commented out or so
5502019-03-04T20:04:38  <jonasschnelli> I can add a bench for that though
5512019-03-04T20:05:06  <jonasschnelli> I'll do that.. but need to fix the current working-tree first
5522019-03-04T20:05:57  <jonasschnelli> sipa: but we would drift away from a poly key per message, wouldn't that mean a single message can't be authenticated by itself?
5532019-03-04T20:06:09  <sipa> jonasschnelli: no
5542019-03-04T20:06:18  <sipa> you just cache the output of the aad cipher
5552019-03-04T20:07:07  <sipa> oh, i'm confusing myself
5562019-03-04T20:07:09  <jonasschnelli> doesn't that result in eventually waiting for additional messages in order to check the MAC?
5572019-03-04T20:07:18  <sipa> no
5582019-03-04T20:07:44  <sipa> you can compute the chacha20 cipher output as far ahead as you want, there is never a need to wait for anything
5592019-03-04T20:08:28  *** kanzure has quit IRC
5602019-03-04T20:08:56  <sipa> poly1305 needs a 32 byte key; right now you generate a per-message (64 + N) byte output, and use the first 32 bytes as poly1305 key, throw away 32 bytes, and use the rest for the payload
5612019-03-04T20:09:07  <sipa> the idea is that you just don't throw away those 32 bytes
5622019-03-04T20:09:17  *** jarthur has joined #bitcoin-core-dev
5632019-03-04T20:09:20  *** kanzure has joined #bitcoin-core-dev
5642019-03-04T20:09:35  <jonasschnelli> Yes. I see that... but I don't see how more then the 3 bytes for the AAD (the packet length) could be used
5652019-03-04T20:09:50  <sipa> likewise, you're now generating 64 bytes from the AAD cipher for encrypting the length, but only using the first 4; the idea is to just not throw away the rest
5662019-03-04T20:10:05  <sipa> or the first 3
5672019-03-04T20:10:18  <sipa> jonasschnelli: there's nothing special about the message counter
5682019-03-04T20:10:34  <sipa> chacha20 is just a giant stream of bytes
5692019-03-04T20:11:08  <sipa> where we use output of position (2^64*message + bytepos)
5702019-03-04T20:11:09  <jonasschnelli> aha.. I think I know what you mean now
5712019-03-04T20:11:51  <sipa> now, depending on the speed of things... this may all be overkill
5722019-03-04T20:11:57  <sipa> so i'd like to know how fast poly1305 is
5732019-03-04T20:12:19  <jonasschnelli> So 64 bytes from the ChaCha round that does the Poly-key/AAD output, use 32for the poly-key, 3 for the length, remains 30.... so we need to kick a round for the next poly key,...
5742019-03-04T20:12:24  <sipa> if most of our time is spent in poly1305, then squeezing out extra chacha20 performance isn't really going to matter much
5752019-03-04T20:12:32  <jonasschnelli> maybe it's on over-optimization
5762019-03-04T20:12:37  <sipa> no no no
5772019-03-04T20:12:53  * jonasschnelli listening
5782019-03-04T20:12:58  <sipa> don't mix the aad and the payload
5792019-03-04T20:13:11  <jonasschnelli> I don't
5802019-03-04T20:13:33  <jonasschnelli> I just have problems processing your:
5812019-03-04T20:13:34  <jonasschnelli> <sipa>	which means you need one invocation of the AAD instance every 16 messages or so (as you only need 4 bytes from the AAD cipher output for each), and one invocation of the payload instance for every 64 bytes of data (offset by 32 bytes)
5822019-03-04T20:13:49  <sipa> generate 64 bytes from the AAD cipher every 21 messages, and cache them. this output will be used to encrypt the lengths of the coming 21 messages
5832019-03-04T20:14:01  <sipa> that's all you ever do with the AAD cipher
5842019-03-04T20:14:07  <jonasschnelli> ah.. shit. right
5852019-03-04T20:14:20  <jonasschnelli> I confused myself by deriving the polykey from the AAD instance
5862019-03-04T20:14:35  <jonasschnelli> yes, yes. I see
5872019-03-04T20:14:35  *** mn949588 has joined #bitcoin-core-dev
5882019-03-04T20:14:52  <sipa> then you generate 32+N bytes from the payload cipher for every message (with incrementing message counter), the first 32 of which you use for the poly1305 cipher, the rest for the payload
5892019-03-04T20:14:53  <jonasschnelli> so the special length encryption property could come at very limited processing time
5902019-03-04T20:15:01  <sipa> yes
5912019-03-04T20:15:53  <jonasschnelli> this means we always do two rounds for an message >32 bytes... but the AAD chacha round runds only every 16 message
5922019-03-04T20:16:16  <jonasschnelli> or 21 with 3 bytes length
5932019-03-04T20:17:08  <sipa> yes
5942019-03-04T20:17:12  <jonasschnelli> Cool... let me bench and specify this
5952019-03-04T20:18:51  <jonasschnelli> Also wonder how much it would be possible to gain by using the optimized code from Zinc (Wireguard) which seems to evetually get merged to the linux kernel
5962019-03-04T20:18:51  <jonasschnelli> https://git.zx2c4.com/WireGuard/tree/src/crypto/zinc/chacha20
5972019-03-04T20:19:40  *** mn949588 has quit IRC
5982019-03-04T20:22:34  <gmaxwell> re benchmarking, benchmark target should be arm.  if what we cared about was x86_64 we should be using AES-GCM. :)
5992019-03-04T20:23:08  <gmaxwell> which is basically better in every dimension except being really slow on arm without hardware AES.
6002019-03-04T20:23:53  <gmaxwell> (simpler to integrate, much more widely used, much lower power consuming (on x86_64), slightly faster)
6012019-03-04T20:24:33  <jonasschnelli> gmaxwell: can't we expect ARM to support AES NI,.. I guess ARMv8-A has AES native instructions?
6022019-03-04T20:25:37  <gmaxwell> someday. maybe. they made it optional, again. IIRC
6032019-03-04T20:26:45  <gmaxwell> (of course, its optional on x86_64 too, but every modern chip provides it... arm has a long long history of optional features that are not proided. :()
6042019-03-04T20:27:42  <sipa> x86 in practice only has two manufacturers :)
6052019-03-04T20:28:07  <gmaxwell> (to be clear, that chacha20/poly and AES are generally close in performance on x86_64 ...  so its not awful to not use AES.  and AES-GCM is pretty bad compared to chacha20 on devices without hardware AES&CLMUL)
6062019-03-04T20:28:12  *** bitcoin-git has joined #bitcoin-core-dev
6072019-03-04T20:28:12  <bitcoin-git> [bitcoin] sipsorcery opened pull request #15529: WIP: Add Qt programs to msvc build (master...qt_msvc) https://github.com/bitcoin/bitcoin/pull/15529
6082019-03-04T20:28:13  *** bitcoin-git has left #bitcoin-core-dev
6092019-03-04T20:29:04  <gmaxwell> So I certantly still support using the chacha20, but just saying, that the performance driver here should be lower end node hardware, not desktops that decrypt at gigabits/s. :P )
6102019-03-04T20:29:21  <sipa> fair point
6112019-03-04T20:31:15  *** jb55 has quit IRC
6122019-03-04T20:37:33  <gmaxwell> Also, since most of our messages are small.. it seems likely that optimizing this will be a fairly large percentage speedup.
6132019-03-04T20:37:47  *** mn949588 has joined #bitcoin-core-dev
6142019-03-04T20:37:50  <gmaxwell> (might be useful to get a histogram of a ordinary nodes send and recieved message sizes)
6152019-03-04T20:39:56  *** EagleTM has joined #bitcoin-core-dev
6162019-03-04T20:49:09  *** ap4lmtree has joined #bitcoin-core-dev
6172019-03-04T20:56:49  *** jb55 has joined #bitcoin-core-dev
6182019-03-04T21:04:07  *** bitcoin-git has joined #bitcoin-core-dev
6192019-03-04T21:04:07  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15530: doc: Move wallet lock annotations to header (master...Mf1902-walletLocks) https://github.com/bitcoin/bitcoin/pull/15530
6202019-03-04T21:04:10  *** bitcoin-git has left #bitcoin-core-dev
6212019-03-04T21:19:41  *** CubicEarth has quit IRC
6222019-03-04T21:22:01  *** CubicEarth has joined #bitcoin-core-dev
6232019-03-04T21:23:58  *** mmgen has quit IRC
6242019-03-04T21:31:54  *** bitcoin-git has joined #bitcoin-core-dev
6252019-03-04T21:31:54  <bitcoin-git> [bitcoin] ryanofsky opened pull request #15531: Suggested interfaces::Chain cleanups from #15288 (master...pr/wclean2) https://github.com/bitcoin/bitcoin/pull/15531
6262019-03-04T21:31:55  *** bitcoin-git has left #bitcoin-core-dev
6272019-03-04T21:36:23  *** e4xit has quit IRC
6282019-03-04T21:38:15  *** elichai2 has quit IRC
6292019-03-04T21:42:31  *** ExtraCrispy has quit IRC
6302019-03-04T21:49:53  *** e4xit has joined #bitcoin-core-dev
6312019-03-04T21:50:12  *** Bullit has quit IRC
6322019-03-04T21:50:41  *** Bullit has joined #bitcoin-core-dev
6332019-03-04T21:51:25  *** bitcoin-git has joined #bitcoin-core-dev
6342019-03-04T21:51:25  <bitcoin-git> [bitcoin] practicalswift opened pull request #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter (master...BlockFilterType) https://github.com/bitcoin/bitcoin/pull/15532
6352019-03-04T21:51:38  *** bitcoin-git has left #bitcoin-core-dev
6362019-03-04T21:51:43  *** MarcoFalke_ has joined #bitcoin-core-dev
6372019-03-04T21:52:13  *** Eliel has joined #bitcoin-core-dev
6382019-03-04T21:53:08  *** MarcoFalke has quit IRC
6392019-03-04T21:53:09  *** MarcoFalke_ is now known as MarcoFalke
6402019-03-04T21:53:47  *** rev_strangehope has quit IRC
6412019-03-04T21:58:27  *** rev_strangehope has joined #bitcoin-core-dev
6422019-03-04T22:07:27  *** ghost43 has quit IRC
6432019-03-04T22:09:00  *** Chris_Stewart_5 has quit IRC
6442019-03-04T22:09:44  *** e4xit has quit IRC
6452019-03-04T22:11:06  *** e4xit has joined #bitcoin-core-dev
6462019-03-04T22:12:13  *** Dean_Guss has quit IRC
6472019-03-04T22:12:31  *** ghost43 has joined #bitcoin-core-dev
6482019-03-04T22:32:02  *** spinza has quit IRC
6492019-03-04T22:42:50  *** spinza has joined #bitcoin-core-dev
6502019-03-04T22:48:52  *** fanquake has joined #bitcoin-core-dev
6512019-03-04T23:11:29  *** ghost43 has quit IRC
6522019-03-04T23:11:30  *** sipa has quit IRC
6532019-03-04T23:13:20  *** sipa has joined #bitcoin-core-dev
6542019-03-04T23:16:54  *** ghost43 has joined #bitcoin-core-dev
6552019-03-04T23:24:38  *** EagleTM has quit IRC
6562019-03-04T23:26:34  *** Cory has quit IRC
6572019-03-04T23:28:27  <gmaxwell> Does anyone in here have a host with clang8? looks like fedora29 is using clang7.  ISTM its assembly is broken: https://github.com/bitcoin-core/secp256k1/issues/594
6582019-03-04T23:31:57  *** Pasha has joined #bitcoin-core-dev
6592019-03-04T23:33:23  *** TX1683 has quit IRC
6602019-03-04T23:34:06  *** bitcoin-git has joined #bitcoin-core-dev
6612019-03-04T23:34:07  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15533: test: .style.yapf: Set column_limit=160 (master...1903-testNoPep8Collim) https://github.com/bitcoin/bitcoin/pull/15533
6622019-03-04T23:34:13  *** bitcoin-git has left #bitcoin-core-dev
6632019-03-04T23:35:08  *** Pasha is now known as Cory
6642019-03-04T23:38:26  *** TX1683 has joined #bitcoin-core-dev
6652019-03-04T23:45:07  *** Zanthir has joined #bitcoin-core-dev
6662019-03-04T23:49:12  *** Zanthir has quit IRC