12019-03-06T00:01:41  *** copumpkin has quit IRC
  22019-03-06T00:02:33  *** CubicEarth has quit IRC
  32019-03-06T00:03:54  *** copumpkin has joined #bitcoin-core-dev
  42019-03-06T00:06:14  *** CubicEarth has joined #bitcoin-core-dev
  52019-03-06T00:13:38  *** AaronvanW has joined #bitcoin-core-dev
  62019-03-06T00:16:26  *** bitcoin-git has joined #bitcoin-core-dev
  72019-03-06T00:16:26  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15521: Fixed some times can not remove "$SUFFIX-dirty" on version number cor… (master...master) https://github.com/bitcoin/bitcoin/pull/15521
  82019-03-06T00:16:39  *** bitcoin-git has left #bitcoin-core-dev
  92019-03-06T00:22:01  *** afk11 has quit IRC
 102019-03-06T00:31:44  *** jarthur_ has joined #bitcoin-core-dev
 112019-03-06T00:32:22  *** promag has joined #bitcoin-core-dev
 122019-03-06T00:32:25  *** jarthur_ has quit IRC
 132019-03-06T00:35:26  *** jarthur has quit IRC
 142019-03-06T00:37:06  *** afk11 has joined #bitcoin-core-dev
 152019-03-06T00:50:06  <kanzure> http://diyhpl.us/~bryan/irc/bitcoin/bitcoin-dev/bitcoin-dev-mailing-list-archive-2019-03-05.zip
 162019-03-06T00:50:24  <kanzure> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016700.html
 172019-03-06T00:52:05  *** promag has quit IRC
 182019-03-06T00:53:00  *** OneFive has quit IRC
 192019-03-06T00:54:42  <kanzure> anything sent during march needs t obe re-sent
 202019-03-06T01:01:52  *** captjakk has joined #bitcoin-core-dev
 212019-03-06T01:02:00  *** zhangzf has joined #bitcoin-core-dev
 222019-03-06T01:02:02  *** captjakk has quit IRC
 232019-03-06T01:02:06  *** captjakk_ has joined #bitcoin-core-dev
 242019-03-06T01:07:48  *** promag has joined #bitcoin-core-dev
 252019-03-06T01:12:07  *** promag has quit IRC
 262019-03-06T01:42:38  *** owowo has quit IRC
 272019-03-06T01:47:31  *** owowo has joined #bitcoin-core-dev
 282019-03-06T01:47:31  *** owowo has joined #bitcoin-core-dev
 292019-03-06T01:59:41  *** EagleTM has joined #bitcoin-core-dev
 302019-03-06T02:12:07  *** Dean_Guss has joined #bitcoin-core-dev
 312019-03-06T02:26:39  *** murrayn_ has quit IRC
 322019-03-06T02:26:59  *** murrayn has joined #bitcoin-core-dev
 332019-03-06T02:58:22  *** OneFive has joined #bitcoin-core-dev
 342019-03-06T03:01:54  *** EagleTM has quit IRC
 352019-03-06T03:09:21  *** afk11 has quit IRC
 362019-03-06T03:09:21  *** afk11 has joined #bitcoin-core-dev
 372019-03-06T03:21:39  *** Aaronvan_ has joined #bitcoin-core-dev
 382019-03-06T03:24:20  *** AaronvanW has quit IRC
 392019-03-06T03:29:12  *** Aaronvan_ has quit IRC
 402019-03-06T03:42:22  *** StopAndDecrypt has joined #bitcoin-core-dev
 412019-03-06T03:48:38  *** d_t has quit IRC
 422019-03-06T03:56:38  *** dviola has joined #bitcoin-core-dev
 432019-03-06T04:46:12  *** spaced0ut has quit IRC
 442019-03-06T05:07:23  *** zhangzf has quit IRC
 452019-03-06T05:14:12  *** ppisati has quit IRC
 462019-03-06T05:14:56  *** zhangzf has joined #bitcoin-core-dev
 472019-03-06T05:15:25  *** dviola has quit IRC
 482019-03-06T05:16:16  *** pinheadmz has quit IRC
 492019-03-06T05:20:51  *** ppisati has joined #bitcoin-core-dev
 502019-03-06T05:49:04  *** promag has joined #bitcoin-core-dev
 512019-03-06T05:53:22  *** promag has quit IRC
 522019-03-06T05:53:56  <wumpus> I've created a new base image, am getting different hashes for aarch64/riscv64 now but still not ones that match the others
 532019-03-06T06:01:59  *** captjakk_ has quit IRC
 542019-03-06T06:12:07  <meshcollider> wumpus: what distro are you on
 552019-03-06T06:16:37  <wumpus> debian 9.6, a VM I've been using for gitian building since pretty much forever
 562019-03-06T06:18:48  <wumpus> I use LXC for building
 572019-03-06T06:48:23  *** noxx_ has joined #bitcoin-core-dev
 582019-03-06T07:24:23  <wumpus> so there's nothing else to do besides trying to compare the binaries, will try so later today
 592019-03-06T07:34:07  *** StopAndDecrypt has quit IRC
 602019-03-06T07:51:26  *** pinheadmz has joined #bitcoin-core-dev
 612019-03-06T08:32:12  *** pinheadmz has quit IRC
 622019-03-06T08:34:40  *** spinza has quit IRC
 632019-03-06T08:36:20  <wumpus> Binary files achow101/aarch/bitcoin-0.18.0rc1/bin/test_bitcoin and laanwj/aarch/bitcoin-0.18.0rc1/bin/test_bitcoin differ
 642019-03-06T08:36:22  <wumpus> Binary files achow101/riscv/bitcoin-0.18.0rc1/bin/test_bitcoin and laanwj/riscv/bitcoin-0.18.0rc1/bin/test_bitcoin differ
 652019-03-06T08:36:32  <wumpus> that's all, apparently
 662019-03-06T08:38:33  *** jungly has joined #bitcoin-core-dev
 672019-03-06T08:42:56  *** spinza has joined #bitcoin-core-dev
 682019-03-06T08:45:26  <gmaxwell> whats the difference look like?
 692019-03-06T08:45:40  <gmaxwell> maybe you can see that its a timestamp or something like that.
 702019-03-06T08:45:48  <gmaxwell> Are they the same size?
 712019-03-06T08:52:24  <wumpus> unfortunately ,no they're different sizes, https://github.com/bitcoin/bitcoin/issues/15541
 722019-03-06T08:53:56  <gmaxwell> [offtopic] NSA released an apparently really good reverse engineering / decompiler tool. Bonus: Contains backdoor (apparently unintentional), network accessible RCE. ( https://twitter.com/hackerfantastic/status/1103087869063704576 )
 732019-03-06T08:55:17  <wumpus> amusing, this is as close as you can get to the actual trojan horse story in the modern day
 742019-03-06T08:56:55  <gmaxwell> comments on HN were like "oh I dunno if I want to run this, it's from the NSA" which I read and thought, "oh come on thats a bit silly"... then scrolls down a bit further.
 752019-03-06T09:01:46  *** bitcoin-git has joined #bitcoin-core-dev
 762019-03-06T09:01:46  <bitcoin-git> [bitcoin] Bushstar opened pull request #15544: Comment typo "iff" (master...master) https://github.com/bitcoin/bitcoin/pull/15544
 772019-03-06T09:01:47  *** bitcoin-git has left #bitcoin-core-dev
 782019-03-06T09:01:48  <wumpus> [extreme paranoia mode: they found one of the RCEs quickly so people think it's safe now]
 792019-03-06T09:03:17  <gmaxwell> a RE tool also has a lot of attack surface, even with it closed off from the network, ... the whole point is to feed it untrusted inputs. Wouldn't be shocking for a debugger to have an RCE facing the instruction stream.
 802019-03-06T09:04:12  <wumpus> yes, very much true
 812019-03-06T09:04:56  <gmaxwell> though presumably anyone using this could manage to isolate it reasonably enough. it sounds pretty cool, esp that it supports weird cpus.
 822019-03-06T09:15:10  *** owowo has quit IRC
 832019-03-06T09:15:47  *** justanotheruser has quit IRC
 842019-03-06T09:16:35  <wumpus> yes it looks nice... I'm all for NSA getting into the 'show off capability by releasing cool things' game instead of by leaks of spying and sabotage, though, can't help being skeptical of their motives
 852019-03-06T09:16:57  <sipa> gmaxwell: that's hilarious
 862019-03-06T09:17:30  *** promag has joined #bitcoin-core-dev
 872019-03-06T09:20:08  *** owowo has joined #bitcoin-core-dev
 882019-03-06T09:24:10  <wumpus> aanyhow back to comparing executables using bog-standard unix tools
 892019-03-06T09:25:53  <sipa> can we somehow tell gitian it's ok if only the tests are nondeterministic?
 902019-03-06T09:26:22  <sipa> i guess we don't actually want that
 912019-03-06T09:26:28  <wumpus> I don't think that's okay, all the binaries we distribute should be deterministic
 922019-03-06T09:26:40  <wumpus> right
 932019-03-06T09:29:50  <wumpus> the difference seems to be minimal: presence/absence of .gnu_debuglink section: https://github.com/bitcoin/bitcoin/issues/15541#issuecomment-470034776
 942019-03-06T09:30:24  *** Deinogalerix21 has joined #bitcoin-core-dev
 952019-03-06T09:32:18  <wumpus> this is the case for both platforms; apparently, mine doesn't have the section but his does
 962019-03-06T09:32:30  *** justanotheruser has joined #bitcoin-core-dev
 972019-03-06T09:33:44  *** mmgen has joined #bitcoin-core-dev
 982019-03-06T09:35:31  *** setpill has joined #bitcoin-core-dev
 992019-03-06T09:38:15  <wumpus> so the good news is that the generated code itself doesn't diverge
1002019-03-06T09:38:51  *** timothy has joined #bitcoin-core-dev
1012019-03-06T09:40:55  <gmaxwell> add a bit of script to strip that section?
1022019-03-06T09:42:59  <wumpus> same for the divergence between my own previous and current builds, except that affects bitcoin-qt
1032019-03-06T09:43:08  <wumpus> gmaxwell: yea that seems the most straightforward option
1042019-03-06T09:43:23  *** Zenton has joined #bitcoin-core-dev
1052019-03-06T09:44:19  <gmaxwell> or find what compiler option controls the creation of that section and set it explicitly, I'm gussing different people's toolchains have changed the defaults on it
1062019-03-06T09:44:30  <wumpus> the script that's suppposed to do this is contrib/devtools/split-debug.sh.in
1072019-03-06T09:44:43  <wumpus> but this is a deterministic build, we're supposed to use the same toolchain
1082019-03-06T09:45:13  <wumpus> the build environment should be exactly the same (ubuntu bionic)
1092019-03-06T09:45:43  <wumpus> I don't dare guess what does cause this though …
1102019-03-06T09:49:37  <gmaxwell> hm. maybe the part of the buildchain that has been identically built doesn't include those particular cross compilers?
1112019-03-06T09:53:26  <wumpus> right, this is why I'm saying "should be" I'm not 100% sure if there isn't something non-deterministic leaking into the toolchain, though it might also be just as well something from the environment (races between threads, ordering of files in file system, system locale, ... we've seen them all by now)
1122019-03-06T09:54:36  <wumpus> it's absurd how difficult determninistic builds are to get right, a few days ago I saw a tweet like "oh fix time at epoch 0 lol" and almost cried :-)
1132019-03-06T09:55:47  <gmaxwell> this complexity ultimately impacts all software.. basically everything running everywhere is running an an untested configuration due to all these factors.
1142019-03-06T10:01:21  *** kexkey has quit IRC
1152019-03-06T10:02:22  <wumpus> yes it's true, would have been better if various tools had been written with determinism in mind, it's kind of a hard thing to bolt on later
1162019-03-06T10:03:55  <wumpus> the thing is, it's so easy to use a randomized algorithms somewhere without noticing; e.g. various hash tables that are seeded with random nonces, then only something has to accidentially use the order and whoops
1172019-03-06T10:06:05  <gmaxwell> filesystem ordering is the funnest stuff.
1182019-03-06T10:06:27  *** owowo has quit IRC
1192019-03-06T10:06:46  <wumpus> yes
1202019-03-06T10:11:08  *** OneFive has quit IRC
1212019-03-06T10:12:44  *** owowo has joined #bitcoin-core-dev
1222019-03-06T10:22:38  <wumpus> so this is curious: the gnu-debuglink section is *supposed* to be explicitly inserted here @OBJCOPY@ --enable-deterministic-archives -p --add-gnu-debuglink=$3 $2
1232019-03-06T10:23:50  <wumpus> that it is missing from my build seems to be a bug
1242019-03-06T10:26:27  <luke-jr> are you sure you were using the current yml from the tag?
1252019-03-06T10:26:33  <wumpus> yes
1262019-03-06T10:32:24  *** noxx_ has quit IRC
1272019-03-06T10:32:33  *** natangl has joined #bitcoin-core-dev
1282019-03-06T10:33:39  <wumpus> but that's a good point, I can actually edit the descriptor without changing the release otherwise
1292019-03-06T10:33:57  <wumpus> (for experimenting ..)
1302019-03-06T10:33:58  *** Guyver2 has joined #bitcoin-core-dev
1312019-03-06T10:35:16  <wumpus> at minimum to build riscv and aarch only to minimize the iteration time…
1322019-03-06T10:37:51  <wumpus> which might reduce to half a day instead of a full day :/
1332019-03-06T10:39:56  *** timothy has quit IRC
1342019-03-06T10:40:19  <wumpus> does the "Upgrading system, may take a while (log in var/install.log)" step take so long for anyone else?
1352019-03-06T10:40:51  <wumpus> it always seemse to me (don't think it's really true) that this takes lnoger than the actual build, at least with dependencies cached
1362019-03-06T10:40:51  *** spinza has quit IRC
1372019-03-06T10:41:43  <luke-jr> wumpus: it takes annoyingly long for me, yes
1382019-03-06T10:42:08  <luke-jr> I haven't actually timed it, though, just noticed it while I was waiting
1392019-03-06T10:42:09  <wumpus> luke-jr: I guess it's a LXC thing, maybe the docker builds don't have this? what is everyone using nowadays?
1402019-03-06T10:42:29  <luke-jr> wumpus: I don't use LXC
1412019-03-06T10:42:33  <wumpus> I feel like completely nuking this VM and starting over
1422019-03-06T10:42:35  <luke-jr> I use KVM
1432019-03-06T10:42:46  <wumpus> oh, same there then
1442019-03-06T10:42:54  <luke-jr> well, part of why it takes long for me, is *because* it nukes the VM every time :P
1452019-03-06T10:43:10  <wumpus> I mean the outer VM where I run gitian in
1462019-03-06T10:43:23  <wumpus> I'm aware that's the whole point of gitian, too :)
1472019-03-06T10:43:48  <wumpus> maybe it's not thorough enough !
1482019-03-06T10:43:51  *** ExtraCrispy has quit IRC
1492019-03-06T10:45:33  <luke-jr> I like the Guix direction
1502019-03-06T10:46:25  <wumpus> me too, I genuinely hope it will make things better, though I must also confess being a bit skeptical, replacing a system that almost works (after years of polishing) with a shiny new thing rarely 'just works'
1512019-03-06T10:48:20  <promag> wumpus: yeah, Qt folks dropped Qbs development in favour of cmake just because "a shiny new thing rarely 'just works'"
1522019-03-06T10:49:28  <luke-jr> Qbs?
1532019-03-06T10:49:31  <luke-jr> is that qmake?
1542019-03-06T10:50:55  *** spinza has joined #bitcoin-core-dev
1552019-03-06T10:52:25  <promag> nop
1562019-03-06T10:53:00  <promag> example https://doc.qt.io/qbs/howtos.html#how-do-i-make-my-app-build-against-my-library
1572019-03-06T10:53:08  <wumpus> promag: on the long run that's probably a good choice, qt having their own build system is kind of annoying, but yes I can imagine there's a lot of initial breakage and frustration
1582019-03-06T10:53:42  <promag> qbs uses qml
1592019-03-06T10:53:52  <luke-jr> so Qt had *two* build systems? <.<
1602019-03-06T10:54:07  <gmaxwell> there is just an effect where no one realizes how much the existing stuff gets right because you don't see the right parts. ... also much of what people see as "cruft" is actually stored knoweldge about weird corner cases that must be handled.
1612019-03-06T10:54:23  <promag> blog post https://blog.qt.io/blog/2018/10/29/deprecation-of-qbs/
1622019-03-06T10:54:44  * wumpus wishes boost would switch away from their own yam or whatever it is as well to something generic
1632019-03-06T10:55:57  <promag> luke-jr: they say "Longer term, we plan to switch to CMake for building Qt itsel"
1642019-03-06T10:56:17  <wumpus> gmaxwell: that certianly happens
1652019-03-06T10:57:54  <wumpus> in the case of gitian the problem is the high overhead, gitian itself is pretty minimalistic, but it spins up a complete Ubuntu VM and updates it to current packages, that's slow and soo many moving (potentially backdoored) parts
1662019-03-06T10:58:17  <gmaxwell> yea... I've never been impressed by the gitian approach.
1672019-03-06T10:58:59  <gmaxwell> also the need to update the vm amplfies risk a lot. It achieves the purpose of making a backdoored binary provably not any of our own faults, but doesn't increase security as much as it could.
1682019-03-06T10:59:30  <gmaxwell> (esp since more expirence with ubuntu packaging security has certantly not increased my confidence there... :) )
1692019-03-06T10:59:36  <wumpus> also the packages used to build are not themselves built deterministically
1702019-03-06T11:00:29  <wumpus> no, I'm not too confident there either, ubuntu was never a good choice there, it just was convenient, given the amount of work people were actually spending on this, I mean in all those years it's still the only thing we have
1712019-03-06T11:00:51  <gmaxwell> yep
1722019-03-06T11:00:57  <wumpus> (not trying to blame anyone specifically there, it's just not a very popular thing)
1732019-03-06T11:02:06  <gmaxwell> well we were pretty much the first project doing determinstic builds that I'm aware of... and even today in spite of huge effort and hype, there is still a long way to go ecosystem wise.  I don't believe there is yet any 'full' (even minimal) linux distro that is reproducably built.
1742019-03-06T11:03:38  *** promag has quit IRC
1752019-03-06T11:05:57  *** natangl has quit IRC
1762019-03-06T11:06:37  <wumpus> it's true; I think we were the first open source project doing this, even tor used gitian for a while for deterministic builds though they switched to some other system now
1772019-03-06T11:06:47  <Sentineo> gmaxwell: I saw a video last week about reproducable builds and debian has 80% I think they stated of the repos build that way now and the tor project is working on it as well. Fdroid has something similar, too. Let meg find the link.
1782019-03-06T11:07:17  *** jonatack has joined #bitcoin-core-dev
1792019-03-06T11:07:30  <wumpus> huh what I read is that debian managed to get 4% of the packages deterministic
1802019-03-06T11:07:59  <wumpus> they were having lots of trouble with it
1812019-03-06T11:08:29  <wumpus> given how many packages they have to build it's a pretty impressive number, still
1822019-03-06T11:08:50  <Sentineo> ah it is 2015 talk, but still ... https://www.youtube.com/watch?v=ilu6yMBGS6I&feature=youtu.be
1832019-03-06T11:08:57  * wumpus doesn't even succeed in making the bitcoin core build deterministic so who am I to complain ...
1842019-03-06T11:09:37  <gmaxwell> my comment was mostly just "this is absurdly hard" so much effort has been put at it, the fact that it's not 99% successful already shows that its hard.
1852019-03-06T11:09:45  <wumpus> yep, exactly
1862019-03-06T11:10:33  <wumpus> many people go into it very optimistically, then they start running into edge cases
1872019-03-06T11:13:25  <wumpus> whaaaaat . . . ... if I *only* build riscv64 and aarch64 I get the same output as the rest
1882019-03-06T11:13:44  <wumpus> I should not only nuke the VM but physically burn this computer too
1892019-03-06T11:13:52  <gmaxwell> lol
1902019-03-06T11:14:08  <gmaxwell> hm maybe some intemediate output from different builds is getting mixed up?
1912019-03-06T11:15:11  <wumpus> it's very possible, the curious thing is that those two platforms are last (being the most recently added)
1922019-03-06T11:15:48  <gmaxwell> I wonder if everyone else did the builds seperately and it would be consistent if they were all done at once?
1932019-03-06T11:16:01  <wumpus> but that makes it *more likely* they're influenced by earlier things
1942019-03-06T11:16:46  <wumpus> nah the same descriptor builds all platforms, the only way to build them separately is to hack the descriptor, I doubt everyone else did that :)
1952019-03-06T11:18:05  <wumpus> ideally you'd want to create a new, clean environment every time (as often as possible, so definitely between different platform builds), as soon as there is less overhead to that we should do that
1962019-03-06T11:18:48  <wumpus> currently that means adding 30-60 minutes of VM setup in between so I understand why it's merged into as few descriptors as possible
1972019-03-06T11:20:38  *** AaronvanW has joined #bitcoin-core-dev
1982019-03-06T11:22:18  *** Deinogalerix21 has quit IRC
1992019-03-06T11:25:03  *** Dean_Guss has quit IRC
2002019-03-06T11:25:28  *** Dean_Guss has joined #bitcoin-core-dev
2012019-03-06T11:26:05  *** zhangzf has quit IRC
2022019-03-06T11:26:23  *** zhangzf has joined #bitcoin-core-dev
2032019-03-06T11:29:31  *** Soligor_ has joined #bitcoin-core-dev
2042019-03-06T11:31:40  *** Soligor has quit IRC
2052019-03-06T11:40:43  <wumpus> in any case my suspicion is that something local here is preventing add-gnu-debuglink from working in some cases; I'd recommend to not make this a blocker for getting rc1 out
2062019-03-06T11:44:37  <wumpus> there's no `set -e` at the top of that split-debug.sh script, so say objdump fails (for what ever reason), the error will go unnoticed!
2072019-03-06T11:45:23  <wumpus> (also: and what does find -exec ... do when its command fails with error status? does it fail)
2082019-03-06T11:45:25  *** Soligor_ has quit IRC
2092019-03-06T11:51:23  <wumpus> "find" ignores errors as well, okay, I don't even have an idea how to  make errors propagate up the chain here
2102019-03-06T11:53:21  <gmaxwell> interesting, errors in -exec can be used to filter the output of find from extra stages, I don't think I realized that.
2112019-03-06T11:53:45  <gmaxwell> e.g. find ./ -exec true \; -print  prints everything but using false prints nothing.
2122019-03-06T11:54:02  <wumpus> oh!
2132019-03-06T12:00:48  <wumpus> apparently the solution to find -exec error propagation is to use 'xargs' instead
2142019-03-06T12:01:36  <gmaxwell> thats why I don't have much -exec expirence-- I've always used xargs. (Also -0 option ftw)
2152019-03-06T12:02:02  <wumpus> right, switching to that
2162019-03-06T12:03:26  *** bitcoin-git has joined #bitcoin-core-dev
2172019-03-06T12:03:26  <bitcoin-git> [bitcoin] Sjors opened pull request #15545: [doc] explain why CheckBlock() is called before AcceptBlock (master...2019/03/clarify-checkblock) https://github.com/bitcoin/bitcoin/pull/15545
2182019-03-06T12:03:27  *** bitcoin-git has left #bitcoin-core-dev
2192019-03-06T12:03:40  *** promag has joined #bitcoin-core-dev
2202019-03-06T12:03:47  <wumpus> find ${DISTNAME}/bin -type f -executable -print0 | xargs -0 -n1 -I{} ../contrib/devtools/split-debug.sh {} {} {}.dbg
2212019-03-06T12:04:39  <wumpus> then adding a 'set -e' at top of that script and it should cause the build to stop if any of the objdump commands fails...
2222019-03-06T12:04:51  <wumpus> objcopy*
2232019-03-06T12:06:27  <wumpus> silently ignoring errors should be the worst sin in computing
2242019-03-06T12:08:32  *** timothy has joined #bitcoin-core-dev
2252019-03-06T12:08:35  *** OneFive has joined #bitcoin-core-dev
2262019-03-06T12:09:54  *** jerem_ has joined #bitcoin-core-dev
2272019-03-06T12:10:26  *** OneFive_ has joined #bitcoin-core-dev
2282019-03-06T12:12:19  *** jerem_ has left #bitcoin-core-dev
2292019-03-06T12:13:59  *** OneFive has quit IRC
2302019-03-06T12:17:29  <promag> provoostenator: are you still using boost::process?
2312019-03-06T12:18:41  <provoostenator> promag: waiting for more feedback on #15440, I'm fine with any solution really, preferably one that minimizes headache.
2322019-03-06T12:18:42  <gribble> https://github.com/bitcoin/bitcoin/issues/15440 | RFC including boost-process · Issue #15440 · bitcoin/bitcoin · GitHub
2332019-03-06T12:19:16  <promag> kk
2342019-03-06T12:20:32  <wumpus> nice !
2352019-03-06T12:20:35  <provoostenator> It seems boost::process is overkill for what I need it for (pass stuff into a command as arguments or stdin, consume its std::out)
2362019-03-06T12:20:56  <promag> overkill? how so?
2372019-03-06T12:21:13  <provoostenator> promag: as I explain in that Github issue, it's a _lot_ of code
2382019-03-06T12:21:34  <provoostenator> With dependencies all over Boost itself, unclear how much that overlap with what we already consume.
2392019-03-06T12:22:01  <provoostenator> But it does Work(tm)
2402019-03-06T12:22:23  <luke-jr> if something else better is made, we can always switch later
2412019-03-06T12:22:31  <provoostenator> And boost things often make it to c++ standards, although afaik there's not progress on that front for process.
2422019-03-06T12:22:49  <luke-jr> doubt there will be
2432019-03-06T12:22:58  <provoostenator> luke-jr: I'm not worried about switching cost, I'm worried about how much review work it takes to use this.
2442019-03-06T12:23:04  <luke-jr> processes are foreign to C at least
2452019-03-06T12:23:07  <wumpus> "But it does Work(tm)" this part is usually undersnowed
2462019-03-06T12:23:20  <promag> provoostenator: I'll rework #13339 (maybe a different branch) to also use boost::process
2472019-03-06T12:23:23  <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
2482019-03-06T12:23:34  <luke-jr> promag: why?
2492019-03-06T12:23:49  <wumpus> so much talk about which dependency to use and so little about the actual feature :(
2502019-03-06T12:23:54  <luke-jr> that is working fine, except for escaping stuff, which boost::process doesn't add afaiki
2512019-03-06T12:24:24  *** fanquake has joined #bitcoin-core-dev
2522019-03-06T12:24:49  <gmaxwell> I thougth the plan of record we to just get it working however and worry about the exact mechenism to use fork() later?
2532019-03-06T12:25:03  <wumpus> yes ^^
2542019-03-06T12:25:20  <promag> luke-jr: ok, another branch then.. I think %w is kind of lame, I want to try env var instead
2552019-03-06T12:25:25  <gmaxwell> certantly we _can_ solve this, one way or another.
2562019-03-06T12:26:03  <provoostenator> gmaxwell: that's my plan as well, I'll just keep working on the hardware wallet support stuff
2572019-03-06T12:29:35  <provoostenator> And I made a seperate PR & issue for the boost:process stuff in order to deflect that discussion away from the feature.
2582019-03-06T12:30:13  <provoostenator> I wish there was an easier way to do nested PRs, but otherwise it's not blocking.
2592019-03-06T12:30:38  <wumpus> thanks, makes sense
2602019-03-06T12:35:08  *** OneFive_ has quit IRC
2612019-03-06T12:36:39  *** zhangzf has joined #bitcoin-core-dev
2622019-03-06T12:38:52  <wumpus> okay I'm lost now, what causes the gitian descriptor to stop building? does a command failing even do that? I had a typo in my descriptor causing find to *completely fail* (find: missing argument to `-exec') and it still continued building
2632019-03-06T12:39:44  <gmaxwell> IT CANNOT BE STOPPED. RUN RUN AND HIDE
2642019-03-06T12:40:19  <wumpus> now you're saying, CTRL-C didn't stop it either. OH NO I think you're right!
2652019-03-06T12:40:56  <provoostenator> Yeah, the unstoppable nature of Gitian builds has been noticed before. Resetting the VM helps :-)
2662019-03-06T12:42:03  <luke-jr> is it a bug that the "rc1" was added to zips, but not installer exes?
2672019-03-06T12:50:12  <wumpus> luke-jr: I think that's a bug
2682019-03-06T12:50:28  *** IGHOR has quit IRC
2692019-03-06T12:51:44  *** IGHOR has joined #bitcoin-core-dev
2702019-03-06T12:52:15  <wumpus> provoostenator: well it was almost done; most shocking to me was that a failing command didn't cause it to stop, it still built *some* output
2712019-03-06T12:54:28  <provoostenator> luke-jr: for which distro? Afaik  bitcoind and bitcoin-cli never include a version number.
2722019-03-06T12:55:02  <wumpus> I think he means to the filenames?
2732019-03-06T12:55:22  <provoostenator> The tar.gz names?
2742019-03-06T12:55:48  *** promag has quit IRC
2752019-03-06T12:56:00  <luke-jr> bitcoin-0.18.0-win32-setup-unsigned.exe bitcoin-0.18.0rc1-win32.zip bitcoin-0.18.0-win64-setup-unsigned.exe bitcoin-0.18.0rc1-win64.zip
2762019-03-06T12:56:31  <wumpus> no, the installer exe names
2772019-03-06T12:56:59  <provoostenator> File naming has some other issues too, in some places it doesn't include the patch version. See: https://github.com/bitcoin-core/docs/issues/18
2782019-03-06T12:57:40  <provoostenator> (but that's another issue that the installers)
2792019-03-06T12:57:51  <wumpus> I vaguely rememebr that one was fixed, not 100% sure though
2802019-03-06T12:58:11  <luke-jr> same
2812019-03-06T12:58:34  <luke-jr> pretty sure that was what fixed the rcN being added too
2822019-03-06T12:58:37  <provoostenator> What was fixed was a bug with the sub patch version, e.g. 0.17.0.1
2832019-03-06T12:58:42  <luke-jr> I had to modify my build scripts not to rename..
2842019-03-06T12:59:06  <provoostenator> (I guess we use semver differently, with the second digit being called the major version)
2852019-03-06T13:00:31  <provoostenator> 0.MAJOR.MINOR.PATCH, so the issue we fixed was that the patch version was ignored in 0.17.0.1. We still have an issue with missing minor version in some Gitian path names.
2862019-03-06T13:01:02  <wumpus> I've never heard of that one
2872019-03-06T13:01:28  <wumpus> you'd say being unable to distinguish minor versions would be extremely apparent
2882019-03-06T13:01:29  <luke-jr> the caches intentionally don't use MINOR.PATCH ..
2892019-03-06T13:01:53  <provoostenator> #14612
2902019-03-06T13:01:55  <gribble> https://github.com/bitcoin/bitcoin/issues/14612 | Include full version number in released file names by achow101 · Pull Request #14612 · bitcoin/bitcoin · GitHub
2912019-03-06T13:03:04  <provoostenator> The unsolved one is that we still use "bitcoin-linux-0.18-build.assert.sig" instead of "bitcoin-linux-0.18.0-build.assert.sig"
2922019-03-06T13:03:04  <luke-jr> #15546 should probably get a 0.18 tag
2932019-03-06T13:03:05  <gribble> https://github.com/bitcoin/bitcoin/issues/15546 | gitian: Windows installer EXE filenames lack "rcN" suffix · Issue #15546 · bitcoin/bitcoin · GitHub
2942019-03-06T13:03:19  <luke-jr> provoostenator: that's not a problem
2952019-03-06T13:03:44  <provoostenator> luke-jr: it's marginally annoying, but I agree not really a problem.
2962019-03-06T13:04:28  <provoostenator> I just need to brush up my bash to take only the first two digits from $VERSION in https://github.com/bitcoin-core/docs/issues/18
2972019-03-06T13:06:08  <luke-jr> I don't think --output is needed at all? and you can just use *.assert
2982019-03-06T13:06:47  <luke-jr> also, is there a reason you're leaving off the last character in --detach-sign ?
2992019-03-06T13:13:53  *** tferghrt has joined #bitcoin-core-dev
3002019-03-06T13:38:01  *** elichai2 has joined #bitcoin-core-dev
3012019-03-06T13:46:36  *** bitcoin-git has joined #bitcoin-core-dev
3022019-03-06T13:46:36  <bitcoin-git> [bitcoin] instagibbs opened pull request #15547: Switch wallet default to reject too-long transaction chains for mempool (master...walletreject_true) https://github.com/bitcoin/bitcoin/pull/15547
3032019-03-06T13:46:37  *** bitcoin-git has left #bitcoin-core-dev
3042019-03-06T13:47:47  <wumpus> okay, phew, at least putting random garbage into the descriptor script at the top causes it to fail the build, maybe it's something with the for loop over platforms that causes the error to be ignored
3052019-03-06T13:52:38  <fanquake> ignoring errors :o
3062019-03-06T13:56:17  *** shesek has quit IRC
3072019-03-06T13:57:09  *** jonatack has quit IRC
3082019-03-06T13:57:26  <wumpus> fanquake: yes; while editing the descriptor I made a typo in the find syntax, I'm sure that returns error status, but the build kept continuing, trying to figure out why now (I really want the build to stop on errors, even minor ones)
3092019-03-06T13:58:28  <wumpus> this is taking 10x as much time as it should because of gitian's VM setup overhead...
3102019-03-06T13:59:00  <fanquake> :/
3112019-03-06T13:59:08  <wumpus> hm I guess it's possible to re-use the image if the output doesn't matter
3122019-03-06T14:02:58  *** jonatack has joined #bitcoin-core-dev
3132019-03-06T14:03:31  <wumpus> OHHHHH I see the problem. `find -exec | xargs -0` returns exec status 0 despite find's error, after all, a pipe will return the exit status of the last command
3142019-03-06T14:03:42  <wumpus> *cries*
3152019-03-06T14:05:36  <wumpus> so what I managed to do: failures in the 'split-debug.sh' script will now make it upstream and cause the build to stop
3162019-03-06T14:06:07  <wumpus> what I managed to mess up: failures in the find itself will no longer be propagated
3172019-03-06T14:06:30  <wumpus> welcome to shell hell, one step forward, one step backward ...
3182019-03-06T14:07:25  <fanquake> Don't worry, deterministic building is "easy"
3192019-03-06T14:07:43  <wumpus> yesss, only a matter of setting time to 0 right
3202019-03-06T14:09:26  <fanquake> Nice quote from HN: "One has to step back and ask: "What made you decide to introduce non-determinism into your compilation process in the first place?""
3212019-03-06T14:09:28  <fanquake> ...
3222019-03-06T14:10:07  <wumpus> ha
3232019-03-06T14:12:27  <wumpus> "One has to step back and ask: what made you decide to let water into your boat in the first place?"
3242019-03-06T14:18:02  <wumpus> anyhow, with this in place I'm going to do the full linux build again, hopefully the problem will have magically disappeared (heisenbug), or it will exit due to an error in objcopy
3252019-03-06T14:20:18  <fanquake> sounds good, maybe a quick fix then
3262019-03-06T14:21:30  <wumpus> hopefully
3272019-03-06T14:35:12  *** shesek has joined #bitcoin-core-dev
3282019-03-06T14:35:12  *** shesek has joined #bitcoin-core-dev
3292019-03-06T14:37:58  <wumpus> TIL bash has `set -o pipefail` to fail a command if any of the stages of the pipe fails
3302019-03-06T14:38:04  <provoostenator> luke-jr: good catch re "--detach-sig", will fix now and then test when the signed binaries are out
3312019-03-06T14:43:16  <provoostenator> luke-jr: TIL gpg on macOS accepts --detach-sig as an alias for --detach-sign  . Undocumented and seems to be left over from older versions.
3322019-03-06T14:48:32  <luke-jr> probably backdoored too
3332019-03-06T14:49:16  <luke-jr> gpg seems to accept --anything if it's an unambiguous prefix
3342019-03-06T15:03:56  *** fanquake has quit IRC
3352019-03-06T15:15:21  *** jonatack has quit IRC
3362019-03-06T15:28:12  *** Victorsueca has quit IRC
3372019-03-06T15:29:19  *** Victorsueca has joined #bitcoin-core-dev
3382019-03-06T15:30:46  *** ExtraCrispy has joined #bitcoin-core-dev
3392019-03-06T15:36:22  *** zhangzf has quit IRC
3402019-03-06T15:37:31  *** Skirmant has joined #bitcoin-core-dev
3412019-03-06T15:40:19  *** zhangzf has joined #bitcoin-core-dev
3422019-03-06T15:41:26  *** d_t has joined #bitcoin-core-dev
3432019-03-06T15:49:14  *** promag has joined #bitcoin-core-dev
3442019-03-06T16:00:56  *** kexkey has joined #bitcoin-core-dev
3452019-03-06T16:10:05  <wumpus> so… it all turned out to be a VM disk space issue: https://github.com/bitcoin/bitcoin/issues/15541#issuecomment-470160960
3462019-03-06T16:16:57  *** jarthur has joined #bitcoin-core-dev
3472019-03-06T16:24:45  *** captjakk has joined #bitcoin-core-dev
3482019-03-06T16:25:23  *** ArdeshirV has joined #bitcoin-core-dev
3492019-03-06T16:26:51  *** spaced0ut has joined #bitcoin-core-dev
3502019-03-06T16:30:56  *** kexkey has quit IRC
3512019-03-06T16:31:24  *** kexkey has joined #bitcoin-core-dev
3522019-03-06T16:31:39  *** jarthur has quit IRC
3532019-03-06T16:34:40  <andytoshi> i'd like to start a wiki page or github issue or something to collect a wishlist for a bip174/psbt extension BIP draft. where is the best place to do that?
3542019-03-06T16:45:49  *** kexkey has quit IRC
3552019-03-06T16:54:37  *** ArdeshirV has quit IRC
3562019-03-06T16:55:07  *** shesek has quit IRC
3572019-03-06T16:55:49  *** ArdeshirV has joined #bitcoin-core-dev
3582019-03-06T16:56:44  *** ArdeshirV has quit IRC
3592019-03-06T16:57:05  *** ArdeshirV has joined #bitcoin-core-dev
3602019-03-06T16:58:07  *** kexkey has joined #bitcoin-core-dev
3612019-03-06T16:58:20  *** jonatack has joined #bitcoin-core-dev
3622019-03-06T16:59:28  *** ArdeshirV has left #bitcoin-core-dev
3632019-03-06T17:00:47  *** owowo has quit IRC
3642019-03-06T17:05:47  *** jarthur has joined #bitcoin-core-dev
3652019-03-06T17:05:53  *** owowo has joined #bitcoin-core-dev
3662019-03-06T17:13:08  *** hebasto has joined #bitcoin-core-dev
3672019-03-06T17:23:00  *** bitcoin-git has joined #bitcoin-core-dev
3682019-03-06T17:23:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15548: build: use full version string in setup.exe (master...1903-winVer) https://github.com/bitcoin/bitcoin/pull/15548
3692019-03-06T17:23:01  *** bitcoin-git has left #bitcoin-core-dev
3702019-03-06T17:28:17  *** zhangzf has quit IRC
3712019-03-06T17:29:37  *** bitcoin-git has joined #bitcoin-core-dev
3722019-03-06T17:29:37  <bitcoin-git> [bitcoin] laanwj opened pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
3732019-03-06T17:29:50  *** bitcoin-git has left #bitcoin-core-dev
3742019-03-06T17:30:45  <wumpus>  #15549
3752019-03-06T17:30:46  <gribble> https://github.com/bitcoin/bitcoin/issues/15549 | gitian: Improve error handling by laanwj · Pull Request #15549 · bitcoin/bitcoin · GitHub
3762019-03-06T17:31:58  <wumpus> andytoshi: that's a good question, normally the bitcoin-dev mailing list would be the best place to solicit feedback like that, but now that it's not working I don't really know
3772019-03-06T17:33:03  <sipa> wumpus: it's working again
3782019-03-06T17:33:08  <sipa> i think?
3792019-03-06T17:37:00  <andytoshi> cool, if it's working i'll use the ML
3802019-03-06T17:38:11  <wumpus> but you could also ask in the meeting tomorrow, for example
3812019-03-06T17:38:37  <andytoshi> I think i'll be in flight during the meeting unfortunately
3822019-03-06T17:38:47  <wumpus> or some other week
3832019-03-06T17:42:53  *** pinheadmz has joined #bitcoin-core-dev
3842019-03-06T17:47:04  *** gleb_ is now known as gleb
3852019-03-06T17:55:10  *** kexkey has quit IRC
3862019-03-06T17:56:11  *** kexkey has joined #bitcoin-core-dev
3872019-03-06T18:03:59  *** setpill has quit IRC
3882019-03-06T18:12:01  *** rh0nj has quit IRC
3892019-03-06T18:13:08  *** rh0nj has joined #bitcoin-core-dev
3902019-03-06T18:20:05  *** jungly has quit IRC
3912019-03-06T18:34:39  *** cubancorona has joined #bitcoin-core-dev
3922019-03-06T18:35:14  *** jonatack has left #bitcoin-core-dev
3932019-03-06T18:36:28  *** promag has quit IRC
3942019-03-06T18:38:56  *** promag has joined #bitcoin-core-dev
3952019-03-06T18:40:27  *** Zenton has quit IRC
3962019-03-06T18:40:27  *** jonatack has joined #bitcoin-core-dev
3972019-03-06T18:43:51  *** promag has quit IRC
3982019-03-06T18:45:44  *** kexkey has quit IRC
3992019-03-06T18:50:52  *** noxx_ has joined #bitcoin-core-dev
4002019-03-06T18:51:01  *** noxx__ has joined #bitcoin-core-dev
4012019-03-06T18:51:14  *** timothy has quit IRC
4022019-03-06T18:57:49  *** lnostdal has quit IRC
4032019-03-06T19:01:37  *** lnostdal has joined #bitcoin-core-dev
4042019-03-06T19:11:22  *** eo has joined #bitcoin-core-dev
4052019-03-06T19:13:36  *** eo has joined #bitcoin-core-dev
4062019-03-06T19:14:58  *** tferghrt has quit IRC
4072019-03-06T19:20:01  *** bitcoin-git has joined #bitcoin-core-dev
4082019-03-06T19:20:01  <bitcoin-git> [bitcoin] fametrano opened pull request #15550: [trivial] fixed path (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15550
4092019-03-06T19:20:14  *** bitcoin-git has left #bitcoin-core-dev
4102019-03-06T19:22:08  *** eo has quit IRC
4112019-03-06T19:36:53  *** Medea has joined #bitcoin-core-dev
4122019-03-06T19:38:18  *** bitjson has joined #bitcoin-core-dev
4132019-03-06T19:47:55  *** Medea has quit IRC
4142019-03-06T19:50:30  *** kexkey has joined #bitcoin-core-dev
4152019-03-06T19:58:50  *** mn949588 has quit IRC
4162019-03-06T19:59:04  *** mn949588 has joined #bitcoin-core-dev
4172019-03-06T19:59:48  *** Dean_Guss has quit IRC
4182019-03-06T19:59:55  <cfields_> gitian builders: detached sigs for v0.18.0rc1 are up.
4192019-03-06T20:00:15  *** Dean_Guss has joined #bitcoin-core-dev
4202019-03-06T20:09:13  *** noxx__ has quit IRC
4212019-03-06T20:09:13  *** noxx_ has quit IRC
4222019-03-06T20:14:00  *** hebasto has quit IRC
4232019-03-06T20:15:11  *** hebasto has joined #bitcoin-core-dev
4242019-03-06T20:16:38  *** kexkey has quit IRC
4252019-03-06T20:17:20  *** spinza has quit IRC
4262019-03-06T20:17:54  *** bitcoin-git has joined #bitcoin-core-dev
4272019-03-06T20:17:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/4952a953585e...df36ddf9ce8a
4282019-03-06T20:17:55  <bitcoin-git> bitcoin/master fab2daa MarcoFalke: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD
4292019-03-06T20:17:55  <bitcoin-git> bitcoin/master fa02b22 MarcoFalke: test: Remove useless test_bitcoin_main.cpp
4302019-03-06T20:17:56  <bitcoin-git> bitcoin/master fa85468 MarcoFalke: test: Move main_tests to validation_tests
4312019-03-06T20:17:57  *** bitcoin-git has left #bitcoin-core-dev
4322019-03-06T20:18:38  *** bitcoin-git has joined #bitcoin-core-dev
4332019-03-06T20:18:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15504: fuzz: Link BasicTestingSetup (shared with unit tests) (master...1903-testMain) https://github.com/bitcoin/bitcoin/pull/15504
4342019-03-06T20:18:39  *** bitcoin-git has left #bitcoin-core-dev
4352019-03-06T20:35:30  *** BlueMatt has quit IRC
4362019-03-06T20:37:51  *** BlueMatt has joined #bitcoin-core-dev
4372019-03-06T20:40:21  *** spinza has joined #bitcoin-core-dev
4382019-03-06T20:40:31  *** EagleTM has joined #bitcoin-core-dev
4392019-03-06T20:40:44  *** mmgen has quit IRC
4402019-03-06T20:44:51  *** Zenton has joined #bitcoin-core-dev
4412019-03-06T20:56:12  *** DeanWeen has joined #bitcoin-core-dev
4422019-03-06T20:57:13  *** Dean_Guss has quit IRC
4432019-03-06T21:00:53  *** kexkey has joined #bitcoin-core-dev
4442019-03-06T21:10:07  *** DeanWeen has quit IRC
4452019-03-06T21:10:51  *** DeanWeen has joined #bitcoin-core-dev
4462019-03-06T21:14:06  *** elichai2 has quit IRC
4472019-03-06T21:16:49  *** DeanWeen has quit IRC
4482019-03-06T21:25:59  *** BobStone_ has joined #bitcoin-core-dev
4492019-03-06T21:35:24  *** BobStone_ has quit IRC
4502019-03-06T21:49:55  *** promag has joined #bitcoin-core-dev
4512019-03-06T21:55:02  *** OneFive_ has joined #bitcoin-core-dev
4522019-03-06T21:56:21  *** OneFive__ has joined #bitcoin-core-dev
4532019-03-06T22:00:10  *** bitcoin-git has joined #bitcoin-core-dev
4542019-03-06T22:00:11  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/df36ddf9ce8a...3515612e069e
4552019-03-06T22:00:11  <bitcoin-git> bitcoin/master fa5dc35 MarcoFalke: rpc: Pass mempool into MempoolToJSON
4562019-03-06T22:00:12  <bitcoin-git> bitcoin/master fa38535 MarcoFalke: bench: Benchmark MempoolToJSON
4572019-03-06T22:00:12  <bitcoin-git> bitcoin/master 3515612 MarcoFalke: Merge #15473: bench: Benchmark MempoolToJSON
4582019-03-06T22:00:14  *** bitcoin-git has left #bitcoin-core-dev
4592019-03-06T22:00:20  *** OneFive_ has quit IRC
4602019-03-06T22:00:55  *** bitcoin-git has joined #bitcoin-core-dev
4612019-03-06T22:00:55  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15473: bench: Benchmark MempoolToJSON (master...Mf1902-benchRpcMempool) https://github.com/bitcoin/bitcoin/pull/15473
4622019-03-06T22:01:03  *** bitcoin-git has left #bitcoin-core-dev
4632019-03-06T22:02:00  *** promag_ has joined #bitcoin-core-dev
4642019-03-06T22:06:31  *** spinza has quit IRC
4652019-03-06T22:07:43  *** MTennis has joined #bitcoin-core-dev
4662019-03-06T22:08:53  *** Guyver2 has quit IRC
4672019-03-06T22:10:31  *** bitcoin-git has joined #bitcoin-core-dev
4682019-03-06T22:10:31  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15552: 0.18: Granular invalidateblock and RewindBlockIndex (0.18...201902_limitrewindinvalidate) https://github.com/bitcoin/bitcoin/pull/15552
4692019-03-06T22:10:34  *** bitcoin-git has left #bitcoin-core-dev
4702019-03-06T22:31:25  *** spinza has joined #bitcoin-core-dev
4712019-03-06T23:03:31  *** bitjson has quit IRC
4722019-03-06T23:05:06  *** justanotheruser has quit IRC
4732019-03-06T23:05:57  *** fanquake has joined #bitcoin-core-dev
4742019-03-06T23:06:34  <fanquake> cfields_ Thanks, I've pushed up some signed sigs
4752019-03-06T23:06:54  *** DeanWeen has joined #bitcoin-core-dev
4762019-03-06T23:07:51  *** jarthur has quit IRC
4772019-03-06T23:08:19  <cfields_> fanquake: Thanks :)
4782019-03-06T23:17:26  *** justanotheruser has joined #bitcoin-core-dev
4792019-03-06T23:17:47  *** booyah has quit IRC
4802019-03-06T23:22:01  *** booyah has joined #bitcoin-core-dev
4812019-03-06T23:29:43  *** MTennis has quit IRC
4822019-03-06T23:48:24  *** fanquake has quit IRC
4832019-03-06T23:53:19  *** Zenton has quit IRC
4842019-03-06T23:53:30  *** Zenton has joined #bitcoin-core-dev
4852019-03-06T23:55:24  *** OneFive__ has quit IRC