1 2019-03-09T00:00:27  *** AaronvanW has quit IRC
  2 2019-03-09T00:05:48  *** shesek has joined #bitcoin-core-dev
  3 2019-03-09T00:05:48  *** shesek has joined #bitcoin-core-dev
  4 2019-03-09T00:08:15  *** d_t has joined #bitcoin-core-dev
  5 2019-03-09T00:26:24  *** belcher has quit IRC
  6 2019-03-09T00:28:32  <sipa> gmaxwell: my formula is wrong
  7 2019-03-09T00:29:28  <sipa> if a fraction p of n-sig transactions is made using lowr, then you would observe a fraction x = p + (1-p)*0.5^n of lowr transactions
  8 2019-03-09T00:29:55  <sipa> so given x, p can be computed as (x*2^n - 1)/(2^n - 1)
  9 2019-03-09T00:38:25  *** tryphe has quit IRC
 10 2019-03-09T00:38:52  *** tryphe has joined #bitcoin-core-dev
 11 2019-03-09T00:39:40  *** belcher has joined #bitcoin-core-dev
 12 2019-03-09T00:41:39  <sipa> 2019-03-09T00:39:53.454594Z Stats LOWR 1: 1478633 0.06805
 13 2019-03-09T00:41:40  <sipa> 2019-03-09T00:39:53.454601Z Stats LOWR 2: 444741 0.0659343
 14 2019-03-09T00:41:40  <sipa> 2019-03-09T00:39:53.454611Z Stats LOWR 3: 70850 0.0976832
 15 2019-03-09T00:41:40  <sipa> 2019-03-09T00:39:53.454618Z Stats LOWR 4: 53930 0.07754
 16 2019-03-09T00:41:40  <sipa> 2019-03-09T00:39:53.454625Z Stats LOWR 5: 17363 0.121424
 17 2019-03-09T00:41:46  <sipa> for the last 1000 blocks
 18 2019-03-09T00:42:07  <sipa> the last number is the estimated ratio of lowr-software-produced transactions
 19 2019-03-09T00:54:45  <gmaxwell> sipa: did you not bother with stats for more than 5 signatures?
 20 2019-03-09T00:57:04  <sipa> i have numbers up to 256 sigs
 21 2019-03-09T00:58:03  <sipa> here are the first 50: https://zerobin.net/?26e00991169c6c76#QYnu/CQ+ywAhOUqaLqzx+HbQMGQFxvI8zgMyuBkUcSw=
 22 2019-03-09T01:06:30  *** dviola has quit IRC
 23 2019-03-09T01:10:07  <gmaxwell> so 6.87382% of transactions overall.
 24 2019-03-09T01:10:40  <sipa> is that the weighted average?
 25 2019-03-09T01:12:09  <gmaxwell> I took your counts time percentage and added it up.
 26 2019-03-09T01:13:40  <sipa> yeah
 27 2019-03-09T01:47:51  *** promag_ has quit IRC
 28 2019-03-09T01:49:37  <sipa> gmaxwell: https://zerobin.net/?43912925929e086e#2I4qQY2fS6KwIO8OOynLImNi48ZCm3UgluqTeRI3FtA=
 29 2019-03-09T01:49:40  <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
 30 2019-03-09T01:49:40  <sipa> last 10000 blocks
 31 2019-03-09T01:49:47  *** spinza has quit IRC
 32 2019-03-09T01:55:48  *** spinza has joined #bitcoin-core-dev
 33 2019-03-09T02:02:09  *** promag_ has joined #bitcoin-core-dev
 34 2019-03-09T02:04:28  <sipa> 5.3856%
 35 2019-03-09T02:05:18  *** d_t has quit IRC
 36 2019-03-09T02:17:10  *** millerti has quit IRC
 37 2019-03-09T02:35:59  *** promag_ has quit IRC
 38 2019-03-09T02:36:54  *** tryphe has quit IRC
 39 2019-03-09T02:37:19  *** tryphe has joined #bitcoin-core-dev
 40 2019-03-09T02:48:07  *** promag_ has joined #bitcoin-core-dev
 41 2019-03-09T02:53:35  *** Aaronvan_ has quit IRC
 42 2019-03-09T02:54:23  *** promag_ has quit IRC
 43 2019-03-09T03:04:50  *** d_t has joined #bitcoin-core-dev
 44 2019-03-09T03:10:34  *** captjakk has joined #bitcoin-core-dev
 45 2019-03-09T03:27:28  *** pinheadmz has quit IRC
 46 2019-03-09T03:36:56  *** tryphe has quit IRC
 47 2019-03-09T03:37:24  *** tryphe has joined #bitcoin-core-dev
 48 2019-03-09T03:38:45  *** pinheadmz has joined #bitcoin-core-dev
 49 2019-03-09T03:51:15  *** d_t has quit IRC
 50 2019-03-09T03:51:36  *** d_t has joined #bitcoin-core-dev
 51 2019-03-09T03:51:40  *** promag_ has joined #bitcoin-core-dev
 52 2019-03-09T03:55:53  *** promag_ has quit IRC
 53 2019-03-09T04:02:27  *** qrestlove has quit IRC
 54 2019-03-09T04:30:02  *** captjakk has quit IRC
 55 2019-03-09T04:36:56  *** tryphe has quit IRC
 56 2019-03-09T04:37:30  *** tryphe has joined #bitcoin-core-dev
 57 2019-03-09T04:49:31  *** zhangzf has joined #bitcoin-core-dev
 58 2019-03-09T04:58:31  *** zhangzf has quit IRC
 59 2019-03-09T05:01:39  *** davec has quit IRC
 60 2019-03-09T05:02:05  *** zhangzf has joined #bitcoin-core-dev
 61 2019-03-09T05:26:18  *** Emcy has quit IRC
 62 2019-03-09T05:36:57  *** tryphe has quit IRC
 63 2019-03-09T05:37:21  *** tryphe has joined #bitcoin-core-dev
 64 2019-03-09T05:39:22  *** zhangzf has quit IRC
 65 2019-03-09T05:45:51  *** bitcoin-git has joined #bitcoin-core-dev
 66 2019-03-09T05:45:52  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efed9809b4fa...12408d33c6ac
 67 2019-03-09T05:45:52  <bitcoin-git> bitcoin/master 32da92b Wladimir J. van der Laan: gitian: Improve error handling
 68 2019-03-09T05:45:53  <bitcoin-git> bitcoin/master 12408d3 Wladimir J. van der Laan: Merge #15549: gitian: Improve error handling
 69 2019-03-09T05:45:56  *** bitcoin-git has left #bitcoin-core-dev
 70 2019-03-09T05:46:39  *** bitcoin-git has joined #bitcoin-core-dev
 71 2019-03-09T05:46:39  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/0fd3632868e2...f810f14cf61d
 72 2019-03-09T05:46:40  <bitcoin-git> bitcoin/0.18 f810f14 Wladimir J. van der Laan: gitian: Improve error handling
 73 2019-03-09T05:46:42  *** bitcoin-git has left #bitcoin-core-dev
 74 2019-03-09T05:46:59  *** bitcoin-git has joined #bitcoin-core-dev
 75 2019-03-09T05:46:59  <bitcoin-git> [bitcoin] laanwj merged pull request #15549: gitian: Improve error handling (master...2019_03_gitian_error_handling) https://github.com/bitcoin/bitcoin/pull/15549
 76 2019-03-09T05:47:00  *** bitcoin-git has left #bitcoin-core-dev
 77 2019-03-09T05:55:56  *** promag_ has joined #bitcoin-core-dev
 78 2019-03-09T06:00:28  *** promag_ has quit IRC
 79 2019-03-09T06:02:40  *** bitcoin-git has joined #bitcoin-core-dev
 80 2019-03-09T06:02:41  <bitcoin-git> [bitcoin] fanquake opened pull request #15562: doc: remove duplicate clone step in build-windows.md (master...improved-15550) https://github.com/bitcoin/bitcoin/pull/15562
 81 2019-03-09T06:02:42  *** bitcoin-git has left #bitcoin-core-dev
 82 2019-03-09T06:03:02  *** bitcoin-git has joined #bitcoin-core-dev
 83 2019-03-09T06:03:02  <bitcoin-git> [bitcoin] fanquake closed pull request #15550: doc: correct path in build-windows.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15550
 84 2019-03-09T06:03:03  *** bitcoin-git has left #bitcoin-core-dev
 85 2019-03-09T06:05:52  *** davec has joined #bitcoin-core-dev
 86 2019-03-09T06:06:19  *** zhangzf has joined #bitcoin-core-dev
 87 2019-03-09T06:12:40  *** bitcoin-git has joined #bitcoin-core-dev
 88 2019-03-09T06:12:41  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/12408d33c6ac...ff3814880861
 89 2019-03-09T06:12:42  <bitcoin-git> bitcoin/master 4d83401 Suhas Daftuar: [addrman] Improve tried table collision logging
 90 2019-03-09T06:12:42  <bitcoin-git> bitcoin/master 4991e3c Suhas Daftuar: [net] feeler connections can be made to outbound peers in same netgroup
 91 2019-03-09T06:12:43  <bitcoin-git> bitcoin/master f71fdda Suhas Daftuar: [addrman] Ensure collisions eventually get resolved
 92 2019-03-09T06:12:48  *** bitcoin-git has left #bitcoin-core-dev
 93 2019-03-09T06:13:16  *** zhangzf has quit IRC
 94 2019-03-09T06:13:28  *** bitcoin-git has joined #bitcoin-core-dev
 95 2019-03-09T06:13:28  <bitcoin-git> [bitcoin] laanwj merged pull request #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (master...2019-02-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15486
 96 2019-03-09T06:13:30  *** bitcoin-git has left #bitcoin-core-dev
 97 2019-03-09T06:19:19  *** Emcy has joined #bitcoin-core-dev
 98 2019-03-09T06:36:57  *** tryphe has quit IRC
 99 2019-03-09T06:37:25  *** tryphe has joined #bitcoin-core-dev
100 2019-03-09T06:43:37  *** hebasto has joined #bitcoin-core-dev
101 2019-03-09T06:53:16  *** rex4539 has quit IRC
102 2019-03-09T07:07:35  *** bitcoin-git has joined #bitcoin-core-dev
103 2019-03-09T07:07:35  <bitcoin-git> [bitcoin] fanquake opened pull request #15563: backport: Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (0.18...backport-15486-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15563
104 2019-03-09T07:07:36  *** bitcoin-git has left #bitcoin-core-dev
105 2019-03-09T07:09:15  <fanquake> wumpus 15562 is a trivial doc merge
106 2019-03-09T07:10:04  <fanquake> no idea why the bottom "build using" is italicized, but it doesn't appear that way in the doc
107 2019-03-09T07:10:11  <wumpus> fanquake: OK
108 2019-03-09T07:10:21  <wumpus> looks good to me
109 2019-03-09T07:13:04  *** bitcoin-git has joined #bitcoin-core-dev
110 2019-03-09T07:13:06  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/f810f14cf61d...936ef73fabc9
111 2019-03-09T07:13:07  <bitcoin-git> bitcoin/0.18 561b00a Suhas Daftuar: [addrman] Improve tried table collision logging
112 2019-03-09T07:13:08  <bitcoin-git> bitcoin/0.18 487f0c3 Suhas Daftuar: [net] feeler connections can be made to outbound peers in same netgroup
113 2019-03-09T07:13:09  <bitcoin-git> bitcoin/0.18 333be7a Suhas Daftuar: [addrman] Ensure collisions eventually get resolved
114 2019-03-09T07:13:11  *** bitcoin-git has left #bitcoin-core-dev
115 2019-03-09T07:13:50  *** bitcoin-git has joined #bitcoin-core-dev
116 2019-03-09T07:13:51  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff3814880861...6b2ee268be45
117 2019-03-09T07:13:51  <bitcoin-git> bitcoin/master 5bd0788 Ferdinando M. Ametrano: doc: correct path in build-windows.md
118 2019-03-09T07:13:52  <bitcoin-git> bitcoin/master 6b2ee26 Wladimir J. van der Laan: Merge #15562: doc: remove duplicate clone step in build-windows.md
119 2019-03-09T07:13:56  *** bitcoin-git has left #bitcoin-core-dev
120 2019-03-09T07:14:35  <fanquake> I shall close my backport of 15486 then heh
121 2019-03-09T07:14:40  *** bitcoin-git has joined #bitcoin-core-dev
122 2019-03-09T07:14:40  <bitcoin-git> [bitcoin] laanwj merged pull request #15562: doc: remove duplicate clone step in build-windows.md (master...improved-15550) https://github.com/bitcoin/bitcoin/pull/15562
123 2019-03-09T07:14:45  *** bitcoin-git has left #bitcoin-core-dev
124 2019-03-09T07:15:18  *** EagleTM has joined #bitcoin-core-dev
125 2019-03-09T07:15:24  <wumpus> fanquake: oh sorry hadn't seen it
126 2019-03-09T07:15:59  <fanquake> np
127 2019-03-09T07:16:10  *** bitcoin-git has joined #bitcoin-core-dev
128 2019-03-09T07:16:11  <bitcoin-git> [bitcoin] fanquake closed pull request #15563: backport: Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups (0.18...backport-15486-addrman-collisions) https://github.com/bitcoin/bitcoin/pull/15563
129 2019-03-09T07:16:24  *** bitcoin-git has left #bitcoin-core-dev
130 2019-03-09T07:17:41  <wumpus> fanquake: it was a clean cherry-pick right?
131 2019-03-09T07:17:49  <fanquake> yes
132 2019-03-09T07:17:52  <wumpus> phew
133 2019-03-09T07:19:38  *** Krusty has joined #bitcoin-core-dev
134 2019-03-09T07:21:16  *** sipa has quit IRC
135 2019-03-09T07:25:16  <wumpus> I really want to improve -getinfo now that it's no longer server side, e.g. show regtest/testnet/mainnet, make some information per wallet
136 2019-03-09T07:25:46  <wumpus> so if anyone has ideas let me know
137 2019-03-09T07:26:30  *** sipa has joined #bitcoin-core-dev
138 2019-03-09T07:27:52  <gmaxwell> wumpus: pilfer ideas from that ncurses interface someone did a while back?
139 2019-03-09T07:30:15  <wumpus> maybe! to be clear I intend to keep it in JSON format, just want to update for changes since 0.10 or so when it last was depreceated and diceded to never change it again
140 2019-03-09T07:32:06  <gmaxwell> well one thing in terms of cli usability maybe don't do what many of our other info rpcs have done and put a billion and one vaguely useful things so that when you run them the good stuff scrolls off the top and its hard to sort out anything useful. :P
141 2019-03-09T07:32:27  <wumpus> removing stuff is open for suggestion too
142 2019-03-09T07:32:58  <wumpus> I mean, 'improve' doesn't always mean 'creep any possible feature into it'
143 2019-03-09T07:33:20  <gmaxwell> exactly.
144 2019-03-09T07:33:34  <gmaxwell> or alternatively, go fetch some useful fields out of e.g. getblockchaininfo
145 2019-03-09T07:34:19  <gmaxwell> I'll comment the next time I get wall of texted when trying to get a frequently used field.
146 2019-03-09T07:35:41  <wumpus> I'd say a good requirement for information on it is that it's dynamic, it's meant as a command for checking the status after all
147 2019-03-09T07:36:00  <wumpus> things that are only dependent on on-time configuration might be better to leave off
148 2019-03-09T07:36:56  *** tryphe has quit IRC
149 2019-03-09T07:37:13  <wumpus> (I mean, how useful is 'protocolversion' on there for example?) or 'keypoololdest', or settings like 'paytxfee'
150 2019-03-09T07:37:24  *** tryphe has joined #bitcoin-core-dev
151 2019-03-09T07:39:02  <wumpus> but, say, the hash of the most recent block would be useful to have
152 2019-03-09T07:39:45  <fanquake> could change testnet: to something like network, then specify main/test/reg ?
153 2019-03-09T07:39:55  <wumpus> fanquake: yes exactly
154 2019-03-09T07:40:57  <wumpus> that would be a simple and non-controversial improvement
155 2019-03-09T07:41:32  <wumpus> just grab getblockchaininfo.main directly
156 2019-03-09T07:41:36  <wumpus> eh, .chain
157 2019-03-09T07:42:29  <wumpus> "verificationprogress" is also more or less useful, though only during initial sync
158 2019-03-09T07:44:02  <gmaxwell> yea, I think what I mostly use getblockchaininfo is the hash of the most recent block, and its scrolled off...
159 2019-03-09T07:44:34  *** Krusty_ has joined #bitcoin-core-dev
160 2019-03-09T07:45:21  <gmaxwell> do we have anything that returns the time of the last updatetip?
161 2019-03-09T07:45:27  <fanquake> Maybe we could do something better for multiwallet use? i.e at the moment walletversion and balance are both just "null" if >1 wallet loaded
162 2019-03-09T07:45:39  <fanquake> * same for keypool*
163 2019-03-09T07:45:48  <wumpus> fanquake: walletversion doesn't need to be in there at all, but yeah, it should *list* wallets
164 2019-03-09T07:45:52  <gmaxwell> keypool shoudl probably be dropped.
165 2019-03-09T07:45:54  <wumpus> gmaxwell: I don't think so
166 2019-03-09T07:46:50  <wumpus> fanquake: the only interesting thing about the wallet in getinfo is the balance, so it could be a object {'walletname': balance} or such then it doesn't really become longer as well
167 2019-03-09T07:47:49  <wumpus> gmaxwell: do we even keep track of the time of an updatetip?
168 2019-03-09T07:48:02  <sipa> wumpus: IsInitialBlockDownload does iirc
169 2019-03-09T07:48:28  *** Krusty has quit IRC
170 2019-03-09T07:48:50  *** Krusty_ has quit IRC
171 2019-03-09T07:49:03  <wumpus> sipa: ok-in that case it'd make sense to report that on getblockchaininfo, I guess!
172 2019-03-09T07:57:55  *** bitcoin-git has joined #bitcoin-core-dev
173 2019-03-09T07:57:55  <bitcoin-git> [bitcoin] fanquake opened pull request #15564: cli: remove duplicate wallet fields from -getinfo (master...cli-remove-duplicate-entries) https://github.com/bitcoin/bitcoin/pull/15564
174 2019-03-09T07:57:58  *** d_t has quit IRC
175 2019-03-09T07:58:02  *** bitcoin-git has left #bitcoin-core-dev
176 2019-03-09T08:00:19  *** EagleTM has quit IRC
177 2019-03-09T08:10:54  *** jonatack_ has quit IRC
178 2019-03-09T08:20:54  *** rex4539 has joined #bitcoin-core-dev
179 2019-03-09T08:21:25  *** bitcoin-git has joined #bitcoin-core-dev
180 2019-03-09T08:21:25  <bitcoin-git> [bitcoin] fanquake opened pull request #15565: doc: remove release note fragments (master...remove-pre-18-release-notes) https://github.com/bitcoin/bitcoin/pull/15565
181 2019-03-09T08:21:33  *** bitcoin-git has left #bitcoin-core-dev
182 2019-03-09T08:36:57  *** tryphe has quit IRC
183 2019-03-09T08:37:24  *** tryphe has joined #bitcoin-core-dev
184 2019-03-09T08:39:38  *** bitcoin-git has joined #bitcoin-core-dev
185 2019-03-09T08:39:38  <bitcoin-git> [bitcoin] fanquake opened pull request #15566: cli: replace testnet with chain and return network name as per BIP70. (master...cli-testnet-to-network) https://github.com/bitcoin/bitcoin/pull/15566
186 2019-03-09T08:39:39  *** bitcoin-git has left #bitcoin-core-dev
187 2019-03-09T08:52:22  *** jungly has joined #bitcoin-core-dev
188 2019-03-09T08:54:58  *** promag_ has joined #bitcoin-core-dev
189 2019-03-09T08:57:47  <wumpus> btw is "analyzepsbt" really returning a formatted string for the feerate? that's awful
190 2019-03-09T08:58:30  <wumpus> ah i see: result.pushKV("estimated_feerate", feerate.ToString());
191 2019-03-09T09:00:18  <gwillen> wumpus: the new AnalyzePSBT after my refactor in #15508 will return it as a CFeeRate, although it will still be flattened to a string in the same way before being returned from the RPC
192 2019-03-09T09:00:20  <gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub
193 2019-03-09T09:00:35  <gwillen> if the RPC behavior should change I can probably sneak that in
194 2019-03-09T09:01:12  <wumpus> gwillen: IMO it should simply be a value, the unit should be in the documentation not part of the value
195 2019-03-09T09:01:14  <gmaxwell> elsewhere we return amounts as json numbers for maximal json library torture potential. :)
196 2019-03-09T09:01:51  <wumpus> gmaxwell: this actually originates from a float though, so there's no decimal encoding issue
197 2019-03-09T09:01:52  <gmaxwell> oh, though an interesting point about feerates, is that sensible feerates have more precision than bitcoin.
198 2019-03-09T09:01:55  <fanquake> wumpus, yea currently "0.00021598 BTC/kB"
199 2019-03-09T09:02:10  <fanquake> I agree a number makes much more sense
200 2019-03-09T09:02:18  <wumpus> there's 0 reason to not simply return this as floating point value
201 2019-03-09T09:02:28  <gmaxwell> PSBT serializes a float? how does it handle endianness?
202 2019-03-09T09:02:46  <wumpus> huh, no, I don't know if PSBT doesthat
203 2019-03-09T09:02:51  <wumpus> CFeeRate has a double IIRC
204 2019-03-09T09:03:08  <gmaxwell> feerate should be a rational number inside PSBT itself, I hope I hope.
205 2019-03-09T09:03:31  <wumpus> oh I'm wrong apparently?
206 2019-03-09T09:03:33  <wumpus> return strprintf("%d.%08d %s/kB", nSatoshisPerK / COIN, nSatoshisPerK % COIN, CURRENCY_UNIT);
207 2019-03-09T09:03:49  <sipa> PSBT doesn't store any feerate
208 2019-03-09T09:03:55  <gmaxwell> I think estimated_feerate sounds like it's a cosmetic field, like difficulty.
209 2019-03-09T09:04:06  <sipa> the feerate is computed as fee divided by expected serialized vsize
210 2019-03-09T09:04:16  <gwillen> this is in analyzepsbt, which returns information for examining the status of a PSBT
211 2019-03-09T09:04:25  <wumpus> in any case the current representation on RPC is useless, you don't want clients to be parsing units from strings
212 2019-03-09T09:04:37  <gmaxwell> for human inspection not programmatic manipulation, so it would be okay to print it as unicode domino characters.
213 2019-03-09T09:04:58  <wumpus> units and the semantics of values belong in the help, not in the value
214 2019-03-09T09:05:01  <gwillen> yeah, although I think it would be reasonable to return it in satoshis per K or something, and let the RPC client decide how to fancy display it
215 2019-03-09T09:05:23  <sipa> yeah
216 2019-03-09T09:05:27  <wumpus> right
217 2019-03-09T09:05:37  <sipa> how are feerates put in JSON elsewhere?
218 2019-03-09T09:05:47  <gmaxwell> are they, anywhere else?
219 2019-03-09T09:05:53  <fanquake> In mining I think
220 2019-03-09T09:05:58  <gwillen> I hate and fear floating point numbers and JSON decimals
221 2019-03-09T09:06:00  <sipa> at least in estimatefeerate i gope!
222 2019-03-09T09:06:03  <sipa> *hope
223 2019-03-09T09:06:03  <luke-jr> ^
224 2019-03-09T09:06:08  <gmaxwell> hah
225 2019-03-09T09:06:23  <fanquake> https://github.com/bitcoin/bitcoin/blob/6b2ee268be459fbc104c054204e2992d4e241915/src/rpc/mining.cpp#L829
226 2019-03-09T09:06:48  <wumpus> heck, even *if* you'd want to return it as a string, because you hate JSON decimals or whatever reason, don't add the unit to it
227 2019-03-09T09:06:48  <gmaxwell> gwillen: fortunately the purpose of this value is display purposes, woe be it to anyone trying to do anything programatic with it. (because exactly rounding matters, and...)
228 2019-03-09T09:07:00  * luke-jr wonders why estimatesmartfee is in mining
229 2019-03-09T09:07:13  <gmaxwell> luke-jr: because chaos
230 2019-03-09T09:07:17  <wumpus> but it makes sense to be consistent with other JSON/RPC calls
231 2019-03-09T09:07:19  <gmaxwell> all hail chaos
232 2019-03-09T09:07:20  <wumpus> that's a good point
233 2019-03-09T09:08:10  <gwillen> gmaxwell: well the nice thing about giving it in integer sat/k is that that's the internal representation so there's no rounding question at all
234 2019-03-09T09:08:21  <gmaxwell> also what is "nSatoshisPerK"? hopefully K is in units of thousands of vsize or something?
235 2019-03-09T09:08:34  <gwillen> heh, yeah that's presumably the case, I didn't think about that
236 2019-03-09T09:08:39  <gmaxwell> gwillen: the internal representation is a double, I believe.
237 2019-03-09T09:09:16  <gmaxwell> (feerates and guistuff and time are the things in bitcoin that use floats)
238 2019-03-09T09:09:24  <gwillen> negative, CFeeRate contains CAmount nSatoshisPerK, CAmount is an int64_t
239 2019-03-09T09:09:42  <gwillen> I only know this because I just looked
240 2019-03-09T09:09:42  <gmaxwell> ah okay, well its float in some places. :P good that it isn't in cfeerate.
241 2019-03-09T09:09:51  <gwillen> like I said, I hate and fear floating point
242 2019-03-09T09:10:14  <gmaxwell> Integer über alles.
243 2019-03-09T09:10:16  <wumpus> floating point for monetary value is always a bad idea
244 2019-03-09T09:10:21  <gwillen> yeah
245 2019-03-09T09:11:05  *** mmgen has joined #bitcoin-core-dev
246 2019-03-09T09:11:06  <gmaxwell> so one thing to keep in mind is that unfortuantely a bunch of websites adopted integer satoshi per byte as a fee unit, resulting in a lot of the ecosystem thinking the integer satoshi per byte is the fundimental primitive feerate unit.
247 2019-03-09T09:11:08  <gwillen> it's interesting that it's per k not per byte, that gives more resolution than any display of fee rate I've ever seen
248 2019-03-09T09:11:13  <gwillen> right
249 2019-03-09T09:11:31  <gmaxwell> (and also this results in some dumb behaviors)
250 2019-03-09T09:11:35  <luke-jr> gmaxwell: it probably should be?
251 2019-03-09T09:11:59  <gmaxwell> luke-jr: not at all... I mean you can have a fee of 1 satoshi for a 1000 vbyte transaction...
252 2019-03-09T09:12:42  <gmaxwell> feerate is naturally a rational number, there isn't any inherent obvious denominator but if you have to pick one, one the size of a reasonable transaction (like 1000) isn't so bad.
253 2019-03-09T09:12:46  <luke-jr> sure, but you could also have 1 sat for a 10k tx
254 2019-03-09T09:12:53  <luke-jr> hypothetically
255 2019-03-09T09:12:57  <gmaxwell> luke-jr: indeed.
256 2019-03-09T09:13:33  <gmaxwell> but there are no 1 byte transactions, so putting a one in a denominator is inherently losing about a factor of 50 in sensible precision.
257 2019-03-09T09:13:35  <gwillen> I guess it ultimately depends on what you're using it for ... for display it doesn't matter too much
258 2019-03-09T09:13:47  <gwillen> for other things it could matter quite a bit
259 2019-03-09T09:14:16  <luke-jr> for display, /kB is a good size to work with
260 2019-03-09T09:14:43  <gmaxwell> yea, I've always found per 1000 to be pretty reasonable, thats always what core's interfaces have had.
261 2019-03-09T09:15:44  <gmaxwell> unfortuantely all these fee estimation sites sprung up around a time when the min relay fee happened to be 1s/b, I think, which is what caused it to be treated as fundimental instead of the bitcoin per/1000b the bitcoin software used in it's interfaces
262 2019-03-09T09:17:07  <gmaxwell> in any case, I just bring up the common units so people will be mindful of the errors users might make.
263 2019-03-09T09:17:46  <gmaxwell> like, don't have interfaces for people to enter fees that take btc/1000 vbytes and fail to guard against users entering values like 10.
264 2019-03-09T09:19:00  <gmaxwell> (in spite of my love of integers, I'm also not super fond of satoshi interfaces... values are usually too big, and it's perfectly reasonable for bitcoin software to work in sub-satoshi amounts even though thats the network precision)
265 2019-03-09T09:20:30  <wumpus> i mean that's always been the problem with integer representation; it's only obvious if there is a single subdivision that makes sense, otherwise, you could end up reporting (or worse, taking) the same kinds of value in different precisions in different parts of the interface
266 2019-03-09T09:20:35  <wumpus> *whoops, overpaid by 1000x*
267 2019-03-09T09:21:13  <wumpus> decimal types (that have an explicit precision) exist for a good reason, it's unfortunate that language adoption of them is so bad
268 2019-03-09T09:22:29  <gmaxwell> the sad thing here is that json itself-- the spec-- is reasonable.
269 2019-03-09T09:22:43  <wumpus> yes
270 2019-03-09T09:22:46  <gmaxwell> Just everything that uses it, including javascript itself makes being reasonable with it hard in practice.
271 2019-03-09T09:23:19  <gmaxwell> I loved that time when json spirit silently snuck in a conversion to (float) ...
272 2019-03-09T09:26:37  <sipa> just work in finite fields
273 2019-03-09T09:26:43  <sipa> exactly representable in finite space
274 2019-03-09T09:28:31  <wumpus> heh
275 2019-03-09T09:29:59  *** jonatack has joined #bitcoin-core-dev
276 2019-03-09T09:36:40  *** bitcoin-git has joined #bitcoin-core-dev
277 2019-03-09T09:36:41  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b2ee268be45...257f750cd986
278 2019-03-09T09:36:41  <bitcoin-git> bitcoin/master 6e1aaff fanquake: doc: remove release note fragments
279 2019-03-09T09:36:42  <bitcoin-git> bitcoin/master 257f750 Wladimir J. van der Laan: Merge #15565: doc: remove release note fragments
280 2019-03-09T09:36:44  *** bitcoin-git has left #bitcoin-core-dev
281 2019-03-09T09:36:57  *** tryphe has quit IRC
282 2019-03-09T09:37:24  *** tryphe has joined #bitcoin-core-dev
283 2019-03-09T09:37:25  *** bitcoin-git has joined #bitcoin-core-dev
284 2019-03-09T09:37:25  <bitcoin-git> [bitcoin] laanwj merged pull request #15565: doc: remove release note fragments (master...remove-pre-18-release-notes) https://github.com/bitcoin/bitcoin/pull/15565
285 2019-03-09T09:37:26  *** bitcoin-git has left #bitcoin-core-dev
286 2019-03-09T09:55:44  *** EagleTM has joined #bitcoin-core-dev
287 2019-03-09T10:24:08  *** spinza has quit IRC
288 2019-03-09T10:28:27  *** TheRec has quit IRC
289 2019-03-09T10:36:58  *** tryphe has quit IRC
290 2019-03-09T10:37:24  *** tryphe has joined #bitcoin-core-dev
291 2019-03-09T10:38:12  *** spinza has joined #bitcoin-core-dev
292 2019-03-09T10:52:21  *** zhangzf has joined #bitcoin-core-dev
293 2019-03-09T11:00:12  *** TheRec has joined #bitcoin-core-dev
294 2019-03-09T11:16:40  *** teslasystsems has joined #bitcoin-core-dev
295 2019-03-09T11:19:48  *** teslasystsems has quit IRC
296 2019-03-09T11:21:37  *** teslasystems has joined #bitcoin-core-dev
297 2019-03-09T11:26:17  <teslasystems> Can anyone tell, where is the button for creating new wallets in Bitcoin Core? It has disappeared after 0.16.3 release
298 2019-03-09T11:28:02  <luke-jr> teslasystems: that's a question for #bitcoin, not here
299 2019-03-09T11:28:46  <wumpus> besides that, I don't think we've ever had a button for creating new wallets
300 2019-03-09T11:29:06  <luke-jr> yes, I have that answer typed up waiting for him in #Bitcoin XD
301 2019-03-09T11:29:16  <wumpus> ok thanks :D
302 2019-03-09T11:29:37  <teslasystems> Sorry, but I thought that the question is related to development, will post to #bitcoin
303 2019-03-09T11:32:52  *** yigig has joined #bitcoin-core-dev
304 2019-03-09T11:34:08  *** teslasystems has quit IRC
305 2019-03-09T11:36:52  *** AaronvanW has joined #bitcoin-core-dev
306 2019-03-09T11:36:59  *** tryphe has quit IRC
307 2019-03-09T11:37:26  *** tryphe has joined #bitcoin-core-dev
308 2019-03-09T11:48:01  *** bitcoin-git has joined #bitcoin-core-dev
309 2019-03-09T11:48:01  <bitcoin-git> [bitcoin] Sjors opened pull request #15567: Make OutputType consistent with Descriptor and return it (master...2019/03/descriptor-output-type) https://github.com/bitcoin/bitcoin/pull/15567
310 2019-03-09T11:48:02  *** bitcoin-git has left #bitcoin-core-dev
311 2019-03-09T11:55:25  *** obsrver has joined #bitcoin-core-dev
312 2019-03-09T12:08:39  *** EagleTM has quit IRC
313 2019-03-09T12:13:38  *** hebasto has quit IRC
314 2019-03-09T12:14:46  *** hebasto has joined #bitcoin-core-dev
315 2019-03-09T12:16:18  *** owowo has quit IRC
316 2019-03-09T12:21:20  *** owowo has joined #bitcoin-core-dev
317 2019-03-09T12:30:56  *** EagleTM has joined #bitcoin-core-dev
318 2019-03-09T12:36:59  *** tryphe has quit IRC
319 2019-03-09T12:37:24  *** tryphe has joined #bitcoin-core-dev
320 2019-03-09T12:52:03  *** rex4539 has quit IRC
321 2019-03-09T13:02:02  *** Aaronvan_ has joined #bitcoin-core-dev
322 2019-03-09T13:05:03  *** AaronvanW has quit IRC
323 2019-03-09T13:12:30  *** jungly has quit IRC
324 2019-03-09T13:37:00  *** tryphe has quit IRC
325 2019-03-09T13:37:26  *** tryphe has joined #bitcoin-core-dev
326 2019-03-09T14:06:15  *** Aaronvan_ is now known as AaronvanW
327 2019-03-09T14:17:15  *** jonatack has quit IRC
328 2019-03-09T14:18:22  *** AaronvanW has quit IRC
329 2019-03-09T14:27:08  *** unknown-os has joined #bitcoin-core-dev
330 2019-03-09T14:37:00  *** tryphe has quit IRC
331 2019-03-09T14:37:27  *** tryphe has joined #bitcoin-core-dev
332 2019-03-09T14:41:12  *** unknown-os has quit IRC
333 2019-03-09T14:43:40  *** Cory has quit IRC
334 2019-03-09T14:46:32  *** e4xit has quit IRC
335 2019-03-09T14:49:27  *** Pasha has joined #bitcoin-core-dev
336 2019-03-09T14:50:22  *** zhangzf has quit IRC
337 2019-03-09T14:50:36  *** zhangzf has joined #bitcoin-core-dev
338 2019-03-09T14:51:24  *** zhangzf has joined #bitcoin-core-dev
339 2019-03-09T14:52:11  *** zhangzf has joined #bitcoin-core-dev
340 2019-03-09T14:52:38  *** Pasha is now known as Cory
341 2019-03-09T14:52:43  *** zhangzf has quit IRC
342 2019-03-09T14:52:59  *** zhangzf has joined #bitcoin-core-dev
343 2019-03-09T14:57:19  *** AaronvanW has joined #bitcoin-core-dev
344 2019-03-09T14:57:51  *** e4xit has joined #bitcoin-core-dev
345 2019-03-09T15:00:03  *** obsrver has quit IRC
346 2019-03-09T15:01:42  *** AaronvanW has quit IRC
347 2019-03-09T15:02:43  *** e4xit has quit IRC
348 2019-03-09T15:08:40  *** zhangzf has joined #bitcoin-core-dev
349 2019-03-09T15:08:41  *** e4xit has joined #bitcoin-core-dev
350 2019-03-09T15:10:08  *** tryphe has quit IRC
351 2019-03-09T15:10:58  *** tryphe has joined #bitcoin-core-dev
352 2019-03-09T15:12:55  *** zhangzf has quit IRC
353 2019-03-09T15:20:05  *** JackH has joined #bitcoin-core-dev
354 2019-03-09T15:20:27  *** Zenton has quit IRC
355 2019-03-09T15:28:35  *** millerti has joined #bitcoin-core-dev
356 2019-03-09T15:29:03  *** promag has quit IRC
357 2019-03-09T15:29:19  *** promag has joined #bitcoin-core-dev
358 2019-03-09T15:29:46  *** Zenton has joined #bitcoin-core-dev
359 2019-03-09T15:34:58  *** EagleTM has quit IRC
360 2019-03-09T15:40:03  *** AaronvanW has joined #bitcoin-core-dev
361 2019-03-09T15:40:36  *** obsrver has joined #bitcoin-core-dev
362 2019-03-09T15:42:56  *** bitcoin-git has joined #bitcoin-core-dev
363 2019-03-09T15:42:56  <bitcoin-git> [bitcoin] hebasto closed pull request #15340: gui: Introduce bilingual GUI error messages (master...20190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340
364 2019-03-09T15:42:58  *** bitcoin-git has left #bitcoin-core-dev
365 2019-03-09T15:43:47  *** obsrver has quit IRC
366 2019-03-09T15:44:25  *** AaronvanW has quit IRC
367 2019-03-09T15:44:33  *** obsrver has joined #bitcoin-core-dev
368 2019-03-09T16:02:48  *** hebasto has quit IRC
369 2019-03-09T16:03:56  *** hebasto has joined #bitcoin-core-dev
370 2019-03-09T16:04:06  *** promag has quit IRC
371 2019-03-09T16:14:32  *** darosior has joined #bitcoin-core-dev
372 2019-03-09T16:16:35  *** profmac has quit IRC
373 2019-03-09T16:23:31  *** Sentineo has quit IRC
374 2019-03-09T16:29:43  *** profmac has joined #bitcoin-core-dev
375 2019-03-09T16:36:44  *** Guyver2 has joined #bitcoin-core-dev
376 2019-03-09T17:00:35  *** AaronvanW has joined #bitcoin-core-dev
377 2019-03-09T17:00:40  *** Sentineo has joined #bitcoin-core-dev
378 2019-03-09T17:19:57  *** dviola has joined #bitcoin-core-dev
379 2019-03-09T17:21:09  *** kexkey has joined #bitcoin-core-dev
380 2019-03-09T17:21:29  *** sfhi has joined #bitcoin-core-dev
381 2019-03-09T17:31:51  *** e4xit has quit IRC
382 2019-03-09T17:33:37  *** e4xit has joined #bitcoin-core-dev
383 2019-03-09T17:37:46  *** d_t has joined #bitcoin-core-dev
384 2019-03-09T17:39:07  *** millerti has quit IRC
385 2019-03-09T17:43:57  *** jonatack has joined #bitcoin-core-dev
386 2019-03-09T17:44:20  *** AaronvanW has quit IRC
387 2019-03-09T18:04:44  *** promag has joined #bitcoin-core-dev
388 2019-03-09T18:08:48  *** promag has quit IRC
389 2019-03-09T18:32:18  *** captjakk has joined #bitcoin-core-dev
390 2019-03-09T18:36:18  *** obsrver has quit IRC
391 2019-03-09T18:41:20  *** AaronvanW has joined #bitcoin-core-dev
392 2019-03-09T18:45:45  *** AaronvanW has quit IRC
393 2019-03-09T18:50:15  *** darosior has quit IRC
394 2019-03-09T18:53:33  *** darosior has joined #bitcoin-core-dev
395 2019-03-09T19:01:47  *** mmgen has quit IRC
396 2019-03-09T19:04:14  *** obsrver has joined #bitcoin-core-dev
397 2019-03-09T19:07:03  *** bitcoin-git has joined #bitcoin-core-dev
398 2019-03-09T19:07:03  <bitcoin-git> [bitcoin] cisba closed pull request #15554: docs: binary tar improvement (master...improve-tar) https://github.com/bitcoin/bitcoin/pull/15554
399 2019-03-09T19:07:04  *** bitcoin-git has left #bitcoin-core-dev
400 2019-03-09T19:08:05  *** bitcoin-git has joined #bitcoin-core-dev
401 2019-03-09T19:08:05  <bitcoin-git> [bitcoin] cisba opened pull request #15569: docs: improve linux tar packages (master...improve-tar-rebased) https://github.com/bitcoin/bitcoin/pull/15569
402 2019-03-09T19:08:13  *** bitcoin-git has left #bitcoin-core-dev
403 2019-03-09T19:14:45  *** jonatack has quit IRC
404 2019-03-09T19:18:03  *** AaronvanW has joined #bitcoin-core-dev
405 2019-03-09T19:18:40  *** rex4539 has joined #bitcoin-core-dev
406 2019-03-09T19:22:11  *** jonatack has joined #bitcoin-core-dev
407 2019-03-09T19:35:52  *** belcher has quit IRC
408 2019-03-09T19:38:47  *** dviola has quit IRC
409 2019-03-09T19:39:54  *** dviola has joined #bitcoin-core-dev
410 2019-03-09T19:41:12  *** AaronvanW has quit IRC
411 2019-03-09T19:41:29  *** AaronvanW has joined #bitcoin-core-dev
412 2019-03-09T19:53:04  *** hebasto has quit IRC
413 2019-03-09T20:00:42  *** EagleTM has joined #bitcoin-core-dev
414 2019-03-09T20:08:27  *** darosior has quit IRC
415 2019-03-09T20:08:39  *** marcinja has quit IRC
416 2019-03-09T20:08:48  *** d_t has quit IRC
417 2019-03-09T20:09:12  *** jamesob has quit IRC
418 2019-03-09T20:09:19  *** marcinja has joined #bitcoin-core-dev
419 2019-03-09T20:09:25  *** jamesob has joined #bitcoin-core-dev
420 2019-03-09T20:11:25  *** phantomcircuit has quit IRC
421 2019-03-09T20:13:13  *** dviola has quit IRC
422 2019-03-09T20:13:14  *** dviola has joined #bitcoin-core-dev
423 2019-03-09T20:14:09  *** xHire has quit IRC
424 2019-03-09T20:14:10  *** gertjaap has quit IRC
425 2019-03-09T20:14:10  *** moneyball has quit IRC
426 2019-03-09T20:14:58  *** phantomcircuit has joined #bitcoin-core-dev
427 2019-03-09T20:15:28  *** jonatack has quit IRC
428 2019-03-09T20:15:29  *** xHire has joined #bitcoin-core-dev
429 2019-03-09T20:15:55  *** gertjaap has joined #bitcoin-core-dev
430 2019-03-09T20:16:20  *** moneyball has joined #bitcoin-core-dev
431 2019-03-09T20:17:28  *** comboy has quit IRC
432 2019-03-09T20:18:25  *** jonatack has joined #bitcoin-core-dev
433 2019-03-09T20:18:42  *** comboy has joined #bitcoin-core-dev
434 2019-03-09T20:22:58  *** Skirmant has quit IRC
435 2019-03-09T20:37:28  *** d_t has joined #bitcoin-core-dev
436 2019-03-09T20:42:17  *** promag has joined #bitcoin-core-dev
437 2019-03-09T20:43:37  *** promag has quit IRC
438 2019-03-09T20:47:13  *** darosior has joined #bitcoin-core-dev
439 2019-03-09T20:48:11  *** promag has joined #bitcoin-core-dev
440 2019-03-09T20:50:24  *** promag has quit IRC
441 2019-03-09T20:53:15  *** AaronvanW has quit IRC
442 2019-03-09T20:56:30  *** promag has joined #bitcoin-core-dev
443 2019-03-09T20:59:32  *** promag has quit IRC
444 2019-03-09T21:01:19  *** promag has joined #bitcoin-core-dev
445 2019-03-09T21:05:28  *** promag has quit IRC
446 2019-03-09T21:08:11  *** siom has joined #bitcoin-core-dev
447 2019-03-09T21:09:40  *** arubi_ has joined #bitcoin-core-dev
448 2019-03-09T21:11:25  *** arubi has quit IRC
449 2019-03-09T21:26:39  *** Guyver2 has quit IRC
450 2019-03-09T21:29:53  <gmaxwell> Does anyone feel like getting agressive with anti-virus companies to get them to stop false positiving on bitcoind?
451 2019-03-09T21:29:54  *** darosior has quit IRC
452 2019-03-09T21:30:20  <gmaxwell> the security alias just got yet another report, apparently mac AV software is now also claiming that bitcoin is a virus.
453 2019-03-09T21:37:34  *** Victorsueca has quit IRC
454 2019-03-09T21:38:21  *** Victorsueca has joined #bitcoin-core-dev
455 2019-03-09T21:39:48  *** spinza has quit IRC
456 2019-03-09T21:50:53  *** AaronvanW has joined #bitcoin-core-dev
457 2019-03-09T21:54:03  *** d_t has quit IRC
458 2019-03-09T21:58:00  *** obsrver has quit IRC
459 2019-03-09T22:07:32  *** siom has quit IRC
460 2019-03-09T22:08:51  *** spinza has joined #bitcoin-core-dev
461 2019-03-09T22:11:56  *** Aaronvan_ has joined #bitcoin-core-dev
462 2019-03-09T22:12:56  <owowo> AV companies are the snake-oil salesmen of the modern age
463 2019-03-09T22:14:11  *** AaronvanW has quit IRC
464 2019-03-09T22:29:48  <tryphe> gmaxwell, if AV software was any good, it would detect itself as a backdoor and self-delete
465 2019-03-09T22:54:28  *** spinza has quit IRC
466 2019-03-09T23:00:24  *** zivl has quit IRC
467 2019-03-09T23:02:58  *** spinza has joined #bitcoin-core-dev
468 2019-03-09T23:04:45  *** DeanGuss has quit IRC
469 2019-03-09T23:05:14  *** zhangzf has joined #bitcoin-core-dev
470 2019-03-09T23:07:45  *** dviola has quit IRC
471 2019-03-09T23:11:43  *** zhangzf has quit IRC
472 2019-03-09T23:13:11  *** Karyon_ has joined #bitcoin-core-dev
473 2019-03-09T23:13:50  *** Karyon has quit IRC
474 2019-03-09T23:14:46  *** Karyon_ is now known as Karyon
475 2019-03-09T23:17:21  *** sfhi has quit IRC
476 2019-03-09T23:28:37  *** jonatack has quit IRC