12019-03-14T00:00:27  *** Dean_Guss has quit IRC
  22019-03-14T00:09:04  *** owowo has quit IRC
  32019-03-14T00:11:12  *** pinheadmz has quit IRC
  42019-03-14T00:14:56  *** owowo has joined #bitcoin-core-dev
  52019-03-14T00:14:57  *** owowo has joined #bitcoin-core-dev
  62019-03-14T00:16:12  *** Randolf has joined #bitcoin-core-dev
  72019-03-14T00:17:38  *** makey40 has quit IRC
  82019-03-14T00:30:30  *** Dean_Guss has joined #bitcoin-core-dev
  92019-03-14T00:34:43  *** makey40 has joined #bitcoin-core-dev
 102019-03-14T00:36:24  *** makey40 has quit IRC
 112019-03-14T00:42:57  *** Dean_Guss has quit IRC
 122019-03-14T00:50:23  *** makey40 has joined #bitcoin-core-dev
 132019-03-14T00:52:04  *** makey40 has joined #bitcoin-core-dev
 142019-03-14T00:57:51  *** makey40 has joined #bitcoin-core-dev
 152019-03-14T01:01:03  *** makey40 has quit IRC
 162019-03-14T01:03:14  *** bitcoin-git has joined #bitcoin-core-dev
 172019-03-14T01:03:14  <bitcoin-git> [bitcoin] pstratem opened pull request #15597: Generate log entry when blocks messages are received unexpectedly. (master...2019-03-12-net-unexpected-block) https://github.com/bitcoin/bitcoin/pull/15597
 182019-03-14T01:03:16  *** bitcoin-git has left #bitcoin-core-dev
 192019-03-14T01:03:56  *** makey40 has joined #bitcoin-core-dev
 202019-03-14T01:04:13  *** makey40 has quit IRC
 212019-03-14T01:09:32  <gmaxwell> phantomcircuit: good spotting
 222019-03-14T01:17:30  *** makey40 has joined #bitcoin-core-dev
 232019-03-14T01:18:50  *** pinheadmz has joined #bitcoin-core-dev
 242019-03-14T01:18:50  *** makey40 has quit IRC
 252019-03-14T01:19:17  *** jonatack has quit IRC
 262019-03-14T01:20:38  *** Dean_Guss has joined #bitcoin-core-dev
 272019-03-14T01:23:35  *** makey40 has joined #bitcoin-core-dev
 282019-03-14T01:24:29  *** makey40 has joined #bitcoin-core-dev
 292019-03-14T01:24:38  *** zhangzf has joined #bitcoin-core-dev
 302019-03-14T01:26:04  *** makey40 has quit IRC
 312019-03-14T01:26:35  *** promag has quit IRC
 322019-03-14T01:37:33  *** jonatack has joined #bitcoin-core-dev
 332019-03-14T01:37:53  *** jarthur has joined #bitcoin-core-dev
 342019-03-14T01:40:08  *** makey40 has joined #bitcoin-core-dev
 352019-03-14T01:41:27  *** booyah_ has joined #bitcoin-core-dev
 362019-03-14T01:41:48  *** booyah has quit IRC
 372019-03-14T01:51:33  *** pinheadmz has quit IRC
 382019-03-14T01:51:49  *** makey40 has joined #bitcoin-core-dev
 392019-03-14T01:51:54  *** Randolf has quit IRC
 402019-03-14T01:52:15  *** makey40 has quit IRC
 412019-03-14T01:54:32  *** makey40 has joined #bitcoin-core-dev
 422019-03-14T01:56:35  *** makey40 has joined #bitcoin-core-dev
 432019-03-14T02:00:13  *** makey40 has joined #bitcoin-core-dev
 442019-03-14T02:01:44  *** spinza has quit IRC
 452019-03-14T02:04:43  *** makey40 has joined #bitcoin-core-dev
 462019-03-14T02:07:10  *** makey40 has quit IRC
 472019-03-14T02:07:10  *** spinza has joined #bitcoin-core-dev
 482019-03-14T02:15:50  *** makey40 has joined #bitcoin-core-dev
 492019-03-14T02:16:45  *** makey40 has quit IRC
 502019-03-14T02:22:44  *** jonatack has quit IRC
 512019-03-14T02:23:47  *** makey40 has joined #bitcoin-core-dev
 522019-03-14T02:25:42  *** makey40 has quit IRC
 532019-03-14T02:25:50  *** Jackielove4u has quit IRC
 542019-03-14T02:28:05  *** makey40 has joined #bitcoin-core-dev
 552019-03-14T02:29:00  *** makey40 has quit IRC
 562019-03-14T02:29:33  *** luke-jr has quit IRC
 572019-03-14T02:34:39  *** luke-jr has joined #bitcoin-core-dev
 582019-03-14T02:36:49  *** makey40 has joined #bitcoin-core-dev
 592019-03-14T02:47:23  *** pinheadmz has joined #bitcoin-core-dev
 602019-03-14T02:53:33  *** AaronvanW has joined #bitcoin-core-dev
 612019-03-14T02:54:29  *** muoitran has joined #bitcoin-core-dev
 622019-03-14T02:56:47  *** drexl has quit IRC
 632019-03-14T02:56:52  *** Aaronvan_ has quit IRC
 642019-03-14T03:07:49  *** captjakk has quit IRC
 652019-03-14T03:12:42  *** jarthur has quit IRC
 662019-03-14T03:13:14  *** jarthur has joined #bitcoin-core-dev
 672019-03-14T03:17:05  *** luke-jr has quit IRC
 682019-03-14T03:21:55  *** justanotheruser has quit IRC
 692019-03-14T03:25:03  *** jarthur has quit IRC
 702019-03-14T03:25:54  *** jarthur has joined #bitcoin-core-dev
 712019-03-14T03:27:14  *** promag has joined #bitcoin-core-dev
 722019-03-14T03:31:52  *** promag has quit IRC
 732019-03-14T03:33:33  *** pinheadmz has quit IRC
 742019-03-14T03:39:34  *** justanotheruser has joined #bitcoin-core-dev
 752019-03-14T03:54:26  *** luke-jr has joined #bitcoin-core-dev
 762019-03-14T04:09:34  *** pinheadmz has joined #bitcoin-core-dev
 772019-03-14T04:25:14  *** pinheadmz has quit IRC
 782019-03-14T04:39:37  *** harrymm has quit IRC
 792019-03-14T04:40:40  *** harrymm has joined #bitcoin-core-dev
 802019-03-14T04:47:26  *** pinheadmz has joined #bitcoin-core-dev
 812019-03-14T04:58:22  *** shesek has quit IRC
 822019-03-14T05:04:39  *** luke-jr has quit IRC
 832019-03-14T05:06:49  *** luke-jr has joined #bitcoin-core-dev
 842019-03-14T05:10:19  *** luke-jr has quit IRC
 852019-03-14T05:10:40  *** luke-jr has joined #bitcoin-core-dev
 862019-03-14T05:21:44  *** pinheadmz has quit IRC
 872019-03-14T05:46:15  *** pinheadmz has joined #bitcoin-core-dev
 882019-03-14T06:05:08  *** d_t has quit IRC
 892019-03-14T06:07:35  *** rex4539 has quit IRC
 902019-03-14T06:16:13  *** muoitran has quit IRC
 912019-03-14T06:24:26  *** pinheadmz has quit IRC
 922019-03-14T07:01:42  *** d_t has joined #bitcoin-core-dev
 932019-03-14T07:21:35  *** booyah_ is now known as booyah
 942019-03-14T07:22:56  *** d_t has quit IRC
 952019-03-14T07:34:01  *** ccdle12 has joined #bitcoin-core-dev
 962019-03-14T07:40:19  <Sentineo> MarcoFalke: did not understand you finding about those gpg keys. Is the issue with the key itself or something else? I did not open an issue yet, I can if it is just not my noobness what causes it not working :)
 972019-03-14T07:41:19  <gmaxwell> Sentineo: run gpg --recv-key AC6626172E00A82CFFAE8972A636E97631F767E0
 982019-03-14T07:42:44  *** ccdle12 has quit IRC
 992019-03-14T07:42:55  *** Jackielove4u has joined #bitcoin-core-dev
1002019-03-14T07:43:31  *** ccdle12 has joined #bitcoin-core-dev
1012019-03-14T07:59:53  <midnightmagic> w/w 3
1022019-03-14T08:00:53  *** CubicEarth has quit IRC
1032019-03-14T08:03:21  *** CubicEarth has joined #bitcoin-core-dev
1042019-03-14T08:05:25  *** harding has quit IRC
1052019-03-14T08:07:33  *** harding has joined #bitcoin-core-dev
1062019-03-14T08:20:15  *** anome has joined #bitcoin-core-dev
1072019-03-14T08:26:19  *** promag has joined #bitcoin-core-dev
1082019-03-14T08:34:09  *** DougieBot5000_ has joined #bitcoin-core-dev
1092019-03-14T08:34:52  *** DougieBot5000 is now known as Guest58108
1102019-03-14T08:34:53  *** DougieBot5000_ is now known as DougieBot5000
1112019-03-14T08:57:57  *** anome has quit IRC
1122019-03-14T09:17:34  *** owowo has quit IRC
1132019-03-14T09:22:15  *** owowo has joined #bitcoin-core-dev
1142019-03-14T09:22:15  *** owowo has joined #bitcoin-core-dev
1152019-03-14T09:31:13  *** anome has joined #bitcoin-core-dev
1162019-03-14T09:35:04  *** timothy has joined #bitcoin-core-dev
1172019-03-14T09:37:21  *** setpill has joined #bitcoin-core-dev
1182019-03-14T10:00:40  *** anome has quit IRC
1192019-03-14T10:01:41  *** anome has joined #bitcoin-core-dev
1202019-03-14T10:06:07  <Sentineo> gmaxwell: thanks, that seemed to help. As it is still working, it took about a minute for it to fail before. I wonder where you got the key ID from though. Mind explaining so I can fix the issue later myself if happens again?
1212019-03-14T10:12:04  <provoostenator> Sentineo the fingerprint of sipa's key, that you just downloaded, is in trusted-keys here: https://github.com/bitcoin/bitcoin/tree/master/contrib/verify-commits
1222019-03-14T10:12:07  *** luke-jr has quit IRC
1232019-03-14T10:12:07  *** anome has quit IRC
1242019-03-14T10:16:44  <Sentineo> oh I see, ok. Thanks provoostenator!
1252019-03-14T10:19:39  *** luke-jr has joined #bitcoin-core-dev
1262019-03-14T10:22:29  *** anome has joined #bitcoin-core-dev
1272019-03-14T10:24:14  *** anome has quit IRC
1282019-03-14T10:25:46  *** spinza has quit IRC
1292019-03-14T10:32:39  *** anome has joined #bitcoin-core-dev
1302019-03-14T10:39:46  *** spinza has joined #bitcoin-core-dev
1312019-03-14T11:10:32  *** anome has quit IRC
1322019-03-14T11:14:44  *** hebasto has joined #bitcoin-core-dev
1332019-03-14T11:20:26  *** zhangzf has quit IRC
1342019-03-14T11:20:51  *** zhangzf has joined #bitcoin-core-dev
1352019-03-14T12:37:52  *** zhangzf has joined #bitcoin-core-dev
1362019-03-14T12:45:25  *** owowo has quit IRC
1372019-03-14T12:49:09  *** rex4539 has joined #bitcoin-core-dev
1382019-03-14T12:49:36  *** owowo has joined #bitcoin-core-dev
1392019-03-14T12:50:13  *** jonatack has joined #bitcoin-core-dev
1402019-03-14T12:50:52  *** shesek has joined #bitcoin-core-dev
1412019-03-14T12:50:52  *** shesek has joined #bitcoin-core-dev
1422019-03-14T13:14:37  *** darosior has joined #bitcoin-core-dev
1432019-03-14T13:16:25  *** AaronvanW has joined #bitcoin-core-dev
1442019-03-14T13:30:50  *** owowo has quit IRC
1452019-03-14T13:31:40  *** owowo has joined #bitcoin-core-dev
1462019-03-14T13:41:00  *** bitcoin-git has joined #bitcoin-core-dev
1472019-03-14T13:41:00  <bitcoin-git> [bitcoin] luke-jr opened pull request #15600: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps or forked process memory spaces (master...lockedpool_dontdump) https://github.com/bitcoin/bitcoin/pull/15600
1482019-03-14T13:41:01  *** bitcoin-git has left #bitcoin-core-dev
1492019-03-14T13:55:38  *** ccdle12 has quit IRC
1502019-03-14T13:56:14  <provoostenator> Does the MSVC build ignore configure.ac?
1512019-03-14T13:57:12  *** spaced0ut has joined #bitcoin-core-dev
1522019-03-14T14:02:01  *** deepakkathayat has joined #bitcoin-core-dev
1532019-03-14T14:06:05  *** bitcoin-git has joined #bitcoin-core-dev
1542019-03-14T14:06:05  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/232ef630ecd3...a01925c1502a
1552019-03-14T14:06:05  <bitcoin-git> bitcoin/0.18 a01925c Wladimir J. van der Laan: doc: Pre-rc2 translations update
1562019-03-14T14:06:07  *** bitcoin-git has left #bitcoin-core-dev
1572019-03-14T14:10:53  *** jungly has quit IRC
1582019-03-14T14:17:24  *** jarthur has quit IRC
1592019-03-14T14:23:42  *** Emcy has quit IRC
1602019-03-14T14:28:37  *** Emcy has joined #bitcoin-core-dev
1612019-03-14T14:55:48  *** zhangzf has quit IRC
1622019-03-14T14:56:20  *** zhangzf has joined #bitcoin-core-dev
1632019-03-14T15:01:28  *** jnewbery has quit IRC
1642019-03-14T15:05:55  *** Aaronvan_ has joined #bitcoin-core-dev
1652019-03-14T15:09:01  *** AaronvanW has quit IRC
1662019-03-14T15:13:16  <wumpus> provoostenator: I think so, yes
1672019-03-14T15:13:27  *** jnewbery has joined #bitcoin-core-dev
1682019-03-14T15:16:10  *** darosior has quit IRC
1692019-03-14T15:19:39  *** ccdle12 has joined #bitcoin-core-dev
1702019-03-14T15:26:14  <provoostenator> Actually I don't think it's ignored. It's just that .appveyor.yml doesn't bust the cache when it changes. Fixed as part of #15457 (hopefully)
1712019-03-14T15:26:16  <gribble> https://github.com/bitcoin/bitcoin/issues/15457 | Check std::system for -[alert|block|wallet]notify by Sjors · Pull Request #15457 · bitcoin/bitcoin · GitHub
1722019-03-14T15:27:10  <provoostenator> I'm trying to get Visual Studio setup on a Windows 10 VM on my Mac. It's insanely slow, but getting there...
1732019-03-14T15:27:37  <provoostenator> I like how PowerShell supports "ls" in addition to "dir" :-)
1742019-03-14T15:28:33  <Sentineo> does it make sense to try to do a gitian build now, or wait till official release?
1752019-03-14T15:31:20  *** captjakk has joined #bitcoin-core-dev
1762019-03-14T15:33:32  *** Aaronvan_ is now known as AaronvanW
1772019-03-14T15:37:09  *** darosior has joined #bitcoin-core-dev
1782019-03-14T15:45:20  <provoostenator> Sentineo: I believe v0.18.0rc2 will be tagged later today, so that's a good one to build.
1792019-03-14T15:45:45  <provoostenator> (see https://github.com/bitcoin-core/docs/blob/master/gitian-building.md)
1802019-03-14T15:46:49  *** lxleuser has joined #bitcoin-core-dev
1812019-03-14T15:47:43  *** lxleuser is now known as deepakmkathayat
1822019-03-14T15:47:54  <Sentineo> ok great, I will try it tomorrow. Hopefully I can build it.
1832019-03-14T15:58:08  *** pinheadmz has joined #bitcoin-core-dev
1842019-03-14T16:00:59  *** jonatack has quit IRC
1852019-03-14T16:04:59  <hebasto> Sentineo: using gitian-build.py with Docker is probably the easiest way.
1862019-03-14T16:08:06  *** mmgen has joined #bitcoin-core-dev
1872019-03-14T16:09:44  *** Deinogalerix21 has joined #bitcoin-core-dev
1882019-03-14T16:12:57  *** luke-jr has quit IRC
1892019-03-14T16:13:46  *** luke-jr has joined #bitcoin-core-dev
1902019-03-14T16:24:01  *** ExtraCrispy has joined #bitcoin-core-dev
1912019-03-14T16:26:08  *** promag has quit IRC
1922019-03-14T16:26:56  *** promag has joined #bitcoin-core-dev
1932019-03-14T16:27:01  *** zhangzf has quit IRC
1942019-03-14T16:31:19  *** jarthur has joined #bitcoin-core-dev
1952019-03-14T16:38:05  *** BEEN has joined #bitcoin-core-dev
1962019-03-14T16:40:39  *** BEEN has quit IRC
1972019-03-14T16:43:25  *** promag has quit IRC
1982019-03-14T16:47:13  *** Guyver2 has joined #bitcoin-core-dev
1992019-03-14T16:50:17  *** TheRec has quit IRC
2002019-03-14T16:54:54  *** deepakmkathayat has quit IRC
2012019-03-14T16:54:59  *** deepakkathayat has quit IRC
2022019-03-14T17:05:46  *** darosior has quit IRC
2032019-03-14T17:18:45  *** TheRec has joined #bitcoin-core-dev
2042019-03-14T17:24:16  <provoostenator> How do I produce the right config.ini for the Visual Studio build? Normally AppVeyor performs some magic on config.ini.in it seems.
2052019-03-14T17:30:21  *** promag has joined #bitcoin-core-dev
2062019-03-14T17:33:17  *** jhfrontz1 has joined #bitcoin-core-dev
2072019-03-14T17:33:20  *** setpill has quit IRC
2082019-03-14T17:33:45  *** cyber55 has quit IRC
2092019-03-14T17:38:27  *** luke-jr has quit IRC
2102019-03-14T17:42:37  *** elichai2 has joined #bitcoin-core-dev
2112019-03-14T17:42:57  *** luke-jr has joined #bitcoin-core-dev
2122019-03-14T17:52:29  *** tripleslash has quit IRC
2132019-03-14T17:54:49  <promag>  anything left to do in #15583?
2142019-03-14T17:54:51  <gribble> https://github.com/bitcoin/bitcoin/issues/15583 | wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree by promag · Pull Request #15583 · bitcoin/bitcoin · GitHub
2152019-03-14T17:59:11  *** bitcoin-git has joined #bitcoin-core-dev
2162019-03-14T17:59:11  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8e1704c01537...7fa1f6258c05
2172019-03-14T17:59:11  <bitcoin-git> bitcoin/master 15c69b1 João Barbosa: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree
2182019-03-14T17:59:12  <bitcoin-git> bitcoin/master 7fa1f62 Wladimir J. van der Laan: Merge #15583: wallet: Log and ignore errors in ListWalletDir and IsBerkele...
2192019-03-14T17:59:24  *** bitcoin-git has left #bitcoin-core-dev
2202019-03-14T17:59:58  *** bitcoin-git has joined #bitcoin-core-dev
2212019-03-14T17:59:59  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/a01925c1502a...ef27a060ac0d
2222019-03-14T17:59:59  <bitcoin-git> bitcoin/0.18 ef27a06 João Barbosa: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree
2232019-03-14T18:00:12  *** bitcoin-git has left #bitcoin-core-dev
2242019-03-14T18:00:28  *** bitcoin-git has joined #bitcoin-core-dev
2252019-03-14T18:00:29  <bitcoin-git> [bitcoin] laanwj merged pull request #15583: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree (master...2019-03-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/15583
2262019-03-14T18:00:42  *** bitcoin-git has left #bitcoin-core-dev
2272019-03-14T18:00:52  <kanzure> meeting time?
2282019-03-14T18:00:58  *** bitcoin-git has joined #bitcoin-core-dev
2292019-03-14T18:00:59  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/ef27a060ac0d...85f1755163a1
2302019-03-14T18:00:59  <bitcoin-git> bitcoin/0.18 85f1755 Wladimir J. van der Laan: build: bump to rc2
2312019-03-14T18:01:12  *** bitcoin-git has left #bitcoin-core-dev
2322019-03-14T18:01:48  <sipa> kanzure: one hour from now
2332019-03-14T18:01:56  <achow101> kanzure: in an hour, dst
2342019-03-14T18:02:16  <achow101> dst changed last weekend
2352019-03-14T18:02:27  <promag> wumpus: that was fast
2362019-03-14T18:06:30  *** bitcoin-git has joined #bitcoin-core-dev
2372019-03-14T18:06:30  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/85f1755163a1...889af0eaacd9
2382019-03-14T18:06:30  <bitcoin-git> bitcoin/0.18 889af0e Wladimir J. van der Laan: doc: Update manpages
2392019-03-14T18:06:33  *** bitcoin-git has left #bitcoin-core-dev
2402019-03-14T18:09:57  *** Deinogalerix21 has quit IRC
2412019-03-14T18:11:45  *** promag has quit IRC
2422019-03-14T18:15:44  *** Aaronvan_ has joined #bitcoin-core-dev
2432019-03-14T18:17:20  *** d_t has joined #bitcoin-core-dev
2442019-03-14T18:19:22  *** AaronvanW has quit IRC
2452019-03-14T18:22:06  *** AaronvanW has joined #bitcoin-core-dev
2462019-03-14T18:25:09  *** Aaronvan_ has quit IRC
2472019-03-14T18:39:13  *** CubicEarth has quit IRC
2482019-03-14T18:41:35  *** vexbuy has joined #bitcoin-core-dev
2492019-03-14T18:44:10  *** spinza has quit IRC
2502019-03-14T18:54:07  *** spinza has joined #bitcoin-core-dev
2512019-03-14T19:00:24  <wumpus> meeting time?
2522019-03-14T19:00:36  <jnewbery> hi
2532019-03-14T19:00:49  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
2542019-03-14T19:00:53  <wumpus> #startmeeti
2552019-03-14T19:00:53  <provoostenator> hi
2562019-03-14T19:00:55  <wumpus> #startmeeting
2572019-03-14T19:00:55  <lightningbot> Meeting started Thu Mar 14 19:00:55 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2582019-03-14T19:00:55  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2592019-03-14T19:00:55  <achow101> hi
2602019-03-14T19:01:09  <instagibbs> oh hi
2612019-03-14T19:01:24  <luke-jr> hi
2622019-03-14T19:01:27  <dongcarl> oh hi mark
2632019-03-14T19:01:37  <instagibbs> topic: 0.18 release progress (I'm a bit out of loop on what needs backport etc)
2642019-03-14T19:01:45  <wumpus> we're pretty much ready to tag 0.18.0rc2
2652019-03-14T19:01:50  <instagibbs> \o/
2662019-03-14T19:01:51  <kanzure> hi
2672019-03-14T19:02:18  <wumpus> any topics?
2682019-03-14T19:02:22  <cfields> hi
2692019-03-14T19:02:27  *** timothy has quit IRC
2702019-03-14T19:02:27  *** bitcoin-git has joined #bitcoin-core-dev
2712019-03-14T19:02:28  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15601: build: depends: Switch to python3 (take 3) (master...1903-buildPy3) https://github.com/bitcoin/bitcoin/pull/15601
2722019-03-14T19:02:33  <meshcollider> hi
2732019-03-14T19:02:37  <kanzure> mailing list still in flux, no updates really
2742019-03-14T19:02:38  <jamesob> hi
2752019-03-14T19:02:41  *** bitcoin-git has left #bitcoin-core-dev
2762019-03-14T19:02:43  <sipa> hi
2772019-03-14T19:02:57  <moneyball> 4 straight weeks no #proposedmeetingtopics :)
2782019-03-14T19:03:11  <wumpus> thanks moneyball
2792019-03-14T19:03:16  <wumpus> #topic high priority for review
2802019-03-14T19:03:30  <instagibbs> I'd like #15557 to get in that list
2812019-03-14T19:03:33  <gribble> https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub
2822019-03-14T19:03:41  <instagibbs> preferably before next fee event ;P
2832019-03-14T19:03:41  <wumpus> https://github.com/bitcoin/bitcoin/projects/8 three PRs on here #15141 #10973 #14856
2842019-03-14T19:03:49  <gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
2852019-03-14T19:03:50  <wumpus> instagibbs: ok
2862019-03-14T19:03:55  <gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
2872019-03-14T19:03:57  <gribble> https://github.com/bitcoin/bitcoin/issues/14856 | net: remove more CConnman globals (theuni) by dongcarl · Pull Request #14856 · bitcoin/bitcoin · GitHub
2882019-03-14T19:04:17  <wumpus> instagibbs: added
2892019-03-14T19:04:24  <achow101> #15006 for me pls
2902019-03-14T19:04:28  <gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
2912019-03-14T19:04:37  <cfields> I for sure owe review on 14856. Will do today.
2922019-03-14T19:05:03  <wumpus> cfields: thanks !
2932019-03-14T19:05:19  <jonasschnelli> hi
2942019-03-14T19:06:00  <jonasschnelli> Can I add #15512 to the high prio list?
2952019-03-14T19:06:02  <gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
2962019-03-14T19:06:12  <jonasschnelli> (if we are fine with adding crypto primitives)
2972019-03-14T19:06:38  <wumpus> jonasschnelli: yes
2982019-03-14T19:06:59  <wumpus> at least if there's concept ACK agreement to add it
2992019-03-14T19:07:33  <jonasschnelli> Okay... added to the list. So waiting for Concept reviews
3002019-03-14T19:09:03  <wumpus> other topics?
3012019-03-14T19:09:43  <sipa> instagibbs had a topic
3022019-03-14T19:09:53  <gmaxwell> RC2 is tagged. hurrah
3032019-03-14T19:10:20  <instagibbs> any "needs" for 0.18 being the topic, in other words
3042019-03-14T19:10:28  <wumpus> #topic 0.18.0rc2
3052019-03-14T19:10:41  <wumpus> it's not tagged yet but intend to do so after the meeting, if no one complains
3062019-03-14T19:10:53  <gmaxwell> oh. :P
3072019-03-14T19:11:09  <gmaxwell> Well great, that would be a good time for people to start building too, I guess?
3082019-03-14T19:11:24  <instagibbs> as an aside I think HWI is near 1.0, 1 open issue right achow101 ?
3092019-03-14T19:11:31  *** F1nny has joined #bitcoin-core-dev
3102019-03-14T19:11:41  <sipa> i'm a bit surprised by the amount of people (claiming to) use the reject message on the ML... should we proceed with making it default off in 0.18?
3112019-03-14T19:11:43  *** promag has joined #bitcoin-core-dev
3122019-03-14T19:11:48  <achow101> instagibbs: yeah, just one thing needs review
3132019-03-14T19:11:59  <wumpus> #topic reject message default
3142019-03-14T19:12:13  <wumpus> sipa: I've alwys been divided on removing it to be honest
3152019-03-14T19:12:28  <sipa> i would very much like to disappear, but my assumption was that it was much less used than people are claiming now
3162019-03-14T19:12:29  <gmaxwell> The comments on the list have, once you sort through the speculative claims, all been "I use it for debugging"
3172019-03-14T19:12:45  <wumpus> that makes sense, that's what it's for
3182019-03-14T19:13:04  <gmaxwell> I'm still confused by those however, -- because is it also "I want to debug a lite wallet without running a full node myself?"
3192019-03-14T19:13:06  <wumpus> then again disabling it by default wouldn't affect that use case, just make sure it's enabled on the node used for debugging
3202019-03-14T19:13:12  <gmaxwell> Right.
3212019-03-14T19:13:14  <instagibbs> right I don't really get it.
3222019-03-14T19:13:21  <instagibbs> have a full node for debugging?!?
3232019-03-14T19:13:26  <gmaxwell> I think its unfortunate that that this has come up in the context of removing it entirely.
3242019-03-14T19:13:33  <achow101> gmaxwell: istm it's debugging user submitted bug reports, not the developer debugging his own app
3252019-03-14T19:13:49  <sipa> yeah that's the case in the schildbach wallet
3262019-03-14T19:13:51  <promag> hi
3272019-03-14T19:14:25  <MarcoFalke> the neutrino wallet is using them as well, apparently
3282019-03-14T19:14:27  *** F1nny is now known as Guest79138
3292019-03-14T19:14:27  *** Hazey1111 has joined #bitcoin-core-dev
3302019-03-14T19:14:27  *** Guest79138 has quit IRC
3312019-03-14T19:14:27  *** Hazey1111 is now known as F1nny
3322019-03-14T19:14:36  <gmaxwell> achow101: Yes, but capturing the transaction itself would seem to be strictly superior for that.
3332019-03-14T19:14:59  *** pinheadmz has quit IRC
3342019-03-14T19:15:00  <gmaxwell> MarcoFalke: along with a bunch of other assumptions about trusting the nodes its communicating with.
3352019-03-14T19:15:24  <gmaxwell> Which is already a security model we've made a conscious decision to not add support for.
3362019-03-14T19:15:46  <gmaxwell> MarcoFalke: and clearly not using them with existing nodes, since they require other protocol extensions.
3372019-03-14T19:15:47  <achow101> gmaxwell: certainly. but at the same time, having the reject message can provide better ux as the user can see why their transaction was rejected (in theory)
3382019-03-14T19:15:48  <MarcoFalke> They way one wallet makes it trustworthy is to send the tx to all nodes and see if at least half of them report the same reject reason
3392019-03-14T19:16:00  <gmaxwell> MarcoFalke: that doesn't make it trustworthy.
3402019-03-14T19:16:23  <MarcoFalke> Yeah, I am not going to start to explain what is wrong with that, even
3412019-03-14T19:16:31  <gmaxwell> Right...
3422019-03-14T19:16:41  <sipa> i'm just bringing it up because i think this ML discussion should have happened before making it disabled by default, rather than before removing it entirely
3432019-03-14T19:16:56  <MarcoFalke> sipa: You are right
3442019-03-14T19:17:16  <MarcoFalke> It is sort of pointless to make them disabled by default, but then not remove them
3452019-03-14T19:17:23  <moneyball> agree with sipa
3462019-03-14T19:17:29  *** pinheadmz has joined #bitcoin-core-dev
3472019-03-14T19:17:57  <MarcoFalke> So they should probably be enabled by default again for now. Not sure if that makes it into 0.18.0
3482019-03-14T19:18:01  <jnewbery> it's not too late to revert #13134
3492019-03-14T19:18:03  <gribble> https://github.com/bitcoin/bitcoin/issues/13134 | net: Add option `-enablebip61` to configure sending of BIP61 notifications by laanwj · Pull Request #13134 · bitcoin/bitcoin · GitHub
3502019-03-14T19:18:08  <jnewbery> or just change the default to 0
3512019-03-14T19:18:13  <gmaxwell> It was covered in the optech newsletter, but I don't see a prior ML discussion of it.
3522019-03-14T19:18:25  <MarcoFalke> yeah, just change the default
3532019-03-14T19:18:31  <MarcoFalke> No need to remove the option
3542019-03-14T19:18:32  <gmaxwell> MarcoFalke: it's not pointless to disable them by default but not remove them.
3552019-03-14T19:18:43  <gmaxwell> MarcoFalke: they're a source of a non-trivial amount of junk protocol chatter.
3562019-03-14T19:18:53  <gmaxwell> MarcoFalke: and the reliance on them creates its own problems.
3572019-03-14T19:18:54  *** Hazey1111 has joined #bitcoin-core-dev
3582019-03-14T19:19:00  *** Hazey1111 has quit IRC
3592019-03-14T19:19:00  <jnewbery> sorry, I mean revert #14054
3602019-03-14T19:19:02  <gribble> https://github.com/bitcoin/bitcoin/issues/14054 | p2p: Disable BIP 61 by default by MarcoFalke · Pull Request #14054 · bitcoin/bitcoin · GitHub
3612019-03-14T19:19:02  <gmaxwell> (including incentives to sybil attack the network)
3622019-03-14T19:19:37  *** F1nny has quit IRC
3632019-03-14T19:20:06  <MarcoFalke> In light of the spv wallets that use them, default by off is the same as having them removed
3642019-03-14T19:20:07  <sipa> ideally we can convince people to switch to more reliable methods before disabling support for it
3652019-03-14T19:20:12  <gmaxwell> I don't see anything terrible about delaying disabling it. But I am also not sure what is going to change.
3662019-03-14T19:20:18  <gmaxwell> sipa: there isn't anything to switch.
3672019-03-14T19:20:36  *** F1nny has joined #bitcoin-core-dev
3682019-03-14T19:20:40  <gmaxwell> sipa: the two respondands saying they're using it (1) only log it, (2) don't work against bitcoin core already.
3692019-03-14T19:20:52  <sipa> gmaxwell: ?
3702019-03-14T19:21:32  <gmaxwell> sipa: android wallet doesn't actually do anything with the messages but log them, the neutrino wallet requires protocol extensions that are only in btcd.
3712019-03-14T19:21:44  <sipa> right, for now
3722019-03-14T19:21:55  <gmaxwell> so whats there to switch?
3732019-03-14T19:22:02  <sipa> ou suggested logging the tx itself instead of the reject message, for example
3742019-03-14T19:22:12  <gmaxwell> Okay, fair point!
3752019-03-14T19:22:27  <sipa> plus there are other methods like seeing transactions announced back to yourself (okay, not very reliable either)
3762019-03-14T19:22:54  <sipa> i just wish this discussion was more resolved before we possibly anger people needlessly by ripping something out they stubbornly rely on now
3772019-03-14T19:23:11  <gmaxwell> sipa: one client does that but sends their txn to all peers :) ...
3782019-03-14T19:23:20  <gmaxwell> 12:20:11 < gmaxwell> I don't see anything terrible about delaying disabling it. But I am also not sure what is going to change.
3792019-03-14T19:23:30  <jnewbery> sounds like the action item is to revert #14054 before 0.18
3802019-03-14T19:23:32  <gribble> https://github.com/bitcoin/bitcoin/issues/14054 | p2p: Disable BIP 61 by default by MarcoFalke · Pull Request #14054 · bitcoin/bitcoin · GitHub
3812019-03-14T19:23:35  <sipa> yeah, it's a fair point that delaying may just literally mean delaying it
3822019-03-14T19:23:47  <sipa> but perhaps it does resolve the discussion further
3832019-03-14T19:24:03  <gmaxwell> I think we should probably make it clear that we still intend to disable it by default.
3842019-03-14T19:24:20  <MarcoFalke> jnewbery: I am fine with that, but I hope that doesn't give a signal that they are encouraged
3852019-03-14T19:24:27  <MarcoFalke> They should still go in the long term
3862019-03-14T19:24:32  <sipa> agree
3872019-03-14T19:24:40  <gmaxwell> I mean I think it was clear years ago that these shouldn't be used the way people are advocating using them... like on day one.
3882019-03-14T19:24:54  <sipa> i doubt that was clear to everyone :)
3892019-03-14T19:25:01  <cfields> Hasn't our unwritten policy always been to deprecate in one release, and non-default/remove in the next?
3902019-03-14T19:25:30  <MarcoFalke> cfields: I tried to do that, but apparently people only picked up on this when I wanted to remove them
3912019-03-14T19:25:35  <sipa> cfields: for RPC that works... for P2P services it's harder
3922019-03-14T19:25:48  <jnewbery> That's easier for RPCs because deprecation is immediately obvious to the user
3932019-03-14T19:25:50  <gmaxwell> some of the things people are reporting doing with them haven't worked right for a long time (or ever)... (like trying to differentiate between already spent and other causes of invalidity)
3942019-03-14T19:26:05  <moneyball> It would also help to better educate what they should do as an alternative. My reading of the thread still has me uncertain, and they also do not seem to know what to do.
3952019-03-14T19:26:21  <gmaxwell> Actually disabling it in a release has that effect somewhat, as it'll be years before it's gone completely on the network.
3962019-03-14T19:26:26  <cfields> sipa: I just meant that if it's going to be non-defaulted in one version, seems only fair to put it through a deprecation cycle in the preceding one.
3972019-03-14T19:26:48  <jnewbery> how do you deprecate a P2P message in a way that users notice?
3982019-03-14T19:26:49  *** shesek has quit IRC
3992019-03-14T19:26:50  <moneyball> Good next steps IMO would be 1) revert in v0.18 2) communicate this to the list but also emphasize the long-term plan 3) educate on alternatives for these users
4002019-03-14T19:26:51  <sipa> cfields: right, but what does 'deprecation' mean here? if it's not disabled by default, it's not even observable
4012019-03-14T19:26:56  <gwillen> cfields: but I think sipa's point is that deprecation doesn't notify the people who care
4022019-03-14T19:27:07  <gmaxwell> moneyball: to some extent what wants to be done just can't be done, even with rejects. You can't find out if the network is taking your transaction, it's just not something anyone can tell.
4032019-03-14T19:27:19  <cfields> Just in the release notes.. we intend to flip this to disabled-by-default in the next release.
4042019-03-14T19:27:28  <sipa> cfields: sgtm
4052019-03-14T19:27:37  <cfields> that's all I meant by "deprecate".
4062019-03-14T19:27:40  <gmaxwell> cfields: ack.
4072019-03-14T19:27:42  <wumpus> so I guess this does hold up rc2 tagging then
4082019-03-14T19:27:59  <jnewbery> I'm happy to open that PR now, unless MarcoFalke wants it
4092019-03-14T19:28:06  <MarcoFalke> jnewbery: go for it
4102019-03-14T19:28:07  <gmaxwell> jnewbery: go do it.
4112019-03-14T19:28:22  <jnewbery> I'll do it today
4122019-03-14T19:28:28  <provoostenator> You can make it noticable by always returning reject :-)
4132019-03-14T19:28:37  <gmaxwell> lol
4142019-03-14T19:28:46  <gmaxwell> provoostenator: nope, in fact.
4152019-03-14T19:28:53  <sipa> reject 00 "The operation completed succesfully"
4162019-03-14T19:29:02  <gmaxwell> provoostenator: because reject isn't doing anything in existing software except ending up burried in some logs.
4172019-03-14T19:29:20  <gmaxwell> so even that would be hit or miss.
4182019-03-14T19:30:21  <sipa> https://www.medo64.com/content/media/errortheoperationcompletedsuccessfully.png
4192019-03-14T19:31:19  <achow101> what's the long term plan for removal? default disable in 0.19, remove in 0.20?
4202019-03-14T19:31:24  <gwillen> I think starting mailing list discussion of what the alternatives are, and getting moneyball to spread it in the newsletter, is probably the best way to spread the good word :-)
4212019-03-14T19:31:32  <MarcoFalke> achow101: Something like that
4222019-03-14T19:31:56  <MarcoFalke> [15:26] <moneyball> Good next steps IMO would be 1) revert in v0.18 2) communicate this to the list but also emphasize the long-term plan 3) educate on alternatives for these users
4232019-03-14T19:32:08  <gmaxwell> gwillen: right, what I would recommend for these logging cases is that they log the transaction and current block height.
4242019-03-14T19:32:40  <MarcoFalke> gmaxwell: you mean the full tx in hex?
4252019-03-14T19:32:56  <sipa> base85 FTW
4262019-03-14T19:32:57  <moneyball> fyi harding referred to the PR commit in the sep 18 newsletter https://bitcoinops.org/en/newsletters/2018/09/18/
4272019-03-14T19:33:04  <cfields> MarcoFalke: where do I point my DoS? :)
4282019-03-14T19:33:10  <moneyball> and the discussion that marco started in the mar 12 newsletter https://bitcoinops.org/en/newsletters/2019/03/12/
4292019-03-14T19:33:16  <gmaxwell> MarcoFalke: whatever is required for them to be able to reproduce! in some applications it might be less than the full tx.
4302019-03-14T19:33:26  <gmaxwell> cfields: you're misunderstanding, the wallet should log its own transaction.
4312019-03-14T19:33:27  *** Dean_Guss has quit IRC
4322019-03-14T19:33:37  <MarcoFalke> Yeah, its only the own wallets txs
4332019-03-14T19:33:42  <cfields> gmaxwell: I was, thanks.
4342019-03-14T19:33:54  <gmaxwell> MarcoFalke: e.g. if the wallet always stores the tx like bitcoin core, the current block and txid are enough.
4352019-03-14T19:34:45  <gmaxwell> cfields: basically the debugging case is "User says my transaction was never confirming" ... what do you do?  Andreas is pointing out that reject messages have been helpful.
4362019-03-14T19:35:31  <gmaxwell> Another thing is that I see no feefilter support in that software... so obviously processing feefilters would allow them to locally learn about some of the failure cases they care about.
4372019-03-14T19:36:51  <gmaxwell> right now reject basically only tells you didn't meet minfee vs "something else happened at the first hop", feefilter + listen to hear it back gets you essentially that, but more reliable.
4382019-03-14T19:37:03  *** vexbuy has quit IRC
4392019-03-14T19:37:15  <sipa> gmaxwell: though feefilter can't be relied upon either in an adverserial setting
4402019-03-14T19:37:26  <sipa> it is less DoS risk though
4412019-03-14T19:37:29  <gmaxwell> sipa: no but it's probably better than reject messages.
4422019-03-14T19:38:23  <gmaxwell> esp if you obey it, e.g. don't send a txn that would violate the filter to a particular peer.
4432019-03-14T19:40:03  <sipa> end topic?
4442019-03-14T19:40:17  <gmaxwell> ack
4452019-03-14T19:40:18  <wumpus> other topics?
4462019-03-14T19:40:57  <wumpus> #endmeeting
4472019-03-14T19:40:57  <lightningbot> Meeting ended Thu Mar 14 19:40:57 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4482019-03-14T19:40:57  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-03-14-19.00.html
4492019-03-14T19:40:57  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-03-14-19.00.txt
4502019-03-14T19:40:57  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-03-14-19.00.log.html
4512019-03-14T19:41:06  <sipa> #lunch
4522019-03-14T19:41:08  <gmaxwell> [outside of meeting now]
4532019-03-14T19:41:50  <gmaxwell> Can someone explain this tweet people were passing around? https://twitter.com/pierre_rochard/status/1104785795523719169   I don't understand how fullblock spv mode and the BIP157 related PRs are at all compariable/substutiable for each other.
4542019-03-14T19:42:27  *** F1nny_ has joined #bitcoin-core-dev
4552019-03-14T19:42:51  *** F1nny has quit IRC
4562019-03-14T19:42:52  *** F1nny_ is now known as F1nny
4572019-03-14T19:42:55  <gmaxwell> (someone in #bitcoin tried asking me my opinion about that debate earlier, and I thought it would be nice to actually understand it before responding...)
4582019-03-14T19:42:59  *** bitcoin-git has joined #bitcoin-core-dev
4592019-03-14T19:43:00  <bitcoin-git> [bitcoin] jnewbery opened pull request #15602: [p2] Enable reject messages by default (0.18...reject_message_by_default) https://github.com/bitcoin/bitcoin/pull/15602
4602019-03-14T19:43:02  *** bitcoin-git has left #bitcoin-core-dev
4612019-03-14T19:44:51  *** F1nny is now known as Guest40521
4622019-03-14T19:44:52  *** F1nny_ has joined #bitcoin-core-dev
4632019-03-14T19:44:52  *** Guest40521 has quit IRC
4642019-03-14T19:44:52  *** F1nny_ is now known as F1nny
4652019-03-14T19:45:15  <moneyball> My understanding is that pierre_rochard is focused on onboarding new Bitcoin users via Lightning (with his Lightning Powered Users), and he would like as many of them as possible to run full nodes, but he wants them to be able to use Bitcoin immediately so wants to support BIP157 style light clients. He's also saying if Core doesn't merge support for BIP157, he'd maintain a version of Core with it merged, and run
4662019-03-14T19:45:16  <moneyball> it himself to support his users
4672019-03-14T19:45:21  <harding> gmaxwell: pierre_rochard maintains an installer that installs Bitcoin Core, LND, and a LN wallet that's capable of using BIP157/158.  I think his desire is to allow people to immediately start using LND and the LN wallet using BIP157 filters served from his node while their Bitcoin Core node syncs.  That is, I don't think he's talking about hybrid SPV in Bitcoin Core by hybrid SPV via LND/Neutrino/some other wallet.
4682019-03-14T19:45:27  *** promag has quit IRC
4692019-03-14T19:45:59  <harding> s/by hybrid/but hybrid/
4702019-03-14T19:46:37  <gmaxwell> harding: for that sort of thing, just fetching the blocks seems completely reasonable even ideal..
4712019-03-14T19:46:48  <provoostenator> harding: that seems a plausible interpretation
4722019-03-14T19:47:08  <harding> gmaxwell: I agree.
4732019-03-14T19:47:24  <gmaxwell> So then I guess the confusion there would be that what he'd really want as the alternative is 'hybrid spv mode' in the ln wallet?  not in bitcoin core.
4742019-03-14T19:47:53  <sipa> only partially related, i think there is a lot of confusion about what "bip157" means; there is (a) the spec, allowing software to implement the filters in a private protocol like wasabi does (b) support for it in bitcoin core via RPC (what the current PRs do) (c) exposing it in core and other software via P2P for trusting peers to use (d) exposing it in core via P2P for non-trusting peers (e) a
4752019-03-14T19:47:59  <sipa> softfork to prevent non-trusting peers from...
4762019-03-14T19:48:02  <sipa> lying about filters (assuming trust in hashrate majority)
4772019-03-14T19:48:14  <gmaxwell> indeed.
4782019-03-14T19:48:38  <sipa> there seems to be a lot of antagonism on twitter against (d)
4792019-03-14T19:48:54  *** F1nny has quit IRC
4802019-03-14T19:49:05  *** F1nny has joined #bitcoin-core-dev
4812019-03-14T19:49:26  <gmaxwell> I'm not really aware of the twitter stuff (other than having been given that link) ... but my thought for many months is that I'm super excited about having the filters to make rescans usable again... and super concerned about them starting a new wave of bip37 like wallets that just blindly trust things.
4822019-03-14T19:49:28  <harding> gmaxwell: AFAIU, he just wants some way for people to start using an LN wallet in the SPV trust model while their node syncs.  I'm not sure he cares how it happens.  I myself don't know why BIP157/158 is entangled in this, except that he might think it's necessary to accomplish that.
4832019-03-14T19:49:33  <echeveria> sipa: (f) using it for wallet rescans.
4842019-03-14T19:49:55  <sipa> echeveria: good point; i'd put it under (b) as trust model, but agree
4852019-03-14T19:50:01  <echeveria> (f) ii. using it for wallet rescans while pruned.
4862019-03-14T19:50:12  *** promag has joined #bitcoin-core-dev
4872019-03-14T19:50:42  <gmaxwell> harding: yea okay, I'd even say BIP157/158 is a pretty weak way to accomplish that particular case. ... deploying a new protocol would take a lot of time in the best case, while just fetching the blocks works now against the existing network.
4882019-03-14T19:50:44  <harding> I've been trying to use "BIP157" for the filters themselves and "BIP158" for the P2P parts, but it's not always that clearcut.
4892019-03-14T19:51:23  <sipa> harding: it's the other way around :p
4902019-03-14T19:51:34  <gmaxwell> Fetchign the blocks has better security/reliablity properties. It uses more bandwidth, but that doesn't seem terribly important in the "while the user's node syncs" case.
4912019-03-14T19:51:56  <harding> gmaxwell: yeah, and any client that supports BIP157 must, by necessity, also support grabbing and parsing full blocks anyway, so supporting grabbing all blocks after a certain height ought to be a trivial addition.
4922019-03-14T19:52:09  <harding> sipa: is it really?  /me facepalms
4932019-03-14T19:52:13  <gmaxwell> the bandwidth usage isn't even all that great if you're also just talking about now-forward and not the history. (14kbit/sec whoppie)
4942019-03-14T19:52:43  <sipa> harding: yeah 158 defines the filters, 157 is the p2p protocol to expose it
4952019-03-14T19:54:36  <gmaxwell> echeveria: (f) ii. -- thats cute.
4962019-03-14T19:55:14  <gmaxwell> being able to rescan with a pruned wallet would be pretty nice... though carring around the filters is a pretty big hit on top of pruning (2x disk space usage maybe?)
4972019-03-14T19:56:10  <gmaxwell> probably worth it, just because a lot more users could prune, which is becoming increasingly critical as the history is now getting larger than the most popular SSD sizes.
4982019-03-14T19:56:40  <sipa> iirc the filters are around 20 KiB per block?
4992019-03-14T19:57:13  <gmaxwell> they're smaller for earlier blocks, but not as much smaller as the blocks are.
5002019-03-14T19:57:22  *** keymone has quit IRC
5012019-03-14T19:58:53  <echeveria> gmaxwell: one PR has a comment that it's about 10GB today.
5022019-03-14T19:59:23  <gmaxwell> ouch, a bit worse than I thought.
5032019-03-14T19:59:26  <echeveria> so pruned would be 10GB + 3GB UTXO + 0.6GB blocks, but allows wallet rescan.
5042019-03-14T19:59:35  <gmaxwell> yeah....
5052019-03-14T19:59:39  <instagibbs> this is where commitments would help i guess
5062019-03-14T19:59:49  <gmaxwell> instagibbs: I don't think so, actually.
5072019-03-14T20:00:04  <instagibbs> oh?
5082019-03-14T20:00:11  <echeveria> unpruned would be 10GB + 220GB, so a 5% hit for significantly faster imports.
5092019-03-14T20:00:13  <gmaxwell> I mean, having to fetch 10GB+growing of data every time you want to rescan isn't really "recan supported" :P
5102019-03-14T20:00:22  <instagibbs> oh hah right
5112019-03-14T20:00:32  <instagibbs> well, you could forget filters on a rolling basis
5122019-03-14T20:00:38  <instagibbs> but i guess the same logic applies
5132019-03-14T20:00:43  <instagibbs> for just redownloading them :)
5142019-03-14T20:00:59  <gmaxwell> yes, though we've not yet really figured out how to make time windowed rescan work well for people.
5152019-03-14T20:01:38  *** bitcoin-git has joined #bitcoin-core-dev
5162019-03-14T20:01:38  <bitcoin-git> [bitcoin] gwillen opened pull request #15603: docs: Add more tips to productivity.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15603
5172019-03-14T20:01:39  *** bitcoin-git has left #bitcoin-core-dev
5182019-03-14T20:01:42  <gmaxwell> instagibbs: if "rescan by fetching 10gb" is okay, then probably rescan via PIR query would be better.
5192019-03-14T20:01:50  <instagibbs> for me I just want for wallet rescan...
5202019-03-14T20:02:33  <gmaxwell> likewise. having an extra 10GB on top of 220GB that makes rescan usable is well worth it.
5212019-03-14T20:02:56  <gmaxwell> (well it was more well worth it when I thought it was 3gb. :P)
5222019-03-14T20:03:16  <jonasschnelli> do you need all filters?
5232019-03-14T20:03:27  <gmaxwell> now actually on the host I most frequently use, I wouldn't acutally have room for that.
5242019-03-14T20:03:51  <gmaxwell> oh is the 10gb more than just the output filter? the output filter is the only one I think is at all useful.
5252019-03-14T20:04:07  *** keymone has joined #bitcoin-core-dev
5262019-03-14T20:05:54  *** F1nny_ has joined #bitcoin-core-dev
5272019-03-14T20:06:11  *** F1nny is now known as Guest57196
5282019-03-14T20:06:12  *** F1nny_ is now known as F1nny
5292019-03-14T20:07:15  <instagibbs> what's the PR for 158(7?)
5302019-03-14T20:08:02  <jonasschnelli> #14121
5312019-03-14T20:08:05  <gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
5322019-03-14T20:08:25  <sipa> it should be called BIP158, there is no p2p protocol support in there :)
5332019-03-14T20:08:41  <jonasschnelli> indeed
5342019-03-14T20:09:06  <jonasschnelli> "Total index size is 3.8 GiB"... echeveria: where did you get the 10GB from?
5352019-03-14T20:09:12  *** keymone has quit IRC
5362019-03-14T20:17:24  *** dgenr8 has quit IRC
5372019-03-14T20:18:02  *** keymone has joined #bitcoin-core-dev
5382019-03-14T20:22:41  <echeveria> jonasschnelli: misreading, apparently.
5392019-03-14T20:22:58  <echeveria> gmaxwell: sipa: looks better with 3.8GB. same size as the UTXO give or take.
5402019-03-14T20:23:34  <gmaxwell> echeveria: yeah, for the moment.. 2x. not terrible.
5412019-03-14T20:24:49  *** Damiano_ has joined #bitcoin-core-dev
5422019-03-14T20:28:42  *** Damiano_ has quit IRC
5432019-03-14T20:31:32  *** shesek has joined #bitcoin-core-dev
5442019-03-14T20:31:32  *** shesek has joined #bitcoin-core-dev
5452019-03-14T20:32:05  *** obsrver has joined #bitcoin-core-dev
5462019-03-14T20:34:27  *** promag has quit IRC
5472019-03-14T20:38:02  *** dgenr8 has joined #bitcoin-core-dev
5482019-03-14T20:42:01  *** mmgen has quit IRC
5492019-03-14T20:42:03  *** tripleslash has joined #bitcoin-core-dev
5502019-03-14T20:43:49  *** F1nny_ has joined #bitcoin-core-dev
5512019-03-14T20:45:29  <roasbeef> i think in that tweet pierre is just saying that if bitcoind doesn't get fully p2p support eventually, he'd maintain a fork that implemented it, as earlier in the thread ppl proposed full block download as an alternative
5522019-03-14T20:46:07  *** F1nny has quit IRC
5532019-03-14T20:46:22  *** bitcoin-git has joined #bitcoin-core-dev
5542019-03-14T20:46:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/889af0eaacd9...d3a038200709
5552019-03-14T20:46:23  <bitcoin-git> bitcoin/0.18 da14d90 John Newbery: [p2p] Enable BIP 61 REJECT messages by default
5562019-03-14T20:46:24  <bitcoin-git> bitcoin/0.18 a756363 John Newbery: [docs] document BIP 61 deprecation
5572019-03-14T20:46:24  <bitcoin-git> bitcoin/0.18 d3a0382 MarcoFalke: Merge #15602: 0.18: [p2p] Enable reject messages by default
5582019-03-14T20:46:26  *** bitcoin-git has left #bitcoin-core-dev
5592019-03-14T20:46:42  *** bitcoin-git has joined #bitcoin-core-dev
5602019-03-14T20:46:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15602: 0.18: [p2p] Enable reject messages by default (0.18...reject_message_by_default) https://github.com/bitcoin/bitcoin/pull/15602
5612019-03-14T20:46:46  *** bitcoin-git has left #bitcoin-core-dev
5622019-03-14T20:59:14  *** Guyver2 has quit IRC
5632019-03-14T21:00:11  *** elichai2 has quit IRC
5642019-03-14T21:01:55  *** newbie2019258_ has quit IRC
5652019-03-14T21:04:34  *** bitcoin-git has joined #bitcoin-core-dev
5662019-03-14T21:04:35  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7fa1f6258c05...b83c6f79400f
5672019-03-14T21:04:35  <bitcoin-git> bitcoin/master bf12093 Sjors Provoost: [doc] productivity: fix broken link
5682019-03-14T21:04:36  <bitcoin-git> bitcoin/master 3a21905 Sjors Provoost: [doc] devtools: mention clang-format dependency
5692019-03-14T21:04:36  <bitcoin-git> bitcoin/master ff7f31e Sjors Provoost: [doc] productivity: more advanced git range-diff
5702019-03-14T21:04:37  *** bitcoin-git has left #bitcoin-core-dev
5712019-03-14T21:05:16  *** bitcoin-git has joined #bitcoin-core-dev
5722019-03-14T21:05:16  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15444: [docs] Additional productivity tips (master...2019/02/typo-productivity) https://github.com/bitcoin/bitcoin/pull/15444
5732019-03-14T21:05:17  *** bitcoin-git has left #bitcoin-core-dev
5742019-03-14T21:08:34  <pierre_rochard> gmaxwell: "for that sort of thing, just fetching the blocks seems completely reasonable even ideal.." agree, and c-lightning does that with spruned. This would work for LND as well, but ZMQ emulation needs to be added to spruned. I would get busy working on that, but I hear LND mainnet neutrino + btcd isn't far off.
5752019-03-14T21:10:06  <pierre_rochard> My activism for serving up filters with bitcoind is because I'd rather be running bitcoind than btcd, just for historical reasons
5762019-03-14T21:11:07  <pierre_rochard> "I think his desire is to allow people to immediately start using LND and the LN wallet using BIP157 filters served from his node while their Bitcoin Core node syncs."
5772019-03-14T21:11:10  <pierre_rochard> This is exactly right
5782019-03-14T21:12:32  <pierre_rochard> people who have to wait hours/days for IBD to be able to use LND often end up just taking the shortcut to a custodial lightning wallet. We can have both rapid onboarding and full nodes if we use a light client as a stopgap
5792019-03-14T21:20:51  <MarcoFalke> rc2 ready to tag?
5802019-03-14T21:30:13  *** jonatack has joined #bitcoin-core-dev
5812019-03-14T21:43:05  <achow101> provoostenator: what tests do you have that require importing private keys into the keypool?
5822019-03-14T21:43:22  <achow101> I would rather not add such a feature just so a test can work easier
5832019-03-14T21:43:53  *** webuser3254 has joined #bitcoin-core-dev
5842019-03-14T21:44:11  <webuser3254> hello, I have a question regarding pruned mode and importprivkey. I have just imported hundreds of privkeys from my electrum wallet to bitcoin gold core pruned wallet but I can't see any addresses or balances. I can't seem to be able to do rescan on pruned mode. Is there a way to see my balance or move ALL the coins to a new address?
5852019-03-14T21:44:26  *** F1nny__ has joined #bitcoin-core-dev
5862019-03-14T21:44:38  <webuser3254> I appologise for posting it here but I can't do it #bitcoin for some reason :/
5872019-03-14T21:45:00  <echeveria> what reason? the channel doesn't require registration.
5882019-03-14T21:45:15  <webuser3254> "Cannot send to nick/channel: #bitcoin"
5892019-03-14T21:45:58  <jimpo> sipa: The line between BIP 157 and 158 is kind of muddied, but the notion of filter types and a chain of headers is in 157. 158 is just the specification of the construction of the basic filter type.
5902019-03-14T21:46:38  <jimpo> Since the index supports multiple filter types (ish), I feel like it's more related to 157 than 158
5912019-03-14T21:46:52  *** F1nny_ has quit IRC
5922019-03-14T21:46:59  <sipa> jimpo: fair
5932019-03-14T21:47:18  <sipa> still, the actual filter is in 158
5942019-03-14T21:50:04  <jimpo> Eh, the data type corresponding to the BlockFilter struct is in 157 (the cfilter response)
5952019-03-14T21:50:48  <achow101> webuser3254: rescanning requires the full blockchain. if you are pruned, you don't have the full blockchain so you can't rescan. you could use scantxoutset to get all of the utxos for our private keys and then create a raw transaction using those
5962019-03-14T21:50:51  <jimpo> and the index PR only never does any encoding/decoding of the filter byte vector
5972019-03-14T21:51:22  <jimpo> but I agree it's kind of in the middle of the two
5982019-03-14T21:51:47  <sipa> yeah
5992019-03-14T21:57:51  *** ThomasLuong has joined #bitcoin-core-dev
6002019-03-14T21:58:58  <webuser3254> achow101, thank you but somehow craeting raw transaction sounds complicated to me right now... my bad again for spamming this channel.
6012019-03-14T21:59:05  <webuser3254> thanks for all the work guys!
6022019-03-14T22:01:55  *** obsrver has quit IRC
6032019-03-14T22:04:17  *** webuser3254 has quit IRC
6042019-03-14T22:07:54  *** F1nny_ has joined #bitcoin-core-dev
6052019-03-14T22:10:58  *** F1nny__ has quit IRC
6062019-03-14T22:14:00  *** cryptapus has quit IRC
6072019-03-14T22:22:36  *** hebasto has quit IRC
6082019-03-14T22:26:04  *** ThomasLuong has quit IRC
6092019-03-14T22:28:33  *** ap4lmtree has quit IRC
6102019-03-14T22:28:51  *** ap4lmtree has joined #bitcoin-core-dev
6112019-03-14T22:29:02  *** ctrlbreak_MAD is now known as ctrlbreak
6122019-03-14T22:32:18  *** ThomasLuong has joined #bitcoin-core-dev
6132019-03-14T22:34:52  *** ap4lmtree has quit IRC
6142019-03-14T22:36:51  *** ap4lmtree has joined #bitcoin-core-dev
6152019-03-14T22:41:19  *** spinza has quit IRC
6162019-03-14T22:44:01  *** promag has joined #bitcoin-core-dev
6172019-03-14T22:52:38  *** mol has joined #bitcoin-core-dev
6182019-03-14T22:53:02  *** mol is now known as Guest61154
6192019-03-14T22:53:51  *** spinza has joined #bitcoin-core-dev
6202019-03-14T22:56:57  *** Guest61154 has quit IRC
6212019-03-14T22:59:03  *** DeanGuss has joined #bitcoin-core-dev
6222019-03-14T23:05:49  *** makey40 has quit IRC
6232019-03-14T23:07:55  *** F1nny__ has joined #bitcoin-core-dev
6242019-03-14T23:10:35  *** F1nny_ has quit IRC
6252019-03-14T23:11:04  *** jarthur has quit IRC
6262019-03-14T23:11:17  *** promag has joined #bitcoin-core-dev
6272019-03-14T23:13:54  *** makey40 has joined #bitcoin-core-dev
6282019-03-14T23:15:45  *** luke-jr has quit IRC
6292019-03-14T23:16:59  *** makey40 has joined #bitcoin-core-dev
6302019-03-14T23:17:53  *** makey40 has quit IRC
6312019-03-14T23:19:57  *** luke-jr has joined #bitcoin-core-dev
6322019-03-14T23:20:29  *** luke-jr has quit IRC
6332019-03-14T23:20:46  *** bitcoin-git has joined #bitcoin-core-dev
6342019-03-14T23:20:46  <bitcoin-git> [bitcoin] jnewbery opened pull request #15604: [docs] release note for disabling reject messages by default (master...release_notes_bip61) https://github.com/bitcoin/bitcoin/pull/15604
6352019-03-14T23:20:48  *** bitcoin-git has left #bitcoin-core-dev
6362019-03-14T23:21:56  *** luke-jr has joined #bitcoin-core-dev
6372019-03-14T23:21:56  *** luke-jr has quit IRC
6382019-03-14T23:27:56  *** fanquake has joined #bitcoin-core-dev
6392019-03-14T23:31:11  *** ccdle12 has quit IRC
6402019-03-14T23:32:29  *** makey40 has joined #bitcoin-core-dev
6412019-03-14T23:36:13  *** luke-jr has joined #bitcoin-core-dev
6422019-03-14T23:37:49  *** luke-jr has joined #bitcoin-core-dev
6432019-03-14T23:39:06  *** luke-jr has joined #bitcoin-core-dev
6442019-03-14T23:43:19  *** F1nny_ has joined #bitcoin-core-dev
6452019-03-14T23:43:34  *** Victor_sueca has joined #bitcoin-core-dev
6462019-03-14T23:43:38  *** Victorsueca has quit IRC
6472019-03-14T23:44:07  *** F1nny_ has quit IRC
6482019-03-14T23:45:25  *** F1nny__ has quit IRC
6492019-03-14T23:45:29  *** makey40 has joined #bitcoin-core-dev
6502019-03-14T23:46:25  *** makey40 has quit IRC
6512019-03-14T23:47:06  *** luke-jr has quit IRC
6522019-03-14T23:47:57  *** luke-jr has joined #bitcoin-core-dev
6532019-03-14T23:50:43  *** lukedashjr has joined #bitcoin-core-dev
6542019-03-14T23:51:00  *** makey40 has joined #bitcoin-core-dev
6552019-03-14T23:51:05  *** lukedashjr has joined #bitcoin-core-dev
6562019-03-14T23:51:32  *** makey40 has quit IRC
6572019-03-14T23:52:08  *** luke-jr has quit IRC
6582019-03-14T23:53:08  *** luke-jr has joined #bitcoin-core-dev
6592019-03-14T23:53:54  *** luke-jr has joined #bitcoin-core-dev
6602019-03-14T23:56:44  *** makey40 has joined #bitcoin-core-dev
6612019-03-14T23:58:11  *** luke-jr has joined #bitcoin-core-dev
6622019-03-14T23:58:11  *** makey40 has quit IRC
6632019-03-14T23:58:39  *** luke-jr has quit IRC
6642019-03-14T23:59:03  *** makey40 has joined #bitcoin-core-dev