1 2019-03-18T00:02:50  *** promag has quit IRC
  2 2019-03-18T00:03:03  *** promag_ has quit IRC
  3 2019-03-18T00:28:38  *** AaronvanW has quit IRC
  4 2019-03-18T00:34:43  *** shesek has joined #bitcoin-core-dev
  5 2019-03-18T00:51:24  *** jonatack has quit IRC
  6 2019-03-18T00:54:21  *** promag has joined #bitcoin-core-dev
  7 2019-03-18T01:13:43  *** fanquake has quit IRC
  8 2019-03-18T01:18:19  *** belcher has joined #bitcoin-core-dev
  9 2019-03-18T01:19:59  *** zhangzf has joined #bitcoin-core-dev
 10 2019-03-18T01:26:27  *** harrymm has quit IRC
 11 2019-03-18T01:31:42  *** pinheadmz has quit IRC
 12 2019-03-18T01:35:22  *** fanquake has joined #bitcoin-core-dev
 13 2019-03-18T01:37:06  *** pinheadmz has joined #bitcoin-core-dev
 14 2019-03-18T01:51:10  *** AaronvanW has joined #bitcoin-core-dev
 15 2019-03-18T01:52:15  *** zhangzf_ has joined #bitcoin-core-dev
 16 2019-03-18T01:52:20  *** zhangzf has quit IRC
 17 2019-03-18T01:55:04  *** promag has quit IRC
 18 2019-03-18T01:55:45  *** promag has joined #bitcoin-core-dev
 19 2019-03-18T01:56:04  *** bitcoin-git has joined #bitcoin-core-dev
 20 2019-03-18T01:56:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15616: rpc: Remove hex from decodescript RPCResult doc (master...1903-rpcDocDecodeS) https://github.com/bitcoin/bitcoin/pull/15616
 21 2019-03-18T01:56:06  *** bitcoin-git has left #bitcoin-core-dev
 22 2019-03-18T02:12:48  *** promag has quit IRC
 23 2019-03-18T02:13:12  *** promag has joined #bitcoin-core-dev
 24 2019-03-18T02:29:00  *** e4xit has quit IRC
 25 2019-03-18T02:35:46  *** EagleTM has quit IRC
 26 2019-03-18T02:41:09  *** promag_ has joined #bitcoin-core-dev
 27 2019-03-18T02:41:09  *** promag has quit IRC
 28 2019-03-18T02:42:50  <warren> fanquake: btw why the alpine container to use guix? the entire point of using guix is to eliminate other non-deterministic tools, the container should be directly guix (and separately the contents of that container are verifiably determinstic)
 29 2019-03-18T02:44:25  *** justanotheruser has quit IRC
 30 2019-03-18T02:45:25  *** promag_ has quit IRC
 31 2019-03-18T02:50:39  <fanquake> warren It seemed like the easiest way to get started. As far as I'm aware I can't run/use guix natively on macOS, so I need the container to actually install/run guix inside. The simplest/smallest choice seemed to be Alpine. Very open to other suggestions if you have any.
 32 2019-03-18T02:50:55  <fanquake> Related guix on macOS discussion here: https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00111.html
 33 2019-03-18T02:52:37  *** justanotheruser has joined #bitcoin-core-dev
 34 2019-03-18T02:56:08  *** Zenton has joined #bitcoin-core-dev
 35 2019-03-18T03:06:18  *** pinheadmz has quit IRC
 36 2019-03-18T03:12:51  *** pinheadmz has joined #bitcoin-core-dev
 37 2019-03-18T03:22:06  *** promag has joined #bitcoin-core-dev
 38 2019-03-18T03:28:14  *** pinheadmz has quit IRC
 39 2019-03-18T03:31:47  *** pinheadmz has joined #bitcoin-core-dev
 40 2019-03-18T03:36:17  *** AaronvanW has quit IRC
 41 2019-03-18T03:44:24  *** fanquake_ has joined #bitcoin-core-dev
 42 2019-03-18T03:47:13  *** fanquake has quit IRC
 43 2019-03-18T03:50:54  *** DeanGuss has joined #bitcoin-core-dev
 44 2019-03-18T03:52:36  *** pinheadmz has quit IRC
 45 2019-03-18T04:17:01  <warren> fanquake_: I suppose it's good to have any working way for macos to additionally replicate the same build for bit-for-bit verification, but given that you rely on osx -> alpine -> guix that's a lot of non-deterministic stuff. I  think verifying determinism of the build environment can be done separately and less often (don't bother to bootstrap guix on a system that can't)
 46 2019-03-18T05:07:00  *** pinheadmz has joined #bitcoin-core-dev
 47 2019-03-18T05:07:35  *** bitcoin-git has joined #bitcoin-core-dev
 48 2019-03-18T05:07:35  <bitcoin-git> [bitcoin] sipa opened pull request #15617: Do not relay banned IP addresses (master...201903_nobannedrelay) https://github.com/bitcoin/bitcoin/pull/15617
 49 2019-03-18T05:07:36  *** bitcoin-git has left #bitcoin-core-dev
 50 2019-03-18T05:13:13  *** davec has quit IRC
 51 2019-03-18T05:15:00  *** davec has joined #bitcoin-core-dev
 52 2019-03-18T05:40:19  *** pinheadmz has quit IRC
 53 2019-03-18T05:48:47  *** pinheadmz has joined #bitcoin-core-dev
 54 2019-03-18T06:36:18  *** rex4539 has quit IRC
 55 2019-03-18T06:46:18  *** rex4539 has joined #bitcoin-core-dev
 56 2019-03-18T07:05:57  *** pinheadmz has quit IRC
 57 2019-03-18T07:13:45  *** DeanGuss has quit IRC
 58 2019-03-18T07:31:54  *** ccdle12 has quit IRC
 59 2019-03-18T07:34:39  *** ccdle12 has joined #bitcoin-core-dev
 60 2019-03-18T07:37:26  *** bitcoin-git has joined #bitcoin-core-dev
 61 2019-03-18T07:37:27  <bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/acbbb7bf0d45...7ec7aea44281
 62 2019-03-18T07:37:27  <bitcoin-git> bitcoin/master faf3698 Glenn Willen: wallet: Improve log output for errors during load
 63 2019-03-18T07:37:28  <bitcoin-git> bitcoin/master 7ec7aea MeshCollider: Merge #15491: wallet: Improve log output for errors during load
 64 2019-03-18T07:37:30  *** bitcoin-git has left #bitcoin-core-dev
 65 2019-03-18T07:38:07  *** bitcoin-git has joined #bitcoin-core-dev
 66 2019-03-18T07:38:07  <bitcoin-git> [bitcoin] MeshCollider merged pull request #15491: wallet: Improve log output for errors during load (master...feature-improve-wallet-load-debug-output) https://github.com/bitcoin/bitcoin/pull/15491
 67 2019-03-18T07:38:09  *** bitcoin-git has left #bitcoin-core-dev
 68 2019-03-18T07:39:42  *** lnostdal has quit IRC
 69 2019-03-18T07:41:07  *** ppisati has quit IRC
 70 2019-03-18T07:41:22  *** lnostdal has joined #bitcoin-core-dev
 71 2019-03-18T07:43:50  *** ppisati has joined #bitcoin-core-dev
 72 2019-03-18T07:55:51  *** jouke_ has quit IRC
 73 2019-03-18T08:14:16  *** spinza has quit IRC
 74 2019-03-18T08:15:28  *** luke-jr has quit IRC
 75 2019-03-18T08:19:13  *** luke-jr has joined #bitcoin-core-dev
 76 2019-03-18T08:35:39  *** DeanGuss has joined #bitcoin-core-dev
 77 2019-03-18T08:36:52  *** spinza has joined #bitcoin-core-dev
 78 2019-03-18T09:23:29  *** ccdle12 has quit IRC
 79 2019-03-18T09:24:41  *** ccdle12 has joined #bitcoin-core-dev
 80 2019-03-18T09:24:59  *** DeanGuss has quit IRC
 81 2019-03-18T09:25:35  *** DeanGuss has joined #bitcoin-core-dev
 82 2019-03-18T09:40:06  *** setpill has joined #bitcoin-core-dev
 83 2019-03-18T09:40:27  *** shesek has quit IRC
 84 2019-03-18T09:44:46  *** setpill has quit IRC
 85 2019-03-18T09:46:30  *** setpill has joined #bitcoin-core-dev
 86 2019-03-18T09:47:10  *** Guyver2 has joined #bitcoin-core-dev
 87 2019-03-18T09:51:43  *** promag_ has joined #bitcoin-core-dev
 88 2019-03-18T09:52:28  *** timothy has joined #bitcoin-core-dev
 89 2019-03-18T09:58:40  *** mmgen has joined #bitcoin-core-dev
 90 2019-03-18T10:09:09  *** TheCharlatan has quit IRC
 91 2019-03-18T10:12:31  *** shesek has joined #bitcoin-core-dev
 92 2019-03-18T10:20:40  *** promag_ has quit IRC
 93 2019-03-18T10:25:03  *** DeanGuss has quit IRC
 94 2019-03-18T10:25:40  *** DeanGuss has joined #bitcoin-core-dev
 95 2019-03-18T10:26:14  *** jungly has joined #bitcoin-core-dev
 96 2019-03-18T10:28:10  *** promag_ has joined #bitcoin-core-dev
 97 2019-03-18T10:31:24  *** ExtraCrispy has joined #bitcoin-core-dev
 98 2019-03-18T10:32:28  <wumpus> rc2 binaries up https://bitcoincore.org/bin/bitcoin-core-0.18.0/test.rc2/
 99 2019-03-18T10:41:03  *** promag_ has quit IRC
100 2019-03-18T10:42:39  *** ExtraCrispy has quit IRC
101 2019-03-18T10:43:52  *** promag_ has joined #bitcoin-core-dev
102 2019-03-18T10:45:46  *** DavidMitchell[m] has joined #bitcoin-core-dev
103 2019-03-18T10:45:58  *** promag_ has quit IRC
104 2019-03-18T10:47:52  *** spinza has quit IRC
105 2019-03-18T10:49:18  *** promag_ has joined #bitcoin-core-dev
106 2019-03-18T10:51:03  *** promag_ has quit IRC
107 2019-03-18T10:55:31  *** promag_ has joined #bitcoin-core-dev
108 2019-03-18T10:55:36  *** ExtraCrispy has joined #bitcoin-core-dev
109 2019-03-18T10:55:49  *** spinza has joined #bitcoin-core-dev
110 2019-03-18T10:57:24  *** zhangzf_ has quit IRC
111 2019-03-18T11:02:43  *** promag_ has quit IRC
112 2019-03-18T11:06:56  *** promag_ has joined #bitcoin-core-dev
113 2019-03-18T11:17:32  *** promag_ has quit IRC
114 2019-03-18T11:20:57  *** fanquake_ has quit IRC
115 2019-03-18T11:22:10  *** promag_ has joined #bitcoin-core-dev
116 2019-03-18T11:26:35  *** promag_ has quit IRC
117 2019-03-18T11:34:15  *** promag_ has joined #bitcoin-core-dev
118 2019-03-18T11:36:55  *** promag_ has quit IRC
119 2019-03-18T11:51:13  *** fanquake has joined #bitcoin-core-dev
120 2019-03-18T11:54:46  <fanquake> \o/
121 2019-03-18T11:55:08  <fanquake> provoostenator hope you don't mind, I've updated 15555 with the new link.
122 2019-03-18T11:56:56  *** promag_ has joined #bitcoin-core-dev
123 2019-03-18T12:01:52  *** promag_ has quit IRC
124 2019-03-18T12:08:18  *** DeanGuss has quit IRC
125 2019-03-18T12:08:33  *** DeanGuss has joined #bitcoin-core-dev
126 2019-03-18T12:14:24  *** AaronvanW has joined #bitcoin-core-dev
127 2019-03-18T12:56:35  *** zhangzf has joined #bitcoin-core-dev
128 2019-03-18T13:13:46  *** Aaronvan_ has joined #bitcoin-core-dev
129 2019-03-18T13:14:49  *** spaced0ut has joined #bitcoin-core-dev
130 2019-03-18T13:16:56  *** AaronvanW has quit IRC
131 2019-03-18T13:36:15  *** jonatack has joined #bitcoin-core-dev
132 2019-03-18T13:43:19  *** Emcy has quit IRC
133 2019-03-18T14:01:09  *** Emcy has joined #bitcoin-core-dev
134 2019-03-18T14:11:24  *** Emcy has quit IRC
135 2019-03-18T14:30:53  *** owowo has quit IRC
136 2019-03-18T14:33:45  *** muoitran has joined #bitcoin-core-dev
137 2019-03-18T14:42:08  <muoitran> Hi, I'm looking at the AcceptConnection() of the net.cpp and I notice that whenever there is a new incoming connection and nInbound >= nMaxInbound, likely one existing incoming connection will be evicted.
138 2019-03-18T14:43:45  <muoitran> Is this a bug or a design choice? Because doesn't this allow an adversary to evict some current legitimate incoming connections?
139 2019-03-18T14:57:13  *** pinheadmz has joined #bitcoin-core-dev
140 2019-03-18T14:57:45  <dongcarl> fanquake: Absolutely marvelous work with the Docker image! Will most likely get to test it out today.
141 2019-03-18T15:02:37  *** captjakk has joined #bitcoin-core-dev
142 2019-03-18T15:07:07  *** dqx_ has joined #bitcoin-core-dev
143 2019-03-18T15:08:05  *** pinheadmz has quit IRC
144 2019-03-18T15:25:20  *** _Sam-- has quit IRC
145 2019-03-18T15:26:17  *** _Sam-- has joined #bitcoin-core-dev
146 2019-03-18T15:27:56  *** bitcoin-git has joined #bitcoin-core-dev
147 2019-03-18T15:27:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7ec7aea44281...27781b6530c0
148 2019-03-18T15:27:57  <bitcoin-git> bitcoin/master 2e5d482 Steven Roose: tests: Print remaining jobs in test_runner.py
149 2019-03-18T15:27:58  <bitcoin-git> bitcoin/master 27781b6 MarcoFalke: Merge #15466: tests: Print remaining jobs in test_runner.py
150 2019-03-18T15:28:09  *** bitcoin-git has left #bitcoin-core-dev
151 2019-03-18T15:28:44  *** bitcoin-git has joined #bitcoin-core-dev
152 2019-03-18T15:28:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15466: tests: Print remaining jobs in test_runner.py (master...remaining-jobs) https://github.com/bitcoin/bitcoin/pull/15466
153 2019-03-18T15:28:47  *** bitcoin-git has left #bitcoin-core-dev
154 2019-03-18T15:30:56  *** setpill has quit IRC
155 2019-03-18T15:33:04  *** bitcoin-git has joined #bitcoin-core-dev
156 2019-03-18T15:33:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/27781b6530c0...2c336a9ccdf4
157 2019-03-18T15:33:06  <bitcoin-git> bitcoin/master 340ef50 Carl Dong: depends: Defer to Python detected by autoconf
158 2019-03-18T15:33:07  <bitcoin-git> bitcoin/master 89bee1b Carl Dong: depends: tar: Always extract as yourself
159 2019-03-18T15:33:08  <bitcoin-git> bitcoin/master f7696e6 Carl Dong: depends: qt: Don't hardcode pwd path
160 2019-03-18T15:33:10  *** bitcoin-git has left #bitcoin-core-dev
161 2019-03-18T15:33:46  *** bitcoin-git has joined #bitcoin-core-dev
162 2019-03-18T15:33:46  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15581: depends: Make less assumptions about build env (master...2019-03-true-neutral-depends) https://github.com/bitcoin/bitcoin/pull/15581
163 2019-03-18T15:33:49  *** bitcoin-git has left #bitcoin-core-dev
164 2019-03-18T15:35:48  *** promag_ has joined #bitcoin-core-dev
165 2019-03-18T15:35:48  *** promag has quit IRC
166 2019-03-18T15:37:35  *** promag has joined #bitcoin-core-dev
167 2019-03-18T15:37:35  *** promag_ has quit IRC
168 2019-03-18T15:41:47  *** jonatack has quit IRC
169 2019-03-18T15:42:40  *** mn949588 has quit IRC
170 2019-03-18T15:42:40  *** mn94958812 has quit IRC
171 2019-03-18T15:42:59  *** mn94958814 has joined #bitcoin-core-dev
172 2019-03-18T15:42:59  *** mn949588 has joined #bitcoin-core-dev
173 2019-03-18T15:47:34  *** MarcoFalke has quit IRC
174 2019-03-18T15:48:24  *** MarcoFalke has joined #bitcoin-core-dev
175 2019-03-18T15:50:18  *** cubancorona has quit IRC
176 2019-03-18T15:55:22  *** TheCharlatan has joined #bitcoin-core-dev
177 2019-03-18T16:02:39  *** StopAndDecrypt has quit IRC
178 2019-03-18T16:02:48  *** StopAndDecrypt_ has joined #bitcoin-core-dev
179 2019-03-18T16:03:08  *** pinheadmz has joined #bitcoin-core-dev
180 2019-03-18T16:03:57  *** pinheadmz has quit IRC
181 2019-03-18T16:04:43  *** pinheadmz has joined #bitcoin-core-dev
182 2019-03-18T16:07:00  *** StopAndDecrypt has joined #bitcoin-core-dev
183 2019-03-18T16:07:09  *** StopAndDecrypt has quit IRC
184 2019-03-18T16:07:09  *** StopAndDecrypt has joined #bitcoin-core-dev
185 2019-03-18T16:07:40  *** StopAndDecrypt_ has quit IRC
186 2019-03-18T16:11:45  *** StopAndDecrypt has quit IRC
187 2019-03-18T16:12:19  *** StopAndDecrypt has joined #bitcoin-core-dev
188 2019-03-18T16:12:28  *** StopAndDecrypt has quit IRC
189 2019-03-18T16:12:29  *** StopAndDecrypt has joined #bitcoin-core-dev
190 2019-03-18T16:16:02  *** zhangzf has quit IRC
191 2019-03-18T16:23:21  *** hebasto has joined #bitcoin-core-dev
192 2019-03-18T16:29:50  *** belcher has quit IRC
193 2019-03-18T16:32:21  *** muoitran has quit IRC
194 2019-03-18T16:34:46  *** muoitran has joined #bitcoin-core-dev
195 2019-03-18T16:54:50  *** promag has quit IRC
196 2019-03-18T16:57:20  *** promag has joined #bitcoin-core-dev
197 2019-03-18T17:01:48  *** instagibbs has quit IRC
198 2019-03-18T17:02:04  *** promag has quit IRC
199 2019-03-18T17:03:01  *** jarthur has joined #bitcoin-core-dev
200 2019-03-18T17:04:00  *** instagibbs has joined #bitcoin-core-dev
201 2019-03-18T17:09:11  *** jungly has quit IRC
202 2019-03-18T17:15:25  *** muoitran has quit IRC
203 2019-03-18T17:23:21  *** pinheadmz has quit IRC
204 2019-03-18T17:24:29  *** pinheadmz has joined #bitcoin-core-dev
205 2019-03-18T17:24:40  *** bitcoin-git has joined #bitcoin-core-dev
206 2019-03-18T17:24:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2c336a9ccdf4...c033c4b5cef8
207 2019-03-18T17:24:41  <bitcoin-git> bitcoin/master e5efacb Karl-Johan Alm: test: Refactor vout fetches in rpc_rawtransaction
208 2019-03-18T17:24:41  <bitcoin-git> bitcoin/master 6c0a6f7 Karl-Johan Alm: wallet/rpc: add maxfeerate parameter to sendrawtransaction
209 2019-03-18T17:24:42  <bitcoin-git> bitcoin/master 7abd2e6 Karl-Johan Alm: wallet/rpc: add maxfeerate parameter to testmempoolaccept
210 2019-03-18T17:24:43  *** bitcoin-git has left #bitcoin-core-dev
211 2019-03-18T17:25:00  *** bitcoin-git has joined #bitcoin-core-dev
212 2019-03-18T17:25:00  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #13541: wallet/rpc: sendrawtransaction maxfeerate (master...sendrawtransaction-maxfeerate) https://github.com/bitcoin/bitcoin/pull/13541
213 2019-03-18T17:25:12  *** bitcoin-git has left #bitcoin-core-dev
214 2019-03-18T17:33:25  *** bitcoin-git has joined #bitcoin-core-dev
215 2019-03-18T17:33:25  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15618: refactor: Remove unused function (master...1903-refRem) https://github.com/bitcoin/bitcoin/pull/15618
216 2019-03-18T17:33:30  *** bitcoin-git has left #bitcoin-core-dev
217 2019-03-18T17:33:56  <MarcoFalke> Sorry, I missed this during merge ^
218 2019-03-18T17:34:42  <MarcoFalke> sneaky attempt of kallewoof to get signet merged? hmm :)
219 2019-03-18T17:42:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
220 2019-03-18T17:43:04  *** Krellan has quit IRC
221 2019-03-18T17:43:32  *** Krellan has joined #bitcoin-core-dev
222 2019-03-18T17:47:26  *** Emcy has joined #bitcoin-core-dev
223 2019-03-18T17:48:00  *** jb55 has quit IRC
224 2019-03-18T17:48:30  *** Krellan has quit IRC
225 2019-03-18T17:57:08  *** promag has joined #bitcoin-core-dev
226 2019-03-18T18:03:18  *** bitcoin-git has joined #bitcoin-core-dev
227 2019-03-18T18:03:18  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15620: rpc: Uncouple rpcs from maxTxFee global (master...1903-rpcNoMaxTxFee) https://github.com/bitcoin/bitcoin/pull/15620
228 2019-03-18T18:03:20  *** bitcoin-git has left #bitcoin-core-dev
229 2019-03-18T18:14:03  *** Deebo_ has joined #bitcoin-core-dev
230 2019-03-18T18:15:19  *** jb55 has joined #bitcoin-core-dev
231 2019-03-18T18:18:59  *** owowo has joined #bitcoin-core-dev
232 2019-03-18T18:24:11  *** belcher has joined #bitcoin-core-dev
233 2019-03-18T18:24:50  *** promag has quit IRC
234 2019-03-18T18:26:40  *** spaced0ut has quit IRC
235 2019-03-18T18:27:23  *** Deebo_ has quit IRC
236 2019-03-18T18:30:26  <wumpus> MarcoFalke: ouch
237 2019-03-18T18:30:52  *** Emcy has quit IRC
238 2019-03-18T18:31:27  <wumpus> wallet/rpc should definitely not touch validation.cpp
239 2019-03-18T18:32:56  *** promag has joined #bitcoin-core-dev
240 2019-03-18T18:38:42  *** spaced0ut has joined #bitcoin-core-dev
241 2019-03-18T18:42:26  *** captjakk has quit IRC
242 2019-03-18T18:46:27  *** Aaronvan_ is now known as AaronvanW
243 2019-03-18T18:48:31  *** captjakk has joined #bitcoin-core-dev
244 2019-03-18T18:49:25  *** captjakk has quit IRC
245 2019-03-18T18:49:56  *** captjakk has joined #bitcoin-core-dev
246 2019-03-18T18:55:56  *** Krellan has joined #bitcoin-core-dev
247 2019-03-18T19:00:19  *** Krellan has quit IRC
248 2019-03-18T19:07:09  *** bitcoin-git has joined #bitcoin-core-dev
249 2019-03-18T19:07:09  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c033c4b5cef8...e45b7f20e651
250 2019-03-18T19:07:10  <bitcoin-git> bitcoin/master fa5c511 MarcoFalke: refactor: Remove unused function
251 2019-03-18T19:07:10  <bitcoin-git> bitcoin/master e45b7f2 Wladimir J. van der Laan: Merge #15618: refactor: Remove unused function
252 2019-03-18T19:07:19  *** bitcoin-git has left #bitcoin-core-dev
253 2019-03-18T19:07:57  *** bitcoin-git has joined #bitcoin-core-dev
254 2019-03-18T19:07:57  <bitcoin-git> [bitcoin] laanwj merged pull request #15618: refactor: Remove unused function (master...1903-refRem) https://github.com/bitcoin/bitcoin/pull/15618
255 2019-03-18T19:08:09  *** bitcoin-git has left #bitcoin-core-dev
256 2019-03-18T19:15:39  <MarcoFalke> Indeed
257 2019-03-18T19:15:58  <MarcoFalke> I will get my DrahtBot script to tag pull requests up and running
258 2019-03-18T19:17:39  <MarcoFalke> That script could be useful on its own
259 2019-03-18T19:32:45  *** promag has quit IRC
260 2019-03-18T19:40:22  *** AaronvanW has quit IRC
261 2019-03-18T19:40:47  *** AaronvanW has joined #bitcoin-core-dev
262 2019-03-18T20:00:49  *** spinza has quit IRC
263 2019-03-18T20:04:40  *** captjakk has quit IRC
264 2019-03-18T20:05:37  *** shesek has quit IRC
265 2019-03-18T20:06:08  *** shesek has joined #bitcoin-core-dev
266 2019-03-18T20:12:19  *** shesek has quit IRC
267 2019-03-18T20:12:44  *** captjakk has joined #bitcoin-core-dev
268 2019-03-18T20:13:32  *** captjakk has joined #bitcoin-core-dev
269 2019-03-18T20:15:24  *** spinza has joined #bitcoin-core-dev
270 2019-03-18T20:15:24  <moneyball> hi, i tried setting gmaxwell ban list in the Core GUI debug console, and in response i got "Error: IP/Subnet already banned (code -23)" even though i've never done this before. is there a reason they were already banned for my node?
271 2019-03-18T20:23:57  <warren> moneyball: grep your debug.log, maybe they already triggered ban scores. in any case I think you'd be best to feed it into RPC with a script and ignore the output.
272 2019-03-18T20:26:00  <moneyball> warren: maybe that error message is just referring to a subset of the list as having already been banned. i'll check the debug log...but i doubt all of them have already been banned? in any case, it seems like a more useful response could be provided to the user to avoid confusion? (i can create a github issue if appropriate)
273 2019-03-18T20:29:54  *** Chris_Stewart_5 has quit IRC
274 2019-03-18T20:32:45  <sipa> moneyball: they may be banned due to automatic behavior
275 2019-03-18T20:33:34  <moneyball> ok. grep'ing for 'ban' reveals one, although i don't see that IP in greg's ban list: 2018-07-28 03:11:56 Misbehaving: 137.74.157.8:8333 peer=302 (80 -> 100) BAN THRESHOLD EXCEEDED
276 2019-03-18T20:33:41  *** DeanGuss has quit IRC
277 2019-03-18T20:34:33  *** Emcy has joined #bitcoin-core-dev
278 2019-03-18T20:36:50  *** darosior has joined #bitcoin-core-dev
279 2019-03-18T21:17:15  *** e4xit has joined #bitcoin-core-dev
280 2019-03-18T21:19:49  <moneyball> i used bitcoin-cli listbanned to determine i have 474 banned, all of which are manually added. greg's list has 670. so i am wondering why my ban list is less (likely due to error aborting prematurely?). i am also still wondering about the "already banned" error message since i have none in the ban list that are shown as automatic.
281 2019-03-18T21:20:07  <moneyball> (i can take this to another channel, or, to a github issue, if you'd prefer. just say the word.)
282 2019-03-18T21:23:41  *** mmgen has quit IRC
283 2019-03-18T21:24:52  <gwillen> moneyball: is it possible that you loaded a version of greg's list or similar in the past?
284 2019-03-18T21:25:02  <echeveria> moneyball: some ranges could overlap.
285 2019-03-18T21:25:34  <moneyball> gwillen: doubtful as i've never done anything around ban lists
286 2019-03-18T21:30:02  <warren> I haven't looked at his ban list, you sure it doesn't have duplicates? Did you run it through sort then uniq and compare the before/after line count?
287 2019-03-18T21:31:36  <warren> If he's using the GUI then I'm guessing it isn't a long lived node that would have a large ban list. Also GUI is a lot less likely to have incoming connections unless you configured your NAT/firewall to allow it. The ban list is mainly relevant to incoming connections.
288 2019-03-18T21:33:13  <moneyball> for context, i'm just testing this out as it is referenced in this week's optech newsletter, so i wanted to make sure our readers have a good experience
289 2019-03-18T21:40:05  *** Krellan has joined #bitcoin-core-dev
290 2019-03-18T21:43:43  <gmaxwell> There is a small range overlap in my banlist, but it shouldn't reject bans for that reason.
291 2019-03-18T21:44:40  <gmaxwell> IIRC There are only two ranges in my banlist at all, one has no overlap in the list because I removed all the overlapped addresses, and the other one I left them in.
292 2019-03-18T21:45:18  <gmaxwell> (removed because it was 245 out of the 256 ips in the range, left the other one in because it was only 20 or so ips out of the range, and thought maybe the range was a bit questionable and might remove it later)
293 2019-03-18T21:46:28  <gmaxwell> moneyball: if you only got one "already banned" that just means there was only one overlap.
294 2019-03-18T21:46:54  <gmaxwell> moneyball: how are you counting in listbanned?
295 2019-03-18T21:47:06  <gmaxwell> $ ./bitcoin-cli listbanned | grep address | wc -l
296 2019-03-18T21:47:06  <gmaxwell> 723
297 2019-03-18T21:47:47  <moneyball> that is how i counted
298 2019-03-18T21:48:06  <moneyball> $bitcoin-cli listbanned | grep address | wc -l
299 2019-03-18T21:48:06  <moneyball>      474
300 2019-03-18T21:48:29  <moneyball> $bitcoin-cli listbanned | grep manually | wc -l
301 2019-03-18T21:48:29  <moneyball>      474
302 2019-03-18T21:48:37  <moneyball> $cat ~/Downloads/banlist.gui.txt | wc -l
303 2019-03-18T21:48:38  <moneyball>      670
304 2019-03-18T21:49:28  <gmaxwell> Is it possible that you used a cached copy (in your browser) of the list? 474 is more like the length of the list last week.
305 2019-03-18T21:51:28  <gmaxwell> I guess I do have one dupe in the list, fixing.
306 2019-03-18T21:51:29  <gmaxwell> https://0bin.net/paste/1hoyzTHrz-Lk94Cl#BcjjsSoYSzUlEhohe82jhANopBG5OL4gE04ke-+gBop
307 2019-03-18T21:52:39  <gmaxwell> hm I don't see the dupe.
308 2019-03-18T21:54:38  <gmaxwell> found it
309 2019-03-18T21:55:04  <gmaxwell> There was just one in there without its /32.
310 2019-03-18T21:55:13  <gmaxwell> maybe that messed up the paste in the gui?
311 2019-03-18T21:56:17  <moneyball> i'm using https://people.xiph.org/~greg/banlist.gui.txt
312 2019-03-18T21:56:50  <moneyball> gmaxwell: let me try again
313 2019-03-18T21:56:52  *** jarthur has quit IRC
314 2019-03-18T21:57:24  <gmaxwell> moneyball: right, they're the same (as in anytime I update cli I regenerate gui by running cat banlist.cli.txt  | cut -d' ' -f2- | sort > banlist.gui.txt )
315 2019-03-18T21:58:26  <moneyball> https://www.irccloud.com/pastebin/z8Vn1pIW/
316 2019-03-18T21:58:39  <moneyball> so maybe the GUI doesn't handle pasting that many items
317 2019-03-18T21:58:44  <gmaxwell> lol :(
318 2019-03-18T21:58:50  <moneyball> i'll try to break it into chunks
319 2019-03-18T21:59:33  <gmaxwell> ::sigh:: maybe I should reorder it so the most important ones are first.
320 2019-03-18T22:00:30  <moneyball> hmmm. even if i paste just ONE into the GUI, i now get this "Method not found" error
321 2019-03-18T22:01:02  <harding> moneyball: are you using the version with ./bitcoin-cli embedded?  You need the one where the lines start with "setban"
322 2019-03-18T22:02:25  <moneyball> harding: whoops!
323 2019-03-18T22:02:34  <moneyball> i switched lists...
324 2019-03-18T22:05:03  *** ThomasLuong has joined #bitcoin-core-dev
325 2019-03-18T22:05:43  <harding> Testing on a regtest node, I can paste the current full list into the GUI, have it evaluate without error, and confirm via listbanned that the expected number of bans have been set.
326 2019-03-18T22:06:00  <harding> (Linux here.)
327 2019-03-18T22:06:16  <moneyball> gmaxwell: fyi  the line "setban 47.90.209.151 add 31557600" is still missing the /32. i tried loading in a different browser to confirm. did you push the change?
328 2019-03-18T22:07:14  <gmaxwell> moneyball: that one didn't have it, it wasn't a dupe though. the /32 isn't required.
329 2019-03-18T22:07:38  <gmaxwell> (I include it just so the output from list banned is consistent with my list)
330 2019-03-18T22:07:43  <gmaxwell> (I added that one now)
331 2019-03-18T22:09:48  <gmaxwell> harding: maybe it's OS specific? moneyball's latest paste looks pretty clearly like a truncation-- its cutoff in the middle of a line.
332 2019-03-18T22:10:26  <luke-jr> aside: 162.218.65.0/24 is actually all attackers?
333 2019-03-18T22:10:45  <luke-jr> (just seems strange most of the peers I know there claim to be btcd)
334 2019-03-18T22:11:39  <moneyball> fwiw i'm MacOS, Chrome, Core v0.18rc2
335 2019-03-18T22:12:55  <gmaxwell> luke-jr: yes.  245 out of the 256 IPs in that subnet connected to me falsely claiming to be android wallet, which they clearly are not, and then sit connected listening to all invs.
336 2019-03-18T22:12:56  <midnightmagic> luke-jr: yes. The /24 is one I personally triangulated with someone else. ban one, another takes its place, randomly, in the /24. We got to 64 and then just killed the whole lot. None of them are even real nodes, and someone else has fingerprinted them.
337 2019-03-18T22:13:03  <moneyball> i pasted just the last few dozen in the list into the GUI, and no error message, although the response i get is "null" ... which isn't very user friendly. is it expected?
338 2019-03-18T22:13:31  <gmaxwell> moneyball: I think it has no response on a successful ban, yes.
339 2019-03-18T22:13:38  <moneyball> also it increased by banned list to 509, which now strongly suggests the paste is being truncated
340 2019-03-18T22:13:50  <moneyball> my*
341 2019-03-18T22:16:29  <moneyball> i've managed to get my ban list up to 669, one short of gmaxwell's list of 670. to be clear, is there one dup/overlap in the list that would cause this?
342 2019-03-18T22:16:37  <luke-jr> midnightmagic: yeah. looking like some kind of botnet
343 2019-03-18T22:16:43  <harding> moneyball: the list is now 669 long.
344 2019-03-18T22:16:54  <harding> I mean, it was 10 minutes ago.
345 2019-03-18T22:17:43  <moneyball> ok i re-downloaded...confirmed
346 2019-03-18T22:17:55  <gmaxwell> I dropped one that was actually duplicated, based on moneyball's report earlier.
347 2019-03-18T22:18:09  <moneyball> so harding, for the newsletter, we might want to point out the pasting challenge.
348 2019-03-18T22:18:11  <gmaxwell> so it sounds like maybe on OSX there is a paste limit that is getting in the way.
349 2019-03-18T22:18:20  <moneyball> gmaxwell yeah
350 2019-03-18T22:18:50  <gmaxwell> :(
351 2019-03-18T22:23:04  <midnightmagic> gmaxwell: there's also a paste limitation when working through..  mosh I think and some kinds of shell connections. Easier to just wget it first and pipe.
352 2019-03-18T22:23:53  *** spinza has quit IRC
353 2019-03-18T22:26:40  *** ccdle12 has quit IRC
354 2019-03-18T22:41:56  *** spinza has joined #bitcoin-core-dev
355 2019-03-18T22:52:21  <luke-jr> gmaxwell: are ALL of your banned IPs implicated in the attack?
356 2019-03-18T23:02:59  *** dqx_ has quit IRC
357 2019-03-18T23:03:47  *** dqx_ has joined #bitcoin-core-dev
358 2019-03-18T23:03:56  *** DeanGuss has joined #bitcoin-core-dev
359 2019-03-18T23:05:02  <gmaxwell> luke-jr: 245 out of 256.
360 2019-03-18T23:05:39  <luke-jr> gmaxwell: how about the specific one I PM'd you?
361 2019-03-18T23:05:48  *** Zenton has quit IRC
362 2019-03-18T23:05:59  <gmaxwell> oh you weren't asking about that /24.
363 2019-03-18T23:07:59  <gmaxwell> Just answering the general question in public: no the IPs in my ban list are either addresses that are mass connecting to (nearly) every reachable node in the network and leaving connections up, OR were directly connecting to a node I control and behaving in a clearly abusive way, OR are part of an apparently eclipse attack in a clearly identifyable way. I'll follow up in PM about the specific
364 2019-03-18T23:07:59  <gmaxwell> ones you're talking about.
365 2019-03-18T23:08:43  *** dqx_ has quit IRC
366 2019-03-18T23:10:19  *** darosior has quit IRC
367 2019-03-18T23:11:44  *** ThomasLuong has quit IRC
368 2019-03-18T23:13:31  *** ap4lmtree has quit IRC
369 2019-03-18T23:13:56  *** ap4lmtree has joined #bitcoin-core-dev
370 2019-03-18T23:21:17  *** Guyver2 has quit IRC
371 2019-03-18T23:24:04  *** justanotheruser has quit IRC
372 2019-03-18T23:24:59  *** justanotheruser has joined #bitcoin-core-dev
373 2019-03-18T23:26:15  *** justanotheruser has quit IRC
374 2019-03-18T23:26:32  <fanquake> dongcarl cheers. I'll take a look at your changes today.
375 2019-03-18T23:26:46  *** justanotheruser has joined #bitcoin-core-dev
376 2019-03-18T23:32:59  *** pinheadmz has quit IRC
377 2019-03-18T23:36:09  <warren> fanquake: try downloading all of the depends prior to running the build inside guix, ideally the builder should work without any networking at all. That also bypasses the permission issue.
378 2019-03-18T23:48:10  *** promag has joined #bitcoin-core-dev
379 2019-03-18T23:55:19  *** ap4lmtree has quit IRC
380 2019-03-18T23:55:41  *** pinheadmz has joined #bitcoin-core-dev
381 2019-03-18T23:55:54  *** rex4539 has joined #bitcoin-core-dev
382 2019-03-18T23:59:04  *** muoitran has joined #bitcoin-core-dev