1 2019-04-15T00:11:16  *** pinheadmz has joined #bitcoin-core-dev
  2 2019-04-15T00:15:52  *** pinheadmz has quit IRC
  3 2019-04-15T00:19:08  *** davterra has quit IRC
  4 2019-04-15T00:19:15  *** pinheadmz has joined #bitcoin-core-dev
  5 2019-04-15T00:25:59  *** captjakk has joined #bitcoin-core-dev
  6 2019-04-15T00:31:07  *** captjakk has quit IRC
  7 2019-04-15T00:34:12  *** Cory has quit IRC
  8 2019-04-15T00:36:46  *** pinheadmz has quit IRC
  9 2019-04-15T00:41:23  *** Cory has joined #bitcoin-core-dev
 10 2019-04-15T00:51:35  *** scoop has joined #bitcoin-core-dev
 11 2019-04-15T00:51:58  *** promag_ has quit IRC
 12 2019-04-15T00:52:03  *** bitcoin-git has joined #bitcoin-core-dev
 13 2019-04-15T00:52:03  <bitcoin-git> [bitcoin] fanquake closed pull request #15815: remove duplicate boundary check in script.cpp (master...remove_duplicate_boundary_check) https://github.com/bitcoin/bitcoin/pull/15815
 14 2019-04-15T00:52:16  *** bitcoin-git has left #bitcoin-core-dev
 15 2019-04-15T00:52:17  *** fanquake has joined #bitcoin-core-dev
 16 2019-04-15T00:52:30  *** promag_ has joined #bitcoin-core-dev
 17 2019-04-15T00:56:07  *** scoop has quit IRC
 18 2019-04-15T00:57:07  *** promag_ has quit IRC
 19 2019-04-15T00:59:41  *** scoop has joined #bitcoin-core-dev
 20 2019-04-15T01:00:37  *** scoop has quit IRC
 21 2019-04-15T01:00:44  *** scoop has joined #bitcoin-core-dev
 22 2019-04-15T01:04:05  *** captjakk has joined #bitcoin-core-dev
 23 2019-04-15T01:06:59  *** spinza has quit IRC
 24 2019-04-15T01:21:09  *** scoop has quit IRC
 25 2019-04-15T01:25:28  *** spinza has joined #bitcoin-core-dev
 26 2019-04-15T01:25:56  *** kljasdfvv has quit IRC
 27 2019-04-15T01:26:34  *** kljasdfvv has joined #bitcoin-core-dev
 28 2019-04-15T01:37:40  *** scoop has joined #bitcoin-core-dev
 29 2019-04-15T02:09:49  *** promag_ has joined #bitcoin-core-dev
 30 2019-04-15T02:11:40  *** pinheadmz has joined #bitcoin-core-dev
 31 2019-04-15T02:14:15  *** promag_ has quit IRC
 32 2019-04-15T02:20:27  <fanquake> gwillen could you sanity check me in 15814..
 33 2019-04-15T02:20:54  <gwillen> fanquake: taking a look
 34 2019-04-15T02:21:40  <gwillen> I will check, but I could absolutely believe those methods are unused
 35 2019-04-15T02:21:51  <gwillen> the refactor that touched all that stuff went through several versions
 36 2019-04-15T02:22:03  <gwillen> I could easily have overlooked that
 37 2019-04-15T02:28:36  *** dviola has quit IRC
 38 2019-04-15T02:31:01  *** pinheadmz has quit IRC
 39 2019-04-15T02:35:42  *** bitcoin-git has joined #bitcoin-core-dev
 40 2019-04-15T02:35:43  <bitcoin-git> [bitcoin] fanquake closed pull request #14949: [0.17] Backport #14849 Qt 5.9.7 (0.17...backport-qt-597) https://github.com/bitcoin/bitcoin/pull/14949
 41 2019-04-15T02:35:44  *** bitcoin-git has left #bitcoin-core-dev
 42 2019-04-15T02:42:03  *** pinheadmz has joined #bitcoin-core-dev
 43 2019-04-15T02:58:54  *** captjakk has quit IRC
 44 2019-04-15T02:59:26  *** captjakk has joined #bitcoin-core-dev
 45 2019-04-15T03:04:11  *** captjakk has quit IRC
 46 2019-04-15T03:10:51  *** pinheadmz has quit IRC
 47 2019-04-15T03:30:51  *** teardown has joined #bitcoin-core-dev
 48 2019-04-15T03:32:19  *** chriswang2019 has joined #bitcoin-core-dev
 49 2019-04-15T03:40:16  *** chriswang2019 has quit IRC
 50 2019-04-15T03:45:43  *** scoop has quit IRC
 51 2019-04-15T04:04:16  *** teardown has quit IRC
 52 2019-04-15T04:10:34  *** promag_ has joined #bitcoin-core-dev
 53 2019-04-15T04:15:07  *** promag_ has quit IRC
 54 2019-04-15T04:16:12  *** teardown has joined #bitcoin-core-dev
 55 2019-04-15T04:23:23  *** scoop has joined #bitcoin-core-dev
 56 2019-04-15T04:27:27  *** scoop has quit IRC
 57 2019-04-15T04:30:51  *** captjakk has joined #bitcoin-core-dev
 58 2019-04-15T04:35:55  *** captjakk has quit IRC
 59 2019-04-15T04:49:17  *** CubicEarth has quit IRC
 60 2019-04-15T04:54:54  *** CubicEarth has joined #bitcoin-core-dev
 61 2019-04-15T05:00:19  *** gamma_ has joined #bitcoin-core-dev
 62 2019-04-15T05:05:35  *** gamma_ has quit IRC
 63 2019-04-15T05:06:47  *** face has quit IRC
 64 2019-04-15T05:37:09  *** DeanGuss has joined #bitcoin-core-dev
 65 2019-04-15T05:41:11  *** face has joined #bitcoin-core-dev
 66 2019-04-15T05:42:07  *** bralyclow has joined #bitcoin-core-dev
 67 2019-04-15T06:00:40  *** face has quit IRC
 68 2019-04-15T06:02:52  *** StopAndDecrypt_ has joined #bitcoin-core-dev
 69 2019-04-15T06:04:14  *** StopAndDecrypt has quit IRC
 70 2019-04-15T06:25:42  *** DougieBot5000_ has joined #bitcoin-core-dev
 71 2019-04-15T06:26:21  *** rex4539 has joined #bitcoin-core-dev
 72 2019-04-15T06:28:23  *** DougieBot5000 has quit IRC
 73 2019-04-15T06:31:23  *** StopAndDecrypt_ has quit IRC
 74 2019-04-15T06:31:32  *** rex4539 has quit IRC
 75 2019-04-15T06:32:01  *** rex4539 has joined #bitcoin-core-dev
 76 2019-04-15T06:32:34  *** pinheadmz has joined #bitcoin-core-dev
 77 2019-04-15T06:35:19  *** ccdle12 has joined #bitcoin-core-dev
 78 2019-04-15T06:35:40  *** Zenton has quit IRC
 79 2019-04-15T06:35:57  *** Zenton has joined #bitcoin-core-dev
 80 2019-04-15T06:47:36  *** wumpus has joined #bitcoin-core-dev
 81 2019-04-15T06:52:14  *** pinheadmz has quit IRC
 82 2019-04-15T06:59:48  *** ExEric3 has quit IRC
 83 2019-04-15T07:03:35  *** captjakk has joined #bitcoin-core-dev
 84 2019-04-15T07:05:34  *** DeanGuss has quit IRC
 85 2019-04-15T07:05:55  *** DeanGuss has joined #bitcoin-core-dev
 86 2019-04-15T07:08:00  *** captjakk has quit IRC
 87 2019-04-15T07:08:54  *** captjakk has joined #bitcoin-core-dev
 88 2019-04-15T07:10:22  *** ExEric3 has joined #bitcoin-core-dev
 89 2019-04-15T07:13:30  *** captjakk has quit IRC
 90 2019-04-15T07:21:08  *** promag_ has joined #bitcoin-core-dev
 91 2019-04-15T07:25:43  *** promag_ has quit IRC
 92 2019-04-15T07:35:29  *** lnostdal has joined #bitcoin-core-dev
 93 2019-04-15T07:36:23  *** DougieBot5000_ is now known as DougieBot5000
 94 2019-04-15T07:50:54  *** StopAndDecrypt has joined #bitcoin-core-dev
 95 2019-04-15T08:04:21  *** darosior has joined #bitcoin-core-dev
 96 2019-04-15T08:05:35  *** setpill has joined #bitcoin-core-dev
 97 2019-04-15T08:10:48  *** Guyver2 has joined #bitcoin-core-dev
 98 2019-04-15T08:12:04  *** darosior has quit IRC
 99 2019-04-15T08:12:28  *** darosior has joined #bitcoin-core-dev
100 2019-04-15T08:34:33  *** zaka has joined #bitcoin-core-dev
101 2019-04-15T08:40:51  *** ghost43 has quit IRC
102 2019-04-15T08:43:00  *** fanquake has quit IRC
103 2019-04-15T08:46:01  *** promag_ has joined #bitcoin-core-dev
104 2019-04-15T08:46:11  *** face has joined #bitcoin-core-dev
105 2019-04-15T08:46:35  *** ghost43 has joined #bitcoin-core-dev
106 2019-04-15T08:47:01  *** rex4539 has quit IRC
107 2019-04-15T08:51:03  *** ghost43 has quit IRC
108 2019-04-15T08:57:57  *** ghost43 has joined #bitcoin-core-dev
109 2019-04-15T08:59:28  *** riperk has quit IRC
110 2019-04-15T09:00:45  *** zaka has quit IRC
111 2019-04-15T09:12:02  *** timothy has joined #bitcoin-core-dev
112 2019-04-15T09:28:53  *** lnostdal has quit IRC
113 2019-04-15T09:29:08  *** lnostdal has joined #bitcoin-core-dev
114 2019-04-15T09:34:49  *** fanquake has joined #bitcoin-core-dev
115 2019-04-15T09:41:05  *** captjakk has joined #bitcoin-core-dev
116 2019-04-15T09:42:37  *** ghost43 has quit IRC
117 2019-04-15T09:45:18  *** captjakk has quit IRC
118 2019-04-15T09:46:58  *** promag_ has quit IRC
119 2019-04-15T09:47:50  <provoostenator> Happy Monday! Getting a Segmentation fault: 11 on macOS master when opening wallets. With and without --enable-debug.
120 2019-04-15T09:48:22  *** promag_ has joined #bitcoin-core-dev
121 2019-04-15T09:49:13  <gmaxwell> run inside a debugger and find out where its crashing?
122 2019-04-15T09:49:38  <provoostenator> Will try
123 2019-04-15T09:50:11  <fanquake> provoostenator calling the loadwallet rpc, through the gui?
124 2019-04-15T09:50:26  *** ccdle12 has quit IRC
125 2019-04-15T09:51:13  <provoostenator> fanquake: bitcoind crashes when starting if a wallet is configured. I can start with -nowallet, and it crashes as I load through RPC call or create a wallet.
126 2019-04-15T09:56:00  *** rex4539 has joined #bitcoin-core-dev
127 2019-04-15T09:56:59  <fanquake> provoostenator from a quick look, I'm not seeing a crash like that. built master, -nowallet, created new wallets and loaded existing.
128 2019-04-15T09:57:53  <provoostenator> My guess is that it will go away as soon as I update homebrew or something like that, so I'll try to get a trace first.
129 2019-04-15T10:02:58  *** shesek has joined #bitcoin-core-dev
130 2019-04-15T10:02:58  *** shesek has joined #bitcoin-core-dev
131 2019-04-15T10:13:31  <provoostenator> "breakpoint set --name _exit" doesn't catch this in lldb, any suggestions?
132 2019-04-15T10:14:37  <provoostenator> (I'll try gdb as well)
133 2019-04-15T10:20:54  <wumpus> doesn't it always trap on segmentation faults?
134 2019-04-15T10:21:52  *** promag_ has quit IRC
135 2019-04-15T10:23:19  *** promag_ has joined #bitcoin-core-dev
136 2019-04-15T10:24:16  <provoostenator> I thought so as well. lldb says "error: process exited with status -1 (Error 1)", so maybe that's something else...
137 2019-04-15T10:24:20  <wumpus> I mean, what are you trying to do by trapping _exit ?
138 2019-04-15T10:24:29  <wumpus> and you can't do 'bt' after that?
139 2019-04-15T10:24:54  <wumpus> to me it sounds like your debugger isn't working at all
140 2019-04-15T10:25:13  <wumpus> it ignores the trap, runs the trap handler and lets the process exit
141 2019-04-15T10:26:16  <wumpus> in gdb at least you can set the signals it should break on with 'signal', but, SIGSEGV is always that by default, it shoudln't be necessary
142 2019-04-15T10:26:34  <provoostenator> Indeed, "lldb src/bitcoind -- -nowallet" also does an exit 1, so I'm using the debugger wrong.
143 2019-04-15T10:26:50  <provoostenator> -1
144 2019-04-15T10:28:40  <provoostenator> aaargh, it was trying to pupop a permission window on my desktop, that's what failed.
145 2019-04-15T10:29:26  <provoostenator> backtrace: https://gist.github.com/Sjors/de8d359d87cd0fecc303b989b5a27cc5
146 2019-04-15T10:31:05  <fanquake> Hi wumpus
147 2019-04-15T10:31:13  <wumpus> hi fanquake !
148 2019-04-15T10:31:15  <provoostenator> This might be a borked bdb@4 homebrew thing
149 2019-04-15T10:31:49  <fanquake> provoostenator make sure you keep a copy of that "A" wallet
150 2019-04-15T10:32:46  <fanquake> wumpus Hope you are doing well. 15809, 15794, 15790, and maybe 15756 are mergable
151 2019-04-15T10:33:05  <wumpus> provoostenator: it might be; it happens in the bowels of berkeleydb, which means either it's being passed garbage arguments, or there's something like an ABI conflict
152 2019-04-15T10:33:41  <provoostenator> It crashes with "createwallet" too, added to the gist...
153 2019-04-15T10:33:42  <wumpus> (the former is not possible to diagnose from this as, as usual with c++ and debugging, the argument data has been optimized out)
154 2019-04-15T10:37:46  *** zaka has joined #bitcoin-core-dev
155 2019-04-15T10:37:47  <provoostenator> I'll try a depends build as well as --with-incompatible-bdb.
156 2019-04-15T10:42:39  *** promag_ has quit IRC
157 2019-04-15T10:43:10  *** promag_ has joined #bitcoin-core-dev
158 2019-04-15T10:47:23  *** ghost43 has joined #bitcoin-core-dev
159 2019-04-15T10:50:52  <aj> wumpus: add #15776 to high pri list?
160 2019-04-15T10:50:54  <gribble> https://github.com/bitcoin/bitcoin/issues/15776 | Expire inflight GETDATA requests by ajtowns · Pull Request #15776 · bitcoin/bitcoin · GitHub
161 2019-04-15T10:51:27  *** promag_ has quit IRC
162 2019-04-15T10:52:18  *** promag_ has joined #bitcoin-core-dev
163 2019-04-15T10:53:50  *** spinza has quit IRC
164 2019-04-15T10:54:31  <jonasschnelli> I got now the second time a 0.18.0rc3 node with a "stuck" mempool (size of 6 for a long time)
165 2019-04-15T10:54:48  <aj> jonasschnelli: see PR above :)
166 2019-04-15T10:55:09  <jonasschnelli> oh... haven't read back yet. :)
167 2019-04-15T10:56:38  <jonasschnelli> aj: is there a way I could check if the problem described in 15776 is what I'm facing at that paricular rc3 node (debug net is off)?
168 2019-04-15T10:57:14  <jonasschnelli> enabling debug=net will require a restart and destroys the debugability I guess.
169 2019-04-15T10:57:29  <gmaxwell> jonasschnelli: you can change any debug options while running
170 2019-04-15T10:57:31  <aj> jonasschnelli: bitcoin-cli logging '["net"]' # turns debug=net back on
171 2019-04-15T10:57:33  <gmaxwell> with the logging rpc
172 2019-04-15T10:58:27  <jonasschnelli> oh.. how could I miss that
173 2019-04-15T10:58:36  * jonasschnelli doing now...
174 2019-04-15T10:58:39  <fanquake> aj have done
175 2019-04-15T10:59:25  <aj> fanquake: thanks
176 2019-04-15T10:59:34  <jonasschnelli> There are many invs but mempool won't grow
177 2019-04-15T10:59:49  <aj> yeah, that's the symptom
178 2019-04-15T10:59:50  <jonasschnelli> I don't see any getdata on the invs
179 2019-04-15T11:00:07  <aj> if you add a new outbound, you should get getdata's for it
180 2019-04-15T11:00:10  *** promag_ has quit IRC
181 2019-04-15T11:00:56  <jonasschnelli> let me try
182 2019-04-15T11:02:28  <jonasschnelli> aj: indeed. A addnode made the mempool grow again
183 2019-04-15T11:03:31  *** rabidus has quit IRC
184 2019-04-15T11:04:13  *** promag_ has joined #bitcoin-core-dev
185 2019-04-15T11:04:22  *** spinza has joined #bitcoin-core-dev
186 2019-04-15T11:04:39  *** shesek has quit IRC
187 2019-04-15T11:05:09  *** zaka has quit IRC
188 2019-04-15T11:10:54  *** rabidus has joined #bitcoin-core-dev
189 2019-04-15T11:13:31  *** promag_ has quit IRC
190 2019-04-15T11:15:08  *** darosior has quit IRC
191 2019-04-15T11:16:39  *** promag_ has joined #bitcoin-core-dev
192 2019-04-15T11:22:23  *** promag_ has quit IRC
193 2019-04-15T11:23:24  <wumpus> fanquake: i'm doing ok (and IRC was offline due to IPv6 routing issues), will take a look at those PRs
194 2019-04-15T11:23:41  *** promag_ has joined #bitcoin-core-dev
195 2019-04-15T11:25:09  <wumpus> jonasschnelli: run time switching of logging state is great, happy that has been added
196 2019-04-15T11:25:48  <jonasschnelli> yes. that's awesome
197 2019-04-15T11:43:50  *** bitcoin-git has joined #bitcoin-core-dev
198 2019-04-15T11:43:51  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4f4ef3138b06...617261eb1c8b
199 2019-04-15T11:43:51  <bitcoin-git> bitcoin/master e7acf44 James O'Beirne: gitignore: add *.dat
200 2019-04-15T11:43:52  <bitcoin-git> bitcoin/master 17be9e0 James O'Beirne: gitignore: add *.plist (clang-check)
201 2019-04-15T11:43:52  <bitcoin-git> bitcoin/master 617261e Wladimir J. van der Laan: Merge #15809: gitignore: plist and dat
202 2019-04-15T11:43:54  *** bitcoin-git has left #bitcoin-core-dev
203 2019-04-15T11:44:43  *** bitcoin-git has joined #bitcoin-core-dev
204 2019-04-15T11:44:43  <bitcoin-git> [bitcoin] laanwj merged pull request #15809: gitignore: plist and dat (master...2019-04-gitignore) https://github.com/bitcoin/bitcoin/pull/15809
205 2019-04-15T11:44:55  *** bitcoin-git has left #bitcoin-core-dev
206 2019-04-15T11:47:07  *** rev_strangehope has quit IRC
207 2019-04-15T11:47:22  *** bralyclo_ has joined #bitcoin-core-dev
208 2019-04-15T11:48:10  <fanquake> wumpus no worries. I also forgot 15751.
209 2019-04-15T11:49:13  *** rev_strangehope has joined #bitcoin-core-dev
210 2019-04-15T11:49:40  <wumpus> lool another day another ham-handed pracicalswift PR
211 2019-04-15T11:50:55  *** bralyclow has quit IRC
212 2019-04-15T11:52:55  *** bitcoin-git has joined #bitcoin-core-dev
213 2019-04-15T11:52:55  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/617261eb1c8b...0c6487c74f8c
214 2019-04-15T11:52:55  <bitcoin-git> bitcoin/master 41a46cb Pieter Wuille: Speed up deriveaddresses for large ranges
215 2019-04-15T11:52:56  <bitcoin-git> bitcoin/master 0c6487c Wladimir J. van der Laan: Merge #15751: Speed up deriveaddresses for large ranges
216 2019-04-15T11:52:57  *** bitcoin-git has left #bitcoin-core-dev
217 2019-04-15T11:53:34  *** bitcoin-git has joined #bitcoin-core-dev
218 2019-04-15T11:53:34  <bitcoin-git> [bitcoin] laanwj merged pull request #15751: Speed up deriveaddresses for large ranges (master...201904_fasterderiveaddresses) https://github.com/bitcoin/bitcoin/pull/15751
219 2019-04-15T11:53:35  *** bitcoin-git has left #bitcoin-core-dev
220 2019-04-15T11:56:43  *** darosior has joined #bitcoin-core-dev
221 2019-04-15T12:01:27  *** Guyver2 has quit IRC
222 2019-04-15T12:01:39  <wumpus> ok, that PR is not as bad as the title makes it sound !
223 2019-04-15T12:10:46  <fanquake> have to get past the lyrics heh
224 2019-04-15T12:11:42  <fanquake> wumpus 15802 and 15792 also both doc, pretty trivial
225 2019-04-15T12:16:22  *** shesek has joined #bitcoin-core-dev
226 2019-04-15T12:16:22  *** shesek has joined #bitcoin-core-dev
227 2019-04-15T12:22:24  *** bitcoin-git has joined #bitcoin-core-dev
228 2019-04-15T12:22:24  <bitcoin-git> [bitcoin] merland opened pull request #15817: trivial: fixed typo (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15817
229 2019-04-15T12:22:36  *** bitcoin-git has left #bitcoin-core-dev
230 2019-04-15T12:24:01  *** bitcoin-git has joined #bitcoin-core-dev
231 2019-04-15T12:24:01  <bitcoin-git> [bitcoin] fanquake closed pull request #15817: trivial: fixed typo (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15817
232 2019-04-15T12:24:03  *** bitcoin-git has left #bitcoin-core-dev
233 2019-04-15T12:26:58  *** captjakk has joined #bitcoin-core-dev
234 2019-04-15T12:29:33  *** spinza has quit IRC
235 2019-04-15T12:29:45  *** bitcoin-git has joined #bitcoin-core-dev
236 2019-04-15T12:29:46  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/164082c822b0...f42ed1442ec2
237 2019-04-15T12:29:47  <bitcoin-git> bitcoin/0.18 60d4621 Ben Carman: rpc: getrpcinfo docs
238 2019-04-15T12:29:48  <bitcoin-git> bitcoin/0.18 f42ed14 Wladimir J. van der Laan: Merge #15790: [0.18] backport #15754
239 2019-04-15T12:29:52  *** bitcoin-git has left #bitcoin-core-dev
240 2019-04-15T12:30:09  *** bitcoin-git has joined #bitcoin-core-dev
241 2019-04-15T12:30:09  <bitcoin-git> [bitcoin] laanwj merged pull request #15790: [0.18] backport #15754 (0.18...0.18) https://github.com/bitcoin/bitcoin/pull/15790
242 2019-04-15T12:30:10  *** bitcoin-git has left #bitcoin-core-dev
243 2019-04-15T12:30:31  *** promag_ has quit IRC
244 2019-04-15T12:31:24  *** captjakk has quit IRC
245 2019-04-15T12:32:03  *** dermoth has quit IRC
246 2019-04-15T12:32:30  *** dermoth has joined #bitcoin-core-dev
247 2019-04-15T12:39:12  *** bitcoin-git has joined #bitcoin-core-dev
248 2019-04-15T12:39:13  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c6487c74f8c...9422e2c29fbc
249 2019-04-15T12:39:13  <bitcoin-git> bitcoin/master 140bbee Jon Atack: doc: describe onlynet option in doc/tor.md
250 2019-04-15T12:39:14  <bitcoin-git> bitcoin/master 9422e2c Wladimir J. van der Laan: Merge #15792: doc: describe onlynet option in doc/tor.md
251 2019-04-15T12:39:16  *** bitcoin-git has left #bitcoin-core-dev
252 2019-04-15T12:40:04  *** bitcoin-git has joined #bitcoin-core-dev
253 2019-04-15T12:40:04  <bitcoin-git> [bitcoin] laanwj merged pull request #15792: doc: describe onlynet option in doc/tor.md (master...add-onlynet-option-to-tor-docs) https://github.com/bitcoin/bitcoin/pull/15792
254 2019-04-15T12:40:17  *** bitcoin-git has left #bitcoin-core-dev
255 2019-04-15T12:42:52  *** bitcoin-git has joined #bitcoin-core-dev
256 2019-04-15T12:42:52  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9422e2c29fbc...2a191b48463a
257 2019-04-15T12:42:52  <bitcoin-git> bitcoin/master 8dfbb5c Jack Mallers: doc: mention creating application support bitcoin folder on OSX
258 2019-04-15T12:42:53  <bitcoin-git> bitcoin/master 2a191b4 Wladimir J. van der Laan: Merge #15802: doc: mention creating application support bitcoin folder on ...
259 2019-04-15T12:43:05  *** bitcoin-git has left #bitcoin-core-dev
260 2019-04-15T12:43:39  *** bitcoin-git has joined #bitcoin-core-dev
261 2019-04-15T12:43:39  <bitcoin-git> [bitcoin] laanwj merged pull request #15802: doc: mention creating application support bitcoin folder on OSX (master...fix/macos-docs) https://github.com/bitcoin/bitcoin/pull/15802
262 2019-04-15T12:43:48  *** bitcoin-git has left #bitcoin-core-dev
263 2019-04-15T12:46:14  *** promag_ has joined #bitcoin-core-dev
264 2019-04-15T12:50:51  *** promag_ has quit IRC
265 2019-04-15T12:54:20  *** scoop has joined #bitcoin-core-dev
266 2019-04-15T12:55:46  *** promag_ has joined #bitcoin-core-dev
267 2019-04-15T13:00:04  *** promag_ has quit IRC
268 2019-04-15T13:06:25  *** bitcoin-git has joined #bitcoin-core-dev
269 2019-04-15T13:06:25  <bitcoin-git> [bitcoin] fanquake opened pull request #15818: [0.18] doc backports (0.18...0.18-doc-backports) https://github.com/bitcoin/bitcoin/pull/15818
270 2019-04-15T13:06:27  *** bitcoin-git has left #bitcoin-core-dev
271 2019-04-15T13:08:08  *** spinza has joined #bitcoin-core-dev
272 2019-04-15T13:19:19  *** promag_ has joined #bitcoin-core-dev
273 2019-04-15T13:23:50  *** promag_ has quit IRC
274 2019-04-15T13:26:04  *** setpill has quit IRC
275 2019-04-15T13:31:33  *** promag has quit IRC
276 2019-04-15T13:31:58  *** promag has joined #bitcoin-core-dev
277 2019-04-15T13:36:21  *** promag has quit IRC
278 2019-04-15T13:37:09  <provoostenator> It's specific to the homebrew version of berkeleydb@4 for me. Depends works fine. I made some notes in #15819.
279 2019-04-15T13:37:10  <gribble> https://github.com/bitcoin/bitcoin/issues/15819 | macOS: crash while loading wallet with berkeley-db@4 · Issue #15819 · bitcoin/bitcoin · GitHub
280 2019-04-15T13:52:43  <wumpus> provoostenator: thanks for investigating - adding upstream label
281 2019-04-15T13:58:27  <provoostenator> When Sqlite? :-)
282 2019-04-15T14:04:44  *** promag has joined #bitcoin-core-dev
283 2019-04-15T14:15:24  *** scoop has quit IRC
284 2019-04-15T14:25:03  <wumpus> with upstream I mean homebrew in this case, not bdb
285 2019-04-15T14:26:11  <wumpus> I'm sure it's possible to get the same kind of crashes when mishandling compilation/linking using any database — though that's not an argument *against* using sqlite ofc
286 2019-04-15T14:32:53  *** davterra has joined #bitcoin-core-dev
287 2019-04-15T14:35:42  *** shesek has quit IRC
288 2019-04-15T14:36:48  *** Guyver2 has joined #bitcoin-core-dev
289 2019-04-15T14:37:53  *** pinheadmz has joined #bitcoin-core-dev
290 2019-04-15T14:38:23  *** chriswang2019 has joined #bitcoin-core-dev
291 2019-04-15T14:39:27  *** pinheadmz has quit IRC
292 2019-04-15T14:43:24  *** promag has quit IRC
293 2019-04-15T14:46:07  *** chriswang2019 has quit IRC
294 2019-04-15T15:01:30  *** timothy has quit IRC
295 2019-04-15T15:08:54  *** drexl has joined #bitcoin-core-dev
296 2019-04-15T15:10:21  *** bitcoin-git has joined #bitcoin-core-dev
297 2019-04-15T15:10:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a191b48463a...2a854a178166
298 2019-04-15T15:10:22  <bitcoin-git> bitcoin/master b4338c1 John Newbery: [rpc] Remove the addresses field from the getaddressinfo return object
299 2019-04-15T15:10:23  <bitcoin-git> bitcoin/master 2a854a1 MarcoFalke: Merge #15750: [rpc] Remove the addresses field from the getaddressinfo ret...
300 2019-04-15T15:10:32  *** bitcoin-git has left #bitcoin-core-dev
301 2019-04-15T15:11:11  *** bitcoin-git has joined #bitcoin-core-dev
302 2019-04-15T15:11:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15750: [rpc] Remove the addresses field from the getaddressinfo return object (master...2019_04_remove_address_from_getaddressinfo) https://github.com/bitcoin/bitcoin/pull/15750
303 2019-04-15T15:11:12  *** bitcoin-git has left #bitcoin-core-dev
304 2019-04-15T15:12:41  *** bralyclo_ has quit IRC
305 2019-04-15T15:13:04  *** bralyclow has joined #bitcoin-core-dev
306 2019-04-15T15:13:35  *** bralyclow has quit IRC
307 2019-04-15T15:20:57  *** Ed0 has joined #bitcoin-core-dev
308 2019-04-15T15:21:51  *** bitcoin-git has joined #bitcoin-core-dev
309 2019-04-15T15:21:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2a854a178166...2209b3ba25de
310 2019-04-15T15:21:52  <bitcoin-git> bitcoin/master fa74749 MarcoFalke: doc: Clarify RPC versioning
311 2019-04-15T15:21:52  <bitcoin-git> bitcoin/master 2209b3b MarcoFalke: Merge #15799: doc: Clarify RPC versioning
312 2019-04-15T15:21:54  *** bitcoin-git has left #bitcoin-core-dev
313 2019-04-15T15:21:55  *** timothy has joined #bitcoin-core-dev
314 2019-04-15T15:22:36  *** bitcoin-git has joined #bitcoin-core-dev
315 2019-04-15T15:22:36  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15799: doc: Clarify RPC versioning (master...1904-docRPC) https://github.com/bitcoin/bitcoin/pull/15799
316 2019-04-15T15:22:38  *** bitcoin-git has left #bitcoin-core-dev
317 2019-04-15T15:27:58  *** captjakk_ has joined #bitcoin-core-dev
318 2019-04-15T15:28:19  *** Dean_Guss has joined #bitcoin-core-dev
319 2019-04-15T15:29:17  *** DeanGuss has quit IRC
320 2019-04-15T15:29:29  *** bitcoin-git has joined #bitcoin-core-dev
321 2019-04-15T15:29:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2209b3ba25de...78295e97b8d3
322 2019-04-15T15:29:30  <bitcoin-git> bitcoin/master 666696b MarcoFalke: test: Have segwit always active in (Basic)TestingSetup
323 2019-04-15T15:29:30  <bitcoin-git> bitcoin/master fa8685d MarcoFalke: test: Use test_bitcoin setup in bench, Add test utils
324 2019-04-15T15:29:31  <bitcoin-git> bitcoin/master fa82190 MarcoFalke: scripted-diff: Rename test_bitcoin to test/setup_common
325 2019-04-15T15:29:33  *** bitcoin-git has left #bitcoin-core-dev
326 2019-04-15T15:30:07  <provoostenator> I'm having difficulty making ./configure forget about CPPFLAGS -I/usr/local/Cellar/berkeley-db@4 when I uninstall it.
327 2019-04-15T15:30:11  *** bitcoin-git has joined #bitcoin-core-dev
328 2019-04-15T15:30:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15788: test: Unify testing setups for fuzz, bench, and unit tests (master...1904-testUnify) https://github.com/bitcoin/bitcoin/pull/15788
329 2019-04-15T15:30:14  *** bitcoin-git has left #bitcoin-core-dev
330 2019-04-15T15:31:10  <provoostenator> Though maybe that's just hard coded.
331 2019-04-15T15:38:32  *** bralyclow has joined #bitcoin-core-dev
332 2019-04-15T15:41:43  *** EagleTM has joined #bitcoin-core-dev
333 2019-04-15T15:51:04  *** pinheadmz has joined #bitcoin-core-dev
334 2019-04-15T15:53:29  *** jonatack has joined #bitcoin-core-dev
335 2019-04-15T16:15:52  *** scoop has joined #bitcoin-core-dev
336 2019-04-15T16:20:28  *** scoop has quit IRC
337 2019-04-15T16:25:21  *** jonatack has quit IRC
338 2019-04-15T16:25:40  *** pinheadmz has quit IRC
339 2019-04-15T16:28:00  *** pinheadmz has joined #bitcoin-core-dev
340 2019-04-15T16:28:45  <gwillen> provoostenator: in situations like this, I go straight for "git clean -dfx", but beware thats it nukes everything that differentiates your local git client from a fresh checkout, including ignored files and any changes you have not checked in
341 2019-04-15T16:28:57  <gwillen> it is the maximumally-aggressive "make distclean"
342 2019-04-15T16:31:26  *** scoop has joined #bitcoin-core-dev
343 2019-04-15T16:36:08  *** jarthur has joined #bitcoin-core-dev
344 2019-04-15T16:43:28  <provoostenator> gwillen: I'll keep it in mind, but for now it's compiling and working despite this.
345 2019-04-15T16:43:54  <gwillen> ok, cool
346 2019-04-15T16:54:12  *** niftynei has quit IRC
347 2019-04-15T16:54:42  *** niftynei has joined #bitcoin-core-dev
348 2019-04-15T17:01:55  *** owowo has quit IRC
349 2019-04-15T17:02:38  *** davterra has quit IRC
350 2019-04-15T17:07:13  *** owowo has joined #bitcoin-core-dev
351 2019-04-15T17:09:36  *** omonk has quit IRC
352 2019-04-15T17:14:11  *** omonk has joined #bitcoin-core-dev
353 2019-04-15T17:16:13  *** bitcoin-git has joined #bitcoin-core-dev
354 2019-04-15T17:16:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/f42ed1442ec2...fa3993bfe856
355 2019-04-15T17:16:14  <bitcoin-git> bitcoin/0.18 b3a04c9 John Newbery: [rpc] Remove the addresses field from the getaddressinfo return object
356 2019-04-15T17:16:15  <bitcoin-git> bitcoin/0.18 fa3993b MarcoFalke: Merge #15800: Backport: [rpc] Remove the addresses field from the getaddre...
357 2019-04-15T17:16:16  *** bitcoin-git has left #bitcoin-core-dev
358 2019-04-15T17:16:35  *** bitcoin-git has joined #bitcoin-core-dev
359 2019-04-15T17:16:35  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15800: Backport: [rpc] Remove the addresses field from the getaddressinfo return object (0.18...2019_04_remove_address_from_getaddressinfo_0.18) https://github.com/bitcoin/bitcoin/pull/15800
360 2019-04-15T17:16:47  *** bitcoin-git has left #bitcoin-core-dev
361 2019-04-15T17:19:34  *** promag has joined #bitcoin-core-dev
362 2019-04-15T17:19:50  *** bitcoin-git has joined #bitcoin-core-dev
363 2019-04-15T17:19:50  <bitcoin-git> [bitcoin] dongcarl opened pull request #15820: docs: Add productivity notes for dummy rebases (master...2019-04-more-productive) https://github.com/bitcoin/bitcoin/pull/15820
364 2019-04-15T17:19:51  *** bitcoin-git has left #bitcoin-core-dev
365 2019-04-15T17:23:51  *** bitbee has quit IRC
366 2019-04-15T17:26:08  *** dermoth has quit IRC
367 2019-04-15T17:26:32  *** dermoth has joined #bitcoin-core-dev
368 2019-04-15T17:29:42  *** scoop has quit IRC
369 2019-04-15T17:30:09  *** scoop has joined #bitcoin-core-dev
370 2019-04-15T17:33:50  *** bitcoin-git has joined #bitcoin-core-dev
371 2019-04-15T17:33:50  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15779: test: Add wallet_balance benchmark (master...1904-benchWallet) https://github.com/bitcoin/bitcoin/pull/15779
372 2019-04-15T17:33:52  *** bitcoin-git has left #bitcoin-core-dev
373 2019-04-15T17:34:21  *** scoop has quit IRC
374 2019-04-15T17:34:37  *** bitbee has joined #bitcoin-core-dev
375 2019-04-15T17:41:33  *** darosior has quit IRC
376 2019-04-15T17:48:04  *** captjakk_ has quit IRC
377 2019-04-15T17:48:21  *** promag has quit IRC
378 2019-04-15T17:49:01  *** pinheadmz has quit IRC
379 2019-04-15T17:49:17  *** zaka has joined #bitcoin-core-dev
380 2019-04-15T17:50:53  *** captjakk has joined #bitcoin-core-dev
381 2019-04-15T17:51:00  *** captjakk has joined #bitcoin-core-dev
382 2019-04-15T17:52:20  *** pinheadmz has joined #bitcoin-core-dev
383 2019-04-15T17:59:11  <dongcarl> wumpus, gmaxwell: The one-shot pseudo-name resolution you guys mentioned last week for people behind Tor thru the name proxy is done using "getaddr" to seed nodes, correct?
384 2019-04-15T18:00:08  <sipa> dongcarl: yes, connect to seed nodes (rather than just resolve them), send getaddr, and disconnect after a response comes
385 2019-04-15T18:00:37  <dongcarl> Understood
386 2019-04-15T18:04:46  *** captjakk has quit IRC
387 2019-04-15T18:06:18  *** captjakk has joined #bitcoin-core-dev
388 2019-04-15T18:07:21  *** shesek has joined #bitcoin-core-dev
389 2019-04-15T18:07:21  *** shesek has joined #bitcoin-core-dev
390 2019-04-15T18:09:53  *** dqx_ has joined #bitcoin-core-dev
391 2019-04-15T18:10:42  *** captjakk has quit IRC
392 2019-04-15T18:14:48  <dongcarl> It would seem that in SOCKS5 you can have UDP-over-SOCKS, which means we should be able to just use the Tor SOCKS5 proxy to do name resolution instead of the one-shot "getaddr," am I missing something?
393 2019-04-15T18:15:20  <sipa> dongcarl: i'm not sure we want a DNS resolver implemented inside core...
394 2019-04-15T18:15:25  <sipa> but yes, in theory that would work
395 2019-04-15T18:16:13  *** bralyclow2 has joined #bitcoin-core-dev
396 2019-04-15T18:16:28  <luke-jr> huh? getaddr isn't DNS, nor is DNS a substitute for that step
397 2019-04-15T18:16:55  <luke-jr> and doesn't Tor have a resolve command?
398 2019-04-15T18:17:07  <dongcarl> I feel like I'm missing something important.
399 2019-04-15T18:17:17  <sipa> luke-jr: if you have a public connection to the internet, we gather seed IPs by just resolving the seed DNS name
400 2019-04-15T18:17:30  <sipa> luke-jr: if you don't, we instead connect to the DNS seed name, and request getaddr from it
401 2019-04-15T18:17:46  *** bralyclow2 has quit IRC
402 2019-04-15T18:17:48  <dongcarl> sipa: So doesn't that mean we already have a resolver in core?
403 2019-04-15T18:17:56  <sipa> dongcarl: no, we use the OS resolver
404 2019-04-15T18:18:04  <sipa> but you can't use that over tor
405 2019-04-15T18:18:07  <luke-jr> sipa: why can't we just use the Tor resolver?
406 2019-04-15T18:18:14  <sipa> luke-jr: afaik it has none
407 2019-04-15T18:18:22  <sipa> you can only connect to a name, not resolve a name
408 2019-04-15T18:18:34  *** captjakk has joined #bitcoin-core-dev
409 2019-04-15T18:18:58  *** ghost43 has quit IRC
410 2019-04-15T18:19:29  <sipa> (unless there is a way to resolve over socks5 i'm not aware of)
411 2019-04-15T18:19:38  <luke-jr> I thought Tor had a SOCKS5 extension for it
412 2019-04-15T18:19:45  <sipa> ah, that's possible
413 2019-04-15T18:20:45  <luke-jr>  As an extension to SOCKS4A and SOCKS5, Tor implements a new command value,
414 2019-04-15T18:20:46  <luke-jr>   "RESOLVE" [F0].  When Tor receives a "RESOLVE" SOCKS command, it initiates
415 2019-04-15T18:20:47  <luke-jr>   a remote lookup of the hostname provided as the target address in the SOCKS
416 2019-04-15T18:20:49  <luke-jr>   request.  The reply is either an error (if the address couldn't be
417 2019-04-15T18:20:50  <luke-jr>   resolved) or a success response.  In the case of success, the address is
418 2019-04-15T18:20:52  <luke-jr>   stored in the portion of the SOCKS response reserved for remote IP address.
419 2019-04-15T18:21:10  <sipa> seems like we should implement support for that then
420 2019-04-15T18:21:43  *** millerti has joined #bitcoin-core-dev
421 2019-04-15T18:22:28  <dongcarl> luke-jr: I have a sneaking suspicion that it'll only return a single address
422 2019-04-15T18:23:00  *** scoop has joined #bitcoin-core-dev
423 2019-04-15T18:23:38  *** captjakk has quit IRC
424 2019-04-15T18:28:35  <gmaxwell> dongcarl: udp over socks5 is AFAIK mostly unimplemented.  (e.g. ssh doesn't implement it)
425 2019-04-15T18:28:54  <gmaxwell> Tor, however, implements some extensions, including a dns resolution one that could be used by us.
426 2019-04-15T18:29:17  <sipa> if it only resolves a single IP, we're better off using the oneshot technique, though
427 2019-04-15T18:30:25  *** jarthur has quit IRC
428 2019-04-15T18:31:17  *** shesek has quit IRC
429 2019-04-15T18:32:12  <dongcarl> gmaxwell: I see, that makes sense.
430 2019-04-15T18:32:18  <dongcarl> sipa: Yea, I agree
431 2019-04-15T18:32:37  * dongcarl is thankful for context to include in documentation
432 2019-04-15T18:35:42  <luke-jr> sipa: we're supposed to only be doing getaddr to the seed-provided addresses anyway, though?
433 2019-04-15T18:39:15  <sipa> luke-jr: when we use the public resolving, the IP addresses the seed name resolves to are added directly into addrman
434 2019-04-15T18:43:28  <dongcarl> luke-jr: Do you have a Tor SOCKS5 you can try a "RESOLVE" with and see if it returns multiple entries?
435 2019-04-15T18:46:17  *** bitcoin-git has joined #bitcoin-core-dev
436 2019-04-15T18:46:17  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15821: doc: Remove upgrade note in release notes from EOL versions (master...1904-docRelEOL) https://github.com/bitcoin/bitcoin/pull/15821
437 2019-04-15T18:46:18  *** bitcoin-git has left #bitcoin-core-dev
438 2019-04-15T18:46:29  <sipa> dongcarl: https://linux.die.net/man/1/tor-resolve looks useful
439 2019-04-15T18:47:02  <sipa> returns a single IP
440 2019-04-15T18:47:05  *** gw2 has joined #bitcoin-core-dev
441 2019-04-15T18:48:01  <dongcarl> :-/
442 2019-04-15T18:48:31  <sipa> i don't think it's much of a problem to use the oneshot technique actually
443 2019-04-15T18:48:54  <sipa> it has advantages in being able to relay more IP addresses, and also communicate service flags and ports
444 2019-04-15T18:49:12  <dongcarl> sipa: True, you're right.
445 2019-04-15T18:49:27  *** hebasto has joined #bitcoin-core-dev
446 2019-04-15T18:49:30  <sipa> if we ever adopt v2 addr messages with NG tor addresses which aren't embeddable in IPv6 anymore, that'll even be the only option i think
447 2019-04-15T18:49:57  <gmaxwell> ^that
448 2019-04-15T18:50:29  <gmaxwell> dnsseed has turned out to have a lot of issues... including stuff like the dnsseed names getting blacklisted because they return some malware ips from time to time
449 2019-04-15T18:58:12  <dongcarl> That makes a lot of sense. Hopefully the net_processing for `getaddr` is fast and lockless enough...
450 2019-04-15T18:58:48  * dongcarl needs to read up on dns seeds
451 2019-04-15T19:00:27  *** captjakk has joined #bitcoin-core-dev
452 2019-04-15T19:03:10  <dongcarl> sipa: Is there a design doc for v2 addr messages?
453 2019-04-15T19:04:14  <sipa> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-February/016687.html
454 2019-04-15T19:04:35  <sipa> cc wumpus ^
455 2019-04-15T19:05:19  *** captjakk has quit IRC
456 2019-04-15T19:06:34  *** laptop500 has joined #bitcoin-core-dev
457 2019-04-15T19:08:53  *** hebasto has quit IRC
458 2019-04-15T19:13:15  *** Dean_Guss has quit IRC
459 2019-04-15T19:13:48  *** jarthur has joined #bitcoin-core-dev
460 2019-04-15T19:15:43  *** captjakk has joined #bitcoin-core-dev
461 2019-04-15T19:16:59  <luke-jr> getaddr isn't as big a deal over Tor, but I'd be at least a little concerned if we had address-seed servers getting direct connections
462 2019-04-15T19:20:00  <dongcarl> perhaps a stupid idea, but I think serving getaddr requests could benefit from process separation once we move over to that being the default
463 2019-04-15T19:21:31  <sipa> what does process separation have to do with this?
464 2019-04-15T19:27:46  *** jarthur has quit IRC
465 2019-04-15T19:28:22  <dongcarl> I'm probably thinking about this the wrong way, but I'm just thinking about how to make sure the address-seed servers don't get overwhelmed, and a bug there won't allow someone to populate addrman with malicious nodes.
466 2019-04-15T19:29:48  <gmaxwell> sounds like magical thinking
467 2019-04-15T19:30:51  *** scoop has quit IRC
468 2019-04-15T19:33:52  <dongcarl> gmaxwell: Well, I'm always open to hearing why my stupid ideas are stupid
469 2019-04-15T19:34:11  *** droark has quit IRC
470 2019-04-15T19:38:32  <gmaxwell> process seperation does a fairly limited, but useful thing-- isolates sub parts so they can crash and restart seperately and primarily puts code into seperate memory spaces so that bugs that cause information leaks don't see other codes data. None of that is implicated for getaddr.  If getaddr's logic is broken, it'll be broken regardless.  Getaddr is also exceptionally trivial.
471 2019-04-15T19:38:53  <gmaxwell> So it isn't like its more likely to have problems worse than any other network message.
472 2019-04-15T19:40:08  *** gw2 has quit IRC
473 2019-04-15T19:40:14  *** scoop has joined #bitcoin-core-dev
474 2019-04-15T19:41:49  <dongcarl> gmaxwell: Thanks for explaining, that makes sense!
475 2019-04-15T19:48:59  *** promag has joined #bitcoin-core-dev
476 2019-04-15T19:51:13  *** laptop500 has quit IRC
477 2019-04-15T19:52:43  *** timothy has quit IRC
478 2019-04-15T19:53:19  *** promag has quit IRC
479 2019-04-15T20:12:38  *** promag has joined #bitcoin-core-dev
480 2019-04-15T20:23:18  *** zaka has quit IRC
481 2019-04-15T20:28:09  *** bitcoin-git has joined #bitcoin-core-dev
482 2019-04-15T20:28:09  <bitcoin-git> [bitcoin] dongcarl opened pull request #15824: docs: Improve netbase comments (master...2019-04-netbase-comments) https://github.com/bitcoin/bitcoin/pull/15824
483 2019-04-15T20:28:10  *** bitcoin-git has left #bitcoin-core-dev
484 2019-04-15T20:44:31  *** promag has quit IRC
485 2019-04-15T20:54:59  *** promag has joined #bitcoin-core-dev
486 2019-04-15T20:59:50  *** jarthur has joined #bitcoin-core-dev
487 2019-04-15T21:03:19  *** drexl has quit IRC
488 2019-04-15T21:05:57  *** zaka has joined #bitcoin-core-dev
489 2019-04-15T21:07:00  *** bitcoin-git has joined #bitcoin-core-dev
490 2019-04-15T21:07:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/78295e97b8d3...598323911e93
491 2019-04-15T21:07:01  <bitcoin-git> bitcoin/master aa410c2 João Barbosa: rpc: Validate maxfeerate with AmountFromValue
492 2019-04-15T21:07:01  <bitcoin-git> bitcoin/master 5983239 MarcoFalke: Merge #15770: rpc: Validate maxfeerate with AmountFromValue
493 2019-04-15T21:07:03  *** bitcoin-git has left #bitcoin-core-dev
494 2019-04-15T21:07:49  *** bitcoin-git has joined #bitcoin-core-dev
495 2019-04-15T21:07:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15770: rpc: Validate maxfeerate with AmountFromValue (master...2019-04-maxfeerate) https://github.com/bitcoin/bitcoin/pull/15770
496 2019-04-15T21:07:50  *** bitcoin-git has left #bitcoin-core-dev
497 2019-04-15T21:21:56  *** captjakk has quit IRC
498 2019-04-15T21:33:24  *** promag has quit IRC
499 2019-04-15T21:33:48  *** Guyver2 has quit IRC
500 2019-04-15T21:34:43  *** zaka has quit IRC
501 2019-04-15T21:35:29  *** promag has joined #bitcoin-core-dev
502 2019-04-15T21:35:52  *** laptop500 has joined #bitcoin-core-dev
503 2019-04-15T21:37:04  *** zaka has joined #bitcoin-core-dev
504 2019-04-15T21:40:22  *** jarthur has quit IRC
505 2019-04-15T21:48:46  *** promag_ has joined #bitcoin-core-dev
506 2019-04-15T21:49:28  *** rex4539 has quit IRC
507 2019-04-15T22:12:50  *** dviola has joined #bitcoin-core-dev
508 2019-04-15T22:20:39  *** captjakk has joined #bitcoin-core-dev
509 2019-04-15T22:24:47  *** captjakk has quit IRC
510 2019-04-15T22:35:36  *** spinza has quit IRC
511 2019-04-15T22:49:08  *** captjakk has joined #bitcoin-core-dev
512 2019-04-15T22:51:02  *** dviola has quit IRC
513 2019-04-15T22:52:43  *** spinza has joined #bitcoin-core-dev
514 2019-04-15T23:10:58  *** scoop has quit IRC
515 2019-04-15T23:11:35  *** promag has quit IRC
516 2019-04-15T23:27:51  *** jimmysong has quit IRC
517 2019-04-15T23:29:01  *** bralyclo_ has joined #bitcoin-core-dev
518 2019-04-15T23:32:08  *** bralyclow has quit IRC
519 2019-04-15T23:38:51  *** EagleTM has quit IRC
520 2019-04-15T23:39:45  *** EagleTM has joined #bitcoin-core-dev
521 2019-04-15T23:42:18  *** bralyclo_ has quit IRC
522 2019-04-15T23:42:44  *** bralyclow has joined #bitcoin-core-dev
523 2019-04-15T23:51:00  *** EagleTM has quit IRC
524 2019-04-15T23:59:31  *** fanquake has quit IRC