1 2019-04-24T00:00:02  *** ericbsd1 has quit IRC
  2 2019-04-24T00:00:56  *** udecker has quit IRC
  3 2019-04-24T00:02:01  *** BlueMatt has quit IRC
  4 2019-04-24T00:02:13  *** Aaronvan_ has joined #bitcoin-core-dev
  5 2019-04-24T00:05:02  *** AaronvanW has quit IRC
  6 2019-04-24T00:07:12  *** promag has quit IRC
  7 2019-04-24T00:07:33  *** Cory has quit IRC
  8 2019-04-24T00:15:03  *** DeanGuss has joined #bitcoin-core-dev
  9 2019-04-24T00:15:11  *** phyll1s_work has joined #bitcoin-core-dev
 10 2019-04-24T00:20:04  *** Pasha has joined #bitcoin-core-dev
 11 2019-04-24T00:23:15  *** Pasha is now known as Cory
 12 2019-04-24T00:23:30  *** Jeff1212 has joined #bitcoin-core-dev
 13 2019-04-24T00:35:06  *** scoop has joined #bitcoin-core-dev
 14 2019-04-24T00:39:37  *** scoop has quit IRC
 15 2019-04-24T00:41:55  *** justanotheruser has quit IRC
 16 2019-04-24T00:45:39  *** DeanGuss has quit IRC
 17 2019-04-24T00:57:55  *** justanotheruser has joined #bitcoin-core-dev
 18 2019-04-24T01:03:29  *** tripleslash has quit IRC
 19 2019-04-24T01:09:56  *** lukedashjr has joined #bitcoin-core-dev
 20 2019-04-24T01:09:57  *** luke-jr has quit IRC
 21 2019-04-24T01:12:58  *** lukedashjr has quit IRC
 22 2019-04-24T01:13:01  *** scoop has joined #bitcoin-core-dev
 23 2019-04-24T01:13:17  *** luke-jr has joined #bitcoin-core-dev
 24 2019-04-24T01:17:27  *** Jeff1212 has quit IRC
 25 2019-04-24T01:22:48  *** michagogo has joined #bitcoin-core-dev
 26 2019-04-24T02:03:10  *** Zenton has joined #bitcoin-core-dev
 27 2019-04-24T02:16:25  *** ccdle12 has joined #bitcoin-core-dev
 28 2019-04-24T02:21:26  *** btcquant has joined #bitcoin-core-dev
 29 2019-04-24T02:22:08  *** spaced0ut has quit IRC
 30 2019-04-24T02:30:40  *** scoop has quit IRC
 31 2019-04-24T02:31:22  *** scoop has joined #bitcoin-core-dev
 32 2019-04-24T02:31:28  *** scoop has quit IRC
 33 2019-04-24T02:31:35  *** scoop has joined #bitcoin-core-dev
 34 2019-04-24T02:32:10  *** Victorsueca has joined #bitcoin-core-dev
 35 2019-04-24T02:32:59  *** Victor_sueca has quit IRC
 36 2019-04-24T02:35:25  *** scoop has quit IRC
 37 2019-04-24T02:35:41  *** scoop has joined #bitcoin-core-dev
 38 2019-04-24T02:41:48  *** scoop has quit IRC
 39 2019-04-24T02:42:15  *** scoop has joined #bitcoin-core-dev
 40 2019-04-24T02:42:44  *** scoop has quit IRC
 41 2019-04-24T02:42:52  *** scoop has joined #bitcoin-core-dev
 42 2019-04-24T02:52:31  *** scoop has quit IRC
 43 2019-04-24T02:54:36  *** scoop has joined #bitcoin-core-dev
 44 2019-04-24T02:57:45  *** scoop has quit IRC
 45 2019-04-24T03:00:01  *** phyll1s_work has quit IRC
 46 2019-04-24T03:02:13  *** scoop has joined #bitcoin-core-dev
 47 2019-04-24T03:02:16  *** scoop has quit IRC
 48 2019-04-24T03:02:23  *** scoop has joined #bitcoin-core-dev
 49 2019-04-24T03:04:31  *** scoop has quit IRC
 50 2019-04-24T03:04:58  *** scoop has joined #bitcoin-core-dev
 51 2019-04-24T03:08:41  *** Dieterbe1 has joined #bitcoin-core-dev
 52 2019-04-24T03:09:27  *** scoop has quit IRC
 53 2019-04-24T03:12:54  *** DeanGuss has joined #bitcoin-core-dev
 54 2019-04-24T03:18:34  *** spinza has quit IRC
 55 2019-04-24T03:27:20  *** btcquant has quit IRC
 56 2019-04-24T03:27:55  *** spinza has joined #bitcoin-core-dev
 57 2019-04-24T03:33:39  *** pinheadmz has quit IRC
 58 2019-04-24T03:37:02  *** pinheadmz has joined #bitcoin-core-dev
 59 2019-04-24T03:39:01  *** Cory has quit IRC
 60 2019-04-24T03:43:57  *** Pasha has joined #bitcoin-core-dev
 61 2019-04-24T03:47:09  *** Pasha is now known as Cory
 62 2019-04-24T04:02:58  *** instagibbs has quit IRC
 63 2019-04-24T04:10:27  *** hebasto has joined #bitcoin-core-dev
 64 2019-04-24T04:17:20  *** hebasto has quit IRC
 65 2019-04-24T04:18:11  *** ccdle12 has quit IRC
 66 2019-04-24T04:18:40  *** ccdle12 has joined #bitcoin-core-dev
 67 2019-04-24T05:49:21  *** dqx has quit IRC
 68 2019-04-24T05:51:39  *** teardown has quit IRC
 69 2019-04-24T05:52:25  *** teardown has joined #bitcoin-core-dev
 70 2019-04-24T05:55:14  *** pinheadmz has quit IRC
 71 2019-04-24T06:00:02  *** Dieterbe1 has quit IRC
 72 2019-04-24T06:04:11  *** armin76 has joined #bitcoin-core-dev
 73 2019-04-24T06:04:12  *** jeremyrubin has quit IRC
 74 2019-04-24T06:10:30  *** ccdle12 has joined #bitcoin-core-dev
 75 2019-04-24T06:24:43  *** dqx has joined #bitcoin-core-dev
 76 2019-04-24T06:38:48  *** ElePHPhant has joined #bitcoin-core-dev
 77 2019-04-24T06:39:13  <ElePHPhant> Can somebody please take a look at this question posted in 2014 which still applies today in 2019 for the latest stable Bitcoin Core on Windows? https://bitcoin.stackexchange.com/questions/23999/blocknotify-walletnotify-but-without-the-console-window
 78 2019-04-24T06:39:37  <ElePHPhant> This bug/issue/mistake/whatever-it-is is preventing me from running my Bitcoin payment system properly.
 79 2019-04-24T06:43:00  *** promag has joined #bitcoin-core-dev
 80 2019-04-24T06:44:50  *** promag has quit IRC
 81 2019-04-24T07:07:25  *** promag has joined #bitcoin-core-dev
 82 2019-04-24T07:14:56  *** promag has quit IRC
 83 2019-04-24T07:20:58  *** ccdle12 has quit IRC
 84 2019-04-24T07:36:56  *** csknk has joined #bitcoin-core-dev
 85 2019-04-24T07:40:33  <jonasschnelli> I think wallet notify should finally be replaced with something more flexible...
 86 2019-04-24T07:40:39  <jonasschnelli> #13262 was my attempt
 87 2019-04-24T07:40:42  <gribble> https://github.com/bitcoin/bitcoin/issues/13262 | Wallet/RPC: Add listsincetx method with a stateless (server-side) long polling option by jonasschnelli · Pull Request #13262 · bitcoin/bitcoin · GitHub
 88 2019-04-24T07:41:25  <jonasschnelli> That PR includes a python scripts that demonstrate the push function
 89 2019-04-24T07:41:41  <jonasschnelli> (with pure RPC usage)
 90 2019-04-24T07:42:59  <jonasschnelli> Since its stateless and similar to "listsinceblock",... missing transactions is really hard
 91 2019-04-24T08:21:14  <ElePHPhant> jonasschnelli: Well, I use the notify things purely to know *when* to immediately do the normal polling of data from the API.
 92 2019-04-24T08:21:22  <ElePHPhant> jonasschnelli: It's done regularly anyway.
 93 2019-04-24T08:21:32  <ElePHPhant> jonasschnelli: But those *notify things make it much snappier.
 94 2019-04-24T08:22:06  <ElePHPhant> Must take a walk to avoid going insane.
 95 2019-04-24T08:22:20  <ElePHPhant> Will come back soon.
 96 2019-04-24T08:22:38  *** ElePHPhant has quit IRC
 97 2019-04-24T08:31:24  *** elichai2 has joined #bitcoin-core-dev
 98 2019-04-24T08:38:53  <provoostenator> ElePHPhant jonasschnelli: related #15382 adds boost process as a dependency, which gives us more flexility on how to execute commands.
 99 2019-04-24T08:38:56  <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
100 2019-04-24T08:39:36  <provoostenator> The PR lists some alternative dependencies too. Maybe that can solve the Windows thing, but I have no idea.
101 2019-04-24T08:39:53  <provoostenator> (I solved all my Windows problems 10+ years ago)
102 2019-04-24T08:43:51  *** promag has joined #bitcoin-core-dev
103 2019-04-24T08:44:22  <sipa> provoostenator: by not using it anymore?
104 2019-04-24T08:44:49  *** ElePHPhant has joined #bitcoin-core-dev
105 2019-04-24T08:49:49  <ElePHPhant> Back.
106 2019-04-24T08:50:08  <ElePHPhant> jonasschnelli: What happened to your suggestion?
107 2019-04-24T08:50:20  <ElePHPhant> jonasschnelli: And will my bug be officially filed somehow now that I've reported it?
108 2019-04-24T08:50:58  <sipa> ElePHPhant: not if you don't file it
109 2019-04-24T08:51:12  <sipa> https://github.com/bitcoin/bitcoin/issues
110 2019-04-24T08:54:10  <sipa> seems there is a fix in that stackexchange answer too; seems like a no-brainer to apply it, but it'll need developing on windows to champion it
111 2019-04-24T08:54:28  <sipa> (even if just to know that it works)
112 2019-04-24T09:00:02  *** armin76 has quit IRC
113 2019-04-24T09:04:04  *** fnichol has joined #bitcoin-core-dev
114 2019-04-24T09:15:46  *** scoop has joined #bitcoin-core-dev
115 2019-04-24T09:17:05  *** jtimon has joined #bitcoin-core-dev
116 2019-04-24T09:20:18  *** scoop has quit IRC
117 2019-04-24T09:21:56  <ElePHPhant> sipa: Any chance you could file the issue for me? So it's done right?
118 2019-04-24T09:38:35  *** queip has quit IRC
119 2019-04-24T09:39:05  *** phwalkr has joined #bitcoin-core-dev
120 2019-04-24T09:39:48  *** rafalcpp has quit IRC
121 2019-04-24T09:39:53  *** rafalcpp_ has joined #bitcoin-core-dev
122 2019-04-24T09:51:37  *** rafalcpp has joined #bitcoin-core-dev
123 2019-04-24T09:52:34  *** rafalcpp_ has quit IRC
124 2019-04-24T09:56:02  *** meshcoll- has quit IRC
125 2019-04-24T09:56:56  *** meshcollider has joined #bitcoin-core-dev
126 2019-04-24T09:59:27  *** rafalcpp_ has joined #bitcoin-core-dev
127 2019-04-24T09:59:46  *** rafalcpp has quit IRC
128 2019-04-24T10:05:23  *** phwalkr has quit IRC
129 2019-04-24T10:05:57  *** queip has joined #bitcoin-core-dev
130 2019-04-24T10:16:13  *** DeanGuss has quit IRC
131 2019-04-24T10:16:26  *** DeanGuss has joined #bitcoin-core-dev
132 2019-04-24T10:28:22  *** promag has quit IRC
133 2019-04-24T10:31:31  *** promag has joined #bitcoin-core-dev
134 2019-04-24T10:32:37  *** promag_ has joined #bitcoin-core-dev
135 2019-04-24T10:32:37  *** promag has quit IRC
136 2019-04-24T10:45:35  *** spinza has quit IRC
137 2019-04-24T11:01:25  *** spinza has joined #bitcoin-core-dev
138 2019-04-24T11:07:20  *** ccdle12 has joined #bitcoin-core-dev
139 2019-04-24T11:15:50  *** AaronvanW has joined #bitcoin-core-dev
140 2019-04-24T11:53:00  *** jtimon has quit IRC
141 2019-04-24T11:55:06  *** needhelpplz has joined #bitcoin-core-dev
142 2019-04-24T11:59:02  *** Guyver2 has joined #bitcoin-core-dev
143 2019-04-24T12:00:02  *** fnichol has quit IRC
144 2019-04-24T12:02:54  *** promag_ has quit IRC
145 2019-04-24T12:03:19  *** promag has joined #bitcoin-core-dev
146 2019-04-24T12:05:03  *** MarconM has joined #bitcoin-core-dev
147 2019-04-24T12:05:08  *** bitcoin-git has joined #bitcoin-core-dev
148 2019-04-24T12:05:08  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15868: rpc: Add have_pruned to getblockchaininfo (master...1904-rpcPruned) https://github.com/bitcoin/bitcoin/pull/15868
149 2019-04-24T12:05:09  *** bitcoin-git has left #bitcoin-core-dev
150 2019-04-24T12:05:24  <ElePHPhant> Sigh... I guess not...
151 2019-04-24T12:14:47  <ElePHPhant> I created an issue myself now...
152 2019-04-24T12:29:38  *** promag has quit IRC
153 2019-04-24T12:35:27  *** scoop has joined #bitcoin-core-dev
154 2019-04-24T12:39:48  *** scoop has quit IRC
155 2019-04-24T12:40:56  *** setpill has joined #bitcoin-core-dev
156 2019-04-24T12:45:16  *** instagibbs has joined #bitcoin-core-dev
157 2019-04-24T13:01:57  *** promag has joined #bitcoin-core-dev
158 2019-04-24T13:06:21  *** promag has quit IRC
159 2019-04-24T13:25:53  *** promag has joined #bitcoin-core-dev
160 2019-04-24T13:29:19  *** spinza has quit IRC
161 2019-04-24T13:46:40  *** promag has quit IRC
162 2019-04-24T13:48:10  *** promag has joined #bitcoin-core-dev
163 2019-04-24T13:48:55  *** promag has joined #bitcoin-core-dev
164 2019-04-24T13:50:47  *** spinza has joined #bitcoin-core-dev
165 2019-04-24T13:53:26  *** scoop has joined #bitcoin-core-dev
166 2019-04-24T13:53:30  *** promag has quit IRC
167 2019-04-24T13:54:14  *** spaced0ut has joined #bitcoin-core-dev
168 2019-04-24T14:10:01  *** afk11 has quit IRC
169 2019-04-24T14:17:59  <waxwing> can i ask what the "traditional partial signatures format" referred to on this line is? https://github.com/bitcoin/bitcoin/blob/master/src/script/sign.h#L131
170 2019-04-24T14:19:36  *** promag has joined #bitcoin-core-dev
171 2019-04-24T14:19:55  *** promag_ has joined #bitcoin-core-dev
172 2019-04-24T14:22:21  *** promag has quit IRC
173 2019-04-24T14:22:42  *** luke-jr has quit IRC
174 2019-04-24T14:22:50  *** lukedashjr has joined #bitcoin-core-dev
175 2019-04-24T14:22:55  *** promag has joined #bitcoin-core-dev
176 2019-04-24T14:25:22  *** bralyclow has joined #bitcoin-core-dev
177 2019-04-24T14:25:30  *** promag has quit IRC
178 2019-04-24T14:26:08  *** scoop has quit IRC
179 2019-04-24T14:27:37  *** lukedashjr is now known as luke-jr
180 2019-04-24T14:29:33  *** luke-jr has quit IRC
181 2019-04-24T14:30:01  *** luke-jr has joined #bitcoin-core-dev
182 2019-04-24T14:34:16  *** promag has joined #bitcoin-core-dev
183 2019-04-24T14:36:06  *** promag has quit IRC
184 2019-04-24T14:37:30  *** ElePHPhant has quit IRC
185 2019-04-24T14:40:16  *** scoop has joined #bitcoin-core-dev
186 2019-04-24T14:40:48  <cfields> wumpus: fyi, I'll be away and unable to sign releases Friday-Tuesday. Headed to Boston to sign the docs for our new place there :)
187 2019-04-24T14:42:53  <instagibbs> anyone know why data carrier outputs have to be push-only in relay policy?
188 2019-04-24T14:43:18  *** bralyclow has quit IRC
189 2019-04-24T14:43:19  <instagibbs> seems wasteful for no reason
190 2019-04-24T14:43:20  <harding> waxwing: I think it's just talking about when you have fewer than the needed number of signatures.   E.g., you need 2 signatures but you call signrawtransactionwithprivatekey (or whatever untweetable name it has) with only one key.  You'll get your input transaction returned back to you with the push of just that single signature in it and an "incomplete" flag in a separate field.
191 2019-04-24T14:44:09  <harding> waxwing: I don't think it means partial in the sense of less-than-one signatures.
192 2019-04-24T14:47:07  *** scoop has quit IRC
193 2019-04-24T14:48:36  <harding> instagibbs: maybe to avoid people putting CHECKSIG-type opcodes in there that would count towards the block's sigop limit even though we know they'd never be evaluated (and that counting sigops in scriptPubKeys is wrong)?
194 2019-04-24T14:49:01  <instagibbs> harding, ehhh just count those then :) (good point regardless)
195 2019-04-24T14:49:40  <instagibbs> it would also mess with the "virtual size" right?
196 2019-04-24T14:51:01  *** lukedashjr has joined #bitcoin-core-dev
197 2019-04-24T14:53:18  *** setpill has quit IRC
198 2019-04-24T14:53:48  *** luke-jr has quit IRC
199 2019-04-24T14:55:31  *** lukedashjr is now known as luke-jr
200 2019-04-24T14:58:05  <waxwing> harding, makes sense thanks. i always end up looking up the difference between witnessscript and scriptwitness hence i end up there, the question was only tangential :)
201 2019-04-24T14:58:08  *** scoop has joined #bitcoin-core-dev
202 2019-04-24T14:59:32  *** scoop has quit IRC
203 2019-04-24T15:00:02  *** MarconM has quit IRC
204 2019-04-24T15:00:18  *** scoop has joined #bitcoin-core-dev
205 2019-04-24T15:01:55  *** luke-jr has quit IRC
206 2019-04-24T15:02:16  *** luke-jr has joined #bitcoin-core-dev
207 2019-04-24T15:03:13  *** kees1 has joined #bitcoin-core-dev
208 2019-04-24T15:04:48  *** scoop has quit IRC
209 2019-04-24T15:06:11  *** promag_ has quit IRC
210 2019-04-24T15:16:38  *** scoop has joined #bitcoin-core-dev
211 2019-04-24T15:20:21  *** bitcoin-git has joined #bitcoin-core-dev
212 2019-04-24T15:20:21  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15858: Faster tests with topological mempool rpc sync 🚀 (master...1904-qaSync) https://github.com/bitcoin/bitcoin/pull/15858
213 2019-04-24T15:20:22  *** bitcoin-git has left #bitcoin-core-dev
214 2019-04-24T15:21:51  *** scoop has quit IRC
215 2019-04-24T15:26:47  *** scoop has joined #bitcoin-core-dev
216 2019-04-24T15:27:35  *** scoop has quit IRC
217 2019-04-24T15:38:42  *** luke-jr has quit IRC
218 2019-04-24T15:38:58  *** Aaronvan_ has joined #bitcoin-core-dev
219 2019-04-24T15:42:07  *** AaronvanW has quit IRC
220 2019-04-24T15:48:25  *** scoop has joined #bitcoin-core-dev
221 2019-04-24T15:49:25  *** AaronvanW has joined #bitcoin-core-dev
222 2019-04-24T15:52:14  *** jarthur has joined #bitcoin-core-dev
223 2019-04-24T15:52:32  *** Aaronvan_ has quit IRC
224 2019-04-24T15:56:30  *** scoop has quit IRC
225 2019-04-24T15:59:19  *** luke-jr has joined #bitcoin-core-dev
226 2019-04-24T15:59:56  *** pinheadmz has joined #bitcoin-core-dev
227 2019-04-24T16:14:57  *** ccdle12 has quit IRC
228 2019-04-24T16:17:00  *** ccdle12 has joined #bitcoin-core-dev
229 2019-04-24T16:21:02  *** jarthur has quit IRC
230 2019-04-24T16:21:36  *** ccdle12 has quit IRC
231 2019-04-24T16:25:13  *** Aaronvan_ has joined #bitcoin-core-dev
232 2019-04-24T16:27:28  *** scoop has joined #bitcoin-core-dev
233 2019-04-24T16:27:39  *** AaronvanW has quit IRC
234 2019-04-24T16:28:14  *** jarthur has joined #bitcoin-core-dev
235 2019-04-24T16:32:58  *** jarthur has quit IRC
236 2019-04-24T16:35:22  *** scoop has quit IRC
237 2019-04-24T16:44:36  *** scoop has joined #bitcoin-core-dev
238 2019-04-24T16:45:57  *** jarthur has joined #bitcoin-core-dev
239 2019-04-24T16:48:48  *** scoop has quit IRC
240 2019-04-24T16:51:21  *** scoop has joined #bitcoin-core-dev
241 2019-04-24T16:52:53  *** brianhoffman_ has joined #bitcoin-core-dev
242 2019-04-24T16:55:24  *** brianhoffman has quit IRC
243 2019-04-24T16:55:25  *** brianhoffman_ is now known as brianhoffman
244 2019-04-24T16:56:42  *** scoop has quit IRC
245 2019-04-24T16:57:30  *** promag has joined #bitcoin-core-dev
246 2019-04-24T16:58:57  *** promag_ has joined #bitcoin-core-dev
247 2019-04-24T17:01:48  *** promag has quit IRC
248 2019-04-24T17:03:33  *** promag_ has quit IRC
249 2019-04-24T17:10:10  *** owowo has quit IRC
250 2019-04-24T17:11:22  *** owowo has joined #bitcoin-core-dev
251 2019-04-24T17:18:48  *** promag has joined #bitcoin-core-dev
252 2019-04-24T17:24:23  *** scoop has joined #bitcoin-core-dev
253 2019-04-24T17:25:42  *** elichai2 has quit IRC
254 2019-04-24T17:28:57  *** scoop has quit IRC
255 2019-04-24T17:30:40  <dongcarl>  w/re #15717, I wish to stop confusing the poor man. I think we should make it a shared library dependency just as we do with `miniupnp`, in that case, we should not submit any more reviews on the subtree-d code which should be removed and make it clear that we really need is another depends package.
256 2019-04-24T17:30:42  <gribble> https://github.com/bitcoin/bitcoin/issues/15717 | Changes to support NAT-PMP by MishraShivendra · Pull Request #15717 · bitcoin/bitcoin · GitHub
257 2019-04-24T17:32:33  <dongcarl> My reading of #11902 was that we'll keep uPNP as an option that's off by default, and introduce NAT-PMP as ON by default, which I'm not sure how I feel about. wumpus perhaps you can enlighten me?
258 2019-04-24T17:32:35  <gribble> https://github.com/bitcoin/bitcoin/issues/11902 | NAT-PMP port forwarding support · Issue #11902 · bitcoin/bitcoin · GitHub
259 2019-04-24T17:35:28  <gmaxwell> dongcarl: do you think wumpus is your shrink? you appear to be asking him to advise you on your feelings. :)
260 2019-04-24T17:36:54  <dongcarl> Hahahaha well... I guess more concretely I'm asking for any info I might be missing :-)
261 2019-04-24T17:36:58  <gmaxwell> miniupnp library is a security disaster-- adhoc xml parsing using lulzical pointer frobbing, nothing has changed about that AFAIK.
262 2019-04-24T17:37:24  * dongcarl adds lulzical pointer frobber to his list of insults
263 2019-04-24T17:38:20  <gmaxwell> And thats pretty bad since by its very nature its exposed to untrustworthy network inputs ... So we're unwilling to enable it by default because it continues to look like a timebomb.
264 2019-04-24T17:38:36  <dongcarl> that makes sense for sure
265 2019-04-24T17:39:06  *** scoop has joined #bitcoin-core-dev
266 2019-04-24T17:40:20  <gmaxwell> (Ideally we'd replace the library with something that isn't so terror inducing, but at least when we looked before there wasn't anything.. in part because upnp is an awful spec...)
267 2019-04-24T17:40:52  <dongcarl> So given that NAT-PMP is a much simpler protocol that's harder to footgun, we can enable it by default, because if someone's got a NAT-PMP server on their gateway they're most likely okay with auto-port forwarding?
268 2019-04-24T17:43:48  *** scoop has quit IRC
269 2019-04-24T17:46:22  *** hebasto has joined #bitcoin-core-dev
270 2019-04-24T17:51:19  *** DeanGuss has quit IRC
271 2019-04-24T17:58:06  *** jannes has joined #bitcoin-core-dev
272 2019-04-24T18:00:01  *** kees1 has quit IRC
273 2019-04-24T18:04:30  *** promag has quit IRC
274 2019-04-24T18:05:25  <gmaxwell> dongcarl: the on/off by default dosn't have anything to do with being okay with port forwarding.
275 2019-04-24T18:05:58  <gmaxwell> It's entirely because of the multiple past RCE bugs in that particular library and the codebase that looks like it'll have more in the future.
276 2019-04-24T18:07:59  *** scoop has joined #bitcoin-core-dev
277 2019-04-24T18:08:44  *** kerbyu has joined #bitcoin-core-dev
278 2019-04-24T18:09:24  *** scoop has quit IRC
279 2019-04-24T18:09:58  *** scoop has joined #bitcoin-core-dev
280 2019-04-24T18:14:57  *** scoop has quit IRC
281 2019-04-24T18:29:16  *** promag has joined #bitcoin-core-dev
282 2019-04-24T18:32:30  *** BlueMatt has joined #bitcoin-core-dev
283 2019-04-24T18:34:35  *** promag has quit IRC
284 2019-04-24T18:39:34  *** promag has joined #bitcoin-core-dev
285 2019-04-24T18:40:32  *** scoop has joined #bitcoin-core-dev
286 2019-04-24T18:43:12  *** promag has quit IRC
287 2019-04-24T18:43:13  *** dbcx has joined #bitcoin-core-dev
288 2019-04-24T18:45:13  *** scoop has quit IRC
289 2019-04-24T18:54:36  *** needhelpplz has quit IRC
290 2019-04-24T19:02:00  *** lnostdal has quit IRC
291 2019-04-24T19:24:07  *** scoop has joined #bitcoin-core-dev
292 2019-04-24T19:36:15  *** promag has joined #bitcoin-core-dev
293 2019-04-24T19:37:07  <dongcarl> gmaxwell: Okay, so should NAT-PMP be on by default or no?
294 2019-04-24T20:10:17  *** scoop has quit IRC
295 2019-04-24T20:13:12  *** BlueMatt has quit IRC
296 2019-04-24T20:14:09  <gmaxwell> Yes
297 2019-04-24T20:15:53  <gmaxwell> dongcarl: it should be on by default, unless turned off-- and solf-set off by discover being off (either directly off, or indirectly off via listen off)
298 2019-04-24T20:15:59  *** promag has quit IRC
299 2019-04-24T20:25:53  *** pinheadmz has quit IRC
300 2019-04-24T20:27:35  *** DeanGuss has joined #bitcoin-core-dev
301 2019-04-24T20:29:34  <dongcarl> gmaxwell: Roger
302 2019-04-24T20:29:55  *** csknk has quit IRC
303 2019-04-24T20:30:14  *** pinheadmz has joined #bitcoin-core-dev
304 2019-04-24T20:32:26  *** Guyver2 has quit IRC
305 2019-04-24T20:35:48  *** scoop has joined #bitcoin-core-dev
306 2019-04-24T20:35:59  <gmaxwell> soft*
307 2019-04-24T20:37:19  *** owowo has quit IRC
308 2019-04-24T20:40:37  *** scoop has quit IRC
309 2019-04-24T20:41:18  *** scoop has joined #bitcoin-core-dev
310 2019-04-24T20:43:10  *** jaybny has joined #bitcoin-core-dev
311 2019-04-24T20:43:42  *** owowo has joined #bitcoin-core-dev
312 2019-04-24T20:45:58  *** scoop has quit IRC
313 2019-04-24T20:49:03  *** bitcoin-git has joined #bitcoin-core-dev
314 2019-04-24T20:49:04  <bitcoin-git> [bitcoin] hebasto opened pull request #15886: qt, wallet: Revamp SendConfirmationDialog (master...20190424-send-confirmation-dialog) https://github.com/bitcoin/bitcoin/pull/15886
315 2019-04-24T20:49:05  *** bitcoin-git has left #bitcoin-core-dev
316 2019-04-24T20:49:20  *** scoop has joined #bitcoin-core-dev
317 2019-04-24T20:53:02  *** jaybny has left #bitcoin-core-dev
318 2019-04-24T20:53:19  *** jannes has quit IRC
319 2019-04-24T20:56:59  *** jaybny has joined #bitcoin-core-dev
320 2019-04-24T20:58:05  *** promag has joined #bitcoin-core-dev
321 2019-04-24T21:00:02  *** kerbyu has quit IRC
322 2019-04-24T21:02:07  *** promag has quit IRC
323 2019-04-24T21:03:02  *** AaronvanW has joined #bitcoin-core-dev
324 2019-04-24T21:05:54  *** Aaronvan_ has quit IRC
325 2019-04-24T21:11:21  *** UltimateNate has joined #bitcoin-core-dev
326 2019-04-24T21:22:19  *** promag has joined #bitcoin-core-dev
327 2019-04-24T21:24:19  *** bitcoin-git has joined #bitcoin-core-dev
328 2019-04-24T21:24:19  <bitcoin-git> [bitcoin] hebasto opened pull request #15887: docs: Align code example style with clang-format (master...20190424-coding-style) https://github.com/bitcoin/bitcoin/pull/15887
329 2019-04-24T21:24:32  *** bitcoin-git has left #bitcoin-core-dev
330 2019-04-24T21:34:54  *** scoop has quit IRC
331 2019-04-24T21:35:21  *** scoop has joined #bitcoin-core-dev
332 2019-04-24T21:39:17  *** hebasto has quit IRC
333 2019-04-24T21:39:36  *** scoop has quit IRC
334 2019-04-24T21:59:55  *** jarthur has quit IRC
335 2019-04-24T22:01:01  *** spinza has quit IRC
336 2019-04-24T22:01:34  *** jb55 has quit IRC
337 2019-04-24T22:07:35  *** cazyjoker96 has joined #bitcoin-core-dev
338 2019-04-24T22:13:46  *** scoop has joined #bitcoin-core-dev
339 2019-04-24T22:14:15  *** DeanGuss has quit IRC
340 2019-04-24T22:19:37  *** davec has quit IRC
341 2019-04-24T22:20:47  *** spinza has joined #bitcoin-core-dev
342 2019-04-24T22:21:48  *** davec has joined #bitcoin-core-dev
343 2019-04-24T22:27:54  *** Aaronvan_ has joined #bitcoin-core-dev
344 2019-04-24T22:28:42  *** jb55 has joined #bitcoin-core-dev
345 2019-04-24T22:31:18  *** AaronvanW has quit IRC
346 2019-04-24T22:42:15  *** promag_ has joined #bitcoin-core-dev
347 2019-04-24T22:58:01  *** promag has quit IRC
348 2019-04-24T22:58:25  *** promag has joined #bitcoin-core-dev
349 2019-04-24T23:00:51  *** promag has quit IRC
350 2019-04-24T23:33:31  *** davec has quit IRC
351 2019-04-24T23:34:57  *** davec has joined #bitcoin-core-dev
352 2019-04-24T23:36:56  *** shesek has quit IRC
353 2019-04-24T23:38:11  *** afk11 has joined #bitcoin-core-dev
354 2019-04-24T23:39:16  *** afk11 has joined #bitcoin-core-dev
355 2019-04-24T23:42:40  *** afk11 has quit IRC
356 2019-04-24T23:50:05  *** shesek has joined #bitcoin-core-dev
357 2019-04-24T23:50:05  *** shesek has joined #bitcoin-core-dev
358 2019-04-24T23:58:05  *** dviola has joined #bitcoin-core-dev
359 2019-04-24T23:58:13  *** shesek has quit IRC