1 2019-04-30T00:00:02  *** gde331 has quit IRC
  2 2019-04-30T00:06:39  *** torax has joined #bitcoin-core-dev
  3 2019-04-30T00:08:22  *** scoop has quit IRC
  4 2019-04-30T00:10:44  *** scoop has joined #bitcoin-core-dev
  5 2019-04-30T00:11:46  *** BlueMatt has joined #bitcoin-core-dev
  6 2019-04-30T00:15:08  *** scoop has quit IRC
  7 2019-04-30T00:25:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  8 2019-04-30T00:30:07  *** fanquake has joined #bitcoin-core-dev
  9 2019-04-30T00:31:48  *** BlueMatt has quit IRC
 10 2019-04-30T00:32:42  *** BlueMatt has joined #bitcoin-core-dev
 11 2019-04-30T00:34:00  *** pinheadmz has quit IRC
 12 2019-04-30T00:34:34  *** scoop has joined #bitcoin-core-dev
 13 2019-04-30T00:39:11  *** scoop has quit IRC
 14 2019-04-30T00:42:52  *** scoop has joined #bitcoin-core-dev
 15 2019-04-30T00:44:31  *** BlueMatt_ has joined #bitcoin-core-dev
 16 2019-04-30T00:45:04  *** BlueMatt has quit IRC
 17 2019-04-30T00:54:19  *** EagleTM has joined #bitcoin-core-dev
 18 2019-04-30T01:01:11  *** BlueMatt has joined #bitcoin-core-dev
 19 2019-04-30T01:01:12  *** BlueMatt_ has quit IRC
 20 2019-04-30T01:01:25  *** Chris_Stewart_5 has quit IRC
 21 2019-04-30T01:02:56  *** scoop has quit IRC
 22 2019-04-30T01:03:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 23 2019-04-30T01:10:50  *** dviola has quit IRC
 24 2019-04-30T01:14:05  *** scoop has joined #bitcoin-core-dev
 25 2019-04-30T01:23:13  *** scoop has quit IRC
 26 2019-04-30T01:23:41  *** scoop has joined #bitcoin-core-dev
 27 2019-04-30T01:23:49  *** scoop has quit IRC
 28 2019-04-30T01:23:55  *** scoop has joined #bitcoin-core-dev
 29 2019-04-30T01:30:22  *** Chris_Stewart_5 has quit IRC
 30 2019-04-30T01:56:02  *** ccdle12 has quit IRC
 31 2019-04-30T01:56:32  *** Victorsueca has quit IRC
 32 2019-04-30T01:58:41  *** Victorsueca has joined #bitcoin-core-dev
 33 2019-04-30T02:02:08  *** promag_ has quit IRC
 34 2019-04-30T02:02:55  *** dviola has joined #bitcoin-core-dev
 35 2019-04-30T02:03:49  *** DeanGuss has quit IRC
 36 2019-04-30T02:36:06  *** promag_ has joined #bitcoin-core-dev
 37 2019-04-30T02:40:42  *** promag_ has quit IRC
 38 2019-04-30T03:00:02  *** torax has quit IRC
 39 2019-04-30T03:04:03  *** pinheadmz has joined #bitcoin-core-dev
 40 2019-04-30T03:09:47  *** DeanGuss has joined #bitcoin-core-dev
 41 2019-04-30T03:16:01  *** xHire has quit IRC
 42 2019-04-30T03:21:27  *** dgilmore1 has joined #bitcoin-core-dev
 43 2019-04-30T03:24:01  *** xHire has joined #bitcoin-core-dev
 44 2019-04-30T03:35:09  *** Eagle[TM] has joined #bitcoin-core-dev
 45 2019-04-30T03:37:07  *** EagleTM has quit IRC
 46 2019-04-30T03:47:18  *** scoop has quit IRC
 47 2019-04-30T03:47:56  *** scoop has joined #bitcoin-core-dev
 48 2019-04-30T04:08:59  *** spinza has quit IRC
 49 2019-04-30T04:09:43  *** pinheadmz has quit IRC
 50 2019-04-30T04:13:01  *** ccdle12 has joined #bitcoin-core-dev
 51 2019-04-30T04:24:27  *** spinza has joined #bitcoin-core-dev
 52 2019-04-30T04:30:27  *** DeanGuss has quit IRC
 53 2019-04-30T04:30:58  *** DeanGuss has joined #bitcoin-core-dev
 54 2019-04-30T04:43:18  *** blockguru has joined #bitcoin-core-dev
 55 2019-04-30T04:50:57  *** ccdle12 has quit IRC
 56 2019-04-30T04:57:08  *** scoop has quit IRC
 57 2019-04-30T05:17:23  *** justanotheruser has quit IRC
 58 2019-04-30T05:53:17  *** scoop has joined #bitcoin-core-dev
 59 2019-04-30T05:57:45  *** scoop has quit IRC
 60 2019-04-30T05:59:27  *** ccdle12 has joined #bitcoin-core-dev
 61 2019-04-30T06:00:02  *** dgilmore1 has quit IRC
 62 2019-04-30T06:00:04  <wumpus> jnewbery: yes, 15141 looks pretty much ready
 63 2019-04-30T06:04:24  *** Cotillion has joined #bitcoin-core-dev
 64 2019-04-30T06:05:56  *** pinheadmz has joined #bitcoin-core-dev
 65 2019-04-30T06:24:57  *** Eagle[TM] has quit IRC
 66 2019-04-30T06:26:31  *** hebasto has joined #bitcoin-core-dev
 67 2019-04-30T06:36:17  *** niska has quit IRC
 68 2019-04-30T06:42:47  <wumpus> jamesob: ok with me
 69 2019-04-30T06:44:21  *** ccdle12 has quit IRC
 70 2019-04-30T06:45:05  <fanquake> jamesob / wumpus I've created the two. Will add related issues/card etc.
 71 2019-04-30T06:45:41  <wumpus> fanquake: oh that's awesome!
 72 2019-04-30T06:47:28  <fanquake> Sounds like james is going to split 15606 up quite a bit, so can dump all that in there shortly
 73 2019-04-30T06:47:37  *** niska has joined #bitcoin-core-dev
 74 2019-04-30T06:50:25  *** roconnor has quit IRC
 75 2019-04-30T06:51:23  <fanquake> ryanofsky if you've got PRs / issues you want added to https://github.com/bitcoin/bitcoin/projects/10 just dump them in here
 76 2019-04-30T06:51:37  *** promag_ has joined #bitcoin-core-dev
 77 2019-04-30T06:53:33  *** pinheadmz has quit IRC
 78 2019-04-30T06:54:13  <wumpus> weird test failure: https://github.com/bitcoin/bitcoin/pull/15141#issuecomment-487835088
 79 2019-04-30T06:54:29  <wumpus> how is 'shutting down' even an error
 80 2019-04-30T06:54:56  <wumpus> I guess, because it shuts down unexpectedly
 81 2019-04-30T06:57:04  <wumpus> the thread doesn't exit in 5 seconds-should be plenty of time, normally, though it's a slow system
 82 2019-04-30T07:01:56  *** fanquake has quit IRC
 83 2019-04-30T07:31:52  *** promag_ has quit IRC
 84 2019-04-30T07:35:15  *** EagleTM has joined #bitcoin-core-dev
 85 2019-04-30T07:40:07  *** fanquake has joined #bitcoin-core-dev
 86 2019-04-30T07:56:31  *** setpill has joined #bitcoin-core-dev
 87 2019-04-30T08:03:09  <wumpus> re: #15141 "ValidationInvalidReason::TX_PREMATURE_SPEND is non-standard in AcceptToMemoryPoolWorker (two occurences) but invalid in Consensus::CheckTxInputs" this one is pretty weird isn't it?
 88 2019-04-30T08:03:13  <gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
 89 2019-04-30T08:10:28  *** Aaronvan_ has joined #bitcoin-core-dev
 90 2019-04-30T08:11:53  *** laptop500 has joined #bitcoin-core-dev
 91 2019-04-30T08:12:58  *** AaronvanW has quit IRC
 92 2019-04-30T08:19:28  *** dermoth has quit IRC
 93 2019-04-30T08:32:39  *** timothy has joined #bitcoin-core-dev
 94 2019-04-30T08:34:38  *** Guyver2 has joined #bitcoin-core-dev
 95 2019-04-30T08:59:10  *** nanotube has quit IRC
 96 2019-04-30T09:00:35  *** Cotillion has quit IRC
 97 2019-04-30T09:04:31  *** wgolden has joined #bitcoin-core-dev
 98 2019-04-30T09:20:06  *** promag_ has joined #bitcoin-core-dev
 99 2019-04-30T09:21:53  *** promag_ has quit IRC
100 2019-04-30T09:23:09  *** promag_ has joined #bitcoin-core-dev
101 2019-04-30T09:24:50  *** dviola has quit IRC
102 2019-04-30T09:34:09  <wumpus> how are things looking for 0.18.0 final today?
103 2019-04-30T09:37:51  <fanquake> wumpus Looking ok. Discussion in #15555 has dried up a bit. #15665 is still open, but no more reports of it occurring.
104 2019-04-30T09:37:54  <gribble> https://github.com/bitcoin/bitcoin/issues/15555 | v0.18.0 testing · Issue #15555 · bitcoin/bitcoin · GitHub
105 2019-04-30T09:37:55  <gribble> https://github.com/bitcoin/bitcoin/issues/15665 | 0.18.0 rc2 CPU spike in thread bitcoin-opencon · Issue #15665 · bitcoin/bitcoin · GitHub
106 2019-04-30T09:38:22  <fanquake> Release is currently only 1 month "overdue" according to #14438 :p
107 2019-04-30T09:38:23  <gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub
108 2019-04-30T09:38:26  *** elichai2 has joined #bitcoin-core-dev
109 2019-04-30T09:38:32  *** kljasdfvv has joined #bitcoin-core-dev
110 2019-04-30T09:51:25  *** vab has joined #bitcoin-core-dev
111 2019-04-30T09:58:06  *** scoop has joined #bitcoin-core-dev
112 2019-04-30T10:02:40  *** scoop has quit IRC
113 2019-04-30T10:04:48  *** spinza has quit IRC
114 2019-04-30T10:08:16  *** Guest42 has joined #bitcoin-core-dev
115 2019-04-30T10:10:04  *** dermoth has joined #bitcoin-core-dev
116 2019-04-30T10:10:10  *** promag_ has quit IRC
117 2019-04-30T10:10:39  *** promag_ has joined #bitcoin-core-dev
118 2019-04-30T10:15:21  *** spinza has joined #bitcoin-core-dev
119 2019-04-30T10:20:11  *** dviola has joined #bitcoin-core-dev
120 2019-04-30T10:24:45  *** promag_ has quit IRC
121 2019-04-30T10:36:24  *** promag_ has joined #bitcoin-core-dev
122 2019-04-30T10:38:52  *** promag_ has quit IRC
123 2019-04-30T10:42:47  *** nanotube has joined #bitcoin-core-dev
124 2019-04-30T10:54:51  *** blockguru has quit IRC
125 2019-04-30T11:09:22  *** promag_ has joined #bitcoin-core-dev
126 2019-04-30T11:14:25  *** EagleTM has quit IRC
127 2019-04-30T11:15:34  *** dcousens has joined #bitcoin-core-dev
128 2019-04-30T11:26:43  <jamesob> fanquake: thanks!
129 2019-04-30T11:27:32  <fanquake> jamesob np
130 2019-04-30T11:27:47  *** dcousens has quit IRC
131 2019-04-30T11:28:05  *** dcousens has joined #bitcoin-core-dev
132 2019-04-30T11:30:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
133 2019-04-30T11:34:38  *** dcousens has quit IRC
134 2019-04-30T11:34:57  *** dcousens has joined #bitcoin-core-dev
135 2019-04-30T11:41:51  *** SopaXorzTaker has joined #bitcoin-core-dev
136 2019-04-30T11:41:55  *** dcousens has quit IRC
137 2019-04-30T11:47:08  *** SopaXorzTaker has quit IRC
138 2019-04-30T11:49:37  *** Chris_Stewart_5 has quit IRC
139 2019-04-30T11:51:08  <wumpus> fanquake: looks like the release notes issues were also fixed, time to tag then !
140 2019-04-30T11:52:46  *** setpill has quit IRC
141 2019-04-30T11:55:02  <fanquake> wumpus \o/
142 2019-04-30T11:59:56  *** SopaXorzTaker has joined #bitcoin-core-dev
143 2019-04-30T12:00:02  *** wgolden has quit IRC
144 2019-04-30T12:11:37  *** kireguy has joined #bitcoin-core-dev
145 2019-04-30T12:12:22  *** bitcoin-git has joined #bitcoin-core-dev
146 2019-04-30T12:12:22  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/825ecb5758f6...2472733a24a9
147 2019-04-30T12:12:22  <bitcoin-git> bitcoin/0.18 2472733 Wladimir J. van der Laan: build: Bump version to -final
148 2019-04-30T12:12:24  *** bitcoin-git has left #bitcoin-core-dev
149 2019-04-30T12:14:46  *** bitcoin-git has joined #bitcoin-core-dev
150 2019-04-30T12:14:46  <bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0: https://github.com/bitcoin/bitcoin/compare/v0.18.0
151 2019-04-30T12:14:47  *** bitcoin-git has left #bitcoin-core-dev
152 2019-04-30T12:24:04  *** vab has quit IRC
153 2019-04-30T12:26:17  *** promag_ has quit IRC
154 2019-04-30T12:26:54  *** promag_ has joined #bitcoin-core-dev
155 2019-04-30T12:30:26  *** promag_ has quit IRC
156 2019-04-30T12:36:36  *** dcousens has joined #bitcoin-core-dev
157 2019-04-30T13:05:25  *** Dukew has joined #bitcoin-core-dev
158 2019-04-30T13:09:43  *** Dukew has quit IRC
159 2019-04-30T13:12:32  *** queip has quit IRC
160 2019-04-30T13:14:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
161 2019-04-30T13:14:40  *** rafalcpp has quit IRC
162 2019-04-30T13:14:54  *** rafalcpp has joined #bitcoin-core-dev
163 2019-04-30T13:29:38  *** queip has joined #bitcoin-core-dev
164 2019-04-30T13:30:19  *** scoop has joined #bitcoin-core-dev
165 2019-04-30T13:34:30  *** scoop has quit IRC
166 2019-04-30T13:47:31  *** Aaronvan_ is now known as AaronvanW
167 2019-04-30T14:09:41  *** spaced0ut_ has joined #bitcoin-core-dev
168 2019-04-30T14:11:29  *** spaced0ut has quit IRC
169 2019-04-30T14:12:00  *** bitcoin-git has joined #bitcoin-core-dev
170 2019-04-30T14:12:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ce6762030f81...45d8b7177851
171 2019-04-30T14:12:01  <bitcoin-git> bitcoin/master 8728a66 John Newbery: [tests] fix block time in feature_pruning.py
172 2019-04-30T14:12:02  <bitcoin-git> bitcoin/master fafb55e MarcoFalke: [qa] test_runner: Move feature_pruning to base tests
173 2019-04-30T14:12:02  <bitcoin-git> bitcoin/master 45d8b71 MarcoFalke: Merge #15696: [qa] test_runner: Move feature_pruning to base tests
174 2019-04-30T14:12:04  *** bitcoin-git has left #bitcoin-core-dev
175 2019-04-30T14:12:44  *** bitcoin-git has joined #bitcoin-core-dev
176 2019-04-30T14:12:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15696: [qa] test_runner: Move feature_pruning to base tests (master...1904-qaPruning) https://github.com/bitcoin/bitcoin/pull/15696
177 2019-04-30T14:12:45  *** bitcoin-git has left #bitcoin-core-dev
178 2019-04-30T14:27:49  *** SopaXorzTaker has quit IRC
179 2019-04-30T14:39:16  *** scoop has joined #bitcoin-core-dev
180 2019-04-30T14:48:07  *** promag_ has joined #bitcoin-core-dev
181 2019-04-30T14:50:52  *** promag_ has quit IRC
182 2019-04-30T14:51:01  *** MrPaz has joined #bitcoin-core-dev
183 2019-04-30T15:00:01  *** kireguy has quit IRC
184 2019-04-30T15:06:09  *** promag_ has joined #bitcoin-core-dev
185 2019-04-30T15:08:47  *** promag_ has quit IRC
186 2019-04-30T15:10:23  *** scoop has quit IRC
187 2019-04-30T15:10:50  *** scoop has joined #bitcoin-core-dev
188 2019-04-30T15:11:20  *** pleia21 has joined #bitcoin-core-dev
189 2019-04-30T15:27:23  *** cubancorona2 has joined #bitcoin-core-dev
190 2019-04-30T15:27:41  *** booyah has quit IRC
191 2019-04-30T15:27:59  *** booyah has joined #bitcoin-core-dev
192 2019-04-30T15:30:21  *** cubancorona has quit IRC
193 2019-04-30T15:32:52  *** ExEric3 has quit IRC
194 2019-04-30T15:33:04  *** ExEric3 has joined #bitcoin-core-dev
195 2019-04-30T15:33:11  *** booyah has quit IRC
196 2019-04-30T15:33:19  *** booyah has joined #bitcoin-core-dev
197 2019-04-30T15:34:09  *** promag_ has joined #bitcoin-core-dev
198 2019-04-30T15:35:36  *** davterra has quit IRC
199 2019-04-30T15:37:31  *** Chris_Stewart_5 has quit IRC
200 2019-04-30T15:38:00  *** profmac has quit IRC
201 2019-04-30T15:39:21  *** promag_ has quit IRC
202 2019-04-30T15:39:47  *** promag_ has joined #bitcoin-core-dev
203 2019-04-30T15:45:32  *** promag_ has quit IRC
204 2019-04-30T15:47:17  *** davterra has joined #bitcoin-core-dev
205 2019-04-30T15:49:53  *** Guest42 has quit IRC
206 2019-04-30T16:04:17  *** scoop has quit IRC
207 2019-04-30T16:04:51  *** scoop has joined #bitcoin-core-dev
208 2019-04-30T16:04:51  *** scoop has quit IRC
209 2019-04-30T16:04:57  *** scoop has joined #bitcoin-core-dev
210 2019-04-30T16:08:41  *** pinheadmz has joined #bitcoin-core-dev
211 2019-04-30T16:15:02  *** bitcoin-git has joined #bitcoin-core-dev
212 2019-04-30T16:15:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45d8b7177851...10ed4dff2447
213 2019-04-30T16:15:03  <bitcoin-git> bitcoin/master 151f3e9 Russell Yanofsky: Add settings merge test to prevent regresssions
214 2019-04-30T16:15:03  <bitcoin-git> bitcoin/master 10ed4df MarcoFalke: Merge #15869: Add settings merge test to prevent regresssions
215 2019-04-30T16:15:05  *** bitcoin-git has left #bitcoin-core-dev
216 2019-04-30T16:15:46  *** bitcoin-git has joined #bitcoin-core-dev
217 2019-04-30T16:15:46  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15869: Add settings merge test to prevent regresssions (master...pr/testset) https://github.com/bitcoin/bitcoin/pull/15869
218 2019-04-30T16:15:51  *** bitcoin-git has left #bitcoin-core-dev
219 2019-04-30T16:27:44  *** cubancorona2 has quit IRC
220 2019-04-30T16:31:50  *** scoop has quit IRC
221 2019-04-30T16:33:36  *** omonk has quit IRC
222 2019-04-30T16:35:10  *** pinheadmz has quit IRC
223 2019-04-30T16:36:17  *** omonk has joined #bitcoin-core-dev
224 2019-04-30T16:44:10  *** promag_ has joined #bitcoin-core-dev
225 2019-04-30T16:47:36  *** scoop has joined #bitcoin-core-dev
226 2019-04-30T16:54:04  *** scoop has quit IRC
227 2019-04-30T16:54:11  *** scoop has joined #bitcoin-core-dev
228 2019-04-30T16:55:59  *** pinheadmz has joined #bitcoin-core-dev
229 2019-04-30T17:15:49  *** promag_ has quit IRC
230 2019-04-30T17:24:46  *** scoop has quit IRC
231 2019-04-30T17:25:17  *** timothy has quit IRC
232 2019-04-30T17:26:55  *** DeanGuss has quit IRC
233 2019-04-30T17:32:08  *** FredHampton has joined #bitcoin-core-dev
234 2019-04-30T17:32:24  *** spinza has quit IRC
235 2019-04-30T17:33:48  *** FredHampton has left #bitcoin-core-dev
236 2019-04-30T17:40:15  *** scoop has joined #bitcoin-core-dev
237 2019-04-30T17:42:56  *** spinza has joined #bitcoin-core-dev
238 2019-04-30T17:44:30  *** scoop has quit IRC
239 2019-04-30T17:55:55  *** scoop has joined #bitcoin-core-dev
240 2019-04-30T18:00:01  *** pleia21 has quit IRC
241 2019-04-30T18:00:30  *** scoop has quit IRC
242 2019-04-30T18:02:26  *** bitcoin-git has joined #bitcoin-core-dev
243 2019-04-30T18:02:26  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15926: tinyformat: Add format_no_throw (master...1904-tinyformatNoThrow) https://github.com/bitcoin/bitcoin/pull/15926
244 2019-04-30T18:02:29  *** bitcoin-git has left #bitcoin-core-dev
245 2019-04-30T18:03:21  *** matael1 has joined #bitcoin-core-dev
246 2019-04-30T18:12:20  *** scoop has joined #bitcoin-core-dev
247 2019-04-30T18:17:25  *** scoop has quit IRC
248 2019-04-30T18:38:22  *** scoop has joined #bitcoin-core-dev
249 2019-04-30T18:59:11  *** Ga1aCt1Cz00 has joined #bitcoin-core-dev
250 2019-04-30T19:09:37  *** queip has quit IRC
251 2019-04-30T19:10:28  *** rafalcpp has quit IRC
252 2019-04-30T19:10:37  *** sdaftuar has quit IRC
253 2019-04-30T19:10:43  *** rafalcpp has joined #bitcoin-core-dev
254 2019-04-30T19:11:30  *** spaced0ut_ has quit IRC
255 2019-04-30T19:11:40  *** spaced0ut has joined #bitcoin-core-dev
256 2019-04-30T19:12:36  *** sdaftuar has joined #bitcoin-core-dev
257 2019-04-30T19:19:59  *** scoop has quit IRC
258 2019-04-30T19:20:38  *** scoop has joined #bitcoin-core-dev
259 2019-04-30T19:22:13  *** queip has joined #bitcoin-core-dev
260 2019-04-30T19:22:16  *** promag_ has joined #bitcoin-core-dev
261 2019-04-30T19:25:02  *** scoop has quit IRC
262 2019-04-30T19:27:38  *** bitcoin-git has joined #bitcoin-core-dev
263 2019-04-30T19:27:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/10ed4dff2447...2c35fe623813
264 2019-04-30T19:27:40  <bitcoin-git> bitcoin/master 188ca75 James O'Beirne: disable HAVE_THREAD_LOCAL on unreliable platforms
265 2019-04-30T19:27:41  <bitcoin-git> bitcoin/master ae5f2b6 James O'Beirne: threads: introduce util/threadnames, refactor thread naming
266 2019-04-30T19:27:42  <bitcoin-git> bitcoin/master ddd95cc James O'Beirne: tests: add threadutil tests
267 2019-04-30T19:27:51  *** bitcoin-git has left #bitcoin-core-dev
268 2019-04-30T19:28:20  *** bitcoin-git has joined #bitcoin-core-dev
269 2019-04-30T19:28:20  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15849: Thread names in logs and deadlock debug tools (master...2018-05-threadnames-take-2) https://github.com/bitcoin/bitcoin/pull/15849
270 2019-04-30T19:28:25  *** bitcoin-git has left #bitcoin-core-dev
271 2019-04-30T19:35:28  *** promag_ has quit IRC
272 2019-04-30T19:36:57  *** Tralfaz has joined #bitcoin-core-dev
273 2019-04-30T19:38:45  *** promag_ has joined #bitcoin-core-dev
274 2019-04-30T19:39:12  *** davterra has quit IRC
275 2019-04-30T19:46:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
276 2019-04-30T19:48:55  *** scoop has joined #bitcoin-core-dev
277 2019-04-30T19:51:44  *** Guyver2 has quit IRC
278 2019-04-30T19:53:44  *** scoop has quit IRC
279 2019-04-30T19:54:15  *** scoop has joined #bitcoin-core-dev
280 2019-04-30T19:54:39  <instagibbs> MarcoFalke, re 15881 what about having it set via parameter, and specific build in CI runs with it as mainnet default?
281 2019-04-30T19:55:05  <instagibbs> I realize there are alrady too many cooks
282 2019-04-30T19:56:01  *** promag_ has quit IRC
283 2019-04-30T19:58:08  *** promag_ has joined #bitcoin-core-dev
284 2019-04-30T20:02:41  *** berndj-blackout has joined #bitcoin-core-dev
285 2019-04-30T20:03:31  *** berndj has quit IRC
286 2019-04-30T20:04:35  *** berndj-blackout is now known as berndj
287 2019-04-30T20:06:40  *** blockguru has joined #bitcoin-core-dev
288 2019-04-30T20:08:19  *** scoop has quit IRC
289 2019-04-30T20:08:26  *** scoop has joined #bitcoin-core-dev
290 2019-04-30T20:08:32  *** cj_ has joined #bitcoin-core-dev
291 2019-04-30T20:08:33  *** dermoth_ has joined #bitcoin-core-dev
292 2019-04-30T20:08:34  *** dermoth has quit IRC
293 2019-04-30T20:08:49  *** dermoth_ is now known as dermoth
294 2019-04-30T20:08:56  *** cj_ has quit IRC
295 2019-04-30T20:15:33  *** bitcoin-git has joined #bitcoin-core-dev
296 2019-04-30T20:15:33  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15858: Faster tests with topological mempool rpc sync 🚀 (master...1904-qaSync) https://github.com/bitcoin/bitcoin/pull/15858
297 2019-04-30T20:15:47  *** bitcoin-git has left #bitcoin-core-dev
298 2019-04-30T20:18:01  <wumpus> what was wrong with the #15858 approach? I liked keeping the change contained to the tests only
299 2019-04-30T20:18:03  <gribble> https://github.com/bitcoin/bitcoin/issues/15858 | Faster tests with topological mempool rpc sync 🚀 by MarcoFalke · Pull Request #15858 · bitcoin/bitcoin · GitHub
300 2019-04-30T20:20:01  <wumpus> confused why it got closed
301 2019-04-30T20:20:10  *** bitcoin-git has joined #bitcoin-core-dev
302 2019-04-30T20:20:11  <bitcoin-git> [bitcoin] jnewbery opened pull request #15927: [tests] log thread names by default in functional tests (master...2019-04-log-threads-tests) https://github.com/bitcoin/bitcoin/pull/15927
303 2019-04-30T20:20:15  *** bitcoin-git has left #bitcoin-core-dev
304 2019-04-30T20:30:42  *** promag_ has quit IRC
305 2019-04-30T20:30:44  *** scoop has quit IRC
306 2019-04-30T20:31:12  *** scoop has joined #bitcoin-core-dev
307 2019-04-30T20:35:40  *** scoop has quit IRC
308 2019-04-30T20:38:18  *** scoop has joined #bitcoin-core-dev
309 2019-04-30T20:38:49  <jnewbery> wumpus: I prefer 15881 since it's a smaller deviation from what happens for tx propogation on mainnet
310 2019-04-30T20:42:37  *** scoop has quit IRC
311 2019-04-30T20:42:45  *** scoop has joined #bitcoin-core-dev
312 2019-04-30T20:47:43  *** scoop has quit IRC
313 2019-04-30T20:51:56  *** scoop has joined #bitcoin-core-dev
314 2019-04-30T20:54:53  <luke-jr> #define stacktop(i)  (stack.at(stack.size()+(i)))
315 2019-04-30T20:55:13  <luke-jr> LLVM likes to cast i to unsigned and do the addition with an overflow :/
316 2019-04-30T20:55:29  <luke-jr> should we just cast stack.size() to ssize_t or something else?
317 2019-04-30T20:57:48  *** scoop has quit IRC
318 2019-04-30T20:57:58  *** scoop has joined #bitcoin-core-dev
319 2019-04-30T20:58:48  <harding> wumpus: FYI, 0.18.0 release PR for BitcoinCore.org is here: https://github.com/bitcoin-core/bitcoincore.org/pull/649
320 2019-04-30T20:59:44  <gwillen> it's not really up to LLVM, the C integer promotion rules are fixed
321 2019-04-30T20:59:54  <gwillen> it should depend only on the integer types involved
322 2019-04-30T21:00:02  *** matael1 has quit IRC
323 2019-04-30T21:00:06  <gwillen> unfortunately they are extremely arcane
324 2019-04-30T21:00:38  <sipa> can we do a search replace stacktop(-i) -> stacktop(i) and then use (stack.at(stack.size()-(i)))
325 2019-04-30T21:01:11  *** hebasto has quit IRC
326 2019-04-30T21:02:45  <gwillen> it seems like the offending rule is "If the operand that has unsigned integer type has rank greater than or equal to the rank of the type of the other operand, the operand with signed integer type is converted to the type of the operand with unsigned integer type."
327 2019-04-30T21:03:04  <gwillen> so if you do math with a size_t (64 bit unsigned) and an int (32-bit signed) you get flattened
328 2019-04-30T21:03:19  <luke-jr> sipa: if we do that, let's rename stacktop
329 2019-04-30T21:03:19  <gwillen> it's a weird rule.
330 2019-04-30T21:03:39  <gwillen> but casting to ssize_t should solve it?
331 2019-04-30T21:03:51  <sipa> *(stack.rbegin() + i) also works :p
332 2019-04-30T21:04:10  <luke-jr> + -i ?
333 2019-04-30T21:04:16  <sipa> with positive i, i mean
334 2019-04-30T21:04:35  <sipa> oh, no; *(stack.rbegin() + (i - 1))
335 2019-04-30T21:04:38  *** ilovezfs has joined #bitcoin-core-dev
336 2019-04-30T21:04:48  <luke-jr> positive i is a hazard
337 2019-04-30T21:05:02  <sipa> why?
338 2019-04-30T21:05:17  <luke-jr> too easy to accidentally merge or backport with an invisible error
339 2019-04-30T21:05:29  <sipa> that's fair
340 2019-04-30T21:05:50  <gwillen> this seems like something you could check statically, if it's generally a constant
341 2019-04-30T21:05:58  <luke-jr> gwillen: it's not always a constant
342 2019-04-30T21:06:07  *** Kevin__6 has joined #bitcoin-core-dev
343 2019-04-30T21:06:35  <luke-jr> anyway, keeping the negative i should be harmless
344 2019-04-30T21:10:59  *** profmac has joined #bitcoin-core-dev
345 2019-04-30T21:13:36  <gwillen> luke-jr: how did it come to pass that this is coming up -- did core change, or did LLVM change?
346 2019-04-30T21:13:59  <luke-jr> gwillen: -fsanitize=undefined
347 2019-04-30T21:14:21  <luke-jr> (apparently while we have a Travis job for it, we also have a suppressions file to hide all our existing issues!)
348 2019-04-30T21:14:41  <gwillen> that's odd... there shouldn't be anything undefined about that, should there? Does it cite chapter and verse?
349 2019-04-30T21:14:50  <gwillen> I can imagine it getting the wrong answer, but not being undefined
350 2019-04-30T21:15:03  <gwillen> and it sounds like it's not in fact getting the wrong answer in practice or we'd have hit this before?
351 2019-04-30T21:15:17  <luke-jr> gwillen: overflows are undefined behaviour
352 2019-04-30T21:15:27  <gwillen> not unsigned overflows
353 2019-04-30T21:15:29  <gwillen> only signed
354 2019-04-30T21:15:40  <gwillen> if it gets converted to unsigned first it should be well-defined
355 2019-04-30T21:15:43  <luke-jr> UBSan says unsigned are undefined too <.<
356 2019-04-30T21:16:02  <gwillen> maybe that's why it was suppressed...
357 2019-04-30T21:17:10  <gwillen> see e.g. https://stackoverflow.com/questions/18195715/why-is-unsigned-integer-overflow-defined-behavior-but-signed-integer-overflow-is
358 2019-04-30T21:17:26  <gwillen> can you pastebin the ubsan complaint?
359 2019-04-30T21:18:32  <sipa> luke-jr: by default ubsan does not warn on unsigned overflow, but there is an optional flag to enable them
360 2019-04-30T21:18:49  <sipa> they're not undefined behavior, but a common red flag
361 2019-04-30T21:19:02  <luke-jr> gwillen: it scrolled out of my terminal - and I'm not entirely sure how I triggered it, since I wasn't running on mainnet ☺
362 2019-04-30T21:19:13  <luke-jr> sipa: odd, I didn't explicitly set any flag
363 2019-04-30T21:19:33  <sipa> the core build system enables it afaik
364 2019-04-30T21:19:37  <luke-jr> ah
365 2019-04-30T21:20:13  *** dqx_ has quit IRC
366 2019-04-30T21:20:20  <luke-jr> is the cast from negative to unsigned also well-defined?
367 2019-04-30T21:20:43  <luke-jr> script/interpreter.cpp:922:42: runtime error: unsigned integer overflow: 2 + 18446744073709551615 cannot be represented in type 'unsigned long'
368 2019-04-30T21:20:45  <luke-jr> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior script/interpreter.cpp:922:42 in
369 2019-04-30T21:20:51  <luke-jr> gwillen: ^
370 2019-04-30T21:22:00  <sipa> luke-jr: cast from signed to unsigned is well defined
371 2019-04-30T21:22:05  <sipa> the other way isn't afaik
372 2019-04-30T21:22:38  * luke-jr typically avoids answering these questions by being explicit on anything that could reasonably be undefined :p
373 2019-04-30T21:23:02  *** Chris_Stewart_5 has quit IRC
374 2019-04-30T21:25:38  <gwillen> yeah so it seems like we are in one of the corners of integer promotion that is weird but not bad
375 2019-04-30T21:26:00  <gwillen> wherein C promotes from signed to unsigned in a way that creates apparent integer overflow that actually gives the correct answer consistently
376 2019-04-30T21:26:46  <gwillen> casting to ssize_t will probably get rid of the weirdness but will cause undefined behavior (I think) if the stack has more than 2 billion elements, which I expect is not a concern
377 2019-04-30T21:27:02  <gwillen> actually if size_t is 64 bit it would need to be a lot more than that
378 2019-04-30T21:29:18  *** scoop has quit IRC
379 2019-04-30T21:35:38  *** elichai2 has quit IRC
380 2019-04-30T21:36:05  *** pinheadmz has quit IRC
381 2019-04-30T21:43:34  *** DougieBot5000 has quit IRC
382 2019-04-30T21:43:39  *** scoop has joined #bitcoin-core-dev
383 2019-04-30T21:45:18  <luke-jr> gwillen: ssize_t isn't guaranteed to be large enough for all sizes?
384 2019-04-30T21:48:38  *** DougieBot5000 has joined #bitcoin-core-dev
385 2019-04-30T21:53:53  *** Aaronvan_ has joined #bitcoin-core-dev
386 2019-04-30T21:53:57  *** justanotheruser has joined #bitcoin-core-dev
387 2019-04-30T21:56:52  *** AaronvanW has quit IRC
388 2019-04-30T22:09:44  <gmaxwell> gwillen: we are misusing sanitization tools
389 2019-04-30T22:09:54  <gmaxwell> and using suppression files to cover up the misuse
390 2019-04-30T22:10:23  <gmaxwell> and then probably just giving up on making useful changes, to cover up the difficulty of updating the suppressions.
391 2019-04-30T22:10:31  *** justanotheruser has quit IRC
392 2019-04-30T22:13:17  <gmaxwell> there are a ton of sanitizers which are available which trigger on behavior that is sometimes (even only rarely) a mistake, and turning them on means either (1) you leave them producing false positives which you ignore, causing you to miss real reports, (2) go change the code in ways that silence them, often lowering code quality or even adding bugs, (3) suppress them, and then deal with the
393 2019-04-30T22:13:17  <gmaxwell> returning every time you add a new instance of the same idiom or refactor something
394 2019-04-30T22:14:32  <gmaxwell> In commercial tools like coverity these concerns are addressed by not emitting warnings for anything that has a high false positive rate (even if that misses some true positives), and by havinga nice database that lets you track suppressions, keep notes on them, and which manages to survive refactoring most of the time.
395 2019-04-30T22:22:19  *** DeanGuss has joined #bitcoin-core-dev
396 2019-04-30T22:26:27  *** justanotheruser has joined #bitcoin-core-dev
397 2019-04-30T22:31:23  *** scoop has quit IRC
398 2019-04-30T22:31:38  *** EagleTM has joined #bitcoin-core-dev
399 2019-04-30T22:34:13  *** scoop has joined #bitcoin-core-dev
400 2019-04-30T22:37:24  *** scoop has quit IRC
401 2019-04-30T22:39:12  *** spinza has quit IRC
402 2019-04-30T22:40:53  *** Guest42 has joined #bitcoin-core-dev
403 2019-04-30T22:43:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
404 2019-04-30T22:49:18  *** davterra has joined #bitcoin-core-dev
405 2019-04-30T22:50:52  *** Tralfaz has quit IRC
406 2019-04-30T22:55:39  *** bitcoin-git has joined #bitcoin-core-dev
407 2019-04-30T22:55:40  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15881: net: Send txs without delay on regtest (master...1904-txRelayRegtest) https://github.com/bitcoin/bitcoin/pull/15881
408 2019-04-30T22:55:41  *** bitcoin-git has left #bitcoin-core-dev
409 2019-04-30T22:59:54  *** spinza has joined #bitcoin-core-dev
410 2019-04-30T23:01:17  *** ddustin has joined #bitcoin-core-dev
411 2019-04-30T23:01:56  *** Chris_Stewart_5 has quit IRC
412 2019-04-30T23:03:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
413 2019-04-30T23:13:10  *** laptop500 has quit IRC
414 2019-04-30T23:16:04  *** fanquake has quit IRC
415 2019-04-30T23:19:42  *** Chris_Stewart_5 has quit IRC
416 2019-04-30T23:23:15  <gwillen> gmaxwell: *nod*, that all makes sense
417 2019-04-30T23:25:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
418 2019-04-30T23:47:17  *** scoop has joined #bitcoin-core-dev
419 2019-04-30T23:53:16  *** scoop has quit IRC
420 2019-04-30T23:59:03  *** pinheadmz has joined #bitcoin-core-dev