1 2019-05-02T00:00:02  *** paolo|out has quit IRC
  2 2019-05-02T00:04:10  *** Guest42 has quit IRC
  3 2019-05-02T00:11:08  *** Guest42 has joined #bitcoin-core-dev
  4 2019-05-02T00:13:27  *** Randolf has joined #bitcoin-core-dev
  5 2019-05-02T00:27:16  *** AaronvanW has quit IRC
  6 2019-05-02T00:28:21  *** ddustin has quit IRC
  7 2019-05-02T00:29:01  *** ddustin has joined #bitcoin-core-dev
  8 2019-05-02T00:33:32  *** ddustin has quit IRC
  9 2019-05-02T00:34:28  *** scoop has joined #bitcoin-core-dev
 10 2019-05-02T00:39:10  *** scoop has quit IRC
 11 2019-05-02T00:43:38  *** justanotheruser has quit IRC
 12 2019-05-02T00:44:10  *** scoop has joined #bitcoin-core-dev
 13 2019-05-02T00:44:38  *** promag_ has joined #bitcoin-core-dev
 14 2019-05-02T00:52:40  *** scoop has quit IRC
 15 2019-05-02T00:54:01  *** scoop has joined #bitcoin-core-dev
 16 2019-05-02T00:56:53  *** promag_ has quit IRC
 17 2019-05-02T00:58:36  *** justanotheruser has joined #bitcoin-core-dev
 18 2019-05-02T00:59:27  *** bralyclow has joined #bitcoin-core-dev
 19 2019-05-02T01:04:13  *** jtimon has quit IRC
 20 2019-05-02T01:13:11  *** michagogo has quit IRC
 21 2019-05-02T01:23:29  *** scoop has quit IRC
 22 2019-05-02T01:23:52  *** Jackielove4u has quit IRC
 23 2019-05-02T01:26:44  *** MrPaz has quit IRC
 24 2019-05-02T01:26:47  *** scoop has joined #bitcoin-core-dev
 25 2019-05-02T01:28:47  *** bosma has quit IRC
 26 2019-05-02T01:33:07  *** valwal_ has quit IRC
 27 2019-05-02T01:37:06  *** scoop has quit IRC
 28 2019-05-02T01:39:37  *** scoop has joined #bitcoin-core-dev
 29 2019-05-02T01:39:38  *** bosma has joined #bitcoin-core-dev
 30 2019-05-02T01:41:12  *** cepinheiro has joined #bitcoin-core-dev
 31 2019-05-02T01:41:34  *** bosma has quit IRC
 32 2019-05-02T01:47:47  *** bosma has joined #bitcoin-core-dev
 33 2019-05-02T01:49:40  *** valwal_ has joined #bitcoin-core-dev
 34 2019-05-02T01:53:00  *** Jackielove4u has joined #bitcoin-core-dev
 35 2019-05-02T02:02:21  *** cepinheiro has quit IRC
 36 2019-05-02T02:02:58  *** cepinheiro has joined #bitcoin-core-dev
 37 2019-05-02T02:08:48  *** wpaulino has joined #bitcoin-core-dev
 38 2019-05-02T02:15:48  *** cubancorona has quit IRC
 39 2019-05-02T02:16:13  *** cubancorona has joined #bitcoin-core-dev
 40 2019-05-02T02:19:28  <wpaulino> > The replacement transaction pays an absolute fee of at least the sum paid by the original transactions.
 41 2019-05-02T02:19:59  <wpaulino> looking at bip 125, in the case of multiple replacements, is “original transactions” meant to just be the previous replacement with its descendants (if any)?
 42 2019-05-02T02:25:48  <wpaulino> double checking with the validation code, that seems to be the case. just want to make sure tho as the wording is kinda weird
 43 2019-05-02T02:26:42  <luke-jr> wpaulino: any and all transactions the new one conflicts with
 44 2019-05-02T02:27:14  <luke-jr> so if the new one has two inputs conflicting with two different and unrelated transactions, it includes both of them and all their descendents
 45 2019-05-02T02:27:46  <luke-jr> potentially conflicts could be huge, but I think there's a limit to what we process
 46 2019-05-02T02:30:07  <wpaulino> luke-jr: gotcha, thanks
 47 2019-05-02T02:49:18  <phantomcircuit> luke-jr, nope they're actually separate buffers
 48 2019-05-02T02:49:32  <phantomcircuit> somethings just happen to map to both
 49 2019-05-02T02:52:32  <luke-jr> phantomcircuit: ?
 50 2019-05-02T02:52:37  <luke-jr> oh
 51 2019-05-02T02:52:59  <luke-jr> phantomcircuit: but terminal programs don't have their own clipboards…
 52 2019-05-02T02:53:06  <luke-jr> they use the same ones every other program does
 53 2019-05-02T03:02:22  <phantomcircuit> luke-jr, actually they don't by default, they're just virtually universally configured to copy into both the "primary" and "clipboard"
 54 2019-05-02T03:06:07  <luke-jr> phantomcircuit: QClipboard doesn't even support 4 clipboards, so what you're claiming is extremely unlikely
 55 2019-05-02T03:06:48  <luke-jr> and the 3rd one is only supported on macOS
 56 2019-05-02T03:06:57  <phantomcircuit> luke-jr, see xclip
 57 2019-05-02T03:07:05  <luke-jr> bash: xclip: command not found
 58 2019-05-02T03:07:34  <luke-jr> phantomcircuit: ancient terminals nobody uses != all or normal terminals
 59 2019-05-02T03:11:53  *** Eagle[TM] has joined #bitcoin-core-dev
 60 2019-05-02T03:12:44  *** scoop has quit IRC
 61 2019-05-02T03:13:22  *** Guest42 has quit IRC
 62 2019-05-02T03:13:48  *** EagleTM has quit IRC
 63 2019-05-02T03:22:08  *** bralyclow2 has joined #bitcoin-core-dev
 64 2019-05-02T03:22:21  *** cubancorona has quit IRC
 65 2019-05-02T03:22:41  *** cubancorona has joined #bitcoin-core-dev
 66 2019-05-02T03:29:44  *** cubancorona has quit IRC
 67 2019-05-02T03:30:05  *** cubancorona has joined #bitcoin-core-dev
 68 2019-05-02T03:30:59  *** bralyclow2 has quit IRC
 69 2019-05-02T03:36:09  *** davterra has joined #bitcoin-core-dev
 70 2019-05-02T03:50:00  *** scoop_ has joined #bitcoin-core-dev
 71 2019-05-02T03:57:53  *** bralyclow has quit IRC
 72 2019-05-02T03:59:00  *** bralyclow has joined #bitcoin-core-dev
 73 2019-05-02T04:14:44  *** scoop_ has quit IRC
 74 2019-05-02T04:27:16  *** cubancorona has quit IRC
 75 2019-05-02T04:27:38  *** cubancorona has joined #bitcoin-core-dev
 76 2019-05-02T04:30:02  *** bralyclow has quit IRC
 77 2019-05-02T04:30:24  *** bralyclow has joined #bitcoin-core-dev
 78 2019-05-02T04:37:49  <wumpus> luke-jr: they could go in separate files IMO
 79 2019-05-02T04:38:33  <wumpus> luke-jr: the usual qt convention seems to be one file pair = one class, which makes it easy to find where a class lives, so makes a sensible default unless you're dealing with lots of small classes
 80 2019-05-02T04:41:46  <luke-jr> fair enough
 81 2019-05-02T04:47:58  *** justanotheruser has quit IRC
 82 2019-05-02T04:55:14  *** DeanGuss has joined #bitcoin-core-dev
 83 2019-05-02T04:58:46  <fanquake> 4x signed sigs for v0.18.0 so far.
 84 2019-05-02T04:59:52  *** cubancorona has quit IRC
 85 2019-05-02T05:00:14  *** cubancorona has joined #bitcoin-core-dev
 86 2019-05-02T05:04:55  *** bralyclow has quit IRC
 87 2019-05-02T05:05:19  *** bralyclow has joined #bitcoin-core-dev
 88 2019-05-02T05:10:03  *** bralyclow has quit IRC
 89 2019-05-02T05:27:55  *** spaced0ut has quit IRC
 90 2019-05-02T05:46:23  *** murrayn_ has quit IRC
 91 2019-05-02T05:46:42  *** murrayn has joined #bitcoin-core-dev
 92 2019-05-02T05:46:42  *** murrayn has joined #bitcoin-core-dev
 93 2019-05-02T06:15:08  *** jarthur has joined #bitcoin-core-dev
 94 2019-05-02T06:15:11  *** scoop has joined #bitcoin-core-dev
 95 2019-05-02T06:19:38  *** scoop has quit IRC
 96 2019-05-02T06:26:35  *** bitcoin-git has joined #bitcoin-core-dev
 97 2019-05-02T06:26:35  <bitcoin-git> [bitcoin] practicalswift opened pull request #15938: Silence GCC 7 warning "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp (master...psbt-return-type-warning) https://github.com/bitcoin/bitcoin/pull/15938
 98 2019-05-02T06:26:39  *** bitcoin-git has left #bitcoin-core-dev
 99 2019-05-02T06:27:04  *** Eagle[TM] has quit IRC
100 2019-05-02T06:33:25  <wumpus> fanquake: goign fast
101 2019-05-02T06:39:20  <luke-jr> now if only more of them would build Knots too ;)
102 2019-05-02T07:17:24  <wumpus> no problem, which repo/tag is that?
103 2019-05-02T07:20:46  <luke-jr> wumpus: will announce here when tagged, thanks ☺ (probably an hour or so)
104 2019-05-02T07:23:51  *** zakk has joined #bitcoin-core-dev
105 2019-05-02T07:29:36  <luke-jr> hrm, Launchpad is timing out trying to get PPA download counts for Core - hopefully it will get fixed before Matt pushes 0.18 XD
106 2019-05-02T07:46:24  *** ccdle12 has joined #bitcoin-core-dev
107 2019-05-02T07:46:49  *** laptop_ has joined #bitcoin-core-dev
108 2019-05-02T07:51:36  *** Randolf has quit IRC
109 2019-05-02T07:52:00  *** Randolf has joined #bitcoin-core-dev
110 2019-05-02T07:53:48  *** ccdle12 has quit IRC
111 2019-05-02T08:00:03  *** DeanGuss has quit IRC
112 2019-05-02T08:00:10  *** RandolfR has joined #bitcoin-core-dev
113 2019-05-02T08:02:28  *** Randolf has quit IRC
114 2019-05-02T08:13:42  *** Guest42 has joined #bitcoin-core-dev
115 2019-05-02T08:16:38  <luke-jr> hmm
116 2019-05-02T08:16:49  <luke-jr> the big "Download Bitcoin Core" button on the website links ot the non-existent win32 :/
117 2019-05-02T08:17:16  *** cepinheiro has quit IRC
118 2019-05-02T08:17:32  <luke-jr> wumpus: can you fix that quickly? otherwise it may skew our goal of finding out who cares
119 2019-05-02T08:17:42  *** cepinheiro has joined #bitcoin-core-dev
120 2019-05-02T08:17:48  <luke-jr> (ie, people may care that the default doesn't work, even if they don't necessarily care about win32 specifically)
121 2019-05-02T08:18:04  <wumpus> I don't really know how to do website stuff
122 2019-05-02T08:18:14  <wumpus> surprised anyone's default would be win32 though
123 2019-05-02T08:18:25  <wumpus> ping @ harding
124 2019-05-02T08:20:04  <luke-jr> probably just need to change win32exe to win64exe on line 21
125 2019-05-02T08:20:11  <luke-jr> of _includes/templates/download.html
126 2019-05-02T08:21:09  <wumpus> so this means *everyone* with windows was suggested the 32-bit download? ouch
127 2019-05-02T08:21:10  <wumpus> will change
128 2019-05-02T08:21:34  <gmaxwell> ugh
129 2019-05-02T08:21:51  <luke-jr> wumpus: does it try to detect even? I got that link on Linux
130 2019-05-02T08:22:06  <luke-jr> looks like it's a win32 link for everyone
131 2019-05-02T08:22:26  <wumpus> it used to detect, maybe no more
132 2019-05-02T08:23:02  <gmaxwell> maybe it correctly detects 64 bits on win64 but elsewhere just does 32bits?
133 2019-05-02T08:23:13  <luke-jr> gmaxwell: i don't see any conditional logic
134 2019-05-02T08:23:24  <luke-jr> bet it was lost with bitcoin.org -> bitcoincore.org
135 2019-05-02T08:23:36  *** setpill has joined #bitcoin-core-dev
136 2019-05-02T08:24:06  <wumpus> https://github.com/bitcoin-core/bitcoincore.org/pull/650
137 2019-05-02T08:24:58  <wumpus> luke-jr: oh good point, I guess the bitcoin.org PR will fail because it's missing the 32-bit windows files
138 2019-05-02T08:28:12  <luke-jr> bitcoin.org indeed has OS detection Javascript
139 2019-05-02T08:28:22  *** ossifrage has quit IRC
140 2019-05-02T08:28:26  *** promag_ has joined #bitcoin-core-dev
141 2019-05-02T08:37:32  *** jarthur has quit IRC
142 2019-05-02T08:40:49  *** ossifrage has joined #bitcoin-core-dev
143 2019-05-02T08:40:58  *** promag_ has quit IRC
144 2019-05-02T08:41:18  *** promag_ has joined #bitcoin-core-dev
145 2019-05-02T08:56:32  *** Guyver2 has joined #bitcoin-core-dev
146 2019-05-02T09:00:02  *** zakk has quit IRC
147 2019-05-02T09:03:43  *** timothy has joined #bitcoin-core-dev
148 2019-05-02T09:20:34  *** miyamofigo_ has joined #bitcoin-core-dev
149 2019-05-02T09:21:33  <luke-jr> wumpus: nevermind, it'll be a while. something broke with the power64 gitian builds :/
150 2019-05-02T09:22:42  *** miyamofigo_ has quit IRC
151 2019-05-02T09:41:12  <luke-jr> apparently a bug with Ubuntu's GCC 8 for older ppc64
152 2019-05-02T09:41:25  * luke-jr ponders whether to bump up the ppc64 -mcpu, or drop to GCC 7
153 2019-05-02T09:53:53  <wumpus> bumping the cpu sounds better, at least if it's still suppported on the TALOS
154 2019-05-02T09:54:34  <luke-jr> yeah, it needs power7 for __float128, which glibcxx's headers assume is available
155 2019-05-02T09:55:07  *** promag_ has quit IRC
156 2019-05-02T09:56:13  <gmaxwell> forcing down to older power probably hurts performance in any case, is anyone running this on anything less than power9?
157 2019-05-02T09:57:55  <luke-jr> gmaxwell: awilfox was pushing for 970 (G5)
158 2019-05-02T09:58:20  <luke-jr> gmaxwell: and ironically, it performs better on POWER9 with an older target, than if targetting power9
159 2019-05-02T09:59:28  <wumpus> that's interesting
160 2019-05-02T10:00:14  *** jonatack has joined #bitcoin-core-dev
161 2019-05-02T10:00:28  <wumpus> FWIW I'm surprised how good recent gcc's risc-v code generation is, it took ages to get to that level for ARM, for a long time it did kind of dumb things like juggle results between registers and memory unnecessarily
162 2019-05-02T10:00:33  <luke-jr> it's -misel that makes the performance hit specifically
163 2019-05-02T10:01:09  <gmaxwell> wumpus: might help that GCC is presumably the compiler the risc-v designers use, while arm was focused on their own toolchain for a long time
164 2019-05-02T10:01:18  <wumpus> gmaxwell: yup
165 2019-05-02T10:02:54  <gmaxwell> luke-jr: IIRC isel is some predicated execution thing? it might want branch profiling...
166 2019-05-02T10:03:28  <wumpus> gcc is the only feasible toolchain for RISC-V at the moment, clang doesn't support everything yet for full linux rv64gc
167 2019-05-02T10:06:04  <luke-jr> gmaxwell: well, supposedly POWER8 had it, but it performed worse, so GCC disabled it by default.. I imagine they'll end up doing the same for POWER9
168 2019-05-02T10:07:53  <gmaxwell> Predication like features can result in big performance gains, but only when they're used on frequently executed low predictability branches, if you use it on a branch that always goes the right way on many that are rarely executed they hurt performance....  This was a super big deal on itanium.
169 2019-05-02T10:08:34  <gmaxwell> without profiles GCC has some guesses, e.g. exceptions are rare... malloc failures seldom happen, etc.
170 2019-05-02T10:10:23  <luke-jr> should we begin littering our code with likely()/unlikely()? :P
171 2019-05-02T10:12:26  <wumpus> luke-jr: the performance critical parts, maybe yes, that'll also help for other platforms
172 2019-05-02T10:12:26  *** Guest11323 has joined #bitcoin-core-dev
173 2019-05-02T10:12:39  <gmaxwell> Littering, probably not, but there might be a couple places where they make sense... but PGO is better from a maintance perspective!
174 2019-05-02T10:12:48  <wumpus> although I've never seen those in c++ code, only c code
175 2019-05-02T10:13:02  <luke-jr> PGO?
176 2019-05-02T10:13:14  <gmaxwell> profile guided optimization.
177 2019-05-02T10:13:24  <wumpus> e.g. MESA is littered with them (but that makes sense, almost everything in GPU drivers is perf critical that's the whole reason they exist)
178 2019-05-02T10:13:28  <gmaxwell> I think for C++ you can't manage to likely tag all the important stuff...
179 2019-05-02T10:14:22  <wumpus> the problem with PGO in our case might be reproducibility
180 2019-05-02T10:14:38  <gmaxwell> luke-jr: -fprofile-generate  and then run -fprofile-use.
181 2019-05-02T10:14:38  <wumpus> yes, I also suspect it's more difficult due to more implicit behavior
182 2019-05-02T10:14:47  <luke-jr> does PGO do cross anyway?
183 2019-05-02T10:14:49  <gmaxwell> I believe mozilla has addressed PGO + reproducability.
184 2019-05-02T10:15:17  <gmaxwell> but I'm not sure where that stands, in theory you should just be able to ship the profiles as side information along with the source.
185 2019-05-02T10:15:44  <gmaxwell> in any case, might be worth benchmarking, if just to know even if its too much trouble to use.
186 2019-05-02T10:16:09  <wumpus> right
187 2019-05-02T10:16:18  <gmaxwell> If it gets a big speedup anywhere that might suggest likely() usage and/or refactoring to avoid confusing compiler hurestics.
188 2019-05-02T10:17:42  <gmaxwell> (we do use builtin_expect in secp256k1, but mostly just around error handling code to get it to turn those into distant jumps)
189 2019-05-02T10:19:43  *** rockhouse has quit IRC
190 2019-05-02T10:20:18  *** spinza has quit IRC
191 2019-05-02T10:20:44  *** rockhouse has joined #bitcoin-core-dev
192 2019-05-02T10:25:07  *** timothy has quit IRC
193 2019-05-02T10:25:39  *** promag_ has joined #bitcoin-core-dev
194 2019-05-02T10:31:43  *** Skirmant has quit IRC
195 2019-05-02T10:45:03  *** b10c has joined #bitcoin-core-dev
196 2019-05-02T10:46:43  *** spinza has joined #bitcoin-core-dev
197 2019-05-02T10:51:58  <harding> wumpus: did you get the win32/64 thing for the website sorted out?  (Sorry; I thought I tested that for the removal.)
198 2019-05-02T10:52:27  <luke-jr> harding: looks like it
199 2019-05-02T10:53:01  <harding> luke-jr: cool.  Thanks for noticing it was broken.
200 2019-05-02T10:59:46  <gmaxwell> achow101: awake? time for a new bitcoin release thread on bitcointalk
201 2019-05-02T11:07:21  *** Guest42 has quit IRC
202 2019-05-02T11:13:10  <gmaxwell> achow101: you snooze you loose, https://bitcointalk.org/index.php?topic=5138532.0
203 2019-05-02T11:14:08  <luke-jr> lol
204 2019-05-02T11:17:34  *** AaronvanW has joined #bitcoin-core-dev
205 2019-05-02T11:18:49  <wumpus> harding: I think so, made a minimal change to fix the broken link, suggested by luke-jr
206 2019-05-02T11:23:04  *** Guest42 has joined #bitcoin-core-dev
207 2019-05-02T11:24:36  *** Guest42 has quit IRC
208 2019-05-02T11:27:06  *** Guest42 has joined #bitcoin-core-dev
209 2019-05-02T11:29:06  <harding> wumpus: thanks!  Sorry I missed that in the release PR.
210 2019-05-02T11:30:19  <wumpus> no problem
211 2019-05-02T11:31:22  *** timothy has joined #bitcoin-core-dev
212 2019-05-02T11:32:37  *** jonatack has quit IRC
213 2019-05-02T11:33:01  *** EagleTM has joined #bitcoin-core-dev
214 2019-05-02T11:33:26  <Lauda> IsBerkeleyBtree: The system cannot find the file specified D:\Disk 1\Bitcoin\blocks\wallet.dat
215 2019-05-02T11:33:26  <Lauda> is this intended in 18?
216 2019-05-02T11:33:34  <Lauda> Seems to go through all folders looking for wallet.dat
217 2019-05-02T11:34:21  <luke-jr> Lauda: that looks weird
218 2019-05-02T11:34:37  <luke-jr> maybe trying to build the wallet list?
219 2019-05-02T11:35:04  <Lauda> follow up is remaining folders
220 2019-05-02T11:35:09  <Lauda> well it sounds weird 'find the file specified'
221 2019-05-02T11:35:12  <Lauda> I didn't specify anything
222 2019-05-02T11:41:48  *** spinza has quit IRC
223 2019-05-02T11:48:37  <wumpus> bitcoin_test is really noisy on 0.18.0 RISC-V "Error: Specified -walletdir "/tmp/test_bitcoin/1556792182_943311758/tempdir/path_does_not_exist" does not exist" a zillion times, but the tests pass OK so I suppose these are expected errors
224 2019-05-02T11:49:20  *** jonatack has joined #bitcoin-core-dev
225 2019-05-02T11:49:56  <luke-jr> also on x86_64 IIRC
226 2019-05-02T11:50:29  <wumpus> on master x86_64 it prints three errors, which is better, but still not ideal
227 2019-05-02T11:59:45  *** promag_ has quit IRC
228 2019-05-02T12:00:01  *** Guest11323 has quit IRC
229 2019-05-02T12:00:37  *** spinza has joined #bitcoin-core-dev
230 2019-05-02T12:03:04  *** jtimon has joined #bitcoin-core-dev
231 2019-05-02T12:03:24  *** tryphe has quit IRC
232 2019-05-02T12:03:47  *** tryphe has joined #bitcoin-core-dev
233 2019-05-02T12:09:01  *** b10c has quit IRC
234 2019-05-02T12:09:27  *** jonatack has quit IRC
235 2019-05-02T12:21:50  *** scoop has joined #bitcoin-core-dev
236 2019-05-02T12:36:53  *** b10c has joined #bitcoin-core-dev
237 2019-05-02T12:41:19  *** bitcoin-git has joined #bitcoin-core-dev
238 2019-05-02T12:41:19  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15939: gitian: Remove Windows 32 bit build (master...1904-GitianWin) https://github.com/bitcoin/bitcoin/pull/15939
239 2019-05-02T12:41:21  *** bitcoin-git has left #bitcoin-core-dev
240 2019-05-02T12:42:10  *** promag_ has joined #bitcoin-core-dev
241 2019-05-02T12:45:38  *** bitcoin-git has joined #bitcoin-core-dev
242 2019-05-02T12:45:38  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0936f35f65ad...c4560a7dfee9
243 2019-05-02T12:45:39  <bitcoin-git> bitcoin/master 5d35ae3 Luca Venturini: Handle the result of posix_fallocate system call
244 2019-05-02T12:45:39  <bitcoin-git> bitcoin/master c4560a7 MarcoFalke: Merge #15650: Handle the result of posix_fallocate system call
245 2019-05-02T12:45:41  *** bitcoin-git has left #bitcoin-core-dev
246 2019-05-02T12:46:13  *** bitcoin-git has joined #bitcoin-core-dev
247 2019-05-02T12:46:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15650: Handle the result of posix_fallocate system call (master...handle-posix-fallocate) https://github.com/bitcoin/bitcoin/pull/15650
248 2019-05-02T12:46:15  *** bitcoin-git has left #bitcoin-core-dev
249 2019-05-02T12:50:22  *** Y_Ichiro has joined #bitcoin-core-dev
250 2019-05-02T12:53:15  *** wbnns has joined #bitcoin-core-dev
251 2019-05-02T13:04:59  *** hashist has joined #bitcoin-core-dev
252 2019-05-02T13:05:17  *** hashist has left #bitcoin-core-dev
253 2019-05-02T13:16:13  *** bitcoin-git has joined #bitcoin-core-dev
254 2019-05-02T13:16:13  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c4560a7dfee9...c1ba1182eb43
255 2019-05-02T13:16:13  <bitcoin-git> bitcoin/master beb42d7 practicalswift: Silence GCC 7 warning "control reaches end of non-void function" (-Wreturn...
256 2019-05-02T13:16:14  <bitcoin-git> bitcoin/master c1ba118 MarcoFalke: Merge #15938: refactor: Silence "control reaches end of non-void function"...
257 2019-05-02T13:16:15  *** bitcoin-git has left #bitcoin-core-dev
258 2019-05-02T13:16:39  *** bitcoin-git has joined #bitcoin-core-dev
259 2019-05-02T13:16:39  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15938: refactor: Silence "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp (master...psbt-return-type-warning) https://github.com/bitcoin/bitcoin/pull/15938
260 2019-05-02T13:16:40  *** bitcoin-git has left #bitcoin-core-dev
261 2019-05-02T13:17:14  *** justanotheruser has joined #bitcoin-core-dev
262 2019-05-02T13:23:32  *** spaced0ut has joined #bitcoin-core-dev
263 2019-05-02T13:26:30  *** promag_ has quit IRC
264 2019-05-02T13:35:31  *** sdaftuar has quit IRC
265 2019-05-02T13:36:25  *** alex___ has joined #bitcoin-core-dev
266 2019-05-02T13:37:31  *** sdaftuar has joined #bitcoin-core-dev
267 2019-05-02T13:37:35  *** alex___ has quit IRC
268 2019-05-02T13:38:50  *** ccdle12 has joined #bitcoin-core-dev
269 2019-05-02T13:39:58  *** ossifrage_ has joined #bitcoin-core-dev
270 2019-05-02T13:41:06  *** ossifrage has quit IRC
271 2019-05-02T13:50:03  *** ossifrage_ has quit IRC
272 2019-05-02T13:50:27  *** ossifrage_ has joined #bitcoin-core-dev
273 2019-05-02T14:02:34  *** justanotheruser has quit IRC
274 2019-05-02T14:02:49  *** scoop has quit IRC
275 2019-05-02T14:08:22  *** baldur has quit IRC
276 2019-05-02T14:11:41  *** bitcoin-git has joined #bitcoin-core-dev
277 2019-05-02T14:11:41  <bitcoin-git> [bitcoin] laanwj opened pull request #15941: doc: Add historical release notes for 0.18.0 (master...2019_05_historical_release_notes) https://github.com/bitcoin/bitcoin/pull/15941
278 2019-05-02T14:11:44  *** bitcoin-git has left #bitcoin-core-dev
279 2019-05-02T14:14:35  *** Guest42 has quit IRC
280 2019-05-02T14:15:15  *** bitcoin-git has joined #bitcoin-core-dev
281 2019-05-02T14:15:15  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/2472733a24a9...be92be5644a7
282 2019-05-02T14:15:15  <bitcoin-git> bitcoin/0.18 be92be5 Wladimir J. van der Laan: doc: Clean out release notes post-0.18.0
283 2019-05-02T14:15:29  *** bitcoin-git has left #bitcoin-core-dev
284 2019-05-02T14:16:55  *** Guest42 has joined #bitcoin-core-dev
285 2019-05-02T14:18:21  *** shesek has quit IRC
286 2019-05-02T14:19:54  <achow101> gmaxwell: 7 am is too early for me
287 2019-05-02T14:20:13  *** scoop has joined #bitcoin-core-dev
288 2019-05-02T14:21:44  *** baldur has joined #bitcoin-core-dev
289 2019-05-02T14:23:56  *** justanotheruser has joined #bitcoin-core-dev
290 2019-05-02T14:24:21  *** scoop has quit IRC
291 2019-05-02T14:24:48  *** bitcoin-git has joined #bitcoin-core-dev
292 2019-05-02T14:24:49  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1ba1182eb43...24dfcf3a56f9
293 2019-05-02T14:24:49  <bitcoin-git> bitcoin/master da9f1ac Wladimir J. van der Laan: doc: Add historical release notes for 0.18.0
294 2019-05-02T14:24:50  <bitcoin-git> bitcoin/master 24dfcf3 Wladimir J. van der Laan: Merge #15941: doc: Add historical release notes for 0.18.0
295 2019-05-02T14:24:50  *** Tralfaz has joined #bitcoin-core-dev
296 2019-05-02T14:25:00  *** bitcoin-git has left #bitcoin-core-dev
297 2019-05-02T14:25:32  *** hebasto has joined #bitcoin-core-dev
298 2019-05-02T14:25:33  *** bitcoin-git has joined #bitcoin-core-dev
299 2019-05-02T14:25:33  <bitcoin-git> [bitcoin] laanwj merged pull request #15941: doc: Add historical release notes for 0.18.0 (master...2019_05_historical_release_notes) https://github.com/bitcoin/bitcoin/pull/15941
300 2019-05-02T14:25:40  *** bitcoin-git has left #bitcoin-core-dev
301 2019-05-02T14:26:42  *** Aaronvan_ has joined #bitcoin-core-dev
302 2019-05-02T14:27:16  *** davterra has quit IRC
303 2019-05-02T14:30:14  *** AaronvanW has quit IRC
304 2019-05-02T14:31:19  *** davterra has joined #bitcoin-core-dev
305 2019-05-02T14:32:10  *** StopAndDecrypt has quit IRC
306 2019-05-02T14:33:40  *** Tralfaz has quit IRC
307 2019-05-02T14:40:53  *** ossifrage_ has quit IRC
308 2019-05-02T14:41:05  *** ossifrage_ has joined #bitcoin-core-dev
309 2019-05-02T15:00:02  *** Y_Ichiro has quit IRC
310 2019-05-02T15:02:36  *** jimmysong has quit IRC
311 2019-05-02T15:04:35  *** furkanmustafa has joined #bitcoin-core-dev
312 2019-05-02T15:09:18  *** WarrenBuffet has joined #bitcoin-core-dev
313 2019-05-02T15:09:46  <hebasto> wumpus: #15940 "for 0.18.0" - typo?
314 2019-05-02T15:09:47  <gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
315 2019-05-02T15:11:36  *** Guest42 has quit IRC
316 2019-05-02T15:14:11  *** dgenr8 has quit IRC
317 2019-05-02T15:21:34  *** shivendra has joined #bitcoin-core-dev
318 2019-05-02T15:25:29  <wumpus> hebasto: yes, thanks, updated
319 2019-05-02T15:26:03  *** _Sam-- has joined #bitcoin-core-dev
320 2019-05-02T15:29:10  *** Eagle[TM] has joined #bitcoin-core-dev
321 2019-05-02T15:30:37  *** EagleTM has quit IRC
322 2019-05-02T15:32:35  *** dgenr8 has joined #bitcoin-core-dev
323 2019-05-02T15:35:59  *** ccdle12 has quit IRC
324 2019-05-02T15:38:31  *** scoop has joined #bitcoin-core-dev
325 2019-05-02T15:41:37  *** jimmysong has joined #bitcoin-core-dev
326 2019-05-02T15:44:43  *** DeanGuss has joined #bitcoin-core-dev
327 2019-05-02T15:50:43  *** setpill has quit IRC
328 2019-05-02T16:11:12  *** ossifrage_ has quit IRC
329 2019-05-02T16:12:30  *** spaced0ut has quit IRC
330 2019-05-02T16:20:16  *** cepinheiro has quit IRC
331 2019-05-02T16:26:09  *** ossifrage has joined #bitcoin-core-dev
332 2019-05-02T16:28:11  *** shivendra has quit IRC
333 2019-05-02T16:28:16  *** scoop has quit IRC
334 2019-05-02T16:36:35  *** hebasto has quit IRC
335 2019-05-02T16:42:05  *** Eagle[TM] has quit IRC
336 2019-05-02T16:56:40  *** afk11 has quit IRC
337 2019-05-02T17:18:06  *** bitcoin-git has joined #bitcoin-core-dev
338 2019-05-02T17:18:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15942: tests: Use BOOST_CHECK_EQUAL for verbose prints on fail (master...1905-testCryptoEqual) https://github.com/bitcoin/bitcoin/pull/15942
339 2019-05-02T17:18:07  *** bitcoin-git has left #bitcoin-core-dev
340 2019-05-02T17:34:05  *** sipa has quit IRC
341 2019-05-02T17:35:51  *** sipa has joined #bitcoin-core-dev
342 2019-05-02T17:47:44  <luke-jr> apparently GCC 8.2 is broken on PPC in other ways too so just reverting to GCC 7
343 2019-05-02T17:47:58  <luke-jr> (has anyone checked that 8.2 isn't broken on other platforms we support?)
344 2019-05-02T17:48:08  <luke-jr> wumpus: ^
345 2019-05-02T17:53:48  <wumpus> no problems with it for risc-v nor x86
346 2019-05-02T17:59:32  *** timothy has quit IRC
347 2019-05-02T18:00:01  *** furkanmustafa has quit IRC
348 2019-05-02T18:01:17  *** nullptr| has quit IRC
349 2019-05-02T18:05:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
350 2019-05-02T18:07:38  *** nullptr| has joined #bitcoin-core-dev
351 2019-05-02T18:08:53  *** Victorsueca is now known as Tipper
352 2019-05-02T18:08:59  *** Tipper is now known as Victorsueca
353 2019-05-02T18:22:45  *** perrito6661 has joined #bitcoin-core-dev
354 2019-05-02T18:28:58  *** hebasto has joined #bitcoin-core-dev
355 2019-05-02T18:33:02  *** DeanGuss has quit IRC
356 2019-05-02T18:51:56  *** bitcoin-git has joined #bitcoin-core-dev
357 2019-05-02T18:51:57  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15942: tests: Use BOOST_CHECK_EQUAL for verbose prints on fail (master...1905-testCryptoEqual) https://github.com/bitcoin/bitcoin/pull/15942
358 2019-05-02T18:51:58  *** bitcoin-git has left #bitcoin-core-dev
359 2019-05-02T19:01:08  <wumpus> #startmeeting
360 2019-05-02T19:01:08  <lightningbot> Meeting started Thu May  2 19:01:08 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
361 2019-05-02T19:01:08  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
362 2019-05-02T19:01:20  <sipa> hi
363 2019-05-02T19:01:20  <luke-jr> hi
364 2019-05-02T19:01:22  <kanzure> hi
365 2019-05-02T19:01:22  <jnewbery> hi
366 2019-05-02T19:01:41  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
367 2019-05-02T19:02:01  <sdaftuar> hi
368 2019-05-02T19:02:21  <achow101> hi
369 2019-05-02T19:02:27  <wumpus> congrats on release 0.18.0 everyone !
370 2019-05-02T19:02:36  <sipa> indeed!
371 2019-05-02T19:02:51  <jamesob> hi
372 2019-05-02T19:02:54  <jonasschnelli> hi
373 2019-05-02T19:02:57  <sdaftuar> \o/
374 2019-05-02T19:03:18  <jtimon> still not sure what I did for this release exactly...but thanks, I guess :)
375 2019-05-02T19:03:33  <wumpus> I've created an issue with the release schedule for 0.19: #15940
376 2019-05-02T19:03:34  <gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
377 2019-05-02T19:04:32  <wumpus> any proposed topics? nothing on moneyball's list this week
378 2019-05-02T19:05:27  <instagibbs> \o/
379 2019-05-02T19:05:32  <wumpus> #topic high priority for review
380 2019-05-02T19:05:46  <sipa> i've been busy with some other things, i'll be more active soon
381 2019-05-02T19:05:48  <phantomcircuit> hi
382 2019-05-02T19:06:19  <wumpus> currently on the list: #15427 #15024 #15006 #15141 #15512
383 2019-05-02T19:06:21  <gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub
384 2019-05-02T19:06:23  <gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
385 2019-05-02T19:06:26  <gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
386 2019-05-02T19:06:28  <gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
387 2019-05-02T19:06:29  <wumpus> sipa: good to know!
388 2019-05-02T19:06:33  <gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
389 2019-05-02T19:06:50  <wumpus> anything to add/remove?
390 2019-05-02T19:07:09  <jonasschnelli> If you want progress on the p2p encryption, review the ChaCha20 stuff in #15512 (</ad>)
391 2019-05-02T19:07:11  <gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
392 2019-05-02T19:07:33  <wumpus> right!
393 2019-05-02T19:07:34  *** promag_ has joined #bitcoin-core-dev
394 2019-05-02T19:07:34  <sipa> jonasschnelli: will do, promise
395 2019-05-02T19:07:41  <jonasschnelli> thanks
396 2019-05-02T19:07:42  <jamesob> psa: going to be putting up the first of the assumeutxo-related PRs in the next few days; if you're interested and haven't reviewed the general proposal you can do so here: https://github.com/jamesob/assumeutxo-docs/pull/1
397 2019-05-02T19:08:22  <wumpus> jamesob: yes, some context is always useful
398 2019-05-02T19:10:01  <wumpus> any other topics? (or, more to discuss about assumeutxo)
399 2019-05-02T19:10:43  <jamesob> not on my end, though happy to chat about assumeutxo if anyone has questions
400 2019-05-02T19:11:48  *** joe___ has joined #bitcoin-core-dev
401 2019-05-02T19:12:27  <wumpus> okay
402 2019-05-02T19:13:15  <wumpus> a short meeting then, I guess
403 2019-05-02T19:13:28  <jonasschnelli> new record
404 2019-05-02T19:13:29  <jnewbery> short meetings are good meetings
405 2019-05-02T19:13:52  <wumpus> very efficient
406 2019-05-02T19:14:00  <wumpus> #endmeeting
407 2019-05-02T19:14:00  <lightningbot> Meeting ended Thu May  2 19:14:00 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
408 2019-05-02T19:14:00  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-02-19.01.html
409 2019-05-02T19:14:00  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-02-19.01.txt
410 2019-05-02T19:14:00  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-02-19.01.log.html
411 2019-05-02T19:15:19  <MarcoFalke> Oh, I missed it
412 2019-05-02T19:15:51  <sipa> MarcoFalke: you didn't miss much :p
413 2019-05-02T19:15:57  <MarcoFalke> heh
414 2019-05-02T19:15:59  <luke-jr> we need to have another meeting for MarcoFalke
415 2019-05-02T19:16:03  <MarcoFalke> can I add #15870?
416 2019-05-02T19:16:05  <gribble> https://github.com/bitcoin/bitcoin/issues/15870 | wallet: Only fail rescan when blocks have actually been pruned by MarcoFalke · Pull Request #15870 · bitcoin/bitcoin · GitHub
417 2019-05-02T19:16:39  <MarcoFalke> to high priority?
418 2019-05-02T19:20:05  <wumpus> MarcoFalke :sure
419 2019-05-02T19:20:19  <MarcoFalke> cool thx
420 2019-05-02T19:20:30  * MarcoFalke #end meeting for MarcoFalke
421 2019-05-02T19:30:30  *** promag_ has quit IRC
422 2019-05-02T19:32:10  *** promag_ has joined #bitcoin-core-dev
423 2019-05-02T19:34:45  *** promag_ has quit IRC
424 2019-05-02T19:36:53  *** promag_ has joined #bitcoin-core-dev
425 2019-05-02T19:39:40  <jtimon> jamesob: reading the proposal, looks very nice
426 2019-05-02T19:39:57  <jamesob> jtimon: cool, thanks!
427 2019-05-02T19:41:55  *** promag_ has quit IRC
428 2019-05-02T19:42:42  *** owowo has quit IRC
429 2019-05-02T19:43:21  *** joe___ has quit IRC
430 2019-05-02T19:43:51  *** promag_ has joined #bitcoin-core-dev
431 2019-05-02T19:47:26  *** owowo has joined #bitcoin-core-dev
432 2019-05-02T20:03:54  *** stephan3000 has joined #bitcoin-core-dev
433 2019-05-02T20:08:26  *** Guyver2 has quit IRC
434 2019-05-02T20:09:33  <phantomcircuit> sipa, the CAddrMan Unserialize method trusts that the nSize parameter isn't corrupted, is there an upper bound for that we could set to prevent an infinite loop on disk corruption?
435 2019-05-02T20:11:14  <sipa> phantomcircuit: the total number of entries is capped by the number and size of the buckets, so yes
436 2019-05-02T20:11:40  <sipa> though we may want to set the limit a small factor higher to permit downgrading if the bucket layout ever changes
437 2019-05-02T20:12:05  <phantomcircuit> sipa, line 423 in addrman.h , so it's the "new" table
438 2019-05-02T20:12:36  *** ddustin has joined #bitcoin-core-dev
439 2019-05-02T20:13:29  *** promag_ has quit IRC
440 2019-05-02T20:13:41  *** ddustin has joined #bitcoin-core-dev
441 2019-05-02T20:16:03  *** user2019 has joined #bitcoin-core-dev
442 2019-05-02T20:16:17  *** davterra has quit IRC
443 2019-05-02T20:19:37  *** stephan3000 has quit IRC
444 2019-05-02T20:27:33  *** promag_ has joined #bitcoin-core-dev
445 2019-05-02T20:32:16  *** bitcoin-git has joined #bitcoin-core-dev
446 2019-05-02T20:32:16  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15943: tests: Fail if RPC has been added without tests (master...1905-testFailNoRpcCov) https://github.com/bitcoin/bitcoin/pull/15943
447 2019-05-02T20:32:30  *** bitcoin-git has left #bitcoin-core-dev
448 2019-05-02T20:33:32  <phantomcircuit> sipa, i guess it mostly doesn't matter cause the stream will probably fault before it loops for too long
449 2019-05-02T20:35:08  <sipa> phantomcircuit: i think there are at most 64*1024 entries in the 'new' table
450 2019-05-02T20:35:18  <sipa> #define ADDRMAN_NEW_BUCKET_COUNT_LOG2 10
451 2019-05-02T20:35:26  <sipa> #define ADDRMAN_BUCKET_SIZE_LOG2 6
452 2019-05-02T20:54:42  <sipa> MarcoFalke: that sha256d64 test failing is scary
453 2019-05-02T21:00:02  *** perrito6661 has quit IRC
454 2019-05-02T21:00:19  <phantomcircuit> sipa, thinking about it more i dont think it really matters cause the stream reads will just throw an exception once it's past the end of the file
455 2019-05-02T21:00:38  <sipa> yes
456 2019-05-02T21:01:14  <sipa> phantomcircuit: i guess the only thing to worry about is if a garbage file can cause us to allocate a ginormous amount of memory immediately
457 2019-05-02T21:01:26  <sipa> but the normal vector serialization functions allocate incrementally to prevent that
458 2019-05-02T21:01:33  <sipa> *deserialization
459 2019-05-02T21:02:37  *** ddustin has quit IRC
460 2019-05-02T21:03:19  *** ddustin has joined #bitcoin-core-dev
461 2019-05-02T21:04:18  *** davec has quit IRC
462 2019-05-02T21:04:34  *** hebasto has quit IRC
463 2019-05-02T21:05:26  *** ddustin has joined #bitcoin-core-dev
464 2019-05-02T21:08:12  *** mryandao_ has joined #bitcoin-core-dev
465 2019-05-02T21:09:26  *** mryandao has quit IRC
466 2019-05-02T21:10:44  *** brantje has joined #bitcoin-core-dev
467 2019-05-02T21:12:53  *** Chris_Stewart_5 has quit IRC
468 2019-05-02T21:12:53  *** reardencode has quit IRC
469 2019-05-02T21:15:03  <phantomcircuit> sipa, and this is just reading integers so it cant be more than 32bits at a time
470 2019-05-02T21:22:10  <MarcoFalke> yeah, indeed scary
471 2019-05-02T21:22:39  <MarcoFalke> So bitcoind is using a different sha than the tests do?
472 2019-05-02T21:23:08  <MarcoFalke> Otherwise, how could it sync
473 2019-05-02T21:25:37  <sipa> MarcoFalke: how many times do you get the "check memcmp(...) == 0 has failed" ?
474 2019-05-02T21:25:49  <MarcoFalke> 32
475 2019-05-02T21:26:28  <sipa> what happens if you add a SHA256AutoDetect() call in the test?
476 2019-05-02T21:28:02  <MarcoFalke> Same
477 2019-05-02T21:28:18  <MarcoFalke> I guess it is already called in BasicTestingSetup()
478 2019-05-02T21:29:18  <sipa> ok, what if you comment out the "if (have_avx2 && have_avx && enabled_avx) {" block in crpyto/sha256.cpp ?
479 2019-05-02T21:32:15  <MarcoFalke> Same with if (true||have_avx2 && have_avx && enabled_avx) {
480 2019-05-02T21:33:11  *** davec has joined #bitcoin-core-dev
481 2019-05-02T21:33:20  <sipa> what if you disable it entirely (as in: don't use avx2)
482 2019-05-02T21:33:49  <MarcoFalke> still fails
483 2019-05-02T21:34:46  <sipa> what if you comment out the "TransformD64_4way = sha256d64_sse41::Transform_4way" line and the "TransformD64_8way = sha256d64_avx2::Transform_8way;" line?
484 2019-05-02T21:34:52  * sipa is baffled
485 2019-05-02T21:35:47  <MarcoFalke> same
486 2019-05-02T21:35:58  * MarcoFalke yes I double checked that I compiled it again
487 2019-05-02T21:37:44  <MarcoFalke> 2019-05-02T21:37:33Z Using the 'standard' SHA256 implementation
488 2019-05-02T21:38:03  <sipa> sense, it makes none.
489 2019-05-02T21:38:31  <luke-jr> NSA disagrees
490 2019-05-02T21:38:32  <sipa> can you add an assert inside the avx2/sse4 implementations to make sure they're not invoked?
491 2019-05-02T21:40:34  *** michaelfolkson has joined #bitcoin-core-dev
492 2019-05-02T21:41:16  *** promag_ has quit IRC
493 2019-05-02T21:44:49  <MarcoFalke> I think it calls TransformD64
494 2019-05-02T21:45:26  <MarcoFalke> and Transform
495 2019-05-02T21:46:39  <MarcoFalke> sha256_sse4::Transform and Transform_8way have an assert(false)
496 2019-05-02T21:48:48  <sipa> what if you set TransformD64 to TransformD64Wrapper<sha256::Transform> (and make SHA256AutoDetect a no-op)?
497 2019-05-02T21:49:20  <sipa> in the initializer
498 2019-05-02T21:51:44  *** reardencode has joined #bitcoin-core-dev
499 2019-05-02T21:53:01  <MarcoFalke> still fails
500 2019-05-02T22:01:00  <luke-jr> MarcoFalke: what GCC version?
501 2019-05-02T22:01:58  <MarcoFalke> $ gcc --version === gcc (GCC) 9.0.1 20190312 (Red Hat 9.0.1-0.10)
502 2019-05-02T22:05:26  <luke-jr> hrm, I'd guess probably not the issue, but it might indicate GCC has been playing with memory stuff? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88273
503 2019-05-02T22:06:03  <luke-jr> might be worth recompiling with GCC 7 just to see if it's compiler-dependent
504 2019-05-02T22:07:05  <MarcoFalke> Someone else reported it with fedora 29, which has gcc8?
505 2019-05-02T22:07:16  <MarcoFalke> But I will try with clang
506 2019-05-02T22:07:44  <MarcoFalke> Might take a while since 32 bit only gives me 2gb of ram
507 2019-05-02T22:07:48  <sipa> MarcoFalke: does compiling with ubsan or asan give any interesting results
508 2019-05-02T22:07:51  <sipa> ?
509 2019-05-02T22:08:04  <MarcoFalke> rip ram
510 2019-05-02T22:08:20  <MarcoFalke> will have results in an hour earliest
511 2019-05-02T22:08:42  *** ddustin has quit IRC
512 2019-05-02T22:09:01  *** ddustin has joined #bitcoin-core-dev
513 2019-05-02T22:09:41  *** ddustin has quit IRC
514 2019-05-02T22:10:03  *** sdaftuar has quit IRC
515 2019-05-02T22:10:07  <luke-jr> MarcoFalke: since this is a not-very-likely cause, I'd suggest continuing to troubleshoot with sipa while it builds
516 2019-05-02T22:10:17  *** ddustin has joined #bitcoin-core-dev
517 2019-05-02T22:10:28  <luke-jr> although I guess rebuilding with sanitizers are going to take just as long :x
518 2019-05-02T22:10:47  <luke-jr> I would be surprised if asan supported x86_32 since it requires so much virtual memory space
519 2019-05-02T22:10:49  *** sdaftuar has joined #bitcoin-core-dev
520 2019-05-02T22:10:50  *** ddustin has quit IRC
521 2019-05-02T22:11:37  *** ddustin has joined #bitcoin-core-dev
522 2019-05-02T22:13:45  <MarcoFalke> So just to confirm this should be the call stack?
523 2019-05-02T22:13:47  <MarcoFalke> https://pastebin.ubuntu.com/p/tSVxBJvTZy/
524 2019-05-02T22:14:04  <MarcoFalke> SHA256D64 calls Transform?
525 2019-05-02T22:14:31  <sipa> yeah, that looks right
526 2019-05-02T22:14:58  <sipa> it calls TransformD64, which is a function pointer to a wrapper function that invokes Transform
527 2019-05-02T22:19:35  <MarcoFalke> ok, building on clang with sanitizers    = address,undefined
528 2019-05-02T22:22:00  *** spinza has quit IRC
529 2019-05-02T22:23:23  *** Randolf has joined #bitcoin-core-dev
530 2019-05-02T22:25:16  *** RandolfR has quit IRC
531 2019-05-02T22:25:25  *** user2019 has quit IRC
532 2019-05-02T22:32:29  *** spinza has joined #bitcoin-core-dev
533 2019-05-02T22:35:10  *** laptop_ has quit IRC
534 2019-05-02T22:42:47  *** Guest42 has joined #bitcoin-core-dev
535 2019-05-02T22:44:12  *** Zenton has quit IRC
536 2019-05-02T22:58:04  <phantomcircuit> so apparently GetTimeMillis() can throw an exception, which isn't handled like anywhere
537 2019-05-02T22:58:17  <sipa> phantomcircuit: define 'can'
538 2019-05-02T22:58:25  <phantomcircuit> actually it can't nvm
539 2019-05-02T22:58:33  <phantomcircuit> sorry
540 2019-05-02T22:58:54  <phantomcircuit> boost::gregorian::date can but not with the constants we use
541 2019-05-02T22:59:01  <MarcoFalke> So it passes with clang and address sanitizer
542 2019-05-02T22:59:03  <MarcoFalke> !?
543 2019-05-02T22:59:03  <gribble> (misc help [<plugin>] [<command>]) -- This command gives a useful description of what <command> does. <plugin> is only necessary if the command is in more than one plugin.
544 2019-05-02T22:59:23  <sipa> MarcoFalke: gcc 9 bug?
545 2019-05-02T22:59:24  * MarcoFalke off
546 2019-05-02T22:59:45  <MarcoFalke> Maybe.
547 2019-05-02T22:59:51  <MarcoFalke> Could also be 8
548 2019-05-02T23:00:01  <MarcoFalke> Will update the issue tomorrow
549 2019-05-02T23:00:14  <luke-jr> hopefully not 8, as we just shipped built with 8 :x
550 2019-05-02T23:00:32  <MarcoFalke> luke-jr: The issue is there since 0.17.1
551 2019-05-02T23:00:45  <MarcoFalke> So yes, likely also gcc 8
552 2019-05-02T23:01:02  <luke-jr> :|
553 2019-05-02T23:02:52  *** scoop has joined #bitcoin-core-dev
554 2019-05-02T23:04:04  *** justanotheruser has quit IRC
555 2019-05-02T23:05:22  <booyah> on limited memory maybe just run in valgrind, if you have memory problems? (though always few false positives)
556 2019-05-02T23:19:15  *** justanotheruser has joined #bitcoin-core-dev
557 2019-05-02T23:19:54  *** Skirmant has joined #bitcoin-core-dev
558 2019-05-02T23:20:20  <sipa> MarcoFalke: i can reproduce
559 2019-05-02T23:55:47  * luke-jr looks forward to the day he can do these gitian builds on ppc64