1 2019-05-08T00:00:00  *** scoop has quit IRC
  2 2019-05-08T00:00:00  *** instagibbs has quit IRC
  3 2019-05-08T00:00:02  *** feedoo1 has quit IRC
  4 2019-05-08T00:17:42  *** rlaager1 has joined #bitcoin-core-dev
  5 2019-05-08T00:23:06  *** fanquake has joined #bitcoin-core-dev
  6 2019-05-08T00:24:35  *** chriswang2019 has joined #bitcoin-core-dev
  7 2019-05-08T00:32:59  *** Chris_Stewart_5 has quit IRC
  8 2019-05-08T00:35:56  *** chriswang2019 has quit IRC
  9 2019-05-08T00:55:44  *** pinheadmz has quit IRC
 10 2019-05-08T00:57:53  *** promag_ has quit IRC
 11 2019-05-08T00:59:07  *** pinheadmz has joined #bitcoin-core-dev
 12 2019-05-08T01:01:48  *** side^effects has quit IRC
 13 2019-05-08T01:05:37  *** promag has joined #bitcoin-core-dev
 14 2019-05-08T01:06:15  <promag> an alternative to force the build is to redeliver the webhook, however there's no official API for this. But I think it should be possible by using GET https://github.com/hooks/$HOOK_ID/deliveries and POST https://github.com/hooks/$HOOK_ID/deliveries/$DELIVERY_ID/redeliver with the right headers
 15 2019-05-08T01:07:09  *** promag has quit IRC
 16 2019-05-08T01:07:11  *** pinheadmz has quit IRC
 17 2019-05-08T01:07:28  *** pinheadmz has joined #bitcoin-core-dev
 18 2019-05-08T01:28:21  *** instagibbs has joined #bitcoin-core-dev
 19 2019-05-08T01:30:36  *** promag has joined #bitcoin-core-dev
 20 2019-05-08T01:33:40  *** bitcoin-git has joined #bitcoin-core-dev
 21 2019-05-08T01:33:40  <bitcoin-git> [bitcoin] dongcarl opened pull request #15978: .gitignore: Don't ignore depends patches (master...2019-05-no-ignore-depends-patches) https://github.com/bitcoin/bitcoin/pull/15978
 22 2019-05-08T01:33:41  *** bitcoin-git has left #bitcoin-core-dev
 23 2019-05-08T01:33:44  *** pinheadmz has quit IRC
 24 2019-05-08T01:34:17  *** hyperwang has joined #bitcoin-core-dev
 25 2019-05-08T01:35:04  *** promag has quit IRC
 26 2019-05-08T01:36:05  *** hyperwang has quit IRC
 27 2019-05-08T01:36:13  *** pinheadmz has joined #bitcoin-core-dev
 28 2019-05-08T01:59:27  *** jtimon has quit IRC
 29 2019-05-08T02:06:05  *** jhfrontz has joined #bitcoin-core-dev
 30 2019-05-08T02:43:47  <luke-jr> achow101: the travis restart thing won't?
 31 2019-05-08T02:45:03  <achow101> restarting a job will just use the same commit for that job
 32 2019-05-08T02:45:18  <achow101> you'd need to trigger a new build for the pr, which isn't possible at least from the web ui
 33 2019-05-08T02:46:27  <luke-jr> what if we modify our travis scripts to fetch master explicitly?
 34 2019-05-08T02:47:51  *** AaronvanW has quit IRC
 35 2019-05-08T03:00:01  *** rlaager1 has quit IRC
 36 2019-05-08T03:05:50  *** Eagle[TM] has joined #bitcoin-core-dev
 37 2019-05-08T03:07:32  *** EagleTM has quit IRC
 38 2019-05-08T03:18:02  *** aowi has joined #bitcoin-core-dev
 39 2019-05-08T03:29:17  <gmaxwell> luke-jr: re your list post, "If that is inacceptable, pick as internal key a point with unknown discrete logarithm."  there is no reason your forced to have a everyone agress bypass.
 40 2019-05-08T04:20:37  *** hebasto_ has quit IRC
 41 2019-05-08T04:58:01  *** ghost43 has quit IRC
 42 2019-05-08T04:58:16  *** ghost43 has joined #bitcoin-core-dev
 43 2019-05-08T05:29:42  *** murchandamus has left #bitcoin-core-dev
 44 2019-05-08T05:32:04  *** murch has joined #bitcoin-core-dev
 45 2019-05-08T05:32:14  *** promag has joined #bitcoin-core-dev
 46 2019-05-08T05:33:49  *** dermoth has quit IRC
 47 2019-05-08T05:36:59  *** promag has quit IRC
 48 2019-05-08T05:42:45  *** dermoth has joined #bitcoin-core-dev
 49 2019-05-08T05:49:22  *** pinheadmz has quit IRC
 50 2019-05-08T06:00:02  *** aowi has quit IRC
 51 2019-05-08T06:04:56  *** jtimon has joined #bitcoin-core-dev
 52 2019-05-08T06:20:30  *** hyperwang has joined #bitcoin-core-dev
 53 2019-05-08T06:22:01  *** hyperwang has quit IRC
 54 2019-05-08T06:22:28  *** hyperwang has joined #bitcoin-core-dev
 55 2019-05-08T06:23:56  *** hyperwang has joined #bitcoin-core-dev
 56 2019-05-08T06:25:22  *** Eagle[TM] has quit IRC
 57 2019-05-08T06:25:25  *** hyperwang has joined #bitcoin-core-dev
 58 2019-05-08T06:26:26  *** hyperwang has quit IRC
 59 2019-05-08T06:26:53  *** hyperwang has joined #bitcoin-core-dev
 60 2019-05-08T06:27:55  *** hyperwang has quit IRC
 61 2019-05-08T06:28:22  *** hyperwang has joined #bitcoin-core-dev
 62 2019-05-08T06:29:57  *** hyperwang has joined #bitcoin-core-dev
 63 2019-05-08T06:31:25  *** hyperwang has joined #bitcoin-core-dev
 64 2019-05-08T06:32:26  *** hyperwang has quit IRC
 65 2019-05-08T06:32:53  *** hyperwang has joined #bitcoin-core-dev
 66 2019-05-08T06:33:16  <tryphe> i noticed there's not a lot of usage of 'const' in a lot of bitcoin code where there could be. is this for readability purposes, or are changes welcome?
 67 2019-05-08T06:34:16  *** hyperwang has quit IRC
 68 2019-05-08T06:35:09  *** feth1 has joined #bitcoin-core-dev
 69 2019-05-08T06:36:14  *** hyperwang has joined #bitcoin-core-dev
 70 2019-05-08T06:36:27  <sipa> tryphe: we reject patches that only improve coding stylr
 71 2019-05-08T06:36:30  <sipa> *style
 72 2019-05-08T06:37:46  *** hyperwang has quit IRC
 73 2019-05-08T06:38:00  <tryphe> sipa, i was thinking of an improvement like so: say you pass a pointer to a thread, and you expect the pointer to be accessed non-const but the address value to not be modified. now you could enforce that with coverage tests and stuff.
 74 2019-05-08T06:38:09  <tryphe> gah, thread/function*
 75 2019-05-08T06:38:13  *** hyperwang has joined #bitcoin-core-dev
 76 2019-05-08T06:38:46  <tryphe> whereas if you don't enforce it, you won't know if you accidentally modified a value
 77 2019-05-08T06:39:21  <sipa> yes, improving that is great, but it is very low priority noise compared to other potential changes
 78 2019-05-08T06:39:32  <sipa> and review time is limited and precious
 79 2019-05-08T06:39:40  *** Karyon has quit IRC
 80 2019-05-08T06:39:52  <tryphe> true, but in terms of undefined behavior i think it could be helpful
 81 2019-05-08T06:40:15  <gwillen> adding "const" feels like it should be slightly different from "mere style" changes, since it's functional rather than aesthetic, and any instance the compiler accepts is almost surely correct
 82 2019-05-08T06:40:28  <gwillen> (so review effort ought to be limited)
 83 2019-05-08T06:40:39  <sipa> if you actually find an issue, for example by adding const where you expect it to work and it doesn't, it is different
 84 2019-05-08T06:40:42  *** jtimon has quit IRC
 85 2019-05-08T06:40:45  <tryphe> (i realized it's impractical to change this though, there's a crapload of changes that would need be done to enforce this example above)
 86 2019-05-08T06:40:45  <gwillen> *nods*
 87 2019-05-08T06:41:05  <sipa> but adding const in places where the code already works has no effect except add assurances
 88 2019-05-08T06:41:08  <tryphe> alright, that makes sense. i guess there's enough tests anyways to catch most issues.
 89 2019-05-08T06:42:08  *** hyperwang has quit IRC
 90 2019-05-08T06:42:35  *** hyperwang has joined #bitcoin-core-dev
 91 2019-05-08T06:43:59  *** Karyon has joined #bitcoin-core-dev
 92 2019-05-08T06:44:02  <gmaxwell> you can also introduce bugs by peppering around const, so it's not like those changes are free to review, even ignoring the effect on change flow.
 93 2019-05-08T06:44:15  *** hyperwang has joined #bitcoin-core-dev
 94 2019-05-08T06:45:10  <sipa> in general adding const can't have too much effect if the code works both before and after... but there are some
 95 2019-05-08T06:45:41  <sipa> for example moving a const argument will silently introduce a (deep) copy of certain objects, where a move was expected
 96 2019-05-08T06:45:47  <tryphe> yeah, the problem is knowing the intent of the code you are modifying
 97 2019-05-08T06:45:58  <sipa> tryphe: exactly!
 98 2019-05-08T06:46:38  <sipa> adding such things where they are intended is great, but adding them mechanically is mostly useless without careful review of every individual case
 99 2019-05-08T06:47:38  *** hyperwang has quit IRC
100 2019-05-08T06:48:16  *** hyperwang has joined #bitcoin-core-dev
101 2019-05-08T06:48:38  <gmaxwell> That is also a general problem with broad 'cleanup' changes, they're done without much understanding or care about the code they're changing.
102 2019-05-08T06:49:38  *** hyperwang has quit IRC
103 2019-05-08T06:50:14  *** hyperwang has joined #bitcoin-core-dev
104 2019-05-08T06:51:53  *** hyperwang has joined #bitcoin-core-dev
105 2019-05-08T06:53:21  *** hyperwang has joined #bitcoin-core-dev
106 2019-05-08T06:54:22  *** hyperwang has quit IRC
107 2019-05-08T06:55:00  *** hyperwang has joined #bitcoin-core-dev
108 2019-05-08T06:56:01  *** hyperwang has quit IRC
109 2019-05-08T06:56:34  *** hyperwang has joined #bitcoin-core-dev
110 2019-05-08T06:57:35  *** hyperwang has quit IRC
111 2019-05-08T06:58:03  *** hyperwang has joined #bitcoin-core-dev
112 2019-05-08T06:58:25  *** blkwolf has joined #bitcoin-core-dev
113 2019-05-08T06:59:25  *** hyperwang has quit IRC
114 2019-05-08T06:59:53  *** hyperwang has joined #bitcoin-core-dev
115 2019-05-08T07:01:22  *** hyperwang has joined #bitcoin-core-dev
116 2019-05-08T07:02:23  *** hyperwang has quit IRC
117 2019-05-08T07:02:49  *** hyperwang has joined #bitcoin-core-dev
118 2019-05-08T07:03:50  *** hyperwang has quit IRC
119 2019-05-08T07:04:19  *** hyperwang has joined #bitcoin-core-dev
120 2019-05-08T07:05:20  *** hyperwang has quit IRC
121 2019-05-08T07:05:51  *** hyperwang has joined #bitcoin-core-dev
122 2019-05-08T07:07:20  *** hyperwang has joined #bitcoin-core-dev
123 2019-05-08T07:08:21  *** hyperwang has quit IRC
124 2019-05-08T07:08:59  *** hyperwang has joined #bitcoin-core-dev
125 2019-05-08T07:09:13  *** blkwolf has left #bitcoin-core-dev
126 2019-05-08T07:09:59  *** blkwolf has joined #bitcoin-core-dev
127 2019-05-08T07:10:17  <tryphe> one good reason i like to do it, though, is because i get a compiler error when i try to modify something that wasn't intended by the programmer. it's easy for someone to... misuse the code i guess is a better way to put it.
128 2019-05-08T07:10:25  *** blkwolf has left #bitcoin-core-dev
129 2019-05-08T07:11:25  *** hyperwang has quit IRC
130 2019-05-08T07:12:03  *** hyperwang has joined #bitcoin-core-dev
131 2019-05-08T07:13:15  <tryphe> sorta like using nullptr instead of 0, you state the intention of the usage for future programmers to reference, instead of relying on them to make a good guess, hehe
132 2019-05-08T07:13:31  *** hyperwang has joined #bitcoin-core-dev
133 2019-05-08T07:14:18  <tryphe> good/correct*
134 2019-05-08T07:15:19  *** hyperwang has quit IRC
135 2019-05-08T07:15:45  *** hyperwang has joined #bitcoin-core-dev
136 2019-05-08T07:16:46  *** hyperwang has quit IRC
137 2019-05-08T07:17:13  *** hyperwang has joined #bitcoin-core-dev
138 2019-05-08T07:18:14  *** hyperwang has quit IRC
139 2019-05-08T07:18:41  *** hyperwang has joined #bitcoin-core-dev
140 2019-05-08T07:20:08  *** hyperwang has joined #bitcoin-core-dev
141 2019-05-08T07:21:10  *** hyperwang has quit IRC
142 2019-05-08T07:21:36  *** hyperwang has joined #bitcoin-core-dev
143 2019-05-08T07:22:37  *** hyperwang has quit IRC
144 2019-05-08T07:23:05  *** hyperwang has joined #bitcoin-core-dev
145 2019-05-08T07:24:06  *** hyperwang has quit IRC
146 2019-05-08T07:24:33  *** hyperwang has joined #bitcoin-core-dev
147 2019-05-08T07:26:12  *** hyperwang has joined #bitcoin-core-dev
148 2019-05-08T07:27:40  *** hyperwang has joined #bitcoin-core-dev
149 2019-05-08T07:28:41  *** hyperwang has quit IRC
150 2019-05-08T07:29:02  *** bitcoin-git has joined #bitcoin-core-dev
151 2019-05-08T07:29:02  <bitcoin-git> [bitcoin] Bushstar opened pull request #15979: Replace incorrectly named comment with func (master...replace-with-func) https://github.com/bitcoin/bitcoin/pull/15979
152 2019-05-08T07:29:03  *** bitcoin-git has left #bitcoin-core-dev
153 2019-05-08T07:29:18  *** hyperwang has joined #bitcoin-core-dev
154 2019-05-08T07:29:24  *** bushstar has joined #bitcoin-core-dev
155 2019-05-08T07:30:24  *** hyperwang has quit IRC
156 2019-05-08T07:30:52  *** hyperwang has joined #bitcoin-core-dev
157 2019-05-08T07:32:20  *** hyperwang has joined #bitcoin-core-dev
158 2019-05-08T07:33:21  *** hyperwang has quit IRC
159 2019-05-08T07:33:59  *** hyperwang has joined #bitcoin-core-dev
160 2019-05-08T07:35:01  *** hyperwang has quit IRC
161 2019-05-08T07:35:38  *** hyperwang has joined #bitcoin-core-dev
162 2019-05-08T07:36:39  *** hyperwang has quit IRC
163 2019-05-08T07:37:06  *** hyperwang has joined #bitcoin-core-dev
164 2019-05-08T07:38:07  *** hyperwang has quit IRC
165 2019-05-08T07:38:36  *** hyperwang has joined #bitcoin-core-dev
166 2019-05-08T07:39:10  *** drexl has quit IRC
167 2019-05-08T07:40:11  *** hyperwang has quit IRC
168 2019-05-08T07:40:38  *** hyperwang has joined #bitcoin-core-dev
169 2019-05-08T07:42:07  *** hyperwang has joined #bitcoin-core-dev
170 2019-05-08T07:43:35  *** hyperwang has joined #bitcoin-core-dev
171 2019-05-08T07:44:36  *** hyperwang has quit IRC
172 2019-05-08T07:45:04  *** hyperwang has joined #bitcoin-core-dev
173 2019-05-08T07:46:05  *** hyperwang has quit IRC
174 2019-05-08T07:46:33  *** hyperwang has joined #bitcoin-core-dev
175 2019-05-08T07:48:02  *** hyperwang has joined #bitcoin-core-dev
176 2019-05-08T07:49:04  *** hyperwang has quit IRC
177 2019-05-08T07:49:51  *** hyperwang has joined #bitcoin-core-dev
178 2019-05-08T07:50:53  *** hyperwang has quit IRC
179 2019-05-08T07:51:19  *** hyperwang has joined #bitcoin-core-dev
180 2019-05-08T07:52:21  *** hyperwang has quit IRC
181 2019-05-08T07:52:47  *** hyperwang has joined #bitcoin-core-dev
182 2019-05-08T07:56:15  *** fanquake has quit IRC
183 2019-05-08T07:57:42  *** booyah has quit IRC
184 2019-05-08T08:00:03  *** Dean_Guss has joined #bitcoin-core-dev
185 2019-05-08T08:16:34  *** talesfromthecryp has joined #bitcoin-core-dev
186 2019-05-08T08:20:59  *** kevinryan has joined #bitcoin-core-dev
187 2019-05-08T08:21:57  *** talesfromthecryp has quit IRC
188 2019-05-08T08:31:07  *** kevinryan has quit IRC
189 2019-05-08T08:35:23  *** Zenton has joined #bitcoin-core-dev
190 2019-05-08T08:39:11  *** fanquake has joined #bitcoin-core-dev
191 2019-05-08T08:44:48  *** laptop500 has joined #bitcoin-core-dev
192 2019-05-08T08:45:04  *** justanotheruser has quit IRC
193 2019-05-08T08:45:40  *** murrayn has joined #bitcoin-core-dev
194 2019-05-08T08:45:40  *** murrayn has joined #bitcoin-core-dev
195 2019-05-08T08:52:54  *** promag has joined #bitcoin-core-dev
196 2019-05-08T08:59:05  *** promag has quit IRC
197 2019-05-08T09:00:02  *** feth1 has quit IRC
198 2019-05-08T09:04:46  *** Fuchs1 has joined #bitcoin-core-dev
199 2019-05-08T09:10:44  *** queip has quit IRC
200 2019-05-08T09:11:56  *** rafalcpp_ has joined #bitcoin-core-dev
201 2019-05-08T09:12:01  *** rafalcpp has quit IRC
202 2019-05-08T09:21:22  *** timothy has joined #bitcoin-core-dev
203 2019-05-08T09:21:29  *** promag has joined #bitcoin-core-dev
204 2019-05-08T09:23:48  *** queip has joined #bitcoin-core-dev
205 2019-05-08T09:34:35  *** csknk has joined #bitcoin-core-dev
206 2019-05-08T09:37:21  *** csknk has quit IRC
207 2019-05-08T10:04:43  *** davec has quit IRC
208 2019-05-08T10:07:29  *** kevinryan has joined #bitcoin-core-dev
209 2019-05-08T10:07:54  *** setpill has joined #bitcoin-core-dev
210 2019-05-08T10:22:37  *** spinza has quit IRC
211 2019-05-08T10:24:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
212 2019-05-08T10:28:29  *** arubi has quit IRC
213 2019-05-08T10:30:01  *** arubi has joined #bitcoin-core-dev
214 2019-05-08T10:30:23  *** bitcoin-git has joined #bitcoin-core-dev
215 2019-05-08T10:30:23  <bitcoin-git> [bitcoin] Bushstar opened pull request #15981: Use __func__ for log messages (master...replace-all-with-func) https://github.com/bitcoin/bitcoin/pull/15981
216 2019-05-08T10:30:24  *** bitcoin-git has left #bitcoin-core-dev
217 2019-05-08T10:31:59  *** kevinryan has quit IRC
218 2019-05-08T10:32:15  *** kevinryan has joined #bitcoin-core-dev
219 2019-05-08T10:37:29  *** kevinryan has quit IRC
220 2019-05-08T10:37:53  *** spinza has joined #bitcoin-core-dev
221 2019-05-08T10:38:15  *** promag has quit IRC
222 2019-05-08T10:39:07  *** promag has joined #bitcoin-core-dev
223 2019-05-08T10:40:02  *** kevinryan has joined #bitcoin-core-dev
224 2019-05-08T10:46:33  *** kevinryan has quit IRC
225 2019-05-08T10:47:08  *** Chris_Stewart_5 has quit IRC
226 2019-05-08T10:53:14  *** promag has quit IRC
227 2019-05-08T10:56:08  *** davec has joined #bitcoin-core-dev
228 2019-05-08T11:02:47  *** promag has joined #bitcoin-core-dev
229 2019-05-08T11:03:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
230 2019-05-08T11:06:15  *** promag has quit IRC
231 2019-05-08T11:07:34  *** promag has joined #bitcoin-core-dev
232 2019-05-08T11:12:22  *** Chris_Stewart_5 has quit IRC
233 2019-05-08T11:29:28  *** promag has quit IRC
234 2019-05-08T11:33:35  *** promag has joined #bitcoin-core-dev
235 2019-05-08T11:47:09  *** promag has quit IRC
236 2019-05-08T11:52:52  *** AaronvanW has joined #bitcoin-core-dev
237 2019-05-08T11:53:43  *** queip has quit IRC
238 2019-05-08T11:53:54  *** lipsch_hth has joined #bitcoin-core-dev
239 2019-05-08T11:55:29  *** rafalcpp_ has quit IRC
240 2019-05-08T11:55:43  *** rafalcpp_ has joined #bitcoin-core-dev
241 2019-05-08T11:59:33  *** Aaronvan_ has joined #bitcoin-core-dev
242 2019-05-08T12:00:01  *** Fuchs1 has quit IRC
243 2019-05-08T12:00:21  *** lipsch_hth has quit IRC
244 2019-05-08T12:00:31  *** rafalcpp has joined #bitcoin-core-dev
245 2019-05-08T12:01:19  *** rafalcpp_ has quit IRC
246 2019-05-08T12:01:45  *** bitcoin-git has joined #bitcoin-core-dev
247 2019-05-08T12:01:46  <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b2a6b0216192...ef802ef5d694
248 2019-05-08T12:01:47  <bitcoin-git> bitcoin/master 4f65af9 Hennadii Stepanov: Remove dead code for walletFile check
249 2019-05-08T12:01:48  <bitcoin-git> bitcoin/master a0a222e Hennadii Stepanov: Replace deprecated Boost Filesystem function
250 2019-05-08T12:01:49  <bitcoin-git> bitcoin/master ef802ef MeshCollider: Merge #15880: utils and libraries: Replace deprecated Boost Filesystem fun...
251 2019-05-08T12:01:50  *** bitcoin-git has left #bitcoin-core-dev
252 2019-05-08T12:02:03  *** AaronvanW has quit IRC
253 2019-05-08T12:02:30  *** bitcoin-git has joined #bitcoin-core-dev
254 2019-05-08T12:02:30  <bitcoin-git> [bitcoin] meshcollider merged pull request #15880: utils and libraries: Replace deprecated Boost Filesystem functions (master...20190423-boost-coding-guidelines) https://github.com/bitcoin/bitcoin/pull/15880
255 2019-05-08T12:02:32  *** bitcoin-git has left #bitcoin-core-dev
256 2019-05-08T12:05:03  *** Leo-WAC-WAC has joined #bitcoin-core-dev
257 2019-05-08T12:05:17  *** queip has joined #bitcoin-core-dev
258 2019-05-08T12:14:44  *** promag has joined #bitcoin-core-dev
259 2019-05-08T12:14:49  *** promag has quit IRC
260 2019-05-08T12:15:54  *** michaelfolkson has joined #bitcoin-core-dev
261 2019-05-08T12:18:06  *** queip has quit IRC
262 2019-05-08T12:18:38  <jonasschnelli> #15512 is waiting on a final review from sipa
263 2019-05-08T12:18:41  <gribble> https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub
264 2019-05-08T12:18:55  *** rafalcpp has quit IRC
265 2019-05-08T12:19:14  *** rafalcpp has joined #bitcoin-core-dev
266 2019-05-08T12:20:17  *** bitcoin-git has joined #bitcoin-core-dev
267 2019-05-08T12:20:17  <bitcoin-git> [bitcoin] fanquake closed pull request #15979: Replace incorrectly named comment with func (master...replace-with-func) https://github.com/bitcoin/bitcoin/pull/15979
268 2019-05-08T12:20:18  *** bitcoin-git has left #bitcoin-core-dev
269 2019-05-08T12:20:58  *** queip has joined #bitcoin-core-dev
270 2019-05-08T12:21:12  <fanquake> jonasschnelli Could use some more input from you in #15957 when you have a chance.
271 2019-05-08T12:21:14  <gribble> https://github.com/bitcoin/bitcoin/issues/15957 | Show "No wallets available" in open menu instead of nothing by meshcollider · Pull Request #15957 · bitcoin/bitcoin · GitHub
272 2019-05-08T12:26:04  *** bitcoin-git has joined #bitcoin-core-dev
273 2019-05-08T12:26:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ef802ef5d694...bbb7119ca835
274 2019-05-08T12:26:05  <bitcoin-git> bitcoin/master a3592c9 Carl Dong: .gitignore: Don't ignore depends patches
275 2019-05-08T12:26:05  <bitcoin-git> bitcoin/master bbb7119 MarcoFalke: Merge #15978: .gitignore: Don't ignore depends patches
276 2019-05-08T12:26:07  *** bitcoin-git has left #bitcoin-core-dev
277 2019-05-08T12:26:38  *** drexl has joined #bitcoin-core-dev
278 2019-05-08T12:26:54  *** bitcoin-git has joined #bitcoin-core-dev
279 2019-05-08T12:26:54  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15978: .gitignore: Don't ignore depends patches (master...2019-05-no-ignore-depends-patches) https://github.com/bitcoin/bitcoin/pull/15978
280 2019-05-08T12:26:56  *** bitcoin-git has left #bitcoin-core-dev
281 2019-05-08T12:32:58  <fanquake> eh https://imgur.com/a/LJSJIKD ?
282 2019-05-08T12:33:34  <luke-jr> gmaxwell: how do you prove it's unknown?
283 2019-05-08T12:35:05  <gmaxwell> luke-jr: hash of G is sufficient.
284 2019-05-08T12:35:33  <gmaxwell> or hash of G concatinated with whatever random number you want, if you want per application randomization for privacy (preferable)
285 2019-05-08T12:36:41  *** Chris_Stewart_5 has joined #bitcoin-core-dev
286 2019-05-08T12:36:43  <gmaxwell> (it's better to randomize it so that later when you spend third parties can't tell that there wasn't a key-only path)
287 2019-05-08T12:40:47  *** jtimon has joined #bitcoin-core-dev
288 2019-05-08T12:46:10  *** Guyver2 has joined #bitcoin-core-dev
289 2019-05-08T12:50:32  *** jonatack has joined #bitcoin-core-dev
290 2019-05-08T12:57:44  *** scoop has joined #bitcoin-core-dev
291 2019-05-08T13:02:31  *** justanotheruser has joined #bitcoin-core-dev
292 2019-05-08T13:10:59  *** millerti has joined #bitcoin-core-dev
293 2019-05-08T13:21:55  *** bitcoin-git has joined #bitcoin-core-dev
294 2019-05-08T13:21:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bbb7119ca835...49c1aa5f83d0
295 2019-05-08T13:21:55  <bitcoin-git> bitcoin/master 62d50ef practicalswift: Add LOCKS_EXCLUDED(cs_main) to LimitValidationInterfaceQueue(...) which do...
296 2019-05-08T13:21:56  <bitcoin-git> bitcoin/master 49c1aa5 MarcoFalke: Merge #15971: validation: Add compile-time checking for negative locking r...
297 2019-05-08T13:21:57  *** bitcoin-git has left #bitcoin-core-dev
298 2019-05-08T13:22:38  *** bitcoin-git has joined #bitcoin-core-dev
299 2019-05-08T13:22:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15971: validation: Add compile-time checking for negative locking requirement in LimitValidationInterfaceQueue (master...negative-locks) https://github.com/bitcoin/bitcoin/pull/15971
300 2019-05-08T13:22:39  *** bitcoin-git has left #bitcoin-core-dev
301 2019-05-08T13:29:54  *** promag has joined #bitcoin-core-dev
302 2019-05-08T13:30:32  <jonasschnelli> fanquake: thanks... I'll have a look at that asap
303 2019-05-08T13:34:58  *** promag_ has joined #bitcoin-core-dev
304 2019-05-08T13:39:11  *** promag_ has quit IRC
305 2019-05-08T13:43:55  *** bitcoin-git has joined #bitcoin-core-dev
306 2019-05-08T13:43:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/49c1aa5f83d0...c459c5f70176
307 2019-05-08T13:43:56  <bitcoin-git> bitcoin/master 124ea38 Gregory Sanders: change default Python block serialization to witness
308 2019-05-08T13:43:57  <bitcoin-git> bitcoin/master c459c5f MarcoFalke: Merge #15664: change default Python block serialization to witness
309 2019-05-08T13:43:58  *** bitcoin-git has left #bitcoin-core-dev
310 2019-05-08T13:44:29  *** bitcoin-git has joined #bitcoin-core-dev
311 2019-05-08T13:44:30  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15664: change default Python block serialization to witness (master...default_wit_block) https://github.com/bitcoin/bitcoin/pull/15664
312 2019-05-08T13:44:31  *** bitcoin-git has left #bitcoin-core-dev
313 2019-05-08T13:44:37  *** jonatack has quit IRC
314 2019-05-08T13:46:15  *** _Sam-- has joined #bitcoin-core-dev
315 2019-05-08T13:47:54  <instagibbs> provoostenator, meshcollider re-review beg of #15452
316 2019-05-08T13:47:56  <gribble> https://github.com/bitcoin/bitcoin/issues/15452 | Replace CScriptID and CKeyID in CTxDestination with dedicated types by instagibbs · Pull Request #15452 · bitcoin/bitcoin · GitHub
317 2019-05-08T14:00:25  *** sdaftuar has quit IRC
318 2019-05-08T14:01:13  *** bitcoin-git has joined #bitcoin-core-dev
319 2019-05-08T14:01:13  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15982: test: Remove True argument to CBlock::serialize (master...1905-testWitnessTrue) https://github.com/bitcoin/bitcoin/pull/15982
320 2019-05-08T14:01:17  *** bitcoin-git has left #bitcoin-core-dev
321 2019-05-08T14:01:57  *** promag_ has joined #bitcoin-core-dev
322 2019-05-08T14:02:42  *** scoop has quit IRC
323 2019-05-08T14:02:49  *** drexl has quit IRC
324 2019-05-08T14:05:04  *** drexl_ has joined #bitcoin-core-dev
325 2019-05-08T14:23:23  *** sdaftuar has joined #bitcoin-core-dev
326 2019-05-08T14:29:58  *** promag_ has quit IRC
327 2019-05-08T14:31:43  <luke-jr> does C++ have a way to say "this method can be called with a const or non-const `this`, but the types yielded by it have the same constness"?
328 2019-05-08T14:34:14  *** pinheadmz has joined #bitcoin-core-dev
329 2019-05-08T14:34:52  *** scoop has joined #bitcoin-core-dev
330 2019-05-08T14:35:45  *** spinza has quit IRC
331 2019-05-08T14:42:16  *** drexl_ has left #bitcoin-core-dev
332 2019-05-08T14:42:33  *** spinza has joined #bitcoin-core-dev
333 2019-05-08T14:59:24  *** kevinryan has joined #bitcoin-core-dev
334 2019-05-08T15:00:02  *** Leo-WAC-WAC has quit IRC
335 2019-05-08T15:02:55  *** kevinryan has quit IRC
336 2019-05-08T15:03:15  *** kevinryan has joined #bitcoin-core-dev
337 2019-05-08T15:18:09  *** Dimlock has joined #bitcoin-core-dev
338 2019-05-08T15:20:28  *** kevinryan has quit IRC
339 2019-05-08T15:21:04  *** michaelfolkson has quit IRC
340 2019-05-08T15:22:55  *** kevinryan has joined #bitcoin-core-dev
341 2019-05-08T15:38:04  *** kevinryan has quit IRC
342 2019-05-08T15:41:37  *** shesek has quit IRC
343 2019-05-08T15:44:24  *** ccdle12 has joined #bitcoin-core-dev
344 2019-05-08T15:58:21  *** laptop500 has quit IRC
345 2019-05-08T16:00:52  *** csknk has joined #bitcoin-core-dev
346 2019-05-08T16:08:10  *** setpill has quit IRC
347 2019-05-08T16:13:10  *** Aaronvan_ is now known as AaronvanW
348 2019-05-08T16:13:25  *** scoop has quit IRC
349 2019-05-08T16:13:58  *** scoop has joined #bitcoin-core-dev
350 2019-05-08T16:21:16  *** michaelfolkson has joined #bitcoin-core-dev
351 2019-05-08T16:26:43  *** scoop has quit IRC
352 2019-05-08T16:36:39  *** JulioBarros has joined #bitcoin-core-dev
353 2019-05-08T16:38:29  *** scoop has joined #bitcoin-core-dev
354 2019-05-08T16:42:49  *** scoop has quit IRC
355 2019-05-08T16:47:35  *** shesek has joined #bitcoin-core-dev
356 2019-05-08T16:54:47  *** scoop has joined #bitcoin-core-dev
357 2019-05-08T16:59:09  *** scoop has quit IRC
358 2019-05-08T17:03:47  *** Chris_Stewart_5 has quit IRC
359 2019-05-08T17:07:23  *** promag_ has joined #bitcoin-core-dev
360 2019-05-08T17:07:55  *** jarthur has joined #bitcoin-core-dev
361 2019-05-08T17:11:48  *** promag_ has quit IRC
362 2019-05-08T17:14:20  *** scoop has joined #bitcoin-core-dev
363 2019-05-08T17:17:41  *** timothy has quit IRC
364 2019-05-08T17:18:51  *** scoop has quit IRC
365 2019-05-08T17:40:15  *** cubancorona has joined #bitcoin-core-dev
366 2019-05-08T17:41:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
367 2019-05-08T17:43:23  <jb55> can you re-org from genesis in principle? there's nothing preventing that in the code right?
368 2019-05-08T17:43:55  *** Zenton has quit IRC
369 2019-05-08T17:43:55  <sipa> genesis is hardcoded, you can't reorg away from the genesis block
370 2019-05-08T17:44:02  <sipa> even if you disable checkpoints
371 2019-05-08T17:44:44  <jb55> I mean from one after genesis
372 2019-05-08T17:46:07  <sipa> yes
373 2019-05-08T17:46:27  <jb55> kk thx
374 2019-05-08T17:47:46  *** Elkim has joined #bitcoin-core-dev
375 2019-05-08T17:48:17  *** b10c has joined #bitcoin-core-dev
376 2019-05-08T17:53:18  *** scoop has joined #bitcoin-core-dev
377 2019-05-08T17:54:18  *** scoop has quit IRC
378 2019-05-08T17:54:29  *** scoop has joined #bitcoin-core-dev
379 2019-05-08T18:00:02  *** Dimlock has quit IRC
380 2019-05-08T18:00:34  *** Elkim has left #bitcoin-core-dev
381 2019-05-08T18:01:27  *** michaelsdunn1 has joined #bitcoin-core-dev
382 2019-05-08T18:03:05  <luke-jr> jb55: checkpoints prevent that, but can be disabled as sipa points out
383 2019-05-08T18:07:05  *** csknk has quit IRC
384 2019-05-08T18:08:20  *** ccdle12 has quit IRC
385 2019-05-08T18:09:24  *** michaelfolkson has quit IRC
386 2019-05-08T18:15:53  <phantomcircuit> luke-jr, iirc the checkpoints don't prevent a re-org like that either exactly
387 2019-05-08T18:16:59  <sipa> they do
388 2019-05-08T18:17:12  <sipa> assumevalid does not
389 2019-05-08T18:17:23  <sipa> but checkpoints actually prevent reorging away feom
390 2019-05-08T18:19:21  *** shesek has quit IRC
391 2019-05-08T18:19:55  *** b_b1 has joined #bitcoin-core-dev
392 2019-05-08T18:20:20  *** bitcoin-git has joined #bitcoin-core-dev
393 2019-05-08T18:20:20  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15983: build with -fstack-reuse=none (master...1905-buildStackReuseNone) https://github.com/bitcoin/bitcoin/pull/15983
394 2019-05-08T18:20:33  *** bitcoin-git has left #bitcoin-core-dev
395 2019-05-08T18:22:01  *** scoop has quit IRC
396 2019-05-08T18:22:35  *** scoop has joined #bitcoin-core-dev
397 2019-05-08T18:23:24  *** bitcoin-git has joined #bitcoin-core-dev
398 2019-05-08T18:23:24  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15959: refactor: Work around gcc compiler bug 90348 (master...1905-gccBugWorkaround) https://github.com/bitcoin/bitcoin/pull/15959
399 2019-05-08T18:23:25  *** bitcoin-git has left #bitcoin-core-dev
400 2019-05-08T18:27:39  *** scoop has quit IRC
401 2019-05-08T18:30:42  *** scoop has joined #bitcoin-core-dev
402 2019-05-08T18:47:01  *** michaelfolkson has joined #bitcoin-core-dev
403 2019-05-08T18:47:01  *** b10c has quit IRC
404 2019-05-08T18:47:04  *** cubancorona has quit IRC
405 2019-05-08T18:47:26  *** cubancorona has joined #bitcoin-core-dev
406 2019-05-08T18:55:51  *** hebasto has joined #bitcoin-core-dev
407 2019-05-08T19:00:44  *** EagleTM has joined #bitcoin-core-dev
408 2019-05-08T19:02:05  *** roconnor has joined #bitcoin-core-dev
409 2019-05-08T19:07:31  *** scoop has quit IRC
410 2019-05-08T19:08:03  *** scoop has joined #bitcoin-core-dev
411 2019-05-08T19:09:16  *** scoop has quit IRC
412 2019-05-08T19:09:27  *** scoop has joined #bitcoin-core-dev
413 2019-05-08T19:10:52  *** queip has quit IRC
414 2019-05-08T19:12:01  *** rafalcpp_ has joined #bitcoin-core-dev
415 2019-05-08T19:12:27  *** rafalcpp has quit IRC
416 2019-05-08T19:15:39  *** Lightlike has joined #bitcoin-core-dev
417 2019-05-08T19:20:11  *** scoop has quit IRC
418 2019-05-08T19:30:37  *** queip has joined #bitcoin-core-dev
419 2019-05-08T19:41:43  *** ovovo has quit IRC
420 2019-05-08T19:46:46  *** Zenton has joined #bitcoin-core-dev
421 2019-05-08T19:46:58  *** shesek has joined #bitcoin-core-dev
422 2019-05-08T19:47:58  *** laptop500 has joined #bitcoin-core-dev
423 2019-05-08T19:50:02  *** fanquake has quit IRC
424 2019-05-08T19:51:23  *** fanquake has joined #bitcoin-core-dev
425 2019-05-08T19:56:03  *** Emcy has quit IRC
426 2019-05-08T19:56:39  *** Emcy has joined #bitcoin-core-dev
427 2019-05-08T20:01:28  *** bitcoin-git has joined #bitcoin-core-dev
428 2019-05-08T20:01:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c459c5f70176...08788ce1701a
429 2019-05-08T20:01:29  <bitcoin-git> bitcoin/master e0bb279 David A. Harding: Doc: remove text about txes always relayed from -whitelist
430 2019-05-08T20:01:30  <bitcoin-git> bitcoin/master 08788ce MarcoFalke: Merge #15890: Doc: remove text about txes always relayed from -whitelist
431 2019-05-08T20:01:32  *** bitcoin-git has left #bitcoin-core-dev
432 2019-05-08T20:02:08  *** bitcoin-git has joined #bitcoin-core-dev
433 2019-05-08T20:02:08  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15890: Doc: remove text about txes always relayed from -whitelist (master...2019-04-whitelist-help) https://github.com/bitcoin/bitcoin/pull/15890
434 2019-05-08T20:02:10  *** bitcoin-git has left #bitcoin-core-dev
435 2019-05-08T20:03:47  *** scoop has joined #bitcoin-core-dev
436 2019-05-08T20:07:55  *** scoop has quit IRC
437 2019-05-08T20:11:54  *** DougieBot5000_ has joined #bitcoin-core-dev
438 2019-05-08T20:15:03  *** waxwing has quit IRC
439 2019-05-08T20:15:03  *** baldur has quit IRC
440 2019-05-08T20:15:03  *** rockhouse has quit IRC
441 2019-05-08T20:15:03  *** votesmith has quit IRC
442 2019-05-08T20:15:28  *** rafalcpp_ has quit IRC
443 2019-05-08T20:15:29  *** DougieBot5000 has quit IRC
444 2019-05-08T20:15:29  *** gnusha has quit IRC
445 2019-05-08T20:15:39  *** rockhouse has joined #bitcoin-core-dev
446 2019-05-08T20:16:14  *** rafalcpp_ has joined #bitcoin-core-dev
447 2019-05-08T20:17:15  *** gnusha has joined #bitcoin-core-dev
448 2019-05-08T20:18:34  *** scoop has joined #bitcoin-core-dev
449 2019-05-08T20:20:38  *** votesmith has joined #bitcoin-core-dev
450 2019-05-08T20:21:22  *** waxwing has joined #bitcoin-core-dev
451 2019-05-08T20:21:54  *** waxwing has quit IRC
452 2019-05-08T20:21:55  *** waxwing has joined #bitcoin-core-dev
453 2019-05-08T20:22:23  *** hebasto has quit IRC
454 2019-05-08T20:22:58  *** scoop has quit IRC
455 2019-05-08T20:27:35  *** baldur has joined #bitcoin-core-dev
456 2019-05-08T20:33:13  *** bitcoin-git has joined #bitcoin-core-dev
457 2019-05-08T20:33:13  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #15984: net: Remove -whitelistrelay (master...1905-netWhitelistRelay) https://github.com/bitcoin/bitcoin/pull/15984
458 2019-05-08T20:33:14  *** bitcoin-git has left #bitcoin-core-dev
459 2019-05-08T20:34:30  *** scoop has joined #bitcoin-core-dev
460 2019-05-08T20:34:35  *** scoop has quit IRC
461 2019-05-08T20:44:19  *** bitcoin-git has joined #bitcoin-core-dev
462 2019-05-08T20:44:19  <bitcoin-git> [bitcoin] sipa opened pull request #15985: Add test for GCC bug 90348 (master...201905_gccbug90348) https://github.com/bitcoin/bitcoin/pull/15985
463 2019-05-08T20:44:32  *** bitcoin-git has left #bitcoin-core-dev
464 2019-05-08T21:00:01  *** b_b1 has quit IRC
465 2019-05-08T21:00:12  <MarcoFalke> gmaxwell: Wouldn't the (blocksonly) border node need to accept txs from whitelisted wallets?
466 2019-05-08T21:00:52  <MarcoFalke> Also, if blocksonly is recommended for security or resource conversation, it shouldn't be a hidden debug option
467 2019-05-08T21:01:43  <MarcoFalke> Anyway, I tend to agree with your idea to make whitelisting more specific
468 2019-05-08T21:03:13  *** Chris_Stewart_5 has quit IRC
469 2019-05-08T21:03:20  <MarcoFalke> But that should probably happen on a per-node basis. E.g. whitelistfortxrelay=${Node_Address}:{Whitelist_Level}
470 2019-05-08T21:04:46  <gmaxwell> It shouldn't be hidden.
471 2019-05-08T21:05:13  <gmaxwell> MarcoFalke: not levels, flags, most things whitelisty things are not ordereable.
472 2019-05-08T21:05:42  <gmaxwell> It's hidden because of historical reasons, I'd forgotten it was. it's frequently recommended.
473 2019-05-08T21:05:56  <MarcoFalke> So that should be changed first, I guess
474 2019-05-08T21:07:13  <gmaxwell> Flags would be pretty awesome.
475 2019-05-08T21:11:16  *** hashist has joined #bitcoin-core-dev
476 2019-05-08T21:21:46  *** bitcoin-git has joined #bitcoin-core-dev
477 2019-05-08T21:21:46  <bitcoin-git> [bitcoin] sipa opened pull request #15986: Add unmodified-descriptor-with-checksum to getdescriptorinfo (master...201905_justchecksum) https://github.com/bitcoin/bitcoin/pull/15986
478 2019-05-08T21:21:47  *** bitcoin-git has left #bitcoin-core-dev
479 2019-05-08T21:23:22  *** thaumavorio_ is now known as thaumavorio
480 2019-05-08T21:26:30  *** michaelfolkson has quit IRC
481 2019-05-08T21:35:02  *** bushstar has quit IRC
482 2019-05-08T21:42:26  *** bitcoin-git has joined #bitcoin-core-dev
483 2019-05-08T21:42:26  <bitcoin-git> [bitcoin] luke-jr opened pull request #15987: Wallet, GUI: Warn when sending to already-used Bitcoin addresses (also RPC: include such information in getaddressinfo) (master...wallet_no_reuse) https://github.com/bitcoin/bitcoin/pull/15987
484 2019-05-08T21:42:27  *** bitcoin-git has left #bitcoin-core-dev
485 2019-05-08T21:44:12  <gmaxwell> \O/
486 2019-05-08T21:47:47  *** indolering has joined #bitcoin-core-dev
487 2019-05-08T22:04:09  *** spinza has quit IRC
488 2019-05-08T22:04:57  *** side^effects has joined #bitcoin-core-dev
489 2019-05-08T22:07:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
490 2019-05-08T22:12:30  *** spinza has joined #bitcoin-core-dev
491 2019-05-08T22:18:49  *** Chris_Stewart_5 has quit IRC
492 2019-05-08T22:26:20  *** michaelsdunn1 has quit IRC
493 2019-05-08T22:30:23  *** Guyver2 has quit IRC
494 2019-05-08T22:40:03  *** Dean_Guss has quit IRC
495 2019-05-08T22:42:57  *** Lightlike has quit IRC
496 2019-05-08T22:43:35  *** michaelfolkson has joined #bitcoin-core-dev
497 2019-05-08T22:49:41  *** JulioBarros has quit IRC
498 2019-05-08T22:51:15  *** michaelfolkson has quit IRC
499 2019-05-08T23:00:04  *** bushstar has joined #bitcoin-core-dev
500 2019-05-08T23:02:35  *** scoop has joined #bitcoin-core-dev
501 2019-05-08T23:03:59  *** jarthur_ has joined #bitcoin-core-dev
502 2019-05-08T23:04:51  *** bushstar has quit IRC
503 2019-05-08T23:06:13  *** scoop has quit IRC
504 2019-05-08T23:06:19  *** scoop has joined #bitcoin-core-dev
505 2019-05-08T23:07:20  *** jarthur has quit IRC
506 2019-05-08T23:08:33  *** jarthur_ has quit IRC
507 2019-05-08T23:17:00  *** laptop500 has quit IRC
508 2019-05-08T23:18:19  *** jarthur has joined #bitcoin-core-dev
509 2019-05-08T23:19:14  *** scoop has quit IRC
510 2019-05-08T23:32:05  *** scoop has joined #bitcoin-core-dev
511 2019-05-08T23:36:12  *** scoop has quit IRC
512 2019-05-08T23:40:09  *** dfsg has joined #bitcoin-core-dev
513 2019-05-08T23:40:58  *** dfsg has left #bitcoin-core-dev
514 2019-05-08T23:41:15  *** booyah has joined #bitcoin-core-dev
515 2019-05-08T23:43:52  *** murrayn has quit IRC
516 2019-05-08T23:50:04  *** scoop has joined #bitcoin-core-dev
517 2019-05-08T23:52:56  *** scoop has quit IRC
518 2019-05-08T23:55:27  *** scoop has joined #bitcoin-core-dev