12019-05-10T00:00:02  *** tss1 has quit IRC
  22019-05-10T00:01:06  *** michaelfolkson has quit IRC
  32019-05-10T00:03:47  *** scoop has quit IRC
  42019-05-10T00:04:11  *** Chris_Stewart_5 has quit IRC
  52019-05-10T00:05:29  *** scoop has joined #bitcoin-core-dev
  62019-05-10T00:09:50  *** omonk has quit IRC
  72019-05-10T00:11:32  *** scoop has quit IRC
  82019-05-10T00:15:08  *** omonk has joined #bitcoin-core-dev
  92019-05-10T00:18:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 102019-05-10T00:19:54  *** ccdle12 has quit IRC
 112019-05-10T00:24:14  *** scoop has joined #bitcoin-core-dev
 122019-05-10T00:24:25  *** scoop has quit IRC
 132019-05-10T00:24:31  *** scoop has joined #bitcoin-core-dev
 142019-05-10T00:24:51  *** AaronvanW has quit IRC
 152019-05-10T00:28:22  *** jeremyrubin has quit IRC
 162019-05-10T00:30:37  *** fanquake has quit IRC
 172019-05-10T00:32:20  *** Chris_Stewart_5 has quit IRC
 182019-05-10T00:33:35  *** jeremyrubin has joined #bitcoin-core-dev
 192019-05-10T00:33:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 202019-05-10T00:43:06  *** ccdle12 has joined #bitcoin-core-dev
 212019-05-10T00:47:57  *** ccdle12 has quit IRC
 222019-05-10T00:55:13  *** igorivachshenko has joined #bitcoin-core-dev
 232019-05-10T00:55:29  *** aclark1 has joined #bitcoin-core-dev
 242019-05-10T01:01:30  *** jimmysong_ has quit IRC
 252019-05-10T01:01:52  *** jimmysong_ has joined #bitcoin-core-dev
 262019-05-10T01:09:53  *** bitcoin-git has joined #bitcoin-core-dev
 272019-05-10T01:09:53  <bitcoin-git> [bitcoin] sipa opened pull request #16001: Give WalletModel::UnlockContext move semantics (master...201905_moveunlockcontext) https://github.com/bitcoin/bitcoin/pull/16001
 282019-05-10T01:09:58  *** bitcoin-git has left #bitcoin-core-dev
 292019-05-10T01:10:55  *** Chris_Stewart_5 has quit IRC
 302019-05-10T01:13:01  *** igorivachshenko has quit IRC
 312019-05-10T01:13:32  *** schmidty has quit IRC
 322019-05-10T01:19:53  *** Zenton has joined #bitcoin-core-dev
 332019-05-10T01:24:35  *** schmidty has joined #bitcoin-core-dev
 342019-05-10T01:24:35  *** schmidty has joined #bitcoin-core-dev
 352019-05-10T01:27:28  *** fanquake has joined #bitcoin-core-dev
 362019-05-10T01:40:03  *** scoop has quit IRC
 372019-05-10T01:40:30  *** scoop has joined #bitcoin-core-dev
 382019-05-10T01:41:04  *** belcher has quit IRC
 392019-05-10T01:44:50  *** scoop has quit IRC
 402019-05-10T01:45:17  *** scoop has joined #bitcoin-core-dev
 412019-05-10T01:45:46  *** scoop has quit IRC
 422019-05-10T01:45:54  *** scoop has joined #bitcoin-core-dev
 432019-05-10T01:50:35  *** rhavar has quit IRC
 442019-05-10T01:53:10  *** d_t has quit IRC
 452019-05-10T01:59:20  *** scoop has quit IRC
 462019-05-10T01:59:47  *** scoop has joined #bitcoin-core-dev
 472019-05-10T02:04:00  *** scoop has quit IRC
 482019-05-10T02:04:56  *** scoop has joined #bitcoin-core-dev
 492019-05-10T02:12:07  *** scoop has quit IRC
 502019-05-10T02:12:14  *** scoop has joined #bitcoin-core-dev
 512019-05-10T02:22:45  *** Dean_Guss has joined #bitcoin-core-dev
 522019-05-10T02:23:14  *** scoop has quit IRC
 532019-05-10T02:32:34  *** thaumavorio has quit IRC
 542019-05-10T02:33:32  *** thaumavorio has joined #bitcoin-core-dev
 552019-05-10T02:34:06  *** d_t has joined #bitcoin-core-dev
 562019-05-10T02:45:15  *** jhfrontz has quit IRC
 572019-05-10T03:00:01  *** aclark1 has quit IRC
 582019-05-10T03:00:21  *** bushstar has joined #bitcoin-core-dev
 592019-05-10T03:00:28  *** millerti has quit IRC
 602019-05-10T03:04:00  *** havenwood1 has joined #bitcoin-core-dev
 612019-05-10T03:06:13  *** scoop has joined #bitcoin-core-dev
 622019-05-10T03:10:53  *** tryphe_ has joined #bitcoin-core-dev
 632019-05-10T03:12:36  *** tryphe has quit IRC
 642019-05-10T03:14:08  *** Eagle[TM] has joined #bitcoin-core-dev
 652019-05-10T03:15:09  *** scoop has quit IRC
 662019-05-10T03:15:59  *** EagleTM has quit IRC
 672019-05-10T03:27:28  *** scoop has joined #bitcoin-core-dev
 682019-05-10T03:31:58  *** scoop has quit IRC
 692019-05-10T03:40:57  *** scoop has joined #bitcoin-core-dev
 702019-05-10T03:48:28  *** scoop has quit IRC
 712019-05-10T04:09:06  *** hebasto has joined #bitcoin-core-dev
 722019-05-10T04:15:23  *** scoop has joined #bitcoin-core-dev
 732019-05-10T04:19:53  *** scoop has quit IRC
 742019-05-10T04:23:24  *** scoop has joined #bitcoin-core-dev
 752019-05-10T04:37:09  *** d_t has quit IRC
 762019-05-10T04:37:39  *** scoop has quit IRC
 772019-05-10T04:39:23  *** d_t has joined #bitcoin-core-dev
 782019-05-10T04:41:30  *** tryphe_ is now known as tryphe
 792019-05-10T04:44:03  *** d_t has quit IRC
 802019-05-10T04:44:31  *** bushstar has quit IRC
 812019-05-10T04:46:07  *** scoop has joined #bitcoin-core-dev
 822019-05-10T04:57:06  *** ccdle12_ has joined #bitcoin-core-dev
 832019-05-10T04:58:38  *** scoop has quit IRC
 842019-05-10T05:14:52  *** spaced0ut has quit IRC
 852019-05-10T05:15:10  *** ccdle12_ has quit IRC
 862019-05-10T05:25:35  *** scoop has joined #bitcoin-core-dev
 872019-05-10T05:30:02  *** scoop has quit IRC
 882019-05-10T05:39:59  *** scoop has joined #bitcoin-core-dev
 892019-05-10T06:00:01  *** havenwood1 has quit IRC
 902019-05-10T06:04:29  *** scoop has quit IRC
 912019-05-10T06:05:44  *** scoop has joined #bitcoin-core-dev
 922019-05-10T06:13:58  *** scoop has quit IRC
 932019-05-10T06:17:17  *** d_t has joined #bitcoin-core-dev
 942019-05-10T06:22:19  *** Eagle[TM] has quit IRC
 952019-05-10T06:26:46  *** alct has joined #bitcoin-core-dev
 962019-05-10T06:28:54  *** rockhouse has joined #bitcoin-core-dev
 972019-05-10T06:29:08  *** victorSN has joined #bitcoin-core-dev
 982019-05-10T06:32:37  *** spinza has quit IRC
 992019-05-10T06:44:15  *** scoop has joined #bitcoin-core-dev
1002019-05-10T06:48:40  *** scoop has quit IRC
1012019-05-10T06:50:09  *** spinza has joined #bitcoin-core-dev
1022019-05-10T06:52:23  *** Chris2009 has joined #bitcoin-core-dev
1032019-05-10T06:59:05  *** jimmysong_ has quit IRC
1042019-05-10T07:14:22  <jonasschnelli> sipa: Oh. I wasn't aware importmulti does not support private keys through descriptors...
1052019-05-10T07:17:01  *** scoop has joined #bitcoin-core-dev
1062019-05-10T07:20:12  <jonasschnelli> We don't even mention this in the importmulti help (that private key based descriptors silently "ignore" the privkeys)?
1072019-05-10T07:20:32  <gwillen> I believe this is what #15414 fixes
1082019-05-10T07:20:33  <gribble> https://github.com/bitcoin/bitcoin/issues/15414 | [wallet] allow adding pubkeys from imported private keys to keypool by Sjors · Pull Request #15414 · bitcoin/bitcoin · GitHub
1092019-05-10T07:20:48  *** d_t has quit IRC
1102019-05-10T07:21:09  <gwillen> oh, that might be the wrong PR
1112019-05-10T07:21:27  *** scoop has quit IRC
1122019-05-10T07:21:49  <gwillen> I meant #15024
1132019-05-10T07:21:51  <gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
1142019-05-10T07:22:20  <gwillen> which is in the high priority list
1152019-05-10T07:26:16  <jonasschnelli> Yes. I see. But maybe we should add something to the importmulti help (and backport)
1162019-05-10T07:27:49  *** bitcoin-git has joined #bitcoin-core-dev
1172019-05-10T07:27:50  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/79046d574980...695141bf7a32
1182019-05-10T07:27:51  <bitcoin-git> bitcoin/master 2bc2b8b Jonas Schnelli: Add ChaCha20 encryption option (XOR)
1192019-05-10T07:27:51  <bitcoin-git> bitcoin/master 2dfe275 Jonas Schnelli: Add ChaCha20 bench
1202019-05-10T07:27:52  <bitcoin-git> bitcoin/master 695141b Jonas Schnelli: Merge #15512: Add ChaCha20 encryption option (XOR)
1212019-05-10T07:27:53  *** bitcoin-git has left #bitcoin-core-dev
1222019-05-10T07:28:14  *** fanquake has quit IRC
1232019-05-10T07:28:25  *** bitcoin-git has joined #bitcoin-core-dev
1242019-05-10T07:28:25  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15512: Add ChaCha20 encryption option (XOR) (master...2019/03/chacha) https://github.com/bitcoin/bitcoin/pull/15512
1252019-05-10T07:28:27  *** bitcoin-git has left #bitcoin-core-dev
1262019-05-10T07:39:49  *** AaronvanW has joined #bitcoin-core-dev
1272019-05-10T08:04:23  <tryphe> anyone know if -addnode connections count towards the total of maxconnections? no, right?
1282019-05-10T08:08:59  <gmaxwell> tryphe: max connections, yes, but not your outbound connections
1292019-05-10T08:09:54  *** laptop500 has joined #bitcoin-core-dev
1302019-05-10T08:10:17  <gmaxwell> Why?
1312019-05-10T08:10:38  <wumpus> yes, maxconnections is a hard limit (to be able to limit memory and file descriptor usage), there should be no way to exceed it
1322019-05-10T08:11:01  *** AaronvanW has quit IRC
1332019-05-10T08:13:25  <tryphe> gmaxwell, i'm about to open a PR that addresses a bug and has some logic fixes but i'm unsure about a small part of it, in terms of the "minimum" number of file handles we should request in terms of addnode/outbound/feeler connections. MAX_ADDNODE_CONNECTIONS + MAX_OUTBOUND_CONNECTIONS + feelers = 8 + 8 + 1, but i'm not sure if that should be the minimum for -maxconnections. and if it shouldn't be, there's no way to lower those constants at
1342019-05-10T08:13:25  <tryphe> the moment.
1352019-05-10T08:13:30  *** AaronvanW has joined #bitcoin-core-dev
1362019-05-10T08:14:43  *** promag_ has joined #bitcoin-core-dev
1372019-05-10T08:18:22  <gmaxwell> tryphe: okay, reviewing the logic: reducing maxconnections can (if you set it low enough) reduce the outbound connections. But it doesn't reduce the addnode connections, because how would it decide how to split up the reduction.  Addnode connections are handled seperately for the FD limits.
1382019-05-10T08:18:57  <gmaxwell> tryphe: there probably doesn't need to be anything to lower the max addnodes: if you want fewer, add less addnodes.
1392019-05-10T08:21:01  <tryphe> gmaxwell, i just meant in determining a "soft cap" for the theoretical minimum number of handles that could be used in the normal daemon, 8+8+1 seems to be the answer there. ie. it's unknown at runtime whether the user will need it, but they might.
1402019-05-10T08:21:17  <wumpus> interesting, so maxconnections isn't really maxconnections
1412019-05-10T08:21:33  <gmaxwell> tryphe: if maxconnections is lowered one of those 8s will go down.
1422019-05-10T08:21:33  <tryphe> gmaxwell, and in this context i mean only handles for sockets
1432019-05-10T08:22:10  <wumpus> I think it used to be different, but no sure...
1442019-05-10T08:22:25  <tryphe> it got changed about a year ago with the new select() code i believe
1452019-05-10T08:22:30  <gmaxwell> wumpus: right, I'd forgotten about that. It's because if maxconnections is set lower than 16 how do would decide how to share with addnode? and addnodes can be limited by not using them.
1462019-05-10T08:22:52  <gmaxwell> wumpus: it was probably done by the change to make addnodes not use up the outbound connection slots.
1472019-05-10T08:23:08  <gmaxwell> (which made addnode unreliable, since outbounds would eat up all its slots)
1482019-05-10T08:23:13  <wumpus> gmaxwell: I would have expected addnode to fail at some point if it requests adding connections and there are no slots available, but I agree
1492019-05-10T08:23:20  <gmaxwell> it wasn't an unintentional change, I just didn't remember it.
1502019-05-10T08:23:54  <wumpus> addnode is always a manual action so if you run out of resources that way, it's your own fault
1512019-05-10T08:24:17  <tryphe> i'm not using addnode, i'm just asking for the bug's sake (you'll see in a second, hehe)
1522019-05-10T08:24:30  <tryphe> it probably needs some fixing
1532019-05-10T08:25:51  <gmaxwell> wumpus: right but the problem that drove splitting them was this:  You add an addnode. Your node comes it it uses it. Great.  Then days/weeks/month later your addnode connection disconnects... now it'll never reestablish it because an automatic outbound took the 'free' socket. So the alternatives were to make addnode disconnect outbounds (which is kinda ugly since the addnode reconnect might
1542019-05-10T08:25:51  <gmaxwell> fail), or -- not share a limit.
1552019-05-10T08:27:28  *** d_t has joined #bitcoin-core-dev
1562019-05-10T08:27:32  <gmaxwell> tryphe: sure, we've been cheating for a while with the "MIN_CORE_FILEDESCRIPTORS"
1572019-05-10T08:28:05  <tryphe> if you set ulimit -n 150, you get this message: Warning: Reducing -maxconnections from 125 to -8, because of system limitations.
1582019-05-10T08:28:16  <tryphe> :D
1592019-05-10T08:28:26  <wumpus> gmaxwell: yes it gets quite complex in that case, could reserve the addnode slots and not make normal outbound connections in them (so there's nothing to disconnect), but, I think this is ok
1602019-05-10T08:29:18  <gmaxwell> wumpus: yep, though then we'd have an odd behavior that setting maxconnections < 8 would cause you to make no connections. That might not be so bad except it would be a surprise for people with maxconnections already set to some low value.
1612019-05-10T08:29:18  *** bitcoin-git has joined #bitcoin-core-dev
1622019-05-10T08:29:18  <bitcoin-git> [bitcoin] tryphe opened pull request #16003: [init] an incorrect amount of file descriptors is requested, and a different amount is also asserted (master...fd-limits-3) https://github.com/bitcoin/bitcoin/pull/16003
1632019-05-10T08:29:19  *** bitcoin-git has left #bitcoin-core-dev
1642019-05-10T08:30:00  <wumpus> tryphe: whoops it should error out in that case I think
1652019-05-10T08:30:35  <gmaxwell> tryphe: min would be 150 + 8 + 1 + 1 + 1  I think  the MAX_OUTBOUND_CONNECTIONS gets reduced.
1662019-05-10T08:30:54  <gmaxwell> connOptions.nMaxOutbound = std::min(MAX_OUTBOUND_CONNECTIONS, connOptions.nMaxConnections);
1672019-05-10T08:31:34  <gmaxwell> tryphe: sounds like you're on the right path to me, though
1682019-05-10T08:31:47  <tryphe> gmaxwell, hmm, but i wonder how the net code regards those consts. if i have -maxconnections=8 i don't know how many -addnode connections i -should- be able to make, for example
1692019-05-10T08:32:01  <tryphe> versus other connections i mean
1702019-05-10T08:32:23  <gmaxwell> tryphe: 8. it'll make up to 8 addnode connections regardless of what maxconnections is set to.
1712019-05-10T08:32:34  <tryphe> ahh i see, thanks
1722019-05-10T08:32:52  <tryphe> i figured that's how the feeler was as well
1732019-05-10T08:33:08  <gmaxwell> tryphe: wumpus and my initial answer were incorrect, addnodes don't charge against maxconnections.
1742019-05-10T08:33:31  <gmaxwell> Nor does the feeler IIRC though I haven't gone and checked again (feeler is short lived-- matters for FD accounting reasons)
1752019-05-10T08:33:38  <tryphe> okay, so i should probably exclude that from nUserMinConnections, but still include it in nFDMin
1762019-05-10T08:33:50  <tryphe> i think?
1772019-05-10T08:34:06  <gmaxwell> no.
1782019-05-10T08:34:18  <tryphe> oh, nevermind
1792019-05-10T08:34:36  <gmaxwell> if the user runs with a silly ulimit that only lets them make 0 outbounds, I suppose thats their own problem!
1802019-05-10T08:34:46  <gmaxwell> (though obviously it should be logging that fact.)
1812019-05-10T08:36:13  <tryphe> yeah, but there are systems like mac os where the requested amount comes close to the actual system limit, unlike the 1024 default in most Linux distros
1822019-05-10T08:36:30  <mryandao> is there even a use-case to apply ulimit changes before running an application?
1832019-05-10T08:37:30  <tryphe> mryandao, it was simply the only thing i could find to show that there's an issue :p
1842019-05-10T08:37:48  <gmaxwell> tryphe: on macos it increases it.
1852019-05-10T08:38:44  <gmaxwell> Erroring out would not be a good thing to do by default on any reasonably popular system.
1862019-05-10T08:38:49  <wumpus> mryandao: no, but some OSes do that automatically, I remember OpenBSD used to have very low FD limits for default users, don't know if this is stil true
1872019-05-10T08:39:23  <gmaxwell> right many of the BSDs set soft limits low (actually inhereted behavior from older unixes), but applications can increase them.
1882019-05-10T08:39:32  <wumpus> gmaxwell: I think it should error out only if it's not able to function normally, e.g. even reserve the file descriptors for the databases and default # outgoing connections
1892019-05-10T08:40:04  <wumpus> if your 'available FD count' ends up in the negative I'd say that is true
1902019-05-10T08:40:22  <gmaxwell> So this stuff about erroring out is only if we've run into the hardlimit (can't increase more) and still don't have enough to work.
1912019-05-10T08:40:28  <wumpus> much better to fail initially than later on when it's unable to open a file
1922019-05-10T08:40:31  <mryandao> its unusual for an application to be able to increase ulimit when the user has pre-define a lower ulimit before executing the application.
1932019-05-10T08:40:38  <wumpus> gmaxwell:yes, that's what I mean
1942019-05-10T08:40:42  <mryandao> what if an application decides to set to unlimited?
1952019-05-10T08:41:05  <gmaxwell> mryandao: it's _really_ common for applications to increase the soft limits. Soft limits everwhere have to be 1024 or less to prevent breaking select.
1962019-05-10T08:41:20  <gmaxwell> mryandao: so anything that doesn't have that problem increases it, your browser does, openoffice does, etc.
1972019-05-10T08:41:33  <gmaxwell> If you want to prevent that you lower the hard limit.
1982019-05-10T08:41:41  <tryphe> mryandao, the daemon can't increase the limit if you have it specifically set, though
1992019-05-10T08:41:58  <tryphe> hence 125 max connections is dynamic
2002019-05-10T08:42:40  <gmaxwell> I'm not aware of any system that has a particularly low default hard limit.
2012019-05-10T08:42:59  <tryphe> it can lower 125 to as low as 17 (with my PR), it doesn't return an error, but i feel like people might still be dumb and try to set it lower and expect it not to make those connections
2022019-05-10T08:44:03  *** AaronvanW has quit IRC
2032019-05-10T08:44:28  <gmaxwell> I don't think setting maxconnections higher than your system ulimit max count can support should result in a failure to start, it should do as it does now: log that its reducing your max connections.
2042019-05-10T08:44:59  <gmaxwell> It's debatable if it should refuse to start if it can't even get enough for 8 connections, I could go either way on that.
2052019-05-10T08:45:22  <gmaxwell> on one hand, its normal operation, on the other hand you might be noconnect and not making any connections at ll.
2062019-05-10T08:45:25  <gmaxwell> all*
2072019-05-10T08:46:55  <gmaxwell> sounds like wumpus prefers to at least preserve the ability to make 8 connections (I supose unless you've set maxconnections lower than even that)
2082019-05-10T08:47:28  *** justanotheruser has quit IRC
2092019-05-10T08:48:03  <tryphe> yeah, presumably you'd be able to run -connect=0 if you want no connections or something, as i think -maxconnections was intended to only increase connections and not specify what types of connections are to be used.
2102019-05-10T08:48:43  <tryphe> like if i have -maxconnections=1, does the feeler socket use the connection? it would be nice to mention something like that in the docs probably
2112019-05-10T08:50:40  <tryphe> i mean mention that a value below is invalid, or something
2122019-05-10T08:50:43  <tryphe> below x*
2132019-05-10T08:51:41  <gmaxwell> tryphe: no maxconnections is not intended to only increase connections.
2142019-05-10T08:51:49  <gmaxwell> In fact historically it could not increase connections.
2152019-05-10T08:52:04  <tryphe> gmaxwell, i guess i never ran with -maxconnections=0
2162019-05-10T08:52:26  <gmaxwell> tryphe: feeler and addnode do not eat into maxconnections count, I believe. (well I know for addnode, pretty sure for feeler)
2172019-05-10T08:52:41  <sipa> it's a way to set resource limitations
2182019-05-10T08:52:44  <gmaxwell> max connections is the limit on automatic and inbound connections.
2192019-05-10T08:53:18  <sipa> running with -maxconnections=20 was fairly common advice on low-memory systems (at a tike when we had huge per-peer network buffers; it's much less impactful now)
2202019-05-10T08:53:36  <sipa> *time
2212019-05-10T08:54:40  <tryphe> i think i see now: int nMaxInbound = nMaxConnections - (nMaxOutbound + nMaxFeeler); via https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L895
2222019-05-10T08:55:59  *** goatpig has quit IRC
2232019-05-10T08:56:47  *** timothy has joined #bitcoin-core-dev
2242019-05-10T09:00:02  *** alct has quit IRC
2252019-05-10T09:02:54  *** setpill has joined #bitcoin-core-dev
2262019-05-10T09:03:07  *** hebasto_ has joined #bitcoin-core-dev
2272019-05-10T09:06:21  *** d_t has quit IRC
2282019-05-10T09:17:51  *** scoop has joined #bitcoin-core-dev
2292019-05-10T09:22:16  *** scoop has quit IRC
2302019-05-10T09:22:28  *** paolo|out has joined #bitcoin-core-dev
2312019-05-10T09:48:25  *** IGHOR has quit IRC
2322019-05-10T09:53:07  *** nibnalin has joined #bitcoin-core-dev
2332019-05-10T09:57:05  *** hebasto has quit IRC
2342019-05-10T10:10:23  *** arubi has quit IRC
2352019-05-10T10:10:49  *** arubi has joined #bitcoin-core-dev
2362019-05-10T10:14:42  *** fanquake has joined #bitcoin-core-dev
2372019-05-10T10:30:19  *** spinza has quit IRC
2382019-05-10T10:36:24  *** rafalcpp_ is now known as rafalcpp
2392019-05-10T10:47:20  *** spinza has joined #bitcoin-core-dev
2402019-05-10T10:48:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2412019-05-10T10:50:38  *** luke-jr has quit IRC
2422019-05-10T10:51:35  *** hebasto_ has quit IRC
2432019-05-10T10:53:12  *** luke-jr has joined #bitcoin-core-dev
2442019-05-10T10:59:04  *** michagogo has quit IRC
2452019-05-10T10:59:48  *** michagogo has joined #bitcoin-core-dev
2462019-05-10T11:08:28  *** promag_ has quit IRC
2472019-05-10T11:10:17  *** nibnalin has quit IRC
2482019-05-10T11:10:50  *** promag_ has joined #bitcoin-core-dev
2492019-05-10T11:14:04  *** promag_ has quit IRC
2502019-05-10T11:17:31  *** promag_ has joined #bitcoin-core-dev
2512019-05-10T11:18:24  *** scoop has joined #bitcoin-core-dev
2522019-05-10T11:20:05  *** hebasto has joined #bitcoin-core-dev
2532019-05-10T11:22:48  *** IGHOR has joined #bitcoin-core-dev
2542019-05-10T11:23:32  *** scoop has quit IRC
2552019-05-10T11:39:24  *** Chris_Stewart_5 has quit IRC
2562019-05-10T11:39:36  *** emzy_ has joined #bitcoin-core-dev
2572019-05-10T11:44:32  *** Guyver2 has joined #bitcoin-core-dev
2582019-05-10T11:44:38  *** promag_ has quit IRC
2592019-05-10T11:46:59  *** ccdle12 has joined #bitcoin-core-dev
2602019-05-10T11:52:35  *** emzy_ has quit IRC
2612019-05-10T11:53:08  *** emzy_ has joined #bitcoin-core-dev
2622019-05-10T12:00:02  *** paolo|out has quit IRC
2632019-05-10T12:00:09  *** emzy_ has quit IRC
2642019-05-10T12:00:09  *** emzy_ has joined #bitcoin-core-dev
2652019-05-10T12:00:27  *** emzy_ is now known as emzy
2662019-05-10T12:00:52  *** bitcoin-git has joined #bitcoin-core-dev
2672019-05-10T12:00:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/695141bf7a32...87dbf89271df
2682019-05-10T12:00:53  <bitcoin-git> bitcoin/master 5c04814 Hennadii Stepanov: Move non-linux source tarball to bitcoin-binaries
2692019-05-10T12:00:53  <bitcoin-git> bitcoin/master 87dbf89 MarcoFalke: Merge #15239: scripts and tools: Move non-linux build source tarballs to "...
2702019-05-10T12:00:54  *** bitcoin-git has left #bitcoin-core-dev
2712019-05-10T12:01:22  *** bitcoin-git has joined #bitcoin-core-dev
2722019-05-10T12:01:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15239: scripts and tools: Move non-linux build source tarballs to "bitcoin-binaries/version" directory (master...20190123-gitian-source-tarballs) https://github.com/bitcoin/bitcoin/pull/15239
2732019-05-10T12:01:24  *** bitcoin-git has left #bitcoin-core-dev
2742019-05-10T12:11:37  *** bitcoin-git has joined #bitcoin-core-dev
2752019-05-10T12:11:38  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/87dbf89271df...14959753a424
2762019-05-10T12:11:39  <bitcoin-git> bitcoin/master 510c653 Ben Woosley: Extract ParseDescriptorRange
2772019-05-10T12:11:39  <bitcoin-git> bitcoin/master 1495975 MarcoFalke: Merge #15744: refactor: Extract ParseDescriptorRange
2782019-05-10T12:11:41  *** bitcoin-git has left #bitcoin-core-dev
2792019-05-10T12:12:17  *** bitcoin-git has joined #bitcoin-core-dev
2802019-05-10T12:12:17  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15744: refactor: Extract ParseDescriptorRange (master...parse-descriptor-range) https://github.com/bitcoin/bitcoin/pull/15744
2812019-05-10T12:12:18  *** bitcoin-git has left #bitcoin-core-dev
2822019-05-10T12:17:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2832019-05-10T12:20:42  *** panda1 has joined #bitcoin-core-dev
2842019-05-10T12:21:41  *** michaelfolkson has joined #bitcoin-core-dev
2852019-05-10T12:31:00  *** scoop has joined #bitcoin-core-dev
2862019-05-10T12:53:02  *** astro has joined #bitcoin-core-dev
2872019-05-10T12:59:39  *** hebasto has quit IRC
2882019-05-10T13:04:09  *** scoop has quit IRC
2892019-05-10T13:04:17  *** scoop has joined #bitcoin-core-dev
2902019-05-10T13:05:14  *** scoop has quit IRC
2912019-05-10T13:08:34  *** nibnalin has joined #bitcoin-core-dev
2922019-05-10T13:13:03  *** scoop has joined #bitcoin-core-dev
2932019-05-10T13:13:13  *** scoop has quit IRC
2942019-05-10T13:13:39  *** scoop has joined #bitcoin-core-dev
2952019-05-10T13:16:42  *** Chris_Stewart_5 has quit IRC
2962019-05-10T13:16:47  *** bitcoin-git has joined #bitcoin-core-dev
2972019-05-10T13:16:47  <bitcoin-git> [bitcoin] nalinbhardwaj opened pull request #16006: rpc: use walletrbf as default setting in walletcreatefundedpsbt (master...walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/16006
2982019-05-10T13:16:48  *** bitcoin-git has left #bitcoin-core-dev
2992019-05-10T13:17:58  *** scoop has quit IRC
3002019-05-10T13:19:35  *** dqx has quit IRC
3012019-05-10T13:27:53  *** dqx has joined #bitcoin-core-dev
3022019-05-10T13:29:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3032019-05-10T13:46:40  *** scoop has joined #bitcoin-core-dev
3042019-05-10T13:50:43  *** d_t has joined #bitcoin-core-dev
3052019-05-10T13:52:07  *** scoop has quit IRC
3062019-05-10T13:55:02  *** d_t has quit IRC
3072019-05-10T14:01:28  *** jhfrontz has joined #bitcoin-core-dev
3082019-05-10T14:01:55  *** spaced0ut has joined #bitcoin-core-dev
3092019-05-10T14:19:03  *** shesek has quit IRC
3102019-05-10T14:26:48  *** hebasto has joined #bitcoin-core-dev
3112019-05-10T14:28:43  *** scoop has joined #bitcoin-core-dev
3122019-05-10T14:29:40  *** dfsg has joined #bitcoin-core-dev
3132019-05-10T14:29:58  *** dfsg has left #bitcoin-core-dev
3142019-05-10T14:30:29  *** dfsg has joined #bitcoin-core-dev
3152019-05-10T14:30:34  *** dfsg has left #bitcoin-core-dev
3162019-05-10T14:36:11  *** scoop has quit IRC
3172019-05-10T14:39:08  *** promag_ has joined #bitcoin-core-dev
3182019-05-10T14:39:21  *** scoop has joined #bitcoin-core-dev
3192019-05-10T14:46:24  *** Chris_Stewart_5 has quit IRC
3202019-05-10T14:52:27  *** michaelsdunn1 has joined #bitcoin-core-dev
3212019-05-10T15:00:01  *** panda1 has quit IRC
3222019-05-10T15:01:19  *** scoop has quit IRC
3232019-05-10T15:02:54  *** scoop has joined #bitcoin-core-dev
3242019-05-10T15:04:28  *** scoop has quit IRC
3252019-05-10T15:04:39  *** scoop has joined #bitcoin-core-dev
3262019-05-10T15:05:45  *** scoop has quit IRC
3272019-05-10T15:06:12  *** scoop has joined #bitcoin-core-dev
3282019-05-10T15:08:11  *** sdaftuar has joined #bitcoin-core-dev
3292019-05-10T15:10:19  *** scoop has quit IRC
3302019-05-10T15:13:36  *** ExEric3 has quit IRC
3312019-05-10T15:13:55  *** ExEric3 has joined #bitcoin-core-dev
3322019-05-10T15:16:17  *** setpill has quit IRC
3332019-05-10T15:20:02  *** promag_ has quit IRC
3342019-05-10T15:21:59  *** lipsch has joined #bitcoin-core-dev
3352019-05-10T15:26:03  *** shortdudey1231 has joined #bitcoin-core-dev
3362019-05-10T15:28:19  *** jnewbery has quit IRC
3372019-05-10T15:28:41  *** lipsch has quit IRC
3382019-05-10T15:33:53  *** ccdle12_ has joined #bitcoin-core-dev
3392019-05-10T15:37:25  <tryphe> gmaxwell/wumpus: i smoothed some things out better, but still not sure if that feeler connection should be added to the initial handle minimum. let me know what you think.
3402019-05-10T15:37:32  *** ccdle12 has quit IRC
3412019-05-10T15:37:40  <tryphe> handle/descriptor*
3422019-05-10T15:38:39  *** promag_ has joined #bitcoin-core-dev
3432019-05-10T15:41:36  *** promag_ has quit IRC
3442019-05-10T15:44:29  *** promag_ has joined #bitcoin-core-dev
3452019-05-10T15:45:22  *** jnewbery has joined #bitcoin-core-dev
3462019-05-10T15:45:40  *** jnewbery has joined #bitcoin-core-dev
3472019-05-10T15:49:04  *** promag_ has quit IRC
3482019-05-10T16:05:23  *** promag_ has joined #bitcoin-core-dev
3492019-05-10T16:09:43  *** promag_ has quit IRC
3502019-05-10T16:10:03  *** nibnalin has quit IRC
3512019-05-10T16:25:07  *** d_t has joined #bitcoin-core-dev
3522019-05-10T16:25:19  *** jonatack has joined #bitcoin-core-dev
3532019-05-10T16:34:56  *** CubicEarth has quit IRC
3542019-05-10T16:41:28  *** bitcoin-git has joined #bitcoin-core-dev
3552019-05-10T16:41:29  <bitcoin-git> [bitcoin] nalinbhardwaj closed pull request #16006: rpc: use walletrbf as default setting in walletcreatefundedpsbt (master...walletcreatefundedpsbt) https://github.com/bitcoin/bitcoin/pull/16006
3562019-05-10T16:41:30  *** bitcoin-git has left #bitcoin-core-dev
3572019-05-10T16:42:00  *** sfhi has joined #bitcoin-core-dev
3582019-05-10T16:48:35  *** nibnalin has joined #bitcoin-core-dev
3592019-05-10T16:49:09  *** promag_ has joined #bitcoin-core-dev
3602019-05-10T16:50:00  *** d_t has quit IRC
3612019-05-10T16:53:51  *** d_t has joined #bitcoin-core-dev
3622019-05-10T16:53:51  *** sfhi2 has joined #bitcoin-core-dev
3632019-05-10T16:56:02  *** promag_ has quit IRC
3642019-05-10T16:57:26  *** sfhi has quit IRC
3652019-05-10T17:01:34  *** ccdle12_ has quit IRC
3662019-05-10T17:06:39  *** Dean_Guss has quit IRC
3672019-05-10T17:06:58  *** CubicEarth has joined #bitcoin-core-dev
3682019-05-10T17:11:42  *** timothy has quit IRC
3692019-05-10T17:14:54  <gmaxwell> tryphe: I think they should, you can't deactivate the feeler.
3702019-05-10T17:22:42  *** bitcoin-git has joined #bitcoin-core-dev
3712019-05-10T17:22:43  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/14959753a424...e2371f842fb9
3722019-05-10T17:22:43  <bitcoin-git> bitcoin/master d20d756 Felix Weis: rpc: faster getblockstats using BlockUndo data
3732019-05-10T17:22:44  <bitcoin-git> bitcoin/master e2371f8 MarcoFalke: Merge #14802: rpc: faster getblockstats using BlockUndo data
3742019-05-10T17:22:46  *** bitcoin-git has left #bitcoin-core-dev
3752019-05-10T17:23:12  *** bitcoin-git has joined #bitcoin-core-dev
3762019-05-10T17:23:12  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14802: rpc: faster getblockstats using BlockUndo data (master...201811_blockstats_undoblock) https://github.com/bitcoin/bitcoin/pull/14802
3772019-05-10T17:23:13  *** bitcoin-git has left #bitcoin-core-dev
3782019-05-10T17:25:54  *** michaelfolkson has quit IRC
3792019-05-10T17:29:35  *** MrPaz has joined #bitcoin-core-dev
3802019-05-10T17:32:12  *** nibnalin has quit IRC
3812019-05-10T17:32:34  *** DougieBot5000_ has joined #bitcoin-core-dev
3822019-05-10T17:32:45  *** DougieBot5000 is now known as Guest70560
3832019-05-10T17:32:45  *** DougieBot5000_ is now known as DougieBot5000
3842019-05-10T17:43:30  *** DougieBot5000 has quit IRC
3852019-05-10T17:45:39  *** DougieBot5000_ has joined #bitcoin-core-dev
3862019-05-10T17:53:47  *** scoop has joined #bitcoin-core-dev
3872019-05-10T18:00:01  *** shortdudey1231 has quit IRC
3882019-05-10T18:04:20  *** DougieBot5000_ is now known as DougieBot5000
3892019-05-10T18:23:34  *** scoop has quit IRC
3902019-05-10T18:25:29  *** scoop has joined #bitcoin-core-dev
3912019-05-10T18:28:59  *** scoop has quit IRC
3922019-05-10T18:30:46  *** scoop has joined #bitcoin-core-dev
3932019-05-10T18:33:11  *** Wayno has joined #bitcoin-core-dev
3942019-05-10T18:39:55  *** ExEric3 has quit IRC
3952019-05-10T18:53:44  *** scoop has quit IRC
3962019-05-10T18:58:05  *** ExEric3 has joined #bitcoin-core-dev
3972019-05-10T19:00:07  <meshcollider> #startmeeting
3982019-05-10T19:00:07  <lightningbot> Meeting started Fri May 10 19:00:07 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
3992019-05-10T19:00:07  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4002019-05-10T19:00:17  <sipa> hi
4012019-05-10T19:00:18  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
4022019-05-10T19:00:23  <jnewbery> hi
4032019-05-10T19:00:39  <phantomcircuit> hu
4042019-05-10T19:00:44  <phantomcircuit> also hi
4052019-05-10T19:01:02  <gmaxwell> ih
4062019-05-10T19:01:17  <meshcollider> The meetings have been pretty short for the past few weeks so maybe this will be too, but does anyone have any topics?
4072019-05-10T19:01:30  <jnewbery> High priority for review?
4082019-05-10T19:02:04  <meshcollider> #topic wallet high priority for review
4092019-05-10T19:02:06  <sipa> anything beyond what what discussed yesterday?
4102019-05-10T19:02:10  <jnewbery> I think there are three wallet PRs in there: #15024 #15006 #15870
4112019-05-10T19:02:13  <gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
4122019-05-10T19:02:16  <gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
4132019-05-10T19:02:18  <gribble> https://github.com/bitcoin/bitcoin/issues/15870 | wallet: Only fail rescan when blocks have actually been pruned by MarcoFalke · Pull Request #15870 · bitcoin/bitcoin · GitHub
4142019-05-10T19:02:42  <jnewbery> Do we want to add anything for descriptor wallets?
4152019-05-10T19:02:57  *** d_t has quit IRC
4162019-05-10T19:02:58  <jnewbery> are there any pre-req PRs
4172019-05-10T19:02:58  <sipa> i'm thinking about creating a psbt/descriptor separate tool that can update/sign, but i'm going to wait until some of the in-flight PRs are in
4182019-05-10T19:03:30  <sipa> jnewbery: 15024 is a pre-req for descriptor wallets iirc
4192019-05-10T19:03:36  <sipa> but already on the list
4202019-05-10T19:04:13  *** d_t has joined #bitcoin-core-dev
4212019-05-10T19:04:13  *** sfhi2 has quit IRC
4222019-05-10T19:04:31  <jnewbery> other than #15427, what's on the path for the descriptor tool?
4232019-05-10T19:04:32  *** sfhi2 has joined #bitcoin-core-dev
4242019-05-10T19:04:34  <gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub
4252019-05-10T19:04:59  <sipa> jnewbery: also 15024
4262019-05-10T19:05:20  <sipa> oh, i have a topic: how do we expect to deal with signign scripts were different satisfactions may have different costs?
4272019-05-10T19:05:21  <meshcollider> Andrews PR is based on #15741 and #15761 too
4282019-05-10T19:05:25  <gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
4292019-05-10T19:05:27  <gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
4302019-05-10T19:05:38  <meshcollider> But both are his PRs and he already has one
4312019-05-10T19:05:52  <jnewbery> I think 15761 will be removed as a requirement based on the IRC meeting a few weeks ago
4322019-05-10T19:06:02  <gmaxwell> sipa: an upper bound on the cost needs to be known before signing starts.
4332019-05-10T19:06:09  <achow101> hi
4342019-05-10T19:07:18  <achow101> meshcollider: 15761 isn't a requirement for descriptor wallets anymore
4352019-05-10T19:07:33  <achow101> 15741 isn't necessarily a requirement, but it makes things faster
4362019-05-10T19:07:42  <meshcollider> achow101: ok, that's good
4372019-05-10T19:08:00  <sipa> we probably need something like 15741 anyway
4382019-05-10T19:08:55  <meshcollider> But not necessarily on high priority atm, I guess we will leave it as-is
4392019-05-10T19:08:57  <meshcollider> #topic signing scripts were different satisfactions may have different costs (sipa)
4402019-05-10T19:09:17  <sipa> gmaxwell: yes, the easiest approach is always assuming the worst case
4412019-05-10T19:09:43  <sipa> this is in the context of things like miniscript or the taproot proposal i recently published
4422019-05-10T19:09:56  <gmaxwell> sipa:  that isn't quite what I meant, like if you're going to spend via branch X, you have to know that in advance if you want to use lower weight for fee purposes.
4432019-05-10T19:10:22  <gmaxwell> so I think PSBT may need an extension for that.
4442019-05-10T19:10:29  <sipa> right, but plugging that into fee estimation and coin selection seems nontrivial
4452019-05-10T19:11:29  <gmaxwell> I think its trivial once you assume you have a way of knowing the "weight bound" for each input you're going to use... which itself is only triial if you always assume the worst case branch.
4462019-05-10T19:11:30  <sipa> gmaxwell: hmm, i guess if we can come up with something sufficiently generic to put in PSBT (something that restricts certain options or so?), it can probably go in the same form into descriptor records
4472019-05-10T19:11:38  <gmaxwell> right.
4482019-05-10T19:11:49  <gmaxwell> my thought is that a descriptor should be subsettable.
4492019-05-10T19:12:17  <gmaxwell> Like if a script is A or B, there should exist a descriptor that maps to the same spk but only lets you spend via A
4502019-05-10T19:12:33  <sipa> that's an interesting idea, putting it in the descriptor itself
4512019-05-10T19:12:41  <gmaxwell> in the context of taproot, that descriptor might not even reveal the content of B.
4522019-05-10T19:12:46  <gmaxwell> Descriptor-slice.
4532019-05-10T19:13:02  <sipa> let's call it a subscriptor
4542019-05-10T19:13:04  <sipa> :p
4552019-05-10T19:13:06  <gmaxwell> oohhhh
4562019-05-10T19:13:17  <meshcollider> lol
4572019-05-10T19:13:37  <gmaxwell> Right, so basically you make the cost analysis use the worst case, but use of a subscriptor can lower the worst case.
4582019-05-10T19:14:26  <achow101> so if used with taproot, you would have the hash of the other branch indicating that that other branch won't be used
4592019-05-10T19:15:11  <gmaxwell> right. something like that. I think you should be also able to include the data but indicate it won't be used.
4602019-05-10T19:15:19  <sipa> i guess there could be an unavailable(...) syntax element in descriptors, which for output calculation is identical to ..., but assumes the key/path/... subexpression isn't available for signing
4612019-05-10T19:15:22  <gmaxwell> (for a lot of applications you'll want to know what it is)
4622019-05-10T19:15:27  <sipa> (or something more syntax sugarry)
4632019-05-10T19:15:56  *** spaced0ut has quit IRC
4642019-05-10T19:16:27  <sipa> i like this
4652019-05-10T19:17:38  <achow101> but does such a subscriptor need to be included in a psbt?
4662019-05-10T19:18:27  <sipa> i think a subscriptor could just result in certain information not being put in a PSBT
4672019-05-10T19:19:08  <sipa> like certain branches of a merkle tree (assuming a taproot psbt extension) would just be left out if they're known to be unavailable (or just unknown)
4682019-05-10T19:19:56  <achow101> right
4692019-05-10T19:20:08  <sipa> thanks, i don't think this much more discussion right now
4702019-05-10T19:21:53  <meshcollider> Any other topics then?
4712019-05-10T19:22:33  <meshcollider> Is there anything else related to the Taproot/schnorr proposals that anyone wants to discuss here?
4722019-05-10T19:23:01  <gmaxwell> sipa: will you be doing a miniscript that targets taproot?
4732019-05-10T19:23:33  <gmaxwell> (like a compiler that takes the current input and outputs taproot scripts)
4742019-05-10T19:24:00  <sipa> gmaxwell: obviously :)
4752019-05-10T19:24:27  <gmaxwell> if you were planning to anyways, it might help discussion around taproot because you could compile example scripts both ways and show how their minimum and worst case spending costs change.
4762019-05-10T19:24:28  <sipa> meshcollider: i think most wallet discussions related to that are for later
4772019-05-10T19:24:52  <gmaxwell> manually constructing examples is always a bummer (and easy to get wrong)
4782019-05-10T19:25:36  <sipa> (afk now, will be back in an hour or so)
4792019-05-10T19:25:46  <meshcollider> Ok let's end things here then, thanks everyone :)
4802019-05-10T19:25:50  <meshcollider> #endmeeting
4812019-05-10T19:25:50  <lightningbot> Meeting ended Fri May 10 19:25:50 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4822019-05-10T19:25:50  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-10-19.00.html
4832019-05-10T19:25:50  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-10-19.00.txt
4842019-05-10T19:25:50  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-10-19.00.log.html
4852019-05-10T19:25:54  <instagibbs> was going to ask "when miniscript in Core"
4862019-05-10T19:26:30  <instagibbs> motivating use-cases are probably required, but above conversation answers that one way
4872019-05-10T19:27:48  <gmaxwell> instagibbs: well, maybe it makes sense to do miniscript with taproot and not bother without.
4882019-05-10T19:28:54  <instagibbs> yep
4892019-05-10T19:35:11  <gmaxwell> certantly, things like taproot need miniscript in the sense that their ability will be wasted if we don't make it easier to make complex scripts.
4902019-05-10T19:35:40  *** hebasto has quit IRC
4912019-05-10T19:47:39  *** jonatack has quit IRC
4922019-05-10T20:00:28  *** bitcoin-git has joined #bitcoin-core-dev
4932019-05-10T20:00:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e2371f842fb9...e79bbb73e08e
4942019-05-10T20:00:30  <bitcoin-git> bitcoin/master 96d32a7 Jon Atack: [docs] Update release-process.md
4952019-05-10T20:00:31  <bitcoin-git> bitcoin/master bd63c1e Jon Atack: [docs] Update release-notes.md
4962019-05-10T20:00:32  <bitcoin-git> bitcoin/master e79bbb7 MarcoFalke: Merge #15607: [Docs] Release process updates
4972019-05-10T20:00:34  *** bitcoin-git has left #bitcoin-core-dev
4982019-05-10T20:01:11  *** bitcoin-git has joined #bitcoin-core-dev
4992019-05-10T20:01:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15607: [Docs] Release process updates (master...release-process-updates) https://github.com/bitcoin/bitcoin/pull/15607
5002019-05-10T20:01:12  *** bitcoin-git has left #bitcoin-core-dev
5012019-05-10T20:06:15  *** sfhi2 has quit IRC
5022019-05-10T20:12:30  *** jnewbery has quit IRC
5032019-05-10T20:12:57  *** jnewbery has joined #bitcoin-core-dev
5042019-05-10T20:14:33  *** Chris2009 has quit IRC
5052019-05-10T20:34:18  *** Guest42 has joined #bitcoin-core-dev
5062019-05-10T20:34:19  *** ExEric3 has quit IRC
5072019-05-10T20:36:38  *** ExEric3 has joined #bitcoin-core-dev
5082019-05-10T20:40:04  *** pinheadmz has quit IRC
5092019-05-10T20:41:06  *** spinza has quit IRC
5102019-05-10T20:44:29  *** profmac has quit IRC
5112019-05-10T20:49:39  *** elichai2 has joined #bitcoin-core-dev
5122019-05-10T20:51:07  *** spinza has joined #bitcoin-core-dev
5132019-05-10T20:54:32  *** Guyver2 has quit IRC
5142019-05-10T20:57:43  *** profmac has joined #bitcoin-core-dev
5152019-05-10T21:00:02  *** Wayno has quit IRC
5162019-05-10T21:02:09  *** estammadII has joined #bitcoin-core-dev
5172019-05-10T21:06:13  *** krazyj has joined #bitcoin-core-dev
5182019-05-10T21:06:40  *** scoop has joined #bitcoin-core-dev
5192019-05-10T21:07:24  *** estammadII has quit IRC
5202019-05-10T21:17:06  *** Guest42 has quit IRC
5212019-05-10T21:19:32  *** owowo has joined #bitcoin-core-dev
5222019-05-10T21:23:02  *** Guest42 has joined #bitcoin-core-dev
5232019-05-10T21:57:12  *** justanotheruser has joined #bitcoin-core-dev
5242019-05-10T22:04:43  *** spinza has quit IRC
5252019-05-10T22:09:03  *** promag_ has joined #bitcoin-core-dev
5262019-05-10T22:12:13  *** promag_ has quit IRC
5272019-05-10T22:15:43  *** spinza has joined #bitcoin-core-dev
5282019-05-10T22:15:49  *** promag_ has joined #bitcoin-core-dev
5292019-05-10T22:18:16  *** promag_ has quit IRC
5302019-05-10T22:19:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5312019-05-10T22:27:10  *** Guest42 has quit IRC
5322019-05-10T22:29:47  *** Guest42 has joined #bitcoin-core-dev
5332019-05-10T22:36:02  *** michaelsdunn1 has quit IRC
5342019-05-10T22:37:00  *** scoop has quit IRC
5352019-05-10T22:38:35  *** AaronvanW has joined #bitcoin-core-dev
5362019-05-10T22:41:14  *** scoop_ has joined #bitcoin-core-dev
5372019-05-10T22:45:03  <sipa> jonasschnelli: now that you have benchmarks for your poly1305/chacha20 implementation... would it be much work to also implement the "standard" openssh-like construction?
5382019-05-10T22:45:26  <sipa> it'd be good to have numbers to justify the choice for our own modification
5392019-05-10T22:45:47  *** scoop_ has quit IRC
5402019-05-10T22:50:59  *** hebasto has joined #bitcoin-core-dev
5412019-05-10T23:09:15  *** Chris_Stewart_5 has quit IRC
5422019-05-10T23:17:29  *** scoop has joined #bitcoin-core-dev
5432019-05-10T23:30:37  *** AaronvanW has quit IRC
5442019-05-10T23:31:13  *** AaronvanW has joined #bitcoin-core-dev
5452019-05-10T23:32:22  *** ossifrage has quit IRC
5462019-05-10T23:41:21  *** Guest42 has quit IRC
5472019-05-10T23:44:41  *** Guest42 has joined #bitcoin-core-dev
5482019-05-10T23:45:12  *** scoop has quit IRC
5492019-05-10T23:46:54  *** scoop has joined #bitcoin-core-dev
5502019-05-10T23:50:25  *** scoop has quit IRC
5512019-05-10T23:51:58  *** scoop has joined #bitcoin-core-dev
5522019-05-10T23:58:31  *** scoop has quit IRC
5532019-05-10T23:59:41  *** scoop has joined #bitcoin-core-dev
5542019-05-10T23:59:54  *** scoop has quit IRC