12019-05-23T00:00:02 *** grafa has quit IRC
22019-05-23T00:13:43 *** justanotheruser has joined #bitcoin-core-dev
32019-05-23T00:23:07 *** AaronvanW has quit IRC
42019-05-23T00:34:10 *** icek has quit IRC
52019-05-23T00:38:20 *** oneark has joined #bitcoin-core-dev
62019-05-23T00:41:33 *** Jackielove4u has quit IRC
72019-05-23T00:46:50 *** Antonet has joined #bitcoin-core-dev
82019-05-23T00:47:48 *** icek has joined #bitcoin-core-dev
92019-05-23T01:01:05 *** justanotheruser has quit IRC
102019-05-23T01:24:58 *** DeanWeen has joined #bitcoin-core-dev
112019-05-23T01:34:13 *** justanotheruser has joined #bitcoin-core-dev
122019-05-23T01:45:28 *** pinheadmz has quit IRC
132019-05-23T01:54:37 *** scoop has quit IRC
142019-05-23T01:55:29 *** scoop has joined #bitcoin-core-dev
152019-05-23T02:01:46 *** scoop has quit IRC
162019-05-23T02:02:33 *** d_t has quit IRC
172019-05-23T02:14:01 *** scoop has joined #bitcoin-core-dev
182019-05-23T02:14:14 *** ccdle12_ has quit IRC
192019-05-23T02:18:46 *** ccdle12 has joined #bitcoin-core-dev
202019-05-23T02:29:46 *** pinheadmz has joined #bitcoin-core-dev
212019-05-23T02:41:51 *** ccdle12 has quit IRC
222019-05-23T02:46:10 *** ccdle12 has joined #bitcoin-core-dev
232019-05-23T02:49:12 *** hebasto has joined #bitcoin-core-dev
242019-05-23T03:00:02 *** Antonet has quit IRC
252019-05-23T03:09:07 *** ccdle12 has quit IRC
262019-05-23T03:12:13 *** hebasto has quit IRC
272019-05-23T03:12:56 *** ccdle12 has joined #bitcoin-core-dev
282019-05-23T03:15:18 *** davterra has quit IRC
292019-05-23T03:18:39 *** EricFisher has joined #bitcoin-core-dev
302019-05-23T03:20:26 *** davterra has joined #bitcoin-core-dev
312019-05-23T03:30:48 *** scoop has quit IRC
322019-05-23T03:31:51 *** pinheadmz has quit IRC
332019-05-23T03:33:06 *** scoop has joined #bitcoin-core-dev
342019-05-23T03:35:28 *** ccdle12 has quit IRC
352019-05-23T03:37:26 *** scoop has quit IRC
362019-05-23T03:37:29 *** nullptr_ has quit IRC
372019-05-23T03:38:13 *** MrPaz has quit IRC
382019-05-23T03:39:02 *** nullptr| has joined #bitcoin-core-dev
392019-05-23T03:44:56 *** scoop has joined #bitcoin-core-dev
402019-05-23T03:46:56 *** pinheadmz has joined #bitcoin-core-dev
412019-05-23T03:56:36 *** scoop has quit IRC
422019-05-23T04:03:02 *** rh0nj has quit IRC
432019-05-23T04:04:08 *** rh0nj has joined #bitcoin-core-dev
442019-05-23T04:44:27 *** spinza has quit IRC
452019-05-23T04:53:26 *** spinza has joined #bitcoin-core-dev
462019-05-23T05:06:50 *** xingzhi has joined #bitcoin-core-dev
472019-05-23T05:11:44 *** Eric3 has joined #bitcoin-core-dev
482019-05-23T05:12:02 *** ExEric3 has quit IRC
492019-05-23T05:31:13 *** d_t has joined #bitcoin-core-dev
502019-05-23T05:38:37 *** xingzhi has quit IRC
512019-05-23T05:43:30 *** electric-sheep[m has joined #bitcoin-core-dev
522019-05-23T05:48:33 *** EagleTM has joined #bitcoin-core-dev
532019-05-23T05:53:22 *** EagleTM has quit IRC
542019-05-23T06:00:01 *** EricFisher has quit IRC
552019-05-23T06:00:49 *** icek has quit IRC
562019-05-23T06:03:40 *** sankarshan1 has joined #bitcoin-core-dev
572019-05-23T06:05:56 *** adiabat_ has quit IRC
582019-05-23T06:12:33 *** adiabat_ has joined #bitcoin-core-dev
592019-05-23T06:16:05 *** ExEric3 has joined #bitcoin-core-dev
602019-05-23T06:16:05 *** d_t has quit IRC
612019-05-23T06:17:18 *** Eric3 has quit IRC
622019-05-23T06:28:58 *** icek has joined #bitcoin-core-dev
632019-05-23T06:45:14 *** JamesAU has joined #bitcoin-core-dev
642019-05-23T06:48:07 *** hebasto has joined #bitcoin-core-dev
652019-05-23T06:56:59 *** davterra has quit IRC
662019-05-23T07:11:45 *** davterra has joined #bitcoin-core-dev
672019-05-23T07:21:09 *** JamesAU_ has joined #bitcoin-core-dev
682019-05-23T07:23:20 *** JamesAU has quit IRC
692019-05-23T07:24:40 *** kljasdfvv has quit IRC
702019-05-23T07:26:17 *** adam3us has quit IRC
712019-05-23T07:26:29 *** adam3us has joined #bitcoin-core-dev
722019-05-23T07:27:35 *** schmidty has quit IRC
732019-05-23T07:28:06 *** kljasdfvv has joined #bitcoin-core-dev
742019-05-23T07:28:08 *** schmidty has joined #bitcoin-core-dev
752019-05-23T07:33:18 *** promag_ has joined #bitcoin-core-dev
762019-05-23T07:35:23 *** promag has quit IRC
772019-05-23T07:49:39 *** JamesAU has joined #bitcoin-core-dev
782019-05-23T07:52:43 *** JamesAU_ has quit IRC
792019-05-23T08:04:05 *** timothy has joined #bitcoin-core-dev
802019-05-23T08:04:33 *** ccdle12 has joined #bitcoin-core-dev
812019-05-23T08:06:38 *** setpill has joined #bitcoin-core-dev
822019-05-23T08:44:41 *** promag has joined #bitcoin-core-dev
832019-05-23T08:53:52 *** icek has quit IRC
842019-05-23T09:00:01 *** sankarshan1 has quit IRC
852019-05-23T09:03:51 *** newz2000 has joined #bitcoin-core-dev
862019-05-23T09:25:39 *** bitcoin-git has joined #bitcoin-core-dev
872019-05-23T09:25:40 <bitcoin-git> [bitcoin] hebasto opened pull request #16077: docs: Follow ISO/IEC 14882 terms and definitions (master...20190523-iso-parameter) https://github.com/bitcoin/bitcoin/pull/16077
882019-05-23T09:25:41 *** bitcoin-git has left #bitcoin-core-dev
892019-05-23T09:28:38 *** hebasto has quit IRC
902019-05-23T09:41:11 *** icek has joined #bitcoin-core-dev
912019-05-23T09:54:36 *** Guyver2 has joined #bitcoin-core-dev
922019-05-23T10:21:39 *** JamesAU has quit IRC
932019-05-23T10:27:28 *** ccdle12 has quit IRC
942019-05-23T10:31:56 *** scoop has joined #bitcoin-core-dev
952019-05-23T10:36:37 *** Chris_Stewart_5 has joined #bitcoin-core-dev
962019-05-23T10:37:06 *** scoop has quit IRC
972019-05-23T10:43:03 <stevenroose> Does bitcoind have an RPC that either (1) gives the xpub of the master priv (the one that dumpwallet gives) or (2) allows calculating the xpub of an xpriv?
982019-05-23T10:48:57 *** rafalcpp has joined #bitcoin-core-dev
992019-05-23T10:49:15 *** timothy has quit IRC
1002019-05-23T10:50:13 *** Jackielove4u has joined #bitcoin-core-dev
1012019-05-23T10:54:45 *** AaronvanW has joined #bitcoin-core-dev
1022019-05-23T10:55:40 *** spinza has quit IRC
1032019-05-23T11:03:19 *** spinza has joined #bitcoin-core-dev
1042019-05-23T11:03:51 *** ccdle12 has joined #bitcoin-core-dev
1052019-05-23T11:07:54 *** oneark has quit IRC
1062019-05-23T11:08:48 *** ccdle12 has quit IRC
1072019-05-23T11:09:24 *** Chris_Stewart_5 has quit IRC
1082019-05-23T11:47:04 *** ccdle12 has joined #bitcoin-core-dev
1092019-05-23T11:51:17 *** promag has quit IRC
1102019-05-23T11:53:37 *** ccdle12 has quit IRC
1112019-05-23T11:57:41 *** icek has quit IRC
1122019-05-23T12:00:01 *** newz2000 has quit IRC
1132019-05-23T12:04:03 *** csslayer1 has joined #bitcoin-core-dev
1142019-05-23T12:07:27 *** ccdle12 has joined #bitcoin-core-dev
1152019-05-23T12:24:37 *** bitcoin-git has joined #bitcoin-core-dev
1162019-05-23T12:24:37 <bitcoin-git> [bitcoin] LongShao007 opened pull request #16078: replace tx hash with txid in test rawtransaction (master...pytest) https://github.com/bitcoin/bitcoin/pull/16078
1172019-05-23T12:24:39 *** bitcoin-git has left #bitcoin-core-dev
1182019-05-23T12:35:28 *** promag has joined #bitcoin-core-dev
1192019-05-23T12:39:42 *** promag has quit IRC
1202019-05-23T12:45:49 *** DeanWeen has quit IRC
1212019-05-23T12:53:30 *** Guyver2 has quit IRC
1222019-05-23T13:06:34 *** Ll1i1lL has quit IRC
1232019-05-23T13:18:13 *** promag_ has quit IRC
1242019-05-23T13:19:04 *** promag has joined #bitcoin-core-dev
1252019-05-23T13:23:56 *** promag has quit IRC
1262019-05-23T13:32:43 *** davterra has quit IRC
1272019-05-23T13:33:05 *** davterra has joined #bitcoin-core-dev
1282019-05-23T13:44:23 *** timothy has joined #bitcoin-core-dev
1292019-05-23T13:45:14 *** Skirmant has quit IRC
1302019-05-23T13:48:38 *** timothy has quit IRC
1312019-05-23T13:49:52 *** votesmith has quit IRC
1322019-05-23T13:50:26 *** d_t has joined #bitcoin-core-dev
1332019-05-23T13:52:17 *** timothy has joined #bitcoin-core-dev
1342019-05-23T13:54:58 *** designwish has quit IRC
1352019-05-23T13:54:58 *** d_t has quit IRC
1362019-05-23T13:55:33 *** icek has joined #bitcoin-core-dev
1372019-05-23T13:58:54 *** votesmith has joined #bitcoin-core-dev
1382019-05-23T13:59:55 *** justanotheruser has quit IRC
1392019-05-23T14:00:29 *** shesek has joined #bitcoin-core-dev
1402019-05-23T14:00:29 *** shesek has joined #bitcoin-core-dev
1412019-05-23T14:03:03 *** scoop has joined #bitcoin-core-dev
1422019-05-23T14:04:04 *** icek has quit IRC
1432019-05-23T14:04:37 *** pinheadmz has quit IRC
1442019-05-23T14:05:37 *** designwish has joined #bitcoin-core-dev
1452019-05-23T14:09:01 *** promag has joined #bitcoin-core-dev
1462019-05-23T14:15:37 *** pinheadmz has joined #bitcoin-core-dev
1472019-05-23T14:18:29 *** michaelfolkson has joined #bitcoin-core-dev
1482019-05-23T14:21:32 <achow101> stevenroose: no
1492019-05-23T14:22:34 <stevenroose> achow101: thanks
1502019-05-23T14:24:58 *** ccdle12 has quit IRC
1512019-05-23T14:25:26 *** fanquake has joined #bitcoin-core-dev
1522019-05-23T14:27:50 *** obsrver has joined #bitcoin-core-dev
1532019-05-23T14:34:49 *** michaelsdunn1 has joined #bitcoin-core-dev
1542019-05-23T14:34:53 *** pinheadmz has quit IRC
1552019-05-23T14:37:28 *** promag has quit IRC
1562019-05-23T14:40:02 *** bitcoin-git has joined #bitcoin-core-dev
1572019-05-23T14:40:02 <bitcoin-git> [bitcoin] stevenroose opened pull request #16079: wallet_balance.py: Prevent edge cases (master...wallet-balance-test) https://github.com/bitcoin/bitcoin/pull/16079
1582019-05-23T14:40:14 *** bitcoin-git has left #bitcoin-core-dev
1592019-05-23T14:47:55 *** timothy has quit IRC
1602019-05-23T14:51:20 *** timothy has joined #bitcoin-core-dev
1612019-05-23T14:52:44 *** pinheadmz has joined #bitcoin-core-dev
1622019-05-23T14:56:56 <dongcarl> cfields: Trying to understand your fork of cctools-port... Out of the 5 commits that you made that's no upstream, they've taken care of openssl and uuid (the first 2 commits), but I'm having trouble understanding the remaining 3... Namely: 3a2152b8e4d74601d9976f75aa7c30fd2b54733f, 81589bba090b29989dee31d8f04a78d917b34589, and ee31ae567931c426136c94aad457c7b51d844beb
1632019-05-23T14:56:59 *** mryandao has quit IRC
1642019-05-23T14:57:22 *** mryandao has joined #bitcoin-core-dev
1652019-05-23T15:00:01 *** csslayer1 has quit IRC
1662019-05-23T15:02:04 *** timothy has quit IRC
1672019-05-23T15:06:18 *** glidenote1 has joined #bitcoin-core-dev
1682019-05-23T15:06:35 *** timothy has joined #bitcoin-core-dev
1692019-05-23T15:12:04 *** Guyver2 has joined #bitcoin-core-dev
1702019-05-23T15:40:07 *** bitcoin-git has joined #bitcoin-core-dev
1712019-05-23T15:40:07 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/12fd4bbd1ed9...b4223dd5f113
1722019-05-23T15:40:08 <bitcoin-git> bitcoin/master bb41e63 Steven Roose: wallet_balance.py: Prevent edge cases
1732019-05-23T15:40:08 <bitcoin-git> bitcoin/master b4223dd MarcoFalke: Merge #16079: wallet_balance.py: Prevent edge cases
1742019-05-23T15:40:10 *** bitcoin-git has left #bitcoin-core-dev
1752019-05-23T15:41:01 *** bitcoin-git has joined #bitcoin-core-dev
1762019-05-23T15:41:02 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16079: wallet_balance.py: Prevent edge cases (master...wallet-balance-test) https://github.com/bitcoin/bitcoin/pull/16079
1772019-05-23T15:41:13 *** dviola has quit IRC
1782019-05-23T15:41:14 *** bitcoin-git has left #bitcoin-core-dev
1792019-05-23T15:51:04 *** Aaronvan_ has joined #bitcoin-core-dev
1802019-05-23T15:53:19 *** setpill has quit IRC
1812019-05-23T15:54:19 *** AaronvanW has quit IRC
1822019-05-23T15:56:25 *** michaelfolkson has quit IRC
1832019-05-23T16:00:00 *** fanquake has quit IRC
1842019-05-23T16:01:11 *** obsrver has quit IRC
1852019-05-23T16:01:18 *** fanquake has joined #bitcoin-core-dev
1862019-05-23T16:02:57 *** fanquake has quit IRC
1872019-05-23T16:05:02 *** rh0nj has quit IRC
1882019-05-23T16:06:07 *** rh0nj has joined #bitcoin-core-dev
1892019-05-23T16:07:12 *** promag has joined #bitcoin-core-dev
1902019-05-23T16:07:47 *** michaelsdunn1 has quit IRC
1912019-05-23T16:12:27 *** michaelsdunn1 has joined #bitcoin-core-dev
1922019-05-23T16:13:49 *** promag has quit IRC
1932019-05-23T16:17:33 *** profmac has quit IRC
1942019-05-23T16:19:58 *** sfhi has joined #bitcoin-core-dev
1952019-05-23T16:26:34 *** profmac has joined #bitcoin-core-dev
1962019-05-23T16:26:46 *** promag has joined #bitcoin-core-dev
1972019-05-23T16:30:59 *** michaelsdunn1 has quit IRC
1982019-05-23T16:32:54 *** michaelsdunn1 has joined #bitcoin-core-dev
1992019-05-23T16:36:59 *** siom has joined #bitcoin-core-dev
2002019-05-23T16:38:53 *** fanquake has joined #bitcoin-core-dev
2012019-05-23T16:40:29 *** timothy has quit IRC
2022019-05-23T16:43:16 *** fanquake has quit IRC
2032019-05-23T16:43:45 *** fanquake has joined #bitcoin-core-dev
2042019-05-23T16:46:11 *** bitcoin-git has joined #bitcoin-core-dev
2052019-05-23T16:46:11 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4223dd5f113...0b058ba69d85
2062019-05-23T16:46:11 <bitcoin-git> bitcoin/master e23809a Chris Capobianco: [rpc] deriveaddresses: Correct descriptor checksum in RPCExamples
2072019-05-23T16:46:12 <bitcoin-git> bitcoin/master 0b058ba MarcoFalke: Merge #16024: [rpc] deriveaddresses: Correction of descriptor checksum in ...
2082019-05-23T16:46:25 *** bitcoin-git has left #bitcoin-core-dev
2092019-05-23T16:46:46 *** bitcoin-git has joined #bitcoin-core-dev
2102019-05-23T16:46:46 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16024: [rpc] deriveaddresses: Correction of descriptor checksum in RPC example (master...2019-05-14-deriveaddresses-example-checksum) https://github.com/bitcoin/bitcoin/pull/16024
2112019-05-23T16:46:48 *** bitcoin-git has left #bitcoin-core-dev
2122019-05-23T16:48:09 *** promag has quit IRC
2132019-05-23T16:51:37 *** bitcoin-git has joined #bitcoin-core-dev
2142019-05-23T16:51:37 <bitcoin-git> [bitcoin] jonatack opened pull request #16080: build/doc: update bitcoin_config.h packages, release process (master...bitcoin_config-and-release_process-updates) https://github.com/bitcoin/bitcoin/pull/16080
2152019-05-23T16:51:38 *** bitcoin-git has left #bitcoin-core-dev
2162019-05-23T17:05:16 *** sfhi has quit IRC
2172019-05-23T17:08:38 *** scoop has quit IRC
2182019-05-23T17:38:39 *** scoop has joined #bitcoin-core-dev
2192019-05-23T17:39:02 *** bitcoin-git has joined #bitcoin-core-dev
2202019-05-23T17:39:02 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0b058ba69d85...65c4bbe629bb
2212019-05-23T17:39:03 <bitcoin-git> bitcoin/master cc25885 practicalswift: Move LockAnnotation from threadsafety.h (imported code) to sync.h (our cod...
2222019-05-23T17:39:03 <bitcoin-git> bitcoin/master 3a80944 practicalswift: Move LockAnnotation to make it reflect the truth
2232019-05-23T17:39:04 <bitcoin-git> bitcoin/master de9b5db practicalswift: Make sure the compile-time locking promises given via LockAnnotation:s hol...
2242019-05-23T17:39:05 *** bitcoin-git has left #bitcoin-core-dev
2252019-05-23T17:39:52 *** bitcoin-git has joined #bitcoin-core-dev
2262019-05-23T17:39:52 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16034: refactoring: Rename LockAnnotation to LockAssertion and add run-time check to it (master...make-sure-LockAnnotation-promises-are-truthful) https://github.com/bitcoin/bitcoin/pull/16034
2272019-05-23T17:40:04 *** bitcoin-git has left #bitcoin-core-dev
2282019-05-23T17:43:40 *** hebasto has joined #bitcoin-core-dev
2292019-05-23T17:56:07 *** promag has joined #bitcoin-core-dev
2302019-05-23T17:59:13 *** promag_ has joined #bitcoin-core-dev
2312019-05-23T17:59:17 *** ExEric3 has quit IRC
2322019-05-23T18:00:02 *** glidenote1 has quit IRC
2332019-05-23T18:03:29 *** promag has quit IRC
2342019-05-23T18:03:44 *** promag_ has quit IRC
2352019-05-23T18:03:44 *** scoop has quit IRC
2362019-05-23T18:04:46 *** ExEric3 has joined #bitcoin-core-dev
2372019-05-23T18:06:31 *** scoop has joined #bitcoin-core-dev
2382019-05-23T18:07:53 *** scoop has quit IRC
2392019-05-23T18:07:59 *** scoop has joined #bitcoin-core-dev
2402019-05-23T18:11:38 *** scoop has quit IRC
2412019-05-23T18:12:41 *** scoop has joined #bitcoin-core-dev
2422019-05-23T18:19:40 *** nirik-fre has joined #bitcoin-core-dev
2432019-05-23T18:27:35 *** hebasto has quit IRC
2442019-05-23T18:34:50 *** bitcoin-git has joined #bitcoin-core-dev
2452019-05-23T18:34:50 <bitcoin-git> [bitcoin] fanquake reopened pull request #13442: Convert the 1-way SSE4 SHA256 code from asm to intrinsics (master...201806_sse4intrin) https://github.com/bitcoin/bitcoin/pull/13442
2462019-05-23T18:34:55 *** bitcoin-git has left #bitcoin-core-dev
2472019-05-23T18:45:33 *** ExEric3 has quit IRC
2482019-05-23T18:46:26 *** ExEric3 has joined #bitcoin-core-dev
2492019-05-23T18:51:17 *** gmaxwell has quit IRC
2502019-05-23T18:51:49 *** gmaxwell has joined #bitcoin-core-dev
2512019-05-23T18:52:12 *** gmaxwell is now known as Guest58856
2522019-05-23T18:53:22 *** ExEric3 has quit IRC
2532019-05-23T18:54:08 *** ExEric3 has joined #bitcoin-core-dev
2542019-05-23T18:55:51 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2552019-05-23T18:56:55 *** nkohen has joined #bitcoin-core-dev
2562019-05-23T18:59:56 *** promag has joined #bitcoin-core-dev
2572019-05-23T19:00:30 <wumpus> #startmeeting
2582019-05-23T19:00:30 <lightningbot> Meeting started Thu May 23 19:00:30 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2592019-05-23T19:00:30 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2602019-05-23T19:00:41 <sipa> ohai
2612019-05-23T19:00:50 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
2622019-05-23T19:00:58 <achow101> hi
2632019-05-23T19:01:01 <promag> hi
2642019-05-23T19:01:05 <fanquake> Hi
2652019-05-23T19:01:08 <achow101> only here for 30 min or so (if the meeting even goes that long)
2662019-05-23T19:01:15 <meshcollider> hi
2672019-05-23T19:01:15 <jamesob> hi
2682019-05-23T19:01:47 <gwillen> hi
2692019-05-23T19:01:49 <wumpus> proposed topics? (none on moneyball 's list)
2702019-05-23T19:02:10 <phantomcircuit> hi
2712019-05-23T19:02:26 *** Kvaciral has joined #bitcoin-core-dev
2722019-05-23T19:02:38 <jonasschnelli> hi
2732019-05-23T19:02:46 <Chris_Stewart_5> hello
2742019-05-23T19:03:03 <wumpus> hello
2752019-05-23T19:03:23 <wumpus> #topic High priority for review
2762019-05-23T19:03:32 <wumpus> https://github.com/bitcoin/bitcoin/projects/8
2772019-05-23T19:04:16 <wumpus> current PRs: #15427 #15741 #15759 #15024 #15649
2782019-05-23T19:04:20 <gribble> https://github.com/bitcoin/bitcoin/issues/15427 | Add support for descriptors to utxoupdatepsbt by sipa · Pull Request #15427 · bitcoin/bitcoin · GitHub
2792019-05-23T19:04:21 <moneyball> hi
2802019-05-23T19:04:23 <gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
2812019-05-23T19:04:26 <gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub
2822019-05-23T19:04:27 <gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
2832019-05-23T19:04:30 <gribble> https://github.com/bitcoin/bitcoin/issues/15649 | Add ChaCha20Poly1305@Bitcoin AEAD by jonasschnelli · Pull Request #15649 · bitcoin/bitcoin · GitHub
2842019-05-23T19:04:36 <kanzure> hi
2852019-05-23T19:04:37 <jamesob> can I ask that #15976 be added? it's prone to rebase conflicts and pretty close to ack-threshold for merge (I think)
2862019-05-23T19:04:44 <gribble> https://github.com/bitcoin/bitcoin/issues/15976 | refactor: move methods under CChainState (pt. 1) by jamesob · Pull Request #15976 · bitcoin/bitcoin · GitHub
2872019-05-23T19:04:54 <jamesob> (and blocks the assumeutxo project)
2882019-05-23T19:04:55 <wumpus> jamesob: of course
2892019-05-23T19:05:05 *** scoop has quit IRC
2902019-05-23T19:05:13 <jamesob> wumpus: thanks
2912019-05-23T19:05:16 <fanquake> done
2922019-05-23T19:05:20 <dongcarl> Could we add #16059? Small but without it linux gitian builds are broken right now
2932019-05-23T19:05:22 <gribble> https://github.com/bitcoin/bitcoin/issues/16059 | configure: Fix thread_local detection by dongcarl · Pull Request #16059 · bitcoin/bitcoin · GitHub
2942019-05-23T19:06:02 <wumpus> dongcarl: sure
2952019-05-23T19:06:17 <wumpus> fanquake: thanks
2962019-05-23T19:06:18 <jnewbery> hi
2972019-05-23T19:06:26 <fanquake> I think that can be merged quite soon. I'm testing it at the moment.
2982019-05-23T19:06:37 <fanquake> Have added to high prio.
2992019-05-23T19:06:40 <dongcarl> thank you
3002019-05-23T19:06:45 <wumpus> why are we using thread_local again btw?
3012019-05-23T19:06:55 <jamesob> for thread names
3022019-05-23T19:06:56 <wumpus> I thought that was removed at some point
3032019-05-23T19:07:12 <jamesob> cory and I came up with a way to do without at some point but it was pretty convoluted
3042019-05-23T19:08:19 <fanquake> It's also linux and openbsd? only atm. Broken on win, freebsd and we can't use it on macOS until we are using a newer sdk.
3052019-05-23T19:08:34 <wumpus> doesn't pthread have a way to keep track of thread names?
3062019-05-23T19:09:13 <wumpus> I thought that was how we did that, anyway
3072019-05-23T19:09:17 <jonasschnelli> fanquake: you mean SDK for the depends build?
3082019-05-23T19:09:21 <wumpus> that'll also show up in top and such
3092019-05-23T19:09:28 <jamesob> there's some posix key-value store API we were using with the pthreads id to avoid thread_local, but it ended up being a lot of code IIRC
3102019-05-23T19:09:49 <wumpus> pthread_setname or such
3112019-05-23T19:10:11 <wumpus> pthread_getname_np
3122019-05-23T19:10:16 <fanquake> jonasschnelli yes. Although now I think about it, we are building against 10.11 which I think means we can use it. Have to double check.
3132019-05-23T19:10:40 <jonasschnelli> Also since this is nice for debugging, the depends build matters not too much
3142019-05-23T19:11:23 <sipa> wumpus: https://github.com/bitcoin/bitcoin/blob/master/src/util/threadnames.cpp
3152019-05-23T19:11:56 <wumpus> do we have a whole util to keep track of thread names? wow
3162019-05-23T19:11:57 <ryanofsky> #16059 is a straightforward fix, simpler than rewriting thread names imo...
3172019-05-23T19:12:00 <gribble> https://github.com/bitcoin/bitcoin/issues/16059 | configure: Fix thread_local detection by dongcarl · Pull Request #16059 · bitcoin/bitcoin · GitHub
3182019-05-23T19:12:11 <jamesob> ryanofsky: agree
3192019-05-23T19:12:26 <wumpus> I had no idea it was such a big issue, anyhow, any other topics?
3202019-05-23T19:12:40 * luke-jr for one finds thread names useful sometimes
3212019-05-23T19:12:47 <jamesob> we avoided doing pthread_getname because there are supposedly implementation problems (https://stackoverflow.com/questions/2369738/how-to-set-the-name-of-a-thread-in-linux-pthreads/7989973#7989973). see also the notes at the bottom of this PR description: https://github.com/bitcoin/bitcoin/pull/13099
3222019-05-23T19:12:48 <gribble> https://github.com/bitcoin/bitcoin/issues/7989973 | HTTP Error 404: Not Found
3232019-05-23T19:14:17 <wumpus> jamesob:thanks
3242019-05-23T19:14:37 *** sfhi has joined #bitcoin-core-dev
3252019-05-23T19:15:36 <meshcollider> Not a topic, but I won't be able to attend tomorrows wallet meeting so could someone please volunteer to host it?
3262019-05-23T19:15:54 <wumpus> anyonw?
3272019-05-23T19:15:57 <sipa> i'll be here, if there's interest
3282019-05-23T19:16:10 *** michaelfolkson has joined #bitcoin-core-dev
3292019-05-23T19:16:15 <fanquake> Maybe #15993 for a topic? Has been through a few iterations but seems to be more ready now?
3302019-05-23T19:16:17 <jnewbery> I'll be there
3312019-05-23T19:16:18 <gribble> https://github.com/bitcoin/bitcoin/issues/15993 | net: Drop support of the insecure miniUPnPc versions by hebasto · Pull Request #15993 · bitcoin/bitcoin · GitHub
3322019-05-23T19:16:39 <wumpus> fanquake:I think that should just be merged?
3332019-05-23T19:16:49 <wumpus> fanquake: is there anything to discuss about it?
3342019-05-23T19:17:26 *** michaelfolkson has quit IRC
3352019-05-23T19:17:26 <luke-jr> did configure finally get updated?
3362019-05-23T19:17:38 <luke-jr> not that I see..
3372019-05-23T19:17:48 <wumpus> I don't know...
3382019-05-23T19:17:51 <MarcoFalke> Seems like it is just shuffling things around and not actually dropping support
3392019-05-23T19:17:59 <fanquake> wumpus I haven't tested any of the changes, just seemed there was discussion about which versions to drop support for, and wether other versions had actually been patched.
3402019-05-23T19:18:20 <wumpus> it's dropping support for <10, which is fine, the only thing controversial was <14
3412019-05-23T19:18:21 <luke-jr> looks like it would detect older miniupnpc libraries, then fail to compile
3422019-05-23T19:18:36 <wumpus> because that's still in debian table
3432019-05-23T19:18:38 <wumpus> stable
3442019-05-23T19:19:30 <fanquake> ok.
3452019-05-23T19:19:42 <fanquake> One other topic is suggestions for 0.18.1 backporting that aren't already in #16035
3462019-05-23T19:19:44 <gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
3472019-05-23T19:19:46 * wumpus would prefer to drop support for miniUPnP completely but, don't feel like having that discussion
3482019-05-23T19:20:00 <wumpus> #topic backport suggestions for 0.18.1
3492019-05-23T19:21:23 <wumpus> anything?
3502019-05-23T19:21:47 <promag> maybe #14984?
3512019-05-23T19:21:49 <gribble> https://github.com/bitcoin/bitcoin/issues/14984 | rpc: Speedup getrawmempool when verbose=true by promag · Pull Request #14984 · bitcoin/bitcoin · GitHub
3522019-05-23T19:22:17 <wumpus> it's not really a bugfix
3532019-05-23T19:22:19 <MarcoFalke> It is not strictly a bugfix.
3542019-05-23T19:22:22 <fanquake> Apparently that isn't actually a clean backport, and maybe not worth it if it's just perfomance gain.
3552019-05-23T19:22:23 <wumpus> unless performance is *really* horrible right now
3562019-05-23T19:22:52 <MarcoFalke> Only when the mempool is large ;)
3572019-05-23T19:22:53 <wumpus> if it's non-trivial to backport too then better not to, I think
3582019-05-23T19:23:15 <promag> right, large mempool, about 30% faster
3592019-05-23T19:23:27 <promag> no problem, just asked
3602019-05-23T19:23:38 <wumpus> no problem, thanks for suggesting something
3612019-05-23T19:24:14 <MarcoFalke> I am mostly waiting on those to get merged: https://github.com/bitcoin/bitcoin/milestone/41
3622019-05-23T19:24:28 <wumpus> are we planning on doing a 0.18.1 soon btw?
3632019-05-23T19:24:38 <wumpus> I mean, is there anything motivating it?
3642019-05-23T19:24:40 *** Guest58856 has quit IRC
3652019-05-23T19:24:41 *** Guest58856 has joined #bitcoin-core-dev
3662019-05-23T19:25:10 <MarcoFalke> nothing urgent, no
3672019-05-23T19:25:11 <promag> ops, forgot about #15453
3682019-05-23T19:25:12 <gribble> https://github.com/bitcoin/bitcoin/issues/15453 | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet · Issue #15453 · bitcoin/bitcoin · GitHub
3692019-05-23T19:25:46 <fanquake> A couple of bug fixes for potentially confusing behaviour, like #15952, but nothing catastrophic
3702019-05-23T19:25:48 <gribble> https://github.com/bitcoin/bitcoin/issues/15952 | Cant open wallet · Issue #15952 · bitcoin/bitcoin · GitHub
3712019-05-23T19:25:49 <MarcoFalke> oh, maybe the gcc compile bug?
3722019-05-23T19:26:05 <wumpus> MarcoFalke:yes maybe that
3732019-05-23T19:26:13 <MarcoFalke> But it seemed to only affect the tests, so ... flip a coin?
3742019-05-23T19:26:16 <wumpus> would be good to have that out of the way
3752019-05-23T19:26:23 <wumpus> we don't *know*
3762019-05-23T19:26:36 <MarcoFalke> jup
3772019-05-23T19:26:39 <fanquake> #15983
3782019-05-23T19:26:41 <gribble> https://github.com/bitcoin/bitcoin/issues/15983 | build with -fstack-reuse=none by MarcoFalke · Pull Request #15983 · bitcoin/bitcoin · GitHub
3792019-05-23T19:27:25 <fanquake> Maybe wait another week or two then, assuming outstanding PRs are merged, cut an rc1 ?
3802019-05-23T19:27:33 <wumpus> that definitely needs backport to 0.18
3812019-05-23T19:27:46 *** brianhoffman has quit IRC
3822019-05-23T19:27:55 <MarcoFalke> It is the first thing in #16035
3832019-05-23T19:27:57 <gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
3842019-05-23T19:27:59 <wumpus> it's labeled for 0.17.2 but that's not very likely to happen
3852019-05-23T19:28:01 <wumpus> oh okay
3862019-05-23T19:28:04 <sipa> has anyone done general benchmarks to see the affect of -fstack-reuse=none ?
3872019-05-23T19:28:10 <fanquake> jamesob
3882019-05-23T19:28:32 <fanquake> sipa https://github.com/bitcoin/bitcoin/pull/15983#issuecomment-490700321
3892019-05-23T19:28:34 <jamesob> I tried but I don't think I was doing it right
3902019-05-23T19:28:35 <MarcoFalke> sipa: We couldn't find any significant changes on our hardware
3912019-05-23T19:28:46 <wumpus> I doubt it affects performance at all
3922019-05-23T19:28:47 <sipa> MarcoFalke: that's not surprising, but good to confirm
3932019-05-23T19:28:48 *** Guest58856 is now known as gmaxwell
3942019-05-23T19:28:48 <wumpus> just stack use
3952019-05-23T19:29:48 <gmaxwell> My only concern was that it would break some other performance optimization, sounds like it doesn't.
3962019-05-23T19:30:00 <wumpus> anyhow, upgrade to a compiler that doesn't have the bug (when there's one)
3972019-05-23T19:30:10 <wumpus> performance loss is preferable to random unpredictable corruption
3982019-05-23T19:30:22 <wumpus> certainly for something like bitcoin
3992019-05-23T19:30:29 <MarcoFalke> right
4002019-05-23T19:31:24 <wumpus> (I mean it's obviously different if say, validation becomes two times as slow or something extreme like that, but we'd have noticed)
4012019-05-23T19:31:28 <gmaxwell> if the performance loss were truly significant though, we might want to look for other alternative workarounds, good that we don't need to.
4022019-05-23T19:31:34 <wumpus> of course
4032019-05-23T19:31:56 <sipa> agree
4042019-05-23T19:32:01 <wumpus> any other topics?
4052019-05-23T19:32:45 <promag> is this worth it? https://github.com/bitcoin/bitcoin/pull/16065#issuecomment-494853746
4062019-05-23T19:33:54 <wumpus> avoiding hashing is always the best sha256 optimization :)
4072019-05-23T19:34:34 <jonasschnelli> ;-)
4082019-05-23T19:34:43 <wumpus> (but if it's worth it depends on what slice of the total the 2.44s is, if it's on the whole initial sync it's neglible)
4092019-05-23T19:35:05 <fanquake> If anyone can reproduce #16027 that might be handy. Has come up a couple times now.
4102019-05-23T19:35:06 <gribble> https://github.com/bitcoin/bitcoin/issues/16027 | client 0.18.0 crashes when computer wakes up from hibernation · Issue #16027 · bitcoin/bitcoin · GitHub
4112019-05-23T19:35:14 <MarcoFalke> Yeah, sync is ~hours, so a second doesn't matter at all
4122019-05-23T19:35:28 <wumpus> MarcoFalke: right
4132019-05-23T19:35:29 <promag> wumpus: right, agree at the moment saving a couple of seconds isn't worth it
4142019-05-23T19:35:31 <gmaxwell> that sounds like it maybe more more relevant to propagation at the tip.
4152019-05-23T19:35:46 <wumpus> and that's within the measuring noise isn't it?
4162019-05-23T19:36:06 <gmaxwell> e.g. time from getting a block to sending the first non-HB peer.
4172019-05-23T19:36:31 <wumpus> gmaxwell: yes, that latency would be useful to measure
4182019-05-23T19:36:41 <wumpus> if it makes a significant difference there then it could still be worth it
4192019-05-23T19:36:48 <gmaxwell> the fact that we're rehashing in general suggests we've got something kinda wrong, layout wise.
4202019-05-23T19:36:55 <wumpus> true
4212019-05-23T19:37:27 <promag> ok, I'll keep doing those profiles
4222019-05-23T19:37:40 <MarcoFalke> Could just cache the hash in the data structure?
4232019-05-23T19:37:40 <wumpus> depends also on how much more complicated it makes the code, or whether it increases memory use, etc
4242019-05-23T19:37:58 <wumpus> how much it increases memory use, of course caching increases memory use
4252019-05-23T19:38:03 * MarcoFalke ducks
4262019-05-23T19:38:07 <sipa> jamesob: mr profiling... do we have any way to generally benchmark block-propagation-speed-at-synced-tip ?
4272019-05-23T19:38:39 <jamesob> mmm short of parsing verbose debug.log, I don't think so. not built into bitcoinperf yet, at any rate :)
4282019-05-23T19:38:41 <promag> MarcoFalke: the hash is only necessary while processing/validating
4292019-05-23T19:39:07 <sipa> jamesob: i think it would be very valuable to have; especially for scenarios where the block's transactions have already been validated in the mempool
4302019-05-23T19:39:25 <sipa> as there are very relevant performance improvements there that'd generally be dwarfed by script validation
4312019-05-23T19:39:41 <MarcoFalke> sipa: Would that require two nodes?
4322019-05-23T19:39:53 <MarcoFalke> or are you talking about a micro benchmark
4332019-05-23T19:39:56 <jamesob> sipa: yeah, agree that's a metric worth tracking
4342019-05-23T19:40:05 <jamesob> happy to build something for it
4352019-05-23T19:40:22 <sipa> perhaps we should do some brainstorming about that, but maybe outside the meeting
4362019-05-23T19:40:22 <wumpus> jamesob: cool!
4372019-05-23T19:40:46 <fanquake> If anyone is interested in guix building, dongcarl has been doing a lot of work in #15277. Would be good to get some more builds to compare hashes with.
4382019-05-23T19:40:48 <gribble> https://github.com/bitcoin/bitcoin/issues/15277 | [Help Wanted] contrib: Enable building in Guix containers by dongcarl · Pull Request #15277 · bitcoin/bitcoin · GitHub
4392019-05-23T19:41:00 <MarcoFalke> sipa: If it is for bitcoinperf: https://github.com/chaincodelabs/bitcoinperf/issues
4402019-05-23T19:41:03 <gmaxwell> sipa: there are tests in bitcoinfibre.
4412019-05-23T19:41:07 <wumpus> fanquake: if there's clear instructions to test, I'm happy to try
4422019-05-23T19:41:16 <promag> ah btw, one thing that takes a while is base_uint<BITS>& base_uint<BITS>::operator>>=(unsigned int shift)
4432019-05-23T19:41:37 <dongcarl> wumpus: I'll update and link you
4442019-05-23T19:41:44 <wumpus> dongcarl: great !
4452019-05-23T19:41:46 <sipa> promag: inside the division logic for retargetting that's expected
4462019-05-23T19:41:51 <sipa> most of the time is in shifts
4472019-05-23T19:42:14 <gmaxwell> MarcoFalke: The logical place to cache hashes in block objects themselves, doing so there is irrelevant memory use wise (32 bytes in a 1.2MB object), but complicates constness.
4482019-05-23T19:42:48 <fanquake> I have a setup/container guide for a quick Guix setup here as well: https://github.com/fanquake/core-review/tree/master/guix
4492019-05-23T19:43:03 <gmaxwell> promag: if thats actually taking a non-trivial amount of some real usecase, the division could be made faster... it uses a fairly naieve algorithim right now.
4502019-05-23T19:43:05 <wumpus> agree it's irrelevant on block objects, it's mostly CBlockIndex where it counts because so many of them are permanently in memory
4512019-05-23T19:43:11 *** sfhi2 has joined #bitcoin-core-dev
4522019-05-23T19:43:28 <jamesob> fanquake: cool!
4532019-05-23T19:44:08 <wumpus> fanquake:nice
4542019-05-23T19:45:32 <wumpus> any other topics?
4552019-05-23T19:46:33 *** sfhi has quit IRC
4562019-05-23T19:47:00 <wumpus> #endmeeting
4572019-05-23T19:47:00 <lightningbot> Meeting ended Thu May 23 19:47:00 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4582019-05-23T19:47:00 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-23-19.00.html
4592019-05-23T19:47:00 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-23-19.00.txt
4602019-05-23T19:47:00 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-23-19.00.log.html
4612019-05-23T19:47:34 <jamesob> gmaxwell: were those fibre tests you mentioned in the microbench or somewhere else?
4622019-05-23T19:48:51 <gmaxwell> microbench, IIRC
4632019-05-23T19:49:05 <gmaxwell> BlueMatt: I summon thee
4642019-05-23T19:49:33 <BlueMatt> hmm
4652019-05-23T19:50:06 <luke-jr> is it just me, or did gmaxwell's nick change colour?
4662019-05-23T19:50:18 <BlueMatt> gmaxwell: note that CBlock const-ness is already fucked (yay CheckBlock), not to say we should make it worse, though
4672019-05-23T19:50:19 <kanzure> btw, i'm still seeking submissions for topics for upcoming physical meetup.
4682019-05-23T19:50:21 <promag> gmaxwell: effective
4692019-05-23T19:51:32 <jamesob> BlueMatt gmaxwell: this thing? https://github.com/bitcoinfibre/bitcoinfibre/commit/a04d57208e09c21d241dc880dffa8eb4efbda1e5
4702019-05-23T19:52:16 <BlueMatt> whats the question?
4712019-05-23T19:53:07 <gmaxwell> BlueMatt: 12:38:07 < sipa> jamesob: mr profiling... do we have any way to generally benchmark block-propagation-speed-at-synced-tip ?
4722019-05-23T19:53:12 <gmaxwell> 12:41:03 < gmaxwell> sipa: there are tests in bitcoinfibre.
4732019-05-23T19:53:38 <gmaxwell> basically promag has an optimization that avoids rehashing the whole block when accepting it.
4742019-05-23T19:53:53 <gmaxwell> her rehashing the header perhaps actually.
4752019-05-23T19:53:54 <promag> gmaxwell: no the block
4762019-05-23T19:54:04 <promag> yap, the blockheader
4772019-05-23T19:54:05 <BlueMatt> when do we hash the block?
4782019-05-23T19:54:09 <BlueMatt> yea, blockheader, ok
4792019-05-23T19:54:27 <BlueMatt> there was a patch like 5 years ago that removed most of the duplicate hashes in acceptance path
4802019-05-23T19:54:29 <BlueMatt> how many are left?
4812019-05-23T19:54:33 <promag> https://github.com/bitcoin/bitcoin/pull/16065#issuecomment-494853746
4822019-05-23T19:54:36 <gmaxwell> header yea, so question is it worthwhile? obviously not against IBD, but maybe at tip relay for non-hb peers.
4832019-05-23T19:56:13 *** bitcoin-git has joined #bitcoin-core-dev
4842019-05-23T19:56:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/65c4bbe629bb...fe47ae168b57
4852019-05-23T19:56:15 <bitcoin-git> bitcoin/master 3ee28c5 Jon Atack: build: bump bitcoin_config.h packages to v0.18
4862019-05-23T19:56:16 <bitcoin-git> bitcoin/master 8afca32 Jon Atack: doc: add bitcoin_config.h PACKAGE updates to release process
4872019-05-23T19:56:17 <bitcoin-git> bitcoin/master fe47ae1 MarcoFalke: Merge #16080: build/doc: update bitcoin_config.h packages, release process...
4882019-05-23T19:56:18 *** bitcoin-git has left #bitcoin-core-dev
4892019-05-23T19:56:44 <BlueMatt> hmm, only things I have that would test this is looking at debug.log (which I have scripts that do, but its fibre-specific)
4902019-05-23T19:57:00 <gmaxwell> BlueMatt: I thought one of your fibre unit tests tested accepting a block.
4912019-05-23T19:57:09 *** bitcoin-git has joined #bitcoin-core-dev
4922019-05-23T19:57:10 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16080: build/doc: update bitcoin_config.h packages, release process (master...bitcoin_config-and-release_process-updates) https://github.com/bitcoin/bitcoin/pull/16080
4932019-05-23T19:57:22 *** bitcoin-git has left #bitcoin-core-dev
4942019-05-23T19:57:22 <BlueMatt> they do not, I believe
4952019-05-23T19:57:38 <BlueMatt> they do test the equivalent of getting a block in via fibre and converting it to a CBlock for acceptance
4962019-05-23T19:57:40 <BlueMatt> but nothing further
4972019-05-23T19:58:28 <gmaxwell> ah, okay, my mistake then.
4982019-05-23T19:59:49 <jamesob> so if we were to bench acceptance-at-tip, would it make sense to have different fixtures for HB vs. LB?
4992019-05-23T20:00:46 <gmaxwell> Yes. Both figures are important and they're radically different.
5002019-05-23T20:01:14 <gmaxwell> Because HB relay happens before EVERYTHING, including validation.
5012019-05-23T20:01:32 <gmaxwell> (okay maybe my everything was still to uppercase)
5022019-05-23T20:01:42 <gmaxwell> too*
5032019-05-23T20:02:46 <jamesob> hm, in net_processing:SendMessages?
5042019-05-23T20:04:24 <jamesob> https://github.com/jamesob/bitcoin/blob/b2a6b0216192b6e8428f1a80b47f5178fccb961a/src/net_processing.cpp#L3587-L3590
5052019-05-23T20:08:59 <gmaxwell> when I'm benchmarking I'm normally looking at logs with microsecond time on for the difference between these lines:
5062019-05-23T20:09:00 <gmaxwell> 2019-05-23T20:07:22.551652Z received: cmpctblock (16841 bytes) peer=1
5072019-05-23T20:09:09 <gmaxwell> 2019-05-23T20:07:22.571894Z sending cmpctblock (16841 bytes) peer=5
5082019-05-23T20:09:39 <gmaxwell> 2019-05-23T20:07:22.654285Z SendMessages: sending header 00000000000000000013886cc5bfa15d88db56f024a66b92f4b10ecf46922ff5 to peer=2
5092019-05-23T20:10:25 <gmaxwell> The first is getting the cmpct block, the second is sending the first HB block, and the third is the first non-HB announcement.
5102019-05-23T20:11:09 *** jtimon has joined #bitcoin-core-dev
5112019-05-23T20:12:07 <jamesob> gmaxwell: ah okay, that helps
5122019-05-23T20:12:58 <gmaxwell> it might be interesting to setup a little stats datastructure that you can get at with an RPC.
5132019-05-23T20:14:22 <gmaxwell> That keeps a couple relevant times --- like the above two deltas for the last block, and maybe a couple EWMA averages of them. Then the python test framework could be used to do some benchmarking without relying on log parsing (which we break with frustrating frequency)
5142019-05-23T20:14:56 *** michaelfolkson has joined #bitcoin-core-dev
5152019-05-23T20:16:08 <gmaxwell> one thing to keep in mind is that cmpctblock is only the relevant start point when there are no missing txn, otherwise the blocktxn message is.
5162019-05-23T20:16:59 <gmaxwell> (if you measure cmpct->cmpct when there are missing txn, you'll include the response time of the peer and network latency-- which is itself also very interesting but perhaps doesn't make for a clean test :) )
5172019-05-23T20:21:07 *** michaelfolkson has quit IRC
5182019-05-23T20:26:40 *** dviola has joined #bitcoin-core-dev
5192019-05-23T20:30:32 *** ExEric3 has quit IRC
5202019-05-23T20:31:18 *** ExEric3 has joined #bitcoin-core-dev
5212019-05-23T20:39:45 <jamesob> gmaxwell: thanks for the pointers. I was actually about to start working on a bitcoind log parsing lib, but the RPC idea's interesting too. I wonder if maintaining some of those stats datastructures under an #if defined(DEBUG) wouldn't be too invasive
5222019-05-23T20:40:20 <jamesob> err probably not DEBUG; we might want a separate configure flag I guess
5232019-05-23T20:46:40 *** Chris_Stewart_5 has quit IRC
5242019-05-23T20:54:09 *** rex4539 has joined #bitcoin-core-dev
5252019-05-23T20:55:00 *** d_t has joined #bitcoin-core-dev
5262019-05-23T20:58:50 <gmaxwell> Ifdefs are kind of invasive, I don't think some operational stats would be bad to have at runtime regardless.
5272019-05-23T21:00:02 *** nirik-fre has quit IRC
5282019-05-23T21:08:07 *** nkohen has quit IRC
5292019-05-23T21:18:05 *** bpalmer has joined #bitcoin-core-dev
5302019-05-23T21:26:20 *** pinheadmz has quit IRC
5312019-05-23T21:29:40 *** justanotheruser has joined #bitcoin-core-dev
5322019-05-23T21:31:12 *** justanotheruser has joined #bitcoin-core-dev
5332019-05-23T21:34:58 *** AaronvanW has joined #bitcoin-core-dev
5342019-05-23T21:38:40 *** Aaronvan_ has quit IRC
5352019-05-23T21:42:06 *** spinza has quit IRC
5362019-05-23T21:43:35 *** d_t has joined #bitcoin-core-dev
5372019-05-23T21:43:35 *** Guyver2 has quit IRC
5382019-05-23T21:46:10 *** sfhi2 has quit IRC
5392019-05-23T21:49:02 *** spinza has joined #bitcoin-core-dev
5402019-05-23T21:49:47 *** spaced0ut has quit IRC
5412019-05-23T22:07:41 *** d_t has quit IRC
5422019-05-23T22:09:22 *** michaelsdunn1 has quit IRC
5432019-05-23T22:10:14 *** promag has quit IRC
5442019-05-23T22:13:25 *** fanquake has quit IRC
5452019-05-23T22:37:50 *** siom has quit IRC
5462019-05-23T22:41:58 *** spinza has quit IRC
5472019-05-23T22:46:54 *** spinza has joined #bitcoin-core-dev
5482019-05-23T22:56:12 *** d_t has joined #bitcoin-core-dev
5492019-05-23T23:01:54 *** pinheadmz has joined #bitcoin-core-dev
5502019-05-23T23:04:36 *** ccdle12 has joined #bitcoin-core-dev
5512019-05-23T23:15:34 *** jtimon has quit IRC
5522019-05-23T23:31:03 *** Zenton has quit IRC
5532019-05-23T23:48:52 *** michaelfolkson has joined #bitcoin-core-dev
5542019-05-23T23:51:23 *** fanquake has joined #bitcoin-core-dev
5552019-05-23T23:52:51 *** promag has joined #bitcoin-core-dev
5562019-05-23T23:57:20 *** promag has quit IRC