1 2019-05-30T00:00:02  *** toony1 has quit IRC
  2 2019-05-30T00:02:50  *** jarthur has quit IRC
  3 2019-05-30T00:04:04  *** engil1 has joined #bitcoin-core-dev
  4 2019-05-30T00:04:07  *** Lightsword has quit IRC
  5 2019-05-30T00:04:21  *** Lightsword has joined #bitcoin-core-dev
  6 2019-05-30T00:08:21  *** icek has joined #bitcoin-core-dev
  7 2019-05-30T00:12:14  *** pinheadmz has joined #bitcoin-core-dev
  8 2019-05-30T00:13:19  *** scoop has quit IRC
  9 2019-05-30T00:14:08  *** scoop has joined #bitcoin-core-dev
 10 2019-05-30T00:16:19  *** scoop has quit IRC
 11 2019-05-30T00:17:30  *** d_t has joined #bitcoin-core-dev
 12 2019-05-30T00:17:41  *** ghost43 has quit IRC
 13 2019-05-30T00:17:56  *** ghost43 has joined #bitcoin-core-dev
 14 2019-05-30T00:26:08  *** Chris_Stewart_5 has quit IRC
 15 2019-05-30T00:29:27  *** AaronvanW has joined #bitcoin-core-dev
 16 2019-05-30T00:31:51  *** murrayn is now known as murray
 17 2019-05-30T00:32:17  *** cltrbreak_MAD2 is now known as ctrlbreak
 18 2019-05-30T00:32:21  *** murray is now known as Guest45886
 19 2019-05-30T00:32:47  *** michaelfolkson has joined #bitcoin-core-dev
 20 2019-05-30T00:33:12  *** Guest45886 is now known as murrayn
 21 2019-05-30T00:34:08  *** AaronvanW has quit IRC
 22 2019-05-30T00:34:57  *** luke-jr has quit IRC
 23 2019-05-30T00:35:44  *** luke-jr has joined #bitcoin-core-dev
 24 2019-05-30T00:38:20  *** ccdle12 has quit IRC
 25 2019-05-30T00:38:34  *** luke-jr has quit IRC
 26 2019-05-30T00:41:00  *** luke-jr has joined #bitcoin-core-dev
 27 2019-05-30T00:43:47  *** d_t_ has joined #bitcoin-core-dev
 28 2019-05-30T00:43:48  *** spinza has quit IRC
 29 2019-05-30T00:44:28  *** ddustin_ has joined #bitcoin-core-dev
 30 2019-05-30T00:45:44  *** ddustin has quit IRC
 31 2019-05-30T00:46:42  *** dgenr8 has quit IRC
 32 2019-05-30T00:46:42  *** d_t has quit IRC
 33 2019-05-30T00:46:43  *** luke-jr has quit IRC
 34 2019-05-30T00:47:06  *** dgenr8 has joined #bitcoin-core-dev
 35 2019-05-30T00:47:22  *** luke-jr has joined #bitcoin-core-dev
 36 2019-05-30T00:50:06  *** jtimon has quit IRC
 37 2019-05-30T00:51:28  *** luke-jr has quit IRC
 38 2019-05-30T00:52:35  *** luke-jr has joined #bitcoin-core-dev
 39 2019-05-30T00:52:54  *** bitbee has quit IRC
 40 2019-05-30T00:53:20  *** spinza has joined #bitcoin-core-dev
 41 2019-05-30T00:53:25  *** bitbee has joined #bitcoin-core-dev
 42 2019-05-30T00:54:23  *** luke-jr has quit IRC
 43 2019-05-30T00:55:08  *** luke-jr has joined #bitcoin-core-dev
 44 2019-05-30T01:00:27  *** luke-jr has quit IRC
 45 2019-05-30T01:00:54  *** luke-jr has joined #bitcoin-core-dev
 46 2019-05-30T01:01:13  *** jb55 has quit IRC
 47 2019-05-30T01:02:40  *** luke-jr has quit IRC
 48 2019-05-30T01:03:16  *** luke-jr has joined #bitcoin-core-dev
 49 2019-05-30T01:05:35  *** sean8219 has joined #bitcoin-core-dev
 50 2019-05-30T01:08:50  *** luke-jr has quit IRC
 51 2019-05-30T01:09:46  *** luke-jr has joined #bitcoin-core-dev
 52 2019-05-30T01:13:58  *** luke-jr has quit IRC
 53 2019-05-30T01:15:10  *** bitcoin-git has joined #bitcoin-core-dev
 54 2019-05-30T01:15:10  <bitcoin-git> [bitcoin] Empact opened pull request #16123: Return error information on descriptor parse error (master...descriptor-parse-error) https://github.com/bitcoin/bitcoin/pull/16123
 55 2019-05-30T01:15:11  *** bitcoin-git has left #bitcoin-core-dev
 56 2019-05-30T01:16:34  *** justanotheruser has joined #bitcoin-core-dev
 57 2019-05-30T01:18:18  *** luke-jr has joined #bitcoin-core-dev
 58 2019-05-30T01:21:19  *** bg002h has joined #bitcoin-core-dev
 59 2019-05-30T01:23:34  *** AaronvanW has joined #bitcoin-core-dev
 60 2019-05-30T01:24:21  *** justan0theruser has joined #bitcoin-core-dev
 61 2019-05-30T01:24:58  *** justanotheruser has quit IRC
 62 2019-05-30T01:28:22  *** jb55 has joined #bitcoin-core-dev
 63 2019-05-30T01:35:14  *** michaelfolkson has quit IRC
 64 2019-05-30T01:38:44  *** ccdle12 has joined #bitcoin-core-dev
 65 2019-05-30T01:43:23  *** ccdle12 has quit IRC
 66 2019-05-30T01:43:50  *** sean8219 has quit IRC
 67 2019-05-30T01:44:10  *** openminded has joined #bitcoin-core-dev
 68 2019-05-30T01:46:31  *** openminded has quit IRC
 69 2019-05-30T01:46:50  *** openminded has joined #bitcoin-core-dev
 70 2019-05-30T01:48:04  *** ddustin_ has quit IRC
 71 2019-05-30T01:48:44  *** openminded has quit IRC
 72 2019-05-30T01:48:50  *** ddustin has joined #bitcoin-core-dev
 73 2019-05-30T01:49:03  *** sean8219 has joined #bitcoin-core-dev
 74 2019-05-30T01:53:47  *** sean8219 has quit IRC
 75 2019-05-30T01:53:52  *** ddustin has quit IRC
 76 2019-05-30T01:54:12  *** ddustin has joined #bitcoin-core-dev
 77 2019-05-30T01:54:49  *** ddustin has quit IRC
 78 2019-05-30T01:55:36  *** ddustin has joined #bitcoin-core-dev
 79 2019-05-30T01:55:40  *** sean8219 has joined #bitcoin-core-dev
 80 2019-05-30T01:56:10  *** ddustin has quit IRC
 81 2019-05-30T01:56:47  *** ddustin has joined #bitcoin-core-dev
 82 2019-05-30T01:56:49  *** teardown has joined #bitcoin-core-dev
 83 2019-05-30T01:57:16  *** AaronvanW has quit IRC
 84 2019-05-30T01:59:58  *** reitoukousen has joined #bitcoin-core-dev
 85 2019-05-30T02:03:45  *** sean8219 has quit IRC
 86 2019-05-30T02:06:33  *** reitoukousen has quit IRC
 87 2019-05-30T02:07:38  *** sean8219 has joined #bitcoin-core-dev
 88 2019-05-30T02:11:06  *** d_t_ has quit IRC
 89 2019-05-30T02:20:42  *** sean8219 has quit IRC
 90 2019-05-30T02:32:22  *** sean8219 has joined #bitcoin-core-dev
 91 2019-05-30T02:33:37  *** scoop has joined #bitcoin-core-dev
 92 2019-05-30T02:36:37  *** sean8219 has quit IRC
 93 2019-05-30T02:37:11  *** scoop has quit IRC
 94 2019-05-30T02:37:17  *** scoop has joined #bitcoin-core-dev
 95 2019-05-30T02:38:25  *** sean8219 has joined #bitcoin-core-dev
 96 2019-05-30T02:40:15  *** sean8219 has quit IRC
 97 2019-05-30T02:40:47  *** AaronvanW has joined #bitcoin-core-dev
 98 2019-05-30T02:45:20  *** AaronvanW has quit IRC
 99 2019-05-30T02:49:26  *** sean8219 has joined #bitcoin-core-dev
100 2019-05-30T02:50:01  *** sean8219 has quit IRC
101 2019-05-30T02:51:50  *** sean8219 has joined #bitcoin-core-dev
102 2019-05-30T02:52:42  *** ddustin has quit IRC
103 2019-05-30T02:53:17  *** TheRec has quit IRC
104 2019-05-30T02:53:21  *** ddustin has joined #bitcoin-core-dev
105 2019-05-30T02:57:09  *** sean8219 has quit IRC
106 2019-05-30T02:59:01  *** sean8219 has joined #bitcoin-core-dev
107 2019-05-30T03:00:01  *** engil1 has quit IRC
108 2019-05-30T03:01:15  *** sean8219 has quit IRC
109 2019-05-30T03:04:01  *** DragonEyes1 has joined #bitcoin-core-dev
110 2019-05-30T03:05:10  *** sean8219 has joined #bitcoin-core-dev
111 2019-05-30T03:05:33  *** TheRec has joined #bitcoin-core-dev
112 2019-05-30T03:05:49  *** scoop has quit IRC
113 2019-05-30T03:06:15  *** scoop has joined #bitcoin-core-dev
114 2019-05-30T03:09:27  *** justan0theruser is now known as justanotheruser
115 2019-05-30T03:10:22  *** scoop has quit IRC
116 2019-05-30T03:13:57  *** sean8219 has quit IRC
117 2019-05-30T03:14:30  *** sean8219 has joined #bitcoin-core-dev
118 2019-05-30T03:17:13  *** sean8219 has joined #bitcoin-core-dev
119 2019-05-30T03:18:17  *** sean8219 has quit IRC
120 2019-05-30T03:25:00  *** sean8219 has joined #bitcoin-core-dev
121 2019-05-30T03:27:07  *** ccdle12 has joined #bitcoin-core-dev
122 2019-05-30T03:32:16  *** ccdle12 has quit IRC
123 2019-05-30T03:34:54  *** AaronvanW has joined #bitcoin-core-dev
124 2019-05-30T03:39:03  *** sean8219 has quit IRC
125 2019-05-30T03:40:00  *** kljasdfvv has quit IRC
126 2019-05-30T03:40:42  *** kljasdfvv has joined #bitcoin-core-dev
127 2019-05-30T03:45:10  *** sean8219 has joined #bitcoin-core-dev
128 2019-05-30T03:56:19  *** Eagle[TM] has joined #bitcoin-core-dev
129 2019-05-30T03:58:38  *** EagleTM has quit IRC
130 2019-05-30T04:05:06  *** michaelfolkson has joined #bitcoin-core-dev
131 2019-05-30T04:08:07  *** AaronvanW has quit IRC
132 2019-05-30T04:08:21  *** sean8219 has quit IRC
133 2019-05-30T04:11:10  *** sean8219 has joined #bitcoin-core-dev
134 2019-05-30T04:16:14  *** michaelfolkson has quit IRC
135 2019-05-30T04:31:19  *** ccdle12 has joined #bitcoin-core-dev
136 2019-05-30T04:31:58  *** sean8219 has quit IRC
137 2019-05-30T04:32:27  *** michaelfolkson has joined #bitcoin-core-dev
138 2019-05-30T04:32:28  *** michaelfolkson has quit IRC
139 2019-05-30T04:38:30  *** sean8219 has joined #bitcoin-core-dev
140 2019-05-30T04:39:19  *** sean8219_ has joined #bitcoin-core-dev
141 2019-05-30T04:40:21  *** sean8219_ has quit IRC
142 2019-05-30T04:41:22  *** sean8219 has quit IRC
143 2019-05-30T04:59:02  *** AaronvanW has joined #bitcoin-core-dev
144 2019-05-30T05:03:25  *** AaronvanW has quit IRC
145 2019-05-30T05:21:57  *** bitcoin-git has joined #bitcoin-core-dev
146 2019-05-30T05:21:58  <bitcoin-git> [bitcoin] Empact closed pull request #16123: Return error information on descriptor parse error (master...descriptor-parse-error) https://github.com/bitcoin/bitcoin/pull/16123
147 2019-05-30T05:22:10  *** bitcoin-git has left #bitcoin-core-dev
148 2019-05-30T05:37:02  *** luke-jr has quit IRC
149 2019-05-30T05:37:51  *** luke-jr has joined #bitcoin-core-dev
150 2019-05-30T05:41:20  *** luke-jr has quit IRC
151 2019-05-30T05:44:41  *** luke-jr has joined #bitcoin-core-dev
152 2019-05-30T05:50:30  *** luke-jr has quit IRC
153 2019-05-30T05:51:37  *** luke-jr has joined #bitcoin-core-dev
154 2019-05-30T05:53:02  *** AaronvanW has joined #bitcoin-core-dev
155 2019-05-30T06:00:02  *** DragonEyes1 has quit IRC
156 2019-05-30T06:02:36  *** while has joined #bitcoin-core-dev
157 2019-05-30T06:04:14  *** dscho has joined #bitcoin-core-dev
158 2019-05-30T06:26:20  *** rex4539 has quit IRC
159 2019-05-30T06:27:12  *** AaronvanW has quit IRC
160 2019-05-30T06:39:46  *** d_t has joined #bitcoin-core-dev
161 2019-05-30T06:42:22  *** bitcoin-git has joined #bitcoin-core-dev
162 2019-05-30T06:42:22  <bitcoin-git> [bitcoin] practicalswift opened pull request #16124: tests: Limit Python linting to files in the repo (master...lint-inside-repo) https://github.com/bitcoin/bitcoin/pull/16124
163 2019-05-30T06:42:35  *** bitcoin-git has left #bitcoin-core-dev
164 2019-05-30T06:57:10  *** laptop500 has joined #bitcoin-core-dev
165 2019-05-30T07:02:58  *** d_t has quit IRC
166 2019-05-30T07:06:17  *** AaronvanW has joined #bitcoin-core-dev
167 2019-05-30T07:06:32  *** scoop has joined #bitcoin-core-dev
168 2019-05-30T07:10:56  *** scoop has quit IRC
169 2019-05-30T07:10:56  *** AaronvanW has quit IRC
170 2019-05-30T07:16:16  *** promag has joined #bitcoin-core-dev
171 2019-05-30T07:48:31  *** b10c has joined #bitcoin-core-dev
172 2019-05-30T07:54:05  *** rex4539 has joined #bitcoin-core-dev
173 2019-05-30T08:00:24  *** AaronvanW has joined #bitcoin-core-dev
174 2019-05-30T08:28:12  *** mryandao_ has joined #bitcoin-core-dev
175 2019-05-30T08:31:09  <stevenroose> Any idea what it could mean when Travis gives this error for the feature_notification.py test?
176 2019-05-30T08:31:12  <stevenroose> node0 2019-05-29T20:16:15.512410Z runCommand error: system(echo > /tmp/test_runner_₿_🏃_20190529_201410/feature_notifications_45/blocknotify/03d5fa58ac73a6b5e2d1baf5849e0142355758746314509e3eff69683ffe9872) returned -1
177 2019-05-30T08:31:15  *** mryandao has quit IRC
178 2019-05-30T08:31:31  <stevenroose> Seems like it can't write to the file somehow. Or the directory doesn't exist or something.
179 2019-05-30T08:34:22  *** AaronvanW has quit IRC
180 2019-05-30T08:48:18  *** thaumavorio_ has quit IRC
181 2019-05-30T08:49:49  *** thaumavorio has joined #bitcoin-core-dev
182 2019-05-30T08:50:08  *** ccdle12 has quit IRC
183 2019-05-30T08:51:45  *** ccdle12 has joined #bitcoin-core-dev
184 2019-05-30T08:52:28  *** ccdle12 has joined #bitcoin-core-dev
185 2019-05-30T08:53:46  *** siom has joined #bitcoin-core-dev
186 2019-05-30T08:58:32  *** Guest46546 has joined #bitcoin-core-dev
187 2019-05-30T09:00:02  *** dscho has quit IRC
188 2019-05-30T09:03:01  *** promag_ has joined #bitcoin-core-dev
189 2019-05-30T09:04:52  *** gorthx has joined #bitcoin-core-dev
190 2019-05-30T09:04:56  *** luke-jr has quit IRC
191 2019-05-30T09:05:39  *** luke-jr has joined #bitcoin-core-dev
192 2019-05-30T09:09:12  *** luke-jr has quit IRC
193 2019-05-30T09:09:28  *** Guest46546 has quit IRC
194 2019-05-30T09:09:59  *** luke-jr has joined #bitcoin-core-dev
195 2019-05-30T09:10:17  *** ccdle12 has quit IRC
196 2019-05-30T09:11:24  *** luke-jr has quit IRC
197 2019-05-30T09:14:27  *** luke-jr has joined #bitcoin-core-dev
198 2019-05-30T09:18:30  *** timothy has joined #bitcoin-core-dev
199 2019-05-30T09:20:32  *** luke-jr has quit IRC
200 2019-05-30T09:21:22  *** luke-jr has joined #bitcoin-core-dev
201 2019-05-30T09:23:00  *** sean8219 has joined #bitcoin-core-dev
202 2019-05-30T09:23:36  *** luke-jr has quit IRC
203 2019-05-30T09:24:26  *** AaronvanW has joined #bitcoin-core-dev
204 2019-05-30T09:24:30  *** luke-jr has joined #bitcoin-core-dev
205 2019-05-30T09:25:34  *** sean8219_ has joined #bitcoin-core-dev
206 2019-05-30T09:27:07  *** Dean_Guss has joined #bitcoin-core-dev
207 2019-05-30T09:28:48  *** AaronvanW has quit IRC
208 2019-05-30T09:29:13  *** sean8219 has quit IRC
209 2019-05-30T09:29:51  *** sean8219_ has joined #bitcoin-core-dev
210 2019-05-30T09:31:31  *** luke-jr has quit IRC
211 2019-05-30T09:32:11  *** darosior has joined #bitcoin-core-dev
212 2019-05-30T09:32:30  *** luke-jr has joined #bitcoin-core-dev
213 2019-05-30T09:37:42  *** luke-jr has quit IRC
214 2019-05-30T09:39:36  *** luke-jr has joined #bitcoin-core-dev
215 2019-05-30T09:45:27  *** luke-jr has quit IRC
216 2019-05-30T09:45:48  *** sean8219_ has quit IRC
217 2019-05-30T09:46:15  *** luke-jr has joined #bitcoin-core-dev
218 2019-05-30T09:48:06  *** sean8219_ has joined #bitcoin-core-dev
219 2019-05-30T09:56:03  *** rex4539 has quit IRC
220 2019-05-30T10:03:34  *** spinza has quit IRC
221 2019-05-30T10:07:39  *** jonatack has quit IRC
222 2019-05-30T10:10:40  *** lnostdal has quit IRC
223 2019-05-30T10:11:03  *** spinza has joined #bitcoin-core-dev
224 2019-05-30T10:11:07  *** lnostdal has joined #bitcoin-core-dev
225 2019-05-30T10:14:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
226 2019-05-30T10:15:10  *** lnostdal has quit IRC
227 2019-05-30T10:15:28  *** lnostdal has joined #bitcoin-core-dev
228 2019-05-30T10:17:52  *** AaronvanW has joined #bitcoin-core-dev
229 2019-05-30T10:18:42  *** promag_ has quit IRC
230 2019-05-30T10:22:21  *** AaronvanW has quit IRC
231 2019-05-30T10:24:33  *** sean8219_ has quit IRC
232 2019-05-30T10:26:45  *** sean8219_ has joined #bitcoin-core-dev
233 2019-05-30T10:29:35  *** sean8219_ has quit IRC
234 2019-05-30T10:30:06  *** mryandao_ is now known as mryandao
235 2019-05-30T10:31:30  *** sean8219_ has joined #bitcoin-core-dev
236 2019-05-30T10:35:32  *** rex4539 has joined #bitcoin-core-dev
237 2019-05-30T10:36:44  *** Deinogalerix21 has joined #bitcoin-core-dev
238 2019-05-30T10:41:02  *** promag_ has joined #bitcoin-core-dev
239 2019-05-30T10:43:27  *** sean8219_ has quit IRC
240 2019-05-30T10:44:12  *** shesek has quit IRC
241 2019-05-30T10:44:20  *** sean8219_ has joined #bitcoin-core-dev
242 2019-05-30T10:49:24  *** jonatack has joined #bitcoin-core-dev
243 2019-05-30T10:54:54  *** sean8219_ has quit IRC
244 2019-05-30T10:55:35  *** ccdle12 has joined #bitcoin-core-dev
245 2019-05-30T10:56:11  *** sean8219_ has joined #bitcoin-core-dev
246 2019-05-30T10:59:46  *** sean8219_ has quit IRC
247 2019-05-30T11:00:58  *** sean8219_ has joined #bitcoin-core-dev
248 2019-05-30T11:05:19  *** michaelfolkson has joined #bitcoin-core-dev
249 2019-05-30T11:06:56  *** scoop has joined #bitcoin-core-dev
250 2019-05-30T11:07:04  *** sean8219_ has quit IRC
251 2019-05-30T11:07:30  *** sean8219_ has joined #bitcoin-core-dev
252 2019-05-30T11:11:45  *** michaelfolkson has quit IRC
253 2019-05-30T11:12:02  *** AaronvanW has joined #bitcoin-core-dev
254 2019-05-30T11:12:04  *** scoop has quit IRC
255 2019-05-30T11:16:56  *** AaronvanW has quit IRC
256 2019-05-30T11:20:04  *** michaelfolkson has joined #bitcoin-core-dev
257 2019-05-30T11:21:06  *** sfhi has joined #bitcoin-core-dev
258 2019-05-30T11:26:46  *** sean8219_ has quit IRC
259 2019-05-30T11:26:59  *** mats_ has quit IRC
260 2019-05-30T11:27:18  *** Deinogalerix21 has quit IRC
261 2019-05-30T11:30:43  *** AaronvanW has joined #bitcoin-core-dev
262 2019-05-30T11:31:30  *** sean8219_ has joined #bitcoin-core-dev
263 2019-05-30T11:32:10  *** Victorsueca has quit IRC
264 2019-05-30T11:33:18  *** Victorsueca has joined #bitcoin-core-dev
265 2019-05-30T11:34:14  *** sean8219_ has quit IRC
266 2019-05-30T11:35:12  *** sean8219_ has joined #bitcoin-core-dev
267 2019-05-30T11:35:53  *** Chris_Stewart_5 has quit IRC
268 2019-05-30T11:40:54  *** rex4539 has quit IRC
269 2019-05-30T11:43:41  *** sean8219_ has quit IRC
270 2019-05-30T11:47:50  *** shesek has joined #bitcoin-core-dev
271 2019-05-30T11:47:50  *** shesek has joined #bitcoin-core-dev
272 2019-05-30T11:48:37  *** owowo has quit IRC
273 2019-05-30T11:53:12  *** owowo has joined #bitcoin-core-dev
274 2019-05-30T11:56:34  *** sean8219_ has joined #bitcoin-core-dev
275 2019-05-30T11:56:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
276 2019-05-30T11:58:00  *** sean8219_ has quit IRC
277 2019-05-30T11:58:14  *** sean8219_ has joined #bitcoin-core-dev
278 2019-05-30T12:00:02  *** gorthx has quit IRC
279 2019-05-30T12:00:42  *** promag_ has quit IRC
280 2019-05-30T12:01:18  *** sean8219_ has quit IRC
281 2019-05-30T12:01:51  *** sean8219_ has joined #bitcoin-core-dev
282 2019-05-30T12:03:46  *** theGrg has joined #bitcoin-core-dev
283 2019-05-30T12:04:37  *** michaelfolkson has quit IRC
284 2019-05-30T12:09:44  *** Chris_Stewart_5 has quit IRC
285 2019-05-30T12:09:53  *** michaelfolkson has joined #bitcoin-core-dev
286 2019-05-30T12:16:15  *** michaelfolkson has quit IRC
287 2019-05-30T12:17:25  *** qubenix has quit IRC
288 2019-05-30T12:20:28  *** b10c has quit IRC
289 2019-05-30T12:27:47  *** qubenix has joined #bitcoin-core-dev
290 2019-05-30T12:28:57  *** sean8219_ has quit IRC
291 2019-05-30T12:32:05  *** mryandao has quit IRC
292 2019-05-30T12:38:13  *** obsrver has joined #bitcoin-core-dev
293 2019-05-30T12:38:31  *** mryandao has joined #bitcoin-core-dev
294 2019-05-30T12:44:58  *** sean8219_ has joined #bitcoin-core-dev
295 2019-05-30T12:50:02  *** AaronvanW has quit IRC
296 2019-05-30T12:55:18  *** sean8219_ has quit IRC
297 2019-05-30T12:58:52  *** michaelfolkson has joined #bitcoin-core-dev
298 2019-05-30T13:02:36  *** jb55 has quit IRC
299 2019-05-30T13:02:50  *** sean8219_ has joined #bitcoin-core-dev
300 2019-05-30T13:07:00  *** icek has quit IRC
301 2019-05-30T13:09:59  *** sean8219_ has joined #bitcoin-core-dev
302 2019-05-30T13:10:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
303 2019-05-30T13:13:11  *** sean8219_ has quit IRC
304 2019-05-30T13:13:18  *** mdunnio has joined #bitcoin-core-dev
305 2019-05-30T13:14:34  *** michaelsdunn1 has joined #bitcoin-core-dev
306 2019-05-30T13:17:20  *** michaelsdunn1 has quit IRC
307 2019-05-30T13:17:21  *** mdunnio has quit IRC
308 2019-05-30T13:17:50  *** sean8219_ has joined #bitcoin-core-dev
309 2019-05-30T13:24:29  *** scoop has joined #bitcoin-core-dev
310 2019-05-30T13:29:36  *** shesek has quit IRC
311 2019-05-30T13:29:38  *** jb55 has joined #bitcoin-core-dev
312 2019-05-30T13:32:35  *** sean8219_ has quit IRC
313 2019-05-30T13:34:30  *** sean8219_ has joined #bitcoin-core-dev
314 2019-05-30T13:35:03  *** jonatack has quit IRC
315 2019-05-30T13:36:34  *** AaronvanW has joined #bitcoin-core-dev
316 2019-05-30T13:41:09  *** sean8219_ has quit IRC
317 2019-05-30T13:41:18  *** AaronvanW has quit IRC
318 2019-05-30T13:44:05  *** sean8219_ has joined #bitcoin-core-dev
319 2019-05-30T13:50:38  *** d_t has joined #bitcoin-core-dev
320 2019-05-30T13:51:03  *** shesek has joined #bitcoin-core-dev
321 2019-05-30T13:51:03  *** shesek has joined #bitcoin-core-dev
322 2019-05-30T13:55:03  *** d_t has quit IRC
323 2019-05-30T13:57:09  *** darosior has quit IRC
324 2019-05-30T14:12:21  *** michaelsdunn1 has joined #bitcoin-core-dev
325 2019-05-30T14:14:18  *** scoop has quit IRC
326 2019-05-30T14:14:52  *** AaronvanW has joined #bitcoin-core-dev
327 2019-05-30T14:16:24  *** scoop has joined #bitcoin-core-dev
328 2019-05-30T14:19:12  *** AaronvanW has quit IRC
329 2019-05-30T14:20:48  *** scoop has quit IRC
330 2019-05-30T14:21:00  *** sean8219_ has quit IRC
331 2019-05-30T14:22:00  *** michaelfolkson has quit IRC
332 2019-05-30T14:23:41  *** scoop has joined #bitcoin-core-dev
333 2019-05-30T14:23:42  *** sean8219_ has joined #bitcoin-core-dev
334 2019-05-30T14:28:39  *** sean8219_ has quit IRC
335 2019-05-30T14:29:18  *** sean8219_ has joined #bitcoin-core-dev
336 2019-05-30T14:37:25  *** sean8219_ has quit IRC
337 2019-05-30T14:41:04  *** AaronvanW has joined #bitcoin-core-dev
338 2019-05-30T14:44:20  *** sean8219_ has joined #bitcoin-core-dev
339 2019-05-30T14:45:26  *** ccdle12 has quit IRC
340 2019-05-30T14:46:10  *** AaronvanW has quit IRC
341 2019-05-30T14:46:50  *** captjakk has joined #bitcoin-core-dev
342 2019-05-30T14:49:06  *** laurentmt has joined #bitcoin-core-dev
343 2019-05-30T14:49:50  *** sean8219_ has quit IRC
344 2019-05-30T14:51:06  *** scoop has quit IRC
345 2019-05-30T14:53:06  *** sean8219_ has joined #bitcoin-core-dev
346 2019-05-30T14:56:54  *** ossifrage_ has joined #bitcoin-core-dev
347 2019-05-30T14:58:08  <jnewbery> #proposedmeetingtopic - has travis got worse or have we just added so many builds to our job that it times out?
348 2019-05-30T14:58:13  <jnewbery> moneyball: ^
349 2019-05-30T14:58:22  *** ossifrage has quit IRC
350 2019-05-30T14:59:20  *** michaelfolkson has joined #bitcoin-core-dev
351 2019-05-30T14:59:31  <ryanofsky> MarcoFalke, could drahtbot just automatically restart travis jobs that fail with "Error! Initial build successful, but not enough time remains to run later build stages and tests."?
352 2019-05-30T15:00:01  *** theGrg has quit IRC
353 2019-05-30T15:02:49  *** laurentmt has quit IRC
354 2019-05-30T15:05:58  *** sean8219_ has quit IRC
355 2019-05-30T15:11:01  *** scoop has joined #bitcoin-core-dev
356 2019-05-30T15:13:02  *** juhp has joined #bitcoin-core-dev
357 2019-05-30T15:13:15  *** davterra has quit IRC
358 2019-05-30T15:22:27  *** jonatack has joined #bitcoin-core-dev
359 2019-05-30T15:40:12  *** jnewbery has quit IRC
360 2019-05-30T15:42:04  *** jnewbery has joined #bitcoin-core-dev
361 2019-05-30T15:44:07  *** Guyver2 has joined #bitcoin-core-dev
362 2019-05-30T15:47:29  *** scoop has quit IRC
363 2019-05-30T15:47:30  *** rex4539 has joined #bitcoin-core-dev
364 2019-05-30T15:49:12  *** sfhi2 has joined #bitcoin-core-dev
365 2019-05-30T15:52:25  *** sfhi has quit IRC
366 2019-05-30T16:02:53  *** scoop has joined #bitcoin-core-dev
367 2019-05-30T16:04:33  *** sean8219_ has joined #bitcoin-core-dev
368 2019-05-30T16:07:23  *** scoop has quit IRC
369 2019-05-30T16:11:09  *** Dean_Guss has quit IRC
370 2019-05-30T16:11:32  *** Dean_Guss has joined #bitcoin-core-dev
371 2019-05-30T16:12:08  *** timothy has quit IRC
372 2019-05-30T16:16:46  *** hsmiths has quit IRC
373 2019-05-30T16:19:58  *** scoop has joined #bitcoin-core-dev
374 2019-05-30T16:21:23  *** scoop has quit IRC
375 2019-05-30T16:22:26  *** scoop has joined #bitcoin-core-dev
376 2019-05-30T16:23:51  *** scoop has quit IRC
377 2019-05-30T16:24:07  *** sean8219_ has quit IRC
378 2019-05-30T16:25:49  *** sean8219_ has joined #bitcoin-core-dev
379 2019-05-30T16:25:57  *** scoop has joined #bitcoin-core-dev
380 2019-05-30T16:29:40  *** sean8219_ has quit IRC
381 2019-05-30T16:30:19  *** profmac has quit IRC
382 2019-05-30T16:32:29  *** michaelfolkson has quit IRC
383 2019-05-30T16:36:19  *** jarthur has joined #bitcoin-core-dev
384 2019-05-30T16:39:11  *** cubancorona has quit IRC
385 2019-05-30T16:42:55  <wumpus> ryanofsky: I don't think drahtbot queries/scans the travis logs right now
386 2019-05-30T16:43:42  *** profmac has joined #bitcoin-core-dev
387 2019-05-30T16:44:03  <wumpus> but it's a good topic I think, it definitely seems that travis is overloaded, I'm not sure what changed why it's like that now
388 2019-05-30T17:01:53  *** nullptr| has quit IRC
389 2019-05-30T17:04:23  *** nullptr| has joined #bitcoin-core-dev
390 2019-05-30T17:05:28  *** Chris_Stewart_5 has quit IRC
391 2019-05-30T17:05:36  *** dviola has joined #bitcoin-core-dev
392 2019-05-30T17:20:04  *** scoop has quit IRC
393 2019-05-30T17:21:21  *** siom has quit IRC
394 2019-05-30T17:30:19  *** ossifrage_ has quit IRC
395 2019-05-30T17:30:27  *** ossifrage_ has joined #bitcoin-core-dev
396 2019-05-30T17:35:29  *** scoop has joined #bitcoin-core-dev
397 2019-05-30T17:39:48  *** scoop has quit IRC
398 2019-05-30T17:40:06  *** d_t has joined #bitcoin-core-dev
399 2019-05-30T17:41:35  *** obsrver has quit IRC
400 2019-05-30T17:41:42  *** obsrver has joined #bitcoin-core-dev
401 2019-05-30T17:43:33  *** Karyon has quit IRC
402 2019-05-30T17:43:44  *** Karyon_ has joined #bitcoin-core-dev
403 2019-05-30T17:45:11  *** Karyon_ is now known as Karyon
404 2019-05-30T17:54:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
405 2019-05-30T17:59:40  *** lightlike has joined #bitcoin-core-dev
406 2019-05-30T18:00:01  *** juhp has quit IRC
407 2019-05-30T18:05:44  *** obsrver has quit IRC
408 2019-05-30T18:07:32  *** scoop has joined #bitcoin-core-dev
409 2019-05-30T18:12:16  *** no_cluez has joined #bitcoin-core-dev
410 2019-05-30T18:12:36  *** scoop has quit IRC
411 2019-05-30T18:21:09  *** Dean_Guss has quit IRC
412 2019-05-30T18:25:57  *** scoop has joined #bitcoin-core-dev
413 2019-05-30T18:30:32  *** elichai2 has joined #bitcoin-core-dev
414 2019-05-30T18:47:14  *** ddustin has quit IRC
415 2019-05-30T18:47:32  *** ddustin has joined #bitcoin-core-dev
416 2019-05-30T18:50:27  <fanquake> Are we at the free limit/tier with Travis? I know the idea of adding "another" CI wasn't liked too much, for risk of increasing the size of the slot machine, but if we need more capacity maybe we could look at Circle CI, and be able to add some BSDs while we are at it ?
417 2019-05-30T18:53:13  <wumpus> right, I'd be for adding a CI only if it improves reliability by lowering the load on travis, the reason I'm against it otherwise is exactly that, even more different ways to fail randomly and different buttons to press to respin
418 2019-05-30T19:00:15  <wumpus> #startmeeting
419 2019-05-30T19:00:15  <lightningbot> Meeting started Thu May 30 19:00:15 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
420 2019-05-30T19:00:15  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
421 2019-05-30T19:00:20  <moneyball> hi!
422 2019-05-30T19:00:23  <instagibbs> hi
423 2019-05-30T19:00:25  <jamesob> hi
424 2019-05-30T19:00:31  <meshcollider> hi
425 2019-05-30T19:00:33  <moneyball> https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
426 2019-05-30T19:00:38  <promag> hi
427 2019-05-30T19:00:44  <jnewbery> hi
428 2019-05-30T19:00:47  <jarthur> 'lo
429 2019-05-30T19:00:50  <fanquake> hi
430 2019-05-30T19:01:18  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
431 2019-05-30T19:02:08  <wumpus> any proposed topics? (in addition to moneyball's) ?
432 2019-05-30T19:02:41  <fanquake> Probably any suggestions for short talks at Core Dev? Is there a list of anything like that already?
433 2019-05-30T19:02:49  <instagibbs> kanzure, ^
434 2019-05-30T19:03:31  <fanquake> If so that's fine, let's discuss the other topics.
435 2019-05-30T19:03:58  <moneyball> fanquake be sure to provide kanzure with any topics you'd like to discuss at CoreDev!
436 2019-05-30T19:03:58  <sipa> about to get to the airport, i think we'll have better meeting time in amsterdam
437 2019-05-30T19:04:24  <promag> jarthur:
438 2019-05-30T19:04:25  <wumpus> #topic High priority for review
439 2019-05-30T19:04:29  <promag> (ops)
440 2019-05-30T19:04:48  <wumpus> 5 things on the list now https://github.com/bitcoin/bitcoin/projects/8
441 2019-05-30T19:05:10  *** shesek has quit IRC
442 2019-05-30T19:05:19  <promag> sorry, what is the date for 0.18.1?
443 2019-05-30T19:05:23  <wumpus> anything to add/remove ?
444 2019-05-30T19:05:31  <wumpus> promag: whaa? is 0.18.1 planned at all?
445 2019-05-30T19:05:46  <wumpus> I don't think anything made it necessary yet
446 2019-05-30T19:06:01  <achow101> hi
447 2019-05-30T19:06:10  <fanquake> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.1
448 2019-05-30T19:06:10  *** d_t has quit IRC
449 2019-05-30T19:06:19  <promag> also https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+label%3A%22Needs+backport%22+
450 2019-05-30T19:06:46  <achow101> #15450 for hi prio
451 2019-05-30T19:06:49  <gribble> https://github.com/bitcoin/bitcoin/issues/15450 | [GUI] Create wallet menu option by achow101 · Pull Request #15450 · bitcoin/bitcoin · GitHub
452 2019-05-30T19:07:04  <promag> but nevermind, I got it's too soon
453 2019-05-30T19:07:12  <fanquake> added
454 2019-05-30T19:07:55  <wumpus> absent any really important bug fix I think it's too soon, yes, we don't tend to do a lot of minor releases usually
455 2019-05-30T19:08:23  <fanquake> There's a call for some more review on #15976, has 4 utACKs at the moment (already high-prio).
456 2019-05-30T19:08:26  <gribble> https://github.com/bitcoin/bitcoin/issues/15976 | refactor: move methods under CChainState (pt. 1) by jamesob · Pull Request #15976 · bitcoin/bitcoin · GitHub
457 2019-05-30T19:09:52  <wumpus> okay!
458 2019-05-30T19:10:45  <wumpus> #topic Has travis got worse? (jnewbery)
459 2019-05-30T19:10:54  <wumpus> "has travis got worse or have we just added so many builds to our job that it times out?"
460 2019-05-30T19:11:16  <wumpus> I've wondered this, too, travis has been more unreliable on (PRs at least) than it used to be
461 2019-05-30T19:11:22  <jnewbery> In the last couple of months, *a lot* of travis builds time out
462 2019-05-30T19:11:29  <wumpus> while I don't notice this for local tests
463 2019-05-30T19:11:31  <jamesob> hasn't seemed any worse to me recently, though we've had to rekick certain jobs for months
464 2019-05-30T19:11:41  <jnewbery> I don't know if our builds got slower, travis got slower, or we just added to many jobs for travis to handle
465 2019-05-30T19:11:51  <achow101> a lot of things have been added recently, maybe it's too much for them to handle?
466 2019-05-30T19:11:57  <wumpus> at least we should be careful with making the tests even longer now
467 2019-05-30T19:12:23  <fanquake> Also a lot of depends related PRs timing out recently, but not much that can be done about that.
468 2019-05-30T19:12:24  <instagibbs> There is an element of how Travis is feeling that day
469 2019-05-30T19:12:30  <instagibbs> lots of variance in build times
470 2019-05-30T19:12:47  <wumpus> right, it's very possible that it's not our fault entirely though and it's simply the infrastructure becoming worse
471 2019-05-30T19:13:11  <jnewbery> There are currently 10 different test stages. I know it used to be 6 or 7
472 2019-05-30T19:13:20  <wumpus> I haven't noticed the tests nor builds becoming noticably slower locally
473 2019-05-30T19:13:59  <wumpus> jnewbery: hmm might be time to evaluate whether they're really all contributing something useful
474 2019-05-30T19:14:27  *** promag_ has joined #bitcoin-core-dev
475 2019-05-30T19:14:52  *** spaced0ut has quit IRC
476 2019-05-30T19:14:55  <instagibbs> in elements land we've been having weird issues too that might reflect travis being overly taxed, hard to say
477 2019-05-30T19:15:06  <instagibbs> failure to write to files, that kind of stuff
478 2019-05-30T19:15:27  <promag> best case I usually see is around 20min (for longest job 8)
479 2019-05-30T19:15:36  <jnewbery> I know it runs those test stages in parallel
480 2019-05-30T19:15:38  <wumpus> yes weird stuff happens but I don't think we have that often, it's mostly just timeouts
481 2019-05-30T19:15:40  <luke-jr> instagibbs: does the Elements Travis have caching enabled?
482 2019-05-30T19:15:46  <ryanofsky> are people seeing travis errors other than "Error! Initial build successful..."? This is the only travis error i see and restarting fixes it 100% of the time
483 2019-05-30T19:16:04  <jnewbery> ryanofsky: yes, that's the error
484 2019-05-30T19:16:22  <luke-jr> ryanofsky: I've seen cases where restarting *doesn't* fix it
485 2019-05-30T19:16:22  <instagibbs> ryanofsky, that's when dpeends takes "too long"
486 2019-05-30T19:16:22  <promag> ryanofsky: sometimes I see others and I leave a comment in the PR (before restarting) or create an issue
487 2019-05-30T19:16:24  <instagibbs> and it early exits
488 2019-05-30T19:16:32  <luke-jr> ryanofsky: but they mysteriously resolved before I could troubleshoot :/
489 2019-05-30T19:16:45  <instagibbs> luke-jr, I believe so, the restarting thing fixes  that issue
490 2019-05-30T19:17:08  <jnewbery> The longest running test stage is "sanitizers: address/leak (ASan + LSan) + undefined (UBSan) + integer". I wonder if the same hardware is shared between different test stages and whatever is running at the same time as that one might time out
491 2019-05-30T19:17:10  <wumpus> it *should* be fixed by restarting, that's the point of that message, it's an ugly hack though
492 2019-05-30T19:17:44  <jnewbery> yes, travis is supposed to save developer time, not add an extra step to opening a PR!
493 2019-05-30T19:18:21  <luke-jr> jnewbery: on that note, it's annoying that AppVeyor doesn't use standard build tools, and requires duplicating changes for it
494 2019-05-30T19:18:40  *** jeremyrubin has quit IRC
495 2019-05-30T19:18:56  <meshcollider> Is it possible for a new drahtbot feature to auto-restart builds with that error?
496 2019-05-30T19:19:02  *** promag_ has quit IRC
497 2019-05-30T19:19:11  <achow101> apparently travis switched from docker containers on ec2 to vms on gce late last year, maybe that's related?
498 2019-05-30T19:19:46  <jnewbery> has anyone raised this with travis? We have a paid account, right? Can we try to get support?
499 2019-05-30T19:19:48  <promag> does it run multiple "build depends" with the same conf if needed? sounds unnecessary?
500 2019-05-30T19:21:06  <luke-jr> jnewbery: Travis support is pretty useless in my experience :/
501 2019-05-30T19:21:26  <luke-jr> jnewbery: I expect we'd at the very least need a very specific concern
502 2019-05-30T19:21:47  <jnewbery> luke-jr: support is pretty useless in my experience :/
503 2019-05-30T19:21:50  <wumpus> yes, filing an issue 'it is slow' probably won't do much, I'm sure they get that a lot
504 2019-05-30T19:21:57  <jamesob> circleci (https://circleci.com/) execution is very good in my experience but I am definitely not volunteering to migrate our .travis.yml :)
505 2019-05-30T19:22:22  <wumpus> migrating to another CI would definitely be an option if it's better
506 2019-05-30T19:22:32  <meshcollider> jnewbery: Travis is free for open source projects, we don't pay
507 2019-05-30T19:22:36  <wumpus> (and then I really mean migrating not adding another one)
508 2019-05-30T19:22:48  <luke-jr> meshcollider: we do have a paid account, though
509 2019-05-30T19:22:56  <meshcollider> Oh?
510 2019-05-30T19:23:09  <luke-jr> meshcollider: afaik the Bitcoin Foundation set it up way back when
511 2019-05-30T19:23:09  <jnewbery> well, what's the issue exactly? There's some specific job timout on travis, and so we cancel the build before that timeout to cache whatver has been built already? Can we ask them to increase the job timeout for us?
512 2019-05-30T19:23:27  <jnewbery> I believe we have a paid account so we get more parallel builds
513 2019-05-30T19:23:38  <jnewbery> because we were getting a backlog of PR builds a couple of years ago
514 2019-05-30T19:23:48  <luke-jr> jnewbery: it used to also be required for caches (though I'm not sure if they expanded that to free accounts maybe)
515 2019-05-30T19:23:52  <jamesob> meshcollider: Chaincode starting kicking in for Travis a year and change ago
516 2019-05-30T19:24:02  <jamesob> *started
517 2019-05-30T19:24:39  *** sean8219_ has joined #bitcoin-core-dev
518 2019-05-30T19:24:51  <wumpus> but it didn't use to run into the timeout so often, so it's become slower, that's really the issue, not the timeout itself; increasing the timeout would work, up to a point, but doing that indefinitely makes the testing slower and slower which isn't good either
519 2019-05-30T19:25:30  *** sean8219_ has quit IRC
520 2019-05-30T19:26:15  <wumpus> are we somehow doing more travis builds than before? e.g. how often does drahtbot re-kick builds?
521 2019-05-30T19:26:21  <jnewbery> yeah, someone needs to investigate where the slowness comes from. Is there an API to pull down all the build results from Travis for a project so we can at least get a sense for how often things are failing?
522 2019-05-30T19:26:35  <wumpus> yes, travis has a quite extensive API
523 2019-05-30T19:26:37  <luke-jr> jnewbery: there's certainly an API
524 2019-05-30T19:26:48  <jnewbery> One issue is that restarting a build makes the logs for the failed build unavailable (at least on the website)
525 2019-05-30T19:26:49  <luke-jr> (including one that lets you SSH into the VM)
526 2019-05-30T19:27:16  *** spinza has quit IRC
527 2019-05-30T19:27:36  <wumpus> jnewbery: I don't know if that's the case for the API, or the new log will get a new id
528 2019-05-30T19:27:52  <luke-jr> wumpus: pretty sure it overwrites the existing log
529 2019-05-30T19:28:09  <jamesob> I think there's some amdahl's law at work here though - is speeding up travis really going to make the process materially faster? we're pretty review-bound
530 2019-05-30T19:28:13  <wumpus> ah yes I'm sure too--this is the URL: https://api.travis-ci.org/v3/job/$1/log.txt   it's per job, and it will have the same job id
531 2019-05-30T19:28:35  <wumpus> jamesob: *making it fail less* will lower frustration
532 2019-05-30T19:28:52  <jamesob> wumpus: yeah, agree spurious failures are annoying
533 2019-05-30T19:29:17  <jnewbery> yeah, it's not about how long it takes, it's that if you open a PR, most of the time you'll need to log back in an hour later or more to rekick travis
534 2019-05-30T19:29:18  <wumpus> it's really frustrating if tests fail randomly, if that happens too often people take them less seriously which means actual problems might be ignored
535 2019-05-30T19:29:32  <luke-jr> maybe a flag to tell Travis "updated caches, please restart"?
536 2019-05-30T19:29:40  * luke-jr ponders if the Travis job can call the API to restart itself
537 2019-05-30T19:30:18  <jnewbery> wumpus: exactly that - inconsistently failing builds/tests lower confidence in the product/tests and hide real problems
538 2019-05-30T19:30:19  <luke-jr> wumpus: well, false failures on tests is another issue IMO
539 2019-05-30T19:31:27  <promag> luke-jr: it needs an auth token, not sure if there's a way to set secrets in travis
540 2019-05-30T19:31:45  <jnewbery> luke-jr: that'd be nice, or to get drahtbot to do it, but this is just a variation on the increase timeouts and kick the can down the road, no?
541 2019-05-30T19:32:01  <luke-jr> promag: there is, but it may be a dead idea since the job would still be running :/
542 2019-05-30T19:32:21  <luke-jr> jnewbery: dunno, it might be nice to restart after cache updates regardless
543 2019-05-30T19:32:35  <luke-jr> just to make it more deterministic for the actual tests
544 2019-05-30T19:33:28  <wumpus> #topic GitHub feedback issue (moneyball)
545 2019-05-30T19:33:32  <fanquake> Should we move onto another topic? Seems like the conclusion here is to go away adn investigate Travis/bot/other CI options and discuss in AMS?
546 2019-05-30T19:33:34  <moneyball> hi!
547 2019-05-30T19:33:48  <moneyball> so we have this issue https://github.com/bitcoin/bitcoin/issues/15847
548 2019-05-30T19:33:49  <wumpus> ""please review GitHub feedback issue and vote with thumbs up on issues you think you make the top 10 https://github.com/bitcoin/bitcoin/issues/15847""
549 2019-05-30T19:33:52  <moneyball> with many responses - thank you!
550 2019-05-30T19:34:19  <moneyball> i would like to suggest folks take a look at the issue and "vote" for the ideas that resonate with you by doing a thumbs up
551 2019-05-30T19:34:46  <fanquake> moneyball is there any timeline for when that meetup might happen?
552 2019-05-30T19:34:51  <moneyball> this will help us figure out a top 10 for the CEO lunch, which is now scheduled for june 21, and sipa, cfields, and i plan to attend
553 2019-05-30T19:35:20  <moneyball> we can also review this next week at CoreDev if there is interest
554 2019-05-30T19:35:58  <moneyball> that's all i had to say, unless there are any other questions right now
555 2019-05-30T19:36:20  <sipa> i think it's most useful to talk about issues with are mostly unique to our usage of github
556 2019-05-30T19:36:37  <wumpus> thank you, yes this was expected to be a fairly short topic
557 2019-05-30T19:36:42  <sipa> as i expect that there are a lot of grievances that are mostly shared between projects
558 2019-05-30T19:36:46  <luke-jr> hmm, it'd be nice to use GitHub's code review stuff but also verify the diff against a local git instance somehow
559 2019-05-30T19:37:05  <sipa> probably best to discuss on the issue tracker
560 2019-05-30T19:37:09  <luke-jr> sometimes I review on GitHub, and therefore leave a commithash out of ACKs because I don't know for sure the commithash is what I reviewed
561 2019-05-30T19:37:10  <moneyball> luke-jr please make sure to add your ideas to the github issue
562 2019-05-30T19:37:23  <luke-jr> right, but I don't know if this is even a viable issue to address :p
563 2019-05-30T19:39:09  <wumpus> ok, any other topics?
564 2019-05-30T19:40:24  <wumpus> thanks everyone, see (some of) you next week in Amsterdam
565 2019-05-30T19:40:32  <wumpus> #endmeeting
566 2019-05-30T19:40:32  <lightningbot> Meeting ended Thu May 30 19:40:32 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
567 2019-05-30T19:40:32  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-30-19.00.html
568 2019-05-30T19:40:32  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-30-19.00.txt
569 2019-05-30T19:40:32  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-05-30-19.00.log.html
570 2019-05-30T19:42:21  <luke-jr> I'm probably going to have to miss Amsterdam after all, FWIW
571 2019-05-30T19:42:36  <wumpus> oh :(
572 2019-05-30T19:47:15  *** spinza has joined #bitcoin-core-dev
573 2019-05-30T19:50:20  *** promag_ has joined #bitcoin-core-dev
574 2019-05-30T19:55:53  *** promag_ has quit IRC
575 2019-05-30T20:01:46  *** laptop500 has quit IRC
576 2019-05-30T20:08:47  *** dviola has quit IRC
577 2019-05-30T20:27:43  *** jtimon has joined #bitcoin-core-dev
578 2019-05-30T20:33:00  *** sean8219_ has joined #bitcoin-core-dev
579 2019-05-30T20:34:56  *** lukedashjr has joined #bitcoin-core-dev
580 2019-05-30T20:35:44  *** luke-jr has quit IRC
581 2019-05-30T20:36:29  *** lukedashjr has quit IRC
582 2019-05-30T20:37:29  <instagibbs> CScript(byte_vector) vs CScript(byte_vector.begin(), byte_vector.end()) whyyyy
583 2019-05-30T20:38:07  <gwillen> I suspect because certain overloads didn't used to exist or something
584 2019-05-30T20:38:16  *** Chris_Stewart_5 has quit IRC
585 2019-05-30T20:39:36  <instagibbs> I don't think anyone actually tries using the former?
586 2019-05-30T20:39:42  *** luke-jr has joined #bitcoin-core-dev
587 2019-05-30T20:39:52  <instagibbs> intentionally*
588 2019-05-30T20:40:10  *** elichai2 has quit IRC
589 2019-05-30T20:40:19  <kanzure> also, i'm still seeking topics for amsterdam meeting
590 2019-05-30T20:40:26  <instagibbs> just my nth time running into it, in case my annoyance is justified
591 2019-05-30T20:40:37  <kanzure> and also, does anyone want to take over luke-jr things and be a substitute luke-jr?
592 2019-05-30T20:41:10  <gwillen> instagibbs: wait I'm confused now, which of these do you consider preferable
593 2019-05-30T20:41:25  <gwillen> I can't tell why you'd ever want to use the longer form
594 2019-05-30T20:41:27  <instagibbs> gwillen, the former gives you a script with the first byte being the size of the vector, IIRC
595 2019-05-30T20:41:36  <instagibbs> the latter gives you what you'd expect :D
596 2019-05-30T20:41:42  <gwillen> oh, that seems like a horrifying bug that should be fixed
597 2019-05-30T20:41:50  <instagibbs> CScript is a prevectoryadayada
598 2019-05-30T20:42:06  *** scoop has quit IRC
599 2019-05-30T20:42:18  *** luke-jr has quit IRC
600 2019-05-30T20:42:34  *** scoop has joined #bitcoin-core-dev
601 2019-05-30T20:42:53  *** luke-jr has joined #bitcoin-core-dev
602 2019-05-30T20:43:18  <gwillen> it's not even clear to me how that would happen
603 2019-05-30T20:43:59  <sipa> gwillen: CScript(vector) is the same as CScript() << vector
604 2019-05-30T20:44:50  *** scoop has quit IRC
605 2019-05-30T20:44:58  *** scoop has joined #bitcoin-core-dev
606 2019-05-30T20:45:11  <sipa> it's the script that consists of pushing vector onto the stack
607 2019-05-30T20:45:30  <sipa> the confusion is because CScript (used to be) a subclass of vector
608 2019-05-30T20:45:51  <sipa> so CScript(script) would be the script that pushes script onto the stack
609 2019-05-30T20:46:54  *** sean8219_ has quit IRC
610 2019-05-30T20:49:33  *** luke-jr has quit IRC
611 2019-05-30T20:50:21  *** luke-jr has joined #bitcoin-core-dev
612 2019-05-30T20:51:18  *** sean8219_ has joined #bitcoin-core-dev
613 2019-05-30T20:54:35  *** sean8219_ has joined #bitcoin-core-dev
614 2019-05-30T21:00:02  *** no_cluez has quit IRC
615 2019-05-30T21:05:19  *** pwgn has joined #bitcoin-core-dev
616 2019-05-30T21:12:01  *** brianhoffman_ has joined #bitcoin-core-dev
617 2019-05-30T21:12:57  *** scoop has quit IRC
618 2019-05-30T21:14:05  *** brianhoffman has quit IRC
619 2019-05-30T21:16:15  *** rex4539 has quit IRC
620 2019-05-30T21:16:35  *** scoop has joined #bitcoin-core-dev
621 2019-05-30T21:23:23  *** d_t has joined #bitcoin-core-dev
622 2019-05-30T21:34:16  <gwillen> mmm, that seems really confusing and errorprone
623 2019-05-30T21:35:07  <sipa> gwillen: yes
624 2019-05-30T21:35:39  <sipa> i've tried to touch the CScript API once and almost introduced a consensus bug
625 2019-05-30T21:35:44  <gwillen> ahhhhhhh, heh. I see.
626 2019-05-30T21:36:13  <gwillen> are those constructors ever used intentionally, do you know?
627 2019-05-30T21:36:27  <gwillen> (specifically the ones I would describe as ambiguous, and used directly and not via << or the like)
628 2019-05-30T21:36:47  <sipa> if they're actually unused we should just get rid of them
629 2019-05-30T21:37:08  <sipa> feel free to try and remove them, but i suspect we'd have caught them already
630 2019-05-30T21:37:42  <gwillen> yeah, understood, I am going to go poke around but you've made me afraid to touch it much now ;-)
631 2019-05-30T21:37:49  <sipa> i also don't want to imply we're forever stuck with this confusing convention; just that yoi really need to be careful about it
632 2019-05-30T21:38:09  <gwillen> yeah, that makes total sense and I appreciate the clarification
633 2019-05-30T21:38:46  * sipa ✈️
634 2019-05-30T21:40:08  *** sean8219_ has joined #bitcoin-core-dev
635 2019-05-30T21:40:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
636 2019-05-30T21:41:57  <jarthur> Have fun out there, everyone.
637 2019-05-30T21:43:09  *** ghost43_ has joined #bitcoin-core-dev
638 2019-05-30T21:43:27  *** ghost43 has quit IRC
639 2019-05-30T21:45:12  *** sean8219_ has quit IRC
640 2019-05-30T21:53:16  *** scoop has quit IRC
641 2019-05-30T21:55:43  *** Guyver2 has quit IRC
642 2019-05-30T21:57:42  *** ddustin has quit IRC
643 2019-05-30T21:58:30  *** ddustin has joined #bitcoin-core-dev
644 2019-05-30T21:59:12  *** jarthur_ has joined #bitcoin-core-dev
645 2019-05-30T22:01:58  *** jarthur has quit IRC
646 2019-05-30T22:02:46  *** ctrlbreak has quit IRC
647 2019-05-30T22:03:29  *** jarthur_ has quit IRC
648 2019-05-30T22:07:37  *** spinza has quit IRC
649 2019-05-30T22:10:09  *** sfhi2 has quit IRC
650 2019-05-30T22:12:35  *** sean8219_ has joined #bitcoin-core-dev
651 2019-05-30T22:13:20  *** ddustin has quit IRC
652 2019-05-30T22:13:34  *** ddustin has joined #bitcoin-core-dev
653 2019-05-30T22:14:00  *** ddustin has quit IRC
654 2019-05-30T22:14:01  *** sean8219_ has quit IRC
655 2019-05-30T22:14:45  *** ddustin has joined #bitcoin-core-dev
656 2019-05-30T22:15:57  *** ddustin has joined #bitcoin-core-dev
657 2019-05-30T22:22:20  *** siom has joined #bitcoin-core-dev
658 2019-05-30T22:30:57  *** ctrlbreak has joined #bitcoin-core-dev
659 2019-05-30T22:48:43  *** Zenton has quit IRC
660 2019-05-30T22:51:14  *** michaelsdunn1 has quit IRC
661 2019-05-30T23:00:22  *** spinza has joined #bitcoin-core-dev
662 2019-05-30T23:04:33  *** jonatack has quit IRC
663 2019-05-30T23:08:30  *** ccdle12 has joined #bitcoin-core-dev
664 2019-05-30T23:14:46  *** ddustin has quit IRC
665 2019-05-30T23:15:26  *** ddustin has joined #bitcoin-core-dev
666 2019-05-30T23:22:30  *** davterra has joined #bitcoin-core-dev
667 2019-05-30T23:22:32  *** Zenton has joined #bitcoin-core-dev
668 2019-05-30T23:23:03  *** scoop has joined #bitcoin-core-dev
669 2019-05-30T23:24:30  *** Chris_Stewart_5 has quit IRC
670 2019-05-30T23:25:13  *** lnostdal has quit IRC
671 2019-05-30T23:31:21  *** jeremyrubin has joined #bitcoin-core-dev
672 2019-05-30T23:31:58  *** lightlike has quit IRC
673 2019-05-30T23:36:54  *** ctrlbreak has quit IRC
674 2019-05-30T23:46:12  *** lnostdal has joined #bitcoin-core-dev
675 2019-05-30T23:52:54  *** promag_ has joined #bitcoin-core-dev
676 2019-05-30T23:57:54  *** promag_ has quit IRC