12019-06-13T00:00:02  *** toresbe1 has quit IRC
  22019-06-13T00:05:27  *** Chris_Stewart_5 has quit IRC
  32019-06-13T00:06:53  *** scoop has quit IRC
  42019-06-13T00:08:56  *** scoop has joined #bitcoin-core-dev
  52019-06-13T00:12:59  *** scoop has quit IRC
  62019-06-13T00:13:25  *** scoop has joined #bitcoin-core-dev
  72019-06-13T00:14:31  *** scoop has quit IRC
  82019-06-13T00:14:37  *** scoop has joined #bitcoin-core-dev
  92019-06-13T00:18:58  *** Wayno has joined #bitcoin-core-dev
 102019-06-13T00:23:21  *** Jason has joined #bitcoin-core-dev
 112019-06-13T00:23:39  *** jb55 has quit IRC
 122019-06-13T00:23:44  *** Jason is now known as Guest56090
 132019-06-13T00:41:59  *** promag_ has quit IRC
 142019-06-13T00:42:18  *** promag has quit IRC
 152019-06-13T00:42:46  *** fjahr has quit IRC
 162019-06-13T00:49:00  <sipa> jonasschnelli: seems reasonable
 172019-06-13T00:49:41  *** pinheadmz has quit IRC
 182019-06-13T00:50:19  *** jarthur has joined #bitcoin-core-dev
 192019-06-13T00:55:04  *** jarthur has quit IRC
 202019-06-13T00:56:12  *** taron has joined #bitcoin-core-dev
 212019-06-13T00:56:48  *** gacky has joined #bitcoin-core-dev
 222019-06-13T00:57:29  <sipa> i may not be around for the meeting tomorrow, but BlueMatt suggested earlier that maybe instead of using /16 groups for the IP range "groups" (which affect outgoing connections, and addrman bucketing), we could use actual AS numbers (the identifiers of the autonomous networks which can assign IP addresses)
 232019-06-13T00:58:55  <sipa> so i spent some time coming up with a compact encoding for a table with all AS numbers, and it seems a binary trie that's stored as a concatenation of variable-length integers with byte offset jumps can encode the whole thing (IPv4 and IPv6) in about 2 MB
 242019-06-13T00:59:20  <sipa> does that seem like a reasonable thing to build into bitcoind, or ship as a file along with it?
 252019-06-13T01:00:47  <sipa> if too large, we could of course approximate things by merging adjacent tiny IP ranges
 262019-06-13T01:01:07  *** gacky has quit IRC
 272019-06-13T01:03:44  *** Evel-Knievel has quit IRC
 282019-06-13T01:04:12  *** Evel-Knievel has joined #bitcoin-core-dev
 292019-06-13T01:27:08  *** taron has quit IRC
 302019-06-13T01:34:10  <phantomcircuit> sipa, where would you get the as information?
 312019-06-13T01:34:29  *** pinheadmz has joined #bitcoin-core-dev
 322019-06-13T01:36:11  <sipa> phantomcircuit: BlueMatt
 332019-06-13T01:38:40  <phantomcircuit> BlueMatt, ^
 342019-06-13T01:40:30  *** itsiku has quit IRC
 352019-06-13T01:47:18  *** itsiku has joined #bitcoin-core-dev
 362019-06-13T01:54:49  *** pinheadmz has quit IRC
 372019-06-13T01:58:41  *** fjahr has joined #bitcoin-core-dev
 382019-06-13T02:16:13  *** harding has quit IRC
 392019-06-13T02:19:00  *** harding has joined #bitcoin-core-dev
 402019-06-13T02:27:14  *** pinheadmz has joined #bitcoin-core-dev
 412019-06-13T02:50:29  *** Guest56090 has quit IRC
 422019-06-13T02:50:51  *** cubancorona has quit IRC
 432019-06-13T02:51:12  *** cubancorona has joined #bitcoin-core-dev
 442019-06-13T02:51:48  *** pinheadmz has quit IRC
 452019-06-13T02:59:30  *** spinza has quit IRC
 462019-06-13T03:00:02  *** Wayno has quit IRC
 472019-06-13T03:02:39  *** DeanWeen has joined #bitcoin-core-dev
 482019-06-13T03:03:31  *** ffej has joined #bitcoin-core-dev
 492019-06-13T03:04:04  *** elichai2 has quit IRC
 502019-06-13T03:07:32  *** spinza has joined #bitcoin-core-dev
 512019-06-13T03:14:52  *** pinheadmz has joined #bitcoin-core-dev
 522019-06-13T03:15:38  *** jb55 has joined #bitcoin-core-dev
 532019-06-13T03:21:09  *** d_t has quit IRC
 542019-06-13T03:24:30  <midnightmagic> just a snapshot of the current bgp routing table aint it
 552019-06-13T03:25:19  *** bitcoin-git has joined #bitcoin-core-dev
 562019-06-13T03:25:19  <bitcoin-git> [bitcoin] shannon1916 opened pull request #16199: rpc: fix showing wrong amount when not all inputs are from me in gettransaction (master...master) https://github.com/bitcoin/bitcoin/pull/16199
 572019-06-13T03:25:22  *** bitcoin-git has left #bitcoin-core-dev
 582019-06-13T03:30:15  *** pinheadmz has quit IRC
 592019-06-13T03:41:48  *** pinheadmz has joined #bitcoin-core-dev
 602019-06-13T03:43:07  *** pinheadmz has quit IRC
 612019-06-13T03:55:04  *** scoop has quit IRC
 622019-06-13T04:01:12  *** jcorgan has quit IRC
 632019-06-13T04:17:28  *** ppisati has quit IRC
 642019-06-13T04:22:07  *** ddustin has joined #bitcoin-core-dev
 652019-06-13T04:24:08  *** ppisati has joined #bitcoin-core-dev
 662019-06-13T04:26:53  <sipa> midnightmagic: yeah
 672019-06-13T04:41:24  <midnightmagic> a feed of bgp routing changes might be helpful on its own for checking connection flapping -- and especially bgp hijack detection
 682019-06-13T04:41:29  *** jb55 has quit IRC
 692019-06-13T04:41:59  <midnightmagic> there's a twitter account that publishes such things too, it's pretty eye-popping the AS who end up stealing other peoples' AS.
 702019-06-13T04:43:50  <midnightmagic> https://twitter.com/bgpstream  <-- there, that one.  crazy!
 712019-06-13T04:44:41  <midnightmagic> Its AS database isn't updated though so sometimes it looks like nobody hijacked anything but of course, it ends up being like telstra hijacking like .. Comcast or something
 722019-06-13T04:51:08  *** jarthur has joined #bitcoin-core-dev
 732019-06-13T04:55:28  *** scoop has joined #bitcoin-core-dev
 742019-06-13T04:55:55  *** jarthur has quit IRC
 752019-06-13T04:59:37  *** scoop has quit IRC
 762019-06-13T05:21:40  *** pinheadmz has joined #bitcoin-core-dev
 772019-06-13T05:30:17  *** ddustin has quit IRC
 782019-06-13T05:34:53  *** michaelfolkson has joined #bitcoin-core-dev
 792019-06-13T05:41:05  *** ddustin has joined #bitcoin-core-dev
 802019-06-13T05:48:36  *** ddustin has quit IRC
 812019-06-13T05:48:55  *** ddustin has joined #bitcoin-core-dev
 822019-06-13T06:00:01  *** ffej has quit IRC
 832019-06-13T06:05:04  *** Sho_1 has joined #bitcoin-core-dev
 842019-06-13T06:05:54  *** michaelfolkson has quit IRC
 852019-06-13T06:10:06  *** michaelfolkson has joined #bitcoin-core-dev
 862019-06-13T06:10:52  *** michaelfolkson has quit IRC
 872019-06-13T06:28:57  *** d_t has joined #bitcoin-core-dev
 882019-06-13T06:29:24  *** muoi has joined #bitcoin-core-dev
 892019-06-13T06:30:35  *** d_t has quit IRC
 902019-06-13T07:00:26  *** muoi has quit IRC
 912019-06-13T07:07:15  *** michaelfolkson has joined #bitcoin-core-dev
 922019-06-13T07:17:51  *** rafalcpp_ has joined #bitcoin-core-dev
 932019-06-13T07:17:52  *** queip has quit IRC
 942019-06-13T07:18:38  *** rafalcpp has quit IRC
 952019-06-13T07:23:21  *** queip has joined #bitcoin-core-dev
 962019-06-13T07:27:38  *** michaelfolkson has quit IRC
 972019-06-13T07:29:27  *** gabuqo has joined #bitcoin-core-dev
 982019-06-13T07:32:01  *** EagleTM has joined #bitcoin-core-dev
 992019-06-13T07:33:11  *** davterra has quit IRC
1002019-06-13T07:36:35  *** DeanWeen has quit IRC
1012019-06-13T07:43:27  *** ddustin has quit IRC
1022019-06-13T07:48:17  *** ddustin has joined #bitcoin-core-dev
1032019-06-13T07:49:40  *** booyah has quit IRC
1042019-06-13T07:53:12  *** kljasdfvv has joined #bitcoin-core-dev
1052019-06-13T08:05:37  *** jb55 has joined #bitcoin-core-dev
1062019-06-13T08:06:31  *** ddustin has quit IRC
1072019-06-13T08:06:58  *** ddustin has joined #bitcoin-core-dev
1082019-06-13T08:07:23  *** rafalcpp_ has quit IRC
1092019-06-13T08:07:38  *** rafalcpp_ has joined #bitcoin-core-dev
1102019-06-13T08:07:42  *** queip has quit IRC
1112019-06-13T08:07:51  *** ddustin has quit IRC
1122019-06-13T08:08:16  *** ddustin has joined #bitcoin-core-dev
1132019-06-13T08:09:00  *** ddustin has joined #bitcoin-core-dev
1142019-06-13T08:09:06  *** gabuqo has quit IRC
1152019-06-13T08:09:23  *** ddustin has quit IRC
1162019-06-13T08:11:32  *** setpill has joined #bitcoin-core-dev
1172019-06-13T08:12:49  *** queip has joined #bitcoin-core-dev
1182019-06-13T08:16:15  *** ddustin has joined #bitcoin-core-dev
1192019-06-13T08:21:15  *** ddustin has quit IRC
1202019-06-13T08:25:25  *** ddustin has joined #bitcoin-core-dev
1212019-06-13T08:26:06  *** bitcoin-git has joined #bitcoin-core-dev
1222019-06-13T08:26:07  <bitcoin-git> [bitcoin] laanwj opened pull request #16201: devtools: Always use unabbreviated commit IDs in github-merge.py (master...2019_06_ghmerge_unabbrev) https://github.com/bitcoin/bitcoin/pull/16201
1232019-06-13T08:26:20  *** bitcoin-git has left #bitcoin-core-dev
1242019-06-13T08:29:20  *** EagleTM has quit IRC
1252019-06-13T08:30:12  *** ddustin has quit IRC
1262019-06-13T08:32:52  *** jimmysong_ has joined #bitcoin-core-dev
1272019-06-13T08:35:25  *** jimmysong has quit IRC
1282019-06-13T08:45:47  *** justanotheruser has quit IRC
1292019-06-13T08:47:01  *** promag has joined #bitcoin-core-dev
1302019-06-13T08:47:19  *** promag has joined #bitcoin-core-dev
1312019-06-13T08:48:54  *** bitcoin-git has joined #bitcoin-core-dev
1322019-06-13T08:48:54  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f792395d13aa...afab1312c5e1
1332019-06-13T08:48:55  <bitcoin-git> bitcoin/master 75485ef João Barbosa: gui: Enable open wallet menu on setWalletController
1342019-06-13T08:48:55  <bitcoin-git> bitcoin/master afab131 fanquake: Merge #16118: gui: Enable open wallet menu on setWalletController
1352019-06-13T08:49:07  *** bitcoin-git has left #bitcoin-core-dev
1362019-06-13T08:50:05  *** bitcoin-git has joined #bitcoin-core-dev
1372019-06-13T08:50:05  <bitcoin-git> [bitcoin] fanquake merged pull request #16118: gui: Enable open wallet menu on setWalletController (master...2019-05-null-walletcontroller) https://github.com/bitcoin/bitcoin/pull/16118
1382019-06-13T08:50:06  *** bitcoin-git has left #bitcoin-core-dev
1392019-06-13T08:51:48  *** jarthur has joined #bitcoin-core-dev
1402019-06-13T08:56:09  *** jarthur has quit IRC
1412019-06-13T09:00:02  *** Sho_1 has quit IRC
1422019-06-13T09:00:16  <promag> fanquake: first?
1432019-06-13T09:00:38  <fanquake> promag yes
1442019-06-13T09:00:44  <promag> \o/
1452019-06-13T09:01:12  *** AaronvanW has joined #bitcoin-core-dev
1462019-06-13T09:03:08  *** ddustin has joined #bitcoin-core-dev
1472019-06-13T09:05:03  *** kcomandich1 has joined #bitcoin-core-dev
1482019-06-13T09:07:33  *** ddustin has quit IRC
1492019-06-13T09:11:26  *** ddustin has joined #bitcoin-core-dev
1502019-06-13T09:14:12  *** cubancorona has quit IRC
1512019-06-13T09:14:32  *** cubancorona has joined #bitcoin-core-dev
1522019-06-13T09:16:28  *** ddustin has quit IRC
1532019-06-13T09:18:14  <meshcollider> \o/
1542019-06-13T09:20:25  *** ddustin has joined #bitcoin-core-dev
1552019-06-13T09:23:10  *** timothy has joined #bitcoin-core-dev
1562019-06-13T09:24:37  *** ddustin has quit IRC
1572019-06-13T09:29:30  *** ddustin has joined #bitcoin-core-dev
1582019-06-13T09:30:43  *** jtimon has joined #bitcoin-core-dev
1592019-06-13T09:34:02  *** ddustin has quit IRC
1602019-06-13T09:38:36  *** ddustin has joined #bitcoin-core-dev
1612019-06-13T09:42:57  *** ddustin has quit IRC
1622019-06-13T09:45:25  <jonasschnelli> fanquake: \o/!
1632019-06-13T09:50:00  *** darosior has joined #bitcoin-core-dev
1642019-06-13T09:54:29  *** gabuqo has joined #bitcoin-core-dev
1652019-06-13T09:55:58  *** phwalkr has joined #bitcoin-core-dev
1662019-06-13T10:00:09  *** bitcoin-git has joined #bitcoin-core-dev
1672019-06-13T10:00:10  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #16202: Refactor network message deserialization  (master...2019/06/net_refactor_1) https://github.com/bitcoin/bitcoin/pull/16202
1682019-06-13T10:00:18  *** bitcoin-git has left #bitcoin-core-dev
1692019-06-13T10:03:32  *** spinza has quit IRC
1702019-06-13T10:05:28  *** gabuqo has quit IRC
1712019-06-13T10:06:14  *** phwalkr_ has joined #bitcoin-core-dev
1722019-06-13T10:07:13  *** phwalkr has quit IRC
1732019-06-13T10:08:33  *** phwalkr has joined #bitcoin-core-dev
1742019-06-13T10:10:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1752019-06-13T10:11:34  *** phwalkr_ has quit IRC
1762019-06-13T10:17:32  *** rafalcpp has joined #bitcoin-core-dev
1772019-06-13T10:17:53  *** ddustin has joined #bitcoin-core-dev
1782019-06-13T10:17:57  *** queip has quit IRC
1792019-06-13T10:17:57  *** rafalcpp_ has quit IRC
1802019-06-13T10:22:01  *** spinza has joined #bitcoin-core-dev
1812019-06-13T10:22:56  *** ddustin has quit IRC
1822019-06-13T10:24:04  *** queip has joined #bitcoin-core-dev
1832019-06-13T10:31:11  *** darosior has quit IRC
1842019-06-13T10:32:13  *** rafalcpp has quit IRC
1852019-06-13T10:32:58  *** rafalcpp has joined #bitcoin-core-dev
1862019-06-13T10:34:48  *** siom has joined #bitcoin-core-dev
1872019-06-13T10:39:20  *** bitcoin-git has joined #bitcoin-core-dev
1882019-06-13T10:39:21  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/be92be5644a7...9c29bc71dc40
1892019-06-13T10:39:21  <bitcoin-git> bitcoin/0.18 206c30f MarcoFalke: dummywallet: Reformat ignored wallet options list
1902019-06-13T10:39:22  <bitcoin-git> bitcoin/0.18 106471d Luke Dashjr: Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet op...
1912019-06-13T10:39:22  <bitcoin-git> bitcoin/0.18 9c29bc7 Wladimir J. van der Laan: Merge #16189: 0.18: Backport "Add -ignorepartialspends to list of ignored ...
1922019-06-13T10:39:23  *** bitcoin-git has left #bitcoin-core-dev
1932019-06-13T10:39:40  *** bitcoin-git has joined #bitcoin-core-dev
1942019-06-13T10:39:41  <bitcoin-git> [bitcoin] laanwj merged pull request #16189: 0.18: Backport "Add -ignorepartialspends to list of ignored wallet options" (0.18...1906-18Backport) https://github.com/bitcoin/bitcoin/pull/16189
1952019-06-13T10:39:42  *** bitcoin-git has left #bitcoin-core-dev
1962019-06-13T10:48:39  <wumpus> so many PRs failing travis again
1972019-06-13T10:49:07  <wumpus> there should be zero reason for a PR like #16188 to fail travis, it just adds a few comments
1982019-06-13T10:49:08  <gribble> https://github.com/bitcoin/bitcoin/issues/16188 | net: Document what happens to getdata of unknown type by MarcoFalke · Pull Request #16188 · bitcoin/bitcoin · GitHub
1992019-06-13T10:50:18  <wumpus> it has such a long build log that I don't even know what fails
2002019-06-13T10:51:48  <fanquake> it'll likely be just after building zmq in depends
2012019-06-13T10:52:40  <wumpus> it's like travis stopped caching some of our results, forcing a rebuild
2022019-06-13T10:52:41  <promag> the cache is per PR?
2032019-06-13T10:53:10  <fanquake> wumpus here's the end of the log: https://gist.github.com/fanquake/e04e7c1e02e5e6363fd0c1e1abb20b8a
2042019-06-13T10:53:14  <wumpus> promag: it is, though the initial build uses the cache for the branch (at least I hope so)
2052019-06-13T10:53:25  <wumpus> it *used to*
2062019-06-13T10:53:49  <wumpus> but I'm starting to think something changed in regard to caching
2072019-06-13T10:55:02  <wumpus> fanquake: ahh so it's another case of "Initial build successful, but not enough time remains ..." I wish that was displayed at the top instead
2082019-06-13T10:56:46  *** scoop has joined #bitcoin-core-dev
2092019-06-13T10:58:16  *** bitcoin-git has joined #bitcoin-core-dev
2102019-06-13T10:58:18  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.17: https://github.com/bitcoin/bitcoin/compare/6cf81b01b48e...c165df198d6e
2112019-06-13T10:58:19  <bitcoin-git> bitcoin/0.17 05fb9f7 MarcoFalke: build with -fstack-reuse=none
2122019-06-13T10:58:20  <bitcoin-git> bitcoin/0.17 b5a4abe Pieter Wuille: Add test for GCC bug 90348
2132019-06-13T10:58:22  <bitcoin-git> bitcoin/0.17 c165df1 Wladimir J. van der Laan: Merge #16163: 0.17.2 backport: build with -fstack-reuse=none  and test cas...
2142019-06-13T10:58:23  *** bitcoin-git has left #bitcoin-core-dev
2152019-06-13T10:58:41  *** bitcoin-git has joined #bitcoin-core-dev
2162019-06-13T10:58:41  <bitcoin-git> [bitcoin] laanwj merged pull request #16163: 0.17.2 backport: build with -fstack-reuse=none  and test case (0.17...backport_stack_reuse_none_017) https://github.com/bitcoin/bitcoin/pull/16163
2172019-06-13T10:58:42  *** bitcoin-git has left #bitcoin-core-dev
2182019-06-13T11:01:20  *** scoop has quit IRC
2192019-06-13T11:02:38  *** ddustin has joined #bitcoin-core-dev
2202019-06-13T11:07:07  *** ddustin has quit IRC
2212019-06-13T11:08:07  <promag> MarcoFalke: thanks for the backport
2222019-06-13T11:12:06  *** ddustin has joined #bitcoin-core-dev
2232019-06-13T11:16:12  *** darosior has joined #bitcoin-core-dev
2242019-06-13T11:17:20  *** ddustin has quit IRC
2252019-06-13T11:21:02  *** ddustin has joined #bitcoin-core-dev
2262019-06-13T11:26:15  *** ddustin has quit IRC
2272019-06-13T11:27:46  <jonasschnelli> #proposedmeetingtopic travis stability and usefulness in current state
2282019-06-13T11:28:22  *** queip has quit IRC
2292019-06-13T11:28:25  *** rafalcpp has quit IRC
2302019-06-13T11:28:43  *** rafalcpp has joined #bitcoin-core-dev
2312019-06-13T11:28:55  *** ddustin has joined #bitcoin-core-dev
2322019-06-13T11:33:22  *** ddustin has quit IRC
2332019-06-13T11:34:32  *** queip has joined #bitcoin-core-dev
2342019-06-13T11:35:21  *** bitcoin-git has joined #bitcoin-core-dev
2352019-06-13T11:35:22  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/afab1312c5e1...431d81b61ca9
2362019-06-13T11:35:23  <bitcoin-git> bitcoin/master 97f517d Jonas Schnelli: Fix RPC/pruneblockchain returned prune height
2372019-06-13T11:35:23  <bitcoin-git> bitcoin/master f402012 João Barbosa: fixup: Fix prunning test
2382019-06-13T11:35:24  <bitcoin-git> bitcoin/master 431d81b Jonas Schnelli: Merge #15991: Bugfix: fix pruneblockchain returned prune height
2392019-06-13T11:35:25  *** bitcoin-git has left #bitcoin-core-dev
2402019-06-13T11:35:56  *** promag has quit IRC
2412019-06-13T11:36:00  *** omonk has quit IRC
2422019-06-13T11:36:15  *** bitcoin-git has joined #bitcoin-core-dev
2432019-06-13T11:36:15  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #15991: Bugfix: fix pruneblockchain returned prune height (master...2019/05/pruning_test) https://github.com/bitcoin/bitcoin/pull/15991
2442019-06-13T11:36:28  *** bitcoin-git has left #bitcoin-core-dev
2452019-06-13T11:37:45  *** omonk has joined #bitcoin-core-dev
2462019-06-13T11:38:22  *** Chris_Stewart_5 has quit IRC
2472019-06-13T11:40:54  <jonasschnelli> sipa, MarcoFalke: you commented on https://github.com/bitcoin/bitcoin/pull/15615 . Would appreciate closing the review by NACK/ACK/comment.
2482019-06-13T11:48:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2492019-06-13T11:49:51  *** michaelfolkson has joined #bitcoin-core-dev
2502019-06-13T11:55:55  *** michaelfolkson has quit IRC
2512019-06-13T11:59:26  *** michaelfolkson has joined #bitcoin-core-dev
2522019-06-13T11:59:51  *** promag has joined #bitcoin-core-dev
2532019-06-13T12:00:01  *** kcomandich1 has quit IRC
2542019-06-13T12:01:36  *** justanotheruser has joined #bitcoin-core-dev
2552019-06-13T12:02:32  *** Chris_Stewart_5 has quit IRC
2562019-06-13T12:04:23  *** Dragavnir has joined #bitcoin-core-dev
2572019-06-13T12:10:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2582019-06-13T12:12:47  <MarcoFalke> So why are we using tinyformat for printf, but not for fprintf et al?
2592019-06-13T12:13:31  <MarcoFalke> Also, it seems like we might not be using tinyformat at all, since it depends on include order what the symbol refers to, no?
2602019-06-13T12:14:15  *** ddustin has joined #bitcoin-core-dev
2612019-06-13T12:16:10  <MarcoFalke> re travis: I have deleted all caches on travis
2622019-06-13T12:16:23  <MarcoFalke> It can't get any worse than now
2632019-06-13T12:16:24  <jonasschnelli> I think we just use it for log printing,.. right?
2642019-06-13T12:17:08  <MarcoFalke> Yeah, why. Why not for printing to a file handle
2652019-06-13T12:17:20  <MarcoFalke> stdout or whatever
2662019-06-13T12:17:39  <jonasschnelli> Maybe due to security/stability concerns? but probably not
2672019-06-13T12:18:43  <wumpus> tinyformat should ideally be used for everything, but at the moment it's used for 1) formatting to strings (strprintf) 2) log formatting
2682019-06-13T12:19:23  <wumpus> (LogPrint / LogPrintf)
2692019-06-13T12:19:48  <MarcoFalke> it is also used for some printf, depending on include order
2702019-06-13T12:19:52  <wumpus> I strongly disagree with "we might not be using tinyformat at all", in contrast to libc printf implementations, tinyformat is type safe
2712019-06-13T12:19:55  <MarcoFalke> since the tinyformat header has a printf in it
2722019-06-13T12:20:31  <MarcoFalke> I meant "we might not be using tinyformat *accidentally* at all"
2732019-06-13T12:20:39  <wumpus> we had some really awful problems with platform libc implementations (esp windows), with regards to strings, locale, even formatting 64 bit integers, there's no way we're going back to that
2742019-06-13T12:20:44  <wumpus> ooh
2752019-06-13T12:20:51  <MarcoFalke> because it might depend on include order
2762019-06-13T12:21:01  <wumpus> is bare 'printf' used anywhere?
2772019-06-13T12:21:06  <wumpus> it shouldn't really be
2782019-06-13T12:21:25  <jonasschnelli> I don't think we use bar printf anywhere
2792019-06-13T12:21:30  <jonasschnelli> (expect ctaes bench)
2802019-06-13T12:21:46  <MarcoFalke> oh, yeah
2812019-06-13T12:21:52  <MarcoFalke> But we use fprintf
2822019-06-13T12:21:52  *** ddustin has quit IRC
2832019-06-13T12:21:53  <jonasschnelli> *except
2842019-06-13T12:22:06  <wumpus> (it's kind of useless as stdout might be redirected to nowhere, ther's some fprintf(stderr, ) where we're sure it's before the daemonize I guess, would be OK with replacing those with something that uses tinyformat)
2852019-06-13T12:22:34  <wumpus> but please don't redefine fprintf for that but define a new function
2862019-06-13T12:22:40  *** emilengler has joined #bitcoin-core-dev
2872019-06-13T12:22:45  <MarcoFalke> ok, makes sense
2882019-06-13T12:23:29  <wumpus> it's kind of bizarre that tinyformat redefines printf
2892019-06-13T12:24:26  <wumpus> I think you have agood point in that
2902019-06-13T12:24:35  <wumpus> we definitely should avoid using that one
2912019-06-13T12:24:42  <jonasschnelli> "Tinyformat: A minimal type safe printf replacement"
2922019-06-13T12:24:43  <MarcoFalke> Yeah, I was really confused when reading through all this after I had issues with the %zu format specifier on windows
2932019-06-13T12:25:08  <MarcoFalke> I dig all the way to #326 :(
2942019-06-13T12:25:09  <wumpus> jonasschnelli: yes, that doesn't mean the function has to be called that :)
2952019-06-13T12:25:12  <gribble> https://github.com/bitcoin/bitcoin/issues/326 | Remove the IRC triggered hard last-seen check from the peer selection. by gmaxwell · Pull Request #326 · bitcoin/bitcoin · GitHub
2962019-06-13T12:25:17  <jonasschnelli> heh.. indeed
2972019-06-13T12:25:22  <MarcoFalke> Eh https://github.com/libevent/libevent/issues/326
2982019-06-13T12:25:55  <MarcoFalke> Which is #8730
2992019-06-13T12:25:56  <wumpus> yes, please don't use platform printf
3002019-06-13T12:25:57  <gribble> https://github.com/bitcoin/bitcoin/issues/8730 | depends: Add libevent compatibility patch for windows by laanwj · Pull Request #8730 · bitcoin/bitcoin · GitHub
3012019-06-13T12:26:08  <MarcoFalke> Ok, thx for the input
3022019-06-13T12:26:16  <MarcoFalke> Lets see what I can come up with
3032019-06-13T12:26:25  *** ddustin has joined #bitcoin-core-dev
3042019-06-13T12:31:03  *** ddustin has quit IRC
3052019-06-13T12:33:19  *** ddustin has joined #bitcoin-core-dev
3062019-06-13T12:39:55  *** ddustin has quit IRC
3072019-06-13T12:41:04  *** Chris_Stewart_5 has quit IRC
3082019-06-13T12:42:28  *** phwalkr has quit IRC
3092019-06-13T12:42:39  *** ddustin has joined #bitcoin-core-dev
3102019-06-13T12:47:20  *** ddustin has quit IRC
3112019-06-13T12:51:52  *** ddustin has joined #bitcoin-core-dev
3122019-06-13T12:52:54  *** siom has quit IRC
3132019-06-13T12:53:09  *** elichai2 has joined #bitcoin-core-dev
3142019-06-13T12:56:03  *** ddustin has quit IRC
3152019-06-13T13:05:23  *** gabuqo has joined #bitcoin-core-dev
3162019-06-13T13:07:45  *** michaelfolkson has quit IRC
3172019-06-13T13:08:22  *** michaelfolkson has joined #bitcoin-core-dev
3182019-06-13T13:08:22  *** michaelfolkson has quit IRC
3192019-06-13T13:09:01  *** michaelfolkson has joined #bitcoin-core-dev
3202019-06-13T13:09:49  *** ddustin has joined #bitcoin-core-dev
3212019-06-13T13:11:59  *** cubancorona has quit IRC
3222019-06-13T13:14:03  *** ddustin has quit IRC
3232019-06-13T13:15:15  *** cubancorona has joined #bitcoin-core-dev
3242019-06-13T13:16:12  *** cubancorona2 has joined #bitcoin-core-dev
3252019-06-13T13:20:02  *** cubancorona has quit IRC
3262019-06-13T13:27:25  *** bitcoin-git has joined #bitcoin-core-dev
3272019-06-13T13:27:25  <bitcoin-git> [bitcoin] laanwj closed pull request #15981: Use __func__ for log messages (master...replace-all-with-func) https://github.com/bitcoin/bitcoin/pull/15981
3282019-06-13T13:27:27  *** bitcoin-git has left #bitcoin-core-dev
3292019-06-13T13:29:38  *** harding has quit IRC
3302019-06-13T13:31:33  *** bitcoin-git has joined #bitcoin-core-dev
3312019-06-13T13:31:33  <bitcoin-git> [bitcoin] emilengler opened pull request #16204: Change Content-Type to plain text for the webroot (master...patch-emilengler) https://github.com/bitcoin/bitcoin/pull/16204
3322019-06-13T13:31:34  *** shesek has joined #bitcoin-core-dev
3332019-06-13T13:31:34  *** shesek has joined #bitcoin-core-dev
3342019-06-13T13:31:34  *** bitcoin-git has left #bitcoin-core-dev
3352019-06-13T13:31:40  *** harding has joined #bitcoin-core-dev
3362019-06-13T13:32:27  *** ddustin has joined #bitcoin-core-dev
3372019-06-13T13:32:56  *** michaelfolkson has quit IRC
3382019-06-13T13:33:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3392019-06-13T13:34:39  *** bitcoin-git has joined #bitcoin-core-dev
3402019-06-13T13:34:39  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16205: Refactor: Replace fprintf with tfm::format (master...1906-nofprintf) https://github.com/bitcoin/bitcoin/pull/16205
3412019-06-13T13:34:40  *** bitcoin-git has left #bitcoin-core-dev
3422019-06-13T13:37:22  *** ddustin has quit IRC
3432019-06-13T13:38:19  *** bralyclow01 has quit IRC
3442019-06-13T13:39:36  *** bralyclow has joined #bitcoin-core-dev
3452019-06-13T13:40:06  *** ddustin has joined #bitcoin-core-dev
3462019-06-13T13:43:00  *** darosior has quit IRC
3472019-06-13T13:44:35  *** spaced0ut has joined #bitcoin-core-dev
3482019-06-13T13:45:01  *** ddustin has quit IRC
3492019-06-13T13:48:01  *** rh0nj has quit IRC
3502019-06-13T13:48:26  *** siom has joined #bitcoin-core-dev
3512019-06-13T13:49:09  *** rh0nj has joined #bitcoin-core-dev
3522019-06-13T13:49:22  <instagibbs> jnewbery, what is a --debug build
3532019-06-13T13:49:24  <instagibbs> and how to detect :)
3542019-06-13T13:50:26  *** d_t has joined #bitcoin-core-dev
3552019-06-13T13:50:33  *** davterra has joined #bitcoin-core-dev
3562019-06-13T13:51:28  <MarcoFalke> Maybe --enable-debug?
3572019-06-13T13:51:37  <MarcoFalke> ./configure --enable-debug
3582019-06-13T13:52:44  <jnewbery> instagibbs: eg https://github.com/bitcoin/bitcoin/blob/431d81b61ca968da2d7c25f0d56455a44cd46fed/src/init.cpp#L871
3592019-06-13T13:52:55  <jnewbery> #ifdef DEBUG
3602019-06-13T13:53:20  <instagibbs> that's set when non-release, or?
3612019-06-13T13:53:25  <instagibbs> --enable-debug ?
3622019-06-13T13:53:43  <instagibbs> oh I should have read it
3632019-06-13T13:53:45  <instagibbs> non-release :)
3642019-06-13T13:54:07  *** michaelfolkson has joined #bitcoin-core-dev
3652019-06-13T13:56:58  *** michaelfolkson has quit IRC
3662019-06-13T13:57:33  *** ddustin has joined #bitcoin-core-dev
3672019-06-13T13:59:29  *** scoop has joined #bitcoin-core-dev
3682019-06-13T14:00:46  *** jonatack has joined #bitcoin-core-dev
3692019-06-13T14:02:08  *** ddustin has quit IRC
3702019-06-13T14:08:25  *** ddustin has joined #bitcoin-core-dev
3712019-06-13T14:11:26  *** bralyclow01 has joined #bitcoin-core-dev
3722019-06-13T14:13:03  *** astro has quit IRC
3732019-06-13T14:13:20  *** astro has joined #bitcoin-core-dev
3742019-06-13T14:13:22  *** bralyclo_ has joined #bitcoin-core-dev
3752019-06-13T14:14:09  *** bralyclo_ has quit IRC
3762019-06-13T14:14:51  *** bralyclow has quit IRC
3772019-06-13T14:15:28  *** ddustin has quit IRC
3782019-06-13T14:17:04  *** bralyclow01 has quit IRC
3792019-06-13T14:20:50  *** Guyver2 has joined #bitcoin-core-dev
3802019-06-13T14:27:01  *** laurentmt has joined #bitcoin-core-dev
3812019-06-13T14:27:04  *** ddustin has joined #bitcoin-core-dev
3822019-06-13T14:27:16  *** astro has quit IRC
3832019-06-13T14:27:28  *** astro has joined #bitcoin-core-dev
3842019-06-13T14:27:41  *** laurentmt has quit IRC
3852019-06-13T14:28:04  *** shtirlic has quit IRC
3862019-06-13T14:28:19  *** hebasto has joined #bitcoin-core-dev
3872019-06-13T14:29:03  *** bralyclow has joined #bitcoin-core-dev
3882019-06-13T14:29:06  *** bralyclow has quit IRC
3892019-06-13T14:29:40  *** bralyclow has joined #bitcoin-core-dev
3902019-06-13T14:29:59  *** shtirlic has joined #bitcoin-core-dev
3912019-06-13T14:31:48  *** ddustin has quit IRC
3922019-06-13T14:36:22  *** ccdle12 has joined #bitcoin-core-dev
3932019-06-13T14:44:56  *** ddustin has joined #bitcoin-core-dev
3942019-06-13T14:48:16  *** spinza has quit IRC
3952019-06-13T14:48:40  *** michaelfolkson has joined #bitcoin-core-dev
3962019-06-13T14:49:12  *** ddustin has quit IRC
3972019-06-13T14:49:59  <BlueMatt> phantomcircuit: I got it by dumping the routing table as visible from my router
3982019-06-13T14:50:14  *** rafalcpp has quit IRC
3992019-06-13T14:50:29  *** rafalcpp has joined #bitcoin-core-dev
4002019-06-13T14:50:30  *** d_t has quit IRC
4012019-06-13T14:50:35  *** queip has quit IRC
4022019-06-13T14:50:38  <phantomcircuit> BlueMatt, right, need a bgp session to do that
4032019-06-13T14:50:40  <phantomcircuit> does your table vaguely match https://iptoasn.com/
4042019-06-13T14:50:45  <BlueMatt> I have a bgp session
4052019-06-13T14:50:48  <BlueMatt> several, in fact
4062019-06-13T14:50:58  <phantomcircuit> yeah i know
4072019-06-13T14:52:34  <BlueMatt> i dunno where they pull it, but I didnt try to correlate between v4 -> RIR objects -> asns
4082019-06-13T14:52:41  <BlueMatt> which, I suppose, may also be a relevant approach
4092019-06-13T14:54:27  *** ddustin has joined #bitcoin-core-dev
4102019-06-13T14:56:35  *** queip has joined #bitcoin-core-dev
4112019-06-13T14:57:58  *** dviola has joined #bitcoin-core-dev
4122019-06-13T14:59:00  *** ddustin has quit IRC
4132019-06-13T15:00:02  *** Dragavnir has quit IRC
4142019-06-13T15:00:15  *** spinza has joined #bitcoin-core-dev
4152019-06-13T15:01:07  *** ppisati has quit IRC
4162019-06-13T15:06:04  *** defnordic has joined #bitcoin-core-dev
4172019-06-13T15:06:43  <BlueMatt> phantomcircuit: the nice thing is what sipa wrote will eat bird "show route all" output and map it, so its rather easy to get others' dumps as well
4182019-06-13T15:07:46  *** ppisati has joined #bitcoin-core-dev
4192019-06-13T15:12:30  *** ddustin has joined #bitcoin-core-dev
4202019-06-13T15:15:04  *** harrigan has joined #bitcoin-core-dev
4212019-06-13T15:16:42  *** ddustin has quit IRC
4222019-06-13T15:18:35  *** michaelfolkson has quit IRC
4232019-06-13T15:21:42  *** ddustin has joined #bitcoin-core-dev
4242019-06-13T15:24:53  <phantomcircuit> BlueMatt, that is nice
4252019-06-13T15:25:09  <phantomcircuit> it's definitely better to do asn grouping than /16
4262019-06-13T15:26:13  *** ddustin has quit IRC
4272019-06-13T15:26:32  *** cubancorona2 has quit IRC
4282019-06-13T15:26:32  <BlueMatt> indeed
4292019-06-13T15:29:30  *** captjakk has joined #bitcoin-core-dev
4302019-06-13T15:31:46  *** ccdle12 has quit IRC
4312019-06-13T15:33:27  *** setpill has quit IRC
4322019-06-13T15:36:59  *** cubancorona has joined #bitcoin-core-dev
4332019-06-13T15:38:29  *** jnewbery has quit IRC
4342019-06-13T15:38:43  *** jnewbery has joined #bitcoin-core-dev
4352019-06-13T15:42:15  <promag> imo #16106 is good to go
4362019-06-13T15:42:17  *** rafalcpp_ has joined #bitcoin-core-dev
4372019-06-13T15:42:18  <gribble> https://github.com/bitcoin/bitcoin/issues/16106 | gui: Sort wallets in open wallet menu by promag · Pull Request #16106 · bitcoin/bitcoin · GitHub
4382019-06-13T15:43:24  *** rafalcpp has quit IRC
4392019-06-13T15:44:28  *** ccc has joined #bitcoin-core-dev
4402019-06-13T15:45:52  *** lnostdal has quit IRC
4412019-06-13T15:46:21  *** jarthur has joined #bitcoin-core-dev
4422019-06-13T15:54:07  *** michaelfolkson has joined #bitcoin-core-dev
4432019-06-13T15:54:15  *** michaelfolkson has quit IRC
4442019-06-13T15:55:06  *** dlaw_ has joined #bitcoin-core-dev
4452019-06-13T15:57:15  *** dlaw_ has quit IRC
4462019-06-13T16:03:49  *** lightlike has joined #bitcoin-core-dev
4472019-06-13T16:07:24  *** ddustin has joined #bitcoin-core-dev
4482019-06-13T16:11:44  *** ddustin has quit IRC
4492019-06-13T16:12:13  *** bitcoin-git has joined #bitcoin-core-dev
4502019-06-13T16:12:13  <bitcoin-git> [bitcoin] asood123 opened pull request #16207: test: stop generating lcov coverage when functional tests fail (master...patch-15648) https://github.com/bitcoin/bitcoin/pull/16207
4512019-06-13T16:12:17  *** bitcoin-git has left #bitcoin-core-dev
4522019-06-13T16:16:20  *** ddustin has joined #bitcoin-core-dev
4532019-06-13T16:19:30  *** Chris_Stewart_5 has quit IRC
4542019-06-13T16:21:01  *** ddustin has quit IRC
4552019-06-13T16:21:47  *** shtirlic has quit IRC
4562019-06-13T16:21:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4572019-06-13T16:22:29  *** AaronvanW has quit IRC
4582019-06-13T16:23:09  *** shtirlic has joined #bitcoin-core-dev
4592019-06-13T16:25:24  *** ddustin has joined #bitcoin-core-dev
4602019-06-13T16:26:35  *** Chris_Stewart_5 has quit IRC
4612019-06-13T16:27:46  *** michaelfolkson has joined #bitcoin-core-dev
4622019-06-13T16:29:47  *** ddustin has quit IRC
4632019-06-13T16:32:36  *** lnostdal has joined #bitcoin-core-dev
4642019-06-13T16:45:23  *** ddustin has joined #bitcoin-core-dev
4652019-06-13T16:46:03  *** rafalcpp has joined #bitcoin-core-dev
4662019-06-13T16:46:55  *** rafalcpp_ has quit IRC
4672019-06-13T16:46:56  *** queip has quit IRC
4682019-06-13T16:50:01  *** captjakk has quit IRC
4692019-06-13T16:50:34  *** captjakk has joined #bitcoin-core-dev
4702019-06-13T16:52:23  *** gabuqo has quit IRC
4712019-06-13T16:52:50  *** queip has joined #bitcoin-core-dev
4722019-06-13T16:53:43  *** rafalcpp has quit IRC
4732019-06-13T16:53:50  *** rafalcpp has joined #bitcoin-core-dev
4742019-06-13T16:54:53  *** ddustin has quit IRC
4752019-06-13T16:57:52  *** michaelfolkson has quit IRC
4762019-06-13T17:03:20  *** cubancorona has quit IRC
4772019-06-13T17:03:29  *** d_t has joined #bitcoin-core-dev
4782019-06-13T17:05:02  <MarcoFalke> I think travis is horribly broken upstream and discards caches randomly
4792019-06-13T17:15:50  *** michaelfolkson has joined #bitcoin-core-dev
4802019-06-13T17:25:42  *** dviola has quit IRC
4812019-06-13T17:38:23  *** lnostdal has quit IRC
4822019-06-13T17:45:49  *** michaelfolkson has quit IRC
4832019-06-13T17:47:37  <jonasschnelli> In some contexts, cache means "can randomly delete"
4842019-06-13T17:48:54  *** booyah has joined #bitcoin-core-dev
4852019-06-13T17:50:25  *** emilengler has quit IRC
4862019-06-13T17:52:33  *** kristapsk has quit IRC
4872019-06-13T17:55:34  <dongcarl> :-/
4882019-06-13T17:59:49  *** scoop has quit IRC
4892019-06-13T18:00:01  *** defnordic has quit IRC
4902019-06-13T18:00:17  *** scoop has joined #bitcoin-core-dev
4912019-06-13T18:00:28  *** siom has quit IRC
4922019-06-13T18:00:29  <MarcoFalke> It should store them for 30days
4932019-06-13T18:00:46  <MarcoFalke> Mabye something else corrupts the caches or thinks they are outdated
4942019-06-13T18:02:15  *** laptop500 has quit IRC
4952019-06-13T18:02:31  <jonasschnelli> meeting?
4962019-06-13T18:03:56  *** jacob11 has joined #bitcoin-core-dev
4972019-06-13T18:04:15  <sipa> 1 hour from now
4982019-06-13T18:04:16  *** queip has quit IRC
4992019-06-13T18:04:36  *** laptop500 has joined #bitcoin-core-dev
5002019-06-13T18:04:36  *** rafalcpp_ has joined #bitcoin-core-dev
5012019-06-13T18:04:38  *** rafalcpp has quit IRC
5022019-06-13T18:04:40  <jonasschnelli> Argh. Right. Summertime.
5032019-06-13T18:05:43  *** scoop has quit IRC
5042019-06-13T18:05:49  *** scoop_ has joined #bitcoin-core-dev
5052019-06-13T18:06:17  *** laptop500 has quit IRC
5062019-06-13T18:07:11  *** laptop500 has joined #bitcoin-core-dev
5072019-06-13T18:08:57  <MarcoFalke> https://duckduckgo.com/?q=current+time+in+reykjavik
5082019-06-13T18:09:31  *** laptop_ has joined #bitcoin-core-dev
5092019-06-13T18:09:38  *** queip has joined #bitcoin-core-dev
5102019-06-13T18:10:33  *** laptop500 has quit IRC
5112019-06-13T18:12:11  *** morcos has joined #bitcoin-core-dev
5122019-06-13T18:13:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5132019-06-13T18:15:00  *** laptop__ has joined #bitcoin-core-dev
5142019-06-13T18:15:20  *** nkohen has joined #bitcoin-core-dev
5152019-06-13T18:16:34  *** csknk has joined #bitcoin-core-dev
5162019-06-13T18:17:34  *** laptop_ has quit IRC
5172019-06-13T18:22:27  *** nkohen has left #bitcoin-core-dev
5182019-06-13T18:22:39  *** nkohen has joined #bitcoin-core-dev
5192019-06-13T18:22:58  <nkohen> Hey all, I've implemented golomb coded sets as mentioned in BIP 158 and I'm currently trying to implement serialization of blocks into block filters (from the same BIP) and I'm looking over how core does this and it appears to me that entire output scripts are being put in blocks and not just the data pushed on the stack as specified in BIP 158. Is this true?
5202019-06-13T18:23:02  <nkohen> https://github.com/jimpo/bitcoin/blob/254c85b68794ada713dbdae415db72adf5fcbaf3/src/blockfilter.cpp#L203
5212019-06-13T18:25:24  <sipa> nkohen: from BIP158:
5222019-06-13T18:25:26  <sipa> > The scriptPubKey of each output, aside from all OP_RETURN output
5232019-06-13T18:25:36  *** d_t has quit IRC
5242019-06-13T18:26:04  *** d_t has joined #bitcoin-core-dev
5252019-06-13T18:26:19  <phantomcircuit> nkohen, the same data is probably in the filter more than once in different forms
5262019-06-13T18:26:25  <sipa> phantomcircuit: no
5272019-06-13T18:26:26  *** lnostdal has joined #bitcoin-core-dev
5282019-06-13T18:26:58  <sipa> it's the scriptPubKeys of all outputs in the block, and the scriptPubKeys of all outputs spent by the block
5292019-06-13T18:27:11  <jonasschnelli> nkohen: core has two filter types
5302019-06-13T18:27:33  <sipa> jonasschnelli: wut?
5312019-06-13T18:27:59  <sipa> no it doesn't
5322019-06-13T18:28:24  <jonasschnelli> no...
5332019-06-13T18:28:25  <jonasschnelli> :(
5342019-06-13T18:28:26  <jonasschnelli> only basic is imlemented
5352019-06-13T18:28:38  <jonasschnelli> I though since we had that option the extended was also there...
5362019-06-13T18:28:59  <sipa> the extended one was dropped from the bip
5372019-06-13T18:30:01  *** laptop_ has joined #bitcoin-core-dev
5382019-06-13T18:32:24  <jonasschnelli> nkohen: maybe lookup the function "BasicFilterElements" in blockfiler.cpp
5392019-06-13T18:32:32  *** laptop__ has quit IRC
5402019-06-13T18:34:53  <nkohen> jonasschnelli: that is the function I've linked to, and I'm not super fluent in c++ might be the issue but it looks like we call `elements.emplace(script.begin(), script.end());` where script is a CScript, and unless that somehow skips the opcodes and such which aren't data it looks like they get added?
5412019-06-13T18:35:15  <sipa> nkohen: no
5422019-06-13T18:35:26  <sipa> the spec says the entire scriptPubKey is added to the filter and nothing else
5432019-06-13T18:36:25  <jonasschnelli> nkohen: https://github.com/bitcoin/bips/blob/master/bip-0158.mediawiki#contents
5442019-06-13T18:36:31  <nkohen> ah I see, I've also been referencing the btcd implementation: https://github.com/Roasbeef/btcutil/blob/gcs/gcs/builder/builder.go#L186
5452019-06-13T18:36:37  <nkohen> and they seem to only take `PushedData`
5462019-06-13T18:38:24  <jonasschnelli> nkohen: that is roasbeef's branch? Maybe old?
5472019-06-13T18:38:48  <nkohen> joansschnelli: good point, I'll check
5482019-06-13T18:39:06  <jonasschnelli> nkohen: I guess you should look in: https://github.com/btcsuite/btcutil/blob/master/gcs/builder/builder.go#L299
5492019-06-13T18:40:34  *** bitcoin-git has joined #bitcoin-core-dev
5502019-06-13T18:40:34  <bitcoin-git> [bitcoin] instagibbs opened pull request #16208: Consume CReserveKey on successful CreateTransaction (master...createtransaction_keepkey) https://github.com/bitcoin/bitcoin/pull/16208
5512019-06-13T18:40:36  *** bitcoin-git has left #bitcoin-core-dev
5522019-06-13T18:40:45  <nkohen> yup, that has it fixed, I now understand why nothing has been working, thanks sipa and jonasschnelli!
5532019-06-13T18:45:20  *** rafalcpp_ has quit IRC
5542019-06-13T18:45:23  *** rafalcpp has joined #bitcoin-core-dev
5552019-06-13T18:45:56  *** queip has quit IRC
5562019-06-13T18:51:37  *** queip has joined #bitcoin-core-dev
5572019-06-13T18:54:21  <nkohen> luke-jr: I changed the link to the reference implementation of GCS which was out of date - https://github.com/bitcoin/bips/pull/788
5582019-06-13T19:00:24  <achow101> meeting?
5592019-06-13T19:00:37  <instagibbs> hello
5602019-06-13T19:00:38  <jnewbery> hi
5612019-06-13T19:00:40  <sipa> meeting!
5622019-06-13T19:00:54  <fanquake> Hi
5632019-06-13T19:00:56  <jonasschnelli> hi
5642019-06-13T19:01:07  <promag> hi
5652019-06-13T19:01:22  <wumpus> #startmeeting
5662019-06-13T19:01:22  <lightningbot> Meeting started Thu Jun 13 19:01:22 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
5672019-06-13T19:01:22  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
5682019-06-13T19:01:32  <cfields> hi
5692019-06-13T19:01:37  <dongcarl> hi (sort of)
5702019-06-13T19:01:41  <achow101> hi
5712019-06-13T19:01:48  <meshcollider> hi
5722019-06-13T19:01:51  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
5732019-06-13T19:02:10  <phantomcircuit> hi
5742019-06-13T19:02:40  <wumpus> we have three topics in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
5752019-06-13T19:02:43  *** rafalcpp has quit IRC
5762019-06-13T19:02:51  <moneyball> hi
5772019-06-13T19:02:57  *** queip has quit IRC
5782019-06-13T19:02:57  <phantomcircuit> sipa, oh it's the bloom filters that add other stuff
5792019-06-13T19:03:02  <sipa> topic suggestion: ASN database shipped with bitcoind?
5802019-06-13T19:03:06  *** rafalcpp has joined #bitcoin-core-dev
5812019-06-13T19:03:29  <wumpus> also high priority for review but I didn't look at that at all this week due to coredev and the conference tbh
5822019-06-13T19:03:42  <phantomcircuit> sipa, i think yes, it's certainly better than assuming /16 are distinct entities
5832019-06-13T19:03:49  <jb55> sipa: can you go over the benefit of that for those who might be out of the loop
5842019-06-13T19:03:52  * jb55 like this guy
5852019-06-13T19:03:57  <wumpus> #topic High priority for review
5862019-06-13T19:04:06  <sipa> phantomcircuit, jb55: i'm suggesting a topic; we'll discuss it when the topic comes up
5872019-06-13T19:04:26  <Chris_Stewart_5> hello
5882019-06-13T19:04:27  <wumpus> https://github.com/bitcoin/bitcoin/projects/8 there's four things on there now
5892019-06-13T19:04:40  <wumpus> +2 brainstorming topics
5902019-06-13T19:05:18  <wumpus> anything to add/remove for this week ?
5912019-06-13T19:05:36  <MarcoFalke> I'd like to add #14193
5922019-06-13T19:05:40  <gribble> https://github.com/bitcoin/bitcoin/issues/14193 | validation: Add missing mempool locks by MarcoFalke · Pull Request #14193 · bitcoin/bitcoin · GitHub
5932019-06-13T19:05:52  <sipa> not sure to what extent we decided that the high priority list should have an implicit "basic concept ack" because discussed in the meeting; but to the extent that it is, i think the list entries are great :)
5942019-06-13T19:06:03  <MarcoFalke> good point
5952019-06-13T19:06:15  <MarcoFalke> I'd like to add 14193 as "bugfix"
5962019-06-13T19:06:35  <jtimon> review beg https://github.com/bitcoin/bitcoin/pull/8994#issuecomment-501826862
5972019-06-13T19:06:48  *** shtirlic has quit IRC
5982019-06-13T19:06:55  <wumpus> missing locks sounds pretty concept ackable
5992019-06-13T19:07:04  <MarcoFalke> jtimon: are you adding that as "Chasing Concept ACK"?
6002019-06-13T19:07:07  *** infernix has quit IRC
6012019-06-13T19:07:20  <MarcoFalke> wumpus: Yeah, it has been open for months and hasn't received any attention
6022019-06-13T19:07:30  <fanquake> dongcarl do you have any build related blockers? Guix or otherwise.
6032019-06-13T19:07:32  <sipa> concept ack
6042019-06-13T19:08:21  <meshcollider> concept ack for adding Marco's PR
6052019-06-13T19:08:34  <dongcarl> fanquake: looking
6062019-06-13T19:08:47  <sipa> agree on jtimon
6072019-06-13T19:08:52  <sipa> agree on jtimon's pr as chasing concept ack
6082019-06-13T19:08:56  <jnewbery> I'd like #16060 on there. I have a couple of review comments from last week to address. It's blocking some work that BlueMatt is doing on reducing cs_main usage
6092019-06-13T19:08:59  <gribble> https://github.com/bitcoin/bitcoin/issues/16060 | Bury bip9 deployments by jnewbery · Pull Request #16060 · bitcoin/bitcoin · GitHub
6102019-06-13T19:09:06  <wumpus> why is the github 'add cards' search so broken, every time I search for a number it shows 20 different ones
6112019-06-13T19:09:33  <jonasschnelli> yes. that's so broken
6122019-06-13T19:09:46  <jnewbery> wumpus: I think it's easier to add a PR to a project from within the PR itself
6132019-06-13T19:09:47  <dongcarl> fanquake: no blockers
6142019-06-13T19:10:11  *** shtirlic has joined #bitcoin-core-dev
6152019-06-13T19:10:11  *** shtirlic has quit IRC
6162019-06-13T19:10:36  <fanquake> Yes from the sidebar in a PR is usually easy.
6172019-06-13T19:10:37  <jtimon> MarcoFalke: yeah, I mean, it got concept acks before, but I have been not rebasing it for 6 months or so
6182019-06-13T19:10:53  <fanquake> dongcarl ok
6192019-06-13T19:11:14  *** shtirlic has joined #bitcoin-core-dev
6202019-06-13T19:11:16  *** queip has joined #bitcoin-core-dev
6212019-06-13T19:11:25  <wumpus> jnewbery: good point
6222019-06-13T19:11:35  <jtimon> I think 16060 could be done before or after and I think the result will be the same
6232019-06-13T19:11:36  <jb55> jnewbery jtimon: testchains pr would be good for review club?
6242019-06-13T19:12:43  <fanquake> I’m no more High Priority, should we discuss first proposed topic? EOL dates?
6252019-06-13T19:12:43  <jtimon> jb55: sure, why not?
6262019-06-13T19:13:08  <wumpus> #topic Update EOL dates (MarcoFalke)
6272019-06-13T19:13:18  <wumpus> https://github.com/bitcoin-core/bitcoincore.org/pull/659#issuecomment-499884131
6282019-06-13T19:13:30  <instagibbs> how do I read those columns in isolation?
6292019-06-13T19:13:50  <kanzure> hi
6302019-06-13T19:14:07  <MarcoFalke> Basically I am removing historical EOL dates and update others
6312019-06-13T19:14:15  <cfields> Would it be possible to pull these values from SECURITY.md, rather than keeping them in sync?
6322019-06-13T19:14:16  <achow101> is it necessary to remove historical ones?
6332019-06-13T19:14:28  <wumpus> LGTM
6342019-06-13T19:14:41  <MarcoFalke> achow101: They are not representative and have been made up
6352019-06-13T19:14:44  <wumpus> it defeinitely cleans up a lot
6362019-06-13T19:15:10  <MarcoFalke> The only information you need is that they are surely eol today
6372019-06-13T19:15:17  <wumpus> yes
6382019-06-13T19:15:33  <meshcollider> Is it sensible to add an EOL date for 0.17 before the maintainance end date has even been announced
6392019-06-13T19:15:49  <wumpus> for the rest there's git history I guess…
6402019-06-13T19:16:04  <wumpus> but come on, 0.8.x
6412019-06-13T19:16:08  <MarcoFalke> meshcollider: good point
6422019-06-13T19:16:25  <wumpus> meshcollider:probably not
6432019-06-13T19:16:30  <MarcoFalke> I think given that we have a fixed release schedule, it should be fine
6442019-06-13T19:16:45  <cfields> wumpus: segwit 0.8.x when? :p
6452019-06-13T19:16:47  <achow101> perhaps put the scheduled 0.19 release date?
6462019-06-13T19:16:50  <wumpus> things drift a few months here and there though
6472019-06-13T19:16:54  <wumpus> cfields:lol
6482019-06-13T19:16:55  <achow101> (for 0.17 maintenance end)
6492019-06-13T19:17:38  <MarcoFalke> happy to remove the 0.17 EOL, though
6502019-06-13T19:18:00  <instagibbs> (took me way too long to figure out the table headers: https://bitcoincore.org/en/lifecycle/#schedule )
6512019-06-13T19:18:10  <meshcollider> the EOL date for 0.16 seems fine though, just under 1 year was the rule I used last time I updated it
6522019-06-13T19:18:17  <cfields> Again, though, can we somehow automatically keep this in sync with SECURITY.md? I'm afraid of them drifting apart.
6532019-06-13T19:18:19  <wumpus> yes
6542019-06-13T19:19:20  <fanquake> We could just make security.md the place where they live, and they get manually/automatically pulled out of their for website updates?
6552019-06-13T19:19:28  <meshcollider> +1
6562019-06-13T19:19:31  <wumpus> so the information in security.md is only for security fixes, not general maintenance
6572019-06-13T19:19:59  <wumpus> it should list the versions that are not entirely EOL I guess
6582019-06-13T19:20:14  <cfields> fanquake: +1
6592019-06-13T19:20:15  <meshcollider> Kinda makes more sense to have it in the repo though than on a separate website?
6602019-06-13T19:20:45  <wumpus> maybe ...
6612019-06-13T19:20:57  <wumpus> I'm usually not in favor of importing everything into the repo
6622019-06-13T19:21:05  <achow101> it should be possible to have SECURITY.md fetched and parsed during the build for the website. I know bitcoin.org does something similar to generate the contributors page
6632019-06-13T19:21:14  <nehan> fwiw: the motivation for SECURITY.md was in part because people who wanted to report things did not know about bitcoincore.org
6642019-06-13T19:21:23  <wumpus> like it's fiiine to maintain different things in different places, it doesn't all have to go through the same bottleneck you know
6652019-06-13T19:21:39  <wumpus> nehan: yes, for reporting it makes perfect sense
6662019-06-13T19:21:45  <sipa> i think the SECURITY.md living in the repo itself is weird, as it's not tied to the specific source tree it lives in (this is also true for release notes etc)
6672019-06-13T19:21:50  <MarcoFalke> Add it to "release-process.md"? *ducks
6682019-06-13T19:21:53  <meshcollider> Fair enough actually yeah
6692019-06-13T19:22:28  <MarcoFalke> sipa: Release notes should be shipped, so at least during build you'd have to fetch them
6702019-06-13T19:22:29  <wumpus> sipa: I think the reporting emails and gpg keys are
6712019-06-13T19:22:36  <cfields> sipa: elaborate?
6722019-06-13T19:22:43  <wumpus> sipa: as for the schedule, I guess I'd somewhat agree
6732019-06-13T19:23:01  <sipa> cfields: which versions are still under maintenance, eg
6742019-06-13T19:23:28  <wumpus> but that wasn't the main point of security.md, it was to let people know where to report critical security issues
6752019-06-13T19:23:51  <fanquake> security.md is also being removed from any branch that isn’t master right.
6762019-06-13T19:23:53  <sipa> if someone randomly clones the repo, leaves their copy untouched for years... someone stumbles upon it (like nkohen's with roasbeef's repo above ^), and sees the version they think they
6772019-06-13T19:23:53  <wumpus> and I guess what releases to report them for ? like, if you find a problem with 0.8 now it's probably not useful to report it
6782019-06-13T19:23:55  <MarcoFalke> So lets remove the eol dates from there again?
6792019-06-13T19:23:58  <sipa> if someone randomly clones the repo, leaves their copy untouched for years... someone stumbles upon it (like nkohen's with roasbeef's repo above ^), and sees the version they think they're working with is maintained
6802019-06-13T19:24:08  <cfields> wumpus: fair enough.
6812019-06-13T19:24:35  <sipa> i don't know if this confusion doesn't weigh up to having the information in a well-visible location
6822019-06-13T19:24:38  <cfields> MarcoFalke: I'd +1 that as well. I just don't like the idea of having them maintained separately in two places.
6832019-06-13T19:24:44  <wumpus> sipa: yes
6842019-06-13T19:24:57  <wumpus> ok, let's remove the dates from security.md
6852019-06-13T19:25:08  <MarcoFalke> #action remove the dates from security.md
6862019-06-13T19:25:20  <sipa> we could have a link in security.md to the authoritative place where that information is maintained
6872019-06-13T19:25:22  <instagibbs> ack
6882019-06-13T19:25:33  <meshcollider> +1
6892019-06-13T19:25:33  <fanquake> If that’s done. Second proposed topic is where to have the next Core Dev meetup.
6902019-06-13T19:25:43  <cfields> sipa: +1
6912019-06-13T19:25:50  <moneyball> hi
6922019-06-13T19:25:55  <MarcoFalke> ok,next topic
6932019-06-13T19:25:57  <wumpus> #topic when/where should we have next CoreDev? (moneyball)
6942019-06-13T19:26:02  <moneyball> Thanks for those that attended CoreDev. By all accounts I think it was a success!
6952019-06-13T19:26:07  <wumpus> agree!
6962019-06-13T19:26:10  <MarcoFalke> Once per release seems fine to me
6972019-06-13T19:26:13  <moneyball> We had 18 responses to the feedback survey. The summary is "don't change anything." 72% want to keep reviewing/merging unstructured. 93% liked the scheduled talks. 83% think 3 days is the optimal duration. And majority of people like the # attendees and the mix.
6982019-06-13T19:26:13  <meshcollider> Definitely, thank you \i/
6992019-06-13T19:26:19  <cfields> moneyball: thanks for organizing!
7002019-06-13T19:26:27  <moneyball> If anyone has other feedback please either fill out the form or let schmidty or me know.
7012019-06-13T19:26:31  <instagibbs> I definitely think it was the best so far
7022019-06-13T19:26:40  <jonasschnelli> Yeah. Thanks moneyball!
7032019-06-13T19:26:46  <sipa> indeed!
7042019-06-13T19:26:50  <fanquake> \o/
7052019-06-13T19:27:05  <sipa> also congrats on getting Gary fired
7062019-06-13T19:27:19  <moneyball> thx :)
7072019-06-13T19:27:24  <moneyball> So I started thinking about the next CoreDev already! Aiming for 6-9 months from now which means December to March. Considerations include, most importantly, what % of active Core devs can attend, and after that, minimizing aggregate travel time/timezone shift/cost of travel, exploring new locations, winter weather, ease of organizing (eg piggyback off of conferences or have local Core devs to help)
7082019-06-13T19:27:26  <jonasschnelli> indeed. Congratz moneyball
7092019-06-13T19:27:38  <MarcoFalke> Who is gary?
7102019-06-13T19:27:45  <cfields> moneyball: since there's typically a large turnout for Financial Crypto, maybe we could piggyback there?
7112019-06-13T19:27:52  <cfields> It's usually within that window.
7122019-06-13T19:27:58  <wumpus> not December please :)
7132019-06-13T19:28:02  <moneyball> Initial candidates include SF, Austin, NYC, Uruguay mid-December (La Bitconf), and Australia (possible Feb 2020 Bitcoin conf). If anyone has other candidate dates/locations please let me know! I'll likely send a survey around (sorry for all the surveys but it is really helpful!) allowing Core devs to rank candidate locations.
7142019-06-13T19:28:05  <instagibbs> internet kinda really sucks there cfields IIRC
7152019-06-13T19:28:07  <jonasschnelli> We haven't had a CoreDev in Hawaii...
7162019-06-13T19:28:08  <nehan> moneyball: also MIT Bitcoin Expo
7172019-06-13T19:28:12  <fanquake> Marco A fake SquareCrypto intern.
7182019-06-13T19:28:56  <MarcoFalke> Ah, thx. I uninstalled twitter
7192019-06-13T19:29:01  <moneyball> nehan i will add that to the list!
7202019-06-13T19:29:16  <instagibbs> Holiday season is a prob a no-go, as wumpus said.
7212019-06-13T19:29:24  <sipa> cfields: i'd personally like a coredev colocated with FC, but i'm not sure it's that accessible for everyone (especially people who don't have company funding for travel)
7222019-06-13T19:29:42  <jnewbery> financial crypto is 5 days. piggybacking would make a very long trip for people
7232019-06-13T19:29:54  <cfields> sipa: good point.
7242019-06-13T19:29:57  <achow101> moneyball: there's also advancing bitcoin in london in feb
7252019-06-13T19:30:04  <instagibbs> co-located to another less-academic conference also has the benefits of people can submit talks/run workshops and piggyback that
7262019-06-13T19:30:25  <jonasschnelli> coredev.tech does fund travel expenses of those not receiving support from employers
7272019-06-13T19:30:25  <sipa> about Boston: not everyone can enter (or likes to enter) the US
7282019-06-13T19:30:37  <fanquake> I’d probably almost strike Aus of the list for Dec - Feb. Too hot.
7292019-06-13T19:31:17  <sipa> fanquake: i was very confused for a minute and thought you were talking about austin
7302019-06-13T19:31:17  <instagibbs> dropbears don't like the heat though
7312019-06-13T19:31:43  <jnewbery> fanquake: maybe in Binnu. There are places that aren't quite as hot
7322019-06-13T19:31:48  <fanquake> Yes but neither do Core Devs I’d assume.
7332019-06-13T19:32:16  <fanquake> jnewbery if your happy with 40C days, go ahead. We’ll have Core dev on the beach.
7342019-06-13T19:32:31  *** elichai2 has quit IRC
7352019-06-13T19:32:38  <meshcollider> NZ is a bit more mild than aus, come over here instead ;)
7362019-06-13T19:32:42  <jnewbery> I meant maybe Binnu was too hot and we could have it somewhere else
7372019-06-13T19:32:43  <wumpus> hehe
7382019-06-13T19:33:07  <fanquake> ah right
7392019-06-13T19:33:08  * sipa would suggest Iceland (nicely in the middle between EU and US), but only if in summer :)
7402019-06-13T19:33:08  <moneyball> regarding not wanting to enter the US, i would like to better understand how big of an issue this is. if those affected are comfortable, please reach out to me and let me know so it is taken into account
7412019-06-13T19:33:26  <wumpus> Iceland :D
7422019-06-13T19:33:34  <jonasschnelli> ack Iceland
7432019-06-13T19:33:36  <instagibbs> there are >=2 people that came to last coredev that can't come generally speaking.
7442019-06-13T19:33:47  <moneyball> yeah the next next CoreDev is already decided...summer 2020 iceland :)
7452019-06-13T19:33:49  <nehan> i was also going to suggest iceland
7462019-06-13T19:34:07  <instagibbs> It should be over the next halving tbh :)
7472019-06-13T19:35:09  <fanquake> moneyball I think this could be left for suggestions/comments. Anything else you wanted to bring up? Otherwise final proposed topic is Travis instability.
7482019-06-13T19:35:24  <moneyball> all good thanks for the input everyone
7492019-06-13T19:35:52  <meshcollider> Is there a way to provide input that's easier for you? Like a survey of our preferred location and timing or something?
7502019-06-13T19:36:04  <cfields> moneyball: fyi, the last thing done at FC is voting on the next location. Which is cool because the people there are obviously a great sample.
7512019-06-13T19:36:11  <cfields> Just throwing that out there because I think it's neat :)
7522019-06-13T19:36:26  <sipa> it's just an informative vote though; the actual decision is made much later
7532019-06-13T19:36:35  <cfields> right, that.
7542019-06-13T19:36:48  <wumpus> heh it doesn't include the people that weren't able to come
7552019-06-13T19:36:58  <meshcollider> Confirmation bias lol
7562019-06-13T19:37:02  <sipa> self-echochambering is best echochambering
7572019-06-13T19:37:12  <wumpus> #topic Travis stability and usefulness in current state (jonasschnelli)
7582019-06-13T19:37:35  <wumpus> travis is failing sooo much on PRs now
7592019-06-13T19:37:43  <moneyball> i'll do a survey ranking locations
7602019-06-13T19:37:47  <jonasschnelli> We probably discussed that already to a certain level. But somehow I think we should have a plan how to get travis back on track
7612019-06-13T19:38:05  <jonasschnelli> Right now on an avg of 3-4 tries travis will succeed.
7622019-06-13T19:38:09  *** emilengler has joined #bitcoin-core-dev
7632019-06-13T19:38:16  <wumpus> it's absurd that even PRs that change like 3 comment lines fail
7642019-06-13T19:38:19  <cfields> jonasschnelli: by travis do you mean Travis the service? Or our c-i checks in general?
7652019-06-13T19:38:38  <wumpus> I know it's bad but I'm already starting to effectively ignore it
7662019-06-13T19:38:39  <jonasschnelli> It can't be that we just need to re-trigger builds all over... this makes the value of CI partially disappearing
7672019-06-13T19:39:07  <fanquake> cfields: it seems like lots of invalide caches, casting constant depends rebuilds? At least what I’ve seen.
7682019-06-13T19:39:09  <wumpus> it used to be 'oh this PR fails, it needs more work by the author' but it's never the author's fault !
7692019-06-13T19:39:21  <fanquake> *invalid, *causing
7702019-06-13T19:39:22  *** scoop_ has quit IRC
7712019-06-13T19:39:32  <wumpus> so I run the tests locally, which is incomplete but at least reliable ...
7722019-06-13T19:39:41  <achow101> can drahtbot be made to retrigger travis on certain kinds of errors?
7732019-06-13T19:39:42  <jonasschnelli> I think we should have a strategy how to escape this mess...
7742019-06-13T19:39:48  *** scoop has joined #bitcoin-core-dev
7752019-06-13T19:39:52  <achow101> otherwise maybe we should consider using a different CI
7762019-06-13T19:40:03  <jonasschnelli> eventually... but that is a lot of work
7772019-06-13T19:40:03  <fanquake> The depends builds then obviously take up all the build time, and the build dies.
7782019-06-13T19:40:11  <wumpus> yes, we need something better
7792019-06-13T19:40:13  <cfields> Maybe we should finally consider decoupling the depends builds?
7802019-06-13T19:40:17  <wumpus> another CI would be ok with me
7812019-06-13T19:40:23  <jb55> circle-ci ?
7822019-06-13T19:40:31  <sipa> are there any self-hostable CI systems that integrate with github?
7832019-06-13T19:40:58  <cfields> (afaik I've been the one arguing for keeping depends compiles included in the past, but things have changed...)
7842019-06-13T19:41:02  <wumpus> I liked travis a lot when it worked but this is just not doable anymore
7852019-06-13T19:41:07  <jonasschnelli> I think it would be worth if willing people can propose a researched alternative on next meeting
7862019-06-13T19:41:27  <wumpus> cfields: you mean, using distro deps instead of depends?
7872019-06-13T19:41:32  <fanquake> I think those would be interesting to review.
7882019-06-13T19:41:33  <jonasschnelli> if we have volunteers...
7892019-06-13T19:41:44  <wumpus> cfields: too bad travis has such old versions
7902019-06-13T19:41:52  <meshcollider> sipa: Jenkins is self hostable I think
7912019-06-13T19:41:55  <wumpus> it's still trusty isn't it?
7922019-06-13T19:42:01  <cfields> wumpus: I mean automating depends builds separately, and having bitcoind builds fetch pre-built depends binaries.
7932019-06-13T19:42:09  <wumpus> cfields: ohh makes sense
7942019-06-13T19:42:20  <wumpus> cfields: then only do depends rebuilds, if depends change
7952019-06-13T19:42:21  <fanquake> FYI if anyone is unaware, we already have a circle CI confit in the repo, and Marco runs its against his own repo I’m pretty sure. Has a PR open for confit updates atm.
7962019-06-13T19:42:27  <cfields> as that seems to be the biggest mess?
7972019-06-13T19:42:30  <jonasschnelli> github lists 24 CI tools: https://github.com/marketplace/category/continuous-integration
7982019-06-13T19:42:38  <wumpus> cfields: it's certainly speed up things a lot
7992019-06-13T19:42:42  <wumpus> it'd*
8002019-06-13T19:42:59  <wumpus> especially the qt build in depends takes a long time, the rest is pretty fast
8012019-06-13T19:43:07  <cfields> I can work on that if it sounds interesting?
8022019-06-13T19:43:13  <cfields> It would introduce some new sync issues...
8032019-06-13T19:43:24  <cfields> But may be better than the status quo.
8042019-06-13T19:43:29  <wumpus> protobuf is a few seconds, even boost is, as we've stripped it down a lot
8052019-06-13T19:43:41  <wumpus> but qt....
8062019-06-13T19:43:46  <fanquake> cfields: would the pre built stuff live on bitcoincore.org ?
8072019-06-13T19:43:47  <cfields> I think it probably takes longer to gzip boost than to build it :(
8082019-06-13T19:43:52  <wumpus> yes
8092019-06-13T19:43:57  <sipa> cfields: lol
8102019-06-13T19:44:05  <wumpus> I think so too hehe
8112019-06-13T19:44:12  *** scoop has quit IRC
8122019-06-13T19:44:23  <wumpus> so it *seems* that travis caching is not working anymore
8132019-06-13T19:44:30  <wumpus> it rebuilds things unnecessarily a lot
8142019-06-13T19:44:33  <cfields> fanquake: I guess so?
8152019-06-13T19:44:41  <jonasschnelli> Maybe Google Cloud Builds could be something? Supported by Github?
8162019-06-13T19:44:46  <cfields> wumpus: the problem would be when you need a new dependency for your core change.
8172019-06-13T19:44:55  <cfields> Might have to split that up logically and wait a day for sync.
8182019-06-13T19:44:57  <wumpus> it shouldn't need to rebuild the depends on a PR that changes three comment lines, if the branch has the same version of depends
8192019-06-13T19:45:05  <cfields> s/new/modified/
8202019-06-13T19:45:35  <fanquake> I’m just slightly worried about the potential lag in updates. Especially as a lot of build related work is happening atm.
8212019-06-13T19:45:57  <instagibbs> could there be a "no really, build depends" option somehow?
8222019-06-13T19:45:59  <cfields> fanquake: that's probably a good bit of what's making the build times worse, though.
8232019-06-13T19:46:01  <wumpus> anything is better than having travis fail on every pr
8242019-06-13T19:46:09  <cfields> Any touch to depends will mean that tons of PRs start rebuilding everything.
8252019-06-13T19:46:12  <fanquake> cfields: true
8262019-06-13T19:46:35  <wumpus> cfields: ohh of course
8272019-06-13T19:46:44  <wumpus> would make sense to decouple it
8282019-06-13T19:47:12  <cfields> I'll take a look at that in parallel to the discussion about other services.
8292019-06-13T19:47:19  <wumpus> thanks
8302019-06-13T19:47:20  <jonasschnelli> Would asking the Travis guys be an option (explain them our situation)?
8312019-06-13T19:47:29  <jonasschnelli> I guess its mostly about execution time limits
8322019-06-13T19:47:36  <cfields> I'm also not opposed to self-hosted as I was before. The landscape has changed. We have lots more volunteers now :)
8332019-06-13T19:48:01  <fanquake> Does that mean your volunteering :p
8342019-06-13T19:48:14  <cfields> fanquake: nobody would want that :p
8352019-06-13T19:48:16  <wumpus> I used to be oppposed to self-hosted, but if hosted CIs are this bad, anything is better :p
8362019-06-13T19:48:17  <fanquake> Need to use the big new desktop for something hah.
8372019-06-13T19:48:25  <jonasschnelli> Travis would still be fine if we add self-hosted Jenkins... if we strip the depends build on the travis side
8382019-06-13T19:48:46  <jb55> #bitcoin-builds would be a good place to coordinate build system/ops stuff
8392019-06-13T19:49:15  <instagibbs> this channel is really not that busy...
8402019-06-13T19:49:35  <wumpus> hehe I'm still sceptical about the channel split too, though it's cosy there
8412019-06-13T19:49:47  <jb55> yeah just mentioning it since it's already there
8422019-06-13T19:50:03  <fanquake> So conclusion is some options might be presented at the next meeting? There are no more proposed topics left.
8432019-06-13T19:50:10  <cfields> * instagibbs has been banned from #bitcoin-builds
8442019-06-13T19:50:22  <instagibbs> psh like I was ever going there
8452019-06-13T19:50:32  <wumpus> hehe
8462019-06-13T19:50:44  <fanquake> sipa did you want to discuss the ASN stuff?
8472019-06-13T19:50:48  <sipa> sure
8482019-06-13T19:50:54  <sipa> though it's probably better if BlueMatt is here
8492019-06-13T19:51:06  <wumpus> oh sorry forgot about sipa's topic a bit
8502019-06-13T19:51:54  <fanquake> Can someone at chaincode tap Matt on the shoulder. jamesob ?
8512019-06-13T19:51:56  <wumpus> oh in that case let's add it to proposed topics for next week, and hope BlueMatt is there then
8522019-06-13T19:52:31  <sipa> all right
8532019-06-13T19:53:13  <wumpus> thanks everyeone
8542019-06-13T19:53:17  <wumpus> #endmeeting
8552019-06-13T19:53:17  <lightningbot> Meeting ended Thu Jun 13 19:53:17 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
8562019-06-13T19:53:17  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-13-19.01.html
8572019-06-13T19:53:17  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-13-19.01.txt
8582019-06-13T19:53:17  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-13-19.01.log.html
8592019-06-13T19:53:45  <fanquake> Productive.
8602019-06-13T19:54:07  *** bitcoin-git has joined #bitcoin-core-dev
8612019-06-13T19:54:07  <bitcoin-git> [bitcoin] instagibbs closed pull request #15796: CReserveKey should not allow passive key re-use, debug assert in destructor (master...burn_reserve) https://github.com/bitcoin/bitcoin/pull/15796
8622019-06-13T19:54:08  *** bitcoin-git has left #bitcoin-core-dev
8632019-06-13T19:57:41  <MarcoFalke> Yeah sorry for missing the last topic
8642019-06-13T19:57:54  <MarcoFalke> But it seems travis caches are broken in some way
8652019-06-13T19:58:01  <MarcoFalke> Still investigating ...
8662019-06-13T20:01:00  *** kristapsk has joined #bitcoin-core-dev
8672019-06-13T20:02:45  *** nkohen has quit IRC
8682019-06-13T20:04:39  *** timothy has quit IRC
8692019-06-13T20:05:11  *** dviola has joined #bitcoin-core-dev
8702019-06-13T20:07:39  *** scoop has joined #bitcoin-core-dev
8712019-06-13T20:12:48  *** Chris_Stewart_5 has quit IRC
8722019-06-13T20:16:16  *** scoop has quit IRC
8732019-06-13T20:18:07  *** scoop has joined #bitcoin-core-dev
8742019-06-13T20:21:53  *** lightlike has quit IRC
8752019-06-13T20:21:58  *** scoop has quit IRC
8762019-06-13T20:22:07  *** scoop has joined #bitcoin-core-dev
8772019-06-13T20:22:44  *** elichai2 has joined #bitcoin-core-dev
8782019-06-13T20:25:06  <fanquake> #proposedmeetingtopic Requiring 2FA for bitcoin orgs on GH. This was discussed a little at Core dev, and we got 4-5 members to turn 2FA on.
8792019-06-13T20:29:12  *** Guyver2 has quit IRC
8802019-06-13T20:38:05  *** jonatack has quit IRC
8812019-06-13T20:38:13  *** emilengler has quit IRC
8822019-06-13T20:40:26  *** TheRec has quit IRC
8832019-06-13T20:42:09  *** TheRec has joined #bitcoin-core-dev
8842019-06-13T20:42:09  *** TheRec has joined #bitcoin-core-dev
8852019-06-13T20:47:02  <jamesob> fanquake: sorry, was afk. will tap matt next I see him
8862019-06-13T20:55:37  <dongcarl> fanquake: Probably 2FA but no SMS recovery?
8872019-06-13T21:00:02  *** jacob11 has quit IRC
8882019-06-13T21:01:00  <hebasto> SMS recovery seems to be a great security issue
8892019-06-13T21:02:46  *** rafalcpp has quit IRC
8902019-06-13T21:02:54  *** rafalcpp has joined #bitcoin-core-dev
8912019-06-13T21:03:14  *** queip has quit IRC
8922019-06-13T21:04:42  *** kljasdfvv has quit IRC
8932019-06-13T21:04:47  *** hebasto has quit IRC
8942019-06-13T21:05:09  *** kljasdfvv has joined #bitcoin-core-dev
8952019-06-13T21:05:20  *** csknk has quit IRC
8962019-06-13T21:06:17  *** jpcw1 has joined #bitcoin-core-dev
8972019-06-13T21:06:34  <fanquake> dongcarl hebasto correct. kanzure might have some thoughts to share on that.
8982019-06-13T21:10:08  *** queip has joined #bitcoin-core-dev
8992019-06-13T21:10:36  *** TheRec has quit IRC
9002019-06-13T21:10:45  *** TheRec has joined #bitcoin-core-dev
9012019-06-13T21:10:46  *** TheRec has joined #bitcoin-core-dev
9022019-06-13T21:12:09  *** jimmysong has joined #bitcoin-core-dev
9032019-06-13T21:14:30  <phantomcircuit> dongcarl, there's no way to configure github organizations to require 2fa but not sms
9042019-06-13T21:14:48  <dongcarl> phantomcircuit: :-/
9052019-06-13T21:16:54  <phantomcircuit> dongcarl, and yes sms is basically useless
9062019-06-13T21:26:24  *** rafalcpp has quit IRC
9072019-06-13T21:26:39  *** rafalcpp has joined #bitcoin-core-dev
9082019-06-13T21:26:51  *** queip has quit IRC
9092019-06-13T21:29:41  *** scoop has quit IRC
9102019-06-13T21:30:03  *** scoop has joined #bitcoin-core-dev
9112019-06-13T21:32:01  *** queip has joined #bitcoin-core-dev
9122019-06-13T21:34:02  <wumpus> huh I definitely set up 2FA but not SMS recovery on my github
9132019-06-13T21:34:25  <wumpus> that was a long time ago though, maybe it changed
9142019-06-13T21:37:40  <kanzure> oh, yeah, we should enforce that users can't turn SMS recovery back on
9152019-06-13T21:40:56  *** Victor_sueca has joined #bitcoin-core-dev
9162019-06-13T21:42:13  *** Victorsueca has quit IRC
9172019-06-13T21:44:38  <meshcollider> It's possible to have 2FA without SMS but he means there's no way to enforce it, from an organization setting
9182019-06-13T21:44:55  <meshcollider> GitHub thinks 2FA is 2FA
9192019-06-13T21:45:36  <meshcollider> We could also discuss removing some inactive members from the org which was briefly brought up in discussion too
9202019-06-13T21:52:37  *** scoop has quit IRC
9212019-06-13T21:53:04  *** scoop has joined #bitcoin-core-dev
9222019-06-13T21:53:57  <phantomcircuit> achow101, can we not use acronyms for class names
9232019-06-13T21:54:13  <phantomcircuit> it makes it much more confusing for people who aren't looking at the code everyday
9242019-06-13T21:54:35  <phantomcircuit> wumpus, yes you can set that up on your personal account, but an organization cannot enforce it
9252019-06-13T21:55:06  <achow101> phantomcircuit: where?
9262019-06-13T21:57:04  *** scoop has quit IRC
9272019-06-13T21:57:12  *** scoop has joined #bitcoin-core-dev
9282019-06-13T21:57:54  <phantomcircuit> achow101, the wallet class stuff
9292019-06-13T21:58:04  <phantomcircuit> SPKManager
9302019-06-13T21:58:25  <phantomcircuit> I know it's longer to type and that's kind of annoying without autocomplete, but it's definitely more confusing
9312019-06-13T21:59:52  <phantomcircuit> maybe people disagree with me, but that's what i find looking at stuff i haven't looked at in a while
9322019-06-13T22:20:00  <dongcarl> Would like a bit of feedback on changing `nMaxIPs`: https://github.com/bitcoin/bitcoin/issues/16070#issuecomment-501898990
9332019-06-13T22:26:32  *** bralyclow01 has joined #bitcoin-core-dev
9342019-06-13T22:27:28  *** spinza has quit IRC
9352019-06-13T22:30:03  *** bralyclow has quit IRC
9362019-06-13T22:32:08  *** infernix has joined #bitcoin-core-dev
9372019-06-13T22:47:20  *** cryptapus has quit IRC
9382019-06-13T22:47:56  *** scoop has quit IRC
9392019-06-13T22:48:23  *** scoop has joined #bitcoin-core-dev
9402019-06-13T22:49:07  *** spinza has joined #bitcoin-core-dev
9412019-06-13T22:52:03  *** Zenton has quit IRC
9422019-06-13T22:52:08  *** cryptapus has joined #bitcoin-core-dev
9432019-06-13T22:52:08  *** cryptapus has quit IRC
9442019-06-13T22:52:08  *** cryptapus has joined #bitcoin-core-dev
9452019-06-13T22:53:26  *** scoop has quit IRC
9462019-06-13T22:54:23  *** jarthur_ has joined #bitcoin-core-dev
9472019-06-13T22:56:22  <meshcollider> ScriptPubkeyManager isn't that long I guess
9482019-06-13T22:57:52  *** jarthur has quit IRC
9492019-06-13T22:59:08  *** jarthur_ has quit IRC
9502019-06-13T22:59:30  *** scoop has joined #bitcoin-core-dev
9512019-06-13T23:00:33  *** michaelfolkson has joined #bitcoin-core-dev
9522019-06-13T23:09:16  *** captjakk has quit IRC
9532019-06-13T23:09:29  *** scoop has quit IRC
9542019-06-13T23:09:57  *** scoop has joined #bitcoin-core-dev
9552019-06-13T23:10:32  *** michaelfolkson has quit IRC
9562019-06-13T23:11:23  *** michaelfolkson has joined #bitcoin-core-dev
9572019-06-13T23:14:12  *** scoop has quit IRC
9582019-06-13T23:14:38  *** jtimon has quit IRC
9592019-06-13T23:16:14  *** michaelfolkson has quit IRC
9602019-06-13T23:38:24  *** rafalcpp_ has joined #bitcoin-core-dev
9612019-06-13T23:38:40  *** queip has quit IRC
9622019-06-13T23:38:41  *** rafalcpp has quit IRC
9632019-06-13T23:43:56  *** queip has joined #bitcoin-core-dev
9642019-06-13T23:54:27  *** sheets has joined #bitcoin-core-dev
9652019-06-13T23:57:08  *** scoop has joined #bitcoin-core-dev