12019-06-20T00:00:02 *** guilhermeblanco has quit IRC
22019-06-20T00:00:39 *** elichai2 has quit IRC
32019-06-20T00:02:31 *** Squidicuz has quit IRC
42019-06-20T00:04:18 *** geekounet has joined #bitcoin-core-dev
52019-06-20T00:10:04 *** scoop has quit IRC
62019-06-20T00:10:36 *** scoop has joined #bitcoin-core-dev
72019-06-20T00:19:03 *** Chris_Stewart_5 has quit IRC
82019-06-20T00:19:51 *** Chris_Stewart_5 has joined #bitcoin-core-dev
92019-06-20T00:32:19 *** infinitis has joined #bitcoin-core-dev
102019-06-20T00:32:28 *** midnightmagic has quit IRC
112019-06-20T00:33:21 *** Squidicuz has joined #bitcoin-core-dev
122019-06-20T00:36:21 *** promag_ has joined #bitcoin-core-dev
132019-06-20T00:38:30 *** Chris_Stewart_5 has quit IRC
142019-06-20T00:40:04 *** promag_ has quit IRC
152019-06-20T00:49:04 *** justanotheruser has quit IRC
162019-06-20T00:57:51 *** aseem has joined #bitcoin-core-dev
172019-06-20T00:57:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
182019-06-20T01:01:13 *** shesek has quit IRC
192019-06-20T01:04:49 *** aseem has quit IRC
202019-06-20T01:04:54 *** JamesAU has joined #bitcoin-core-dev
212019-06-20T01:09:25 *** JamesAU has quit IRC
222019-06-20T01:10:31 *** JamesAU has joined #bitcoin-core-dev
232019-06-20T01:11:45 *** surja795 has joined #bitcoin-core-dev
242019-06-20T01:18:32 *** pinheadmz has quit IRC
252019-06-20T01:22:47 *** DeanWeen has joined #bitcoin-core-dev
262019-06-20T01:23:16 *** Chris_Stewart_5 has quit IRC
272019-06-20T01:23:31 *** bralyclow has quit IRC
282019-06-20T01:35:38 *** justanotheruser has joined #bitcoin-core-dev
292019-06-20T01:37:09 *** hugohn has joined #bitcoin-core-dev
302019-06-20T01:39:08 *** bralyclow has joined #bitcoin-core-dev
312019-06-20T01:40:05 *** hugohn has joined #bitcoin-core-dev
322019-06-20T01:48:33 *** infinitis has quit IRC
332019-06-20T01:51:42 *** pinheadmz has joined #bitcoin-core-dev
342019-06-20T01:55:14 *** booyah has quit IRC
352019-06-20T01:55:16 *** gribble has quit IRC
362019-06-20T01:56:58 *** booyah has joined #bitcoin-core-dev
372019-06-20T01:57:40 *** harding has quit IRC
382019-06-20T02:04:01 *** harding has joined #bitcoin-core-dev
392019-06-20T02:11:58 *** gribble has joined #bitcoin-core-dev
402019-06-20T02:12:57 *** justanotheruser has quit IRC
412019-06-20T02:13:10 *** ccdle12 has joined #bitcoin-core-dev
422019-06-20T02:28:37 *** hugohn has quit IRC
432019-06-20T02:42:44 *** justanotheruser has joined #bitcoin-core-dev
442019-06-20T02:47:31 *** hugohn has joined #bitcoin-core-dev
452019-06-20T03:00:01 *** geekounet has quit IRC
462019-06-20T03:06:09 *** ddustin has quit IRC
472019-06-20T03:06:47 *** ddustin has joined #bitcoin-core-dev
482019-06-20T03:08:41 *** tryphe_ has joined #bitcoin-core-dev
492019-06-20T03:09:52 *** tryphe has quit IRC
502019-06-20T03:10:00 *** tryphe_ is now known as tryphe
512019-06-20T03:12:32 *** ddustin has quit IRC
522019-06-20T03:14:28 *** AaronvanW has quit IRC
532019-06-20T03:20:21 *** lgedeon has joined #bitcoin-core-dev
542019-06-20T03:32:13 *** DeanWeen has quit IRC
552019-06-20T03:35:22 *** JamesAU_ has joined #bitcoin-core-dev
562019-06-20T03:39:28 *** JamesAU has quit IRC
572019-06-20T03:44:17 *** pinheadmz has quit IRC
582019-06-20T03:45:13 *** hebasto has joined #bitcoin-core-dev
592019-06-20T03:45:58 *** AaronvanW has joined #bitcoin-core-dev
602019-06-20T03:47:22 *** bitcoin-git has joined #bitcoin-core-dev
612019-06-20T03:47:22 <bitcoin-git> [bitcoin] NicolasDorier opened pull request #16246: MSVC: Fix error in debug mode (Fix #16245) (master...fix/bigobj) https://github.com/bitcoin/bitcoin/pull/16246
622019-06-20T03:47:24 *** bitcoin-git has left #bitcoin-core-dev
632019-06-20T03:49:28 *** JamesAU_ has quit IRC
642019-06-20T03:51:02 *** AaronvanW has quit IRC
652019-06-20T03:52:56 *** surja795 has quit IRC
662019-06-20T04:12:19 *** JamesAU has joined #bitcoin-core-dev
672019-06-20T04:23:27 *** tryphe_ has joined #bitcoin-core-dev
682019-06-20T04:24:16 *** AaronvanW has joined #bitcoin-core-dev
692019-06-20T04:25:52 *** tryphe has quit IRC
702019-06-20T04:42:40 *** jnewbery has quit IRC
712019-06-20T04:43:03 *** sdaftuar has quit IRC
722019-06-20T04:56:54 *** AaronvanW has quit IRC
732019-06-20T04:58:31 *** surja795 has joined #bitcoin-core-dev
742019-06-20T05:00:31 *** pinheadmz has joined #bitcoin-core-dev
752019-06-20T05:01:26 *** pinheadmz has quit IRC
762019-06-20T05:02:18 *** pinheadmz has joined #bitcoin-core-dev
772019-06-20T05:03:22 *** surja795 has quit IRC
782019-06-20T05:06:23 *** bralyclow has quit IRC
792019-06-20T05:13:22 *** dviola has joined #bitcoin-core-dev
802019-06-20T05:15:47 *** ccdle12 has quit IRC
812019-06-20T05:21:38 *** ccdle12 has joined #bitcoin-core-dev
822019-06-20T05:24:23 *** hugohn has quit IRC
832019-06-20T05:24:51 *** DeanWeen has joined #bitcoin-core-dev
842019-06-20T05:26:24 *** ccdle12 has quit IRC
852019-06-20T05:29:48 *** hugohn has joined #bitcoin-core-dev
862019-06-20T05:31:35 *** cubancorona has quit IRC
872019-06-20T05:31:55 *** cubancorona has joined #bitcoin-core-dev
882019-06-20T05:36:33 *** bralyclow has joined #bitcoin-core-dev
892019-06-20T05:38:52 *** hugohn has quit IRC
902019-06-20T05:48:41 *** jnewbery has joined #bitcoin-core-dev
912019-06-20T05:54:59 *** scoop has quit IRC
922019-06-20T05:55:14 *** sdaftuar has joined #bitcoin-core-dev
932019-06-20T06:00:01 *** lgedeon has quit IRC
942019-06-20T06:00:53 *** AaronvanW has joined #bitcoin-core-dev
952019-06-20T06:03:49 *** bralyclow has quit IRC
962019-06-20T06:04:22 *** bralyclow has joined #bitcoin-core-dev
972019-06-20T06:04:50 *** Dogechain has joined #bitcoin-core-dev
982019-06-20T06:11:27 *** ghost43 has quit IRC
992019-06-20T06:13:03 *** ghost43 has joined #bitcoin-core-dev
1002019-06-20T06:14:48 *** keymone has quit IRC
1012019-06-20T06:18:07 *** keymone has joined #bitcoin-core-dev
1022019-06-20T06:18:59 *** d_t has quit IRC
1032019-06-20T06:26:48 *** spinza has quit IRC
1042019-06-20T06:33:16 *** spinza has joined #bitcoin-core-dev
1052019-06-20T06:41:17 *** ccdle12 has joined #bitcoin-core-dev
1062019-06-20T06:45:46 *** ccdle12 has quit IRC
1072019-06-20T06:47:32 *** harding has quit IRC
1082019-06-20T07:04:17 *** reallll has quit IRC
1092019-06-20T07:04:49 *** AaronvanW has quit IRC
1102019-06-20T07:13:09 *** rex4539 has joined #bitcoin-core-dev
1112019-06-20T07:14:08 *** belcher has joined #bitcoin-core-dev
1122019-06-20T07:17:30 *** bralyclow has quit IRC
1132019-06-20T07:17:43 *** JamesAU has quit IRC
1142019-06-20T07:18:51 *** JamesAU has joined #bitcoin-core-dev
1152019-06-20T07:27:16 *** queip has quit IRC
1162019-06-20T07:27:55 *** rafalcpp has joined #bitcoin-core-dev
1172019-06-20T07:28:16 *** rafalcpp_ has quit IRC
1182019-06-20T07:34:36 *** queip has joined #bitcoin-core-dev
1192019-06-20T07:35:31 *** gribble has quit IRC
1202019-06-20T07:37:34 *** dviola has quit IRC
1212019-06-20T07:37:46 *** AaronvanW has joined #bitcoin-core-dev
1222019-06-20T07:49:50 *** hrofu has quit IRC
1232019-06-20T07:50:19 *** ccdle12 has joined #bitcoin-core-dev
1242019-06-20T07:50:51 *** hrofu has joined #bitcoin-core-dev
1252019-06-20T07:54:46 *** ccdle12 has quit IRC
1262019-06-20T07:55:26 *** scoop has joined #bitcoin-core-dev
1272019-06-20T07:59:38 *** scoop has quit IRC
1282019-06-20T08:00:46 *** kljasdfvv has joined #bitcoin-core-dev
1292019-06-20T08:03:06 *** gribble has joined #bitcoin-core-dev
1302019-06-20T08:04:16 *** ORVANEX has joined #bitcoin-core-dev
1312019-06-20T08:05:12 *** ORVANEX has left #bitcoin-core-dev
1322019-06-20T08:05:57 *** dviola has joined #bitcoin-core-dev
1332019-06-20T08:07:51 *** rafalcpp_ has joined #bitcoin-core-dev
1342019-06-20T08:07:52 *** rafalcpp has quit IRC
1352019-06-20T08:10:27 *** AaronvanW has quit IRC
1362019-06-20T08:12:49 *** laptop500 has joined #bitcoin-core-dev
1372019-06-20T08:15:46 *** teardown has joined #bitcoin-core-dev
1382019-06-20T08:19:07 *** Akindev has joined #bitcoin-core-dev
1392019-06-20T08:20:16 *** Akindev has quit IRC
1402019-06-20T08:41:00 *** setpill has joined #bitcoin-core-dev
1412019-06-20T09:00:01 *** Dogechain has quit IRC
1422019-06-20T09:02:18 *** timothy has joined #bitcoin-core-dev
1432019-06-20T09:05:46 *** rex4539 has quit IRC
1442019-06-20T09:13:47 *** bralyclow has joined #bitcoin-core-dev
1452019-06-20T09:24:31 *** rafalcpp_ has quit IRC
1462019-06-20T09:24:38 *** rafalcpp has joined #bitcoin-core-dev
1472019-06-20T09:25:25 *** queip has quit IRC
1482019-06-20T09:29:57 *** queip has joined #bitcoin-core-dev
1492019-06-20T09:35:21 *** darosior has joined #bitcoin-core-dev
1502019-06-20T09:41:35 *** Mikaku1 has joined #bitcoin-core-dev
1512019-06-20T09:44:31 *** bitcoin-git has joined #bitcoin-core-dev
1522019-06-20T09:44:32 <bitcoin-git> [bitcoin] NicolasDorier opened pull request #16248: [WIP] Make whitebind/whitelist permissions more flexible (master...feature/permissions) https://github.com/bitcoin/bitcoin/pull/16248
1532019-06-20T09:44:33 *** bitcoin-git has left #bitcoin-core-dev
1542019-06-20T09:46:03 *** bitcoin-git has joined #bitcoin-core-dev
1552019-06-20T09:46:03 <bitcoin-git> [bitcoin] NicolasDorier closed pull request #16176: Allow NODE_BLOOM services for whitelisted peers (master...feature/node-bloom-whitelisted) https://github.com/bitcoin/bitcoin/pull/16176
1562019-06-20T09:46:04 *** bitcoin-git has left #bitcoin-core-dev
1572019-06-20T09:46:20 *** bralyclow has quit IRC
1582019-06-20T09:50:55 *** AaronvanW has joined #bitcoin-core-dev
1592019-06-20T10:15:17 *** ccdle12 has joined #bitcoin-core-dev
1602019-06-20T10:15:28 *** omonk has quit IRC
1612019-06-20T10:17:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1622019-06-20T10:20:02 *** ccdle12 has quit IRC
1632019-06-20T10:24:11 *** ccdle12 has joined #bitcoin-core-dev
1642019-06-20T10:32:27 *** surja795 has joined #bitcoin-core-dev
1652019-06-20T10:37:07 *** surja795 has quit IRC
1662019-06-20T10:44:12 *** spinza has quit IRC
1672019-06-20T10:49:12 *** spinza has joined #bitcoin-core-dev
1682019-06-20T10:54:31 *** spinza has quit IRC
1692019-06-20T10:58:24 *** rafalcpp_ has joined #bitcoin-core-dev
1702019-06-20T10:58:48 *** queip has quit IRC
1712019-06-20T10:59:57 *** rafalcpp has quit IRC
1722019-06-20T11:01:27 *** EagleTM has joined #bitcoin-core-dev
1732019-06-20T11:01:58 *** dviola has quit IRC
1742019-06-20T11:02:15 *** ccdle12 has quit IRC
1752019-06-20T11:02:21 *** michaelfolkson has joined #bitcoin-core-dev
1762019-06-20T11:02:42 *** ccdle12 has joined #bitcoin-core-dev
1772019-06-20T11:03:51 *** Eagle[TM] has joined #bitcoin-core-dev
1782019-06-20T11:04:03 *** spinza has joined #bitcoin-core-dev
1792019-06-20T11:04:47 *** queip has joined #bitcoin-core-dev
1802019-06-20T11:05:52 *** EagleTM has quit IRC
1812019-06-20T11:09:12 *** ccdle12 has quit IRC
1822019-06-20T11:10:48 *** michaelfolkson has quit IRC
1832019-06-20T11:12:41 *** harding has joined #bitcoin-core-dev
1842019-06-20T11:13:22 *** bralyclow has joined #bitcoin-core-dev
1852019-06-20T11:13:54 *** michaelfolkson has joined #bitcoin-core-dev
1862019-06-20T11:19:44 *** sdaftuar has quit IRC
1872019-06-20T11:20:11 *** sdaftuar has joined #bitcoin-core-dev
1882019-06-20T11:20:38 *** michaelfolkson has quit IRC
1892019-06-20T11:27:32 *** aseem has joined #bitcoin-core-dev
1902019-06-20T11:27:47 *** Eagle[TM] has quit IRC
1912019-06-20T11:28:17 *** cubancorona has quit IRC
1922019-06-20T11:32:49 *** justanotheruser has quit IRC
1932019-06-20T11:35:14 *** queip has quit IRC
1942019-06-20T11:35:14 *** rafalcpp_ has quit IRC
1952019-06-20T11:35:16 *** rafalcpp has joined #bitcoin-core-dev
1962019-06-20T11:36:42 *** aseem has quit IRC
1972019-06-20T11:37:07 *** Chris_Stewart_5 has quit IRC
1982019-06-20T11:39:53 *** aseem has joined #bitcoin-core-dev
1992019-06-20T11:41:06 *** queip has joined #bitcoin-core-dev
2002019-06-20T11:41:59 *** aseem has quit IRC
2012019-06-20T11:42:39 *** justanotheruser has joined #bitcoin-core-dev
2022019-06-20T11:43:02 *** omonk has joined #bitcoin-core-dev
2032019-06-20T11:45:20 *** bitcoin-git has joined #bitcoin-core-dev
2042019-06-20T11:45:21 <bitcoin-git> [bitcoin] ajtowns opened pull request #16250: signrawtransactionwithkey: report error when missing redeemScript/witnessScript (master...201906-signrawerror-regression) https://github.com/bitcoin/bitcoin/pull/16250
2052019-06-20T11:45:22 *** bitcoin-git has left #bitcoin-core-dev
2062019-06-20T11:46:43 *** bralyclow has quit IRC
2072019-06-20T11:48:34 *** omonk has quit IRC
2082019-06-20T12:00:01 *** Mikaku1 has quit IRC
2092019-06-20T12:00:35 *** darosior has quit IRC
2102019-06-20T12:07:58 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2112019-06-20T12:18:26 *** scoop has joined #bitcoin-core-dev
2122019-06-20T12:20:32 *** timothy has quit IRC
2132019-06-20T12:23:48 *** Guyver2 has joined #bitcoin-core-dev
2142019-06-20T12:23:50 *** hugohn has joined #bitcoin-core-dev
2152019-06-20T12:25:49 *** timothy has joined #bitcoin-core-dev
2162019-06-20T12:29:58 *** hugohn has quit IRC
2172019-06-20T12:40:24 *** darosior has joined #bitcoin-core-dev
2182019-06-20T12:41:35 *** ccdle12_ has joined #bitcoin-core-dev
2192019-06-20T12:41:39 *** ccdle12 has joined #bitcoin-core-dev
2202019-06-20T12:45:31 *** ccdle12 has joined #bitcoin-core-dev
2212019-06-20T12:45:33 *** bitcoin-git has joined #bitcoin-core-dev
2222019-06-20T12:45:33 <bitcoin-git> [bitcoin] ajtowns opened pull request #16251: Improve signrawtransaction error reporting (master...201906-signrawerror) https://github.com/bitcoin/bitcoin/pull/16251
2232019-06-20T12:45:36 *** bitcoin-git has left #bitcoin-core-dev
2242019-06-20T12:47:57 *** ccdle12_ has quit IRC
2252019-06-20T12:47:57 *** omonk has joined #bitcoin-core-dev
2262019-06-20T12:51:09 *** omonk has quit IRC
2272019-06-20T12:53:48 *** ccdle12 has quit IRC
2282019-06-20T12:55:36 *** ccdle12 has joined #bitcoin-core-dev
2292019-06-20T12:58:01 *** ccdle12_ has joined #bitcoin-core-dev
2302019-06-20T12:58:56 *** ccdle12 has quit IRC
2312019-06-20T13:02:47 *** michaelfolkson has joined #bitcoin-core-dev
2322019-06-20T13:07:42 *** fsargent has joined #bitcoin-core-dev
2332019-06-20T13:09:48 *** timothy has quit IRC
2342019-06-20T13:14:41 <fanquake> Iâm quite unwell, so wonât be up at the meeting. +1 for 2FA. Ideally not text message based.
2352019-06-20T13:16:26 *** Guyver2 has quit IRC
2362019-06-20T13:19:01 *** michaelfolkson has quit IRC
2372019-06-20T13:19:44 *** timothy has joined #bitcoin-core-dev
2382019-06-20T13:20:00 <fanquake> #proposedmeetingtopic ASN blob discussion that was missed at the end of last meeting. Assuming sipa and bluematt are available.
2392019-06-20T13:25:37 *** timothy has quit IRC
2402019-06-20T13:25:47 *** timothy has joined #bitcoin-core-dev
2412019-06-20T13:41:26 *** bitcoin-git has joined #bitcoin-core-dev
2422019-06-20T13:41:27 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16252: test: Log to debug.log in all unit tests (master...1905-bufferLog) https://github.com/bitcoin/bitcoin/pull/16252
2432019-06-20T13:41:28 *** bitcoin-git has left #bitcoin-core-dev
2442019-06-20T13:43:29 *** bralyclow has joined #bitcoin-core-dev
2452019-06-20T13:49:25 *** aseem has joined #bitcoin-core-dev
2462019-06-20T13:52:28 *** omonk has joined #bitcoin-core-dev
2472019-06-20T13:58:09 *** omonk has quit IRC
2482019-06-20T14:02:18 *** paracyst has quit IRC
2492019-06-20T14:02:28 *** paracyst_ has joined #bitcoin-core-dev
2502019-06-20T14:05:35 *** d_t has joined #bitcoin-core-dev
2512019-06-20T14:11:56 *** ccdle12 has joined #bitcoin-core-dev
2522019-06-20T14:11:57 *** ccdle12_ has quit IRC
2532019-06-20T14:13:04 *** kristapsk has quit IRC
2542019-06-20T14:13:48 *** bralyclow has quit IRC
2552019-06-20T14:14:27 *** bralyclow has joined #bitcoin-core-dev
2562019-06-20T14:15:12 *** nullptr| has quit IRC
2572019-06-20T14:16:44 *** nullptr| has joined #bitcoin-core-dev
2582019-06-20T14:20:53 *** ccdle12_ has joined #bitcoin-core-dev
2592019-06-20T14:21:58 *** ccdle12 has quit IRC
2602019-06-20T14:23:04 *** rafalcpp_ has joined #bitcoin-core-dev
2612019-06-20T14:23:44 *** queip has quit IRC
2622019-06-20T14:23:48 *** rafalcpp has quit IRC
2632019-06-20T14:29:16 *** queip has joined #bitcoin-core-dev
2642019-06-20T14:35:45 *** spaced0ut has quit IRC
2652019-06-20T15:00:01 *** fsargent has quit IRC
2662019-06-20T15:00:44 *** setpill has quit IRC
2672019-06-20T15:04:16 *** feb1 has joined #bitcoin-core-dev
2682019-06-20T15:04:22 *** ccdle12_ has quit IRC
2692019-06-20T15:04:22 *** ccdle12 has joined #bitcoin-core-dev
2702019-06-20T15:04:33 *** bralyclow has quit IRC
2712019-06-20T15:05:33 *** ccdle12 has quit IRC
2722019-06-20T15:05:34 *** bralyclow has joined #bitcoin-core-dev
2732019-06-20T15:06:02 *** ccdle12 has joined #bitcoin-core-dev
2742019-06-20T15:10:36 *** bralyclow has quit IRC
2752019-06-20T15:13:14 *** d_t has quit IRC
2762019-06-20T15:16:50 *** rafalcpp has joined #bitcoin-core-dev
2772019-06-20T15:17:10 *** queip has quit IRC
2782019-06-20T15:17:34 *** rafalcpp_ has quit IRC
2792019-06-20T15:22:59 *** queip has joined #bitcoin-core-dev
2802019-06-20T15:23:16 *** jarthur has joined #bitcoin-core-dev
2812019-06-20T15:29:46 *** user_____ has joined #bitcoin-core-dev
2822019-06-20T15:35:48 *** captjakk has joined #bitcoin-core-dev
2832019-06-20T15:38:03 *** bralyclow has joined #bitcoin-core-dev
2842019-06-20T15:41:06 *** Guyver2 has joined #bitcoin-core-dev
2852019-06-20T15:43:53 *** captjakk has quit IRC
2862019-06-20T15:45:39 *** rafalcpp_ has joined #bitcoin-core-dev
2872019-06-20T15:46:00 <MarcoFalke> Anyone knows how to report scams to duckduckgo? https://duckduckgo.com/?q=bitcoin+core+release+notes
2882019-06-20T15:46:08 *** rafalcpp has quit IRC
2892019-06-20T15:46:15 <MarcoFalke> returns "bitcoincorewallet org" as third result
2902019-06-20T15:46:33 <MarcoFalke> obviously malware
2912019-06-20T15:46:36 *** captjakk has joined #bitcoin-core-dev
2922019-06-20T15:46:42 *** queip has quit IRC
2932019-06-20T15:50:49 *** queip has joined #bitcoin-core-dev
2942019-06-20T15:53:50 *** kljasdfvv has quit IRC
2952019-06-20T15:55:20 *** hirish has joined #bitcoin-core-dev
2962019-06-20T15:55:31 *** wumpus2 has joined #bitcoin-core-dev
2972019-06-20T15:55:47 *** wallet42_ has joined #bitcoin-core-dev
2982019-06-20T15:56:02 *** Karyon_ has joined #bitcoin-core-dev
2992019-06-20T15:57:08 *** TheHoliestRoger_ has joined #bitcoin-core-dev
3002019-06-20T15:57:18 *** kallewoof_ has joined #bitcoin-core-dev
3012019-06-20T15:57:24 *** Lauda_ has joined #bitcoin-core-dev
3022019-06-20T15:58:50 *** wumpus has quit IRC
3032019-06-20T15:58:55 *** wumpus2 is now known as wumpus
3042019-06-20T15:59:19 *** e4xit_ has joined #bitcoin-core-dev
3052019-06-20T16:01:21 *** chainhead_ has joined #bitcoin-core-dev
3062019-06-20T16:02:32 *** michaelsdunn1_ has joined #bitcoin-core-dev
3072019-06-20T16:03:12 *** wallet42 has quit IRC
3082019-06-20T16:03:12 *** TheHoliestRoger has quit IRC
3092019-06-20T16:03:12 *** cluelessperson has quit IRC
3102019-06-20T16:03:12 *** Karyon has quit IRC
3112019-06-20T16:03:12 *** profmac has quit IRC
3122019-06-20T16:03:12 *** e4xit has quit IRC
3132019-06-20T16:03:12 *** michaelsdunn1 has quit IRC
3142019-06-20T16:03:12 *** kallewoof has quit IRC
3152019-06-20T16:03:12 *** Lauda has quit IRC
3162019-06-20T16:03:12 *** chainhead has quit IRC
3172019-06-20T16:03:12 *** hirish_ has quit IRC
3182019-06-20T16:03:13 *** Karyon_ is now known as Karyon
3192019-06-20T16:03:13 *** wallet42_ is now known as wallet42
3202019-06-20T16:04:22 *** infernix has quit IRC
3212019-06-20T16:04:46 *** kallewoof_ has left #bitcoin-core-dev
3222019-06-20T16:06:38 *** kallewoof has joined #bitcoin-core-dev
3232019-06-20T16:08:07 *** luke-jr has quit IRC
3242019-06-20T16:08:35 *** luke-jr has joined #bitcoin-core-dev
3252019-06-20T16:10:29 *** profmac has joined #bitcoin-core-dev
3262019-06-20T16:11:36 *** bralyclow has quit IRC
3272019-06-20T16:13:06 *** infernix has joined #bitcoin-core-dev
3282019-06-20T16:18:37 *** Lauda_ has left #bitcoin-core-dev
3292019-06-20T16:18:59 *** Lauda has joined #bitcoin-core-dev
3302019-06-20T16:24:56 *** spaced0ut has joined #bitcoin-core-dev
3312019-06-20T16:28:16 *** scoop has quit IRC
3322019-06-20T16:32:07 *** Chris_Stewart_5 has quit IRC
3332019-06-20T16:33:34 <moneyball> MarcoFalke not sure but perhaps https://twitter.com/duckduckgo? although I think you said you quit Twitter. I can report it. Do we have evidence of malware? Or should I just say it looks suspicious?
3342019-06-20T16:44:27 *** elichai2 has joined #bitcoin-core-dev
3352019-06-20T16:45:21 *** scoop has joined #bitcoin-core-dev
3362019-06-20T16:47:28 *** cubancorona has joined #bitcoin-core-dev
3372019-06-20T16:49:06 *** ccdle12_ has joined #bitcoin-core-dev
3382019-06-20T16:49:09 *** aseem has quit IRC
3392019-06-20T16:49:12 *** ccdle12 has quit IRC
3402019-06-20T16:49:43 <MarcoFalke> Download any of the .exe or .zip and compare the hash
3412019-06-20T16:50:18 <MarcoFalke> Even if the hash matched, it is not our website and not the official download location
3422019-06-20T16:51:19 *** aseem has joined #bitcoin-core-dev
3432019-06-20T16:52:32 *** ccdle12_ has quit IRC
3442019-06-20T16:52:54 *** ccdle12 has joined #bitcoin-core-dev
3452019-06-20T16:55:06 <moneyball> https://twitter.com/moneyball/status/1141751255070416897
3462019-06-20T16:56:26 *** kristapsk has joined #bitcoin-core-dev
3472019-06-20T16:56:42 *** ccdle12_ has joined #bitcoin-core-dev
3482019-06-20T16:56:48 *** ccdle12 has quit IRC
3492019-06-20T16:56:59 *** lightlike has joined #bitcoin-core-dev
3502019-06-20T17:00:31 *** kristapsk has quit IRC
3512019-06-20T17:00:54 *** kristapsk has joined #bitcoin-core-dev
3522019-06-20T17:01:20 *** ccdle12_ has quit IRC
3532019-06-20T17:02:45 *** bralyclow has joined #bitcoin-core-dev
3542019-06-20T17:04:30 *** bralyclow has quit IRC
3552019-06-20T17:04:49 *** bitcoin-git has joined #bitcoin-core-dev
3562019-06-20T17:04:49 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16192: Wallet: Catches situations where capping on maxtxfee drops the fee too low (master...issue-10122) https://github.com/bitcoin/bitcoin/pull/16192
3572019-06-20T17:04:52 *** bitcoin-git has left #bitcoin-core-dev
3582019-06-20T17:05:09 *** bitcoin-git has joined #bitcoin-core-dev
3592019-06-20T17:05:10 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16192: Wallet: Catches situations where capping on maxtxfee drops the fee too low (master...issue-10122) https://github.com/bitcoin/bitcoin/pull/16192
3602019-06-20T17:05:12 *** bitcoin-git has left #bitcoin-core-dev
3612019-06-20T17:06:02 *** bralyclow has joined #bitcoin-core-dev
3622019-06-20T17:07:56 *** captjakk has quit IRC
3632019-06-20T17:08:12 *** captjakk has joined #bitcoin-core-dev
3642019-06-20T17:10:22 *** bralyclow has quit IRC
3652019-06-20T17:17:31 <MarcoFalke> moneyball: thx
3662019-06-20T17:17:52 *** bralyclow has joined #bitcoin-core-dev
3672019-06-20T17:21:17 *** cubancorona has quit IRC
3682019-06-20T17:21:36 *** cubancorona has joined #bitcoin-core-dev
3692019-06-20T17:24:17 *** captjakk has quit IRC
3702019-06-20T17:26:55 *** DeanWeen has quit IRC
3712019-06-20T17:28:25 *** darosior has quit IRC
3722019-06-20T17:29:24 *** captjakk has joined #bitcoin-core-dev
3732019-06-20T17:33:00 *** cubancorona has quit IRC
3742019-06-20T17:33:19 *** cubancorona has joined #bitcoin-core-dev
3752019-06-20T17:37:19 *** timothy has quit IRC
3762019-06-20T17:41:24 <BlueMatt> lol 3 dnsseeds have broken ipv6 resolvers.......
3772019-06-20T17:43:24 <moneyball> fyi i also emailed abuse@ and cc'd MarcoFalke
3782019-06-20T17:43:33 <BlueMatt> thanks moneyball!
3792019-06-20T17:50:33 *** sfhi has joined #bitcoin-core-dev
3802019-06-20T17:51:34 *** bitcoin-git has joined #bitcoin-core-dev
3812019-06-20T17:51:34 <bitcoin-git> [bitcoin] hebasto opened pull request #16254: qt: Set AA_EnableHighDpiScaling attribute early (master...20190620-EnableHighDpiScaling-warning) https://github.com/bitcoin/bitcoin/pull/16254
3822019-06-20T17:51:38 *** bitcoin-git has left #bitcoin-core-dev
3832019-06-20T17:53:25 <BlueMatt> sipa: maybe your seeder is broken for resolving over v6?
3842019-06-20T17:56:09 *** bitcoin-git has joined #bitcoin-core-dev
3852019-06-20T17:56:10 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16255: util: Remove code to cache datadir (master...1906-utilNoPath) https://github.com/bitcoin/bitcoin/pull/16255
3862019-06-20T17:56:11 *** bitcoin-git has left #bitcoin-core-dev
3872019-06-20T17:58:36 <sipa> BlueMatt: it seems the vps it's running on doesn't have a v6 ip address :s
3882019-06-20T17:59:04 <BlueMatt> sipa: no, I mean the software
3892019-06-20T17:59:15 <BlueMatt> sipa: cause it seems several others have v6 issues and theirs does
3902019-06-20T18:00:02 *** feb1 has quit IRC
3912019-06-20T18:00:04 <sipa> BlueMatt: my seeder has v6 addresses, but they're all marked "bad"
3922019-06-20T18:00:24 <sipa> so i suspect that's why it's not reporting any over dns
3932019-06-20T18:00:26 <BlueMatt> sipa: nonono, I mean the seeder software responding to dns queries over v6
3942019-06-20T18:00:55 *** rex4539 has joined #bitcoin-core-dev
3952019-06-20T18:01:17 <sipa> it's responding for me, just with an empty result
3962019-06-20T18:01:36 <sipa> $ dig -t AAAA @bitcoin.sipa.be seed.bitcoin.sipa.be
3972019-06-20T18:01:59 <BlueMatt> sipa: noooo
3982019-06-20T18:02:11 <BlueMatt> I mean $ dig @(bitcoin.sipa.be's ipv6 address) seed.bitcoin.sipa.be
3992019-06-20T18:02:43 <luke-jr> in my case, I don't want to run the seeder as root, so I have a NAT from port 53 to 1053, but my server doesn't support NAT for IPV6
4002019-06-20T18:03:00 <luke-jr> removed the AAAA record for the NS for now
4012019-06-20T18:03:03 <sipa> BlueMatt: ... my server has no IPv6 address
4022019-06-20T18:03:09 <BlueMatt> yea, you're different, mostly I see that (at least) emzy's and jonasschnelli's servers dont respond
4032019-06-20T18:03:18 <BlueMatt> sipa: yes...I'm asking about the software (which other seeders run)
4042019-06-20T18:03:36 <sipa> ah ok, it seems there are two distinct problems
4052019-06-20T18:04:30 <luke-jr> BlueMatt: the software is listening to IPv6 1053 for me
4062019-06-20T18:04:56 <BlueMatt> luke-jr: can you try to resolve via that?
4072019-06-20T18:07:24 <phantomcircuit> BlueMatt, hi
4082019-06-20T18:07:46 <BlueMatt> you rang?
4092019-06-20T18:07:56 <luke-jr> dig -p 1053 @2001:470:88ff:2e::1 AAAA dnsseed.bitcoin.dashjr.org
4102019-06-20T18:07:57 <luke-jr> seems to work
4112019-06-20T18:08:22 <BlueMatt> ah weird, maybe something specific about the version/setup on emzy and jonasschnelli's ends :/
4122019-06-20T18:08:51 <hebasto> MarcoFalke: in #16254 should we follow qt docs: "Supported platforms are X11, Windows and Android."? I mean no mention of macOS.
4132019-06-20T18:08:52 <gribble> https://github.com/bitcoin/bitcoin/issues/16254 | qt: Set AA_EnableHighDpiScaling attribute early by hebasto · Pull Request #16254 · bitcoin/bitcoin · GitHub
4142019-06-20T18:09:22 *** bitcoin-git has joined #bitcoin-core-dev
4152019-06-20T18:09:22 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16255: util: Remove code to cache datadir (master...1906-utilNoPath) https://github.com/bitcoin/bitcoin/pull/16255
4162019-06-20T18:09:35 *** bitcoin-git has left #bitcoin-core-dev
4172019-06-20T18:10:01 <jonasschnelli> Yeah. It's the NAT
4182019-06-20T18:10:03 <jonasschnelli> dig -p 5353 @2604:a880:2:d0::469c:c001 AAAA seed.bitcoin.jonasschnelli.ch
4192019-06-20T18:10:05 <jonasschnelli> works as well
4202019-06-20T18:10:33 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4212019-06-20T18:10:45 <jonasschnelli> I do iptables -t nat -A PREROUTING -p udp --dport 53 -j REDIRECT --to-port 5353
4222019-06-20T18:10:59 <BlueMatt> ah, should be able to do that for v6 too
4232019-06-20T18:11:31 <BlueMatt> "IPv6 support available starting Linux kernels >= 3.7." (for REDIRECT)
4242019-06-20T18:12:25 *** rafalcpp has joined #bitcoin-core-dev
4252019-06-20T18:12:31 <jonasschnelli> I guess I need ip6tables
4262019-06-20T18:12:32 *** rafalcpp_ has quit IRC
4272019-06-20T18:13:00 *** queip has quit IRC
4282019-06-20T18:13:15 *** emilengler has joined #bitcoin-core-dev
4292019-06-20T18:14:10 *** aseem has quit IRC
4302019-06-20T18:15:02 <BlueMatt> indeed
4312019-06-20T18:15:46 <jonasschnelli> instead of the stupid NAT, why don't allow the dnsseed user to use UDP 53 directly?
4322019-06-20T18:15:56 <jonasschnelli> (should also work without root)
4332019-06-20T18:16:17 <luke-jr> ?
4342019-06-20T18:16:39 <luke-jr> Linux doesn't allow non-root to listen below 1024
4352019-06-20T18:16:43 <jonasschnelli> luke-jr: we do the NAT to avoid running the seeder as root
4362019-06-20T18:16:51 <jonasschnelli> setcap?
4372019-06-20T18:17:26 <BlueMatt> bind + drop
4382019-06-20T18:18:08 *** queip has joined #bitcoin-core-dev
4392019-06-20T18:18:21 <luke-jr> dunno why Linux doesn't add a way to assign ports to specific users :/
4402019-06-20T18:18:39 <luke-jr> that would also be nice to block other users from binding the Bitcoin JSON-RPC port
4412019-06-20T18:19:33 <BlueMatt> you could use inetd, no?
4422019-06-20T18:19:42 *** v4hn has joined #bitcoin-core-dev
4432019-06-20T18:20:56 *** emilengler has quit IRC
4442019-06-20T18:21:18 <jonasschnelli> solved....
4452019-06-20T18:21:23 <jonasschnelli> dig -p 53 @2604:a880:2:d0::469c:c001 AAAA seed.bitcoin.jonasschnelli.ch <--- works now
4462019-06-20T18:21:47 <jonasschnelli> (testnet seed as well)
4472019-06-20T18:21:57 *** sfhi has quit IRC
4482019-06-20T18:23:36 *** emilengler has joined #bitcoin-core-dev
4492019-06-20T18:24:39 <phantomcircuit> luke-jr, you can with the power of selinux
4502019-06-20T18:24:41 * phantomcircuit runs
4512019-06-20T18:26:44 *** ddustin has joined #bitcoin-core-dev
4522019-06-20T18:26:45 <gertjaap> are there any docs on how to run the linters and checks that travis does locally before committing? i hate to bother reviewers with stuff that i should've caught before committing.
4532019-06-20T18:28:21 *** d_t has joined #bitcoin-core-dev
4542019-06-20T18:28:56 <gertjaap> if i run test/lint/lint-all.sh it does catch the whitespace errors from my PR, but also a whole bunch of other stuff like unused functions and spelling errors.
4552019-06-20T18:31:57 <gertjaap> https://gist.github.com/gertjaap/6abe29c49a84b64e179fd093a6e7579a
4562019-06-20T18:32:05 <luke-jr> check the exit code
4572019-06-20T18:32:35 <sipa> BlueMatt: ok, i have an IPv6 address!
4582019-06-20T18:33:05 <sipa> (i had it all along, but apparantly i had to configure it as a static ip on the system)
4592019-06-20T18:33:27 <luke-jr> ISPs are supposed to give you a /48 subnet :P
4602019-06-20T18:34:46 <BlueMatt> sipa: lol nice
4612019-06-20T18:35:51 *** aseem has joined #bitcoin-core-dev
4622019-06-20T18:38:32 <sipa> BlueMatt: does it work now?
4632019-06-20T18:39:39 <sipa> i expect not
4642019-06-20T18:41:09 <BlueMatt> sipa: I'm on a plane....things r slow....
4652019-06-20T18:41:15 <sipa> ha
4662019-06-20T18:42:41 <BlueMatt> sipa: I dont get a response from 2607:5300:201:3100::3b74
4672019-06-20T18:44:56 *** ddustin has quit IRC
4682019-06-20T18:48:08 <sipa> bleh
4692019-06-20T18:53:23 *** DeanWeen has joined #bitcoin-core-dev
4702019-06-20T18:56:23 <sipa> ok, now my seeder is actually returning ipv6 addresses when requested
4712019-06-20T18:56:30 <sipa> still not available over ipv6 itself
4722019-06-20T18:59:15 <jonasschnelli> sipa: do you do port forwarding to avoid running it as root?
4732019-06-20T18:59:30 <sipa> yes
4742019-06-20T18:59:52 <jonasschnelli> so you either need ip6tables forwarding or switch back to port 53
4752019-06-20T19:00:17 <sipa> yes
4762019-06-20T19:00:17 <jonasschnelli> sudo setcap 'cap_net_bind_service=+ep' /path/to/dnsseeder
4772019-06-20T19:00:31 <jonasschnelli> would allow to occupy port 53 without root
4782019-06-20T19:00:33 <sipa> i use ip6tables, but apparently not correctly :)
4792019-06-20T19:01:09 <wumpus> #startmeeting
4802019-06-20T19:01:09 <lightningbot> Meeting started Thu Jun 20 19:01:09 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4812019-06-20T19:01:09 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4822019-06-20T19:01:13 <sipa> hello
4832019-06-20T19:01:17 <jeremyrubin> hi
4842019-06-20T19:01:31 <jonasschnelli> hi
4852019-06-20T19:01:45 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
4862019-06-20T19:01:53 <achow101> hi
4872019-06-20T19:01:57 <meshcollider> hi
4882019-06-20T19:02:20 <wumpus> two topics proposed in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a : Bitcoin core PR review club, ASN blob discussion
4892019-06-20T19:02:44 <kanzure> hi
4902019-06-20T19:02:46 <wumpus> also maybe we want to discuss the travis issue again
4912019-06-20T19:02:57 *** spinza has quit IRC
4922019-06-20T19:04:03 <meshcollider> Also 2FA discussion from fanquake
4932019-06-20T19:04:08 <moneyball> hi
4942019-06-20T19:04:09 <wumpus> #topic High priority for review
4952019-06-20T19:04:51 <wumpus> https://github.com/bitcoin/bitcoin/projects/8 5 blockers, 2 bugfixes and 6(!) things chasing concept ack
4962019-06-20T19:05:13 <wumpus> anything to add/remove this week ?
4972019-06-20T19:05:34 <jnewbery> hi
4982019-06-20T19:07:21 <wumpus> ok, apparently nothing to discuss in regard to that
4992019-06-20T19:07:50 <wumpus> #topic Bitcoin Core PR review club (jnewbery)
5002019-06-20T19:08:03 <jnewbery> Thanks wumpus
5012019-06-20T19:08:07 <wumpus> https://bitcoin-core-review-club.github.io/
5022019-06-20T19:08:09 <jnewbery> I just wanted to give an update on the Bitcoin Core Review Club (https://bitcoin-core-review-club.github.io/) that we've been doing for the last couple of months.
5032019-06-20T19:08:18 <jnewbery> We've got a solid group of attendees every week, and some of them are commenting on and reviewing PRs in github, so I think it's been reasonably successful so far.
5042019-06-20T19:08:39 <jnewbery> If anyone wants to get involved, we have IRC meetings at 17:00 UTC on Wednesdays. Appearances from established contributors are always appreciated.
5052019-06-20T19:08:45 <jonasschnelli> thanks for doing this jnewbery!
5062019-06-20T19:09:01 <jnewbery> If you have any friends who are less experienced and want to get into Bitcoin Core development, you should send them along
5072019-06-20T19:09:15 <wumpus> yes, great!
5082019-06-20T19:09:31 <jnewbery> I'm away for the next couple of weeks and I'm looking for one or two volunteer hosts, so please message me if you're interested
5092019-06-20T19:09:38 <meshcollider> Very cool, I would definitely come if it wasn't at 5am haha
5102019-06-20T19:09:39 *** ddustin has joined #bitcoin-core-dev
5112019-06-20T19:10:21 <jnewbery> oh, and finally, if you have any suggested PRs for us to cover, please message me also. We're looking for stuff that doesn't require too much esoteric knowledge and is a reasonable size (perhaps ~100 LOC)
5122019-06-20T19:10:26 <jnewbery> that's all. Thanks!
5132019-06-20T19:10:27 *** ddustin has joined #bitcoin-core-dev
5142019-06-20T19:10:36 <BlueMatt> can we do asns? I want to take a nap
5152019-06-20T19:10:37 <wumpus> thanks jnewbery
5162019-06-20T19:10:43 <BlueMatt> also, +1 thanks jnewbery
5172019-06-20T19:10:52 *** ddustin has quit IRC
5182019-06-20T19:10:53 <wumpus> #topic ASN blobs (BlueMatt)
5192019-06-20T19:11:00 <BlueMatt> well maybe sipa can introduce
5202019-06-20T19:11:09 <BlueMatt> but the idea is, basically, why are we bucketing by /16s
5212019-06-20T19:11:12 *** Kvaciral has joined #bitcoin-core-dev
5222019-06-20T19:11:25 <BlueMatt> its an easy hack, but there's lots of isps with way more than /16s and lots with way less
5232019-06-20T19:11:29 *** ddustin has joined #bitcoin-core-dev
5242019-06-20T19:11:33 <sipa> to give some context
5252019-06-20T19:11:35 <BlueMatt> our goal, really, is to capture diversity of isps/hosting providers
5262019-06-20T19:12:09 <BlueMatt> we also have seen several groups of spy nodes/large-connection-farms from several different places, but, all together, they originate from < 10 isps
5272019-06-20T19:12:09 *** ddustin has quit IRC
5282019-06-20T19:12:15 <BlueMatt> despite being a *ton* of ips
5292019-06-20T19:12:33 <sipa> we're currently "grouping" certain IP ranges into groups, to make decisions such as whether to make multiple connections to the same range or not, prioritize incoming connections from distinct groups, and control which addrman buckets IPs go into (under the theory that an attacker has a hard time controlling many groups, sybil resistance is improved)
5302019-06-20T19:12:41 <sipa> right now, those are just /16 groups
5312019-06-20T19:12:45 <sipa> for most things
5322019-06-20T19:12:48 *** ddustin has joined #bitcoin-core-dev
5332019-06-20T19:13:13 <sipa> but /16 is a really naive choice; some ISPs control very large ranges, some very small ones
5342019-06-20T19:13:29 *** ddustin has quit IRC
5352019-06-20T19:13:54 <sipa> an obvious improvement is to have a map built-in to bitcoin core that tells what the actual independent network ranges are
5362019-06-20T19:14:08 *** ddustin has joined #bitcoin-core-dev
5372019-06-20T19:14:17 *** spinza has joined #bitcoin-core-dev
5382019-06-20T19:14:28 *** ddustin has quit IRC
5392019-06-20T19:14:33 <wumpus> so the practical problem would be how to include enough of this data to be useful, but without adding too much data to the executable size
5402019-06-20T19:14:37 <luke-jr> BlueMatt: don't ASNs change?
5412019-06-20T19:14:41 <sipa> so i've been working on seeing how large such a map for real internet data would be, and it turns out we can pack it in around 1 MB, and still efficiently look things up in it
5422019-06-20T19:14:49 <BlueMatt> luke-jr: sure, but not a *lot*
5432019-06-20T19:14:50 <wumpus> yes, they change, it'd be at most an approximation at the time of release
5442019-06-20T19:14:56 <luke-jr> and even if the same ISP owns a big range, that range may be very diverse?
5452019-06-20T19:15:03 *** ddustin has joined #bitcoin-core-dev
5462019-06-20T19:15:09 <wumpus> but that's good enough
5472019-06-20T19:15:27 <BlueMatt> diverse how? against any practical attacks that grouping helps prevent, not diverse at all (mitms, sybils, etc)
5482019-06-20T19:15:37 <wumpus> we don't really want to include all the data in our github repo though
5492019-06-20T19:15:38 *** ddustin has quit IRC
5502019-06-20T19:16:04 <luke-jr> BlueMatt: depends on the attack I guess
5512019-06-20T19:16:06 <wumpus> so I guess this is some kind of challenge for the deterministic builds
5522019-06-20T19:16:12 <BlueMatt> well we could incoporate a text file dump of a routing table into the build process
5532019-06-20T19:16:13 <BlueMatt> thats not too hard
5542019-06-20T19:16:24 <sipa> so i've used a dump from BGP (which is... a gigabyte or so) to extract a mapping from prefixes to ASNs, and then developed a custom packed format to store just the mapping
5552019-06-20T19:16:33 <wumpus> yes, but it should be determinstic per version, without including it into the repo itself
5562019-06-20T19:16:54 <luke-jr> we don't actually need the ASNs though, right? just some logic to decide whether to group by /16, /24, /8, etc
5572019-06-20T19:17:10 <BlueMatt> indeed, we'd have to agree on a source (we could use my dumps, or get them from one of several others who provide dumps, or get output from anyone's bird router)
5582019-06-20T19:17:12 <sipa> luke-jr: correct; though consistency matters for things like addrman
5592019-06-20T19:17:13 <wumpus> that does add some requirements, maybe it's not hard, but it's also not something we've done before
5602019-06-20T19:17:20 *** gabuqo has joined #bitcoin-core-dev
5612019-06-20T19:17:24 <sipa> as we don't want to change what number each range maps to too frequently
5622019-06-20T19:17:27 <luke-jr> although maybe some ISPs have multiple subnets
5632019-06-20T19:17:32 <sipa> and ASN numbers are small
5642019-06-20T19:17:44 <sipa> (most are below 2^16, all are below 350000 or so)
5652019-06-20T19:17:50 <wumpus> luke-jr:yes, quite a few ISPs have non-consecutive subnets
5662019-06-20T19:18:00 *** sheets has joined #bitcoin-core-dev
5672019-06-20T19:18:02 <sipa> luke-jr: indeed, and that's actually by design
5682019-06-20T19:18:08 <sipa> this would give most of AWS one number
5692019-06-20T19:18:21 <BlueMatt> hmm, is there some attack whereby someone just flips their asn every 6 months per release and gets into several buckets? I mean at most you'd get one per six months
5702019-06-20T19:18:32 <sipa> yeah, it's not terrible
5712019-06-20T19:18:37 <sipa> just better to be consistent when possible
5722019-06-20T19:18:41 <BlueMatt> which i guess is also plenty of time to register a new asn, buy some ips, and sell the old ones
5732019-06-20T19:19:05 <sipa> so i think a question for here is, what binary size increase is acceptable and/or is it a separate file with the map that can be replaced?
5742019-06-20T19:19:26 <BlueMatt> separate file seems ideal to me, but that has deployment concerns
5752019-06-20T19:19:43 <BlueMatt> I dont think we could realistically say "take this file that shipped with bitcoin core and copy it to your datadir on first run"
5762019-06-20T19:19:46 <sipa> and what kind of auditing is necessary for it... not everyone is able to extract a BGP dump and compare the result (and it wouldn't be consistent across dumps anyway)
5772019-06-20T19:20:09 <BlueMatt> we could get my dump, and a few other dumps and have a tool to compare them?
5782019-06-20T19:20:09 *** Guyver2 has quit IRC
5792019-06-20T19:20:18 <BlueMatt> there's several providers, so it should be doable
5802019-06-20T19:20:20 <sipa> just a text list of prefix -> ASN mappings is just a few MB
5812019-06-20T19:20:27 <sipa> when gzipped
5822019-06-20T19:20:31 <BlueMatt> eg you could get a bunch of dumps from https://rt-bgp.he.net/
5832019-06-20T19:20:45 <BlueMatt> (including mine, indirectly)
5842019-06-20T19:21:18 <sipa> so opinions?
5852019-06-20T19:21:36 <luke-jr> maybe we should only do it for 4 of the 8 peers?
5862019-06-20T19:21:36 <BlueMatt> well I guess two hard proposals, pick one:
5872019-06-20T19:21:40 <BlueMatt> a) build it into the binary
5882019-06-20T19:21:41 <luke-jr> in case ther'es a way to game it
5892019-06-20T19:21:59 <BlueMatt> b) ship a file and (1) look in datadir, (2) if not there, look in the folder where bitcoind is being run from.
5902019-06-20T19:22:05 *** Guyver2 has joined #bitcoin-core-dev
5912019-06-20T19:22:10 <BlueMatt> b) (3) if not, print warning and fall back to /16s
5922019-06-20T19:22:15 <achow101> is it possible to do both? i.e. build it in and have a separate file in datador
5932019-06-20T19:22:22 <sipa> yeah
5942019-06-20T19:22:26 <jnewbery> I'd say not (a). We don't want to add a MB of data to the repo
5952019-06-20T19:22:26 <achow101> so datadir file overrides built in
5962019-06-20T19:22:41 <jnewbery> do we want people to be able to override?
5972019-06-20T19:22:42 <BlueMatt> right, but its mostly a binary size question
5982019-06-20T19:22:44 <sipa> jnewbery: but the distribution should still include it
5992019-06-20T19:22:49 <wumpus> well the build could fetch it somewhere else, it doesn't need to be in the repo
6002019-06-20T19:22:56 <jb55> why does it have to be in-tree? couldn't it be a dependency?
6012019-06-20T19:22:58 <jnewbery> yes, i think the distribution should include it
6022019-06-20T19:22:58 <jb55> yeah
6032019-06-20T19:22:59 <wumpus> it definitely shouldn't be *
6042019-06-20T19:23:01 <BlueMatt> jnewbery: doesnt *technically* have to be in the repo
6052019-06-20T19:23:13 <luke-jr> BlueMatt: data files shouldn't be in bin/
6062019-06-20T19:23:14 <BlueMatt> it could be in the binary without that, as a separate input to gitian
6072019-06-20T19:23:43 <BlueMatt> luke-jr: if you're using a distribution, it should install it appropriately, if you're downloading the targz, then it can be wherever
6082019-06-20T19:24:00 <luke-jr> BlueMatt: datadir is per-user, so can't install there
6092019-06-20T19:24:44 <BlueMatt> further opinions?
6102019-06-20T19:25:11 <jnewbery> Do we want people to be able to supply their own. I think no
6112019-06-20T19:25:21 <BlueMatt> luke-jr: sure, that doesnt mean its not allowed to be there? there's also a copy of the chain there, which is not per-user :p
6122019-06-20T19:25:21 <sipa> jnewbery: i see no reason not to allow that
6132019-06-20T19:25:41 <luke-jr> BlueMatt: it means the distro can't install it there
6142019-06-20T19:25:54 <sipa> we'd have the scripts to build the blob from a list of mappings in contrib/ i guess
6152019-06-20T19:26:06 <wumpus> could have an argument to point to where it is
6162019-06-20T19:26:19 <BlueMatt> yes, definitely have to make it possible to generate your own, given the input is otherwise hard to audit
6172019-06-20T19:26:32 <BlueMatt> luke-jr: yes, hence an option like -look-in-var
6182019-06-20T19:26:51 <wumpus> datadir would only be the default, like it is for other things too unless overridden
6192019-06-20T19:27:55 <luke-jr> so force distros to patch it?
6202019-06-20T19:27:59 <wumpus> but I think we're very much getting into specific implementation details now
6212019-06-20T19:28:00 <jnewbery> because then bad people might supply a bogus network.dat (or whatever) file and tell people to use it
6222019-06-20T19:28:28 <wumpus> well that's true for any file, like peers.dat too
6232019-06-20T19:28:39 <gwillen> I think you could limit the damage a bad network.dat could do by putting sanity checks on it
6242019-06-20T19:28:40 <wumpus> or like a malicious wallet
6252019-06-20T19:28:52 <gwillen> e.g. no aggregating the entire internet into a single "ASN", that sort of thing
6262019-06-20T19:28:53 <sipa> wumpus: are you talking about having it always as a separate file (which may be sourced from several locations), or having it built into the binary (with the option to source it from elsewhere)
6272019-06-20T19:28:55 <wumpus> if you get people to install bogus files into their datadir it's kind of bad
6282019-06-20T19:29:04 *** infernix has quit IRC
6292019-06-20T19:29:24 <BlueMatt> (hopefully, many of these classes of attacks can be further limited by better peer eviction logic, so hopefully thats not *that* easy)
6302019-06-20T19:29:33 <wumpus> sipa: the latter, I think
6312019-06-20T19:29:43 <harding> Perhaps it should start as a separate file and then, later, if it's working well it can be considered for direct inclusion in the binary.
6322019-06-20T19:29:55 <wumpus> sipa: I'm ok with including the data in the distributed binary, I just don't want it in the repository
6332019-06-20T19:30:00 <sipa> ok fair
6342019-06-20T19:30:02 <wumpus> harding: good point too
6352019-06-20T19:30:13 <wumpus> first add support for this
6362019-06-20T19:30:16 <wumpus> then the rest later
6372019-06-20T19:31:53 <sipa> yeah
6382019-06-20T19:33:02 <wumpus> #topic Requiring 2FA for bitcoin orgs on GH (fanquake)
6392019-06-20T19:33:35 <jonasschnelli> I guess I we should disable sms 2fa recovery...
6402019-06-20T19:33:49 <luke-jr> eh, maybe for people with push? it doesn't really matter for most of us
6412019-06-20T19:34:13 <luke-jr> GH doesn't even check 2FA all that often either
6422019-06-20T19:34:15 <BlueMatt> i mean push is pgp-signed (at least in theory)
6432019-06-20T19:34:19 <BlueMatt> matters most for acks
6442019-06-20T19:34:22 <wumpus> jonasschnelli: so is that possible on an organization?
6452019-06-20T19:34:37 <BlueMatt> but, yea, I think I've not had to re-login to github in...years?
6462019-06-20T19:34:42 <jonasschnelli> no... I think need to be done on an individual level
6472019-06-20T19:34:45 <luke-jr> BlueMatt: GitHub being trusted with ACKs is a problem in itself :x
6482019-06-20T19:34:57 <BlueMatt> indeed
6492019-06-20T19:36:02 * jeremyrubin acks on the blockchain
6502019-06-20T19:36:13 <luke-jr> (why nobody sees it)
6512019-06-20T19:36:59 *** harrigan has quit IRC
6522019-06-20T19:36:59 * BlueMatt -> nap
6532019-06-20T19:37:00 <wumpus> I don't think there's actually much to discuss here: in any case, if you read this and haven't enabled 2FA please do so if possible
6542019-06-20T19:37:21 <jonasschnelli> Yes. And disable phone 2fa recovery
6552019-06-20T19:37:45 <jonasschnelli> (probably use FIDO key and recovery code for backup)
6562019-06-20T19:38:32 <wumpus> ok, any other topics? I think we're through
6572019-06-20T19:39:09 *** elichai2 has quit IRC
6582019-06-20T19:39:30 <phantomcircuit> jonasschnelli, at an organization level you can only enforce that some form of 2fa is enabled, not which type
6592019-06-20T19:41:15 <sipa> oh also short reminder we're going to meet with github tomorrow, if there are any things we should bring up, see https://github.com/bitcoin/bitcoin/issues/15847
6602019-06-20T19:44:08 <wumpus> good to know sipa
6612019-06-20T19:44:20 <wumpus> thanks everyone
6622019-06-20T19:44:21 <wumpus> #endmeeting
6632019-06-20T19:44:21 <lightningbot> Meeting ended Thu Jun 20 19:44:21 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6642019-06-20T19:44:21 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-20-19.01.html
6652019-06-20T19:44:21 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-20-19.01.txt
6662019-06-20T19:44:21 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-20-19.01.log.html
6672019-06-20T19:47:58 *** bitcoin-git has joined #bitcoin-core-dev
6682019-06-20T19:47:58 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/413e438ea976...9c95515ba034
6692019-06-20T19:47:59 <bitcoin-git> bitcoin/master fa00326 MarcoFalke: ci: Run extended tests
6702019-06-20T19:47:59 <bitcoin-git> bitcoin/master 9c95515 MarcoFalke: Merge #15520: cirrus: Run extended test feature_pruning
6712019-06-20T19:48:01 *** bitcoin-git has left #bitcoin-core-dev
6722019-06-20T19:48:37 *** bitcoin-git has joined #bitcoin-core-dev
6732019-06-20T19:48:37 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15520: cirrus: Run extended test feature_pruning (master...1903-ciExt) https://github.com/bitcoin/bitcoin/pull/15520
6742019-06-20T19:48:39 *** bitcoin-git has left #bitcoin-core-dev
6752019-06-20T19:53:11 <achow101> meshcollider: sipa: I've been working on implementing the scriptpubkeymanager and I noticed a bunch of things related to key generation rely on the wallet version and wallet flags. Thoughts on how to handle those without introducing a circular dependency?
6762019-06-20T19:57:10 *** harrigan has joined #bitcoin-core-dev
6772019-06-20T19:57:39 *** infernix has joined #bitcoin-core-dev
6782019-06-20T19:58:02 <sipa> achow101: expose some options in the LegacySPKMAnager (or whatever you call the instance of it that encapsulated the current ismine/keypool/...), as constructor arguments, and at wallet creation pass the flags down as options to it?
6792019-06-20T20:00:50 *** sheets has quit IRC
6802019-06-20T20:01:05 <achow101> there happen to be some things that can happen after a wallet is loaded that can change the flags though. also the flags aren't necessarily loaded when legacyspkmanager is created
6812019-06-20T20:01:14 <achow101> I supposed a pointer would work?
6822019-06-20T20:03:52 <sipa> maybe, but be careful about locking
6832019-06-20T20:04:09 <sipa> spkmamagers won't have access to a wallet's locks probably
6842019-06-20T20:04:36 <achow101> right
6852019-06-20T20:05:19 <achow101> also a minor problem with wallet.h defining the flags but including it in any of the spkmanager files results in a circular dependency
6862019-06-20T20:05:21 <sipa> if the only way to change a wallet's property is through a setter method, that method can just delegate to calling the legacyspkmanager's corresponding setter
6872019-06-20T20:06:52 *** lightlike has quit IRC
6882019-06-20T20:08:54 *** belcher has quit IRC
6892019-06-20T20:09:29 *** belcher has joined #bitcoin-core-dev
6902019-06-20T20:10:25 *** queip has quit IRC
6912019-06-20T20:10:29 *** rafalcpp_ has joined #bitcoin-core-dev
6922019-06-20T20:10:48 *** rafalcpp has quit IRC
6932019-06-20T20:11:14 *** rex4539 has quit IRC
6942019-06-20T20:12:05 *** skyikot has joined #bitcoin-core-dev
6952019-06-20T20:15:33 *** hebasto has quit IRC
6962019-06-20T20:16:02 *** queip has joined #bitcoin-core-dev
6972019-06-20T20:29:20 *** EagleTM has joined #bitcoin-core-dev
6982019-06-20T20:36:16 *** rafalcpp has joined #bitcoin-core-dev
6992019-06-20T20:36:17 *** queip has quit IRC
7002019-06-20T20:36:58 *** rafalcpp_ has quit IRC
7012019-06-20T20:42:31 *** queip has joined #bitcoin-core-dev
7022019-06-20T20:43:52 *** TheHoliestRoger_ is now known as TheHoliestRoger
7032019-06-20T20:43:56 *** gabuqo has quit IRC
7042019-06-20T20:56:22 *** hugohn has joined #bitcoin-core-dev
7052019-06-20T20:56:50 *** elichai2 has joined #bitcoin-core-dev
7062019-06-20T21:00:02 *** v4hn has quit IRC
7072019-06-20T21:00:18 *** bitcoin-git has joined #bitcoin-core-dev
7082019-06-20T21:00:18 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c95515ba034...ea45967e856d
7092019-06-20T21:00:19 <bitcoin-git> bitcoin/master fa7dd88 MarcoFalke: test: Add test for unknown args
7102019-06-20T21:00:19 <bitcoin-git> bitcoin/master ea45967 MarcoFalke: Merge #16234: test: Add test for unknown args
7112019-06-20T21:00:21 *** bitcoin-git has left #bitcoin-core-dev
7122019-06-20T21:01:13 *** bitcoin-git has joined #bitcoin-core-dev
7132019-06-20T21:01:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16234: test: Add test for unknown args (master...1906-unknownArgs) https://github.com/bitcoin/bitcoin/pull/16234
7142019-06-20T21:01:14 *** bitcoin-git has left #bitcoin-core-dev
7152019-06-20T21:04:17 *** chaosagent has joined #bitcoin-core-dev
7162019-06-20T21:06:22 *** hugohn has quit IRC
7172019-06-20T21:08:22 *** rex4539 has joined #bitcoin-core-dev
7182019-06-20T21:11:16 *** aseem has quit IRC
7192019-06-20T21:28:20 *** aseem has joined #bitcoin-core-dev
7202019-06-20T21:32:46 *** emilengler has quit IRC
7212019-06-20T21:38:04 *** scoop has quit IRC
7222019-06-20T21:38:40 *** Chris_Stewart_5 has quit IRC
7232019-06-20T21:40:06 *** bitcoin-git has joined #bitcoin-core-dev
7242019-06-20T21:40:07 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea45967e856d...b4ad4c0de30f
7252019-06-20T21:40:07 <bitcoin-git> bitcoin/master 9218ce8 Aseem Sood: Failing functional tests stop lcov
7262019-06-20T21:40:07 <bitcoin-git> bitcoin/master b4ad4c0 MarcoFalke: Merge #16207: test: stop generating lcov coverage when functional tests fa...
7272019-06-20T21:40:20 *** bitcoin-git has left #bitcoin-core-dev
7282019-06-20T21:41:01 *** bitcoin-git has joined #bitcoin-core-dev
7292019-06-20T21:41:02 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16207: test: stop generating lcov coverage when functional tests fail (master...patch-15648) https://github.com/bitcoin/bitcoin/pull/16207
7302019-06-20T21:41:14 *** bitcoin-git has left #bitcoin-core-dev
7312019-06-20T21:41:25 *** scoop has joined #bitcoin-core-dev
7322019-06-20T21:41:51 *** bitcoin-git has joined #bitcoin-core-dev
7332019-06-20T21:41:52 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4ad4c0de30f...23815ee74dfd
7342019-06-20T21:41:52 <bitcoin-git> bitcoin/master eb832cd nicolas.dorier: MSVC: Fix error in debug mode (Fix #16245)
7352019-06-20T21:41:53 <bitcoin-git> bitcoin/master 23815ee MarcoFalke: Merge #16246: MSVC: Fix error in debug mode (Fix #16245)
7362019-06-20T21:42:04 *** bitcoin-git has left #bitcoin-core-dev
7372019-06-20T21:42:22 *** harrigan has quit IRC
7382019-06-20T21:42:51 *** bitcoin-git has joined #bitcoin-core-dev
7392019-06-20T21:42:52 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16246: MSVC: Fix error in debug mode (Fix #16245) (master...fix/bigobj) https://github.com/bitcoin/bitcoin/pull/16246
7402019-06-20T21:43:05 *** bitcoin-git has left #bitcoin-core-dev
7412019-06-20T21:44:55 *** scoop has quit IRC
7422019-06-20T21:45:01 *** scoop has joined #bitcoin-core-dev
7432019-06-20T21:47:49 *** Guyver2 has quit IRC
7442019-06-20T21:54:45 *** aseem has quit IRC
7452019-06-20T21:57:25 *** jonatack has joined #bitcoin-core-dev
7462019-06-20T22:18:28 *** DeanWeen has quit IRC
7472019-06-20T22:19:57 *** bitcoin-git has joined #bitcoin-core-dev
7482019-06-20T22:19:57 <bitcoin-git> [bitcoin] jonatack opened pull request #16256: doc: remove orphaned header in developer notes (master...remove-orphaned-header-link-in-developer-notes) https://github.com/bitcoin/bitcoin/pull/16256
7492019-06-20T22:19:58 *** bitcoin-git has left #bitcoin-core-dev
7502019-06-20T22:24:24 *** promag_ has joined #bitcoin-core-dev
7512019-06-20T22:25:12 *** Milford33Kassulk has joined #bitcoin-core-dev
7522019-06-20T22:30:10 *** michaelsdunn1 has joined #bitcoin-core-dev
7532019-06-20T22:30:26 *** Milford33Kassulk has quit IRC
7542019-06-20T22:31:51 *** DeanGuss has joined #bitcoin-core-dev
7552019-06-20T22:37:00 *** spinza has quit IRC
7562019-06-20T22:40:01 *** shesek has joined #bitcoin-core-dev
7572019-06-20T22:42:03 *** ylbam has joined #bitcoin-core-dev
7582019-06-20T22:42:42 *** aseem has joined #bitcoin-core-dev
7592019-06-20T22:45:22 *** aseem has quit IRC
7602019-06-20T22:51:42 *** promag_ has quit IRC
7612019-06-20T22:52:01 *** surja795 has joined #bitcoin-core-dev
7622019-06-20T22:52:17 *** promag_ has joined #bitcoin-core-dev
7632019-06-20T22:55:03 *** rafalcpp_ has joined #bitcoin-core-dev
7642019-06-20T22:55:27 *** queip has quit IRC
7652019-06-20T22:55:28 *** rafalcpp has quit IRC
7662019-06-20T22:56:35 *** promag_ has quit IRC
7672019-06-20T23:00:41 *** DeanGuss has quit IRC
7682019-06-20T23:00:43 *** surja795 has quit IRC
7692019-06-20T23:01:05 *** captjakk has quit IRC
7702019-06-20T23:03:47 *** queip has joined #bitcoin-core-dev
7712019-06-20T23:05:32 *** spinza has joined #bitcoin-core-dev
7722019-06-20T23:16:22 *** ddustin has joined #bitcoin-core-dev
7732019-06-20T23:17:13 *** ddustin has quit IRC
7742019-06-20T23:17:21 *** jarthur has quit IRC
7752019-06-20T23:17:48 *** ddustin has joined #bitcoin-core-dev
7762019-06-20T23:18:43 *** ddustin has joined #bitcoin-core-dev
7772019-06-20T23:24:57 *** Victorsueca has quit IRC
7782019-06-20T23:25:21 *** dviola has joined #bitcoin-core-dev
7792019-06-20T23:27:07 *** lnostdal has quit IRC
7802019-06-20T23:29:10 *** scoop has quit IRC
7812019-06-20T23:29:32 *** scoop has joined #bitcoin-core-dev
7822019-06-20T23:30:12 *** michaelsdunn1 has quit IRC
7832019-06-20T23:32:14 *** Zenton has quit IRC
7842019-06-20T23:42:08 *** reallll has joined #bitcoin-core-dev
7852019-06-20T23:45:02 *** belcher has quit IRC
7862019-06-20T23:47:10 *** dfsg has joined #bitcoin-core-dev
7872019-06-20T23:47:55 *** dfsg has left #bitcoin-core-dev
7882019-06-20T23:49:18 *** Victorsueca has joined #bitcoin-core-dev
7892019-06-20T23:50:34 *** lnostdal has joined #bitcoin-core-dev