1 2019-06-25T00:00:01  *** Guest53294 has quit IRC
  2 2019-06-25T00:02:55  *** darosior has quit IRC
  3 2019-06-25T00:04:22  *** freakofmimsy has joined #bitcoin-core-dev
  4 2019-06-25T00:07:09  *** pinheadmz has joined #bitcoin-core-dev
  5 2019-06-25T00:08:02  *** PastaPasta has quit IRC
  6 2019-06-25T00:11:29  *** pinheadmz has quit IRC
  7 2019-06-25T00:14:14  *** surja795 has joined #bitcoin-core-dev
  8 2019-06-25T00:17:19  *** michaelfolkson has joined #bitcoin-core-dev
  9 2019-06-25T00:21:00  *** scoop has quit IRC
 10 2019-06-25T00:21:26  *** scoop has joined #bitcoin-core-dev
 11 2019-06-25T00:25:28  *** scoop has quit IRC
 12 2019-06-25T00:35:39  *** Guest45841 has quit IRC
 13 2019-06-25T00:42:04  *** surja795 has quit IRC
 14 2019-06-25T01:00:23  *** aseem has joined #bitcoin-core-dev
 15 2019-06-25T01:08:45  *** ryanofsky has quit IRC
 16 2019-06-25T01:09:24  *** morcos has quit IRC
 17 2019-06-25T01:10:23  *** reallll has joined #bitcoin-core-dev
 18 2019-06-25T01:10:31  *** e4xit has quit IRC
 19 2019-06-25T01:13:49  *** belcher has quit IRC
 20 2019-06-25T01:14:04  *** morcos has joined #bitcoin-core-dev
 21 2019-06-25T01:23:50  *** michaelfolkson has quit IRC
 22 2019-06-25T01:35:12  *** DeanGuss has joined #bitcoin-core-dev
 23 2019-06-25T01:44:34  *** pinheadmz has joined #bitcoin-core-dev
 24 2019-06-25T01:52:36  *** PastaPasta has joined #bitcoin-core-dev
 25 2019-06-25T01:54:49  *** PastaPasta has quit IRC
 26 2019-06-25T01:57:51  *** AaronvanW has joined #bitcoin-core-dev
 27 2019-06-25T02:13:41  *** cubancorona has joined #bitcoin-core-dev
 28 2019-06-25T02:15:35  <sdaftuar> luke-jr: hi -- saw you pinged me on friday?
 29 2019-06-25T02:17:37  *** baldur has quit IRC
 30 2019-06-25T02:20:17  *** luke-jr has quit IRC
 31 2019-06-25T02:20:35  *** luke-jr has joined #bitcoin-core-dev
 32 2019-06-25T02:20:41  *** aseem has quit IRC
 33 2019-06-25T02:22:46  <aj> sdaftuar: hey, just sent an email based on having run the relay-parents code that we talked briefly about in amsterdam
 34 2019-06-25T02:26:48  *** pinheadmz has quit IRC
 35 2019-06-25T02:31:36  *** baldur has joined #bitcoin-core-dev
 36 2019-06-25T02:34:57  <fanquake> sdaftuar while you're here, be good to get a quick sanity check from you in #16188.
 37 2019-06-25T02:35:00  <gribble> https://github.com/bitcoin/bitcoin/issues/16188 | net: Document what happens to getdata of unknown type by MarcoFalke · Pull Request #16188 · bitcoin/bitcoin · GitHub
 38 2019-06-25T02:39:14  <fanquake> sdaftuar cheers
 39 2019-06-25T02:41:27  *** DeanGuss has quit IRC
 40 2019-06-25T02:41:31  <sdaftuar> fanquake: thanks for the reminder
 41 2019-06-25T02:41:56  *** DeanGuss has joined #bitcoin-core-dev
 42 2019-06-25T02:42:30  *** MJ64 has joined #bitcoin-core-dev
 43 2019-06-25T02:43:52  *** elichai2 has quit IRC
 44 2019-06-25T02:44:13  <luke-jr> sdaftuar: yes, about the dbcrash test: I don't understand why after restarting the node that crashes on submitblock, it's okay to wait for the block to be the tip? What if it crashed BEFORE the block was processed? (as it seems to be when I run it)
 45 2019-06-25T02:45:56  *** bralyclow01 has joined #bitcoin-core-dev
 46 2019-06-25T02:48:36  *** MJ64 has quit IRC
 47 2019-06-25T02:49:37  *** bralyclow has quit IRC
 48 2019-06-25T02:51:25  <sdaftuar> luke-jr: that seems strange to me -- did you perhaps modify the test to run on a pruning node somehow?
 49 2019-06-25T02:52:09  <sdaftuar> other than that, i don't see how FlushStateToDisk could be called before the new block is connected (which is where the crash happens)
 50 2019-06-25T02:53:26  *** spinza has quit IRC
 51 2019-06-25T02:54:31  <luke-jr> hmm
 52 2019-06-25T02:55:48  *** AaronvanW has quit IRC
 53 2019-06-25T02:55:48  *** arubi has quit IRC
 54 2019-06-25T02:56:12  *** arubi has joined #bitcoin-core-dev
 55 2019-06-25T02:58:17  <sdaftuar> oh, maybe there's a race condition somewhere else...
 56 2019-06-25T03:00:02  *** freakofmimsy has quit IRC
 57 2019-06-25T03:00:28  <sdaftuar> i guess ATMP calls FlushStateToDisk as well, so if the test is generating transactions and then occasionally submitting a block, there could be a race where the FSTD call in transaction acceptance triggers a crash right as submitblock is firing.
 58 2019-06-25T03:01:14  <sdaftuar> i haven't actually looked at the test in-depth enough to know if that might be a plausible explanation though
 59 2019-06-25T03:05:19  *** gchaix has joined #bitcoin-core-dev
 60 2019-06-25T03:07:47  *** ddustin has joined #bitcoin-core-dev
 61 2019-06-25T03:11:09  <sdaftuar> luke-jr: do you have a commit that the test fails on?
 62 2019-06-25T03:13:42  *** bitcoin-git has joined #bitcoin-core-dev
 63 2019-06-25T03:13:42  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e115a21f79c4...21bd6eb782ca
 64 2019-06-25T03:13:43  <bitcoin-git> bitcoin/master dddd927 MarcoFalke: net: Document what happens to getdata of unknonw type
 65 2019-06-25T03:13:43  <bitcoin-git> bitcoin/master 21bd6eb fanquake: Merge #16188: net: Document what happens to getdata of unknown type
 66 2019-06-25T03:13:55  *** bitcoin-git has left #bitcoin-core-dev
 67 2019-06-25T03:14:30  *** bitcoin-git has joined #bitcoin-core-dev
 68 2019-06-25T03:14:30  <bitcoin-git> [bitcoin] stplaydog opened pull request #16281: [fix #1] Understand transaction_tests (master...transaction_tests) https://github.com/bitcoin/bitcoin/pull/16281
 69 2019-06-25T03:14:33  *** bitcoin-git has left #bitcoin-core-dev
 70 2019-06-25T03:14:50  *** bitcoin-git has joined #bitcoin-core-dev
 71 2019-06-25T03:14:50  <bitcoin-git> [bitcoin] fanquake merged pull request #16188: net: Document what happens to getdata of unknown type (master...1906-netGetData) https://github.com/bitcoin/bitcoin/pull/16188
 72 2019-06-25T03:14:53  *** bitcoin-git has left #bitcoin-core-dev
 73 2019-06-25T03:19:15  *** bitcoin-git has joined #bitcoin-core-dev
 74 2019-06-25T03:19:15  <bitcoin-git> [bitcoin] fanquake closed pull request #16281: [fix #1] Understand transaction_tests (master...transaction_tests) https://github.com/bitcoin/bitcoin/pull/16281
 75 2019-06-25T03:19:19  *** bitcoin-git has left #bitcoin-core-dev
 76 2019-06-25T03:27:58  *** surja795 has joined #bitcoin-core-dev
 77 2019-06-25T03:29:20  *** AaronvanW has joined #bitcoin-core-dev
 78 2019-06-25T03:30:25  *** spinza has joined #bitcoin-core-dev
 79 2019-06-25T03:32:38  *** surja795 has quit IRC
 80 2019-06-25T03:33:44  *** AaronvanW has quit IRC
 81 2019-06-25T04:01:46  *** surja795 has joined #bitcoin-core-dev
 82 2019-06-25T04:08:25  *** bralyclow01 has quit IRC
 83 2019-06-25T04:11:02  *** surja795 has quit IRC
 84 2019-06-25T04:18:09  *** spaced0ut has quit IRC
 85 2019-06-25T04:19:02  *** DeanGuss has quit IRC
 86 2019-06-25T04:19:16  *** DeanGuss has joined #bitcoin-core-dev
 87 2019-06-25T04:40:06  *** instagibbs has quit IRC
 88 2019-06-25T04:55:39  *** pinheadmz has joined #bitcoin-core-dev
 89 2019-06-25T04:56:03  *** rex4539 has joined #bitcoin-core-dev
 90 2019-06-25T04:58:27  *** instagibbs has joined #bitcoin-core-dev
 91 2019-06-25T05:04:44  *** bralyclow has joined #bitcoin-core-dev
 92 2019-06-25T05:10:03  *** jonatack has joined #bitcoin-core-dev
 93 2019-06-25T05:16:17  *** bralyclow has quit IRC
 94 2019-06-25T05:36:45  *** bralyclow has joined #bitcoin-core-dev
 95 2019-06-25T05:41:21  *** bralyclow has quit IRC
 96 2019-06-25T05:42:48  *** shesek has joined #bitcoin-core-dev
 97 2019-06-25T05:42:48  *** shesek has joined #bitcoin-core-dev
 98 2019-06-25T05:47:06  *** teardown has joined #bitcoin-core-dev
 99 2019-06-25T05:47:10  *** teardown_ has joined #bitcoin-core-dev
100 2019-06-25T05:47:38  *** teardown is now known as Guest79354
101 2019-06-25T05:47:38  *** teardown_ is now known as teardown
102 2019-06-25T05:59:25  *** bralyclow has joined #bitcoin-core-dev
103 2019-06-25T06:00:01  *** gchaix has quit IRC
104 2019-06-25T06:02:11  *** Guest79354 has quit IRC
105 2019-06-25T06:20:10  *** evanpro has joined #bitcoin-core-dev
106 2019-06-25T06:34:14  <kallewoof> With bech32, is MIN_STANDARD_TX_NONWITNESS_SIZE still 82 bytes?
107 2019-06-25T06:34:58  <kallewoof> I am seeing failure in feature_bip68_sequence.py if I flip the default address type to bech32, cause it runs into a tx that is 62 bytes w/o witness stuff.
108 2019-06-25T06:37:42  *** bitcoin-git has joined #bitcoin-core-dev
109 2019-06-25T06:37:43  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/21bd6eb782ca...bc948d4cfd6d
110 2019-06-25T06:37:43  <bitcoin-git> bitcoin/master 30ea931 Carl Dong: depends: xtrans: Configure flags cleanup.
111 2019-06-25T06:37:44  <bitcoin-git> bitcoin/master bc948d4 fanquake: Merge #16183: depends: xtrans: Configure flags cleanup.
112 2019-06-25T06:37:55  *** bitcoin-git has left #bitcoin-core-dev
113 2019-06-25T06:38:31  *** bitcoin-git has joined #bitcoin-core-dev
114 2019-06-25T06:38:31  <bitcoin-git> [bitcoin] fanquake merged pull request #16183: depends: xtrans: Configure flags cleanup. (master...2019-06-leave-xtrans-alone-right-now) https://github.com/bitcoin/bitcoin/pull/16183
115 2019-06-25T06:38:32  *** bitcoin-git has left #bitcoin-core-dev
116 2019-06-25T06:42:37  *** hebasto has joined #bitcoin-core-dev
117 2019-06-25T06:52:39  *** ddustin has quit IRC
118 2019-06-25T06:53:00  *** ddustin has joined #bitcoin-core-dev
119 2019-06-25T06:53:25  *** ddustin has quit IRC
120 2019-06-25T06:53:47  *** ddustin has joined #bitcoin-core-dev
121 2019-06-25T06:54:32  *** ddustin has joined #bitcoin-core-dev
122 2019-06-25T06:55:19  *** ddustin has joined #bitcoin-core-dev
123 2019-06-25T06:55:45  *** ddustin has quit IRC
124 2019-06-25T06:56:09  *** ddustin has joined #bitcoin-core-dev
125 2019-06-25T06:57:26  *** ddustin has joined #bitcoin-core-dev
126 2019-06-25T07:00:52  *** Guyver2 has joined #bitcoin-core-dev
127 2019-06-25T07:07:44  *** ddustin has quit IRC
128 2019-06-25T07:15:25  *** AaronvanW has joined #bitcoin-core-dev
129 2019-06-25T07:20:01  *** AaronvanW has quit IRC
130 2019-06-25T07:22:14  *** hebasto has quit IRC
131 2019-06-25T07:31:23  *** reallll is now known as belcher
132 2019-06-25T07:40:34  *** aseem has joined #bitcoin-core-dev
133 2019-06-25T07:41:20  *** AaronvanW has joined #bitcoin-core-dev
134 2019-06-25T07:47:38  *** ctrlbreak has quit IRC
135 2019-06-25T07:58:49  *** laptop500 has joined #bitcoin-core-dev
136 2019-06-25T08:00:52  *** jonatack has quit IRC
137 2019-06-25T08:07:47  *** omonk has quit IRC
138 2019-06-25T08:12:40  *** omonk has joined #bitcoin-core-dev
139 2019-06-25T08:13:52  *** darosior has joined #bitcoin-core-dev
140 2019-06-25T08:14:34  *** aseem has quit IRC
141 2019-06-25T08:14:59  *** setpill has joined #bitcoin-core-dev
142 2019-06-25T08:16:00  <jonasschnelli> Hmm... compiling depends W64 (minGW64) on Ubuntu 18.04 fails... can't figure out why
143 2019-06-25T08:16:33  <jonasschnelli> error: ‘mutex’ is not a member of ‘std’    <---- looks like its not compiling with c++11, I tried even to force it with "CXXFLAGS="-std=gnu++11"" ... no success
144 2019-06-25T08:16:36  <jonasschnelli> Probably missing a package?
145 2019-06-25T08:20:50  <jonasschnelli> selecting the posix version through sudo update-alternatives --config x86_64-w64-mingw32-g++ fixed it
146 2019-06-25T08:33:47  *** AaronvanW has quit IRC
147 2019-06-25T08:36:25  <gertjaap> is there anything i should do if the DrahtBot reports a conflicting PR? Or just leave it for reviewers.
148 2019-06-25T08:37:11  <fanquake> jonasschnelli just need to read the docs :p
149 2019-06-25T08:37:18  <jonasschnelli> indeed... :)
150 2019-06-25T08:37:35  <jonasschnelli> gertjaap: just informal,... no need to fix
151 2019-06-25T08:37:38  <fanquake> gertjaap I wouldn't worry to much
152 2019-06-25T08:37:54  <gertjaap> ok, cool
153 2019-06-25T08:38:11  <fanquake> The conflicting PR could be quite possibly be 6 months old, need rebasing itself etc etc.
154 2019-06-25T08:50:31  *** timothy has joined #bitcoin-core-dev
155 2019-06-25T08:57:47  <meshcollider> I feel like the conflicting info is more useful for maintainers to decide what order to merge stuff in than it is for anyone else
156 2019-06-25T09:00:02  *** evanpro has quit IRC
157 2019-06-25T09:05:17  *** rex4539 has quit IRC
158 2019-06-25T09:14:46  *** harrigan has joined #bitcoin-core-dev
159 2019-06-25T09:28:10  *** AaronvanW has joined #bitcoin-core-dev
160 2019-06-25T09:29:35  *** promag_ has joined #bitcoin-core-dev
161 2019-06-25T09:36:27  *** omonk has quit IRC
162 2019-06-25T09:37:40  *** AaronvanW has quit IRC
163 2019-06-25T09:39:30  *** omonk has joined #bitcoin-core-dev
164 2019-06-25T09:40:59  *** pinheadmz has quit IRC
165 2019-06-25T09:42:06  *** peterpomade has joined #bitcoin-core-dev
166 2019-06-25T09:43:44  *** pinheadmz has joined #bitcoin-core-dev
167 2019-06-25T09:45:23  *** bitcoin-git has joined #bitcoin-core-dev
168 2019-06-25T09:45:24  <bitcoin-git> [bitcoin] fanquake closed pull request #15572: Add auto select custom fee when smart fee not initialized. (master...dev) https://github.com/bitcoin/bitcoin/pull/15572
169 2019-06-25T09:45:24  *** bitcoin-git has left #bitcoin-core-dev
170 2019-06-25T09:50:00  *** AaronvanW has joined #bitcoin-core-dev
171 2019-06-25T09:52:16  *** AaronvanW has quit IRC
172 2019-06-25T09:53:59  *** michaelfolkson has joined #bitcoin-core-dev
173 2019-06-25T09:55:20  *** promag_ has quit IRC
174 2019-06-25T09:58:28  *** promag_ has joined #bitcoin-core-dev
175 2019-06-25T10:00:21  *** promag_ has quit IRC
176 2019-06-25T10:03:14  *** EagleTM has quit IRC
177 2019-06-25T10:06:03  *** promag_ has joined #bitcoin-core-dev
178 2019-06-25T10:07:34  <fanquake> wumpus Would you like to take a look at #15894 ?
179 2019-06-25T10:07:37  <gribble> https://github.com/bitcoin/bitcoin/issues/15894 | Remove duplicated "Error: " prefix in logs by hebasto · Pull Request #15894 · bitcoin/bitcoin · GitHub
180 2019-06-25T10:08:09  *** ctrlbreak has joined #bitcoin-core-dev
181 2019-06-25T10:11:01  *** Guyver2 has quit IRC
182 2019-06-25T10:11:03  *** promag_ has quit IRC
183 2019-06-25T10:14:28  *** promag_ has joined #bitcoin-core-dev
184 2019-06-25T10:15:09  *** bitcoin-git has joined #bitcoin-core-dev
185 2019-06-25T10:15:09  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc948d4cfd6d...c52776e6ff4d
186 2019-06-25T10:15:10  <bitcoin-git> bitcoin/master fad3d2a MarcoFalke: test: Create data dir in BasicTestingSetup
187 2019-06-25T10:15:10  <bitcoin-git> bitcoin/master fa4a04a MarcoFalke: test: use common setup in gui tests
188 2019-06-25T10:15:11  <bitcoin-git> bitcoin/master fabc57e MarcoFalke: test: Log to debug.log in all tests
189 2019-06-25T10:15:12  *** bitcoin-git has left #bitcoin-core-dev
190 2019-06-25T10:16:04  *** bitcoin-git has joined #bitcoin-core-dev
191 2019-06-25T10:16:04  <bitcoin-git> [bitcoin] laanwj merged pull request #16252: test: Log to debug.log in all unit tests (master...1905-bufferLog) https://github.com/bitcoin/bitcoin/pull/16252
192 2019-06-25T10:16:08  *** bitcoin-git has left #bitcoin-core-dev
193 2019-06-25T10:17:36  *** promag_ has quit IRC
194 2019-06-25T10:21:46  *** bitcoin-git has joined #bitcoin-core-dev
195 2019-06-25T10:21:46  <bitcoin-git> [bitcoin] fanquake reopened pull request #16255: util: Remove code to cache datadir (master...1906-utilNoPath) https://github.com/bitcoin/bitcoin/pull/16255
196 2019-06-25T10:21:47  *** bitcoin-git has left #bitcoin-core-dev
197 2019-06-25T10:26:35  *** harrigan has quit IRC
198 2019-06-25T10:28:10  *** promag_ has joined #bitcoin-core-dev
199 2019-06-25T10:28:34  *** spinza has quit IRC
200 2019-06-25T10:32:21  *** promag_ has quit IRC
201 2019-06-25T10:32:58  *** promag_ has joined #bitcoin-core-dev
202 2019-06-25T10:33:37  *** DeanGuss has quit IRC
203 2019-06-25T10:34:07  *** DeanGuss has joined #bitcoin-core-dev
204 2019-06-25T10:34:09  *** spinza has joined #bitcoin-core-dev
205 2019-06-25T10:38:00  *** promag_ has quit IRC
206 2019-06-25T10:38:35  *** e4xit has joined #bitcoin-core-dev
207 2019-06-25T10:39:50  *** spinza has quit IRC
208 2019-06-25T10:45:40  *** laptop500 has quit IRC
209 2019-06-25T10:49:00  *** harrigan has joined #bitcoin-core-dev
210 2019-06-25T10:53:35  *** michaelfolkson has quit IRC
211 2019-06-25T10:54:48  *** michaelfolkson has joined #bitcoin-core-dev
212 2019-06-25T11:00:49  *** spinza has joined #bitcoin-core-dev
213 2019-06-25T11:02:50  <wumpus> fanquake: sure
214 2019-06-25T11:07:35  *** michaelfolkson has quit IRC
215 2019-06-25T11:08:11  *** michaelfolkson has joined #bitcoin-core-dev
216 2019-06-25T11:12:55  *** EagleTM has joined #bitcoin-core-dev
217 2019-06-25T11:14:26  *** laptop500 has joined #bitcoin-core-dev
218 2019-06-25T11:16:06  *** TheHoliestRoger has quit IRC
219 2019-06-25T11:16:51  *** TheHoliestRoger has joined #bitcoin-core-dev
220 2019-06-25T11:21:13  *** Skirmant has quit IRC
221 2019-06-25T11:21:46  *** michaelfolkson has quit IRC
222 2019-06-25T11:26:25  *** michaelfolkson has joined #bitcoin-core-dev
223 2019-06-25T11:27:55  *** AaronvanW has joined #bitcoin-core-dev
224 2019-06-25T11:28:07  *** michaelfolkson has quit IRC
225 2019-06-25T11:29:03  *** michaelfolkson has joined #bitcoin-core-dev
226 2019-06-25T11:31:44  *** rafalcpp has joined #bitcoin-core-dev
227 2019-06-25T11:33:24  *** bitcoin-git has joined #bitcoin-core-dev
228 2019-06-25T11:33:25  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c52776e6ff4d...332c6134bb15
229 2019-06-25T11:33:25  <bitcoin-git> bitcoin/master f0641f2 Hennadii Stepanov: Prepend the error/warning prefix for GUI messages
230 2019-06-25T11:33:26  <bitcoin-git> bitcoin/master 96fd4ee Hennadii Stepanov: Add MSG_NOPREFIX flag for user messages
231 2019-06-25T11:33:27  <bitcoin-git> bitcoin/master f724f31 Hennadii Stepanov: Make AbortNode() aware of MSG_NOPREFIX flag
232 2019-06-25T11:33:30  <fanquake> wumpus thanks
233 2019-06-25T11:33:38  *** bitcoin-git has left #bitcoin-core-dev
234 2019-06-25T11:34:09  *** bitcoin-git has joined #bitcoin-core-dev
235 2019-06-25T11:34:09  <bitcoin-git> [bitcoin] laanwj merged pull request #15894: Remove duplicated "Error: " prefix in logs (master...20190425-duplicated-error-prefix) https://github.com/bitcoin/bitcoin/pull/15894
236 2019-06-25T11:34:22  *** bitcoin-git has left #bitcoin-core-dev
237 2019-06-25T11:36:59  *** darosior has quit IRC
238 2019-06-25T11:37:30  *** queip has joined #bitcoin-core-dev
239 2019-06-25T11:40:25  *** promag_ has joined #bitcoin-core-dev
240 2019-06-25T11:51:47  *** promag_ has quit IRC
241 2019-06-25T11:57:13  *** michaelfolkson has quit IRC
242 2019-06-25T11:57:44  <fanquake> wumpus I was going to ACK #16278 (no longer because it doesn't seem to compile..). Basically because it's tests only, Marco seems ok with it and it doesn't conflict with anything else that is merge ready. However, for the rest of the the 0.19.0 cycle, I feel like we're at the point where we can just start rejecting those kinds of PRs.
243 2019-06-25T11:57:46  <gribble> https://github.com/bitcoin/bitcoin/issues/16278 | tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests by practicalswift · Pull Request #16278 · bitcoin/bitcoin · GitHub
244 2019-06-25T11:57:58  <fanquake> I know you'd be happy to just close them all the time.
245 2019-06-25T12:00:02  *** peterpomade has quit IRC
246 2019-06-25T12:00:36  *** harrigan has quit IRC
247 2019-06-25T12:00:58  <fanquake> hebasto (are you on IRC, different nick?) also asked how to test these kinds of PRs. I was just going to say using whichever methods wastes the least developer time. It's sort of annoying that a lot of these changes are seemingly hand-rolled, and the PR's don't actually contain any information about how they were done, or point to ways that this can just be automated away and forgotten about in future.
248 2019-06-25T12:02:27  *** michaelfolkson has joined #bitcoin-core-dev
249 2019-06-25T12:03:28  <fanquake> It's also a bit crazy that the 0.19 branch off is only 3 months away. #15940.
250 2019-06-25T12:03:30  <gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
251 2019-06-25T12:07:57  *** harrigan has joined #bitcoin-core-dev
252 2019-06-25T12:10:59  *** porygon2 has joined #bitcoin-core-dev
253 2019-06-25T12:14:01  *** laptop500 has quit IRC
254 2019-06-25T12:22:31  *** ryanofsky has joined #bitcoin-core-dev
255 2019-06-25T12:24:59  <wumpus> fanquake: whoa yes that branch-off is pretty soon, thanks for the reminder :)
256 2019-06-25T12:27:48  <wumpus> fanquake: I don't necessarily want to close them, but yes, messing around with includes just has the lowest priority for me
257 2019-06-25T12:28:29  <fanquake> yes
258 2019-06-25T12:28:43  *** elichai2 has joined #bitcoin-core-dev
259 2019-06-25T12:29:19  <wumpus> although it's nice they benchmarked it and it increased the build speed, it's not really a metric we generally optimized for, but still
260 2019-06-25T12:30:03  <fanquake> Sure. Although a bit concerning that they might push a change like that and it not even compile.
261 2019-06-25T12:30:11  *** aseem has joined #bitcoin-core-dev
262 2019-06-25T12:30:31  *** michaelfolkson has quit IRC
263 2019-06-25T12:33:06  <wumpus> fanquake: silent merge conflict I guess?
264 2019-06-25T12:34:12  <fanquake> wumpus yea I'd assume so. Looks like it happened right after rebasing.
265 2019-06-25T12:35:18  <wumpus> (tbh I'm not sure 2% compile speed improvement warrants that much work; most complaints with regard to compile are about compile-time memory usage, not sure how that is affected)
266 2019-06-25T12:36:46  <fanquake> I think there is another PR open, or possibly got closed that reduced compile time memory by 1% or so by removing a bunch of includes
267 2019-06-25T12:38:11  <fanquake> Yea #16238. Which was a follow up to #16129 which supposedly reduced compile time memory use by 2%.
268 2019-06-25T12:38:14  <gribble> https://github.com/bitcoin/bitcoin/issues/16238 | build: Remove unused C++ standard library includes by practicalswift · Pull Request #16238 · bitcoin/bitcoin · GitHub
269 2019-06-25T12:38:15  <gribble> https://github.com/bitcoin/bitcoin/issues/16129 | refactor: Remove unused includes by practicalswift · Pull Request #16129 · bitcoin/bitcoin · GitHub
270 2019-06-25T12:39:14  <fanquake> tbh I'm not sure why the later wasn't part of the former.
271 2019-06-25T12:43:48  *** DeanGuss has quit IRC
272 2019-06-25T12:44:12  *** michaelfolkson has joined #bitcoin-core-dev
273 2019-06-25T12:50:07  *** aseem has quit IRC
274 2019-06-25T12:51:54  <jonasschnelli> wumpus: thanks for clearing up the mystery of openSSH's BE/LE code
275 2019-06-25T12:52:57  <jonasschnelli> I think one conversion to host endianness needs to be kept:
276 2019-06-25T12:52:58  <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/15649/commits/5aad287ef3b2c410385d6e9a898fb70526c5bd98#diff-d64c806cc86b6f80f4cf5b777238b493R126
277 2019-06-25T12:53:19  <jonasschnelli> Since we are reading the stream (which is always LE) and give back an int
278 2019-06-25T12:58:34  <wumpus> jonasschnelli: I'm not sure, it seems this could be done without ever relying on host endianness like openssh does
279 2019-06-25T12:59:05  <wumpus> read the stream to integer with specified endian and write the integers with specified endian
280 2019-06-25T13:00:29  <jonasschnelli> wumpus: hmm...
281 2019-06-25T13:00:32  <wumpus> of course the integers will be in host endianness but you'd never rely on that fact in the code and use shifts and bitwise ANDs/ORs
282 2019-06-25T13:00:33  <jonasschnelli> I guess we are doing that...
283 2019-06-25T13:00:33  <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/15649/files#diff-d64c806cc86b6f80f4cf5b777238b493R121
284 2019-06-25T13:00:50  <jonasschnelli> the byte shifts are BE/LE safe AFAIK
285 2019-06-25T13:01:06  <jonasschnelli> so that one *len24_out = le32toh(*len24_out); is not necessary?
286 2019-06-25T13:01:15  <wumpus> not as long as you're using the htole64
287 2019-06-25T13:02:23  <wumpus> so basically you never want to cast bytes to integers and vice versa, so you don't need Xtoh or htoX
288 2019-06-25T13:03:27  <wumpus> access bytes as bytes and integers as integers and use endian-explicit poke/peek functions where needed to convert between them
289 2019-06-25T13:04:12  *** michaelfolkson has quit IRC
290 2019-06-25T13:06:12  <jonasschnelli> wumpus: and we are using htole64 since this is network protocol serialisation... so you agree it's safe to remove that le32toh?
291 2019-06-25T13:06:22  *** michaelfolkson has joined #bitcoin-core-dev
292 2019-06-25T13:07:22  <wumpus> I'll have to review the code to be sure, but I think it's unnecessary, unless you're type-punning somethere
293 2019-06-25T13:07:48  <wumpus> in which case that's what you'd want to avoid instead
294 2019-06-25T13:08:50  <jonasschnelli> That part is not in the AEAD pull,... since nothing is really creating encrypted streams from internal structures (the testvectors are given)
295 2019-06-25T13:09:21  <wumpus> jonasschnelli:yes, the " *len24_out = le32toh(*len24_out);" should be unnecessary
296 2019-06-25T13:09:22  <jonasschnelli> So the AEAD PR tests against test vectors where the integer (there is only one for the AAD len) is encoded LE
297 2019-06-25T13:09:56  <wumpus> "// encode to host endianness 32bit integer", it's an integer: it's always host endianness in memory, but you don't need to care, treat it as an abstract integer
298 2019-06-25T13:10:48  <wumpus> only when you convert the integer from/to bytes, endian starts to be something you need to be concerned about
299 2019-06-25T13:11:03  <jonasschnelli> Yes. Thanks for clearing that up...
300 2019-06-25T13:11:19  <jonasschnelli> The current code that writes the 3 byte length field is...:
301 2019-06-25T13:11:21  <jonasschnelli> CVectorWriter vector_writer(SER_NETWORK, INIT_PROTO_VERSION, serialized_envelope, 0, int24[0], int24[1], int24[2]);
302 2019-06-25T13:14:21  <wumpus> right, would change that to ((int24>>16)&0xff), ((int24>>8)&0xff), (int24&0xff)  (assuming you want it BE)  instead of type-punning the int
303 2019-06-25T13:14:39  <wumpus> (other way around if you want LE)
304 2019-06-25T13:16:54  <jonasschnelli> if we would use a standard int32 for the size (instead of 3 bytes) we could just pass the int into CVectorWriter since it uses ser_writedata32 under the hood, right?
305 2019-06-25T13:17:15  <wumpus> yes
306 2019-06-25T13:17:26  <jonasschnelli> But since there is no ser_writedata24 (obviously), we need to use our own punning
307 2019-06-25T13:19:07  <wumpus> you have to handle your own serialization / deserialization for the byte stream from/to an integer, yes
308 2019-06-25T13:32:39  *** EagleTM has quit IRC
309 2019-06-25T13:35:05  <wumpus> but not with type punning (which is explicitly defined as casting one type of pointer to another and suspicable to various kinds of UB and IBD), rather, use explicit shifts and logical operations to extract/concatentate the bytes
310 2019-06-25T13:37:45  *** EagleTM has joined #bitcoin-core-dev
311 2019-06-25T13:37:56  *** arubi has quit IRC
312 2019-06-25T13:38:30  *** arubi has joined #bitcoin-core-dev
313 2019-06-25T13:41:54  *** bralyclow has quit IRC
314 2019-06-25T13:42:21  *** bralyclow has joined #bitcoin-core-dev
315 2019-06-25T13:50:31  *** d_t has joined #bitcoin-core-dev
316 2019-06-25T13:53:49  *** bralyclow01 has joined #bitcoin-core-dev
317 2019-06-25T13:55:45  *** d_t has quit IRC
318 2019-06-25T13:56:40  *** bralyclow has quit IRC
319 2019-06-25T14:08:26  *** pinheadmz has quit IRC
320 2019-06-25T14:11:25  *** spaced0ut has joined #bitcoin-core-dev
321 2019-06-25T14:16:33  *** rafalcpp_ has joined #bitcoin-core-dev
322 2019-06-25T14:17:07  *** rafalcpp has quit IRC
323 2019-06-25T14:17:08  *** queip has quit IRC
324 2019-06-25T14:18:07  *** bralyclow01 has quit IRC
325 2019-06-25T14:18:25  *** aseem has joined #bitcoin-core-dev
326 2019-06-25T14:18:51  *** hebasto has joined #bitcoin-core-dev
327 2019-06-25T14:21:05  *** bralyclow has joined #bitcoin-core-dev
328 2019-06-25T14:21:29  *** michaelfolkson has quit IRC
329 2019-06-25T14:23:03  *** scoop has joined #bitcoin-core-dev
330 2019-06-25T14:23:12  *** queip has joined #bitcoin-core-dev
331 2019-06-25T14:23:16  *** bralyclow01 has joined #bitcoin-core-dev
332 2019-06-25T14:23:21  *** michaelfolkson has joined #bitcoin-core-dev
333 2019-06-25T14:26:38  *** bralyclow has quit IRC
334 2019-06-25T14:28:15  *** michaelsdunn1 has joined #bitcoin-core-dev
335 2019-06-25T14:28:15  *** michaelsdunn1 has quit IRC
336 2019-06-25T14:28:15  *** michaelsdunn1 has joined #bitcoin-core-dev
337 2019-06-25T14:29:23  *** aseem has quit IRC
338 2019-06-25T14:40:43  *** aseem has joined #bitcoin-core-dev
339 2019-06-25T14:51:36  *** darosior has joined #bitcoin-core-dev
340 2019-06-25T14:53:32  *** Soligor has quit IRC
341 2019-06-25T14:56:25  *** AaronvanW has quit IRC
342 2019-06-25T15:00:01  *** porygon2 has quit IRC
343 2019-06-25T15:01:29  *** Soligor has joined #bitcoin-core-dev
344 2019-06-25T15:04:35  *** Inigo_Montoya has joined #bitcoin-core-dev
345 2019-06-25T15:11:12  *** aseem has quit IRC
346 2019-06-25T15:11:52  *** aseem has joined #bitcoin-core-dev
347 2019-06-25T15:17:10  *** darosior has quit IRC
348 2019-06-25T15:20:04  *** rh0nj has quit IRC
349 2019-06-25T15:21:07  *** rh0nj has joined #bitcoin-core-dev
350 2019-06-25T15:24:12  *** aseem has quit IRC
351 2019-06-25T15:28:33  *** bralyclow01 has quit IRC
352 2019-06-25T15:49:57  *** aseem has joined #bitcoin-core-dev
353 2019-06-25T15:51:10  *** bralyclow has joined #bitcoin-core-dev
354 2019-06-25T15:55:50  *** aseem has quit IRC
355 2019-06-25T16:00:38  *** michaelfolkson has quit IRC
356 2019-06-25T16:02:57  *** davec has quit IRC
357 2019-06-25T16:05:08  *** davec has joined #bitcoin-core-dev
358 2019-06-25T16:06:08  *** pinheadmz has joined #bitcoin-core-dev
359 2019-06-25T16:08:07  *** pinheadmz has joined #bitcoin-core-dev
360 2019-06-25T16:09:14  *** shesek has quit IRC
361 2019-06-25T16:11:24  *** StopAndDecrypt has joined #bitcoin-core-dev
362 2019-06-25T16:12:08  *** Emcy has quit IRC
363 2019-06-25T16:17:51  *** Emcy has joined #bitcoin-core-dev
364 2019-06-25T16:18:49  *** pinheadmz has joined #bitcoin-core-dev
365 2019-06-25T16:19:14  *** bitcoin-git has joined #bitcoin-core-dev
366 2019-06-25T16:19:14  <bitcoin-git> [bitcoin] promag opened pull request #16285: rpc: Improve scantxoutset response and help message (master...2019-06-scantxoutset-nits) https://github.com/bitcoin/bitcoin/pull/16285
367 2019-06-25T16:19:15  *** bitcoin-git has left #bitcoin-core-dev
368 2019-06-25T16:25:31  *** jarthur has joined #bitcoin-core-dev
369 2019-06-25T16:26:05  *** pinheadmz has quit IRC
370 2019-06-25T16:32:28  *** pinheadmz has joined #bitcoin-core-dev
371 2019-06-25T16:36:08  *** pinheadmz has quit IRC
372 2019-06-25T16:42:31  *** michaelfolkson has joined #bitcoin-core-dev
373 2019-06-25T16:43:26  *** davec has quit IRC
374 2019-06-25T16:44:37  *** davec has joined #bitcoin-core-dev
375 2019-06-25T16:47:46  <wumpus> its funny that no one can answer my question in #16183
376 2019-06-25T16:47:48  <gribble> https://github.com/bitcoin/bitcoin/issues/16183 | depends: xtrans: Configure flags cleanup. by dongcarl · Pull Request #16183 · bitcoin/bitcoin · GitHub
377 2019-06-25T16:49:54  <gwillen> wumpus: it appears to be a library somehow involved in talking to the X windows server?
378 2019-06-25T16:50:39  <dongcarl> wumpus: X11 needs it at build time
379 2019-06-25T16:50:54  <gwillen> it looks like qt depends on xcb which might depend on xtrans
380 2019-06-25T16:51:11  <gwillen> so it's a fairly deep dependency which is why nobody remembers what it does ;-)
381 2019-06-25T16:51:35  <dongcarl> libX11*
382 2019-06-25T17:00:36  *** scoop has quit IRC
383 2019-06-25T17:05:33  *** setpill has quit IRC
384 2019-06-25T17:11:05  *** aseem has joined #bitcoin-core-dev
385 2019-06-25T17:12:09  *** kristapsk has joined #bitcoin-core-dev
386 2019-06-25T17:15:41  *** harrigan has quit IRC
387 2019-06-25T17:16:08  *** michaelfolkson has quit IRC
388 2019-06-25T17:16:33  *** scoop has joined #bitcoin-core-dev
389 2019-06-25T17:18:46  *** michaelfolkson has joined #bitcoin-core-dev
390 2019-06-25T17:23:11  *** bitcoin-git has joined #bitcoin-core-dev
391 2019-06-25T17:23:11  <bitcoin-git> [bitcoin] hebasto opened pull request #16286: Fix GCC 7.4.0 warning (master...20190625-fix-warning) https://github.com/bitcoin/bitcoin/pull/16286
392 2019-06-25T17:23:12  *** bitcoin-git has left #bitcoin-core-dev
393 2019-06-25T17:42:56  *** timothy has quit IRC
394 2019-06-25T17:51:13  <wumpus> gwillen dongcarl: okay, thanks, makes sense, the thing that made me confused is that if it's not even a library, how do we depend on it?
395 2019-06-25T17:51:49  <wumpus> I guess I'd still rather depend on some obscure X dep than... expat
396 2019-06-25T17:51:52  <gwillen> .... that's a good question
397 2019-06-25T17:56:02  *** usahgagahb has joined #bitcoin-core-dev
398 2019-06-25T18:00:02  *** Inigo_Montoya has quit IRC
399 2019-06-25T18:00:21  *** scoop has quit IRC
400 2019-06-25T18:00:50  *** scoop has joined #bitcoin-core-dev
401 2019-06-25T18:18:07  *** pinheadmz has joined #bitcoin-core-dev
402 2019-06-25T18:21:12  *** edit_21 has joined #bitcoin-core-dev
403 2019-06-25T18:25:31  *** scoop_ has joined #bitcoin-core-dev
404 2019-06-25T18:25:31  *** scoop has quit IRC
405 2019-06-25T18:29:51  *** harrigan has joined #bitcoin-core-dev
406 2019-06-25T18:30:44  *** dviola has joined #bitcoin-core-dev
407 2019-06-25T18:32:03  *** pinheadmz has joined #bitcoin-core-dev
408 2019-06-25T18:33:58  *** pinheadmz has quit IRC
409 2019-06-25T18:46:56  *** omonk has quit IRC
410 2019-06-25T18:50:14  *** michaelfolkson has quit IRC
411 2019-06-25T18:50:27  *** owowo has quit IRC
412 2019-06-25T18:53:15  *** omonk has joined #bitcoin-core-dev
413 2019-06-25T18:56:16  *** d_t has joined #bitcoin-core-dev
414 2019-06-25T18:56:26  *** owowo has joined #bitcoin-core-dev
415 2019-06-25T18:58:10  *** scoop_ has quit IRC
416 2019-06-25T19:01:13  *** lightlike has joined #bitcoin-core-dev
417 2019-06-25T19:08:21  *** rafalcpp has joined #bitcoin-core-dev
418 2019-06-25T19:08:29  *** queip has quit IRC
419 2019-06-25T19:09:13  *** rafalcpp_ has quit IRC
420 2019-06-25T19:11:08  *** bitcoin-git has joined #bitcoin-core-dev
421 2019-06-25T19:11:08  <bitcoin-git> [bitcoin] rrybarczyk opened pull request #16287: Remove extra CBlockIndex declaration (master...remove-extra-cblockindex) https://github.com/bitcoin/bitcoin/pull/16287
422 2019-06-25T19:11:21  *** bitcoin-git has left #bitcoin-core-dev
423 2019-06-25T19:15:12  *** queip has joined #bitcoin-core-dev
424 2019-06-25T19:15:46  *** bralyclow01 has joined #bitcoin-core-dev
425 2019-06-25T19:18:00  *** usahgagahb has quit IRC
426 2019-06-25T19:18:38  *** bralyclow has quit IRC
427 2019-06-25T19:26:08  *** aseem has quit IRC
428 2019-06-25T19:41:46  *** aseem has joined #bitcoin-core-dev
429 2019-06-25T20:02:00  *** harrigan has quit IRC
430 2019-06-25T20:03:41  *** pinheadmz has joined #bitcoin-core-dev
431 2019-06-25T20:04:49  *** pinheadmz has quit IRC
432 2019-06-25T20:10:15  <hebasto> Hi! Could someone point me to the adopted practice or discussion about translation of the "Bitcoin Core" brand name to other languages?
433 2019-06-25T20:14:09  *** aseem has quit IRC
434 2019-06-25T20:34:18  *** harrigan has joined #bitcoin-core-dev
435 2019-06-25T20:36:20  *** harrigan has quit IRC
436 2019-06-25T20:37:07  *** aseem has joined #bitcoin-core-dev
437 2019-06-25T20:48:50  *** spaced0ut has quit IRC
438 2019-06-25T21:00:01  *** edit_21 has quit IRC
439 2019-06-25T21:00:21  *** morcos has quit IRC
440 2019-06-25T21:01:03  *** morcos has joined #bitcoin-core-dev
441 2019-06-25T21:04:10  *** lightlike has quit IRC
442 2019-06-25T21:04:22  *** lightlike has joined #bitcoin-core-dev
443 2019-06-25T21:04:45  *** Snowstormer has joined #bitcoin-core-dev
444 2019-06-25T21:08:45  *** hebasto has quit IRC
445 2019-06-25T21:11:57  *** tryphe_ has joined #bitcoin-core-dev
446 2019-06-25T21:12:36  *** tryphe has quit IRC
447 2019-06-25T21:18:17  *** IGHOR has joined #bitcoin-core-dev
448 2019-06-25T21:19:00  *** arubi has quit IRC
449 2019-06-25T21:23:57  *** arubi has joined #bitcoin-core-dev
450 2019-06-25T21:25:52  *** Zenton has quit IRC
451 2019-06-25T21:26:14  *** aseem has quit IRC
452 2019-06-25T21:30:17  *** Zenton has joined #bitcoin-core-dev
453 2019-06-25T21:46:09  <ossifrage> Some how I lost 7342 blocks in an out of space shutdown
454 2019-06-25T21:48:27  *** hrofu has joined #bitcoin-core-dev
455 2019-06-25T21:48:29  <ossifrage> The node had been down since jan, it synced up to the tip and then many hours later it ran out of disk.
456 2019-06-25T21:49:21  <ossifrage> When I restarted the node the tip went from 582102 back to 574747
457 2019-06-25T21:50:02  *** rockhouse has quit IRC
458 2019-06-25T21:50:13  *** rabidus has quit IRC
459 2019-06-25T21:50:14  *** Lauda has quit IRC
460 2019-06-25T21:50:52  *** rockhouse has joined #bitcoin-core-dev
461 2019-06-25T21:50:52  *** hrofu_ has quit IRC
462 2019-06-25T21:51:29  *** Lauda has joined #bitcoin-core-dev
463 2019-06-25T21:51:29  *** Lauda has joined #bitcoin-core-dev
464 2019-06-25T21:52:07  <ossifrage> 574747 was the first UpdateTip line from the previous run of bitcoin-qt, this seems like an excessive amount of state to loose
465 2019-06-25T21:52:15  *** rabidus has joined #bitcoin-core-dev
466 2019-06-25T21:56:32  *** Jason has joined #bitcoin-core-dev
467 2019-06-25T21:57:06  *** Jason is now known as Guest81088
468 2019-06-25T22:00:08  *** aseem has joined #bitcoin-core-dev
469 2019-06-25T22:12:56  *** pinheadmz has joined #bitcoin-core-dev
470 2019-06-25T22:20:50  *** pinheadmz has quit IRC
471 2019-06-25T22:21:20  *** spinza has quit IRC
472 2019-06-25T22:24:39  *** aseem has quit IRC
473 2019-06-25T22:28:51  *** ubba has joined #bitcoin-core-dev
474 2019-06-25T22:31:02  *** aseem has joined #bitcoin-core-dev
475 2019-06-25T22:32:02  *** jarthur has quit IRC
476 2019-06-25T22:32:43  <achow101> is it project policy that all commits must compile and pass all tests?
477 2019-06-25T22:35:23  *** ubba has quit IRC
478 2019-06-25T22:36:27  <gwillen> achow101: I think it's like, polite at least?
479 2019-06-25T22:36:38  <gwillen> I've not heard of it being enforced, I do not believe Travis checks anything but the tip
480 2019-06-25T22:37:01  <gwillen> but I always try to preserve it, bisection is more annoying if you don't
481 2019-06-25T22:37:27  <achow101> gwillen: my situation is either make people review a commit that's something like +/- 5000 LOC but compiles and passes tests, or break that up but none of those commits will pass tests (they should compile though)
482 2019-06-25T22:37:53  <achow101> for my own sanity, I'm making the separate commits, but I can squash them all together if people want commits that pass tests
483 2019-06-25T22:38:39  <gwillen> you could just disable the broken tests in the intermediate commits
484 2019-06-25T22:38:48  <gwillen> I don't know if that's actually a good idea but it fixes the bisection issue
485 2019-06-25T22:40:15  <achow101> .. there's a lot of broken tests. basically anything that involves the wallet
486 2019-06-25T22:40:32  <achow101> which is almost all of them
487 2019-06-25T22:44:04  <gwillen> *nods*
488 2019-06-25T22:49:48  *** spinza has joined #bitcoin-core-dev
489 2019-06-25T22:53:23  *** promag_ has joined #bitcoin-core-dev
490 2019-06-25T22:54:30  *** michaelsdunn1 has quit IRC
491 2019-06-25T22:57:37  *** promag_ has quit IRC
492 2019-06-25T22:58:41  *** pinheadmz has joined #bitcoin-core-dev
493 2019-06-25T23:01:34  *** itsiku has quit IRC
494 2019-06-25T23:03:06  *** nullptr| has quit IRC
495 2019-06-25T23:03:15  *** pinheadmz has quit IRC
496 2019-06-25T23:12:08  *** nullptr| has joined #bitcoin-core-dev
497 2019-06-25T23:13:02  <luke-jr> bisect should only ever go inside a merge when it's related to the issue
498 2019-06-25T23:15:09  *** nullptr| has quit IRC
499 2019-06-25T23:15:51  *** nullptr| has joined #bitcoin-core-dev
500 2019-06-25T23:32:28  <promag> achow101: fwiw I prefer green commits
501 2019-06-25T23:34:50  *** Emcy has quit IRC
502 2019-06-25T23:39:32  *** Emcy has joined #bitcoin-core-dev
503 2019-06-25T23:41:01  <meshcollider> Squash them locally then ;)
504 2019-06-25T23:47:01  <jb55> in general I think you should structure commits so that each one passes tests, obviously that's not always possible, but it's good practice