12019-07-08T00:00:01  *** mrd1 has quit IRC
  22019-07-08T00:19:19  *** Ceriand has joined #bitcoin-core-dev
  32019-07-08T00:22:58  *** bitcoin-git has joined #bitcoin-core-dev
  42019-07-08T00:22:59  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f373beebbcc0...05623c021681
  52019-07-08T00:22:59  <bitcoin-git> bitcoin/master d003110 Hennadii Stepanov: Remove unused guard
  62019-07-08T00:23:00  <bitcoin-git> bitcoin/master 05623c0 fanquake: Merge #16350: qt: Remove unused guard
  72019-07-08T00:23:03  *** bitcoin-git has left #bitcoin-core-dev
  82019-07-08T00:24:03  *** bitcoin-git has joined #bitcoin-core-dev
  92019-07-08T00:24:04  <bitcoin-git> [bitcoin] fanquake merged pull request #16350: qt: Remove unused guard (master...20190707-remove-unused-guard) https://github.com/bitcoin/bitcoin/pull/16350
 102019-07-08T00:24:05  *** bitcoin-git has left #bitcoin-core-dev
 112019-07-08T00:27:28  *** promag has quit IRC
 122019-07-08T00:28:08  *** promag has joined #bitcoin-core-dev
 132019-07-08T00:33:14  *** promag has quit IRC
 142019-07-08T00:35:37  *** d_t has quit IRC
 152019-07-08T00:35:44  *** bitcoin-git has joined #bitcoin-core-dev
 162019-07-08T00:35:45  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05623c021681...2b465195e09a
 172019-07-08T00:35:45  <bitcoin-git> bitcoin/master 64b27c4 fanquake: docs: add reduce-memory.md
 182019-07-08T00:35:46  <bitcoin-git> bitcoin/master 2b46519 fanquake: Merge #16339: doc: add reduce-memory.md
 192019-07-08T00:35:48  *** bitcoin-git has left #bitcoin-core-dev
 202019-07-08T00:36:48  *** bitcoin-git has joined #bitcoin-core-dev
 212019-07-08T00:36:49  <bitcoin-git> [bitcoin] fanquake merged pull request #16339: doc: add reduce-memory.md (master...doc-reduce-memory-usage) https://github.com/bitcoin/bitcoin/pull/16339
 222019-07-08T00:37:01  *** bitcoin-git has left #bitcoin-core-dev
 232019-07-08T00:51:21  *** MoonJaCk- has quit IRC
 242019-07-08T01:15:10  *** shesek has joined #bitcoin-core-dev
 252019-07-08T01:15:10  *** shesek has quit IRC
 262019-07-08T01:15:10  *** shesek has joined #bitcoin-core-dev
 272019-07-08T01:17:02  *** elichai2 has quit IRC
 282019-07-08T01:20:33  *** d_t has joined #bitcoin-core-dev
 292019-07-08T01:22:14  *** elichai2 has joined #bitcoin-core-dev
 302019-07-08T01:40:17  *** cyberstorm_ has quit IRC
 312019-07-08T01:48:23  *** mdunnio has joined #bitcoin-core-dev
 322019-07-08T02:31:10  *** scoop has joined #bitcoin-core-dev
 332019-07-08T02:32:01  *** Raystonn has joined #bitcoin-core-dev
 342019-07-08T02:45:24  *** promag has joined #bitcoin-core-dev
 352019-07-08T02:45:36  *** kristapsk has quit IRC
 362019-07-08T02:46:58  *** kristapsk has joined #bitcoin-core-dev
 372019-07-08T02:49:38  *** promag has quit IRC
 382019-07-08T02:51:19  *** scoop has quit IRC
 392019-07-08T02:51:46  *** scoop has joined #bitcoin-core-dev
 402019-07-08T02:58:08  *** mdunnio has quit IRC
 412019-07-08T02:58:35  *** mdunnio has joined #bitcoin-core-dev
 422019-07-08T02:58:54  *** mdunnio has quit IRC
 432019-07-08T02:59:23  *** mdunnio has joined #bitcoin-core-dev
 442019-07-08T02:59:42  *** mdunnio has quit IRC
 452019-07-08T03:00:02  *** Ceriand has quit IRC
 462019-07-08T03:02:07  *** mdunnio has joined #bitcoin-core-dev
 472019-07-08T03:02:25  *** scoop has quit IRC
 482019-07-08T03:04:28  *** nighmi has joined #bitcoin-core-dev
 492019-07-08T03:04:33  *** nighmi is now known as Guest47769
 502019-07-08T03:07:54  *** scoop has joined #bitcoin-core-dev
 512019-07-08T03:13:35  *** d_t has quit IRC
 522019-07-08T03:15:36  *** Raystonn has quit IRC
 532019-07-08T03:24:48  *** scoop has quit IRC
 542019-07-08T03:25:14  *** scoop has joined #bitcoin-core-dev
 552019-07-08T03:29:56  *** scoop has quit IRC
 562019-07-08T03:30:01  *** goatpig has quit IRC
 572019-07-08T03:45:10  *** luke-jr has joined #bitcoin-core-dev
 582019-07-08T03:45:22  *** Honthe has quit IRC
 592019-07-08T03:47:02  *** elichai2 has quit IRC
 602019-07-08T03:48:25  *** DeanWeen has joined #bitcoin-core-dev
 612019-07-08T04:45:58  *** promag has joined #bitcoin-core-dev
 622019-07-08T04:50:44  *** promag has quit IRC
 632019-07-08T04:59:15  *** hebasto has joined #bitcoin-core-dev
 642019-07-08T05:03:05  *** Karyon has quit IRC
 652019-07-08T05:11:52  *** Karyon has joined #bitcoin-core-dev
 662019-07-08T05:13:04  *** X3sA5WavYxY has joined #bitcoin-core-dev
 672019-07-08T05:30:35  *** X3sA5WavYxY has quit IRC
 682019-07-08T05:34:44  *** Karyon has quit IRC
 692019-07-08T06:00:01  *** Guest47769 has quit IRC
 702019-07-08T06:05:52  *** Karyon has joined #bitcoin-core-dev
 712019-07-08T06:17:44  *** DARKNE55 has joined #bitcoin-core-dev
 722019-07-08T06:27:39  *** promag has joined #bitcoin-core-dev
 732019-07-08T06:32:20  *** promag has quit IRC
 742019-07-08T07:10:18  *** Guyver2 has joined #bitcoin-core-dev
 752019-07-08T07:14:56  *** Fleta77Towne has joined #bitcoin-core-dev
 762019-07-08T07:21:11  *** ccdle12 has joined #bitcoin-core-dev
 772019-07-08T07:25:53  *** Fleta77Towne has quit IRC
 782019-07-08T07:30:48  *** bitcoin-git has joined #bitcoin-core-dev
 792019-07-08T07:30:49  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2b465195e09a...e1a8d76aff8d
 802019-07-08T07:30:49  <bitcoin-git> bitcoin/master 84ad4d2 Carl Dong: doc: Include static members in Doxygen
 812019-07-08T07:30:50  <bitcoin-git> bitcoin/master e1a8d76 Wladimir J. van der Laan: Merge #16347: doc: Include static members in Doxygen
 822019-07-08T07:30:51  *** bitcoin-git has left #bitcoin-core-dev
 832019-07-08T07:31:58  *** bitcoin-git has joined #bitcoin-core-dev
 842019-07-08T07:31:59  <bitcoin-git> [bitcoin] laanwj merged pull request #16347: doc: Include static members in Doxygen (master...2019-07-doxygen-extract-static) https://github.com/bitcoin/bitcoin/pull/16347
 852019-07-08T07:32:00  *** bitcoin-git has left #bitcoin-core-dev
 862019-07-08T07:32:33  *** AaronvanW has joined #bitcoin-core-dev
 872019-07-08T07:36:24  *** Aaronvan_ has joined #bitcoin-core-dev
 882019-07-08T07:40:44  *** AaronvanW has quit IRC
 892019-07-08T07:45:43  *** jungly has joined #bitcoin-core-dev
 902019-07-08T07:47:23  *** queip has quit IRC
 912019-07-08T07:57:58  *** queip has joined #bitcoin-core-dev
 922019-07-08T08:06:44  *** setpill has joined #bitcoin-core-dev
 932019-07-08T08:06:53  *** ccdle12 has quit IRC
 942019-07-08T08:08:06  *** ccdle12 has joined #bitcoin-core-dev
 952019-07-08T08:20:17  *** shesek has quit IRC
 962019-07-08T08:27:24  *** darosior has joined #bitcoin-core-dev
 972019-07-08T08:34:00  *** Zenton has joined #bitcoin-core-dev
 982019-07-08T08:43:23  *** reallll has joined #bitcoin-core-dev
 992019-07-08T08:47:01  *** belcher has quit IRC
1002019-07-08T08:55:48  *** reallll is now known as belcher
1012019-07-08T08:57:04  *** setpill has quit IRC
1022019-07-08T08:57:27  *** setpill has joined #bitcoin-core-dev
1032019-07-08T08:57:50  *** promag has joined #bitcoin-core-dev
1042019-07-08T08:58:29  *** promag_ has joined #bitcoin-core-dev
1052019-07-08T08:59:03  *** promag_ has joined #bitcoin-core-dev
1062019-07-08T09:00:02  *** DARKNE55 has quit IRC
1072019-07-08T09:04:43  *** evrt has joined #bitcoin-core-dev
1082019-07-08T09:13:32  <promag> imo #16106 is ready to merge
1092019-07-08T09:13:35  <gribble> https://github.com/bitcoin/bitcoin/issues/16106 | gui: Sort wallets in open wallet menu by promag · Pull Request #16106 · bitcoin/bitcoin · GitHub
1102019-07-08T09:14:13  <promag> #15305 seems like forgotten
1112019-07-08T09:14:16  <gribble> https://github.com/bitcoin/bitcoin/issues/15305 | [validation] Crash if disconnecting a block fails by sdaftuar · Pull Request #15305 · bitcoin/bitcoin · GitHub
1122019-07-08T09:17:43  *** obsrver has joined #bitcoin-core-dev
1132019-07-08T09:24:32  <fanquake> promag I’ll look at sort wallets tonight, sorry.
1142019-07-08T09:24:45  <promag> no worries
1152019-07-08T09:25:45  <promag> #16285 is also a pretty simple change
1162019-07-08T09:25:46  <gribble> https://github.com/bitcoin/bitcoin/issues/16285 | rpc: Improve scantxoutset response and help message by promag · Pull Request #16285 · bitcoin/bitcoin · GitHub
1172019-07-08T09:26:42  *** obsrver has quit IRC
1182019-07-08T09:26:42  <hebasto> promag: fanquake: hi, did you try to build with downloaded Qt 5.7.1?
1192019-07-08T09:26:53  <promag> hebasto: no
1202019-07-08T09:26:53  *** obsrver has joined #bitcoin-core-dev
1212019-07-08T09:27:08  <promag> hebasto: the problem only exists with 5.7.1?
1222019-07-08T09:27:19  <fanquake> on Debian with -nowallet? I used apt installed.
1232019-07-08T09:27:21  <hebasto> it seems so...
1242019-07-08T09:27:51  <fanquake> Assuming I’m thinking of the right issue.
1252019-07-08T09:28:51  <promag> let's just bump to qt 5.10 X)
1262019-07-08T09:29:05  <hebasto> yes, i build on Debian, but it is not convenient to investigate a bug with system Qt
1272019-07-08T09:29:46  <hebasto> promag: we should wait for stretch EOL at least ;)
1282019-07-08T09:30:08  <promag> hebasto: if the problem doesn't exists with depends then I wouldn't be too worried
1292019-07-08T09:31:05  *** Aaronvan_ is now known as AaronvanW
1302019-07-08T09:32:05  <hebasto> anyway, consider to remove a private slot in #16349, if you don't mind
1312019-07-08T09:32:08  <gribble> https://github.com/bitcoin/bitcoin/issues/16349 | qt: Fix "opening a wallet" issue #15453 by hebasto · Pull Request #16349 · bitcoin/bitcoin · GitHub
1322019-07-08T09:33:07  *** timothy has joined #bitcoin-core-dev
1332019-07-08T09:35:52  *** hi102 has joined #bitcoin-core-dev
1342019-07-08T09:38:41  *** belcher has quit IRC
1352019-07-08T09:41:19  *** promag has quit IRC
1362019-07-08T09:44:07  *** booyah has quit IRC
1372019-07-08T09:45:16  *** booyah has joined #bitcoin-core-dev
1382019-07-08T09:49:22  *** promag has joined #bitcoin-core-dev
1392019-07-08T09:51:18  *** hexyul has quit IRC
1402019-07-08T09:52:32  *** promag has quit IRC
1412019-07-08T09:54:36  *** hexyul has joined #bitcoin-core-dev
1422019-07-08T10:02:38  *** masesa has joined #bitcoin-core-dev
1432019-07-08T10:09:00  *** promag has joined #bitcoin-core-dev
1442019-07-08T10:09:25  *** shesek has joined #bitcoin-core-dev
1452019-07-08T10:09:25  *** shesek has joined #bitcoin-core-dev
1462019-07-08T10:15:23  *** ElZakaria has joined #bitcoin-core-dev
1472019-07-08T10:24:32  <promag> hebasto: wrong pr?
1482019-07-08T10:26:06  *** spinza has quit IRC
1492019-07-08T10:26:07  <hebasto> promag: correct ;)  I mean WalletController::addWallet private slot.
1502019-07-08T10:26:29  <promag> whats the problem with that?
1512019-07-08T10:27:48  <hebasto> It seems redundant: everything could be run in one thread, IMO
1522019-07-08T10:30:52  <promag> hebasto: but it's not
1532019-07-08T10:30:57  <promag> m_node.handleLoadWallet
1542019-07-08T10:31:23  <promag> that callback is called from different thread
1552019-07-08T10:31:34  <promag> for instance, from the loadwallet rpc thread
1562019-07-08T10:33:48  <hebasto> I'll look into it more thoroughly.
1572019-07-08T10:34:10  *** spinza has joined #bitcoin-core-dev
1582019-07-08T10:35:04  *** spinza has quit IRC
1592019-07-08T10:44:15  *** cyberstorm_ has joined #bitcoin-core-dev
1602019-07-08T10:45:39  *** spinza has joined #bitcoin-core-dev
1612019-07-08T10:48:32  *** promag has quit IRC
1622019-07-08T10:54:05  *** ElZakaria has quit IRC
1632019-07-08T10:54:52  *** cyberstorm_ has quit IRC
1642019-07-08T10:58:10  *** bitcoin-git has joined #bitcoin-core-dev
1652019-07-08T10:58:10  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e1a8d76aff8d...f5a01cf25986
1662019-07-08T10:58:11  <bitcoin-git> bitcoin/master a30bd09 Gregory Sanders: Add logpath description for getrpcinfo
1672019-07-08T10:58:11  <bitcoin-git> bitcoin/master f5a01cf Wladimir J. van der Laan: Merge #16332: rpc: Add logpath description for getrpcinfo
1682019-07-08T10:58:13  *** bitcoin-git has left #bitcoin-core-dev
1692019-07-08T10:59:05  *** bitcoin-git has joined #bitcoin-core-dev
1702019-07-08T10:59:05  <bitcoin-git> [bitcoin] laanwj merged pull request #16332: rpc: Add logpath description for getrpcinfo (master...getrpcinfo_logpath_help) https://github.com/bitcoin/bitcoin/pull/16332
1712019-07-08T10:59:08  *** bitcoin-git has left #bitcoin-core-dev
1722019-07-08T10:59:56  <wumpus> getLoadedWallets() lol
1732019-07-08T11:00:25  <fanquake> wumpus: too explicit?
1742019-07-08T11:00:37  <wumpus> promag_: I'm not a native speaker but that sounds somehow wrong
1752019-07-08T11:01:06  <wumpus> at least it's funny
1762019-07-08T11:03:35  <wumpus> I'm not sure all the additional changes are necessary in a PR that just adds deterministic sorting, but YMMV
1772019-07-08T11:07:35  <wumpus> ok using a map in listWalletDir seems an improvement because there's a second pass that is now O(N^2)
1782019-07-08T11:12:36  <wumpus> well not N^2 but ... removing things one by one from a vector is still a code stink usually
1792019-07-08T11:15:52  <wumpus> so +1 on that, did leave a comment about some other (likely unexpected) change of behavior
1802019-07-08T11:29:14  *** goatpig has joined #bitcoin-core-dev
1812019-07-08T11:33:37  *** bitcoin-git has joined #bitcoin-core-dev
1822019-07-08T11:33:37  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5a01cf25986...983c84844c59
1832019-07-08T11:33:38  <bitcoin-git> bitcoin/master e8fabd9 fanquake: build: prune dbus from depends
1842019-07-08T11:33:38  <bitcoin-git> bitcoin/master 983c848 Wladimir J. van der Laan: Merge #16352: build: prune dbus from depends
1852019-07-08T11:33:40  *** bitcoin-git has left #bitcoin-core-dev
1862019-07-08T11:34:32  *** bitcoin-git has joined #bitcoin-core-dev
1872019-07-08T11:34:32  <bitcoin-git> [bitcoin] laanwj merged pull request #16352: build: prune dbus from depends (master...depends_prune_dbus) https://github.com/bitcoin/bitcoin/pull/16352
1882019-07-08T11:34:35  *** bitcoin-git has left #bitcoin-core-dev
1892019-07-08T11:40:12  *** afk11 has quit IRC
1902019-07-08T11:41:59  *** afk11 has joined #bitcoin-core-dev
1912019-07-08T11:45:28  *** Nukeops has quit IRC
1922019-07-08T11:45:40  *** Nukeops has joined #bitcoin-core-dev
1932019-07-08T11:51:33  *** phwalkr has joined #bitcoin-core-dev
1942019-07-08T11:58:03  *** cdecker has joined #bitcoin-core-dev
1952019-07-08T12:00:02  *** evrt has quit IRC
1962019-07-08T12:03:21  <cdecker> Bind alt-n to toggle the nicklist.
1972019-07-08T12:03:53  <cdecker> Oops, wrong window ^^"
1982019-07-08T12:04:35  *** stranger64 has joined #bitcoin-core-dev
1992019-07-08T12:14:03  *** hebasto has quit IRC
2002019-07-08T12:19:42  *** hebasto has joined #bitcoin-core-dev
2012019-07-08T12:26:05  *** scoop has joined #bitcoin-core-dev
2022019-07-08T12:29:53  *** shesek has quit IRC
2032019-07-08T12:30:46  *** scoop has quit IRC
2042019-07-08T12:35:36  *** DeanWeen has quit IRC
2052019-07-08T12:43:21  *** Guyver2 has quit IRC
2062019-07-08T12:44:58  *** masesa has quit IRC
2072019-07-08T12:55:08  *** shesek has joined #bitcoin-core-dev
2082019-07-08T12:58:05  *** bitcoin-git has joined #bitcoin-core-dev
2092019-07-08T12:58:07  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/983c84844c59...b5fa2319d863
2102019-07-08T12:58:07  <bitcoin-git> bitcoin/master 1eb13f0 Jon Atack: test: Add log messages to test/functional/tool_wallet.py
2112019-07-08T12:58:08  <bitcoin-git> bitcoin/master 3bf2b3a Jon Atack: test: Split tool_wallet.py test into subtests
2122019-07-08T12:58:09  <bitcoin-git> bitcoin/master 7195fa7 Jon Atack: test: Tool wallet test coverage for unexpected writes to wallet
2132019-07-08T12:58:11  *** bitcoin-git has left #bitcoin-core-dev
2142019-07-08T12:58:45  *** bitcoin-git has joined #bitcoin-core-dev
2152019-07-08T12:58:45  <bitcoin-git> [bitcoin] laanwj merged pull request #15687: test: tool wallet test coverage for unexpected writes to wallet (master...tool-wallet-tests-for-unexpected-writes-to-wallet-file) https://github.com/bitcoin/bitcoin/pull/15687
2162019-07-08T12:58:48  *** bitcoin-git has left #bitcoin-core-dev
2172019-07-08T13:05:33  *** promag_ is now known as promag
2182019-07-08T13:05:40  <promag> wumpus: what the problem with getLoadedWallets?
2192019-07-08T13:08:59  <wumpus> promag: it sounds strange to me (and not just because of the double definition of 'loaded' esp in the context of money)
2202019-07-08T13:09:00  <promag> I could drop 2nd commit or rename to something else
2212019-07-08T13:09:22  <wumpus> yea, I'm not sure the renaming is necessary at all
2222019-07-08T13:09:38  <promag> but more importantly is that currently listWalletDir is called twice
2232019-07-08T13:10:53  <promag> The rename was done because of https://github.com/bitcoin/bitcoin/pull/16106#discussion_r287878827
2242019-07-08T13:11:44  <promag> I'm going to address your comment, let me know if the rename can be dropped (could keep a comment thought)
2252019-07-08T13:15:27  <wumpus> getOpenWallets maybe ?
2262019-07-08T13:15:48  <promag> sold
2272019-07-08T13:16:11  <wumpus> let's do that then :)
2282019-07-08T13:22:56  <promag> done
2292019-07-08T13:29:40  *** Guest61179 has quit IRC
2302019-07-08T13:31:12  *** bitcoin-git has joined #bitcoin-core-dev
2312019-07-08T13:31:12  <bitcoin-git> [bitcoin] fanquake closed pull request #16351: 0.18 backport: backport github-merge.py improvements (0.18...backport_github_merge_improvements) https://github.com/bitcoin/bitcoin/pull/16351
2322019-07-08T13:31:26  *** bitcoin-git has left #bitcoin-core-dev
2332019-07-08T13:32:12  *** sipa has quit IRC
2342019-07-08T13:33:03  *** queip has quit IRC
2352019-07-08T13:34:57  *** hebasto has quit IRC
2362019-07-08T13:39:40  *** sipa has joined #bitcoin-core-dev
2372019-07-08T13:40:09  *** queip has joined #bitcoin-core-dev
2382019-07-08T13:46:25  *** scoop has joined #bitcoin-core-dev
2392019-07-08T13:48:11  *** lightlike has joined #bitcoin-core-dev
2402019-07-08T13:50:38  *** d_t has joined #bitcoin-core-dev
2412019-07-08T13:52:12  <wumpus> promag: I think something went wrong in 16106
2422019-07-08T14:05:55  *** elichai2 has joined #bitcoin-core-dev
2432019-07-08T14:05:56  *** sipa has quit IRC
2442019-07-08T14:06:07  *** sipa has joined #bitcoin-core-dev
2452019-07-08T14:11:50  *** davterra has quit IRC
2462019-07-08T14:13:40  <promag> wumpus: yeah, outdated branch
2472019-07-08T14:13:50  <promag> wumpus: should be ok now
2482019-07-08T14:13:53  *** davterra has joined #bitcoin-core-dev
2492019-07-08T14:16:19  *** aseem has joined #bitcoin-core-dev
2502019-07-08T14:20:01  *** hebasto has joined #bitcoin-core-dev
2512019-07-08T14:27:10  <wumpus> rechecking
2522019-07-08T14:32:27  *** bitcoin-git has joined #bitcoin-core-dev
2532019-07-08T14:32:28  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b5fa2319d863...2679bb8919b5
2542019-07-08T14:32:29  <bitcoin-git> bitcoin/master 224eb95 João Barbosa: gui: Sort wallets in open wallet menu
2552019-07-08T14:32:29  <bitcoin-git> bitcoin/master fa90fe6 João Barbosa: refactor: Rename getWallets to getOpenWallets in WalletController
2562019-07-08T14:32:30  <bitcoin-git> bitcoin/master 2679bb8 Wladimir J. van der Laan: Merge #16106: gui: Sort wallets in open wallet menu
2572019-07-08T14:32:41  *** bitcoin-git has left #bitcoin-core-dev
2582019-07-08T14:33:03  <promag> thanks
2592019-07-08T14:33:18  *** bitcoin-git has joined #bitcoin-core-dev
2602019-07-08T14:33:18  <bitcoin-git> [bitcoin] laanwj merged pull request #16106: gui: Sort wallets in open wallet menu (master...2019-05-followup-15957) https://github.com/bitcoin/bitcoin/pull/16106
2612019-07-08T14:33:19  *** bitcoin-git has left #bitcoin-core-dev
2622019-07-08T14:38:57  *** michaelsdunn1 has joined #bitcoin-core-dev
2632019-07-08T14:38:58  *** michaelsdunn1 has quit IRC
2642019-07-08T14:38:58  *** michaelsdunn1 has joined #bitcoin-core-dev
2652019-07-08T14:43:59  *** e4xit has joined #bitcoin-core-dev
2662019-07-08T14:50:39  *** d_t has quit IRC
2672019-07-08T14:51:21  *** Guyver2 has joined #bitcoin-core-dev
2682019-07-08T14:58:46  *** hugohn has joined #bitcoin-core-dev
2692019-07-08T15:00:02  *** stranger64 has quit IRC
2702019-07-08T15:09:07  *** hugohn has quit IRC
2712019-07-08T15:11:56  *** hugohn has joined #bitcoin-core-dev
2722019-07-08T15:14:02  *** ermau has joined #bitcoin-core-dev
2732019-07-08T15:49:17  *** bitcoin-git has joined #bitcoin-core-dev
2742019-07-08T15:49:17  <bitcoin-git> [bitcoin] jamesob opened pull request #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp (master...2019-07-au-coinscatcher) https://github.com/bitcoin/bitcoin/pull/16355
2752019-07-08T15:49:18  *** bitcoin-git has left #bitcoin-core-dev
2762019-07-08T15:54:10  *** sfhi has joined #bitcoin-core-dev
2772019-07-08T15:57:58  *** owowo has quit IRC
2782019-07-08T15:58:33  *** jungly has quit IRC
2792019-07-08T16:03:36  *** owowo has joined #bitcoin-core-dev
2802019-07-08T16:04:05  <jnewbery> MarcoFalke: is #15891 ready for merge or are there comments outstanding? It has 3 ACKs
2812019-07-08T16:04:09  <gribble> https://github.com/bitcoin/bitcoin/issues/15891 | test: Require standard txs in regtest by default by MarcoFalke · Pull Request #15891 · bitcoin/bitcoin · GitHub
2822019-07-08T16:05:26  *** setpill has quit IRC
2832019-07-08T16:06:40  *** aseem has quit IRC
2842019-07-08T16:07:59  <jnewbery> achow101: what makes you think fqlx is from the review club? I don't think he's ever commented in there
2852019-07-08T16:09:58  <jnewbery> also, why would we block someone who's clearly just trying to help?! Can't you just ask him to look at the contributing docs and review smaller PRs first?
2862019-07-08T16:10:27  <sipa> agree
2872019-07-08T16:12:27  *** jarthur has joined #bitcoin-core-dev
2882019-07-08T16:16:53  *** hugohn has quit IRC
2892019-07-08T16:18:03  *** lightlike has quit IRC
2902019-07-08T16:18:15  *** lightlike has joined #bitcoin-core-dev
2912019-07-08T16:19:32  <promag> sipa already asked https://github.com/bitcoin/bitcoin/pull/16341#discussion_r300818321
2922019-07-08T16:20:35  <promag> me too https://github.com/bitcoin/bitcoin/pull/16267#discussion_r300812954
2932019-07-08T16:20:51  <achow101> jnewbery: he was asked multiple times and didn't seem to actually do it
2942019-07-08T16:21:31  <promag> hebasto: omg
2952019-07-08T16:21:52  <promag> someone: how can I search git history for a string?
2962019-07-08T16:23:23  *** e4xit has quit IRC
2972019-07-08T16:28:48  <jarthur> If searching commit messages, specifically: `git log --grep=<pattern>`   To search the actual code changes: `git grep <regexp> $(git rev-list --all)`
2982019-07-08T16:30:26  <promag> jarthur: thanks, I've used git log -S
2992019-07-08T16:31:38  *** darosior has quit IRC
3002019-07-08T16:42:32  *** StopAndDecrypt_ has joined #bitcoin-core-dev
3012019-07-08T16:46:02  *** StopAndDecrypt has quit IRC
3022019-07-08T16:47:51  *** hugohn has joined #bitcoin-core-dev
3032019-07-08T16:52:19  *** MarcoFalke has joined #bitcoin-core-dev
3042019-07-08T17:04:12  *** aseem has joined #bitcoin-core-dev
3052019-07-08T17:07:06  <wumpus> I agree blocking them goes a bit far if they're just trying to help, though if they keep commenting while clearly not understanding the code it is kind of annoying
3062019-07-08T17:12:53  *** davterra has quit IRC
3072019-07-08T17:16:22  <jb55> promag: I've always used git log -G for searching for strings, it seems to work well.
3082019-07-08T17:16:52  <jb55> there is some subtle difference between the two which I have yet to understand
3092019-07-08T17:30:29  <hebasto> promag: the question remains: why only Qt 5.7.1 needs that bugfix?
3102019-07-08T17:34:15  *** davterra has joined #bitcoin-core-dev
3112019-07-08T17:41:45  *** bitcoin-git has joined #bitcoin-core-dev
3122019-07-08T17:41:46  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2679bb8919b5...4882040182ea
3132019-07-08T17:41:46  <bitcoin-git> bitcoin/master fa5e9f1 MarcoFalke: build: Stop translating PACKAGE_NAME
3142019-07-08T17:41:47  <bitcoin-git> bitcoin/master fabe87d MarcoFalke: scripted-diff: Avoid passing PACKAGE_NAME for translation
3152019-07-08T17:41:48  <bitcoin-git> bitcoin/master fab8520 MarcoFalke: qt: Run «make translate» in ./src/
3162019-07-08T17:41:48  *** bitcoin-git has left #bitcoin-core-dev
3172019-07-08T17:42:31  *** bitcoin-git has joined #bitcoin-core-dev
3182019-07-08T17:42:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16291: gui: Stop translating PACKAGE_NAME (master...1906-noTranslatePackageName) https://github.com/bitcoin/bitcoin/pull/16291
3192019-07-08T17:42:32  *** bitcoin-git has left #bitcoin-core-dev
3202019-07-08T17:44:34  *** phwalkr has quit IRC
3212019-07-08T17:48:02  *** pinheadmz has quit IRC
3222019-07-08T17:49:12  *** owowo has quit IRC
3232019-07-08T17:51:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3242019-07-08T17:53:46  *** owowo has joined #bitcoin-core-dev
3252019-07-08T17:57:12  *** hebasto has quit IRC
3262019-07-08T17:58:13  *** sfhi has quit IRC
3272019-07-08T17:59:29  *** Zenton has quit IRC
3282019-07-08T18:00:01  *** ermau has quit IRC
3292019-07-08T18:02:42  *** timothy has quit IRC
3302019-07-08T18:06:23  *** secdragon has joined #bitcoin-core-dev
3312019-07-08T18:15:26  *** bitcoin-git has joined #bitcoin-core-dev
3322019-07-08T18:15:27  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4882040182ea...0a6ee9797e65
3332019-07-08T18:15:27  <bitcoin-git> bitcoin/master 91509ff Kirill Fomichev: bench: Benchmark blockToJSON
3342019-07-08T18:15:28  <bitcoin-git> bitcoin/master 0a6ee97 Wladimir J. van der Laan: Merge #16267: bench: Benchmark blockToJSON
3352019-07-08T18:15:40  *** bitcoin-git has left #bitcoin-core-dev
3362019-07-08T18:16:21  *** bitcoin-git has joined #bitcoin-core-dev
3372019-07-08T18:16:21  <bitcoin-git> [bitcoin] laanwj merged pull request #16267: bench: Benchmark blockToJSON (master...bench-blocktojson) https://github.com/bitcoin/bitcoin/pull/16267
3382019-07-08T18:16:23  *** bitcoin-git has left #bitcoin-core-dev
3392019-07-08T18:17:37  *** Victorsueca has quit IRC
3402019-07-08T18:21:43  *** Karyon has quit IRC
3412019-07-08T18:26:51  *** Karyon has joined #bitcoin-core-dev
3422019-07-08T18:29:08  *** scoop has quit IRC
3432019-07-08T18:29:26  *** bitcoin-git has joined #bitcoin-core-dev
3442019-07-08T18:29:26  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a6ee9797e65...345f42a9e3ae
3452019-07-08T18:29:26  <bitcoin-git> bitcoin/master c4606b8 practicalswift: Add Travis check for single parameter constructors not marked "explicit"
3462019-07-08T18:29:27  <bitcoin-git> bitcoin/master 345f42a Wladimir J. van der Laan: Merge #14505: test: Add linter to make sure single parameter constructors ...
3472019-07-08T18:29:28  *** bitcoin-git has left #bitcoin-core-dev
3482019-07-08T18:29:46  *** bitcoin-git has joined #bitcoin-core-dev
3492019-07-08T18:29:46  <bitcoin-git> [bitcoin] laanwj merged pull request #14505: test: Add linter to make sure single parameter constructors are marked explicit (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
3502019-07-08T18:29:47  *** bitcoin-git has left #bitcoin-core-dev
3512019-07-08T18:30:01  *** scoop has joined #bitcoin-core-dev
3522019-07-08T18:30:07  *** pinheadmz has joined #bitcoin-core-dev
3532019-07-08T18:35:28  *** scoop has quit IRC
3542019-07-08T18:40:42  *** lnostdal has quit IRC
3552019-07-08T18:42:26  *** lnostdal has joined #bitcoin-core-dev
3562019-07-08T18:45:36  *** bitcoin-git has joined #bitcoin-core-dev
3572019-07-08T18:45:37  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345f42a9e3ae...c799976c86e2
3582019-07-08T18:45:37  <bitcoin-git> bitcoin/master e1a5569 Gregory Sanders: Delete error-prone CScript constructor
3592019-07-08T18:45:37  <bitcoin-git> bitcoin/master c799976 Wladimir J. van der Laan: Merge #16128: Delete error-prone CScript constructor only used with FindAn...
3602019-07-08T18:45:38  *** bitcoin-git has left #bitcoin-core-dev
3612019-07-08T18:46:26  *** bitcoin-git has joined #bitcoin-core-dev
3622019-07-08T18:46:27  <bitcoin-git> [bitcoin] laanwj merged pull request #16128: Delete error-prone CScript constructor only used with FindAndDelete (master...cscript_construct) https://github.com/bitcoin/bitcoin/pull/16128
3632019-07-08T18:46:40  *** bitcoin-git has left #bitcoin-core-dev
3642019-07-08T18:53:20  *** bitcoin-git has joined #bitcoin-core-dev
3652019-07-08T18:53:20  <bitcoin-git> [bitcoin] instagibbs closed pull request #13057: refactor pre-selected coin code (master...selectedcoins) https://github.com/bitcoin/bitcoin/pull/13057
3662019-07-08T18:53:21  *** spaced0ut has quit IRC
3672019-07-08T18:53:23  *** bitcoin-git has left #bitcoin-core-dev
3682019-07-08T18:59:10  *** obsrver has quit IRC
3692019-07-08T19:02:07  *** emilengler has joined #bitcoin-core-dev
3702019-07-08T19:05:54  *** hebasto has joined #bitcoin-core-dev
3712019-07-08T19:06:04  *** Karyon has quit IRC
3722019-07-08T19:07:58  *** owowo has quit IRC
3732019-07-08T19:12:59  *** owowo has joined #bitcoin-core-dev
3742019-07-08T19:12:59  *** owowo has joined #bitcoin-core-dev
3752019-07-08T19:22:05  *** Victorsueca has joined #bitcoin-core-dev
3762019-07-08T19:29:40  *** hebasto has quit IRC
3772019-07-08T19:33:48  *** shesek has quit IRC
3782019-07-08T19:47:54  *** scoop has joined #bitcoin-core-dev
3792019-07-08T19:56:12  *** emilengler has quit IRC
3802019-07-08T19:57:29  *** Zenton has joined #bitcoin-core-dev
3812019-07-08T19:58:44  *** belcher has joined #bitcoin-core-dev
3822019-07-08T20:19:59  *** darosior has joined #bitcoin-core-dev
3832019-07-08T20:43:50  *** scoop has quit IRC
3842019-07-08T20:49:37  *** scoop has joined #bitcoin-core-dev
3852019-07-08T20:53:58  *** Chris_Stewart_5 has quit IRC
3862019-07-08T21:00:01  *** secdragon has quit IRC
3872019-07-08T21:01:03  <achow101> does bdb handle large binary blobs well? or should I break it up into separate records?
3882019-07-08T21:02:11  <sipa> achow101: are you going to rewrite all of them everytime something is updated?
3892019-07-08T21:02:29  <achow101> maybe? it'd be the descriptor cache
3902019-07-08T21:02:36  *** davec has quit IRC
3912019-07-08T21:02:48  <sipa> probably better to split that up in per-index entries
3922019-07-08T21:02:57  <sipa> as they're only written once
3932019-07-08T21:03:09  <sipa> if they are a single blob, you'd be rewriting the whole thing every time
3942019-07-08T21:03:16  <achow101> right
3952019-07-08T21:04:55  *** manishearth1 has joined #bitcoin-core-dev
3962019-07-08T21:05:54  *** e4xit has joined #bitcoin-core-dev
3972019-07-08T21:12:35  *** davec has joined #bitcoin-core-dev
3982019-07-08T21:14:33  *** hugohn has quit IRC
3992019-07-08T21:20:16  *** aseem has quit IRC
4002019-07-08T21:24:04  *** queip has quit IRC
4012019-07-08T21:29:03  *** queip has joined #bitcoin-core-dev
4022019-07-08T21:32:29  *** hugohn has joined #bitcoin-core-dev
4032019-07-08T21:46:26  *** scoop has quit IRC
4042019-07-08T21:47:59  *** Guyver2 has quit IRC
4052019-07-08T21:48:17  *** davterra has quit IRC
4062019-07-08T21:53:20  *** jarthur has quit IRC
4072019-07-08T21:53:50  *** hugohn has quit IRC
4082019-07-08T22:07:11  *** scoop has joined #bitcoin-core-dev
4092019-07-08T22:09:27  *** spinza has quit IRC
4102019-07-08T22:16:30  *** ccdle12 has quit IRC
4112019-07-08T22:19:04  *** EagleTM has quit IRC
4122019-07-08T22:23:06  *** ccdle12 has joined #bitcoin-core-dev
4132019-07-08T22:26:53  *** EagleTM has joined #bitcoin-core-dev
4142019-07-08T22:27:52  *** ccdle12 has quit IRC
4152019-07-08T22:30:35  *** spinza has joined #bitcoin-core-dev
4162019-07-08T22:36:53  *** michaelsdunn1 has quit IRC
4172019-07-08T22:46:34  *** ccdle12 has joined #bitcoin-core-dev
4182019-07-08T22:48:56  *** hugohn has joined #bitcoin-core-dev
4192019-07-08T22:55:10  *** hugohn has quit IRC
4202019-07-08T23:00:16  *** davterra has joined #bitcoin-core-dev
4212019-07-08T23:12:58  *** darosior has quit IRC
4222019-07-08T23:13:07  *** hex17or has quit IRC
4232019-07-08T23:13:36  *** darosior has joined #bitcoin-core-dev
4242019-07-08T23:23:55  *** AaronvanW has quit IRC
4252019-07-08T23:29:50  *** hex17or has joined #bitcoin-core-dev
4262019-07-08T23:33:24  *** queip has quit IRC
4272019-07-08T23:33:36  *** bitcoin-git has joined #bitcoin-core-dev
4282019-07-08T23:33:36  <bitcoin-git> [bitcoin] cajunlady78 opened pull request #16356: BIP148 user activated activation of segwit (master...bip-segwit-flagday) https://github.com/bitcoin/bitcoin/pull/16356
4292019-07-08T23:33:37  *** bitcoin-git has left #bitcoin-core-dev
4302019-07-08T23:33:51  *** bitcoin-git has joined #bitcoin-core-dev
4312019-07-08T23:33:51  <bitcoin-git> [bitcoin] cajunlady78 closed pull request #16356: BIP148 user activated activation of segwit (master...bip-segwit-flagday) https://github.com/bitcoin/bitcoin/pull/16356
4322019-07-08T23:33:58  *** bitcoin-git has left #bitcoin-core-dev
4332019-07-08T23:40:16  *** queip has joined #bitcoin-core-dev
4342019-07-08T23:42:48  *** lightlike has quit IRC
4352019-07-08T23:50:51  *** bitcoin-git has joined #bitcoin-core-dev
4362019-07-08T23:50:51  <bitcoin-git> [bitcoin] nkostoulas opened pull request #16357: Implement modulo for arith_uint256 (master...uint256-modulo) https://github.com/bitcoin/bitcoin/pull/16357
4372019-07-08T23:50:52  *** bitcoin-git has left #bitcoin-core-dev
4382019-07-08T23:58:46  *** AaronvanW has joined #bitcoin-core-dev