1 2019-07-08T00:00:01  *** mrd1 has quit IRC
  2 2019-07-08T00:19:19  *** Ceriand has joined #bitcoin-core-dev
  3 2019-07-08T00:22:58  *** bitcoin-git has joined #bitcoin-core-dev
  4 2019-07-08T00:22:59  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f373beebbcc0...05623c021681
  5 2019-07-08T00:22:59  <bitcoin-git> bitcoin/master d003110 Hennadii Stepanov: Remove unused guard
  6 2019-07-08T00:23:00  <bitcoin-git> bitcoin/master 05623c0 fanquake: Merge #16350: qt: Remove unused guard
  7 2019-07-08T00:23:03  *** bitcoin-git has left #bitcoin-core-dev
  8 2019-07-08T00:24:03  *** bitcoin-git has joined #bitcoin-core-dev
  9 2019-07-08T00:24:04  <bitcoin-git> [bitcoin] fanquake merged pull request #16350: qt: Remove unused guard (master...20190707-remove-unused-guard) https://github.com/bitcoin/bitcoin/pull/16350
 10 2019-07-08T00:24:05  *** bitcoin-git has left #bitcoin-core-dev
 11 2019-07-08T00:27:28  *** promag has quit IRC
 12 2019-07-08T00:28:08  *** promag has joined #bitcoin-core-dev
 13 2019-07-08T00:33:14  *** promag has quit IRC
 14 2019-07-08T00:35:37  *** d_t has quit IRC
 15 2019-07-08T00:35:44  *** bitcoin-git has joined #bitcoin-core-dev
 16 2019-07-08T00:35:45  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05623c021681...2b465195e09a
 17 2019-07-08T00:35:45  <bitcoin-git> bitcoin/master 64b27c4 fanquake: docs: add reduce-memory.md
 18 2019-07-08T00:35:46  <bitcoin-git> bitcoin/master 2b46519 fanquake: Merge #16339: doc: add reduce-memory.md
 19 2019-07-08T00:35:48  *** bitcoin-git has left #bitcoin-core-dev
 20 2019-07-08T00:36:48  *** bitcoin-git has joined #bitcoin-core-dev
 21 2019-07-08T00:36:49  <bitcoin-git> [bitcoin] fanquake merged pull request #16339: doc: add reduce-memory.md (master...doc-reduce-memory-usage) https://github.com/bitcoin/bitcoin/pull/16339
 22 2019-07-08T00:37:01  *** bitcoin-git has left #bitcoin-core-dev
 23 2019-07-08T00:51:21  *** MoonJaCk- has quit IRC
 24 2019-07-08T01:15:10  *** shesek has joined #bitcoin-core-dev
 25 2019-07-08T01:15:10  *** shesek has quit IRC
 26 2019-07-08T01:15:10  *** shesek has joined #bitcoin-core-dev
 27 2019-07-08T01:17:02  *** elichai2 has quit IRC
 28 2019-07-08T01:20:33  *** d_t has joined #bitcoin-core-dev
 29 2019-07-08T01:22:14  *** elichai2 has joined #bitcoin-core-dev
 30 2019-07-08T01:40:17  *** cyberstorm_ has quit IRC
 31 2019-07-08T01:48:23  *** mdunnio has joined #bitcoin-core-dev
 32 2019-07-08T02:31:10  *** scoop has joined #bitcoin-core-dev
 33 2019-07-08T02:32:01  *** Raystonn has joined #bitcoin-core-dev
 34 2019-07-08T02:45:24  *** promag has joined #bitcoin-core-dev
 35 2019-07-08T02:45:36  *** kristapsk has quit IRC
 36 2019-07-08T02:46:58  *** kristapsk has joined #bitcoin-core-dev
 37 2019-07-08T02:49:38  *** promag has quit IRC
 38 2019-07-08T02:51:19  *** scoop has quit IRC
 39 2019-07-08T02:51:46  *** scoop has joined #bitcoin-core-dev
 40 2019-07-08T02:58:08  *** mdunnio has quit IRC
 41 2019-07-08T02:58:35  *** mdunnio has joined #bitcoin-core-dev
 42 2019-07-08T02:58:54  *** mdunnio has quit IRC
 43 2019-07-08T02:59:23  *** mdunnio has joined #bitcoin-core-dev
 44 2019-07-08T02:59:42  *** mdunnio has quit IRC
 45 2019-07-08T03:00:02  *** Ceriand has quit IRC
 46 2019-07-08T03:02:07  *** mdunnio has joined #bitcoin-core-dev
 47 2019-07-08T03:02:25  *** scoop has quit IRC
 48 2019-07-08T03:04:28  *** nighmi has joined #bitcoin-core-dev
 49 2019-07-08T03:04:33  *** nighmi is now known as Guest47769
 50 2019-07-08T03:07:54  *** scoop has joined #bitcoin-core-dev
 51 2019-07-08T03:13:35  *** d_t has quit IRC
 52 2019-07-08T03:15:36  *** Raystonn has quit IRC
 53 2019-07-08T03:24:48  *** scoop has quit IRC
 54 2019-07-08T03:25:14  *** scoop has joined #bitcoin-core-dev
 55 2019-07-08T03:29:56  *** scoop has quit IRC
 56 2019-07-08T03:30:01  *** goatpig has quit IRC
 57 2019-07-08T03:45:10  *** luke-jr has joined #bitcoin-core-dev
 58 2019-07-08T03:45:22  *** Honthe has quit IRC
 59 2019-07-08T03:47:02  *** elichai2 has quit IRC
 60 2019-07-08T03:48:25  *** DeanWeen has joined #bitcoin-core-dev
 61 2019-07-08T04:45:58  *** promag has joined #bitcoin-core-dev
 62 2019-07-08T04:50:44  *** promag has quit IRC
 63 2019-07-08T04:59:15  *** hebasto has joined #bitcoin-core-dev
 64 2019-07-08T05:03:05  *** Karyon has quit IRC
 65 2019-07-08T05:11:52  *** Karyon has joined #bitcoin-core-dev
 66 2019-07-08T05:13:04  *** X3sA5WavYxY has joined #bitcoin-core-dev
 67 2019-07-08T05:30:35  *** X3sA5WavYxY has quit IRC
 68 2019-07-08T05:34:44  *** Karyon has quit IRC
 69 2019-07-08T06:00:01  *** Guest47769 has quit IRC
 70 2019-07-08T06:05:52  *** Karyon has joined #bitcoin-core-dev
 71 2019-07-08T06:17:44  *** DARKNE55 has joined #bitcoin-core-dev
 72 2019-07-08T06:27:39  *** promag has joined #bitcoin-core-dev
 73 2019-07-08T06:32:20  *** promag has quit IRC
 74 2019-07-08T07:10:18  *** Guyver2 has joined #bitcoin-core-dev
 75 2019-07-08T07:14:56  *** Fleta77Towne has joined #bitcoin-core-dev
 76 2019-07-08T07:21:11  *** ccdle12 has joined #bitcoin-core-dev
 77 2019-07-08T07:25:53  *** Fleta77Towne has quit IRC
 78 2019-07-08T07:30:48  *** bitcoin-git has joined #bitcoin-core-dev
 79 2019-07-08T07:30:49  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2b465195e09a...e1a8d76aff8d
 80 2019-07-08T07:30:49  <bitcoin-git> bitcoin/master 84ad4d2 Carl Dong: doc: Include static members in Doxygen
 81 2019-07-08T07:30:50  <bitcoin-git> bitcoin/master e1a8d76 Wladimir J. van der Laan: Merge #16347: doc: Include static members in Doxygen
 82 2019-07-08T07:30:51  *** bitcoin-git has left #bitcoin-core-dev
 83 2019-07-08T07:31:58  *** bitcoin-git has joined #bitcoin-core-dev
 84 2019-07-08T07:31:59  <bitcoin-git> [bitcoin] laanwj merged pull request #16347: doc: Include static members in Doxygen (master...2019-07-doxygen-extract-static) https://github.com/bitcoin/bitcoin/pull/16347
 85 2019-07-08T07:32:00  *** bitcoin-git has left #bitcoin-core-dev
 86 2019-07-08T07:32:33  *** AaronvanW has joined #bitcoin-core-dev
 87 2019-07-08T07:36:24  *** Aaronvan_ has joined #bitcoin-core-dev
 88 2019-07-08T07:40:44  *** AaronvanW has quit IRC
 89 2019-07-08T07:45:43  *** jungly has joined #bitcoin-core-dev
 90 2019-07-08T07:47:23  *** queip has quit IRC
 91 2019-07-08T07:57:58  *** queip has joined #bitcoin-core-dev
 92 2019-07-08T08:06:44  *** setpill has joined #bitcoin-core-dev
 93 2019-07-08T08:06:53  *** ccdle12 has quit IRC
 94 2019-07-08T08:08:06  *** ccdle12 has joined #bitcoin-core-dev
 95 2019-07-08T08:20:17  *** shesek has quit IRC
 96 2019-07-08T08:27:24  *** darosior has joined #bitcoin-core-dev
 97 2019-07-08T08:34:00  *** Zenton has joined #bitcoin-core-dev
 98 2019-07-08T08:43:23  *** reallll has joined #bitcoin-core-dev
 99 2019-07-08T08:47:01  *** belcher has quit IRC
100 2019-07-08T08:55:48  *** reallll is now known as belcher
101 2019-07-08T08:57:04  *** setpill has quit IRC
102 2019-07-08T08:57:27  *** setpill has joined #bitcoin-core-dev
103 2019-07-08T08:57:50  *** promag has joined #bitcoin-core-dev
104 2019-07-08T08:58:29  *** promag_ has joined #bitcoin-core-dev
105 2019-07-08T08:59:03  *** promag_ has joined #bitcoin-core-dev
106 2019-07-08T09:00:02  *** DARKNE55 has quit IRC
107 2019-07-08T09:04:43  *** evrt has joined #bitcoin-core-dev
108 2019-07-08T09:13:32  <promag> imo #16106 is ready to merge
109 2019-07-08T09:13:35  <gribble> https://github.com/bitcoin/bitcoin/issues/16106 | gui: Sort wallets in open wallet menu by promag · Pull Request #16106 · bitcoin/bitcoin · GitHub
110 2019-07-08T09:14:13  <promag> #15305 seems like forgotten
111 2019-07-08T09:14:16  <gribble> https://github.com/bitcoin/bitcoin/issues/15305 | [validation] Crash if disconnecting a block fails by sdaftuar · Pull Request #15305 · bitcoin/bitcoin · GitHub
112 2019-07-08T09:17:43  *** obsrver has joined #bitcoin-core-dev
113 2019-07-08T09:24:32  <fanquake> promag I’ll look at sort wallets tonight, sorry.
114 2019-07-08T09:24:45  <promag> no worries
115 2019-07-08T09:25:45  <promag> #16285 is also a pretty simple change
116 2019-07-08T09:25:46  <gribble> https://github.com/bitcoin/bitcoin/issues/16285 | rpc: Improve scantxoutset response and help message by promag · Pull Request #16285 · bitcoin/bitcoin · GitHub
117 2019-07-08T09:26:42  *** obsrver has quit IRC
118 2019-07-08T09:26:42  <hebasto> promag: fanquake: hi, did you try to build with downloaded Qt 5.7.1?
119 2019-07-08T09:26:53  <promag> hebasto: no
120 2019-07-08T09:26:53  *** obsrver has joined #bitcoin-core-dev
121 2019-07-08T09:27:08  <promag> hebasto: the problem only exists with 5.7.1?
122 2019-07-08T09:27:19  <fanquake> on Debian with -nowallet? I used apt installed.
123 2019-07-08T09:27:21  <hebasto> it seems so...
124 2019-07-08T09:27:51  <fanquake> Assuming I’m thinking of the right issue.
125 2019-07-08T09:28:51  <promag> let's just bump to qt 5.10 X)
126 2019-07-08T09:29:05  <hebasto> yes, i build on Debian, but it is not convenient to investigate a bug with system Qt
127 2019-07-08T09:29:46  <hebasto> promag: we should wait for stretch EOL at least ;)
128 2019-07-08T09:30:08  <promag> hebasto: if the problem doesn't exists with depends then I wouldn't be too worried
129 2019-07-08T09:31:05  *** Aaronvan_ is now known as AaronvanW
130 2019-07-08T09:32:05  <hebasto> anyway, consider to remove a private slot in #16349, if you don't mind
131 2019-07-08T09:32:08  <gribble> https://github.com/bitcoin/bitcoin/issues/16349 | qt: Fix "opening a wallet" issue #15453 by hebasto · Pull Request #16349 · bitcoin/bitcoin · GitHub
132 2019-07-08T09:33:07  *** timothy has joined #bitcoin-core-dev
133 2019-07-08T09:35:52  *** hi102 has joined #bitcoin-core-dev
134 2019-07-08T09:38:41  *** belcher has quit IRC
135 2019-07-08T09:41:19  *** promag has quit IRC
136 2019-07-08T09:44:07  *** booyah has quit IRC
137 2019-07-08T09:45:16  *** booyah has joined #bitcoin-core-dev
138 2019-07-08T09:49:22  *** promag has joined #bitcoin-core-dev
139 2019-07-08T09:51:18  *** hexyul has quit IRC
140 2019-07-08T09:52:32  *** promag has quit IRC
141 2019-07-08T09:54:36  *** hexyul has joined #bitcoin-core-dev
142 2019-07-08T10:02:38  *** masesa has joined #bitcoin-core-dev
143 2019-07-08T10:09:00  *** promag has joined #bitcoin-core-dev
144 2019-07-08T10:09:25  *** shesek has joined #bitcoin-core-dev
145 2019-07-08T10:09:25  *** shesek has joined #bitcoin-core-dev
146 2019-07-08T10:15:23  *** ElZakaria has joined #bitcoin-core-dev
147 2019-07-08T10:24:32  <promag> hebasto: wrong pr?
148 2019-07-08T10:26:06  *** spinza has quit IRC
149 2019-07-08T10:26:07  <hebasto> promag: correct ;)  I mean WalletController::addWallet private slot.
150 2019-07-08T10:26:29  <promag> whats the problem with that?
151 2019-07-08T10:27:48  <hebasto> It seems redundant: everything could be run in one thread, IMO
152 2019-07-08T10:30:52  <promag> hebasto: but it's not
153 2019-07-08T10:30:57  <promag> m_node.handleLoadWallet
154 2019-07-08T10:31:23  <promag> that callback is called from different thread
155 2019-07-08T10:31:34  <promag> for instance, from the loadwallet rpc thread
156 2019-07-08T10:33:48  <hebasto> I'll look into it more thoroughly.
157 2019-07-08T10:34:10  *** spinza has joined #bitcoin-core-dev
158 2019-07-08T10:35:04  *** spinza has quit IRC
159 2019-07-08T10:44:15  *** cyberstorm_ has joined #bitcoin-core-dev
160 2019-07-08T10:45:39  *** spinza has joined #bitcoin-core-dev
161 2019-07-08T10:48:32  *** promag has quit IRC
162 2019-07-08T10:54:05  *** ElZakaria has quit IRC
163 2019-07-08T10:54:52  *** cyberstorm_ has quit IRC
164 2019-07-08T10:58:10  *** bitcoin-git has joined #bitcoin-core-dev
165 2019-07-08T10:58:10  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e1a8d76aff8d...f5a01cf25986
166 2019-07-08T10:58:11  <bitcoin-git> bitcoin/master a30bd09 Gregory Sanders: Add logpath description for getrpcinfo
167 2019-07-08T10:58:11  <bitcoin-git> bitcoin/master f5a01cf Wladimir J. van der Laan: Merge #16332: rpc: Add logpath description for getrpcinfo
168 2019-07-08T10:58:13  *** bitcoin-git has left #bitcoin-core-dev
169 2019-07-08T10:59:05  *** bitcoin-git has joined #bitcoin-core-dev
170 2019-07-08T10:59:05  <bitcoin-git> [bitcoin] laanwj merged pull request #16332: rpc: Add logpath description for getrpcinfo (master...getrpcinfo_logpath_help) https://github.com/bitcoin/bitcoin/pull/16332
171 2019-07-08T10:59:08  *** bitcoin-git has left #bitcoin-core-dev
172 2019-07-08T10:59:56  <wumpus> getLoadedWallets() lol
173 2019-07-08T11:00:25  <fanquake> wumpus: too explicit?
174 2019-07-08T11:00:37  <wumpus> promag_: I'm not a native speaker but that sounds somehow wrong
175 2019-07-08T11:01:06  <wumpus> at least it's funny
176 2019-07-08T11:03:35  <wumpus> I'm not sure all the additional changes are necessary in a PR that just adds deterministic sorting, but YMMV
177 2019-07-08T11:07:35  <wumpus> ok using a map in listWalletDir seems an improvement because there's a second pass that is now O(N^2)
178 2019-07-08T11:12:36  <wumpus> well not N^2 but ... removing things one by one from a vector is still a code stink usually
179 2019-07-08T11:15:52  <wumpus> so +1 on that, did leave a comment about some other (likely unexpected) change of behavior
180 2019-07-08T11:29:14  *** goatpig has joined #bitcoin-core-dev
181 2019-07-08T11:33:37  *** bitcoin-git has joined #bitcoin-core-dev
182 2019-07-08T11:33:37  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f5a01cf25986...983c84844c59
183 2019-07-08T11:33:38  <bitcoin-git> bitcoin/master e8fabd9 fanquake: build: prune dbus from depends
184 2019-07-08T11:33:38  <bitcoin-git> bitcoin/master 983c848 Wladimir J. van der Laan: Merge #16352: build: prune dbus from depends
185 2019-07-08T11:33:40  *** bitcoin-git has left #bitcoin-core-dev
186 2019-07-08T11:34:32  *** bitcoin-git has joined #bitcoin-core-dev
187 2019-07-08T11:34:32  <bitcoin-git> [bitcoin] laanwj merged pull request #16352: build: prune dbus from depends (master...depends_prune_dbus) https://github.com/bitcoin/bitcoin/pull/16352
188 2019-07-08T11:34:35  *** bitcoin-git has left #bitcoin-core-dev
189 2019-07-08T11:40:12  *** afk11 has quit IRC
190 2019-07-08T11:41:59  *** afk11 has joined #bitcoin-core-dev
191 2019-07-08T11:45:28  *** Nukeops has quit IRC
192 2019-07-08T11:45:40  *** Nukeops has joined #bitcoin-core-dev
193 2019-07-08T11:51:33  *** phwalkr has joined #bitcoin-core-dev
194 2019-07-08T11:58:03  *** cdecker has joined #bitcoin-core-dev
195 2019-07-08T12:00:02  *** evrt has quit IRC
196 2019-07-08T12:03:21  <cdecker> Bind alt-n to toggle the nicklist.
197 2019-07-08T12:03:53  <cdecker> Oops, wrong window ^^"
198 2019-07-08T12:04:35  *** stranger64 has joined #bitcoin-core-dev
199 2019-07-08T12:14:03  *** hebasto has quit IRC
200 2019-07-08T12:19:42  *** hebasto has joined #bitcoin-core-dev
201 2019-07-08T12:26:05  *** scoop has joined #bitcoin-core-dev
202 2019-07-08T12:29:53  *** shesek has quit IRC
203 2019-07-08T12:30:46  *** scoop has quit IRC
204 2019-07-08T12:35:36  *** DeanWeen has quit IRC
205 2019-07-08T12:43:21  *** Guyver2 has quit IRC
206 2019-07-08T12:44:58  *** masesa has quit IRC
207 2019-07-08T12:55:08  *** shesek has joined #bitcoin-core-dev
208 2019-07-08T12:58:05  *** bitcoin-git has joined #bitcoin-core-dev
209 2019-07-08T12:58:07  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/983c84844c59...b5fa2319d863
210 2019-07-08T12:58:07  <bitcoin-git> bitcoin/master 1eb13f0 Jon Atack: test: Add log messages to test/functional/tool_wallet.py
211 2019-07-08T12:58:08  <bitcoin-git> bitcoin/master 3bf2b3a Jon Atack: test: Split tool_wallet.py test into subtests
212 2019-07-08T12:58:09  <bitcoin-git> bitcoin/master 7195fa7 Jon Atack: test: Tool wallet test coverage for unexpected writes to wallet
213 2019-07-08T12:58:11  *** bitcoin-git has left #bitcoin-core-dev
214 2019-07-08T12:58:45  *** bitcoin-git has joined #bitcoin-core-dev
215 2019-07-08T12:58:45  <bitcoin-git> [bitcoin] laanwj merged pull request #15687: test: tool wallet test coverage for unexpected writes to wallet (master...tool-wallet-tests-for-unexpected-writes-to-wallet-file) https://github.com/bitcoin/bitcoin/pull/15687
216 2019-07-08T12:58:48  *** bitcoin-git has left #bitcoin-core-dev
217 2019-07-08T13:05:33  *** promag_ is now known as promag
218 2019-07-08T13:05:40  <promag> wumpus: what the problem with getLoadedWallets?
219 2019-07-08T13:08:59  <wumpus> promag: it sounds strange to me (and not just because of the double definition of 'loaded' esp in the context of money)
220 2019-07-08T13:09:00  <promag> I could drop 2nd commit or rename to something else
221 2019-07-08T13:09:22  <wumpus> yea, I'm not sure the renaming is necessary at all
222 2019-07-08T13:09:38  <promag> but more importantly is that currently listWalletDir is called twice
223 2019-07-08T13:10:53  <promag> The rename was done because of https://github.com/bitcoin/bitcoin/pull/16106#discussion_r287878827
224 2019-07-08T13:11:44  <promag> I'm going to address your comment, let me know if the rename can be dropped (could keep a comment thought)
225 2019-07-08T13:15:27  <wumpus> getOpenWallets maybe ?
226 2019-07-08T13:15:48  <promag> sold
227 2019-07-08T13:16:11  <wumpus> let's do that then :)
228 2019-07-08T13:22:56  <promag> done
229 2019-07-08T13:29:40  *** Guest61179 has quit IRC
230 2019-07-08T13:31:12  *** bitcoin-git has joined #bitcoin-core-dev
231 2019-07-08T13:31:12  <bitcoin-git> [bitcoin] fanquake closed pull request #16351: 0.18 backport: backport github-merge.py improvements (0.18...backport_github_merge_improvements) https://github.com/bitcoin/bitcoin/pull/16351
232 2019-07-08T13:31:26  *** bitcoin-git has left #bitcoin-core-dev
233 2019-07-08T13:32:12  *** sipa has quit IRC
234 2019-07-08T13:33:03  *** queip has quit IRC
235 2019-07-08T13:34:57  *** hebasto has quit IRC
236 2019-07-08T13:39:40  *** sipa has joined #bitcoin-core-dev
237 2019-07-08T13:40:09  *** queip has joined #bitcoin-core-dev
238 2019-07-08T13:46:25  *** scoop has joined #bitcoin-core-dev
239 2019-07-08T13:48:11  *** lightlike has joined #bitcoin-core-dev
240 2019-07-08T13:50:38  *** d_t has joined #bitcoin-core-dev
241 2019-07-08T13:52:12  <wumpus> promag: I think something went wrong in 16106
242 2019-07-08T14:05:55  *** elichai2 has joined #bitcoin-core-dev
243 2019-07-08T14:05:56  *** sipa has quit IRC
244 2019-07-08T14:06:07  *** sipa has joined #bitcoin-core-dev
245 2019-07-08T14:11:50  *** davterra has quit IRC
246 2019-07-08T14:13:40  <promag> wumpus: yeah, outdated branch
247 2019-07-08T14:13:50  <promag> wumpus: should be ok now
248 2019-07-08T14:13:53  *** davterra has joined #bitcoin-core-dev
249 2019-07-08T14:16:19  *** aseem has joined #bitcoin-core-dev
250 2019-07-08T14:20:01  *** hebasto has joined #bitcoin-core-dev
251 2019-07-08T14:27:10  <wumpus> rechecking
252 2019-07-08T14:32:27  *** bitcoin-git has joined #bitcoin-core-dev
253 2019-07-08T14:32:28  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b5fa2319d863...2679bb8919b5
254 2019-07-08T14:32:29  <bitcoin-git> bitcoin/master 224eb95 João Barbosa: gui: Sort wallets in open wallet menu
255 2019-07-08T14:32:29  <bitcoin-git> bitcoin/master fa90fe6 João Barbosa: refactor: Rename getWallets to getOpenWallets in WalletController
256 2019-07-08T14:32:30  <bitcoin-git> bitcoin/master 2679bb8 Wladimir J. van der Laan: Merge #16106: gui: Sort wallets in open wallet menu
257 2019-07-08T14:32:41  *** bitcoin-git has left #bitcoin-core-dev
258 2019-07-08T14:33:03  <promag> thanks
259 2019-07-08T14:33:18  *** bitcoin-git has joined #bitcoin-core-dev
260 2019-07-08T14:33:18  <bitcoin-git> [bitcoin] laanwj merged pull request #16106: gui: Sort wallets in open wallet menu (master...2019-05-followup-15957) https://github.com/bitcoin/bitcoin/pull/16106
261 2019-07-08T14:33:19  *** bitcoin-git has left #bitcoin-core-dev
262 2019-07-08T14:38:57  *** michaelsdunn1 has joined #bitcoin-core-dev
263 2019-07-08T14:38:58  *** michaelsdunn1 has quit IRC
264 2019-07-08T14:38:58  *** michaelsdunn1 has joined #bitcoin-core-dev
265 2019-07-08T14:43:59  *** e4xit has joined #bitcoin-core-dev
266 2019-07-08T14:50:39  *** d_t has quit IRC
267 2019-07-08T14:51:21  *** Guyver2 has joined #bitcoin-core-dev
268 2019-07-08T14:58:46  *** hugohn has joined #bitcoin-core-dev
269 2019-07-08T15:00:02  *** stranger64 has quit IRC
270 2019-07-08T15:09:07  *** hugohn has quit IRC
271 2019-07-08T15:11:56  *** hugohn has joined #bitcoin-core-dev
272 2019-07-08T15:14:02  *** ermau has joined #bitcoin-core-dev
273 2019-07-08T15:49:17  *** bitcoin-git has joined #bitcoin-core-dev
274 2019-07-08T15:49:17  <bitcoin-git> [bitcoin] jamesob opened pull request #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp (master...2019-07-au-coinscatcher) https://github.com/bitcoin/bitcoin/pull/16355
275 2019-07-08T15:49:18  *** bitcoin-git has left #bitcoin-core-dev
276 2019-07-08T15:54:10  *** sfhi has joined #bitcoin-core-dev
277 2019-07-08T15:57:58  *** owowo has quit IRC
278 2019-07-08T15:58:33  *** jungly has quit IRC
279 2019-07-08T16:03:36  *** owowo has joined #bitcoin-core-dev
280 2019-07-08T16:04:05  <jnewbery> MarcoFalke: is #15891 ready for merge or are there comments outstanding? It has 3 ACKs
281 2019-07-08T16:04:09  <gribble> https://github.com/bitcoin/bitcoin/issues/15891 | test: Require standard txs in regtest by default by MarcoFalke · Pull Request #15891 · bitcoin/bitcoin · GitHub
282 2019-07-08T16:05:26  *** setpill has quit IRC
283 2019-07-08T16:06:40  *** aseem has quit IRC
284 2019-07-08T16:07:59  <jnewbery> achow101: what makes you think fqlx is from the review club? I don't think he's ever commented in there
285 2019-07-08T16:09:58  <jnewbery> also, why would we block someone who's clearly just trying to help?! Can't you just ask him to look at the contributing docs and review smaller PRs first?
286 2019-07-08T16:10:27  <sipa> agree
287 2019-07-08T16:12:27  *** jarthur has joined #bitcoin-core-dev
288 2019-07-08T16:16:53  *** hugohn has quit IRC
289 2019-07-08T16:18:03  *** lightlike has quit IRC
290 2019-07-08T16:18:15  *** lightlike has joined #bitcoin-core-dev
291 2019-07-08T16:19:32  <promag> sipa already asked https://github.com/bitcoin/bitcoin/pull/16341#discussion_r300818321
292 2019-07-08T16:20:35  <promag> me too https://github.com/bitcoin/bitcoin/pull/16267#discussion_r300812954
293 2019-07-08T16:20:51  <achow101> jnewbery: he was asked multiple times and didn't seem to actually do it
294 2019-07-08T16:21:31  <promag> hebasto: omg
295 2019-07-08T16:21:52  <promag> someone: how can I search git history for a string?
296 2019-07-08T16:23:23  *** e4xit has quit IRC
297 2019-07-08T16:28:48  <jarthur> If searching commit messages, specifically: `git log --grep=<pattern>`   To search the actual code changes: `git grep <regexp> $(git rev-list --all)`
298 2019-07-08T16:30:26  <promag> jarthur: thanks, I've used git log -S
299 2019-07-08T16:31:38  *** darosior has quit IRC
300 2019-07-08T16:42:32  *** StopAndDecrypt_ has joined #bitcoin-core-dev
301 2019-07-08T16:46:02  *** StopAndDecrypt has quit IRC
302 2019-07-08T16:47:51  *** hugohn has joined #bitcoin-core-dev
303 2019-07-08T16:52:19  *** MarcoFalke has joined #bitcoin-core-dev
304 2019-07-08T17:04:12  *** aseem has joined #bitcoin-core-dev
305 2019-07-08T17:07:06  <wumpus> I agree blocking them goes a bit far if they're just trying to help, though if they keep commenting while clearly not understanding the code it is kind of annoying
306 2019-07-08T17:12:53  *** davterra has quit IRC
307 2019-07-08T17:16:22  <jb55> promag: I've always used git log -G for searching for strings, it seems to work well.
308 2019-07-08T17:16:52  <jb55> there is some subtle difference between the two which I have yet to understand
309 2019-07-08T17:30:29  <hebasto> promag: the question remains: why only Qt 5.7.1 needs that bugfix?
310 2019-07-08T17:34:15  *** davterra has joined #bitcoin-core-dev
311 2019-07-08T17:41:45  *** bitcoin-git has joined #bitcoin-core-dev
312 2019-07-08T17:41:46  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2679bb8919b5...4882040182ea
313 2019-07-08T17:41:46  <bitcoin-git> bitcoin/master fa5e9f1 MarcoFalke: build: Stop translating PACKAGE_NAME
314 2019-07-08T17:41:47  <bitcoin-git> bitcoin/master fabe87d MarcoFalke: scripted-diff: Avoid passing PACKAGE_NAME for translation
315 2019-07-08T17:41:48  <bitcoin-git> bitcoin/master fab8520 MarcoFalke: qt: Run «make translate» in ./src/
316 2019-07-08T17:41:48  *** bitcoin-git has left #bitcoin-core-dev
317 2019-07-08T17:42:31  *** bitcoin-git has joined #bitcoin-core-dev
318 2019-07-08T17:42:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16291: gui: Stop translating PACKAGE_NAME (master...1906-noTranslatePackageName) https://github.com/bitcoin/bitcoin/pull/16291
319 2019-07-08T17:42:32  *** bitcoin-git has left #bitcoin-core-dev
320 2019-07-08T17:44:34  *** phwalkr has quit IRC
321 2019-07-08T17:48:02  *** pinheadmz has quit IRC
322 2019-07-08T17:49:12  *** owowo has quit IRC
323 2019-07-08T17:51:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
324 2019-07-08T17:53:46  *** owowo has joined #bitcoin-core-dev
325 2019-07-08T17:57:12  *** hebasto has quit IRC
326 2019-07-08T17:58:13  *** sfhi has quit IRC
327 2019-07-08T17:59:29  *** Zenton has quit IRC
328 2019-07-08T18:00:01  *** ermau has quit IRC
329 2019-07-08T18:02:42  *** timothy has quit IRC
330 2019-07-08T18:06:23  *** secdragon has joined #bitcoin-core-dev
331 2019-07-08T18:15:26  *** bitcoin-git has joined #bitcoin-core-dev
332 2019-07-08T18:15:27  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4882040182ea...0a6ee9797e65
333 2019-07-08T18:15:27  <bitcoin-git> bitcoin/master 91509ff Kirill Fomichev: bench: Benchmark blockToJSON
334 2019-07-08T18:15:28  <bitcoin-git> bitcoin/master 0a6ee97 Wladimir J. van der Laan: Merge #16267: bench: Benchmark blockToJSON
335 2019-07-08T18:15:40  *** bitcoin-git has left #bitcoin-core-dev
336 2019-07-08T18:16:21  *** bitcoin-git has joined #bitcoin-core-dev
337 2019-07-08T18:16:21  <bitcoin-git> [bitcoin] laanwj merged pull request #16267: bench: Benchmark blockToJSON (master...bench-blocktojson) https://github.com/bitcoin/bitcoin/pull/16267
338 2019-07-08T18:16:23  *** bitcoin-git has left #bitcoin-core-dev
339 2019-07-08T18:17:37  *** Victorsueca has quit IRC
340 2019-07-08T18:21:43  *** Karyon has quit IRC
341 2019-07-08T18:26:51  *** Karyon has joined #bitcoin-core-dev
342 2019-07-08T18:29:08  *** scoop has quit IRC
343 2019-07-08T18:29:26  *** bitcoin-git has joined #bitcoin-core-dev
344 2019-07-08T18:29:26  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a6ee9797e65...345f42a9e3ae
345 2019-07-08T18:29:26  <bitcoin-git> bitcoin/master c4606b8 practicalswift: Add Travis check for single parameter constructors not marked "explicit"
346 2019-07-08T18:29:27  <bitcoin-git> bitcoin/master 345f42a Wladimir J. van der Laan: Merge #14505: test: Add linter to make sure single parameter constructors ...
347 2019-07-08T18:29:28  *** bitcoin-git has left #bitcoin-core-dev
348 2019-07-08T18:29:46  *** bitcoin-git has joined #bitcoin-core-dev
349 2019-07-08T18:29:46  <bitcoin-git> [bitcoin] laanwj merged pull request #14505: test: Add linter to make sure single parameter constructors are marked explicit (master...explicit-single-argument-constructors) https://github.com/bitcoin/bitcoin/pull/14505
350 2019-07-08T18:29:47  *** bitcoin-git has left #bitcoin-core-dev
351 2019-07-08T18:30:01  *** scoop has joined #bitcoin-core-dev
352 2019-07-08T18:30:07  *** pinheadmz has joined #bitcoin-core-dev
353 2019-07-08T18:35:28  *** scoop has quit IRC
354 2019-07-08T18:40:42  *** lnostdal has quit IRC
355 2019-07-08T18:42:26  *** lnostdal has joined #bitcoin-core-dev
356 2019-07-08T18:45:36  *** bitcoin-git has joined #bitcoin-core-dev
357 2019-07-08T18:45:37  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345f42a9e3ae...c799976c86e2
358 2019-07-08T18:45:37  <bitcoin-git> bitcoin/master e1a5569 Gregory Sanders: Delete error-prone CScript constructor
359 2019-07-08T18:45:37  <bitcoin-git> bitcoin/master c799976 Wladimir J. van der Laan: Merge #16128: Delete error-prone CScript constructor only used with FindAn...
360 2019-07-08T18:45:38  *** bitcoin-git has left #bitcoin-core-dev
361 2019-07-08T18:46:26  *** bitcoin-git has joined #bitcoin-core-dev
362 2019-07-08T18:46:27  <bitcoin-git> [bitcoin] laanwj merged pull request #16128: Delete error-prone CScript constructor only used with FindAndDelete (master...cscript_construct) https://github.com/bitcoin/bitcoin/pull/16128
363 2019-07-08T18:46:40  *** bitcoin-git has left #bitcoin-core-dev
364 2019-07-08T18:53:20  *** bitcoin-git has joined #bitcoin-core-dev
365 2019-07-08T18:53:20  <bitcoin-git> [bitcoin] instagibbs closed pull request #13057: refactor pre-selected coin code (master...selectedcoins) https://github.com/bitcoin/bitcoin/pull/13057
366 2019-07-08T18:53:21  *** spaced0ut has quit IRC
367 2019-07-08T18:53:23  *** bitcoin-git has left #bitcoin-core-dev
368 2019-07-08T18:59:10  *** obsrver has quit IRC
369 2019-07-08T19:02:07  *** emilengler has joined #bitcoin-core-dev
370 2019-07-08T19:05:54  *** hebasto has joined #bitcoin-core-dev
371 2019-07-08T19:06:04  *** Karyon has quit IRC
372 2019-07-08T19:07:58  *** owowo has quit IRC
373 2019-07-08T19:12:59  *** owowo has joined #bitcoin-core-dev
374 2019-07-08T19:12:59  *** owowo has joined #bitcoin-core-dev
375 2019-07-08T19:22:05  *** Victorsueca has joined #bitcoin-core-dev
376 2019-07-08T19:29:40  *** hebasto has quit IRC
377 2019-07-08T19:33:48  *** shesek has quit IRC
378 2019-07-08T19:47:54  *** scoop has joined #bitcoin-core-dev
379 2019-07-08T19:56:12  *** emilengler has quit IRC
380 2019-07-08T19:57:29  *** Zenton has joined #bitcoin-core-dev
381 2019-07-08T19:58:44  *** belcher has joined #bitcoin-core-dev
382 2019-07-08T20:19:59  *** darosior has joined #bitcoin-core-dev
383 2019-07-08T20:43:50  *** scoop has quit IRC
384 2019-07-08T20:49:37  *** scoop has joined #bitcoin-core-dev
385 2019-07-08T20:53:58  *** Chris_Stewart_5 has quit IRC
386 2019-07-08T21:00:01  *** secdragon has quit IRC
387 2019-07-08T21:01:03  <achow101> does bdb handle large binary blobs well? or should I break it up into separate records?
388 2019-07-08T21:02:11  <sipa> achow101: are you going to rewrite all of them everytime something is updated?
389 2019-07-08T21:02:29  <achow101> maybe? it'd be the descriptor cache
390 2019-07-08T21:02:36  *** davec has quit IRC
391 2019-07-08T21:02:48  <sipa> probably better to split that up in per-index entries
392 2019-07-08T21:02:57  <sipa> as they're only written once
393 2019-07-08T21:03:09  <sipa> if they are a single blob, you'd be rewriting the whole thing every time
394 2019-07-08T21:03:16  <achow101> right
395 2019-07-08T21:04:55  *** manishearth1 has joined #bitcoin-core-dev
396 2019-07-08T21:05:54  *** e4xit has joined #bitcoin-core-dev
397 2019-07-08T21:12:35  *** davec has joined #bitcoin-core-dev
398 2019-07-08T21:14:33  *** hugohn has quit IRC
399 2019-07-08T21:20:16  *** aseem has quit IRC
400 2019-07-08T21:24:04  *** queip has quit IRC
401 2019-07-08T21:29:03  *** queip has joined #bitcoin-core-dev
402 2019-07-08T21:32:29  *** hugohn has joined #bitcoin-core-dev
403 2019-07-08T21:46:26  *** scoop has quit IRC
404 2019-07-08T21:47:59  *** Guyver2 has quit IRC
405 2019-07-08T21:48:17  *** davterra has quit IRC
406 2019-07-08T21:53:20  *** jarthur has quit IRC
407 2019-07-08T21:53:50  *** hugohn has quit IRC
408 2019-07-08T22:07:11  *** scoop has joined #bitcoin-core-dev
409 2019-07-08T22:09:27  *** spinza has quit IRC
410 2019-07-08T22:16:30  *** ccdle12 has quit IRC
411 2019-07-08T22:19:04  *** EagleTM has quit IRC
412 2019-07-08T22:23:06  *** ccdle12 has joined #bitcoin-core-dev
413 2019-07-08T22:26:53  *** EagleTM has joined #bitcoin-core-dev
414 2019-07-08T22:27:52  *** ccdle12 has quit IRC
415 2019-07-08T22:30:35  *** spinza has joined #bitcoin-core-dev
416 2019-07-08T22:36:53  *** michaelsdunn1 has quit IRC
417 2019-07-08T22:46:34  *** ccdle12 has joined #bitcoin-core-dev
418 2019-07-08T22:48:56  *** hugohn has joined #bitcoin-core-dev
419 2019-07-08T22:55:10  *** hugohn has quit IRC
420 2019-07-08T23:00:16  *** davterra has joined #bitcoin-core-dev
421 2019-07-08T23:12:58  *** darosior has quit IRC
422 2019-07-08T23:13:07  *** hex17or has quit IRC
423 2019-07-08T23:13:36  *** darosior has joined #bitcoin-core-dev
424 2019-07-08T23:23:55  *** AaronvanW has quit IRC
425 2019-07-08T23:29:50  *** hex17or has joined #bitcoin-core-dev
426 2019-07-08T23:33:24  *** queip has quit IRC
427 2019-07-08T23:33:36  *** bitcoin-git has joined #bitcoin-core-dev
428 2019-07-08T23:33:36  <bitcoin-git> [bitcoin] cajunlady78 opened pull request #16356: BIP148 user activated activation of segwit (master...bip-segwit-flagday) https://github.com/bitcoin/bitcoin/pull/16356
429 2019-07-08T23:33:37  *** bitcoin-git has left #bitcoin-core-dev
430 2019-07-08T23:33:51  *** bitcoin-git has joined #bitcoin-core-dev
431 2019-07-08T23:33:51  <bitcoin-git> [bitcoin] cajunlady78 closed pull request #16356: BIP148 user activated activation of segwit (master...bip-segwit-flagday) https://github.com/bitcoin/bitcoin/pull/16356
432 2019-07-08T23:33:58  *** bitcoin-git has left #bitcoin-core-dev
433 2019-07-08T23:40:16  *** queip has joined #bitcoin-core-dev
434 2019-07-08T23:42:48  *** lightlike has quit IRC
435 2019-07-08T23:50:51  *** bitcoin-git has joined #bitcoin-core-dev
436 2019-07-08T23:50:51  <bitcoin-git> [bitcoin] nkostoulas opened pull request #16357: Implement modulo for arith_uint256 (master...uint256-modulo) https://github.com/bitcoin/bitcoin/pull/16357
437 2019-07-08T23:50:52  *** bitcoin-git has left #bitcoin-core-dev
438 2019-07-08T23:58:46  *** AaronvanW has joined #bitcoin-core-dev