1 2019-07-11T00:00:01  *** rlaager1 has quit IRC
  2 2019-07-11T00:04:08  *** amcrae has joined #bitcoin-core-dev
  3 2019-07-11T00:04:23  *** amcrae is now known as Guest3516
  4 2019-07-11T00:08:55  *** mdunnio has joined #bitcoin-core-dev
  5 2019-07-11T00:11:14  *** mdunnio has quit IRC
  6 2019-07-11T00:11:17  *** michaelfolkson has joined #bitcoin-core-dev
  7 2019-07-11T00:20:19  *** Honthe has quit IRC
  8 2019-07-11T00:33:56  *** Cory has joined #bitcoin-core-dev
  9 2019-07-11T00:39:33  *** lightlike has quit IRC
 10 2019-07-11T00:42:08  *** TheRec has quit IRC
 11 2019-07-11T00:42:29  *** TheRec has joined #bitcoin-core-dev
 12 2019-07-11T00:42:29  *** TheRec has joined #bitcoin-core-dev
 13 2019-07-11T00:52:10  *** pinheadmz has quit IRC
 14 2019-07-11T01:00:34  *** scoop has joined #bitcoin-core-dev
 15 2019-07-11T01:03:14  *** jonatack has quit IRC
 16 2019-07-11T01:05:02  *** scoop has quit IRC
 17 2019-07-11T01:11:09  *** MrJ0nK has joined #bitcoin-core-dev
 18 2019-07-11T01:15:59  *** MrJ0nK has quit IRC
 19 2019-07-11T01:17:46  *** nijak has quit IRC
 20 2019-07-11T01:17:47  *** nijak_ has joined #bitcoin-core-dev
 21 2019-07-11T01:37:23  *** scoop has joined #bitcoin-core-dev
 22 2019-07-11T01:52:01  *** pinheadmz has joined #bitcoin-core-dev
 23 2019-07-11T01:55:59  *** michaelfolkson has quit IRC
 24 2019-07-11T02:00:04  *** michaelfolkson has joined #bitcoin-core-dev
 25 2019-07-11T02:02:59  *** gelmutshmidt has joined #bitcoin-core-dev
 26 2019-07-11T02:07:35  *** scoop has quit IRC
 27 2019-07-11T02:14:59  *** DeanGuss has joined #bitcoin-core-dev
 28 2019-07-11T02:15:40  *** pinheadmz has quit IRC
 29 2019-07-11T02:26:01  *** scoop has joined #bitcoin-core-dev
 30 2019-07-11T02:26:17  *** scoop has quit IRC
 31 2019-07-11T02:26:33  *** scoop has joined #bitcoin-core-dev
 32 2019-07-11T02:30:34  *** michaelfolkson has quit IRC
 33 2019-07-11T02:44:04  *** elichai2 has quit IRC
 34 2019-07-11T02:45:34  *** DeanGuss has quit IRC
 35 2019-07-11T02:45:34  *** kristapsk has quit IRC
 36 2019-07-11T02:46:23  *** scoop has quit IRC
 37 2019-07-11T02:48:18  *** DeanGuss has joined #bitcoin-core-dev
 38 2019-07-11T02:50:05  *** pinheadmz has joined #bitcoin-core-dev
 39 2019-07-11T02:55:06  *** bitcoin-git has joined #bitcoin-core-dev
 40 2019-07-11T02:55:07  <bitcoin-git> [bitcoin] fanquake opened pull request #16370: depends: cleanup package configure flags (master...not_so_great_configure_cleanup) https://github.com/bitcoin/bitcoin/pull/16370
 41 2019-07-11T02:55:08  *** bitcoin-git has left #bitcoin-core-dev
 42 2019-07-11T03:00:02  *** Guest3516 has quit IRC
 43 2019-07-11T03:04:06  *** banux1 has joined #bitcoin-core-dev
 44 2019-07-11T03:06:10  *** shesek has quit IRC
 45 2019-07-11T03:07:02  *** EdThorp has quit IRC
 46 2019-07-11T03:07:37  *** spinza has quit IRC
 47 2019-07-11T03:22:07  *** spinza has joined #bitcoin-core-dev
 48 2019-07-11T03:43:51  *** pinheadmz has quit IRC
 49 2019-07-11T04:05:09  *** gelmutshmidt has quit IRC
 50 2019-07-11T04:16:15  *** Klox3 has joined #bitcoin-core-dev
 51 2019-07-11T04:31:16  *** bitcoin-git has joined #bitcoin-core-dev
 52 2019-07-11T04:31:17  <bitcoin-git> [bitcoin] fanquake opened pull request #16371: trivial: build: ignore osx_volname & add it to clean-local (master...ignore_osx_volname) https://github.com/bitcoin/bitcoin/pull/16371
 53 2019-07-11T04:31:30  *** bitcoin-git has left #bitcoin-core-dev
 54 2019-07-11T04:42:48  *** pinheadmz has joined #bitcoin-core-dev
 55 2019-07-11T04:47:47  *** scoop has joined #bitcoin-core-dev
 56 2019-07-11T04:52:04  *** scoop has quit IRC
 57 2019-07-11T05:02:45  *** pinheadmz has quit IRC
 58 2019-07-11T05:09:06  *** pinheadmz has joined #bitcoin-core-dev
 59 2019-07-11T05:38:39  *** pinheadmz has quit IRC
 60 2019-07-11T05:57:55  *** pinheadmz has joined #bitcoin-core-dev
 61 2019-07-11T06:00:02  *** banux1 has quit IRC
 62 2019-07-11T06:01:17  *** d_t has joined #bitcoin-core-dev
 63 2019-07-11T06:03:47  *** landonf1 has joined #bitcoin-core-dev
 64 2019-07-11T06:15:25  *** pinheadmz has quit IRC
 65 2019-07-11T06:21:52  *** d_t has quit IRC
 66 2019-07-11T06:26:30  *** d_t has joined #bitcoin-core-dev
 67 2019-07-11T06:28:41  *** shesek has joined #bitcoin-core-dev
 68 2019-07-11T06:28:41  *** shesek has joined #bitcoin-core-dev
 69 2019-07-11T06:45:04  *** d_t has quit IRC
 70 2019-07-11T06:46:35  *** d_t has joined #bitcoin-core-dev
 71 2019-07-11T06:46:51  *** d_t has quit IRC
 72 2019-07-11T06:52:20  *** d_t has joined #bitcoin-core-dev
 73 2019-07-11T07:02:19  *** belcher has joined #bitcoin-core-dev
 74 2019-07-11T07:03:57  *** hugohn has quit IRC
 75 2019-07-11T07:05:30  *** d_t has quit IRC
 76 2019-07-11T07:20:48  *** hebasto has joined #bitcoin-core-dev
 77 2019-07-11T07:47:46  *** shesek has quit IRC
 78 2019-07-11T08:05:16  *** Victorsueca has joined #bitcoin-core-dev
 79 2019-07-11T08:05:53  *** Victor_sueca has quit IRC
 80 2019-07-11T08:06:00  *** jungly has joined #bitcoin-core-dev
 81 2019-07-11T08:08:14  *** setpill has joined #bitcoin-core-dev
 82 2019-07-11T08:18:16  *** EagleTM has quit IRC
 83 2019-07-11T08:18:30  *** EagleTM has joined #bitcoin-core-dev
 84 2019-07-11T08:36:18  *** Zenton has quit IRC
 85 2019-07-11T08:41:51  *** setpill has quit IRC
 86 2019-07-11T08:42:38  *** setpill has joined #bitcoin-core-dev
 87 2019-07-11T08:43:42  *** jonatack has joined #bitcoin-core-dev
 88 2019-07-11T08:45:41  *** kristapsk has joined #bitcoin-core-dev
 89 2019-07-11T09:00:02  *** landonf1 has quit IRC
 90 2019-07-11T09:03:47  *** zule1 has joined #bitcoin-core-dev
 91 2019-07-11T09:16:06  *** jonatack has quit IRC
 92 2019-07-11T09:26:18  *** jonatack94 has joined #bitcoin-core-dev
 93 2019-07-11T09:39:35  *** jonatack94 has quit IRC
 94 2019-07-11T09:43:47  *** hebasto has quit IRC
 95 2019-07-11T09:45:52  *** queip has quit IRC
 96 2019-07-11T09:49:20  *** jonatack has joined #bitcoin-core-dev
 97 2019-07-11T09:51:41  *** hebasto has joined #bitcoin-core-dev
 98 2019-07-11T09:51:54  *** queip has joined #bitcoin-core-dev
 99 2019-07-11T09:57:51  *** jonatack has quit IRC
100 2019-07-11T10:07:27  *** timothy has joined #bitcoin-core-dev
101 2019-07-11T10:10:30  *** jonatack has joined #bitcoin-core-dev
102 2019-07-11T10:10:52  *** spinza has quit IRC
103 2019-07-11T10:15:03  *** jonatack has quit IRC
104 2019-07-11T10:24:06  *** jonatack has joined #bitcoin-core-dev
105 2019-07-11T10:31:27  *** spinza has joined #bitcoin-core-dev
106 2019-07-11T10:31:42  *** jungly has quit IRC
107 2019-07-11T10:38:29  *** setpill has quit IRC
108 2019-07-11T10:43:37  *** hugohn has joined #bitcoin-core-dev
109 2019-07-11T10:44:52  *** michaelfolkson has joined #bitcoin-core-dev
110 2019-07-11T10:48:53  *** spinza has quit IRC
111 2019-07-11T10:59:19  *** spinza has joined #bitcoin-core-dev
112 2019-07-11T11:02:04  *** jungly has joined #bitcoin-core-dev
113 2019-07-11T11:06:12  *** jonatack has joined #bitcoin-core-dev
114 2019-07-11T11:08:20  *** kristapsk has quit IRC
115 2019-07-11T11:08:41  *** kristapsk has joined #bitcoin-core-dev
116 2019-07-11T11:14:31  *** jonatack has quit IRC
117 2019-07-11T11:20:34  *** farmerwampum has quit IRC
118 2019-07-11T11:23:24  *** michaelfolkson has quit IRC
119 2019-07-11T11:32:37  *** jonatack has joined #bitcoin-core-dev
120 2019-07-11T11:35:49  *** farmerwampum has joined #bitcoin-core-dev
121 2019-07-11T11:39:28  *** booyah has quit IRC
122 2019-07-11T11:47:57  *** jungly has quit IRC
123 2019-07-11T11:54:49  *** Deinogalerix21 has joined #bitcoin-core-dev
124 2019-07-11T12:00:02  *** zule1 has quit IRC
125 2019-07-11T12:03:04  *** rutyiraw has joined #bitcoin-core-dev
126 2019-07-11T12:03:12  *** vosechu has joined #bitcoin-core-dev
127 2019-07-11T12:04:19  *** jonatack has quit IRC
128 2019-07-11T12:04:21  *** jungly has joined #bitcoin-core-dev
129 2019-07-11T12:08:48  *** booyah has joined #bitcoin-core-dev
130 2019-07-11T12:13:17  *** setpill has joined #bitcoin-core-dev
131 2019-07-11T12:19:52  *** Deinogalerix21 has quit IRC
132 2019-07-11T12:24:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
133 2019-07-11T12:37:39  *** Zenton has joined #bitcoin-core-dev
134 2019-07-11T12:41:13  <jnewbery> provoostenator: from the base bitcoin directory: ./test/functional/test_runner.py $(for f in test/functional/wallet*; do echo $f | xargs -n 1 basename; done)
135 2019-07-11T12:41:56  <provoostenator> jnewbery: thanks!
136 2019-07-11T12:44:36  <jnewbery> better: ./test/functional/test_runner.py $(for f in test/functional/wallet*; do basename $f; done)
137 2019-07-11T12:44:53  <jnewbery> or you could just cd to test/functional I suppose :)
138 2019-07-11T12:45:33  *** lightlike has joined #bitcoin-core-dev
139 2019-07-11T12:49:13  *** belcher has quit IRC
140 2019-07-11T12:50:41  *** Chris_Stewart_5 has quit IRC
141 2019-07-11T12:56:05  *** michaelfolkson has joined #bitcoin-core-dev
142 2019-07-11T13:02:47  *** belcher has joined #bitcoin-core-dev
143 2019-07-11T13:07:13  *** spaced0ut has quit IRC
144 2019-07-11T13:11:40  *** hebasto has quit IRC
145 2019-07-11T13:13:37  *** hebasto has joined #bitcoin-core-dev
146 2019-07-11T13:32:23  *** shesek has joined #bitcoin-core-dev
147 2019-07-11T13:34:11  <provoostenator> cd'ing into test/functional is suboptimal, because I often do: make -j20 && make check && test/functional/...
148 2019-07-11T13:37:48  <shesek> provoostenator, I don't know what's the context here, but cd'ing inside a subshell might be helpful, e.g. make -j20 && make check && (cd test/functional/ && foobar)
149 2019-07-11T13:38:16  <shesek> this will keep the same cwd in your shell
150 2019-07-11T13:38:39  * luke-jr wonders why make check doesn't run the functional tests ;)
151 2019-07-11T13:39:28  <wumpus> *originally* because the functional tests required python whereas the rest of the build did not
152 2019-07-11T13:39:55  <luke-jr> could skip them when Python isn't found
153 2019-07-11T13:39:57  <wumpus> this hasn't been the case for a long time
154 2019-07-11T13:40:10  <luke-jr> no?
155 2019-07-11T13:40:29  <wumpus> configure doesn't even pass without python, does it?
156 2019-07-11T13:40:45  <provoostenator> shesek: cool!
157 2019-07-11T13:41:49  <provoostenator> make check indeed requires (a non messed up) python somewhere along the way
158 2019-07-11T13:43:15  <luke-jr> wumpus: I thought it did
159 2019-07-11T13:43:34  <luke-jr> I guess probably nobody is testing it without Python
160 2019-07-11T13:47:09  *** nijak has joined #bitcoin-core-dev
161 2019-07-11T13:47:43  *** nijak_ has quit IRC
162 2019-07-11T13:49:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
163 2019-07-11T13:50:31  *** d_t has joined #bitcoin-core-dev
164 2019-07-11T13:52:16  *** hebasto has quit IRC
165 2019-07-11T13:55:24  *** scoop has joined #bitcoin-core-dev
166 2019-07-11T13:56:15  *** aseem has joined #bitcoin-core-dev
167 2019-07-11T13:57:53  *** Chris_Stewart_5 has quit IRC
168 2019-07-11T14:00:48  *** lipsch has joined #bitcoin-core-dev
169 2019-07-11T14:02:52  <wumpus> i'm fine with having python as required dependency of the project, it has become the de-facto standard cross-platform scripting language
170 2019-07-11T14:03:38  *** jungly has quit IRC
171 2019-07-11T14:04:52  *** queip has quit IRC
172 2019-07-11T14:11:09  *** queip has joined #bitcoin-core-dev
173 2019-07-11T14:15:23  *** lipsch has quit IRC
174 2019-07-11T14:16:03  *** lipsch has joined #bitcoin-core-dev
175 2019-07-11T14:17:33  *** queip has quit IRC
176 2019-07-11T14:19:05  *** lipsch has quit IRC
177 2019-07-11T14:25:42  *** michaelfolkson has quit IRC
178 2019-07-11T14:25:48  *** queip has joined #bitcoin-core-dev
179 2019-07-11T14:30:13  <luke-jr> wumpus: there are platforms without it (eg, Android)
180 2019-07-11T14:30:25  <luke-jr> Perl still seems to be a bit more ubiquitous
181 2019-07-11T14:30:46  <luke-jr> I guess the most portable is POSIX sh
182 2019-07-11T14:35:09  *** jungly has joined #bitcoin-core-dev
183 2019-07-11T14:38:06  *** spaced0ut has joined #bitcoin-core-dev
184 2019-07-11T14:41:19  *** etet has joined #bitcoin-core-dev
185 2019-07-11T14:42:58  <wumpus> definitely not saying that it's the *most portable*, but it seems a good compromise nowadays
186 2019-07-11T14:44:06  <wumpus> oh yes and i meant 'required build time dependency', not run-time dependency, native android has no gcc and toolchains either so as a build platform it's useless anyway :)
187 2019-07-11T14:47:33  *** jungly has quit IRC
188 2019-07-11T14:50:54  *** d_t has quit IRC
189 2019-07-11T14:50:57  *** michaelsdunn1 has joined #bitcoin-core-dev
190 2019-07-11T14:58:20  <provoostenator> Some thoughs on how to apply achow101's The Box to hardware wallets: https://github.com/bitcoin/bitcoin/pull/14912#issuecomment-510520757
191 2019-07-11T14:59:45  *** queip has quit IRC
192 2019-07-11T15:00:01  *** vosechu has quit IRC
193 2019-07-11T15:04:36  *** tsmango1 has joined #bitcoin-core-dev
194 2019-07-11T15:05:23  *** queip has joined #bitcoin-core-dev
195 2019-07-11T15:09:56  *** pinheadmz has joined #bitcoin-core-dev
196 2019-07-11T15:12:00  *** jungly has joined #bitcoin-core-dev
197 2019-07-11T15:20:16  *** hebasto has joined #bitcoin-core-dev
198 2019-07-11T15:22:33  *** michaelfolkson has joined #bitcoin-core-dev
199 2019-07-11T15:25:16  *** aseem has quit IRC
200 2019-07-11T15:29:39  *** aseem has joined #bitcoin-core-dev
201 2019-07-11T15:29:53  *** setpill has quit IRC
202 2019-07-11T15:35:55  *** elichai2 has joined #bitcoin-core-dev
203 2019-07-11T15:40:20  *** jungly has quit IRC
204 2019-07-11T15:41:36  *** michaelfolkson has quit IRC
205 2019-07-11T15:43:16  *** DeanGuss has quit IRC
206 2019-07-11T15:54:25  *** michaelfolkson has joined #bitcoin-core-dev
207 2019-07-11T15:54:57  *** emilengler has joined #bitcoin-core-dev
208 2019-07-11T15:57:36  *** aseem has quit IRC
209 2019-07-11T16:00:42  *** csknk has joined #bitcoin-core-dev
210 2019-07-11T16:09:35  *** scoop has quit IRC
211 2019-07-11T16:10:28  *** scoop has joined #bitcoin-core-dev
212 2019-07-11T16:14:03  *** michaelfolkson has quit IRC
213 2019-07-11T16:14:43  *** scoop has quit IRC
214 2019-07-11T16:21:30  *** michaelfolkson has joined #bitcoin-core-dev
215 2019-07-11T16:32:55  *** Guyver2 has joined #bitcoin-core-dev
216 2019-07-11T16:35:01  *** scoop has joined #bitcoin-core-dev
217 2019-07-11T16:41:23  *** michaelfolkson has quit IRC
218 2019-07-11T16:44:08  *** michaelfolkson has joined #bitcoin-core-dev
219 2019-07-11T16:49:59  *** afk11 has quit IRC
220 2019-07-11T16:50:23  *** afk11 has joined #bitcoin-core-dev
221 2019-07-11T16:51:31  *** aseem has joined #bitcoin-core-dev
222 2019-07-11T17:12:24  *** michaelfolkson has quit IRC
223 2019-07-11T17:20:57  *** icek has joined #bitcoin-core-dev
224 2019-07-11T17:21:43  *** queip has quit IRC
225 2019-07-11T17:23:22  *** timothy has quit IRC
226 2019-07-11T17:28:28  *** queip has joined #bitcoin-core-dev
227 2019-07-11T17:30:53  *** goatpig has joined #bitcoin-core-dev
228 2019-07-11T17:35:03  *** jnewbery has quit IRC
229 2019-07-11T17:35:16  *** sdaftuar has quit IRC
230 2019-07-11T17:36:33  *** blevins has joined #bitcoin-core-dev
231 2019-07-11T17:40:49  *** scoop has quit IRC
232 2019-07-11T17:50:34  *** blevins has quit IRC
233 2019-07-11T17:52:10  <instagibbs> provoostenator, cool thanks
234 2019-07-11T17:52:49  *** jnewbery has joined #bitcoin-core-dev
235 2019-07-11T17:52:50  *** sdaftuar has joined #bitcoin-core-dev
236 2019-07-11T18:00:01  *** tsmango1 has quit IRC
237 2019-07-11T18:00:21  *** scoop has joined #bitcoin-core-dev
238 2019-07-11T18:04:03  *** dwfreed1 has joined #bitcoin-core-dev
239 2019-07-11T18:04:11  *** bitcoin-git has joined #bitcoin-core-dev
240 2019-07-11T18:04:11  <bitcoin-git> [bitcoin] instagibbs opened pull request #16373: Add bumpfee option to return PSBT instead of commiting to wallet (master...bump_psbt) https://github.com/bitcoin/bitcoin/pull/16373
241 2019-07-11T18:04:13  *** bitcoin-git has left #bitcoin-core-dev
242 2019-07-11T18:05:15  *** sipa has quit IRC
243 2019-07-11T18:08:39  *** jarthur has joined #bitcoin-core-dev
244 2019-07-11T18:10:26  *** sipa has joined #bitcoin-core-dev
245 2019-07-11T18:12:33  *** aseem has quit IRC
246 2019-07-11T18:24:12  *** scoop has quit IRC
247 2019-07-11T18:26:42  *** scoop has joined #bitcoin-core-dev
248 2019-07-11T18:30:16  *** scoop has quit IRC
249 2019-07-11T18:30:31  *** scoop has joined #bitcoin-core-dev
250 2019-07-11T18:36:42  *** timothy has joined #bitcoin-core-dev
251 2019-07-11T18:38:59  *** timothy has quit IRC
252 2019-07-11T18:42:35  <wumpus> meeting in about 15 minutes
253 2019-07-11T18:43:00  *** icek has quit IRC
254 2019-07-11T18:43:25  *** xwirton has joined #bitcoin-core-dev
255 2019-07-11T18:44:17  *** rutyiraw has quit IRC
256 2019-07-11T18:45:28  *** Kvaciral has joined #bitcoin-core-dev
257 2019-07-11T18:56:01  *** queip has quit IRC
258 2019-07-11T19:00:04  <wumpus> #startmeeting
259 2019-07-11T19:00:04  <lightningbot> Meeting started Thu Jul 11 19:00:04 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
260 2019-07-11T19:00:04  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
261 2019-07-11T19:00:21  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
262 2019-07-11T19:00:22  <kanzure> hi
263 2019-07-11T19:00:27  <achow101> hi
264 2019-07-11T19:00:34  <jamesob> hi
265 2019-07-11T19:00:36  <sdaftuar> hi
266 2019-07-11T19:01:00  <wumpus> looks like there have been no proposed topics in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
267 2019-07-11T19:01:10  <wumpus> does anyone have any last minute suggestions?
268 2019-07-11T19:01:19  <sipa> hi
269 2019-07-11T19:01:34  <midnightmagic> hello! \o/
270 2019-07-11T19:01:34  <wumpus> hi
271 2019-07-11T19:01:44  <meshcollider> hi
272 2019-07-11T19:02:02  <instagibbs> hi!
273 2019-07-11T19:02:23  <wumpus> #topic High priority for review
274 2019-07-11T19:02:29  <wumpus> https://github.com/bitcoin/bitcoin/projects/8
275 2019-07-11T19:02:54  <wumpus> 5 blockers, and 5 things chasing concept ACK
276 2019-07-11T19:03:03  *** queip has joined #bitcoin-core-dev
277 2019-07-11T19:03:45  <wumpus> anything to add/remove?
278 2019-07-11T19:04:51  <sipa> seems not
279 2019-07-11T19:04:55  <wumpus> no...
280 2019-07-11T19:05:08  <wumpus> that's a short meeting I suppose then
281 2019-07-11T19:05:15  <midnightmagic> :-)
282 2019-07-11T19:05:18  *** booyah has quit IRC
283 2019-07-11T19:05:54  <sipa> no wallet meeting tomorrow, right?
284 2019-07-11T19:06:09  <sdaftuar> perhaps people can discuss what they're working on, if there's nothing else to discuss and anyone is inclined to share
285 2019-07-11T19:06:09  <achow101> sipa: right
286 2019-07-11T19:06:23  <sipa> if not, i have a small wallet related topic
287 2019-07-11T19:06:24  <jamesob> ah can we add https://github.com/bitcoin/bitcoin/pull/16194 ?
288 2019-07-11T19:06:28  *** booyah has joined #bitcoin-core-dev
289 2019-07-11T19:06:34  <jamesob> at this rate assumeutxo'll be done by 2028
290 2019-07-11T19:06:48  <sdaftuar> so you're saying it's going to be done at some point :)
291 2019-07-11T19:06:49  <instagibbs> jamesob, woah there, why so optimistic
292 2019-07-11T19:07:02  <jamesob> good points
293 2019-07-11T19:07:15  <wumpus> jamesob:sure
294 2019-07-11T19:07:22  <jamesob> thanks
295 2019-07-11T19:08:01  <sipa> topic suggestion: explicit privkey derivation through descriptors, or generic support for all signingproviders?
296 2019-07-11T19:08:27  <wumpus> #topic explicit privkey derivation through descriptors, or generic support for all signingproviders?
297 2019-07-11T19:09:22  <sipa> so, right now (and correct me if i'm wrong), i think the only way to get a private key for a xpub-derived key, is by having a descriptor that encapsulates it, and then expanding it at the right position
298 2019-07-11T19:10:15  <sipa> which is a weird restriction i think; signingproviders can contain keys, and derivation paths for derived pubkeys... they have all the information necessary to compute derived privkeys in general
299 2019-07-11T19:10:41  <sipa> i'm suggesting this because i'd like a bitcoin-psbt tool that you just give psbts and utxos and descriptors and keys and figures out what it can do
300 2019-07-11T19:11:03  <sipa> but if a psbt contains a pubkey derivation field, and you have one of the parent privkeys available, we *should* have enough to sign
301 2019-07-11T19:11:15  <sipa> but afaik the current structure doesn't permit that
302 2019-07-11T19:11:31  <achow101> sipa: you'd be missing the chaincode
303 2019-07-11T19:11:32  <sipa> achow101, meshcollider: does this make any sense?
304 2019-07-11T19:12:12  <sipa> achow101: ugh right... thanks :)
305 2019-07-11T19:12:17  <sipa> it's not that easy
306 2019-07-11T19:13:14  *** xwirton has quit IRC
307 2019-07-11T19:13:30  <sipa> i guess end of topic, back to drawing board :)
308 2019-07-11T19:13:43  *** mnarix has joined #bitcoin-core-dev
309 2019-07-11T19:14:23  <sipa> ack sdaftuar's topic to share what people are working on
310 2019-07-11T19:14:26  <meshcollider> That seems like a weird situation to be in anyway, if you have a descriptor and it's private keys in your wallet then why wouldn't you have included the privkey in the descriptor in the first place
311 2019-07-11T19:15:12  <sipa> meshcollider: yeah but from a generic psbt perspective, if you have an xprv for example, and a psbt that claims the need for a key derived from it... it feels like you should be able to use it
312 2019-07-11T19:16:28  <sipa> i think the point is that psbt assumes your "keystore" consists of xpubs/xprvs more than it assumes just individual leaf keys
313 2019-07-11T19:18:19  <sipa> but i'll come up with something else :)
314 2019-07-11T19:19:06  *** lnostdal has quit IRC
315 2019-07-11T19:19:27  <wumpus> #topic what people are working on
316 2019-07-11T19:20:08  <wumpus> feel free to say something about what you're working on, or want to review-beg for a PR etc
317 2019-07-11T19:20:37  *** scoop has quit IRC
318 2019-07-11T19:20:40  * sipa working mostly on miniscript, still a lot of design and proof of concept... no PRable code yet
319 2019-07-11T19:20:58  <achow101> i'm working on native descriptor wallets (take 2) based on the SPKManager stuff
320 2019-07-11T19:21:22  <sdaftuar> i'm working on an ATMP refactor to support package relay, and generally working on p2p improvements
321 2019-07-11T19:21:54  <sipa> cool
322 2019-07-11T19:21:55  <instagibbs> in review mode these days, focusing on wallet. With proper motivation you can bug me to review your scary p2p/consensus code :)
323 2019-07-11T19:22:14  *** scoop has joined #bitcoin-core-dev
324 2019-07-11T19:23:59  <sdaftuar> i'm also happy to be pinged to review (if anyone has a PR they think i should look at)
325 2019-07-11T19:24:08  <wumpus> thanks for sharing everyone; I'm pretty much in review mode too at the moment
326 2019-07-11T19:25:33  <wumpus> I think that concludes the meeting, maybe it's good to have this as recurring topic like "high priority for review"
327 2019-07-11T19:25:40  <sdaftuar> +1
328 2019-07-11T19:25:44  <sipa> agree
329 2019-07-11T19:25:53  <wumpus> #endmeeting
330 2019-07-11T19:25:53  <lightningbot> Meeting ended Thu Jul 11 19:25:53 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
331 2019-07-11T19:25:53  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-07-11-19.00.html
332 2019-07-11T19:25:53  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-07-11-19.00.txt
333 2019-07-11T19:25:53  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-07-11-19.00.log.html
334 2019-07-11T19:29:05  *** scoop has quit IRC
335 2019-07-11T19:29:26  *** scoop has joined #bitcoin-core-dev
336 2019-07-11T19:32:03  <achow101> sipa: meshcollider: in native descriptor wallets, do you think it makes sense to populate a CKeyMetadata for each scriptpubkey? I don't think that really makes sense, but I feel like it's necessary for getaddressinfo to give usable info. or is just the descriptor in getaddressinfo enough?
337 2019-07-11T19:33:51  *** jarthur_ has joined #bitcoin-core-dev
338 2019-07-11T19:35:08  <achow101> also, does key birth time really matter?
339 2019-07-11T19:35:24  <instagibbs> key time affects some rescan logic IIRC
340 2019-07-11T19:35:52  <instagibbs> maybe not anymore though...
341 2019-07-11T19:35:55  *** Eagle[TM] has joined #bitcoin-core-dev
342 2019-07-11T19:35:57  <achow101> only the time of the first key
343 2019-07-11T19:36:19  *** EagleTM has quit IRC
344 2019-07-11T19:37:14  <achow101> afaik individual key birth times are only used in getaddressinfo and dumpwallet
345 2019-07-11T19:37:38  *** jarthur has quit IRC
346 2019-07-11T19:38:42  *** scoop has quit IRC
347 2019-07-11T19:40:39  *** hebasto has quit IRC
348 2019-07-11T19:40:45  <wumpus> right, the key birth is only used to determine where to start rescanning
349 2019-07-11T19:41:35  <sipa> achow101: is it just for birth times?
350 2019-07-11T19:42:13  <achow101> sipa: I don't think the keymetadata is being used for anything else. it's just for information to display to the user (or in dumpwallet)
351 2019-07-11T19:42:25  <sipa> i think in a descriptor wallet individual keys shouldn't have birth times; the descriptor/record itself can have a birth time though
352 2019-07-11T19:42:36  <achow101> right
353 2019-07-11T19:42:58  <instagibbs> the descriptor already stores everything else except the derivation index, which I presume can be calculated somehow
354 2019-07-11T19:43:32  <achow101> instagibbs: we will be storing in memory the index for each scriptpubkey generated
355 2019-07-11T19:43:47  <achow101> so given a scriptpubkey, we can find the index and get the rest from the descriptor
356 2019-07-11T19:43:57  <wumpus> CKeyMetadata does have some other fields too: version, hdKeypath, hd_seed_id, key_origin
357 2019-07-11T19:44:24  <wumpus> don't seem to be relevant there though
358 2019-07-11T19:44:25  <sipa> all the other information becomes implicit
359 2019-07-11T19:44:35  <wumpus> right
360 2019-07-11T19:44:59  <achow101> version is just ckeymetadata version. the hd stuff can come from the descriptor itself
361 2019-07-11T19:45:18  <sipa> yup
362 2019-07-11T19:45:43  <instagibbs> nice
363 2019-07-11T19:46:17  <instagibbs> achow101, these scriptpubkeys are never dumped from memory? ever-growing in other words?
364 2019-07-11T19:46:17  <achow101> my idea was to have a GetMetadata function which the ScriptPubKeyMan would populate when a metadat was requested instead of storing metadata. but this doesn't really work well when a descriptor isn't just a single key descriptor
365 2019-07-11T19:46:24  *** scoop has joined #bitcoin-core-dev
366 2019-07-11T19:46:47  <instagibbs> I mean we already do that today, so stupid question :)
367 2019-07-11T19:47:03  <achow101> instagibbs: yes, but we already do that for keys, so...
368 2019-07-11T19:47:58  *** EagleTM has joined #bitcoin-core-dev
369 2019-07-11T19:48:23  *** Eagle[TM] has quit IRC
370 2019-07-11T19:54:13  *** aseem has joined #bitcoin-core-dev
371 2019-07-11T20:00:12  *** scoop has quit IRC
372 2019-07-11T20:00:44  *** bitcoin-git has joined #bitcoin-core-dev
373 2019-07-11T20:00:44  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/4fcccdac785e...28d1353f4837
374 2019-07-11T20:00:45  <bitcoin-git> bitcoin/master af5d1b5 Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin AEAD implementation
375 2019-07-11T20:00:45  <bitcoin-git> bitcoin/master 99aea04 Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin tests
376 2019-07-11T20:00:46  <bitcoin-git> bitcoin/master bb326ad Jonas Schnelli: Add ChaCha20Poly1305@Bitcoin AEAD benchmark
377 2019-07-11T20:00:49  *** bitcoin-git has left #bitcoin-core-dev
378 2019-07-11T20:01:25  *** bitcoin-git has joined #bitcoin-core-dev
379 2019-07-11T20:01:25  <bitcoin-git> [bitcoin] laanwj merged pull request #15649: Add ChaCha20Poly1305@Bitcoin AEAD (master...2019/03/chachapoly1305) https://github.com/bitcoin/bitcoin/pull/15649
380 2019-07-11T20:01:28  *** bitcoin-git has left #bitcoin-core-dev
381 2019-07-11T20:01:39  *** emilengler has quit IRC
382 2019-07-11T20:10:31  *** scoop has joined #bitcoin-core-dev
383 2019-07-11T20:15:27  *** mnarix has quit IRC
384 2019-07-11T20:16:17  *** scoop has quit IRC
385 2019-07-11T20:16:53  <instagibbs> is there scripted-diff docs somewhere in the repo?
386 2019-07-11T20:21:10  <wumpus> I don't think so, but it's simply sh script, best way to find examples would be to look at 'git log --grep="BEGIN VERIFY SCRIPT"'
387 2019-07-11T20:21:26  *** scoop has joined #bitcoin-core-dev
388 2019-07-11T20:27:56  *** scoop has quit IRC
389 2019-07-11T20:29:46  *** bitcoin-git has joined #bitcoin-core-dev
390 2019-07-11T20:29:46  <bitcoin-git> [bitcoin] jonatack opened pull request #16374: test: Enable passing wildcard test names to test runner from root (master...enable-passing-wildcard-files-to-test-runner-from-root) https://github.com/bitcoin/bitcoin/pull/16374
391 2019-07-11T20:29:48  *** bitcoin-git has left #bitcoin-core-dev
392 2019-07-11T20:30:21  <instagibbs> ok so it's just a thing you can run in your own repo, check the diff, got it, not validated in travis or anything
393 2019-07-11T20:30:32  <sipa> it is validated by travis
394 2019-07-11T20:30:54  <sipa> travis reruns the script, and verifies that the commit exactly matches the diff it applies to the repo
395 2019-07-11T20:31:05  *** scoop has joined #bitcoin-core-dev
396 2019-07-11T20:31:24  <instagibbs> ok, so the magic to make this happen is -BEGIN VERIFY SCRIPT-\n<scripttorun>\n-END VERIFY SCRIPT- in commit message?
397 2019-07-11T20:31:40  <wumpus> yes, exactly
398 2019-07-11T20:32:45  *** aseem has quit IRC
399 2019-07-11T20:33:53  <instagibbs> lies, here it is: https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs
400 2019-07-11T20:33:54  <instagibbs> :)
401 2019-07-11T20:34:13  <wumpus> :-)
402 2019-07-11T20:34:17  *** aseem has joined #bitcoin-core-dev
403 2019-07-11T20:41:30  <wumpus> instagibbs: your comments on #16227 aren't blocking right? (I was just about to merge it)
404 2019-07-11T20:41:32  <gribble> https://github.com/bitcoin/bitcoin/issues/16227 | Refactor CWallets inheritance chain by achow101 · Pull Request #16227 · bitcoin/bitcoin · GitHub
405 2019-07-11T20:41:45  *** setpill has joined #bitcoin-core-dev
406 2019-07-11T20:42:05  <instagibbs> no! merge please
407 2019-07-11T20:42:21  <instagibbs> one was confirming proper behavior based on read of code, and one is mu-nit comment thing
408 2019-07-11T20:43:29  *** bitcoin-git has joined #bitcoin-core-dev
409 2019-07-11T20:43:30  <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/28d1353f4837...735d6b57e795
410 2019-07-11T20:43:30  <bitcoin-git> bitcoin/master 1b699a5 Andrew Chow: Add HaveKey and HaveCScript to SigningProvider
411 2019-07-11T20:43:31  <bitcoin-git> bitcoin/master c7797ec Andrew Chow: Remove CKeyStore and squash into CBasicKeyStore
412 2019-07-11T20:43:32  <bitcoin-git> bitcoin/master a913e3f Andrew Chow: Move HaveKey static function from keystore to rpcwallet where it is used
413 2019-07-11T20:43:43  *** bitcoin-git has left #bitcoin-core-dev
414 2019-07-11T20:44:19  *** bitcoin-git has joined #bitcoin-core-dev
415 2019-07-11T20:44:20  <bitcoin-git> [bitcoin] laanwj merged pull request #16227: Refactor CWallet's inheritance chain (master...rm-keystores) https://github.com/bitcoin/bitcoin/pull/16227
416 2019-07-11T20:44:21  *** bitcoin-git has left #bitcoin-core-dev
417 2019-07-11T20:46:19  *** mnarix has joined #bitcoin-core-dev
418 2019-07-11T20:47:54  *** scoop has quit IRC
419 2019-07-11T20:50:32  <achow101> \o/
420 2019-07-11T20:50:39  *** mnarix has quit IRC
421 2019-07-11T20:50:58  <achow101> this is going far faster than I expected
422 2019-07-11T20:51:27  <wumpus> wallet development seems to be going quite quickly lately
423 2019-07-11T20:51:45  <achow101> wumpus: #16301 for hi prio please
424 2019-07-11T20:51:47  <gribble> https://github.com/bitcoin/bitcoin/issues/16301 | Use CWallet::Import* functions in all import* RPCs by achow101 · Pull Request #16301 · bitcoin/bitcoin · GitHub
425 2019-07-11T20:52:00  <wumpus> it used to be impossible to find reviewers for wallet changes
426 2019-07-11T20:52:38  <wumpus> achow101: done
427 2019-07-11T20:54:19  <instagibbs> wallet gang
428 2019-07-11T20:56:31  *** nijak_ has joined #bitcoin-core-dev
429 2019-07-11T20:56:33  *** nijak has quit IRC
430 2019-07-11T21:00:02  *** dwfreed1 has quit IRC
431 2019-07-11T21:00:15  *** csknk has quit IRC
432 2019-07-11T21:00:20  *** nijak has joined #bitcoin-core-dev
433 2019-07-11T21:01:10  *** nijak_ has quit IRC
434 2019-07-11T21:04:49  *** sunetoft has joined #bitcoin-core-dev
435 2019-07-11T21:08:01  *** jarthur_ has quit IRC
436 2019-07-11T21:10:28  *** bitcoin-git has joined #bitcoin-core-dev
437 2019-07-11T21:10:28  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13903: Significantly reduce GetTransaction cs_main locking (TheBlueMatt) (master...Mf1808-ReadBlockFromDiskCsMain) https://github.com/bitcoin/bitcoin/pull/13903
438 2019-07-11T21:10:30  *** bitcoin-git has left #bitcoin-core-dev
439 2019-07-11T21:12:14  *** bitcoin-git has joined #bitcoin-core-dev
440 2019-07-11T21:12:14  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13947: Dandelion transaction relay (BIP 156) (master...Mf1804-dandelion) https://github.com/bitcoin/bitcoin/pull/13947
441 2019-07-11T21:12:15  *** bitcoin-git has left #bitcoin-core-dev
442 2019-07-11T21:13:46  *** setpill has quit IRC
443 2019-07-11T21:17:09  *** setpill has joined #bitcoin-core-dev
444 2019-07-11T21:18:55  *** setpill has quit IRC
445 2019-07-11T21:19:18  *** setpill has joined #bitcoin-core-dev
446 2019-07-11T21:19:57  *** scoop has joined #bitcoin-core-dev
447 2019-07-11T21:21:26  *** setpill has joined #bitcoin-core-dev
448 2019-07-11T21:24:53  *** Kvaciral has quit IRC
449 2019-07-11T21:27:35  *** scoop has quit IRC
450 2019-07-11T21:28:06  *** setpill has quit IRC
451 2019-07-11T21:30:08  *** aseem has quit IRC
452 2019-07-11T21:31:57  *** scoop has joined #bitcoin-core-dev
453 2019-07-11T21:33:53  *** scoop has quit IRC
454 2019-07-11T21:39:14  *** scoop has joined #bitcoin-core-dev
455 2019-07-11T21:44:04  *** goatpig has quit IRC
456 2019-07-11T21:44:21  *** Guyver2 has quit IRC
457 2019-07-11T21:48:16  *** darosior has quit IRC
458 2019-07-11T21:50:18  *** scoop has quit IRC
459 2019-07-11T22:05:21  *** darosior has joined #bitcoin-core-dev
460 2019-07-11T22:05:52  *** scoop has joined #bitcoin-core-dev
461 2019-07-11T22:09:01  *** spinza has quit IRC
462 2019-07-11T22:10:04  *** scoop has quit IRC
463 2019-07-11T22:10:18  *** setpill has joined #bitcoin-core-dev
464 2019-07-11T22:10:38  *** ezegom has joined #bitcoin-core-dev
465 2019-07-11T22:11:35  *** michaelsdunn1 has quit IRC
466 2019-07-11T22:14:18  *** bitcoin-git has joined #bitcoin-core-dev
467 2019-07-11T22:14:18  <bitcoin-git> [bitcoin] antigaius opened pull request #16375: secp256k1/src/tests.c:  Properly handle sscanf return value. (master...2019-07-12) https://github.com/bitcoin/bitcoin/pull/16375
468 2019-07-11T22:14:20  *** bitcoin-git has left #bitcoin-core-dev
469 2019-07-11T22:18:11  *** bitcoin-git has joined #bitcoin-core-dev
470 2019-07-11T22:18:11  <bitcoin-git> [bitcoin] antigaius closed pull request #16375: secp256k1/src/tests.c:  Properly handle sscanf return value. (master...2019-07-12) https://github.com/bitcoin/bitcoin/pull/16375
471 2019-07-11T22:18:12  *** bitcoin-git has left #bitcoin-core-dev
472 2019-07-11T22:18:44  *** kristapsk_ has joined #bitcoin-core-dev
473 2019-07-11T22:18:51  *** Zenton has quit IRC
474 2019-07-11T22:21:51  *** kristapsk has quit IRC
475 2019-07-11T22:29:34  *** nijak_ has joined #bitcoin-core-dev
476 2019-07-11T22:29:40  *** spinza has joined #bitcoin-core-dev
477 2019-07-11T22:32:06  *** nijak has quit IRC
478 2019-07-11T22:37:53  *** justanotheruser has quit IRC
479 2019-07-11T22:51:02  *** Bach has joined #bitcoin-core-dev
480 2019-07-11T22:59:27  *** ezegom has quit IRC
481 2019-07-11T23:05:58  *** Bach has quit IRC
482 2019-07-11T23:06:08  *** ddustin has joined #bitcoin-core-dev
483 2019-07-11T23:07:27  *** ezegom has joined #bitcoin-core-dev
484 2019-07-11T23:10:50  *** setpill has quit IRC
485 2019-07-11T23:13:22  *** ddustin has quit IRC
486 2019-07-11T23:13:51  *** ddustin has joined #bitcoin-core-dev
487 2019-07-11T23:15:34  *** AaronvanW has quit IRC
488 2019-07-11T23:18:13  *** ddustin has quit IRC
489 2019-07-11T23:19:01  *** Fuzzbawls has joined #bitcoin-core-dev
490 2019-07-11T23:27:26  <fanquake> I like the “what is everyone working on” idea for the meeting as well. 👍
491 2019-07-11T23:51:19  *** AaronvanW has joined #bitcoin-core-dev
492 2019-07-11T23:52:10  *** IGHOR has quit IRC
493 2019-07-11T23:55:52  *** AaronvanW has quit IRC
494 2019-07-11T23:56:17  *** IGHOR has joined #bitcoin-core-dev
495 2019-07-11T23:56:22  *** queip has quit IRC