1 2019-07-12T00:00:01  *** sunetoft has quit IRC
  2 2019-07-12T00:01:02  *** pinheadmz has quit IRC
  3 2019-07-12T00:04:06  *** kcomandich1 has joined #bitcoin-core-dev
  4 2019-07-12T00:04:09  *** queip has joined #bitcoin-core-dev
  5 2019-07-12T00:05:15  *** ezegom has quit IRC
  6 2019-07-12T00:14:10  *** captjakk_ has joined #bitcoin-core-dev
  7 2019-07-12T00:22:56  *** scoop has joined #bitcoin-core-dev
  8 2019-07-12T00:27:08  *** scoop has quit IRC
  9 2019-07-12T00:28:30  *** AaronvanW has joined #bitcoin-core-dev
 10 2019-07-12T00:33:49  *** AaronvanW has quit IRC
 11 2019-07-12T00:37:32  *** cornfeedhobo has quit IRC
 12 2019-07-12T00:43:32  *** scoop has joined #bitcoin-core-dev
 13 2019-07-12T00:46:08  *** scoop has quit IRC
 14 2019-07-12T00:46:15  *** scoop has joined #bitcoin-core-dev
 15 2019-07-12T00:57:40  *** lightlike has quit IRC
 16 2019-07-12T00:57:50  *** aseem has joined #bitcoin-core-dev
 17 2019-07-12T01:05:46  *** cornfeedhobo has joined #bitcoin-core-dev
 18 2019-07-12T01:09:09  *** AaronvanW has joined #bitcoin-core-dev
 19 2019-07-12T01:13:29  *** AaronvanW has quit IRC
 20 2019-07-12T01:24:50  *** justanotheruser has joined #bitcoin-core-dev
 21 2019-07-12T01:31:01  *** rh0nj has quit IRC
 22 2019-07-12T01:31:34  *** justanotheruser has quit IRC
 23 2019-07-12T01:32:07  *** rh0nj has joined #bitcoin-core-dev
 24 2019-07-12T01:33:04  *** justan0theruser has joined #bitcoin-core-dev
 25 2019-07-12T01:41:19  *** scoop has quit IRC
 26 2019-07-12T01:42:43  *** booyah has quit IRC
 27 2019-07-12T01:43:52  *** booyah has joined #bitcoin-core-dev
 28 2019-07-12T01:46:30  *** aseem has quit IRC
 29 2019-07-12T01:46:40  *** AaronvanW has joined #bitcoin-core-dev
 30 2019-07-12T01:51:29  *** AaronvanW has quit IRC
 31 2019-07-12T02:04:13  *** cornfeedhobo has quit IRC
 32 2019-07-12T02:07:47  *** dviola has joined #bitcoin-core-dev
 33 2019-07-12T02:09:14  *** elichai2 has quit IRC
 34 2019-07-12T02:09:47  *** scoop has joined #bitcoin-core-dev
 35 2019-07-12T02:10:21  *** scoop has quit IRC
 36 2019-07-12T02:10:28  *** scoop has joined #bitcoin-core-dev
 37 2019-07-12T02:21:42  *** kristapsk___ has joined #bitcoin-core-dev
 38 2019-07-12T02:21:50  *** kristapsk_ has quit IRC
 39 2019-07-12T02:23:52  *** AaronvanW has joined #bitcoin-core-dev
 40 2019-07-12T02:28:40  *** AaronvanW has quit IRC
 41 2019-07-12T02:35:17  *** cornfeedhobo has joined #bitcoin-core-dev
 42 2019-07-12T02:45:36  *** kristapsk___ has quit IRC
 43 2019-07-12T02:48:38  *** kristapsk___ has joined #bitcoin-core-dev
 44 2019-07-12T02:48:44  *** sdaftuar has quit IRC
 45 2019-07-12T02:49:44  *** sdaftuar has joined #bitcoin-core-dev
 46 2019-07-12T02:54:53  *** DeanGuss has joined #bitcoin-core-dev
 47 2019-07-12T02:59:41  *** AaronvanW has joined #bitcoin-core-dev
 48 2019-07-12T03:00:01  *** kcomandich1 has quit IRC
 49 2019-07-12T03:04:01  *** AaronvanW has quit IRC
 50 2019-07-12T03:20:28  *** d_t has joined #bitcoin-core-dev
 51 2019-07-12T03:28:32  *** DeanGuss has quit IRC
 52 2019-07-12T03:29:21  *** DeanGuss has joined #bitcoin-core-dev
 53 2019-07-12T03:34:00  *** DeanGuss has quit IRC
 54 2019-07-12T03:37:19  *** AaronvanW has joined #bitcoin-core-dev
 55 2019-07-12T03:39:00  *** scoop has quit IRC
 56 2019-07-12T03:40:27  *** scoop has joined #bitcoin-core-dev
 57 2019-07-12T03:42:00  *** AaronvanW has quit IRC
 58 2019-07-12T03:45:14  *** scoop has quit IRC
 59 2019-07-12T03:45:21  *** scoop has joined #bitcoin-core-dev
 60 2019-07-12T03:48:37  *** Dantman has joined #bitcoin-core-dev
 61 2019-07-12T03:59:05  *** d_t has quit IRC
 62 2019-07-12T04:09:34  *** AaronvanW has joined #bitcoin-core-dev
 63 2019-07-12T04:12:33  *** hebasto has joined #bitcoin-core-dev
 64 2019-07-12T04:13:47  *** AaronvanW has quit IRC
 65 2019-07-12T04:16:14  *** scoop has quit IRC
 66 2019-07-12T04:17:35  *** hebasto has quit IRC
 67 2019-07-12T04:26:48  *** justan0theruser is now known as justanotheruser
 68 2019-07-12T04:39:22  *** scoop has joined #bitcoin-core-dev
 69 2019-07-12T04:43:47  *** scoop has quit IRC
 70 2019-07-12T04:47:28  *** AaronvanW has joined #bitcoin-core-dev
 71 2019-07-12T04:47:36  *** d_t has joined #bitcoin-core-dev
 72 2019-07-12T04:52:02  *** AaronvanW has quit IRC
 73 2019-07-12T04:57:15  *** scoop has joined #bitcoin-core-dev
 74 2019-07-12T05:00:04  *** d_t has quit IRC
 75 2019-07-12T05:02:51  *** hebasto has joined #bitcoin-core-dev
 76 2019-07-12T05:04:43  *** captjakk_ has quit IRC
 77 2019-07-12T05:06:05  *** JamesAU has joined #bitcoin-core-dev
 78 2019-07-12T05:06:26  *** scoop has quit IRC
 79 2019-07-12T05:16:12  *** Klox3 has quit IRC
 80 2019-07-12T05:24:33  *** spinza has quit IRC
 81 2019-07-12T05:30:48  *** AaronvanW has joined #bitcoin-core-dev
 82 2019-07-12T05:34:06  *** spinza has joined #bitcoin-core-dev
 83 2019-07-12T05:35:03  *** AaronvanW has quit IRC
 84 2019-07-12T05:37:05  *** DeanGuss has joined #bitcoin-core-dev
 85 2019-07-12T05:41:09  *** JamesAU has quit IRC
 86 2019-07-12T05:51:18  *** d_t has joined #bitcoin-core-dev
 87 2019-07-12T05:58:45  *** d_t has quit IRC
 88 2019-07-12T06:00:02  *** Dantman has quit IRC
 89 2019-07-12T06:06:48  *** AaronvanW has joined #bitcoin-core-dev
 90 2019-07-12T06:10:55  *** limpkin1 has joined #bitcoin-core-dev
 91 2019-07-12T06:11:29  *** AaronvanW has quit IRC
 92 2019-07-12T06:17:58  *** d_t has joined #bitcoin-core-dev
 93 2019-07-12T06:19:50  *** queip has quit IRC
 94 2019-07-12T06:26:17  *** queip has joined #bitcoin-core-dev
 95 2019-07-12T06:30:06  *** d_t has quit IRC
 96 2019-07-12T06:38:25  *** AaronvanW has joined #bitcoin-core-dev
 97 2019-07-12T06:43:15  *** AaronvanW has quit IRC
 98 2019-07-12T06:58:33  *** pinheadmz has joined #bitcoin-core-dev
 99 2019-07-12T07:07:46  *** queip has quit IRC
100 2019-07-12T07:13:24  *** queip has joined #bitcoin-core-dev
101 2019-07-12T07:14:31  *** ddustin has joined #bitcoin-core-dev
102 2019-07-12T07:17:40  *** AaronvanW has joined #bitcoin-core-dev
103 2019-07-12T07:19:01  *** ddustin has quit IRC
104 2019-07-12T07:22:16  *** AaronvanW has quit IRC
105 2019-07-12T07:26:43  *** AaronvanW has joined #bitcoin-core-dev
106 2019-07-12T07:33:49  *** queip has quit IRC
107 2019-07-12T07:35:13  *** promag has quit IRC
108 2019-07-12T07:39:26  *** queip has joined #bitcoin-core-dev
109 2019-07-12T07:52:29  *** jungly has joined #bitcoin-core-dev
110 2019-07-12T08:03:47  *** pinheadmz has quit IRC
111 2019-07-12T08:15:36  *** scoop has joined #bitcoin-core-dev
112 2019-07-12T08:18:13  *** Dean_Guss has joined #bitcoin-core-dev
113 2019-07-12T08:20:03  *** scoop has quit IRC
114 2019-07-12T08:23:26  *** DeanGuss has quit IRC
115 2019-07-12T08:25:57  *** jonatack has joined #bitcoin-core-dev
116 2019-07-12T08:27:33  *** instagibbs has quit IRC
117 2019-07-12T08:28:21  *** instagibbs has joined #bitcoin-core-dev
118 2019-07-12T08:45:53  *** scoop has joined #bitcoin-core-dev
119 2019-07-12T08:47:18  *** scoop has quit IRC
120 2019-07-12T08:51:11  *** timothy has joined #bitcoin-core-dev
121 2019-07-12T08:54:40  *** justanotheruser has quit IRC
122 2019-07-12T08:59:46  *** scoop has joined #bitcoin-core-dev
123 2019-07-12T09:00:01  *** limpkin1 has quit IRC
124 2019-07-12T09:01:11  *** scoop has quit IRC
125 2019-07-12T09:02:58  *** Emcy has quit IRC
126 2019-07-12T09:03:57  *** scoop_ has joined #bitcoin-core-dev
127 2019-07-12T09:04:17  *** pleia21 has joined #bitcoin-core-dev
128 2019-07-12T09:14:27  *** Guest30053 has joined #bitcoin-core-dev
129 2019-07-12T09:15:33  *** scoop_ has quit IRC
130 2019-07-12T09:20:28  *** dviola has quit IRC
131 2019-07-12T09:22:31  *** belcher has quit IRC
132 2019-07-12T09:27:35  *** jonatack has quit IRC
133 2019-07-12T09:38:23  *** Emcy has joined #bitcoin-core-dev
134 2019-07-12T09:43:17  *** scoop has joined #bitcoin-core-dev
135 2019-07-12T09:43:37  *** scoop has quit IRC
136 2019-07-12T09:44:03  *** scoop has joined #bitcoin-core-dev
137 2019-07-12T09:44:13  *** jungly has quit IRC
138 2019-07-12T09:48:23  *** scoop has quit IRC
139 2019-07-12T09:58:32  *** jungly has joined #bitcoin-core-dev
140 2019-07-12T10:08:45  <fanquake> Hopefully no-one has to clean any toilets.. https://github.com/bitcoin/bitcoin/pull/16248#issuecomment-510831024
141 2019-07-12T10:08:57  *** dviola has joined #bitcoin-core-dev
142 2019-07-12T10:09:23  *** dviola has joined #bitcoin-core-dev
143 2019-07-12T10:21:32  *** IGHOR has quit IRC
144 2019-07-12T10:27:43  *** queip has quit IRC
145 2019-07-12T10:34:36  *** queip has joined #bitcoin-core-dev
146 2019-07-12T10:46:26  *** IGHOR has joined #bitcoin-core-dev
147 2019-07-12T10:46:37  *** setpill has joined #bitcoin-core-dev
148 2019-07-12T10:46:53  *** IGHOR has quit IRC
149 2019-07-12T10:51:09  *** jungly has quit IRC
150 2019-07-12T10:52:33  *** dviola has quit IRC
151 2019-07-12T10:55:57  *** IGHOR has joined #bitcoin-core-dev
152 2019-07-12T11:01:27  *** Emcy has quit IRC
153 2019-07-12T11:04:37  *** designwish has quit IRC
154 2019-07-12T11:04:44  *** votesmith has quit IRC
155 2019-07-12T11:06:16  *** spinza has quit IRC
156 2019-07-12T11:07:49  *** votesmith has joined #bitcoin-core-dev
157 2019-07-12T11:11:44  *** designwish has joined #bitcoin-core-dev
158 2019-07-12T11:16:15  *** spinza has joined #bitcoin-core-dev
159 2019-07-12T11:16:18  *** queip has quit IRC
160 2019-07-12T11:22:11  *** queip has joined #bitcoin-core-dev
161 2019-07-12T11:37:06  *** queip has quit IRC
162 2019-07-12T11:41:03  *** bitcoin-git has joined #bitcoin-core-dev
163 2019-07-12T11:41:03  <bitcoin-git> [bitcoin] Sjors opened pull request #16377: [rpc] don't automatically append inputs in walletcreatefundedpsbt (master...2019/07/walletcreatefundedpsbt_addinputs) https://github.com/bitcoin/bitcoin/pull/16377
164 2019-07-12T11:41:04  *** bitcoin-git has left #bitcoin-core-dev
165 2019-07-12T11:42:40  *** queip has joined #bitcoin-core-dev
166 2019-07-12T11:52:02  *** booyah has quit IRC
167 2019-07-12T11:56:09  *** lowentropy has joined #bitcoin-core-dev
168 2019-07-12T11:59:39  *** booyah has joined #bitcoin-core-dev
169 2019-07-12T12:00:02  *** pleia21 has quit IRC
170 2019-07-12T12:01:15  *** goatpig has joined #bitcoin-core-dev
171 2019-07-12T12:04:23  *** csslayer has joined #bitcoin-core-dev
172 2019-07-12T12:04:24  *** csslayer is now known as Guest16440
173 2019-07-12T12:15:36  *** elichai2 has joined #bitcoin-core-dev
174 2019-07-12T12:22:06  *** threewater027 has joined #bitcoin-core-dev
175 2019-07-12T12:24:31  *** threewater027 has quit IRC
176 2019-07-12T12:45:13  *** promag has joined #bitcoin-core-dev
177 2019-07-12T12:47:01  *** rh0nj has quit IRC
178 2019-07-12T12:48:13  *** lightlike has joined #bitcoin-core-dev
179 2019-07-12T12:50:07  *** rh0nj has joined #bitcoin-core-dev
180 2019-07-12T12:55:23  *** scoop has joined #bitcoin-core-dev
181 2019-07-12T12:56:48  *** Guest30053 has quit IRC
182 2019-07-12T12:58:54  *** Bullitje has joined #bitcoin-core-dev
183 2019-07-12T12:59:21  *** justanotheruser has joined #bitcoin-core-dev
184 2019-07-12T12:59:37  *** Aaronvan_ has joined #bitcoin-core-dev
185 2019-07-12T13:00:15  *** double_helix has quit IRC
186 2019-07-12T13:00:57  *** double_helix has joined #bitcoin-core-dev
187 2019-07-12T13:02:08  *** AaronvanW has quit IRC
188 2019-07-12T13:02:09  *** Bullit has quit IRC
189 2019-07-12T13:35:25  *** Zenton has joined #bitcoin-core-dev
190 2019-07-12T13:37:33  *** gelmutshmidt has joined #bitcoin-core-dev
191 2019-07-12T13:50:21  *** d_t has joined #bitcoin-core-dev
192 2019-07-12T13:51:46  *** scoop has quit IRC
193 2019-07-12T13:57:16  *** bitcoin-git has joined #bitcoin-core-dev
194 2019-07-12T13:57:16  <bitcoin-git> [bitcoin] Sjors opened pull request #16378: [WIP] The ultimate send RPC (master...2019/07/send) https://github.com/bitcoin/bitcoin/pull/16378
195 2019-07-12T13:57:19  *** bitcoin-git has left #bitcoin-core-dev
196 2019-07-12T14:00:55  *** scoop has joined #bitcoin-core-dev
197 2019-07-12T14:05:24  *** hebasto has quit IRC
198 2019-07-12T14:06:08  *** Aaronvan_ is now known as AaronvanW
199 2019-07-12T14:16:44  <sdaftuar> if we're making a regular outbound connection and our peer has fRelayTxes=false when we connect (ie because that node is running in -blocksonly mode, i'm guessing?) should we disconnect?
200 2019-07-12T14:17:12  <sdaftuar> now that -blocksonly is not a hidden option, i think we should probably do something to ensure we have sufficient tx-relay peers
201 2019-07-12T14:17:24  <sdaftuar> opinions?
202 2019-07-12T14:23:59  <jamesob> sounds reasonable to me. I'd say this would be especially important if we're more lenient with fRelayTxes=false peers re: eviction based on some kind of inactivity ("I haven't received an INV from this peer in n minutes") but I don't think that's the case at the moment
203 2019-07-12T14:25:17  <jamesob> the rationale being that it'd take fewer resources to sybil broadly with a bunch of -blocksonly nodes, but again I don't think that's the case atm
204 2019-07-12T14:29:27  <sdaftuar> i don't think there's a partition risk introduced by this, i'm more thinking that we have no protections in our code against our 8 regular outbounds all being run in -blocksonly mode and so there's an edge case where we are surprised to not receive transactions at all
205 2019-07-12T14:30:04  <sdaftuar> i'm not sure how much transaction-relaying peers is sufficient, but it'd be easy to detect a blocksonly peer when we're looking for a regular peer and just disconnect, i think.  might be too heavy-handed though?
206 2019-07-12T14:32:20  <jamesob> is ensuring some min ratio of regular peers too special casey?
207 2019-07-12T14:34:40  <sdaftuar> well, there are only 9 values to choose from when it comes to the number of blocksonly peers you'd tolerate as a "regular" outbound, so i think we can just pick where to set that threshold :)
208 2019-07-12T14:34:57  <sdaftuar> (i don't think we should include inbounds in that calculation)
209 2019-07-12T14:39:12  *** gleb has left #bitcoin-core-dev
210 2019-07-12T14:39:15  *** gleb has joined #bitcoin-core-dev
211 2019-07-12T14:40:58  *** nmnkgl has joined #bitcoin-core-dev
212 2019-07-12T14:43:14  *** gleb has left #bitcoin-core-dev
213 2019-07-12T14:43:37  *** Guyver2 has joined #bitcoin-core-dev
214 2019-07-12T14:44:27  *** belcher has joined #bitcoin-core-dev
215 2019-07-12T14:44:32  *** gleb has joined #bitcoin-core-dev
216 2019-07-12T14:48:14  <gleb> hi
217 2019-07-12T14:48:48  <gleb> sdaftuar: Why there is no explicit p2p message when "fRelayTxes=false"?
218 2019-07-12T14:50:09  *** d_t has quit IRC
219 2019-07-12T14:50:10  <sdaftuar> it's a hack -- we use a bit added to version messages when bip37 was rolled out to communicate that we don't want to enable transaction relay
220 2019-07-12T14:50:23  <sdaftuar> see https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki
221 2019-07-12T14:51:18  <gleb> So why we don't want to keep using this bit when identifying a fRelayTxes=false on other side?
222 2019-07-12T14:51:43  <sdaftuar> because bip37 allows for transaction relay to be re-enabled later in the connection's lifetime
223 2019-07-12T14:52:22  <sdaftuar> i'm not sure whether bip37 support is currently default on or off right now in our software, but we should do something more explicit for blocksonly connections in the future, i think.
224 2019-07-12T14:52:53  <gleb> Oh, I See. So something like an explicit message? :)
225 2019-07-12T14:53:01  <sdaftuar> yes
226 2019-07-12T14:58:30  *** michaelsdunn1 has joined #bitcoin-core-dev
227 2019-07-12T14:58:48  *** pinheadmz has joined #bitcoin-core-dev
228 2019-07-12T15:00:04  *** Guest16440 has quit IRC
229 2019-07-12T15:04:24  *** peeja has joined #bitcoin-core-dev
230 2019-07-12T15:10:39  *** StopAndDecrypt has joined #bitcoin-core-dev
231 2019-07-12T15:10:56  *** nmnkgl has quit IRC
232 2019-07-12T15:19:36  *** Victorsueca has quit IRC
233 2019-07-12T15:20:07  *** DeanWeen has joined #bitcoin-core-dev
234 2019-07-12T15:20:44  *** hebasto has joined #bitcoin-core-dev
235 2019-07-12T15:21:44  *** Victorsueca has joined #bitcoin-core-dev
236 2019-07-12T15:22:52  *** Dean_Guss has quit IRC
237 2019-07-12T15:27:32  *** DeanWeen has quit IRC
238 2019-07-12T15:34:39  *** pinheadmz has quit IRC
239 2019-07-12T15:40:27  *** queip has quit IRC
240 2019-07-12T15:44:53  *** amnesiac has joined #bitcoin-core-dev
241 2019-07-12T15:46:29  *** amnesiac has left #bitcoin-core-dev
242 2019-07-12T15:46:55  *** mnarix has joined #bitcoin-core-dev
243 2019-07-12T15:47:31  *** queip has joined #bitcoin-core-dev
244 2019-07-12T15:48:22  *** Zenton has quit IRC
245 2019-07-12T15:58:55  *** spinza has quit IRC
246 2019-07-12T16:01:38  *** rutyiraw has joined #bitcoin-core-dev
247 2019-07-12T16:03:01  *** setpill has quit IRC
248 2019-07-12T16:05:28  *** mnarix has quit IRC
249 2019-07-12T16:07:31  <lightlike> sdaftuar: looks like bip37 support is on per default, but will possibly be disabled if #16152 is merged
250 2019-07-12T16:07:33  <gribble> https://github.com/bitcoin/bitcoin/issues/16152 | Disable bloom filtering by default. by TheBlueMatt · Pull Request #16152 · bitcoin/bitcoin · GitHub
251 2019-07-12T16:07:44  *** morcos has quit IRC
252 2019-07-12T16:08:11  *** bitcoin-git has joined #bitcoin-core-dev
253 2019-07-12T16:08:11  <bitcoin-git> [bitcoin] hebasto opened pull request #16379: Fix autostart filenames Linux for testnet/regtest (master...20190712-fix-autostart) https://github.com/bitcoin/bitcoin/pull/16379
254 2019-07-12T16:08:17  *** bitcoin-git has left #bitcoin-core-dev
255 2019-07-12T16:09:10  *** morcos has joined #bitcoin-core-dev
256 2019-07-12T16:11:17  *** queip has quit IRC
257 2019-07-12T16:14:08  *** spinza has joined #bitcoin-core-dev
258 2019-07-12T16:15:13  *** nijak has joined #bitcoin-core-dev
259 2019-07-12T16:15:44  *** pinheadmz has joined #bitcoin-core-dev
260 2019-07-12T16:16:37  *** nijak_ has quit IRC
261 2019-07-12T16:17:45  *** queip has joined #bitcoin-core-dev
262 2019-07-12T16:18:05  *** jonatack has joined #bitcoin-core-dev
263 2019-07-12T16:22:11  *** emilengler has joined #bitcoin-core-dev
264 2019-07-12T16:25:32  *** emilengler has joined #bitcoin-core-dev
265 2019-07-12T16:29:31  *** emilengler has quit IRC
266 2019-07-12T16:31:38  *** double_helix has quit IRC
267 2019-07-12T16:32:02  *** emilengler has joined #bitcoin-core-dev
268 2019-07-12T16:57:43  *** itsiku has quit IRC
269 2019-07-12T16:58:03  *** itsiku has joined #bitcoin-core-dev
270 2019-07-12T17:01:30  *** jarthur has joined #bitcoin-core-dev
271 2019-07-12T17:09:07  *** Emcy has joined #bitcoin-core-dev
272 2019-07-12T17:09:30  *** scoop has quit IRC
273 2019-07-12T17:16:02  *** scoop has joined #bitcoin-core-dev
274 2019-07-12T17:20:46  *** scoop has quit IRC
275 2019-07-12T17:20:52  *** timothy has quit IRC
276 2019-07-12T17:23:06  *** owowo has quit IRC
277 2019-07-12T17:24:37  <BlueMatt> seems like something that should just get merged :)
278 2019-07-12T17:24:56  *** scoop has joined #bitcoin-core-dev
279 2019-07-12T17:25:16  *** bitcoin-git has joined #bitcoin-core-dev
280 2019-07-12T17:25:17  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/735d6b57e795...3453cf26dbaf
281 2019-07-12T17:25:18  <bitcoin-git> bitcoin/master 3e80ec3 Carl Dong: contrib: Add deterministic Guix builds.
282 2019-07-12T17:25:18  <bitcoin-git> bitcoin/master 8dff3e4 Carl Dong: contrib: guix: Clarify SOURCE_DATE_EPOCH.
283 2019-07-12T17:25:19  <bitcoin-git> bitcoin/master cd3e947 Carl Dong: contrib: guix: Various improvements.
284 2019-07-12T17:25:21  *** bitcoin-git has left #bitcoin-core-dev
285 2019-07-12T17:25:46  *** bitcoin-git has joined #bitcoin-core-dev
286 2019-07-12T17:25:46  <bitcoin-git> [bitcoin] laanwj closed pull request #16310: refactor: small optimization for IsHex method (master...master) https://github.com/bitcoin/bitcoin/pull/16310
287 2019-07-12T17:25:49  *** bitcoin-git has left #bitcoin-core-dev
288 2019-07-12T17:26:06  *** bitcoin-git has joined #bitcoin-core-dev
289 2019-07-12T17:26:06  <bitcoin-git> [bitcoin] laanwj merged pull request #15277: contrib: Enable building in Guix containers (master...2019-01-guix) https://github.com/bitcoin/bitcoin/pull/15277
290 2019-07-12T17:26:08  *** bitcoin-git has left #bitcoin-core-dev
291 2019-07-12T17:27:49  *** owowo has joined #bitcoin-core-dev
292 2019-07-12T17:39:04  <instagibbs> BlueMatt, marked "waiting for author" for some reason....
293 2019-07-12T17:41:17  <achow101> so are we now using guix for deterministic builds instead of gitian?
294 2019-07-12T17:41:54  <BlueMatt> instagibbs: dunno why?
295 2019-07-12T17:41:56  <BlueMatt> looks fine to me
296 2019-07-12T17:42:16  <instagibbs> Marco said stuff in his ACK, but you need to say "Shove it" and he'll merge
297 2019-07-12T17:42:22  <instagibbs> ;)
298 2019-07-12T17:42:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
299 2019-07-12T17:43:25  <BlueMatt> right, I dont know that the release note categories are
300 2019-07-12T17:43:51  <instagibbs> achow101, https://github.com/bitcoin/bitcoin/tree/master/contrib/guix looks like you're supposed ot be able to use it
301 2019-07-12T17:44:10  *** spaced0ut has quit IRC
302 2019-07-12T17:46:10  *** nijak_ has joined #bitcoin-core-dev
303 2019-07-12T17:47:14  *** Chris_Stewart_5 has quit IRC
304 2019-07-12T17:47:33  *** nijak has quit IRC
305 2019-07-12T17:53:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
306 2019-07-12T17:57:19  <dongcarl> achow101: This section was written specifically for you: https://github.com/bitcoin/bitcoin/tree/master/contrib/guix#speeding-up-builds-with-substitute-servers
307 2019-07-12T17:57:28  <dongcarl> <3
308 2019-07-12T17:59:11  *** nijak has joined #bitcoin-core-dev
309 2019-07-12T17:59:30  *** nijak_ has quit IRC
310 2019-07-12T18:00:02  *** peeja has quit IRC
311 2019-07-12T18:12:09  *** Wolfy87 has joined #bitcoin-core-dev
312 2019-07-12T18:16:04  *** Chris_Stewart_5 has quit IRC
313 2019-07-12T18:16:17  *** dgenr8 has quit IRC
314 2019-07-12T18:16:42  *** dgenr8 has joined #bitcoin-core-dev
315 2019-07-12T18:19:10  *** bitcoin-git has joined #bitcoin-core-dev
316 2019-07-12T18:19:10  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
317 2019-07-12T18:19:11  *** bitcoin-git has left #bitcoin-core-dev
318 2019-07-12T18:26:01  *** jonatack has left #bitcoin-core-dev
319 2019-07-12T18:26:08  *** jonatack has joined #bitcoin-core-dev
320 2019-07-12T18:29:12  *** elichai2 has quit IRC
321 2019-07-12T18:33:06  *** Randolf has joined #bitcoin-core-dev
322 2019-07-12T18:43:25  *** xwirton has joined #bitcoin-core-dev
323 2019-07-12T18:43:52  *** rutyiraw has quit IRC
324 2019-07-12T18:50:46  <emilengler> Can someone help me? I'm currently stucking at a PR and I have no idea why the travis build is failing on the tests (https://travis-ci.org/bitcoin/bitcoin/jobs/557960750)
325 2019-07-12T18:56:09  *** instagibbs has quit IRC
326 2019-07-12T18:56:41  <MarcoFalke> Looks like a segfault in your code
327 2019-07-12T18:57:02  <MarcoFalke> Run a getblockbyheight locally and you get the error
328 2019-07-12T18:58:30  *** instagibbs has joined #bitcoin-core-dev
329 2019-07-12T18:58:39  <wumpus> yea, 'waiting for author' just means 'author needs to reply', it doesn't mean that the author needs to do everything (including cleaning toilets) that the reviewers propose :p
330 2019-07-12T18:58:58  <wumpus> it's fiine to say 'this is out of scope of this PR'
331 2019-07-12T18:59:37  <MarcoFalke> A p2p network change is not a command line change
332 2019-07-12T18:59:38  <wumpus> I'd even encourage that to make sure that progress is made and things don't get held up in a back-and-forth forever
333 2019-07-12T19:00:21  <wumpus> MarcoFalke: definitely
334 2019-07-12T19:01:55  <MarcoFalke> If there is feedback and multiple reviewers agree on it, it shouldn't be ignored
335 2019-07-12T19:02:53  <MarcoFalke> If it was a whitespace nit or something, yeah maybe ignore it
336 2019-07-12T19:03:00  <wumpus> it should never be *ignored*
337 2019-07-12T19:03:05  <wumpus> saying 'no' is ok, ignorning not
338 2019-07-12T19:03:31  <MarcoFalke> Agree
339 2019-07-12T19:04:33  <MarcoFalke> Knowing the reason that some feedback has not been addressed gives helpful insights
340 2019-07-12T19:04:49  <MarcoFalke> s/that/why/
341 2019-07-12T19:05:12  <wumpus> I mean reviewers spend time in writing review comments so the least you can do is respond to it, with reasoning
342 2019-07-12T19:05:53  <wumpus> right
343 2019-07-12T19:08:17  *** RandolfR has joined #bitcoin-core-dev
344 2019-07-12T19:11:14  *** Randolf has quit IRC
345 2019-07-12T19:13:16  *** RandolfR is now known as Randolf
346 2019-07-12T19:18:06  *** Randolf has quit IRC
347 2019-07-12T19:29:11  *** bitcoin-git has joined #bitcoin-core-dev
348 2019-07-12T19:29:11  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/3453cf26dbaf...536590f358dc
349 2019-07-12T19:29:12  <bitcoin-git> bitcoin/master 604e2a9 Carl Dong: test: rpc_users: Add function for auth'd requests.
350 2019-07-12T19:29:12  <bitcoin-git> bitcoin/master c73d871 Carl Dong: test: rpc_users: Add function for testing auth params.
351 2019-07-12T19:29:13  <bitcoin-git> bitcoin/master 830dc2d Carl Dong: test: rpc_users: Also test rpcauth.py with specified password.
352 2019-07-12T19:29:16  *** bitcoin-git has left #bitcoin-core-dev
353 2019-07-12T19:30:06  *** bitcoin-git has joined #bitcoin-core-dev
354 2019-07-12T19:30:06  <bitcoin-git> [bitcoin] laanwj merged pull request #16334: test: rpc_users: Also test rpcauth.py with password. (master...2019-07-rpcauth-passwd-specified-case) https://github.com/bitcoin/bitcoin/pull/16334
355 2019-07-12T19:30:09  *** bitcoin-git has left #bitcoin-core-dev
356 2019-07-12T19:37:08  <emilengler> MarcoFalke, it works without any issues on my system (Debian Buster, amd64), thats really strange
357 2019-07-12T19:37:30  <MarcoFalke> Oh, you might have to compile with --enable-debug
358 2019-07-12T19:38:25  <MarcoFalke> ./configure --enable-debug
359 2019-07-12T19:39:03  <MarcoFalke> if that doesn't help, run the server in valgrind and call the rpc again
360 2019-07-12T19:40:26  <emilengler> Ok thanks
361 2019-07-12T19:43:22  *** elichai2 has joined #bitcoin-core-dev
362 2019-07-12T19:51:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
363 2019-07-12T20:00:43  *** promag has quit IRC
364 2019-07-12T20:05:33  *** Deangus has joined #bitcoin-core-dev
365 2019-07-12T20:08:00  <midnightmagic> dongcarl: Any experience yet with non-arm/x86 hosts for guix..?
366 2019-07-12T20:11:39  <emilengler> Is it normal that when you compile with --enable-debug bitcoind quits after one RPC command#
367 2019-07-12T20:14:34  <emilengler> Nevermind, it is a problem of my code
368 2019-07-12T20:19:13  *** Chris_Stewart_5 has quit IRC
369 2019-07-12T20:21:31  <midnightmagic> the guix guy's gpg key is expired as of four days ago.
370 2019-07-12T20:22:10  <midnightmagic> rsa4096/090B11993D9AEBB5 -> expired: 2019-07-08
371 2019-07-12T20:26:25  <dongcarl> midnightmagic: Not really, I know MIPS is supported well
372 2019-07-12T20:26:56  <dongcarl> I've been porting things to riscv64, but have only gotten it working as a build target
373 2019-07-12T20:28:24  <dongcarl> midnightmagic: Try refreshing it
374 2019-07-12T20:28:34  <dongcarl> you might have pulled it a few months ago
375 2019-07-12T20:28:50  <dongcarl> he refreshes every few months I believe
376 2019-07-12T20:45:14  <emilengler> Can someone with permission restart this build? https://travis-ci.org/bitcoin/bitcoin/builds/556932611?utm_source=github_status&utm_medium=notification
377 2019-07-12T20:55:30  *** Zenton has joined #bitcoin-core-dev
378 2019-07-12T21:00:01  *** Wolfy87 has quit IRC
379 2019-07-12T21:05:13  <emilengler> Thanks to whoever has restarted the build ^^ :-)
380 2019-07-12T21:13:06  *** Guyver2 has quit IRC
381 2019-07-12T21:14:51  *** jonatack is now known as jonatack_
382 2019-07-12T21:15:58  *** hebasto has quit IRC
383 2019-07-12T21:18:07  *** mmf has joined #bitcoin-core-dev
384 2019-07-12T21:26:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
385 2019-07-12T21:39:21  *** gelmutshmidt has quit IRC
386 2019-07-12T21:39:41  *** gelmutshmidt has joined #bitcoin-core-dev
387 2019-07-12T21:43:09  *** scoop has quit IRC
388 2019-07-12T21:45:44  *** queip has quit IRC
389 2019-07-12T21:52:38  *** queip has joined #bitcoin-core-dev
390 2019-07-12T22:16:17  *** Chris_Stewart_5 has quit IRC
391 2019-07-12T22:18:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
392 2019-07-12T22:22:59  *** michaelsdunn1 has quit IRC
393 2019-07-12T22:27:30  *** michaelfolkson has joined #bitcoin-core-dev
394 2019-07-12T22:30:00  <midnightmagic> dongcarl: no, I pulleld it literally minutes before I mentioned it in here..?
395 2019-07-12T22:30:09  <midnightmagic> based on the install script suggestion for import anyway
396 2019-07-12T22:31:29  *** spinza has quit IRC
397 2019-07-12T22:33:56  *** michaelfolkson has quit IRC
398 2019-07-12T22:41:29  *** spinza has joined #bitcoin-core-dev
399 2019-07-12T22:45:52  *** Chris_Stewart_5 has quit IRC
400 2019-07-12T22:53:26  *** hexyul has quit IRC
401 2019-07-12T22:59:18  *** hexyul has joined #bitcoin-core-dev
402 2019-07-12T23:13:05  *** emilengler has quit IRC
403 2019-07-12T23:35:41  *** brianhoffman has joined #bitcoin-core-dev
404 2019-07-12T23:43:38  *** scoop has joined #bitcoin-core-dev
405 2019-07-12T23:48:18  *** scoop has quit IRC
406 2019-07-12T23:59:32  *** jarthur has quit IRC