12019-07-16T00:00:01  *** rknLA1 has quit IRC
  22019-07-16T00:04:36  *** Lauwenmark has joined #bitcoin-core-dev
  32019-07-16T00:22:10  *** instagibbs_ has quit IRC
  42019-07-16T00:22:35  *** captjakk has quit IRC
  52019-07-16T00:31:22  *** IGHOR has quit IRC
  62019-07-16T00:34:11  *** IGHOR has joined #bitcoin-core-dev
  72019-07-16T00:57:45  *** pinheadmz has quit IRC
  82019-07-16T01:04:39  *** scoop has joined #bitcoin-core-dev
  92019-07-16T01:10:44  *** scoop has quit IRC
 102019-07-16T01:11:11  *** scoop has joined #bitcoin-core-dev
 112019-07-16T01:15:08  *** scoop has quit IRC
 122019-07-16T01:15:15  *** scoop has joined #bitcoin-core-dev
 132019-07-16T01:17:21  *** scoop has quit IRC
 142019-07-16T01:33:27  *** scoop has joined #bitcoin-core-dev
 152019-07-16T01:57:01  *** mnarix has quit IRC
 162019-07-16T01:59:09  *** jarthur has quit IRC
 172019-07-16T02:03:12  *** bitcoin-git has joined #bitcoin-core-dev
 182019-07-16T02:03:12  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d37ed888e34...29082e8f40c3
 192019-07-16T02:03:13  <bitcoin-git> bitcoin/master fa0d0ff MarcoFalke: Remove unused bits from the service flags enum
 202019-07-16T02:03:13  <bitcoin-git> bitcoin/master 29082e8 fanquake: Merge #16380: Remove unused bits from the service flags enum
 212019-07-16T02:03:15  *** scoop has quit IRC
 222019-07-16T02:03:26  *** bitcoin-git has left #bitcoin-core-dev
 232019-07-16T02:03:41  *** scoop has joined #bitcoin-core-dev
 242019-07-16T02:04:16  *** scoop has quit IRC
 252019-07-16T02:04:20  *** bitcoin-git has joined #bitcoin-core-dev
 262019-07-16T02:04:20  <bitcoin-git> [bitcoin] fanquake merged pull request #16380: Remove unused bits from the service flags enum (master...1907-netRemoveUnusedServiceBits) https://github.com/bitcoin/bitcoin/pull/16380
 272019-07-16T02:04:23  *** scoop_ has joined #bitcoin-core-dev
 282019-07-16T02:04:27  *** bitcoin-git has left #bitcoin-core-dev
 292019-07-16T02:07:54  *** scoop_ has quit IRC
 302019-07-16T02:08:23  *** StopAndDecrypt has quit IRC
 312019-07-16T02:13:29  *** scoop has joined #bitcoin-core-dev
 322019-07-16T02:25:07  *** ddustin has quit IRC
 332019-07-16T02:25:42  *** ddustin has joined #bitcoin-core-dev
 342019-07-16T02:30:02  *** ddustin has quit IRC
 352019-07-16T02:44:50  *** scoop has quit IRC
 362019-07-16T02:45:45  *** scoop has joined #bitcoin-core-dev
 372019-07-16T02:47:32  *** mryandao has quit IRC
 382019-07-16T02:47:39  *** mryandao_ has joined #bitcoin-core-dev
 392019-07-16T02:48:09  *** scoop has quit IRC
 402019-07-16T02:48:15  *** scoop has joined #bitcoin-core-dev
 412019-07-16T02:53:47  *** scoop has quit IRC
 422019-07-16T03:00:01  *** Lauwenmark has quit IRC
 432019-07-16T03:04:27  *** SatanX has joined #bitcoin-core-dev
 442019-07-16T03:04:52  *** SatanX is now known as Guest63177
 452019-07-16T03:13:08  *** elichai2 has quit IRC
 462019-07-16T03:15:22  *** DeanWeen has joined #bitcoin-core-dev
 472019-07-16T03:30:59  *** Victorsueca has quit IRC
 482019-07-16T03:31:24  *** Victorsueca has joined #bitcoin-core-dev
 492019-07-16T03:45:47  *** scoop has joined #bitcoin-core-dev
 502019-07-16T03:46:12  *** scoop has quit IRC
 512019-07-16T03:46:18  *** scoop has joined #bitcoin-core-dev
 522019-07-16T03:47:52  *** ddustin has joined #bitcoin-core-dev
 532019-07-16T03:59:01  *** d_t has joined #bitcoin-core-dev
 542019-07-16T03:59:03  *** ddustin has quit IRC
 552019-07-16T04:17:31  *** scoop has quit IRC
 562019-07-16T04:18:56  *** scoop has joined #bitcoin-core-dev
 572019-07-16T04:23:21  *** scoop has quit IRC
 582019-07-16T04:24:50  *** d_t has quit IRC
 592019-07-16T04:25:13  *** d_t has joined #bitcoin-core-dev
 602019-07-16T04:27:43  *** dogydogedoger has joined #bitcoin-core-dev
 612019-07-16T04:31:53  *** Victor_sueca has joined #bitcoin-core-dev
 622019-07-16T04:32:11  *** spinza has quit IRC
 632019-07-16T04:34:13  *** Victorsueca has quit IRC
 642019-07-16T04:42:57  *** spinza has joined #bitcoin-core-dev
 652019-07-16T04:47:07  *** mryandao_ is now known as mryandao
 662019-07-16T04:48:33  *** scoop has joined #bitcoin-core-dev
 672019-07-16T04:50:06  *** d_t has quit IRC
 682019-07-16T04:50:54  *** pinheadmz has joined #bitcoin-core-dev
 692019-07-16T04:52:58  *** scoop has quit IRC
 702019-07-16T05:06:47  *** goatpig has quit IRC
 712019-07-16T05:11:58  <pinheadmz> I'm getting a leveldb checksum mismatch error `Fatal LevelDB error: Corruption: block checksum mismatch: /home/pi/.bitcoin/chainstate/2109327.ldb` but only when I shutdown with RPC stop... Since the error is in chainstate, can I try with -reindex ? Or do I need to redownload the chain...?
 722019-07-16T05:19:36  <sipa> even -reindex-chainstate should work
 732019-07-16T05:21:12  <pinheadmz> tnx
 742019-07-16T05:23:49  *** dogydogedoger has quit IRC
 752019-07-16T05:24:30  *** dogeydogedoger1 has joined #bitcoin-core-dev
 762019-07-16T05:26:42  *** dogeydogedoger1 has left #bitcoin-core-dev
 772019-07-16T05:31:12  *** scoop has joined #bitcoin-core-dev
 782019-07-16T05:36:02  *** scoop has quit IRC
 792019-07-16T05:52:37  *** DeanWeen has quit IRC
 802019-07-16T05:53:22  *** DeanWeen has joined #bitcoin-core-dev
 812019-07-16T05:55:35  *** DeanWeen has quit IRC
 822019-07-16T05:56:00  *** DeanWeen has joined #bitcoin-core-dev
 832019-07-16T06:00:02  *** Guest63177 has quit IRC
 842019-07-16T06:03:35  *** sipa has quit IRC
 852019-07-16T06:04:18  *** Frojoe1 has joined #bitcoin-core-dev
 862019-07-16T06:08:47  *** sipa has joined #bitcoin-core-dev
 872019-07-16T06:14:17  *** d_t has joined #bitcoin-core-dev
 882019-07-16T06:16:18  *** d_t has quit IRC
 892019-07-16T06:26:11  *** rh0nj has quit IRC
 902019-07-16T06:27:09  *** rh0nj has joined #bitcoin-core-dev
 912019-07-16T06:30:23  *** pinheadmz has quit IRC
 922019-07-16T06:32:33  *** scoop has joined #bitcoin-core-dev
 932019-07-16T06:37:08  *** scoop has quit IRC
 942019-07-16T06:42:45  *** pinheadmz has joined #bitcoin-core-dev
 952019-07-16T06:47:45  *** asdf44 has quit IRC
 962019-07-16T06:51:03  *** booyah_ has quit IRC
 972019-07-16T06:56:37  *** hebasto has joined #bitcoin-core-dev
 982019-07-16T06:57:22  *** queip has quit IRC
 992019-07-16T07:03:15  *** EagleTM has joined #bitcoin-core-dev
1002019-07-16T07:05:38  *** queip has joined #bitcoin-core-dev
1012019-07-16T07:13:09  *** pinheadmz has quit IRC
1022019-07-16T07:15:29  *** Honthe has quit IRC
1032019-07-16T07:32:32  *** Guyver2 has joined #bitcoin-core-dev
1042019-07-16T07:34:40  *** jungly has joined #bitcoin-core-dev
1052019-07-16T07:39:17  *** DeanWeen has quit IRC
1062019-07-16T07:39:48  *** DeanWeen has joined #bitcoin-core-dev
1072019-07-16T07:41:54  *** EagleTM has quit IRC
1082019-07-16T07:44:15  *** DeanWeen has quit IRC
1092019-07-16T07:47:24  *** csknk has joined #bitcoin-core-dev
1102019-07-16T07:58:12  *** setpill has joined #bitcoin-core-dev
1112019-07-16T08:13:54  *** queip has quit IRC
1122019-07-16T08:19:45  *** hebasto has quit IRC
1132019-07-16T08:20:33  *** queip has joined #bitcoin-core-dev
1142019-07-16T08:21:06  *** hui has joined #bitcoin-core-dev
1152019-07-16T08:22:13  *** hui has quit IRC
1162019-07-16T08:24:10  *** hebasto has joined #bitcoin-core-dev
1172019-07-16T08:33:55  *** scoop has joined #bitcoin-core-dev
1182019-07-16T08:33:55  *** hebasto has quit IRC
1192019-07-16T08:38:26  *** scoop has quit IRC
1202019-07-16T08:39:20  *** lowentropy has quit IRC
1212019-07-16T08:39:31  *** lowentropy has joined #bitcoin-core-dev
1222019-07-16T08:41:21  *** AaronvanW has joined #bitcoin-core-dev
1232019-07-16T08:47:09  *** Aaronvan_ has joined #bitcoin-core-dev
1242019-07-16T08:51:22  *** AaronvanW has quit IRC
1252019-07-16T09:00:02  *** Frojoe1 has quit IRC
1262019-07-16T09:04:03  *** ranman1 has joined #bitcoin-core-dev
1272019-07-16T09:34:46  *** goatpig has joined #bitcoin-core-dev
1282019-07-16T09:35:20  *** scoop has joined #bitcoin-core-dev
1292019-07-16T09:39:46  *** scoop has quit IRC
1302019-07-16T09:40:24  *** timothy has joined #bitcoin-core-dev
1312019-07-16T09:40:47  *** Aaronvan_ is now known as AaronvanW
1322019-07-16T09:43:37  *** queip has quit IRC
1332019-07-16T09:45:47  *** hebasto has joined #bitcoin-core-dev
1342019-07-16T09:53:02  *** queip has joined #bitcoin-core-dev
1352019-07-16T09:57:01  *** keymone has quit IRC
1362019-07-16T10:00:23  *** belcher has quit IRC
1372019-07-16T10:33:40  *** mildly_risky has joined #bitcoin-core-dev
1382019-07-16T10:34:43  *** spinza has quit IRC
1392019-07-16T10:36:00  *** mildly_risky has quit IRC
1402019-07-16T10:39:06  *** etwert has joined #bitcoin-core-dev
1412019-07-16T10:56:28  *** spinza has joined #bitcoin-core-dev
1422019-07-16T11:05:10  *** csknk has quit IRC
1432019-07-16T11:14:40  *** Aaronvan_ has joined #bitcoin-core-dev
1442019-07-16T11:16:41  *** shesek` has joined #bitcoin-core-dev
1452019-07-16T11:17:54  *** AaronvanW has quit IRC
1462019-07-16T11:18:22  *** shesek has quit IRC
1472019-07-16T11:20:55  *** shesek` has quit IRC
1482019-07-16T11:24:42  *** shesek has joined #bitcoin-core-dev
1492019-07-16T11:24:42  *** shesek has joined #bitcoin-core-dev
1502019-07-16T11:36:44  *** scoop has joined #bitcoin-core-dev
1512019-07-16T11:41:02  *** scoop has quit IRC
1522019-07-16T11:44:32  *** jb55 has quit IRC
1532019-07-16T11:45:21  *** queip has quit IRC
1542019-07-16T11:46:18  *** etwert has quit IRC
1552019-07-16T11:47:08  *** Aaronvan_ is now known as AaronvanW
1562019-07-16T11:51:32  *** queip has joined #bitcoin-core-dev
1572019-07-16T11:57:00  *** jb55 has joined #bitcoin-core-dev
1582019-07-16T12:00:02  *** ranman1 has quit IRC
1592019-07-16T12:04:37  *** wright has joined #bitcoin-core-dev
1602019-07-16T12:05:17  *** EagleTM has joined #bitcoin-core-dev
1612019-07-16T12:14:26  *** etwert has joined #bitcoin-core-dev
1622019-07-16T12:22:03  *** etwert has quit IRC
1632019-07-16T12:23:18  *** cubancorona has joined #bitcoin-core-dev
1642019-07-16T12:26:16  *** cubancorona has joined #bitcoin-core-dev
1652019-07-16T12:31:00  *** scoop has joined #bitcoin-core-dev
1662019-07-16T12:36:21  <stevenroose> What's the name of the default wallet?
1672019-07-16T12:37:15  <stevenroose> Like some other process calls `create("myname")` and then uses `/wallet/myname` as endpoint. If I want to use the default wallet, what endpoint do I use?
1682019-07-16T12:42:31  *** Guyver2 has quit IRC
1692019-07-16T12:43:14  *** double_helix has quit IRC
1702019-07-16T12:46:43  *** jungly has quit IRC
1712019-07-16T12:47:07  *** waxwing has quit IRC
1722019-07-16T12:47:07  *** waxwing has joined #bitcoin-core-dev
1732019-07-16T12:54:31  <stevenroose> When doing multiwallet stuff, all wallets should notice new incoming transactions, right?
1742019-07-16T12:55:09  *** csknk has joined #bitcoin-core-dev
1752019-07-16T12:55:30  <luke-jr> their own only
1762019-07-16T13:02:25  *** jungly has joined #bitcoin-core-dev
1772019-07-16T13:02:46  *** hebasto has quit IRC
1782019-07-16T13:03:36  *** bitcoin-git has joined #bitcoin-core-dev
1792019-07-16T13:03:36  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29082e8f40c3...8f9725c83f1d
1802019-07-16T13:03:37  <bitcoin-git> bitcoin/master 1a62425 João Barbosa: qa: Add --filter option to test_runner.py
1812019-07-16T13:03:37  <bitcoin-git> bitcoin/master 8f9725c MarcoFalke: Merge #16390: qa: Add --filter option to test_runner.py
1822019-07-16T13:03:49  *** bitcoin-git has left #bitcoin-core-dev
1832019-07-16T13:04:45  *** bitcoin-git has joined #bitcoin-core-dev
1842019-07-16T13:04:46  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16390: qa: Add --filter option to test_runner.py (master...2019-07-testrunner-filter) https://github.com/bitcoin/bitcoin/pull/16390
1852019-07-16T13:04:47  *** bitcoin-git has left #bitcoin-core-dev
1862019-07-16T13:14:19  *** queip has quit IRC
1872019-07-16T13:16:39  *** scoop has quit IRC
1882019-07-16T13:16:45  *** scoop has joined #bitcoin-core-dev
1892019-07-16T13:18:47  *** goatpig has quit IRC
1902019-07-16T13:20:15  *** queip has joined #bitcoin-core-dev
1912019-07-16T13:20:36  <promag> stevenroose: /wallet/
1922019-07-16T13:20:41  *** michaelfolkson has joined #bitcoin-core-dev
1932019-07-16T13:20:55  <promag> default wallet is ""
1942019-07-16T13:21:29  <promag> what do you mean by "notice new incoming transactions"?
1952019-07-16T13:25:58  *** jb55 has quit IRC
1962019-07-16T13:26:06  <stevenroose> promag: that if the wallet is loaded, and then you call fundraw, it should know about the utxos it has
1972019-07-16T13:26:22  <stevenroose> promag: I guess my issue is more with fundraw than the wallets
1982019-07-16T13:26:30  *** jb55 has joined #bitcoin-core-dev
1992019-07-16T13:27:22  <jnewbery> fundrawtransaction is a wallet RPC. It needs to be sent to an individual wallet's RPC endpoint
2002019-07-16T13:27:32  <stevenroose> I'm running this all inside a program so it's not trivial to get good debugging information (I can print out things, but to investigate deeper I need to change the code and re-run integration test.).
2012019-07-16T13:27:41  <stevenroose> So listunspent shows a 500 btc output
2022019-07-16T13:27:51  <stevenroose> but fundraw keeps saying "insufficient funds"
2032019-07-16T13:28:00  <promag> note that if the wallet was offline then some utxo might not be known. getwalletinfo has the "scanning" response
2042019-07-16T13:28:09  <stevenroose> The funds are watchonly, but I have the include_watchonly variable set to true
2052019-07-16T13:28:40  <stevenroose> promag: the node doesn't go down.. so the the wallet online as long as it was "createwallet"'d before?
2062019-07-16T13:29:14  <promag> stevenroose: I don't know how you have that setup, but wallets can be loaded/unloaded
2072019-07-16T13:29:55  <promag> do you specify conf_target in fundraw?
2082019-07-16T13:30:08  <stevenroose> promag: don't think so
2092019-07-16T13:30:10  <stevenroose> it's regtest
2102019-07-16T13:30:23  <stevenroose> I have minrelaytxfee and minblockfee set to 0
2112019-07-16T13:30:40  <stevenroose> (While I would like to remove those later, I have them at 0 now.)
2122019-07-16T13:30:42  <shesek> stevenroose, did you set includeWatching?
2132019-07-16T13:30:54  <shesek> oh sorry, missed your message
2142019-07-16T13:31:55  <stevenroose> yeah I did, I'm not 100% sure the client is encoding includeWatching correctly, though, but I suppose if the field is names incorrectly (like include_watching), Core would complain, right? promag
2152019-07-16T13:32:22  <promag> stevenroose: some yeah
2162019-07-16T13:32:37  <promag> not sure about invalid options in json options
2172019-07-16T13:32:41  <stevenroose> (@shesek we have serde(rename_all = "camelCase") so that should work
2182019-07-16T13:32:45  <promag> invalid keys I mean
2192019-07-16T13:32:46  <shesek> I just looked, FundRawTransactionOptions has serde configured with rename_all = "camelCase", then special case for the ones that aren't
2202019-07-16T13:32:57  *** lnostdal has quit IRC
2212019-07-16T13:33:09  <stevenroose> shesek: yeah I know, just not 100% confident in it :D
2222019-07-16T13:33:26  * luke-jr grumbles at tests failing on normal hard drives
2232019-07-16T13:33:32  <stevenroose> hmmmm, do you have time, shesek? I could push my current progress, I reverted all the manual tx creation stuff
2242019-07-16T13:33:54  <shesek> yes, lets move over to pm?
2252019-07-16T13:33:58  <stevenroose> sure
2262019-07-16T13:34:11  <stevenroose> thanks, promag, jnewbery I'll keep you posted if we figure it out :)
2272019-07-16T13:34:23  <promag> sure
2282019-07-16T13:34:35  *** michaelfolkson has quit IRC
2292019-07-16T13:38:14  *** michaelfolkson has joined #bitcoin-core-dev
2302019-07-16T13:41:56  *** goatpig has joined #bitcoin-core-dev
2312019-07-16T13:45:35  <stevenroose> promag: can you do multiwallet witn bitcoin-cli without having to change the url in the config file?
2322019-07-16T13:45:42  <stevenroose> -h doesn't show a -wallet or something
2332019-07-16T13:45:43  <promag> -rpcwallet
2342019-07-16T13:45:46  <stevenroose> oh
2352019-07-16T13:46:04  <stevenroose> k cool thanks
2362019-07-16T13:48:42  *** michaelfolkson has quit IRC
2372019-07-16T13:50:45  *** d_t has joined #bitcoin-core-dev
2382019-07-16T13:51:21  <stevenroose> promag: I just tried manually doing the same as what I did and it seems like it also doesn't work. Let me write this up briefly.
2392019-07-16T13:52:37  <promag> stevenroose: if you prefer you can pm
2402019-07-16T13:54:02  *** Guyver2 has joined #bitcoin-core-dev
2412019-07-16T13:55:03  *** d_t has quit IRC
2422019-07-16T13:57:28  <stevenroose> https://gist.github.com/stevenroose/b7d60c44d5235ac4d98dbdbf4442210b
2432019-07-16T13:58:26  *** davec has quit IRC
2442019-07-16T13:59:21  *** elichai2 has joined #bitcoin-core-dev
2452019-07-16T14:03:52  *** davterra has joined #bitcoin-core-dev
2462019-07-16T14:04:54  *** davec has joined #bitcoin-core-dev
2472019-07-16T14:05:11  *** setpill has quit IRC
2482019-07-16T14:09:27  <promag> stevenroose: there's spendable:false in the 500 utxo
2492019-07-16T14:09:43  <stevenroose> promag: it's imported by address
2502019-07-16T14:10:07  <stevenroose>             bool spendable = ((mine & ISMINE_SPENDABLE) != ISMINE_NO) || (((mine & ISMINE_WATCH_ONLY) != ISMINE_NO) && (coinControl && coinControl->fAllowWatchOnly && solvable));
2512019-07-16T14:10:27  <promag> right, how do you expect it to spend that?
2522019-07-16T14:10:55  <stevenroose> I'm calling fundraw with includeWatching: true.. Is that not supposed to work?
2532019-07-16T14:11:24  <promag> I could watch your coins and then I could spend them?
2542019-07-16T14:11:25  <stevenroose> I'm just trying to use Core for coin selection.
2552019-07-16T14:11:43  <stevenroose> promag: well there is includeWatching on fundraw..
2562019-07-16T14:11:52  <stevenroose> fundraw doesn't sign, right
2572019-07-16T14:12:06  <stevenroose> So it just fills some inputs from the unspent ones in the wallet
2582019-07-16T14:12:15  <promag> 1sec
2592019-07-16T14:16:06  <shesek> the output needs to be `solvable` in order to be used by fundrawtransaction, not necessarily spendable
2602019-07-16T14:17:09  <shesek> I think the issue is that the addresses needs to be imported with their matching pubkeys/spks in order to be `solvable`
2612019-07-16T14:20:59  <stevenroose> True. But it doesn't really make sense. It's supposed to be for fee calculation because for solvable inputs you know the witness/scriptSig size, but for p2wpkh you should also know that
2622019-07-16T14:21:02  <stevenroose> https://github.com/bitcoin/bitcoin/issues/14405
2632019-07-16T14:32:12  *** hebasto has joined #bitcoin-core-dev
2642019-07-16T14:34:09  *** michaelfolkson has joined #bitcoin-core-dev
2652019-07-16T14:35:19  <sipa> stevenroose: you're right that this could work in theory, but it's an exception
2662019-07-16T14:35:51  <sipa> p2wpkh is only thing where feerates are computable without actually knowing the pubkeys
2672019-07-16T14:37:26  *** michaelfolkson has quit IRC
2682019-07-16T14:38:45  *** goatpig has quit IRC
2692019-07-16T14:40:59  <sipa> stevenroose: fee estimation works by trying to sign with a dummy signers which succeeds without knowing private keys
2702019-07-16T14:41:26  <sipa> but if your address is not solvable, there isn't even a public key to invoke it on
2712019-07-16T14:43:49  *** michaelsdunn1 has joined #bitcoin-core-dev
2722019-07-16T14:43:58  *** jonatack has joined #bitcoin-core-dev
2732019-07-16T14:44:52  <promag> is there any inconvenient in importpubkey 03d2fad0057c658d013153cfab628af5fab3ff78cb6b4d6d5cd194556eedf0f206 ?
2742019-07-16T14:45:04  <stevenroose> sipa: I understand now it's for feecalculation reasons. My main confusion is that includeWatching stringly suggests that watched addresses should work.
2752019-07-16T14:45:12  <stevenroose> I'll pr a clarification.
2762019-07-16T14:46:11  *** obsrver has joined #bitcoin-core-dev
2772019-07-16T14:49:32  *** bitcoin-git has joined #bitcoin-core-dev
2782019-07-16T14:49:32  <bitcoin-git> [bitcoin] stevenroose opened pull request #16397: Clarify includeWatching for fundrawtransaction (master...fundraw-includewatching) https://github.com/bitcoin/bitcoin/pull/16397
2792019-07-16T14:49:35  *** bitcoin-git has left #bitcoin-core-dev
2802019-07-16T14:54:27  *** emilengler has joined #bitcoin-core-dev
2812019-07-16T15:00:02  *** wright has quit IRC
2822019-07-16T15:00:07  *** scoop has quit IRC
2832019-07-16T15:01:03  *** scoop has joined #bitcoin-core-dev
2842019-07-16T15:01:04  *** scoop has quit IRC
2852019-07-16T15:01:10  *** scoop_ has joined #bitcoin-core-dev
2862019-07-16T15:01:30  *** scoop_ has quit IRC
2872019-07-16T15:02:27  *** bitcoin-git has joined #bitcoin-core-dev
2882019-07-16T15:02:27  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13804: WIP: Transaction Pool Layer (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/13804
2892019-07-16T15:02:31  *** bitcoin-git has left #bitcoin-core-dev
2902019-07-16T15:05:55  *** bitcoin-git has joined #bitcoin-core-dev
2912019-07-16T15:05:55  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16398: rpc: testmempoolaccept for list of transactions (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/16398
2922019-07-16T15:05:56  *** bitcoin-git has left #bitcoin-core-dev
2932019-07-16T15:06:47  *** Honthe has joined #bitcoin-core-dev
2942019-07-16T15:15:38  *** scoop has joined #bitcoin-core-dev
2952019-07-16T15:24:37  *** EagleTM has quit IRC
2962019-07-16T15:24:56  <stevenroose> I'm getting this error when I'm using importmulti with "desc": { code: -8, message: "Invalid scriptPubKey" }
2972019-07-16T15:24:57  *** lnostdal has joined #bitcoin-core-dev
2982019-07-16T15:25:15  <stevenroose> But the documentation for that field says "Should not be provided if using a descriptor"
2992019-07-16T15:45:36  *** pcmanus1 has joined #bitcoin-core-dev
3002019-07-16T15:53:44  *** Krellan_ has joined #bitcoin-core-dev
3012019-07-16T15:59:00  *** etwert has joined #bitcoin-core-dev
3022019-07-16T16:06:45  *** scoop has quit IRC
3032019-07-16T16:08:28  *** sfhi has joined #bitcoin-core-dev
3042019-07-16T16:12:29  *** cubancorona has quit IRC
3052019-07-16T16:12:41  *** Krellan_ has quit IRC
3062019-07-16T16:13:08  *** Krellan has joined #bitcoin-core-dev
3072019-07-16T16:17:43  *** Krellan has quit IRC
3082019-07-16T16:17:51  <stevenroose> promag, sipa: someone familiar with importmulti? I have a descriptor `wpkh(xpub..../0)` that I want to import. So that I (1) watch the address, (2) see the balance, (3) use it for coin selection in fundraw.
3092019-07-16T16:18:06  <stevenroose> I'm reading: "If using descriptor, do not also provide address/scriptPubKey, scripts, or pubkeys"
3102019-07-16T16:18:36  <stevenroose> When I don't provide `scriptPubKey`, I'm getting the "Invalid scriptPubkey" error.
3112019-07-16T16:19:11  <stevenroose> When I do provide it (`{"address": "<derived p2wpkh address>"}`), the outputs for it stay `solvable: false`..
3122019-07-16T16:20:18  <sipa> stevenroose: what version of bitcoin core?
3132019-07-16T16:20:24  <stevenroose> 0.17.1
3142019-07-16T16:20:30  <stevenroose> sorry, that's probably relevant.
3152019-07-16T16:20:47  <stevenroose> but my cites from the docs are from master
3162019-07-16T16:21:13  <sipa> given that descriptor imports were only added in 0.18, that is relevant yes :)
3172019-07-16T16:21:46  <sipa> if you want to use the pre-descriptor importmulti you'll need to provide the public key explicitly
3182019-07-16T16:21:58  <sipa> and do it separately for each address imported
3192019-07-16T16:22:10  <sipa> or use importpubkey
3202019-07-16T16:22:18  <stevenroose> Oh really is "desc" just silently ignored? Yeah whoops that makes sense for the invalid scriptPubKey :D
3212019-07-16T16:22:41  <sipa> yes
3222019-07-16T16:23:19  <stevenroose> So now I did {"scriptPubKey":{"address":"bc1.."}, "pubkeys":["<the pubkey>"]} and I'm getting consistency check failed
3232019-07-16T16:23:51  <sipa> there were many bugs in importmulti before it was overhauled in 0.18
3242019-07-16T16:24:13  <stevenroose> hmm, k so I'll probably go with importpublickey for now then
3252019-07-16T16:24:30  <sipa> what is the pubkey you're importing if i can ask?
3262019-07-16T16:24:39  <stevenroose> I just don't really like that you can't force only indexing p2wpkh
3272019-07-16T16:24:52  <stevenroose> Just a pubkey from the path.
3282019-07-16T16:25:11  <stevenroose> We want Core to do coin control for us, while keeping the derivation outside of the node.
3292019-07-16T16:25:14  <sipa> stevenroose: yes, that's a huge shortcoming... but we need a pretty big internal change before we can support that
3302019-07-16T16:25:27  <stevenroose> So we have the xpriv and whenever a new address is requested, we put the address in Core.
3312019-07-16T16:25:28  <sipa> descriptor wallets will do that
3322019-07-16T16:26:02  <sipa> even in 0.18 with descriptor importmulti it'll effectively also import other address formats for the same key
3332019-07-16T16:26:09  <stevenroose> So with importpublickey instead of importaddress, people can send to the p2pkh scriptpubkey and Core will think it's ours, coin select it and we'll fail signing it
3342019-07-16T16:26:25  <sipa> yup
3352019-07-16T16:26:56  <stevenroose> I mean we could have logic that checks for that, but Core doesn't have "drop this utxo" logic, so Core will keep selecting the output.
3362019-07-16T16:27:01  <stevenroose> Ah we could lock it with lockunspent
3372019-07-16T16:27:05  <sipa> yeah
3382019-07-16T16:27:14  *** scoop has joined #bitcoin-core-dev
3392019-07-16T16:37:54  *** emilengler has quit IRC
3402019-07-16T16:43:57  *** etwert has quit IRC
3412019-07-16T16:46:33  *** michaelfolkson has joined #bitcoin-core-dev
3422019-07-16T16:47:09  *** scoop has quit IRC
3432019-07-16T16:47:36  *** scoop has joined #bitcoin-core-dev
3442019-07-16T16:48:40  *** bitcoin-git has joined #bitcoin-core-dev
3452019-07-16T16:48:42  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8f9725c83f1d...8f604361ebaa
3462019-07-16T16:48:42  <bitcoin-git> bitcoin/master 613c46f James O'Beirne: refactoring: move block metadata structures into BlockManager
3472019-07-16T16:48:43  <bitcoin-git> bitcoin/master 4ed55df James O'Beirne: refactoring: add block_index_candidates arg to LoadBlockIndex
3482019-07-16T16:48:44  <bitcoin-git> bitcoin/master 55d525a James O'Beirne: refactoring: make pindexBestInvalid internal to validation.cpp
3492019-07-16T16:48:46  *** bitcoin-git has left #bitcoin-core-dev
3502019-07-16T16:48:47  <promag> stevenroose: don't forget to unlock if you end up not using them
3512019-07-16T16:49:14  *** Krellan has joined #bitcoin-core-dev
3522019-07-16T16:49:35  *** bitcoin-git has joined #bitcoin-core-dev
3532019-07-16T16:49:36  <bitcoin-git> [bitcoin] laanwj merged pull request #16194: refactor: share blockmetadata with BlockManager (master...2019-06-au-blockman) https://github.com/bitcoin/bitcoin/pull/16194
3542019-07-16T16:49:37  *** bitcoin-git has left #bitcoin-core-dev
3552019-07-16T16:49:38  *** lnostdal has quit IRC
3562019-07-16T16:51:42  *** scoop has quit IRC
3572019-07-16T16:53:55  *** Krellan has quit IRC
3582019-07-16T16:54:06  *** jungly has quit IRC
3592019-07-16T17:05:34  *** michaelfolkson has quit IRC
3602019-07-16T17:31:27  *** Krellan has joined #bitcoin-core-dev
3612019-07-16T17:35:55  *** bitcoin-git has joined #bitcoin-core-dev
3622019-07-16T17:35:55  <bitcoin-git> [bitcoin] fjahr opened pull request #16399: wallet: Improve wallet creation (master...followup-16244) https://github.com/bitcoin/bitcoin/pull/16399
3632019-07-16T17:35:58  *** bitcoin-git has left #bitcoin-core-dev
3642019-07-16T17:37:16  *** timothy has quit IRC
3652019-07-16T17:37:38  *** Krellan has quit IRC
3662019-07-16T17:59:30  *** queip has quit IRC
3672019-07-16T18:00:02  *** pcmanus1 has quit IRC
3682019-07-16T18:07:09  *** queip has joined #bitcoin-core-dev
3692019-07-16T18:08:42  *** davterra has quit IRC
3702019-07-16T18:12:26  *** promag has quit IRC
3712019-07-16T18:13:59  *** jarthur has joined #bitcoin-core-dev
3722019-07-16T18:17:37  *** evanpro1 has joined #bitcoin-core-dev
3732019-07-16T18:18:23  *** queip has quit IRC
3742019-07-16T18:24:55  *** queip has joined #bitcoin-core-dev
3752019-07-16T18:25:06  *** spaced0ut has quit IRC
3762019-07-16T18:28:02  *** rh0nj has quit IRC
3772019-07-16T18:29:07  *** rh0nj has joined #bitcoin-core-dev
3782019-07-16T18:29:55  *** Krellan has joined #bitcoin-core-dev
3792019-07-16T18:31:54  *** tynes_ has joined #bitcoin-core-dev
3802019-07-16T18:32:40  *** tynes has quit IRC
3812019-07-16T18:33:05  *** zivl has joined #bitcoin-core-dev
3822019-07-16T18:35:18  *** Krellan has quit IRC
3832019-07-16T18:41:01  *** obsrver has quit IRC
3842019-07-16T18:51:35  *** pinheadmz has joined #bitcoin-core-dev
3852019-07-16T18:52:18  *** jarthur_ has joined #bitcoin-core-dev
3862019-07-16T18:55:02  *** jarthur has quit IRC
3872019-07-16T18:56:14  *** etwert has joined #bitcoin-core-dev
3882019-07-16T19:09:22  *** owowo has quit IRC
3892019-07-16T19:12:34  *** farmerwampum has quit IRC
3902019-07-16T19:14:15  *** owowo has joined #bitcoin-core-dev
3912019-07-16T19:25:59  *** farmerwampum has joined #bitcoin-core-dev
3922019-07-16T19:27:39  *** lnostdal has joined #bitcoin-core-dev
3932019-07-16T19:38:46  *** scoop has joined #bitcoin-core-dev
3942019-07-16T19:39:03  *** Kvaciral has joined #bitcoin-core-dev
3952019-07-16T19:39:10  *** csknk has quit IRC
3962019-07-16T19:40:12  *** scoop has quit IRC
3972019-07-16T19:42:07  *** scoop has joined #bitcoin-core-dev
3982019-07-16T19:57:21  *** adiabat has quit IRC
3992019-07-16T20:11:03  *** bitcoin-git has joined #bitcoin-core-dev
4002019-07-16T20:11:03  <bitcoin-git> [bitcoin] hebasto closed pull request #16389: Early "-" check for bitcoin-tx using stdin in ParseParameters() (master...20190714-short-parse-tx) https://github.com/bitcoin/bitcoin/pull/16389
4012019-07-16T20:11:04  *** bitcoin-git has left #bitcoin-core-dev
4022019-07-16T20:12:13  *** bitcoin-git has joined #bitcoin-core-dev
4032019-07-16T20:12:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8f604361ebaa...24dbcf380844
4042019-07-16T20:12:14  <bitcoin-git> bitcoin/master fa613ca MarcoFalke: chainparams: Remove unused fMineBlocksOnDemand
4052019-07-16T20:12:15  <bitcoin-git> bitcoin/master fa9b419 MarcoFalke: test: Add test that mainnet requires standard txs
4062019-07-16T20:12:16  <bitcoin-git> bitcoin/master fa89bad MarcoFalke: test: Require standard txs in regtest
4072019-07-16T20:12:17  *** bitcoin-git has left #bitcoin-core-dev
4082019-07-16T20:13:06  *** bitcoin-git has joined #bitcoin-core-dev
4092019-07-16T20:13:06  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #15891: test: Require standard txs in regtest by default (master...1904-testRequireStandard) https://github.com/bitcoin/bitcoin/pull/15891
4102019-07-16T20:13:07  *** bitcoin-git has left #bitcoin-core-dev
4112019-07-16T20:15:49  *** hebasto has quit IRC
4122019-07-16T20:16:11  *** bitcoin-git has joined #bitcoin-core-dev
4132019-07-16T20:16:11  <bitcoin-git> [bitcoin] sdaftuar opened pull request #16400: [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts (master...2019-07-refactor-atmp) https://github.com/bitcoin/bitcoin/pull/16400
4142019-07-16T20:16:18  *** bitcoin-git has left #bitcoin-core-dev
4152019-07-16T20:16:36  *** bitcoin-git has joined #bitcoin-core-dev
4162019-07-16T20:16:36  <bitcoin-git> [bitcoin] sdaftuar opened pull request #16401: Package relay (master...2019-07-package-relay) https://github.com/bitcoin/bitcoin/pull/16401
4172019-07-16T20:16:40  *** bitcoin-git has left #bitcoin-core-dev
4182019-07-16T20:26:16  *** bitcoin-git has joined #bitcoin-core-dev
4192019-07-16T20:26:16  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16402: Remove wallet settings from chainparams (master...1907-walletNoChainParams) https://github.com/bitcoin/bitcoin/pull/16402
4202019-07-16T20:26:19  *** bitcoin-git has left #bitcoin-core-dev
4212019-07-16T20:28:52  *** sfhi has quit IRC
4222019-07-16T20:29:00  *** jb55 has quit IRC
4232019-07-16T20:29:30  *** jb55 has joined #bitcoin-core-dev
4242019-07-16T20:29:52  *** jb55 has quit IRC
4252019-07-16T20:30:35  *** Krellan has joined #bitcoin-core-dev
4262019-07-16T20:32:20  *** jb55 has joined #bitcoin-core-dev
4272019-07-16T20:33:06  *** queip has quit IRC
4282019-07-16T20:35:16  *** Krellan has quit IRC
4292019-07-16T20:35:50  *** michaelfolkson has joined #bitcoin-core-dev
4302019-07-16T20:38:33  *** queip has joined #bitcoin-core-dev
4312019-07-16T20:42:36  *** justanotheruser has quit IRC
4322019-07-16T20:46:26  *** Guyver2 has quit IRC
4332019-07-16T20:47:24  *** michaelfolkson has quit IRC
4342019-07-16T20:47:38  *** Krellan has joined #bitcoin-core-dev
4352019-07-16T20:47:58  *** michaelfolkson has joined #bitcoin-core-dev
4362019-07-16T20:50:12  *** michaelfolkson has quit IRC
4372019-07-16T20:50:53  *** schnerchi has joined #bitcoin-core-dev
4382019-07-16T20:53:56  *** michaelfolkson has joined #bitcoin-core-dev
4392019-07-16T21:00:01  *** evanpro1 has quit IRC
4402019-07-16T21:01:03  *** schnerchi has quit IRC
4412019-07-16T21:03:03  *** arubi has quit IRC
4422019-07-16T21:03:34  *** arubi has joined #bitcoin-core-dev
4432019-07-16T21:08:31  *** jarthur_ has quit IRC
4442019-07-16T21:08:59  *** jarthur has joined #bitcoin-core-dev
4452019-07-16T21:16:18  *** jarthur_ has joined #bitcoin-core-dev
4462019-07-16T21:19:12  *** jarthur has quit IRC
4472019-07-16T21:21:14  *** kwm1 has joined #bitcoin-core-dev
4482019-07-16T21:28:19  *** justanotheruser has joined #bitcoin-core-dev
4492019-07-16T21:34:09  *** Aaronvan_ has joined #bitcoin-core-dev
4502019-07-16T21:35:57  *** AaronvanW has quit IRC
4512019-07-16T21:43:04  *** Aaronvan_ is now known as AaronvanW
4522019-07-16T21:43:16  *** IGHOR has quit IRC
4532019-07-16T21:50:04  *** IGHOR has joined #bitcoin-core-dev
4542019-07-16T21:50:28  *** IGHOR has quit IRC
4552019-07-16T21:52:26  *** IGHOR has joined #bitcoin-core-dev
4562019-07-16T21:55:44  *** michaelfolkson has quit IRC
4572019-07-16T21:58:01  *** enigmisto has joined #bitcoin-core-dev
4582019-07-16T22:00:42  *** michaelfolkson has joined #bitcoin-core-dev
4592019-07-16T22:17:05  *** michaelsdunn1 has quit IRC
4602019-07-16T22:18:02  <enigmisto> Where is the source code for how the nodes discover the "true" chain with the most proof of work?
4612019-07-16T22:19:21  <tryphe> enigmisto, the one with the longest cumulative work has the most work
4622019-07-16T22:19:42  <tryphe> longest/biggest
4632019-07-16T22:20:09  <sipa> enigmisto: really, it discovers all chains
4642019-07-16T22:20:14  <sipa> and then tries to validate the best one
4652019-07-16T22:20:32  *** justanotheruser has quit IRC
4662019-07-16T22:20:46  <sipa> hard to point to exactly the source code for that; it's combination of p2p logic, consensus validation, and headers processing
4672019-07-16T22:20:54  *** jarthur_ has quit IRC
4682019-07-16T22:21:20  *** jarthur has joined #bitcoin-core-dev
4692019-07-16T22:23:16  <enigmisto> I'm concerned there may be a denial of service vector where a node lies that they have a chain with most cumulative work, and forms the chain in a way that is computationally intensive to prove wrong.
4702019-07-16T22:24:23  <enigmisto> For example, make a chain with hundreds of millions of blocks, each with a valid shallow proof of work, lie about the total they'll see when they get to to the end.
4712019-07-16T22:25:43  <enigmisto> I assume I'm not the first person to think of that attack, so presumably there's some protection against it, but I'd like to understand it better.
4722019-07-16T22:26:11  <sipa> basically that protection is checkpoints (unfortunately)
4732019-07-16T22:26:31  <sipa> you can't branch off before the last checkpoints (which is now years old, but still sufficient for this purpose)
4742019-07-16T22:26:55  <sipa> which means that every individual block must start with a large number of blocks that each have PoW as was required at the time
4752019-07-16T22:27:36  <sipa> there won't be any actual validation however, until you have actually a chain of headers that exceed the known best chain's pow
4762019-07-16T22:27:42  <sipa> the blocks won't even be downloaded
4772019-07-16T22:27:51  <sipa> but the headers would be, if not for this protection
4782019-07-16T22:28:23  <enigmisto> I see. Thanks for the explanation.
4792019-07-16T22:29:20  <sipa> yw
4802019-07-16T22:46:15  *** ezegom has joined #bitcoin-core-dev
4812019-07-16T22:56:29  *** nijak has joined #bitcoin-core-dev
4822019-07-16T22:59:52  *** nijak_ has quit IRC
4832019-07-16T23:09:46  *** peleion has joined #bitcoin-core-dev
4842019-07-16T23:13:22  *** queip has quit IRC
4852019-07-16T23:19:10  *** queip has joined #bitcoin-core-dev
4862019-07-16T23:20:02  *** d3spwn has quit IRC
4872019-07-16T23:23:09  *** michaelfolkson has quit IRC
4882019-07-16T23:31:52  *** d3spwn has joined #bitcoin-core-dev
4892019-07-16T23:43:42  *** scoop has quit IRC
4902019-07-16T23:50:00  *** promag has joined #bitcoin-core-dev
4912019-07-16T23:50:49  <promag> fanquake: don't forget about #16296 #16306 :D
4922019-07-16T23:50:50  <gribble> https://github.com/bitcoin/bitcoin/issues/16296 | gui: crash with loadwallet & QT_FATAL_WARNINGS · Issue #16296 · bitcoin/bitcoin · GitHub
4932019-07-16T23:50:51  <gribble> https://github.com/bitcoin/bitcoin/issues/16306 | gui: crash in Console after loading & unloading wallet · Issue #16306 · bitcoin/bitcoin · GitHub
4942019-07-16T23:55:34  <fanquake> promag: can have a go at reproducing today. They are somewhat sporadic.
4952019-07-16T23:59:40  *** promag has quit IRC