1 2019-07-23T00:00:01  *** flamingspinach has quit IRC
  2 2019-07-23T00:00:08  *** lukedashjr has joined #bitcoin-core-dev
  3 2019-07-23T00:03:12  *** luke-jr has quit IRC
  4 2019-07-23T00:04:14  *** lukedashjr is now known as luke-jr
  5 2019-07-23T00:04:40  *** kutio has joined #bitcoin-core-dev
  6 2019-07-23T00:17:11  *** luke-jr has quit IRC
  7 2019-07-23T00:17:30  *** luke-jr has joined #bitcoin-core-dev
  8 2019-07-23T00:20:19  *** bitcoin-git has joined #bitcoin-core-dev
  9 2019-07-23T00:20:19  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16438: travis: Print memory and number of cpus (master...1907-travisFreeProc) https://github.com/bitcoin/bitcoin/pull/16438
 10 2019-07-23T00:20:29  *** bitcoin-git has left #bitcoin-core-dev
 11 2019-07-23T00:20:49  *** bitcoin-git has joined #bitcoin-core-dev
 12 2019-07-23T00:20:49  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16438: travis: Print memory and number of cpus (master...1907-travisFreeProc) https://github.com/bitcoin/bitcoin/pull/16438
 13 2019-07-23T00:20:50  *** bitcoin-git has left #bitcoin-core-dev
 14 2019-07-23T00:21:17  *** AaronvanW has quit IRC
 15 2019-07-23T00:22:02  *** ptiyoyip has quit IRC
 16 2019-07-23T00:26:32  *** pinheadmz_ has joined #bitcoin-core-dev
 17 2019-07-23T00:27:07  *** pinheadmz has quit IRC
 18 2019-07-23T00:27:07  *** pinheadmz_ is now known as pinheadmz
 19 2019-07-23T00:29:45  *** pinheadmz has quit IRC
 20 2019-07-23T00:31:41  *** IGHOR has quit IRC
 21 2019-07-23T00:32:11  *** Relis has quit IRC
 22 2019-07-23T00:32:53  *** Relis has joined #bitcoin-core-dev
 23 2019-07-23T00:33:34  *** IGHOR has joined #bitcoin-core-dev
 24 2019-07-23T00:52:02  <elichai2> sipa: FYI https://github.com/rust-bitcoin/rust-secp256k1/pull/132 from my very non serious benchmarks it seem to be 10-15 precent faster in verification
 25 2019-07-23T00:53:13  <sipa> yeah, seems expected
 26 2019-07-23T00:53:26  <sipa> libsecp256 benchmarks show something similar
 27 2019-07-23T00:57:00  *** laptop500 has quit IRC
 28 2019-07-23T00:57:42  <fanquake> So is Travis always meant to give us 2 cores per build, or does it just flip a coin to pick between 1 or 2 cores.
 29 2019-07-23T00:58:05  <fanquake> Maybe I'm misunderstanding how it's setup: https://github.com/bitcoin/bitcoin/pull/16438#issuecomment-514010659
 30 2019-07-23T01:06:05  *** pinheadmz has joined #bitcoin-core-dev
 31 2019-07-23T01:11:18  *** promag has quit IRC
 32 2019-07-23T01:12:03  *** promag has joined #bitcoin-core-dev
 33 2019-07-23T01:17:51  *** davterra has joined #bitcoin-core-dev
 34 2019-07-23T01:18:09  *** DeanWeen has joined #bitcoin-core-dev
 35 2019-07-23T01:22:08  *** davterra has quit IRC
 36 2019-07-23T01:22:28  *** liberiga has quit IRC
 37 2019-07-23T01:23:14  *** Relis has quit IRC
 38 2019-07-23T01:28:32  *** bitcoin-git has joined #bitcoin-core-dev
 39 2019-07-23T01:28:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/51a6e2c41929...67737cf22aee
 40 2019-07-23T01:28:33  <bitcoin-git> bitcoin/master fa4010e MarcoFalke: travis: Print memory and number of cpus
 41 2019-07-23T01:28:33  <bitcoin-git> bitcoin/master 67737cf MarcoFalke: Merge #16438: travis: Print memory and number of cpus
 42 2019-07-23T01:28:35  *** bitcoin-git has left #bitcoin-core-dev
 43 2019-07-23T01:29:42  *** bitcoin-git has joined #bitcoin-core-dev
 44 2019-07-23T01:29:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16438: travis: Print memory and number of cpus (master...1907-travisFreeProc) https://github.com/bitcoin/bitcoin/pull/16438
 45 2019-07-23T01:29:43  *** bitcoin-git has left #bitcoin-core-dev
 46 2019-07-23T01:30:12  *** liberiga has joined #bitcoin-core-dev
 47 2019-07-23T01:33:26  *** pinheadmz has quit IRC
 48 2019-07-23T01:33:59  *** pinheadmz has joined #bitcoin-core-dev
 49 2019-07-23T01:38:52  *** Relis has joined #bitcoin-core-dev
 50 2019-07-23T01:53:27  *** pinheadmz has quit IRC
 51 2019-07-23T01:53:30  <fanquake> Raystonn: I'm working on porting one of our C based tools to Rust. The library (libdmg-hfsplus) is unmaintained, and broken such that we need to use genisoimage to first create an ISO, then convert that to a DMG.
 52 2019-07-23T01:53:36  <fanquake> Ideally we can replace both with a single tool. It'd also mean we can drop some of our "hacks" and generate DMGs closer to what you'd expect to see out of hdiutil.
 53 2019-07-23T02:00:08  *** pinheadmz has joined #bitcoin-core-dev
 54 2019-07-23T02:00:41  *** davterra has joined #bitcoin-core-dev
 55 2019-07-23T02:01:46  <fanquake> ariard: would you like anything put into high-priority? One of the base PRs for some of your locking changes?
 56 2019-07-23T02:08:33  *** rex4539 has quit IRC
 57 2019-07-23T02:10:26  <ariard> fanquake: hey, #15713 has already been reviewed a lot by jnewbery, I think it's ready for another round, that's the first step for the locking changes
 58 2019-07-23T02:10:29  <gribble> https://github.com/bitcoin/bitcoin/issues/15713 | refactor: Replace chain relayTransactions/submitMemoryPool by higher method by ariard · Pull Request #15713 · bitcoin/bitcoin · GitHub
 59 2019-07-23T02:10:32  *** liberiga has quit IRC
 60 2019-07-23T02:13:31  <luke-jr> fanquake: so now we'd need to build a Rust compiler instead? I'm not sure that's an improvement
 61 2019-07-23T02:15:17  *** liberiga has joined #bitcoin-core-dev
 62 2019-07-23T02:28:49  *** Relis has quit IRC
 63 2019-07-23T02:32:33  *** kristapsk has quit IRC
 64 2019-07-23T02:32:34  *** DeanWeen has quit IRC
 65 2019-07-23T02:32:46  *** kristapsk has joined #bitcoin-core-dev
 66 2019-07-23T02:32:59  *** DeanWeen has joined #bitcoin-core-dev
 67 2019-07-23T02:34:30  *** pinheadmz has quit IRC
 68 2019-07-23T02:38:54  *** bitcoin-git has joined #bitcoin-core-dev
 69 2019-07-23T02:38:55  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67737cf22aee...ad4391ca384b
 70 2019-07-23T02:38:55  <bitcoin-git> bitcoin/master fa56b21 MarcoFalke: doc: Update bips 35, 37 and 111 status
 71 2019-07-23T02:38:56  <bitcoin-git> bitcoin/master ad4391c fanquake: Merge #16430: doc: Update bips 35, 37 and 111 status
 72 2019-07-23T02:38:57  *** bitcoin-git has left #bitcoin-core-dev
 73 2019-07-23T02:39:59  *** bitcoin-git has joined #bitcoin-core-dev
 74 2019-07-23T02:39:59  <bitcoin-git> [bitcoin] fanquake merged pull request #16430: doc: Update bips 35, 37 and 111 status (master...1907-docBips) https://github.com/bitcoin/bitcoin/pull/16430
 75 2019-07-23T02:40:12  *** bitcoin-git has left #bitcoin-core-dev
 76 2019-07-23T03:00:00  *** votesmith has quit IRC
 77 2019-07-23T03:00:01  *** kutio has quit IRC
 78 2019-07-23T03:04:01  *** funkatron has joined #bitcoin-core-dev
 79 2019-07-23T03:04:13  *** emilengler has quit IRC
 80 2019-07-23T03:06:03  *** votesmith has joined #bitcoin-core-dev
 81 2019-07-23T03:12:50  *** bitcoin-git has joined #bitcoin-core-dev
 82 2019-07-23T03:12:50  <bitcoin-git> [bitcoin] ajtowns opened pull request #16439: RPC: support "@height" in place of blockhash for getblock etc (master...201907-getblock-at-height) https://github.com/bitcoin/bitcoin/pull/16439
 83 2019-07-23T03:12:57  *** bitcoin-git has left #bitcoin-core-dev
 84 2019-07-23T03:15:04  *** emilengler has joined #bitcoin-core-dev
 85 2019-07-23T03:15:07  *** scoop_ has quit IRC
 86 2019-07-23T03:15:54  *** schnerch_ has joined #bitcoin-core-dev
 87 2019-07-23T03:17:03  *** pinheadmz has joined #bitcoin-core-dev
 88 2019-07-23T03:18:58  *** schnerchi has quit IRC
 89 2019-07-23T03:38:21  *** pinheadmz has quit IRC
 90 2019-07-23T03:39:46  *** davterra has quit IRC
 91 2019-07-23T03:40:38  *** Guest62 has joined #bitcoin-core-dev
 92 2019-07-23T03:41:54  *** molly has quit IRC
 93 2019-07-23T03:43:28  *** Guest62 has quit IRC
 94 2019-07-23T03:46:24  *** pinheadmz has joined #bitcoin-core-dev
 95 2019-07-23T03:47:20  *** pinheadmz has quit IRC
 96 2019-07-23T04:00:12  *** liberiga has quit IRC
 97 2019-07-23T04:00:51  *** nijak has quit IRC
 98 2019-07-23T04:01:22  *** nijak has joined #bitcoin-core-dev
 99 2019-07-23T04:03:45  <kallewoof> If I wanna turn a CKey into a CTxDestination, is ExtractDestination(GetScriptForRawPubKey(key.GetPubKey()), dest) the right approach? It looks weird, e.g. GetScriptForRawPubKey() gives a P2PK script...
100 2019-07-23T04:08:35  *** scoop has joined #bitcoin-core-dev
101 2019-07-23T04:10:38  <aj> kallewoof: GetAllDestinationsForKey() ?
102 2019-07-23T04:11:17  <kallewoof> aj: Ahh, nice. Thank you
103 2019-07-23T04:14:03  *** scoop has quit IRC
104 2019-07-23T04:14:31  *** jtimon has quit IRC
105 2019-07-23T04:14:50  *** scoop has joined #bitcoin-core-dev
106 2019-07-23T04:16:39  *** Honethe_ has joined #bitcoin-core-dev
107 2019-07-23T04:20:26  *** Honthe has quit IRC
108 2019-07-23T04:22:08  *** DeanWeen has quit IRC
109 2019-07-23T04:25:05  *** ppisati has quit IRC
110 2019-07-23T04:31:52  *** ppisati has joined #bitcoin-core-dev
111 2019-07-23T04:32:11  *** scoop has quit IRC
112 2019-07-23T04:32:51  *** scoop has joined #bitcoin-core-dev
113 2019-07-23T04:43:24  *** bitcoin-git has joined #bitcoin-core-dev
114 2019-07-23T04:43:25  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ad4391ca384b...848f245d04b6
115 2019-07-23T04:43:26  <bitcoin-git> bitcoin/master 4f050b9 James O'Beirne: move-onlyish: move CCoinsViewErrorCatcher out of init.cpp
116 2019-07-23T04:43:26  <bitcoin-git> bitcoin/master 848f245 fanquake: Merge #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp
117 2019-07-23T04:43:28  *** bitcoin-git has left #bitcoin-core-dev
118 2019-07-23T04:44:19  *** bitcoin-git has joined #bitcoin-core-dev
119 2019-07-23T04:44:19  <bitcoin-git> [bitcoin] fanquake merged pull request #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp (master...2019-07-au-coinscatcher) https://github.com/bitcoin/bitcoin/pull/16355
120 2019-07-23T04:44:20  *** bitcoin-git has left #bitcoin-core-dev
121 2019-07-23T05:13:11  <aj> fanquake: mind restarting https://travis-ci.org/bitcoin/bitcoin/builds/553802498 ?
122 2019-07-23T05:13:33  <fanquake> aj: done
123 2019-07-23T05:15:48  <aj> fanquake: thanks!
124 2019-07-23T05:16:52  *** hebasto has joined #bitcoin-core-dev
125 2019-07-23T05:31:12  *** elichai2 has quit IRC
126 2019-07-23T05:40:35  *** scoop has quit IRC
127 2019-07-23T05:41:11  *** scoop has joined #bitcoin-core-dev
128 2019-07-23T05:45:28  *** scoop has quit IRC
129 2019-07-23T06:00:02  *** funkatron has quit IRC
130 2019-07-23T06:04:11  *** alxgnon has joined #bitcoin-core-dev
131 2019-07-23T06:06:37  *** hebasto has quit IRC
132 2019-07-23T06:11:37  *** scoop has joined #bitcoin-core-dev
133 2019-07-23T06:16:02  *** scoop has quit IRC
134 2019-07-23T06:16:45  *** liberiga has joined #bitcoin-core-dev
135 2019-07-23T06:29:34  *** bitcoin-git has joined #bitcoin-core-dev
136 2019-07-23T06:29:34  <bitcoin-git> [bitcoin] kallewoof opened pull request #16440: BIP-322: Generic signed message format (master...feature-generic-signed-message-format) https://github.com/bitcoin/bitcoin/pull/16440
137 2019-07-23T06:29:37  *** bitcoin-git has left #bitcoin-core-dev
138 2019-07-23T07:07:58  *** bitcoin-git has joined #bitcoin-core-dev
139 2019-07-23T07:07:59  <bitcoin-git> [bitcoin] fanquake pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/848f245d04b6...e6e99d4f757f
140 2019-07-23T07:08:00  <bitcoin-git> bitcoin/master 1ec30b8 Carl Dong: depends: xproto is only directly needed by libXau
141 2019-07-23T07:08:00  <bitcoin-git> bitcoin/master 9a01ab0 Carl Dong: depends: qt: Explicitly stop using Xlib/libX11
142 2019-07-23T07:08:01  <bitcoin-git> bitcoin/master aa53cb7 Carl Dong: depends: libX11: Make package headers-only
143 2019-07-23T07:08:03  *** bitcoin-git has left #bitcoin-core-dev
144 2019-07-23T07:08:53  *** bitcoin-git has joined #bitcoin-core-dev
145 2019-07-23T07:08:53  <bitcoin-git> [bitcoin] fanquake merged pull request #16408: depends: Prune X packages (master...2019-07-depends-X-pruning) https://github.com/bitcoin/bitcoin/pull/16408
146 2019-07-23T07:08:56  *** bitcoin-git has left #bitcoin-core-dev
147 2019-07-23T07:20:26  *** emilengler has quit IRC
148 2019-07-23T07:20:26  *** DougieBot5000 has quit IRC
149 2019-07-23T07:20:32  *** DougieBot5000_ has joined #bitcoin-core-dev
150 2019-07-23T07:20:52  *** mr_burdell has quit IRC
151 2019-07-23T07:21:03  *** DougieBot5000_ is now known as DougieBot5000
152 2019-07-23T07:21:17  *** victorSN has quit IRC
153 2019-07-23T07:21:34  *** emilengler has joined #bitcoin-core-dev
154 2019-07-23T07:21:45  *** victorSN has joined #bitcoin-core-dev
155 2019-07-23T07:23:07  *** designwish has quit IRC
156 2019-07-23T07:23:08  *** shigeya has quit IRC
157 2019-07-23T07:23:09  <aj> fanquake: can you restart https://travis-ci.org/bitcoin/bitcoin/builds/553802498 again? :( :)
158 2019-07-23T07:23:19  *** mr_burdell has joined #bitcoin-core-dev
159 2019-07-23T07:23:49  <fanquake> aj: done again
160 2019-07-23T07:25:27  *** shigeya has joined #bitcoin-core-dev
161 2019-07-23T07:25:54  *** baldur has quit IRC
162 2019-07-23T07:31:31  *** davterra has joined #bitcoin-core-dev
163 2019-07-23T07:33:35  *** designwish has joined #bitcoin-core-dev
164 2019-07-23T07:37:47  *** jungly has joined #bitcoin-core-dev
165 2019-07-23T07:39:15  *** baldur has joined #bitcoin-core-dev
166 2019-07-23T07:40:45  *** scoop has joined #bitcoin-core-dev
167 2019-07-23T07:45:51  *** scoop has quit IRC
168 2019-07-23T07:51:19  *** kljasdfvv has quit IRC
169 2019-07-23T07:52:51  *** kljasdfvv has joined #bitcoin-core-dev
170 2019-07-23T07:55:07  *** mryandao has quit IRC
171 2019-07-23T07:55:29  *** mryandao has joined #bitcoin-core-dev
172 2019-07-23T07:58:19  *** bitcoin-git has joined #bitcoin-core-dev
173 2019-07-23T07:58:20  <bitcoin-git> [bitcoin] fanquake opened pull request #16441: Remove qt libjpeg check from bitcoin_qt.m4 (master...remove-qt-libjpeg-check) https://github.com/bitcoin/bitcoin/pull/16441
174 2019-07-23T07:58:21  *** bitcoin-git has left #bitcoin-core-dev
175 2019-07-23T08:01:46  *** setpill has joined #bitcoin-core-dev
176 2019-07-23T08:11:44  *** jb55 has quit IRC
177 2019-07-23T08:21:42  *** jb55 has joined #bitcoin-core-dev
178 2019-07-23T08:33:10  *** Relis has joined #bitcoin-core-dev
179 2019-07-23T08:38:42  *** Relis has quit IRC
180 2019-07-23T08:40:50  *** Relis has joined #bitcoin-core-dev
181 2019-07-23T08:42:24  *** promag has quit IRC
182 2019-07-23T08:42:38  *** promag has joined #bitcoin-core-dev
183 2019-07-23T08:44:36  *** AaronvanW has joined #bitcoin-core-dev
184 2019-07-23T09:00:02  *** alxgnon has quit IRC
185 2019-07-23T09:00:43  *** Aaronvan_ has joined #bitcoin-core-dev
186 2019-07-23T09:02:03  <promag> test only pull: #16404
187 2019-07-23T09:02:04  <gribble> https://github.com/bitcoin/bitcoin/issues/16404 | qa: Test ZMQ notification after chain reorg by promag · Pull Request #16404 · bitcoin/bitcoin · GitHub
188 2019-07-23T09:04:10  *** AaronvanW has quit IRC
189 2019-07-23T09:09:37  *** scoop has joined #bitcoin-core-dev
190 2019-07-23T09:14:18  *** scoop has quit IRC
191 2019-07-23T09:15:12  *** Relis has quit IRC
192 2019-07-23T09:16:20  *** dmlloyd_laptop has joined #bitcoin-core-dev
193 2019-07-23T09:19:23  *** timothy has joined #bitcoin-core-dev
194 2019-07-23T09:23:36  *** liberiga has quit IRC
195 2019-07-23T09:25:28  *** kristapsk has quit IRC
196 2019-07-23T09:29:27  *** laptop500 has joined #bitcoin-core-dev
197 2019-07-23T09:32:28  *** jungly has quit IRC
198 2019-07-23T09:34:45  *** jungly has joined #bitcoin-core-dev
199 2019-07-23T09:37:30  *** Emcy has quit IRC
200 2019-07-23T09:42:57  *** Emcy has joined #bitcoin-core-dev
201 2019-07-23T09:46:27  *** shtirlic has quit IRC
202 2019-07-23T09:47:50  *** shtirlic has joined #bitcoin-core-dev
203 2019-07-23T09:48:57  *** Relis has joined #bitcoin-core-dev
204 2019-07-23T09:49:13  *** Relis has left #bitcoin-core-dev
205 2019-07-23T10:16:22  *** Aaronvan_ is now known as AaronvanW
206 2019-07-23T10:25:27  *** jungly has quit IRC
207 2019-07-23T10:27:50  *** jungly has joined #bitcoin-core-dev
208 2019-07-23T10:33:31  *** Sentineo has quit IRC
209 2019-07-23T10:38:06  *** Sentineo has joined #bitcoin-core-dev
210 2019-07-23T10:59:52  *** Sentineo has quit IRC
211 2019-07-23T11:07:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
212 2019-07-23T11:21:16  *** promag has quit IRC
213 2019-07-23T11:22:00  *** promag has joined #bitcoin-core-dev
214 2019-07-23T11:22:06  *** harrigan has joined #bitcoin-core-dev
215 2019-07-23T11:27:01  *** promag has quit IRC
216 2019-07-23T11:27:14  *** promag has joined #bitcoin-core-dev
217 2019-07-23T11:28:55  *** hebasto has joined #bitcoin-core-dev
218 2019-07-23T11:44:17  *** Sentineo has joined #bitcoin-core-dev
219 2019-07-23T11:46:24  *** jonatack has joined #bitcoin-core-dev
220 2019-07-23T12:00:01  *** dmlloyd_laptop has quit IRC
221 2019-07-23T12:11:38  *** Chris_Stewart_5 has quit IRC
222 2019-07-23T12:13:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
223 2019-07-23T12:17:39  *** feedoo1 has joined #bitcoin-core-dev
224 2019-07-23T12:23:02  *** promag has quit IRC
225 2019-07-23T12:23:36  *** promag has joined #bitcoin-core-dev
226 2019-07-23T12:33:13  *** queip has quit IRC
227 2019-07-23T12:38:23  *** queip has joined #bitcoin-core-dev
228 2019-07-23T12:48:31  *** elichai2 has joined #bitcoin-core-dev
229 2019-07-23T12:50:45  *** Guyver2 has joined #bitcoin-core-dev
230 2019-07-23T12:59:17  *** jonatack has quit IRC
231 2019-07-23T13:07:36  *** jb55 has quit IRC
232 2019-07-23T13:11:54  *** Yukino has joined #bitcoin-core-dev
233 2019-07-23T13:14:00  *** jonatack has joined #bitcoin-core-dev
234 2019-07-23T13:20:40  *** promag has quit IRC
235 2019-07-23T13:20:54  *** promag has joined #bitcoin-core-dev
236 2019-07-23T13:22:33  *** spaced0ut has quit IRC
237 2019-07-23T13:24:32  *** dgfhdfg has joined #bitcoin-core-dev
238 2019-07-23T13:25:06  *** laptop500 has quit IRC
239 2019-07-23T13:26:22  *** spaced0ut has joined #bitcoin-core-dev
240 2019-07-23T13:27:49  *** Yukino has left #bitcoin-core-dev
241 2019-07-23T13:32:57  *** spaced0ut has quit IRC
242 2019-07-23T13:37:17  *** laptop500 has joined #bitcoin-core-dev
243 2019-07-23T13:37:26  *** michaelsdunn1 has joined #bitcoin-core-dev
244 2019-07-23T13:41:17  *** spaced0ut has joined #bitcoin-core-dev
245 2019-07-23T13:49:20  *** spaced0ut has quit IRC
246 2019-07-23T13:50:56  *** d_t has joined #bitcoin-core-dev
247 2019-07-23T13:52:26  *** promag has quit IRC
248 2019-07-23T13:53:15  *** promag has joined #bitcoin-core-dev
249 2019-07-23T13:53:26  *** lightlike has joined #bitcoin-core-dev
250 2019-07-23T13:55:26  *** d_t has quit IRC
251 2019-07-23T13:57:07  *** spaced0ut has joined #bitcoin-core-dev
252 2019-07-23T14:00:53  *** harrigan has quit IRC
253 2019-07-23T14:05:38  *** Chris_Stewart_5 has quit IRC
254 2019-07-23T14:14:22  *** michaelsdunn1 has quit IRC
255 2019-07-23T14:20:20  *** setpill has quit IRC
256 2019-07-23T14:20:36  *** instagibbs has quit IRC
257 2019-07-23T14:21:24  *** instagibbs has joined #bitcoin-core-dev
258 2019-07-23T14:25:12  *** michaelsdunn1 has joined #bitcoin-core-dev
259 2019-07-23T14:30:28  *** captjakk has quit IRC
260 2019-07-23T14:39:38  *** davterra has quit IRC
261 2019-07-23T14:49:07  *** davterra has joined #bitcoin-core-dev
262 2019-07-23T14:59:00  *** nijak_ has joined #bitcoin-core-dev
263 2019-07-23T15:00:01  *** feedoo1 has quit IRC
264 2019-07-23T15:00:03  *** nijak has quit IRC
265 2019-07-23T15:02:14  *** michaelsdunn1 has quit IRC
266 2019-07-23T15:04:36  *** Guyver2 has quit IRC
267 2019-07-23T15:04:38  *** modi123_1 has joined #bitcoin-core-dev
268 2019-07-23T15:18:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
269 2019-07-23T15:20:03  *** TheRec has quit IRC
270 2019-07-23T15:21:33  *** TheRec has joined #bitcoin-core-dev
271 2019-07-23T15:21:33  *** TheRec has joined #bitcoin-core-dev
272 2019-07-23T15:28:02  *** emilengler has quit IRC
273 2019-07-23T15:28:16  *** emilengler has joined #bitcoin-core-dev
274 2019-07-23T15:31:36  *** shtirlic has quit IRC
275 2019-07-23T15:32:56  *** shtirlic has joined #bitcoin-core-dev
276 2019-07-23T15:39:37  *** emilengler has quit IRC
277 2019-07-23T15:42:27  *** emilengler has joined #bitcoin-core-dev
278 2019-07-23T15:50:07  *** liberiga has joined #bitcoin-core-dev
279 2019-07-23T15:50:52  *** Emilstud has joined #bitcoin-core-dev
280 2019-07-23T15:52:55  <Raystonn> fanquake: Just saw the message regarding the port of libdmg-hfsplus to rust.  That's great.  Are there any other tools or other unmaintained modules that you think could use the same treatment?  I'm tempted to port everything to rust just to see what flaws it can help us find in Core.  But so much work in a complex moving target.
281 2019-07-23T15:53:23  *** emilengler has quit IRC
282 2019-07-23T15:56:28  *** Emilstud has quit IRC
283 2019-07-23T16:09:04  *** dviola has joined #bitcoin-core-dev
284 2019-07-23T16:31:22  <ryanofsky> dongcarl, wumpus: question about bip-0155. I don't see a size field. So if we add a new network type, and serialize a list of addresses, can old software deserialize the full list and only ignore new addresses?
285 2019-07-23T16:32:31  <dongcarl> ryanofsky: From my understanding we're not going to send addrv2 messages to old peers
286 2019-07-23T16:35:50  <ryanofsky> by "old software" i mean software that understands addrv2, but doesn't understand new address types that we could add later
287 2019-07-23T16:37:01  <ryanofsky> if there's a size field, that software could skip unknown address types in a list and ignore them. question is if that's possible in the proposal without a size field
288 2019-07-23T16:37:34  *** rex4539 has joined #bitcoin-core-dev
289 2019-07-23T16:37:35  *** dviola has quit IRC
290 2019-07-23T16:38:25  <sipa> oh, i assumed there was some form of size field
291 2019-07-23T16:39:26  <sipa> ryanofsky: addr is serialized as a byte vector
292 2019-07-23T16:39:33  <sipa> which has an implicit length byte
293 2019-07-23T16:40:44  <ryanofsky> ah, missed that part, thanks
294 2019-07-23T16:41:06  *** Chris_Stewart_5 has quit IRC
295 2019-07-23T16:41:30  <ryanofsky> and i see dongcarl basically asked the opposite question yesterday. just catching up now
296 2019-07-23T16:41:51  *** timothy has quit IRC
297 2019-07-23T16:43:53  <dongcarl> I think the "size" can be specified either at the addr-field level (as in the spec) or at the "address"-level... I'll try both out when implementing and see which one is simpler. If people have a preference with a rationale that would also be nice
298 2019-07-23T16:44:22  <dongcarl> s/"address"/"address-entry"/
299 2019-07-23T16:46:40  *** reallll has joined #bitcoin-core-dev
300 2019-07-23T16:47:17  <sipa> dongcarl: i suspect it's easiest as specified in the bip
301 2019-07-23T16:47:52  <sipa> just treat the addr field as a std::vector<uint8_t> and convert it from/to internal format
302 2019-07-23T16:48:44  <dongcarl> sipa: makes sense!
303 2019-07-23T16:49:16  *** bitcoin-git has joined #bitcoin-core-dev
304 2019-07-23T16:49:16  <bitcoin-git> [bitcoin] jimpo opened pull request #16442: Serve BIP 157 compact filters (master...bip157-net) https://github.com/bitcoin/bitcoin/pull/16442
305 2019-07-23T16:49:29  *** bitcoin-git has left #bitcoin-core-dev
306 2019-07-23T16:49:33  <ryanofsky> yeah, field level as specified is probably easier to implement. entry level probably doesn't have an advantage because there are already other fields that could be used to extend entry format in the future
307 2019-07-23T16:50:14  *** jarthur has joined #bitcoin-core-dev
308 2019-07-23T16:50:14  <ryanofsky> one thing i might change is "Network port. If not relevant for the network this MUST be 0."
309 2019-07-23T16:50:18  *** belcher has quit IRC
310 2019-07-23T16:51:25  <ryanofsky> if port is not relevant for the networkID, could just not serialize the port field
311 2019-07-23T16:51:44  <ryanofsky> but this would argue for entry-level rather than field-level size i guess...
312 2019-07-23T16:52:03  <sipa> yup, exactly
313 2019-07-23T16:54:08  *** reallll is now known as belcher
314 2019-07-23T16:55:58  <sipa> could also merge the port field into the address
315 2019-07-23T16:56:08  <sipa> with network type specific semantics on how to split them
316 2019-07-23T17:13:32  *** liberiga has quit IRC
317 2019-07-23T17:17:17  *** jb55 has joined #bitcoin-core-dev
318 2019-07-23T17:25:36  *** pinheadmz has joined #bitcoin-core-dev
319 2019-07-23T17:29:44  *** promag has quit IRC
320 2019-07-23T17:29:58  *** promag has joined #bitcoin-core-dev
321 2019-07-23T17:34:59  *** kljasdfvv has quit IRC
322 2019-07-23T17:42:28  <jnewbery> Is there any reason for CMerkleTx to exist (separate from CWalletTx)? It's been there since it was in main.cpp in the first git commit, but it's now in wallet.h and is _only_ used as the base class for CWalletTx, so it seems redundant.
323 2019-07-23T17:44:37  <sipa> it used to be the case that for every CWalletTx , a CMerkleTx was stoeea for each unconfirmed dependency or so
324 2019-07-23T17:44:46  <sipa> *stored
325 2019-07-23T17:45:44  <jnewbery> That doesn't seem to be the case any more
326 2019-07-23T17:46:31  <sipa> indeed; i believe they're redundant now
327 2019-07-23T17:48:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
328 2019-07-23T17:50:36  <jnewbery> yeah, looks like it was called vtxPrev, removed in 93a18a3650292afbb441a47d1fa1b94aeb0164e3
329 2019-07-23T17:51:12  <jnewbery> I guess we'd still need the deserialization logic, to be able to read old wallet files
330 2019-07-23T17:51:28  <sipa> oh, good point
331 2019-07-23T17:53:10  *** promag has quit IRC
332 2019-07-23T17:53:55  *** promag has joined #bitcoin-core-dev
333 2019-07-23T17:54:20  <jnewbery> but we could have a very small class with just serialize/deserialize functions and move all the other functions into CWalletTx
334 2019-07-23T17:56:58  <MarcoFalke> If you do that, it might be good to move it to ./primitives/ (see https://github.com/bitcoin/bitcoin/pull/5306#issuecomment-63618817)
335 2019-07-23T17:57:35  <MarcoFalke> Oh, maybe not, because it is only used by the wallet
336 2019-07-23T17:57:44  * MarcoFalke off
337 2019-07-23T18:00:02  *** modi123_1 has quit IRC
338 2019-07-23T18:00:48  <jnewbery> yeah, I imagine adding some class DummyMerkleTx or similar in wallet.h that just deals with [de]serialization, and moving all the actual CMerkleTx code into CWalletTx
339 2019-07-23T18:01:31  <jnewbery> (this is in the context of https://github.com/bitcoin/bitcoin/pull/15931/commits/827f65ba7a98bc1124a3483f42157df9db0975a7, in which some of those CMerkleTx functions require access to the CWallet class)
340 2019-07-23T18:02:29  <jnewbery> thanks for the pointers all
341 2019-07-23T18:04:46  <amiti> hi! I have been thinking about improvements to rebroadcast logic. Instead of nodes only rebroadcasting wallet txns, nodes will rebroadcast all txns it believes should have been in the last block. The goal is to improve privacy by making it harder to discern the transaction source.
342 2019-07-23T18:04:53  <amiti> For more details: https://gist.github.com/amitiuttarwar/b592ee410e1f02ac0d44fcbed4621dba
343 2019-07-23T18:05:12  <amiti> You can also see https://github.com/bitcoin/bitcoin/issues/15734 for more context.
344 2019-07-23T18:05:19  <amiti> Looking for critical feedback and concept ACKs. Thanks in advance !
345 2019-07-23T18:05:21  *** solirc has joined #bitcoin-core-dev
346 2019-07-23T18:05:41  <MarcoFalke> Concept ACK ;)
347 2019-07-23T18:17:26  *** Victor_sueca has quit IRC
348 2019-07-23T18:17:45  *** Victor_sueca has joined #bitcoin-core-dev
349 2019-07-23T18:20:28  *** Chris_Stewart_5 has quit IRC
350 2019-07-23T18:20:37  *** michaelsdunn1 has joined #bitcoin-core-dev
351 2019-07-23T18:23:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
352 2019-07-23T18:34:27  *** promag has quit IRC
353 2019-07-23T18:34:39  *** promag has joined #bitcoin-core-dev
354 2019-07-23T18:35:39  *** davterra has quit IRC
355 2019-07-23T18:40:08  *** Krellan has joined #bitcoin-core-dev
356 2019-07-23T18:43:20  <jonasschnelli> amiti: probably send that to the mailing list
357 2019-07-23T18:44:37  <jonasschnelli> although very Bitcoin Core specific... but probably ok
358 2019-07-23T18:45:29  <sipa> it may make sense to write a comprehensive "how bitcoin core does transaction broadcasting" for publishing once we've figured everything out
359 2019-07-23T18:45:39  <fanquake> Might be worth bringing up at the meeting?
360 2019-07-23T18:45:41  <sipa> i'm not sure it matters that much at this point
361 2019-07-23T18:45:44  <sipa> yeah
362 2019-07-23T18:46:41  <amiti> sipa: not sure what matters much?
363 2019-07-23T18:47:13  <sipa> amiti: getting mailinglist input at this point
364 2019-07-23T18:47:50  <amiti> gotcha
365 2019-07-23T18:48:26  <amiti> as per ryanofsky's comment on the issue, I'm thinking of posting a version of the gist to the dev wiki (https://github.com/bitcoin-core/bitcoin-devwiki/wiki) once its more figured out
366 2019-07-23T18:49:44  <gleb> 50 minutes ago I was not aware of bitcoin-devwiki :)
367 2019-07-23T18:50:40  <amiti> I'm happy to bring up at the meeting
368 2019-07-23T18:51:25  <amiti> gleb: yeah, looks like a thriving place =P
369 2019-07-23T18:51:52  <sipa> haha
370 2019-07-23T18:52:10  <fanquake> amiti: you can suggest a topic in here using #proposedmeetingtopic
371 2019-07-23T18:52:40  <amiti> #proposedmeetingtopic: Transaction Rebroadcasting https://gist.github.com/amitiuttarwar/b592ee410e1f02ac0d44fcbed4621dba
372 2019-07-23T18:54:19  *** davterra has joined #bitcoin-core-dev
373 2019-07-23T19:02:58  *** davterra has quit IRC
374 2019-07-23T19:03:42  *** liberiga has joined #bitcoin-core-dev
375 2019-07-23T19:03:47  *** davterra has joined #bitcoin-core-dev
376 2019-07-23T19:08:46  *** Entropy87 has joined #bitcoin-core-dev
377 2019-07-23T19:27:59  *** nijak has joined #bitcoin-core-dev
378 2019-07-23T19:28:07  *** bitcoin-git has joined #bitcoin-core-dev
379 2019-07-23T19:28:07  <bitcoin-git> [bitcoin] jamesob opened pull request #16443: refactor: have CCoins* data managed under CChainState (master...2019-07-au-coins-under-chainstate) https://github.com/bitcoin/bitcoin/pull/16443
380 2019-07-23T19:28:09  *** bitcoin-git has left #bitcoin-core-dev
381 2019-07-23T19:29:38  *** nijak_ has quit IRC
382 2019-07-23T19:30:39  *** lnostdal has quit IRC
383 2019-07-23T19:33:31  *** bitcoin-git has joined #bitcoin-core-dev
384 2019-07-23T19:33:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16437: Always connect NotifyEntryRemoved with MempoolEntryRemoved (master...1907-AlwaysNotifyMempoolEntryRemoved) https://github.com/bitcoin/bitcoin/pull/16437
385 2019-07-23T19:33:32  *** bitcoin-git has left #bitcoin-core-dev
386 2019-07-23T19:34:38  <promag> those on macos, how do you run guix? vm or docker container?
387 2019-07-23T19:39:14  <dongcarl> promag: I believe fanquake has been doing so on docker
388 2019-07-23T19:39:38  <dongcarl> promag: https://github.com/fanquake/core-review/tree/master/guix
389 2019-07-23T19:41:51  *** Aaronvan_ has joined #bitcoin-core-dev
390 2019-07-23T19:42:14  *** bitcoin-git has joined #bitcoin-core-dev
391 2019-07-23T19:42:14  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16400: [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts (master...2019-07-refactor-atmp) https://github.com/bitcoin/bitcoin/pull/16400
392 2019-07-23T19:42:28  *** bitcoin-git has left #bitcoin-core-dev
393 2019-07-23T19:42:44  *** bitcoin-git has joined #bitcoin-core-dev
394 2019-07-23T19:42:45  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16400: [refactor] Rewrite AcceptToMemoryPoolWorker() using smaller parts (master...2019-07-refactor-atmp) https://github.com/bitcoin/bitcoin/pull/16400
395 2019-07-23T19:42:53  *** bitcoin-git has left #bitcoin-core-dev
396 2019-07-23T19:43:39  <dongcarl> promag: Ping me if you run into any trouble
397 2019-07-23T19:43:57  <promag> dongcarl: thanks, for sure
398 2019-07-23T19:45:30  *** AaronvanW has quit IRC
399 2019-07-23T19:47:06  *** csknk has joined #bitcoin-core-dev
400 2019-07-23T19:47:19  *** csknk has quit IRC
401 2019-07-23T19:50:15  *** kristapsk has joined #bitcoin-core-dev
402 2019-07-23T19:53:51  *** Tinamu has joined #bitcoin-core-dev
403 2019-07-23T19:55:46  *** tripleslash has quit IRC
404 2019-07-23T19:56:03  *** tripleslash has joined #bitcoin-core-dev
405 2019-07-23T20:00:21  *** bitcoin-git has joined #bitcoin-core-dev
406 2019-07-23T20:00:21  <bitcoin-git> [bitcoin] fjahr opened pull request #16445: test: Skip flaky p2p_invalid_messages test on macOS (master...mac_test) https://github.com/bitcoin/bitcoin/pull/16445
407 2019-07-23T20:00:22  *** bitcoin-git has left #bitcoin-core-dev
408 2019-07-23T20:01:57  *** Tinamu has quit IRC
409 2019-07-23T20:02:00  *** nijak_ has joined #bitcoin-core-dev
410 2019-07-23T20:02:50  *** promag has quit IRC
411 2019-07-23T20:03:28  *** nijak has quit IRC
412 2019-07-23T20:03:37  *** promag has joined #bitcoin-core-dev
413 2019-07-23T20:14:53  *** Aaronvan_ is now known as AaronvanW
414 2019-07-23T20:26:16  *** Chris_Stewart_5 has quit IRC
415 2019-07-23T20:26:18  *** schnerch_ has quit IRC
416 2019-07-23T20:30:56  *** liberiga has quit IRC
417 2019-07-23T20:30:57  *** Victor_sueca is now known as Victorsueca
418 2019-07-23T20:33:44  *** laptop500 has quit IRC
419 2019-07-23T20:34:10  *** laptop500 has joined #bitcoin-core-dev
420 2019-07-23T20:48:21  *** farmerwampum has quit IRC
421 2019-07-23T20:57:48  *** schnerchi has joined #bitcoin-core-dev
422 2019-07-23T21:00:02  *** solirc has quit IRC
423 2019-07-23T21:03:19  *** farmerwampum has joined #bitcoin-core-dev
424 2019-07-23T21:04:26  *** rah1 has joined #bitcoin-core-dev
425 2019-07-23T21:06:43  *** bitcoin-git has joined #bitcoin-core-dev
426 2019-07-23T21:06:43  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16328: rpc: Tidy up reporting of buried and ongoing softforks (master...1907-rpcSoftforks) https://github.com/bitcoin/bitcoin/pull/16328
427 2019-07-23T21:06:46  *** bitcoin-git has left #bitcoin-core-dev
428 2019-07-23T21:06:53  *** lightlike has quit IRC
429 2019-07-23T21:07:09  *** captjakk has joined #bitcoin-core-dev
430 2019-07-23T21:21:43  *** farmerwampum has quit IRC
431 2019-07-23T21:21:53  *** lightlike has joined #bitcoin-core-dev
432 2019-07-23T21:24:22  *** EagleTM has joined #bitcoin-core-dev
433 2019-07-23T21:26:18  *** captjakk_ has joined #bitcoin-core-dev
434 2019-07-23T21:29:38  *** captjakk has quit IRC
435 2019-07-23T21:30:20  *** rh0nj has quit IRC
436 2019-07-23T21:31:29  *** promag has quit IRC
437 2019-07-23T21:31:43  *** promag has joined #bitcoin-core-dev
438 2019-07-23T21:37:06  *** farmerwampum has joined #bitcoin-core-dev
439 2019-07-23T21:39:03  *** nijak has joined #bitcoin-core-dev
440 2019-07-23T21:40:12  *** nijak_ has quit IRC
441 2019-07-23T21:59:21  *** gelmutshmidt has joined #bitcoin-core-dev
442 2019-07-23T22:09:16  <achow101> meshcollider: do you think #16301 is ready to merge yet?
443 2019-07-23T22:09:20  <gribble> https://github.com/bitcoin/bitcoin/issues/16301 | Use CWallet::Import* functions in all import* RPCs by achow101 · Pull Request #16301 · bitcoin/bitcoin · GitHub
444 2019-07-23T22:16:43  *** michaelsdunn1 has quit IRC
445 2019-07-23T22:22:31  <instagibbs> achow101, imo one more in depth ACK should do it?
446 2019-07-23T22:24:22  *** lnostdal has joined #bitcoin-core-dev
447 2019-07-23T22:25:05  <meshcollider> Yeah ^ it's very close but I'd like at least one more or a tested ack
448 2019-07-23T22:25:23  <meshcollider> I'll try and build and test later today
449 2019-07-23T22:30:47  *** jarthur has quit IRC
450 2019-07-23T22:32:07  *** rh0nj has joined #bitcoin-core-dev
451 2019-07-23T22:32:50  *** toto999 has joined #bitcoin-core-dev
452 2019-07-23T22:33:42  *** Tinamu has joined #bitcoin-core-dev
453 2019-07-23T22:34:31  *** Tinamu has left #bitcoin-core-dev
454 2019-07-23T22:35:00  *** Tinamu has joined #bitcoin-core-dev
455 2019-07-23T22:35:02  *** Tinamu has left #bitcoin-core-dev
456 2019-07-23T22:36:44  *** TheRec has quit IRC
457 2019-07-23T22:37:04  <fanquake> promag: yea all my test builds in the Guix PR were done using that Docker setup.
458 2019-07-23T22:37:39  *** TheRec has joined #bitcoin-core-dev
459 2019-07-23T22:38:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
460 2019-07-23T22:41:18  *** EagleTM has quit IRC
461 2019-07-23T22:43:56  *** promag has quit IRC
462 2019-07-23T22:44:04  *** bitcoin-git has joined #bitcoin-core-dev
463 2019-07-23T22:44:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e6e99d4f757f...67923d6b3c1e
464 2019-07-23T22:44:06  <bitcoin-git> bitcoin/master fad2502 MarcoFalke: init: Use InitError for all errors in bitcoind/qt
465 2019-07-23T22:44:07  <bitcoin-git> bitcoin/master fa6f402 Russell Yanofsky: Call node->initError instead of InitError from GUI code
466 2019-07-23T22:44:08  <bitcoin-git> bitcoin/master 67923d6 MarcoFalke: Merge #16366: init: Use InitError for all errors in bitcoind/qt
467 2019-07-23T22:44:10  *** bitcoin-git has left #bitcoin-core-dev
468 2019-07-23T22:44:12  *** Zenton has quit IRC
469 2019-07-23T22:44:44  *** promag has joined #bitcoin-core-dev
470 2019-07-23T22:45:04  *** bitcoin-git has joined #bitcoin-core-dev
471 2019-07-23T22:45:04  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16366: init: Use InitError for all errors in bitcoind/qt (master...1907-initErrorGui) https://github.com/bitcoin/bitcoin/pull/16366
472 2019-07-23T22:45:17  *** bitcoin-git has left #bitcoin-core-dev
473 2019-07-23T22:46:48  *** shesek has joined #bitcoin-core-dev
474 2019-07-23T22:49:38  *** Chris_Stewart_5 has quit IRC
475 2019-07-23T22:50:23  *** toto999 has quit IRC
476 2019-07-23T23:13:12  *** promag has quit IRC
477 2019-07-23T23:13:25  *** promag has joined #bitcoin-core-dev
478 2019-07-23T23:23:51  *** captjakk_ has quit IRC
479 2019-07-23T23:28:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
480 2019-07-23T23:31:16  *** lightlike has quit IRC
481 2019-07-23T23:42:46  *** Karyon has quit IRC
482 2019-07-23T23:44:23  *** promag has quit IRC
483 2019-07-23T23:44:26  *** Karyon has joined #bitcoin-core-dev
484 2019-07-23T23:45:06  *** promag has joined #bitcoin-core-dev
485 2019-07-23T23:49:45  *** AaronvanW has quit IRC