1 2019-07-24T00:00:02  *** rah1 has quit IRC
  2 2019-07-24T00:03:00  *** ptiyoyip has joined #bitcoin-core-dev
  3 2019-07-24T00:04:36  *** AntiSpamMeta has joined #bitcoin-core-dev
  4 2019-07-24T00:04:59  *** AntiSpamMeta is now known as Guest42475
  5 2019-07-24T00:05:52  *** ryufghj has joined #bitcoin-core-dev
  6 2019-07-24T00:06:58  *** dgfhdfg has quit IRC
  7 2019-07-24T00:09:51  *** ptiyoyip has quit IRC
  8 2019-07-24T00:12:12  *** captjakk has joined #bitcoin-core-dev
  9 2019-07-24T00:14:10  *** captjakk_ has joined #bitcoin-core-dev
 10 2019-07-24T00:14:10  *** captjakk has quit IRC
 11 2019-07-24T00:23:58  *** Karyon has quit IRC
 12 2019-07-24T00:24:25  *** Karyon has joined #bitcoin-core-dev
 13 2019-07-24T00:24:50  *** dgfhdfg has joined #bitcoin-core-dev
 14 2019-07-24T00:28:12  *** ryufghj has quit IRC
 15 2019-07-24T00:30:12  *** AaronvanW has joined #bitcoin-core-dev
 16 2019-07-24T00:34:42  *** AaronvanW has quit IRC
 17 2019-07-24T00:40:54  *** toto99 has joined #bitcoin-core-dev
 18 2019-07-24T00:42:44  *** laptop500 has quit IRC
 19 2019-07-24T00:50:58  *** captjakk_ has quit IRC
 20 2019-07-24T00:51:24  *** captjakk has joined #bitcoin-core-dev
 21 2019-07-24T00:52:54  *** captjakk has quit IRC
 22 2019-07-24T01:18:48  *** dgfhdfg has quit IRC
 23 2019-07-24T01:22:16  *** AaronvanW has joined #bitcoin-core-dev
 24 2019-07-24T01:38:11  *** elichai2 has quit IRC
 25 2019-07-24T01:40:11  *** toto99 has quit IRC
 26 2019-07-24T01:41:54  *** Chris_Stewart_5 has quit IRC
 27 2019-07-24T01:54:58  *** AaronvanW has quit IRC
 28 2019-07-24T02:28:46  *** DeanWeen has joined #bitcoin-core-dev
 29 2019-07-24T02:44:56  *** rex4539 has quit IRC
 30 2019-07-24T02:47:18  *** ghost43_ has joined #bitcoin-core-dev
 31 2019-07-24T02:47:44  *** ghost43 has quit IRC
 32 2019-07-24T02:48:56  *** sipa has quit IRC
 33 2019-07-24T02:49:24  *** sipa has joined #bitcoin-core-dev
 34 2019-07-24T03:00:02  *** Guest42475 has quit IRC
 35 2019-07-24T03:03:31  *** rob01 has joined #bitcoin-core-dev
 36 2019-07-24T03:07:19  *** pinheadmz has quit IRC
 37 2019-07-24T03:09:26  *** schnerch_ has joined #bitcoin-core-dev
 38 2019-07-24T03:09:54  *** pinheadmz has joined #bitcoin-core-dev
 39 2019-07-24T03:12:07  *** schnerchi has quit IRC
 40 2019-07-24T03:14:05  *** davterra has quit IRC
 41 2019-07-24T03:15:00  *** davterra has joined #bitcoin-core-dev
 42 2019-07-24T03:15:51  *** d_t has joined #bitcoin-core-dev
 43 2019-07-24T03:17:06  *** davterra has quit IRC
 44 2019-07-24T03:18:47  *** davterra has joined #bitcoin-core-dev
 45 2019-07-24T03:32:46  *** davterra has quit IRC
 46 2019-07-24T03:37:55  *** gelmutshmidt has quit IRC
 47 2019-07-24T03:42:22  *** elichai2 has joined #bitcoin-core-dev
 48 2019-07-24T03:52:13  *** AaronvanW has joined #bitcoin-core-dev
 49 2019-07-24T04:08:55  *** liberiga has joined #bitcoin-core-dev
 50 2019-07-24T04:11:06  *** pinheadmz has quit IRC
 51 2019-07-24T04:25:28  *** AaronvanW has quit IRC
 52 2019-07-24T04:50:17  *** d_t has quit IRC
 53 2019-07-24T05:07:32  *** liberiga has quit IRC
 54 2019-07-24T05:46:40  *** Krellan has quit IRC
 55 2019-07-24T05:47:07  *** Krellan has joined #bitcoin-core-dev
 56 2019-07-24T05:50:01  *** d_t has joined #bitcoin-core-dev
 57 2019-07-24T05:52:55  *** Krellan has quit IRC
 58 2019-07-24T05:59:28  *** yufryutf has joined #bitcoin-core-dev
 59 2019-07-24T06:00:01  *** rob01 has quit IRC
 60 2019-07-24T06:00:31  *** yufryutf has quit IRC
 61 2019-07-24T06:04:25  *** mg0314b has joined #bitcoin-core-dev
 62 2019-07-24T06:04:38  *** SRV_DW20 has joined #bitcoin-core-dev
 63 2019-07-24T06:09:56  *** mg0314b has quit IRC
 64 2019-07-24T06:16:55  *** d_t has quit IRC
 65 2019-07-24T06:21:28  *** mg0314b has joined #bitcoin-core-dev
 66 2019-07-24T06:23:02  *** AaronvanW has joined #bitcoin-core-dev
 67 2019-07-24T06:23:04  *** mg0314b_ has joined #bitcoin-core-dev
 68 2019-07-24T06:26:13  *** mg0314b has quit IRC
 69 2019-07-24T06:27:18  *** Krellan has joined #bitcoin-core-dev
 70 2019-07-24T06:30:13  *** mg0314b_ has quit IRC
 71 2019-07-24T06:31:09  *** mg0314b has joined #bitcoin-core-dev
 72 2019-07-24T06:32:42  *** Krellan has quit IRC
 73 2019-07-24T06:33:41  *** bitcoin-git has joined #bitcoin-core-dev
 74 2019-07-24T06:33:41  <bitcoin-git> [bitcoin] fanquake opened pull request #16448: doc: add note on precedence of options in bitcoin.conf (master...options_bitocin_conf) https://github.com/bitcoin/bitcoin/pull/16448
 75 2019-07-24T06:33:42  *** bitcoin-git has left #bitcoin-core-dev
 76 2019-07-24T06:33:57  *** mg0314b has quit IRC
 77 2019-07-24T06:55:27  *** AaronvanW has quit IRC
 78 2019-07-24T07:05:46  *** Krellan has joined #bitcoin-core-dev
 79 2019-07-24T07:26:26  *** IGHOR has quit IRC
 80 2019-07-24T07:28:11  *** elichai2 has quit IRC
 81 2019-07-24T07:35:20  *** liberiga has joined #bitcoin-core-dev
 82 2019-07-24T07:40:28  *** Krellan has quit IRC
 83 2019-07-24T07:50:42  *** kljasdfvv has joined #bitcoin-core-dev
 84 2019-07-24T08:00:57  *** AaronvanW has joined #bitcoin-core-dev
 85 2019-07-24T08:07:55  *** Krellan has joined #bitcoin-core-dev
 86 2019-07-24T08:08:41  *** kristapsk has quit IRC
 87 2019-07-24T08:09:23  *** Aaronvan_ has joined #bitcoin-core-dev
 88 2019-07-24T08:09:59  <wumpus> rc1 binaries up https://bitcoincore.org/bin/bitcoin-core-0.18.1/test.rc1/
 89 2019-07-24T08:10:17  <fanquake> wumpus \o/
 90 2019-07-24T08:10:36  <wumpus> (sorry it took a while, hard to concentrate with these temperatures!)
 91 2019-07-24T08:10:52  <fanquake> too hot or too cold ?
 92 2019-07-24T08:12:05  <wumpus> too hot
 93 2019-07-24T08:12:08  *** AaronvanW has quit IRC
 94 2019-07-24T08:14:20  *** Krellan has quit IRC
 95 2019-07-24T08:37:08  *** Zenton has joined #bitcoin-core-dev
 96 2019-07-24T08:41:48  <wumpus> oh, we still need relesae notes for 0.18.1
 97 2019-07-24T08:42:14  <wumpus> release notes on the 0.18 branch are entirely blank at the moment https://github.com/bitcoin/bitcoin/blob/0.18/doc/release-notes.md
 98 2019-07-24T08:49:35  *** Krellan has joined #bitcoin-core-dev
 99 2019-07-24T08:54:21  *** laptop500 has joined #bitcoin-core-dev
100 2019-07-24T08:59:58  *** liberiga has quit IRC
101 2019-07-24T09:00:02  *** SRV_DW20 has quit IRC
102 2019-07-24T09:04:58  *** Shabbypenguin has joined #bitcoin-core-dev
103 2019-07-24T09:09:11  <fanquake> 👀
104 2019-07-24T09:09:12  *** setpill has joined #bitcoin-core-dev
105 2019-07-24T09:09:37  <fanquake> Good call. Are you putting those together, otherwise I can have a look later tonight
106 2019-07-24T09:10:27  *** vincenzopalazzo has joined #bitcoin-core-dev
107 2019-07-24T09:23:48  *** Krellan has quit IRC
108 2019-07-24T09:24:18  *** timothy has joined #bitcoin-core-dev
109 2019-07-24T09:28:45  <wumpus> i'll have a look at it in the evening
110 2019-07-24T09:29:02  <wumpus> if you want to put in something already please do :)
111 2019-07-24T09:32:15  *** jonatack has quit IRC
112 2019-07-24T09:43:42  *** timothy has quit IRC
113 2019-07-24T09:50:26  *** Honethe_ has quit IRC
114 2019-07-24T09:51:13  *** timothy has joined #bitcoin-core-dev
115 2019-07-24T09:55:50  *** Krellan has joined #bitcoin-core-dev
116 2019-07-24T10:01:10  *** vincenzopalazzo has quit IRC
117 2019-07-24T10:01:22  *** Krellan has quit IRC
118 2019-07-24T10:04:32  *** TheFuzzStone[m] has quit IRC
119 2019-07-24T10:04:53  *** kewde[m] has quit IRC
120 2019-07-24T10:08:05  *** tuirektiujm[m] has quit IRC
121 2019-07-24T10:08:21  *** electric-sheep[m has quit IRC
122 2019-07-24T10:08:50  *** DavidMitchell[m] has quit IRC
123 2019-07-24T10:13:43  *** Honethe_ has joined #bitcoin-core-dev
124 2019-07-24T10:16:28  *** Krellan has joined #bitcoin-core-dev
125 2019-07-24T10:45:51  *** TheFuzzStone[m] has joined #bitcoin-core-dev
126 2019-07-24T10:52:34  *** Chris_Stewart_5 has joined #bitcoin-core-dev
127 2019-07-24T10:52:57  *** kewde[m] has joined #bitcoin-core-dev
128 2019-07-24T10:52:58  *** tuirektiujm[m] has joined #bitcoin-core-dev
129 2019-07-24T10:53:04  *** electric-sheep[m has joined #bitcoin-core-dev
130 2019-07-24T10:53:05  *** DavidMitchell[m] has joined #bitcoin-core-dev
131 2019-07-24T11:01:30  *** Honethe_ has quit IRC
132 2019-07-24T11:07:58  *** jonatack has joined #bitcoin-core-dev
133 2019-07-24T11:17:47  *** Chris_Stewart_5 has quit IRC
134 2019-07-24T11:18:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
135 2019-07-24T11:20:02  *** Krellan has quit IRC
136 2019-07-24T11:20:57  *** bitcoin-git has joined #bitcoin-core-dev
137 2019-07-24T11:20:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67923d6b3c1e...0626b8cbdf0a
138 2019-07-24T11:20:58  <bitcoin-git> bitcoin/master c3dfc91 Fabian Jahr: test: Skip flaky p2p_invalid_messages test on macOS
139 2019-07-24T11:20:58  <bitcoin-git> bitcoin/master 0626b8c MarcoFalke: Merge #16445: test: Skip flaky p2p_invalid_messages test on macOS
140 2019-07-24T11:21:10  *** bitcoin-git has left #bitcoin-core-dev
141 2019-07-24T11:22:07  *** bitcoin-git has joined #bitcoin-core-dev
142 2019-07-24T11:22:07  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16445: test: Skip flaky p2p_invalid_messages test on macOS (master...mac_test) https://github.com/bitcoin/bitcoin/pull/16445
143 2019-07-24T11:22:08  *** bitcoin-git has left #bitcoin-core-dev
144 2019-07-24T11:22:32  *** Chris_Stewart_5 has quit IRC
145 2019-07-24T11:23:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
146 2019-07-24T11:28:43  *** bitcoin-git has joined #bitcoin-core-dev
147 2019-07-24T11:28:43  <bitcoin-git> [bitcoin] EvertonMelo opened pull request #16449: Update v4.3> zmq.md fix CVE-2019-6250 { doc }  (master...patch-22) https://github.com/bitcoin/bitcoin/pull/16449
148 2019-07-24T11:28:45  *** bitcoin-git has left #bitcoin-core-dev
149 2019-07-24T11:30:53  *** tuirektiujm[m] has quit IRC
150 2019-07-24T11:37:04  *** tuirektiujm[m] has joined #bitcoin-core-dev
151 2019-07-24T11:38:23  *** Aaronvan_ has quit IRC
152 2019-07-24T12:00:01  *** Shabbypenguin has quit IRC
153 2019-07-24T12:05:25  *** Aaronvan_ has joined #bitcoin-core-dev
154 2019-07-24T12:17:35  *** lightlike has joined #bitcoin-core-dev
155 2019-07-24T12:25:10  *** dgfhdfg has joined #bitcoin-core-dev
156 2019-07-24T12:28:57  *** Krellan has joined #bitcoin-core-dev
157 2019-07-24T12:38:34  *** promag has quit IRC
158 2019-07-24T12:38:50  *** promag has joined #bitcoin-core-dev
159 2019-07-24T12:40:12  *** DeanWeen has quit IRC
160 2019-07-24T12:44:42  *** smtx has joined #bitcoin-core-dev
161 2019-07-24T12:45:51  *** Chris_Stewart_5 has quit IRC
162 2019-07-24T12:52:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
163 2019-07-24T13:04:08  *** ollij has joined #bitcoin-core-dev
164 2019-07-24T13:06:10  *** Krellan has quit IRC
165 2019-07-24T13:18:50  *** goatpig has joined #bitcoin-core-dev
166 2019-07-24T13:18:53  *** pinheadmz has joined #bitcoin-core-dev
167 2019-07-24T13:25:20  *** shesek has quit IRC
168 2019-07-24T13:33:10  *** Krellan has joined #bitcoin-core-dev
169 2019-07-24T13:34:17  *** ghost43_ is now known as ghost43
170 2019-07-24T13:39:12  *** Krellan has quit IRC
171 2019-07-24T13:50:30  *** d_t has joined #bitcoin-core-dev
172 2019-07-24T13:56:00  *** elichai2 has joined #bitcoin-core-dev
173 2019-07-24T13:58:14  *** davterra has joined #bitcoin-core-dev
174 2019-07-24T14:03:31  *** shesek has joined #bitcoin-core-dev
175 2019-07-24T14:03:31  *** shesek has joined #bitcoin-core-dev
176 2019-07-24T14:03:46  *** davterra has quit IRC
177 2019-07-24T14:04:18  *** davterra has joined #bitcoin-core-dev
178 2019-07-24T14:08:33  *** IGHOR has joined #bitcoin-core-dev
179 2019-07-24T14:08:37  *** Krellan has joined #bitcoin-core-dev
180 2019-07-24T14:43:08  *** Krellan has quit IRC
181 2019-07-24T14:50:54  *** d_t has quit IRC
182 2019-07-24T14:51:05  *** bitcoin-git has joined #bitcoin-core-dev
183 2019-07-24T14:51:05  <bitcoin-git> [bitcoin] jnewbery opened pull request #16451: Remove CMerkleTx (master...2019-07-remove-CMerkleTx) https://github.com/bitcoin/bitcoin/pull/16451
184 2019-07-24T14:51:10  *** bitcoin-git has left #bitcoin-core-dev
185 2019-07-24T14:55:52  *** michaelsdunn1 has joined #bitcoin-core-dev
186 2019-07-24T15:00:01  *** smtx has quit IRC
187 2019-07-24T15:08:41  *** emilengler has joined #bitcoin-core-dev
188 2019-07-24T15:09:01  *** jnewbery has quit IRC
189 2019-07-24T15:09:04  *** sdaftuar has quit IRC
190 2019-07-24T15:14:45  *** setpill has quit IRC
191 2019-07-24T15:15:08  *** sdaftuar has joined #bitcoin-core-dev
192 2019-07-24T15:16:19  *** jnewbery has joined #bitcoin-core-dev
193 2019-07-24T15:16:46  *** havenwood1 has joined #bitcoin-core-dev
194 2019-07-24T15:24:22  *** Aaronvan_ has quit IRC
195 2019-07-24T15:24:57  *** AaronvanW has joined #bitcoin-core-dev
196 2019-07-24T15:46:05  *** Krellan has joined #bitcoin-core-dev
197 2019-07-24T15:54:03  *** kljasdfvv has quit IRC
198 2019-07-24T15:57:00  <dongcarl> So my prototype for addrv2 is passing all netbase tests except for one: `ResolveSubNet("::/0").Match(ResolveIP("1.2.3.4"))`
199 2019-07-24T15:57:23  <dongcarl> Logically, should we treat IPv4 as a subset of IPv6?
200 2019-07-24T15:58:22  <dongcarl> Another question: should we treat an all-0 netmask as meaning _any network_?
201 2019-07-24T16:01:17  *** shesek has quit IRC
202 2019-07-24T16:12:13  *** promag has quit IRC
203 2019-07-24T16:12:58  *** promag has joined #bitcoin-core-dev
204 2019-07-24T16:14:28  *** Krellan has quit IRC
205 2019-07-24T16:22:48  *** sdaftuar has quit IRC
206 2019-07-24T16:23:22  *** jnewbery has quit IRC
207 2019-07-24T16:27:51  *** sdaftuar has joined #bitcoin-core-dev
208 2019-07-24T16:30:29  *** jnewbery has joined #bitcoin-core-dev
209 2019-07-24T16:33:23  *** timothy has quit IRC
210 2019-07-24T16:35:16  *** bitcoin-git has joined #bitcoin-core-dev
211 2019-07-24T16:35:16  <bitcoin-git> [bitcoin] hebasto closed pull request #16416: -datadir or -datadir="" option implies default datadir (master...20190718-nodatadir) https://github.com/bitcoin/bitcoin/pull/16416
212 2019-07-24T16:35:17  *** bitcoin-git has left #bitcoin-core-dev
213 2019-07-24T16:39:08  *** sdaftuar has quit IRC
214 2019-07-24T16:39:48  *** jnewbery has quit IRC
215 2019-07-24T16:42:15  *** jungly has quit IRC
216 2019-07-24T16:45:10  <wumpus> dongcarl: we've always regarded IPv4 as a subset of IPv6, I think to change that would need a very good reason, as it might break some things
217 2019-07-24T16:45:57  *** belcher has quit IRC
218 2019-07-24T16:46:51  *** belcher has joined #bitcoin-core-dev
219 2019-07-24T16:49:26  *** csknk has joined #bitcoin-core-dev
220 2019-07-24T16:51:18  *** jarthur has joined #bitcoin-core-dev
221 2019-07-24T16:57:03  <dongcarl> wumpus: Sounds good
222 2019-07-24T16:57:51  *** bpo has joined #bitcoin-core-dev
223 2019-07-24T17:00:20  *** shesek has joined #bitcoin-core-dev
224 2019-07-24T17:00:20  *** shesek has joined #bitcoin-core-dev
225 2019-07-24T17:02:08  *** Chris_Stewart_5 has quit IRC
226 2019-07-24T17:03:16  *** f1231l has joined #bitcoin-core-dev
227 2019-07-24T17:06:58  *** michaelfolkson has joined #bitcoin-core-dev
228 2019-07-24T17:07:34  *** sdaftuar has joined #bitcoin-core-dev
229 2019-07-24T17:14:12  *** shesek has quit IRC
230 2019-07-24T17:15:09  *** f1231l has quit IRC
231 2019-07-24T17:15:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
232 2019-07-24T17:34:11  *** bitcoin-git has joined #bitcoin-core-dev
233 2019-07-24T17:34:12  <bitcoin-git> [bitcoin] ariard opened pull request #16452: refactor : use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
234 2019-07-24T17:34:13  *** bitcoin-git has left #bitcoin-core-dev
235 2019-07-24T17:39:48  *** jb55 has quit IRC
236 2019-07-24T17:43:43  *** Zenton has quit IRC
237 2019-07-24T17:47:33  *** jb55 has joined #bitcoin-core-dev
238 2019-07-24T17:48:40  *** jonatack has quit IRC
239 2019-07-24T17:49:16  *** jonatack has joined #bitcoin-core-dev
240 2019-07-24T17:54:40  *** sdaftuar_ has joined #bitcoin-core-dev
241 2019-07-24T17:58:00  *** sdaftuar has quit IRC
242 2019-07-24T17:59:12  *** kcalvinalvin has joined #bitcoin-core-dev
243 2019-07-24T18:00:01  *** havenwood1 has quit IRC
244 2019-07-24T18:00:20  *** sdaftuar_ has quit IRC
245 2019-07-24T18:02:57  *** kcalvinalvin has quit IRC
246 2019-07-24T18:03:19  *** sdaftuar_ has joined #bitcoin-core-dev
247 2019-07-24T18:03:51  *** kcalvinalvin has joined #bitcoin-core-dev
248 2019-07-24T18:06:58  *** jnewbery_ has joined #bitcoin-core-dev
249 2019-07-24T18:08:01  *** bitcoin-git has joined #bitcoin-core-dev
250 2019-07-24T18:08:03  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0626b8cbdf0a...d960d5ca99b7
251 2019-07-24T18:08:03  <bitcoin-git> bitcoin/master 0b86e51 Hennadii Stepanov: Refactor out translation.h
252 2019-07-24T18:08:04  <bitcoin-git> bitcoin/master 7c45e14 Hennadii Stepanov: Add bilingual message type
253 2019-07-24T18:08:05  <bitcoin-git> bitcoin/master 753f7cc Hennadii Stepanov: scripted-diff: Make translation bilingual
254 2019-07-24T18:08:07  *** bitcoin-git has left #bitcoin-core-dev
255 2019-07-24T18:08:23  *** rex4539 has joined #bitcoin-core-dev
256 2019-07-24T18:09:07  *** bitcoin-git has joined #bitcoin-core-dev
257 2019-07-24T18:09:07  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16362: Add bilingual_str type (master...20190709-bilingual-part-one) https://github.com/bitcoin/bitcoin/pull/16362
258 2019-07-24T18:09:15  *** rex4539 has quit IRC
259 2019-07-24T18:09:21  *** bitcoin-git has left #bitcoin-core-dev
260 2019-07-24T18:11:59  *** csknk has quit IRC
261 2019-07-24T18:12:16  *** rex4539 has joined #bitcoin-core-dev
262 2019-07-24T18:12:50  *** belcher has quit IRC
263 2019-07-24T18:14:29  *** michaelfolkson has quit IRC
264 2019-07-24T18:15:27  *** bitcoin-git has joined #bitcoin-core-dev
265 2019-07-24T18:15:27  <bitcoin-git> [bitcoin] laanwj closed pull request #16449: doc: Update v4.3> zmq.md fix CVE-2019-6250 (master...patch-22) https://github.com/bitcoin/bitcoin/pull/16449
266 2019-07-24T18:15:28  *** bitcoin-git has left #bitcoin-core-dev
267 2019-07-24T18:17:10  *** belcher has joined #bitcoin-core-dev
268 2019-07-24T18:19:16  *** Guest50398 has joined #bitcoin-core-dev
269 2019-07-24T18:21:44  *** jkczyz has joined #bitcoin-core-dev
270 2019-07-24T18:26:53  *** sipa has quit IRC
271 2019-07-24T18:27:08  *** sipa has joined #bitcoin-core-dev
272 2019-07-24T18:28:35  *** coreybt has joined #bitcoin-core-dev
273 2019-07-24T18:29:31  *** jeremyrubin has joined #bitcoin-core-dev
274 2019-07-24T18:31:35  *** ezegom has joined #bitcoin-core-dev
275 2019-07-24T18:35:43  *** bpo has quit IRC
276 2019-07-24T18:37:59  *** ezegom has quit IRC
277 2019-07-24T18:49:33  *** bitcoin-git has joined #bitcoin-core-dev
278 2019-07-24T18:49:33  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/a6cba19831da...784e218610d4
279 2019-07-24T18:49:33  <bitcoin-git> bitcoin/0.18 784e218 Wladimir J. van der Laan: doc: Update release notes for rc1
280 2019-07-24T18:49:35  *** bitcoin-git has left #bitcoin-core-dev
281 2019-07-24T18:51:38  *** ollij has quit IRC
282 2019-07-24T18:53:40  *** coreybt has quit IRC
283 2019-07-24T18:55:06  *** bitcoin-git has joined #bitcoin-core-dev
284 2019-07-24T18:55:06  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16452: refactor: use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
285 2019-07-24T18:55:07  *** bitcoin-git has left #bitcoin-core-dev
286 2019-07-24T18:55:22  *** bitcoin-git has joined #bitcoin-core-dev
287 2019-07-24T18:55:22  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16452: refactor: use RelayTransaction in BroadcastTransaction utility (master...2019-07-reuse-relay-tx) https://github.com/bitcoin/bitcoin/pull/16452
288 2019-07-24T18:55:35  *** bitcoin-git has left #bitcoin-core-dev
289 2019-07-24T19:06:32  *** kcalvinalvin has quit IRC
290 2019-07-24T19:06:51  *** kcalvinalvin has joined #bitcoin-core-dev
291 2019-07-24T19:10:07  <hebasto> should I rebase my open PR when a range of its commits are already merged with other PR? (see: #16224, #16362)
292 2019-07-24T19:10:10  <gribble> https://github.com/bitcoin/bitcoin/issues/16224 | gui: Bilingual GUI error messages by hebasto · Pull Request #16224 · bitcoin/bitcoin · GitHub
293 2019-07-24T19:10:12  <gribble> https://github.com/bitcoin/bitcoin/issues/16362 | Add bilingual_str type by hebasto · Pull Request #16362 · bitcoin/bitcoin · GitHub
294 2019-07-24T19:15:26  *** jonatack has quit IRC
295 2019-07-24T19:33:12  <elichai2> sipa: Hey, I'm trying to figure out what kind of descriptors makes sense *inside* a `tap(internal_key, [...tree..])` desc, I came up with a new pk(let's call it ts_pk for the conversation) and a new multi for CHECKSIGADD scripts(n-of-n), and that's it? maybe `raw()`? (I don't think sh,wsh, pkh, wpkh, combo,addr or regular pk makes sense inside of taproot/tapscripts)
296 2019-07-24T19:34:09  *** jonatack has joined #bitcoin-core-dev
297 2019-07-24T19:37:07  *** CubicEarth has quit IRC
298 2019-07-24T19:38:26  *** captjakk has joined #bitcoin-core-dev
299 2019-07-24T19:46:17  <sipa> elichai2: join ##miniscript
300 2019-07-24T19:46:37  <sipa> there are many things possible
301 2019-07-24T19:47:10  <sipa> wsh/wpkh clearly don't make sense inside taproot, as they're only valid as toplevel things or p2sh by definition
302 2019-07-24T19:47:43  <sipa> but i think pk/pkh should be, though perhaps by then we can just only have a miniscript variant for taproot and only support that inside taproot descriptors
303 2019-07-24T19:48:08  <elichai2> But tapscript modifies `OP_CHECKSIG` to be with schnorr
304 2019-07-24T19:48:14  <sipa> sure
305 2019-07-24T19:48:37  <elichai2> so then `pk()` will mean different thing inside and outside of taproot
306 2019-07-24T19:48:37  <sipa> but pk could have different semantics inside taproot than inside other things
307 2019-07-24T19:48:41  <sipa> that's already the case
308 2019-07-24T19:48:44  <elichai2> should it still be the same name?
309 2019-07-24T19:48:53  <sipa> inside p2sh the sighash is computed differently than outside
310 2019-07-24T19:49:00  <sipa> inside segwit it's computed even more differently
311 2019-07-24T19:49:07  <elichai2> he
312 2019-07-24T19:49:50  <elichai2> ok, makes sense. pkh doesn't make a lot of sense to me because when do you reveal the pubkey? on the same script you give the hash?
313 2019-07-24T19:50:23  <sipa> elichai2: in miniscript we have a pk_h that's actually preferable sometimes to pk
314 2019-07-24T19:50:38  <sipa> because you only put a shorter hash inside the script
315 2019-07-24T19:51:18  <elichai2> but on the spending script you'll need to supply that key anyway. (in the same tx that you reveal the script with the hash)
316 2019-07-24T19:51:18  *** bitcoin-git has joined #bitcoin-core-dev
317 2019-07-24T19:51:18  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16453: validation: Run CheckBlockIndex only on success (Fixup) (master...1907-validationCheckBlockIndexSuccess) https://github.com/bitcoin/bitcoin/pull/16453
318 2019-07-24T19:51:19  *** bitcoin-git has left #bitcoin-core-dev
319 2019-07-24T19:51:29  <sipa> elichai2: only if the branch is actually executed
320 2019-07-24T19:51:45  <sipa> if the probability for that is low enough, this may be a good tradeoff
321 2019-07-24T19:51:55  <sipa> the miniscript compiler can figure that out :)
322 2019-07-24T19:52:01  *** davterra has quit IRC
323 2019-07-24T19:52:51  *** davterra has joined #bitcoin-core-dev
324 2019-07-24T19:52:56  *** Zenton has joined #bitcoin-core-dev
325 2019-07-24T19:53:00  <elichai2> to alliveate 32 byte of hashing computation? ok haha, i'm trying to figure out if the current non-miniscript desc makes sense. because it seems that there's some time until miniscript is really public
326 2019-07-24T19:53:28  <sipa> elichai2: no, to reduce the size of a satisfaction
327 2019-07-24T19:53:51  <sipa> 20 byte hash instead of 33 byte pubkey
328 2019-07-24T19:54:30  <elichai2> but if that's not the spending path you reveal only the hash of the branch anyway, right?
329 2019-07-24T19:54:39  <sipa> right
330 2019-07-24T19:58:11  *** davterra has quit IRC
331 2019-07-24T19:58:46  *** davterra has joined #bitcoin-core-dev
332 2019-07-24T19:59:38  *** davterra has joined #bitcoin-core-dev
333 2019-07-24T20:03:22  *** emilengler has quit IRC
334 2019-07-24T20:07:19  <elichai2> what about a SIGHASHADD multi descriptor?(n-of-n) do you think it should be a thing or people should try to stick to musig even when interactivity is a problem?
335 2019-07-24T20:08:38  <sipa> elichai2: the signing interactivity won't always be possible, so there definitely should be a way to use CHECKSIGADD-based multisig scripts
336 2019-07-24T20:09:09  *** rex4539 has quit IRC
337 2019-07-24T20:09:47  <sipa> elichai2: we could have a variant of multi for that in taproot descriptors (and i'd suggest that for that it does get a different name, because the actual opcodes that correspond to it are different)
338 2019-07-24T20:10:05  *** jarthur has quit IRC
339 2019-07-24T20:11:06  <elichai2> Right. and I think there's no point of talking about a muSig descriptor before musig has at least a standardization proposal
340 2019-07-24T20:14:00  <sipa> agree
341 2019-07-24T20:14:13  <sipa> i think the same is true about taproot
342 2019-07-24T20:14:26  <sipa> but at least in terms of experimental work, we can do both
343 2019-07-24T20:14:39  <sipa> but regardless, we can't do without non-musig based thresholds/multisig
344 2019-07-24T20:23:03  *** michaelfolkson has joined #bitcoin-core-dev
345 2019-07-24T20:26:35  *** michaelfolkson has quit IRC
346 2019-07-24T20:33:28  *** stalker` has joined #bitcoin-core-dev
347 2019-07-24T20:34:52  *** ezegom has joined #bitcoin-core-dev
348 2019-07-24T20:40:36  *** bitcoin-git has joined #bitcoin-core-dev
349 2019-07-24T20:40:36  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16455: doc: Remove downgrading warning in release notes, per 0.18 branch (master...1907-docReleaseNotes) https://github.com/bitcoin/bitcoin/pull/16455
350 2019-07-24T20:40:37  *** bitcoin-git has left #bitcoin-core-dev
351 2019-07-24T20:55:01  *** kcalvinalvin has quit IRC
352 2019-07-24T20:58:52  *** state_bits has quit IRC
353 2019-07-24T21:00:02  *** Guest50398 has quit IRC
354 2019-07-24T21:04:22  *** hcchien has joined #bitcoin-core-dev
355 2019-07-24T21:05:35  *** hebasto has quit IRC
356 2019-07-24T21:05:54  *** hebasto has joined #bitcoin-core-dev
357 2019-07-24T21:06:08  *** bitcoin-git has joined #bitcoin-core-dev
358 2019-07-24T21:06:08  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16453: WIP: validation: Run CheckBlockIndex only on success (Fixup) (master...1907-validationCheckBlockIndexSuccess) https://github.com/bitcoin/bitcoin/pull/16453
359 2019-07-24T21:06:10  *** bitcoin-git has left #bitcoin-core-dev
360 2019-07-24T21:10:10  *** Chris_Stewart_5 has quit IRC
361 2019-07-24T21:10:30  *** liberiga has joined #bitcoin-core-dev
362 2019-07-24T21:10:38  *** stalker` has quit IRC
363 2019-07-24T21:12:45  *** goatpig has quit IRC
364 2019-07-24T21:13:32  *** michaelfolkson has joined #bitcoin-core-dev
365 2019-07-24T21:13:46  *** toto99 has joined #bitcoin-core-dev
366 2019-07-24T21:15:51  *** hebasto has quit IRC
367 2019-07-24T21:15:57  *** hebasto_ has joined #bitcoin-core-dev
368 2019-07-24T21:22:14  *** michaelfolkson has quit IRC
369 2019-07-24T21:33:13  *** toto99 has quit IRC
370 2019-07-24T21:35:01  *** michaelsdunn1 has quit IRC
371 2019-07-24T21:48:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
372 2019-07-24T22:06:13  *** captjakk has quit IRC
373 2019-07-24T22:08:27  *** ezegom has quit IRC
374 2019-07-24T22:21:42  *** laptop500 has quit IRC
375 2019-07-24T22:25:47  *** promag has quit IRC
376 2019-07-24T22:25:59  *** promag has joined #bitcoin-core-dev
377 2019-07-24T22:26:25  *** captjakk has joined #bitcoin-core-dev
378 2019-07-24T22:27:44  *** liberiga has quit IRC
379 2019-07-24T22:28:44  *** michaelfolkson has joined #bitcoin-core-dev
380 2019-07-24T22:30:45  *** promag has quit IRC
381 2019-07-24T22:31:30  *** promag has joined #bitcoin-core-dev
382 2019-07-24T22:31:30  *** Chris_Stewart_5 has quit IRC
383 2019-07-24T22:38:59  *** michaelfolkson has quit IRC
384 2019-07-24T22:40:03  *** michaelfolkson has joined #bitcoin-core-dev
385 2019-07-24T22:50:01  *** rh0nj has quit IRC
386 2019-07-24T22:50:25  <elichai2> Is the right way to access the scripts in descriptors is using `ExpandHelper`? (because `MakeScripts` is private) (I have a function that parses a taproot desc and generates a tree with `DescriptorImpl` leafs, and I want to compute the right tweak)
387 2019-07-24T22:51:09  *** rh0nj has joined #bitcoin-core-dev
388 2019-07-24T22:57:26  *** michaelfolkson has quit IRC
389 2019-07-24T23:02:36  *** kristapsk has joined #bitcoin-core-dev
390 2019-07-24T23:02:59  <sipa> elichai2: eh depends what you want to do
391 2019-07-24T23:03:17  <sipa> MakeScripts is the node-type-specific function to be overridden
392 2019-07-24T23:03:26  <sipa> ExpandHelper is what invokes things recursively etc
393 2019-07-24T23:05:37  <elichai2> let's say I have a `PKDescriptor` descriptor there I would want to get the `KEY OP_CHECKSIG` script so I can hash it. it seems that naivley MakeScripts does it but it's designed as you said to be used internally by ExpandHelper
394 2019-07-24T23:06:26  <sipa> everything is expanded into the FlatSigningProvider
395 2019-07-24T23:06:43  *** michaelfolkson has joined #bitcoin-core-dev
396 2019-07-24T23:07:41  <sipa> you'll need to add some interface to SigningProvider to access taproot pubkey->key or pubkey->(merklebranch,script) things
397 2019-07-24T23:08:10  <elichai2> does it expand in `ParseScript` already? or do I need to call something to make it expand there?
398 2019-07-24T23:08:21  <sipa> ParseScript just builds the Descriptor objects
399 2019-07-24T23:08:28  *** davterra has quit IRC
400 2019-07-24T23:08:35  <sipa> filling the FlatSigningProvider happens through the Expand* functions
401 2019-07-24T23:09:12  <elichai2> Ok. So I'll make my TapDescriptor contain DescriptorImpls and not scripts and i'll expand them later when needed. Thanks!
402 2019-07-24T23:09:23  <sipa> that sounds right
403 2019-07-24T23:13:20  *** AaronvanW has quit IRC
404 2019-07-24T23:13:32  *** toto99 has joined #bitcoin-core-dev
405 2019-07-24T23:13:36  *** AaronvanW has joined #bitcoin-core-dev
406 2019-07-24T23:17:46  *** michaelsdunn1 has joined #bitcoin-core-dev
407 2019-07-24T23:17:53  *** michaelfolkson has quit IRC
408 2019-07-24T23:24:31  *** toto99 has quit IRC
409 2019-07-24T23:29:51  *** ptiyoyip has joined #bitcoin-core-dev
410 2019-07-24T23:32:07  *** lightlike has quit IRC
411 2019-07-24T23:33:18  *** dgfhdfg has quit IRC
412 2019-07-24T23:47:01  *** ptiyoyip has quit IRC
413 2019-07-24T23:47:45  *** michaelsdunn1 has quit IRC
414 2019-07-24T23:52:30  *** AaronvanW has joined #bitcoin-core-dev
415 2019-07-24T23:56:49  *** AaronvanW has quit IRC