1 2019-07-26T00:00:01  *** phyll1s_work has quit IRC
  2 2019-07-26T00:03:01  *** davterra has joined #bitcoin-core-dev
  3 2019-07-26T00:03:13  *** vincenzopalazzo has joined #bitcoin-core-dev
  4 2019-07-26T00:04:06  *** them_ has joined #bitcoin-core-dev
  5 2019-07-26T00:05:05  *** lightlike has quit IRC
  6 2019-07-26T00:08:36  *** vincenzopalazzo has left #bitcoin-core-dev
  7 2019-07-26T00:10:44  *** nijak_ has joined #bitcoin-core-dev
  8 2019-07-26T00:12:21  *** nijak has quit IRC
  9 2019-07-26T00:25:09  <fanquake> MarcoFalke: Is there something wrong with the bot. It keeps tagging and commenting on closed PRs. Some of them more than once.
 10 2019-07-26T01:05:39  *** davterra has quit IRC
 11 2019-07-26T01:33:24  *** d_t has quit IRC
 12 2019-07-26T01:34:18  *** davterra has joined #bitcoin-core-dev
 13 2019-07-26T01:36:10  *** michagogo has joined #bitcoin-core-dev
 14 2019-07-26T02:02:46  *** ossifrage_ is now known as ossifrage
 15 2019-07-26T02:16:42  *** ryufghj has quit IRC
 16 2019-07-26T02:17:40  *** sipa has quit IRC
 17 2019-07-26T02:22:53  *** sipa has joined #bitcoin-core-dev
 18 2019-07-26T02:24:48  *** hebasto has joined #bitcoin-core-dev
 19 2019-07-26T02:24:52  *** zivl has quit IRC
 20 2019-07-26T02:25:31  *** pinheadmz_ has joined #bitcoin-core-dev
 21 2019-07-26T02:27:53  *** pinheadmz has quit IRC
 22 2019-07-26T02:27:54  *** pinheadmz_ is now known as pinheadmz
 23 2019-07-26T02:27:57  *** sipa has joined #bitcoin-core-dev
 24 2019-07-26T02:53:54  *** davterra has quit IRC
 25 2019-07-26T02:55:26  *** davterra has joined #bitcoin-core-dev
 26 2019-07-26T02:59:03  *** sipa has quit IRC
 27 2019-07-26T03:00:02  *** them_ has quit IRC
 28 2019-07-26T03:03:53  *** edunham1 has joined #bitcoin-core-dev
 29 2019-07-26T03:04:17  *** sipa has joined #bitcoin-core-dev
 30 2019-07-26T03:05:00  *** bitcoin-git has joined #bitcoin-core-dev
 31 2019-07-26T03:05:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16386: depends: disable unused Qt features (master...slim_qt_597) https://github.com/bitcoin/bitcoin/pull/16386
 32 2019-07-26T03:05:14  *** bitcoin-git has left #bitcoin-core-dev
 33 2019-07-26T03:15:51  *** zivl has joined #bitcoin-core-dev
 34 2019-07-26T03:16:41  *** sipa has quit IRC
 35 2019-07-26T03:26:52  *** sipa has joined #bitcoin-core-dev
 36 2019-07-26T03:40:11  *** farmerwampum has quit IRC
 37 2019-07-26T03:43:44  *** michagogo has quit IRC
 38 2019-07-26T03:48:18  *** baldur has quit IRC
 39 2019-07-26T03:50:58  *** sipa has quit IRC
 40 2019-07-26T03:52:45  *** farmerwampum has joined #bitcoin-core-dev
 41 2019-07-26T03:56:11  *** sipa has joined #bitcoin-core-dev
 42 2019-07-26T03:56:57  *** schnerch_ has joined #bitcoin-core-dev
 43 2019-07-26T04:00:02  *** schnerchi has quit IRC
 44 2019-07-26T04:00:27  *** baldur has joined #bitcoin-core-dev
 45 2019-07-26T04:06:19  *** sipa has quit IRC
 46 2019-07-26T04:11:31  *** sipa has joined #bitcoin-core-dev
 47 2019-07-26T04:26:16  *** liberiga has quit IRC
 48 2019-07-26T04:29:28  *** TheV01d_ has quit IRC
 49 2019-07-26T04:29:57  *** TheV01d_ has joined #bitcoin-core-dev
 50 2019-07-26T04:36:56  *** rex4539 has quit IRC
 51 2019-07-26T05:25:21  *** d_t has joined #bitcoin-core-dev
 52 2019-07-26T05:36:16  *** bralyclow2 has joined #bitcoin-core-dev
 53 2019-07-26T05:37:20  *** d_t has quit IRC
 54 2019-07-26T05:37:59  *** bralyclow2 has quit IRC
 55 2019-07-26T05:41:34  *** d_t has joined #bitcoin-core-dev
 56 2019-07-26T05:44:05  *** kcalvinalvin has joined #bitcoin-core-dev
 57 2019-07-26T05:45:26  *** kcalvina_ has joined #bitcoin-core-dev
 58 2019-07-26T05:49:03  *** kcalvinalvin has quit IRC
 59 2019-07-26T05:51:06  *** d_t has quit IRC
 60 2019-07-26T05:57:03  *** elichai2 has quit IRC
 61 2019-07-26T06:00:02  *** edunham1 has quit IRC
 62 2019-07-26T06:02:13  *** davterra has quit IRC
 63 2019-07-26T06:16:05  *** slewis has joined #bitcoin-core-dev
 64 2019-07-26T06:57:24  *** timothy has joined #bitcoin-core-dev
 65 2019-07-26T07:04:30  *** EagleTM has joined #bitcoin-core-dev
 66 2019-07-26T07:35:11  *** potatoe_face has joined #bitcoin-core-dev
 67 2019-07-26T07:36:02  *** rh0nj has quit IRC
 68 2019-07-26T07:37:08  *** rh0nj has joined #bitcoin-core-dev
 69 2019-07-26T08:24:56  *** jonatack has joined #bitcoin-core-dev
 70 2019-07-26T08:25:24  *** Zenton has joined #bitcoin-core-dev
 71 2019-07-26T08:29:16  *** kljasdfvv has joined #bitcoin-core-dev
 72 2019-07-26T08:33:17  <jonasschnelli> elichai2: re https://github.com/drone/drone: what I wanted is a lightweight solution. I'm not a fan of docker and I think especially for a CI its not ideal (but I may be wrong).
 73 2019-07-26T08:42:45  *** ccdle12 has joined #bitcoin-core-dev
 74 2019-07-26T08:43:04  *** hex17or has quit IRC
 75 2019-07-26T08:44:37  *** EagleTM has quit IRC
 76 2019-07-26T08:48:48  *** AaronvanW has joined #bitcoin-core-dev
 77 2019-07-26T08:58:18  *** justanotheruser has quit IRC
 78 2019-07-26T09:00:01  *** slewis has quit IRC
 79 2019-07-26T09:08:27  <wumpus> i'm really confused about #16386
 80 2019-07-26T09:08:29  <gribble> https://github.com/bitcoin/bitcoin/issues/16386 | depends: disable unused Qt features by fanquake · Pull Request #16386 · bitcoin/bitcoin · GitHub
 81 2019-07-26T09:09:06  <wumpus> i remember merging it yesterday but it shows that MarcoFalke did so
 82 2019-07-26T09:10:53  *** Soligor has quit IRC
 83 2019-07-26T09:14:31  *** setpill has joined #bitcoin-core-dev
 84 2019-07-26T09:16:50  *** matael1 has joined #bitcoin-core-dev
 85 2019-07-26T09:18:04  *** Soligor has joined #bitcoin-core-dev
 86 2019-07-26T09:18:41  *** justanotheruser has joined #bitcoin-core-dev
 87 2019-07-26T09:33:21  *** vincenzopalazzo has joined #bitcoin-core-dev
 88 2019-07-26T09:44:00  *** Aaronvan_ has joined #bitcoin-core-dev
 89 2019-07-26T09:47:10  *** AaronvanW has quit IRC
 90 2019-07-26T09:55:42  *** kcalvina_ has quit IRC
 91 2019-07-26T10:06:23  <jonasschnelli> wumpus: where did it show that MarcoFalke did?
 92 2019-07-26T10:06:28  <jonasschnelli> "where does"
 93 2019-07-26T10:07:28  <jonasschnelli> I only see Drahts "needs rebase"  comments after the merge in the timeline
 94 2019-07-26T10:19:43  *** bitcoin-git has joined #bitcoin-core-dev
 95 2019-07-26T10:19:44  <bitcoin-git> [bitcoin] jonatack opened pull request #16467: rpc: sendrawtransaction help privacy note (master...sendrawtransaction-privacy-note) https://github.com/bitcoin/bitcoin/pull/16467
 96 2019-07-26T10:19:47  *** bitcoin-git has left #bitcoin-core-dev
 97 2019-07-26T10:20:38  <jonatack> is it just me, or did one of the last dozen commits on master break building locally on debian?
 98 2019-07-26T10:21:04  <jonatack> will try to isolate which one
 99 2019-07-26T10:25:19  <jonatack> ah nvm it's building again
100 2019-07-26T10:27:03  *** gribble has quit IRC
101 2019-07-26T10:28:24  <jonasschnelli> jonatack: works on my end
102 2019-07-26T10:31:03  <jonatack> jonasschnelli: thank you
103 2019-07-26T10:45:07  *** gribble has joined #bitcoin-core-dev
104 2019-07-26T10:58:31  *** Aaronvan_ is now known as AaronvanW
105 2019-07-26T11:04:06  *** timothy has quit IRC
106 2019-07-26T11:10:24  *** jb55 has quit IRC
107 2019-07-26T11:27:37  *** queip has quit IRC
108 2019-07-26T11:37:31  *** queip has joined #bitcoin-core-dev
109 2019-07-26T11:49:02  *** lightlike has joined #bitcoin-core-dev
110 2019-07-26T11:49:11  *** dgfhdfg has joined #bitcoin-core-dev
111 2019-07-26T11:59:41  *** victorSN has quit IRC
112 2019-07-26T11:59:41  *** rockhouse has quit IRC
113 2019-07-26T12:00:01  *** matael1 has quit IRC
114 2019-07-26T12:00:04  *** rockhouse has joined #bitcoin-core-dev
115 2019-07-26T12:00:17  *** victorSN has joined #bitcoin-core-dev
116 2019-07-26T12:04:40  *** flukiluke1 has joined #bitcoin-core-dev
117 2019-07-26T12:07:04  *** rockhouse has quit IRC
118 2019-07-26T12:07:10  *** victorSN has quit IRC
119 2019-07-26T12:10:51  *** rockhouse has joined #bitcoin-core-dev
120 2019-07-26T12:11:12  *** victorSN has joined #bitcoin-core-dev
121 2019-07-26T12:58:42  *** vincenzopalazzo has left #bitcoin-core-dev
122 2019-07-26T13:13:34  *** ccdle12 has quit IRC
123 2019-07-26T13:34:15  *** elichai2 has joined #bitcoin-core-dev
124 2019-07-26T13:49:31  <fanquake> wumpus: yes that confused me as well. It’d be good to get an explanation as to why/how the MarcoFalke merge message showed up in this channel.
125 2019-07-26T13:50:34  *** d_t has joined #bitcoin-core-dev
126 2019-07-26T13:50:49  <fanquake> Obviously you’d merged it first quite a while earlier, so I don’t understand how a merge message from a different user, on an already closed & merged PR has ended up posted here.
127 2019-07-26T13:52:18  *** spaced0ut has quit IRC
128 2019-07-26T13:53:38  *** davterra has joined #bitcoin-core-dev
129 2019-07-26T13:55:26  *** spaced0ut has joined #bitcoin-core-dev
130 2019-07-26T14:02:30  *** davterra has quit IRC
131 2019-07-26T14:02:41  *** davterra has joined #bitcoin-core-dev
132 2019-07-26T14:03:11  *** laurentmt has joined #bitcoin-core-dev
133 2019-07-26T14:06:30  *** setpill has quit IRC
134 2019-07-26T14:16:06  *** laurentmt has quit IRC
135 2019-07-26T14:22:15  <cfields> jonasschnelli: sorry for missing the meeting yesterday. That looks great!
136 2019-07-26T14:24:04  <cfields> I'm excited to catch up and play around.
137 2019-07-26T14:24:21  *** IGHOR has quit IRC
138 2019-07-26T14:30:26  *** davec has quit IRC
139 2019-07-26T14:41:28  <wumpus> fanquake: i think the github API was messed up for tha tPR, also causing the bot to misbehave
140 2019-07-26T14:44:10  <wumpus> this is the logging from the bot: https://0bin.net/paste/PeFZGajcOPfMmXV0#Dea0H42UViZiyCF86Pb2YspJma47s9NycgKX4FSspKS  it got a pull request closed event, which is strange so long after the actual merge, but anyhow, let's hope it was a fluke
141 2019-07-26T14:46:41  <jonasschnelli> cfields: if you want to work on a better per-package dependency cache... I'm all in.
142 2019-07-26T14:48:32  *** davec has joined #bitcoin-core-dev
143 2019-07-26T14:48:39  <cfields> jonasschnelli: sure, happy to lend a hand. What do you have in mind?
144 2019-07-26T14:50:25  <cfields> jonasschnelli: fyi, the package names are deterministic and shouldn't ever collide. So the easiest option is to simply never delete them. Then, if it exists when a client requests it, it's guaranteed to be what they wanted.
145 2019-07-26T14:50:25  *** d_t has quit IRC
146 2019-07-26T14:50:35  <jonasschnelli> for the CI, I guess it would be ideal to just cache all possible versions of packages to avoid rebuilding depends all the times when a package change in master
147 2019-07-26T14:50:51  <jonasschnelli> although I might have a lack of understanding how the cache works
148 2019-07-26T14:50:57  <cfields> jonasschnelli: see ^^, then :)
149 2019-07-26T14:51:16  <jonasschnelli> I see
150 2019-07-26T14:51:38  <cfields> jonasschnelli: we could just add a NO_CLEANUP option, so that depends doesn't delete as it goes. It would just leave old copies behind.
151 2019-07-26T14:51:56  <cfields> Hmm, maybe I already did that? I certainly intended to at one point.
152 2019-07-26T14:52:25  <cfields> I'll PR if not.
153 2019-07-26T14:52:32  <jonasschnelli> thanks
154 2019-07-26T14:53:00  <cfields> jonasschnelli: does that fix the problem you're talking about? I'm only pretty sure we're on the same page :)
155 2019-07-26T14:53:57  <jonasschnelli> my head is almost exploding.. I need to dive into that once I have more time. I'll let you know it I see potential for further optimization
156 2019-07-26T14:54:47  <cfields> Haha, no worries. I'll PR the option and we'll see if it ends up helping. I think it will.
157 2019-07-26T14:58:37  *** michaelsdunn1 has joined #bitcoin-core-dev
158 2019-07-26T15:00:02  *** flukiluke1 has quit IRC
159 2019-07-26T15:03:58  *** kcalvinalvin has joined #bitcoin-core-dev
160 2019-07-26T15:04:33  *** CareBearemcho has joined #bitcoin-core-dev
161 2019-07-26T15:09:15  *** kcalvina_ has joined #bitcoin-core-dev
162 2019-07-26T15:09:36  *** CareBearemcho has quit IRC
163 2019-07-26T15:12:07  *** kcalvinalvin has quit IRC
164 2019-07-26T15:13:58  *** kcalvinalvin has joined #bitcoin-core-dev
165 2019-07-26T15:15:07  *** zivl has quit IRC
166 2019-07-26T15:15:46  *** kcalvina_ has quit IRC
167 2019-07-26T15:19:52  *** aowi has joined #bitcoin-core-dev
168 2019-07-26T15:20:57  *** zivl has joined #bitcoin-core-dev
169 2019-07-26T15:24:18  *** justanotheruser has quit IRC
170 2019-07-26T15:28:05  *** lightningbot has joined #bitcoin-core-dev
171 2019-07-26T15:33:29  <phantomcircuit> there's a memory cliff for io, at 1GB im seeing 1000 tps reading the utxo set
172 2019-07-26T15:33:33  <phantomcircuit> but at 4GB there's almost zero
173 2019-07-26T15:34:13  <phantomcircuit> has anybody looked at the number of leveldb reads vs dbcache size?
174 2019-07-26T15:41:16  *** justanotheruser has joined #bitcoin-core-dev
175 2019-07-26T15:44:27  *** emilengler has joined #bitcoin-core-dev
176 2019-07-26T15:45:38  <cfields> jonasschnelli: I just added the option to not delete previous builds, and it works as intended, but it occurs to me that a malicious PR could simply disable the option.
177 2019-07-26T15:45:47  <cfields> So I'm afraid it will actually need to be handled on the builder's side.
178 2019-07-26T15:48:17  <cfields> jonasschnelli: basically, you want a filesystem where "rm -rf" of a certain directory is a no op.
179 2019-07-26T15:49:49  <cfields> jonasschnelli: hmm, I think a chmod/chown after the build should do the trick.
180 2019-07-26T15:53:04  <jonasschnelli> in the CI, a PR can only affect the PRs branch cache...
181 2019-07-26T15:53:32  <jonasschnelli> and I guess one could do way more dangerous stuff
182 2019-07-26T15:53:56  <jonasschnelli> at least bitcoinbuilds.org could exploited on PR level quite hard...
183 2019-07-26T15:54:08  <jonasschnelli> I need to add some protection at some point
184 2019-07-26T15:55:00  <jonasschnelli> if it builds a new branch (PR) for the first time, it copies over master depends built, builds depends and caches under the new branch
185 2019-07-26T15:55:15  <jonasschnelli> next time the same PR gets built, it uses that cache
186 2019-07-26T15:55:22  <jonasschnelli> master is unaffected
187 2019-07-26T16:00:14  *** Zenton has quit IRC
188 2019-07-26T16:05:53  <cfields> jonasschnelli: mmm, that's similar to what Travis does. It's rather non-ideal for taking advantage of depends, though :(
189 2019-07-26T16:07:57  <cfields> jonasschnelli: let's discuss when you're less fried. I'll go ahead and push a branch with a few changes that I think would be helpful.
190 2019-07-26T16:09:13  <jonasschnelli> thanks... its 37C here.
191 2019-07-26T16:10:43  <sipa> jonasschnelli: jump in a lake
192 2019-07-26T16:11:27  <fanquake> Or find a beach 🏄‍♂️
193 2019-07-26T16:12:05  <jonasschnelli> there is no lake where I live... but the rhein... will jup in soon though!
194 2019-07-26T16:12:08  <jonasschnelli> jump
195 2019-07-26T16:12:55  <sipa> fanquake: i challenge you to find switzerland's coastline :)
196 2019-07-26T16:13:05  <jonasschnelli> heh lol
197 2019-07-26T16:13:56  <fanquake> sipa: hah yes, I guess the more viable cooling option is heading for the top of a very large mountain.
198 2019-07-26T16:22:10  *** kljasdfvv has quit IRC
199 2019-07-26T16:23:38  <provoostenator> What does GetDepthInMainChain do? And what is CMerkleTx? In context of #15713 where this is removed from SubmitMemoryPoolAndRelay (prev: RelayWalletTransaction).
200 2019-07-26T16:23:41  <gribble> https://github.com/bitcoin/bitcoin/issues/15713 | refactor: Replace chain relayTransactions/submitMemoryPool by higher method by ariard · Pull Request #15713 · bitcoin/bitcoin · GitHub
201 2019-07-26T16:34:41  *** jarthur has joined #bitcoin-core-dev
202 2019-07-26T16:39:40  *** dgfhdfg has quit IRC
203 2019-07-26T16:44:16  *** rex4539 has joined #bitcoin-core-dev
204 2019-07-26T17:16:18  *** luke-jr has quit IRC
205 2019-07-26T17:17:00  *** liberiga has joined #bitcoin-core-dev
206 2019-07-26T17:18:49  *** luke-jr has joined #bitcoin-core-dev
207 2019-07-26T17:24:12  <cfields> jonasschnelli: Now that I've worked through it locally, I think there are a few easy changes to make on the builder side, no need to change depends. Ping me whenever you'd like to discuss.
208 2019-07-26T17:24:58  *** DeanGuss has quit IRC
209 2019-07-26T17:25:33  *** DeanGuss has joined #bitcoin-core-dev
210 2019-07-26T17:26:23  *** DeanGuss has quit IRC
211 2019-07-26T17:26:51  *** DeanGuss has joined #bitcoin-core-dev
212 2019-07-26T17:29:56  *** bitcoin-git has joined #bitcoin-core-dev
213 2019-07-26T17:29:56  <bitcoin-git> [bitcoin] promag opened pull request #16468: Exclude depends/Makefile in .gitignore (master...2019-07-gitignore) https://github.com/bitcoin/bitcoin/pull/16468
214 2019-07-26T17:30:02  *** bitcoin-git has left #bitcoin-core-dev
215 2019-07-26T17:38:17  <promag> elichai2: re drone, I've used it, it's cool and all, but IIRC lacks support for parallel builds and caching
216 2019-07-26T17:39:14  <elichai2> promag: caching isn't as easy as travis but you can set it up and parallel builds is definitely supported (though you need to set a env var for it)
217 2019-07-26T17:51:00  *** Zenton has joined #bitcoin-core-dev
218 2019-07-26T17:52:47  *** Emcy has quit IRC
219 2019-07-26T17:58:47  <jonasschnelli> elichai2: can you tell docker to only use limited resources? Similar to a VM with X amount of cores and Y amount of ram?
220 2019-07-26T17:59:22  <jonasschnelli> cfields; sounds good. Interested to hear...
221 2019-07-26T17:59:59  <elichai2> jonasschnelli: it seems so: https://docs.docker.com/config/containers/resource_constraints/ (altough if you have a dedicated machine for that I don't see why you would want that)
222 2019-07-26T18:00:02  *** aowi has quit IRC
223 2019-07-26T18:01:43  <jonasschnelli> elichai2: Good to know. I'm not an expert,... but I though limiting each build (that runs in parallel) by VM's memory and CPU may make sense for sanity reasons...
224 2019-07-26T18:04:17  *** theos1 has joined #bitcoin-core-dev
225 2019-07-26T18:05:32  <cfields> jonasschnelli: https://github.com/theuni/bitcoin/commits/depends-keep-cache
226 2019-07-26T18:05:51  <cfields> The option is unsafe for public use, but illustrates the idea for testing.
227 2019-07-26T18:07:29  <jonasschnelli> cfields: thanks. I see.
228 2019-07-26T18:08:17  <jonasschnelli> How "more unsafe" is that than allowing to run arbitrary python/shell-scripts or even binaries in the build VM?
229 2019-07-26T18:09:22  <cfields> jonasschnelli: it's unsafe in that when using that, you'd want a cache shared among all builders. Problem is that if any build removes the whole cache, that would remove the cache for all builders.
230 2019-07-26T18:09:39  <cfields> So in reality you'd likely want to handle it with permissions changes before/after the builds.
231 2019-07-26T18:10:30  <cfields> Or symliks, or mount options. I assume there are plenty of clever ways to handle it safely.
232 2019-07-26T18:11:21  <jonasschnelli> cfields: is it possible somehow to make it "add only"?
233 2019-07-26T18:12:01  <cfields> jonasschnelli: right, that's the goal. But it has to be done on the builder. Any changes to depends could be subverted by a malicious PR.
234 2019-07-26T18:12:06  <jonasschnelli> (then eventually delete oldest package [or package with minimal hits] when cache size limit reached)
235 2019-07-26T18:12:13  <cfields> Yup, exactly.
236 2019-07-26T18:12:19  *** DeanGuss has quit IRC
237 2019-07-26T18:12:31  <jonasschnelli> I see
238 2019-07-26T18:12:47  *** michaelsdunn1 has quit IRC
239 2019-07-26T18:14:05  *** DeanGuss has joined #bitcoin-core-dev
240 2019-07-26T18:17:10  *** reallll has joined #bitcoin-core-dev
241 2019-07-26T18:20:46  *** belcher has quit IRC
242 2019-07-26T18:26:09  *** dgfhdfg has joined #bitcoin-core-dev
243 2019-07-26T18:38:03  *** tryphe_ has joined #bitcoin-core-dev
244 2019-07-26T18:40:02  *** tryphe has quit IRC
245 2019-07-26T19:06:40  *** MARKUS87 has joined #bitcoin-core-dev
246 2019-07-26T19:08:17  *** MARKUS87 has quit IRC
247 2019-07-26T19:10:52  *** owowo has quit IRC
248 2019-07-26T19:13:05  *** lightlike has quit IRC
249 2019-07-26T19:15:05  *** morcos has quit IRC
250 2019-07-26T19:15:20  *** owowo has joined #bitcoin-core-dev
251 2019-07-26T19:15:24  *** morcos has joined #bitcoin-core-dev
252 2019-07-26T19:20:20  *** bitcoin-git has joined #bitcoin-core-dev
253 2019-07-26T19:20:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/a54a12046e98...dbf4f3f86a8f
254 2019-07-26T19:20:22  <bitcoin-git> bitcoin/master ab28e31 Andrew Chow: Change ImportScriptPubKeys' internal to apply_label
255 2019-07-26T19:20:23  <bitcoin-git> bitcoin/master fae7a5b Andrew Chow: Log when an import is being skipped because we already have it
256 2019-07-26T19:20:24  <bitcoin-git> bitcoin/master c6a8274 Andrew Chow: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and Import...
257 2019-07-26T19:20:25  *** bitcoin-git has left #bitcoin-core-dev
258 2019-07-26T19:21:20  *** bitcoin-git has joined #bitcoin-core-dev
259 2019-07-26T19:21:21  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16301: Use CWallet::Import* functions in all import* RPCs (master...imports-use-cwallet-funcs) https://github.com/bitcoin/bitcoin/pull/16301
260 2019-07-26T19:21:22  *** bitcoin-git has left #bitcoin-core-dev
261 2019-07-26T19:22:30  <MarcoFalke> > [09:49] <fanquake> wumpus: yes that confused me as well. It’d be good to get an explanation as to why/how the MarcoFalke merge message showed up in this channel.
262 2019-07-26T19:22:37  <MarcoFalke> Just a GitHub bug
263 2019-07-26T19:23:40  <MarcoFalke> I am glad we don't use GitHub for merges, considering how often they corrupted metadata or the git tree in the last couple of weeks
264 2019-07-26T19:28:22  <MarcoFalke> people should start signing their ACKs *stares at everyone*
265 2019-07-26T19:29:39  <achow101> but that takes so much more work
266 2019-07-26T19:30:53  *** lightlike has joined #bitcoin-core-dev
267 2019-07-26T19:31:09  *** Emcy has joined #bitcoin-core-dev
268 2019-07-26T19:31:29  <promag> (hides)
269 2019-07-26T19:33:01  *** rh0nj has quit IRC
270 2019-07-26T19:34:07  *** rh0nj has joined #bitcoin-core-dev
271 2019-07-26T19:34:39  <elichai2> achow101: should DescriptorImpl keep doing all the work for the deriving classes even when there's special work that needs to be done only for a specific desc? (i.e. I don't think you would want all of the taproot hashing/branching logic in `DescriptorImpl::ExpandHelper`, isn't it better that inheriting classes can override it? )
272 2019-07-26T19:35:16  <achow101> probably, ask sipa, he wrote it
273 2019-07-26T19:35:41  <elichai2> (like they override `IsSolvable` and `MakeScripts`, altough `MakeScripts` is a bad example because that's what `ExpandHelper` uses)
274 2019-07-26T19:36:05  <sipa> expandhelper does all the work
275 2019-07-26T19:36:17  <sipa> makescripts is the per-descriptor logic
276 2019-07-26T19:36:28  *** laurentmt has joined #bitcoin-core-dev
277 2019-07-26T19:37:53  <elichai2> I thought it would be better if the taproot descriptor kept the tree and expanded everything but i see that in the other cases you do all the work in `DescriptorImpl` and `ExpandHelper`, I'm just afraid that this function will blow up.
278 2019-07-26T19:38:30  <elichai2> (so I guess `DescriptorImpl` will keep a unique_ptr to the tree and treat it like m_script_arg)
279 2019-07-26T19:39:54  *** laurentmt has quit IRC
280 2019-07-26T19:41:38  <sipa> elichai2: i guess the taproot descriptor impl should work pretty much like the p2sh/p2wsh ones?
281 2019-07-26T19:41:53  <sipa> ah, i see
282 2019-07-26T19:41:57  <elichai2> yeah, they do all the logic in the parent.
283 2019-07-26T19:42:06  <sipa> instead of m_script_arg you need something to store a tree
284 2019-07-26T19:42:09  <elichai2> (parent = DescriptorImpl)
285 2019-07-26T19:42:14  <elichai2> yes
286 2019-07-26T19:42:37  <sipa> you can also just put that structurr in the tapprot specific one, i think
287 2019-07-26T19:42:38  <elichai2> until now I implemented it in the taproot descriptor itself which inherits from DescriptorImpl
288 2019-07-26T19:42:40  <sipa> if that's easier
289 2019-07-26T19:43:09  <sipa> it's a bit of a weird design, iknow
290 2019-07-26T19:43:22  <elichai2> but that I can't call MakeScripts on the leafs and I can't override ExpandHelper (without changing anything)
291 2019-07-26T19:43:28  <elichai2> *but then
292 2019-07-26T19:44:27  <elichai2> so either I make them public/virtual or I keep everything in the DescriptorImpl as it already is
293 2019-07-26T19:44:50  *** mdunnio has joined #bitcoin-core-dev
294 2019-07-26T19:46:46  <sipa> you could turn m_script_arg into a vector
295 2019-07-26T19:47:08  <sipa> but you'd still need some place to storr tree structure information
296 2019-07-26T19:47:49  <elichai2> yeah... and the base class can't access the deriving class data members. so I guess i'll keep everything in DescriptorImpl
297 2019-07-26T19:48:15  *** tryphe_ is now known as tryphe
298 2019-07-26T19:48:30  <sipa> we may need to refactor stuff at some point
299 2019-07-26T19:48:47  <elichai2> aren't you changing some of this logic with the miniscript code?
300 2019-07-26T19:48:50  <sipa> not every descriptor will fit in the structure imposed by the current DescriptotImpl
301 2019-07-26T19:49:02  <sipa> yeah, i was about to mention that
302 2019-07-26T19:49:29  <elichai2> (waiting eagerly to see your changes :) )
303 2019-07-26T19:49:59  <elichai2> will be a hard rebase but i'll get over it haha
304 2019-07-26T19:57:02  *** bitcoin-git has joined #bitcoin-core-dev
305 2019-07-26T19:57:03  <bitcoin-git> [bitcoin] hebasto opened pull request #16469: refactoring: Use direct list initialization for Arg struct (master...20190726-remove-arg-ctor) https://github.com/bitcoin/bitcoin/pull/16469
306 2019-07-26T19:57:15  *** bitcoin-git has left #bitcoin-core-dev
307 2019-07-26T20:09:46  *** dgfhdfg has quit IRC
308 2019-07-26T20:13:52  *** bitcoin-git has joined #bitcoin-core-dev
309 2019-07-26T20:13:53  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16470: test: Fail early on disconnect in mininode.wait_for_* (master...1907-testMininodeNoWaitOnDisconnect) https://github.com/bitcoin/bitcoin/pull/16470
310 2019-07-26T20:14:06  *** bitcoin-git has left #bitcoin-core-dev
311 2019-07-26T20:20:42  *** hebasto has quit IRC
312 2019-07-26T20:23:31  *** bitcoin-git has joined #bitcoin-core-dev
313 2019-07-26T20:23:31  <bitcoin-git> [bitcoin] jnewbery opened pull request #16471: [mempool] log correct messages when CPFP fails (master...2019-07-fix-CalculateMempoolAncestors-logging) https://github.com/bitcoin/bitcoin/pull/16471
314 2019-07-26T20:23:35  *** bitcoin-git has left #bitcoin-core-dev
315 2019-07-26T20:31:16  *** mdunnio has quit IRC
316 2019-07-26T20:31:41  *** EagleTM has joined #bitcoin-core-dev
317 2019-07-26T20:32:23  *** mdunnio has joined #bitcoin-core-dev
318 2019-07-26T20:37:43  *** tryphe_ has joined #bitcoin-core-dev
319 2019-07-26T20:40:02  *** tryphe has quit IRC
320 2019-07-26T20:53:29  *** grubles has left #bitcoin-core-dev
321 2019-07-26T20:56:25  *** davterra has quit IRC
322 2019-07-26T21:00:01  *** theos1 has quit IRC
323 2019-07-26T21:04:44  *** afk11 has quit IRC
324 2019-07-26T21:05:17  *** afk11 has joined #bitcoin-core-dev
325 2019-07-26T21:19:49  *** strattog has joined #bitcoin-core-dev
326 2019-07-26T21:25:00  *** mdunnio has quit IRC
327 2019-07-26T21:25:35  *** mdunnio has joined #bitcoin-core-dev
328 2019-07-26T21:30:02  *** mdunnio has quit IRC
329 2019-07-26T21:32:06  *** mdunnio has joined #bitcoin-core-dev
330 2019-07-26T21:36:17  *** EagleTM has quit IRC
331 2019-07-26T21:37:09  *** Krellan_ has joined #bitcoin-core-dev
332 2019-07-26T21:37:17  *** tryphe_ is now known as tryphe
333 2019-07-26T21:38:41  *** dviola has joined #bitcoin-core-dev
334 2019-07-26T21:41:51  *** EagleTM has joined #bitcoin-core-dev
335 2019-07-26T22:01:24  *** afk11 has quit IRC
336 2019-07-26T22:01:51  *** afk11 has joined #bitcoin-core-dev
337 2019-07-26T22:14:43  *** mdunnio has quit IRC
338 2019-07-26T22:16:17  *** kcalvinalvin has quit IRC
339 2019-07-26T22:25:20  *** EagleTM has quit IRC
340 2019-07-26T22:45:14  *** rex4539 has quit IRC
341 2019-07-26T22:45:54  *** davex__ has joined #bitcoin-core-dev
342 2019-07-26T22:46:17  *** davex__ has quit IRC
343 2019-07-26T22:47:01  *** davex__ has joined #bitcoin-core-dev
344 2019-07-26T22:55:26  *** jb55 has joined #bitcoin-core-dev
345 2019-07-26T22:56:00  *** liberiga has quit IRC
346 2019-07-26T23:09:10  *** jarthur has quit IRC
347 2019-07-26T23:09:17  <fanquake> MarcoFalke: Thanks
348 2019-07-26T23:09:52  *** cornfeedhobo has quit IRC
349 2019-07-26T23:10:00  *** DeanGuss has quit IRC
350 2019-07-26T23:12:30  *** dviola has quit IRC
351 2019-07-26T23:13:38  *** EagleTM has joined #bitcoin-core-dev
352 2019-07-26T23:22:51  *** cornfeedhobo has joined #bitcoin-core-dev
353 2019-07-26T23:31:41  *** captjakk has quit IRC
354 2019-07-26T23:32:15  *** captjakk has joined #bitcoin-core-dev
355 2019-07-26T23:36:42  *** captjakk has quit IRC
356 2019-07-26T23:41:31  *** dviola has joined #bitcoin-core-dev
357 2019-07-26T23:41:44  *** lightlike has quit IRC
358 2019-07-26T23:51:37  *** mdunnio has joined #bitcoin-core-dev
359 2019-07-26T23:52:30  *** mdunnio has quit IRC
360 2019-07-26T23:53:38  *** dviola has quit IRC
361 2019-07-26T23:54:23  *** emilengler has quit IRC
362 2019-07-26T23:57:46  *** dviola has joined #bitcoin-core-dev
363 2019-07-26T23:58:14  *** dviola has quit IRC
364 2019-07-26T23:58:15  *** dviola has joined #bitcoin-core-dev