1 2019-08-06T00:00:02  *** Morgon1 has quit IRC
  2 2019-08-06T00:00:02  *** Cory has joined #bitcoin-core-dev
  3 2019-08-06T00:08:04  *** aqu4 has joined #bitcoin-core-dev
  4 2019-08-06T00:09:10  *** confused has quit IRC
  5 2019-08-06T00:11:22  *** Chris_Stewart_5 has quit IRC
  6 2019-08-06T00:26:03  *** tryphe_ is now known as tryphe
  7 2019-08-06T00:28:11  *** jonatack has quit IRC
  8 2019-08-06T00:28:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  9 2019-08-06T00:28:20  *** Haitham has joined #bitcoin-core-dev
 10 2019-08-06T00:30:24  *** Relis has quit IRC
 11 2019-08-06T00:32:31  *** Relis has joined #bitcoin-core-dev
 12 2019-08-06T00:32:52  *** Relis has left #bitcoin-core-dev
 13 2019-08-06T00:32:57  *** Haitham has quit IRC
 14 2019-08-06T00:36:02  *** DeanGuss has joined #bitcoin-core-dev
 15 2019-08-06T00:41:18  *** Chris_Stewart_5 has quit IRC
 16 2019-08-06T00:42:57  *** profmac has quit IRC
 17 2019-08-06T00:47:50  *** lightlike has quit IRC
 18 2019-08-06T00:49:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 19 2019-08-06T00:56:12  *** profmac has joined #bitcoin-core-dev
 20 2019-08-06T00:58:15  *** emilengler has quit IRC
 21 2019-08-06T00:58:45  *** emilengler has joined #bitcoin-core-dev
 22 2019-08-06T00:59:51  *** kljasdfvv has quit IRC
 23 2019-08-06T01:00:43  *** kljasdfvv has joined #bitcoin-core-dev
 24 2019-08-06T01:02:40  *** emilengler has quit IRC
 25 2019-08-06T01:06:46  *** emilengler has joined #bitcoin-core-dev
 26 2019-08-06T01:08:39  *** captjakk has quit IRC
 27 2019-08-06T01:23:27  *** pinheadmz has quit IRC
 28 2019-08-06T01:25:14  *** promag has quit IRC
 29 2019-08-06T01:39:54  *** bitcoin-git has joined #bitcoin-core-dev
 30 2019-08-06T01:39:54  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/62117f9f363e...31d98584f3c5
 31 2019-08-06T01:39:55  <bitcoin-git> bitcoin/master fa5a4cd MarcoFalke: gui: Generate bech32 addresses by default (take 2, fixup)
 32 2019-08-06T01:39:55  <bitcoin-git> bitcoin/master 31d9858 fanquake: Merge #16497: gui: Generate bech32 addresses by default (take 2, fixup)
 33 2019-08-06T01:39:57  *** bitcoin-git has left #bitcoin-core-dev
 34 2019-08-06T01:40:49  *** bitcoin-git has joined #bitcoin-core-dev
 35 2019-08-06T01:40:49  <bitcoin-git> [bitcoin] fanquake merged pull request #16497: gui: Generate bech32 addresses by default (take 2, fixup) (master...1907-guiBech32Take2) https://github.com/bitcoin/bitcoin/pull/16497
 36 2019-08-06T01:40:51  *** bitcoin-git has left #bitcoin-core-dev
 37 2019-08-06T01:54:36  *** bitcoin-git has joined #bitcoin-core-dev
 38 2019-08-06T01:54:37  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31d98584f3c5...fbe4b7665b97
 39 2019-08-06T01:54:37  <bitcoin-git> bitcoin/master b2ea20d Kristian Kramer: doc: Fix grammar and punctuation in developer notes
 40 2019-08-06T01:54:38  <bitcoin-git> bitcoin/master fbe4b76 fanquake: Merge #16530: doc: Fix grammar and punctuation in developer notes
 41 2019-08-06T01:54:40  *** bitcoin-git has left #bitcoin-core-dev
 42 2019-08-06T01:55:36  *** bitcoin-git has joined #bitcoin-core-dev
 43 2019-08-06T01:55:36  <bitcoin-git> [bitcoin] fanquake merged pull request #16530: doc: Fix grammar and punctuation in developer notes (master...Tech1k-patch-1) https://github.com/bitcoin/bitcoin/pull/16530
 44 2019-08-06T01:55:37  *** bitcoin-git has left #bitcoin-core-dev
 45 2019-08-06T01:58:07  *** Chris_Stewart_5 has quit IRC
 46 2019-08-06T01:58:46  *** promag has joined #bitcoin-core-dev
 47 2019-08-06T02:03:54  *** promag has quit IRC
 48 2019-08-06T03:00:02  *** aqu4 has quit IRC
 49 2019-08-06T03:04:19  *** Eprom has joined #bitcoin-core-dev
 50 2019-08-06T03:10:59  <emilengler> Does the argmanager also loads the bitcoin.conf? Or is this being done seperately
 51 2019-08-06T03:16:04  <ariard> kallewoof: but did your txn land in your mempool or were bounced-off by ATMP ?
 52 2019-08-06T03:16:26  *** kcalvinalvin has joined #bitcoin-core-dev
 53 2019-08-06T03:18:48  <ariard> MarcoFalke: yes I agree, if I'm correct MaybeResendWallet will rebroadcast no matter what age?
 54 2019-08-06T03:28:26  <fanquake> I've added some Flame Graph notes to core-review: https://github.com/fanquake/core-review/tree/master/flamegraph
 55 2019-08-06T03:29:04  *** mzygar has joined #bitcoin-core-dev
 56 2019-08-06T03:33:23  *** mzygar has quit IRC
 57 2019-08-06T03:40:27  <ariard> oh that's nice, it's interesting to see how much reads are expensive even if it's something you always expect
 58 2019-08-06T03:45:17  *** kcalvinalvin has quit IRC
 59 2019-08-06T03:46:40  *** sdaftuar has quit IRC
 60 2019-08-06T03:48:37  *** sdaftuar has joined #bitcoin-core-dev
 61 2019-08-06T03:49:58  *** kcalvinalvin has joined #bitcoin-core-dev
 62 2019-08-06T03:54:12  *** kcalvinalvin has quit IRC
 63 2019-08-06T04:06:05  <kallewoof>  ariard: no the mempool is empty afterwards, it's just a big spam fest listing every coinbase ever mined by that node (i think)
 64 2019-08-06T04:15:26  *** elichai2 has quit IRC
 65 2019-08-06T04:28:14  <kallewoof> This was not the case. Not sure what was different. --> <kallewoof> MarcoFalke: Hm, not sure if 16452 is related or not from looking at the changes. Anyway Ithink you can trigger this by simply starting two regtest nodes and reorging one to the other. They should start spamming those messages I think
 66 2019-08-06T04:31:28  *** jb55 has quit IRC
 67 2019-08-06T04:41:43  *** Krellan has quit IRC
 68 2019-08-06T04:52:19  *** pinheadmz has joined #bitcoin-core-dev
 69 2019-08-06T04:59:35  *** Krellan has joined #bitcoin-core-dev
 70 2019-08-06T05:07:03  *** DeanGuss has quit IRC
 71 2019-08-06T05:10:51  *** _atos has joined #bitcoin-core-dev
 72 2019-08-06T05:29:17  *** mzygar has joined #bitcoin-core-dev
 73 2019-08-06T05:33:57  *** mzygar has quit IRC
 74 2019-08-06T05:36:08  *** EagleTM has joined #bitcoin-core-dev
 75 2019-08-06T05:37:34  <ariard> kallewoof: my PR removed coinbase check in SubmitMemoryPoolAndRelay because it was already checked in ATMP, what you're saying is coinbase txn being resubmited to mempool despite being confirmed?
 76 2019-08-06T05:44:04  *** kcalvinalvin has joined #bitcoin-core-dev
 77 2019-08-06T05:59:48  *** pinheadmz has quit IRC
 78 2019-08-06T06:00:01  *** Eprom has quit IRC
 79 2019-08-06T06:04:30  *** rawtaz1 has joined #bitcoin-core-dev
 80 2019-08-06T06:08:50  *** mzygar has joined #bitcoin-core-dev
 81 2019-08-06T06:09:39  *** EagleTM has quit IRC
 82 2019-08-06T06:25:55  <fanquake> wumpus: looks like there is also at least 5204, 4908, 3095, 2936
 83 2019-08-06T06:29:16  *** mzygar has quit IRC
 84 2019-08-06T06:31:03  <wumpus> fanquake: ooh fun
 85 2019-08-06T06:35:26  <wumpus> fanquake: we should deprecate problematic things more often :)
 86 2019-08-06T06:35:59  <fanquake> wumpus: I agree
 87 2019-08-06T06:36:16  <fanquake> wumpus: I actually rebased my disable BIP70 by default PR earlier today as well.. #15584
 88 2019-08-06T06:36:18  <gribble> https://github.com/bitcoin/bitcoin/issues/15584 | build: disable BIP70 support by default by fanquake · Pull Request #15584 · bitcoin/bitcoin · GitHub
 89 2019-08-06T06:37:10  *** promag has joined #bitcoin-core-dev
 90 2019-08-06T06:37:43  <wumpus> fanquake:thanks !
 91 2019-08-06T06:40:43  <fanquake> wumpus: also 5722, 2302
 92 2019-08-06T06:41:56  *** promag has quit IRC
 93 2019-08-06T06:46:38  *** jungly has joined #bitcoin-core-dev
 94 2019-08-06T07:11:23  <emilengler> How stuff is being printed in the bitcoind interface?
 95 2019-08-06T07:11:28  <emilengler> What is is the function for this
 96 2019-08-06T07:12:49  <emilengler> Or is there even a function?
 97 2019-08-06T07:13:04  <wumpus> you mean printing to the debug log?
 98 2019-08-06T07:13:29  <emilengler> wumpus: Exactly
 99 2019-08-06T07:13:32  <sipa> LogPrintf
100 2019-08-06T07:13:43  <emilengler> sipa: Thanks
101 2019-08-06T07:13:53  <wumpus> fanquake: #2302 seems to be about bitcoin: URLs in general
102 2019-08-06T07:13:54  <gribble> https://github.com/bitcoin/bitcoin/issues/2302 | Double-clicking bitcoin: URI link == duplicate Pay Tos · Issue #2302 · bitcoin/bitcoin · GitHub
103 2019-08-06T07:14:01  <sipa> emilengler: you can find these things yourself by grepping the source code for strings you see appear
104 2019-08-06T07:14:25  <fanquake> wumpus: yea, realised after another look, have left that open
105 2019-08-06T07:14:40  <wumpus> emilengler: yes, or LogPrint(BCLog::ADDRMAN,   for specific categories that can be specified with -debug=...
106 2019-08-06T07:15:08  <emilengler> sipa: Ok, will do this in future :) I might be using this channel to often ;)
107 2019-08-06T07:16:12  <sipa> emilengler: it's not that you're not welcome asking questions, but you can learn a lot more by investigating things yourself
108 2019-08-06T07:16:15  <wumpus> yes, printing to the debug log seemed too straightforward a question, I was worried for a bit that he wanted to print, to a printer :)
109 2019-08-06T07:16:51  <sipa> ha
110 2019-08-06T07:16:59  <emilengler> I think priting is better term then putting
111 2019-08-06T07:17:29  <sipa> "logging"
112 2019-08-06T07:18:14  <sipa> transitive verb
113 2019-08-06T07:18:14  <sipa> 1a : to cut (trees) for lumber
114 2019-08-06T07:18:15  <sipa> b : to clear (land) of trees in lumbering —often used with off
115 2019-08-06T07:19:04  *** jonatack has joined #bitcoin-core-dev
116 2019-08-06T07:22:26  <wumpus> hah i remember that the icon for gnome-logger (or a tool to browse system logs, at least) was a literal log of wood at some point, this confused people for whom English is not their native language a lot
117 2019-08-06T07:23:44  *** Guyver2 has joined #bitcoin-core-dev
118 2019-08-06T07:28:48  *** rex4539 has joined #bitcoin-core-dev
119 2019-08-06T07:29:56  *** EagleTM has joined #bitcoin-core-dev
120 2019-08-06T07:30:20  *** mzygar has joined #bitcoin-core-dev
121 2019-08-06T07:39:54  *** Sentineo has joined #bitcoin-core-dev
122 2019-08-06T07:41:34  *** EagleTM has quit IRC
123 2019-08-06T07:41:56  *** EagleTM has joined #bitcoin-core-dev
124 2019-08-06T07:44:58  *** EagleTM has quit IRC
125 2019-08-06T07:45:21  *** EagleTM has joined #bitcoin-core-dev
126 2019-08-06T08:03:33  <wumpus> fanquake: I don't see the comment you added in #16533, maybe you pushed the wrong branch?
127 2019-08-06T08:03:35  <gribble> https://github.com/bitcoin/bitcoin/issues/16533 | build: disable libxcb extensions by fanquake · Pull Request #16533 · bitcoin/bitcoin · GitHub
128 2019-08-06T08:06:43  <wumpus> oh, you added it only to the commit description and not in the change itself, ok, that wasn't clear to me
129 2019-08-06T08:06:47  *** EagleTM has quit IRC
130 2019-08-06T08:07:08  *** EagleTM has joined #bitcoin-core-dev
131 2019-08-06T08:07:39  * wumpus tends to interpret 'comment' as code comment 😄
132 2019-08-06T08:16:04  <kallewoof> ariard: see my pastebin link etc. I've never seen that kind of stuff before. The coinbase is obviously not getting into the mempool because it is not a valid mempool tx, but the logger is saying it attempts to do so for what it looksl ike a lot of or all of the coinbases related to the node's wallet.
133 2019-08-06T08:22:18  *** kcalvinalvin has quit IRC
134 2019-08-06T08:26:03  *** kcalvinalvin has joined #bitcoin-core-dev
135 2019-08-06T08:27:18  *** EagleTM has quit IRC
136 2019-08-06T08:27:38  *** EagleTM has joined #bitcoin-core-dev
137 2019-08-06T08:31:35  <fanquake> wumpus: right, that might actually be what dongcarl meant. I can update with a comment in the .mk file if you prefer.
138 2019-08-06T08:32:32  <emilengler> I think I'm using LogPrintf() wrong
139 2019-08-06T08:32:40  *** EagleTM has quit IRC
140 2019-08-06T08:32:43  <emilengler> It logs stuff that does not belong there
141 2019-08-06T08:33:04  *** EagleTM has joined #bitcoin-core-dev
142 2019-08-06T08:33:27  <emilengler> It logs stuff like "Env: opencon thread exit" eventhough it should only log a %s with a linebreak
143 2019-08-06T08:33:48  *** mzygar has quit IRC
144 2019-08-06T08:35:24  <emilengler> Ok nevermind looks like the problems are at my pointer
145 2019-08-06T08:40:44  *** mzygar has joined #bitcoin-core-dev
146 2019-08-06T08:49:35  *** emilengler has quit IRC
147 2019-08-06T08:50:39  *** Victor_sueca is now known as Victorsueca
148 2019-08-06T08:52:46  *** IGHOR has quit IRC
149 2019-08-06T08:53:58  *** IGHOR has joined #bitcoin-core-dev
150 2019-08-06T08:54:29  *** laptop500 has joined #bitcoin-core-dev
151 2019-08-06T08:55:00  <fanquake> wumpus: added both now anyways.
152 2019-08-06T08:55:36  *** justanotheruser has quit IRC
153 2019-08-06T08:58:36  *** EagleTM has quit IRC
154 2019-08-06T08:59:01  *** EagleTM has joined #bitcoin-core-dev
155 2019-08-06T09:00:02  *** rawtaz1 has quit IRC
156 2019-08-06T09:03:38  *** setpill has joined #bitcoin-core-dev
157 2019-08-06T09:04:05  *** EagleTM has quit IRC
158 2019-08-06T09:04:16  *** ThunderChicken has joined #bitcoin-core-dev
159 2019-08-06T09:04:26  *** EagleTM has joined #bitcoin-core-dev
160 2019-08-06T09:07:28  *** EagleTM has quit IRC
161 2019-08-06T09:07:51  *** EagleTM has joined #bitcoin-core-dev
162 2019-08-06T09:08:37  *** setpill has quit IRC
163 2019-08-06T09:09:16  *** timothy has joined #bitcoin-core-dev
164 2019-08-06T09:10:03  *** setpill has joined #bitcoin-core-dev
165 2019-08-06T09:10:53  *** EagleTM has quit IRC
166 2019-08-06T09:11:17  *** EagleTM has joined #bitcoin-core-dev
167 2019-08-06T09:11:18  *** bitcoin-git has joined #bitcoin-core-dev
168 2019-08-06T09:11:19  <bitcoin-git> [bitcoin] fanquake opened pull request #16554: test: only include and use OpenSSL where it's actually needed (BIP70) (master...test_openssl_include) https://github.com/bitcoin/bitcoin/pull/16554
169 2019-08-06T09:11:20  *** bitcoin-git has left #bitcoin-core-dev
170 2019-08-06T09:12:43  *** kcalvinalvin has quit IRC
171 2019-08-06T09:12:53  *** kcalvinalvin has joined #bitcoin-core-dev
172 2019-08-06T09:16:38  *** justanotheruser has joined #bitcoin-core-dev
173 2019-08-06T09:18:21  *** EagleTM has quit IRC
174 2019-08-06T09:18:45  *** EagleTM has joined #bitcoin-core-dev
175 2019-08-06T09:23:31  *** kcalvinalvin has quit IRC
176 2019-08-06T09:24:35  *** Aleru has joined #bitcoin-core-dev
177 2019-08-06T09:25:57  *** EagleTM has quit IRC
178 2019-08-06T09:26:17  *** EagleTM has joined #bitcoin-core-dev
179 2019-08-06T09:34:32  *** promag has joined #bitcoin-core-dev
180 2019-08-06T09:50:38  *** EagleTM has quit IRC
181 2019-08-06T09:51:02  *** EagleTM has joined #bitcoin-core-dev
182 2019-08-06T09:56:24  *** rex4539 has quit IRC
183 2019-08-06T09:58:30  <wumpus> fanquake: yes, i think adding both is best for these kinds of things: a source code comment is more apparent than a commit comment on casual browsing, but it's good to have the rationale in git history too
184 2019-08-06T10:03:20  *** Aleru has quit IRC
185 2019-08-06T10:09:27  <promag> all done in #15729 and #16404
186 2019-08-06T10:09:30  <gribble> https://github.com/bitcoin/bitcoin/issues/15729 | rpc: Raise error in getbalance if minconf is not zero by promag · Pull Request #15729 · bitcoin/bitcoin · GitHub
187 2019-08-06T10:09:31  <gribble> https://github.com/bitcoin/bitcoin/issues/16404 | qa: Test ZMQ notification after chain reorg by promag · Pull Request #16404 · bitcoin/bitcoin · GitHub
188 2019-08-06T10:13:20  *** EagleTM has quit IRC
189 2019-08-06T10:13:44  *** EagleTM has joined #bitcoin-core-dev
190 2019-08-06T10:15:15  *** jonatack has quit IRC
191 2019-08-06T10:17:25  *** EagleTM has quit IRC
192 2019-08-06T10:17:47  *** EagleTM has joined #bitcoin-core-dev
193 2019-08-06T10:29:33  *** promag has quit IRC
194 2019-08-06T10:35:43  *** EagleTM has quit IRC
195 2019-08-06T10:36:04  *** EagleTM has joined #bitcoin-core-dev
196 2019-08-06T10:41:13  *** EagleTM has quit IRC
197 2019-08-06T10:41:33  *** EagleTM has joined #bitcoin-core-dev
198 2019-08-06T10:42:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
199 2019-08-06T10:43:25  *** Victorsueca has quit IRC
200 2019-08-06T10:43:46  *** booyah_ has joined #bitcoin-core-dev
201 2019-08-06T10:44:04  *** booyah has quit IRC
202 2019-08-06T10:44:24  *** jungly has quit IRC
203 2019-08-06T10:44:34  *** Victorsueca has joined #bitcoin-core-dev
204 2019-08-06T10:46:45  *** jungly has joined #bitcoin-core-dev
205 2019-08-06T10:50:50  *** bitcoin-git has joined #bitcoin-core-dev
206 2019-08-06T10:50:50  <bitcoin-git> [bitcoin] Sjors opened pull request #16555: [doc] mention whitelist is inbound, and applies to blocksonly (master...2019/08/doc-whitelistrelay) https://github.com/bitcoin/bitcoin/pull/16555
207 2019-08-06T10:50:51  *** bitcoin-git has left #bitcoin-core-dev
208 2019-08-06T10:52:29  *** EagleTM has quit IRC
209 2019-08-06T10:52:54  *** EagleTM has joined #bitcoin-core-dev
210 2019-08-06T11:05:07  *** jungly has quit IRC
211 2019-08-06T11:06:25  *** jungly has joined #bitcoin-core-dev
212 2019-08-06T11:06:36  *** EagleTM has quit IRC
213 2019-08-06T11:07:01  *** EagleTM has joined #bitcoin-core-dev
214 2019-08-06T11:12:21  *** EagleTM has quit IRC
215 2019-08-06T11:12:45  *** EagleTM has joined #bitcoin-core-dev
216 2019-08-06T11:14:12  *** bitcoin-git has joined #bitcoin-core-dev
217 2019-08-06T11:14:12  <bitcoin-git> [bitcoin] setpill opened pull request #16556: Fix systemd service perms (master...fix-systemd-service-perms) https://github.com/bitcoin/bitcoin/pull/16556
218 2019-08-06T11:14:15  *** bitcoin-git has left #bitcoin-core-dev
219 2019-08-06T11:32:58  *** luke-jr has quit IRC
220 2019-08-06T11:33:25  *** luke-jr has joined #bitcoin-core-dev
221 2019-08-06T11:35:15  *** EagleTM has quit IRC
222 2019-08-06T11:35:39  *** EagleTM has joined #bitcoin-core-dev
223 2019-08-06T11:38:40  *** EagleTM has quit IRC
224 2019-08-06T11:39:03  *** EagleTM has joined #bitcoin-core-dev
225 2019-08-06T11:43:10  *** luke-jr has quit IRC
226 2019-08-06T11:43:39  *** luke-jr has joined #bitcoin-core-dev
227 2019-08-06T11:44:32  *** luke-jr has quit IRC
228 2019-08-06T11:46:20  *** Skirmant has joined #bitcoin-core-dev
229 2019-08-06T11:46:25  *** tnamrikS has joined #bitcoin-core-dev
230 2019-08-06T11:46:25  *** Skirmant has quit IRC
231 2019-08-06T11:46:25  *** tnamrikS has quit IRC
232 2019-08-06T11:46:58  *** Skirmant has joined #bitcoin-core-dev
233 2019-08-06T11:47:24  *** luke-jr has joined #bitcoin-core-dev
234 2019-08-06T11:47:31  *** EagleTM has quit IRC
235 2019-08-06T11:47:56  *** EagleTM has joined #bitcoin-core-dev
236 2019-08-06T12:00:02  *** ThunderChicken has quit IRC
237 2019-08-06T12:02:55  *** justanotheruser has quit IRC
238 2019-08-06T12:04:13  *** MartinAS1 has joined #bitcoin-core-dev
239 2019-08-06T12:04:29  *** justan0theruser has joined #bitcoin-core-dev
240 2019-08-06T12:06:28  *** EagleTM has quit IRC
241 2019-08-06T12:06:51  *** EagleTM has joined #bitcoin-core-dev
242 2019-08-06T12:06:58  *** Uirchit has joined #bitcoin-core-dev
243 2019-08-06T12:17:55  *** Uirchit has left #bitcoin-core-dev
244 2019-08-06T12:22:56  *** EagleTM has quit IRC
245 2019-08-06T12:23:20  *** EagleTM has joined #bitcoin-core-dev
246 2019-08-06T12:35:47  *** bitcoin-git has joined #bitcoin-core-dev
247 2019-08-06T12:35:48  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fbe4b7665b97...b725979a1175
248 2019-08-06T12:35:49  <bitcoin-git> bitcoin/master faff85a MarcoFalke: test: Format feature_fee_estimation with pep8
249 2019-08-06T12:35:49  <bitcoin-git> bitcoin/master fa76285 MarcoFalke: test: Explain why -whitelist is used in feature_fee_estimation
250 2019-08-06T12:35:50  <bitcoin-git> bitcoin/master b725979 MarcoFalke: Merge #16535: test: Explain why -whitelist is used in feature_fee_estimati...
251 2019-08-06T12:35:51  *** bitcoin-git has left #bitcoin-core-dev
252 2019-08-06T12:36:52  *** bitcoin-git has joined #bitcoin-core-dev
253 2019-08-06T12:36:53  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16535: test: Explain why -whitelist is used in feature_fee_estimation (master...1908-testDocFeeEst) https://github.com/bitcoin/bitcoin/pull/16535
254 2019-08-06T12:36:54  *** bitcoin-git has left #bitcoin-core-dev
255 2019-08-06T12:50:32  *** EagleTM has quit IRC
256 2019-08-06T12:50:56  *** EagleTM has joined #bitcoin-core-dev
257 2019-08-06T12:51:17  *** bitcoin-git has joined #bitcoin-core-dev
258 2019-08-06T12:51:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b725979a1175...e5fdda68c6d2
259 2019-08-06T12:51:17  <bitcoin-git> bitcoin/master 2f37163 fanquake: test: only include and init openSSL where it's actually used
260 2019-08-06T12:51:18  <bitcoin-git> bitcoin/master e5fdda6 MarcoFalke: Merge #16554: test: only include and use OpenSSL where it's actually neede...
261 2019-08-06T12:51:18  *** bitcoin-git has left #bitcoin-core-dev
262 2019-08-06T12:52:22  *** bitcoin-git has joined #bitcoin-core-dev
263 2019-08-06T12:52:22  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16554: test: only include and use OpenSSL where it's actually needed (BIP70) (master...test_openssl_include) https://github.com/bitcoin/bitcoin/pull/16554
264 2019-08-06T12:52:24  *** bitcoin-git has left #bitcoin-core-dev
265 2019-08-06T12:56:31  *** EagleTM has quit IRC
266 2019-08-06T12:56:56  *** EagleTM has joined #bitcoin-core-dev
267 2019-08-06T13:03:15  *** dviola has joined #bitcoin-core-dev
268 2019-08-06T13:08:47  *** Victorsueca has quit IRC
269 2019-08-06T13:08:59  *** ghost43_ has joined #bitcoin-core-dev
270 2019-08-06T13:09:00  *** ghost43 has quit IRC
271 2019-08-06T13:09:03  *** Victorsueca has joined #bitcoin-core-dev
272 2019-08-06T13:14:10  *** EagleTM has quit IRC
273 2019-08-06T13:14:34  *** EagleTM has joined #bitcoin-core-dev
274 2019-08-06T13:19:11  *** Chris_Stewart_5 has quit IRC
275 2019-08-06T13:21:38  *** EagleTM has quit IRC
276 2019-08-06T13:21:58  *** EagleTM has joined #bitcoin-core-dev
277 2019-08-06T13:24:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
278 2019-08-06T13:25:01  *** EagleTM has quit IRC
279 2019-08-06T13:25:23  *** EagleTM has joined #bitcoin-core-dev
280 2019-08-06T13:28:26  *** EagleTM has quit IRC
281 2019-08-06T13:28:48  *** EagleTM has joined #bitcoin-core-dev
282 2019-08-06T13:42:29  *** EagleTM has quit IRC
283 2019-08-06T13:42:49  *** EagleTM has joined #bitcoin-core-dev
284 2019-08-06T13:45:51  *** EagleTM has quit IRC
285 2019-08-06T13:46:14  *** EagleTM has joined #bitcoin-core-dev
286 2019-08-06T13:57:41  *** Aaronvan_ is now known as AaronvanW
287 2019-08-06T14:02:14  *** EagleTM has quit IRC
288 2019-08-06T14:02:39  *** EagleTM has joined #bitcoin-core-dev
289 2019-08-06T14:06:30  *** elichai2 has joined #bitcoin-core-dev
290 2019-08-06T14:06:57  *** dgfhdfg has joined #bitcoin-core-dev
291 2019-08-06T14:12:07  <ariard> kallewoof: ah yes now the logger in SubmitMemoryPoolAndRelay is printing before confirmation checks are done in BroadcastTransaction
292 2019-08-06T14:13:12  <ariard> IMO best would be to remove txn with more 100 confs from mapWallet to avoid broadcast retries of old confirmed ones
293 2019-08-06T14:14:33  *** EagleTM has quit IRC
294 2019-08-06T14:14:56  *** EagleTM has joined #bitcoin-core-dev
295 2019-08-06T14:24:55  *** EagleTM has quit IRC
296 2019-08-06T14:25:16  *** EagleTM has joined #bitcoin-core-dev
297 2019-08-06T14:27:50  *** promag has joined #bitcoin-core-dev
298 2019-08-06T14:39:54  *** belcher has joined #bitcoin-core-dev
299 2019-08-06T14:42:55  *** laptop500 has quit IRC
300 2019-08-06T14:43:10  *** EagleTM has quit IRC
301 2019-08-06T14:43:34  *** EagleTM has joined #bitcoin-core-dev
302 2019-08-06T14:44:18  *** mdunnio has joined #bitcoin-core-dev
303 2019-08-06T14:49:07  *** EagleTM has quit IRC
304 2019-08-06T14:49:29  *** bitcoin-git has joined #bitcoin-core-dev
305 2019-08-06T14:49:29  <bitcoin-git> [bitcoin] jamesob closed pull request #16487: validationinterface: add unused CChainState parameter (master...2019-07-au-vi-arg) https://github.com/bitcoin/bitcoin/pull/16487
306 2019-08-06T14:49:29  *** EagleTM has joined #bitcoin-core-dev
307 2019-08-06T14:49:43  *** bitcoin-git has left #bitcoin-core-dev
308 2019-08-06T14:53:05  *** EagleTM has quit IRC
309 2019-08-06T14:53:29  *** EagleTM has joined #bitcoin-core-dev
310 2019-08-06T14:55:32  *** mdunnio has quit IRC
311 2019-08-06T14:56:49  *** mdunnio has joined #bitcoin-core-dev
312 2019-08-06T14:57:13  *** belcher has quit IRC
313 2019-08-06T14:57:42  *** belcher has joined #bitcoin-core-dev
314 2019-08-06T15:00:02  *** MartinAS1 has quit IRC
315 2019-08-06T15:05:17  *** EagleTM has quit IRC
316 2019-08-06T15:05:39  *** EagleTM has joined #bitcoin-core-dev
317 2019-08-06T15:07:10  *** hebasto has joined #bitcoin-core-dev
318 2019-08-06T15:10:47  *** EagleTM has quit IRC
319 2019-08-06T15:11:09  *** EagleTM has joined #bitcoin-core-dev
320 2019-08-06T15:14:38  *** mzygar has quit IRC
321 2019-08-06T15:16:11  *** EagleTM has quit IRC
322 2019-08-06T15:16:36  *** EagleTM has joined #bitcoin-core-dev
323 2019-08-06T15:20:03  *** captjakk has joined #bitcoin-core-dev
324 2019-08-06T15:24:23  *** EagleTM has quit IRC
325 2019-08-06T15:24:43  *** EagleTM has joined #bitcoin-core-dev
326 2019-08-06T15:34:47  *** EagleTM has quit IRC
327 2019-08-06T15:35:09  *** EagleTM has joined #bitcoin-core-dev
328 2019-08-06T15:36:03  *** Skirmant has quit IRC
329 2019-08-06T15:36:10  *** pinheadmz has joined #bitcoin-core-dev
330 2019-08-06T15:38:19  *** EagleTM has quit IRC
331 2019-08-06T15:38:43  *** EagleTM has joined #bitcoin-core-dev
332 2019-08-06T15:38:57  *** captjakk has quit IRC
333 2019-08-06T15:39:13  *** setpill has quit IRC
334 2019-08-06T15:39:31  *** captjakk has joined #bitcoin-core-dev
335 2019-08-06T15:41:01  *** captjakk has quit IRC
336 2019-08-06T15:41:18  *** captjakk has joined #bitcoin-core-dev
337 2019-08-06T15:41:22  *** DavidMitchell[m] has quit IRC
338 2019-08-06T15:42:20  *** kormoc1 has joined #bitcoin-core-dev
339 2019-08-06T15:42:30  *** EagleTM has quit IRC
340 2019-08-06T15:42:33  *** DavidMitchell[m] has joined #bitcoin-core-dev
341 2019-08-06T15:42:54  *** EagleTM has joined #bitcoin-core-dev
342 2019-08-06T15:46:23  *** lightlike has joined #bitcoin-core-dev
343 2019-08-06T15:46:42  *** captjakk has quit IRC
344 2019-08-06T15:47:16  *** captjakk has joined #bitcoin-core-dev
345 2019-08-06T15:48:10  *** jarthur has joined #bitcoin-core-dev
346 2019-08-06T15:48:38  *** Skirmant has joined #bitcoin-core-dev
347 2019-08-06T15:50:23  *** EagleTM has quit IRC
348 2019-08-06T15:50:46  *** EagleTM has joined #bitcoin-core-dev
349 2019-08-06T15:51:52  *** captjakk has quit IRC
350 2019-08-06T16:12:21  *** promag has quit IRC
351 2019-08-06T16:16:00  *** hebasto has quit IRC
352 2019-08-06T16:20:25  *** Guyver2 has quit IRC
353 2019-08-06T16:26:11  *** Chris_Stewart_5 has quit IRC
354 2019-08-06T16:26:35  *** ghost43_ is now known as ghost43
355 2019-08-06T16:26:38  *** EagleTM has quit IRC
356 2019-08-06T16:27:03  *** EagleTM has joined #bitcoin-core-dev
357 2019-08-06T16:27:27  *** memo1234 has joined #bitcoin-core-dev
358 2019-08-06T16:31:54  *** memo1234 has quit IRC
359 2019-08-06T16:36:00  *** dviola has quit IRC
360 2019-08-06T16:36:29  *** mdunnio has quit IRC
361 2019-08-06T16:42:21  *** EagleTM has quit IRC
362 2019-08-06T16:42:43  *** EagleTM has joined #bitcoin-core-dev
363 2019-08-06T16:42:57  *** timothy has quit IRC
364 2019-08-06T16:44:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
365 2019-08-06T16:48:26  *** afk11 has quit IRC
366 2019-08-06T16:48:55  *** afk11 has joined #bitcoin-core-dev
367 2019-08-06T16:49:34  *** promag has joined #bitcoin-core-dev
368 2019-08-06T16:53:47  *** promag has quit IRC
369 2019-08-06T16:53:55  *** baldur has quit IRC
370 2019-08-06T16:56:19  *** captjakk has joined #bitcoin-core-dev
371 2019-08-06T16:57:56  *** EagleTM has quit IRC
372 2019-08-06T16:58:19  *** EagleTM has joined #bitcoin-core-dev
373 2019-08-06T17:08:19  *** captjakk has quit IRC
374 2019-08-06T17:08:54  *** captjakk has joined #bitcoin-core-dev
375 2019-08-06T17:13:22  *** captjakk has quit IRC
376 2019-08-06T17:13:31  *** mdunnio has joined #bitcoin-core-dev
377 2019-08-06T17:14:32  <jnewbery> The coinbase check was removed here: https://github.com/bitcoin/bitcoin/pull/15713/files#diff-b2bb174788c7409b671c46ccc86034bdL2163 (in PR 15713). I think we should just restore it
378 2019-08-06T17:14:53  <jnewbery> I didn't realise the log spam implications of removing that check
379 2019-08-06T17:18:48  *** mdunnio has quit IRC
380 2019-08-06T17:20:07  *** mdunnio has joined #bitcoin-core-dev
381 2019-08-06T17:23:07  *** EagleTM has quit IRC
382 2019-08-06T17:23:28  *** EagleTM has joined #bitcoin-core-dev
383 2019-08-06T17:24:08  *** CubicEarth has quit IRC
384 2019-08-06T17:26:12  *** mdunnio has quit IRC
385 2019-08-06T17:27:58  *** EagleTM has quit IRC
386 2019-08-06T17:28:30  *** mdunnio has joined #bitcoin-core-dev
387 2019-08-06T17:29:53  *** jb55 has joined #bitcoin-core-dev
388 2019-08-06T17:30:38  *** dviola has joined #bitcoin-core-dev
389 2019-08-06T17:33:35  *** Victor_sueca has joined #bitcoin-core-dev
390 2019-08-06T17:34:59  *** Victorsueca has quit IRC
391 2019-08-06T17:39:44  *** dviola has quit IRC
392 2019-08-06T17:44:50  *** jungly has quit IRC
393 2019-08-06T18:00:01  *** kormoc1 has quit IRC
394 2019-08-06T18:15:57  *** Bille has joined #bitcoin-core-dev
395 2019-08-06T18:18:18  *** reallll has joined #bitcoin-core-dev
396 2019-08-06T18:21:37  *** belcher has quit IRC
397 2019-08-06T18:36:40  *** mdunnio has quit IRC
398 2019-08-06T18:39:54  *** bitcoin-git has joined #bitcoin-core-dev
399 2019-08-06T18:39:54  <bitcoin-git> [bitcoin] jnewbery opened pull request #16557: [wallet] restore coinbase check in SubmitMemoryPoolAndRelay() (master...2019-08-restore-coinbase-check) https://github.com/bitcoin/bitcoin/pull/16557
400 2019-08-06T18:39:58  *** bitcoin-git has left #bitcoin-core-dev
401 2019-08-06T18:43:11  <jnewbery> kallewoof: 16557 should fix it for you
402 2019-08-06T18:43:30  *** ercwl has joined #bitcoin-core-dev
403 2019-08-06T18:43:55  *** laptop500 has joined #bitcoin-core-dev
404 2019-08-06T18:46:01  *** ercwl has quit IRC
405 2019-08-06T18:47:54  *** mdunnio has joined #bitcoin-core-dev
406 2019-08-06T18:48:42  *** dviola has joined #bitcoin-core-dev
407 2019-08-06T18:49:03  *** reallll is now known as belcher
408 2019-08-06T18:53:54  *** ercwl has joined #bitcoin-core-dev
409 2019-08-06T19:10:22  *** EagleTM has joined #bitcoin-core-dev
410 2019-08-06T19:11:13  *** Eagle[TM] has joined #bitcoin-core-dev
411 2019-08-06T19:14:37  *** EagleTM has quit IRC
412 2019-08-06T19:15:56  *** ca98am79 has joined #bitcoin-core-dev
413 2019-08-06T19:17:10  *** CubicEarth has joined #bitcoin-core-dev
414 2019-08-06T19:20:19  *** alko has quit IRC
415 2019-08-06T19:22:11  *** Skirmant has quit IRC
416 2019-08-06T19:22:38  *** Skirmant has joined #bitcoin-core-dev
417 2019-08-06T19:48:58  *** Victorsueca has joined #bitcoin-core-dev
418 2019-08-06T19:49:16  *** Victor_sueca has quit IRC
419 2019-08-06T19:56:08  *** ptiyoyip has joined #bitcoin-core-dev
420 2019-08-06T19:59:30  *** instabot has joined #bitcoin-core-dev
421 2019-08-06T20:00:07  *** ptiyoyip has quit IRC
422 2019-08-06T20:00:22  *** dgfhdfg has quit IRC
423 2019-08-06T20:06:31  *** ca98am79 has quit IRC
424 2019-08-06T20:21:38  *** tryphe has quit IRC
425 2019-08-06T20:22:02  *** tryphe has joined #bitcoin-core-dev
426 2019-08-06T20:28:57  *** belcher has quit IRC
427 2019-08-06T20:31:26  *** lightlike has quit IRC
428 2019-08-06T20:35:19  *** Eagle[TM] has quit IRC
429 2019-08-06T20:36:04  *** lightlike has joined #bitcoin-core-dev
430 2019-08-06T20:44:20  *** EagleTM has joined #bitcoin-core-dev
431 2019-08-06T20:56:44  *** mdunnio has quit IRC
432 2019-08-06T21:00:01  *** Bille has quit IRC
433 2019-08-06T21:00:31  *** mdunnio has joined #bitcoin-core-dev
434 2019-08-06T21:01:48  *** mdunnio has quit IRC
435 2019-08-06T21:04:34  *** VitamineD has joined #bitcoin-core-dev
436 2019-08-06T21:06:09  *** ptiyoyip has joined #bitcoin-core-dev
437 2019-08-06T21:09:10  *** mdunnio has joined #bitcoin-core-dev
438 2019-08-06T21:09:38  *** justan0theruser is now known as justanotheruser
439 2019-08-06T21:10:11  *** mdunnio has quit IRC
440 2019-08-06T21:23:58  *** Chris_Stewart_5 has quit IRC
441 2019-08-06T21:34:30  *** instabot has quit IRC
442 2019-08-06T21:37:27  <achow101> did the code signatures for 0.18.1 go up yet?
443 2019-08-06T21:43:31  *** emilengler has joined #bitcoin-core-dev
444 2019-08-06T21:47:01  *** davex_ has joined #bitcoin-core-dev
445 2019-08-06T21:47:57  *** davex__ has quit IRC
446 2019-08-06T21:55:17  *** liberiga has joined #bitcoin-core-dev
447 2019-08-06T22:01:10  *** _atos has quit IRC
448 2019-08-06T22:22:24  *** jarthur has quit IRC
449 2019-08-06T22:25:33  *** bitcoin-git has joined #bitcoin-core-dev
450 2019-08-06T22:25:34  <bitcoin-git> [bitcoin] gapeman opened pull request #16558: Update headers to 2019 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16558
451 2019-08-06T22:25:35  *** bitcoin-git has left #bitcoin-core-dev
452 2019-08-06T22:38:07  *** promag has joined #bitcoin-core-dev
453 2019-08-06T22:39:18  *** bitcoin-git has joined #bitcoin-core-dev
454 2019-08-06T22:39:19  <bitcoin-git> [bitcoin] fanquake closed pull request #16558: Update headers to 2019 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16558
455 2019-08-06T22:39:20  *** bitcoin-git has left #bitcoin-core-dev
456 2019-08-06T22:45:30  *** bitcoin-git has joined #bitcoin-core-dev
457 2019-08-06T22:45:30  <bitcoin-git> [bitcoin] gapeman opened pull request #16559: Unified text outputs (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16559
458 2019-08-06T22:45:33  *** bitcoin-git has left #bitcoin-core-dev
459 2019-08-06T22:50:53  *** ercwl has quit IRC
460 2019-08-06T22:51:42  *** Skirmant has quit IRC
461 2019-08-06T23:00:26  *** EagleTM has quit IRC
462 2019-08-06T23:01:32  *** AaronvanW has quit IRC
463 2019-08-06T23:03:23  *** Skirmant has joined #bitcoin-core-dev
464 2019-08-06T23:16:19  *** laptop500 has quit IRC
465 2019-08-06T23:17:48  *** dgfhdfg has joined #bitcoin-core-dev
466 2019-08-06T23:18:07  *** bitcoin-git has joined #bitcoin-core-dev
467 2019-08-06T23:18:07  <bitcoin-git> [bitcoin] luke-jr opened pull request #16560: Bugfix: QA: Run tests with UPnP disabled (master...test_without_upnp) https://github.com/bitcoin/bitcoin/pull/16560
468 2019-08-06T23:18:21  *** bitcoin-git has left #bitcoin-core-dev
469 2019-08-06T23:20:35  *** ptiyoyip has quit IRC
470 2019-08-06T23:25:48  *** mryandao_ has joined #bitcoin-core-dev
471 2019-08-06T23:26:22  *** mryandao has quit IRC
472 2019-08-06T23:34:00  *** mryandao_ is now known as mryandao
473 2019-08-06T23:37:47  *** captjakk has joined #bitcoin-core-dev
474 2019-08-06T23:41:59  *** AaronvanW has joined #bitcoin-core-dev
475 2019-08-06T23:46:18  *** AaronvanW has quit IRC
476 2019-08-06T23:50:40  *** marcinja_ has joined #bitcoin-core-dev
477 2019-08-06T23:59:52  *** laptop500 has joined #bitcoin-core-dev