1 2019-08-07T00:00:02  *** VitamineD has quit IRC
  2 2019-08-07T00:02:39  *** AaronvanW has joined #bitcoin-core-dev
  3 2019-08-07T00:03:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  4 2019-08-07T00:04:51  *** scf-1 has joined #bitcoin-core-dev
  5 2019-08-07T00:10:18  *** shtirlic has quit IRC
  6 2019-08-07T00:10:36  *** baldur has joined #bitcoin-core-dev
  7 2019-08-07T00:10:36  *** shtirlic has joined #bitcoin-core-dev
  8 2019-08-07T00:14:41  <fanquake> sipa: would you be able to address feedback in #15558 when you get a chance?
  9 2019-08-07T00:14:44  <gribble> https://github.com/bitcoin/bitcoin/issues/15558 | Dont query all DNS seeds at once by sipa · Pull Request #15558 · bitcoin/bitcoin · GitHub
 10 2019-08-07T00:23:06  <sipa> fanquake: on it
 11 2019-08-07T00:25:39  *** dviola has quit IRC
 12 2019-08-07T00:26:50  <fanquake> sipa: cheers
 13 2019-08-07T00:34:38  *** instagibbs has quit IRC
 14 2019-08-07T00:35:53  *** AaronvanW has quit IRC
 15 2019-08-07T00:35:58  *** instagibbs has joined #bitcoin-core-dev
 16 2019-08-07T00:46:38  *** captjakk has quit IRC
 17 2019-08-07T00:51:48  *** liberiga has quit IRC
 18 2019-08-07T01:10:19  *** dgfhdfg has quit IRC
 19 2019-08-07T01:11:06  *** AaronvanW has joined #bitcoin-core-dev
 20 2019-08-07T01:13:34  *** laptop500 has quit IRC
 21 2019-08-07T01:15:58  *** AaronvanW has quit IRC
 22 2019-08-07T01:35:56  *** lightlike has quit IRC
 23 2019-08-07T01:41:13  *** promag has quit IRC
 24 2019-08-07T01:43:29  *** AaronvanW has joined #bitcoin-core-dev
 25 2019-08-07T01:48:16  *** AaronvanW has quit IRC
 26 2019-08-07T01:52:27  *** Bullitje has joined #bitcoin-core-dev
 27 2019-08-07T01:54:31  *** Bullit has quit IRC
 28 2019-08-07T01:54:38  *** Chris_Stewart_5 has quit IRC
 29 2019-08-07T02:04:54  *** nijak_ has quit IRC
 30 2019-08-07T02:14:53  *** AaronvanW has joined #bitcoin-core-dev
 31 2019-08-07T02:16:18  *** fox2p has joined #bitcoin-core-dev
 32 2019-08-07T02:16:59  *** fox2p_ has joined #bitcoin-core-dev
 33 2019-08-07T02:19:12  *** AaronvanW has quit IRC
 34 2019-08-07T02:20:51  *** fox2p has quit IRC
 35 2019-08-07T02:54:12  *** AaronvanW has joined #bitcoin-core-dev
 36 2019-08-07T02:58:48  *** AaronvanW has quit IRC
 37 2019-08-07T03:00:02  *** scf-1 has quit IRC
 38 2019-08-07T03:11:56  *** mzygar has joined #bitcoin-core-dev
 39 2019-08-07T03:16:09  *** promag has joined #bitcoin-core-dev
 40 2019-08-07T03:16:18  *** mzygar has quit IRC
 41 2019-08-07T03:18:28  *** gnomus has joined #bitcoin-core-dev
 42 2019-08-07T03:19:00  *** promag has quit IRC
 43 2019-08-07T03:33:41  *** AaronvanW has joined #bitcoin-core-dev
 44 2019-08-07T03:38:28  *** AaronvanW has quit IRC
 45 2019-08-07T03:39:20  *** jb55 has quit IRC
 46 2019-08-07T03:53:40  *** DeanGuss has joined #bitcoin-core-dev
 47 2019-08-07T04:05:41  *** Cory has quit IRC
 48 2019-08-07T04:08:29  *** AaronvanW has joined #bitcoin-core-dev
 49 2019-08-07T04:11:20  *** Pasha has joined #bitcoin-core-dev
 50 2019-08-07T04:12:57  *** AaronvanW has quit IRC
 51 2019-08-07T04:14:31  *** Pasha is now known as Cory
 52 2019-08-07T04:31:53  *** Victor_sueca has joined #bitcoin-core-dev
 53 2019-08-07T04:34:28  *** Victorsueca has quit IRC
 54 2019-08-07T04:40:52  *** pinheadmz has quit IRC
 55 2019-08-07T04:40:58  *** pinheadmz_ has joined #bitcoin-core-dev
 56 2019-08-07T04:42:20  *** AaronvanW has joined #bitcoin-core-dev
 57 2019-08-07T04:47:00  *** AaronvanW has quit IRC
 58 2019-08-07T04:52:08  *** pinheadmz_ has quit IRC
 59 2019-08-07T05:18:58  *** EagleTM has joined #bitcoin-core-dev
 60 2019-08-07T05:39:37  *** emilengler has quit IRC
 61 2019-08-07T05:52:07  *** pinheadmz has joined #bitcoin-core-dev
 62 2019-08-07T05:53:31  *** AaronvanW has joined #bitcoin-core-dev
 63 2019-08-07T05:54:37  *** EagleTM has quit IRC
 64 2019-08-07T06:00:01  *** gnomus has quit IRC
 65 2019-08-07T06:01:23  *** ThomasLuong has joined #bitcoin-core-dev
 66 2019-08-07T06:04:21  *** ironmarx has joined #bitcoin-core-dev
 67 2019-08-07T06:25:24  *** davterra has joined #bitcoin-core-dev
 68 2019-08-07T06:26:50  *** AaronvanW has quit IRC
 69 2019-08-07T06:29:40  *** jungly has joined #bitcoin-core-dev
 70 2019-08-07T06:36:58  *** promag has joined #bitcoin-core-dev
 71 2019-08-07T06:41:10  *** promag has quit IRC
 72 2019-08-07T06:57:53  *** AaronvanW has joined #bitcoin-core-dev
 73 2019-08-07T06:59:12  *** justanotheruser has quit IRC
 74 2019-08-07T07:02:08  *** AaronvanW has quit IRC
 75 2019-08-07T07:06:46  *** DeanGuss has quit IRC
 76 2019-08-07T07:06:48  *** Dean_Guss has joined #bitcoin-core-dev
 77 2019-08-07T07:18:32  *** AaronvanW has joined #bitcoin-core-dev
 78 2019-08-07T07:38:00  *** sylvanas has joined #bitcoin-core-dev
 79 2019-08-07T07:42:12  *** sylvanas has left #bitcoin-core-dev
 80 2019-08-07T07:54:07  *** Guyver2 has joined #bitcoin-core-dev
 81 2019-08-07T08:26:34  <fanquake> jonasschnelli: Will you be uploading some macOS sigs soonish? I can only see win sigs for 0.18.1 so far.
 82 2019-08-07T08:28:22  *** setpill has joined #bitcoin-core-dev
 83 2019-08-07T08:28:25  <jonasschnelli> fanquake: I will take a look when I'm back in my office (3-4h).
 84 2019-08-07T08:28:38  <fanquake> jonasschnelli: thanks!
 85 2019-08-07T08:33:10  *** jonatack has joined #bitcoin-core-dev
 86 2019-08-07T08:36:14  *** belcher has joined #bitcoin-core-dev
 87 2019-08-07T08:52:30  *** timothy has joined #bitcoin-core-dev
 88 2019-08-07T09:00:01  *** ironmarx has quit IRC
 89 2019-08-07T09:02:38  <kallewoof> jnewbery: see my comment on your PR
 90 2019-08-07T09:04:22  *** Kim2 has joined #bitcoin-core-dev
 91 2019-08-07T09:16:05  *** laptop500 has joined #bitcoin-core-dev
 92 2019-08-07T09:16:18  *** jungly has quit IRC
 93 2019-08-07T09:17:50  *** jungly has joined #bitcoin-core-dev
 94 2019-08-07T09:18:24  *** Guyver2 has quit IRC
 95 2019-08-07T09:39:46  *** setpill has quit IRC
 96 2019-08-07T09:41:58  *** setpill has joined #bitcoin-core-dev
 97 2019-08-07T09:45:28  <fanquake> promag: re steps to reproduce #16307 (sorry it's taken so long). The best I can give you is just spam load and unload wallet actions from the GUI. "Eventually" it might happen.
 98 2019-08-07T09:45:30  <gribble> https://github.com/bitcoin/bitcoin/issues/16307 | scheduler: crash after releasing wallet · Issue #16307 · bitcoin/bitcoin · GitHub
 99 2019-08-07T09:45:50  <fanquake> I saw a different, new crash today as well: https://gist.github.com/fanquake/678aea41c7d6a4f7de8e2ebf1efc3467
100 2019-08-07T09:51:18  *** ThomasLuong has quit IRC
101 2019-08-07T09:52:44  *** ercwl has joined #bitcoin-core-dev
102 2019-08-07T10:08:18  *** jonatack has quit IRC
103 2019-08-07T10:25:31  <provoostenator> Fun fact, and something to be aware of when reviewing: if Travis flags the account of a contributor, it won't build their pull request.
104 2019-08-07T10:25:57  <provoostenator> This doesn't show up as a failure! You still see a green check mark under the PR because of AppVeyor.
105 2019-08-07T10:26:29  <provoostenator> Also Travis doesn't email you when they flag your account, which is I why I didn't found out for days, see e.g. #16555
106 2019-08-07T10:26:31  <gribble> https://github.com/bitcoin/bitcoin/issues/16555 | [doc] mention whitelist is inbound, and applies to blocksonly by Sjors · Pull Request #16555 · bitcoin/bitcoin · GitHub
107 2019-08-07T10:26:44  <provoostenator> (I contacted their support now to ask what happened)
108 2019-08-07T10:27:57  *** promag has joined #bitcoin-core-dev
109 2019-08-07T10:28:19  <promag> fanquake: ok thanks, I'll see what I can find
110 2019-08-07T10:33:04  *** ercwl has quit IRC
111 2019-08-07T10:48:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
112 2019-08-07T10:51:19  *** rex4539 has joined #bitcoin-core-dev
113 2019-08-07T11:03:22  *** lightlike has joined #bitcoin-core-dev
114 2019-08-07T11:21:16  *** luke-jr has quit IRC
115 2019-08-07T11:21:24  *** bitcoin-git has joined #bitcoin-core-dev
116 2019-08-07T11:21:24  <bitcoin-git> [bitcoin] practicalswift opened pull request #16561: tests: Add test_runner.py option --parsable (master...parsable) https://github.com/bitcoin/bitcoin/pull/16561
117 2019-08-07T11:21:25  *** bitcoin-git has left #bitcoin-core-dev
118 2019-08-07T11:22:02  *** Skirmant has quit IRC
119 2019-08-07T11:26:12  *** luke-jr has joined #bitcoin-core-dev
120 2019-08-07T11:27:16  *** luke-jr has quit IRC
121 2019-08-07T11:29:33  *** luke-jr has joined #bitcoin-core-dev
122 2019-08-07T11:36:50  *** luke-jr has quit IRC
123 2019-08-07T11:39:06  *** luke-jr has joined #bitcoin-core-dev
124 2019-08-07T11:50:27  *** dgfhdfg has joined #bitcoin-core-dev
125 2019-08-07T12:00:02  *** Kim2 has quit IRC
126 2019-08-07T12:04:42  *** davidfischer has joined #bitcoin-core-dev
127 2019-08-07T12:05:04  *** davidfischer is now known as Guest84170
128 2019-08-07T12:05:40  *** justanotheruser has joined #bitcoin-core-dev
129 2019-08-07T12:11:01  *** bitcoin-git has joined #bitcoin-core-dev
130 2019-08-07T12:11:01  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465
131 2019-08-07T12:11:03  *** bitcoin-git has left #bitcoin-core-dev
132 2019-08-07T12:11:21  *** bitcoin-git has joined #bitcoin-core-dev
133 2019-08-07T12:11:21  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16465: test: Test p2sh-witness and bech32 in wallet_import_rescan (master...1907-testAllAddressTypesImport) https://github.com/bitcoin/bitcoin/pull/16465
134 2019-08-07T12:11:22  *** bitcoin-git has left #bitcoin-core-dev
135 2019-08-07T12:18:37  *** promag has quit IRC
136 2019-08-07T12:21:30  *** jonatack has joined #bitcoin-core-dev
137 2019-08-07T12:22:27  *** promag has joined #bitcoin-core-dev
138 2019-08-07T12:23:59  *** jonatack has quit IRC
139 2019-08-07T12:26:49  *** dgfhdfg has quit IRC
140 2019-08-07T12:27:45  *** promag has quit IRC
141 2019-08-07T12:30:26  *** DeanWeen has joined #bitcoin-core-dev
142 2019-08-07T12:32:16  *** Dean_Guss has quit IRC
143 2019-08-07T12:32:42  <jnewbery> provoostenator: contributors' accounts have been flagged in the past because it looks like they're using travis for mining. An email to support usually gets in unblocked pretty quickly.
144 2019-08-07T12:33:49  *** rex4539 has quit IRC
145 2019-08-07T12:34:03  <MarcoFalke> provoostenator: Going to send them an email. I do this every couple of weeks, and I have an email template
146 2019-08-07T12:34:10  <MarcoFalke> God I can't wait to get rid of travis
147 2019-08-07T12:34:24  <provoostenator> Thanks, I sent them an email earlier today.
148 2019-08-07T12:37:00  *** promag has joined #bitcoin-core-dev
149 2019-08-07T12:38:17  <jnewbery> kallewoof: thanks. Will look at it this morning. I think behaviour is basically unchanged, except for log spam.
150 2019-08-07T12:39:00  <MarcoFalke> I guess it makes sense to revert the "Remove redundant checks" commit
151 2019-08-07T12:39:42  *** promag has quit IRC
152 2019-08-07T12:41:15  *** astro has quit IRC
153 2019-08-07T12:41:15  <MarcoFalke> Assuming a wallet with 100k txs, this will fill up the debug log in no time
154 2019-08-07T12:41:32  *** astro has joined #bitcoin-core-dev
155 2019-08-07T12:43:00  *** DeanWeen has quit IRC
156 2019-08-07T12:54:24  *** promag has joined #bitcoin-core-dev
157 2019-08-07T13:29:28  <jonasschnelli> OSX sigs for 0.18.1 are ready to review and merge: https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/28
158 2019-08-07T13:36:08  <jonasschnelli> [merged]
159 2019-08-07T13:36:23  <jonasschnelli> !start your gitian builders!
160 2019-08-07T13:36:23  <gribble> Error: "start" is not a valid command.
161 2019-08-07T13:36:31  <fanquake> 🚀
162 2019-08-07T13:51:31  *** timothy has quit IRC
163 2019-08-07T13:53:32  <jonasschnelli> fanquake: wait... it's not merged. :)
164 2019-08-07T13:53:37  * jonasschnelli stops his gitian build
165 2019-08-07T13:53:44  <jonasschnelli> https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/28 still open
166 2019-08-07T13:53:54  <jonasschnelli> (confused it with my gitian sigs)
167 2019-08-07T14:00:05  <fanquake> jonasschnelli: yea I only merged your sigs. Cory can check the detached.
168 2019-08-07T14:00:16  <jonasschnelli> sure... thanks
169 2019-08-07T14:30:33  *** hebasto has joined #bitcoin-core-dev
170 2019-08-07T14:33:38  <gleb> fanquake: btw thanks for pointing me to the PRs I looked at at some point but never ended up reviewing :)
171 2019-08-07T14:35:18  <fanquake> gleb: no worries 👍
172 2019-08-07T14:35:35  <fanquake> Thanks for following up
173 2019-08-07T14:42:49  *** bitcoin-git has joined #bitcoin-core-dev
174 2019-08-07T14:42:49  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #16562: Refactor message transport packaging (master...2019/06/net_refactor_2) https://github.com/bitcoin/bitcoin/pull/16562
175 2019-08-07T14:42:50  *** bitcoin-git has left #bitcoin-core-dev
176 2019-08-07T14:45:39  *** laptop500 has quit IRC
177 2019-08-07T14:47:51  *** mdunnio has joined #bitcoin-core-dev
178 2019-08-07T14:52:03  * provoostenator aborts gitian build
179 2019-08-07T14:52:32  *** mdunnio has joined #bitcoin-core-dev
180 2019-08-07T14:53:15  <provoostenator> Optech newsletter jumped the gun on "Upgrade to Bitcoin Core 0.18.1"
181 2019-08-07T14:54:27  *** mdunnio has quit IRC
182 2019-08-07T14:54:53  <jnewbery> oops. We'll tweet a correction and update the newsletter on our site.
183 2019-08-07T14:55:45  *** mdunnio has joined #bitcoin-core-dev
184 2019-08-07T14:57:13  *** timothy has joined #bitcoin-core-dev
185 2019-08-07T15:00:01  *** Guest84170 has quit IRC
186 2019-08-07T15:07:33  *** bitcoin-git has joined #bitcoin-core-dev
187 2019-08-07T15:07:33  <bitcoin-git> [bitcoin] mzumsande opened pull request #16563: test: Add unit test for AddTimeData (master...201908_test_timedata) https://github.com/bitcoin/bitcoin/pull/16563
188 2019-08-07T15:07:34  *** bitcoin-git has left #bitcoin-core-dev
189 2019-08-07T15:15:46  *** glidenote1 has joined #bitcoin-core-dev
190 2019-08-07T15:18:24  *** ccdle12 has joined #bitcoin-core-dev
191 2019-08-07T15:30:53  *** setpill has quit IRC
192 2019-08-07T15:38:55  *** mryandao_ has joined #bitcoin-core-dev
193 2019-08-07T15:39:09  *** bitcoin-git has joined #bitcoin-core-dev
194 2019-08-07T15:39:10  <bitcoin-git> [bitcoin] candrews opened pull request #16564: Always define the raii_event_tests test suite (0.18...patch-1) https://github.com/bitcoin/bitcoin/pull/16564
195 2019-08-07T15:39:22  *** bitcoin-git has left #bitcoin-core-dev
196 2019-08-07T15:41:44  *** mryandao has quit IRC
197 2019-08-07T15:49:44  *** captjakk has joined #bitcoin-core-dev
198 2019-08-07T16:16:55  *** Chris_Stewart_5 has quit IRC
199 2019-08-07T16:23:32  *** mryandao has joined #bitcoin-core-dev
200 2019-08-07T16:25:36  *** mryandao_ has quit IRC
201 2019-08-07T16:27:57  *** mryandao_ has joined #bitcoin-core-dev
202 2019-08-07T16:30:44  *** mryandao has quit IRC
203 2019-08-07T16:31:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
204 2019-08-07T16:34:33  *** PaulTroon has joined #bitcoin-core-dev
205 2019-08-07T16:35:25  *** mdunnio has quit IRC
206 2019-08-07T16:36:16  *** hebasto has quit IRC
207 2019-08-07T16:50:25  *** emilengler has joined #bitcoin-core-dev
208 2019-08-07T16:56:06  *** csknk has joined #bitcoin-core-dev
209 2019-08-07T16:56:30  *** jb55 has joined #bitcoin-core-dev
210 2019-08-07T16:57:27  *** timothy has quit IRC
211 2019-08-07T16:59:34  *** jarthur has joined #bitcoin-core-dev
212 2019-08-07T17:02:33  *** ThomasLuong has joined #bitcoin-core-dev
213 2019-08-07T17:07:57  *** mdunnio has joined #bitcoin-core-dev
214 2019-08-07T17:10:15  *** dviola has joined #bitcoin-core-dev
215 2019-08-07T17:12:40  *** mdunnio has quit IRC
216 2019-08-07T17:15:47  *** mdunnio has joined #bitcoin-core-dev
217 2019-08-07T17:17:10  *** luke-jr has quit IRC
218 2019-08-07T17:17:59  *** luke-jr has joined #bitcoin-core-dev
219 2019-08-07T17:25:20  *** luke-jr has quit IRC
220 2019-08-07T17:27:50  *** luke-jr has joined #bitcoin-core-dev
221 2019-08-07T17:30:14  *** justanotheruser has quit IRC
222 2019-08-07T17:31:01  *** luke-jr has quit IRC
223 2019-08-07T17:31:22  *** Emzy is now known as emzy
224 2019-08-07T17:36:18  <dongcarl> For addrv2, it seems that version messages are also affected... Not sure what the best way to resolve is. If we keep as is, then what do Torv3 senders/receivers set as their `addr_{from,recv}`? If we change to new serialization, old nodes will be confused. It seems that we need a versionv2 as well, that's upgraded to by first sending a versionv1? (kind of messy)
225 2019-08-07T17:36:22  *** luke-jr has joined #bitcoin-core-dev
226 2019-08-07T17:37:43  *** luke-jr has quit IRC
227 2019-08-07T17:38:23  *** luke-jr has joined #bitcoin-core-dev
228 2019-08-07T17:55:12  *** PaulTroon is now known as remyers
229 2019-08-07T17:55:48  *** alko has joined #bitcoin-core-dev
230 2019-08-07T17:56:43  *** remyers has left #bitcoin-core-dev
231 2019-08-07T17:56:47  *** remyers has joined #bitcoin-core-dev
232 2019-08-07T17:57:49  *** mdunnio has quit IRC
233 2019-08-07T18:00:02  *** glidenote1 has quit IRC
234 2019-08-07T18:02:58  *** mdunnio has joined #bitcoin-core-dev
235 2019-08-07T18:07:47  <jonasschnelli> dongcarl: good point. Maybe wumpus have made some thoughts already on this. Probably something for the thursday meeting.
236 2019-08-07T18:07:50  *** captjakk has quit IRC
237 2019-08-07T18:08:20  *** captjakk has joined #bitcoin-core-dev
238 2019-08-07T18:08:28  <dongcarl> jonasschnelli: Sounds good, I'll bring it up
239 2019-08-07T18:08:50  *** laptop500 has joined #bitcoin-core-dev
240 2019-08-07T18:12:36  *** captjakk has quit IRC
241 2019-08-07T18:13:27  *** kreative has joined #bitcoin-core-dev
242 2019-08-07T18:15:10  <jonasschnelli> requesting Cory review on https://github.com/bitcoin/bitcoin/pull/16562 (especially a comment on the joining of header&payload as single buffer in vSendMsg)
243 2019-08-07T18:18:23  *** reallll has joined #bitcoin-core-dev
244 2019-08-07T18:20:21  *** roconnor has joined #bitcoin-core-dev
245 2019-08-07T18:21:31  *** belcher has quit IRC
246 2019-08-07T18:27:11  *** ccdle12 has quit IRC
247 2019-08-07T18:29:51  *** mdunnio has quit IRC
248 2019-08-07T18:32:53  *** mdunnio has joined #bitcoin-core-dev
249 2019-08-07T18:35:29  *** csknk has quit IRC
250 2019-08-07T18:37:42  <fanquake> achow101 is currently live streaming some wallet dev: https://www.twitch.tv/achow101/
251 2019-08-07T18:43:07  <jonasschnelli> nice!
252 2019-08-07T18:57:32  *** ccdle12 has joined #bitcoin-core-dev
253 2019-08-07T18:58:57  *** jarthur has quit IRC
254 2019-08-07T19:04:06  *** StopAndDecrypt has joined #bitcoin-core-dev
255 2019-08-07T19:14:40  <wumpus> dongcarl: I don't think the address in the version message is of any relevance to tor, or other protocols where there's no known 'from' address
256 2019-08-07T19:16:11  <dongcarl> wumpus: what about  `addr_recv `?
257 2019-08-07T19:16:44  * dongcarl is complete aware that he might be misunderstanding this whole situation
258 2019-08-07T19:16:55  <dongcarl> completely*
259 2019-08-07T19:17:34  <sipa> i think we rely on the addr in the version message to tell a peer through which address we're connecting to them
260 2019-08-07T19:17:41  <sipa> to figure out which incoming addresses work
261 2019-08-07T19:17:53  <sipa> which would still exist with TorV3?
262 2019-08-07T19:18:24  *** ccdle12 has quit IRC
263 2019-08-07T19:20:33  <wumpus> sipa: oh, you're right
264 2019-08-07T19:20:53  <dongcarl> Oh, I'm only vaguely aware that this piece of logic exists... Is there documentation or code I can read?
265 2019-08-07T19:21:20  <sipa> i'm not sure it's particularly useful
266 2019-08-07T19:22:12  <wumpus> dongcarl: maybe this could be part of the https://github.com/bitcoin/bips/pull/766#issuecomment-517003833  sendaddrv2 message here to notify peers of addrv2 support (which was poroposed as alternative to the protocol version bump the BIP currently documents)
267 2019-08-07T19:23:03  *** justanotheruser has joined #bitcoin-core-dev
268 2019-08-07T19:23:19  <wumpus> dongcarl: I think the handling of the VERSION message is the only 'documentation' for this
269 2019-08-07T19:23:20  <sipa> a sendaddrv2 message would go after a version message though
270 2019-08-07T19:23:37  * dongcarl thinking
271 2019-08-07T19:23:39  <sipa> so maybe the proposal should be to send a specific dummy address in the version message when v2 is in use
272 2019-08-07T19:23:46  <wumpus> sipa: yes, so it can extend the version in the version message
273 2019-08-07T19:23:47  <sipa> and send the actual one inside the sendaddrv2
274 2019-08-07T19:23:52  <wumpus> yes, that
275 2019-08-07T19:23:57  <dongcarl> sipa: Yeah that's what I'm thinking
276 2019-08-07T19:24:00  <wumpus> I don't want to change the version message itself for this
277 2019-08-07T19:24:24  <wumpus> that's even worse than changing the protocol version :-)
278 2019-08-07T19:24:25  *** luke-jr has quit IRC
279 2019-08-07T19:25:17  <dongcarl> wumpus: I'm not 100% sure why we need sendaddrv2 though, why doesn't the protocl VERSION bump work?
280 2019-08-07T19:25:44  *** luke-jr has joined #bitcoin-core-dev
281 2019-08-07T19:25:47  <sipa> dongcarl: because protocol version bumps require monotonically increasing features
282 2019-08-07T19:25:53  <wumpus> dongcarl: please read the discussion in that PR
283 2019-08-07T19:25:59  <wumpus> dongcarl: (esp marcofalke's point)
284 2019-08-07T19:27:57  *** luke-jr has quit IRC
285 2019-08-07T19:28:26  *** ThomasLuong has quit IRC
286 2019-08-07T19:29:38  *** luke-jr has joined #bitcoin-core-dev
287 2019-08-07T19:30:09  *** EagleTM has joined #bitcoin-core-dev
288 2019-08-07T19:30:14  *** Guyver2 has joined #bitcoin-core-dev
289 2019-08-07T19:30:36  <dongcarl> wumpus: When I talked to MarcoFalke in person, he said it doesn't matter that much... But I can see the point for feature-monotonic protocol versions
290 2019-08-07T19:31:44  *** luke-jr has quit IRC
291 2019-08-07T19:31:50  <dongcarl> A little uncomfortable about adding another protocol message though...
292 2019-08-07T19:32:07  <wumpus> if we need an extended-version message anyway, then this could have the two purposes at once
293 2019-08-07T19:32:29  *** luke-jr has joined #bitcoin-core-dev
294 2019-08-07T19:32:36  * dongcarl thinking
295 2019-08-07T19:32:45  <wumpus> what's wrong with adidng another message?
296 2019-08-07T19:33:04  <wumpus> at least unknown messages are simply ignored, so they're pretty much free
297 2019-08-07T19:34:06  <dongcarl> wumpus: true... perhaps a naive thought but I was thinking maybe there needs to be a generic feature-signaling message for non-monotonic features that don't fit in the protocol version model.
298 2019-08-07T19:34:34  <wumpus> yes, it's unfortunate that that doesn't exist, but let's please not include that in the scope of this
299 2019-08-07T19:35:22  <dongcarl> wumpus: Of course not. Could you elaborate a little on how sendaddrv2 would serve dual purpose? I think I'm close to getting it but not quite
300 2019-08-07T19:36:19  <wumpus> so it would a) signal that the peer sending it can accept addrv2 messages, and b) can contain the wide address that was connected to (e.g. extend what was sent in the version message before it)
301 2019-08-07T19:36:42  *** MasterdonX has quit IRC
302 2019-08-07T19:37:27  <dongcarl> wumpus: And this would be sent by the connection initiator immediately after its `version` message, right?
303 2019-08-07T19:38:13  <wumpus> after the version handshake completes
304 2019-08-07T19:38:20  <wumpus> it's the same as sendheaders
305 2019-08-07T19:39:34  <dongcarl> wumpus: Okay, and there needs to be a stub netaddr in the version handshake if it's a wide address then?
306 2019-08-07T19:40:26  <wumpus> yes
307 2019-08-07T19:40:45  <sipa> yes, because you don't know whether the peer supports v2 yet by that point
308 2019-08-07T19:41:00  <wumpus> FWIW a lot of alterntative implementations always put localhost in the version message, so that's probably a good dummy
309 2019-08-07T19:41:10  *** Victor_sueca is now known as Victorsueca
310 2019-08-07T19:41:33  <dongcarl> wumpus: I was gunna use the SetInternal format on the "addrv2" string
311 2019-08-07T19:42:16  <wumpus> dongcarl: what do you mean?
312 2019-08-07T19:42:39  <wumpus> which addrv2 string? what setinternal format?
313 2019-08-07T19:43:07  <dongcarl> wumpus: you know the special address format we use to encode seed hostnames so that addrman knows where addresses came from?
314 2019-08-07T19:43:38  <wumpus> that will probably confuse other peers
315 2019-08-07T19:43:48  <wumpus> e.g. localhost is well known as a 'ignore' value
316 2019-08-07T19:43:50  <wumpus> that isn't
317 2019-08-07T19:43:58  <dongcarl> wumpus: roger that
318 2019-08-07T19:44:06  <sipa> agree
319 2019-08-07T19:44:34  <dongcarl> easier for non-Core implementers too...
320 2019-08-07T19:45:01  <wumpus> right, I think so too
321 2019-08-07T19:45:05  *** dgfhdfg has joined #bitcoin-core-dev
322 2019-08-07T19:45:14  <dongcarl> Okay, I'll try making a PR to the BIP repo, thanks wumpus and sipa for being patient with me
323 2019-08-07T19:45:42  *** pinheadmz has quit IRC
324 2019-08-07T19:45:52  *** Chris_Stewart_5 has quit IRC
325 2019-08-07T19:46:20  <wumpus> dongcarl: we should do that, though, we might want to wait with that until we're further along with the implementation, there seem to be many thing no one had realized (like the addresses in the version) until someone tried implementing it :)
326 2019-08-07T19:47:09  *** Eagle[TM] has joined #bitcoin-core-dev
327 2019-08-07T19:47:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
328 2019-08-07T19:48:01  <dongcarl> wumpus: You're right, this entire experience has taught me how important implementation is to spec iteration
329 2019-08-07T19:48:29  <dongcarl> I'll continue the implementation then, and we'll reconvene when I have something more testable
330 2019-08-07T19:48:30  <wumpus> same for me
331 2019-08-07T19:49:04  *** pinheadmz has joined #bitcoin-core-dev
332 2019-08-07T19:49:12  *** EagleTM has quit IRC
333 2019-08-07T19:51:59  <wumpus> I think the PR comments on https://github.com/bitcoin/bips/pull/766 is an ok place to keep track of things we want to change to the BIP until that
334 2019-08-07T19:52:15  <dongcarl> wumpus: One more thing... What will happen in the future if torv42 has 512-bit addresses or something?
335 2019-08-07T19:52:36  <wumpus> I don't follow the mailing list much
336 2019-08-07T19:52:43  <wumpus> dongcarl: this scheme is extensible
337 2019-08-07T19:53:10  <wumpus> it's possible to add new address types to it in another BIP
338 2019-08-07T19:53:18  <wumpus> old implementations ignore those
339 2019-08-07T19:53:46  <dongcarl> wumpus: I see, so we'd bump the max size in another BIP
340 2019-08-07T19:54:07  <dongcarl> wumpus: and the old client would ignore b/c of the max 32-byte restriction in the spec
341 2019-08-07T19:54:12  <sipa> there isn't a max size, right?
342 2019-08-07T19:54:22  <wumpus> "Field <code>addr</code> has a variable length, with a maximum of 32 bytes (256 bits). Clients SHOULD reject
343 2019-08-07T19:54:24  <wumpus> longer addresses.
344 2019-08-07T19:54:31  <sipa> ah
345 2019-08-07T19:55:03  <wumpus> I've added a maximum, might want to bump that if we realistically expect protocols with even larger addresses
346 2019-08-07T19:55:16  <wumpus> or even remove it
347 2019-08-07T19:55:47  <sipa> this could be an implementation aspect "Implementations MAY ignore address messages of an unknown type, or otherwise impose limits on the maximum size of addr messages for unknown types they relay.
348 2019-08-07T19:55:53  <wumpus> though, might want to keep some bound for deserialization DoS reasons?
349 2019-08-07T19:55:57  <sipa> yeah
350 2019-08-07T19:56:58  <dongcarl> should... implementations relay unknown types??
351 2019-08-07T19:57:02  <wumpus> "Client MAY store and gossip address formats that they do not know about. Further network ID numbers MUST be reserved in a new BIP document."
352 2019-08-07T19:57:17  <wumpus> they may
353 2019-08-07T19:57:38  <wumpus> it's not necessary, imo
354 2019-08-07T19:58:12  <dongcarl> wumpus: yeah, so this way there's no hard cap, but realistically there's a cap based on the max size corresponding to defined network IDs
355 2019-08-07T19:58:35  <sipa> probably best to recommand not to relay/store unknown types, at which point there is an implied max size anyway
356 2019-08-07T19:58:48  <sipa> for bandwidth DoS you could have a max size, but it can be fairly large
357 2019-08-07T19:59:19  <wumpus> the thing is you want to ignore individual unknown addresses even if they're larger than the cap, but not declare the entire addrv2 message they're in invalid
358 2019-08-07T19:59:30  <wumpus> right
359 2019-08-07T20:01:04  <sipa> like the limit could be 512 bytes or whatever; it's just so that you can instaban anyone who sends excessive things
360 2019-08-07T20:01:26  <wumpus> ok, so if an addrv2 message contains any item larger than that, the entire message is invalid
361 2019-08-07T20:01:46  *** mdunnio has quit IRC
362 2019-08-07T20:05:12  <wumpus> https://github.com/bitcoin/bips/pull/766#issuecomment-519248699
363 2019-08-07T20:06:52  <dongcarl> just to confirm, we still recommend to ignore individually for addresses that are in between MAX_KNOWN_NETWORK_ID_ADDR_LEN and 512 bytes, correct?
364 2019-08-07T20:07:10  <wumpus> yes
365 2019-08-07T20:07:30  <dongcarl> sorry, more accurately, for addresses that have unknown networkID and are below 512 bytes
366 2019-08-07T20:08:46  <wumpus> they are independent rules a) addresses of unknown type should be ignored, individually, independent of their size b) if the message contains anything larger than 512 bytes the whole message is invalid and anything in it is ignored
367 2019-08-07T20:08:48  *** luke-jr has quit IRC
368 2019-08-07T20:09:15  *** luke-jr has joined #bitcoin-core-dev
369 2019-08-07T20:10:20  *** reallll is now known as belcher
370 2019-08-07T20:16:15  *** mdunnio has joined #bitcoin-core-dev
371 2019-08-07T20:18:10  <dongcarl> wumpus: address of unknown type + 513 bytes addr field -> invalidate entire message (rule b), addr of unknown type + 512 bytes addr field -> ignore individually (rule a)
372 2019-08-07T20:22:59  *** Chris_Stewart_5 has quit IRC
373 2019-08-07T20:23:51  <wumpus> dongcarl: yes
374 2019-08-07T20:24:18  <wumpus> addr of known type + wrong-sized addr field -> also ignore individually, I think
375 2019-08-07T20:30:53  <dongcarl> wumpus: true
376 2019-08-07T20:32:54  *** pinheadmz has quit IRC
377 2019-08-07T20:42:55  *** ThomasLuong has joined #bitcoin-core-dev
378 2019-08-07T20:46:26  *** ercwl has joined #bitcoin-core-dev
379 2019-08-07T20:50:48  *** captjakk has joined #bitcoin-core-dev
380 2019-08-07T20:57:58  *** Eagle[TM] has quit IRC
381 2019-08-07T21:00:01  *** kreative has quit IRC
382 2019-08-07T21:04:34  *** seefischer has joined #bitcoin-core-dev
383 2019-08-07T21:05:05  *** MasterdonX has joined #bitcoin-core-dev
384 2019-08-07T21:05:56  *** diverger has joined #bitcoin-core-dev
385 2019-08-07T21:07:17  *** captjakk has quit IRC
386 2019-08-07T21:07:45  *** captjakk has joined #bitcoin-core-dev
387 2019-08-07T21:08:44  *** rh0nj has quit IRC
388 2019-08-07T21:10:20  *** rh0nj has joined #bitcoin-core-dev
389 2019-08-07T21:11:50  *** pinheadmz has joined #bitcoin-core-dev
390 2019-08-07T21:12:24  *** captjakk has quit IRC
391 2019-08-07T21:14:46  *** rh0nj has quit IRC
392 2019-08-07T21:18:12  *** EagleTM has joined #bitcoin-core-dev
393 2019-08-07T21:27:25  *** rh0nj has joined #bitcoin-core-dev
394 2019-08-07T21:29:45  *** promag has joined #bitcoin-core-dev
395 2019-08-07T21:37:21  *** promag has quit IRC
396 2019-08-07T21:44:34  *** simerax has joined #bitcoin-core-dev
397 2019-08-07T21:44:38  *** rh0nj has quit IRC
398 2019-08-07T21:45:27  *** jarthur has joined #bitcoin-core-dev
399 2019-08-07T21:55:32  *** booyah_ has quit IRC
400 2019-08-07T22:07:16  *** mdunnio has quit IRC
401 2019-08-07T22:07:22  *** promag has joined #bitcoin-core-dev
402 2019-08-07T22:08:39  *** mdunnio has joined #bitcoin-core-dev
403 2019-08-07T22:11:49  *** promag has quit IRC
404 2019-08-07T22:14:06  *** ercwl has quit IRC
405 2019-08-07T22:16:43  *** dviola has quit IRC
406 2019-08-07T22:19:27  *** dviola has joined #bitcoin-core-dev
407 2019-08-07T22:23:52  *** booyah_ has joined #bitcoin-core-dev
408 2019-08-07T22:26:52  *** AaronvanW has quit IRC
409 2019-08-07T22:27:38  *** booyah_ has quit IRC
410 2019-08-07T22:29:23  *** lnostdal has quit IRC
411 2019-08-07T22:40:16  *** justanotheruser has quit IRC
412 2019-08-07T22:41:25  *** Guyver2 has quit IRC
413 2019-08-07T22:47:01  *** mdunnio has quit IRC
414 2019-08-07T22:55:59  *** mdunnio has joined #bitcoin-core-dev
415 2019-08-07T22:56:07  *** justanotheruser has joined #bitcoin-core-dev
416 2019-08-07T22:56:45  *** mdunnio has quit IRC
417 2019-08-07T22:59:11  *** promag has joined #bitcoin-core-dev
418 2019-08-07T23:06:00  *** elichai2 has quit IRC
419 2019-08-07T23:12:19  *** mdunnio has joined #bitcoin-core-dev
420 2019-08-07T23:17:28  *** mdunnio has quit IRC
421 2019-08-07T23:17:42  *** dgfhdfg has quit IRC
422 2019-08-07T23:18:11  *** dgfhdfg has joined #bitcoin-core-dev
423 2019-08-07T23:27:27  *** promag has quit IRC
424 2019-08-07T23:28:26  *** mdunnio has joined #bitcoin-core-dev
425 2019-08-07T23:29:52  *** promag has joined #bitcoin-core-dev
426 2019-08-07T23:32:56  *** mdunnio has quit IRC
427 2019-08-07T23:42:57  *** dgfhdfg has quit IRC
428 2019-08-07T23:45:52  *** jarthur has quit IRC
429 2019-08-07T23:53:05  *** ThomasLuong has quit IRC