1 2019-08-14T00:00:02  *** Darki1 has quit IRC
  2 2019-08-14T00:05:07  *** visser_ has joined #bitcoin-core-dev
  3 2019-08-14T00:11:03  *** promag has joined #bitcoin-core-dev
  4 2019-08-14T00:15:31  *** promag has quit IRC
  5 2019-08-14T00:45:12  <pinheadmz> luke-jr: can you elaborate? How can any block not be subject to a better-work chain?
  6 2019-08-14T00:48:40  *** kljasdfvv has quit IRC
  7 2019-08-14T00:48:46  <harding> pinheadmz: the bad block corrupts the utxo db so that other chains don't look like valid chains to the old software.
  8 2019-08-14T00:49:04  *** kljasdfvv has joined #bitcoin-core-dev
  9 2019-08-14T00:50:06  <pinheadmz> harding: weird, thanks.
 10 2019-08-14T00:50:09  *** elichai2 has quit IRC
 11 2019-08-14T00:57:57  *** dviola has quit IRC
 12 2019-08-14T01:05:35  *** lightlike has quit IRC
 13 2019-08-14T01:20:46  *** Dean_Guss has joined #bitcoin-core-dev
 14 2019-08-14T01:27:59  *** xzytrewq has quit IRC
 15 2019-08-14T01:29:29  *** xzytrewq has joined #bitcoin-core-dev
 16 2019-08-14T01:40:08  *** AaronvanW has joined #bitcoin-core-dev
 17 2019-08-14T01:57:32  *** EagleTM has quit IRC
 18 2019-08-14T02:03:49  *** Dean_Guss has quit IRC
 19 2019-08-14T02:05:15  *** Dean_Guss has joined #bitcoin-core-dev
 20 2019-08-14T02:06:03  *** justanotheruser has quit IRC
 21 2019-08-14T02:13:06  *** AaronvanW has quit IRC
 22 2019-08-14T02:14:26  *** justanotheruser has joined #bitcoin-core-dev
 23 2019-08-14T02:25:23  *** hanhua has joined #bitcoin-core-dev
 24 2019-08-14T02:32:27  *** ddustin has joined #bitcoin-core-dev
 25 2019-08-14T02:37:16  *** ddustin has quit IRC
 26 2019-08-14T03:00:02  *** visser_ has quit IRC
 27 2019-08-14T03:02:33  *** pinheadmz has quit IRC
 28 2019-08-14T03:03:55  *** pinheadmz has joined #bitcoin-core-dev
 29 2019-08-14T03:09:28  *** astro has quit IRC
 30 2019-08-14T03:14:17  <kallewoof> luke-jr: I re-pushed it now that the first commit was merged. I assumed it wouldn't break as the commits were identical, but don't assume, I guess. trying to build now.
 31 2019-08-14T03:16:13  *** astro has joined #bitcoin-core-dev
 32 2019-08-14T03:37:06  *** ecrist1 has joined #bitcoin-core-dev
 33 2019-08-14T03:39:40  <kallewoof> luke-jr: it builds fine on my end. (and travis/appveyor seem to have no issues either)
 34 2019-08-14T03:40:55  <luke-jr> weird
 35 2019-08-14T03:51:14  *** seeder has joined #bitcoin-core-dev
 36 2019-08-14T04:09:40  *** AaronvanW has joined #bitcoin-core-dev
 37 2019-08-14T04:13:50  *** hanhua has quit IRC
 38 2019-08-14T04:18:11  *** ddustin has joined #bitcoin-core-dev
 39 2019-08-14T04:30:01  *** hanhua has joined #bitcoin-core-dev
 40 2019-08-14T04:42:57  *** AaronvanW has quit IRC
 41 2019-08-14T04:43:58  *** lalitmee has joined #bitcoin-core-dev
 42 2019-08-14T04:51:41  *** kristapsk has quit IRC
 43 2019-08-14T04:52:07  *** kristapsk has joined #bitcoin-core-dev
 44 2019-08-14T04:53:04  *** ppisati has quit IRC
 45 2019-08-14T04:54:32  *** sdaftuar has quit IRC
 46 2019-08-14T04:54:55  *** sdaftuar has joined #bitcoin-core-dev
 47 2019-08-14T04:59:43  *** ppisati has joined #bitcoin-core-dev
 48 2019-08-14T05:24:28  *** promag has joined #bitcoin-core-dev
 49 2019-08-14T05:28:47  *** promag has quit IRC
 50 2019-08-14T05:41:23  *** anemous has quit IRC
 51 2019-08-14T05:59:01  *** shesek has joined #bitcoin-core-dev
 52 2019-08-14T05:59:01  *** shesek has joined #bitcoin-core-dev
 53 2019-08-14T06:00:01  *** ecrist1 has quit IRC
 54 2019-08-14T06:00:36  *** AaronvanW has joined #bitcoin-core-dev
 55 2019-08-14T06:00:44  *** EagleTM has joined #bitcoin-core-dev
 56 2019-08-14T06:00:52  *** seeder has quit IRC
 57 2019-08-14T06:00:56  *** ddustin has quit IRC
 58 2019-08-14T06:01:32  *** ddustin has joined #bitcoin-core-dev
 59 2019-08-14T06:04:14  *** jonhcw has joined #bitcoin-core-dev
 60 2019-08-14T06:06:04  *** ddustin has quit IRC
 61 2019-08-14T06:13:12  *** bitcoin-git has joined #bitcoin-core-dev
 62 2019-08-14T06:13:12  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b799ebcc17ea...c3b605cf1301
 63 2019-08-14T06:13:13  <bitcoin-git> bitcoin/master fa7789f MarcoFalke: doc: Mention other ways to conserve memory on compilation
 64 2019-08-14T06:13:13  <bitcoin-git> bitcoin/master c3b605c fanquake: Merge #16586: doc: Mention other ways to conserve memory on compilation
 65 2019-08-14T06:13:16  *** bitcoin-git has left #bitcoin-core-dev
 66 2019-08-14T06:14:22  *** bitcoin-git has joined #bitcoin-core-dev
 67 2019-08-14T06:14:22  <bitcoin-git> [bitcoin] fanquake merged pull request #16586: doc: Mention other ways to conserve memory on compilation (master...1908-docLowMem) https://github.com/bitcoin/bitcoin/pull/16586
 68 2019-08-14T06:14:24  *** bitcoin-git has left #bitcoin-core-dev
 69 2019-08-14T06:19:37  *** EagleTM has quit IRC
 70 2019-08-14T06:19:59  *** tryphe has quit IRC
 71 2019-08-14T06:20:24  *** tryphe has joined #bitcoin-core-dev
 72 2019-08-14T06:39:44  *** nosss2 has quit IRC
 73 2019-08-14T06:46:31  *** bitcoin-git has joined #bitcoin-core-dev
 74 2019-08-14T06:46:32  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c3b605cf1301...05ccbe9a2991
 75 2019-08-14T06:46:32  <bitcoin-git> bitcoin/master afc0966 Elichai Turkel: Moved and renamed hash256 from util.py to zmq_interface.py
 76 2019-08-14T06:46:33  <bitcoin-git> bitcoin/master 05ccbe9 fanquake: Merge #16598: test: Remove confusing hash256 function in util
 77 2019-08-14T06:46:34  *** bitcoin-git has left #bitcoin-core-dev
 78 2019-08-14T06:47:36  *** bitcoin-git has joined #bitcoin-core-dev
 79 2019-08-14T06:47:37  <bitcoin-git> [bitcoin] fanquake merged pull request #16598: test: Remove confusing hash256 function in util (master...2019-08-rename-hash256) https://github.com/bitcoin/bitcoin/pull/16598
 80 2019-08-14T06:47:38  *** bitcoin-git has left #bitcoin-core-dev
 81 2019-08-14T06:54:52  *** sdaftuar has quit IRC
 82 2019-08-14T06:55:18  *** sdaftuar has joined #bitcoin-core-dev
 83 2019-08-14T06:57:04  *** hanhua has quit IRC
 84 2019-08-14T07:04:03  *** AaronvanW has quit IRC
 85 2019-08-14T07:13:04  *** Dean_Guss has quit IRC
 86 2019-08-14T07:13:48  *** lalitmee has quit IRC
 87 2019-08-14T07:19:55  *** jungly has joined #bitcoin-core-dev
 88 2019-08-14T07:34:12  *** xzytrewq has quit IRC
 89 2019-08-14T07:50:45  *** kljasdfvv has quit IRC
 90 2019-08-14T07:52:22  *** kljasdfvv has joined #bitcoin-core-dev
 91 2019-08-14T08:03:20  *** lalitmee has joined #bitcoin-core-dev
 92 2019-08-14T08:14:40  *** bitcoin-git has joined #bitcoin-core-dev
 93 2019-08-14T08:14:40  <bitcoin-git> [bitcoin] fanquake closed pull request #15032: Nit fixes for PR 14565 (master...201812_pr_14565_nits) https://github.com/bitcoin/bitcoin/pull/15032
 94 2019-08-14T08:14:44  *** bitcoin-git has left #bitcoin-core-dev
 95 2019-08-14T08:37:04  *** jpe_ has joined #bitcoin-core-dev
 96 2019-08-14T08:39:03  *** setpill has joined #bitcoin-core-dev
 97 2019-08-14T08:41:09  *** timothy has joined #bitcoin-core-dev
 98 2019-08-14T08:42:33  *** jpe_ has quit IRC
 99 2019-08-14T08:53:56  *** AaronvanW has joined #bitcoin-core-dev
100 2019-08-14T08:56:18  *** AaronvanW has quit IRC
101 2019-08-14T09:00:01  *** jonhcw has quit IRC
102 2019-08-14T09:01:05  *** drizztbsd has joined #bitcoin-core-dev
103 2019-08-14T09:01:36  *** timothy has quit IRC
104 2019-08-14T09:05:12  *** [42]1 has joined #bitcoin-core-dev
105 2019-08-14T09:07:19  *** bitcoin-git has joined #bitcoin-core-dev
106 2019-08-14T09:07:19  <bitcoin-git> [bitcoin] fanquake closed pull request #14079: Implement sighash cache in CHECKMULTISIG (master...cms_cache) https://github.com/bitcoin/bitcoin/pull/14079
107 2019-08-14T09:07:20  *** bitcoin-git has left #bitcoin-core-dev
108 2019-08-14T09:15:02  *** AaronvanW has joined #bitcoin-core-dev
109 2019-08-14T09:22:37  *** harrigan has joined #bitcoin-core-dev
110 2019-08-14T09:28:06  *** jonatack has quit IRC
111 2019-08-14T09:37:45  *** bitcoin-git has joined #bitcoin-core-dev
112 2019-08-14T09:37:45  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/05ccbe9a2991...b120645e8cfc
113 2019-08-14T09:37:46  <bitcoin-git> bitcoin/master fa1e9c6 MarcoFalke: travis: Bump timeout from 50 minutes to 90
114 2019-08-14T09:37:46  <bitcoin-git> bitcoin/master b120645 Wladimir J. van der Laan: Merge #16595: travis: use extended 90 minute timeout when available
115 2019-08-14T09:37:48  *** bitcoin-git has left #bitcoin-core-dev
116 2019-08-14T09:38:55  *** bitcoin-git has joined #bitcoin-core-dev
117 2019-08-14T09:38:55  <bitcoin-git> [bitcoin] laanwj merged pull request #16595: travis: use extended 90 minute timeout when available (master...1908-travisNoTimeout) https://github.com/bitcoin/bitcoin/pull/16595
118 2019-08-14T09:38:59  *** bitcoin-git has left #bitcoin-core-dev
119 2019-08-14T09:39:03  <fanquake> I've just closed the 0.18.1 milestone. https://github.com/bitcoin/bitcoin/milestones/41
120 2019-08-14T09:45:35  <meshcollider> is it too late to add a missing contributor to the 0.18.1 release notes?
121 2019-08-14T09:46:22  <meshcollider> fanquake: advice? ^
122 2019-08-14T09:47:28  <fanquake> meshcollider: You could add them to the release notes on GH I guess? Obviously too late for the mailing lists etc
123 2019-08-14T09:47:53  <meshcollider> ok just wanted to check there wasn't a policy against amending release notes in branches
124 2019-08-14T09:48:13  <meshcollider> specifically it is the reporter of this issue #16011 who followed up with PR #16012 and helped with 16022 among others
125 2019-08-14T09:48:14  <gribble> https://github.com/bitcoin/bitcoin/issues/16011 | addmultisigaddress does not fallback to legacy when there are uncompressed public keys in the parameters · Issue #16011 · bitcoin/bitcoin · GitHub
126 2019-08-14T09:48:17  <gribble> https://github.com/bitcoin/bitcoin/issues/16012 | rpc: addmultisigaddress should fallback to OutputType::LEGACY when uncompressed public keys are provided by ps1dr3x · Pull Request #16012 · bitcoin/bitcoin · GitHub
127 2019-08-14T09:48:22  <meshcollider> I think he should definitely be acknowledged
128 2019-08-14T09:50:07  <fanquake> meshcollider fair enough. I don't have a problem with it, and it's right after release. What we don't like it someone turning up and "fixing" typos in the 0.5.x release notes etc
129 2019-08-14T09:50:32  <meshcollider> fanquake: yeah, makes sense :)
130 2019-08-14T09:58:55  *** bitcoin-git has joined #bitcoin-core-dev
131 2019-08-14T09:58:55  <bitcoin-git> [bitcoin] meshcollider opened pull request #16604: [0.18] Add missing contributor to 0.18.1 release notes (0.18...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16604
132 2019-08-14T09:58:57  *** bitcoin-git has left #bitcoin-core-dev
133 2019-08-14T10:20:53  *** bitcoin-git has joined #bitcoin-core-dev
134 2019-08-14T10:20:54  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b120645e8cfc...b49e7796c298
135 2019-08-14T10:20:55  <bitcoin-git> bitcoin/master 3303124 fanquake: build: disable libxcb extensions
136 2019-08-14T10:20:55  <bitcoin-git> bitcoin/master b49e779 Wladimir J. van der Laan: Merge #16533: build: disable libxcb extensions
137 2019-08-14T10:21:07  *** bitcoin-git has left #bitcoin-core-dev
138 2019-08-14T10:21:53  *** bitcoin-git has joined #bitcoin-core-dev
139 2019-08-14T10:21:54  <bitcoin-git> [bitcoin] laanwj merged pull request #16533: build: disable libxcb extensions (master...disable_xcb_extensions) https://github.com/bitcoin/bitcoin/pull/16533
140 2019-08-14T10:21:55  *** bitcoin-git has left #bitcoin-core-dev
141 2019-08-14T10:31:02  *** jonatack has joined #bitcoin-core-dev
142 2019-08-14T10:41:04  *** bitcoin-git has joined #bitcoin-core-dev
143 2019-08-14T10:41:04  <bitcoin-git> [bitcoin] meshcollider closed pull request #16604: [0.18] Add missing contributor to 0.18.1 release notes (0.18...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16604
144 2019-08-14T10:41:18  *** bitcoin-git has left #bitcoin-core-dev
145 2019-08-14T10:47:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
146 2019-08-14T10:50:02  *** jonatack has quit IRC
147 2019-08-14T10:52:02  *** jonatack has joined #bitcoin-core-dev
148 2019-08-14T11:03:57  *** bitcoin-git has joined #bitcoin-core-dev
149 2019-08-14T11:03:57  <bitcoin-git> [bitcoin] meshcollider opened pull request #16605: Add missing contributor to 0.18.1 release notes  (master...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16605
150 2019-08-14T11:03:58  *** bitcoin-git has left #bitcoin-core-dev
151 2019-08-14T11:04:01  *** lnostdal has joined #bitcoin-core-dev
152 2019-08-14T11:08:08  *** jonatack has quit IRC
153 2019-08-14T11:08:25  *** jonatack has joined #bitcoin-core-dev
154 2019-08-14T11:08:56  *** bitcoin-git has joined #bitcoin-core-dev
155 2019-08-14T11:08:56  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.18: https://github.com/bitcoin/bitcoin/compare/fa27a0760792...bbc2970082a2
156 2019-08-14T11:08:56  <bitcoin-git> bitcoin/0.18 bbc2970 Wladimir J. van der Laan: doc: Clean out release notes post-0.18.1
157 2019-08-14T11:08:59  *** bitcoin-git has left #bitcoin-core-dev
158 2019-08-14T11:16:29  *** bitcoin-git has joined #bitcoin-core-dev
159 2019-08-14T11:16:29  <bitcoin-git> [bitcoin] jesuscristincarbajal opened pull request #16606: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16606
160 2019-08-14T11:16:30  *** bitcoin-git has left #bitcoin-core-dev
161 2019-08-14T11:17:15  *** bitcoin-git has joined #bitcoin-core-dev
162 2019-08-14T11:17:15  <bitcoin-git> [bitcoin] fanquake closed pull request #16606: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16606
163 2019-08-14T11:17:16  *** bitcoin-git has left #bitcoin-core-dev
164 2019-08-14T11:18:31  *** bitcoin-git has joined #bitcoin-core-dev
165 2019-08-14T11:18:31  <bitcoin-git> [bitcoin] jesuscristincarbajal opened pull request #16607: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16607
166 2019-08-14T11:18:36  *** bitcoin-git has left #bitcoin-core-dev
167 2019-08-14T11:19:06  *** bitcoin-git has joined #bitcoin-core-dev
168 2019-08-14T11:19:06  <bitcoin-git> [bitcoin] fanquake closed pull request #16607: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/16607
169 2019-08-14T11:19:20  *** bitcoin-git has left #bitcoin-core-dev
170 2019-08-14T11:19:53  <wumpus> ugh PR spam
171 2019-08-14T11:19:59  *** tryphe has quit IRC
172 2019-08-14T11:20:25  *** tryphe has joined #bitcoin-core-dev
173 2019-08-14T11:21:31  *** bitcoin-git has joined #bitcoin-core-dev
174 2019-08-14T11:21:31  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b49e7796c298...286332495d43
175 2019-08-14T11:21:32  <bitcoin-git> bitcoin/master 862cbf3 MeshCollider: Add missing contributor to release notes
176 2019-08-14T11:21:32  <bitcoin-git> bitcoin/master 2863324 Wladimir J. van der Laan: Merge #16605: Add missing contributor to 0.18.1 release notes
177 2019-08-14T11:21:34  *** bitcoin-git has left #bitcoin-core-dev
178 2019-08-14T11:22:36  *** bitcoin-git has joined #bitcoin-core-dev
179 2019-08-14T11:22:36  <bitcoin-git> [bitcoin] laanwj merged pull request #16605: Add missing contributor to 0.18.1 release notes  (master...201908_update_release_notes) https://github.com/bitcoin/bitcoin/pull/16605
180 2019-08-14T11:22:37  *** bitcoin-git has left #bitcoin-core-dev
181 2019-08-14T11:31:04  *** bitcoin-git has joined #bitcoin-core-dev
182 2019-08-14T11:31:06  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/286332495d43...e7df1ecd1758
183 2019-08-14T11:31:06  <bitcoin-git> bitcoin/master 2290269 Sjors Provoost: scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg
184 2019-08-14T11:31:07  <bitcoin-git> bitcoin/master 2e68ffa Sjors Provoost: [doc] descriptor: explain GetPubKey() usage with cached public key
185 2019-08-14T11:31:08  <bitcoin-git> bitcoin/master e7df1ec Wladimir J. van der Laan: Merge #14934: Descriptor expansion cache clarifications
186 2019-08-14T11:31:10  *** bitcoin-git has left #bitcoin-core-dev
187 2019-08-14T11:31:24  *** bitcoin-git has joined #bitcoin-core-dev
188 2019-08-14T11:31:24  <bitcoin-git> [bitcoin] laanwj merged pull request #14934: Descriptor expansion cache clarifications (master...2018/12/rename_m_script_arg) https://github.com/bitcoin/bitcoin/pull/14934
189 2019-08-14T11:31:26  *** bitcoin-git has left #bitcoin-core-dev
190 2019-08-14T11:32:28  *** queip has quit IRC
191 2019-08-14T11:33:28  <fanquake> hopefully he's given up..
192 2019-08-14T11:37:33  <fanquake> wumpus did that last pr break compiling on master ?
193 2019-08-14T11:37:43  <fanquake> script/descriptor.cpp:495:13: error: use of undeclared identifier 'm_script_arg'
194 2019-08-14T11:39:15  <wumpus> oh crap did it?
195 2019-08-14T11:39:29  <wumpus> will try and revert if so
196 2019-08-14T11:39:40  <fanquake> I think the fix may be trivial
197 2019-08-14T11:39:45  <fanquake> just checking
198 2019-08-14T11:40:53  <fanquake> wumpus: I can pr a fix now, if you'd rather not revert ?
199 2019-08-14T11:42:35  <wumpus> if it's trivial, sure, if not, we might want to revert and go with this through review again
200 2019-08-14T11:43:02  <fanquake> Should be a trivial 2-line change, just looks like a missed renaming.
201 2019-08-14T11:43:15  <wumpus> must be code that was introduced since the PR
202 2019-08-14T11:43:55  <wumpus> yes, it's pretty much  documentation PR, and a renamed field, you'd say what can go wrong with it, well apparantly something can
203 2019-08-14T11:44:21  *** bitcoin-git has joined #bitcoin-core-dev
204 2019-08-14T11:44:22  <bitcoin-git> [bitcoin] Sjors opened pull request #16608: [backport] Use wallet RBF default for walletcreatefundedpsbt (0.18...2018/08/backport-wallet-rbf-default) https://github.com/bitcoin/bitcoin/pull/16608
205 2019-08-14T11:44:23  *** bitcoin-git has left #bitcoin-core-dev
206 2019-08-14T11:49:13  <provoostenator> wumpus fanquake: I'll take a look
207 2019-08-14T11:49:28  <fanquake> provoostenator: I'm about to open a PR.
208 2019-08-14T11:49:29  <wumpus> provoostenator: thanks!
209 2019-08-14T11:49:42  <provoostenator> Could either revert and then I can rebase, or I make a PR now that fixes the new occurance.
210 2019-08-14T11:50:27  <provoostenator> Fix appears trivial, just running tests locall now
211 2019-08-14T11:50:40  *** bitcoin-git has joined #bitcoin-core-dev
212 2019-08-14T11:50:40  <bitcoin-git> [bitcoin] fanquake opened pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
213 2019-08-14T11:50:43  *** bitcoin-git has left #bitcoin-core-dev
214 2019-08-14T11:51:27  <provoostenator> Oh I see fanquake beat me to it with the exact same change :-)
215 2019-08-14T11:51:38  <wumpus> at least ACK it then
216 2019-08-14T11:51:44  <provoostenator> About to
217 2019-08-14T11:51:47  *** bitcoin-git has joined #bitcoin-core-dev
218 2019-08-14T11:51:47  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #16584: gui: New filesave icon, updated copyright (master...branch4) https://github.com/bitcoin/bitcoin/pull/16584
219 2019-08-14T11:51:49  *** bitcoin-git has left #bitcoin-core-dev
220 2019-08-14T11:52:45  *** queip has joined #bitcoin-core-dev
221 2019-08-14T11:55:53  <provoostenator> I would be cool if Drahtbot could detect a silent merge conflict like this one.
222 2019-08-14T11:58:26  <wumpus> I think it sometimes does re-run travis on PRs that have been open a long time
223 2019-08-14T11:58:54  <wumpus> that's the only way to 'detect' silent merge conflicts, re-running the build and test suite
224 2019-08-14T11:59:12  <wumpus> I should have built locally before merging, but this one seemed trivial
225 2019-08-14T12:00:02  *** [42]1 has quit IRC
226 2019-08-14T12:01:04  <wumpus> didn't think anything could go wrong, but there you see…
227 2019-08-14T12:03:21  *** bitcoin-git has joined #bitcoin-core-dev
228 2019-08-14T12:03:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7df1ecd1758...034575e9c7a3
229 2019-08-14T12:03:22  <bitcoin-git> bitcoin/master 3963856 fanquake: descriptor: fix missed m_script_arg arg renaming in #14934
230 2019-08-14T12:03:22  <bitcoin-git> bitcoin/master 034575e MarcoFalke: Merge #16609: descriptor: fix missed m_script_arg arg renaming in #14934
231 2019-08-14T12:03:28  *** bitcoin-git has left #bitcoin-core-dev
232 2019-08-14T12:03:29  <provoostenator> When running the functional test suite with --jobs=100 a bunch of tests break because of the 60 second node stop timeout.
233 2019-08-14T12:03:52  <provoostenator> That should probably be configurable, because CPU and RAM usage weren't particularly bad.
234 2019-08-14T12:03:56  <wumpus> To github.com:bitcoin/bitcoin
235 2019-08-14T12:03:58  <wumpus>  ! [rejected]                                                                          master -> master (fetch first)
236 2019-08-14T12:04:00  <wumpus> error: failed to push some refs to 'git@github.com:bitcoin/bitcoin'
237 2019-08-14T12:04:02  <wumpus> h
238 2019-08-14T12:04:12  <wumpus> lol MarcoFalke beat me to merging a millisecond or so
239 2019-08-14T12:04:31  *** bitcoin-git has joined #bitcoin-core-dev
240 2019-08-14T12:04:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16609: descriptor: fix missed m_script_arg arg renaming in #14934 (master...fix_descriptor_arg) https://github.com/bitcoin/bitcoin/pull/16609
241 2019-08-14T12:04:32  *** bitcoin-git has left #bitcoin-core-dev
242 2019-08-14T12:09:11  *** lightlike has joined #bitcoin-core-dev
243 2019-08-14T12:10:09  *** harrigan has quit IRC
244 2019-08-14T12:13:13  *** bitcoin-git has joined #bitcoin-core-dev
245 2019-08-14T12:13:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/034575e9c7a3...0753c7392796
246 2019-08-14T12:13:14  <bitcoin-git> bitcoin/master 14f7eec Emil Engler: rpc: Fix getblocktemplate CLI example (#16594)
247 2019-08-14T12:13:14  <bitcoin-git> bitcoin/master 0753c73 fanquake: Merge #16596: rpc: Fix getblocktemplate CLI example
248 2019-08-14T12:13:16  *** bitcoin-git has left #bitcoin-core-dev
249 2019-08-14T12:14:23  *** bitcoin-git has joined #bitcoin-core-dev
250 2019-08-14T12:14:23  <bitcoin-git> [bitcoin] fanquake merged pull request #16596: rpc: Fix getblocktemplate CLI example (master...2019-08-helpexamplecli-fix) https://github.com/bitcoin/bitcoin/pull/16596
251 2019-08-14T12:14:26  *** bitcoin-git has left #bitcoin-core-dev
252 2019-08-14T12:19:08  *** omega8cc has joined #bitcoin-core-dev
253 2019-08-14T12:20:27  *** tryphe_ has joined #bitcoin-core-dev
254 2019-08-14T12:20:28  *** bitcoin-git has joined #bitcoin-core-dev
255 2019-08-14T12:20:29  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
256 2019-08-14T12:20:30  *** bitcoin-git has left #bitcoin-core-dev
257 2019-08-14T12:23:47  *** tryphe has quit IRC
258 2019-08-14T12:28:05  *** bitcoin-git has joined #bitcoin-core-dev
259 2019-08-14T12:28:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0753c7392796...24f29790cd7e
260 2019-08-14T12:28:06  <bitcoin-git> bitcoin/master fa4ee0d MarcoFalke: build: Remove unused src/obj-test folder
261 2019-08-14T12:28:07  <bitcoin-git> bitcoin/master 24f2979 MarcoFalke: Merge #16589: build: Remove unused src/obj-test folder
262 2019-08-14T12:28:18  *** bitcoin-git has left #bitcoin-core-dev
263 2019-08-14T12:29:14  *** bitcoin-git has joined #bitcoin-core-dev
264 2019-08-14T12:29:15  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16589: build: Remove unused src/obj-test folder (master...1908-buildNoSrcObjTest) https://github.com/bitcoin/bitcoin/pull/16589
265 2019-08-14T12:29:28  *** bitcoin-git has left #bitcoin-core-dev
266 2019-08-14T12:30:43  *** designwish has quit IRC
267 2019-08-14T12:31:58  *** votesmith has quit IRC
268 2019-08-14T12:33:56  *** bitcoin-git has joined #bitcoin-core-dev
269 2019-08-14T12:33:56  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24f29790cd7e...a7aa80902763
270 2019-08-14T12:33:57  <bitcoin-git> bitcoin/master 7cd069d Martin Zumsande: Add test for AddTimeData
271 2019-08-14T12:33:57  <bitcoin-git> bitcoin/master a7aa809 Wladimir J. van der Laan: Merge #16563: test: Add unit test for AddTimeData
272 2019-08-14T12:34:00  *** bitcoin-git has left #bitcoin-core-dev
273 2019-08-14T12:35:00  *** bitcoin-git has joined #bitcoin-core-dev
274 2019-08-14T12:35:00  <bitcoin-git> [bitcoin] laanwj merged pull request #16563: test: Add unit test for AddTimeData (master...201908_test_timedata) https://github.com/bitcoin/bitcoin/pull/16563
275 2019-08-14T12:35:02  *** bitcoin-git has left #bitcoin-core-dev
276 2019-08-14T12:35:34  *** votesmith has joined #bitcoin-core-dev
277 2019-08-14T12:38:27  *** lalitmee has quit IRC
278 2019-08-14T12:38:57  *** designwish has joined #bitcoin-core-dev
279 2019-08-14T12:44:01  *** harrigan has joined #bitcoin-core-dev
280 2019-08-14T12:54:08  *** mryandao has quit IRC
281 2019-08-14T13:00:57  *** bitcoin-git has joined #bitcoin-core-dev
282 2019-08-14T13:00:57  <bitcoin-git> [bitcoin] laanwj opened pull request #16611: build: Remove src/obj directory from repository (master...2019_08_srcobj) https://github.com/bitcoin/bitcoin/pull/16611
283 2019-08-14T13:01:01  *** bitcoin-git has left #bitcoin-core-dev
284 2019-08-14T13:15:15  *** mryandao has joined #bitcoin-core-dev
285 2019-08-14T13:19:59  *** tryphe_ has quit IRC
286 2019-08-14T13:20:23  *** tryphe_ has joined #bitcoin-core-dev
287 2019-08-14T13:25:53  *** jonatack has quit IRC
288 2019-08-14T13:27:35  *** bsm1175321 has joined #bitcoin-core-dev
289 2019-08-14T13:28:56  *** bsm1175321 has quit IRC
290 2019-08-14T13:47:32  *** millerti has joined #bitcoin-core-dev
291 2019-08-14T13:51:23  *** bitcoin-git has joined #bitcoin-core-dev
292 2019-08-14T13:51:26  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/bbc2970082a2...43cf76b19395
293 2019-08-14T13:51:26  <bitcoin-git> bitcoin/0.18 2c341e3 MarcoFalke: travis: Properly cache and error on timeout
294 2019-08-14T13:51:28  <bitcoin-git> bitcoin/0.18 5aac5e9 MarcoFalke: travis: Bump second timeout to 33 minutes, Add rationale
295 2019-08-14T13:51:29  <bitcoin-git> bitcoin/0.18 80cd3f0 MarcoFalke: travis: Bump timeout from 50 minutes to 90
296 2019-08-14T13:51:31  *** bitcoin-git has left #bitcoin-core-dev
297 2019-08-14T13:51:47  *** bitcoin-git has joined #bitcoin-core-dev
298 2019-08-14T13:51:48  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16610: [0.18] travis: Bump timeout from 50 minutes to 90, caching fixes (0.18...1908-018travisBackports) https://github.com/bitcoin/bitcoin/pull/16610
299 2019-08-14T13:51:49  *** bitcoin-git has left #bitcoin-core-dev
300 2019-08-14T13:57:43  *** justanotheruser has quit IRC
301 2019-08-14T14:02:57  *** bitcoin-git has joined #bitcoin-core-dev
302 2019-08-14T14:02:58  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
303 2019-08-14T14:02:59  *** bitcoin-git has left #bitcoin-core-dev
304 2019-08-14T14:03:15  *** bitcoin-git has joined #bitcoin-core-dev
305 2019-08-14T14:03:15  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16490: rpc: Report reason for 'bip125-replaceable' value (master...1907-rpcMempoolWhyReplacable) https://github.com/bitcoin/bitcoin/pull/16490
306 2019-08-14T14:03:16  *** bitcoin-git has left #bitcoin-core-dev
307 2019-08-14T14:04:51  *** jonatack has joined #bitcoin-core-dev
308 2019-08-14T14:04:51  *** jeremyrubin has quit IRC
309 2019-08-14T14:05:08  *** alko has joined #bitcoin-core-dev
310 2019-08-14T14:06:03  *** rh0nj has quit IRC
311 2019-08-14T14:07:08  *** rh0nj has joined #bitcoin-core-dev
312 2019-08-14T14:13:58  *** harrigan has quit IRC
313 2019-08-14T14:15:07  *** bitcoin-git has joined #bitcoin-core-dev
314 2019-08-14T14:15:07  <bitcoin-git> [bitcoin] laanwj opened pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
315 2019-08-14T14:15:08  *** bitcoin-git has left #bitcoin-core-dev
316 2019-08-14T14:18:05  *** justanotheruser has joined #bitcoin-core-dev
317 2019-08-14T14:22:27  *** justanotheruser has quit IRC
318 2019-08-14T14:25:25  *** justanotheruser has joined #bitcoin-core-dev
319 2019-08-14T14:36:56  *** jarthur has joined #bitcoin-core-dev
320 2019-08-14T14:37:00  *** seeder has joined #bitcoin-core-dev
321 2019-08-14T14:41:04  *** elichai2 has joined #bitcoin-core-dev
322 2019-08-14T14:42:36  *** hebasto has joined #bitcoin-core-dev
323 2019-08-14T14:47:11  *** Guyver2 has joined #bitcoin-core-dev
324 2019-08-14T14:50:11  *** lalitmee has joined #bitcoin-core-dev
325 2019-08-14T14:51:47  *** nosss2 has joined #bitcoin-core-dev
326 2019-08-14T14:54:16  *** gleb has left #bitcoin-core-dev
327 2019-08-14T14:54:19  *** gleb has joined #bitcoin-core-dev
328 2019-08-14T14:57:29  *** E_ has joined #bitcoin-core-dev
329 2019-08-14T15:00:01  *** omega8cc has quit IRC
330 2019-08-14T15:01:20  *** E__ has quit IRC
331 2019-08-14T15:04:16  *** DpEpsilon1 has joined #bitcoin-core-dev
332 2019-08-14T15:05:56  *** jeremyrubin has joined #bitcoin-core-dev
333 2019-08-14T15:07:55  <gleb> I want to discuss #16599 sometime at the meeting, but maybe we should start with “needs conceptual review”? Do we have room for this discussion in the conceptual review list?
334 2019-08-14T15:07:57  <gribble> https://github.com/bitcoin/bitcoin/issues/16599 | ASN-based bucketing of the network nodes · Issue #16599 · bitcoin/bitcoin · GitHub
335 2019-08-14T15:08:02  *** bitcoin-git has joined #bitcoin-core-dev
336 2019-08-14T15:08:02  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a7aa80902763...67be6d7a177c
337 2019-08-14T15:08:03  <bitcoin-git> bitcoin/master e5b26de nicolas.dorier: Make whitebind/whitelist permissions more flexible
338 2019-08-14T15:08:03  <bitcoin-git> bitcoin/master ecd5cf7 nicolas.dorier: Do not disconnect peer for asking mempool if it has NO_BAN permission
339 2019-08-14T15:08:04  <bitcoin-git> bitcoin/master d541fa3 nicolas.dorier: Replace the use of fWhitelisted by permission checks
340 2019-08-14T15:08:05  *** bitcoin-git has left #bitcoin-core-dev
341 2019-08-14T15:08:51  *** bitcoin-git has joined #bitcoin-core-dev
342 2019-08-14T15:08:51  <bitcoin-git> [bitcoin] laanwj merged pull request #16248: Make whitebind/whitelist permissions more flexible (master...feature/permissions) https://github.com/bitcoin/bitcoin/pull/16248
343 2019-08-14T15:08:53  *** bitcoin-git has left #bitcoin-core-dev
344 2019-08-14T15:10:13  <wumpus> gleb: sure, willl add it to that
345 2019-08-14T15:21:17  *** captjakk has joined #bitcoin-core-dev
346 2019-08-14T15:22:59  *** tryphe_ has quit IRC
347 2019-08-14T15:23:25  *** tryphe_ has joined #bitcoin-core-dev
348 2019-08-14T15:25:59  *** tryphe_ has quit IRC
349 2019-08-14T15:26:25  *** tryphe_ has joined #bitcoin-core-dev
350 2019-08-14T15:27:08  *** tryphe_ has quit IRC
351 2019-08-14T15:27:40  *** tryphe_ has joined #bitcoin-core-dev
352 2019-08-14T15:28:50  *** tryphe_ has joined #bitcoin-core-dev
353 2019-08-14T15:30:03  *** tryphe_ has joined #bitcoin-core-dev
354 2019-08-14T15:41:35  *** bitcoin-git has joined #bitcoin-core-dev
355 2019-08-14T15:41:36  <bitcoin-git> [bitcoin] practicalswift closed pull request #16273: refactor: Remove unused includes (master...cut-compilation-bloat) https://github.com/bitcoin/bitcoin/pull/16273
356 2019-08-14T15:41:49  *** bitcoin-git has left #bitcoin-core-dev
357 2019-08-14T15:42:41  *** E__ has joined #bitcoin-core-dev
358 2019-08-14T15:46:17  *** E_ has quit IRC
359 2019-08-14T15:58:15  *** E_ has joined #bitcoin-core-dev
360 2019-08-14T16:02:08  *** E__ has quit IRC
361 2019-08-14T16:19:36  *** csknk has joined #bitcoin-core-dev
362 2019-08-14T16:19:42  *** EagleTM has joined #bitcoin-core-dev
363 2019-08-14T16:24:37  *** michaelfolkson has joined #bitcoin-core-dev
364 2019-08-14T16:28:07  *** EagleTM has quit IRC
365 2019-08-14T16:28:23  *** E__ has joined #bitcoin-core-dev
366 2019-08-14T16:32:03  *** E_ has quit IRC
367 2019-08-14T16:32:34  <luke-jr> kallewoof: it might make sense to split out a couple more changes
368 2019-08-14T16:33:07  <luke-jr> suggest: fees: FeeModes doc helper function ; RPC/Wallet: Make fee estimate modes case insensitive.
369 2019-08-14T16:42:48  *** tryphe has joined #bitcoin-core-dev
370 2019-08-14T16:46:17  *** seeder has quit IRC
371 2019-08-14T16:48:09  *** kljasdfvv has quit IRC
372 2019-08-14T16:48:31  *** kljasdfvv has joined #bitcoin-core-dev
373 2019-08-14T16:52:07  *** jcorgan has quit IRC
374 2019-08-14T16:59:25  *** jcorgan has joined #bitcoin-core-dev
375 2019-08-14T17:01:49  *** seeder has joined #bitcoin-core-dev
376 2019-08-14T17:03:01  *** Chris_Stewart_5 has quit IRC
377 2019-08-14T17:03:28  *** captjakk has quit IRC
378 2019-08-14T17:03:45  *** captjakk has joined #bitcoin-core-dev
379 2019-08-14T17:04:31  *** captjakk has joined #bitcoin-core-dev
380 2019-08-14T17:05:04  *** captjakk has quit IRC
381 2019-08-14T17:05:23  *** captjakk has joined #bitcoin-core-dev
382 2019-08-14T17:06:08  *** captjakk has joined #bitcoin-core-dev
383 2019-08-14T17:06:56  *** captjakk has joined #bitcoin-core-dev
384 2019-08-14T17:13:23  *** sdaftuar has quit IRC
385 2019-08-14T17:13:40  *** sdaftuar has joined #bitcoin-core-dev
386 2019-08-14T17:16:26  *** pinheadmz has quit IRC
387 2019-08-14T17:18:38  *** nosss2 has quit IRC
388 2019-08-14T17:20:01  *** tryphe has quit IRC
389 2019-08-14T17:20:29  *** tryphe has joined #bitcoin-core-dev
390 2019-08-14T17:26:38  *** harrigan has joined #bitcoin-core-dev
391 2019-08-14T17:26:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
392 2019-08-14T17:28:51  *** bitcoin-git has joined #bitcoin-core-dev
393 2019-08-14T17:28:51  <bitcoin-git> [bitcoin] gapeman opened pull request #16615: doc: Fix typos in COPYRIGHT (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16615
394 2019-08-14T17:28:53  *** bitcoin-git has left #bitcoin-core-dev
395 2019-08-14T17:32:32  *** jungly has quit IRC
396 2019-08-14T17:35:44  *** phwalkr_ has quit IRC
397 2019-08-14T17:35:46  *** drizztbsd has quit IRC
398 2019-08-14T17:37:39  *** harrigan has quit IRC
399 2019-08-14T17:38:37  *** jarthur has quit IRC
400 2019-08-14T17:38:51  *** jarthur has joined #bitcoin-core-dev
401 2019-08-14T17:41:07  *** nosss2 has joined #bitcoin-core-dev
402 2019-08-14T17:44:49  *** lalitmee has quit IRC
403 2019-08-14T17:45:28  *** nosss2 has quit IRC
404 2019-08-14T18:00:02  *** DpEpsilon1 has quit IRC
405 2019-08-14T18:03:07  *** michaelfolkson has quit IRC
406 2019-08-14T18:04:33  *** cmeiklejohn1 has joined #bitcoin-core-dev
407 2019-08-14T18:30:43  *** elichai2 has quit IRC
408 2019-08-14T18:34:19  *** peleion has quit IRC
409 2019-08-14T18:41:07  *** captjakk has joined #bitcoin-core-dev
410 2019-08-14T18:44:03  *** captjakk_ has joined #bitcoin-core-dev
411 2019-08-14T18:45:18  *** captjak__ has joined #bitcoin-core-dev
412 2019-08-14T18:48:04  *** captjakk has quit IRC
413 2019-08-14T18:48:35  *** captjakk_ has quit IRC
414 2019-08-14T18:53:59  *** captjak__ has quit IRC
415 2019-08-14T18:55:42  *** captjakk has joined #bitcoin-core-dev
416 2019-08-14T19:02:06  *** bitcoin-git has joined #bitcoin-core-dev
417 2019-08-14T19:02:07  <bitcoin-git> [bitcoin] dongcarl closed pull request #14856: net: remove more CConnman globals (theuni) (master...2018-12-more-connman-params) https://github.com/bitcoin/bitcoin/pull/14856
418 2019-08-14T19:02:08  *** bitcoin-git has left #bitcoin-core-dev
419 2019-08-14T19:02:16  *** rockhouse has quit IRC
420 2019-08-14T19:02:16  *** victorSN has quit IRC
421 2019-08-14T19:03:24  *** rockhouse has joined #bitcoin-core-dev
422 2019-08-14T19:09:49  *** victorSN has joined #bitcoin-core-dev
423 2019-08-14T19:20:29  *** reallll has joined #bitcoin-core-dev
424 2019-08-14T19:20:31  *** tryphe has quit IRC
425 2019-08-14T19:20:59  *** tryphe has joined #bitcoin-core-dev
426 2019-08-14T19:22:03  *** ddustin has joined #bitcoin-core-dev
427 2019-08-14T19:22:48  *** morcos has quit IRC
428 2019-08-14T19:22:48  *** arubi has quit IRC
429 2019-08-14T19:22:48  *** ghost43 has quit IRC
430 2019-08-14T19:22:48  *** mryandao has quit IRC
431 2019-08-14T19:22:48  *** afk11 has quit IRC
432 2019-08-14T19:22:48  *** sipa has quit IRC
433 2019-08-14T19:22:48  *** kristapsk has quit IRC
434 2019-08-14T19:22:48  *** sdaftuar has quit IRC
435 2019-08-14T19:22:48  *** astro has quit IRC
436 2019-08-14T19:22:48  *** jb55 has quit IRC
437 2019-08-14T19:23:21  *** astro has joined #bitcoin-core-dev
438 2019-08-14T19:23:21  *** afk11 has joined #bitcoin-core-dev
439 2019-08-14T19:23:47  *** belcher has quit IRC
440 2019-08-14T19:24:24  *** jb55 has joined #bitcoin-core-dev
441 2019-08-14T19:24:36  *** mryandao has joined #bitcoin-core-dev
442 2019-08-14T19:25:08  *** ghost43 has joined #bitcoin-core-dev
443 2019-08-14T19:25:56  *** arubi has joined #bitcoin-core-dev
444 2019-08-14T19:26:16  *** seeder has quit IRC
445 2019-08-14T19:27:37  *** ddustin has quit IRC
446 2019-08-14T19:28:04  *** sipa has joined #bitcoin-core-dev
447 2019-08-14T19:43:43  *** sdaftuar has joined #bitcoin-core-dev
448 2019-08-14T19:51:55  *** captjakk has quit IRC
449 2019-08-14T19:55:55  <jnewbery> wumpus: would you consider reverting #16248? It's quite a large PR (~450 LOC) with only your ACK. I'm not sure anyone has actually reviewed the parsing code in detail.
450 2019-08-14T19:55:58  <gribble> https://github.com/bitcoin/bitcoin/issues/16248 | Make whitebind/whitelist permissions more flexible by NicolasDorier · Pull Request #16248 · bitcoin/bitcoin · GitHub
451 2019-08-14T20:02:54  <wumpus> jnewbery: if you think it's really a risk
452 2019-08-14T20:03:38  <wumpus> the parsing code looks fine to me
453 2019-08-14T20:03:52  *** setpill has quit IRC
454 2019-08-14T20:04:22  <wumpus> imo if it causes trouble we can revert it later, before the 0.19 release
455 2019-08-14T20:04:24  *** Chris_Stewart_5 has quit IRC
456 2019-08-14T20:06:25  <jnewbery> wumpus: not sure if it's a risk. Just seems under-reviewed to me.
457 2019-08-14T20:06:28  <wumpus> tbh I was a bit sick of only merging small refactors and documentation changes, seems we have a lot of trouble merging anything more significant lately
458 2019-08-14T20:07:54  *** bitcoin-git has joined #bitcoin-core-dev
459 2019-08-14T20:07:55  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67be6d7a177c...f418c3379cba
460 2019-08-14T20:07:55  <bitcoin-git> bitcoin/master d6ac25b Carl Dong: autoconf: Sane --enable-debug defaults.
461 2019-08-14T20:07:56  <bitcoin-git> bitcoin/master f418c33 Jonas Schnelli: Merge #16435: autoconf: Sane `--enable-debug` defaults.
462 2019-08-14T20:07:58  *** bitcoin-git has left #bitcoin-core-dev
463 2019-08-14T20:08:54  *** bitcoin-git has joined #bitcoin-core-dev
464 2019-08-14T20:08:54  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #16435: autoconf: Sane `--enable-debug` defaults. (master...2019-07-better-debuggability) https://github.com/bitcoin/bitcoin/pull/16435
465 2019-08-14T20:08:57  *** bitcoin-git has left #bitcoin-core-dev
466 2019-08-14T20:09:28  <wumpus> and this seems pretty straightforward and has tests, anyhow if you really think it should be reverted instead of fixing the issues with it that's fine with me
467 2019-08-14T20:10:44  <jnewbery> I don't pay as much attention to what's being merged as you, but lowering the review burden doesn't seem like the right fix to interesting things not getting merged (at least not without discussion first)
468 2019-08-14T20:11:19  <wumpus> it has been open for quite a while
469 2019-08-14T20:11:37  <jnewbery> like I say, I haven't looked at the PR in great detail, so I can't say whether it's a big risk. It just seemed like the code change:number of ACKs ratio was unusual
470 2019-08-14T20:12:42  <sipa> Code ACK on the string parsing code in that PR.
471 2019-08-14T20:12:51  <sipa> there :)
472 2019-08-14T20:14:25  *** iamtimmarchant has joined #bitcoin-core-dev
473 2019-08-14T20:17:03  <wumpus> I don't know either, sorry okay
474 2019-08-14T20:20:31  *** tryphe has quit IRC
475 2019-08-14T20:20:50  *** csknk has quit IRC
476 2019-08-14T20:20:56  *** tryphe has joined #bitcoin-core-dev
477 2019-08-14T20:22:47  <wumpus> sipa: thanks!
478 2019-08-14T20:23:02  <wumpus> that's some forward momentum right there :)
479 2019-08-14T20:27:37  *** iamtimmarchant has quit IRC
480 2019-08-14T20:28:43  <jnewbery> merge driven review :)
481 2019-08-14T20:29:12  <wumpus> we did that more often in the past
482 2019-08-14T20:32:07  *** baldur has quit IRC
483 2019-08-14T20:32:47  <wumpus> it's good to be careful, but also, not everything needs the same level of assurance as changes to the consensus code
484 2019-08-14T20:44:55  *** captjakk has joined #bitcoin-core-dev
485 2019-08-14T20:45:19  *** baldur has joined #bitcoin-core-dev
486 2019-08-14T20:49:27  *** ddustin has joined #bitcoin-core-dev
487 2019-08-14T20:57:42  *** EagleTM has joined #bitcoin-core-dev
488 2019-08-14T21:00:01  *** cmeiklejohn1 has quit IRC
489 2019-08-14T21:02:43  *** Guyver2 has quit IRC
490 2019-08-14T21:04:12  *** dhart has joined #bitcoin-core-dev
491 2019-08-14T21:09:06  *** hanhua has joined #bitcoin-core-dev
492 2019-08-14T21:20:31  *** tryphe has quit IRC
493 2019-08-14T21:20:55  *** tryphe has joined #bitcoin-core-dev
494 2019-08-14T21:22:07  *** jarthur has quit IRC
495 2019-08-14T21:25:18  <aj> wumpus: oh, i kept putting off doing a proper review/ack for 16248, sorry. moneyball was meant to be pinging people to ACK PRs so we got less bogged down in refactors etc, wonder if he's still doing that
496 2019-08-14T21:27:19  <moneyball> aj i intend too but sadly have put on back burner as i'm heads down building the square crypto team right now. everyone should bug me again in 1-2 months to make sure i am doing my part to help this project!
497 2019-08-14T21:35:02  *** Bullit has quit IRC
498 2019-08-14T21:35:49  *** jeremyrubin has quit IRC
499 2019-08-14T21:36:30  <fanquake> aj I’ve been ramping up my pinging / reaching out to people.
500 2019-08-14T21:40:35  *** ddustin has quit IRC
501 2019-08-14T21:46:53  *** learning has joined #bitcoin-core-dev
502 2019-08-14T21:47:16  *** ddustin has joined #bitcoin-core-dev
503 2019-08-14T21:53:31  <aj> moneyball: ohoh, fanquake's going to render you obsolete
504 2019-08-14T21:54:41  <moneyball> fantastic!
505 2019-08-14T22:02:36  *** kristapsk has joined #bitcoin-core-dev
506 2019-08-14T22:06:23  *** jeremyrubin has joined #bitcoin-core-dev
507 2019-08-14T22:07:45  *** ddustin has quit IRC
508 2019-08-14T22:10:54  *** ddustin has joined #bitcoin-core-dev
509 2019-08-14T22:11:32  *** jeremyrubin has quit IRC
510 2019-08-14T22:11:49  *** lnostdal has quit IRC
511 2019-08-14T22:24:49  *** KS has joined #bitcoin-core-dev
512 2019-08-14T22:32:43  *** jeremyrubin has joined #bitcoin-core-dev
513 2019-08-14T22:32:51  *** KS has quit IRC
514 2019-08-14T22:36:54  *** promag has joined #bitcoin-core-dev
515 2019-08-14T22:38:03  *** ddustin has quit IRC
516 2019-08-14T22:38:39  *** ddustin has joined #bitcoin-core-dev
517 2019-08-14T22:40:23  *** ddustin has quit IRC
518 2019-08-14T22:40:26  *** ddustin_ has joined #bitcoin-core-dev
519 2019-08-14T22:42:24  *** hanhua has quit IRC
520 2019-08-14T22:45:29  *** pinheadmz has joined #bitcoin-core-dev
521 2019-08-14T22:57:15  *** esotericnonsense has quit IRC
522 2019-08-14T23:01:24  *** esotericnonsense has joined #bitcoin-core-dev
523 2019-08-14T23:08:35  *** ddustin_ has quit IRC
524 2019-08-14T23:10:01  *** elichai2 has joined #bitcoin-core-dev
525 2019-08-14T23:10:10  *** ddustin has joined #bitcoin-core-dev
526 2019-08-14T23:11:13  *** profmac has quit IRC
527 2019-08-14T23:13:34  *** ddustin has quit IRC
528 2019-08-14T23:17:06  *** ddustin has joined #bitcoin-core-dev
529 2019-08-14T23:18:15  *** captjakk_ has joined #bitcoin-core-dev
530 2019-08-14T23:20:17  *** captjakk has quit IRC
531 2019-08-14T23:21:01  *** tryphe has quit IRC
532 2019-08-14T23:21:27  *** tryphe has joined #bitcoin-core-dev
533 2019-08-14T23:24:43  *** captjakk_ has quit IRC
534 2019-08-14T23:49:54  *** nosss2 has joined #bitcoin-core-dev
535 2019-08-14T23:50:28  *** pinheadmz_ has joined #bitcoin-core-dev
536 2019-08-14T23:52:07  *** AaronvanW has quit IRC
537 2019-08-14T23:52:22  *** ddustin has quit IRC
538 2019-08-14T23:52:32  *** pinheadmz has quit IRC
539 2019-08-14T23:54:18  *** pinheadmz_ has quit IRC
540 2019-08-14T23:55:07  *** pinheadmz has joined #bitcoin-core-dev
541 2019-08-14T23:55:16  *** nosss2 has quit IRC