1 2019-08-16T00:00:02  *** sankarshan1 has quit IRC
  2 2019-08-16T00:19:08  *** csharpsteen has joined #bitcoin-core-dev
  3 2019-08-16T00:21:02  *** promag_ has quit IRC
  4 2019-08-16T00:24:55  *** bitcoin-git has joined #bitcoin-core-dev
  5 2019-08-16T00:24:56  <bitcoin-git> [bitcoin] fanquake opened pull request #16625: scripts: remove github-merge.py (master...remove_github_merge_script) https://github.com/bitcoin/bitcoin/pull/16625
  6 2019-08-16T00:24:57  *** bitcoin-git has left #bitcoin-core-dev
  7 2019-08-16T00:26:41  <fanquake> The github-merge.py script has been merged into the maintainer tools repo in: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/28
  8 2019-08-16T00:27:25  *** promag has joined #bitcoin-core-dev
  9 2019-08-16T00:27:29  <fanquake> Would anyone be opposed to having the maintainer-tools commits show up here via the bot, if that's possible? Commits are infrequent, but probably interesting to those watching in here.
 10 2019-08-16T00:27:36  *** promag has quit IRC
 11 2019-08-16T00:27:54  <fanquake> Also since we are moving more important scripts to that repo.
 12 2019-08-16T00:34:49  <fanquake> Opened https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/29 to port the docs, feel free to nit-pick.
 13 2019-08-16T00:49:45  *** nosss2 has quit IRC
 14 2019-08-16T00:58:12  *** lightlike has quit IRC
 15 2019-08-16T01:47:15  *** Dean_Guss has joined #bitcoin-core-dev
 16 2019-08-16T01:51:29  *** dviola has quit IRC
 17 2019-08-16T02:00:31  *** Dean_Guss has quit IRC
 18 2019-08-16T02:00:57  *** Dean_Guss has joined #bitcoin-core-dev
 19 2019-08-16T02:10:27  *** hebasto has joined #bitcoin-core-dev
 20 2019-08-16T02:14:44  *** bitcoin-git has joined #bitcoin-core-dev
 21 2019-08-16T02:14:44  <bitcoin-git> [bitcoin] nilswloewen opened pull request #16626: Fix spelling error chache -> cache. (master...master) https://github.com/bitcoin/bitcoin/pull/16626
 22 2019-08-16T02:14:45  *** bitcoin-git has left #bitcoin-core-dev
 23 2019-08-16T02:17:00  *** nilswloewen has joined #bitcoin-core-dev
 24 2019-08-16T02:17:42  <fanquake> I'm messaging some users in here directly about review and re-review (don't want to spam the channel). If you'd rather not hear from me, just let me know.
 25 2019-08-16T02:18:43  *** PaulTroon has joined #bitcoin-core-dev
 26 2019-08-16T02:27:05  *** StopAndDecrypt has joined #bitcoin-core-dev
 27 2019-08-16T02:27:15  *** StopAndDecrypt has quit IRC
 28 2019-08-16T02:27:15  *** StopAndDecrypt has joined #bitcoin-core-dev
 29 2019-08-16T02:27:57  *** StopAndDecrypt_ has quit IRC
 30 2019-08-16T02:34:51  *** bitcoin-git has joined #bitcoin-core-dev
 31 2019-08-16T02:34:51  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bf2ff2bf8e8...14982b87e945
 32 2019-08-16T02:34:52  <bitcoin-git> bitcoin/master f9d40ce Nils Loewen: Fix spelling error chache -> cache.
 33 2019-08-16T02:34:52  <bitcoin-git> bitcoin/master 14982b8 fanquake: Merge #16626: doc: Fix spelling error chache -> cache.
 34 2019-08-16T02:34:55  *** bitcoin-git has left #bitcoin-core-dev
 35 2019-08-16T02:35:56  *** bitcoin-git has joined #bitcoin-core-dev
 36 2019-08-16T02:35:56  <bitcoin-git> [bitcoin] fanquake merged pull request #16626: doc: Fix spelling error chache -> cache. (master...master) https://github.com/bitcoin/bitcoin/pull/16626
 37 2019-08-16T02:35:59  *** bitcoin-git has left #bitcoin-core-dev
 38 2019-08-16T02:43:22  *** hebasto has quit IRC
 39 2019-08-16T02:45:21  *** bitcoin-git has joined #bitcoin-core-dev
 40 2019-08-16T02:45:21  <bitcoin-git> [bitcoin] kallewoof opened pull request #16628: refactor: remove redundant pindexPrev from TestBlockValidity (master...2019-08-tbv-nopi) https://github.com/bitcoin/bitcoin/pull/16628
 41 2019-08-16T02:45:22  *** bitcoin-git has left #bitcoin-core-dev
 42 2019-08-16T02:52:44  *** bitcoin-git has joined #bitcoin-core-dev
 43 2019-08-16T02:52:44  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/14982b87e945...95a5918c9059
 44 2019-08-16T02:52:45  <bitcoin-git> bitcoin/master 6576a87 Antoine Riard: doc: Improve versionbits.h documentation
 45 2019-08-16T02:52:45  <bitcoin-git> bitcoin/master 95a5918 fanquake: Merge #16587: doc: Improve versionbits.h documentation
 46 2019-08-16T02:52:47  *** bitcoin-git has left #bitcoin-core-dev
 47 2019-08-16T02:53:44  *** bitcoin-git has joined #bitcoin-core-dev
 48 2019-08-16T02:53:44  <bitcoin-git> [bitcoin] fanquake merged pull request #16587: doc: Improve versionbits.h documentation (master...2019-08-docs-versionbits) https://github.com/bitcoin/bitcoin/pull/16587
 49 2019-08-16T02:53:45  *** bitcoin-git has left #bitcoin-core-dev
 50 2019-08-16T02:55:07  *** nilswloewen has quit IRC
 51 2019-08-16T03:00:02  *** csharpsteen has quit IRC
 52 2019-08-16T03:19:18  *** tummy has joined #bitcoin-core-dev
 53 2019-08-16T03:56:11  *** bitcoin-git has joined #bitcoin-core-dev
 54 2019-08-16T03:56:13  <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/95a5918c9059...0d65106dce28
 55 2019-08-16T03:56:13  <bitcoin-git> bitcoin/master a50d9e6 William Casarin: rpcwallet: default include_watchonly to true for watchonly wallets
 56 2019-08-16T03:56:13  <bitcoin-git> bitcoin/master 003a3c7 William Casarin: rpcwallet: document include_watchonly default for watchonly wallets
 57 2019-08-16T03:56:14  <bitcoin-git> bitcoin/master 72ffbdc William Casarin: doc: add release note for include_watchonly default changes
 58 2019-08-16T03:56:17  *** bitcoin-git has left #bitcoin-core-dev
 59 2019-08-16T03:56:52  *** bitcoin-git has joined #bitcoin-core-dev
 60 2019-08-16T03:56:52  <bitcoin-git> [bitcoin] fanquake merged pull request #16383: rpcwallet: default include_watchonly to true for watchonly wallets (master...20190713-watchonly-defaults) https://github.com/bitcoin/bitcoin/pull/16383
 61 2019-08-16T03:56:53  *** bitcoin-git has left #bitcoin-core-dev
 62 2019-08-16T04:02:57  <fanquake> harding: Would you be interested in doing another release notes roll-up, similar to what you did in #15081? Currently 17 fragments floating around the repo. Note that one is actually in the doc/release-notes/ folder.
 63 2019-08-16T04:02:59  <gribble> https://github.com/bitcoin/bitcoin/issues/15081 | Doc: Update release notes for master through to 2019-01-01 by harding · Pull Request #15081 · bitcoin/bitcoin · GitHub
 64 2019-08-16T04:03:37  *** PaulTroon has quit IRC
 65 2019-08-16T04:14:35  *** PaulTroon has joined #bitcoin-core-dev
 66 2019-08-16T04:19:17  *** PaulTroon has quit IRC
 67 2019-08-16T04:31:28  <harding> fanquake: yes, definitely interested.  I'll try to get a PR opened by early next week.  Thanks for suggesting it (and for the note about the one in doc/release-notes---I would've missed that).
 68 2019-08-16T04:31:49  *** Victor_sueca has joined #bitcoin-core-dev
 69 2019-08-16T04:34:32  *** Victorsueca has quit IRC
 70 2019-08-16T04:35:26  <fanquake> harding: Awesome, thanks for that.
 71 2019-08-16T04:37:54  *** bitcoin-git has joined #bitcoin-core-dev
 72 2019-08-16T04:37:55  <bitcoin-git> [bitcoin] kallewoof closed pull request #16628: refactor: remove redundant pindexPrev from TestBlockValidity (master...2019-08-tbv-nopi) https://github.com/bitcoin/bitcoin/pull/16628
 73 2019-08-16T04:37:56  *** bitcoin-git has left #bitcoin-core-dev
 74 2019-08-16T04:43:40  *** bitcoin-git has joined #bitcoin-core-dev
 75 2019-08-16T04:43:40  <bitcoin-git> [bitcoin] NicolasDorier opened pull request #16629: [Doc] Add documentation for the new whitelist permissions (master...doc/permissions) https://github.com/bitcoin/bitcoin/pull/16629
 76 2019-08-16T04:43:43  *** bitcoin-git has left #bitcoin-core-dev
 77 2019-08-16T04:47:01  *** bitcoin-git has joined #bitcoin-core-dev
 78 2019-08-16T04:47:01  <bitcoin-git> [bitcoin] kallewoof opened pull request #16630: consensus: skip genesis block POW check (master...2019-08-validation-skip-genesis-pow) https://github.com/bitcoin/bitcoin/pull/16630
 79 2019-08-16T04:47:02  *** bitcoin-git has left #bitcoin-core-dev
 80 2019-08-16T05:00:32  *** tripleslash has quit IRC
 81 2019-08-16T05:49:38  *** nosss2 has joined #bitcoin-core-dev
 82 2019-08-16T05:56:28  *** EagleTM has joined #bitcoin-core-dev
 83 2019-08-16T05:59:19  *** tripleslash has joined #bitcoin-core-dev
 84 2019-08-16T06:00:02  *** tummy has quit IRC
 85 2019-08-16T06:04:30  *** josevalim1 has joined #bitcoin-core-dev
 86 2019-08-16T06:07:04  *** elichai2 has quit IRC
 87 2019-08-16T06:20:41  *** jb55 has quit IRC
 88 2019-08-16T06:21:11  *** jb55 has joined #bitcoin-core-dev
 89 2019-08-16T06:22:27  *** EagleTM has quit IRC
 90 2019-08-16T06:24:40  *** bitcoin-git has joined #bitcoin-core-dev
 91 2019-08-16T06:24:40  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0d65106dce28...93bacb8cc9c0
 92 2019-08-16T06:24:40  <bitcoin-git> bitcoin/master 390874c Wladimir J. van der Laan: qt: Remove menu icons
 93 2019-08-16T06:24:41  <bitcoin-git> bitcoin/master 93bacb8 Jonas Schnelli: Merge #16612: qt: Remove menu icons
 94 2019-08-16T06:24:42  *** bitcoin-git has left #bitcoin-core-dev
 95 2019-08-16T06:26:01  *** bitcoin-git has joined #bitcoin-core-dev
 96 2019-08-16T06:26:01  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #16612: qt: Remove menu icons (master...2019_08_remove_menuicons) https://github.com/bitcoin/bitcoin/pull/16612
 97 2019-08-16T06:26:05  *** bitcoin-git has left #bitcoin-core-dev
 98 2019-08-16T06:30:42  *** jungly has joined #bitcoin-core-dev
 99 2019-08-16T06:35:03  *** jungly has quit IRC
100 2019-08-16T06:36:50  *** jungly has joined #bitcoin-core-dev
101 2019-08-16T06:59:22  *** promag has joined #bitcoin-core-dev
102 2019-08-16T07:03:35  *** promag has quit IRC
103 2019-08-16T07:09:31  *** Krellan has joined #bitcoin-core-dev
104 2019-08-16T07:13:03  *** Krellan_ has quit IRC
105 2019-08-16T07:24:09  <jonasschnelli> MarcoFalke (or anyone): do you know why the tests fail with the address sanitizer? https://bitcoinbuilds.org/index.php?ansilog=c11df07f-50c7-41db-aa3a-53eed3d0798f.log#l7605
106 2019-08-16T07:34:48  *** nosss2 has quit IRC
107 2019-08-16T07:41:15  *** test has joined #bitcoin-core-dev
108 2019-08-16T07:41:51  *** test is now known as Guest45256
109 2019-08-16T07:48:19  *** laptop500 has joined #bitcoin-core-dev
110 2019-08-16T08:01:50  *** Raystonn has quit IRC
111 2019-08-16T08:06:52  *** setpill has joined #bitcoin-core-dev
112 2019-08-16T08:11:42  *** Krellan has quit IRC
113 2019-08-16T08:13:03  *** Krellan has joined #bitcoin-core-dev
114 2019-08-16T08:24:58  *** liberiga has joined #bitcoin-core-dev
115 2019-08-16T08:29:54  *** Evel-Knievel has quit IRC
116 2019-08-16T08:31:29  *** Krellan has quit IRC
117 2019-08-16T08:47:57  *** bitcoin-git has joined #bitcoin-core-dev
118 2019-08-16T08:47:57  <bitcoin-git> [bitcoin] NicolasDorier opened pull request #16631: [Fix] The default whitelistrelay should be true (master...fix/default-whiterelay) https://github.com/bitcoin/bitcoin/pull/16631
119 2019-08-16T08:47:58  *** bitcoin-git has left #bitcoin-core-dev
120 2019-08-16T08:54:36  *** liberiga has quit IRC
121 2019-08-16T09:00:02  *** josevalim1 has quit IRC
122 2019-08-16T09:00:30  *** Krellan has joined #bitcoin-core-dev
123 2019-08-16T09:05:28  *** Krellan has quit IRC
124 2019-08-16T09:11:15  *** laptop500 has quit IRC
125 2019-08-16T09:11:44  *** laptop500 has joined #bitcoin-core-dev
126 2019-08-16T09:19:11  *** Guest45256 has quit IRC
127 2019-08-16T09:19:36  *** Philantrop1 has joined #bitcoin-core-dev
128 2019-08-16T09:35:19  *** Krellan has joined #bitcoin-core-dev
129 2019-08-16T09:55:18  *** Evel-Knievel has joined #bitcoin-core-dev
130 2019-08-16T10:00:17  *** queip has quit IRC
131 2019-08-16T10:09:18  *** queip has joined #bitcoin-core-dev
132 2019-08-16T10:09:25  *** Krellan has quit IRC
133 2019-08-16T10:25:07  *** liberiga has joined #bitcoin-core-dev
134 2019-08-16T10:32:53  *** jonatack has quit IRC
135 2019-08-16T10:34:06  *** jonatack has joined #bitcoin-core-dev
136 2019-08-16T10:35:58  *** promag has joined #bitcoin-core-dev
137 2019-08-16T10:38:27  *** Krellan has joined #bitcoin-core-dev
138 2019-08-16T10:40:30  *** promag has quit IRC
139 2019-08-16T10:43:16  *** Krellan has quit IRC
140 2019-08-16T11:08:56  *** _Sam-- has quit IRC
141 2019-08-16T11:10:46  *** Krellan has joined #bitcoin-core-dev
142 2019-08-16T11:26:08  *** coinmonks has joined #bitcoin-core-dev
143 2019-08-16T11:35:03  *** queip has quit IRC
144 2019-08-16T11:41:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
145 2019-08-16T11:42:40  *** queip has joined #bitcoin-core-dev
146 2019-08-16T11:45:11  *** Krellan has quit IRC
147 2019-08-16T11:46:35  <coinmonks> hey guys, few days ago, I tried to understand the Bitcoin codebase using different metrics, for now i want to understand what is state of Bitcoin contributors and their economic well being..
148 2019-08-16T11:46:39  <coinmonks> https://docs.google.com/forms/d/e/1FAIpQLSfR9C1VJLjHpi_p__3c1bE3D1-nvYqTzTsx-A_Q1WtYplUz7A/viewform?usp=sf_link
149 2019-08-16T11:46:47  <coinmonks> Here is link for survey..
150 2019-08-16T11:47:26  <coinmonks> It has only 6 questions
151 2019-08-16T11:49:49  *** Chris_Stewart_5 has quit IRC
152 2019-08-16T11:50:01  *** oyvkva has joined #bitcoin-core-dev
153 2019-08-16T11:55:01  <coinmonks> BTW this is last weeks code base analysis https://blog.coincodecap.com/bitcoin-development-stats/
154 2019-08-16T11:55:18  *** mxl86 has joined #bitcoin-core-dev
155 2019-08-16T11:55:33  *** bitcoin-git has joined #bitcoin-core-dev
156 2019-08-16T11:55:33  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/93bacb8cc9c0...21a165325eda
157 2019-08-16T11:55:33  <bitcoin-git> bitcoin/master fa27c55 MarcoFalke: util: Move ResolveErrMsg to util/error
158 2019-08-16T11:55:34  <bitcoin-git> bitcoin/master 21a1653 MarcoFalke: Merge #16620: util: Move ResolveErrMsg to util/error
159 2019-08-16T11:55:46  *** bitcoin-git has left #bitcoin-core-dev
160 2019-08-16T11:56:38  *** bitcoin-git has joined #bitcoin-core-dev
161 2019-08-16T11:56:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16620: util: Move ResolveErrMsg to util/error (master...1908-utilErrorResolveErrMsg) https://github.com/bitcoin/bitcoin/pull/16620
162 2019-08-16T11:56:38  *** bitcoin-git has left #bitcoin-core-dev
163 2019-08-16T11:58:42  *** mxl86 has quit IRC
164 2019-08-16T12:00:02  *** Philantrop1 has quit IRC
165 2019-08-16T12:00:04  *** mxl86 has joined #bitcoin-core-dev
166 2019-08-16T12:02:46  <meshcollider> Reminder wallet meeting is this week (in 7 hours)
167 2019-08-16T12:10:34  *** lightlike has joined #bitcoin-core-dev
168 2019-08-16T12:10:36  *** jungly has quit IRC
169 2019-08-16T12:10:39  *** oyvkva has quit IRC
170 2019-08-16T12:10:53  *** oyvkva has joined #bitcoin-core-dev
171 2019-08-16T12:12:02  *** Krellan has joined #bitcoin-core-dev
172 2019-08-16T12:12:07  *** oyvkva has quit IRC
173 2019-08-16T12:12:21  *** oyvkva has joined #bitcoin-core-dev
174 2019-08-16T12:15:27  *** laptop500 has quit IRC
175 2019-08-16T12:16:52  *** Krellan has quit IRC
176 2019-08-16T12:21:35  *** sirkitree has joined #bitcoin-core-dev
177 2019-08-16T12:22:19  *** coinmonks has quit IRC
178 2019-08-16T12:47:31  *** Krellan has joined #bitcoin-core-dev
179 2019-08-16T12:51:10  *** bitcoin-git has joined #bitcoin-core-dev
180 2019-08-16T12:51:10  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16633: travis: Fix test_runner.py timeouts (master...1908-travisTimeouts) https://github.com/bitcoin/bitcoin/pull/16633
181 2019-08-16T12:51:18  *** bitcoin-git has left #bitcoin-core-dev
182 2019-08-16T12:57:39  *** jeremyrubin has quit IRC
183 2019-08-16T12:59:37  *** fox2p has joined #bitcoin-core-dev
184 2019-08-16T13:01:57  *** fox2p_ has quit IRC
185 2019-08-16T13:08:32  *** bitcoin-git has joined #bitcoin-core-dev
186 2019-08-16T13:08:32  <bitcoin-git> [bitcoin] GChuf closed pull request #16621: doc: add default bitcoin.conf locations (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16621
187 2019-08-16T13:08:33  *** bitcoin-git has left #bitcoin-core-dev
188 2019-08-16T13:15:59  *** PaulTroon has joined #bitcoin-core-dev
189 2019-08-16T13:17:59  *** elichai2 has joined #bitcoin-core-dev
190 2019-08-16T13:21:49  *** Krellan has quit IRC
191 2019-08-16T13:24:09  *** jeremyrubin has joined #bitcoin-core-dev
192 2019-08-16T13:29:05  *** bitcoin-git has joined #bitcoin-core-dev
193 2019-08-16T13:29:05  <bitcoin-git> [bitcoin] GChuf reopened pull request #16621: doc: add default bitcoin.conf locations (master...patch-2) https://github.com/bitcoin/bitcoin/pull/16621
194 2019-08-16T13:29:06  *** bitcoin-git has left #bitcoin-core-dev
195 2019-08-16T13:30:50  *** bitcoin-git has joined #bitcoin-core-dev
196 2019-08-16T13:30:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/21a165325eda...aed15edf179d
197 2019-08-16T13:30:51  <bitcoin-git> bitcoin/master faba46d MarcoFalke: ci: Set --ansi in test_runner
198 2019-08-16T13:30:51  <bitcoin-git> bitcoin/master aed15ed MarcoFalke: Merge #16633: travis: Fix test_runner.py timeouts
199 2019-08-16T13:30:57  *** bitcoin-git has left #bitcoin-core-dev
200 2019-08-16T13:32:19  *** bitcoin-git has joined #bitcoin-core-dev
201 2019-08-16T13:32:19  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16633: travis: Fix test_runner.py timeouts (master...1908-travisTimeouts) https://github.com/bitcoin/bitcoin/pull/16633
202 2019-08-16T13:32:20  *** bitcoin-git has left #bitcoin-core-dev
203 2019-08-16T13:32:40  <provoostenator> Double unicorn on Github when viewing validation.cpp with blame, works the third time though.
204 2019-08-16T13:33:37  *** Guyver2 has joined #bitcoin-core-dev
205 2019-08-16T13:37:28  *** roconnor has quit IRC
206 2019-08-16T13:40:21  *** dgenr8 has quit IRC
207 2019-08-16T13:49:02  *** bitcoin-git has joined #bitcoin-core-dev
208 2019-08-16T13:49:02  <bitcoin-git> [bitcoin] DrahtBot closed pull request #14786: Skip redundant OP_CODESEPARATOR scan (master...skip_codeseparator) https://github.com/bitcoin/bitcoin/pull/14786
209 2019-08-16T13:49:03  *** bitcoin-git has left #bitcoin-core-dev
210 2019-08-16T13:49:22  *** bitcoin-git has joined #bitcoin-core-dev
211 2019-08-16T13:49:22  <bitcoin-git> [bitcoin] DrahtBot reopened pull request #14786: Skip redundant OP_CODESEPARATOR scan (master...skip_codeseparator) https://github.com/bitcoin/bitcoin/pull/14786
212 2019-08-16T13:49:24  *** bitcoin-git has left #bitcoin-core-dev
213 2019-08-16T13:49:42  *** bitcoin-git has joined #bitcoin-core-dev
214 2019-08-16T13:49:42  <bitcoin-git> [bitcoin] DrahtBot closed pull request #14740: docs: Update rpcbind doc to match the manpage (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14740
215 2019-08-16T13:49:43  *** bitcoin-git has left #bitcoin-core-dev
216 2019-08-16T13:50:00  *** bitcoin-git has joined #bitcoin-core-dev
217 2019-08-16T13:50:00  <bitcoin-git> [bitcoin] DrahtBot reopened pull request #14740: docs: Update rpcbind doc to match the manpage (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14740
218 2019-08-16T13:50:01  *** bitcoin-git has left #bitcoin-core-dev
219 2019-08-16T13:50:20  *** bitcoin-git has joined #bitcoin-core-dev
220 2019-08-16T13:50:20  <bitcoin-git> [bitcoin] DrahtBot closed pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
221 2019-08-16T13:50:24  *** bitcoin-git has left #bitcoin-core-dev
222 2019-08-16T13:50:40  *** bitcoin-git has joined #bitcoin-core-dev
223 2019-08-16T13:50:40  <bitcoin-git> [bitcoin] DrahtBot reopened pull request #14729: correct -onion default to -proxy behavior (master...qubenix-proxyfix) https://github.com/bitcoin/bitcoin/pull/14729
224 2019-08-16T13:50:41  *** bitcoin-git has left #bitcoin-core-dev
225 2019-08-16T13:51:00  *** bitcoin-git has joined #bitcoin-core-dev
226 2019-08-16T13:51:00  <bitcoin-git> [bitcoin] DrahtBot closed pull request #14694: tests: Separately check for rapidcheck/boost_test.h in configure (master...rapidcheck-boost-test) https://github.com/bitcoin/bitcoin/pull/14694
227 2019-08-16T13:51:01  *** bitcoin-git has left #bitcoin-core-dev
228 2019-08-16T13:51:21  *** bitcoin-git has joined #bitcoin-core-dev
229 2019-08-16T13:51:21  <bitcoin-git> [bitcoin] DrahtBot reopened pull request #14694: tests: Separately check for rapidcheck/boost_test.h in configure (master...rapidcheck-boost-test) https://github.com/bitcoin/bitcoin/pull/14694
230 2019-08-16T13:51:22  *** bitcoin-git has left #bitcoin-core-dev
231 2019-08-16T13:51:41  *** bitcoin-git has joined #bitcoin-core-dev
232 2019-08-16T13:51:41  <bitcoin-git> [bitcoin] DrahtBot closed pull request #14687: zmq: enable tcp keepalive (master...zmq-keep-alive) https://github.com/bitcoin/bitcoin/pull/14687
233 2019-08-16T13:51:42  *** bitcoin-git has left #bitcoin-core-dev
234 2019-08-16T13:52:00  *** bitcoin-git has joined #bitcoin-core-dev
235 2019-08-16T13:52:00  <bitcoin-git> [bitcoin] DrahtBot reopened pull request #14687: zmq: enable tcp keepalive (master...zmq-keep-alive) https://github.com/bitcoin/bitcoin/pull/14687
236 2019-08-16T13:52:01  *** bitcoin-git has left #bitcoin-core-dev
237 2019-08-16T13:52:20  *** bitcoin-git has joined #bitcoin-core-dev
238 2019-08-16T13:52:20  <bitcoin-git> [bitcoin] DrahtBot closed pull request #13533: [tests] Reduced number of validations in tx_validationcache_tests (master...reduce-txvalidationcache_tests-runtime) https://github.com/bitcoin/bitcoin/pull/13533
239 2019-08-16T13:52:25  *** bitcoin-git has left #bitcoin-core-dev
240 2019-08-16T13:52:46  *** bitcoin-git has joined #bitcoin-core-dev
241 2019-08-16T13:52:46  <bitcoin-git> [bitcoin] DrahtBot reopened pull request #13533: [tests] Reduced number of validations in tx_validationcache_tests (master...reduce-txvalidationcache_tests-runtime) https://github.com/bitcoin/bitcoin/pull/13533
242 2019-08-16T13:52:47  *** bitcoin-git has left #bitcoin-core-dev
243 2019-08-16T13:53:05  *** bitcoin-git has joined #bitcoin-core-dev
244 2019-08-16T13:53:05  <bitcoin-git> [bitcoin] DrahtBot closed pull request #10729: Wrap EvalScript in a ScriptExecution class (master...scriptex) https://github.com/bitcoin/bitcoin/pull/10729
245 2019-08-16T13:53:06  *** bitcoin-git has left #bitcoin-core-dev
246 2019-08-16T13:53:26  *** bitcoin-git has joined #bitcoin-core-dev
247 2019-08-16T13:53:26  <bitcoin-git> [bitcoin] DrahtBot reopened pull request #10729: Wrap EvalScript in a ScriptExecution class (master...scriptex) https://github.com/bitcoin/bitcoin/pull/10729
248 2019-08-16T13:53:27  *** bitcoin-git has left #bitcoin-core-dev
249 2019-08-16T14:02:24  *** bitcoin-git has joined #bitcoin-core-dev
250 2019-08-16T14:02:24  <bitcoin-git> [bitcoin] DrahtBot closed pull request #15717: Changes to support NAT-PMP  (master...master) https://github.com/bitcoin/bitcoin/pull/15717
251 2019-08-16T14:02:27  *** bitcoin-git has left #bitcoin-core-dev
252 2019-08-16T14:02:44  *** bitcoin-git has joined #bitcoin-core-dev
253 2019-08-16T14:02:44  <bitcoin-git> [bitcoin] DrahtBot closed pull request #15493: rfc: Add -printconfig arg to bitcoind (master...2019-02-printconfig) https://github.com/bitcoin/bitcoin/pull/15493
254 2019-08-16T14:02:49  *** bitcoin-git has left #bitcoin-core-dev
255 2019-08-16T14:03:04  *** bitcoin-git has joined #bitcoin-core-dev
256 2019-08-16T14:03:04  <bitcoin-git> [bitcoin] DrahtBot closed pull request #15150: gui: Show wallet selector on console window if there are wallets loaded (master...2019-01-consolewalletselector) https://github.com/bitcoin/bitcoin/pull/15150
257 2019-08-16T14:03:07  *** bitcoin-git has left #bitcoin-core-dev
258 2019-08-16T14:05:42  *** kanonderen has joined #bitcoin-core-dev
259 2019-08-16T14:06:13  *** kanonderen has joined #bitcoin-core-dev
260 2019-08-16T14:06:23  *** setpill has quit IRC
261 2019-08-16T14:06:45  *** kanonderen is now known as setpill
262 2019-08-16T14:17:30  *** Krellan has joined #bitcoin-core-dev
263 2019-08-16T14:19:30  *** bitcoin-git has joined #bitcoin-core-dev
264 2019-08-16T14:19:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/aed15edf179d...b80cdfec9a07
265 2019-08-16T14:19:31  <bitcoin-git> bitcoin/master dc7529a nicolas.dorier: [Fix] Allow connection of a noban banned peer
266 2019-08-16T14:19:31  <bitcoin-git> bitcoin/master d117f45 nicolas.dorier: Add test for setban
267 2019-08-16T14:19:32  <bitcoin-git> bitcoin/master b80cdfe MarcoFalke: Merge #16618: [Fix] Allow connection of a noban banned peer
268 2019-08-16T14:19:33  *** bitcoin-git has left #bitcoin-core-dev
269 2019-08-16T14:20:30  *** bitcoin-git has joined #bitcoin-core-dev
270 2019-08-16T14:20:31  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16618: [Fix] Allow connection of a noban banned peer (master...fix/noban-banned) https://github.com/bitcoin/bitcoin/pull/16618
271 2019-08-16T14:20:32  *** bitcoin-git has left #bitcoin-core-dev
272 2019-08-16T14:25:16  *** Krellan has quit IRC
273 2019-08-16T14:26:52  *** liberiga has quit IRC
274 2019-08-16T14:46:08  *** bitcoin-git has joined #bitcoin-core-dev
275 2019-08-16T14:46:09  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #14786: Skip redundant OP_CODESEPARATOR scan (master...skip_codeseparator) https://github.com/bitcoin/bitcoin/pull/14786
276 2019-08-16T14:46:10  *** bitcoin-git has left #bitcoin-core-dev
277 2019-08-16T14:53:45  *** bitcoin-git has joined #bitcoin-core-dev
278 2019-08-16T14:53:45  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16634: doc: Refer in rpcbind doc to the manpage (master...1908-docManPage) https://github.com/bitcoin/bitcoin/pull/16634
279 2019-08-16T14:53:51  *** bitcoin-git has left #bitcoin-core-dev
280 2019-08-16T15:00:01  *** sirkitree has quit IRC
281 2019-08-16T15:01:05  *** Krellan has joined #bitcoin-core-dev
282 2019-08-16T15:06:15  *** Krellan has quit IRC
283 2019-08-16T15:08:20  *** roconnor has joined #bitcoin-core-dev
284 2019-08-16T15:11:28  *** nosss2 has joined #bitcoin-core-dev
285 2019-08-16T15:16:00  *** MTecknology1 has joined #bitcoin-core-dev
286 2019-08-16T15:21:59  *** bitcoin-git has joined #bitcoin-core-dev
287 2019-08-16T15:21:59  <bitcoin-git> [bitcoin] NicolasDorier opened pull request #16635: [Tests] fix chmod permissions on test files (master...fix/chmod) https://github.com/bitcoin/bitcoin/pull/16635
288 2019-08-16T15:22:00  *** bitcoin-git has left #bitcoin-core-dev
289 2019-08-16T15:28:51  *** mxl86 has quit IRC
290 2019-08-16T15:44:18  *** bitcoin-git has joined #bitcoin-core-dev
291 2019-08-16T15:44:18  <bitcoin-git> [bitcoin] NicolasDorier closed pull request #16635: [Tests] fix chmod permissions on test files (master...fix/chmod) https://github.com/bitcoin/bitcoin/pull/16635
292 2019-08-16T15:44:21  *** bitcoin-git has left #bitcoin-core-dev
293 2019-08-16T15:47:13  *** bitcoin-git has joined #bitcoin-core-dev
294 2019-08-16T15:47:13  <bitcoin-git> [bitcoin] GChuf opened pull request #16636: [QT] Optimize spinner (master...mv0) https://github.com/bitcoin/bitcoin/pull/16636
295 2019-08-16T15:47:16  *** bitcoin-git has left #bitcoin-core-dev
296 2019-08-16T15:49:28  *** Dean_Guss has quit IRC
297 2019-08-16T15:55:10  *** jarthur has joined #bitcoin-core-dev
298 2019-08-16T15:58:51  *** roconnor has quit IRC
299 2019-08-16T16:03:27  *** PaulTroon has quit IRC
300 2019-08-16T16:03:59  *** PaulTroon has joined #bitcoin-core-dev
301 2019-08-16T16:08:38  *** PaulTroon has quit IRC
302 2019-08-16T16:09:38  *** PaulTroon has joined #bitcoin-core-dev
303 2019-08-16T16:17:35  *** Krellan has joined #bitcoin-core-dev
304 2019-08-16T16:17:50  *** setpill has quit IRC
305 2019-08-16T16:18:07  *** phwalkr has joined #bitcoin-core-dev
306 2019-08-16T16:20:34  *** btbt has joined #bitcoin-core-dev
307 2019-08-16T16:29:03  *** kljasdfvv has quit IRC
308 2019-08-16T16:51:33  *** Krellan has quit IRC
309 2019-08-16T16:53:52  *** hanhua91 has joined #bitcoin-core-dev
310 2019-08-16T17:01:17  *** Krellan has joined #bitcoin-core-dev
311 2019-08-16T17:31:03  *** owowo has quit IRC
312 2019-08-16T17:32:04  *** JamesAU has joined #bitcoin-core-dev
313 2019-08-16T17:35:48  *** owowo has joined #bitcoin-core-dev
314 2019-08-16T18:00:02  *** MTecknology1 has quit IRC
315 2019-08-16T18:13:15  *** cfields has quit IRC
316 2019-08-16T18:14:28  *** davec has quit IRC
317 2019-08-16T18:16:06  *** cfields has joined #bitcoin-core-dev
318 2019-08-16T18:18:36  *** davec has joined #bitcoin-core-dev
319 2019-08-16T18:19:19  *** windsok has quit IRC
320 2019-08-16T18:19:38  *** windsok has joined #bitcoin-core-dev
321 2019-08-16T18:19:38  *** windsok has joined #bitcoin-core-dev
322 2019-08-16T18:20:08  *** jarthur_ has joined #bitcoin-core-dev
323 2019-08-16T18:23:34  *** jarthur has quit IRC
324 2019-08-16T18:30:04  *** Krellan has quit IRC
325 2019-08-16T18:30:44  *** EagleTM has joined #bitcoin-core-dev
326 2019-08-16T18:33:57  *** EagleTM has quit IRC
327 2019-08-16T18:34:19  *** EagleTM has joined #bitcoin-core-dev
328 2019-08-16T18:37:21  *** EagleTM has quit IRC
329 2019-08-16T18:37:45  *** EagleTM has joined #bitcoin-core-dev
330 2019-08-16T18:37:50  *** m1rror has joined #bitcoin-core-dev
331 2019-08-16T18:45:20  *** BlaDe^ has joined #bitcoin-core-dev
332 2019-08-16T18:58:03  *** Dean_Guss has joined #bitcoin-core-dev
333 2019-08-16T18:59:30  *** phwalkr has quit IRC
334 2019-08-16T18:59:58  *** phwalkr has joined #bitcoin-core-dev
335 2019-08-16T19:00:39  <meshcollider> #startmeeting
336 2019-08-16T19:00:39  <lightningbot> Meeting started Fri Aug 16 19:00:39 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
337 2019-08-16T19:00:39  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
338 2019-08-16T19:00:46  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
339 2019-08-16T19:01:03  <kanzure> hi
340 2019-08-16T19:01:04  <sipa> hi
341 2019-08-16T19:01:08  <jnewbery> hi
342 2019-08-16T19:01:49  *** EagleTM has quit IRC
343 2019-08-16T19:01:52  <achow101>  hi
344 2019-08-16T19:02:10  *** EagleTM has joined #bitcoin-core-dev
345 2019-08-16T19:02:51  <provoostenator> hi
346 2019-08-16T19:02:53  <ariard> hi
347 2019-08-16T19:02:54  <meshcollider> Firstly apologies from me for the lack of review/merging I've done recently, had an especially busy project at uni which just finished so I'll get a few PRs merged today hopefully
348 2019-08-16T19:02:59  <meshcollider> Any topics?
349 2019-08-16T19:03:16  <achow101> People should test and review #16341
350 2019-08-16T19:03:20  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
351 2019-08-16T19:03:29  <meshcollider> Yes :)
352 2019-08-16T19:04:09  *** phwalkr has quit IRC
353 2019-08-16T19:04:59  *** laptop500 has joined #bitcoin-core-dev
354 2019-08-16T19:05:08  <ariard> I'm trying to rationalize the way we track txn in the wallet, if any ones has opinions on it feel free to review : https://github.com/bitcoin/bitcoin/pull/16624
355 2019-08-16T19:05:33  <ariard> I hope it moves things in the right direction to solve long-standing issues like #7315
356 2019-08-16T19:05:34  <gribble> https://github.com/bitcoin/bitcoin/issues/7315 | Minor wallet issue with conflicted txs · Issue #7315 · bitcoin/bitcoin · GitHub
357 2019-08-16T19:06:21  <achow101> topic: replacing coin selection
358 2019-08-16T19:06:27  <achow101> *topic suggestion
359 2019-08-16T19:07:00  <jnewbery> I think that's a nice change. In general there are a few places where serialization details leak into the wallet implementation unnecessarily. 16624 cleans up some of that.
360 2019-08-16T19:07:50  <meshcollider> Yes it looks nice at first read
361 2019-08-16T19:08:10  <meshcollider> #topic replacing coin selection (achow101)
362 2019-08-16T19:08:18  <achow101> ping instagibbs
363 2019-08-16T19:08:42  <sipa> random selection fallback?
364 2019-08-16T19:08:45  <achow101> current coin selection uses branch and bound which uses effective value, and then falls back to the old algo which does not use effective value if that fals
365 2019-08-16T19:08:58  <achow101> it would be nice to retry random selection
366 2019-08-16T19:09:04  <achow101> as the fallback and get rid of the old thing entirely
367 2019-08-16T19:09:16  <achow101> the previous pr was #13307 and it just kind of stalled out
368 2019-08-16T19:09:19  <gribble> https://github.com/bitcoin/bitcoin/issues/13307 | Replace coin selection fallback strategy with Single Random Draw by achow101 · Pull Request #13307 · bitcoin/bitcoin · GitHub
369 2019-08-16T19:10:16  <sipa> i guess the only reason not to would be because we're not entirely sure that the algorithm works reasonably well on all kinds of utxo sets
370 2019-08-16T19:10:19  <achow101> I think the main issue was that with SRD as the fallback, we weren't consolidating as much as the legacy algo did
371 2019-08-16T19:10:59  <sipa> hmm, i was worrying about the opposite, where it might occasionally pick a crazy high number of inputs despite being unnecessary
372 2019-08-16T19:11:47  <achow101> the simulations I did previously showed that basically for all runs, there were a lot more utxos in the wallet on average
373 2019-08-16T19:12:17  <sipa> simulations only show behavior for the type of wallets you have data for, though
374 2019-08-16T19:12:48  <achow101> right..
375 2019-08-16T19:13:47  <achow101> I think we could mitigate the possiblity of choosing too many utxos by selecting multiple times and choosing the "least waste"
376 2019-08-16T19:13:53  <achow101> kind of like we do for BnB already
377 2019-08-16T19:13:55  <sipa> but when you do things like "run SRD 3 times, and pick the cheapest result", the risk of overly large input set goes down dramatically, but you're also worsening the consolidation further
378 2019-08-16T19:14:30  <meshcollider> Have you got some results that indicate it is somehow better in some aspect then? This seems like the naive approach, why do we want to switch it in?
379 2019-08-16T19:15:22  <achow101> part of the whole consolidation thing I think was that the legacy algo would actually select dust (negative effective value) for inputs whereas in BnB and SRD, we would ignore those entirely
380 2019-08-16T19:15:39  <sipa> i suspect that's an inherent tradeoff
381 2019-08-16T19:15:51  <sipa> anything that does not consume dust will have worse consolidation
382 2019-08-16T19:15:58  <achow101> meshcollider: https://gist.github.com/achow101/242470486265d3f21adab08f65b9102c old simulation results. it generally resulted in better fees
383 2019-08-16T19:16:37  <achow101> also, from murch's original paper, he found that it helped BnB get better exact matches over other methods
384 2019-08-16T19:17:12  <achow101> one of the issues with the legacy selection is that it does not use effective value which makes doing some other things difficult, according to instagibbs
385 2019-08-16T19:17:32  <sipa> does SRD use effective value?
386 2019-08-16T19:17:46  <achow101> yes
387 2019-08-16T19:18:14  <sipa> hmm, remind me how?
388 2019-08-16T19:18:39  <sipa> it just doesn't consider anything with negative effective value?
389 2019-08-16T19:18:50  <achow101> basically
390 2019-08-16T19:19:22  <achow101> effective value just subtracts the fee required for that input from its value so that we don't have to constantly guess what the fees are going to be
391 2019-08-16T19:19:46  <sipa> ah right that too, it lets you predict in one pass whether you have enough
392 2019-08-16T19:20:17  <sipa> i guess you could make the consolidation/dust tradeoff configurable by making it allow negative EV, but limiting how negative it can be (for example as a percentage of the payment value)
393 2019-08-16T19:20:18  <achow101> yes, so we can get rid of this stupid loop in CreateTransaction
394 2019-08-16T19:20:32  <meshcollider> Can't the same effective value check just be added to the legacy code
395 2019-08-16T19:20:46  *** reallll has joined #bitcoin-core-dev
396 2019-08-16T19:21:50  *** EagleTM has quit IRC
397 2019-08-16T19:22:07  <achow101> probably
398 2019-08-16T19:22:10  *** EagleTM has joined #bitcoin-core-dev
399 2019-08-16T19:22:28  <achow101> but the legacy code is also kind of pointless as it also tries to do an exact match which we are already doing in BnB
400 2019-08-16T19:22:42  *** DeanWeen has joined #bitcoin-core-dev
401 2019-08-16T19:23:46  <achow101> one of the main things that SRD did in my simulations was that it made BnB have more exact matches which helps with privacy
402 2019-08-16T19:23:48  *** DeanWeen has quit IRC
403 2019-08-16T19:24:12  *** belcher has quit IRC
404 2019-08-16T19:24:36  *** Dean_Guss has quit IRC
405 2019-08-16T19:26:03  <meshcollider> This is the thing I don't like about the coin selection, its all super heuristic and the tradeoffs are really hard to identify or compare
406 2019-08-16T19:26:43  <sipa> it is
407 2019-08-16T19:26:47  <meshcollider> If you think this is worth revisiting will you reopen the PR?
408 2019-08-16T19:27:00  <sipa> but it's also an algorithm that has weathered a lot
409 2019-08-16T19:27:01  <achow101> instagibbs said he would take a crack at it
410 2019-08-16T19:28:22  <meshcollider> Ok
411 2019-08-16T19:28:23  <achow101> it would be useful to have other kinds of simulation data rather than just the one or two datasets I got
412 2019-08-16T19:28:39  <sipa> ping murch :)
413 2019-08-16T19:28:40  *** phwalkr has joined #bitcoin-core-dev
414 2019-08-16T19:29:02  <achow101> he says no everytime I ask
415 2019-08-16T19:29:13  <achow101> won't give me the secrets to Bitgo's coin selection :p
416 2019-08-16T19:31:19  <sipa> achow101: just an idea, what happens if you simulate something SRD like, but permit individual utxos whose EV is > -0.2 * feerate*size
417 2019-08-16T19:31:32  *** MasterdonX has quit IRC
418 2019-08-16T19:31:33  <sipa> rather than > 0
419 2019-08-16T19:32:17  *** Krellan has joined #bitcoin-core-dev
420 2019-08-16T19:32:27  <sipa> this can be discussed outside of the meeting of course
421 2019-08-16T19:32:51  <achow101> it probably should be. simulations take a long time
422 2019-08-16T19:33:32  <achow101> I would assume something with more mean utxos than the simulation that allows any negative EV utxo but not as bad as those that exclude
423 2019-08-16T19:33:40  *** phwalkr has quit IRC
424 2019-08-16T19:33:58  <sipa> actually that rule is equivalent to "only utxos that are positive EV at 80% of the feerate"
425 2019-08-16T19:35:05  <achow101> in terms of fees, including negative ev still does better than current
426 2019-08-16T19:35:08  <meshcollider> You had a lot of simulations when we switched the BnB initially, what happened to those datasets?
427 2019-08-16T19:35:51  <achow101> they're all in public gists on github
428 2019-08-16T19:36:14  <achow101> i have the data somewhere too
429 2019-08-16T19:37:17  <meshcollider> Yeah I was wondering if they have more variation in types of utxo set than what you've tested so far
430 2019-08-16T19:37:32  <achow101> those datasets were still only based on two actual datasets, just with different variations of filtering and ordering of the data
431 2019-08-16T19:38:52  <meshcollider> Ah
432 2019-08-16T19:39:26  *** MasterdonX has joined #bitcoin-core-dev
433 2019-08-16T19:39:30  <meshcollider> Alright so we just see what instagibbs does and discuss further in the PR?
434 2019-08-16T19:39:45  <achow101> all of the different BnB simulations were mostly for different feerates
435 2019-08-16T19:40:17  <achow101> yeah. i guess the question was really whether this was something even worth pursuing again
436 2019-08-16T19:42:50  <sipa> i think so
437 2019-08-16T19:44:29  <meshcollider> If sipa thinks so then I think so too ;)
438 2019-08-16T19:44:37  <meshcollider> Any other last topics?
439 2019-08-16T19:46:04  <meshcollider> #endmeeting
440 2019-08-16T19:46:04  <lightningbot> Meeting ended Fri Aug 16 19:46:04 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
441 2019-08-16T19:46:04  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-16-19.00.html
442 2019-08-16T19:46:04  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-16-19.00.txt
443 2019-08-16T19:46:04  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-16-19.00.log.html
444 2019-08-16T19:46:21  <meshcollider> If it's true, it's kind of sad that just randomly picking utxos pretty much naively is better than the more complicated logic we have currently lol
445 2019-08-16T19:46:47  <achow101> the question is how do you define better?
446 2019-08-16T19:46:48  <meshcollider> But I guess "better" is not well-defined
447 2019-08-16T19:46:50  <meshcollider> Yeah
448 2019-08-16T19:47:08  <achow101> I suspect that effective value is what makes srd perform better in terms of fees
449 2019-08-16T19:48:28  <achow101> it would also be nice to cleanup coin selection. right now to understand it you have to read like 5 different functions
450 2019-08-16T19:48:58  <meshcollider> Yes that would be nice :)
451 2019-08-16T19:49:06  <jb55> what's the best place to read up on coin selection algos?
452 2019-08-16T19:49:27  <meshcollider> Murch's masters thesis probably lol
453 2019-08-16T19:49:34  <sipa> yeah
454 2019-08-16T19:49:49  <sipa> http://murch.one/wp-content/uploads/2016/11/erhardt2016coinselection.pdf
455 2019-08-16T19:50:08  *** EagleTM has quit IRC
456 2019-08-16T19:50:12  <sipa> only 2 out of 67 pages are in german
457 2019-08-16T19:50:29  *** EagleTM has joined #bitcoin-core-dev
458 2019-08-16T19:50:42  <jb55> ok cool I found that when googling, wasn't sure
459 2019-08-16T19:51:40  <achow101> maybe we should actually document this...
460 2019-08-16T19:53:12  *** jarthur has joined #bitcoin-core-dev
461 2019-08-16T19:55:12  <meshcollider> You could make a wiki page like we did for the new wallet model
462 2019-08-16T19:58:21  *** EagleTM has quit IRC
463 2019-08-16T19:58:42  *** EagleTM has joined #bitcoin-core-dev
464 2019-08-16T20:06:07  *** Krellan has quit IRC
465 2019-08-16T20:08:04  *** EagleTM has quit IRC
466 2019-08-16T20:08:30  *** EagleTM has joined #bitcoin-core-dev
467 2019-08-16T20:14:52  *** hanhua has quit IRC
468 2019-08-16T20:20:08  *** DeanWeen has joined #bitcoin-core-dev
469 2019-08-16T20:20:55  *** btbt has quit IRC
470 2019-08-16T20:21:57  *** EagleTM has quit IRC
471 2019-08-16T20:22:17  *** EagleTM has joined #bitcoin-core-dev
472 2019-08-16T20:29:54  *** Guyver2 has quit IRC
473 2019-08-16T20:44:29  *** EagleTM has quit IRC
474 2019-08-16T20:44:51  *** EagleTM has joined #bitcoin-core-dev
475 2019-08-16T20:47:54  *** EagleTM has quit IRC
476 2019-08-16T20:48:15  *** EagleTM has joined #bitcoin-core-dev
477 2019-08-16T20:55:02  *** EagleTM has quit IRC
478 2019-08-16T21:00:02  *** BlaDe^ has quit IRC
479 2019-08-16T21:02:34  *** reallll is now known as belcher
480 2019-08-16T21:05:26  *** kaimi1 has joined #bitcoin-core-dev
481 2019-08-16T21:08:26  *** laptop500 has quit IRC
482 2019-08-16T21:13:59  *** Krellan has joined #bitcoin-core-dev
483 2019-08-16T21:15:24  <emilengler> Has someone good resources on autotools?
484 2019-08-16T21:15:30  <emilengler> MY brain doesn't want to understand it
485 2019-08-16T21:16:14  <sipa> this is normal
486 2019-08-16T21:17:19  <sipa> my normal approach is "ask cfields"
487 2019-08-16T21:24:31  *** bitcoin-git has joined #bitcoin-core-dev
488 2019-08-16T21:24:32  <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b80cdfec9a07...7a960ba775a6
489 2019-08-16T21:24:32  <bitcoin-git> bitcoin/master 104b3a5 Pieter Wuille: Factor out checksum checking from descriptor parsing
490 2019-08-16T21:24:33  <bitcoin-git> bitcoin/master 26d3fad Pieter Wuille: Add unmodified-but-with-checksum to getdescriptorinfo
491 2019-08-16T21:24:33  <bitcoin-git> bitcoin/master 7a960ba MeshCollider: Merge #15986: Add checksum to getdescriptorinfo
492 2019-08-16T21:24:35  *** bitcoin-git has left #bitcoin-core-dev
493 2019-08-16T21:25:20  *** bitcoin-git has joined #bitcoin-core-dev
494 2019-08-16T21:25:20  <bitcoin-git> [bitcoin] meshcollider merged pull request #15986: Add checksum to getdescriptorinfo (master...201905_justchecksum) https://github.com/bitcoin/bitcoin/pull/15986
495 2019-08-16T21:25:21  *** bitcoin-git has left #bitcoin-core-dev
496 2019-08-16T21:32:37  *** PaulTroon has quit IRC
497 2019-08-16T21:33:09  *** PaulTroon has joined #bitcoin-core-dev
498 2019-08-16T21:38:47  *** jarthur has quit IRC
499 2019-08-16T21:38:50  *** PaulTroon has quit IRC
500 2019-08-16T21:40:39  *** nosss2 has quit IRC
501 2019-08-16T21:46:52  *** PaulTroon has joined #bitcoin-core-dev
502 2019-08-16T21:47:19  *** nosss2 has joined #bitcoin-core-dev
503 2019-08-16T21:47:23  *** PaulTroo_ has joined #bitcoin-core-dev
504 2019-08-16T21:47:57  *** Krellan has quit IRC
505 2019-08-16T21:51:42  *** nosss2 has quit IRC
506 2019-08-16T21:55:21  *** PaulTroo_ has quit IRC
507 2019-08-16T22:02:26  <luke-jr> emilengler: autotools has somewhat decent documentation..
508 2019-08-16T22:02:33  *** owowo has quit IRC
509 2019-08-16T22:02:36  <luke-jr> the hard part is the m4 syntax
510 2019-08-16T22:07:48  *** owowo has joined #bitcoin-core-dev
511 2019-08-16T22:13:02  *** StopAndDecrypt_ has joined #bitcoin-core-dev
512 2019-08-16T22:13:57  *** StopAndDecrypt has quit IRC
513 2019-08-16T22:48:12  *** Krellan has joined #bitcoin-core-dev
514 2019-08-16T22:53:42  *** EagleTM has joined #bitcoin-core-dev
515 2019-08-16T23:22:25  *** Krellan has quit IRC
516 2019-08-16T23:58:27  *** coisinho has joined #bitcoin-core-dev