1 2019-08-23T00:00:02  *** FalconKirtaran has quit IRC
  2 2019-08-23T00:03:21  *** bitcoin-git has joined #bitcoin-core-dev
  3 2019-08-23T00:03:21  <bitcoin-git> [bitcoin] harding opened pull request #16690: Prepare release notes for 0.19 (master...2019-08-0.19-notes) https://github.com/bitcoin/bitcoin/pull/16690
  4 2019-08-23T00:03:34  *** bitcoin-git has left #bitcoin-core-dev
  5 2019-08-23T00:03:50  *** bitcoin-git has joined #bitcoin-core-dev
  6 2019-08-23T00:03:51  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/52b9797119d5...12f7147c8914
  7 2019-08-23T00:03:51  <bitcoin-git> bitcoin/master b9ee63c David Reikher: Make descriptor test deterministic
  8 2019-08-23T00:03:52  <bitcoin-git> bitcoin/master 12f7147 fanquake: Merge #16570: tests: Make descriptor tests deterministic
  9 2019-08-23T00:03:54  *** bitcoin-git has left #bitcoin-core-dev
 10 2019-08-23T00:04:19  *** bitcoin-git has joined #bitcoin-core-dev
 11 2019-08-23T00:04:19  <bitcoin-git> [bitcoin] fanquake merged pull request #16570: tests: Make descriptor tests deterministic (master...make_descriptor_tests_deterministic) https://github.com/bitcoin/bitcoin/pull/16570
 12 2019-08-23T00:04:20  *** bitcoin-git has left #bitcoin-core-dev
 13 2019-08-23T00:05:55  <fanquake> harding: thanks, will review that later today.
 14 2019-08-23T00:13:54  <fanquake> fjahr: Enjoyed your debugging bitcoin core  talk 👍
 15 2019-08-23T00:25:01  *** rh0nj has quit IRC
 16 2019-08-23T00:26:07  *** rh0nj has joined #bitcoin-core-dev
 17 2019-08-23T00:47:50  *** HedgeMage1 has joined #bitcoin-core-dev
 18 2019-08-23T01:03:34  *** Giszmo has joined #bitcoin-core-dev
 19 2019-08-23T01:11:39  *** lightlike has quit IRC
 20 2019-08-23T01:14:30  *** bitcoin-git has joined #bitcoin-core-dev
 21 2019-08-23T01:14:31  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/12f7147c8914...43eaf76e0267
 22 2019-08-23T01:14:31  <bitcoin-git> bitcoin/master f7220e8 Jon Atack: build: update RapidCheck Makefile
 23 2019-08-23T01:14:32  <bitcoin-git> bitcoin/master 43eaf76 fanquake: Merge #16654: build: latest rapidcheck, update configuration
 24 2019-08-23T01:14:34  *** bitcoin-git has left #bitcoin-core-dev
 25 2019-08-23T01:15:20  *** bitcoin-git has joined #bitcoin-core-dev
 26 2019-08-23T01:15:20  <bitcoin-git> [bitcoin] fanquake merged pull request #16654: build: latest rapidcheck, update configuration (master...build-update-rapidcheck-makefile) https://github.com/bitcoin/bitcoin/pull/16654
 27 2019-08-23T01:15:22  *** bitcoin-git has left #bitcoin-core-dev
 28 2019-08-23T01:16:19  *** xzytrewq has joined #bitcoin-core-dev
 29 2019-08-23T01:17:53  *** elichai2 has quit IRC
 30 2019-08-23T01:31:41  *** elichai2 has joined #bitcoin-core-dev
 31 2019-08-23T01:40:09  *** sleepych has joined #bitcoin-core-dev
 32 2019-08-23T01:41:19  *** Giszmo has quit IRC
 33 2019-08-23T01:44:10  *** rafalcpp_ has quit IRC
 34 2019-08-23T01:44:19  *** rafalcpp_ has joined #bitcoin-core-dev
 35 2019-08-23T01:45:56  *** ro0xt has joined #bitcoin-core-dev
 36 2019-08-23T01:46:17  *** ro0xt has left #bitcoin-core-dev
 37 2019-08-23T01:52:33  *** Giszmo has joined #bitcoin-core-dev
 38 2019-08-23T02:00:31  *** Dean_Guss has quit IRC
 39 2019-08-23T02:00:55  *** Dean_Guss has joined #bitcoin-core-dev
 40 2019-08-23T02:07:54  *** emilengler_ has joined #bitcoin-core-dev
 41 2019-08-23T02:09:50  *** emilengler has quit IRC
 42 2019-08-23T02:28:20  *** roconnor has quit IRC
 43 2019-08-23T02:47:48  *** nosss2 has quit IRC
 44 2019-08-23T02:48:27  *** Giszmo has quit IRC
 45 2019-08-23T03:00:02  *** HedgeMage1 has quit IRC
 46 2019-08-23T03:08:47  *** Giszmo has joined #bitcoin-core-dev
 47 2019-08-23T03:17:20  *** rlaager1 has joined #bitcoin-core-dev
 48 2019-08-23T03:28:14  *** Giszmo has quit IRC
 49 2019-08-23T03:37:23  *** bitcoin-git has joined #bitcoin-core-dev
 50 2019-08-23T03:37:23  <bitcoin-git> [bitcoin] fanquake opened pull request #16691: doc: improve depends prefix documentation (master...depends_improve_prefix_docs) https://github.com/bitcoin/bitcoin/pull/16691
 51 2019-08-23T03:37:36  *** bitcoin-git has left #bitcoin-core-dev
 52 2019-08-23T03:57:53  *** elichai2 has quit IRC
 53 2019-08-23T04:10:15  *** seeder has joined #bitcoin-core-dev
 54 2019-08-23T04:12:02  *** hebasto has quit IRC
 55 2019-08-23T04:17:56  <fjahr> fanquake: Thank you :)
 56 2019-08-23T04:51:19  *** lalitmee has joined #bitcoin-core-dev
 57 2019-08-23T04:59:15  *** EagleTM has joined #bitcoin-core-dev
 58 2019-08-23T05:32:31  *** ddustin has joined #bitcoin-core-dev
 59 2019-08-23T05:42:24  *** davec has quit IRC
 60 2019-08-23T05:42:57  *** peltre_ has joined #bitcoin-core-dev
 61 2019-08-23T05:43:48  *** davec has joined #bitcoin-core-dev
 62 2019-08-23T05:45:34  *** pinheadmz has quit IRC
 63 2019-08-23T05:46:26  *** EagleTM has quit IRC
 64 2019-08-23T05:54:18  *** pinheadmz has joined #bitcoin-core-dev
 65 2019-08-23T05:55:10  *** lalitmee has quit IRC
 66 2019-08-23T05:55:39  *** lalitmee has joined #bitcoin-core-dev
 67 2019-08-23T05:58:30  *** lalit has joined #bitcoin-core-dev
 68 2019-08-23T06:00:02  *** rlaager1 has quit IRC
 69 2019-08-23T06:00:20  *** lalitmee has quit IRC
 70 2019-08-23T06:14:03  *** ddustin has quit IRC
 71 2019-08-23T06:14:40  *** ddustin has joined #bitcoin-core-dev
 72 2019-08-23T06:17:42  *** indolering has joined #bitcoin-core-dev
 73 2019-08-23T06:18:48  *** ddustin has quit IRC
 74 2019-08-23T06:19:54  *** seeder has quit IRC
 75 2019-08-23T06:35:24  *** ddustin has joined #bitcoin-core-dev
 76 2019-08-23T06:35:35  *** pinheadmz has quit IRC
 77 2019-08-23T06:41:25  *** ddustin has quit IRC
 78 2019-08-23T06:42:01  *** ddustin has joined #bitcoin-core-dev
 79 2019-08-23T06:42:06  *** rafalcpp has joined #bitcoin-core-dev
 80 2019-08-23T06:43:26  *** rafalcpp_ has quit IRC
 81 2019-08-23T06:45:35  *** ddustin_ has joined #bitcoin-core-dev
 82 2019-08-23T06:46:36  *** ddustin has quit IRC
 83 2019-08-23T06:51:54  *** ddustin_ has quit IRC
 84 2019-08-23T06:52:31  *** ddustin has joined #bitcoin-core-dev
 85 2019-08-23T06:57:22  *** ddustin has quit IRC
 86 2019-08-23T07:07:10  *** Giszmo has joined #bitcoin-core-dev
 87 2019-08-23T07:08:56  *** rafalcpp_ has joined #bitcoin-core-dev
 88 2019-08-23T07:09:12  *** rafalcpp has quit IRC
 89 2019-08-23T07:14:13  *** marcoagner has joined #bitcoin-core-dev
 90 2019-08-23T07:34:43  *** lalit has quit IRC
 91 2019-08-23T07:36:30  *** EagleTM has joined #bitcoin-core-dev
 92 2019-08-23T07:46:45  *** rafalcpp has joined #bitcoin-core-dev
 93 2019-08-23T07:46:59  *** rafalcpp_ has quit IRC
 94 2019-08-23T07:47:46  <warren> https://twitter.com/wtogami/status/1164805975615795202 <--- libfaketime 0.9.8 release is soon. I found it has regressions when tested against older userspace, maybe glibc. I don't know if this affects gitian but it really should be tested there.
 95 2019-08-23T07:49:55  *** jb55 has quit IRC
 96 2019-08-23T07:50:25  *** jb55 has joined #bitcoin-core-dev
 97 2019-08-23T07:59:52  *** setpill has joined #bitcoin-core-dev
 98 2019-08-23T08:12:08  *** EagleTM has quit IRC
 99 2019-08-23T08:20:41  *** rafalcpp_ has joined #bitcoin-core-dev
100 2019-08-23T08:20:52  *** rafalcpp has quit IRC
101 2019-08-23T08:24:20  *** lalit has joined #bitcoin-core-dev
102 2019-08-23T08:28:23  *** rafalcpp_ has quit IRC
103 2019-08-23T08:28:26  *** rafalcpp has joined #bitcoin-core-dev
104 2019-08-23T08:56:48  *** rex4539 has quit IRC
105 2019-08-23T08:58:11  *** rafalcpp_ has joined #bitcoin-core-dev
106 2019-08-23T08:58:48  *** rafalcpp has quit IRC
107 2019-08-23T09:00:02  *** indolering has quit IRC
108 2019-08-23T09:14:10  *** bitcoin-git has joined #bitcoin-core-dev
109 2019-08-23T09:14:11  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/43eaf76e0267...d72758c3f6c3
110 2019-08-23T09:14:11  <bitcoin-git> bitcoin/master bca388d fanquake: gui: remove unused PlatformStyle::TextColorIcon
111 2019-08-23T09:14:12  <bitcoin-git> bitcoin/master d72758c Jonas Schnelli: Merge #16677: gui: remove unused PlatformStyle::TextColorIcon
112 2019-08-23T09:14:14  *** bitcoin-git has left #bitcoin-core-dev
113 2019-08-23T09:14:59  *** bitcoin-git has joined #bitcoin-core-dev
114 2019-08-23T09:14:59  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #16677: gui: remove unused PlatformStyle::TextColorIcon (master...remove_unused_text_coloricon) https://github.com/bitcoin/bitcoin/pull/16677
115 2019-08-23T09:15:00  *** bitcoin-git has left #bitcoin-core-dev
116 2019-08-23T09:16:39  *** afk11 has quit IRC
117 2019-08-23T09:16:52  *** vosechu has joined #bitcoin-core-dev
118 2019-08-23T09:17:27  *** afk11 has joined #bitcoin-core-dev
119 2019-08-23T09:20:50  *** AaronvanW has quit IRC
120 2019-08-23T09:26:43  *** rafalcpp_ has quit IRC
121 2019-08-23T09:26:58  *** rafalcpp_ has joined #bitcoin-core-dev
122 2019-08-23T09:27:52  *** AaronvanW has joined #bitcoin-core-dev
123 2019-08-23T10:03:59  *** rafalcpp has joined #bitcoin-core-dev
124 2019-08-23T10:04:12  *** rafalcpp_ has quit IRC
125 2019-08-23T10:12:27  *** lalit is now known as lalitmee
126 2019-08-23T10:20:04  <fanquake> warren: I've compiled and run the tests on macOS. Looks like that got an autotools PR in progress. Might check that out later.
127 2019-08-23T10:24:37  <warren> fanquake: he's brute force "fixing" problems by adding lots of ifdefs, I'm not sure if those fixes are actually fixes. Now I'm told to edit the Makefile to workaround a failure on older glibc.
128 2019-08-23T10:25:33  <warren> I don't understand a lot of the more recent changes myself so I can't analyze
129 2019-08-23T10:34:44  *** lalitmee has quit IRC
130 2019-08-23T10:35:18  *** lalitmee has joined #bitcoin-core-dev
131 2019-08-23T10:41:52  *** bitcoin-git has joined #bitcoin-core-dev
132 2019-08-23T10:41:53  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d72758c3f6c3...442a9c647754
133 2019-08-23T10:41:54  <bitcoin-git> bitcoin/master be27161 Russell Yanofsky: Clarify need to specify --prefix with depends
134 2019-08-23T10:41:55  <bitcoin-git> bitcoin/master 2483266 Russell Yanofsky: packages.md: document depends build targets
135 2019-08-23T10:41:55  <bitcoin-git> bitcoin/master 442a9c6 fanquake: Merge #16691: doc: improve depends prefix documentation
136 2019-08-23T10:41:57  *** bitcoin-git has left #bitcoin-core-dev
137 2019-08-23T10:43:03  *** bitcoin-git has joined #bitcoin-core-dev
138 2019-08-23T10:43:03  <bitcoin-git> [bitcoin] fanquake merged pull request #16691: doc: improve depends prefix documentation (master...depends_improve_prefix_docs) https://github.com/bitcoin/bitcoin/pull/16691
139 2019-08-23T10:43:06  *** bitcoin-git has left #bitcoin-core-dev
140 2019-08-23T10:44:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
141 2019-08-23T10:46:30  <fanquake> jonatack: yea if you're doing more depends/docs stuff you can pick that nit up 👍
142 2019-08-23T10:48:15  <jonatack> fanquake: 👍
143 2019-08-23T10:49:48  *** rafalcpp has quit IRC
144 2019-08-23T10:49:56  *** rafalcpp has joined #bitcoin-core-dev
145 2019-08-23T11:25:11  *** hebasto has joined #bitcoin-core-dev
146 2019-08-23T11:33:25  *** PWChenD has joined #bitcoin-core-dev
147 2019-08-23T11:34:22  *** PWChenD has left #bitcoin-core-dev
148 2019-08-23T11:42:34  *** bitcoin-git has joined #bitcoin-core-dev
149 2019-08-23T11:42:34  <bitcoin-git> [bitcoin] fanquake opened pull request #16694: gui: Ensure transaction send error is always visible (master...rebased_squashed_14956) https://github.com/bitcoin/bitcoin/pull/16694
150 2019-08-23T11:42:36  *** bitcoin-git has left #bitcoin-core-dev
151 2019-08-23T11:42:54  *** bitcoin-git has joined #bitcoin-core-dev
152 2019-08-23T11:42:54  <bitcoin-git> [bitcoin] fanquake closed pull request #14956: [qt] Ensure tx send error highlight is visible (master...show-highlighted-field) https://github.com/bitcoin/bitcoin/pull/14956
153 2019-08-23T11:42:56  *** bitcoin-git has left #bitcoin-core-dev
154 2019-08-23T11:49:45  *** rafalcpp_ has joined #bitcoin-core-dev
155 2019-08-23T11:49:59  *** rafalcpp has quit IRC
156 2019-08-23T11:56:10  *** Chris_Stewart_5 has quit IRC
157 2019-08-23T11:58:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
158 2019-08-23T12:00:02  *** vosechu has quit IRC
159 2019-08-23T12:12:56  *** zivl has quit IRC
160 2019-08-23T12:27:05  *** rh0nj has quit IRC
161 2019-08-23T12:28:08  *** rh0nj has joined #bitcoin-core-dev
162 2019-08-23T12:36:30  *** rafalcpp has joined #bitcoin-core-dev
163 2019-08-23T12:36:47  *** rafalcpp_ has quit IRC
164 2019-08-23T12:49:20  *** kephra has joined #bitcoin-core-dev
165 2019-08-23T12:55:02  *** rafalcpp has quit IRC
166 2019-08-23T12:55:14  *** rafalcpp has joined #bitcoin-core-dev
167 2019-08-23T12:58:11  <fanquake> jonatack: Let me know if that issue persists. I'm seeing scrolling to the invalid recipient, regardless of it's position or if the address or amount is invalid.
168 2019-08-23T12:59:35  *** oriondeimos has joined #bitcoin-core-dev
169 2019-08-23T13:01:19  *** oriondeimos has quit IRC
170 2019-08-23T13:03:53  *** lalitmee has quit IRC
171 2019-08-23T13:06:54  <jonatack> fanquake: Yep, tested PR/master/PR on testnet with Debian, not scrolling into sight... btw the gui looks much nicer in your video then it does irl for me ;D
172 2019-08-23T13:08:38  <fanquake> jonatack: eh, if it doesn't work for everyone I'll just close and we can move onto other things.
173 2019-08-23T13:09:44  <fanquake> Definitely don't want to waste time with PRs like that.
174 2019-08-23T13:11:36  <jonatack> fanquake: Right. Maybe see if someone else on Debian confirms.
175 2019-08-23T13:23:28  *** setpill has quit IRC
176 2019-08-23T13:38:05  *** spaced0ut has quit IRC
177 2019-08-23T13:56:07  <Kvaciral>  7777777777777777777777777777777777777777777777777777777777777784pls0ntQ42
178 2019-08-23T13:56:36  *** captjakk has joined #bitcoin-core-dev
179 2019-08-23T14:02:00  *** rafalcpp_ has joined #bitcoin-core-dev
180 2019-08-23T14:02:08  *** rafalcpp has quit IRC
181 2019-08-23T14:07:20  <ariard> provoostenator: I don't get your comment, how 16561 is failing travis 5 and 8 on unit tests ?
182 2019-08-23T14:17:06  <hebasto> jonatack: what Debian version do you test on?
183 2019-08-23T14:28:56  *** Highway61 has quit IRC
184 2019-08-23T14:35:57  <jonatack> hebasto: I'm running a PureOS variant of Debian. uname -a gives Linux 4.19.0-5-amd64 #1 SMP Debian 4.19.37-5 (2019-06-19) x86_64 GNU/Linux
185 2019-08-23T14:36:01  <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
186 2019-08-23T14:36:13  <jonatack> hebasto: Qt 5.11.3 according to the GUI Help tab -> About Qt
187 2019-08-23T14:43:25  <achow101> anyone else seeing "Warning: unknown new rules activated (versionbit 1)" in getblockchaininfo? Were we just that unlucky with asicboost miners or did burying bip9 deployments accidentally cause this?
188 2019-08-23T14:43:40  *** pinheadmz has joined #bitcoin-core-dev
189 2019-08-23T14:44:16  <achow101> using a build of master from a few days ago
190 2019-08-23T14:47:24  *** schmidty_ has quit IRC
191 2019-08-23T14:47:45  *** schmidty_ has joined #bitcoin-core-dev
192 2019-08-23T14:56:04  *** schmidty_ has quit IRC
193 2019-08-23T14:56:05  *** schmidty_ has joined #bitcoin-core-dev
194 2019-08-23T14:56:05  *** schmidty_ has joined #bitcoin-core-dev
195 2019-08-23T14:56:19  *** schmidty_ is now known as schmidty
196 2019-08-23T14:56:48  *** Chris_Stewart_5 has quit IRC
197 2019-08-23T15:00:02  *** kephra has quit IRC
198 2019-08-23T15:00:08  <jonatack> achow101: yes i'm seeing it as well on recent master
199 2019-08-23T15:01:18  *** bitcoin-git has joined #bitcoin-core-dev
200 2019-08-23T15:01:18  <bitcoin-git> [bitcoin] leto opened pull request #16695: Add window final block height to getchaintxstats (master...getchaintxstats_height) https://github.com/bitcoin/bitcoin/pull/16695
201 2019-08-23T15:01:21  *** bitcoin-git has left #bitcoin-core-dev
202 2019-08-23T15:06:24  *** Highway61 has joined #bitcoin-core-dev
203 2019-08-23T15:17:16  *** Dean_Guss has quit IRC
204 2019-08-23T15:17:22  *** lahwran has joined #bitcoin-core-dev
205 2019-08-23T15:22:12  *** jarthur has joined #bitcoin-core-dev
206 2019-08-23T15:23:43  *** Giszmo has quit IRC
207 2019-08-23T15:25:15  *** bitcoin-git has joined #bitcoin-core-dev
208 2019-08-23T15:25:15  <bitcoin-git> [bitcoin] shargon opened pull request #16696: [validation] static_assert to ensure width in unit class (master...fix-uintbase) https://github.com/bitcoin/bitcoin/pull/16696
209 2019-08-23T15:25:17  *** bitcoin-git has left #bitcoin-core-dev
210 2019-08-23T15:25:35  *** bitcoin-git has joined #bitcoin-core-dev
211 2019-08-23T15:25:35  <bitcoin-git> [bitcoin] shargon closed pull request #16679: [validation] static_assert to ensure width in unit class (master...fix-unit-base) https://github.com/bitcoin/bitcoin/pull/16679
212 2019-08-23T15:25:40  *** bitcoin-git has left #bitcoin-core-dev
213 2019-08-23T15:25:56  *** thaumavorio has quit IRC
214 2019-08-23T15:26:29  *** Giszmo has joined #bitcoin-core-dev
215 2019-08-23T15:27:01  *** captjakk has quit IRC
216 2019-08-23T15:27:34  *** captjakk has joined #bitcoin-core-dev
217 2019-08-23T15:28:01  *** thaumavorio has joined #bitcoin-core-dev
218 2019-08-23T15:31:22  *** Giszmo has quit IRC
219 2019-08-23T15:31:43  *** captjakk has quit IRC
220 2019-08-23T15:35:06  *** Guyver2 has joined #bitcoin-core-dev
221 2019-08-23T15:49:14  *** nosss2 has joined #bitcoin-core-dev
222 2019-08-23T16:05:41  *** owowo has quit IRC
223 2019-08-23T16:09:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
224 2019-08-23T16:12:18  *** owowo has joined #bitcoin-core-dev
225 2019-08-23T16:13:39  *** kljasdfvv has quit IRC
226 2019-08-23T16:34:50  *** PWChenD has joined #bitcoin-core-dev
227 2019-08-23T16:37:53  *** PWChenD has quit IRC
228 2019-08-23T16:38:03  *** PWChenD has joined #bitcoin-core-dev
229 2019-08-23T16:49:16  *** bitcoin-git has joined #bitcoin-core-dev
230 2019-08-23T16:49:16  <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #16698: [WIP] Mempool: rework rebroadcast logic to improve privacy (master...rebroadcast) https://github.com/bitcoin/bitcoin/pull/16698
231 2019-08-23T16:49:29  *** bitcoin-git has left #bitcoin-core-dev
232 2019-08-23T16:50:28  *** PWChenD has left #bitcoin-core-dev
233 2019-08-23T16:50:33  *** PWChenD has joined #bitcoin-core-dev
234 2019-08-23T16:50:54  *** PWChenD has left #bitcoin-core-dev
235 2019-08-23T16:50:57  *** PWChenD has joined #bitcoin-core-dev
236 2019-08-23T16:59:37  *** owowo has quit IRC
237 2019-08-23T17:00:13  *** emilengler_ has quit IRC
238 2019-08-23T17:03:13  *** emilengler has joined #bitcoin-core-dev
239 2019-08-23T17:04:28  *** owowo has joined #bitcoin-core-dev
240 2019-08-23T17:12:13  *** PWChenD has quit IRC
241 2019-08-23T17:22:30  *** PWChenD has joined #bitcoin-core-dev
242 2019-08-23T17:32:48  *** xzytrewq has quit IRC
243 2019-08-23T17:33:02  *** xzytrewq has joined #bitcoin-core-dev
244 2019-08-23T17:39:49  *** m1rror has quit IRC
245 2019-08-23T17:40:14  *** m1rror has joined #bitcoin-core-dev
246 2019-08-23T17:45:41  *** PWChenD has quit IRC
247 2019-08-23T17:50:43  *** elichai2 has joined #bitcoin-core-dev
248 2019-08-23T18:00:01  *** lahwran has quit IRC
249 2019-08-23T18:17:21  *** SRV_DW20 has joined #bitcoin-core-dev
250 2019-08-23T18:27:37  *** iamtimmarchant has joined #bitcoin-core-dev
251 2019-08-23T18:34:52  *** iamtimmarchant has quit IRC
252 2019-08-23T18:42:06  *** bitcoin-git has joined #bitcoin-core-dev
253 2019-08-23T18:42:07  <bitcoin-git> [bitcoin] hebasto opened pull request #16701: qt: Replace functions deprecated in Qt 5.13 (partly) (master...20190823-qt13-deprecated) https://github.com/bitcoin/bitcoin/pull/16701
254 2019-08-23T18:42:08  *** bitcoin-git has left #bitcoin-core-dev
255 2019-08-23T18:47:36  *** lalitmee has joined #bitcoin-core-dev
256 2019-08-23T18:48:56  *** lalitmee has quit IRC
257 2019-08-23T18:49:25  *** lalitmee has joined #bitcoin-core-dev
258 2019-08-23T18:55:30  *** nosss2 has quit IRC
259 2019-08-23T19:09:34  <jnewbery> achow101: almost certainly due to burying bip9 deployments
260 2019-08-23T19:09:59  *** hebasto has quit IRC
261 2019-08-23T19:10:31  <provoostenator> ariard: https://travis-ci.org/bitcoin/bitcoin/builds/575909990?utm_source=github_status&utm_medium=notification
262 2019-08-23T19:11:09  <provoostenator> If you look at those logs it says "No output has been received in the last 10m0s" right before the functional test suite is supposed to run.
263 2019-08-23T19:11:30  <provoostenator> That's a bug that was fixed in #15561, so the problem should go away after you rebase.
264 2019-08-23T19:11:31  <gribble> https://github.com/bitcoin/bitcoin/issues/15561 | GitHub · Where software is built
265 2019-08-23T19:11:36  <provoostenator> Though MarcoFalke says not
266 2019-08-23T19:12:37  <instagibbs> "This issue has been deleted." that's... annoying feature
267 2019-08-23T19:13:29  <achow101> jnewbery: yes, see #16697
268 2019-08-23T19:13:30  <gribble> https://github.com/bitcoin/bitcoin/issues/16697 | Unknown version bit fork activated warning · Issue #16697 · bitcoin/bitcoin · GitHub
269 2019-08-23T19:14:19  *** pinheadmz has quit IRC
270 2019-08-23T19:16:18  <provoostenator> achow101 great catch!
271 2019-08-23T19:18:01  <provoostenator> instagibbs ariard: sorry, typo, I meant #16561
272 2019-08-23T19:18:04  <gribble> https://github.com/bitcoin/bitcoin/issues/16561 | tests: Use colors and dots in test_runner.py output only if standard output is a terminal by practicalswift · Pull Request #16561 · bitcoin/bitcoin · GitHub
273 2019-08-23T19:19:21  <jnewbery> I'd suggest we remove the "unknown new rules activated" warning entirely. It seems of dubious benefit.
274 2019-08-23T19:20:25  <provoostenator> jnewbery: it seems useful after a softfork, becuase  e.g. you might have something in your mempool that other nodes will never confirm
275 2019-08-23T19:21:00  <provoostenator> I suppose not actually, because of the standardness rules.
276 2019-08-23T19:21:34  <provoostenator> Still seems reasonable to warn people about softforks they don't know about.
277 2019-08-23T19:22:20  <jnewbery> we also warn on every block that 40-50 of the last 100 blocks were of unexpected version
278 2019-08-23T19:23:15  <provoostenator> I thought we killed those?
279 2019-08-23T19:23:30  <harding> provoostenator: those are still in the logs, but no longer the GUI.
280 2019-08-23T19:23:32  *** justanotheruser has quit IRC
281 2019-08-23T19:23:33  <provoostenator> Only keeping actual activation
282 2019-08-23T19:23:50  <jnewbery> A warning in the software that tries to tell you about an event that didn't exist when the software was written isn't very robust. We don't even know if there will be another BIP 9 activation.
283 2019-08-23T19:24:16  *** justanotheruser has joined #bitcoin-core-dev
284 2019-08-23T19:24:31  *** bitcoin-git has joined #bitcoin-core-dev
285 2019-08-23T19:24:31  <bitcoin-git> [bitcoin] naumenkogs opened pull request #16702: p2p: supplying and using asmap to improve IP bucketing in addrman (master...asn_buckets) https://github.com/bitcoin/bitcoin/pull/16702
286 2019-08-23T19:24:32  *** bitcoin-git has left #bitcoin-core-dev
287 2019-08-23T19:24:43  <provoostenator> I would say that even a false positive BIP9 activation message suggests something is going on that the user needs to look into.
288 2019-08-23T19:26:03  <achow101> I don't think it makes sense to get rid of fork warnings altogether
289 2019-08-23T19:26:05  <gleb> Could you mark #16702 draft? It certainly has couple questions to address (todos) before merging, although the code is working and I even have tests :)
290 2019-08-23T19:26:07  <gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
291 2019-08-23T19:30:42  <harding> I worry that the warning could be abused.  E.g., miners with sufficient hashrate can trigger the warning at any time.  If this was combined with, say, a compromise of Bitcoin.org or BitcoinCore.org, they could possibly get a lot of people to "upgrade" to compromised software.
292 2019-08-23T19:37:43  *** alko has quit IRC
293 2019-08-23T19:37:47  *** alko_ has joined #bitcoin-core-dev
294 2019-08-23T19:42:57  <achow101> reading through the warning code, I can't actually figure out how having the deployment parameters prevented the warning from constantly triggering
295 2019-08-23T19:44:02  *** davex__ has joined #bitcoin-core-dev
296 2019-08-23T19:47:10  <jnewbery> achow, yeah it took me a while to figure it out! I think it's this line in the WarningsBitConditionChecker::Condition(): https://github.com/bitcoin/bitcoin/blob/442a9c64775454a7073aff9872721c58b1dd35c5/src/validation.cpp#L1639
297 2019-08-23T19:47:54  <jnewbery> that prevents it triggering for STARTED or LOCKED_IN versionbits activations
298 2019-08-23T19:48:24  <achow101> oh, I see now
299 2019-08-23T19:57:47  *** ctrlbreak has quit IRC
300 2019-08-23T19:58:16  *** ctrlbreak has joined #bitcoin-core-dev
301 2019-08-23T20:14:47  *** jarthur has quit IRC
302 2019-08-23T20:19:10  *** zrc has joined #bitcoin-core-dev
303 2019-08-23T20:35:53  *** bitcoin-git has joined #bitcoin-core-dev
304 2019-08-23T20:35:53  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16703: rpc: Expose GetUTXOStats for testing (master...1908-rpcTestGetUTXOStats) https://github.com/bitcoin/bitcoin/pull/16703
305 2019-08-23T20:35:54  *** bitcoin-git has left #bitcoin-core-dev
306 2019-08-23T20:39:51  *** bitcoin-git has joined #bitcoin-core-dev
307 2019-08-23T20:39:51  <bitcoin-git> [bitcoin] achow101 opened pull request #16704: Don't warn about activated buried BIP 9 deployments (master...buried-versionbits-cache) https://github.com/bitcoin/bitcoin/pull/16704
308 2019-08-23T20:39:54  *** bitcoin-git has left #bitcoin-core-dev
309 2019-08-23T20:54:38  *** Guyver2 has quit IRC
310 2019-08-23T20:54:45  *** rafalcpp has joined #bitcoin-core-dev
311 2019-08-23T20:55:00  *** rafalcpp_ has quit IRC
312 2019-08-23T21:00:02  *** SRV_DW20 has quit IRC
313 2019-08-23T21:10:43  *** Chris_Stewart_5 has quit IRC
314 2019-08-23T21:10:53  *** fox2p has joined #bitcoin-core-dev
315 2019-08-23T21:14:13  *** jamesl22 has quit IRC
316 2019-08-23T21:17:32  *** mrd has joined #bitcoin-core-dev
317 2019-08-23T21:17:41  *** mrd is now known as Guest56340
318 2019-08-23T21:47:28  *** davex__ has quit IRC
319 2019-08-23T21:57:46  *** ddustin has joined #bitcoin-core-dev
320 2019-08-23T21:58:32  *** davex__ has joined #bitcoin-core-dev
321 2019-08-23T21:59:48  <emilengler> What are the steps to do to add a new file to the compilation process?
322 2019-08-23T22:00:05  <emilengler> Only add it to Makefile.am and then run a ./configure again?
323 2019-08-23T22:04:00  <ariard> provoostenator: works now, was a potential deadlock issue well hindered by a boost mishandling of abort in a obscure travis log (see 16700)
324 2019-08-23T22:04:23  <luke-jr> emilengler: there might be some dumb MSVC stuff now too :x
325 2019-08-23T22:05:30  <emilengler> luke-jr: That will be funny, not even full C98 support iirc
326 2019-08-23T22:06:10  <luke-jr> emilengler: C++ is not C
327 2019-08-23T22:07:29  <emilengler> luke-jr: Sure thing but we use C functions right?
328 2019-08-23T22:08:22  <sipa> the libsecp256k1 subtree is compiled with a C compiler
329 2019-08-23T22:08:26  <sipa> but libsecp256k1 is C89
330 2019-08-23T22:08:45  <sipa> the rest is all compiled with C++ i believe
331 2019-08-23T22:10:10  <sipa> also, the msvc makefile is autogenerated from Makefile.am i think
332 2019-08-23T22:10:36  <emilengler> But back to my question, is adding it to Makefile.am enough for a unix compilation? I'm not familiar with autotools
333 2019-08-23T22:10:47  <sipa> yes
334 2019-08-23T22:11:03  <sipa> you could figure this out yourself by grepping for an existing source file name
335 2019-08-23T22:11:38  *** Highway62 has joined #bitcoin-core-dev
336 2019-08-23T22:12:07  *** Highway61 has quit IRC
337 2019-08-23T22:12:07  *** Highway62 is now known as Highway61
338 2019-08-23T22:13:46  *** ddustin has quit IRC
339 2019-08-23T22:14:22  *** ddustin has joined #bitcoin-core-dev
340 2019-08-23T22:17:47  *** lalitmee has quit IRC
341 2019-08-23T22:19:04  *** ddustin has quit IRC
342 2019-08-23T22:22:31  *** rafalcpp_ has joined #bitcoin-core-dev
343 2019-08-23T22:23:10  *** rafalcpp has quit IRC
344 2019-08-23T22:37:22  *** Highway61 has quit IRC
345 2019-08-23T22:41:57  *** bitcoin-git has joined #bitcoin-core-dev
346 2019-08-23T22:41:57  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #16453: validation: Run CheckBlockIndex only on success for now (master...1907-validationCheckBlockIndexSuccess) https://github.com/bitcoin/bitcoin/pull/16453
347 2019-08-23T22:41:58  *** bitcoin-git has left #bitcoin-core-dev
348 2019-08-23T23:32:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
349 2019-08-23T23:44:52  *** marcoagner has quit IRC
350 2019-08-23T23:53:49  *** Chris_Stewart_5 has quit IRC