12019-08-28T00:00:01 *** drybjed1 has quit IRC
22019-08-28T00:10:25 <warren> meshcollider: meaning "git tag -s" type signatures are safe despite sha1 not being safe?
32019-08-28T00:10:50 <warren> when the news came out I remembered reading somewhere that only git signed commits are safe
42019-08-28T00:17:00 *** Steini- has joined #bitcoin-core-dev
52019-08-28T00:22:04 *** Dean_Guss has joined #bitcoin-core-dev
62019-08-28T00:37:36 *** elichai2 has quit IRC
72019-08-28T00:40:47 *** Dean_Guss has quit IRC
82019-08-28T00:53:34 *** jungly has quit IRC
92019-08-28T00:53:59 *** jungly has joined #bitcoin-core-dev
102019-08-28T00:58:15 *** lightlike has quit IRC
112019-08-28T01:05:08 *** Aaronvan_ has quit IRC
122019-08-28T01:13:37 *** brianhoffman_ has joined #bitcoin-core-dev
132019-08-28T01:13:50 *** brianhoffman has quit IRC
142019-08-28T01:13:50 *** brianhoffman_ is now known as brianhoffman
152019-08-28T01:16:55 <meshcollider> Oh actually even an annotated tag would just reference the commit by sha1 hash I think, so it would still rely on second preimage resistance
162019-08-28T01:17:19 *** profmac has quit IRC
172019-08-28T01:17:47 <meshcollider> Why don't we include the tree-sha512 in the tag just like in the merge commits?
182019-08-28T01:17:56 <sipa> can we?
192019-08-28T01:18:08 <sipa> oh, tags have associated text
202019-08-28T01:18:49 <meshcollider> Yeah they can do, and wumpus usually adds text like "Bitcoin Core 0.18.1 release candidate 1"
212019-08-28T01:21:05 *** neyaoz has left #bitcoin-core-dev
222019-08-28T01:21:37 <meshcollider> wumpus: do you usually just tag with git tag -m or is there a script you use
232019-08-28T01:28:09 *** marcinja_ has joined #bitcoin-core-dev
242019-08-28T01:34:48 *** ddustin has joined #bitcoin-core-dev
252019-08-28T01:35:03 *** marcinja has quit IRC
262019-08-28T01:35:10 *** marcinja has joined #bitcoin-core-dev
272019-08-28T01:35:42 *** marcinja_ has quit IRC
282019-08-28T01:38:31 *** harding has quit IRC
292019-08-28T01:38:39 *** marcinja_ has joined #bitcoin-core-dev
302019-08-28T01:40:46 *** AaronvanW has joined #bitcoin-core-dev
312019-08-28T01:45:03 *** AaronvanW has quit IRC
322019-08-28T01:46:13 *** Dean_Guss has joined #bitcoin-core-dev
332019-08-28T01:57:44 *** _Sam-- is now known as kneedrag
342019-08-28T02:00:10 *** harding has joined #bitcoin-core-dev
352019-08-28T02:00:46 *** awesome-doge has joined #bitcoin-core-dev
362019-08-28T02:03:34 *** awesome-doge has joined #bitcoin-core-dev
372019-08-28T02:07:01 *** Dean_Guss has quit IRC
382019-08-28T02:08:22 *** emilengler has quit IRC
392019-08-28T02:11:54 *** emilengler has joined #bitcoin-core-dev
402019-08-28T02:19:41 *** AaronvanW has joined #bitcoin-core-dev
412019-08-28T02:27:58 *** neyaoz has joined #bitcoin-core-dev
422019-08-28T02:28:42 *** awesome-doge has quit IRC
432019-08-28T02:28:58 *** hhhhhhhhhhh has joined #bitcoin-core-dev
442019-08-28T02:29:25 *** neyaoz has left #bitcoin-core-dev
452019-08-28T02:32:15 *** Dean_Guss has joined #bitcoin-core-dev
462019-08-28T02:32:42 *** neyaoz has joined #bitcoin-core-dev
472019-08-28T02:35:28 *** captjakk has joined #bitcoin-core-dev
482019-08-28T02:38:52 *** ddustin_ has joined #bitcoin-core-dev
492019-08-28T02:39:55 *** neyaoz has left #bitcoin-core-dev
502019-08-28T02:40:03 *** ddustin has quit IRC
512019-08-28T02:43:30 *** neyaoz has joined #bitcoin-core-dev
522019-08-28T02:43:47 *** harding has quit IRC
532019-08-28T02:45:49 *** harding has joined #bitcoin-core-dev
542019-08-28T02:53:48 *** AaronvanW has quit IRC
552019-08-28T03:00:01 *** Steini- has quit IRC
562019-08-28T03:19:54 *** Highway62 has joined #bitcoin-core-dev
572019-08-28T03:21:43 *** Highway61 has quit IRC
582019-08-28T03:21:43 *** Highway62 is now known as Highway61
592019-08-28T03:22:11 *** AaronvanW has joined #bitcoin-core-dev
602019-08-28T03:26:20 *** jarthur has joined #bitcoin-core-dev
612019-08-28T03:28:08 *** Dean_Guss has quit IRC
622019-08-28T03:29:13 *** AaronvanW has quit IRC
632019-08-28T03:31:02 *** jarthur has quit IRC
642019-08-28T03:40:34 *** Highway61 has quit IRC
652019-08-28T03:41:58 *** hebasto has quit IRC
662019-08-28T03:47:02 *** pinheadmz has joined #bitcoin-core-dev
672019-08-28T03:47:56 *** nerdboy1 has joined #bitcoin-core-dev
682019-08-28T04:06:11 *** captjakk has quit IRC
692019-08-28T04:10:40 *** lalitmee has joined #bitcoin-core-dev
702019-08-28T04:10:43 *** hhhhhhhhhhh has quit IRC
712019-08-28T04:16:49 *** ddustin has joined #bitcoin-core-dev
722019-08-28T04:20:07 *** ddustin_ has quit IRC
732019-08-28T04:26:54 *** profmac has joined #bitcoin-core-dev
742019-08-28T04:29:01 *** hhhhhhhhhhh has joined #bitcoin-core-dev
752019-08-28T04:29:56 *** pinheadmz has quit IRC
762019-08-28T04:31:52 *** Victor_sueca has joined #bitcoin-core-dev
772019-08-28T04:32:43 *** pinheadmz has joined #bitcoin-core-dev
782019-08-28T04:34:28 *** Victorsueca has quit IRC
792019-08-28T04:40:19 *** jcorgan_ has quit IRC
802019-08-28T04:40:27 *** jcorgan has joined #bitcoin-core-dev
812019-08-28T04:43:27 *** AaronvanW has joined #bitcoin-core-dev
822019-08-28T04:47:03 *** profmac has quit IRC
832019-08-28T04:47:48 *** awesome-doge[m] has joined #bitcoin-core-dev
842019-08-28T04:48:08 *** AaronvanW has quit IRC
852019-08-28T05:19:27 *** AaronvanW has joined #bitcoin-core-dev
862019-08-28T05:23:49 *** AaronvanW has quit IRC
872019-08-28T05:58:05 *** AaronvanW has joined #bitcoin-core-dev
882019-08-28T05:59:48 *** Highway61 has joined #bitcoin-core-dev
892019-08-28T06:00:02 *** nerdboy1 has quit IRC
902019-08-28T06:03:16 *** AaronvanW has quit IRC
912019-08-28T06:17:52 *** MononcQc1 has joined #bitcoin-core-dev
922019-08-28T06:23:50 *** Giszmo has quit IRC
932019-08-28T06:23:56 *** Giszmo1 has joined #bitcoin-core-dev
942019-08-28T06:24:07 *** profmac has joined #bitcoin-core-dev
952019-08-28T06:34:24 *** AaronvanW has joined #bitcoin-core-dev
962019-08-28T06:39:00 *** AaronvanW has quit IRC
972019-08-28T07:03:48 *** Highway61 has quit IRC
982019-08-28T07:06:05 *** pinheadmz has quit IRC
992019-08-28T07:11:27 *** AaronvanW has joined #bitcoin-core-dev
1002019-08-28T07:15:49 *** AaronvanW has quit IRC
1012019-08-28T07:16:30 *** EagleTM has joined #bitcoin-core-dev
1022019-08-28T07:18:45 *** rafalcpp_ has joined #bitcoin-core-dev
1032019-08-28T07:18:47 *** rafalcpp has quit IRC
1042019-08-28T07:24:43 *** rockhouse has quit IRC
1052019-08-28T07:24:44 *** victorSN has quit IRC
1062019-08-28T07:25:28 *** victorSN has joined #bitcoin-core-dev
1072019-08-28T07:25:40 *** ddustin has quit IRC
1082019-08-28T07:26:00 *** ddustin has joined #bitcoin-core-dev
1092019-08-28T07:26:53 *** ddustin has joined #bitcoin-core-dev
1102019-08-28T07:27:00 *** jarthur has joined #bitcoin-core-dev
1112019-08-28T07:27:15 *** ddustin has quit IRC
1122019-08-28T07:27:36 *** ddustin has joined #bitcoin-core-dev
1132019-08-28T07:28:03 *** ddustin has quit IRC
1142019-08-28T07:28:22 *** ddustin has joined #bitcoin-core-dev
1152019-08-28T07:28:38 *** rockhouse has joined #bitcoin-core-dev
1162019-08-28T07:28:49 *** EagleTM has quit IRC
1172019-08-28T07:28:50 *** ddustin has quit IRC
1182019-08-28T07:29:07 *** ddustin has joined #bitcoin-core-dev
1192019-08-28T07:31:52 *** jarthur has quit IRC
1202019-08-28T07:38:16 *** kljasdfvv has joined #bitcoin-core-dev
1212019-08-28T07:48:42 *** AaronvanW has joined #bitcoin-core-dev
1222019-08-28T07:52:07 *** lalitmee has quit IRC
1232019-08-28T07:52:58 *** AaronvanW has quit IRC
1242019-08-28T08:04:00 *** ddustin has joined #bitcoin-core-dev
1252019-08-28T08:09:12 *** ddustin has quit IRC
1262019-08-28T08:17:00 *** rafalcpp has joined #bitcoin-core-dev
1272019-08-28T08:17:23 *** rafalcpp_ has quit IRC
1282019-08-28T08:22:50 *** AaronvanW has joined #bitcoin-core-dev
1292019-08-28T08:27:23 *** AaronvanW has quit IRC
1302019-08-28T08:28:32 *** AaronvanW has joined #bitcoin-core-dev
1312019-08-28T08:31:23 *** hhhhhhhhhhh has quit IRC
1322019-08-28T08:31:44 *** hhhhhhhhhhh has joined #bitcoin-core-dev
1332019-08-28T08:42:15 *** lalitmee has joined #bitcoin-core-dev
1342019-08-28T09:00:01 *** MononcQc1 has quit IRC
1352019-08-28T09:17:26 *** MarconM has joined #bitcoin-core-dev
1362019-08-28T09:34:17 *** Highway61 has joined #bitcoin-core-dev
1372019-08-28T09:58:39 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1382019-08-28T10:12:48 *** Highway61 has quit IRC
1392019-08-28T10:21:42 *** provoostenator has quit IRC
1402019-08-28T10:24:13 *** provoostenator has joined #bitcoin-core-dev
1412019-08-28T10:29:26 *** lalitmee has quit IRC
1422019-08-28T10:30:11 *** lalitmee has joined #bitcoin-core-dev
1432019-08-28T10:41:58 *** lalitmee has quit IRC
1442019-08-28T10:42:19 *** jarthur has joined #bitcoin-core-dev
1452019-08-28T10:47:31 *** jarthur has quit IRC
1462019-08-28T10:50:08 *** lalitmee has joined #bitcoin-core-dev
1472019-08-28T10:50:36 *** lalitmee has quit IRC
1482019-08-28T10:51:53 *** lalitmee has joined #bitcoin-core-dev
1492019-08-28T11:06:11 *** ddustin has joined #bitcoin-core-dev
1502019-08-28T11:10:52 *** ddustin has quit IRC
1512019-08-28T11:20:06 <wumpus> meshcollider: I simply use git tag -s, but yes I think that's a good idea
1522019-08-28T11:22:06 <wumpus> could have a script that automatically makes and signs the tag
1532019-08-28T11:22:38 *** tryphe_ has joined #bitcoin-core-dev
1542019-08-28T11:22:47 <wumpus> and adds in the treehash
1552019-08-28T11:24:56 *** tryphe has quit IRC
1562019-08-28T11:29:49 *** Highway61 has joined #bitcoin-core-dev
1572019-08-28T11:45:27 *** EagleTM has joined #bitcoin-core-dev
1582019-08-28T11:52:40 *** Chris_Stewart_5 has quit IRC
1592019-08-28T11:55:21 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1602019-08-28T12:00:01 *** MarconM has quit IRC
1612019-08-28T12:05:52 *** sdaftuar has quit IRC
1622019-08-28T12:06:32 *** sdaftuar has joined #bitcoin-core-dev
1632019-08-28T12:11:14 *** hhhhhhhhhhh has quit IRC
1642019-08-28T12:17:18 *** quaid1 has joined #bitcoin-core-dev
1652019-08-28T12:24:45 *** AaronvanW has quit IRC
1662019-08-28T12:28:21 *** hhhhhhhhhhh has joined #bitcoin-core-dev
1672019-08-28T12:28:48 *** lightlike has joined #bitcoin-core-dev
1682019-08-28T12:35:37 *** hhhhhhhhhhh has quit IRC
1692019-08-28T12:35:43 *** lalitmee has quit IRC
1702019-08-28T12:36:03 *** hhhhhhhhhhh has joined #bitcoin-core-dev
1712019-08-28T12:57:56 *** EagleTM has quit IRC
1722019-08-28T12:59:49 *** liberiga has joined #bitcoin-core-dev
1732019-08-28T13:07:06 *** ddustin has joined #bitcoin-core-dev
1742019-08-28T13:11:49 *** ddustin has quit IRC
1752019-08-28T13:15:00 <meshcollider> It'd be pretty simple to make compared to the GitHub merge script, if you'd be happy to use it
1762019-08-28T13:18:39 *** captjakk has joined #bitcoin-core-dev
1772019-08-28T13:25:54 *** tsujp has quit IRC
1782019-08-28T13:26:12 *** jonatack has quit IRC
1792019-08-28T13:28:01 *** Highway62 has joined #bitcoin-core-dev
1802019-08-28T13:28:30 *** Highway61 has quit IRC
1812019-08-28T13:28:44 *** Highway62 is now known as Highway61
1822019-08-28T13:28:48 *** tsujp has joined #bitcoin-core-dev
1832019-08-28T13:31:47 *** hhhhhhhhhhh has quit IRC
1842019-08-28T13:34:21 *** hhhhhhhhhhh has joined #bitcoin-core-dev
1852019-08-28T13:40:52 *** hhhhhhhhhhh has quit IRC
1862019-08-28T13:45:29 *** ddustin has joined #bitcoin-core-dev
1872019-08-28T13:55:41 *** jonatack has joined #bitcoin-core-dev
1882019-08-28T13:56:15 *** captjakk has quit IRC
1892019-08-28T13:57:20 *** tsujp has quit IRC
1902019-08-28T13:57:41 <promag> jamesob: #16718 also improves -reindex-chainstate right?
1912019-08-28T13:57:43 <gribble> https://github.com/bitcoin/bitcoin/issues/16718 | Improve speed, memory efficiency with alternate hashmap by jamesob · Pull Request #16718 · bitcoin/bitcoin · GitHub
1922019-08-28T14:03:37 *** tsujp has joined #bitcoin-core-dev
1932019-08-28T14:04:25 *** elichai2 has joined #bitcoin-core-dev
1942019-08-28T14:12:41 <sipa> it should
1952019-08-28T14:26:33 <promag> right, so maybe show numbers of that instead of ibd
1962019-08-28T14:34:32 *** sdaftuar has quit IRC
1972019-08-28T14:35:29 *** sdaftuar has joined #bitcoin-core-dev
1982019-08-28T14:42:20 *** jarthur has joined #bitcoin-core-dev
1992019-08-28T14:51:15 *** awesome-doge[m] has left #bitcoin-core-dev
2002019-08-28T14:55:01 *** rh0nj has quit IRC
2012019-08-28T14:56:07 *** rh0nj has joined #bitcoin-core-dev
2022019-08-28T14:56:38 *** jnewbery has quit IRC
2032019-08-28T14:56:51 *** sdaftuar has quit IRC
2042019-08-28T14:57:00 *** jnewbery has joined #bitcoin-core-dev
2052019-08-28T14:57:20 *** sdaftuar has joined #bitcoin-core-dev
2062019-08-28T14:58:33 <instagibbs> healing power of "and".
2072019-08-28T14:58:49 <instagibbs> IDB under ideal circumstances is more the metric we care about, just harder to make it ideal
2082019-08-28T14:58:53 *** tryphe_ is now known as tryphe
2092019-08-28T15:00:01 *** quaid1 has quit IRC
2102019-08-28T15:03:11 *** pinheadmz has joined #bitcoin-core-dev
2112019-08-28T15:09:28 *** Highway61 has quit IRC
2122019-08-28T15:10:25 *** hebasto has joined #bitcoin-core-dev
2132019-08-28T15:10:54 *** Highway61 has joined #bitcoin-core-dev
2142019-08-28T15:11:20 *** sdaftuar has quit IRC
2152019-08-28T15:11:56 *** sdaftuar has joined #bitcoin-core-dev
2162019-08-28T15:12:11 *** awesome-doge has joined #bitcoin-core-dev
2172019-08-28T15:13:24 *** ccdle12 has joined #bitcoin-core-dev
2182019-08-28T15:17:04 *** tsujp has quit IRC
2192019-08-28T15:17:18 *** Trixar_za has joined #bitcoin-core-dev
2202019-08-28T15:23:51 *** sdaftuar has quit IRC
2212019-08-28T15:25:21 *** sdaftuar has joined #bitcoin-core-dev
2222019-08-28T15:27:57 *** ddustin has quit IRC
2232019-08-28T15:29:03 *** sdaftuar has quit IRC
2242019-08-28T15:29:03 *** jnewbery has quit IRC
2252019-08-28T15:29:34 *** sdaftuar has joined #bitcoin-core-dev
2262019-08-28T15:29:55 *** jnewbery has joined #bitcoin-core-dev
2272019-08-28T15:33:16 *** jarthur has quit IRC
2282019-08-28T15:34:16 *** sdaftuar has quit IRC
2292019-08-28T15:34:28 *** jnewbery has quit IRC
2302019-08-28T15:34:54 *** jnewbery has joined #bitcoin-core-dev
2312019-08-28T15:35:00 *** sdaftuar has joined #bitcoin-core-dev
2322019-08-28T15:37:05 *** chainhead has quit IRC
2332019-08-28T15:39:20 *** chainhead has joined #bitcoin-core-dev
2342019-08-28T15:40:28 *** sdaftuar has quit IRC
2352019-08-28T15:40:35 *** jnewbery has quit IRC
2362019-08-28T15:40:48 *** jnewbery has joined #bitcoin-core-dev
2372019-08-28T15:40:57 *** sdaftuar has joined #bitcoin-core-dev
2382019-08-28T15:54:13 *** jnewbery has quit IRC
2392019-08-28T15:54:20 *** sdaftuar has quit IRC
2402019-08-28T16:11:35 *** jnewbery has joined #bitcoin-core-dev
2412019-08-28T16:21:57 *** sdaftuar has joined #bitcoin-core-dev
2422019-08-28T16:38:56 *** csknk has joined #bitcoin-core-dev
2432019-08-28T16:39:16 *** bitcoin-git has joined #bitcoin-core-dev
2442019-08-28T16:39:17 <bitcoin-git> [bitcoin] theStack opened pull request #16742: test: add executable flag for wallet_watchonly.py (master...add_execflag_for_wallet_watchonly_py) https://github.com/bitcoin/bitcoin/pull/16742
2452019-08-28T16:39:18 *** bitcoin-git has left #bitcoin-core-dev
2462019-08-28T16:41:21 *** TheHoliestRoger is now known as ThaHandyRoger
2472019-08-28T16:49:41 *** Karyon has quit IRC
2482019-08-28T16:51:27 *** Karyon has joined #bitcoin-core-dev
2492019-08-28T16:58:20 *** jnewbery_ has joined #bitcoin-core-dev
2502019-08-28T16:59:41 *** michaelfolkson has joined #bitcoin-core-dev
2512019-08-28T17:02:15 *** jungly has quit IRC
2522019-08-28T17:08:08 *** bitcoin-git has joined #bitcoin-core-dev
2532019-08-28T17:08:08 <bitcoin-git> [bitcoin] jamesob opened pull request #16743: refactor: move LoadChainTip/RelayBlocks under CChainState (master...2019-08-au-chainstate-moves) https://github.com/bitcoin/bitcoin/pull/16743
2542019-08-28T17:08:09 *** bitcoin-git has left #bitcoin-core-dev
2552019-08-28T17:14:36 *** rafalcpp_ has joined #bitcoin-core-dev
2562019-08-28T17:14:51 *** rafalcpp has quit IRC
2572019-08-28T17:19:16 *** liberiga has quit IRC
2582019-08-28T17:19:50 *** Chris_Stewart_5 has quit IRC
2592019-08-28T17:20:27 *** pinheadmz_ has joined #bitcoin-core-dev
2602019-08-28T17:21:18 *** pinheadmz has quit IRC
2612019-08-28T17:21:18 *** pinheadmz_ is now known as pinheadmz
2622019-08-28T17:25:44 *** bitcoin-git has joined #bitcoin-core-dev
2632019-08-28T17:25:44 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a7be1cc92be4...2d38950e5dbd
2642019-08-28T17:25:45 <bitcoin-git> bitcoin/master 71e08ab Sebastian Falbesoner: test: add executable flag for wallet_watchonly.py
2652019-08-28T17:25:45 <bitcoin-git> bitcoin/master 2d38950 MarcoFalke: Merge #16742: test: add executable flag for wallet_watchonly.py
2662019-08-28T17:25:47 *** bitcoin-git has left #bitcoin-core-dev
2672019-08-28T17:26:53 *** bitcoin-git has joined #bitcoin-core-dev
2682019-08-28T17:26:53 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16742: test: add executable flag for wallet_watchonly.py (master...add_execflag_for_wallet_watchonly_py) https://github.com/bitcoin/bitcoin/pull/16742
2692019-08-28T17:26:56 *** bitcoin-git has left #bitcoin-core-dev
2702019-08-28T17:28:19 *** jarthur has joined #bitcoin-core-dev
2712019-08-28T17:28:33 *** sicktastic has joined #bitcoin-core-dev
2722019-08-28T17:29:05 *** captjakk has joined #bitcoin-core-dev
2732019-08-28T17:31:59 *** bitcoin-git has joined #bitcoin-core-dev
2742019-08-28T17:32:00 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d38950e5dbd...119e97ae2d80
2752019-08-28T17:32:00 <bitcoin-git> bitcoin/master 403e372 João Barbosa: qa: Relax so that the subscriber is ready before publishing zmq messages
2762019-08-28T17:32:00 <bitcoin-git> bitcoin/master 119e97a MarcoFalke: Merge #16740: qa: Relax so that the subscriber is ready before publishing ...
2772019-08-28T17:32:01 *** bitcoin-git has left #bitcoin-core-dev
2782019-08-28T17:32:54 *** sicktastic has quit IRC
2792019-08-28T17:32:55 *** bitcoin-git has joined #bitcoin-core-dev
2802019-08-28T17:32:55 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16740: qa: Relax so that the subscriber is ready before publishing zmq messages (master...2019-08-slowjoiner) https://github.com/bitcoin/bitcoin/pull/16740
2812019-08-28T17:32:56 *** bitcoin-git has left #bitcoin-core-dev
2822019-08-28T17:33:24 *** rafalcpp has joined #bitcoin-core-dev
2832019-08-28T17:33:24 *** rafalcpp_ has quit IRC
2842019-08-28T17:35:20 *** bitcoin-git has joined #bitcoin-core-dev
2852019-08-28T17:35:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/119e97ae2d80...cc40b55da70b
2862019-08-28T17:35:21 <bitcoin-git> bitcoin/master 25dd867 practicalswift: Avoid using mutable default parameter values
2872019-08-28T17:35:21 <bitcoin-git> bitcoin/master e4f4ea4 practicalswift: lint: Catch use of [] or {} as default parameter values in Python functions
2882019-08-28T17:35:22 <bitcoin-git> bitcoin/master cc40b55 MarcoFalke: Merge #16726: tests: Avoid common Python default parameter gotcha when mut...
2892019-08-28T17:35:23 *** bitcoin-git has left #bitcoin-core-dev
2902019-08-28T17:35:42 *** captjakk_ has joined #bitcoin-core-dev
2912019-08-28T17:36:23 *** bitcoin-git has joined #bitcoin-core-dev
2922019-08-28T17:36:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16726: tests: Avoid common Python default parameter gotcha when mutable dict/list:s are used as default parameter values (master...python-mutable-default-parameter-values) https://github.com/bitcoin/bitcoin/pull/16726
2932019-08-28T17:36:25 *** bitcoin-git has left #bitcoin-core-dev
2942019-08-28T17:39:13 *** captjakk has quit IRC
2952019-08-28T17:43:15 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2962019-08-28T17:56:09 *** Chris_Stewart_5 has quit IRC
2972019-08-28T17:56:43 *** IGHOR has quit IRC
2982019-08-28T17:59:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2992019-08-28T18:00:02 *** Trixar_za has quit IRC
3002019-08-28T18:01:02 *** IGHOR has joined #bitcoin-core-dev
3012019-08-28T18:01:13 <gleb> provoostenator: Do we really want to download asmap.raw needed for testing from somewhere online? Where do you think it belongs, somewhere on github? Maybe in the repo with scripts to build asmap
3022019-08-28T18:01:37 <provoostenator> We host a bunch of bigger files on bitcoincore.org
3032019-08-28T18:01:55 <provoostenator> Like the macOS SDK
3042019-08-28T18:02:49 *** jnewbery_ has quit IRC
3052019-08-28T18:02:54 <gleb> And then, perhaps if file is not available â omit those tests with a warning or something.
3062019-08-28T18:02:58 <provoostenator> A torrent could add some redudancy
3072019-08-28T18:04:01 <gleb> Sounds like an overkill to me. Alternative source might be the repo with scripts to build asmap.raw, if we end up having a dedicated repo.
3082019-08-28T18:04:04 <provoostenator> Yes, if missing the test can be skipped, we have a standard method for that in the functional test suite.
3092019-08-28T18:04:33 <provoostenator> Building it manually wouldn't be determinstic, right?
3102019-08-28T18:05:20 <sipa> gleb: for testing we don't actually need a big asmap, right?
3112019-08-28T18:05:29 <sipa> we could construct a simplified one of a few kilobytes
3122019-08-28T18:05:42 <provoostenator> There should be a way for people to verify that the end result that we ship is generated from something that they can at least in principle download / generate.
3132019-08-28T18:06:55 <gleb> sipa: Yeah, I had that on mind too.
3142019-08-28T18:08:57 *** Rodrigues has joined #bitcoin-core-dev
3152019-08-28T18:09:25 *** Rodrigues has left #bitcoin-core-dev
3162019-08-28T18:17:36 *** Maqs1 has joined #bitcoin-core-dev
3172019-08-28T18:22:25 <MarcoFalke> There is bitcoin-core/qa-assets
3182019-08-28T18:22:27 <MarcoFalke> just saying
3192019-08-28T18:23:14 <MarcoFalke> no strong opinion if it is worth the tradeoffs for 1MB of test data
3202019-08-28T18:24:29 <emilengler> Is there a way to check which chain is currently in use?
3212019-08-28T18:28:36 <MarcoFalke> help getblockchaininfo
3222019-08-28T18:29:24 *** kneedrag has quit IRC
3232019-08-28T18:33:45 <emilengler> MarcoFalke: I mean a code function which returns the chain name but the rpccall works as well
3242019-08-28T18:38:14 <sipa> emilengler: Params().NetworkIDString()
3252019-08-28T18:38:57 *** csknk has quit IRC
3262019-08-28T18:42:26 *** Honthe has joined #bitcoin-core-dev
3272019-08-28T18:43:36 <MarcoFalke> Since the source code is open, you can simply look into the source of getblockchaininfo: https://github.com/bitcoin/bitcoin/blob/a7be1cc92be4946c4f042bccd3a1b007657f3241/src/rpc/blockchain.cpp#L1244
3282019-08-28T18:45:17 *** kristapsk___ has quit IRC
3292019-08-28T18:48:18 <gleb> sipa: We can include this compressed with only 60 bytes. https://0bin.net/paste/bB3Oc9PC6eoKGGRW#v9ofvdm5eiuzAgc4nrU9aueVlKnUpEob7fcKUqoudOX
3302019-08-28T18:49:06 <gleb> And also bytes to document that tests adhere to this map :)
3312019-08-28T18:49:19 *** ThaHandyRoger is now known as TheHoliestRoger
3322019-08-28T18:53:05 <gleb> This would be enough to show that /16 might now be single-bucket and multi-bucket.
3332019-08-28T18:53:54 <gleb> If extra tests are needed, we can expand this, but generally are there any objections to including completely fake mini-asmap for test purposes?
3342019-08-28T18:54:11 *** StopAndDecrypt_ has joined #bitcoin-core-dev
3352019-08-28T18:55:56 *** StopAndDecrypt has quit IRC
3362019-08-28T19:01:05 *** jarthur_ has joined #bitcoin-core-dev
3372019-08-28T19:04:34 *** jarthur has quit IRC
3382019-08-28T19:09:42 *** jarthur_ is now known as jarthur
3392019-08-28T19:11:15 *** michaelfolkson has quit IRC
3402019-08-28T19:17:02 <MarcoFalke> What would you want to test with the full map anyway?
3412019-08-28T19:18:24 <gleb> I don't know, and that's why I'm asking others.
3422019-08-28T19:25:58 <MarcoFalke> In fuzzing, failing test cases are often reduced to the smallest failing test case. I guess you can do the same in unit tests for a map that passes the test case :)
3432019-08-28T19:34:18 *** kristapsk has joined #bitcoin-core-dev
3442019-08-28T19:44:47 *** jarthur has quit IRC
3452019-08-28T19:45:15 *** jarthur has joined #bitcoin-core-dev
3462019-08-28T19:48:41 *** thenry28 has joined #bitcoin-core-dev
3472019-08-28T19:56:09 *** ykns has joined #bitcoin-core-dev
3482019-08-28T19:58:16 *** bitcoin-git has joined #bitcoin-core-dev
3492019-08-28T19:58:16 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16745: wallet: Translate all initErrors in CreateWalletFromFile (master...1908-walletTranslate) https://github.com/bitcoin/bitcoin/pull/16745
3502019-08-28T19:58:17 *** bitcoin-git has left #bitcoin-core-dev
3512019-08-28T20:02:07 *** ykns has quit IRC
3522019-08-28T20:04:12 *** bitcoin-git has joined #bitcoin-core-dev
3532019-08-28T20:04:12 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cc40b55da70b...93305e6d46b4
3542019-08-28T20:04:13 <bitcoin-git> bitcoin/master 593ba69 Hennadii Stepanov: Add warning messages to the debug window
3552019-08-28T20:04:14 <bitcoin-git> bitcoin/master 93305e6 MarcoFalke: Merge #14879: qt: Add warning messages to the debug window
3562019-08-28T20:04:15 *** bitcoin-git has left #bitcoin-core-dev
3572019-08-28T20:04:26 *** EagleTM has joined #bitcoin-core-dev
3582019-08-28T20:04:34 *** bitcoin-git has joined #bitcoin-core-dev
3592019-08-28T20:04:34 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14879: qt: Add warning messages to the debug window (master...20181205-debugwindow-warnings) https://github.com/bitcoin/bitcoin/pull/14879
3602019-08-28T20:04:38 *** bitcoin-git has left #bitcoin-core-dev
3612019-08-28T20:07:03 *** ykns has joined #bitcoin-core-dev
3622019-08-28T20:07:12 *** bitcoin-git has joined #bitcoin-core-dev
3632019-08-28T20:07:13 <bitcoin-git> [bitcoin] sipsorcery opened pull request #16746: msbuild: Ignore linker warning (master...msvc_ignore_4221) https://github.com/bitcoin/bitcoin/pull/16746
3642019-08-28T20:07:26 *** bitcoin-git has left #bitcoin-core-dev
3652019-08-28T20:08:08 *** rafalcpp_ has joined #bitcoin-core-dev
3662019-08-28T20:08:50 *** rafalcpp has quit IRC
3672019-08-28T20:17:28 *** Guyver2 has joined #bitcoin-core-dev
3682019-08-28T20:17:51 *** profmac has quit IRC
3692019-08-28T20:27:25 *** bitcoin-git has joined #bitcoin-core-dev
3702019-08-28T20:27:25 <bitcoin-git> [bitcoin] sipsorcery opened pull request #16747: msbuild: Add missing classes to the bench_bitcoin project (master...add_missing_bench) https://github.com/bitcoin/bitcoin/pull/16747
3712019-08-28T20:27:27 *** bitcoin-git has left #bitcoin-core-dev
3722019-08-28T20:27:30 *** ddustin has joined #bitcoin-core-dev
3732019-08-28T20:38:24 *** davex__ has quit IRC
3742019-08-28T20:40:21 *** davex__ has joined #bitcoin-core-dev
3752019-08-28T20:54:37 *** Giszmo1 has quit IRC
3762019-08-28T20:56:42 *** Giszmo has joined #bitcoin-core-dev
3772019-08-28T21:00:01 *** Maqs1 has quit IRC
3782019-08-28T21:05:39 *** pinheadmz has quit IRC
3792019-08-28T21:09:12 *** Kvaciral has quit IRC
3802019-08-28T21:14:34 *** jarthur has quit IRC
3812019-08-28T21:17:47 *** solirc has joined #bitcoin-core-dev
3822019-08-28T21:32:39 *** Guyver2 has quit IRC
3832019-08-28T21:33:00 *** bitcoin-git has joined #bitcoin-core-dev
3842019-08-28T21:33:01 <bitcoin-git> [bitcoin] dongcarl opened pull request #16748: [WIP] Add support for addrv2 (BIP155) (master...2019-07-addrv2v4) https://github.com/bitcoin/bitcoin/pull/16748
3852019-08-28T21:33:13 *** bitcoin-git has left #bitcoin-core-dev
3862019-08-28T22:09:11 *** jarthur has joined #bitcoin-core-dev
3872019-08-28T22:11:11 *** davex_ has joined #bitcoin-core-dev
3882019-08-28T22:17:10 *** ddustin has quit IRC
3892019-08-28T22:18:37 *** ddustin has joined #bitcoin-core-dev
3902019-08-28T22:28:17 *** ccdle12 has quit IRC
3912019-08-28T22:32:28 *** Chris_Stewart_5 has quit IRC
3922019-08-28T22:42:19 *** jarthur has quit IRC
3932019-08-28T22:46:59 *** AaronvanW has joined #bitcoin-core-dev
3942019-08-28T23:00:32 <promag> anyone getting "./google/protobuf/stubs/common.h:38:10: fatal error: 'assert.h' file not found" while make in depends?
3952019-08-28T23:00:40 *** captjakk_ has quit IRC
3962019-08-28T23:04:17 *** ddustin has quit IRC
3972019-08-28T23:08:28 *** Highway61 has quit IRC
3982019-08-28T23:08:43 *** ddustin has joined #bitcoin-core-dev
3992019-08-28T23:09:36 *** ddustin has joined #bitcoin-core-dev
4002019-08-28T23:10:23 *** ddustin has joined #bitcoin-core-dev
4012019-08-28T23:11:27 *** ddustin has joined #bitcoin-core-dev
4022019-08-28T23:12:17 *** ddustin has joined #bitcoin-core-dev
4032019-08-28T23:15:18 *** hebasto has quit IRC
4042019-08-28T23:15:44 *** liberiga has joined #bitcoin-core-dev
4052019-08-28T23:15:52 *** Zenton has quit IRC
4062019-08-28T23:39:06 <fanquake> promag: Are you building for macOS and missing the SDK?
4072019-08-28T23:39:55 <promag> yeah that was the problem
4082019-08-28T23:40:33 <fanquake> ð
4092019-08-28T23:44:39 *** murray has joined #bitcoin-core-dev
4102019-08-28T23:45:02 *** murray is now known as Guest75265
4112019-08-28T23:45:47 <promag> fanquake: have you tried to bump qt@depends?
4122019-08-28T23:46:39 <fanquake> promag: No. Will probably take a look at 5.12 in depends post v0.19.0
4132019-08-28T23:47:40 <fanquake> There is a PR open with a 5.9.x bump that might go in for 0.19.0. However last time I looked it didn't have any bug fixes that'd benefit us.