1 2019-08-28T00:00:01  *** drybjed1 has quit IRC
  2 2019-08-28T00:10:25  <warren> meshcollider: meaning "git tag -s" type signatures are safe despite sha1 not being safe?
  3 2019-08-28T00:10:50  <warren> when the news came out I remembered reading somewhere that only git signed commits are safe
  4 2019-08-28T00:17:00  *** Steini- has joined #bitcoin-core-dev
  5 2019-08-28T00:22:04  *** Dean_Guss has joined #bitcoin-core-dev
  6 2019-08-28T00:37:36  *** elichai2 has quit IRC
  7 2019-08-28T00:40:47  *** Dean_Guss has quit IRC
  8 2019-08-28T00:53:34  *** jungly has quit IRC
  9 2019-08-28T00:53:59  *** jungly has joined #bitcoin-core-dev
 10 2019-08-28T00:58:15  *** lightlike has quit IRC
 11 2019-08-28T01:05:08  *** Aaronvan_ has quit IRC
 12 2019-08-28T01:13:37  *** brianhoffman_ has joined #bitcoin-core-dev
 13 2019-08-28T01:13:50  *** brianhoffman has quit IRC
 14 2019-08-28T01:13:50  *** brianhoffman_ is now known as brianhoffman
 15 2019-08-28T01:16:55  <meshcollider> Oh actually even an annotated tag would just reference the commit by sha1 hash I think, so it would still rely on second preimage resistance
 16 2019-08-28T01:17:19  *** profmac has quit IRC
 17 2019-08-28T01:17:47  <meshcollider> Why don't we include the tree-sha512 in the tag just like in the merge commits?
 18 2019-08-28T01:17:56  <sipa> can we?
 19 2019-08-28T01:18:08  <sipa> oh, tags have associated text
 20 2019-08-28T01:18:49  <meshcollider> Yeah they can do, and wumpus usually adds text like "Bitcoin Core 0.18.1 release candidate 1"
 21 2019-08-28T01:21:05  *** neyaoz has left #bitcoin-core-dev
 22 2019-08-28T01:21:37  <meshcollider> wumpus: do you usually just tag with git tag -m or is there a script you use
 23 2019-08-28T01:28:09  *** marcinja_ has joined #bitcoin-core-dev
 24 2019-08-28T01:34:48  *** ddustin has joined #bitcoin-core-dev
 25 2019-08-28T01:35:03  *** marcinja has quit IRC
 26 2019-08-28T01:35:10  *** marcinja has joined #bitcoin-core-dev
 27 2019-08-28T01:35:42  *** marcinja_ has quit IRC
 28 2019-08-28T01:38:31  *** harding has quit IRC
 29 2019-08-28T01:38:39  *** marcinja_ has joined #bitcoin-core-dev
 30 2019-08-28T01:40:46  *** AaronvanW has joined #bitcoin-core-dev
 31 2019-08-28T01:45:03  *** AaronvanW has quit IRC
 32 2019-08-28T01:46:13  *** Dean_Guss has joined #bitcoin-core-dev
 33 2019-08-28T01:57:44  *** _Sam-- is now known as kneedrag
 34 2019-08-28T02:00:10  *** harding has joined #bitcoin-core-dev
 35 2019-08-28T02:00:46  *** awesome-doge has joined #bitcoin-core-dev
 36 2019-08-28T02:03:34  *** awesome-doge has joined #bitcoin-core-dev
 37 2019-08-28T02:07:01  *** Dean_Guss has quit IRC
 38 2019-08-28T02:08:22  *** emilengler has quit IRC
 39 2019-08-28T02:11:54  *** emilengler has joined #bitcoin-core-dev
 40 2019-08-28T02:19:41  *** AaronvanW has joined #bitcoin-core-dev
 41 2019-08-28T02:27:58  *** neyaoz has joined #bitcoin-core-dev
 42 2019-08-28T02:28:42  *** awesome-doge has quit IRC
 43 2019-08-28T02:28:58  *** hhhhhhhhhhh has joined #bitcoin-core-dev
 44 2019-08-28T02:29:25  *** neyaoz has left #bitcoin-core-dev
 45 2019-08-28T02:32:15  *** Dean_Guss has joined #bitcoin-core-dev
 46 2019-08-28T02:32:42  *** neyaoz has joined #bitcoin-core-dev
 47 2019-08-28T02:35:28  *** captjakk has joined #bitcoin-core-dev
 48 2019-08-28T02:38:52  *** ddustin_ has joined #bitcoin-core-dev
 49 2019-08-28T02:39:55  *** neyaoz has left #bitcoin-core-dev
 50 2019-08-28T02:40:03  *** ddustin has quit IRC
 51 2019-08-28T02:43:30  *** neyaoz has joined #bitcoin-core-dev
 52 2019-08-28T02:43:47  *** harding has quit IRC
 53 2019-08-28T02:45:49  *** harding has joined #bitcoin-core-dev
 54 2019-08-28T02:53:48  *** AaronvanW has quit IRC
 55 2019-08-28T03:00:01  *** Steini- has quit IRC
 56 2019-08-28T03:19:54  *** Highway62 has joined #bitcoin-core-dev
 57 2019-08-28T03:21:43  *** Highway61 has quit IRC
 58 2019-08-28T03:21:43  *** Highway62 is now known as Highway61
 59 2019-08-28T03:22:11  *** AaronvanW has joined #bitcoin-core-dev
 60 2019-08-28T03:26:20  *** jarthur has joined #bitcoin-core-dev
 61 2019-08-28T03:28:08  *** Dean_Guss has quit IRC
 62 2019-08-28T03:29:13  *** AaronvanW has quit IRC
 63 2019-08-28T03:31:02  *** jarthur has quit IRC
 64 2019-08-28T03:40:34  *** Highway61 has quit IRC
 65 2019-08-28T03:41:58  *** hebasto has quit IRC
 66 2019-08-28T03:47:02  *** pinheadmz has joined #bitcoin-core-dev
 67 2019-08-28T03:47:56  *** nerdboy1 has joined #bitcoin-core-dev
 68 2019-08-28T04:06:11  *** captjakk has quit IRC
 69 2019-08-28T04:10:40  *** lalitmee has joined #bitcoin-core-dev
 70 2019-08-28T04:10:43  *** hhhhhhhhhhh has quit IRC
 71 2019-08-28T04:16:49  *** ddustin has joined #bitcoin-core-dev
 72 2019-08-28T04:20:07  *** ddustin_ has quit IRC
 73 2019-08-28T04:26:54  *** profmac has joined #bitcoin-core-dev
 74 2019-08-28T04:29:01  *** hhhhhhhhhhh has joined #bitcoin-core-dev
 75 2019-08-28T04:29:56  *** pinheadmz has quit IRC
 76 2019-08-28T04:31:52  *** Victor_sueca has joined #bitcoin-core-dev
 77 2019-08-28T04:32:43  *** pinheadmz has joined #bitcoin-core-dev
 78 2019-08-28T04:34:28  *** Victorsueca has quit IRC
 79 2019-08-28T04:40:19  *** jcorgan_ has quit IRC
 80 2019-08-28T04:40:27  *** jcorgan has joined #bitcoin-core-dev
 81 2019-08-28T04:43:27  *** AaronvanW has joined #bitcoin-core-dev
 82 2019-08-28T04:47:03  *** profmac has quit IRC
 83 2019-08-28T04:47:48  *** awesome-doge[m] has joined #bitcoin-core-dev
 84 2019-08-28T04:48:08  *** AaronvanW has quit IRC
 85 2019-08-28T05:19:27  *** AaronvanW has joined #bitcoin-core-dev
 86 2019-08-28T05:23:49  *** AaronvanW has quit IRC
 87 2019-08-28T05:58:05  *** AaronvanW has joined #bitcoin-core-dev
 88 2019-08-28T05:59:48  *** Highway61 has joined #bitcoin-core-dev
 89 2019-08-28T06:00:02  *** nerdboy1 has quit IRC
 90 2019-08-28T06:03:16  *** AaronvanW has quit IRC
 91 2019-08-28T06:17:52  *** MononcQc1 has joined #bitcoin-core-dev
 92 2019-08-28T06:23:50  *** Giszmo has quit IRC
 93 2019-08-28T06:23:56  *** Giszmo1 has joined #bitcoin-core-dev
 94 2019-08-28T06:24:07  *** profmac has joined #bitcoin-core-dev
 95 2019-08-28T06:34:24  *** AaronvanW has joined #bitcoin-core-dev
 96 2019-08-28T06:39:00  *** AaronvanW has quit IRC
 97 2019-08-28T07:03:48  *** Highway61 has quit IRC
 98 2019-08-28T07:06:05  *** pinheadmz has quit IRC
 99 2019-08-28T07:11:27  *** AaronvanW has joined #bitcoin-core-dev
100 2019-08-28T07:15:49  *** AaronvanW has quit IRC
101 2019-08-28T07:16:30  *** EagleTM has joined #bitcoin-core-dev
102 2019-08-28T07:18:45  *** rafalcpp_ has joined #bitcoin-core-dev
103 2019-08-28T07:18:47  *** rafalcpp has quit IRC
104 2019-08-28T07:24:43  *** rockhouse has quit IRC
105 2019-08-28T07:24:44  *** victorSN has quit IRC
106 2019-08-28T07:25:28  *** victorSN has joined #bitcoin-core-dev
107 2019-08-28T07:25:40  *** ddustin has quit IRC
108 2019-08-28T07:26:00  *** ddustin has joined #bitcoin-core-dev
109 2019-08-28T07:26:53  *** ddustin has joined #bitcoin-core-dev
110 2019-08-28T07:27:00  *** jarthur has joined #bitcoin-core-dev
111 2019-08-28T07:27:15  *** ddustin has quit IRC
112 2019-08-28T07:27:36  *** ddustin has joined #bitcoin-core-dev
113 2019-08-28T07:28:03  *** ddustin has quit IRC
114 2019-08-28T07:28:22  *** ddustin has joined #bitcoin-core-dev
115 2019-08-28T07:28:38  *** rockhouse has joined #bitcoin-core-dev
116 2019-08-28T07:28:49  *** EagleTM has quit IRC
117 2019-08-28T07:28:50  *** ddustin has quit IRC
118 2019-08-28T07:29:07  *** ddustin has joined #bitcoin-core-dev
119 2019-08-28T07:31:52  *** jarthur has quit IRC
120 2019-08-28T07:38:16  *** kljasdfvv has joined #bitcoin-core-dev
121 2019-08-28T07:48:42  *** AaronvanW has joined #bitcoin-core-dev
122 2019-08-28T07:52:07  *** lalitmee has quit IRC
123 2019-08-28T07:52:58  *** AaronvanW has quit IRC
124 2019-08-28T08:04:00  *** ddustin has joined #bitcoin-core-dev
125 2019-08-28T08:09:12  *** ddustin has quit IRC
126 2019-08-28T08:17:00  *** rafalcpp has joined #bitcoin-core-dev
127 2019-08-28T08:17:23  *** rafalcpp_ has quit IRC
128 2019-08-28T08:22:50  *** AaronvanW has joined #bitcoin-core-dev
129 2019-08-28T08:27:23  *** AaronvanW has quit IRC
130 2019-08-28T08:28:32  *** AaronvanW has joined #bitcoin-core-dev
131 2019-08-28T08:31:23  *** hhhhhhhhhhh has quit IRC
132 2019-08-28T08:31:44  *** hhhhhhhhhhh has joined #bitcoin-core-dev
133 2019-08-28T08:42:15  *** lalitmee has joined #bitcoin-core-dev
134 2019-08-28T09:00:01  *** MononcQc1 has quit IRC
135 2019-08-28T09:17:26  *** MarconM has joined #bitcoin-core-dev
136 2019-08-28T09:34:17  *** Highway61 has joined #bitcoin-core-dev
137 2019-08-28T09:58:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
138 2019-08-28T10:12:48  *** Highway61 has quit IRC
139 2019-08-28T10:21:42  *** provoostenator has quit IRC
140 2019-08-28T10:24:13  *** provoostenator has joined #bitcoin-core-dev
141 2019-08-28T10:29:26  *** lalitmee has quit IRC
142 2019-08-28T10:30:11  *** lalitmee has joined #bitcoin-core-dev
143 2019-08-28T10:41:58  *** lalitmee has quit IRC
144 2019-08-28T10:42:19  *** jarthur has joined #bitcoin-core-dev
145 2019-08-28T10:47:31  *** jarthur has quit IRC
146 2019-08-28T10:50:08  *** lalitmee has joined #bitcoin-core-dev
147 2019-08-28T10:50:36  *** lalitmee has quit IRC
148 2019-08-28T10:51:53  *** lalitmee has joined #bitcoin-core-dev
149 2019-08-28T11:06:11  *** ddustin has joined #bitcoin-core-dev
150 2019-08-28T11:10:52  *** ddustin has quit IRC
151 2019-08-28T11:20:06  <wumpus> meshcollider: I simply use git tag -s, but yes I think that's a good idea
152 2019-08-28T11:22:06  <wumpus> could have a script that automatically makes and signs the tag
153 2019-08-28T11:22:38  *** tryphe_ has joined #bitcoin-core-dev
154 2019-08-28T11:22:47  <wumpus> and adds in the treehash
155 2019-08-28T11:24:56  *** tryphe has quit IRC
156 2019-08-28T11:29:49  *** Highway61 has joined #bitcoin-core-dev
157 2019-08-28T11:45:27  *** EagleTM has joined #bitcoin-core-dev
158 2019-08-28T11:52:40  *** Chris_Stewart_5 has quit IRC
159 2019-08-28T11:55:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
160 2019-08-28T12:00:01  *** MarconM has quit IRC
161 2019-08-28T12:05:52  *** sdaftuar has quit IRC
162 2019-08-28T12:06:32  *** sdaftuar has joined #bitcoin-core-dev
163 2019-08-28T12:11:14  *** hhhhhhhhhhh has quit IRC
164 2019-08-28T12:17:18  *** quaid1 has joined #bitcoin-core-dev
165 2019-08-28T12:24:45  *** AaronvanW has quit IRC
166 2019-08-28T12:28:21  *** hhhhhhhhhhh has joined #bitcoin-core-dev
167 2019-08-28T12:28:48  *** lightlike has joined #bitcoin-core-dev
168 2019-08-28T12:35:37  *** hhhhhhhhhhh has quit IRC
169 2019-08-28T12:35:43  *** lalitmee has quit IRC
170 2019-08-28T12:36:03  *** hhhhhhhhhhh has joined #bitcoin-core-dev
171 2019-08-28T12:57:56  *** EagleTM has quit IRC
172 2019-08-28T12:59:49  *** liberiga has joined #bitcoin-core-dev
173 2019-08-28T13:07:06  *** ddustin has joined #bitcoin-core-dev
174 2019-08-28T13:11:49  *** ddustin has quit IRC
175 2019-08-28T13:15:00  <meshcollider> It'd be pretty simple to make compared to the GitHub merge script, if you'd be happy to use it
176 2019-08-28T13:18:39  *** captjakk has joined #bitcoin-core-dev
177 2019-08-28T13:25:54  *** tsujp has quit IRC
178 2019-08-28T13:26:12  *** jonatack has quit IRC
179 2019-08-28T13:28:01  *** Highway62 has joined #bitcoin-core-dev
180 2019-08-28T13:28:30  *** Highway61 has quit IRC
181 2019-08-28T13:28:44  *** Highway62 is now known as Highway61
182 2019-08-28T13:28:48  *** tsujp has joined #bitcoin-core-dev
183 2019-08-28T13:31:47  *** hhhhhhhhhhh has quit IRC
184 2019-08-28T13:34:21  *** hhhhhhhhhhh has joined #bitcoin-core-dev
185 2019-08-28T13:40:52  *** hhhhhhhhhhh has quit IRC
186 2019-08-28T13:45:29  *** ddustin has joined #bitcoin-core-dev
187 2019-08-28T13:55:41  *** jonatack has joined #bitcoin-core-dev
188 2019-08-28T13:56:15  *** captjakk has quit IRC
189 2019-08-28T13:57:20  *** tsujp has quit IRC
190 2019-08-28T13:57:41  <promag> jamesob: #16718 also improves -reindex-chainstate right?
191 2019-08-28T13:57:43  <gribble> https://github.com/bitcoin/bitcoin/issues/16718 | Improve speed, memory efficiency with alternate hashmap by jamesob · Pull Request #16718 · bitcoin/bitcoin · GitHub
192 2019-08-28T14:03:37  *** tsujp has joined #bitcoin-core-dev
193 2019-08-28T14:04:25  *** elichai2 has joined #bitcoin-core-dev
194 2019-08-28T14:12:41  <sipa> it should
195 2019-08-28T14:26:33  <promag> right, so maybe show numbers of that instead of ibd
196 2019-08-28T14:34:32  *** sdaftuar has quit IRC
197 2019-08-28T14:35:29  *** sdaftuar has joined #bitcoin-core-dev
198 2019-08-28T14:42:20  *** jarthur has joined #bitcoin-core-dev
199 2019-08-28T14:51:15  *** awesome-doge[m] has left #bitcoin-core-dev
200 2019-08-28T14:55:01  *** rh0nj has quit IRC
201 2019-08-28T14:56:07  *** rh0nj has joined #bitcoin-core-dev
202 2019-08-28T14:56:38  *** jnewbery has quit IRC
203 2019-08-28T14:56:51  *** sdaftuar has quit IRC
204 2019-08-28T14:57:00  *** jnewbery has joined #bitcoin-core-dev
205 2019-08-28T14:57:20  *** sdaftuar has joined #bitcoin-core-dev
206 2019-08-28T14:58:33  <instagibbs> healing power of "and".
207 2019-08-28T14:58:49  <instagibbs> IDB under ideal circumstances is more the metric we care about, just harder to make it ideal
208 2019-08-28T14:58:53  *** tryphe_ is now known as tryphe
209 2019-08-28T15:00:01  *** quaid1 has quit IRC
210 2019-08-28T15:03:11  *** pinheadmz has joined #bitcoin-core-dev
211 2019-08-28T15:09:28  *** Highway61 has quit IRC
212 2019-08-28T15:10:25  *** hebasto has joined #bitcoin-core-dev
213 2019-08-28T15:10:54  *** Highway61 has joined #bitcoin-core-dev
214 2019-08-28T15:11:20  *** sdaftuar has quit IRC
215 2019-08-28T15:11:56  *** sdaftuar has joined #bitcoin-core-dev
216 2019-08-28T15:12:11  *** awesome-doge has joined #bitcoin-core-dev
217 2019-08-28T15:13:24  *** ccdle12 has joined #bitcoin-core-dev
218 2019-08-28T15:17:04  *** tsujp has quit IRC
219 2019-08-28T15:17:18  *** Trixar_za has joined #bitcoin-core-dev
220 2019-08-28T15:23:51  *** sdaftuar has quit IRC
221 2019-08-28T15:25:21  *** sdaftuar has joined #bitcoin-core-dev
222 2019-08-28T15:27:57  *** ddustin has quit IRC
223 2019-08-28T15:29:03  *** sdaftuar has quit IRC
224 2019-08-28T15:29:03  *** jnewbery has quit IRC
225 2019-08-28T15:29:34  *** sdaftuar has joined #bitcoin-core-dev
226 2019-08-28T15:29:55  *** jnewbery has joined #bitcoin-core-dev
227 2019-08-28T15:33:16  *** jarthur has quit IRC
228 2019-08-28T15:34:16  *** sdaftuar has quit IRC
229 2019-08-28T15:34:28  *** jnewbery has quit IRC
230 2019-08-28T15:34:54  *** jnewbery has joined #bitcoin-core-dev
231 2019-08-28T15:35:00  *** sdaftuar has joined #bitcoin-core-dev
232 2019-08-28T15:37:05  *** chainhead has quit IRC
233 2019-08-28T15:39:20  *** chainhead has joined #bitcoin-core-dev
234 2019-08-28T15:40:28  *** sdaftuar has quit IRC
235 2019-08-28T15:40:35  *** jnewbery has quit IRC
236 2019-08-28T15:40:48  *** jnewbery has joined #bitcoin-core-dev
237 2019-08-28T15:40:57  *** sdaftuar has joined #bitcoin-core-dev
238 2019-08-28T15:54:13  *** jnewbery has quit IRC
239 2019-08-28T15:54:20  *** sdaftuar has quit IRC
240 2019-08-28T16:11:35  *** jnewbery has joined #bitcoin-core-dev
241 2019-08-28T16:21:57  *** sdaftuar has joined #bitcoin-core-dev
242 2019-08-28T16:38:56  *** csknk has joined #bitcoin-core-dev
243 2019-08-28T16:39:16  *** bitcoin-git has joined #bitcoin-core-dev
244 2019-08-28T16:39:17  <bitcoin-git> [bitcoin] theStack opened pull request #16742: test: add executable flag for wallet_watchonly.py (master...add_execflag_for_wallet_watchonly_py) https://github.com/bitcoin/bitcoin/pull/16742
245 2019-08-28T16:39:18  *** bitcoin-git has left #bitcoin-core-dev
246 2019-08-28T16:41:21  *** TheHoliestRoger is now known as ThaHandyRoger
247 2019-08-28T16:49:41  *** Karyon has quit IRC
248 2019-08-28T16:51:27  *** Karyon has joined #bitcoin-core-dev
249 2019-08-28T16:58:20  *** jnewbery_ has joined #bitcoin-core-dev
250 2019-08-28T16:59:41  *** michaelfolkson has joined #bitcoin-core-dev
251 2019-08-28T17:02:15  *** jungly has quit IRC
252 2019-08-28T17:08:08  *** bitcoin-git has joined #bitcoin-core-dev
253 2019-08-28T17:08:08  <bitcoin-git> [bitcoin] jamesob opened pull request #16743: refactor: move LoadChainTip/RelayBlocks under CChainState (master...2019-08-au-chainstate-moves) https://github.com/bitcoin/bitcoin/pull/16743
254 2019-08-28T17:08:09  *** bitcoin-git has left #bitcoin-core-dev
255 2019-08-28T17:14:36  *** rafalcpp_ has joined #bitcoin-core-dev
256 2019-08-28T17:14:51  *** rafalcpp has quit IRC
257 2019-08-28T17:19:16  *** liberiga has quit IRC
258 2019-08-28T17:19:50  *** Chris_Stewart_5 has quit IRC
259 2019-08-28T17:20:27  *** pinheadmz_ has joined #bitcoin-core-dev
260 2019-08-28T17:21:18  *** pinheadmz has quit IRC
261 2019-08-28T17:21:18  *** pinheadmz_ is now known as pinheadmz
262 2019-08-28T17:25:44  *** bitcoin-git has joined #bitcoin-core-dev
263 2019-08-28T17:25:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a7be1cc92be4...2d38950e5dbd
264 2019-08-28T17:25:45  <bitcoin-git> bitcoin/master 71e08ab Sebastian Falbesoner: test: add executable flag for wallet_watchonly.py
265 2019-08-28T17:25:45  <bitcoin-git> bitcoin/master 2d38950 MarcoFalke: Merge #16742: test: add executable flag for wallet_watchonly.py
266 2019-08-28T17:25:47  *** bitcoin-git has left #bitcoin-core-dev
267 2019-08-28T17:26:53  *** bitcoin-git has joined #bitcoin-core-dev
268 2019-08-28T17:26:53  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16742: test: add executable flag for wallet_watchonly.py (master...add_execflag_for_wallet_watchonly_py) https://github.com/bitcoin/bitcoin/pull/16742
269 2019-08-28T17:26:56  *** bitcoin-git has left #bitcoin-core-dev
270 2019-08-28T17:28:19  *** jarthur has joined #bitcoin-core-dev
271 2019-08-28T17:28:33  *** sicktastic has joined #bitcoin-core-dev
272 2019-08-28T17:29:05  *** captjakk has joined #bitcoin-core-dev
273 2019-08-28T17:31:59  *** bitcoin-git has joined #bitcoin-core-dev
274 2019-08-28T17:32:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d38950e5dbd...119e97ae2d80
275 2019-08-28T17:32:00  <bitcoin-git> bitcoin/master 403e372 João Barbosa: qa: Relax so that the subscriber is ready before publishing zmq messages
276 2019-08-28T17:32:00  <bitcoin-git> bitcoin/master 119e97a MarcoFalke: Merge #16740: qa: Relax so that the subscriber is ready before publishing ...
277 2019-08-28T17:32:01  *** bitcoin-git has left #bitcoin-core-dev
278 2019-08-28T17:32:54  *** sicktastic has quit IRC
279 2019-08-28T17:32:55  *** bitcoin-git has joined #bitcoin-core-dev
280 2019-08-28T17:32:55  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16740: qa: Relax so that the subscriber is ready before publishing zmq messages (master...2019-08-slowjoiner) https://github.com/bitcoin/bitcoin/pull/16740
281 2019-08-28T17:32:56  *** bitcoin-git has left #bitcoin-core-dev
282 2019-08-28T17:33:24  *** rafalcpp has joined #bitcoin-core-dev
283 2019-08-28T17:33:24  *** rafalcpp_ has quit IRC
284 2019-08-28T17:35:20  *** bitcoin-git has joined #bitcoin-core-dev
285 2019-08-28T17:35:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/119e97ae2d80...cc40b55da70b
286 2019-08-28T17:35:21  <bitcoin-git> bitcoin/master 25dd867 practicalswift: Avoid using mutable default parameter values
287 2019-08-28T17:35:21  <bitcoin-git> bitcoin/master e4f4ea4 practicalswift: lint: Catch use of [] or {} as default parameter values in Python functions
288 2019-08-28T17:35:22  <bitcoin-git> bitcoin/master cc40b55 MarcoFalke: Merge #16726: tests: Avoid common Python default parameter gotcha when mut...
289 2019-08-28T17:35:23  *** bitcoin-git has left #bitcoin-core-dev
290 2019-08-28T17:35:42  *** captjakk_ has joined #bitcoin-core-dev
291 2019-08-28T17:36:23  *** bitcoin-git has joined #bitcoin-core-dev
292 2019-08-28T17:36:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16726: tests: Avoid common Python default parameter gotcha when mutable dict/list:s are used as default parameter values (master...python-mutable-default-parameter-values) https://github.com/bitcoin/bitcoin/pull/16726
293 2019-08-28T17:36:25  *** bitcoin-git has left #bitcoin-core-dev
294 2019-08-28T17:39:13  *** captjakk has quit IRC
295 2019-08-28T17:43:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
296 2019-08-28T17:56:09  *** Chris_Stewart_5 has quit IRC
297 2019-08-28T17:56:43  *** IGHOR has quit IRC
298 2019-08-28T17:59:22  *** Chris_Stewart_5 has joined #bitcoin-core-dev
299 2019-08-28T18:00:02  *** Trixar_za has quit IRC
300 2019-08-28T18:01:02  *** IGHOR has joined #bitcoin-core-dev
301 2019-08-28T18:01:13  <gleb> provoostenator: Do we really want to download asmap.raw needed for testing from somewhere online? Where do you think it belongs, somewhere on github? Maybe in the repo with scripts to build asmap
302 2019-08-28T18:01:37  <provoostenator> We host a bunch of bigger files on bitcoincore.org
303 2019-08-28T18:01:55  <provoostenator> Like the macOS SDK
304 2019-08-28T18:02:49  *** jnewbery_ has quit IRC
305 2019-08-28T18:02:54  <gleb> And then, perhaps if file is not available — omit those tests with a warning or something.
306 2019-08-28T18:02:58  <provoostenator> A torrent could add some redudancy
307 2019-08-28T18:04:01  <gleb> Sounds like an overkill to me. Alternative source might be the repo with scripts to build asmap.raw, if we end up having a dedicated repo.
308 2019-08-28T18:04:04  <provoostenator> Yes, if missing the test can be skipped, we have a standard method for that in the functional test suite.
309 2019-08-28T18:04:33  <provoostenator> Building it manually wouldn't be determinstic, right?
310 2019-08-28T18:05:20  <sipa> gleb: for testing we don't actually need a big asmap, right?
311 2019-08-28T18:05:29  <sipa> we could construct a simplified one of a few kilobytes
312 2019-08-28T18:05:42  <provoostenator> There should be a way for people to verify that  the end result that we ship is generated from something that they can at least in principle download / generate.
313 2019-08-28T18:06:55  <gleb> sipa: Yeah, I had that on mind too.
314 2019-08-28T18:08:57  *** Rodrigues has joined #bitcoin-core-dev
315 2019-08-28T18:09:25  *** Rodrigues has left #bitcoin-core-dev
316 2019-08-28T18:17:36  *** Maqs1 has joined #bitcoin-core-dev
317 2019-08-28T18:22:25  <MarcoFalke> There is bitcoin-core/qa-assets
318 2019-08-28T18:22:27  <MarcoFalke> just saying
319 2019-08-28T18:23:14  <MarcoFalke> no strong opinion if it is worth the tradeoffs for 1MB of test data
320 2019-08-28T18:24:29  <emilengler> Is there a way to check which chain is currently in use?
321 2019-08-28T18:28:36  <MarcoFalke> help getblockchaininfo
322 2019-08-28T18:29:24  *** kneedrag has quit IRC
323 2019-08-28T18:33:45  <emilengler> MarcoFalke: I mean a code function which returns the chain name but the rpccall works as well
324 2019-08-28T18:38:14  <sipa> emilengler: Params().NetworkIDString()
325 2019-08-28T18:38:57  *** csknk has quit IRC
326 2019-08-28T18:42:26  *** Honthe has joined #bitcoin-core-dev
327 2019-08-28T18:43:36  <MarcoFalke> Since the source code is open, you can simply look into the source of getblockchaininfo: https://github.com/bitcoin/bitcoin/blob/a7be1cc92be4946c4f042bccd3a1b007657f3241/src/rpc/blockchain.cpp#L1244
328 2019-08-28T18:45:17  *** kristapsk___ has quit IRC
329 2019-08-28T18:48:18  <gleb> sipa: We can include this compressed with only 60 bytes. https://0bin.net/paste/bB3Oc9PC6eoKGGRW#v9ofvdm5eiuzAgc4nrU9aueVlKnUpEob7fcKUqoudOX
330 2019-08-28T18:49:06  <gleb> And also bytes to document that tests adhere to this map :)
331 2019-08-28T18:49:19  *** ThaHandyRoger is now known as TheHoliestRoger
332 2019-08-28T18:53:05  <gleb> This would be enough to show that /16 might now be single-bucket and multi-bucket.
333 2019-08-28T18:53:54  <gleb> If extra tests are needed, we can expand this, but generally are there any objections to including completely fake mini-asmap for test purposes?
334 2019-08-28T18:54:11  *** StopAndDecrypt_ has joined #bitcoin-core-dev
335 2019-08-28T18:55:56  *** StopAndDecrypt has quit IRC
336 2019-08-28T19:01:05  *** jarthur_ has joined #bitcoin-core-dev
337 2019-08-28T19:04:34  *** jarthur has quit IRC
338 2019-08-28T19:09:42  *** jarthur_ is now known as jarthur
339 2019-08-28T19:11:15  *** michaelfolkson has quit IRC
340 2019-08-28T19:17:02  <MarcoFalke> What would you want to test with the full map anyway?
341 2019-08-28T19:18:24  <gleb> I don't know, and that's why I'm asking others.
342 2019-08-28T19:25:58  <MarcoFalke> In fuzzing, failing test cases are often reduced to the smallest failing test case. I guess you can do the same in unit tests for a map that passes the test case :)
343 2019-08-28T19:34:18  *** kristapsk has joined #bitcoin-core-dev
344 2019-08-28T19:44:47  *** jarthur has quit IRC
345 2019-08-28T19:45:15  *** jarthur has joined #bitcoin-core-dev
346 2019-08-28T19:48:41  *** thenry28 has joined #bitcoin-core-dev
347 2019-08-28T19:56:09  *** ykns has joined #bitcoin-core-dev
348 2019-08-28T19:58:16  *** bitcoin-git has joined #bitcoin-core-dev
349 2019-08-28T19:58:16  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #16745: wallet: Translate all initErrors in CreateWalletFromFile (master...1908-walletTranslate) https://github.com/bitcoin/bitcoin/pull/16745
350 2019-08-28T19:58:17  *** bitcoin-git has left #bitcoin-core-dev
351 2019-08-28T20:02:07  *** ykns has quit IRC
352 2019-08-28T20:04:12  *** bitcoin-git has joined #bitcoin-core-dev
353 2019-08-28T20:04:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cc40b55da70b...93305e6d46b4
354 2019-08-28T20:04:13  <bitcoin-git> bitcoin/master 593ba69 Hennadii Stepanov: Add warning messages to the debug window
355 2019-08-28T20:04:14  <bitcoin-git> bitcoin/master 93305e6 MarcoFalke: Merge #14879: qt: Add warning messages to the debug window
356 2019-08-28T20:04:15  *** bitcoin-git has left #bitcoin-core-dev
357 2019-08-28T20:04:26  *** EagleTM has joined #bitcoin-core-dev
358 2019-08-28T20:04:34  *** bitcoin-git has joined #bitcoin-core-dev
359 2019-08-28T20:04:34  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14879: qt: Add warning messages to the debug window (master...20181205-debugwindow-warnings) https://github.com/bitcoin/bitcoin/pull/14879
360 2019-08-28T20:04:38  *** bitcoin-git has left #bitcoin-core-dev
361 2019-08-28T20:07:03  *** ykns has joined #bitcoin-core-dev
362 2019-08-28T20:07:12  *** bitcoin-git has joined #bitcoin-core-dev
363 2019-08-28T20:07:13  <bitcoin-git> [bitcoin] sipsorcery opened pull request #16746: msbuild: Ignore linker warning (master...msvc_ignore_4221) https://github.com/bitcoin/bitcoin/pull/16746
364 2019-08-28T20:07:26  *** bitcoin-git has left #bitcoin-core-dev
365 2019-08-28T20:08:08  *** rafalcpp_ has joined #bitcoin-core-dev
366 2019-08-28T20:08:50  *** rafalcpp has quit IRC
367 2019-08-28T20:17:28  *** Guyver2 has joined #bitcoin-core-dev
368 2019-08-28T20:17:51  *** profmac has quit IRC
369 2019-08-28T20:27:25  *** bitcoin-git has joined #bitcoin-core-dev
370 2019-08-28T20:27:25  <bitcoin-git> [bitcoin] sipsorcery opened pull request #16747: msbuild: Add missing classes to the bench_bitcoin project (master...add_missing_bench) https://github.com/bitcoin/bitcoin/pull/16747
371 2019-08-28T20:27:27  *** bitcoin-git has left #bitcoin-core-dev
372 2019-08-28T20:27:30  *** ddustin has joined #bitcoin-core-dev
373 2019-08-28T20:38:24  *** davex__ has quit IRC
374 2019-08-28T20:40:21  *** davex__ has joined #bitcoin-core-dev
375 2019-08-28T20:54:37  *** Giszmo1 has quit IRC
376 2019-08-28T20:56:42  *** Giszmo has joined #bitcoin-core-dev
377 2019-08-28T21:00:01  *** Maqs1 has quit IRC
378 2019-08-28T21:05:39  *** pinheadmz has quit IRC
379 2019-08-28T21:09:12  *** Kvaciral has quit IRC
380 2019-08-28T21:14:34  *** jarthur has quit IRC
381 2019-08-28T21:17:47  *** solirc has joined #bitcoin-core-dev
382 2019-08-28T21:32:39  *** Guyver2 has quit IRC
383 2019-08-28T21:33:00  *** bitcoin-git has joined #bitcoin-core-dev
384 2019-08-28T21:33:01  <bitcoin-git> [bitcoin] dongcarl opened pull request #16748: [WIP] Add support for addrv2 (BIP155) (master...2019-07-addrv2v4) https://github.com/bitcoin/bitcoin/pull/16748
385 2019-08-28T21:33:13  *** bitcoin-git has left #bitcoin-core-dev
386 2019-08-28T22:09:11  *** jarthur has joined #bitcoin-core-dev
387 2019-08-28T22:11:11  *** davex_ has joined #bitcoin-core-dev
388 2019-08-28T22:17:10  *** ddustin has quit IRC
389 2019-08-28T22:18:37  *** ddustin has joined #bitcoin-core-dev
390 2019-08-28T22:28:17  *** ccdle12 has quit IRC
391 2019-08-28T22:32:28  *** Chris_Stewart_5 has quit IRC
392 2019-08-28T22:42:19  *** jarthur has quit IRC
393 2019-08-28T22:46:59  *** AaronvanW has joined #bitcoin-core-dev
394 2019-08-28T23:00:32  <promag> anyone getting "./google/protobuf/stubs/common.h:38:10: fatal error: 'assert.h' file not found" while make in depends?
395 2019-08-28T23:00:40  *** captjakk_ has quit IRC
396 2019-08-28T23:04:17  *** ddustin has quit IRC
397 2019-08-28T23:08:28  *** Highway61 has quit IRC
398 2019-08-28T23:08:43  *** ddustin has joined #bitcoin-core-dev
399 2019-08-28T23:09:36  *** ddustin has joined #bitcoin-core-dev
400 2019-08-28T23:10:23  *** ddustin has joined #bitcoin-core-dev
401 2019-08-28T23:11:27  *** ddustin has joined #bitcoin-core-dev
402 2019-08-28T23:12:17  *** ddustin has joined #bitcoin-core-dev
403 2019-08-28T23:15:18  *** hebasto has quit IRC
404 2019-08-28T23:15:44  *** liberiga has joined #bitcoin-core-dev
405 2019-08-28T23:15:52  *** Zenton has quit IRC
406 2019-08-28T23:39:06  <fanquake> promag: Are you building for macOS and missing the SDK?
407 2019-08-28T23:39:55  <promag> yeah that was the problem
408 2019-08-28T23:40:33  <fanquake> 👍
409 2019-08-28T23:44:39  *** murray has joined #bitcoin-core-dev
410 2019-08-28T23:45:02  *** murray is now known as Guest75265
411 2019-08-28T23:45:47  <promag> fanquake: have you tried to bump qt@depends?
412 2019-08-28T23:46:39  <fanquake> promag: No. Will probably take a look at 5.12 in depends post v0.19.0
413 2019-08-28T23:47:40  <fanquake> There is a PR open with a 5.9.x bump that might go in for 0.19.0. However last time I looked it didn't have any bug fixes that'd benefit us.