12019-09-13T00:00:24  *** Xorlev1 has quit IRC
  22019-09-13T00:09:09  *** elichai2 has quit IRC
  32019-09-13T00:09:09  *** jb55 has quit IRC
  42019-09-13T00:09:09  *** sipa has quit IRC
  52019-09-13T00:09:10  *** mryandao has quit IRC
  62019-09-13T00:09:10  *** astro has quit IRC
  72019-09-13T00:09:49  *** jb55 has joined #bitcoin-core-dev
  82019-09-13T00:09:56  *** mryandao has joined #bitcoin-core-dev
  92019-09-13T00:14:31  *** astro has joined #bitcoin-core-dev
 102019-09-13T00:14:32  *** sipa has joined #bitcoin-core-dev
 112019-09-13T00:17:39  *** Stskeeps1 has joined #bitcoin-core-dev
 122019-09-13T00:20:00  *** captjakk has joined #bitcoin-core-dev
 132019-09-13T00:21:47  *** mryandao has quit IRC
 142019-09-13T00:24:07  *** mryandao has joined #bitcoin-core-dev
 152019-09-13T00:34:35  *** DeanGuss has joined #bitcoin-core-dev
 162019-09-13T00:42:23  *** pinheadmz has quit IRC
 172019-09-13T00:46:32  *** captjakk has quit IRC
 182019-09-13T00:47:53  *** pinheadmz has joined #bitcoin-core-dev
 192019-09-13T00:50:37  *** pinheadmz has quit IRC
 202019-09-13T00:51:03  *** pinheadmz has joined #bitcoin-core-dev
 212019-09-13T00:53:36  *** Jackielove4u has quit IRC
 222019-09-13T00:55:20  *** pinheadmz has quit IRC
 232019-09-13T01:08:52  *** captjakk has joined #bitcoin-core-dev
 242019-09-13T01:12:28  *** pinheadmz has joined #bitcoin-core-dev
 252019-09-13T01:17:49  *** ccdle12 has joined #bitcoin-core-dev
 262019-09-13T01:37:43  *** ccdle12 has quit IRC
 272019-09-13T01:45:37  *** captjakk has quit IRC
 282019-09-13T01:49:14  *** xzytrewq has joined #bitcoin-core-dev
 292019-09-13T01:49:57  *** captjakk has joined #bitcoin-core-dev
 302019-09-13T01:54:30  *** captjakk has quit IRC
 312019-09-13T02:13:16  *** DeanGuss has quit IRC
 322019-09-13T02:42:27  *** jtimon has quit IRC
 332019-09-13T03:00:01  *** Stskeeps1 has quit IRC
 342019-09-13T03:01:32  *** captjakk has joined #bitcoin-core-dev
 352019-09-13T03:17:27  *** Fiver has joined #bitcoin-core-dev
 362019-09-13T03:28:31  *** bitcoin-git has joined #bitcoin-core-dev
 372019-09-13T03:28:31  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/884f7cc81b47...a199f7522589
 382019-09-13T03:28:31  <bitcoin-git> bitcoin/master 7063401 clashicly: Elaborate on the need to re-login on Debian-based systems to use tor follo...
 392019-09-13T03:28:32  <bitcoin-git> bitcoin/master a199f75 fanquake: Merge #16857: doc: Elaborate need to re-login on Debian-based after usermo...
 402019-09-13T03:28:33  *** bitcoin-git has left #bitcoin-core-dev
 412019-09-13T03:28:51  *** bitcoin-git has joined #bitcoin-core-dev
 422019-09-13T03:28:51  <bitcoin-git> [bitcoin] fanquake merged pull request #16857: doc: Elaborate need to re-login on Debian-based after usermod for Tor group (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16857
 432019-09-13T03:28:52  *** bitcoin-git has left #bitcoin-core-dev
 442019-09-13T03:41:59  *** captjakk has quit IRC
 452019-09-13T03:43:50  *** bitcoin-git has joined #bitcoin-core-dev
 462019-09-13T03:43:50  <bitcoin-git> [bitcoin] fanquake opened pull request #16861: doc: Remove release note fragment from #16639 (0.17...remove_release_note_fragment) https://github.com/bitcoin/bitcoin/pull/16861
 472019-09-13T03:43:51  *** bitcoin-git has left #bitcoin-core-dev
 482019-09-13T04:02:23  *** justanotheruser has quit IRC
 492019-09-13T04:04:45  *** tsujp has quit IRC
 502019-09-13T04:26:07  *** justanotheruser has joined #bitcoin-core-dev
 512019-09-13T04:31:44  *** Victor_sueca has joined #bitcoin-core-dev
 522019-09-13T04:34:27  *** Victorsueca has quit IRC
 532019-09-13T05:08:50  *** kcalvinalvin has joined #bitcoin-core-dev
 542019-09-13T05:09:59  *** Highway62 has joined #bitcoin-core-dev
 552019-09-13T05:12:00  *** Highway61 has quit IRC
 562019-09-13T05:12:00  *** Highway62 is now known as Highway61
 572019-09-13T05:19:53  *** kcalvinalvin has quit IRC
 582019-09-13T05:36:22  *** ctrlbreak_MAD has joined #bitcoin-core-dev
 592019-09-13T05:36:40  *** cfields has quit IRC
 602019-09-13T05:39:46  *** tsujp has joined #bitcoin-core-dev
 612019-09-13T05:40:02  *** ctrlbreak has quit IRC
 622019-09-13T05:41:29  *** Highway61 has quit IRC
 632019-09-13T05:50:50  *** bitcoin-git has joined #bitcoin-core-dev
 642019-09-13T05:50:50  <bitcoin-git> [bitcoin] fanquake closed pull request #16860: remove unnecessary png file (master...removepng) https://github.com/bitcoin/bitcoin/pull/16860
 652019-09-13T05:50:51  *** bitcoin-git has left #bitcoin-core-dev
 662019-09-13T06:00:02  *** Fiver has quit IRC
 672019-09-13T06:00:34  *** Highway61 has joined #bitcoin-core-dev
 682019-09-13T06:04:51  *** Highway61 has quit IRC
 692019-09-13T06:11:14  *** rafalcpp has joined #bitcoin-core-dev
 702019-09-13T06:11:45  *** rafalcpp_ has quit IRC
 712019-09-13T06:17:27  *** dvratil has joined #bitcoin-core-dev
 722019-09-13T06:23:43  *** yarwn has joined #bitcoin-core-dev
 732019-09-13T06:24:06  *** Highway61 has joined #bitcoin-core-dev
 742019-09-13T06:40:38  *** face has joined #bitcoin-core-dev
 752019-09-13T06:40:51  *** Giszmo has joined #bitcoin-core-dev
 762019-09-13T06:44:41  *** Jackielove4u has joined #bitcoin-core-dev
 772019-09-13T06:58:38  *** mutatrum has joined #bitcoin-core-dev
 782019-09-13T07:08:14  *** promag has quit IRC
 792019-09-13T07:08:48  *** promag has joined #bitcoin-core-dev
 802019-09-13T07:10:51  *** rafalcpp has quit IRC
 812019-09-13T07:11:00  *** rafalcpp has joined #bitcoin-core-dev
 822019-09-13T07:19:15  *** promag has quit IRC
 832019-09-13T07:23:57  *** Victor_sueca is now known as Victorsueca
 842019-09-13T07:26:49  *** rafalcpp_ has joined #bitcoin-core-dev
 852019-09-13T07:27:56  *** rafalcpp has quit IRC
 862019-09-13T07:31:16  *** ccdle12 has joined #bitcoin-core-dev
 872019-09-13T07:39:37  *** kljasdfvv has joined #bitcoin-core-dev
 882019-09-13T08:03:35  *** kcalvinalvin has joined #bitcoin-core-dev
 892019-09-13T08:11:52  *** Giszmo has quit IRC
 902019-09-13T08:15:24  *** Giszmo has joined #bitcoin-core-dev
 912019-09-13T08:18:38  *** ccdle12 has quit IRC
 922019-09-13T08:21:14  *** ccdle12 has joined #bitcoin-core-dev
 932019-09-13T08:31:55  *** Zenton has joined #bitcoin-core-dev
 942019-09-13T08:35:57  *** ccdle12 has quit IRC
 952019-09-13T08:47:48  *** kcalvinalvin has quit IRC
 962019-09-13T08:51:05  *** tsujp has quit IRC
 972019-09-13T08:55:46  *** tsujp has joined #bitcoin-core-dev
 982019-09-13T09:00:02  *** dvratil has quit IRC
 992019-09-13T09:01:32  *** tsujp has quit IRC
1002019-09-13T09:17:29  *** whartung1 has joined #bitcoin-core-dev
1012019-09-13T10:06:36  *** ghost43 has quit IRC
1022019-09-13T10:06:48  *** ccdle12 has joined #bitcoin-core-dev
1032019-09-13T10:06:51  *** ghost43 has joined #bitcoin-core-dev
1042019-09-13T10:10:26  *** jonatack has quit IRC
1052019-09-13T10:15:38  *** rafalcpp has joined #bitcoin-core-dev
1062019-09-13T10:16:03  *** rafalcpp_ has quit IRC
1072019-09-13T10:46:47  *** kcalvinalvin has joined #bitcoin-core-dev
1082019-09-13T10:49:46  *** reallll has joined #bitcoin-core-dev
1092019-09-13T10:53:13  *** belcher has quit IRC
1102019-09-13T10:58:45  *** ccdle12 has quit IRC
1112019-09-13T11:03:33  *** kcalvina_ has joined #bitcoin-core-dev
1122019-09-13T11:03:33  *** kcalvinalvin has quit IRC
1132019-09-13T11:18:34  *** ccdle12 has joined #bitcoin-core-dev
1142019-09-13T11:20:24  *** rafalcpp_ has joined #bitcoin-core-dev
1152019-09-13T11:20:48  *** rafalcpp has quit IRC
1162019-09-13T11:34:42  *** promag has joined #bitcoin-core-dev
1172019-09-13T11:41:35  *** jonatack has joined #bitcoin-core-dev
1182019-09-13T11:49:53  *** jonatack has quit IRC
1192019-09-13T11:51:46  *** jonatack has joined #bitcoin-core-dev
1202019-09-13T11:53:55  <promag> what's blocking #16414 merge?
1212019-09-13T11:53:57  <gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub
1222019-09-13T11:54:53  *** ccdle12 has quit IRC
1232019-09-13T11:55:16  <promag> and #15204
1242019-09-13T11:55:18  <gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
1252019-09-13T12:00:02  *** whartung1 has quit IRC
1262019-09-13T12:05:15  *** kcalvina_ has quit IRC
1272019-09-13T12:09:26  *** kcalvinalvin has joined #bitcoin-core-dev
1282019-09-13T12:17:39  *** tadeo has joined #bitcoin-core-dev
1292019-09-13T12:22:39  *** jtimon has joined #bitcoin-core-dev
1302019-09-13T12:28:35  *** jonatack has quit IRC
1312019-09-13T12:30:59  *** mutatrum has quit IRC
1322019-09-13T12:42:28  <promag> jonasschnelli, fanquake: take a look at #15204
1332019-09-13T12:42:31  <gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
1342019-09-13T12:42:33  <promag> thanks
1352019-09-13T12:56:55  *** promag has quit IRC
1362019-09-13T13:16:13  *** bitcoin-git has joined #bitcoin-core-dev
1372019-09-13T13:16:14  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a199f7522589...102998ea03f6
1382019-09-13T13:16:14  <bitcoin-git> bitcoin/master 376f492 fanquake: build: disable BIP70 support by default
1392019-09-13T13:16:15  <bitcoin-git> bitcoin/master e09913f fanquake: doc: specify protobuf as optional in build docs
1402019-09-13T13:16:15  <bitcoin-git> bitcoin/master 102998e Wladimir J. van der Laan: Merge #15584: build: disable BIP70 support by default
1412019-09-13T13:16:17  *** bitcoin-git has left #bitcoin-core-dev
1422019-09-13T13:16:48  *** bitcoin-git has joined #bitcoin-core-dev
1432019-09-13T13:16:48  <bitcoin-git> [bitcoin] laanwj merged pull request #15584: build: disable BIP70 support by default (master...disable-bip70-by-default) https://github.com/bitcoin/bitcoin/pull/15584
1442019-09-13T13:16:49  *** bitcoin-git has left #bitcoin-core-dev
1452019-09-13T13:33:01  *** bitcoin-git has joined #bitcoin-core-dev
1462019-09-13T13:33:01  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/102998ea03f6...fb4f5beb6ede
1472019-09-13T13:33:02  <bitcoin-git> bitcoin/master f390d85 Steven Roose: Prevent UpdateTip log message from being broken up
1482019-09-13T13:33:02  <bitcoin-git> bitcoin/master fb4f5be Wladimir J. van der Laan: Merge #16854: Prevent UpdateTip log message from being broken up
1492019-09-13T13:33:04  *** bitcoin-git has left #bitcoin-core-dev
1502019-09-13T13:33:21  *** bitcoin-git has joined #bitcoin-core-dev
1512019-09-13T13:33:21  <bitcoin-git> [bitcoin] laanwj merged pull request #16854: Prevent UpdateTip log message from being broken up (master...log-break-updatetip) https://github.com/bitcoin/bitcoin/pull/16854
1522019-09-13T13:33:22  *** bitcoin-git has left #bitcoin-core-dev
1532019-09-13T13:59:26  *** tryphe has quit IRC
1542019-09-13T14:00:24  *** tryphe has joined #bitcoin-core-dev
1552019-09-13T14:20:58  *** Guyver2 has joined #bitcoin-core-dev
1562019-09-13T14:27:13  *** bitcoin-git has joined #bitcoin-core-dev
1572019-09-13T14:27:13  <bitcoin-git> [bitcoin] darosior opened pull request #16863: NIT: Add a missing closing parenthesis in the bitcoin-wallet's help (master...bitcoin_wallet_nit) https://github.com/bitcoin/bitcoin/pull/16863
1582019-09-13T14:27:14  *** bitcoin-git has left #bitcoin-core-dev
1592019-09-13T14:41:53  *** emilengler has joined #bitcoin-core-dev
1602019-09-13T14:42:56  *** e4xit has quit IRC
1612019-09-13T14:47:04  *** elichai2 has joined #bitcoin-core-dev
1622019-09-13T14:55:12  *** mdunnio has joined #bitcoin-core-dev
1632019-09-13T14:55:58  *** mdunnio has quit IRC
1642019-09-13T14:57:36  *** mdunnio has joined #bitcoin-core-dev
1652019-09-13T15:00:01  *** tadeo has quit IRC
1662019-09-13T15:04:35  *** tsujp has joined #bitcoin-core-dev
1672019-09-13T15:07:15  *** willcl_ark has joined #bitcoin-core-dev
1682019-09-13T15:07:16  *** bitcoin-git has joined #bitcoin-core-dev
1692019-09-13T15:07:17  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.17: https://github.com/bitcoin/bitcoin/compare/40b47d539991...e149cbe5c790
1702019-09-13T15:07:17  <bitcoin-git> bitcoin/0.17 fb9bade fanquake: doc: integrate release notes from #16639
1712019-09-13T15:07:18  <bitcoin-git> bitcoin/0.17 e149cbe Wladimir J. van der Laan: Merge #16861: [0.17] doc: Remove release note fragment from #16639
1722019-09-13T15:07:20  *** bitcoin-git has left #bitcoin-core-dev
1732019-09-13T15:07:36  *** bitcoin-git has joined #bitcoin-core-dev
1742019-09-13T15:07:36  <bitcoin-git> [bitcoin] laanwj merged pull request #16861: [0.17] doc: Remove release note fragment from #16639 (0.17...remove_release_note_fragment) https://github.com/bitcoin/bitcoin/pull/16861
1752019-09-13T15:07:37  *** bitcoin-git has left #bitcoin-core-dev
1762019-09-13T15:12:56  *** bitcoin-git has joined #bitcoin-core-dev
1772019-09-13T15:12:56  <bitcoin-git> [bitcoin] instagibbs opened pull request #16864: Add python bech32 impl round-trip test (master...bech32_encode_test) https://github.com/bitcoin/bitcoin/pull/16864
1782019-09-13T15:12:57  *** bitcoin-git has left #bitcoin-core-dev
1792019-09-13T15:14:53  *** hebasto has joined #bitcoin-core-dev
1802019-09-13T15:19:59  *** hebasto has quit IRC
1812019-09-13T15:20:14  *** hebasto has joined #bitcoin-core-dev
1822019-09-13T15:29:18  *** owowo has quit IRC
1832019-09-13T15:30:41  *** sdaftuar has quit IRC
1842019-09-13T15:30:47  *** jnewbery has quit IRC
1852019-09-13T15:31:11  *** sdaftuar has joined #bitcoin-core-dev
1862019-09-13T15:31:30  *** jnewbery has joined #bitcoin-core-dev
1872019-09-13T15:44:02  *** rh0nj has quit IRC
1882019-09-13T15:45:08  *** rh0nj has joined #bitcoin-core-dev
1892019-09-13T15:47:44  *** Leo_Verto1 has joined #bitcoin-core-dev
1902019-09-13T15:48:59  *** mryandao_ has joined #bitcoin-core-dev
1912019-09-13T15:51:20  *** mryandao has quit IRC
1922019-09-13T15:52:51  *** Zenton has quit IRC
1932019-09-13T15:53:51  *** kljasdfvv has quit IRC
1942019-09-13T15:59:39  *** rafalcpp_ has quit IRC
1952019-09-13T16:00:13  *** rafalcpp_ has joined #bitcoin-core-dev
1962019-09-13T16:19:35  *** owowo has joined #bitcoin-core-dev
1972019-09-13T16:19:42  *** justanotheruser has quit IRC
1982019-09-13T16:20:48  *** ccdle12 has joined #bitcoin-core-dev
1992019-09-13T16:21:31  *** mdunnio has quit IRC
2002019-09-13T16:23:28  *** mdunnio has joined #bitcoin-core-dev
2012019-09-13T16:24:48  *** face has quit IRC
2022019-09-13T16:29:38  *** justanotheruser has joined #bitcoin-core-dev
2032019-09-13T16:30:06  *** tryphe has quit IRC
2042019-09-13T16:32:27  *** captjakk has joined #bitcoin-core-dev
2052019-09-13T16:33:51  *** mdunnio has quit IRC
2062019-09-13T16:36:25  *** ccdle12 has quit IRC
2072019-09-13T16:38:18  *** tsujp has joined #bitcoin-core-dev
2082019-09-13T16:42:31  *** tsujp has quit IRC
2092019-09-13T17:04:27  *** mdunnio has joined #bitcoin-core-dev
2102019-09-13T17:07:06  *** bitcoin-git has joined #bitcoin-core-dev
2112019-09-13T17:07:06  <bitcoin-git> [bitcoin] soroosh-sdi opened pull request #16865: test: add some unit tests for merkle.cpp (master...13-09-19-merkle-unit-tests) https://github.com/bitcoin/bitcoin/pull/16865
2122019-09-13T17:07:07  *** bitcoin-git has left #bitcoin-core-dev
2132019-09-13T17:08:49  *** jtimon has quit IRC
2142019-09-13T17:09:15  *** mdunnio has quit IRC
2152019-09-13T17:27:01  *** rafalcpp has joined #bitcoin-core-dev
2162019-09-13T17:27:15  *** rafalcpp_ has quit IRC
2172019-09-13T17:37:51  *** mdunnio has joined #bitcoin-core-dev
2182019-09-13T17:37:52  *** mdunnio has quit IRC
2192019-09-13T17:38:06  *** mdunnio has joined #bitcoin-core-dev
2202019-09-13T17:40:01  *** m1rror8 has quit IRC
2212019-09-13T17:40:30  *** m1rror8 has joined #bitcoin-core-dev
2222019-09-13T17:47:57  *** ccdle12 has joined #bitcoin-core-dev
2232019-09-13T17:55:15  *** ccdle12 has quit IRC
2242019-09-13T17:55:39  *** captjakk has quit IRC
2252019-09-13T17:58:56  *** yarwn has quit IRC
2262019-09-13T18:00:02  *** Leo_Verto1 has quit IRC
2272019-09-13T18:17:33  *** ByronT has joined #bitcoin-core-dev
2282019-09-13T18:19:19  *** Zenton has joined #bitcoin-core-dev
2292019-09-13T18:22:54  *** santo has joined #bitcoin-core-dev
2302019-09-13T18:28:07  *** Highway62 has joined #bitcoin-core-dev
2312019-09-13T18:29:39  *** Highway61 has quit IRC
2322019-09-13T18:29:42  *** Highway62 is now known as Highway61
2332019-09-13T18:33:51  *** mdunnio has quit IRC
2342019-09-13T18:38:26  *** hebasto has quit IRC
2352019-09-13T18:45:07  *** mdunnio has joined #bitcoin-core-dev
2362019-09-13T18:51:57  *** EagleTM has joined #bitcoin-core-dev
2372019-09-13T18:58:55  *** jonatack has joined #bitcoin-core-dev
2382019-09-13T19:00:33  <meshcollider> #startmeeting
2392019-09-13T19:00:33  <lightningbot> Meeting started Fri Sep 13 19:00:33 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
2402019-09-13T19:00:33  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2412019-09-13T19:00:39  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
2422019-09-13T19:00:43  <achow101> hi
2432019-09-13T19:00:48  <instagibbs> oh hi
2442019-09-13T19:01:02  <fanquake> hi
2452019-09-13T19:01:03  <meshcollider> Topics this week?
2462019-09-13T19:01:11  <jonatack> hi
2472019-09-13T19:01:17  <sipa> hi
2482019-09-13T19:01:18  <kanzure> hi
2492019-09-13T19:01:19  <instagibbs> Last minute feature pushes? :P
2502019-09-13T19:01:33  <sipa> miniscript pretty please?
2512019-09-13T19:01:34  <jb55> hi
2522019-09-13T19:01:36  <achow101> let's merge #16341 :p
2532019-09-13T19:01:36  * sipa hides
2542019-09-13T19:01:39  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
2552019-09-13T19:01:41  <instagibbs> sipa, haha
2562019-09-13T19:02:05  <instagibbs> oh yeah #16341: I'd really like that in in not forever. It's a lot of manual looking, but not hard to track imo
2572019-09-13T19:02:08  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
2582019-09-13T19:02:14  <meshcollider> lol
2592019-09-13T19:02:20  <luke-jr> I have to go get kids at school, but how about #15987
2602019-09-13T19:02:23  <gribble> https://github.com/bitcoin/bitcoin/issues/15987 | Wallet, GUI: Warn when sending to already-used Bitcoin addresses by luke-jr · Pull Request #15987 · bitcoin/bitcoin · GitHub
2612019-09-13T19:03:28  <instagibbs> I kind of forgot to hound people for review before feature freeze, but #16727 is pretty easy
2622019-09-13T19:03:30  <gribble> https://github.com/bitcoin/bitcoin/issues/16727 | wallet: Explicit feerate for bumpfee by instagibbs · Pull Request #16727 · bitcoin/bitcoin · GitHub
2632019-09-13T19:03:40  <achow101> luke-jr: feature freeze is probably too close for that
2642019-09-13T19:03:40  <meshcollider> #15204 is the only wallet PR tagged as 0.19 at the moment I think
2652019-09-13T19:03:43  <gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag · Pull Request #15204 · bitcoin/bitcoin · GitHub
2662019-09-13T19:05:01  <achow101> although, looking at it gives me an idea: what if we used a bloom filter for descriptor wallet ismine rather than generating and loading every scriptpubkey?
2672019-09-13T19:05:13  <meshcollider> Basically none of these PRs have any review yet so if you want one of these in, go review it :)
2682019-09-13T19:05:15  <instagibbs> false positives lol
2692019-09-13T19:05:17  <jonatack> meshcollider: PR #16822 is tagged for 0.19
2702019-09-13T19:05:20  <gribble> https://github.com/bitcoin/bitcoin/issues/16822 | gui: Create wallet menu option follow-ups by jonatack · Pull Request #16822 · bitcoin/bitcoin · GitHub
2712019-09-13T19:05:29  *** tryphe has joined #bitcoin-core-dev
2722019-09-13T19:06:18  <sipa> achow101: or BIP158 filter
2732019-09-13T19:06:41  <sipa> achow101: you'd generate the bloom filter on the fly from the scriptPubKeys i guess, still?
2742019-09-13T19:06:45  <achow101> on second thought, it probably wouldn't work. we still need a map of scriptPubKeys to descriptor indexes in order to be able to get the keys to sign them
2752019-09-13T19:07:13  <sipa> and false positives are not a problem; you do a full check for every match
2762019-09-13T19:08:02  <achow101> is it really that much benefit to have both a filter and all of thes scriptpubkeys?
2772019-09-13T19:08:14  <sipa> it may be much faster
2782019-09-13T19:08:27  <sipa> though, that's a question for later
2792019-09-13T19:08:46  <achow101> yes
2802019-09-13T19:08:51  <sipa> just having an explicit set of scriptPubKeys to IsMineness will be much faster than the current IsMine logic already
2812019-09-13T19:09:48  <instagibbs> good point
2822019-09-13T19:09:53  <achow101> yes
2832019-09-13T19:10:29  <achow101> although now I kinda want to know how long it takes IsMine to check that 2 GB testnet wallet that may or may not still exist
2842019-09-13T19:12:18  <meshcollider> Just checking whether a key is in a map is not that slow is it?
2852019-09-13T19:12:48  <achow101> I think std::map is O(nlog(n))
2862019-09-13T19:13:02  <instagibbs> log(n) access...
2872019-09-13T19:13:43  <sipa> std::unordered_map is O(1) (ignoring the fact that pointer size eventually has to grow O(log n) with the size of the table)
2882019-09-13T19:14:21  <meshcollider> Yeah that's a hash map right sipa?
2892019-09-13T19:15:25  <achow101> instagibbs: oh right. std::map is log(n) everything
2902019-09-13T19:16:54  <meshcollider> So I think an unordered_map of your scriptPubKeys is efficient enough without worrying about filters or whatever
2912019-09-13T19:18:27  <achow101> cool. I hadn't realized c++ actually provided a hash map
2922019-09-13T19:18:31  <tryphe> unordered map averages amort O(1) for operations, which can initially be O(n), but ordered map is always O(log n), so it really depends on how you use it.
2932019-09-13T19:18:55  <instagibbs> we're using chains of addresses we control, so hash collisions should be extremely rare?
2942019-09-13T19:18:58  <achow101> tryphe: it depends on whether there are collisions, no? or resizing, but size can be set initially
2952019-09-13T19:19:56  <achow101> not that it really matters, whatever we use will be faster than current IsMine
2962019-09-13T19:20:03  <tryphe> achow101, iirc, it does something to prevent collisions (maybe i am thinking of just QHash<>),, but i think you are right
2972019-09-13T19:22:05  <meshcollider> Yeah I think the O(n) is only the case where all n elements have the same hash and it has to linearly search through them all
2982019-09-13T19:22:10  <sipa> indeed
2992019-09-13T19:22:20  <achow101> let's just tell it to use sha256 :p
3002019-09-13T19:22:36  <sipa> we use salted siphash for hashmaps elsewhere
3012019-09-13T19:23:05  <instagibbs> more than sufficient considering wallet will control inputs
3022019-09-13T19:23:06  <sipa> which is just as good as sha256 truncated to 64 bit output
3032019-09-13T19:23:08  <instagibbs> (I think)
3042019-09-13T19:23:34  <achow101> instagibbs: people could import some weird shit
3052019-09-13T19:23:47  <instagibbs> SFTL :P
3062019-09-13T19:23:59  <achow101> actually, that wouldn't matter since each import would be its own scriptpubkeyman and thus have it's own map
3072019-09-13T19:24:11  <meshcollider> If people want to slow their own wallet down deliberately, let them :p
3082019-09-13T19:24:43  <instagibbs> actually it's a reasonable point, never know how people are going to use thew allet
3092019-09-13T19:25:01  <meshcollider> So anyway yeah in terms of PRs for 0.19, any other begs for review?
3102019-09-13T19:25:22  <meshcollider> Nothing seems particularly pushed-for at the moment
3112019-09-13T19:25:36  <meshcollider> And any other topics for today?
3122019-09-13T19:26:14  <achow101> any suggestions for having the gui inform the wallet that it's done loading transactions?
3132019-09-13T19:26:32  <achow101> context: the stuff I'm working on to not load every tx into memory
3142019-09-13T19:27:54  <achow101> the gui does some thing where it reads through every txout in order to build the transactions list. i would like it to not hammer the disk so it should do it when the transactions are initially loaded into the wallet before they are kicked out later
3152019-09-13T19:30:09  <meshcollider> It just does it once right
3162019-09-13T19:30:19  <achow101> yes
3172019-09-13T19:34:12  <meshcollider> I don't know off the top of my head but can't you do a callback thingy
3182019-09-13T19:35:51  *** bitcoin-git has joined #bitcoin-core-dev
3192019-09-13T19:35:51  <bitcoin-git> [bitcoin] jnewbery opened pull request #16866: [wallet] Rename 'decode' argument in gettransaction method to 'verbose' (master...2019-09-change-gettransaction-arg-name) https://github.com/bitcoin/bitcoin/pull/16866
3202019-09-13T19:35:52  *** bitcoin-git has left #bitcoin-core-dev
3212019-09-13T19:36:01  <achow101> I guess I could just use a signal. there's some things with async that I'm not sure about (GUI has it's own thread, so may be ready before wallet is?)
3222019-09-13T19:38:45  <achow101> any other topics?
3232019-09-13T19:39:07  <meshcollider> Doesn't look like it :)
3242019-09-13T19:39:20  <meshcollider> #endmeeting
3252019-09-13T19:39:20  <lightningbot> Meeting ended Fri Sep 13 19:39:20 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3262019-09-13T19:39:20  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-13-19.00.html
3272019-09-13T19:39:20  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-13-19.00.txt
3282019-09-13T19:39:20  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-13-19.00.log.html
3292019-09-13T19:40:28  <meshcollider> So yeah if you want 15204, 16727 or 16822 in 0.19, please go and review them
3302019-09-13T19:45:00  *** ccdle12 has joined #bitcoin-core-dev
3312019-09-13T19:50:23  *** captjakk has joined #bitcoin-core-dev
3322019-09-13T19:51:13  *** captjakk_ has joined #bitcoin-core-dev
3332019-09-13T19:55:03  *** captjakk has quit IRC
3342019-09-13T20:02:55  *** mdunnio has quit IRC
3352019-09-13T20:03:11  *** mdunnio has joined #bitcoin-core-dev
3362019-09-13T20:04:17  *** mdunnio_ has joined #bitcoin-core-dev
3372019-09-13T20:05:30  *** ccdle12 has quit IRC
3382019-09-13T20:06:47  *** bitcoin-git has joined #bitcoin-core-dev
3392019-09-13T20:06:47  <bitcoin-git> [bitcoin] theuni opened pull request #16867: release: Update the Windows Codesigning certificate (0.17...0.17) https://github.com/bitcoin/bitcoin/pull/16867
3402019-09-13T20:06:48  *** bitcoin-git has left #bitcoin-core-dev
3412019-09-13T20:07:00  *** ccdle12 has joined #bitcoin-core-dev
3422019-09-13T20:07:48  *** mdunnio has quit IRC
3432019-09-13T20:08:08  *** ccdle12 has quit IRC
3442019-09-13T20:14:03  *** votesmith has quit IRC
3452019-09-13T20:23:36  *** votesmith has joined #bitcoin-core-dev
3462019-09-13T20:37:50  *** rafalcpp_ has joined #bitcoin-core-dev
3472019-09-13T20:38:20  *** rafalcpp has quit IRC
3482019-09-13T20:38:57  *** mdunnio_ has quit IRC
3492019-09-13T20:41:47  *** DavidMitchell[m] has quit IRC
3502019-09-13T20:41:57  *** TheFuzzStone[m] has quit IRC
3512019-09-13T20:42:10  *** kewde[m] has quit IRC
3522019-09-13T20:42:17  *** awesome-doge has quit IRC
3532019-09-13T20:42:23  *** electric-sheep[m has quit IRC
3542019-09-13T20:45:37  *** mdunnio has joined #bitcoin-core-dev
3552019-09-13T20:48:15  *** TheFuzzStone[m] has joined #bitcoin-core-dev
3562019-09-13T20:55:17  *** electric-sheep[m has joined #bitcoin-core-dev
3572019-09-13T20:55:17  *** kewde[m] has joined #bitcoin-core-dev
3582019-09-13T20:55:17  *** awesome-doge has joined #bitcoin-core-dev
3592019-09-13T20:55:24  *** DavidMitchell[m] has joined #bitcoin-core-dev
3602019-09-13T20:57:33  *** Highway62 has joined #bitcoin-core-dev
3612019-09-13T20:57:39  *** Highway61 has quit IRC
3622019-09-13T20:57:39  *** Highway62 is now known as Highway61
3632019-09-13T21:00:02  *** ByronT has quit IRC
3642019-09-13T21:00:47  *** santo has quit IRC
3652019-09-13T21:02:19  *** Salve has quit IRC
3662019-09-13T21:17:52  *** JesusFreke has joined #bitcoin-core-dev
3672019-09-13T21:25:21  *** kristapsk has joined #bitcoin-core-dev
3682019-09-13T21:26:04  *** tryphe_ has joined #bitcoin-core-dev
3692019-09-13T21:27:51  *** tryphe has quit IRC
3702019-09-13T21:34:43  *** tryphe_ is now known as tryphe
3712019-09-13T21:42:42  *** Guyver2 has quit IRC
3722019-09-13T21:47:27  *** tryphe has quit IRC
3732019-09-13T21:48:30  *** tryphe has joined #bitcoin-core-dev
3742019-09-13T21:55:59  *** ccdle12 has joined #bitcoin-core-dev
3752019-09-13T21:56:27  *** rafalcpp_ has quit IRC
3762019-09-13T21:56:38  *** rafalcpp_ has joined #bitcoin-core-dev
3772019-09-13T22:07:29  *** goatpig has quit IRC
3782019-09-13T22:14:03  *** ccdle12 has quit IRC
3792019-09-13T22:17:33  *** mdunnio has quit IRC
3802019-09-13T22:24:24  *** captjakk_ has quit IRC
3812019-09-13T22:30:01  *** goatpig has joined #bitcoin-core-dev
3822019-09-13T22:30:12  <emilengler> How do I add a file to the autotools makefile?
3832019-09-13T22:33:03  <emilengler> Problem solved!
3842019-09-13T22:33:10  <emilengler> See src/Makefile.am
3852019-09-13T22:45:56  *** Highway62 has joined #bitcoin-core-dev
3862019-09-13T22:48:04  *** Highway61 has quit IRC
3872019-09-13T22:48:04  *** Highway62 is now known as Highway61
3882019-09-13T22:55:43  *** bitcoin-git has joined #bitcoin-core-dev
3892019-09-13T22:55:43  <bitcoin-git> [bitcoin] emilengler opened pull request #16868: Add specific envvar system (master...2019-09-specific-envvar) https://github.com/bitcoin/bitcoin/pull/16868
3902019-09-13T22:55:45  *** bitcoin-git has left #bitcoin-core-dev
3912019-09-13T23:17:00  *** bitcoin-git has joined #bitcoin-core-dev
3922019-09-13T23:17:00  <bitcoin-git> [bitcoin] kristapsk opened pull request #16869: Add missing walletconflicts to the help output of gettransaction and listtrasactions (master...help-walletconflicts) https://github.com/bitcoin/bitcoin/pull/16869
3932019-09-13T23:17:01  *** bitcoin-git has left #bitcoin-core-dev
3942019-09-13T23:18:35  *** bitcoin-git has joined #bitcoin-core-dev
3952019-09-13T23:18:35  <bitcoin-git> [bitcoin] fanquake closed pull request #16869: Add missing walletconflicts to the help output of gettransaction and listtrasactions (master...help-walletconflicts) https://github.com/bitcoin/bitcoin/pull/16869
3962019-09-13T23:18:39  *** bitcoin-git has left #bitcoin-core-dev
3972019-09-13T23:33:15  *** elichai2 has quit IRC
3982019-09-13T23:37:28  *** bitcoin-git has joined #bitcoin-core-dev
3992019-09-13T23:37:28  <bitcoin-git> [bitcoin] fanquake opened pull request #16870: build: update boost macros to latest upstream for improved error reporting (master...pull_upstream_boost_m4) https://github.com/bitcoin/bitcoin/pull/16870
4002019-09-13T23:37:39  *** bitcoin-git has left #bitcoin-core-dev
4012019-09-13T23:39:12  *** xzytrewq has quit IRC