1 2019-09-26T00:00:02  *** jchris has quit IRC
  2 2019-09-26T00:03:03  *** diogosergio has joined #bitcoin-core-dev
  3 2019-09-26T00:07:16  *** marcoagner has quit IRC
  4 2019-09-26T00:07:39  *** diogosergio has quit IRC
  5 2019-09-26T00:08:59  *** promag has quit IRC
  6 2019-09-26T00:17:32  *** prae has joined #bitcoin-core-dev
  7 2019-09-26T00:20:30  *** lightlike has quit IRC
  8 2019-09-26T00:21:56  *** tsujp has quit IRC
  9 2019-09-26T00:23:21  *** jb55 has joined #bitcoin-core-dev
 10 2019-09-26T00:31:15  *** yintian has joined #bitcoin-core-dev
 11 2019-09-26T00:35:21  *** clarkmoody has joined #bitcoin-core-dev
 12 2019-09-26T00:36:44  *** yintian has left #bitcoin-core-dev
 13 2019-09-26T00:42:01  *** yintian has joined #bitcoin-core-dev
 14 2019-09-26T00:44:11  *** clarkmoody has quit IRC
 15 2019-09-26T00:47:04  *** promag has joined #bitcoin-core-dev
 16 2019-09-26T00:50:33  *** sdaftuar_ has quit IRC
 17 2019-09-26T00:50:57  *** sdaftuar_ has joined #bitcoin-core-dev
 18 2019-09-26T00:52:05  *** promag has quit IRC
 19 2019-09-26T01:02:33  *** yintian has quit IRC
 20 2019-09-26T01:03:11  *** yintian has joined #bitcoin-core-dev
 21 2019-09-26T01:11:51  *** yintian has quit IRC
 22 2019-09-26T01:17:07  *** rafalcpp_ has quit IRC
 23 2019-09-26T01:17:35  *** rafalcpp_ has joined #bitcoin-core-dev
 24 2019-09-26T01:33:18  *** tsujp has joined #bitcoin-core-dev
 25 2019-09-26T01:36:27  *** cubancorona has joined #bitcoin-core-dev
 26 2019-09-26T01:36:49  *** xzytrewq has quit IRC
 27 2019-09-26T01:37:50  *** cubancorona has quit IRC
 28 2019-09-26T01:38:45  *** cubancorona has joined #bitcoin-core-dev
 29 2019-09-26T01:42:58  *** xzytrewq has joined #bitcoin-core-dev
 30 2019-09-26T01:57:28  *** ddustin has quit IRC
 31 2019-09-26T01:58:03  *** ddustin has joined #bitcoin-core-dev
 32 2019-09-26T02:02:32  *** ddustin has quit IRC
 33 2019-09-26T02:06:15  *** emilengler_ has joined #bitcoin-core-dev
 34 2019-09-26T02:09:46  *** emilengler has quit IRC
 35 2019-09-26T02:11:30  *** justanotheruser has joined #bitcoin-core-dev
 36 2019-09-26T02:21:19  *** harrigan has quit IRC
 37 2019-09-26T02:27:00  *** harrigan has joined #bitcoin-core-dev
 38 2019-09-26T02:38:52  *** clarkmoo_ has joined #bitcoin-core-dev
 39 2019-09-26T02:47:47  *** StopAndDecrypt_ has quit IRC
 40 2019-09-26T02:55:39  *** justanotheruser has quit IRC
 41 2019-09-26T03:00:01  *** prae has quit IRC
 42 2019-09-26T03:04:35  *** rex4539 has joined #bitcoin-core-dev
 43 2019-09-26T03:04:51  *** zenogais has quit IRC
 44 2019-09-26T03:16:59  *** justanotheruser has joined #bitcoin-core-dev
 45 2019-09-26T03:17:37  *** ironmarx has joined #bitcoin-core-dev
 46 2019-09-26T03:21:52  *** promag has joined #bitcoin-core-dev
 47 2019-09-26T03:26:37  *** promag has quit IRC
 48 2019-09-26T03:31:09  *** harrigan_ has joined #bitcoin-core-dev
 49 2019-09-26T03:33:47  *** harrigan has quit IRC
 50 2019-09-26T03:53:01  *** rh0nj has quit IRC
 51 2019-09-26T03:54:08  *** rh0nj has joined #bitcoin-core-dev
 52 2019-09-26T03:56:02  *** harrigan_ has quit IRC
 53 2019-09-26T03:56:33  *** harrigan has joined #bitcoin-core-dev
 54 2019-09-26T04:34:07  *** tsujp has quit IRC
 55 2019-09-26T04:36:39  *** harrigan has quit IRC
 56 2019-09-26T04:36:59  *** harrigan has joined #bitcoin-core-dev
 57 2019-09-26T04:39:08  *** tsujp has joined #bitcoin-core-dev
 58 2019-09-26T05:42:19  *** Victor_sueca is now known as Victorsueca
 59 2019-09-26T05:53:41  *** kristapsk has quit IRC
 60 2019-09-26T06:00:02  *** ironmarx has quit IRC
 61 2019-09-26T06:06:44  *** promag has joined #bitcoin-core-dev
 62 2019-09-26T06:10:02  *** EagleTM has joined #bitcoin-core-dev
 63 2019-09-26T06:10:57  *** promag has quit IRC
 64 2019-09-26T06:12:57  *** rafalcpp_ has quit IRC
 65 2019-09-26T06:13:30  *** rafalcpp_ has joined #bitcoin-core-dev
 66 2019-09-26T06:14:43  *** EagleTM has quit IRC
 67 2019-09-26T06:16:57  *** Salt1 has joined #bitcoin-core-dev
 68 2019-09-26T06:22:17  *** rex4539 has quit IRC
 69 2019-09-26T06:24:20  *** AaronvanW has joined #bitcoin-core-dev
 70 2019-09-26T06:28:18  *** AaronvanW has quit IRC
 71 2019-09-26T06:29:26  *** lnostdal has quit IRC
 72 2019-09-26T06:31:20  *** lnostdal has joined #bitcoin-core-dev
 73 2019-09-26T06:35:45  *** AaronvanW has joined #bitcoin-core-dev
 74 2019-09-26T06:37:19  *** marcoagner has joined #bitcoin-core-dev
 75 2019-09-26T06:38:44  *** rex4539 has joined #bitcoin-core-dev
 76 2019-09-26T06:41:06  *** promag has joined #bitcoin-core-dev
 77 2019-09-26T06:43:34  *** promag has quit IRC
 78 2019-09-26T06:45:52  *** AaronvanW has quit IRC
 79 2019-09-26T06:57:17  *** rafalcpp_ has quit IRC
 80 2019-09-26T06:57:25  *** rafalcpp_ has joined #bitcoin-core-dev
 81 2019-09-26T07:05:44  *** diogosergio has joined #bitcoin-core-dev
 82 2019-09-26T07:10:17  *** diogosergio has quit IRC
 83 2019-09-26T07:15:32  *** ghost43 has quit IRC
 84 2019-09-26T07:17:30  *** ghost43 has joined #bitcoin-core-dev
 85 2019-09-26T07:20:58  *** AaronvanW has joined #bitcoin-core-dev
 86 2019-09-26T07:25:43  *** diogosergio has joined #bitcoin-core-dev
 87 2019-09-26T07:28:27  *** diogosergio has quit IRC
 88 2019-09-26T07:30:42  *** diogosergio has joined #bitcoin-core-dev
 89 2019-09-26T07:33:07  *** diogosergio has quit IRC
 90 2019-09-26T07:36:12  *** rafalcpp_ has quit IRC
 91 2019-09-26T07:36:16  *** rafalcpp has joined #bitcoin-core-dev
 92 2019-09-26T07:47:20  *** IGHOR has quit IRC
 93 2019-09-26T07:47:38  *** diogosergio has joined #bitcoin-core-dev
 94 2019-09-26T07:49:11  *** diogosergio has quit IRC
 95 2019-09-26T07:52:38  *** diogosergio has joined #bitcoin-core-dev
 96 2019-09-26T07:55:40  *** diogosergio has quit IRC
 97 2019-09-26T07:59:17  *** rafalcpp has quit IRC
 98 2019-09-26T08:01:48  *** sdaftuar_ has quit IRC
 99 2019-09-26T08:01:53  *** rafalcpp has joined #bitcoin-core-dev
100 2019-09-26T08:02:18  *** sdaftuar_ has joined #bitcoin-core-dev
101 2019-09-26T08:18:02  *** promag has joined #bitcoin-core-dev
102 2019-09-26T08:24:54  *** astro has quit IRC
103 2019-09-26T08:25:08  *** astro has joined #bitcoin-core-dev
104 2019-09-26T08:28:29  *** promag has quit IRC
105 2019-09-26T08:28:32  *** jonatack has quit IRC
106 2019-09-26T08:34:16  *** promag has joined #bitcoin-core-dev
107 2019-09-26T09:00:01  *** Salt1 has quit IRC
108 2019-09-26T09:08:21  *** bitcoin-git has joined #bitcoin-core-dev
109 2019-09-26T09:08:21  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4c4ff4911a6d...fdfaeb67de36
110 2019-09-26T09:08:22  <bitcoin-git> bitcoin/master fa607c2 MarcoFalke: validation: Make GetWitnessCommitmentIndex public
111 2019-09-26T09:08:22  <bitcoin-git> bitcoin/master fdfaeb6 fanquake: Merge #16956: validation: Make GetWitnessCommitmentIndex public
112 2019-09-26T09:08:24  *** bitcoin-git has left #bitcoin-core-dev
113 2019-09-26T09:08:41  *** bitcoin-git has joined #bitcoin-core-dev
114 2019-09-26T09:08:41  <bitcoin-git> [bitcoin] fanquake merged pull request #16956: validation: Make GetWitnessCommitmentIndex public (master...1909-valGetWitnessCommitmentIndexPublic) https://github.com/bitcoin/bitcoin/pull/16956
115 2019-09-26T09:08:42  *** bitcoin-git has left #bitcoin-core-dev
116 2019-09-26T09:21:32  *** cryptoIndio has joined #bitcoin-core-dev
117 2019-09-26T09:48:01  *** maxfragg1 has joined #bitcoin-core-dev
118 2019-09-26T09:48:13  *** jonatack has joined #bitcoin-core-dev
119 2019-09-26T10:31:04  *** tsujp has quit IRC
120 2019-09-26T10:44:53  *** maxfragg1 has quit IRC
121 2019-09-26T10:54:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
122 2019-09-26T10:59:47  *** Guyver2 has joined #bitcoin-core-dev
123 2019-09-26T11:19:58  *** bitcoin-git has joined #bitcoin-core-dev
124 2019-09-26T11:19:59  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fdfaeb67de36...003f2d20b1c7
125 2019-09-26T11:20:00  <bitcoin-git> bitcoin/master 6eb12ff Carl Dong: depends: qt: Fix C{,XX}FLAGS pickup
126 2019-09-26T11:20:00  <bitcoin-git> bitcoin/master 1b4030e Carl Dong: depends: qt: Fix LDFLAGS pickup
127 2019-09-26T11:20:01  <bitcoin-git> bitcoin/master 003f2d2 Wladimir J. van der Laan: Merge #16837: depends: qt: Fix {C{,XX},LD}FLAGS pickup
128 2019-09-26T11:20:03  *** bitcoin-git has left #bitcoin-core-dev
129 2019-09-26T11:20:23  *** spaced0ut has joined #bitcoin-core-dev
130 2019-09-26T11:20:23  *** bitcoin-git has joined #bitcoin-core-dev
131 2019-09-26T11:20:23  <bitcoin-git> [bitcoin] laanwj merged pull request #16837: depends: qt: Fix {C{,XX},LD}FLAGS pickup (master...2019-09-fix-qt-cflags-pickup) https://github.com/bitcoin/bitcoin/pull/16837
132 2019-09-26T11:20:24  *** bitcoin-git has left #bitcoin-core-dev
133 2019-09-26T11:27:05  *** setpill has joined #bitcoin-core-dev
134 2019-09-26T11:28:46  *** harrigan has quit IRC
135 2019-09-26T11:29:24  *** harrigan has joined #bitcoin-core-dev
136 2019-09-26T11:34:12  *** Chris_Stewart_5 has quit IRC
137 2019-09-26T11:39:16  *** bitcoin-git has joined #bitcoin-core-dev
138 2019-09-26T11:39:16  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/003f2d20b1c7...ab765c2ec7db
139 2019-09-26T11:39:17  <bitcoin-git> bitcoin/master efd2474 Larry Ruane: util: CBufferedFile fixes
140 2019-09-26T11:39:17  <bitcoin-git> bitcoin/master ab765c2 Wladimir J. van der Laan: Merge #16577: util: CBufferedFile fixes and unit test
141 2019-09-26T11:39:19  *** bitcoin-git has left #bitcoin-core-dev
142 2019-09-26T11:39:36  *** bitcoin-git has joined #bitcoin-core-dev
143 2019-09-26T11:39:36  <bitcoin-git> [bitcoin] laanwj merged pull request #16577: util: CBufferedFile fixes and unit test (master...CBufferedFile-fixes) https://github.com/bitcoin/bitcoin/pull/16577
144 2019-09-26T11:39:37  *** bitcoin-git has left #bitcoin-core-dev
145 2019-09-26T11:53:28  *** michaelfolkson has joined #bitcoin-core-dev
146 2019-09-26T11:53:30  *** tsujp has joined #bitcoin-core-dev
147 2019-09-26T11:54:37  *** jonatack has quit IRC
148 2019-09-26T11:59:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
149 2019-09-26T12:17:50  *** MichealH-iPod has joined #bitcoin-core-dev
150 2019-09-26T12:20:58  <wumpus> midnightmagic: good to know
151 2019-09-26T12:21:17  *** tryphe_ has joined #bitcoin-core-dev
152 2019-09-26T12:22:03  *** tryphe has quit IRC
153 2019-09-26T12:22:04  <wumpus> I think we should use today's meeting to discuss and triage the still-open issues on the 0.19 milestone (https://github.com/bitcoin/bitcoin/milestone/37)
154 2019-09-26T12:22:34  <fanquake> wumpus good idea. Branch off isn't far away.
155 2019-09-26T12:22:47  <fanquake> #15940
156 2019-09-26T12:22:50  <gribble> https://github.com/bitcoin/bitcoin/issues/15940 | Release schedule for 0.19.0 · Issue #15940 · bitcoin/bitcoin · GitHub
157 2019-09-26T12:24:15  <fanquake> There's a few issues tagged 0.19.0, like #16444, which don't have the related PR (#16849 in this case) tagged yet.
158 2019-09-26T12:24:16  <gribble> https://github.com/bitcoin/bitcoin/issues/16444 | Assertion `setBlockIndexCandidates.count(pindex) failed · Issue #16444 · bitcoin/bitcoin · GitHub
159 2019-09-26T12:24:20  <gribble> https://github.com/bitcoin/bitcoin/issues/16849 | Fix block index inconsistency in InvalidateBlock() by sdaftuar · Pull Request #16849 · bitcoin/bitcoin · GitHub
160 2019-09-26T12:39:19  *** diogosergio has joined #bitcoin-core-dev
161 2019-09-26T12:42:14  *** promag has quit IRC
162 2019-09-26T12:43:57  *** diogosergio has quit IRC
163 2019-09-26T12:48:38  *** profmac has quit IRC
164 2019-09-26T12:51:20  *** promag has joined #bitcoin-core-dev
165 2019-09-26T12:55:37  *** Chris_Stewart_5 has quit IRC
166 2019-09-26T12:57:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
167 2019-09-26T13:02:31  *** profmac has joined #bitcoin-core-dev
168 2019-09-26T13:04:05  *** jonatack has joined #bitcoin-core-dev
169 2019-09-26T13:09:32  *** davterra has joined #bitcoin-core-dev
170 2019-09-26T13:11:26  *** michaelfolkson has quit IRC
171 2019-09-26T13:14:36  <wumpus> fanquake: let's try to do that, ive tagged 16849
172 2019-09-26T13:15:14  *** promag_ has joined #bitcoin-core-dev
173 2019-09-26T13:33:27  <wumpus> don't think resolving #16778 for 0.19 is realistic, the most straightforward solution would require switching DNS lookup to libevent
174 2019-09-26T13:33:28  <gribble> https://github.com/bitcoin/bitcoin/issues/16778 | ThreadDNSAddressSeed hangs on sk_wait_data and doesnt stop on exit · Issue #16778 · bitcoin/bitcoin · GitHub
175 2019-09-26T13:34:11  <wumpus> moving it to 0.20
176 2019-09-26T13:35:20  *** liberiga has joined #bitcoin-core-dev
177 2019-09-26T13:35:25  <wumpus> (and it's only a "hang at shutdown" issue in, afaik, kind of rare circumstances)
178 2019-09-26T13:47:37  *** jnewbery has quit IRC
179 2019-09-26T13:47:55  *** cubancorona has quit IRC
180 2019-09-26T13:48:26  *** davterra has quit IRC
181 2019-09-26T14:00:54  *** captjakk has joined #bitcoin-core-dev
182 2019-09-26T14:25:01  *** lightlike has joined #bitcoin-core-dev
183 2019-09-26T14:25:11  *** mdunnio has joined #bitcoin-core-dev
184 2019-09-26T14:26:08  *** mdunnio has quit IRC
185 2019-09-26T14:26:22  *** captjakk has quit IRC
186 2019-09-26T14:31:41  *** davex__ has quit IRC
187 2019-09-26T14:32:32  *** promag_ has quit IRC
188 2019-09-26T14:34:21  *** promag_ has joined #bitcoin-core-dev
189 2019-09-26T14:35:19  *** promag_ has joined #bitcoin-core-dev
190 2019-09-26T14:41:20  *** emilengler_ is now known as emilengler
191 2019-09-26T14:46:36  *** mdunnio has joined #bitcoin-core-dev
192 2019-09-26T14:47:48  *** StopAndDecrypt has joined #bitcoin-core-dev
193 2019-09-26T14:48:56  *** bitcoin-git has joined #bitcoin-core-dev
194 2019-09-26T14:48:56  <bitcoin-git> [bitcoin] laanwj opened pull request #16968: doc: Remove MSVC update step from translation process (master...2019_09_translation_process) https://github.com/bitcoin/bitcoin/pull/16968
195 2019-09-26T14:49:08  *** bitcoin-git has left #bitcoin-core-dev
196 2019-09-26T14:49:15  *** davec has quit IRC
197 2019-09-26T14:51:41  *** promag_ has joined #bitcoin-core-dev
198 2019-09-26T14:53:48  *** liberiga has quit IRC
199 2019-09-26T14:59:57  *** captjakk has joined #bitcoin-core-dev
200 2019-09-26T15:00:01  *** MichealH-iPod has quit IRC
201 2019-09-26T15:01:15  *** promag has quit IRC
202 2019-09-26T15:12:44  *** zenogais has joined #bitcoin-core-dev
203 2019-09-26T15:19:35  *** mackr has joined #bitcoin-core-dev
204 2019-09-26T15:20:43  *** promag_ has quit IRC
205 2019-09-26T15:20:59  *** promag has joined #bitcoin-core-dev
206 2019-09-26T15:24:29  *** promag_ has joined #bitcoin-core-dev
207 2019-09-26T15:26:46  *** captjakk has quit IRC
208 2019-09-26T15:30:21  *** captjakk has joined #bitcoin-core-dev
209 2019-09-26T15:43:45  <emilengler> What do these errors by the linter mean? https://travis-ci.org/bitcoin/bitcoin/jobs/590021768
210 2019-09-26T15:46:17  *** jnewbery has joined #bitcoin-core-dev
211 2019-09-26T15:49:09  <darosior7> emilengler: it means that you include envvar in util/system and util/system in envvar, that's a cricular dependency (https://en.wikipedia.org/wiki/Circular_dependency)
212 2019-09-26T15:49:28  <emilengler> thanks
213 2019-09-26T15:50:24  *** captjakk has quit IRC
214 2019-09-26T15:51:39  <emilengler> Unfortunaly I need to use envvar in system and stuff from system in envvar
215 2019-09-26T15:51:57  <emilengler> Is there a may to fix this
216 2019-09-26T15:51:59  <emilengler> way*
217 2019-09-26T15:52:24  <emilengler> Might be a more C++ related question though
218 2019-09-26T15:55:02  *** rh0nj has quit IRC
219 2019-09-26T15:56:09  *** rh0nj has joined #bitcoin-core-dev
220 2019-09-26T15:57:16  *** promag_ has quit IRC
221 2019-09-26T16:01:25  *** promag has quit IRC
222 2019-09-26T16:04:27  *** mdunnio has quit IRC
223 2019-09-26T16:06:48  *** mdunnio has joined #bitcoin-core-dev
224 2019-09-26T16:08:11  <instagibbs> can someone point me to where parallel block fetch code is/gets activated? I only see references to it in non-parallel fetch code via grepping
225 2019-09-26T16:08:29  <sdaftuar_> FindNextBlocksToDownload() is the relevant code
226 2019-09-26T16:08:40  <sdaftuar_> it's invoked in SendMessages for each peer
227 2019-09-26T16:08:52  *** sdaftuar_ is now known as sdaftuar
228 2019-09-26T16:09:06  <instagibbs> ah perfect thanks
229 2019-09-26T16:09:09  <sdaftuar> the code is not written in a way to make this obvious
230 2019-09-26T16:09:24  <instagibbs> Even a comment saying "parallel" would have been helpful :D
231 2019-09-26T16:09:39  <sdaftuar> but the "activation" comes from syncing headers with a peer -- that allows us to download blocks from that peer
232 2019-09-26T16:10:01  <sdaftuar> there are delays (for a node starting up) around how quickly we will sync headers with each peer
233 2019-09-26T16:10:52  *** xzytrewq has quit IRC
234 2019-09-26T16:12:36  *** tryphe__ has joined #bitcoin-core-dev
235 2019-09-26T16:12:40  <jamesob> instagibbs: this is the logic that ensures we're downloading at most MAX_BLOCKS_IN_TRANSIT_PER_PEER * num_peers simultaneously: https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L4017-L4020
236 2019-09-26T16:12:59  *** tryphe__ is now known as tryphe
237 2019-09-26T16:13:08  <jamesob> download happens in parallel because queuing the GETDATA messages isn't blocking, and `SendMessages()` is invoked in a loop for each peer
238 2019-09-26T16:14:10  *** cubancorona has joined #bitcoin-core-dev
239 2019-09-26T16:15:58  *** tryphe_ has quit IRC
240 2019-09-26T16:16:56  *** ddustin has joined #bitcoin-core-dev
241 2019-09-26T16:22:03  *** ddustin has quit IRC
242 2019-09-26T16:23:42  *** captjakk has joined #bitcoin-core-dev
243 2019-09-26T16:29:13  *** mdunnio has quit IRC
244 2019-09-26T16:31:33  *** xzytrewq has joined #bitcoin-core-dev
245 2019-09-26T16:31:37  *** Honthe has joined #bitcoin-core-dev
246 2019-09-26T16:32:47  *** hhhhhhhhhhh has joined #bitcoin-core-dev
247 2019-09-26T16:44:44  *** mdunnio has joined #bitcoin-core-dev
248 2019-09-26T16:45:20  *** captjakk has quit IRC
249 2019-09-26T16:45:21  *** promag has joined #bitcoin-core-dev
250 2019-09-26T16:45:56  *** captjakk has joined #bitcoin-core-dev
251 2019-09-26T16:46:42  *** promag has quit IRC
252 2019-09-26T16:46:59  *** promag has joined #bitcoin-core-dev
253 2019-09-26T16:47:19  *** captjakk_ has joined #bitcoin-core-dev
254 2019-09-26T16:47:24  *** captjakk has quit IRC
255 2019-09-26T16:49:37  *** mdunnio has quit IRC
256 2019-09-26T16:57:37  *** lnostdal has quit IRC
257 2019-09-26T17:00:55  *** mdunnio has joined #bitcoin-core-dev
258 2019-09-26T17:03:44  *** xzytrewq has quit IRC
259 2019-09-26T17:05:27  *** mdunnio has quit IRC
260 2019-09-26T17:09:44  *** mdunnio has joined #bitcoin-core-dev
261 2019-09-26T17:11:12  *** lnostdal has joined #bitcoin-core-dev
262 2019-09-26T17:16:23  *** lnostdal has quit IRC
263 2019-09-26T17:22:16  *** jarthur has joined #bitcoin-core-dev
264 2019-09-26T17:31:41  *** mdunnio has quit IRC
265 2019-09-26T17:31:49  *** captjakk_ has quit IRC
266 2019-09-26T17:32:25  *** captjakk has joined #bitcoin-core-dev
267 2019-09-26T17:32:42  *** lnostdal has joined #bitcoin-core-dev
268 2019-09-26T17:37:38  *** captjakk has quit IRC
269 2019-09-26T17:40:00  *** captjakk has joined #bitcoin-core-dev
270 2019-09-26T17:42:22  *** captjakk has quit IRC
271 2019-09-26T17:42:39  *** captjakk has joined #bitcoin-core-dev
272 2019-09-26T17:42:57  *** tryphe_ has joined #bitcoin-core-dev
273 2019-09-26T17:44:03  *** bitcoin-git has joined #bitcoin-core-dev
274 2019-09-26T17:44:03  <bitcoin-git> [bitcoin] emilengler opened pull request #16969: refactor: Remove Qt function to disable menu icons on macOS (master...2019-09-refactor-qt-menuicons-macos) https://github.com/bitcoin/bitcoin/pull/16969
275 2019-09-26T17:44:05  *** bitcoin-git has left #bitcoin-core-dev
276 2019-09-26T17:44:32  *** tryphe has quit IRC
277 2019-09-26T17:46:21  *** mdunnio has joined #bitcoin-core-dev
278 2019-09-26T17:49:11  *** bitcoin-git has joined #bitcoin-core-dev
279 2019-09-26T17:49:11  <bitcoin-git> [bitcoin] martinus opened pull request #16970: 6% faster, 6% less memory: more tightly pack CCoinMap::value_type (master...2019-09-more-compact-Coin) https://github.com/bitcoin/bitcoin/pull/16970
280 2019-09-26T17:49:23  *** bitcoin-git has left #bitcoin-core-dev
281 2019-09-26T17:50:06  *** captjakk_ has joined #bitcoin-core-dev
282 2019-09-26T17:50:06  *** captjakk has quit IRC
283 2019-09-26T17:50:40  *** captjakk_ has quit IRC
284 2019-09-26T17:50:46  *** captjakk has joined #bitcoin-core-dev
285 2019-09-26T17:52:48  *** captjakk has quit IRC
286 2019-09-26T17:53:24  *** captjakk has joined #bitcoin-core-dev
287 2019-09-26T17:59:48  *** bitcoin-git has joined #bitcoin-core-dev
288 2019-09-26T17:59:49  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ab765c2ec7db...6288f15f50ab
289 2019-09-26T17:59:49  <bitcoin-git> bitcoin/master 8d841ad Wladimir J. van der Laan: doc: Remove MSVC update step from translation process
290 2019-09-26T17:59:50  <bitcoin-git> bitcoin/master 6288f15 Wladimir J. van der Laan: Merge #16968: doc: Remove MSVC update step from translation process
291 2019-09-26T17:59:59  *** bitcoin-git has left #bitcoin-core-dev
292 2019-09-26T18:00:01  *** mackr has quit IRC
293 2019-09-26T18:00:18  *** bitcoin-git has joined #bitcoin-core-dev
294 2019-09-26T18:00:18  <bitcoin-git> [bitcoin] laanwj merged pull request #16968: doc: Remove MSVC update step from translation process (master...2019_09_translation_process) https://github.com/bitcoin/bitcoin/pull/16968
295 2019-09-26T18:00:29  *** bitcoin-git has left #bitcoin-core-dev
296 2019-09-26T18:01:14  *** jcorgan has joined #bitcoin-core-dev
297 2019-09-26T18:03:39  *** jcorgan_ has quit IRC
298 2019-09-26T18:05:19  *** davec has joined #bitcoin-core-dev
299 2019-09-26T18:09:39  *** justanotheruser has quit IRC
300 2019-09-26T18:14:13  *** promag has quit IRC
301 2019-09-26T18:14:44  *** justanotheruser has joined #bitcoin-core-dev
302 2019-09-26T18:17:04  *** kierra has joined #bitcoin-core-dev
303 2019-09-26T18:17:28  *** kierra is now known as Guest35726
304 2019-09-26T18:22:56  *** arubi has quit IRC
305 2019-09-26T18:26:20  *** bitcoin-git has joined #bitcoin-core-dev
306 2019-09-26T18:26:21  <bitcoin-git> [bitcoin] emilengler opened pull request #16971: qt: Change default size of intro frame (master...2019-09-qt-change-intro-default-size) https://github.com/bitcoin/bitcoin/pull/16971
307 2019-09-26T18:26:21  *** bitcoin-git has left #bitcoin-core-dev
308 2019-09-26T18:38:09  *** arubi has joined #bitcoin-core-dev
309 2019-09-26T18:40:11  *** bitcoin-git has joined #bitcoin-core-dev
310 2019-09-26T18:40:11  <bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16825: Default to 2 additional blocks-only connections over Tor (+ bump default max conns to 150) (master...2019-09-tor-blocksonly) https://github.com/bitcoin/bitcoin/pull/16825
311 2019-09-26T18:40:23  *** bitcoin-git has left #bitcoin-core-dev
312 2019-09-26T18:44:00  *** captjakk has quit IRC
313 2019-09-26T18:44:34  *** captjakk has joined #bitcoin-core-dev
314 2019-09-26T18:50:03  *** hhhhhhhhhhh has quit IRC
315 2019-09-26T18:50:18  *** hhhhhhhhhhh has joined #bitcoin-core-dev
316 2019-09-26T18:50:32  *** ryanofsky_ has left #bitcoin-core-dev
317 2019-09-26T18:50:46  *** ryanofsky has joined #bitcoin-core-dev
318 2019-09-26T18:53:56  *** ddustin has joined #bitcoin-core-dev
319 2019-09-26T18:58:06  *** captjakk has quit IRC
320 2019-09-26T18:58:17  *** ddustin has quit IRC
321 2019-09-26T18:58:42  *** captjakk has joined #bitcoin-core-dev
322 2019-09-26T19:00:20  <wumpus> meeting time?
323 2019-09-26T19:00:35  <achow101> meeting?
324 2019-09-26T19:00:41  <wumpus> #startmeeting
325 2019-09-26T19:00:41  <lightningbot> Meeting started Thu Sep 26 19:00:41 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
326 2019-09-26T19:00:41  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
327 2019-09-26T19:00:44  <jonasschnelli> hi
328 2019-09-26T19:00:49  *** captjakk has quit IRC
329 2019-09-26T19:00:51  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
330 2019-09-26T19:00:53  <provoostenator> hi
331 2019-09-26T19:00:58  <achow101> hi
332 2019-09-26T19:00:58  <moneyball> hi
333 2019-09-26T19:01:04  <instagibbs> hi
334 2019-09-26T19:01:21  <MarcoFalke> What is the status of 0.17.2 and 0.18.2?
335 2019-09-26T19:01:24  <wumpus> with the 0.19 split-off coming up, I think we should use today's meeting to discuss and triage the still-open issues on the 0.19 milestone (https://github.com/bitcoin/bitcoin/milestone/37)
336 2019-09-26T19:01:26  *** captjakk has joined #bitcoin-core-dev
337 2019-09-26T19:01:42  *** promag has joined #bitcoin-core-dev
338 2019-09-26T19:01:54  <BlueMatt> ack
339 2019-09-26T19:03:01  <provoostenator> I'll try to resist shiny object syndrome and review a bunch of 0.19 soon tm.
340 2019-09-26T19:03:03  <wumpus> MarcoFalke: 0.17.2 is done, still have to upload executables, dunno about 0.18.2
341 2019-09-26T19:03:29  <BlueMatt> provoostenator: welcome to my life
342 2019-09-26T19:03:29  <MarcoFalke> So 0.17.2rc2 is 0.17.2-final
343 2019-09-26T19:03:49  <wumpus> MarcoFalke: eh wait, I mean rc2
344 2019-09-26T19:03:59  <MarcoFalke> heh
345 2019-09-26T19:04:51  <MarcoFalke> What is the status of #14289 ?
346 2019-09-26T19:04:53  <gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
347 2019-09-26T19:04:54  <wumpus> #topic 0.19 open issues
348 2019-09-26T19:05:17  <MarcoFalke> Something has been addressed and I am not sure what still remains to be fixed
349 2019-09-26T19:05:39  *** captjakk has quit IRC
350 2019-09-26T19:05:53  <wumpus> I don't know either
351 2019-09-26T19:06:13  *** promag has quit IRC
352 2019-09-26T19:06:14  <BlueMatt> #16849 needs review
353 2019-09-26T19:06:15  <gribble> https://github.com/bitcoin/bitcoin/issues/16849 | Fix block index inconsistency in InvalidateBlock() by sdaftuar · Pull Request #16849 · bitcoin/bitcoin · GitHub
354 2019-09-26T19:06:20  <MarcoFalke> Then moving it to another milestone won't help. I'd say close it
355 2019-09-26T19:06:44  <sdaftuar> i'm not aware of any current scheduler queue problems, though i think there are code improvements some have been discussing to ensure no new problems develop? not sure
356 2019-09-26T19:06:50  <BlueMatt> I dont see whay #14289 is on 0.19 - it seems the issue isn't specific anyway?
357 2019-09-26T19:06:52  <gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
358 2019-09-26T19:07:13  <wumpus> BlueMatt: MarcoFalke  let's just remoe the milestone
359 2019-09-26T19:07:36  <sdaftuar> re: #16849, i'm curious to get other opinions about what the best fix is
360 2019-09-26T19:07:37  <BlueMatt> right, long-term I think #16323 "solves" the issue wholesale (and other locking/scheduling/queue concerns)
361 2019-09-26T19:07:38  <gribble> https://github.com/bitcoin/bitcoin/issues/16849 | Fix block index inconsistency in InvalidateBlock() by sdaftuar · Pull Request #16849 · bitcoin/bitcoin · GitHub
362 2019-09-26T19:07:38  <wumpus> it's a long term improvement aim, not something that needs to be solved before a certain version
363 2019-09-26T19:07:40  <gribble> https://github.com/bitcoin/bitcoin/issues/16323 | Call ProcessNewBlock() asynchronously by TheBlueMatt · Pull Request #16323 · bitcoin/bitcoin · GitHub
364 2019-09-26T19:07:40  <provoostenator> The  scheduler queue thing's worst symptom has been fixed a while ago
365 2019-09-26T19:07:42  <BlueMatt> but its *definitely* not an 0.19 thing
366 2019-09-26T19:07:44  <MarcoFalke> I'd rather not do #16849  for 0.19. Seems to risky for a validation change that has effects only tests
367 2019-09-26T19:07:46  <gribble> https://github.com/bitcoin/bitcoin/issues/16849 | Fix block index inconsistency in InvalidateBlock() by sdaftuar · Pull Request #16849 · bitcoin/bitcoin · GitHub
368 2019-09-26T19:08:36  <sdaftuar> MarcoFalke: only invalidateblock is affected, right? i think it's defensively written.  however it may be an unnecessary fix altogether imo
369 2019-09-26T19:08:37  <BlueMatt> I mean its lower-risk than it appears
370 2019-09-26T19:08:53  <sdaftuar> the bug is essentially non-observable
371 2019-09-26T19:08:56  <BlueMatt> adding extra crap to setBlockIndexCandidates just makes things slower, not broken
372 2019-09-26T19:09:13  <BlueMatt> though of course it could have some other classes of bugs
373 2019-09-26T19:09:32  <sdaftuar> agreed :)
374 2019-09-26T19:09:57  <BlueMatt> not for 19, either, but invalidateblock is also broken in other ways - see #16856
375 2019-09-26T19:09:58  <gribble> https://github.com/bitcoin/bitcoin/issues/16856 | Do not allow descendants of BLOCK_FAILED_VALID blocks to be BLOCK_FAILED_VALID by TheBlueMatt · Pull Request #16856 · bitcoin/bitcoin · GitHub
376 2019-09-26T19:09:59  <sdaftuar> anyway i mostly want people to chime in on whether we should even bother fixing the "bug"
377 2019-09-26T19:10:29  <MarcoFalke> #16713 is easier to review. I am going to merge that after one more ACK
378 2019-09-26T19:10:31  <gribble> https://github.com/bitcoin/bitcoin/issues/16713 | Ignore old versionbit activations to avoid unknown softforks warning by jnewbery · Pull Request #16713 · bitcoin/bitcoin · GitHub
379 2019-09-26T19:10:52  *** Evel-Knievel has quit IRC
380 2019-09-26T19:11:20  <BlueMatt> MarcoFalke: concept ack
381 2019-09-26T19:11:24  <BlueMatt> does that count? :P
382 2019-09-26T19:11:30  <wumpus> what about #16072?
383 2019-09-26T19:11:31  <gribble> https://github.com/bitcoin/bitcoin/issues/16072 | sendtoaddress ignores conf_target (spending whole UTxO with subtractfeefromamount=true) · Issue #16072 · bitcoin/bitcoin · GitHub
384 2019-09-26T19:11:51  <wumpus> it looks like we don't have tests for sendtoaddress with a conf_target at all, so can't be sure it works
385 2019-09-26T19:11:53  <instagibbs> ooooof
386 2019-09-26T19:13:05  <wumpus> MarcoFalke: we defeinitely need to merge one of the versionbits warning fixes
387 2019-09-26T19:13:42  <MarcoFalke> jup, this is a bug
388 2019-09-26T19:14:17  <instagibbs> wumpus, I can dig into that sendtoaddress report later today if you'd like and see what i can find
389 2019-09-26T19:14:37  <wumpus> instagibbs: thanks!
390 2019-09-26T19:14:56  <instagibbs> 3 hour train ride should find some time...
391 2019-09-26T19:15:36  <wumpus> what about #16418?
392 2019-09-26T19:15:37  <gribble> https://github.com/bitcoin/bitcoin/issues/16418 | Ensure we have sufficient transaction-relay peers · Issue #16418 · bitcoin/bitcoin · GitHub
393 2019-09-26T19:17:26  <wumpus> it doesn't have an associated PR yet, so it's a bit late
394 2019-09-26T19:17:38  <MarcoFalke> It is mostly brainstorming
395 2019-09-26T19:17:43  <MarcoFalke> Not tied to a release
396 2019-09-26T19:17:50  <wumpus> ok, remove or bump the milestone?
397 2019-09-26T19:17:58  <MarcoFalke> but pointing to an actual (long-term) problem
398 2019-09-26T19:18:03  <MarcoFalke> remove
399 2019-09-26T19:18:05  <MarcoFalke> ? sdaftuar
400 2019-09-26T19:18:18  <wumpus> yes, it's an actual problem
401 2019-09-26T19:18:53  <wumpus> but we're triaging what has to be done for 0.19, not in general
402 2019-09-26T19:19:06  <wumpus> removed the milestone for now, eel free to add a different one
403 2019-09-26T19:19:13  <wumpus> then there's #16485
404 2019-09-26T19:19:15  <gribble> https://github.com/bitcoin/bitcoin/issues/16485 | bumpfee.TotalFee removed without replacement · Issue #16485 · bitcoin/bitcoin · GitHub
405 2019-09-26T19:19:41  <MarcoFalke> instagibbs has a fix, but it hasn't received any review
406 2019-09-26T19:19:41  <wumpus> oh that does have a PR, #16727
407 2019-09-26T19:19:43  <gribble> https://github.com/bitcoin/bitcoin/issues/16727 | wallet: Explicit feerate for bumpfee by instagibbs · Pull Request #16727 · bitcoin/bitcoin · GitHub
408 2019-09-26T19:19:56  <provoostenator> ^ I'll give that a review
409 2019-09-26T19:20:02  <wumpus> we should try to get that in
410 2019-09-26T19:20:14  <instagibbs> thanks, the original contributor ghosted, which is why it was a bit late
411 2019-09-26T19:20:30  <provoostenator> Initially I was hoping to get kallewoof's thing in first for an easier syntax, but that can wait
412 2019-09-26T19:20:50  <instagibbs> provoostenator, was more controversial than I'd hoped tbh
413 2019-09-26T19:20:59  <MarcoFalke> signet?
414 2019-09-26T19:21:03  <provoostenator> #11413
415 2019-09-26T19:21:05  <gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
416 2019-09-26T19:21:17  <instagibbs> the string args for sat/kB etc
417 2019-09-26T19:21:23  <provoostenator> ^ At this point it's better to punt that to 0.20
418 2019-09-26T19:21:24  <wumpus> that's really a feature
419 2019-09-26T19:21:54  <instagibbs> orthogonal too, we can always augment 16727
420 2019-09-26T19:21:58  <instagibbs> later
421 2019-09-26T19:22:07  <provoostenator> Indeed
422 2019-09-26T19:23:21  <wumpus> then there's #16950 (and fix PR #16952)
423 2019-09-26T19:23:21  <gribble> https://github.com/bitcoin/bitcoin/issues/16950 | gui: crash trying to access info of a removed transaction · Issue #16950 · bitcoin/bitcoin · GitHub
424 2019-09-26T19:23:23  <gribble> https://github.com/bitcoin/bitcoin/issues/16952 | gui: make sure to update the UI when deleting a transaction by jonasschnelli · Pull Request #16952 · bitcoin/bitcoin · GitHub
425 2019-09-26T19:23:30  <instagibbs> also a bug, not a *new* one but it's gotten a bunch of review already: #16507
426 2019-09-26T19:23:32  <gribble> https://github.com/bitcoin/bitcoin/issues/16507 | feefilter: Compute the absolute fee rather than stored rate by instagibbs · Pull Request #16507 · bitcoin/bitcoin · GitHub
427 2019-09-26T19:23:47  <wumpus> looks like a simple change, but there's some questions if it solves the whole problem
428 2019-09-26T19:24:19  <jonasschnelli> I'd like to address promags point in 16952
429 2019-09-26T19:24:22  <jonasschnelli> So not ready yet but soon
430 2019-09-26T19:24:23  <wumpus> let's keep discussion to what is already tagged with the milestone for now
431 2019-09-26T19:24:35  <instagibbs> apologies
432 2019-09-26T19:24:53  <wumpus> instagibbs: would be nice to get it in, sure
433 2019-09-26T19:25:01  <wumpus> jonasschnelli: ok!
434 2019-09-26T19:26:04  <wumpus> then we have #16939, which is tagged 0.19, but fixes an issue (#15434) that is not tagged 0.19
435 2019-09-26T19:26:05  <gribble> https://github.com/bitcoin/bitcoin/issues/16939 | p2p: Delay querying DNS seeds if addrman is populated by ajtowns · Pull Request #16939 · bitcoin/bitcoin · GitHub
436 2019-09-26T19:26:06  <gribble> https://github.com/bitcoin/bitcoin/issues/15434 | Querying DNS seeds too frequently · Issue #15434 · bitcoin/bitcoin · GitHub
437 2019-09-26T19:26:34  *** ghost43 has quit IRC
438 2019-09-26T19:26:36  <MarcoFalke> not a regression bugfix, right
439 2019-09-26T19:26:44  <MarcoFalke> Seems like a feature
440 2019-09-26T19:26:47  <wumpus> it's mostly a "query DNS seeds to often" annoyance, not really a bug
441 2019-09-26T19:26:52  <MarcoFalke> yeah
442 2019-09-26T19:26:54  *** ghost43 has joined #bitcoin-core-dev
443 2019-09-26T19:27:22  <wumpus> removing it from the milestone
444 2019-09-26T19:28:13  <wumpus> #16936 is only a test change and should be ready to go after the linter changes are removed from it
445 2019-09-26T19:28:15  <gribble> https://github.com/bitcoin/bitcoin/issues/16936 | qa: Fix service flag comparison check in rpc_net test by luke-jr · Pull Request #16936 · bitcoin/bitcoin · GitHub
446 2019-09-26T19:29:09  <wumpus> #16817 is just a simple argument casing change so no worries it can go in
447 2019-09-26T19:29:10  <gribble> https://github.com/bitcoin/bitcoin/issues/16817 | rpc: Fix casing in getblockchaininfo to be inline with other fields by dangershony · Pull Request #16817 · bitcoin/bitcoin · GitHub
448 2019-09-26T19:29:47  <wumpus> (but it's critical that it gets into 0.19, because otherwise there will be version incompatiblity)
449 2019-09-26T19:30:37  <MarcoFalke> next topic?
450 2019-09-26T19:30:46  <wumpus> #16689 is a help only change, would be nice to have it in but not necessary
451 2019-09-26T19:30:48  <gribble> https://github.com/bitcoin/bitcoin/issues/16689 | rpc: add missing fields to wallet rpc help output by ariard · Pull Request #16689 · bitcoin/bitcoin · GitHub
452 2019-09-26T19:30:53  <wumpus> I think that covered them all
453 2019-09-26T19:30:59  <wumpus> sure, any other topics?
454 2019-09-26T19:31:08  *** elichai2 has joined #bitcoin-core-dev
455 2019-09-26T19:31:28  <wumpus> I don't think we need to do "high priority for review"
456 2019-09-26T19:31:39  *** promag has joined #bitcoin-core-dev
457 2019-09-26T19:31:49  <wumpus> oh we had a topic from last time: proposed by instagibbs: what to do with change output creation with bech32-default Core wallets: https://github.com/bitcoin/bitcoin/issues/15560#issuecomment-531796601
458 2019-09-26T19:32:08  <wumpus> #topic what to do with change output creation with bech32-default Core wallets
459 2019-09-26T19:33:01  <instagibbs> uhhh nothing new on that front :)
460 2019-09-26T19:33:12  <achow101> what would be different from setting -addresstype=bech32 today?
461 2019-09-26T19:33:12  <wumpus> maybe there's someone interested in discussing it this week
462 2019-09-26T19:33:20  <wumpus> last week, there weren't many people
463 2019-09-26T19:34:24  <instagibbs> achow101, the main change I was curious about was if someone specifies p2sh-wrapped for address, should we try to match bech32 change
464 2019-09-26T19:34:37  <instagibbs> that's historical behavior that my PR is changing
465 2019-09-26T19:34:42  <instagibbs> via https://github.com/bitcoin/bitcoin/pull/16884/commits/f069b9bf55936d3793406f2ab1af107a6e1a40c4
466 2019-09-26T19:35:21  <achow101> the mimicking behavior was for privacy so it's slightly less obvious which address is change
467 2019-09-26T19:35:36  <instagibbs> privacy + small discount
468 2019-09-26T19:36:22  <instagibbs> so the q is should someone asking for p2sh-wrapped be given that "discount and privacy", or should we just respect the choice
469 2019-09-26T19:36:37  <instagibbs> since everyone else will be running bech32
470 2019-09-26T19:37:02  <wumpus> but not immediately
471 2019-09-26T19:37:27  <achow101> I would prefer to keep the match the outgoing address type behavior
472 2019-09-26T19:37:27  <wumpus> and only bitcoin core changes the default here, not every other wallet
473 2019-09-26T19:37:31  <instagibbs> well if people are -1 on it I can remove it and fix tests
474 2019-09-26T19:37:47  <wumpus> instagibbs: I think it makes sense to split it off from the default change itself
475 2019-09-26T19:37:54  *** Sentineo has quit IRC
476 2019-09-26T19:37:59  <instagibbs> changing tests twice :P
477 2019-09-26T19:38:13  <instagibbs> I can remove it
478 2019-09-26T19:38:41  <wumpus> ok!
479 2019-09-26T19:38:54  <instagibbs> unless I run into a reason I'd forgotten, then we can continue in-thread
480 2019-09-26T19:38:56  <instagibbs> thanks!
481 2019-09-26T19:39:02  <wumpus> any other topics?
482 2019-09-26T19:39:46  <wumpus> ok, please use the remaining 20 minutes to review PRs for 0.19 then :<
483 2019-09-26T19:39:49  <wumpus> #endmeeting
484 2019-09-26T19:39:49  <lightningbot> Meeting ended Thu Sep 26 19:39:49 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
485 2019-09-26T19:39:49  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-26-19.00.html
486 2019-09-26T19:39:49  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-26-19.00.txt
487 2019-09-26T19:39:49  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-09-26-19.00.log.html
488 2019-09-26T19:46:13  <promag> hi..
489 2019-09-26T19:47:06  <BlueMatt> bad timezone conversion?
490 2019-09-26T19:47:28  *** hhhhhhhhhhh has quit IRC
491 2019-09-26T19:49:20  <BlueMatt> oh, just a random note in case anyone's interested: been playing with the theme of censorship detection/resistance in core - both isp-level cenorship, erebus attacks, other types of eclipse attacks etc - hence the sync-over-clourdlare and headers-over-dns patches, but that kinda spawned the rust framework for low-review-required ways to add backup chain sync mechanisms....the latest being headers-over-cheap-1-10km radio links:
492 2019-09-26T19:49:20  <BlueMatt> https://github.com/TheBlueMatt/bitcoin/commit/2019-09-rusty-lora-headers
493 2019-09-26T19:49:44  <BlueMatt> in case anyone is curious about work in that direction :)
494 2019-09-26T19:49:52  <jeremyrubin> that's super cool
495 2019-09-26T19:50:54  <jonatack> wumpus: wrt #16689 ariard (the author) is on vacation until the end of this week, can pick it up if next week is too late
496 2019-09-26T19:50:56  <gribble> https://github.com/bitcoin/bitcoin/issues/16689 | rpc: add missing fields to wallet rpc help output by ariard · Pull Request #16689 · bitcoin/bitcoin · GitHub
497 2019-09-26T19:51:35  <wumpus> BlueMatt: very cool, what device are you using for that?
498 2019-09-26T19:51:59  <BlueMatt> wumpus: https://unsigned.io/projects/rnode/ but that device is essentially just a 1$ lora modem chip and a serial adapter
499 2019-09-26T19:52:05  <BlueMatt> in a reasonable package
500 2019-09-26T19:52:15  <promag> BlueMatt: just bad timing
501 2019-09-26T19:52:56  <wumpus> jonatack: well the split-off is Oct 1, would be nice to have it in before that at least
502 2019-09-26T19:53:52  *** kristapsk has joined #bitcoin-core-dev
503 2019-09-26T19:54:34  <BlueMatt> wumpus: errrr, the particular chip in that one is $8, but there are also $1 LORA modems
504 2019-09-26T19:54:38  <jonatack> wumpus: ok
505 2019-09-26T19:58:41  *** Bullitje has left #bitcoin-core-dev
506 2019-09-26T19:59:16  *** Bullit has joined #bitcoin-core-dev
507 2019-09-26T20:06:41  <wumpus> BlueMatt: looks like interesting hardware nevertheless
508 2019-09-26T20:07:25  *** echonaut has quit IRC
509 2019-09-26T20:07:38  *** echonaut has joined #bitcoin-core-dev
510 2019-09-26T20:07:47  <BlueMatt> indeed, and reasonable enough pricing for like joe shmoe getting these things built and shipping them with a open source firmware that seems to be pretty stable
511 2019-09-26T20:08:22  *** Madars has quit IRC
512 2019-09-26T20:12:28  *** IGHOR has joined #bitcoin-core-dev
513 2019-09-26T20:17:27  <instagibbs> wumpus, can't seem to replicate the fee issue
514 2019-09-26T20:17:29  *** mdunnio has quit IRC
515 2019-09-26T20:21:53  <instagibbs> we only have one test that modifies the conf_target results really, might be good to stick a test in there anyways
516 2019-09-26T20:25:24  *** mdunnio has joined #bitcoin-core-dev
517 2019-09-26T20:25:39  <fanquake>  BlueMatt cool
518 2019-09-26T20:26:14  *** promag has quit IRC
519 2019-09-26T20:28:19  <wumpus> instagibbs: thanks for trying anyhow, it's possible that there are some other circumstances to trigger it then
520 2019-09-26T20:33:32  *** promag has joined #bitcoin-core-dev
521 2019-09-26T20:33:35  *** IGHOR has quit IRC
522 2019-09-26T20:34:56  *** Madars has joined #bitcoin-core-dev
523 2019-09-26T20:37:35  *** IGHOR has joined #bitcoin-core-dev
524 2019-09-26T20:42:01  *** xzytrewq has joined #bitcoin-core-dev
525 2019-09-26T20:51:37  *** owowo has quit IRC
526 2019-09-26T20:56:12  *** owowo has joined #bitcoin-core-dev
527 2019-09-26T20:57:28  *** bitcoin-git has joined #bitcoin-core-dev
528 2019-09-26T20:57:28  <bitcoin-git> [bitcoin] instagibbs opened pull request #16972: Add test for sendtoaddress conf_target under subtractfromamount scenario (master...sendtoaddr_conftarget_test) https://github.com/bitcoin/bitcoin/pull/16972
529 2019-09-26T20:57:29  *** bitcoin-git has left #bitcoin-core-dev
530 2019-09-26T21:00:02  *** Guest35726 has quit IRC
531 2019-09-26T21:03:13  *** Guyver2 has quit IRC
532 2019-09-26T21:10:47  *** cryptapus has quit IRC
533 2019-09-26T21:13:35  *** bitcoin-git has joined #bitcoin-core-dev
534 2019-09-26T21:13:35  <bitcoin-git> [bitcoin] mzumsande opened pull request #16973: test: Fix combine_logs.py for AppVeyor build (master...201909_test_pathsep) https://github.com/bitcoin/bitcoin/pull/16973
535 2019-09-26T21:13:36  *** bitcoin-git has left #bitcoin-core-dev
536 2019-09-26T21:17:14  *** oniijin has joined #bitcoin-core-dev
537 2019-09-26T21:28:29  *** cryptapus has joined #bitcoin-core-dev
538 2019-09-26T21:33:10  *** captjakk has joined #bitcoin-core-dev
539 2019-09-26T21:36:46  *** xzytrewq has quit IRC
540 2019-09-26T21:39:00  *** Chris_Stewart_5 has quit IRC
541 2019-09-26T21:43:27  *** mdunnio has quit IRC
542 2019-09-26T21:44:27  *** rex4539 has quit IRC
543 2019-09-26T21:44:40  *** captjakk has quit IRC
544 2019-09-26T21:44:54  *** captjakk has joined #bitcoin-core-dev
545 2019-09-26T21:45:37  *** captjakk has joined #bitcoin-core-dev
546 2019-09-26T21:46:25  *** captjakk has joined #bitcoin-core-dev
547 2019-09-26T21:47:00  *** captjakk has quit IRC
548 2019-09-26T21:47:12  *** captjakk has joined #bitcoin-core-dev
549 2019-09-26T21:47:57  *** captjakk has joined #bitcoin-core-dev
550 2019-09-26T21:51:09  *** xzytrewq has joined #bitcoin-core-dev
551 2019-09-26T21:52:03  *** mdunnio has joined #bitcoin-core-dev
552 2019-09-26T22:16:33  *** mdunnio has quit IRC
553 2019-09-26T22:19:15  *** bitcoin-git has joined #bitcoin-core-dev
554 2019-09-26T22:19:15  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16974: Walk pindexBestHeader back to ChainActive().Tip() if it is invalid (master...2019-09-better-header-knowledge) https://github.com/bitcoin/bitcoin/pull/16974
555 2019-09-26T22:19:16  *** bitcoin-git has left #bitcoin-core-dev
556 2019-09-26T22:19:55  *** bitcoin-git has joined #bitcoin-core-dev
557 2019-09-26T22:19:55  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16896: test: replaced hard coded folders with os.path.join & replaced os.path.sep (master...patch-seperator) https://github.com/bitcoin/bitcoin/pull/16896
558 2019-09-26T22:19:56  *** bitcoin-git has left #bitcoin-core-dev
559 2019-09-26T22:24:27  *** Honthe has quit IRC
560 2019-09-26T22:26:48  *** promag_ has joined #bitcoin-core-dev
561 2019-09-26T22:32:44  *** promag_ has quit IRC
562 2019-09-26T22:37:40  *** jarthur_ has joined #bitcoin-core-dev
563 2019-09-26T22:41:17  *** jarthur has quit IRC
564 2019-09-26T22:41:57  *** jarthur_ has quit IRC
565 2019-09-26T22:47:41  *** Zenton has quit IRC
566 2019-09-26T22:55:39  *** marcoagner has quit IRC
567 2019-09-26T23:28:41  *** setpill has quit IRC
568 2019-09-26T23:29:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
569 2019-09-26T23:30:38  *** promag has quit IRC