1 2019-10-04T00:00:02  *** WhereIsMySpoon has quit IRC
  2 2019-10-04T00:02:42  *** promag has joined #bitcoin-core-dev
  3 2019-10-04T00:06:57  *** promag has quit IRC
  4 2019-10-04T00:11:28  *** lightlike has quit IRC
  5 2019-10-04T00:25:48  *** promag has joined #bitcoin-core-dev
  6 2019-10-04T00:27:39  *** AaronvanW has quit IRC
  7 2019-10-04T00:30:35  *** promag has quit IRC
  8 2019-10-04T00:44:44  *** wm4 has joined #bitcoin-core-dev
  9 2019-10-04T00:45:39  *** arik_ has quit IRC
 10 2019-10-04T00:58:17  *** jkczyz has quit IRC
 11 2019-10-04T01:11:42  *** spinza has quit IRC
 12 2019-10-04T01:13:20  *** spinza has joined #bitcoin-core-dev
 13 2019-10-04T01:15:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 14 2019-10-04T01:20:38  *** Ox207fffff has quit IRC
 15 2019-10-04T01:29:03  *** justinmoon has quit IRC
 16 2019-10-04T01:30:02  *** wm4 has quit IRC
 17 2019-10-04T01:30:19  *** justinmoon has joined #bitcoin-core-dev
 18 2019-10-04T01:30:27  *** davec has quit IRC
 19 2019-10-04T01:30:27  *** phantomcircuit has quit IRC
 20 2019-10-04T01:31:17  *** roasbeef has quit IRC
 21 2019-10-04T01:31:28  *** davec has joined #bitcoin-core-dev
 22 2019-10-04T01:31:56  *** roasbeef has joined #bitcoin-core-dev
 23 2019-10-04T01:32:11  *** phantomcircuit has joined #bitcoin-core-dev
 24 2019-10-04T01:41:33  *** Usurp1 has joined #bitcoin-core-dev
 25 2019-10-04T02:05:41  *** emilengler_ has joined #bitcoin-core-dev
 26 2019-10-04T02:09:08  *** emilengler_ has quit IRC
 27 2019-10-04T02:09:15  *** emilengler has quit IRC
 28 2019-10-04T02:10:05  *** emilengler has joined #bitcoin-core-dev
 29 2019-10-04T02:20:36  *** rhavar_ has quit IRC
 30 2019-10-04T02:25:01  *** AaronvanW has joined #bitcoin-core-dev
 31 2019-10-04T02:29:32  *** Chris_Stewart_5 has quit IRC
 32 2019-10-04T02:35:38  *** cryptoIndio has joined #bitcoin-core-dev
 33 2019-10-04T02:40:03  *** cryptoIndio has quit IRC
 34 2019-10-04T02:47:14  *** fox2p_ has joined #bitcoin-core-dev
 35 2019-10-04T02:50:02  *** fox2p has quit IRC
 36 2019-10-04T02:57:15  *** AaronvanW has quit IRC
 37 2019-10-04T02:58:17  *** Highway61 has quit IRC
 38 2019-10-04T03:00:02  *** Usurp1 has quit IRC
 39 2019-10-04T03:05:52  *** promag has joined #bitcoin-core-dev
 40 2019-10-04T03:09:57  *** promag has quit IRC
 41 2019-10-04T03:17:51  *** Jarsto1 has joined #bitcoin-core-dev
 42 2019-10-04T03:19:01  *** promag has joined #bitcoin-core-dev
 43 2019-10-04T03:20:23  *** cryptoIndio has joined #bitcoin-core-dev
 44 2019-10-04T03:23:05  *** cryptoIndio has joined #bitcoin-core-dev
 45 2019-10-04T03:23:29  *** promag has quit IRC
 46 2019-10-04T03:26:32  *** m1rror8955363 has joined #bitcoin-core-dev
 47 2019-10-04T03:27:23  *** m1rror895536 has quit IRC
 48 2019-10-04T03:38:16  *** Eagle[TM] has joined #bitcoin-core-dev
 49 2019-10-04T03:40:17  *** EagleTM has quit IRC
 50 2019-10-04T03:42:13  *** cryptoIndio has quit IRC
 51 2019-10-04T03:42:49  *** cryptoIndio has joined #bitcoin-core-dev
 52 2019-10-04T03:42:50  *** alko has joined #bitcoin-core-dev
 53 2019-10-04T03:45:37  *** alko89 has quit IRC
 54 2019-10-04T03:47:39  *** cryptoIndio has quit IRC
 55 2019-10-04T04:01:11  *** nejon has quit IRC
 56 2019-10-04T04:20:03  *** promag has joined #bitcoin-core-dev
 57 2019-10-04T04:24:17  *** promag has quit IRC
 58 2019-10-04T04:29:49  *** cryptoIndio has joined #bitcoin-core-dev
 59 2019-10-04T04:31:44  *** Victor_sueca has joined #bitcoin-core-dev
 60 2019-10-04T04:34:46  *** Victorsueca has quit IRC
 61 2019-10-04T04:37:49  *** funtimer has joined #bitcoin-core-dev
 62 2019-10-04T04:42:08  *** funtimer has quit IRC
 63 2019-10-04T04:55:21  *** AaronvanW has joined #bitcoin-core-dev
 64 2019-10-04T05:16:48  *** m1rror89553638 has joined #bitcoin-core-dev
 65 2019-10-04T05:16:51  *** ajonas has quit IRC
 66 2019-10-04T05:18:27  *** m1rror8955363 has quit IRC
 67 2019-10-04T05:19:19  *** jkczyz has joined #bitcoin-core-dev
 68 2019-10-04T05:21:54  *** m1rror89553638 has quit IRC
 69 2019-10-04T05:22:56  *** m1rror89553638 has joined #bitcoin-core-dev
 70 2019-10-04T05:25:50  *** tryphe has quit IRC
 71 2019-10-04T05:26:14  *** tryphe has joined #bitcoin-core-dev
 72 2019-10-04T05:28:27  *** AaronvanW has quit IRC
 73 2019-10-04T05:30:17  *** m1rror895536388 has joined #bitcoin-core-dev
 74 2019-10-04T05:32:03  *** m1rror89553638 has quit IRC
 75 2019-10-04T05:34:37  *** shesek has quit IRC
 76 2019-10-04T05:35:01  *** shesek has joined #bitcoin-core-dev
 77 2019-10-04T05:39:22  *** m1rror8955363887 has joined #bitcoin-core-dev
 78 2019-10-04T05:41:10  *** m1rror895536388 has quit IRC
 79 2019-10-04T05:41:11  <wumpus> I don't think there's a reason to bump libevent, wide compatibility is good, we don't bump minimum dependency versions just for fun
 80 2019-10-04T05:46:15  <wumpus> fixing a bug like #15363 would be a valid reason, it's just that libevent's release schedule was a mess for a long time, there were lots of betas but never a new stable, so everyone tended up with the same old version ... don't know in how far that's still the case
 81 2019-10-04T05:46:17  <gribble> https://github.com/bitcoin/bitcoin/issues/15363 | wip: http: Exit the event loop as soon as there are no active events by promag · Pull Request #15363 · bitcoin/bitcoin · GitHub
 82 2019-10-04T05:51:02  *** AaronvanW has joined #bitcoin-core-dev
 83 2019-10-04T05:51:04  *** bitcoin-git has joined #bitcoin-core-dev
 84 2019-10-04T05:51:04  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/9fdaaecf4928...6db76c6bc7fe
 85 2019-10-04T05:51:05  <bitcoin-git> bitcoin/0.19 6db76c6 Wladimir J. van der Laan: qt: Periodic translations update
 86 2019-10-04T05:51:07  *** bitcoin-git has left #bitcoin-core-dev
 87 2019-10-04T05:51:39  *** promag has joined #bitcoin-core-dev
 88 2019-10-04T05:55:28  *** jkczyz has quit IRC
 89 2019-10-04T05:55:44  *** AaronvanW has quit IRC
 90 2019-10-04T05:56:02  *** promag has quit IRC
 91 2019-10-04T05:59:12  *** Highway61 has joined #bitcoin-core-dev
 92 2019-10-04T06:00:01  *** Jarsto1 has quit IRC
 93 2019-10-04T06:11:05  *** bitcoin-git has joined #bitcoin-core-dev
 94 2019-10-04T06:11:05  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/6db76c6bc7fe...cd1e7bb06431
 95 2019-10-04T06:11:05  <bitcoin-git> bitcoin/0.19 cd1e7bb Wladimir J. van der Laan: build: Fix boost detection on Ubuntu ARM 18.04
 96 2019-10-04T06:11:07  *** bitcoin-git has left #bitcoin-core-dev
 97 2019-10-04T06:11:42  *** Klox has quit IRC
 98 2019-10-04T06:18:37  *** IGHOR has quit IRC
 99 2019-10-04T06:22:37  *** jkczyz has joined #bitcoin-core-dev
100 2019-10-04T06:26:57  *** jkczyz has quit IRC
101 2019-10-04T06:28:18  *** face has joined #bitcoin-core-dev
102 2019-10-04T06:32:32  *** IGHOR has joined #bitcoin-core-dev
103 2019-10-04T06:38:52  <wumpus> ok, going to tag 0.19.0rc1 in a bit
104 2019-10-04T06:47:01  *** jackalope has joined #bitcoin-core-dev
105 2019-10-04T07:02:37  *** IGHOR has quit IRC
106 2019-10-04T07:02:51  *** rafalcpp has joined #bitcoin-core-dev
107 2019-10-04T07:03:24  *** rafalcpp_ has quit IRC
108 2019-10-04T07:05:36  *** IGHOR has joined #bitcoin-core-dev
109 2019-10-04T07:12:31  *** marcoagner has joined #bitcoin-core-dev
110 2019-10-04T07:14:28  *** jonatack has quit IRC
111 2019-10-04T07:16:27  *** BlueMatt has quit IRC
112 2019-10-04T07:16:40  *** BlueMatt has joined #bitcoin-core-dev
113 2019-10-04T07:20:42  *** CubicEarth has quit IRC
114 2019-10-04T07:30:08  *** belcher has joined #bitcoin-core-dev
115 2019-10-04T07:31:29  *** rex4539 has joined #bitcoin-core-dev
116 2019-10-04T07:38:29  *** AaronvanW has joined #bitcoin-core-dev
117 2019-10-04T07:41:40  *** CubicEarth has joined #bitcoin-core-dev
118 2019-10-04T07:41:48  *** CubicEarth has quit IRC
119 2019-10-04T07:42:27  *** CubicEarth has joined #bitcoin-core-dev
120 2019-10-04T07:42:37  *** Eagle[TM] has quit IRC
121 2019-10-04T07:56:28  *** rafalcpp has quit IRC
122 2019-10-04T07:56:39  *** rafalcpp has joined #bitcoin-core-dev
123 2019-10-04T08:06:28  *** jonatack has joined #bitcoin-core-dev
124 2019-10-04T08:14:27  *** jonatack has quit IRC
125 2019-10-04T08:16:40  *** jonatack has joined #bitcoin-core-dev
126 2019-10-04T08:23:29  *** jkczyz has joined #bitcoin-core-dev
127 2019-10-04T08:28:29  *** jkczyz has quit IRC
128 2019-10-04T08:44:02  <meshcollider> \o/
129 2019-10-04T08:45:08  *** Zenton has joined #bitcoin-core-dev
130 2019-10-04T08:49:34  *** promag has joined #bitcoin-core-dev
131 2019-10-04T08:56:26  *** rafalcpp_ has joined #bitcoin-core-dev
132 2019-10-04T08:56:28  *** rafalcpp has quit IRC
133 2019-10-04T08:59:56  *** promag has quit IRC
134 2019-10-04T09:00:02  *** jackalope has quit IRC
135 2019-10-04T09:00:11  *** m1rror8955363887 has quit IRC
136 2019-10-04T09:01:15  *** promag has joined #bitcoin-core-dev
137 2019-10-04T09:01:17  *** face has quit IRC
138 2019-10-04T09:02:45  *** face has joined #bitcoin-core-dev
139 2019-10-04T09:04:20  *** face has quit IRC
140 2019-10-04T09:11:59  *** ryanofsky has quit IRC
141 2019-10-04T09:13:39  *** ryanofsky has joined #bitcoin-core-dev
142 2019-10-04T09:14:52  *** promag has quit IRC
143 2019-10-04T09:15:07  *** promag has joined #bitcoin-core-dev
144 2019-10-04T09:15:41  *** landonf1 has joined #bitcoin-core-dev
145 2019-10-04T09:23:04  *** kcalvinalvin has joined #bitcoin-core-dev
146 2019-10-04T09:27:00  <wumpus> I've split the "needs backport" label per branch
147 2019-10-04T09:29:06  <wumpus> this separates it from "milestone" which is something different (e.g. something might be tagged for backport to a branch without targeting a specific release)
148 2019-10-04T09:37:19  <fanquake> wumpus \o/
149 2019-10-04T09:41:42  <fanquake> I think splitting makes sense. It was always a bit confusing when milestones could have multiple meanings
150 2019-10-04T10:03:42  *** cryptoIndio has quit IRC
151 2019-10-04T10:14:30  *** promag has quit IRC
152 2019-10-04T10:20:13  *** bitcoin-git has joined #bitcoin-core-dev
153 2019-10-04T10:20:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f1f284aa757d...8ddc30393121
154 2019-10-04T10:20:14  <bitcoin-git> bitcoin/master 3f89e1e João Barbosa: Prevent processing duplicate payment requests
155 2019-10-04T10:20:14  <bitcoin-git> bitcoin/master 8ddc303 fanquake: Merge #17031: gui: Prevent processing duplicate payment requests
156 2019-10-04T10:20:16  *** bitcoin-git has left #bitcoin-core-dev
157 2019-10-04T10:20:33  *** bitcoin-git has joined #bitcoin-core-dev
158 2019-10-04T10:20:33  <bitcoin-git> [bitcoin] fanquake merged pull request #17031: gui: Prevent processing duplicate payment requests (master...2019-10-fix-paymentserver) https://github.com/bitcoin/bitcoin/pull/17031
159 2019-10-04T10:20:34  *** bitcoin-git has left #bitcoin-core-dev
160 2019-10-04T10:24:26  *** jkczyz has joined #bitcoin-core-dev
161 2019-10-04T10:24:27  *** jonatack has quit IRC
162 2019-10-04T10:28:51  *** jkczyz has quit IRC
163 2019-10-04T10:51:11  *** bitcoin-git has joined #bitcoin-core-dev
164 2019-10-04T10:51:12  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8ddc30393121...94e6e9f38dee
165 2019-10-04T10:51:12  <bitcoin-git> bitcoin/master fab68a0 MarcoFalke: doc: move-only release notes fragments for 0.20.0
166 2019-10-04T10:51:13  <bitcoin-git> bitcoin/master fa8d052 MarcoFalke: doc: Update bips.md for default bech32 addresses in 0.20.0
167 2019-10-04T10:51:13  <bitcoin-git> bitcoin/master fad1dbd MarcoFalke: doc: Fix amount typo in release notes
168 2019-10-04T10:51:15  *** bitcoin-git has left #bitcoin-core-dev
169 2019-10-04T10:51:31  *** bitcoin-git has joined #bitcoin-core-dev
170 2019-10-04T10:51:31  <bitcoin-git> [bitcoin] fanquake merged pull request #17026: doc: Update bips.md for default bech32 addresses in 0.20.0 (master...1909-doc0.20Rel) https://github.com/bitcoin/bitcoin/pull/17026
171 2019-10-04T10:51:32  *** bitcoin-git has left #bitcoin-core-dev
172 2019-10-04T10:54:57  *** promag has joined #bitcoin-core-dev
173 2019-10-04T10:58:48  *** rafalcpp_ is now known as rafalcpp
174 2019-10-04T10:59:26  *** promag has quit IRC
175 2019-10-04T11:14:22  *** promag has joined #bitcoin-core-dev
176 2019-10-04T11:31:58  *** zivl has quit IRC
177 2019-10-04T11:41:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
178 2019-10-04T11:46:08  *** jonatack has joined #bitcoin-core-dev
179 2019-10-04T11:51:57  *** bitcoin-git has joined #bitcoin-core-dev
180 2019-10-04T11:51:57  <bitcoin-git> [bitcoin] GChuf opened pull request #17048: gui: add shortcuts for Options and Command-line options (master...shortcuts) https://github.com/bitcoin/bitcoin/pull/17048
181 2019-10-04T11:51:58  *** bitcoin-git has left #bitcoin-core-dev
182 2019-10-04T11:52:17  *** bitcoin-git has joined #bitcoin-core-dev
183 2019-10-04T11:52:17  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/cd1e7bb06431...bd22dea6331d
184 2019-10-04T11:52:18  <bitcoin-git> bitcoin/0.19 bd22dea João Barbosa: Prevent processing duplicate payment requests
185 2019-10-04T11:52:20  *** bitcoin-git has left #bitcoin-core-dev
186 2019-10-04T11:52:37  *** promag has quit IRC
187 2019-10-04T11:56:27  <wumpus> fanquake: exactly; it is quite rare to backport to the previous major release, but especially so close to a major release it's more common and it can get confusing
188 2019-10-04T12:00:02  *** landonf1 has quit IRC
189 2019-10-04T12:01:32  <wumpus> also, a bot could potentially automatically remove the "Needs backport" tag now when it detects a certain PR has been backported to that branch
190 2019-10-04T12:17:41  *** defnordic has joined #bitcoin-core-dev
191 2019-10-04T12:25:13  *** jkczyz has joined #bitcoin-core-dev
192 2019-10-04T12:30:04  *** jkczyz has quit IRC
193 2019-10-04T12:32:32  *** cubancorona has quit IRC
194 2019-10-04T12:32:57  *** jonatack has quit IRC
195 2019-10-04T12:35:36  *** jonatack has joined #bitcoin-core-dev
196 2019-10-04T12:40:00  *** bitcoin-git has joined #bitcoin-core-dev
197 2019-10-04T12:40:00  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17049: build: Release updates on master (take 2) (master...1909-prep20) https://github.com/bitcoin/bitcoin/pull/17049
198 2019-10-04T12:40:01  *** bitcoin-git has left #bitcoin-core-dev
199 2019-10-04T12:51:27  *** masterdonx2 has joined #bitcoin-core-dev
200 2019-10-04T12:53:33  *** MasterdonX has quit IRC
201 2019-10-04T12:56:14  *** masterdonx2 has quit IRC
202 2019-10-04T12:57:47  *** promag has joined #bitcoin-core-dev
203 2019-10-04T13:06:49  *** Aaronvan_ has joined #bitcoin-core-dev
204 2019-10-04T13:10:03  *** AaronvanW has quit IRC
205 2019-10-04T13:14:31  *** side^effects has joined #bitcoin-core-dev
206 2019-10-04T13:17:53  *** bitcoin-git has joined #bitcoin-core-dev
207 2019-10-04T13:17:53  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/bd22dea6331d...913972944b4f
208 2019-10-04T13:17:53  <bitcoin-git> bitcoin/0.19 9139729 Wladimir J. van der Laan: doc: Update manpages
209 2019-10-04T13:17:55  *** bitcoin-git has left #bitcoin-core-dev
210 2019-10-04T13:22:32  *** bitcoin-git has joined #bitcoin-core-dev
211 2019-10-04T13:22:32  <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.19.0rc1
212 2019-10-04T13:22:33  *** bitcoin-git has left #bitcoin-core-dev
213 2019-10-04T13:22:52  *** bitcoin-git has joined #bitcoin-core-dev
214 2019-10-04T13:22:52  <bitcoin-git> [bitcoin] practicalswift opened pull request #17050: tests: Add fuzzing harnesses for DecodeRawPSBT(...), ParseHDKeypath(...), ParseScript(...), various number parsing functions and various JSON/univalue parsing functions (master...fuzzers) https://github.com/bitcoin/bitcoin/pull/17050
215 2019-10-04T13:22:54  *** bitcoin-git has left #bitcoin-core-dev
216 2019-10-04T13:23:48  *** hebasto has joined #bitcoin-core-dev
217 2019-10-04T13:26:37  *** MasterdonX has joined #bitcoin-core-dev
218 2019-10-04T13:27:56  *** jonatack has quit IRC
219 2019-10-04T13:30:47  *** masterdonx2 has joined #bitcoin-core-dev
220 2019-10-04T13:32:32  *** MasterdonX has quit IRC
221 2019-10-04T13:33:41  *** nejon has joined #bitcoin-core-dev
222 2019-10-04T13:42:20  <hebasto> gitian-build.py fails for 0.19.0rc1; digging...
223 2019-10-04T13:42:46  <fanquake> hebasto what's the error?
224 2019-10-04T13:43:38  <MarcoFalke> hebasto: There is no tag yet
225 2019-10-04T13:43:48  <MarcoFalke> oh wait there is
226 2019-10-04T13:44:21  <MarcoFalke> [05:27] <wumpus> I've split the "needs backport" label per branch
227 2019-10-04T13:44:23  <MarcoFalke> thx ^
228 2019-10-04T13:45:12  <fanquake> MarcoFalke: In the ARM CI PR, have you been seeing the permissions errors the whole time?
229 2019-10-04T13:46:39  <MarcoFalke> Might be something with DOCKER_EXEC, as it is a bash function
230 2019-10-04T13:48:06  <hebasto> fanquake: line 245 subprocess.CalledProcessError: Command '['git', 'pull']' returned non-zero exit status 128.
231 2019-10-04T13:48:47  <MarcoFalke> I've seen some github git fetch timeouts yesterday
232 2019-10-04T13:49:16  <fanquake> hebasto: yea I'd just retry
233 2019-10-04T13:49:51  <hebasto> fanquake: nm; it was my own branch of gitian-builder; sorry
234 2019-10-04T14:05:09  *** funtimer has joined #bitcoin-core-dev
235 2019-10-04T14:15:10  *** SiAnDoG has joined #bitcoin-core-dev
236 2019-10-04T14:21:48  *** dognosewhiskers has joined #bitcoin-core-dev
237 2019-10-04T14:21:52  <dognosewhiskers> Bitcoin.conf has "proxy = 127.0.0.1:9150" but the GUI options doesn't have the checkboxes for the proxy settings checked.
238 2019-10-04T14:21:55  <dognosewhiskers> What gives?
239 2019-10-04T14:22:05  <dognosewhiskers> Is it using Tor or not?
240 2019-10-04T14:26:08  *** jkczyz has joined #bitcoin-core-dev
241 2019-10-04T14:30:24  *** side^effects has quit IRC
242 2019-10-04T14:30:43  *** jkczyz has quit IRC
243 2019-10-04T14:31:23  *** bitcoin-git has joined #bitcoin-core-dev
244 2019-10-04T14:31:23  <bitcoin-git> [bitcoin] practicalswift opened pull request #17051: tests: Add deserialization fuzzing harnesses (master...fuzzers-deserialize) https://github.com/bitcoin/bitcoin/pull/17051
245 2019-10-04T14:31:25  *** bitcoin-git has left #bitcoin-core-dev
246 2019-10-04T14:37:50  <dognosewhiskers> Anyone?
247 2019-10-04T14:41:40  <sdaftuar> dognosewhiskers: just a guess as i'm not very familiar with the gui, but i seem to recall there being some longstanding issues around qt preferences being stored/tracked differently from bitcoin.conf
248 2019-10-04T14:43:29  *** rafalcpp_ has joined #bitcoin-core-dev
249 2019-10-04T14:44:01  *** rafalcpp has quit IRC
250 2019-10-04T14:54:08  *** bitcoin-git has joined #bitcoin-core-dev
251 2019-10-04T14:54:08  <bitcoin-git> [bitcoin] GChuf opened pull request #17052: scripts: update copyright_header script to include additional files (master...copyright-header-script) https://github.com/bitcoin/bitcoin/pull/17052
252 2019-10-04T14:54:09  *** bitcoin-git has left #bitcoin-core-dev
253 2019-10-04T14:56:43  <dognosewhiskers> sdaftuar: Hmm! That is very scary/confusing!
254 2019-10-04T14:57:28  *** bitcoin-git has joined #bitcoin-core-dev
255 2019-10-04T14:57:28  <bitcoin-git> [bitcoin] GChuf opened pull request #17053: Update headers for v0.19 (0.19...update-headers-019) https://github.com/bitcoin/bitcoin/pull/17053
256 2019-10-04T14:57:29  *** bitcoin-git has left #bitcoin-core-dev
257 2019-10-04T14:58:28  *** rex4539 has quit IRC
258 2019-10-04T15:00:02  *** defnordic has quit IRC
259 2019-10-04T15:05:12  *** cubancorona has joined #bitcoin-core-dev
260 2019-10-04T15:07:41  *** kljasdfvv has quit IRC
261 2019-10-04T15:16:02  *** jarthur has joined #bitcoin-core-dev
262 2019-10-04T15:16:07  *** atomicturtle has joined #bitcoin-core-dev
263 2019-10-04T15:24:49  *** cryptapus has quit IRC
264 2019-10-04T15:29:43  *** cryptapus has joined #bitcoin-core-dev
265 2019-10-04T15:29:43  *** cryptapus has quit IRC
266 2019-10-04T15:29:43  *** cryptapus has joined #bitcoin-core-dev
267 2019-10-04T15:30:17  *** jkczyz has joined #bitcoin-core-dev
268 2019-10-04T15:38:38  *** Zenton has quit IRC
269 2019-10-04T15:40:17  *** captjakk has joined #bitcoin-core-dev
270 2019-10-04T15:42:50  *** Guyver2 has joined #bitcoin-core-dev
271 2019-10-04T15:44:06  *** promag has quit IRC
272 2019-10-04T15:45:34  *** rafalcpp_ is now known as rafalcpp
273 2019-10-04T15:48:57  *** jkczyz has quit IRC
274 2019-10-04T15:51:56  *** bitcoin-git has joined #bitcoin-core-dev
275 2019-10-04T15:51:56  <bitcoin-git> [bitcoin] fanquake closed pull request #17053: Update headers for v0.19 (0.19...update-headers-019) https://github.com/bitcoin/bitcoin/pull/17053
276 2019-10-04T15:52:07  *** bitcoin-git has left #bitcoin-core-dev
277 2019-10-04T16:00:15  *** promag has joined #bitcoin-core-dev
278 2019-10-04T16:05:13  *** promag has quit IRC
279 2019-10-04T16:13:26  *** Jackielove4u has quit IRC
280 2019-10-04T16:22:40  *** funtimer has quit IRC
281 2019-10-04T16:43:27  *** jkczyz has joined #bitcoin-core-dev
282 2019-10-04T16:44:02  *** lightlike has joined #bitcoin-core-dev
283 2019-10-04T16:52:41  *** fox2p has joined #bitcoin-core-dev
284 2019-10-04T16:54:22  *** fox2p_ has quit IRC
285 2019-10-04T17:04:46  *** promag has joined #bitcoin-core-dev
286 2019-10-04T17:14:47  *** promag has quit IRC
287 2019-10-04T17:17:27  *** Chris_Stewart_5 has quit IRC
288 2019-10-04T17:27:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
289 2019-10-04T17:34:43  *** arik_ has joined #bitcoin-core-dev
290 2019-10-04T17:35:04  *** jkczyz has quit IRC
291 2019-10-04T17:39:14  *** jkczyz has joined #bitcoin-core-dev
292 2019-10-04T17:47:16  *** bitcoin-git has joined #bitcoin-core-dev
293 2019-10-04T17:47:16  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/94e6e9f38dee...94d6a18f23ec
294 2019-10-04T17:47:17  <bitcoin-git> bitcoin/master 8e59af5 Gregory Sanders: feefilter: Compute the absolute fee rather than stored rate to match mempo...
295 2019-10-04T17:47:17  <bitcoin-git> bitcoin/master 6a51f79 Gregory Sanders: Disallow implicit conversion for CFeeRate constructor
296 2019-10-04T17:47:18  <bitcoin-git> bitcoin/master eb7b781 Gregory Sanders: modify p2p_feefilter test to catch rounding error
297 2019-10-04T17:47:24  *** rockhouse has quit IRC
298 2019-10-04T17:47:25  *** victorSN has quit IRC
299 2019-10-04T17:47:27  *** bitcoin-git has left #bitcoin-core-dev
300 2019-10-04T17:47:44  *** rockhouse has joined #bitcoin-core-dev
301 2019-10-04T17:47:46  *** bitcoin-git has joined #bitcoin-core-dev
302 2019-10-04T17:47:46  <bitcoin-git> [bitcoin] fanquake merged pull request #16507: feefilter: Compute the absolute fee rather than stored rate (master...feefilter_match_mempool) https://github.com/bitcoin/bitcoin/pull/16507
303 2019-10-04T17:47:57  *** bitcoin-git has left #bitcoin-core-dev
304 2019-10-04T17:57:12  *** dognosewhiskers has left #bitcoin-core-dev
305 2019-10-04T17:57:16  *** rafalcpp_ has joined #bitcoin-core-dev
306 2019-10-04T17:57:37  *** rafalcpp has quit IRC
307 2019-10-04T18:00:01  *** atomicturtle has quit IRC
308 2019-10-04T18:17:30  *** lcb has joined #bitcoin-core-dev
309 2019-10-04T18:24:28  *** bitcoin-git has joined #bitcoin-core-dev
310 2019-10-04T18:24:28  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94d6a18f23ec...917d3d9052b5
311 2019-10-04T18:24:29  <bitcoin-git> bitcoin/master dffae5a gchuf: scripts: update copyright_header script to include additional files
312 2019-10-04T18:24:30  <bitcoin-git> bitcoin/master 917d3d9 fanquake: Merge #17052: scripts: update copyright_header script to include additiona...
313 2019-10-04T18:24:40  *** bitcoin-git has left #bitcoin-core-dev
314 2019-10-04T18:24:58  *** bitcoin-git has joined #bitcoin-core-dev
315 2019-10-04T18:24:58  <bitcoin-git> [bitcoin] fanquake merged pull request #17052: scripts: update copyright_header script to include additional files (master...copyright-header-script) https://github.com/bitcoin/bitcoin/pull/17052
316 2019-10-04T18:24:59  *** bitcoin-git has left #bitcoin-core-dev
317 2019-10-04T18:26:45  *** promag has joined #bitcoin-core-dev
318 2019-10-04T18:30:57  *** promag has quit IRC
319 2019-10-04T18:34:36  *** Jackielove4u has joined #bitcoin-core-dev
320 2019-10-04T18:40:32  *** bitcoin-git has joined #bitcoin-core-dev
321 2019-10-04T18:40:32  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/917d3d9052b5...7b701fef58f6
322 2019-10-04T18:40:33  <bitcoin-git> bitcoin/master fa1ad8f MarcoFalke: build: Bump gitian descriptor versions
323 2019-10-04T18:40:33  <bitcoin-git> bitcoin/master 7b701fe fanquake: Merge #17049: contrib: Bump gitian descriptors for 0.20
324 2019-10-04T18:40:35  *** bitcoin-git has left #bitcoin-core-dev
325 2019-10-04T18:40:52  *** bitcoin-git has joined #bitcoin-core-dev
326 2019-10-04T18:40:52  <bitcoin-git> [bitcoin] fanquake merged pull request #17049: contrib: Bump gitian descriptors for 0.20 (master...1909-prep20) https://github.com/bitcoin/bitcoin/pull/17049
327 2019-10-04T18:40:54  *** bitcoin-git has left #bitcoin-core-dev
328 2019-10-04T18:50:49  *** arik_ has quit IRC
329 2019-10-04T18:51:11  *** arik_ has joined #bitcoin-core-dev
330 2019-10-04T18:56:19  *** victorSN has joined #bitcoin-core-dev
331 2019-10-04T19:16:16  *** bitcoin-git has joined #bitcoin-core-dev
332 2019-10-04T19:16:16  <bitcoin-git> [bitcoin] lucayepa opened pull request #17054: [0.18.2] Backport of #15706 (master...check-qt-version-0.18) https://github.com/bitcoin/bitcoin/pull/17054
333 2019-10-04T19:16:18  *** bitcoin-git has left #bitcoin-core-dev
334 2019-10-04T19:22:24  *** fox2p_ has joined #bitcoin-core-dev
335 2019-10-04T19:23:31  *** Zenton has joined #bitcoin-core-dev
336 2019-10-04T19:23:32  *** fox2p has quit IRC
337 2019-10-04T19:41:20  *** tripleslash has joined #bitcoin-core-dev
338 2019-10-04T19:43:18  *** bitcoin-git has joined #bitcoin-core-dev
339 2019-10-04T19:43:18  <bitcoin-git> [bitcoin] lucayepa opened pull request #17055: [0.19] Backport of #15706 (0.19...check-qt-version-0.19) https://github.com/bitcoin/bitcoin/pull/17055
340 2019-10-04T19:43:20  *** bitcoin-git has left #bitcoin-core-dev
341 2019-10-04T19:49:41  *** bitcoin-git has joined #bitcoin-core-dev
342 2019-10-04T19:49:41  <bitcoin-git> [bitcoin] achow101 opened pull request #17056: Introduce sortedmulti descriptor (master...sortedmulti-desc) https://github.com/bitcoin/bitcoin/pull/17056
343 2019-10-04T19:49:43  *** bitcoin-git has left #bitcoin-core-dev
344 2019-10-04T19:49:50  *** Aaronvan_ is now known as AaronvanW
345 2019-10-04T19:54:51  *** bitcoin-git has joined #bitcoin-core-dev
346 2019-10-04T19:54:51  <bitcoin-git> [bitcoin] fanquake opened pull request #17057: build: switch to upstream libdmg-hfsplus (master...upstream_libdmg_hfsplus) https://github.com/bitcoin/bitcoin/pull/17057
347 2019-10-04T19:54:53  *** bitcoin-git has left #bitcoin-core-dev
348 2019-10-04T19:58:02  *** diogosergio has joined #bitcoin-core-dev
349 2019-10-04T20:00:02  *** shesek has quit IRC
350 2019-10-04T20:02:07  *** jonatack has joined #bitcoin-core-dev
351 2019-10-04T20:03:30  *** diogosergio has quit IRC
352 2019-10-04T20:05:08  *** jkczyz has quit IRC
353 2019-10-04T20:07:14  *** cubancorona has quit IRC
354 2019-10-04T20:07:50  *** promag has joined #bitcoin-core-dev
355 2019-10-04T20:20:18  *** tripleslash has quit IRC
356 2019-10-04T20:28:45  *** Chris_Stewart_5 has quit IRC
357 2019-10-04T20:35:36  *** diogosergio has joined #bitcoin-core-dev
358 2019-10-04T20:37:08  *** promag has quit IRC
359 2019-10-04T20:40:03  *** diogosergio has quit IRC
360 2019-10-04T20:45:39  *** spinza has quit IRC
361 2019-10-04T20:45:54  *** jkczyz has joined #bitcoin-core-dev
362 2019-10-04T20:51:22  *** spinza has joined #bitcoin-core-dev
363 2019-10-04T20:51:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
364 2019-10-04T20:57:04  *** reallll has joined #bitcoin-core-dev
365 2019-10-04T20:58:43  *** Guyver2 has quit IRC
366 2019-10-04T21:00:02  *** lcb has quit IRC
367 2019-10-04T21:00:23  *** Chris_Stewart_5 has quit IRC
368 2019-10-04T21:00:49  *** belcher has quit IRC
369 2019-10-04T21:05:23  *** promag has joined #bitcoin-core-dev
370 2019-10-04T21:05:52  *** cubancorona has joined #bitcoin-core-dev
371 2019-10-04T21:17:37  *** guilhermeblanco has joined #bitcoin-core-dev
372 2019-10-04T21:18:02  *** rh0nj has quit IRC
373 2019-10-04T21:19:07  *** rh0nj has joined #bitcoin-core-dev
374 2019-10-04T21:20:51  *** jb55 has quit IRC
375 2019-10-04T21:29:54  *** jb55 has joined #bitcoin-core-dev
376 2019-10-04T21:31:04  *** rafalcpp has joined #bitcoin-core-dev
377 2019-10-04T21:31:52  *** rafalcpp_ has quit IRC
378 2019-10-04T21:34:50  *** owowo has quit IRC
379 2019-10-04T21:41:01  *** owowo has joined #bitcoin-core-dev
380 2019-10-04T21:41:01  *** owowo has joined #bitcoin-core-dev
381 2019-10-04T21:42:10  *** lnostdal has quit IRC
382 2019-10-04T21:52:05  <promag> emilengler: hi
383 2019-10-04T21:52:14  <promag> emilengler: I really don't understand what you mean in https://github.com/bitcoin/bitcoin/pull/17035/files#r331313258
384 2019-10-04T21:52:55  <promag> with my suggestion you can avoid adding Intro::on_prune_stateChanged
385 2019-10-04T21:53:19  <promag> and the actual call to setSizeWarningLabel is simpler
386 2019-10-04T21:53:35  <emilengler> promag: With a connect()?
387 2019-10-04T21:53:49  <promag> yes
388 2019-10-04T21:54:08  <emilengler> I did it because my approach was common
389 2019-10-04T21:54:22  <promag> emilengler: it's not the best though
390 2019-10-04T21:54:37  <emilengler> I don't like to change the syntax of a project just becasue of a simple bugfix
391 2019-10-04T21:54:54  <emilengler> I totally agree, I don't like the cuurent situation either
392 2019-10-04T21:54:56  <promag> emilengler: actually your change is worst
393 2019-10-04T21:55:10  <emilengler> How?
394 2019-10-04T21:56:54  <promag> what Qt does is it iterates all slots and if it finds that syntax (on_<obj name>_<signal>) it automatically connects to that slots. but this is dynamically, and not compiler checked. for instance, if you rename the object then the connect won't happen unless you also rename the slot
395 2019-10-04T21:57:26  <emilengler> Oh
396 2019-10-04T21:57:28  <promag> that's why we also dropped SIGNAL() SLOT() connections
397 2019-10-04T21:57:33  <emilengler> Yeah it is ugly...
398 2019-10-04T21:57:56  <emilengler> But like I said, not only my function is doing this
399 2019-10-04T21:58:03  <emilengler> There are several others in the code
400 2019-10-04T21:58:13  <promag> new code should not use dynamic connections
401 2019-10-04T21:58:40  <emilengler> I thought it should follow the syntax...
402 2019-10-04T21:59:51  <promag> this is not syntax
403 2019-10-04T22:00:08  <promag> this is not code format
404 2019-10-04T22:01:04  <promag> There are several others in the code -> you are free to fix that
405 2019-10-04T22:01:16  <emilengler> But is the approach with connect often used in the code? In intro.cpp connect is only used with the FreespaceChecker
406 2019-10-04T22:02:01  <emilengler> Ok I will fix it ^^
407 2019-10-04T22:04:03  <promag> emilengler: see #13529
408 2019-10-04T22:04:05  <gribble> https://github.com/bitcoin/bitcoin/issues/13529 | Use new Qt5 connect syntax by promag · Pull Request #13529 · bitcoin/bitcoin · GitHub
409 2019-10-04T22:05:14  <promag> also #16348
410 2019-10-04T22:05:16  <gribble> https://github.com/bitcoin/bitcoin/issues/16348 | qt: Assert QMetaObject::invokeMethod result by promag · Pull Request #16348 · bitcoin/bitcoin · GitHub
411 2019-10-04T22:06:18  <promag> see #16261 for some cases with good connect() usage
412 2019-10-04T22:06:20  <gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
413 2019-10-04T22:07:02  <promag> let me know if you need help
414 2019-10-04T22:07:30  <emilengler> Ok, thanks for offering :)
415 2019-10-04T22:11:22  *** Victorsueca has joined #bitcoin-core-dev
416 2019-10-04T22:11:54  *** Victor_sueca has quit IRC
417 2019-10-04T22:19:03  <emilengler> promag: https://github.com/bitcoin/bitcoin/pull/17035/commits/865cf2ddd3d23592b1dbdae377e996def2e65cde
418 2019-10-04T22:19:10  <emilengler> Thanks for your snippet btw
419 2019-10-04T22:20:50  <promag> add a newline at the end of intro.cpp and squash commits
420 2019-10-04T22:21:25  <promag> emilengler: thanks, I'll test the remaining change
421 2019-10-04T22:22:01  <emilengler> promag: I have to say thanks :)
422 2019-10-04T22:24:38  <emilengler> Done
423 2019-10-04T22:26:33  *** profmac has quit IRC
424 2019-10-04T22:27:22  *** profmac has joined #bitcoin-core-dev
425 2019-10-04T22:32:37  *** jkczyz has quit IRC
426 2019-10-04T22:38:19  *** bitcoin-git has joined #bitcoin-core-dev
427 2019-10-04T22:38:19  <bitcoin-git> [bitcoin] GChuf opened pull request #17058: GUI: Remove old translation files, reorganize translations (master...translations-fix) https://github.com/bitcoin/bitcoin/pull/17058
428 2019-10-04T22:38:20  *** bitcoin-git has left #bitcoin-core-dev
429 2019-10-04T22:39:39  *** captjakk has quit IRC
430 2019-10-04T22:40:06  *** captjakk has joined #bitcoin-core-dev
431 2019-10-04T22:44:17  *** captjakk has quit IRC
432 2019-10-04T22:52:30  <sipa> emilengler: generally you should avoid the urge to mimick the surrounding style when writing new code
433 2019-10-04T23:20:24  *** nosss2 has joined #bitcoin-core-dev
434 2019-10-04T23:26:09  *** promag has quit IRC
435 2019-10-04T23:54:39  *** rhavar_ has joined #bitcoin-core-dev
436 2019-10-04T23:56:00  *** reallll is now known as belcher