12019-10-24T00:00:01  *** zalun1 has quit IRC
  22019-10-24T00:04:37  *** andytosh1 has quit IRC
  32019-10-24T00:11:21  *** Aaronvan_ has quit IRC
  42019-10-24T00:11:32  *** Suntop1 has joined #bitcoin-core-dev
  52019-10-24T00:12:59  *** mdunnio has joined #bitcoin-core-dev
  62019-10-24T00:14:28  *** niska has quit IRC
  72019-10-24T00:19:44  *** niska has joined #bitcoin-core-dev
  82019-10-24T00:31:49  *** andytoshi has joined #bitcoin-core-dev
  92019-10-24T00:34:17  *** TheRec has quit IRC
 102019-10-24T00:36:18  *** jkczyz has quit IRC
 112019-10-24T00:36:38  *** TheRec has joined #bitcoin-core-dev
 122019-10-24T00:36:39  *** TheRec has joined #bitcoin-core-dev
 132019-10-24T00:42:37  *** arik_ has quit IRC
 142019-10-24T00:49:52  *** michaelfolkson has joined #bitcoin-core-dev
 152019-10-24T00:50:36  *** AaronvanW has joined #bitcoin-core-dev
 162019-10-24T00:52:35  *** jarthur has quit IRC
 172019-10-24T00:55:15  *** AaronvanW has quit IRC
 182019-10-24T01:00:36  *** cryptoIndio has joined #bitcoin-core-dev
 192019-10-24T01:03:22  *** michaelfolkson has quit IRC
 202019-10-24T01:08:15  *** bitcoin-git has joined #bitcoin-core-dev
 212019-10-24T01:08:15  <bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17214: build: update retry to current version (master...retry) https://github.com/bitcoin/bitcoin/pull/17214
 222019-10-24T01:08:26  *** bitcoin-git has left #bitcoin-core-dev
 232019-10-24T01:08:50  *** _Francisco_ has quit IRC
 242019-10-24T01:12:37  *** andytoshi has quit IRC
 252019-10-24T01:13:05  *** ctrlbreak has quit IRC
 262019-10-24T01:13:29  *** ctrlbreak has joined #bitcoin-core-dev
 272019-10-24T01:17:25  *** emilengler has quit IRC
 282019-10-24T01:20:24  *** jb55 has joined #bitcoin-core-dev
 292019-10-24T01:22:38  *** AaronvanW has joined #bitcoin-core-dev
 302019-10-24T01:24:24  *** cryptoIndio has quit IRC
 312019-10-24T01:25:01  *** rh0nj has quit IRC
 322019-10-24T01:26:02  *** Highway61 has quit IRC
 332019-10-24T01:26:07  *** rh0nj has joined #bitcoin-core-dev
 342019-10-24T01:26:50  *** AaronvanW has quit IRC
 352019-10-24T01:28:55  *** jb55 has quit IRC
 362019-10-24T01:31:56  *** harrigan has quit IRC
 372019-10-24T01:34:37  *** harrigan has joined #bitcoin-core-dev
 382019-10-24T01:38:21  *** mdunnio has quit IRC
 392019-10-24T01:45:08  *** tryphe has quit IRC
 402019-10-24T01:45:36  *** tryphe has joined #bitcoin-core-dev
 412019-10-24T01:46:38  *** jb55 has joined #bitcoin-core-dev
 422019-10-24T01:52:04  *** mdunnio has joined #bitcoin-core-dev
 432019-10-24T01:59:48  *** AaronvanW has joined #bitcoin-core-dev
 442019-10-24T02:04:02  *** AaronvanW has quit IRC
 452019-10-24T02:06:16  *** emilengler has joined #bitcoin-core-dev
 462019-10-24T02:25:50  *** ddustin has quit IRC
 472019-10-24T02:26:27  *** ddustin has joined #bitcoin-core-dev
 482019-10-24T02:31:15  *** ddustin has quit IRC
 492019-10-24T02:35:36  *** jkczyz has joined #bitcoin-core-dev
 502019-10-24T02:39:39  *** AaronvanW has joined #bitcoin-core-dev
 512019-10-24T02:40:02  *** jkczyz has quit IRC
 522019-10-24T02:40:03  *** felixfoertsch has quit IRC
 532019-10-24T02:41:39  *** felixfoertsch has joined #bitcoin-core-dev
 542019-10-24T02:44:03  *** AaronvanW has quit IRC
 552019-10-24T03:00:01  *** Suntop1 has quit IRC
 562019-10-24T03:02:21  *** promag_ has joined #bitcoin-core-dev
 572019-10-24T03:07:23  *** promag_ has quit IRC
 582019-10-24T03:11:00  *** jb55 has quit IRC
 592019-10-24T03:11:23  *** limpkin1 has joined #bitcoin-core-dev
 602019-10-24T03:12:47  *** AaronvanW has joined #bitcoin-core-dev
 612019-10-24T03:17:27  *** AaronvanW has quit IRC
 622019-10-24T03:21:19  *** cryptoIndio has joined #bitcoin-core-dev
 632019-10-24T03:22:40  *** koti has joined #bitcoin-core-dev
 642019-10-24T03:23:38  *** Eagle[TM] has joined #bitcoin-core-dev
 652019-10-24T03:24:10  *** jb55 has joined #bitcoin-core-dev
 662019-10-24T03:24:50  *** EagleTM has quit IRC
 672019-10-24T03:39:17  *** bastion-tester has joined #bitcoin-core-dev
 682019-10-24T03:49:12  *** bastion-tester has quit IRC
 692019-10-24T03:49:27  *** AaronvanW has joined #bitcoin-core-dev
 702019-10-24T03:54:15  *** AaronvanW has quit IRC
 712019-10-24T03:55:58  *** bastion-tester has joined #bitcoin-core-dev
 722019-10-24T03:57:12  *** bastion-tester has joined #bitcoin-core-dev
 732019-10-24T04:03:55  *** ddustin has joined #bitcoin-core-dev
 742019-10-24T04:03:59  *** cryptoIndio has quit IRC
 752019-10-24T04:22:52  *** AaronvanW has joined #bitcoin-core-dev
 762019-10-24T04:25:01  *** mdunnio has quit IRC
 772019-10-24T04:27:33  *** AaronvanW has quit IRC
 782019-10-24T04:33:45  *** tsujp has quit IRC
 792019-10-24T04:35:08  *** tsujp has joined #bitcoin-core-dev
 802019-10-24T04:36:25  *** jkczyz has joined #bitcoin-core-dev
 812019-10-24T04:42:21  *** jkczyz has quit IRC
 822019-10-24T04:42:45  *** ddustin has quit IRC
 832019-10-24T04:43:24  *** ddustin has joined #bitcoin-core-dev
 842019-10-24T04:43:46  *** bastion-tester has quit IRC
 852019-10-24T04:45:23  *** bastion-tester has joined #bitcoin-core-dev
 862019-10-24T04:45:49  *** koti has quit IRC
 872019-10-24T04:48:03  *** ddustin has quit IRC
 882019-10-24T04:59:45  *** mdunnio has joined #bitcoin-core-dev
 892019-10-24T05:00:19  *** bastion-tester has quit IRC
 902019-10-24T05:02:12  *** AaronvanW has joined #bitcoin-core-dev
 912019-10-24T05:03:21  *** bastion-tester has joined #bitcoin-core-dev
 922019-10-24T05:04:33  *** mdunnio has quit IRC
 932019-10-24T05:07:01  *** AaronvanW has quit IRC
 942019-10-24T05:31:44  *** arubi has quit IRC
 952019-10-24T05:32:09  *** arubi has joined #bitcoin-core-dev
 962019-10-24T05:33:03  *** AaronvanW has joined #bitcoin-core-dev
 972019-10-24T05:37:51  *** AaronvanW has quit IRC
 982019-10-24T05:40:00  *** mdunnio has joined #bitcoin-core-dev
 992019-10-24T05:56:59  *** Evel-Knievel has joined #bitcoin-core-dev
1002019-10-24T06:00:01  *** limpkin1 has quit IRC
1012019-10-24T06:06:17  *** AaronvanW has joined #bitcoin-core-dev
1022019-10-24T06:11:06  *** AaronvanW has quit IRC
1032019-10-24T06:13:17  *** mdunnio has quit IRC
1042019-10-24T06:17:34  *** G13 has joined #bitcoin-core-dev
1052019-10-24T06:28:37  *** Eagle[TM] has quit IRC
1062019-10-24T06:32:50  *** achow101 has quit IRC
1072019-10-24T06:37:32  *** AaronvanW has joined #bitcoin-core-dev
1082019-10-24T06:38:18  *** jkczyz has joined #bitcoin-core-dev
1092019-10-24T06:39:19  *** cryptoIndio has joined #bitcoin-core-dev
1102019-10-24T06:42:31  *** AaronvanW has quit IRC
1112019-10-24T06:42:57  *** jkczyz has quit IRC
1122019-10-24T06:43:58  *** cryptoIndio has quit IRC
1132019-10-24T07:02:56  *** laptop_ has joined #bitcoin-core-dev
1142019-10-24T07:06:26  *** cryptoIndio has joined #bitcoin-core-dev
1152019-10-24T07:09:50  *** marcoagner has joined #bitcoin-core-dev
1162019-10-24T07:10:58  *** cryptoIndio has quit IRC
1172019-10-24T07:18:57  *** promag has quit IRC
1182019-10-24T07:22:09  *** mdunnio has joined #bitcoin-core-dev
1192019-10-24T07:26:33  *** laptop_ has quit IRC
1202019-10-24T07:40:21  *** cryptoIndio has joined #bitcoin-core-dev
1212019-10-24T07:42:50  *** AaronvanW has joined #bitcoin-core-dev
1222019-10-24T07:44:44  *** achow101 has joined #bitcoin-core-dev
1232019-10-24T07:52:20  *** EagleTM has joined #bitcoin-core-dev
1242019-10-24T07:55:59  *** mdunnio has quit IRC
1252019-10-24T07:57:59  *** achow101 has quit IRC
1262019-10-24T07:58:27  *** cryptoIndio has quit IRC
1272019-10-24T08:01:06  *** achow101 has joined #bitcoin-core-dev
1282019-10-24T08:04:23  *** kristapsk has quit IRC
1292019-10-24T08:04:43  *** kristapsk has joined #bitcoin-core-dev
1302019-10-24T08:07:57  <elichai2> Look at how they handle performance checks for PRs. I want this. https://github.com/rust-lang/rust/pull/64595
1312019-10-24T08:09:38  *** kabaum has joined #bitcoin-core-dev
1322019-10-24T08:10:56  *** michaelfolkson has joined #bitcoin-core-dev
1332019-10-24T08:12:39  *** promag has joined #bitcoin-core-dev
1342019-10-24T08:16:51  *** bitcoin-git has joined #bitcoin-core-dev
1352019-10-24T08:16:52  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c5ac7af7793a...8a191148db3f
1362019-10-24T08:16:53  <bitcoin-git> bitcoin/master 8bba91b John Newbery: [wallet] Fix whitespace in CWallet::CommitTransaction()
1372019-10-24T08:16:54  <bitcoin-git> bitcoin/master b6f486a John Newbery: [wallet] Add doxygen comment to CWallet::CommitTransaction()
1382019-10-24T08:16:54  <bitcoin-git> bitcoin/master d1734f9 John Newbery: [wallet] Remove return value from CommitTransaction()
1392019-10-24T08:16:56  *** bitcoin-git has left #bitcoin-core-dev
1402019-10-24T08:17:11  *** bitcoin-git has joined #bitcoin-core-dev
1412019-10-24T08:17:11  <bitcoin-git> [bitcoin] laanwj merged pull request #17154: wallet: Remove return value from CommitTransaction (master...2019-04-CommitTransaction) https://github.com/bitcoin/bitcoin/pull/17154
1422019-10-24T08:17:13  *** bitcoin-git has left #bitcoin-core-dev
1432019-10-24T08:17:15  *** promag has quit IRC
1442019-10-24T08:19:57  *** promag has joined #bitcoin-core-dev
1452019-10-24T08:21:02  *** promag_ has joined #bitcoin-core-dev
1462019-10-24T08:24:53  *** promag has quit IRC
1472019-10-24T08:24:54  *** promag_ has quit IRC
1482019-10-24T08:25:09  *** promag has joined #bitcoin-core-dev
1492019-10-24T08:25:16  *** promag_ has joined #bitcoin-core-dev
1502019-10-24T08:27:28  *** michaelfolkson has quit IRC
1512019-10-24T08:27:51  *** laptop_ has joined #bitcoin-core-dev
1522019-10-24T08:32:07  *** cryptoIndio has joined #bitcoin-core-dev
1532019-10-24T08:37:06  *** cryptoIndio has quit IRC
1542019-10-24T08:39:09  *** jkczyz has joined #bitcoin-core-dev
1552019-10-24T08:41:27  *** michaelfolkson has joined #bitcoin-core-dev
1562019-10-24T08:43:29  *** EagleTM has quit IRC
1572019-10-24T08:44:27  *** jkczyz has quit IRC
1582019-10-24T08:47:33  *** bitcoin-git has joined #bitcoin-core-dev
1592019-10-24T08:47:33  <bitcoin-git> [bitcoin] promag opened pull request #17237: wallet: LearnRelatedScripts only if KeepDestination (master...2019-10-wallet-reservedestination) https://github.com/bitcoin/bitcoin/pull/17237
1602019-10-24T08:47:34  *** bitcoin-git has left #bitcoin-core-dev
1612019-10-24T08:50:11  *** bitcoin-git has joined #bitcoin-core-dev
1622019-10-24T08:50:13  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8a191148db3f...b688b859dbb2
1632019-10-24T08:50:13  <bitcoin-git> bitcoin/master a1a07cf John Newbery: [validation] Fix peer punishment for bad blocks
1642019-10-24T08:50:14  <bitcoin-git> bitcoin/master 0053e16 John Newbery: [logging] Don't log REJECT code when transaction is rejected
1652019-10-24T08:50:15  <bitcoin-git> bitcoin/master e9d5a59 John Newbery: [validation] Remove REJECT code from CValidationState
1662019-10-24T08:50:17  *** bitcoin-git has left #bitcoin-core-dev
1672019-10-24T08:50:31  *** bitcoin-git has joined #bitcoin-core-dev
1682019-10-24T08:50:31  <bitcoin-git> [bitcoin] laanwj merged pull request #17004: validation: Remove REJECT code from CValidationState (master...2019-09-no-reject-validation-state) https://github.com/bitcoin/bitcoin/pull/17004
1692019-10-24T08:50:33  *** bitcoin-git has left #bitcoin-core-dev
1702019-10-24T08:52:56  *** michaelfolkson has quit IRC
1712019-10-24T09:00:01  *** G13 has quit IRC
1722019-10-24T09:03:49  *** acked has joined #bitcoin-core-dev
1732019-10-24T09:04:47  *** mdunnio has joined #bitcoin-core-dev
1742019-10-24T09:12:06  *** cryptoIndio has joined #bitcoin-core-dev
1752019-10-24T09:17:23  *** cryptoIndio has quit IRC
1762019-10-24T09:20:15  *** acked has left #bitcoin-core-dev
1772019-10-24T09:22:13  *** timothy has joined #bitcoin-core-dev
1782019-10-24T09:31:46  *** nijynot has joined #bitcoin-core-dev
1792019-10-24T09:34:24  *** michaelfolkson has joined #bitcoin-core-dev
1802019-10-24T09:34:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1812019-10-24T09:36:36  *** tecnovert has joined #bitcoin-core-dev
1822019-10-24T09:38:17  *** mdunnio has quit IRC
1832019-10-24T09:42:54  *** cryptoIndio has joined #bitcoin-core-dev
1842019-10-24T09:43:06  *** Giszmo has joined #bitcoin-core-dev
1852019-10-24T09:43:54  *** Skirmant has quit IRC
1862019-10-24T09:44:56  *** cryptoIndio has quit IRC
1872019-10-24T09:46:42  *** ffej has joined #bitcoin-core-dev
1882019-10-24T09:54:44  *** jonatack has quit IRC
1892019-10-24T10:03:44  *** rex4539 has joined #bitcoin-core-dev
1902019-10-24T10:37:16  *** mdunnio has joined #bitcoin-core-dev
1912019-10-24T10:40:02  *** jkczyz has joined #bitcoin-core-dev
1922019-10-24T10:41:03  *** michaelfolkson has quit IRC
1932019-10-24T10:41:41  *** michaelfolkson has joined #bitcoin-core-dev
1942019-10-24T10:42:32  *** jonatack has joined #bitcoin-core-dev
1952019-10-24T10:44:36  *** jkczyz has quit IRC
1962019-10-24T10:48:22  *** Honthe has quit IRC
1972019-10-24T11:06:33  *** cryptoIndio has joined #bitcoin-core-dev
1982019-10-24T11:10:51  *** mdunnio has quit IRC
1992019-10-24T11:11:41  *** cryptoIndio has quit IRC
2002019-10-24T11:15:27  *** jonatack has quit IRC
2012019-10-24T11:16:23  *** jonatack_ has joined #bitcoin-core-dev
2022019-10-24T11:16:42  *** jonatack_ has joined #bitcoin-core-dev
2032019-10-24T11:18:16  *** jonatack_ has quit IRC
2042019-10-24T11:18:35  *** jonatack_ has joined #bitcoin-core-dev
2052019-10-24T11:21:56  *** michaelfolkson has quit IRC
2062019-10-24T11:22:47  *** michaelfolkson has joined #bitcoin-core-dev
2072019-10-24T11:22:57  *** michaelfolkson has quit IRC
2082019-10-24T11:28:33  *** pergaminho has joined #bitcoin-core-dev
2092019-10-24T11:33:47  *** pergaminho has joined #bitcoin-core-dev
2102019-10-24T11:42:15  *** bitcoin-git has joined #bitcoin-core-dev
2112019-10-24T11:42:15  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b688b859dbb2...205cffaf383c
2122019-10-24T11:42:16  <bitcoin-git> bitcoin/master 0fc81a1 João Barbosa: gui: Fix payAmount tooltip in SendCoinsEntry
2132019-10-24T11:42:16  <bitcoin-git> bitcoin/master 205cffa Wladimir J. van der Laan: Merge #17226: gui: Fix payAmount tooltip in SendCoinsEntry
2142019-10-24T11:42:18  *** bitcoin-git has left #bitcoin-core-dev
2152019-10-24T11:42:35  *** bitcoin-git has joined #bitcoin-core-dev
2162019-10-24T11:42:35  <bitcoin-git> [bitcoin] laanwj merged pull request #17226: gui: Fix payAmount tooltip in SendCoinsEntry (master...2019-10-payamount-tooltip) https://github.com/bitcoin/bitcoin/pull/17226
2172019-10-24T11:42:38  *** bitcoin-git has left #bitcoin-core-dev
2182019-10-24T11:43:08  *** promag has quit IRC
2192019-10-24T11:45:01  *** promag_ has quit IRC
2202019-10-24T11:46:21  *** cryptoIndio has joined #bitcoin-core-dev
2212019-10-24T11:52:10  *** cryptoIndio has quit IRC
2222019-10-24T11:59:34  *** Chris_Stewart_5 has quit IRC
2232019-10-24T12:00:01  *** ffej has quit IRC
2242019-10-24T12:02:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2252019-10-24T12:16:36  *** Highway61 has joined #bitcoin-core-dev
2262019-10-24T12:17:47  *** ao2 has joined #bitcoin-core-dev
2272019-10-24T12:18:11  *** ao2 is now known as Guest68338
2282019-10-24T12:18:27  *** lightlike has joined #bitcoin-core-dev
2292019-10-24T12:30:06  *** mdunnio has joined #bitcoin-core-dev
2302019-10-24T12:32:44  *** promag has joined #bitcoin-core-dev
2312019-10-24T12:34:59  *** bitcoin-git has joined #bitcoin-core-dev
2322019-10-24T12:35:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/205cffaf383c...d53828cb7968
2332019-10-24T12:35:00  <bitcoin-git> bitcoin/master db4bd32 practicalswift: tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only w...
2342019-10-24T12:35:01  <bitcoin-git> bitcoin/master c2f964a practicalswift: tests: Remove Cygwin WinMain workaround
2352019-10-24T12:35:01  <bitcoin-git> bitcoin/master d53828c MarcoFalke: Merge #17235: tests: Skip unnecessary fuzzer initialisation. Hold ECCVerif...
2362019-10-24T12:35:02  *** bitcoin-git has left #bitcoin-core-dev
2372019-10-24T12:35:19  *** bitcoin-git has joined #bitcoin-core-dev
2382019-10-24T12:35:20  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17235: tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed. (master...fuzz-initialize-when-needed) https://github.com/bitcoin/bitcoin/pull/17235
2392019-10-24T12:35:23  *** bitcoin-git has left #bitcoin-core-dev
2402019-10-24T12:40:55  *** jkczyz has joined #bitcoin-core-dev
2412019-10-24T12:45:59  *** jkczyz has quit IRC
2422019-10-24T12:53:19  *** bitcoin-git has joined #bitcoin-core-dev
2432019-10-24T12:53:19  <bitcoin-git> [bitcoin] sandakersmann closed pull request #17166: doc: Changed miniupnp links to https (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17166
2442019-10-24T12:53:21  *** bitcoin-git has left #bitcoin-core-dev
2452019-10-24T12:58:08  *** bitcoin-git has joined #bitcoin-core-dev
2462019-10-24T12:58:08  <bitcoin-git> [bitcoin] sandakersmann opened pull request #17239: doc: Changed miniupnp links to https (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17239
2472019-10-24T12:58:09  *** bitcoin-git has left #bitcoin-core-dev
2482019-10-24T13:00:17  *** mdunnio has quit IRC
2492019-10-24T13:01:51  *** Chris_Stewart_5 has quit IRC
2502019-10-24T13:04:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2512019-10-24T13:04:49  <ryanofsky> can add ariard pr #15931 to high priority reviews? first in a series of changes to make wallet sync code sane and nonblocking
2522019-10-24T13:04:53  <gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard · Pull Request #15931 · bitcoin/bitcoin · GitHub
2532019-10-24T13:05:41  *** davterra has quit IRC
2542019-10-24T13:06:04  *** lowentropy has quit IRC
2552019-10-24T13:06:19  *** lowentropy has joined #bitcoin-core-dev
2562019-10-24T13:07:40  *** davterra has joined #bitcoin-core-dev
2572019-10-24T13:07:54  *** promag has quit IRC
2582019-10-24T13:09:26  *** ddustin has joined #bitcoin-core-dev
2592019-10-24T13:15:55  *** andytoshi has joined #bitcoin-core-dev
2602019-10-24T13:15:55  *** andytoshi has joined #bitcoin-core-dev
2612019-10-24T13:27:01  *** rh0nj has quit IRC
2622019-10-24T13:28:08  *** rh0nj has joined #bitcoin-core-dev
2632019-10-24T13:30:48  *** Guyver2 has joined #bitcoin-core-dev
2642019-10-24T13:31:48  *** jonatack_ has quit IRC
2652019-10-24T13:39:51  *** rex4539 has quit IRC
2662019-10-24T13:46:46  *** nosss2 has quit IRC
2672019-10-24T13:55:06  *** nosss2 has joined #bitcoin-core-dev
2682019-10-24T14:00:02  *** nosss2 has quit IRC
2692019-10-24T14:00:18  *** laptop_ has quit IRC
2702019-10-24T14:11:59  *** justanotheruser has quit IRC
2712019-10-24T14:17:13  *** jonatack_ has joined #bitcoin-core-dev
2722019-10-24T14:22:18  *** cryptoIndio has joined #bitcoin-core-dev
2732019-10-24T14:26:49  *** jonatack_ has quit IRC
2742019-10-24T14:27:10  *** cryptoIndio has quit IRC
2752019-10-24T14:27:14  *** jonatack has joined #bitcoin-core-dev
2762019-10-24T14:28:51  *** justanotheruser has joined #bitcoin-core-dev
2772019-10-24T14:34:54  *** ddustin has quit IRC
2782019-10-24T14:35:30  *** ddustin has joined #bitcoin-core-dev
2792019-10-24T14:39:53  *** ddustin has quit IRC
2802019-10-24T14:41:50  *** jkczyz has joined #bitcoin-core-dev
2812019-10-24T14:44:11  *** pergaminho has quit IRC
2822019-10-24T14:46:49  *** jkczyz has quit IRC
2832019-10-24T14:48:57  *** ddustin has joined #bitcoin-core-dev
2842019-10-24T14:51:34  *** pergaminho has joined #bitcoin-core-dev
2852019-10-24T14:51:47  *** jkczyz has joined #bitcoin-core-dev
2862019-10-24T14:52:59  *** thoragh has joined #bitcoin-core-dev
2872019-10-24T14:53:27  *** ddustin has quit IRC
2882019-10-24T14:54:22  *** thoragh has left #bitcoin-core-dev
2892019-10-24T14:56:02  *** jkczyz has quit IRC
2902019-10-24T14:56:29  *** thoragh has joined #bitcoin-core-dev
2912019-10-24T14:58:49  *** ddustin has joined #bitcoin-core-dev
2922019-10-24T15:00:02  *** Guest68338 has quit IRC
2932019-10-24T15:03:15  *** mdunnio has joined #bitcoin-core-dev
2942019-10-24T15:06:54  *** captjakk has joined #bitcoin-core-dev
2952019-10-24T15:07:02  *** captjakk has joined #bitcoin-core-dev
2962019-10-24T15:08:03  *** bitcoin-git has joined #bitcoin-core-dev
2972019-10-24T15:08:03  <bitcoin-git> [bitcoin] fanquake closed pull request #17054: [0.18.2] Backport of #15706 (0.18...check-qt-version-0.18) https://github.com/bitcoin/bitcoin/pull/17054
2982019-10-24T15:08:04  *** bitcoin-git has left #bitcoin-core-dev
2992019-10-24T15:08:33  *** promag has joined #bitcoin-core-dev
3002019-10-24T15:12:18  *** jarthur has joined #bitcoin-core-dev
3012019-10-24T15:12:37  *** promag has quit IRC
3022019-10-24T15:14:10  *** mmgen has joined #bitcoin-core-dev
3032019-10-24T15:15:18  *** andytoshi has quit IRC
3042019-10-24T15:17:41  *** Aaaron has joined #bitcoin-core-dev
3052019-10-24T15:28:57  *** nijynot has quit IRC
3062019-10-24T15:36:57  *** bitcoin-git has joined #bitcoin-core-dev
3072019-10-24T15:36:58  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d53828cb7968...d7134ead84e3
3082019-10-24T15:36:58  <bitcoin-git> bitcoin/master 6f68523 Marius Kjærstad: doc: Changed miniupnp links to https
3092019-10-24T15:36:59  <bitcoin-git> bitcoin/master d7134ea fanquake: Merge #17239: doc: Changed miniupnp links to https
3102019-10-24T15:37:01  *** bitcoin-git has left #bitcoin-core-dev
3112019-10-24T15:37:17  *** bitcoin-git has joined #bitcoin-core-dev
3122019-10-24T15:37:17  <bitcoin-git> [bitcoin] fanquake merged pull request #17239: doc: Changed miniupnp links to https (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17239
3132019-10-24T15:37:20  *** bitcoin-git has left #bitcoin-core-dev
3142019-10-24T15:58:12  *** lowentropy has quit IRC
3152019-10-24T15:58:24  *** lowentropy has joined #bitcoin-core-dev
3162019-10-24T15:58:40  *** mmgen has quit IRC
3172019-10-24T16:09:45  *** ddustin has quit IRC
3182019-10-24T16:14:47  *** nosss2 has joined #bitcoin-core-dev
3192019-10-24T16:23:26  *** cryptoIndio has joined #bitcoin-core-dev
3202019-10-24T16:23:46  *** roconnor has joined #bitcoin-core-dev
3212019-10-24T16:28:26  *** cryptoIndio has quit IRC
3222019-10-24T16:28:27  *** mmgen has joined #bitcoin-core-dev
3232019-10-24T16:28:56  *** davterra has quit IRC
3242019-10-24T16:31:50  *** rex4539 has joined #bitcoin-core-dev
3252019-10-24T16:37:58  *** jkczyz has joined #bitcoin-core-dev
3262019-10-24T16:39:22  *** captjakk has quit IRC
3272019-10-24T16:45:52  *** captjakk has joined #bitcoin-core-dev
3282019-10-24T16:46:50  *** mdunnio has quit IRC
3292019-10-24T16:47:41  *** bitcoin-git has joined #bitcoin-core-dev
3302019-10-24T16:47:42  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17240: ci: Disable functional tests on mac host (master...1910-ciNoFunMac) https://github.com/bitcoin/bitcoin/pull/17240
3312019-10-24T16:47:42  *** bitcoin-git has left #bitcoin-core-dev
3322019-10-24T16:53:07  <wumpus> removed "waiting for author" and "needs rebase" from all closed PRs
3332019-10-24T16:55:56  *** promag has joined #bitcoin-core-dev
3342019-10-24T16:57:14  *** Chris_Stewart_5 has quit IRC
3352019-10-24T16:58:50  *** jkczyz has quit IRC
3362019-10-24T16:58:58  *** bitcoin-git has joined #bitcoin-core-dev
3372019-10-24T16:58:59  <bitcoin-git> [bitcoin] jnewbery opened pull request #17241: [WIP] remove fCheckDuplicateInputs from CheckTransaction() (master...2019-10-fduplicateinputs) https://github.com/bitcoin/bitcoin/pull/17241
3382019-10-24T16:59:02  *** timothy has quit IRC
3392019-10-24T16:59:11  *** bitcoin-git has left #bitcoin-core-dev
3402019-10-24T16:59:32  *** jtimon has joined #bitcoin-core-dev
3412019-10-24T17:00:06  *** jkczyz has joined #bitcoin-core-dev
3422019-10-24T17:01:05  *** bitcoin-git has joined #bitcoin-core-dev
3432019-10-24T17:01:05  <bitcoin-git> [bitcoin] jnewbery closed pull request #17241: [WIP] remove fCheckDuplicateInputs from CheckTransaction() (master...2019-10-fduplicateinputs) https://github.com/bitcoin/bitcoin/pull/17241
3442019-10-24T17:01:06  *** bitcoin-git has left #bitcoin-core-dev
3452019-10-24T17:08:57  *** ddustin has joined #bitcoin-core-dev
3462019-10-24T17:10:57  *** jkczyz has quit IRC
3472019-10-24T17:11:09  *** arik_ has joined #bitcoin-core-dev
3482019-10-24T17:13:08  *** jkczyz has joined #bitcoin-core-dev
3492019-10-24T17:13:13  *** mdunnio has joined #bitcoin-core-dev
3502019-10-24T17:13:27  *** ddustin has quit IRC
3512019-10-24T17:13:44  *** captjakk has quit IRC
3522019-10-24T17:14:10  *** afk11` is now known as afk11
3532019-10-24T17:15:01  *** ddustin has joined #bitcoin-core-dev
3542019-10-24T17:16:36  *** bitcoin-git has joined #bitcoin-core-dev
3552019-10-24T17:16:37  <bitcoin-git> [bitcoin] jnewbery opened pull request #17242: validation: Remove unused cacheSigStore from CheckInputsFromMempooAndCache (master...2019-10-checkinputsfrommempool) https://github.com/bitcoin/bitcoin/pull/17242
3562019-10-24T17:16:38  *** bitcoin-git has left #bitcoin-core-dev
3572019-10-24T17:19:46  <MarcoFalke> wumpus: could you add  adamjonas  to the Bitcoin Core label group pls?
3582019-10-24T17:19:55  <MarcoFalke> Also, ryanofsky qualifies for that group
3592019-10-24T17:21:17  <jonatack> MarcoFalke: what is the Bitcoin Core label group, and how does one qualify?
3602019-10-24T17:21:33  <wumpus> MarcoFalke: sure
3612019-10-24T17:22:56  <MarcoFalke> jonatack: Anyone who is doing that work, but has to ask others currently, qualifies
3622019-10-24T17:23:10  <wumpus> jonatack: the people who have semi-write access to the repository to be able to change labels and open/close issues
3632019-10-24T17:23:38  <MarcoFalke> I saw ryanofsky and adamjonas go over a lot of historic issues and ask other maintainers to close them or add/remove labels
3642019-10-24T17:24:02  <jonatack> Thank you.
3652019-10-24T17:24:22  *** rex4539 has quit IRC
3662019-10-24T17:24:23  <wumpus> haven't seen the name adamjonas a lot
3672019-10-24T17:24:33  *** justanotheruser has quit IRC
3682019-10-24T17:25:57  *** Victorsueca has quit IRC
3692019-10-24T17:26:52  *** Victorsueca has joined #bitcoin-core-dev
3702019-10-24T17:27:19  <wumpus> invited them to the orgs at least...
3712019-10-24T17:28:45  *** captjakk has joined #bitcoin-core-dev
3722019-10-24T17:40:57  *** Highway61 has quit IRC
3732019-10-24T17:45:16  *** justanotheruser has joined #bitcoin-core-dev
3742019-10-24T17:46:37  *** pergaminho has quit IRC
3752019-10-24T17:49:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3762019-10-24T17:52:00  *** pergaminho has joined #bitcoin-core-dev
3772019-10-24T17:58:06  *** pergaminho has quit IRC
3782019-10-24T18:00:01  *** Aaaron has quit IRC
3792019-10-24T18:03:18  <fanquake> wumpus yea that's only very recently
3802019-10-24T18:04:35  *** ddustin has quit IRC
3812019-10-24T18:14:02  *** thoragh has quit IRC
3822019-10-24T18:14:24  *** thoragh has joined #bitcoin-core-dev
3832019-10-24T18:17:36  *** MarkusH1 has joined #bitcoin-core-dev
3842019-10-24T18:24:16  *** cryptoIndio has joined #bitcoin-core-dev
3852019-10-24T18:27:55  *** bitcoin-git has joined #bitcoin-core-dev
3862019-10-24T18:27:55  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7134ead84e3...4af044716952
3872019-10-24T18:27:56  <bitcoin-git> bitcoin/master fa71006 MarcoFalke: ci: Disable functional tests on mac host
3882019-10-24T18:27:56  <bitcoin-git> bitcoin/master 4af0447 Wladimir J. van der Laan: Merge #17240: ci: Disable functional tests on mac host
3892019-10-24T18:27:58  *** bitcoin-git has left #bitcoin-core-dev
3902019-10-24T18:28:15  *** bitcoin-git has joined #bitcoin-core-dev
3912019-10-24T18:28:15  <bitcoin-git> [bitcoin] laanwj merged pull request #17240: ci: Disable functional tests on mac host (master...1910-ciNoFunMac) https://github.com/bitcoin/bitcoin/pull/17240
3922019-10-24T18:28:17  *** bitcoin-git has left #bitcoin-core-dev
3932019-10-24T18:29:18  *** cryptoIndio has quit IRC
3942019-10-24T18:34:51  <fanquake> I've started engaging with GitHub in regards to: https://github.com/bitcoin/bitcoin/issues/15847#issuecomment-526829870.
3952019-10-24T18:35:01  *** afk11 has quit IRC
3962019-10-24T18:35:02  <fanquake> Interestingly, there are at least two members of the Rust Core team in the same group, and it's looks like we are sharing some of the same GitHub grievances as them.
3972019-10-24T18:35:34  *** afk11 has joined #bitcoin-core-dev
3982019-10-24T18:43:04  *** rex4539 has joined #bitcoin-core-dev
3992019-10-24T18:43:09  *** Highway61 has joined #bitcoin-core-dev
4002019-10-24T18:48:34  *** mdunnio has quit IRC
4012019-10-24T18:57:36  *** reallll has joined #bitcoin-core-dev
4022019-10-24T18:59:02  *** afk11 has quit IRC
4032019-10-24T18:59:46  *** afk11 has joined #bitcoin-core-dev
4042019-10-24T19:00:38  <wumpus> meeting time?
4052019-10-24T19:00:47  <MarcoFalke> yeah
4062019-10-24T19:00:51  <wumpus> #startmeeting
4072019-10-24T19:00:51  <lightningbot> Meeting started Thu Oct 24 19:00:51 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4082019-10-24T19:00:51  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4092019-10-24T19:00:58  <fanquake> Hi
4102019-10-24T19:00:59  <jonatack> hi
4112019-10-24T19:01:01  <sipa> hi
4122019-10-24T19:01:07  *** mdunnio has joined #bitcoin-core-dev
4132019-10-24T19:01:08  <jeremyrubin> hi
4142019-10-24T19:01:15  <MarcoFalke> I'd like to add #16975 and remove my current pull request from high prio
4152019-10-24T19:01:17  <gribble> https://github.com/bitcoin/bitcoin/issues/16975 | test: Show debug log on unit test failure by MarcoFalke · Pull Request #16975 · bitcoin/bitcoin · GitHub
4162019-10-24T19:01:22  *** belcher has quit IRC
4172019-10-24T19:01:32  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral
4182019-10-24T19:01:47  <amiti> hi
4192019-10-24T19:01:48  <moneyball> hi
4202019-10-24T19:01:48  <wumpus> #topic High priority for review
4212019-10-24T19:01:51  <kanzure> hi
4222019-10-24T19:01:57  <achow101> hi
4232019-10-24T19:02:00  <dongcarl> ih
4242019-10-24T19:02:06  <ariard> hi
4252019-10-24T19:02:51  <wumpus> MarcoFalke: done
4262019-10-24T19:03:07  <jamesob> hi
4272019-10-24T19:03:25  <MarcoFalke> thx
4282019-10-24T19:03:44  <MarcoFalke> https://github.com/bitcoin/bitcoin/projects/8
4292019-10-24T19:03:45  <fjahr> hi
4302019-10-24T19:03:45  <fanquake> I'll propose #17165 of mine, as that's now in a fairly reviewable state.
4312019-10-24T19:03:48  <gribble> https://github.com/bitcoin/bitcoin/issues/17165 | Remove BIP70 support by fanquake · Pull Request #17165 · bitcoin/bitcoin · GitHub
4322019-10-24T19:04:02  <provoostenator> hi
4332019-10-24T19:04:09  <jamesob> can I request we add #16442 to high prio?
4342019-10-24T19:04:13  <gribble> https://github.com/bitcoin/bitcoin/issues/16442 | Serve BIP 157 compact filters by jimpo · Pull Request #16442 · bitcoin/bitcoin · GitHub
4352019-10-24T19:04:25  <provoostenator> +1 for 16422
4362019-10-24T19:04:43  <wumpus> fanquake: added
4372019-10-24T19:04:47  *** JeremyCrookshank has joined #bitcoin-core-dev
4382019-10-24T19:05:01  <MarcoFalke> fanquake: Needs (trivial) rebase ;)
4392019-10-24T19:05:23  <wumpus> jamesob: provoostenator  also added
4402019-10-24T19:05:29  <jamesob> thanks!
4412019-10-24T19:05:39  <fanquake> MarcoFalke: I feel like thats at least the 3rd time I've had to rebase recently for that same file :o
4422019-10-24T19:05:47  <wumpus> which file ?
4432019-10-24T19:05:48  <provoostenator> Suggested topic BIP157 if we have time...
4442019-10-24T19:05:55  <fanquake> ci/test/00_setup_env_mac_functional.sh
4452019-10-24T19:06:18  <wumpus> oh, well, mac functional tests are gone now, you shouldn't have to rebase anymore for that
4462019-10-24T19:07:06  <instagibbs> hi
4472019-10-24T19:07:14  <wumpus> I think we have plenty of time, no topics have been suggested for today; though I think we need to discuss 0.19.0rc2 as well
4482019-10-24T19:07:28  <jtimon> can we add #17037 to chasing concept ack?
4492019-10-24T19:07:30  <gribble> https://github.com/bitcoin/bitcoin/issues/17037 | Testschains: Many regtests with different genesis and default datadir by jtimon · Pull Request #17037 · bitcoin/bitcoin · GitHub
4502019-10-24T19:07:41  <wumpus> #topic BIP157 (provoostenator)
4512019-10-24T19:08:01  <provoostenator> I found some issues while testing against Lnd / Btcd
4522019-10-24T19:08:18  <provoostenator> cc roasbeef
4532019-10-24T19:08:20  <wumpus> jtimon: added
4542019-10-24T19:08:22  <digi_james> hi
4552019-10-24T19:08:27  <jtimon> thanks
4562019-10-24T19:08:38  <instagibbs> provoostenator, testing what against, 0.19?
4572019-10-24T19:09:00  <provoostenator> btcd uses a max getcfilters of 1000
4582019-10-24T19:09:19  <provoostenator> Where the BIP uses 100
4592019-10-24T19:09:34  <jeremyrubin> suggested topic: mempool limits
4602019-10-24T19:09:37  <provoostenator> So the #16442 will disconnect from those
4612019-10-24T19:09:39  <gribble> https://github.com/bitcoin/bitcoin/issues/16442 | Serve BIP 157 compact filters by jimpo · Pull Request #16442 · bitcoin/bitcoin · GitHub
4622019-10-24T19:10:09  *** reallll is now known as belcher
4632019-10-24T19:10:12  <provoostenator> I believe the rationale for 100 was to get those messages to about 2 MB
4642019-10-24T19:10:22  <provoostenator> Bigger means fewer round dtrips for mobile.
4652019-10-24T19:10:33  <provoostenator> I don't know if there's a downside to bigger...
4662019-10-24T19:10:42  <provoostenator> We don't send these things unsollicited
4672019-10-24T19:11:20  <MarcoFalke> That sounds like a bug in either btcd or the bip? Maybe the mailing list is a better place to discuss?
4682019-10-24T19:11:21  <provoostenator> Converesy, we don't have a rate limiter for this in the PR. Lnd, when "misconfigured" will happily fetch gigabytes per minute...
4692019-10-24T19:11:50  <provoostenator> Yeah, mailinglist makes sense regardless, but was hoping to find opinions here first.
4702019-10-24T19:12:09  <sipa> provoostenator: how does the misconfiguration manifest?
4712019-10-24T19:12:15  <sipa> is it fetching the same block over and over?
4722019-10-24T19:12:35  <provoostenator> sipa: when it checks lightning channel gossip, it refetches old filters all the time
4732019-10-24T19:12:41  <provoostenator> That's an Lnd bug imo
4742019-10-24T19:12:57  <provoostenator> But someone can do this intentionally too
4752019-10-24T19:13:10  *** Highway61 has quit IRC
4762019-10-24T19:13:30  <sipa> of course
4772019-10-24T19:13:33  <provoostenator> Do we have any rate limiting on block fetching and such?
4782019-10-24T19:13:43  *** promag has quit IRC
4792019-10-24T19:13:50  *** Venom80 has joined #bitcoin-core-dev
4802019-10-24T19:14:05  *** promag has joined #bitcoin-core-dev
4812019-10-24T19:14:09  <sipa> not afaik
4822019-10-24T19:14:30  <provoostenator> Ok, I guess in that case there's not much precedent to add it for filters.
4832019-10-24T19:14:35  <wumpus> no, there's no rate limiting on block fetching
4842019-10-24T19:15:05  <wumpus> it's only limited by the I/O speeds, disk and network
4852019-10-24T19:15:33  <MarcoFalke> or by -maxuploadtarget
4862019-10-24T19:16:13  <wumpus> the extra DoS vector with bloom filters is that it allowed to do a DoS on the disk without actually having to receive the data over the network, but, it's easy to saturate bandwidth
4872019-10-24T19:16:23  <wumpus> yes, there's that
4882019-10-24T19:16:40  <jnewbery> Can we add #15934 to high priority? It's blocking three other PRs which add quite nice functionality (#15935, #15936, #15937)
4892019-10-24T19:16:43  <gribble> https://github.com/bitcoin/bitcoin/issues/15934 | Merge settings one place instead of five places by ryanofsky · Pull Request #15934 · bitcoin/bitcoin · GitHub
4902019-10-24T19:16:45  <gribble> https://github.com/bitcoin/bitcoin/issues/15935 | WIP: Add /settings.json persistent settings storage by ryanofsky · Pull Request #15935 · bitcoin/bitcoin · GitHub
4912019-10-24T19:16:46  <gribble> https://github.com/bitcoin/bitcoin/issues/15936 | WIP: Unify bitcoin-qt and bitcoind persistent settings by ryanofsky · Pull Request #15936 · bitcoin/bitcoin · GitHub
4922019-10-24T19:16:48  <gribble> https://github.com/bitcoin/bitcoin/issues/15937 | WIP: Add loadwallet and createwallet load_on_startup options by ryanofsky · Pull Request #15937 · bitcoin/bitcoin · GitHub
4932019-10-24T19:16:53  <sipa> BIP157 doesn't have the same problem as the I/O required is proportional to what is sent over the network
4942019-10-24T19:16:59  <wumpus> right
4952019-10-24T19:17:25  <wumpus> jnewbery: sure, though I think with 10 blockers in high prio we're kind of pushing it
4962019-10-24T19:17:26  <jamesob> +1 on 15934
4972019-10-24T19:17:35  <jamesob> (but agree the list is getting long)
4982019-10-24T19:17:43  <provoostenator> Ok, so any thoughts on the maximum size of filter messages we send (ignoring the BIP)?
4992019-10-24T19:17:49  <jnewbery> wumpus: how about if I promise to review some of the other ones? :)
5002019-10-24T19:18:04  <instagibbs> wumpus, people have different interests in subtopics, i dont think "long" hurts more than too many type collsions
5012019-10-24T19:18:17  <wumpus> jnewbery: great!
5022019-10-24T19:18:50  <wumpus> instagibbs: 10 is fine
5032019-10-24T19:18:57  <instagibbs> :)
5042019-10-24T19:19:38  <jeremyrubin> I've been making fine progress on the things that depend on #16766, so am OK with either removing from high priority while it gets more review or else I think it's basically mergeable now.
5052019-10-24T19:19:41  <gribble> https://github.com/bitcoin/bitcoin/issues/16766 | wallet: Make IsTrusted scan parents recursively by JeremyRubin · Pull Request #16766 · bitcoin/bitcoin · GitHub
5062019-10-24T19:20:11  <wumpus> #topic 0.19.0rc2
5072019-10-24T19:20:11  *** arik_ has quit IRC
5082019-10-24T19:20:41  <fanquake> https://github.com/bitcoin/bitcoin/milestones/0.19.0
5092019-10-24T19:20:42  <wumpus> there have been quite a few things merged since rc1, and some time has passed, I think it is time to tag rc2?
5102019-10-24T19:20:45  *** JJ34 has joined #bitcoin-core-dev
5112019-10-24T19:20:59  <fanquake> I agree. I think I backported most/all of the bug fixes
5122019-10-24T19:21:22  <wumpus> #17120 should make it in probably
5132019-10-24T19:21:24  <gribble> https://github.com/bitcoin/bitcoin/issues/17120 | gui: Fix start timer from non QThread by promag · Pull Request #17120 · bitcoin/bitcoin · GitHub
5142019-10-24T19:21:58  *** kabaum has quit IRC
5152019-10-24T19:22:03  <fanquake> I'd sort of lost whats been happening in there. Also nother GUI only issue.
5162019-10-24T19:22:06  *** cryptoIndio has joined #bitcoin-core-dev
5172019-10-24T19:22:15  <provoostenator> That definately needs to be in an rc.
5182019-10-24T19:22:17  <wumpus> it's an actual serious bug, which can result in crashes
5192019-10-24T19:22:29  <MarcoFalke> so #17112 is not going to get fixed?
5202019-10-24T19:22:30  <gribble> https://github.com/bitcoin/bitcoin/issues/17112 | v0.19.0rc1 GUI repeatedly not responding · Issue #17112 · bitcoin/bitcoin · GitHub
5212019-10-24T19:22:53  <provoostenator> MarcoFalke: #1712 fixes that
5222019-10-24T19:22:54  <gribble> https://github.com/bitcoin/bitcoin/issues/1712 | Qt: possible bug related to immature balance? · Issue #1712 · bitcoin/bitcoin · GitHub
5232019-10-24T19:22:58  <wumpus> (creating qt objects like timers outside the GUI thread should be considered *really* carefully)
5242019-10-24T19:22:58  <fanquake> I opened the original issue that that is fixing. The crashes only occur, or at least the ones I saw, when you run with FATAL_WARNINGS
5252019-10-24T19:23:05  <fanquake> Which turns warnings into crashes
5262019-10-24T19:23:12  <MarcoFalke> provoostenator: Does it?
5272019-10-24T19:23:25  <provoostenator> MarcoFalke: I meant #17120
5282019-10-24T19:23:27  <gribble> https://github.com/bitcoin/bitcoin/issues/17120 | gui: Fix start timer from non QThread by promag · Pull Request #17120 · bitcoin/bitcoin · GitHub
5292019-10-24T19:23:35  <wumpus> remember, qt is essentially single-threaded
5302019-10-24T19:23:43  <wumpus> at least the GUI part
5312019-10-24T19:24:04  <fanquake> We are still talking about fixing this right #16296 ?
5322019-10-24T19:24:05  <gribble> https://github.com/bitcoin/bitcoin/issues/16296 | gui: crash with loadwallet & QT_FATAL_WARNINGS · Issue #16296 · bitcoin/bitcoin · GitHub
5332019-10-24T19:24:25  <wumpus> I'm talking about the fix in #17120
5342019-10-24T19:24:27  <gribble> https://github.com/bitcoin/bitcoin/issues/17120 | gui: Fix start timer from non QThread by promag · Pull Request #17120 · bitcoin/bitcoin · GitHub
5352019-10-24T19:24:39  <MarcoFalke> provoostenator: I thought that #17135 fixes it, but that isn't tagged for backport
5362019-10-24T19:24:41  <gribble> https://github.com/bitcoin/bitcoin/issues/17135 | gui: Make polling in ClientModel asynchronous by promag · Pull Request #17135 · bitcoin/bitcoin · GitHub
5372019-10-24T19:25:03  <wumpus> MarcoFalke: we're not sure that that fixes it, and it's too risky to merge between RCs imo
5382019-10-24T19:25:07  <fanquake> Right, 17120 will close 16296
5392019-10-24T19:25:17  <provoostenator> MarcoFalke: for the freeze UI problem there were two seperate solutions, I only tested 17120, which fixes it
5402019-10-24T19:25:33  <MarcoFalke> Ah nice
5412019-10-24T19:26:19  <fanquake> So should 17120 be high-prio, and once it's merged we tag an rc2 ?
5422019-10-24T19:26:32  <fanquake> Or do we have other rc blockers?
5432019-10-24T19:26:46  <wumpus> sgtm
5442019-10-24T19:27:12  <promag> provoostenator: wat?
5452019-10-24T19:27:16  *** cryptoIndio has quit IRC
5462019-10-24T19:27:20  <wumpus> #17035, though tagged 0.19.0 is definitely not a blocker imo
5472019-10-24T19:27:23  <gribble> https://github.com/bitcoin/bitcoin/issues/17035 | qt: Fix text display when state of prune button is changed by emilengler · Pull Request #17035 · bitcoin/bitcoin · GitHub
5482019-10-24T19:27:35  <wumpus> it's also nowhere near ready
5492019-10-24T19:27:40  <MarcoFalke> provoostenator: If that is the case, the pull should mention it somewhere
5502019-10-24T19:27:42  <promag> 17120 fixes UI freeze?
5512019-10-24T19:28:00  <MarcoFalke> yeah, I am doubtful as well
5522019-10-24T19:28:02  <emilengler> wumpus: The current text is a bit misleading IMO
5532019-10-24T19:28:13  <emilengler> Same with storage etc.
5542019-10-24T19:28:16  <MarcoFalke> emilengler: Is it a regression?
5552019-10-24T19:28:18  <wumpus> emilengler: yes, it is, I don't disagree
5562019-10-24T19:28:23  <MarcoFalke> If not, it can go in 0.19.1
5572019-10-24T19:28:40  <provoostenator> Oh wait, #17133 fixes those, argh
5582019-10-24T19:28:42  <gribble> https://github.com/bitcoin/bitcoin/issues/17133 | 0.19: gui: Fix start timer from non QThread by promag · Pull Request #17133 · bitcoin/bitcoin · GitHub
5592019-10-24T19:28:54  <promag> IMO both 17120 and 17135 should go to RC
5602019-10-24T19:29:05  <sipa> #17135
5612019-10-24T19:29:08  <gribble> https://github.com/bitcoin/bitcoin/issues/17135 | gui: Make polling in ClientModel asynchronous by promag · Pull Request #17135 · bitcoin/bitcoin · GitHub
5622019-10-24T19:29:41  <provoostenator> What sipa says, that's the one I tested. Indeed that needs to go in the rc too
5632019-10-24T19:30:07  <wumpus> I still think it's too much of a change to go in a rc, but ok...
5642019-10-24T19:30:41  <sipa> (to be clear i don't have a strong opinion on the issue; i was just trying to quickly check what 17135 was)
5652019-10-24T19:30:51  <promag> wumpus: what changes if you only merge after rc?
5662019-10-24T19:31:06  <wumpus> promag: it can be in master for a while
5672019-10-24T19:31:08  <MarcoFalke> I think the changes are straightforward (moving polling to a new thread)
5682019-10-24T19:31:17  <wumpus> so this creates a thread per wallet?
5692019-10-24T19:31:18  <MarcoFalke> What could possibly go wrong?
5702019-10-24T19:31:25  <wumpus> yes, what could possibly go wrong...
5712019-10-24T19:31:39  <promag> wumpus: no, one thread only
5722019-10-24T19:31:46  <sipa> last week we discussed reverting the change that exacerbated the issue; i assume that's considered too complicated?
5732019-10-24T19:32:02  <promag> ClientModel is singleton I think?
5742019-10-24T19:32:09  <wumpus> clientmodel is
5752019-10-24T19:32:15  <MarcoFalke> sipa: I think a lot more can go wrong when we remove all the lock annotations in validation/mempool
5762019-10-24T19:32:20  <promag> sipa: not a clean revert by far
5772019-10-24T19:32:21  <MarcoFalke> and restore the 0.18.0 mempool locks
5782019-10-24T19:32:27  *** owowo has quit IRC
5792019-10-24T19:32:28  <fanquake> sipa: At least in my opinion, reverting a mempool related bug fix to "fix" the gui doesn't seem like the way to go.
5802019-10-24T19:32:29  <sipa> MarcoFalke: that's fair
5812019-10-24T19:32:40  <MarcoFalke> agree with fanquake
5822019-10-24T19:32:42  <promag> too many lock annotations and other refactors were merged
5832019-10-24T19:33:05  <wumpus> yes, the revert is a mess
5842019-10-24T19:33:08  <sipa> ok
5852019-10-24T19:33:36  <MarcoFalke> With the gui fix the worst that could happen is that the polling in the new thread just does not work at all?
5862019-10-24T19:33:37  <promag> well I guess its ok too have a UI freezing in a RC
5872019-10-24T19:33:46  *** cryptoIndio has joined #bitcoin-core-dev
5882019-10-24T19:33:46  <wumpus> a lot can go wrong with qt and threads
5892019-10-24T19:34:11  <MarcoFalke> I don't know a lot about qt, so I should probably shut up
5902019-10-24T19:34:28  <promag> In this particular case I think it's fine - threading with loading wallets etc was more tricky
5912019-10-24T19:34:36  <wumpus> like, if you update the GUI from any thread but the GUI thread, you risk a race/crash
5922019-10-24T19:34:54  <MarcoFalke> crash doesn't sound too nice
5932019-10-24T19:35:21  <wumpus> it's worse than a temporary hang anyhow
5942019-10-24T19:36:33  <wumpus> anyhow, I think what 17135 does is correct
5952019-10-24T19:36:46  <wumpus> it only emits signals from the thread right?
5962019-10-24T19:36:52  <promag> right
5972019-10-24T19:36:53  *** owowo has joined #bitcoin-core-dev
5982019-10-24T19:37:52  <wumpus> wait, no, it's not correct
5992019-10-24T19:38:00  <promag> acquires the locks -> reads -> enqueues signal events to gui event loop -> repeat
6002019-10-24T19:38:07  *** jcorgan has joined #bitcoin-core-dev
6012019-10-24T19:38:07  <wumpus> you move pollTimer to the thread then in the destructor, delete it in the main thread
6022019-10-24T19:38:23  <MarcoFalke> Is there anything we need to do about this macOS crap?
6032019-10-24T19:38:23  <wumpus> no I'm not 100% sure about this
6042019-10-24T19:38:25  <MarcoFalke> #16387
6052019-10-24T19:38:26  <gribble> https://github.com/bitcoin/bitcoin/issues/16387 | macOS Catalina · Issue #16387 · bitcoin/bitcoin · GitHub
6062019-10-24T19:38:40  <promag> wumpus: that's fine the thread is alread stopped
6072019-10-24T19:38:47  <wumpus> promag: I don't think that makes it ok
6082019-10-24T19:38:55  <provoostenator> So macOs requires ./configure CFLAGS="-fno-stack-check"
6092019-10-24T19:38:59  <fanquake> MarcoFalke: I have not upgraded to 10.15, so someone else will have to comment
6102019-10-24T19:39:15  <wumpus> e.g. the timer affects the local event loop of the thread
6112019-10-24T19:39:15  <provoostenator> For secp256k1 tests to pass
6122019-10-24T19:39:22  <wumpus> deleting it somewhere else might mess with the main event loop
6132019-10-24T19:39:24  <provoostenator> No idea if that's a sane config flag.
6142019-10-24T19:39:33  <promag> but I stop and join the thread
6152019-10-24T19:39:40  <wumpus> I know
6162019-10-24T19:39:56  <promag> so the timer's event-loop is no longer running
6172019-10-24T19:40:08  <wumpus> but things need to be deleted inthe thread that owns them
6182019-10-24T19:40:39  <promag> yes, if the event loop is running
6192019-10-24T19:40:42  <wumpus> no, always
6202019-10-24T19:40:50  *** cryptoIndio has quit IRC
6212019-10-24T19:40:55  <promag> ref?
6222019-10-24T19:40:57  *** jcorgan_ has quit IRC
6232019-10-24T19:41:20  <promag> I can change to deleteLater(); quit(); wait() if you prefer
6242019-10-24T19:41:29  <wumpus> I'd rather have that you find for sure that this is safe
6252019-10-24T19:41:35  *** EagleTM has joined #bitcoin-core-dev
6262019-10-24T19:41:36  <promag> wumpus: deal
6272019-10-24T19:41:58  <wumpus> we've had some horrible crashes due to things like this w/ the debug console thread
6282019-10-24T19:42:20  <wumpus> it takes some very careful steps there to delete everything in the thread that owns it
6292019-10-24T19:42:42  <wumpus> provoostenator: what does no-stack-check do?
6302019-10-24T19:42:50  *** Venom80 has quit IRC
6312019-10-24T19:43:17  <provoostenator> No idea, elichai2 found this "fix" in https://github.com/bitcoin-core/secp256k1/issues/674
6322019-10-24T19:43:22  <wumpus> it doesn't disable any hardening features does it?
6332019-10-24T19:44:36  <elichai2> provoostenator: I hope this bug will be fixed before the stable release
6342019-10-24T19:44:46  <wumpus> can we find out what code makes this necessary? is it a bug on our end?
6352019-10-24T19:44:50  <elichai2> wumpus: sounds like a weird story https://stackoverflow.com/questions/10712972/what-is-the-use-of-fno-stack-protector
6362019-10-24T19:45:26  <elichai2> wait it Catalina stable already?
6372019-10-24T19:45:38  <fjahr> elichai2: I thought this was a compiler bug!?
6382019-10-24T19:45:40  <fjahr> yes
6392019-10-24T19:45:45  <wumpus> yes stack protector is what protects against buffer overflows on the stack
6402019-10-24T19:45:53  <MarcoFalke> why can't apple fix their crap?
6412019-10-24T19:46:00  <provoostenator> Catalina is released yes, they even did a few security patches...
6422019-10-24T19:46:02  <elichai2> fjahr: sounds like a compiler bug. https://forums.developer.apple.com/thread/121887 https://trac.ffmpeg.org/ticket/8073
6432019-10-24T19:46:19  <elichai2> but I don't have a mac to try and dive deep into this
6442019-10-24T19:46:19  <wumpus> we're definitely not going to disable that by default, if people want to use such a work-around they're on their own
6452019-10-24T19:46:32  <elichai2> wumpus: +1
6462019-10-24T19:46:57  <provoostenator> The gitian / rc binaries work fine, so I indeed wouldn't change anything there.
6472019-10-24T19:47:01  <elichai2> My comment was more as a step in debugging this :) I really don't know the consequences of actually using this
6482019-10-24T19:47:26  <elichai2> the bug is in AVX assembly *produced by the compiler* (i.e. secp has no avx)
6492019-10-24T19:47:31  *** cryptoIndio has joined #bitcoin-core-dev
6502019-10-24T19:48:21  <wumpus> ok, nothing for us to do there then
6512019-10-24T19:48:41  <elichai2> isn't it possible to just compile clang on Mac OS and use all of the llvm ecosystem instead of xcode?
6522019-10-24T19:48:52  <elichai2> but yeah, off topic
6532019-10-24T19:49:25  <wumpus> any other topics?
6542019-10-24T19:50:16  <wumpus> #endmeeting
6552019-10-24T19:50:16  <lightningbot> Meeting ended Thu Oct 24 19:50:16 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6562019-10-24T19:50:16  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-24-19.00.html
6572019-10-24T19:50:16  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-24-19.00.txt
6582019-10-24T19:50:16  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-10-24-19.00.log.html
6592019-10-24T19:50:50  *** mdunnio has quit IRC
6602019-10-24T19:51:07  <jeremyrubin> I guess it's fine for post meeting; but I wanted to get examples/edge cases people know of bad mempool behaviors that justify the limits currently and collect any tests people have written to benchmark this
6612019-10-24T19:51:15  *** mdunnio has joined #bitcoin-core-dev
6622019-10-24T19:52:14  <jeremyrubin> Because I think there's a bit of a documentation gap for why certain limits exist and the intended protection (or, if additional protections conferred became known post-hoc)
6632019-10-24T19:52:18  <instagibbs> Unfortunately lots of mempool design is communal knowledge spread among like 5 people.
6642019-10-24T19:52:24  *** bitcoin-git has joined #bitcoin-core-dev
6652019-10-24T19:52:25  <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #17243: tools: add PoissonNextSend method that returns mockable time (master...1910-mockable-poisson) https://github.com/bitcoin/bitcoin/pull/17243
6662019-10-24T19:52:26  *** bitcoin-git has left #bitcoin-core-dev
6672019-10-24T19:52:33  *** cryptoIndio has quit IRC
6682019-10-24T19:54:09  <jeremyrubin> instagibbs: this is one way to fix it ;)
6692019-10-24T19:55:09  <wumpus> jeremyrubin: oh sorry I forgot your topic
6702019-10-24T19:55:22  <instagibbs> I'm concept ACKing your call. I've previously asked for a "philosophy of design" type document, sdaftuar wrote something(now I cannot find the link, oops)
6712019-10-24T19:55:22  <wumpus> jeremyrubin: maybe propose it for next week
6722019-10-24T19:55:56  <instagibbs> oh here we go jeremyrubin https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Design-Philosophy
6732019-10-24T19:56:31  <instagibbs> that seems to be more block related, but transaction gossiping would be a good one
6742019-10-24T19:56:56  *** cryptoIndio has joined #bitcoin-core-dev
6752019-10-24T19:58:51  *** jkczyz has quit IRC
6762019-10-24T19:59:22  <wumpus> elichai2: it looks like -fno-stack-check disables stack alignment check, not security checks like the stack protector
6772019-10-24T20:00:27  <wumpus> hm or maybe not, I'm not sure
6782019-10-24T20:00:51  <elichai2> well theoretically x86 is fine with unaligned reads/writes. altough I have no idea if it's even related to this :D
6792019-10-24T20:01:33  <wumpus> I think there's an exception for some instructions like AVX2
6802019-10-24T20:01:34  <sipa> movdqa requires aligned arguments
6812019-10-24T20:01:48  *** cryptoIndio has quit IRC
6822019-10-24T20:04:54  <elichai2> <elichai2> the bug is in AVX assembly *produced by the compiler* (i.e. secp has no avx)
6832019-10-24T20:05:19  <elichai2> wumpus: oh. you meant about read alignments. sorry
6842019-10-24T20:05:41  *** cryptoIndio has joined #bitcoin-core-dev
6852019-10-24T20:05:55  <wumpus> thinking of it, it might generate that AVX code to check the stack cookie
6862019-10-24T20:06:25  <wumpus> assuming the stack pointer is aligned
6872019-10-24T20:06:34  *** thoragh has quit IRC
6882019-10-24T20:08:34  *** captjakk has quit IRC
6892019-10-24T20:10:26  *** cryptoIndio has quit IRC
6902019-10-24T20:11:32  *** cryptoIndio has joined #bitcoin-core-dev
6912019-10-24T20:12:39  *** captjakk_ has joined #bitcoin-core-dev
6922019-10-24T20:14:42  <sdaftuar> instagibbs: i also have some high level slides lying around somewhere that explain mempool design if you're interested
6932019-10-24T20:15:57  *** cryptoIndio has quit IRC
6942019-10-24T20:16:36  *** promag has quit IRC
6952019-10-24T20:16:58  *** EagleTM has quit IRC
6962019-10-24T20:18:41  <instagibbs> sure
6972019-10-24T20:20:28  *** cryptoIndio has joined #bitcoin-core-dev
6982019-10-24T20:21:10  *** JJ34 has quit IRC
6992019-10-24T20:24:50  *** cryptoIndio has quit IRC
7002019-10-24T20:27:56  *** jarthur has quit IRC
7012019-10-24T20:29:07  *** captjakk_ has quit IRC
7022019-10-24T20:29:41  *** captjakk has joined #bitcoin-core-dev
7032019-10-24T20:30:21  *** cryptoIndio has joined #bitcoin-core-dev
7042019-10-24T20:33:43  *** jkczyz has joined #bitcoin-core-dev
7052019-10-24T20:34:03  *** captjakk has quit IRC
7062019-10-24T20:34:43  *** captjakk has joined #bitcoin-core-dev
7072019-10-24T20:34:50  *** arik_ has joined #bitcoin-core-dev
7082019-10-24T20:35:06  *** cryptoIndio has quit IRC
7092019-10-24T20:35:52  *** captjakk has quit IRC
7102019-10-24T20:38:18  *** Guyver2 has quit IRC
7112019-10-24T20:40:08  *** cryptoIndio has joined #bitcoin-core-dev
7122019-10-24T20:44:58  *** justanotheruser has quit IRC
7132019-10-24T20:46:24  *** JeremyCrookshank has quit IRC
7142019-10-24T20:46:26  *** cryptoIndio has quit IRC
7152019-10-24T20:47:35  *** arik_ has quit IRC
7162019-10-24T20:48:48  *** arik_ has joined #bitcoin-core-dev
7172019-10-24T20:50:42  *** JJ34 has joined #bitcoin-core-dev
7182019-10-24T20:57:39  *** Deacyde has joined #bitcoin-core-dev
7192019-10-24T20:57:41  *** cryptoIndio has joined #bitcoin-core-dev
7202019-10-24T21:00:01  *** MarkusH1 has quit IRC
7212019-10-24T21:00:09  *** mmgen has quit IRC
7222019-10-24T21:02:36  *** captjakk has joined #bitcoin-core-dev
7232019-10-24T21:02:51  *** cryptoIndio has quit IRC
7242019-10-24T21:03:32  *** captjakk has quit IRC
7252019-10-24T21:05:08  *** cryptoIndio has joined #bitcoin-core-dev
7262019-10-24T21:05:31  *** captjakk_ has joined #bitcoin-core-dev
7272019-10-24T21:08:39  *** Highway61 has joined #bitcoin-core-dev
7282019-10-24T21:09:38  *** cryptoIndio has quit IRC
7292019-10-24T21:12:44  *** Skirmant has joined #bitcoin-core-dev
7302019-10-24T21:13:56  *** cryptoIndio has joined #bitcoin-core-dev
7312019-10-24T21:17:29  *** b_b1 has joined #bitcoin-core-dev
7322019-10-24T21:19:20  *** nosss2 has quit IRC
7332019-10-24T21:20:44  *** cryptoIndio has quit IRC
7342019-10-24T21:22:39  *** JJ34 has quit IRC
7352019-10-24T21:22:54  <jonatack> jeremyrubin: Thanks, it seems like a good idea to assemble this information, building on jnewbery's document instagibbs linked to and sdaftuar's slides. I'd be interested.
7362019-10-24T21:26:26  *** captjakk has joined #bitcoin-core-dev
7372019-10-24T21:26:30  <elichai2> I just tried to convert `DecodeDumpTime` from using boost to `std::get_time` and chrono. and got into timezone rabbit hole
7382019-10-24T21:26:33  * elichai2 facepalm
7392019-10-24T21:26:47  *** cryptoIndio has joined #bitcoin-core-dev
7402019-10-24T21:27:45  *** nosss2 has joined #bitcoin-core-dev
7412019-10-24T21:28:04  *** bitcoin-git has joined #bitcoin-core-dev
7422019-10-24T21:28:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4af044716952...773026044f9d
7432019-10-24T21:28:05  <bitcoin-git> bitcoin/master 5b44a75 Sebastian Falbesoner: refactor: Remove unused CExt{Pub,}Key (de)serialization methods
7442019-10-24T21:28:06  <bitcoin-git> bitcoin/master 7730260 MarcoFalke: Merge #17212: refactor: Remove unused CExt{Pub,}Key (de)serialization meth...
7452019-10-24T21:28:07  *** bitcoin-git has left #bitcoin-core-dev
7462019-10-24T21:28:24  *** bitcoin-git has joined #bitcoin-core-dev
7472019-10-24T21:28:24  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17212: refactor: Remove unused CExt{Pub,}Key (de)serialization methods (master...20191021-refactor-remove_unused_cextkey_and_cextpubkey_serialization) https://github.com/bitcoin/bitcoin/pull/17212
7482019-10-24T21:28:25  *** bitcoin-git has left #bitcoin-core-dev
7492019-10-24T21:30:22  <MarcoFalke> elichai2: when pull request?
7502019-10-24T21:30:50  <elichai2> C++20? lol
7512019-10-24T21:30:57  <MarcoFalke> Oh
7522019-10-24T21:31:05  <MarcoFalke> So we will never get rid of boost
7532019-10-24T21:31:21  <elichai2> https://en.cppreference.com/w/cpp/chrono/time_zone
7542019-10-24T21:31:44  <elichai2> i'm joking, trying to work on a weirder way, just really hoped I can do it using libstd
7552019-10-24T21:31:50  *** cryptoIndio has quit IRC
7562019-10-24T21:32:00  *** nosss2 has quit IRC
7572019-10-24T21:33:14  *** michaelfolkson has joined #bitcoin-core-dev
7582019-10-24T21:33:38  *** mdunnio has quit IRC
7592019-10-24T21:33:51  *** cryptoIndio has joined #bitcoin-core-dev
7602019-10-24T21:36:28  *** mdunnio has joined #bitcoin-core-dev
7612019-10-24T21:37:32  *** Guyver2 has joined #bitcoin-core-dev
7622019-10-24T21:37:36  <luke-jr> [19:16:40] <jnewbery> Can we add #15934 to high priority? It's blocking three other PRs which add quite nice functionality (#15935, #15936, #15937) <-- more like conflciting with..
7632019-10-24T21:37:42  <gribble> https://github.com/bitcoin/bitcoin/issues/15934 | Merge settings one place instead of five places by ryanofsky · Pull Request #15934 · bitcoin/bitcoin · GitHub
7642019-10-24T21:37:43  <gribble> https://github.com/bitcoin/bitcoin/issues/15935 | WIP: Add /settings.json persistent settings storage by ryanofsky · Pull Request #15935 · bitcoin/bitcoin · GitHub
7652019-10-24T21:37:44  <gribble> https://github.com/bitcoin/bitcoin/issues/15936 | WIP: Unify bitcoin-qt and bitcoind persistent settings by ryanofsky · Pull Request #15936 · bitcoin/bitcoin · GitHub
7662019-10-24T21:37:45  <gribble> https://github.com/bitcoin/bitcoin/issues/15937 | WIP: Add loadwallet and createwallet load_on_startup options by ryanofsky · Pull Request #15937 · bitcoin/bitcoin · GitHub
7672019-10-24T21:37:50  *** victorSN has quit IRC
7682019-10-24T21:37:50  *** rockhouse has quit IRC
7692019-10-24T21:38:14  *** rockhouse has joined #bitcoin-core-dev
7702019-10-24T21:38:18  *** Guyver2 has quit IRC
7712019-10-24T21:38:37  *** cryptoIndio has quit IRC
7722019-10-24T21:39:14  <luke-jr> oh, those listed are the poorly rewritten ones :/
7732019-10-24T21:39:21  *** cryptoIndio has joined #bitcoin-core-dev
7742019-10-24T21:39:32  <luke-jr> #11082 should go in instead ;)
7752019-10-24T21:39:34  <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
7762019-10-24T21:42:23  *** Deacyde has quit IRC
7772019-10-24T21:44:26  *** rex4539 has quit IRC
7782019-10-24T21:46:14  <jonatack> luke-jr: your PR came up in the review club discussion yesterday (https://bitcoincore.reviews/15934.html). Seems PRs 11082 and 15934 ought to be reviewed concurrently then.
7792019-10-24T21:47:52  *** cryptoIndio has quit IRC
7802019-10-24T21:48:29  <luke-jr> jonatack: well, 11082 vs 15935 really; 15934 is probably rebasable
7812019-10-24T21:49:31  <luke-jr> 11082 has been in production use for years at this point
7822019-10-24T21:50:21  *** cryptoIndio has joined #bitcoin-core-dev
7832019-10-24T21:51:15  <jonatack> luke-jr: in https://bitcoinknots.org?
7842019-10-24T21:51:36  <luke-jr> yes
7852019-10-24T21:52:32  <luke-jr> since 2016, apparently
7862019-10-24T21:52:37  *** justanotheruser has joined #bitcoin-core-dev
7872019-10-24T21:52:55  <elichai2> does boost test framework gives us a way to unit test static functions?
7882019-10-24T21:53:41  *** bitcoin-git has joined #bitcoin-core-dev
7892019-10-24T21:53:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/773026044f9d...fce7c7542234
7902019-10-24T21:53:41  <bitcoin-git> bitcoin/master 168b781 Anthony Towns: Continue relaying transactions after they expire from mapRelay
7912019-10-24T21:53:42  <bitcoin-git> bitcoin/master fce7c75 MarcoFalke: Merge #16851: Continue relaying transactions after they expire from mapRel...
7922019-10-24T21:53:43  *** bitcoin-git has left #bitcoin-core-dev
7932019-10-24T21:54:01  *** bitcoin-git has joined #bitcoin-core-dev
7942019-10-24T21:54:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16851: Continue relaying transactions after they expire from mapRelay (master...201909-relayparents) https://github.com/bitcoin/bitcoin/pull/16851
7952019-10-24T21:54:02  *** bitcoin-git has left #bitcoin-core-dev
7962019-10-24T21:54:19  <MarcoFalke> elichai2: no
7972019-10-24T21:55:16  *** cryptoIndio has quit IRC
7982019-10-24T21:55:34  <elichai2> MarcoFalke: so if I want to add a unit test to a static function I must make it non-static?
7992019-10-24T21:55:41  <MarcoFalke> yes
8002019-10-24T21:55:53  *** jkczyz has quit IRC
8012019-10-24T21:55:56  <MarcoFalke> otherwise it wouldn't be properly linked into the test_bitcoin, I think
8022019-10-24T21:57:10  * luke-jr wonders if he should submit PRs for everything blocked on #11082..
8032019-10-24T21:57:13  <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
8042019-10-24T21:57:54  <elichai2> MarcoFalke: well one ugly way would be to `#include` the cpp file heh
8052019-10-24T21:57:59  <sipa> you can test a static function if it's defined in the same compilation unit as the test
8062019-10-24T21:58:07  <sipa> anything else would grossly violate C++
8072019-10-24T21:58:30  <sipa> (that's the definition of static: accessible within the same compilation unit)
8082019-10-24T21:58:48  <MarcoFalke> elichai2: Oh right. Forgot about that, but I'd rather not do that.
8092019-10-24T21:58:56  <elichai2> sipa: so if i'm testing a static function from rpcdump.cpp in wallet_tests.cpp I must make it non static :/
8102019-10-24T21:59:10  <sipa> yes
8112019-10-24T21:59:16  *** cryptoIndio has joined #bitcoin-core-dev
8122019-10-24T21:59:23  <sipa> or put in a .h file, and make it static inline; that also works :p
8132019-10-24T21:59:36  <sipa> or just static;
8142019-10-24T21:59:39  <elichai2> MarcoFalke: yeah, that's seriously ugly and would give us trouble in the future on using the wrong types / redeclaring the same functions etc.
8152019-10-24T22:00:16  <luke-jr> sipa: I think we've been moving away from that?
8162019-10-24T22:00:24  <elichai2> I guess no static it is
8172019-10-24T22:00:51  * luke-jr remembers when GetMinFee was in .h
8182019-10-24T22:01:20  <nothingmuch> typically what is the rationale behind making things static (not in general, in core)?
8192019-10-24T22:01:45  <luke-jr> so the compiler cna inline it?
8202019-10-24T22:02:01  <elichai2> nothingmuch: I would guess if it's a small function used only in that compilation unit that you want to be easily inlined
8212019-10-24T22:02:11  <sipa> s/easily//
8222019-10-24T22:02:16  <MarcoFalke> elichai2: Which function is it?
8232019-10-24T22:02:18  <elichai2> core doesn't get special treatment from gcc yet :P
8242019-10-24T22:02:24  <elichai2> MarcoFalke: DecodeDumpTime
8252019-10-24T22:02:46  <elichai2> wrote a test case that asserts that the old and new ones returns the same value
8262019-10-24T22:03:47  <sipa> something in another compilation unit cannot be inlined (except through LTO)
8272019-10-24T22:03:54  *** cryptoIndio has quit IRC
8282019-10-24T22:03:55  <nothingmuch> thanks, i thought maybe it was something more... in that case wouldn't a non static wrapper also do the job?
8292019-10-24T22:04:43  <MarcoFalke> Yeah, that should be exposed in the header I guess
8302019-10-24T22:04:49  <elichai2> sipa: yeah but in the same compilation unit people tend to think(hope?) that static has more chance to be inlined
8312019-10-24T22:05:03  *** cryptoIndio has joined #bitcoin-core-dev
8322019-10-24T22:05:22  <MarcoFalke> for rpc code such inline performance doesn't matter
8332019-10-24T22:05:45  *** Chris_Stewart_5 has quit IRC
8342019-10-24T22:06:25  <MarcoFalke> also, the rpc*.cpp files should not contain any logic except parsing UniValue and then calling an util function
8352019-10-24T22:09:17  *** cryptoIndio has quit IRC
8362019-10-24T22:09:29  *** Zenton has quit IRC
8372019-10-24T22:10:44  *** michaelfolkson has quit IRC
8382019-10-24T22:10:52  *** jkczyz has joined #bitcoin-core-dev
8392019-10-24T22:11:38  <elichai2> MarcoFalke: so to which header do you think it should move? rpcwallet.h?
8402019-10-24T22:13:26  *** cryptoIndio has joined #bitcoin-core-dev
8412019-10-24T22:15:02  *** Deacyde has joined #bitcoin-core-dev
8422019-10-24T22:16:30  <MarcoFalke> That's the easiest for now
8432019-10-24T22:17:07  <MarcoFalke> If you feel fancy, you could move it to something like ./src/wallet/util
8442019-10-24T22:20:33  *** cryptoIndio has quit IRC
8452019-10-24T22:27:37  *** ensign has quit IRC
8462019-10-24T22:27:38  *** nsh has quit IRC
8472019-10-24T22:30:13  *** cryptoIndio has joined #bitcoin-core-dev
8482019-10-24T22:34:50  *** cryptoIndio has quit IRC
8492019-10-24T22:36:34  *** nsh has joined #bitcoin-core-dev
8502019-10-24T22:38:21  *** bitcoin-git has joined #bitcoin-core-dev
8512019-10-24T22:38:21  <bitcoin-git> [bitcoin] elichai opened pull request #17245: Removing Boost from DecodeDumpTime (master...2019-10-DecodeDumpTime) https://github.com/bitcoin/bitcoin/pull/17245
8522019-10-24T22:38:32  *** bitcoin-git has left #bitcoin-core-dev
8532019-10-24T22:39:25  *** SiAnDoG has quit IRC
8542019-10-24T22:39:42  *** SiAnDoG has joined #bitcoin-core-dev
8552019-10-24T22:40:31  *** cryptoIndio has joined #bitcoin-core-dev
8562019-10-24T22:42:32  *** ensign has joined #bitcoin-core-dev
8572019-10-24T22:43:48  *** kristapsk has quit IRC
8582019-10-24T22:43:56  <elichai2> Fingers crossed for the windows CI hehe
8592019-10-24T22:44:01  *** kristapsk has joined #bitcoin-core-dev
8602019-10-24T22:45:00  *** mdunnio has quit IRC
8612019-10-24T22:45:13  *** cryptoIndio has quit IRC
8622019-10-24T22:46:36  *** cryptoIndio has joined #bitcoin-core-dev
8632019-10-24T22:51:23  *** cryptoIndio has quit IRC
8642019-10-24T22:53:15  *** marcoagner has quit IRC
8652019-10-24T22:57:13  *** cryptoIndio has joined #bitcoin-core-dev
8662019-10-24T23:01:37  *** cryptoIndio has quit IRC
8672019-10-24T23:05:46  *** cryptoIndio has joined #bitcoin-core-dev
8682019-10-24T23:12:58  *** cryptoIndio has quit IRC
8692019-10-24T23:20:08  *** lightlike has quit IRC
8702019-10-24T23:23:03  *** cryptoIndio has joined #bitcoin-core-dev
8712019-10-24T23:27:38  *** cryptoIndio has quit IRC
8722019-10-24T23:29:21  *** Deacyde has quit IRC
8732019-10-24T23:29:45  *** Deacyde has joined #bitcoin-core-dev
8742019-10-24T23:30:46  *** cryptoIndio has joined #bitcoin-core-dev
8752019-10-24T23:35:47  *** cryptoIndio has quit IRC
8762019-10-24T23:39:26  *** arik_ has quit IRC
8772019-10-24T23:43:05  *** farmerwampum has quit IRC
8782019-10-24T23:47:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
8792019-10-24T23:55:31  *** captjakk has quit IRC
8802019-10-24T23:56:48  *** farmerwampum has joined #bitcoin-core-dev