1 2019-10-26T00:00:01  *** lahwran has quit IRC
  2 2019-10-26T00:04:34  *** promag has quit IRC
  3 2019-10-26T00:05:10  *** promag has joined #bitcoin-core-dev
  4 2019-10-26T00:11:26  *** Highway61 has quit IRC
  5 2019-10-26T00:11:27  *** AaronvanW has joined #bitcoin-core-dev
  6 2019-10-26T00:17:36  *** RC-3004 has joined #bitcoin-core-dev
  7 2019-10-26T00:17:48  *** AaronvanW has quit IRC
  8 2019-10-26T00:18:27  *** luigi_ has quit IRC
  9 2019-10-26T00:22:22  *** SiAnDoG has quit IRC
 10 2019-10-26T00:22:41  *** SiAnDoG has joined #bitcoin-core-dev
 11 2019-10-26T00:23:52  *** michaelfolkson has joined #bitcoin-core-dev
 12 2019-10-26T00:29:06  <jeremyrubin> Hey
 13 2019-10-26T00:29:12  <jeremyrubin> I think I found a bug in DynamicUsage
 14 2019-10-26T00:29:25  <jeremyrubin> for unordered_map and unordered_set
 15 2019-10-26T00:29:56  <jeremyrubin> The STL on my machine does an optimization where there's always one bucket (like a prevector)
 16 2019-10-26T00:30:28  <jeremyrubin> This leads to double counting when you have a larger map
 17 2019-10-26T00:30:49  <jeremyrubin> Trying to think of a x-platform way to deal with it...
 18 2019-10-26T00:32:07  <jeremyrubin> this sounds like a thing for sipa to look at :)
 19 2019-10-26T00:34:21  <jeremyrubin> This leads to a nasty-ish bug where when you're trying to track the internal memory of things, you can get an accounting deficit
 20 2019-10-26T00:35:25  <sipa> jeremyrubin: DynamicUsage is inevitaby an approximation on some sysyems
 21 2019-10-26T00:36:11  <sipa> improvememts welcome of course, but it's not possible in general (i think) to exactly know the size of data structures every STL implementation uses
 22 2019-10-26T00:36:23  <sipa> i guess maybe with a custom allocator it could
 23 2019-10-26T00:36:26  <jeremyrubin> One reasonable solution then is to use bucket_count -1
 24 2019-10-26T00:36:59  <sipa> hmm, using a custom allocator to trakc this stuff should be easy
 25 2019-10-26T00:37:10  <jeremyrubin> It will only ever be "off by one" so shouldn't matter too much, but would accurately report 0 allocation for a newly created set
 26 2019-10-26T00:37:24  <jeremyrubin> sipa: I looked at that I don't think it is
 27 2019-10-26T00:37:42  <jeremyrubin> but could be wrong
 28 2019-10-26T00:44:07  <jeremyrubin> I guess something like bucket_count() - (bucket_count() == 1)
 29 2019-10-26T00:46:29  *** roconnor has quit IRC
 30 2019-10-26T00:46:37  *** AaronvanW has joined #bitcoin-core-dev
 31 2019-10-26T00:50:57  *** AaronvanW has quit IRC
 32 2019-10-26T00:57:57  <jeremyrubin> confirm that that approach fixes *my problem* :)
 33 2019-10-26T00:58:08  *** michaelfolkson has quit IRC
 34 2019-10-26T01:15:36  *** jkczyz has quit IRC
 35 2019-10-26T01:23:29  *** AaronvanW has joined #bitcoin-core-dev
 36 2019-10-26T01:28:02  *** AaronvanW has quit IRC
 37 2019-10-26T01:32:19  <luke-jr> sipa: sizeof?
 38 2019-10-26T01:36:28  *** Victor_sueca has joined #bitcoin-core-dev
 39 2019-10-26T01:36:52  *** promag has quit IRC
 40 2019-10-26T01:37:05  <jeremyrubin> sizeof?
 41 2019-10-26T01:37:11  *** Victorsueca has quit IRC
 42 2019-10-26T01:37:40  <luke-jr> whatever size STL uses, you should be able to get usage using sizeof I would think
 43 2019-10-26T01:39:22  <jeremyrubin> huh
 44 2019-10-26T01:39:26  <jeremyrubin> I don't think so
 45 2019-10-26T01:39:36  <luke-jr> why not?
 46 2019-10-26T01:39:38  <jeremyrubin> So you want to know the size on the stack
 47 2019-10-26T01:39:43  <jeremyrubin> you use sizeof
 48 2019-10-26T01:39:54  <jeremyrubin> but what we want to know is the size of the allocation
 49 2019-10-26T01:40:45  <jeremyrubin> And the reason it's difficult is because there's no way to tell if elements claimed by bucket_count() are on the stack or in the allocation
 50 2019-10-26T01:41:02  <jeremyrubin> When you create a new unordered_map, bucket_count() is not nesc 0
 51 2019-10-26T01:41:15  <jeremyrubin> e.g., implementations can optimize a pre-allocated bucket
 52 2019-10-26T01:41:33  <jeremyrubin> that is a pointer for a single bucket that, once allocated, becomes the pointer for the allocation
 53 2019-10-26T01:41:36  <jeremyrubin> or something like that
 54 2019-10-26T01:43:04  <luke-jr> &(&object)[1] - &object ?
 55 2019-10-26T01:44:49  <jeremyrubin> where object is what?
 56 2019-10-26T01:47:44  <jeremyrubin> the map may be empty...
 57 2019-10-26T01:52:33  <sipa> luke-jr: you don't know what the map allocates
 58 2019-10-26T01:52:53  <luke-jr> hmm
 59 2019-10-26T01:52:53  <sipa> it may allocate a struct { yourtype a; metadata b } object
 60 2019-10-26T01:53:04  <sipa> or it may allocate those in arrays
 61 2019-10-26T01:53:15  <luke-jr> C++ should add something :p
 62 2019-10-26T01:53:21  <sipa> well, allocators
 63 2019-10-26T01:53:45  <sipa> they let you observe the allocations STL containers make (and modify their behabior?
 64 2019-10-26T01:53:49  <sipa> )
 65 2019-10-26T01:54:18  *** arik_ has joined #bitcoin-core-dev
 66 2019-10-26T01:55:21  <luke-jr> hmm
 67 2019-10-26T01:55:32  <jeremyrubin> I think I heard there's an issue with allocators being assumed to be copyable or something funky like that, which can mess with collecting stats from one
 68 2019-10-26T01:55:37  <jeremyrubin> But I don't recall what the issue is
 69 2019-10-26T01:59:12  *** z56 has joined #bitcoin-core-dev
 70 2019-10-26T01:59:36  *** z56 has quit IRC
 71 2019-10-26T01:59:41  *** emilengler has quit IRC
 72 2019-10-26T02:00:38  *** AaronvanW has joined #bitcoin-core-dev
 73 2019-10-26T02:01:22  *** dviola is now known as Guest81850
 74 2019-10-26T02:02:18  *** dviola has joined #bitcoin-core-dev
 75 2019-10-26T02:02:28  *** arik_ has quit IRC
 76 2019-10-26T02:05:50  *** AaronvanW has quit IRC
 77 2019-10-26T02:08:14  *** emilengler has joined #bitcoin-core-dev
 78 2019-10-26T02:33:17  *** AaronvanW has joined #bitcoin-core-dev
 79 2019-10-26T02:38:14  *** AaronvanW has quit IRC
 80 2019-10-26T02:40:11  *** felixfoertsch23 has joined #bitcoin-core-dev
 81 2019-10-26T02:41:27  *** felixfoertsch has quit IRC
 82 2019-10-26T02:55:07  *** dviola has quit IRC
 83 2019-10-26T03:00:02  *** RC-3004 has quit IRC
 84 2019-10-26T03:01:55  *** felixfoertsch has joined #bitcoin-core-dev
 85 2019-10-26T03:04:08  *** felixfoertsch23 has quit IRC
 86 2019-10-26T03:07:35  *** AaronvanW has joined #bitcoin-core-dev
 87 2019-10-26T03:09:32  *** roconnor has joined #bitcoin-core-dev
 88 2019-10-26T03:12:27  *** AaronvanW has quit IRC
 89 2019-10-26T03:17:39  *** mkrautz1 has joined #bitcoin-core-dev
 90 2019-10-26T03:26:00  *** roconnor has quit IRC
 91 2019-10-26T03:37:27  *** promag has joined #bitcoin-core-dev
 92 2019-10-26T03:37:45  *** scopeh has quit IRC
 93 2019-10-26T03:38:03  *** scopeh has joined #bitcoin-core-dev
 94 2019-10-26T03:39:37  *** AaronvanW has joined #bitcoin-core-dev
 95 2019-10-26T03:41:56  *** promag has quit IRC
 96 2019-10-26T03:43:57  *** AaronvanW has quit IRC
 97 2019-10-26T04:04:47  *** dqx has quit IRC
 98 2019-10-26T04:11:28  *** AaronvanW has joined #bitcoin-core-dev
 99 2019-10-26T04:13:52  *** nosss2 has quit IRC
100 2019-10-26T04:16:17  *** AaronvanW has quit IRC
101 2019-10-26T04:20:26  *** nosss2 has joined #bitcoin-core-dev
102 2019-10-26T04:24:50  *** nosss2 has quit IRC
103 2019-10-26T04:31:31  *** jkczyz has joined #bitcoin-core-dev
104 2019-10-26T04:35:17  *** hsmiths has quit IRC
105 2019-10-26T04:35:20  *** ddustin has quit IRC
106 2019-10-26T04:35:55  *** ddustin has joined #bitcoin-core-dev
107 2019-10-26T04:35:57  *** jkczyz has quit IRC
108 2019-10-26T04:36:33  *** jkczyz has joined #bitcoin-core-dev
109 2019-10-26T04:40:02  *** ddustin has quit IRC
110 2019-10-26T04:43:12  *** AaronvanW has joined #bitcoin-core-dev
111 2019-10-26T04:47:37  *** AaronvanW has quit IRC
112 2019-10-26T05:14:50  *** AaronvanW has joined #bitcoin-core-dev
113 2019-10-26T05:16:18  *** bitcoin-git has joined #bitcoin-core-dev
114 2019-10-26T05:16:18  <bitcoin-git> [bitcoin] achow101 opened pull request #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple (master...wallet-box-pr-2) https://github.com/bitcoin/bitcoin/pull/17261
115 2019-10-26T05:16:20  *** bitcoin-git has left #bitcoin-core-dev
116 2019-10-26T05:19:34  *** AaronvanW has quit IRC
117 2019-10-26T05:27:01  *** rh0nj has quit IRC
118 2019-10-26T05:28:07  *** rh0nj has joined #bitcoin-core-dev
119 2019-10-26T05:46:17  *** ddustin has joined #bitcoin-core-dev
120 2019-10-26T05:53:53  *** jkczyz has quit IRC
121 2019-10-26T05:54:45  *** AaronvanW has joined #bitcoin-core-dev
122 2019-10-26T06:00:01  *** mkrautz1 has quit IRC
123 2019-10-26T06:00:25  <achow101> ryanofsky: I remember now, the unique_ptr signingprovider commit was for descriptor wallets to work
124 2019-10-26T06:00:30  *** AaronvanW has quit IRC
125 2019-10-26T06:08:34  *** ddustin has quit IRC
126 2019-10-26T06:08:54  *** ddustin has joined #bitcoin-core-dev
127 2019-10-26T06:09:42  *** ddustin has joined #bitcoin-core-dev
128 2019-10-26T06:10:10  *** ddustin has quit IRC
129 2019-10-26T06:10:32  *** ddustin has joined #bitcoin-core-dev
130 2019-10-26T06:17:41  *** torax has joined #bitcoin-core-dev
131 2019-10-26T06:21:30  *** hsmiths has joined #bitcoin-core-dev
132 2019-10-26T06:34:45  *** AaronvanW has joined #bitcoin-core-dev
133 2019-10-26T06:39:27  *** jkczyz has joined #bitcoin-core-dev
134 2019-10-26T06:39:48  *** AaronvanW has quit IRC
135 2019-10-26T06:43:42  *** ddustin has joined #bitcoin-core-dev
136 2019-10-26T06:44:02  *** jkczyz has quit IRC
137 2019-10-26T06:50:19  *** ddustin has quit IRC
138 2019-10-26T07:14:53  *** AaronvanW has joined #bitcoin-core-dev
139 2019-10-26T07:15:14  *** andytoshi has quit IRC
140 2019-10-26T07:15:22  *** promag has joined #bitcoin-core-dev
141 2019-10-26T07:19:28  *** promag has quit IRC
142 2019-10-26T07:19:47  *** AaronvanW has quit IRC
143 2019-10-26T08:00:28  *** AaronvanW has joined #bitcoin-core-dev
144 2019-10-26T08:05:17  *** jonatack has quit IRC
145 2019-10-26T08:10:13  *** AaronvanW has quit IRC
146 2019-10-26T08:10:29  *** AaronvanW has joined #bitcoin-core-dev
147 2019-10-26T08:40:18  *** jkczyz has joined #bitcoin-core-dev
148 2019-10-26T08:45:28  *** jkczyz has quit IRC
149 2019-10-26T08:52:49  *** michaelfolkson has joined #bitcoin-core-dev
150 2019-10-26T08:54:25  <wumpus> cfields: that's how I meant "giving up"; to find out that there's no elegent cross-platform solution for something in C++, and that boost works pretty ok for the case
151 2019-10-26T08:57:04  <wumpus> it's not preferable to boost to end up with maintaining reams of platform-specific compatibility code, or complex general algorithms such as date/time transformations
152 2019-10-26T09:00:02  *** torax has quit IRC
153 2019-10-26T09:08:18  *** marcoagner has joined #bitcoin-core-dev
154 2019-10-26T09:09:33  <wumpus> maybe "Boost->C++11 migration" is just a misnomer,it's clear it's not possible yet, even with C++20 I think think it replaced all of our boost usage
155 2019-10-26T09:09:45  <wumpus> I *don't* think
156 2019-10-26T09:11:47  <wumpus> possilby it'd be better to close that as an active project and add "Don't use boost for new code, when remotely possible." to the developer notes and call it a day
157 2019-10-26T09:17:51  *** jonatack has joined #bitcoin-core-dev
158 2019-10-26T09:19:41  *** michaelfolkson has quit IRC
159 2019-10-26T09:21:11  *** promag has joined #bitcoin-core-dev
160 2019-10-26T09:32:32  *** sdaftuar has quit IRC
161 2019-10-26T09:32:55  *** promag has quit IRC
162 2019-10-26T09:35:11  *** sdaftuar has joined #bitcoin-core-dev
163 2019-10-26T09:35:16  *** jonatack_ has joined #bitcoin-core-dev
164 2019-10-26T09:36:57  *** jonatack has quit IRC
165 2019-10-26T09:39:38  *** jonatack_ has quit IRC
166 2019-10-26T09:41:08  *** jonatack_ has joined #bitcoin-core-dev
167 2019-10-26T09:42:25  *** jonatack_ has joined #bitcoin-core-dev
168 2019-10-26T09:43:01  *** jonatack_ has quit IRC
169 2019-10-26T09:43:50  *** jonatack has joined #bitcoin-core-dev
170 2019-10-26T09:47:34  *** sammuel86 has joined #bitcoin-core-dev
171 2019-10-26T09:49:23  *** bitcoin-git has joined #bitcoin-core-dev
172 2019-10-26T09:49:23  <bitcoin-git> [bitcoin] laanwj pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/25d7e2e78137...d91af4768c1c
173 2019-10-26T09:49:24  <bitcoin-git> bitcoin/master 67328bb fanquake: build: remove protobuf from depends
174 2019-10-26T09:49:24  <bitcoin-git> bitcoin/master 1cb9a4e fanquake: docs: remove protobuf from docs
175 2019-10-26T09:49:25  <bitcoin-git> bitcoin/master 3548e4a fanquake: Remove BIP70 Support
176 2019-10-26T09:49:26  *** bitcoin-git has left #bitcoin-core-dev
177 2019-10-26T09:49:43  *** bitcoin-git has joined #bitcoin-core-dev
178 2019-10-26T09:49:43  <bitcoin-git> [bitcoin] laanwj merged pull request #17165: Remove BIP70 support (master...remove_bip70) https://github.com/bitcoin/bitcoin/pull/17165
179 2019-10-26T09:49:45  *** bitcoin-git has left #bitcoin-core-dev
180 2019-10-26T09:50:24  *** bitcoin-git has joined #bitcoin-core-dev
181 2019-10-26T09:50:25  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d91af4768c1c...e9f73b839ad9
182 2019-10-26T09:50:25  <bitcoin-git> bitcoin/master 6b6be41 João Barbosa: gui: Make polling in ClientModel asynchronous
183 2019-10-26T09:50:26  <bitcoin-git> bitcoin/master e9f73b8 Wladimir J. van der Laan: Merge #17135: gui: Make polling in ClientModel asynchronous
184 2019-10-26T09:50:28  *** bitcoin-git has left #bitcoin-core-dev
185 2019-10-26T09:50:44  *** bitcoin-git has joined #bitcoin-core-dev
186 2019-10-26T09:50:44  <bitcoin-git> [bitcoin] laanwj merged pull request #17135: gui: Make polling in ClientModel asynchronous (master...2019-10-fix-gui-freeze) https://github.com/bitcoin/bitcoin/pull/17135
187 2019-10-26T09:50:45  *** bitcoin-git has left #bitcoin-core-dev
188 2019-10-26T09:52:44  *** mryandao has quit IRC
189 2019-10-26T09:53:09  *** mryandao has joined #bitcoin-core-dev
190 2019-10-26T09:54:34  *** bitcoin-git has joined #bitcoin-core-dev
191 2019-10-26T09:54:35  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/5b68d1654f07...0f6f7a574a4e
192 2019-10-26T09:54:35  <bitcoin-git> bitcoin/0.19 d5c36ce João Barbosa: gui: Make polling in ClientModel asynchronous
193 2019-10-26T09:54:36  <bitcoin-git> bitcoin/0.19 0f6f7a5 Wladimir J. van der Laan: Merge #17252: 0.19: gui: Make polling in ClientModel asynchronous
194 2019-10-26T09:54:38  *** bitcoin-git has left #bitcoin-core-dev
195 2019-10-26T09:54:54  *** bitcoin-git has joined #bitcoin-core-dev
196 2019-10-26T09:54:54  <bitcoin-git> [bitcoin] laanwj merged pull request #17252: 0.19: gui: Make polling in ClientModel asynchronous (0.19...2019-10-backport-17135) https://github.com/bitcoin/bitcoin/pull/17252
197 2019-10-26T09:54:55  *** bitcoin-git has left #bitcoin-core-dev
198 2019-10-26T10:02:42  *** jonatack has quit IRC
199 2019-10-26T10:03:24  *** jonatack has joined #bitcoin-core-dev
200 2019-10-26T10:05:39  *** bitcoin-git has joined #bitcoin-core-dev
201 2019-10-26T10:05:40  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9f73b839ad9...3f875744cb61
202 2019-10-26T10:05:40  <bitcoin-git> bitcoin/master a592913 Jan Beich: http: add missing header bootlegged by boost < 1.72
203 2019-10-26T10:05:41  <bitcoin-git> bitcoin/master 3f87574 Wladimir J. van der Laan: Merge #17249: rpc: Add missing deque include to fix build
204 2019-10-26T10:05:50  *** bitcoin-git has left #bitcoin-core-dev
205 2019-10-26T10:06:09  *** bitcoin-git has joined #bitcoin-core-dev
206 2019-10-26T10:06:09  <bitcoin-git> [bitcoin] laanwj merged pull request #17249: rpc: Add missing deque include to fix build (master...boost) https://github.com/bitcoin/bitcoin/pull/17249
207 2019-10-26T10:06:11  *** bitcoin-git has left #bitcoin-core-dev
208 2019-10-26T10:10:20  *** bitcoin-git has joined #bitcoin-core-dev
209 2019-10-26T10:10:20  <bitcoin-git> [bitcoin] Sjors opened pull request #17264: [rpc] set default bip32derivs to true for psbt methods (master...2019/10/bip32_derivs) https://github.com/bitcoin/bitcoin/pull/17264
210 2019-10-26T10:10:25  *** bitcoin-git has left #bitcoin-core-dev
211 2019-10-26T10:10:57  *** luigi_ has joined #bitcoin-core-dev
212 2019-10-26T10:13:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
213 2019-10-26T10:23:03  *** luigi_ has quit IRC
214 2019-10-26T10:24:25  *** gin has joined #bitcoin-core-dev
215 2019-10-26T10:26:54  *** Chris_Stewart_5 has quit IRC
216 2019-10-26T10:28:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
217 2019-10-26T10:29:14  *** jonatack has quit IRC
218 2019-10-26T10:31:20  <wumpus> #proposedmeetingtopic close Boost → C++11 migration project for now
219 2019-10-26T10:33:07  *** gin has quit IRC
220 2019-10-26T10:33:14  *** JeremyCrookshank has joined #bitcoin-core-dev
221 2019-10-26T10:33:25  *** luigi_ has joined #bitcoin-core-dev
222 2019-10-26T10:36:23  *** ExtraCrispy has joined #bitcoin-core-dev
223 2019-10-26T10:41:11  *** jkczyz has joined #bitcoin-core-dev
224 2019-10-26T10:41:29  *** luigi_ has left #bitcoin-core-dev
225 2019-10-26T10:43:36  *** baldur has quit IRC
226 2019-10-26T10:45:42  *** jkczyz has quit IRC
227 2019-10-26T10:47:45  *** sdaftuar has quit IRC
228 2019-10-26T10:48:10  *** sdaftuar has joined #bitcoin-core-dev
229 2019-10-26T10:56:52  *** baldur has joined #bitcoin-core-dev
230 2019-10-26T11:00:43  *** bitcoin-git has joined #bitcoin-core-dev
231 2019-10-26T11:00:44  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f875744cb61...9bd109b78d93
232 2019-10-26T11:00:44  <bitcoin-git> bitcoin/master a8f5026 João Barbosa: gui: Fix start timer from non QThread
233 2019-10-26T11:00:44  <bitcoin-git> bitcoin/master 9bd109b Wladimir J. van der Laan: Merge #17120: gui: Fix start timer from non QThread
234 2019-10-26T11:00:46  *** bitcoin-git has left #bitcoin-core-dev
235 2019-10-26T11:01:04  *** bitcoin-git has joined #bitcoin-core-dev
236 2019-10-26T11:01:04  <bitcoin-git> [bitcoin] laanwj merged pull request #17120: gui: Fix start timer from non QThread (master...2019-10-fix-timer) https://github.com/bitcoin/bitcoin/pull/17120
237 2019-10-26T11:01:06  *** bitcoin-git has left #bitcoin-core-dev
238 2019-10-26T11:01:57  *** Chris_Stewart_5 has quit IRC
239 2019-10-26T11:02:50  *** owowo has quit IRC
240 2019-10-26T11:03:29  *** bitcoin-git has joined #bitcoin-core-dev
241 2019-10-26T11:03:30  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/0f6f7a574a4e...e39c9cff1a62
242 2019-10-26T11:03:31  <bitcoin-git> bitcoin/0.19 8082b38 Jan Beich: http: add missing header bootlegged by boost < 1.72
243 2019-10-26T11:03:32  <bitcoin-git> bitcoin/0.19 e39c9cf João Barbosa: gui: Fix start timer from non QThread
244 2019-10-26T11:03:34  *** bitcoin-git has left #bitcoin-core-dev
245 2019-10-26T11:04:53  *** belcher has joined #bitcoin-core-dev
246 2019-10-26T11:06:44  *** bitcoin-git has joined #bitcoin-core-dev
247 2019-10-26T11:06:45  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9bd109b78d93...be50469217bd
248 2019-10-26T11:06:46  <bitcoin-git> bitcoin/master e156b9d fanquake: gui: disable font antialiasing for QR image address
249 2019-10-26T11:06:46  <bitcoin-git> bitcoin/master be50469 Wladimir J. van der Laan: Merge #17257: gui: disable font antialiasing for QR image address
250 2019-10-26T11:06:57  *** bitcoin-git has left #bitcoin-core-dev
251 2019-10-26T11:07:15  *** bitcoin-git has joined #bitcoin-core-dev
252 2019-10-26T11:07:15  <bitcoin-git> [bitcoin] laanwj merged pull request #17257: gui: disable font antialiasing for QR image address (master...disable_qr_font_antialiasing) https://github.com/bitcoin/bitcoin/pull/17257
253 2019-10-26T11:07:27  *** bitcoin-git has left #bitcoin-core-dev
254 2019-10-26T11:07:36  *** owowo has joined #bitcoin-core-dev
255 2019-10-26T11:07:36  *** owowo has joined #bitcoin-core-dev
256 2019-10-26T11:07:44  *** bitcoin-git has joined #bitcoin-core-dev
257 2019-10-26T11:07:45  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/e39c9cff1a62...eb5a899d5a97
258 2019-10-26T11:07:45  <bitcoin-git> bitcoin/0.19 eb5a899 fanquake: gui: disable font antialiasing for QR image address
259 2019-10-26T11:07:46  *** bitcoin-git has left #bitcoin-core-dev
260 2019-10-26T11:08:10  <wumpus> looks like things are ready, tagging 0.19.0rc2 in a bit
261 2019-10-26T11:08:55  *** luigi_ has joined #bitcoin-core-dev
262 2019-10-26T11:09:30  *** luigi_ has quit IRC
263 2019-10-26T11:09:48  *** gin_gin has joined #bitcoin-core-dev
264 2019-10-26T11:14:19  <JeremyCrookshank> :)
265 2019-10-26T11:19:01  *** gin_gin is now known as soju
266 2019-10-26T11:20:59  *** soju has quit IRC
267 2019-10-26T11:21:13  *** gin_gin has joined #bitcoin-core-dev
268 2019-10-26T11:24:12  *** gin_gin has quit IRC
269 2019-10-26T11:24:28  *** soju has joined #bitcoin-core-dev
270 2019-10-26T11:25:14  *** soju is now known as gin_gin
271 2019-10-26T11:26:27  *** gin_gin is now known as soju
272 2019-10-26T11:33:33  *** promag has joined #bitcoin-core-dev
273 2019-10-26T11:38:01  *** promag has quit IRC
274 2019-10-26T11:42:44  *** EagleTM has joined #bitcoin-core-dev
275 2019-10-26T11:45:03  *** soju has quit IRC
276 2019-10-26T11:45:18  *** bitcoin-git has joined #bitcoin-core-dev
277 2019-10-26T11:45:18  <bitcoin-git> [bitcoin] BlockMechanic closed pull request #17078: Android depends (master...android-depends) https://github.com/bitcoin/bitcoin/pull/17078
278 2019-10-26T11:45:20  *** bitcoin-git has left #bitcoin-core-dev
279 2019-10-26T11:46:57  *** EagleTM has quit IRC
280 2019-10-26T11:48:58  *** soju has joined #bitcoin-core-dev
281 2019-10-26T11:49:21  *** JeremyCrookshank has quit IRC
282 2019-10-26T11:59:50  *** jtimon has joined #bitcoin-core-dev
283 2019-10-26T12:00:01  *** sammuel86 has quit IRC
284 2019-10-26T12:03:57  *** davterra has quit IRC
285 2019-10-26T12:04:31  *** davterra has joined #bitcoin-core-dev
286 2019-10-26T12:17:51  *** dfreedm has joined #bitcoin-core-dev
287 2019-10-26T12:18:37  *** tsujp has quit IRC
288 2019-10-26T12:22:15  *** AaronvanW has quit IRC
289 2019-10-26T12:24:14  *** tsujp_ has joined #bitcoin-core-dev
290 2019-10-26T12:31:15  *** tsujp has joined #bitcoin-core-dev
291 2019-10-26T12:32:05  *** tsujp_ has quit IRC
292 2019-10-26T12:37:07  *** pinheadmz_ has joined #bitcoin-core-dev
293 2019-10-26T12:39:53  *** pinheadmz has quit IRC
294 2019-10-26T12:39:53  *** pinheadmz_ is now known as pinheadmz
295 2019-10-26T12:42:05  *** jkczyz has joined #bitcoin-core-dev
296 2019-10-26T12:46:26  *** jkczyz has quit IRC
297 2019-10-26T13:01:36  *** AaronvanW has joined #bitcoin-core-dev
298 2019-10-26T13:06:01  *** AaronvanW has quit IRC
299 2019-10-26T13:18:12  *** sdaftuar has quit IRC
300 2019-10-26T13:18:39  *** sdaftuar has joined #bitcoin-core-dev
301 2019-10-26T13:19:41  *** andytoshi has joined #bitcoin-core-dev
302 2019-10-26T13:32:38  *** AaronvanW has joined #bitcoin-core-dev
303 2019-10-26T13:35:31  *** bitcoin-git has joined #bitcoin-core-dev
304 2019-10-26T13:35:32  <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.0rc2: https://github.com/bitcoin/bitcoin/compare/v0.19.0rc2
305 2019-10-26T13:35:32  *** bitcoin-git has left #bitcoin-core-dev
306 2019-10-26T13:36:50  *** AaronvanW has quit IRC
307 2019-10-26T13:37:01  <fanquake> 🚀
308 2019-10-26T13:40:12  <emilengler> 🎉
309 2019-10-26T13:45:01  *** promag has joined #bitcoin-core-dev
310 2019-10-26T13:48:17  *** jonatack has joined #bitcoin-core-dev
311 2019-10-26T14:04:54  *** Guyver2 has joined #bitcoin-core-dev
312 2019-10-26T14:07:26  *** Highway61 has joined #bitcoin-core-dev
313 2019-10-26T14:10:41  *** AaronvanW has joined #bitcoin-core-dev
314 2019-10-26T14:10:54  *** Highway62 has joined #bitcoin-core-dev
315 2019-10-26T14:11:01  *** Highway61 has quit IRC
316 2019-10-26T14:11:01  *** Highway62 is now known as Highway61
317 2019-10-26T14:14:26  *** bitcoin-git has joined #bitcoin-core-dev
318 2019-10-26T14:14:26  <bitcoin-git> [bitcoin] fanquake opened pull request #17265: [WIP] Remove OpenSSL (master...remove_openssl) https://github.com/bitcoin/bitcoin/pull/17265
319 2019-10-26T14:14:27  *** bitcoin-git has left #bitcoin-core-dev
320 2019-10-26T14:15:39  *** AaronvanW has quit IRC
321 2019-10-26T14:20:59  *** Highway61 has quit IRC
322 2019-10-26T14:36:02  *** jonatack has quit IRC
323 2019-10-26T14:36:32  *** jonatack has joined #bitcoin-core-dev
324 2019-10-26T14:36:45  *** promag has quit IRC
325 2019-10-26T14:42:59  *** jkczyz has joined #bitcoin-core-dev
326 2019-10-26T14:46:26  *** Highway61 has joined #bitcoin-core-dev
327 2019-10-26T14:48:56  *** jkczyz has quit IRC
328 2019-10-26T14:50:41  *** AaronvanW has joined #bitcoin-core-dev
329 2019-10-26T14:54:37  *** justanotheruser has quit IRC
330 2019-10-26T14:55:51  *** AaronvanW has quit IRC
331 2019-10-26T14:57:57  *** sipa has quit IRC
332 2019-10-26T14:58:14  *** sipa has joined #bitcoin-core-dev
333 2019-10-26T15:00:02  *** dfreedm has quit IRC
334 2019-10-26T15:05:46  *** promag has joined #bitcoin-core-dev
335 2019-10-26T15:06:13  *** davterra has quit IRC
336 2019-10-26T15:17:57  *** justanotheruser has joined #bitcoin-core-dev
337 2019-10-26T15:18:47  *** promag has quit IRC
338 2019-10-26T15:29:02  <fanquake> pushed some rc2 sigs up https://github.com/bitcoin-core/gitian.sigs/pull/1118
339 2019-10-26T15:29:09  *** AaronvanW has joined #bitcoin-core-dev
340 2019-10-26T15:33:37  *** AaronvanW has quit IRC
341 2019-10-26T15:43:32  *** promag has joined #bitcoin-core-dev
342 2019-10-26T15:44:23  *** Stas99 has joined #bitcoin-core-dev
343 2019-10-26T15:45:19  *** jkczyz has joined #bitcoin-core-dev
344 2019-10-26T15:45:58  *** promag has quit IRC
345 2019-10-26T15:46:27  *** Stas99 has quit IRC
346 2019-10-26T15:47:29  *** jonatack_ has joined #bitcoin-core-dev
347 2019-10-26T15:49:39  *** Frost1 has joined #bitcoin-core-dev
348 2019-10-26T15:50:26  *** jonatack has quit IRC
349 2019-10-26T15:54:36  *** jonatack_ has quit IRC
350 2019-10-26T15:55:06  *** jonatack has joined #bitcoin-core-dev
351 2019-10-26T16:04:49  *** jonatack has quit IRC
352 2019-10-26T16:06:49  *** AaronvanW has joined #bitcoin-core-dev
353 2019-10-26T16:11:14  *** AaronvanW has quit IRC
354 2019-10-26T16:12:44  *** michaelfolkson has joined #bitcoin-core-dev
355 2019-10-26T16:15:38  *** ddustin has joined #bitcoin-core-dev
356 2019-10-26T16:17:17  *** michaelfolkson has quit IRC
357 2019-10-26T16:20:27  *** ddustin has quit IRC
358 2019-10-26T16:24:40  *** michaelfolkson has joined #bitcoin-core-dev
359 2019-10-26T16:31:07  *** michaelfolkson has quit IRC
360 2019-10-26T16:32:36  *** michaelfolkson has joined #bitcoin-core-dev
361 2019-10-26T16:39:23  *** michaelfolkson has quit IRC
362 2019-10-26T16:48:28  *** afk11 has quit IRC
363 2019-10-26T16:48:50  *** afk11 has joined #bitcoin-core-dev
364 2019-10-26T16:49:00  *** jkczyz has quit IRC
365 2019-10-26T16:50:54  <cfields> wumpus: forgot version bump? :)
366 2019-10-26T16:55:54  *** nosss2 has joined #bitcoin-core-dev
367 2019-10-26T17:02:21  *** Victor_sueca is now known as Victorsueca
368 2019-10-26T17:06:04  *** cryptoIndio has quit IRC
369 2019-10-26T17:06:18  *** cryptoIndio has joined #bitcoin-core-dev
370 2019-10-26T17:07:48  *** cryptoIndio has quit IRC
371 2019-10-26T17:11:32  *** cryptoIndio has joined #bitcoin-core-dev
372 2019-10-26T17:13:56  *** thoragh has joined #bitcoin-core-dev
373 2019-10-26T17:15:21  *** AaronvanW has joined #bitcoin-core-dev
374 2019-10-26T17:16:22  *** cryptoIndio has quit IRC
375 2019-10-26T17:22:14  *** cryptoIndio has joined #bitcoin-core-dev
376 2019-10-26T17:22:15  *** AaronvanW has quit IRC
377 2019-10-26T17:23:15  <wumpus> cfields: oh no...
378 2019-10-26T17:23:31  <wumpus> we really need a way to detect this
379 2019-10-26T17:23:56  *** jonatack has joined #bitcoin-core-dev
380 2019-10-26T17:25:04  *** SiAnDoG has quit IRC
381 2019-10-26T17:25:34  *** SiAnDoG has joined #bitcoin-core-dev
382 2019-10-26T17:26:37  *** cryptoIndio has quit IRC
383 2019-10-26T17:28:13  <wumpus> there used to be a time when the rc was auto-detected from the tag
384 2019-10-26T17:28:16  *** cryptoIndio has joined #bitcoin-core-dev
385 2019-10-26T17:28:55  <wumpus> I'm still not really used to this way
386 2019-10-26T17:29:01  *** rh0nj has quit IRC
387 2019-10-26T17:30:07  *** rh0nj has joined #bitcoin-core-dev
388 2019-10-26T17:30:20  <wumpus> anyhow rc2 is dead, will do a rc3
389 2019-10-26T17:31:38  *** promag has joined #bitcoin-core-dev
390 2019-10-26T17:32:54  <provoostenator> Long live rc3!
391 2019-10-26T17:35:06  <wumpus> hehe
392 2019-10-26T17:35:16  <fanquake> 😭
393 2019-10-26T17:36:06  *** cryptoIndio has quit IRC
394 2019-10-26T17:36:10  *** promag has quit IRC
395 2019-10-26T17:39:00  *** cryptoIndio has joined #bitcoin-core-dev
396 2019-10-26T17:39:49  <achow101> would it be possible to add a travis job for tags only that checks version number against tag?
397 2019-10-26T17:41:44  <ghost43> you can do   if: tag IS present
398 2019-10-26T17:49:33  <wumpus> by that time it's too late
399 2019-10-26T17:50:28  <wumpus> I think I'm going to add a script to maintainer tools to do the tagging, and also the version bump
400 2019-10-26T17:50:51  <achow101> git pre-push hook?
401 2019-10-26T17:51:53  <wumpus> meh
402 2019-10-26T17:53:28  *** bitcoin-git has joined #bitcoin-core-dev
403 2019-10-26T17:53:29  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/eb5a899d5a97...7358ae6d71cd
404 2019-10-26T17:53:29  <bitcoin-git> bitcoin/0.19 f6aab42 Wladimir J. van der Laan: build: bump version to rc3
405 2019-10-26T17:53:30  <bitcoin-git> bitcoin/0.19 7358ae6 Wladimir J. van der Laan: gui: rc3 translations update
406 2019-10-26T17:53:32  *** bitcoin-git has left #bitcoin-core-dev
407 2019-10-26T17:59:04  *** bitcoin-git has joined #bitcoin-core-dev
408 2019-10-26T17:59:04  <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.19.0rc3
409 2019-10-26T17:59:05  *** bitcoin-git has left #bitcoin-core-dev
410 2019-10-26T18:00:02  *** Frost1 has quit IRC
411 2019-10-26T18:00:30  <luke-jr> Subversion had a token that would be replaced with commit info in checkouts..
412 2019-10-26T18:00:35  <luke-jr> I think git might have something similar
413 2019-10-26T18:01:58  *** michaelfolkson has joined #bitcoin-core-dev
414 2019-10-26T18:02:06  <luke-jr> can't remember the term to find it tho
415 2019-10-26T18:07:28  <wumpus> I need to make a tagging script anyway (also to automatically set the Tree-SHA512:)
416 2019-10-26T18:13:31  *** bitcoin-git has joined #bitcoin-core-dev
417 2019-10-26T18:13:31  <bitcoin-git> [bitcoin] elichai opened pull request #17266:  Rename DecodeDumpTime to ParseISO8601DateTime (master...2019-10-FormatISO8601DateTime) https://github.com/bitcoin/bitcoin/pull/17266
418 2019-10-26T18:13:32  *** bitcoin-git has left #bitcoin-core-dev
419 2019-10-26T18:13:51  *** bitcoin-git has joined #bitcoin-core-dev
420 2019-10-26T18:13:51  <bitcoin-git> [bitcoin] elichai closed pull request #17245: wallet: Remove Boost from DecodeDumpTime (master...2019-10-DecodeDumpTime) https://github.com/bitcoin/bitcoin/pull/17245
421 2019-10-26T18:13:52  *** bitcoin-git has left #bitcoin-core-dev
422 2019-10-26T18:17:56  *** michaelfolkson has quit IRC
423 2019-10-26T18:28:36  *** AaronvanW has joined #bitcoin-core-dev
424 2019-10-26T18:30:25  *** ddustin has joined #bitcoin-core-dev
425 2019-10-26T18:31:02  *** captjakk has joined #bitcoin-core-dev
426 2019-10-26T18:33:12  *** AaronvanW has quit IRC
427 2019-10-26T18:34:26  *** ddustin has quit IRC
428 2019-10-26T18:38:30  *** nosss2 has quit IRC
429 2019-10-26T18:42:03  *** ddustin has joined #bitcoin-core-dev
430 2019-10-26T18:45:22  *** jkczyz has joined #bitcoin-core-dev
431 2019-10-26T18:46:16  *** kers1 has joined #bitcoin-core-dev
432 2019-10-26T18:47:04  *** nosss2 has joined #bitcoin-core-dev
433 2019-10-26T18:49:57  *** jkczyz has quit IRC
434 2019-10-26T18:51:18  *** bitcoin-git has joined #bitcoin-core-dev
435 2019-10-26T18:51:18  <bitcoin-git> [bitcoin] promag closed pull request #17133: 0.19: gui: Fix start timer from non QThread (0.19...2019-10-backport-17120) https://github.com/bitcoin/bitcoin/pull/17133
436 2019-10-26T18:51:19  *** bitcoin-git has left #bitcoin-core-dev
437 2019-10-26T18:51:30  *** nosss2 has quit IRC
438 2019-10-26T18:52:23  *** bitcoin-git has joined #bitcoin-core-dev
439 2019-10-26T18:52:23  <bitcoin-git> [bitcoin] nijynot opened pull request #17267: bench: Fix negative values and zero for -evals flag (master...fix/eval) https://github.com/bitcoin/bitcoin/pull/17267
440 2019-10-26T18:52:24  *** bitcoin-git has left #bitcoin-core-dev
441 2019-10-26T18:57:40  *** reallll has joined #bitcoin-core-dev
442 2019-10-26T18:59:39  *** ddustin has quit IRC
443 2019-10-26T19:01:15  *** belcher has quit IRC
444 2019-10-26T19:02:13  *** EagleTM has joined #bitcoin-core-dev
445 2019-10-26T19:04:10  *** reallll is now known as belcher
446 2019-10-26T19:06:01  *** AaronvanW has joined #bitcoin-core-dev
447 2019-10-26T19:08:15  *** cryptoIndio has quit IRC
448 2019-10-26T19:08:29  *** cryptoIndio has joined #bitcoin-core-dev
449 2019-10-26T19:10:17  *** AaronvanW has quit IRC
450 2019-10-26T19:10:31  *** cryptoIndio has quit IRC
451 2019-10-26T19:13:47  *** nijynot has joined #bitcoin-core-dev
452 2019-10-26T19:15:00  *** cryptoIndio has joined #bitcoin-core-dev
453 2019-10-26T19:15:26  *** ddustin has joined #bitcoin-core-dev
454 2019-10-26T19:23:24  *** cryptoIndio has quit IRC
455 2019-10-26T19:24:58  *** nijynot has quit IRC
456 2019-10-26T19:32:10  *** Tennis has joined #bitcoin-core-dev
457 2019-10-26T19:34:14  *** cryptoIndio has joined #bitcoin-core-dev
458 2019-10-26T19:42:33  *** AaronvanW has joined #bitcoin-core-dev
459 2019-10-26T19:42:57  *** cryptoIndio has quit IRC
460 2019-10-26T19:46:21  *** cryptoIndio has joined #bitcoin-core-dev
461 2019-10-26T19:46:50  *** AaronvanW has quit IRC
462 2019-10-26T19:49:27  *** ctrlbreak has quit IRC
463 2019-10-26T19:57:40  *** infinitis has joined #bitcoin-core-dev
464 2019-10-26T19:58:20  *** infinitis has quit IRC
465 2019-10-26T20:00:24  *** cryptoIndio has quit IRC
466 2019-10-26T20:01:56  *** ddustin has quit IRC
467 2019-10-26T20:04:06  *** ddustin has joined #bitcoin-core-dev
468 2019-10-26T20:06:51  *** cryptoIndio has joined #bitcoin-core-dev
469 2019-10-26T20:11:30  *** cryptoIndio has quit IRC
470 2019-10-26T20:14:06  *** cryptoIndio has joined #bitcoin-core-dev
471 2019-10-26T20:16:02  *** thoragh has quit IRC
472 2019-10-26T20:17:56  *** thoragh has joined #bitcoin-core-dev
473 2019-10-26T20:18:15  *** AaronvanW has joined #bitcoin-core-dev
474 2019-10-26T20:18:54  *** cryptoIndio has quit IRC
475 2019-10-26T20:20:13  *** cryptoIndio has joined #bitcoin-core-dev
476 2019-10-26T20:22:37  *** AaronvanW has quit IRC
477 2019-10-26T20:23:23  *** thoragh has quit IRC
478 2019-10-26T20:23:31  *** belcher has quit IRC
479 2019-10-26T20:24:37  *** cryptoIndio has quit IRC
480 2019-10-26T20:29:26  *** cryptoIndio has joined #bitcoin-core-dev
481 2019-10-26T20:35:33  *** cryptoIndio has quit IRC
482 2019-10-26T20:35:53  *** michagogo has joined #bitcoin-core-dev
483 2019-10-26T20:39:03  *** cryptoIndio has joined #bitcoin-core-dev
484 2019-10-26T20:43:37  *** cryptoIndio has quit IRC
485 2019-10-26T20:46:14  *** jkczyz has joined #bitcoin-core-dev
486 2019-10-26T20:48:31  *** cryptoIndio has joined #bitcoin-core-dev
487 2019-10-26T20:49:10  <elichai2> sipa: Hi, if you're free to expand on the logic/source of this idea I'm really curious to know about it :) https://github.com/bitcoin/bitcoin/pull/15224
488 2019-10-26T20:50:50  *** jkczyz has quit IRC
489 2019-10-26T20:52:07  *** ddustin has quit IRC
490 2019-10-26T20:53:04  *** qubenix has quit IRC
491 2019-10-26T20:54:32  *** qubenix has joined #bitcoin-core-dev
492 2019-10-26T20:54:40  *** cryptoIndio has quit IRC
493 2019-10-26T20:55:30  *** cryptoIndio has joined #bitcoin-core-dev
494 2019-10-26T20:56:25  *** AaronvanW has joined #bitcoin-core-dev
495 2019-10-26T20:56:28  <sipa> elichai2: it's a source of entropy on its own (by timing periodically during a slow computation), plus it strengthens the existing entrooy
496 2019-10-26T20:57:10  <sipa> as in: if there is not much entropy in there already, attacking will become a multiplication factor slower for an attacker to try anything
497 2019-10-26T20:57:32  <sipa> similar to pbkdf2 for passwords
498 2019-10-26T20:59:03  <elichai2> but these are passwords, usually words (easily bruteforcable with dictionaries). not sure attacking bad entropy of randomness is done via brute forcing (I honestly don't know. that's why I'm asking)
499 2019-10-26T20:59:57  *** cryptoIndio has quit IRC
500 2019-10-26T21:00:01  *** kers1 has quit IRC
501 2019-10-26T21:01:06  *** AaronvanW has quit IRC
502 2019-10-26T21:02:30  <elichai2> I'm just wondering if adding complexity without obvious advantages is a good thing or not in the RNG world.  but for me "entropy" is still a bit of a magic word so curious to hear your thoughts :)
503 2019-10-26T21:03:04  <sipa> entropy is actually the wrong term to use, as it's a concept from information theory
504 2019-10-26T21:03:32  <sipa> and we care about computational complexity for an attacker, not just whether the information is there in the first place
505 2019-10-26T21:04:40  <sipa> but say an attacker knows somehow that all the previous entropy sources we used only have 2^32 possible combinations, he can try all of them, and see if the output of the RNG for any of those seeds matches the observed behavior of the node (or say, generated keys)
506 2019-10-26T21:04:56  *** cryptoIndio has joined #bitcoin-core-dev
507 2019-10-26T21:05:08  <sipa> and there strengthening could be the difference between possible and impossible
508 2019-10-26T21:05:28  <sipa> but it is defense in depth. if the entropy sources before work as expected, it is unnecessary
509 2019-10-26T21:07:15  <elichai2> but don't you decrease the entropy by introducing the chances of collisions of the PRF multiplied by the times you run the function on it?
510 2019-10-26T21:07:32  <sipa> no
511 2019-10-26T21:07:35  <elichai2> (i.e. SHA256 can have collisions even in 256bit inputs)
512 2019-10-26T21:08:50  <sipa> there is a very theoretical (and only relevant when you're actually talking about entropy and not computation necessary for attack) reduction in entropy when you have a 256-bit state with actually 256 bits of entropy, and you sha256 it repeatedly
513 2019-10-26T21:08:53  *** ddustin has joined #bitcoin-core-dev
514 2019-10-26T21:09:09  <sipa> and it only reduces things to slightly below 256 bits
515 2019-10-26T21:09:23  <sipa> however, that's not even what we're doing here
516 2019-10-26T21:09:53  <sipa> we extract 256 bits of entropy from the state, repeatedly hash it, and then mix the result back into the state... using a 512-bit hash function
517 2019-10-26T21:10:36  <sipa> how many bits the strengthening uses is pretty much immaterial; it could be just 64 bits too, probably... as we don't replace the entire state with the outcome
518 2019-10-26T21:10:42  *** cryptoIndio has quit IRC
519 2019-10-26T21:10:56  <sipa> it just so happens that we have super optimized sha256 code, so we'd like to use it increase the advantage over an attacker
520 2019-10-26T21:12:39  <elichai2> That makes a bit more sense to me. I thought it's rehasing the data into itself. but looking again at the code it's obvious that's not what it's doing
521 2019-10-26T21:14:09  <sipa> no, it doesn't even hold the rng lock during the stengthening
522 2019-10-26T21:14:25  <sipa> other entropy may be added to it in the mean time too
523 2019-10-26T21:14:32  <sipa> s/entropy/randomness/
524 2019-10-26T21:17:17  *** DocScrutinizer has joined #bitcoin-core-dev
525 2019-10-26T21:17:40  *** DocScrutinizer is now known as Guest78433
526 2019-10-26T21:22:30  *** bitcoin-git has joined #bitcoin-core-dev
527 2019-10-26T21:22:31  <bitcoin-git> [bitcoin] JeremyRubin opened pull request #17268: Epoch Mempool (master...mempool-experiments-2) https://github.com/bitcoin/bitcoin/pull/17268
528 2019-10-26T21:22:43  *** bitcoin-git has left #bitcoin-core-dev
529 2019-10-26T21:23:28  *** nobody123 has joined #bitcoin-core-dev
530 2019-10-26T21:27:47  *** AaronvanW has joined #bitcoin-core-dev
531 2019-10-26T21:32:02  *** AaronvanW has quit IRC
532 2019-10-26T21:32:32  *** Guyver2 has quit IRC
533 2019-10-26T21:40:10  <elichai2> sipa: Thanks :)
534 2019-10-26T21:45:39  *** Skirmant has quit IRC
535 2019-10-26T21:46:42  *** ctrlbreak has joined #bitcoin-core-dev
536 2019-10-26T21:50:14  *** captjakk has quit IRC
537 2019-10-26T21:51:03  *** captjakk has joined #bitcoin-core-dev
538 2019-10-26T21:54:36  *** Guest81850 has quit IRC
539 2019-10-26T21:55:38  *** dviola has joined #bitcoin-core-dev
540 2019-10-26T21:59:29  *** ddustin has quit IRC
541 2019-10-26T22:00:07  *** ddustin has joined #bitcoin-core-dev
542 2019-10-26T22:03:56  *** cryptoIndio has joined #bitcoin-core-dev
543 2019-10-26T22:04:28  *** AaronvanW has joined #bitcoin-core-dev
544 2019-10-26T22:05:05  *** ddustin has quit IRC
545 2019-10-26T22:09:17  *** AaronvanW has quit IRC
546 2019-10-26T22:11:08  *** cryptoIndio has quit IRC
547 2019-10-26T22:18:59  *** jonatack has quit IRC
548 2019-10-26T22:19:32  *** jonatack has joined #bitcoin-core-dev
549 2019-10-26T22:23:57  *** Skirmant has joined #bitcoin-core-dev
550 2019-10-26T22:26:37  *** captjakk has quit IRC
551 2019-10-26T22:26:51  *** captjakk has joined #bitcoin-core-dev
552 2019-10-26T22:38:36  *** AaronvanW has joined #bitcoin-core-dev
553 2019-10-26T22:43:34  *** AaronvanW has quit IRC
554 2019-10-26T22:47:05  *** jkczyz has joined #bitcoin-core-dev
555 2019-10-26T22:51:53  *** jkczyz has quit IRC
556 2019-10-26T22:59:41  *** nobody123 has quit IRC
557 2019-10-26T22:59:41  *** marcoagner has quit IRC
558 2019-10-26T23:09:47  *** AaronvanW has joined #bitcoin-core-dev
559 2019-10-26T23:14:02  *** AaronvanW has quit IRC
560 2019-10-26T23:20:54  *** dviola has quit IRC
561 2019-10-26T23:27:28  *** AaronvanW has joined #bitcoin-core-dev
562 2019-10-26T23:43:37  *** jkczyz has joined #bitcoin-core-dev
563 2019-10-26T23:53:53  *** dviola has joined #bitcoin-core-dev