12019-10-30T00:00:01 *** kees1 has quit IRC
22019-10-30T00:06:02 *** freedomcode has quit IRC
32019-10-30T00:06:24 *** Chris_Stewart_5 has joined #bitcoin-core-dev
42019-10-30T00:16:42 *** Victor_sueca is now known as Victorsueca
52019-10-30T00:17:42 *** milky1 has joined #bitcoin-core-dev
62019-10-30T00:18:32 *** reardencode has joined #bitcoin-core-dev
72019-10-30T00:33:20 *** Chris_Stewart_5 has quit IRC
82019-10-30T00:43:46 *** pinheadmz has quit IRC
92019-10-30T00:47:26 *** AaronvanW has quit IRC
102019-10-30T00:49:39 *** justanotheruser has quit IRC
112019-10-30T00:50:16 *** justanotheruser has joined #bitcoin-core-dev
122019-10-30T01:37:17 *** pinheadmz has joined #bitcoin-core-dev
132019-10-30T01:49:40 *** lightlike has quit IRC
142019-10-30T02:10:14 *** captjakk has joined #bitcoin-core-dev
152019-10-30T02:11:33 *** captjakk_ has joined #bitcoin-core-dev
162019-10-30T02:14:53 *** captjakk has quit IRC
172019-10-30T02:21:35 *** Highway61 has quit IRC
182019-10-30T02:28:21 *** nosss2 has joined #bitcoin-core-dev
192019-10-30T02:30:27 *** ddustin has quit IRC
202019-10-30T02:31:03 *** ddustin has joined #bitcoin-core-dev
212019-10-30T02:35:17 *** ddustin has quit IRC
222019-10-30T02:39:28 *** nosss2 has quit IRC
232019-10-30T02:39:57 *** nosss2 has joined #bitcoin-core-dev
242019-10-30T02:45:08 *** nosss2 has quit IRC
252019-10-30T02:55:50 *** Randolf has joined #bitcoin-core-dev
262019-10-30T03:00:01 *** milky1 has quit IRC
272019-10-30T03:00:01 *** alko89 has quit IRC
282019-10-30T03:00:08 *** alko has joined #bitcoin-core-dev
292019-10-30T03:05:47 *** emilengler_ has joined #bitcoin-core-dev
302019-10-30T03:08:02 *** emilengler has quit IRC
312019-10-30T03:16:48 *** veehexx has joined #bitcoin-core-dev
322019-10-30T03:19:29 *** captjakk_ has quit IRC
332019-10-30T03:19:43 *** captjakk has joined #bitcoin-core-dev
342019-10-30T03:20:31 *** captjakk has joined #bitcoin-core-dev
352019-10-30T03:20:36 *** felixfoertsch23 has joined #bitcoin-core-dev
362019-10-30T03:21:01 *** captjakk has quit IRC
372019-10-30T03:21:15 *** captjakk has joined #bitcoin-core-dev
382019-10-30T03:21:19 *** felixfoertsch has quit IRC
392019-10-30T03:21:48 *** captjakk has quit IRC
402019-10-30T03:22:06 *** captjakk has joined #bitcoin-core-dev
412019-10-30T03:22:51 *** captjakk has joined #bitcoin-core-dev
422019-10-30T04:02:31 *** Randolf has quit IRC
432019-10-30T04:18:26 *** Eagle[TM] has joined #bitcoin-core-dev
442019-10-30T04:19:57 *** EagleTM has quit IRC
452019-10-30T04:19:57 *** soju has joined #bitcoin-core-dev
462019-10-30T05:20:22 *** bitcoin-git has joined #bitcoin-core-dev
472019-10-30T05:20:22 <bitcoin-git> [bitcoin] dodisefti23 opened pull request #17310: Create moneyChangeC++ (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17310
482019-10-30T05:20:23 *** bitcoin-git has left #bitcoin-core-dev
492019-10-30T05:24:40 *** tsujp_ has joined #bitcoin-core-dev
502019-10-30T05:27:11 *** tsujp has quit IRC
512019-10-30T05:31:02 *** hodlen has joined #bitcoin-core-dev
522019-10-30T05:31:45 *** brianhoffman_ has joined #bitcoin-core-dev
532019-10-30T05:34:53 *** brianhoffman has quit IRC
542019-10-30T05:34:54 *** brianhoffman_ is now known as brianhoffman
552019-10-30T05:35:29 *** hodlen has quit IRC
562019-10-30T05:36:59 *** hodlen has joined #bitcoin-core-dev
572019-10-30T05:42:05 *** jarthur has joined #bitcoin-core-dev
582019-10-30T05:45:05 *** EagleTM has joined #bitcoin-core-dev
592019-10-30T05:46:36 *** hodlen has quit IRC
602019-10-30T05:47:14 *** Eagle[TM] has quit IRC
612019-10-30T05:51:47 *** hodlen_caufield has joined #bitcoin-core-dev
622019-10-30T05:59:49 *** Highway61 has joined #bitcoin-core-dev
632019-10-30T06:00:02 *** veehexx has quit IRC
642019-10-30T06:08:19 *** hodlen_caufield has quit IRC
652019-10-30T06:17:37 *** ddustin has joined #bitcoin-core-dev
662019-10-30T06:18:41 *** bitcoin-git has joined #bitcoin-core-dev
672019-10-30T06:18:42 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #17310: Create moneyChangeC++ (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17310
682019-10-30T06:18:42 *** bitcoin-git has left #bitcoin-core-dev
692019-10-30T06:21:41 *** bitcoin-git has joined #bitcoin-core-dev
702019-10-30T06:21:42 <bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17273: build: proper fix for the kerning issue in macOS build fixes #16836 (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17273
712019-10-30T06:21:43 *** bitcoin-git has left #bitcoin-core-dev
722019-10-30T06:25:18 *** kabaum has quit IRC
732019-10-30T06:32:25 *** arik_ has joined #bitcoin-core-dev
742019-10-30T06:34:02 *** Victorsueca has quit IRC
752019-10-30T06:47:40 *** jarthur has quit IRC
762019-10-30T06:48:10 *** Guest58618 has joined #bitcoin-core-dev
772019-10-30T07:01:29 *** arik_ has quit IRC
782019-10-30T07:02:05 *** arik_ has joined #bitcoin-core-dev
792019-10-30T07:10:09 *** timothy has joined #bitcoin-core-dev
802019-10-30T07:17:29 *** EagleTM has quit IRC
812019-10-30T07:25:38 *** bitcoin-git has joined #bitcoin-core-dev
822019-10-30T07:25:38 <bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17311: build: macOS fix background.svg (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17311
832019-10-30T07:25:41 *** captjakk has joined #bitcoin-core-dev
842019-10-30T07:25:51 *** bitcoin-git has left #bitcoin-core-dev
852019-10-30T07:25:54 *** jungly has joined #bitcoin-core-dev
862019-10-30T07:37:00 *** kabaum has joined #bitcoin-core-dev
872019-10-30T07:53:08 *** IGHOR has quit IRC
882019-10-30T07:54:50 *** arik_ has quit IRC
892019-10-30T07:56:03 *** IGHOR has joined #bitcoin-core-dev
902019-10-30T07:59:11 *** kabaum has quit IRC
912019-10-30T08:09:58 *** AaronvanW has joined #bitcoin-core-dev
922019-10-30T08:12:03 *** kabaum has joined #bitcoin-core-dev
932019-10-30T08:20:02 *** luke-jr has quit IRC
942019-10-30T08:20:10 *** marcoagner has joined #bitcoin-core-dev
952019-10-30T08:22:03 *** jonatack has quit IRC
962019-10-30T08:22:20 *** luke-jr has joined #bitcoin-core-dev
972019-10-30T08:36:10 *** ddustin has quit IRC
982019-10-30T08:36:37 *** kabaum has quit IRC
992019-10-30T08:46:42 *** Bullit has quit IRC
1002019-10-30T08:47:08 *** Bullit has joined #bitcoin-core-dev
1012019-10-30T09:00:01 *** Guest58618 has quit IRC
1022019-10-30T09:08:32 *** jonatack has joined #bitcoin-core-dev
1032019-10-30T09:10:21 *** Guyver2 has joined #bitcoin-core-dev
1042019-10-30T09:18:19 *** jbarnette has joined #bitcoin-core-dev
1052019-10-30T09:19:06 *** bitcoin-git has joined #bitcoin-core-dev
1062019-10-30T09:19:06 <bitcoin-git> [bitcoin] laanwj opened pull request #17312: Improve tracethread usability and trace loadblk thread (master...2019_10_tracedthread) https://github.com/bitcoin/bitcoin/pull/17312
1072019-10-30T09:19:07 *** bitcoin-git has left #bitcoin-core-dev
1082019-10-30T09:21:42 *** kabaum has joined #bitcoin-core-dev
1092019-10-30T09:23:32 *** jonatack has quit IRC
1102019-10-30T09:24:15 *** jonatack has joined #bitcoin-core-dev
1112019-10-30T09:30:05 *** jonatack_ has joined #bitcoin-core-dev
1122019-10-30T09:30:44 *** jonatack has quit IRC
1132019-10-30T09:33:50 *** jonatack_ has quit IRC
1142019-10-30T09:34:07 *** jonatack has joined #bitcoin-core-dev
1152019-10-30T09:38:22 *** jonatack has quit IRC
1162019-10-30T09:39:47 <wumpus> argh, how do I pass a const std::string to util::ThreadRename(std::string&& name)? https://github.com/bitcoin/bitcoin/pull/17312#pullrequestreview-309065741
1172019-10-30T09:40:26 <wumpus> in rust you'd add something like .clone()
1182019-10-30T09:43:26 *** bitcoin-git has joined #bitcoin-core-dev
1192019-10-30T09:43:27 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ecad0a8019fb...5728f88d645c
1202019-10-30T09:43:27 <bitcoin-git> bitcoin/master f3b51eb Wladimir J. van der Laan: Fix occurences of c_str() used with size() to data()
1212019-10-30T09:43:28 <bitcoin-git> bitcoin/master 5728f88 Wladimir J. van der Laan: Merge #17280: refactor: Change occurences of c_str() used with size() to d...
1222019-10-30T09:43:29 *** bitcoin-git has left #bitcoin-core-dev
1232019-10-30T09:43:46 *** bitcoin-git has joined #bitcoin-core-dev
1242019-10-30T09:43:47 <bitcoin-git> [bitcoin] laanwj merged pull request #17280: refactor: Change occurences of c_str() used with size() to data() (master...2019_10_c_str_size) https://github.com/bitcoin/bitcoin/pull/17280
1252019-10-30T09:43:48 *** bitcoin-git has left #bitcoin-core-dev
1262019-10-30T09:44:35 <elichai2> wumpus: you could "clone" it like `std::string str2(str1);` (pretty sure that will clone the data)
1272019-10-30T09:44:50 <wumpus> there must be a 'proper' way right?
1282019-10-30T09:45:04 <wumpus> hm maybe just wrapping in std::string(...) would do it
1292019-10-30T09:45:32 <elichai2> if you ever find a guide for "idiomatic" C++ please tell me :)
1302019-10-30T09:46:26 <wumpus> point taken
1312019-10-30T09:47:14 <wumpus> I don't understand why ThreadRename would take a move argument anyhow, it seems a pointless case of over-optimization
1322019-10-30T09:47:21 <wumpus> but not going to address that here
1332019-10-30T09:53:13 <elichai2> i like that the rust `.clone()` makes it really easy to see all the allocations going on, while in C++ it's way more subtle
1342019-10-30T09:54:04 *** siom_ has joined #bitcoin-core-dev
1352019-10-30T09:54:34 <wumpus> yes, in general rust seems to be better thought out
1362019-10-30T09:57:14 *** tsujp_ has quit IRC
1372019-10-30T09:59:18 *** Highway61 has quit IRC
1382019-10-30T09:59:45 *** Highway61 has joined #bitcoin-core-dev
1392019-10-30T10:02:38 *** tsujp has joined #bitcoin-core-dev
1402019-10-30T10:05:14 *** cryptoIndio has quit IRC
1412019-10-30T10:14:56 *** kabaum has quit IRC
1422019-10-30T10:15:30 *** Highway61 has quit IRC
1432019-10-30T10:15:58 *** Highway61 has joined #bitcoin-core-dev
1442019-10-30T10:24:38 <wumpus> I guess its whole point is to make it harder to make subtle mistakes and avoid all C++'s footguns
1452019-10-30T10:26:07 *** rh0nj has joined #bitcoin-core-dev
1462019-10-30T10:27:25 *** kabaum has joined #bitcoin-core-dev
1472019-10-30T10:30:02 *** Highway61 has quit IRC
1482019-10-30T10:30:45 *** spinza has quit IRC
1492019-10-30T10:35:43 *** cryptoIndio has joined #bitcoin-core-dev
1502019-10-30T10:40:45 *** cryptoIndio has quit IRC
1512019-10-30T10:42:15 *** DavidMitchell[m] has quit IRC
1522019-10-30T10:42:16 *** TheFuzzStone[m] has quit IRC
1532019-10-30T10:42:20 *** awesome-doge has quit IRC
1542019-10-30T10:42:23 *** kewde[m] has quit IRC
1552019-10-30T10:42:40 *** electric-sheep[m has quit IRC
1562019-10-30T10:44:27 *** BlueMatt has quit IRC
1572019-10-30T10:45:00 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1582019-10-30T10:46:58 *** BlueMatt has joined #bitcoin-core-dev
1592019-10-30T10:53:55 *** bitcoin-git has joined #bitcoin-core-dev
1602019-10-30T10:53:56 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5728f88d645c...6daddc449555
1612019-10-30T10:53:56 <bitcoin-git> bitcoin/master dd94cc4 fanquake: contrib: remove accounts from bash completion
1622019-10-30T10:53:57 <bitcoin-git> bitcoin/master 6daddc4 Wladimir J. van der Laan: Merge #17282: contrib: remove accounts from bash completion
1632019-10-30T10:54:05 *** bitcoin-git has left #bitcoin-core-dev
1642019-10-30T10:54:20 *** bitcoin-git has joined #bitcoin-core-dev
1652019-10-30T10:54:20 <bitcoin-git> [bitcoin] laanwj merged pull request #17282: contrib: remove accounts from bash completion (master...update_bash_completion) https://github.com/bitcoin/bitcoin/pull/17282
1662019-10-30T10:54:31 *** bitcoin-git has left #bitcoin-core-dev
1672019-10-30T11:00:21 *** AaronvanW has quit IRC
1682019-10-30T11:03:12 *** electric-sheep[m has joined #bitcoin-core-dev
1692019-10-30T11:09:48 *** cryptoIndio has joined #bitcoin-core-dev
1702019-10-30T11:10:24 *** DavidMitchell[m] has joined #bitcoin-core-dev
1712019-10-30T11:10:25 *** kewde[m] has joined #bitcoin-core-dev
1722019-10-30T11:10:25 *** awesome-doge has joined #bitcoin-core-dev
1732019-10-30T11:10:25 *** TheFuzzStone[m] has joined #bitcoin-core-dev
1742019-10-30T11:15:57 *** kabaum has quit IRC
1752019-10-30T11:23:51 *** bitcoin-git has joined #bitcoin-core-dev
1762019-10-30T11:23:51 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6daddc449555...f129170b8592
1772019-10-30T11:23:52 <bitcoin-git> bitcoin/master 37b8475 Jorge Timón: Chainparams: Use name constants in chainparams initialization
1782019-10-30T11:23:52 <bitcoin-git> bitcoin/master f129170 Wladimir J. van der Laan: Merge #17306: refactor: Use name constants in chainparams initialization
1792019-10-30T11:23:54 *** bitcoin-git has left #bitcoin-core-dev
1802019-10-30T11:24:11 *** bitcoin-git has joined #bitcoin-core-dev
1812019-10-30T11:24:11 <bitcoin-git> [bitcoin] laanwj merged pull request #17306: refactor: Use name constants in chainparams initialization (master...b20-chain-constants) https://github.com/bitcoin/bitcoin/pull/17306
1822019-10-30T11:24:12 *** bitcoin-git has left #bitcoin-core-dev
1832019-10-30T11:34:42 *** aqquadro has joined #bitcoin-core-dev
1842019-10-30T11:36:12 *** bitcoin-git has joined #bitcoin-core-dev
1852019-10-30T11:36:13 <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/f129170b8592...471e5f882907
1862019-10-30T11:36:14 <bitcoin-git> bitcoin/master 301bd41 Russell Yanofsky: scripted-diff: Rename InitInterfaces to NodeContext
1872019-10-30T11:36:15 <bitcoin-git> bitcoin/master 4d5448c Russell Yanofsky: MOVEONLY: Move NodeContext struct to node/context.h
1882019-10-30T11:36:15 <bitcoin-git> bitcoin/master e6f4f89 Russell Yanofsky: Pass NodeContext, ConnMan, BanMan references more places
1892019-10-30T11:36:17 *** bitcoin-git has left #bitcoin-core-dev
1902019-10-30T11:36:32 *** bitcoin-git has joined #bitcoin-core-dev
1912019-10-30T11:36:32 <bitcoin-git> [bitcoin] laanwj merged pull request #16839: Replace Connman and BanMan globals with NodeContext local (master...pr/noglob) https://github.com/bitcoin/bitcoin/pull/16839
1922019-10-30T11:36:33 *** bitcoin-git has left #bitcoin-core-dev
1932019-10-30T11:38:54 *** bitcoin-git has joined #bitcoin-core-dev
1942019-10-30T11:38:55 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/471e5f882907...edd9d0781b96
1952019-10-30T11:38:55 <bitcoin-git> bitcoin/master 3187934 Wladimir J. van der Laan: cli: Add "headers" and "verificationprogress" to -getinfo
1962019-10-30T11:38:56 <bitcoin-git> bitcoin/master edd9d07 Wladimir J. van der Laan: Merge #17302: cli: Add "headers" and "verificationprogress" to -getinfo
1972019-10-30T11:38:58 *** bitcoin-git has left #bitcoin-core-dev
1982019-10-30T11:39:15 *** bitcoin-git has joined #bitcoin-core-dev
1992019-10-30T11:39:15 <bitcoin-git> [bitcoin] laanwj merged pull request #17302: cli: Add "headers" and "verificationprogress" to -getinfo (master...2019_10_getinfo) https://github.com/bitcoin/bitcoin/pull/17302
2002019-10-30T11:39:17 *** bitcoin-git has left #bitcoin-core-dev
2012019-10-30T11:44:40 *** davterra has joined #bitcoin-core-dev
2022019-10-30T11:53:18 *** setpill has joined #bitcoin-core-dev
2032019-10-30T11:53:37 *** nijynot has joined #bitcoin-core-dev
2042019-10-30T11:59:39 *** Chris_Stewart_5 has quit IRC
2052019-10-30T12:00:02 *** jbarnette has quit IRC
2062019-10-30T12:03:53 *** ExtraCrispy has joined #bitcoin-core-dev
2072019-10-30T12:07:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2082019-10-30T12:09:09 *** Victorsueca has joined #bitcoin-core-dev
2092019-10-30T12:12:05 <setpill> wumpus: re #16994 there is no status label that can be applied to "blocked" or "waiting" PRs? not sure how differentiation between "abandoned" and "will be picked up later again after external issues are resolved" is made if both are closed without label.
2102019-10-30T12:12:07 <gribble> https://github.com/bitcoin/bitcoin/issues/16994 | contrib: replace deprecated PermissionsStartOnly in systemd init by setpill · Pull Request #16994 · bitcoin/bitcoin · GitHub
2112019-10-30T12:13:16 <wumpus> no, there's no label for that; I'm asking you to close the PR instead of doing it myself, because then you can open it again when you deem the time is there
2122019-10-30T12:13:29 <setpill> ack
2132019-10-30T12:13:54 *** bitcoin-git has joined #bitcoin-core-dev
2142019-10-30T12:13:55 <bitcoin-git> [bitcoin] setpill closed pull request #16994: contrib: replace deprecated PermissionsStartOnly in systemd init (master...fix-deprecated-permissionsstartonly) https://github.com/bitcoin/bitcoin/pull/16994
2152019-10-30T12:13:55 *** bitcoin-git has left #bitcoin-core-dev
2162019-10-30T12:14:02 <wumpus> I guess I can add milestone 'future'
2172019-10-30T12:15:18 <wumpus> it's the closest thing, it basically means that it should be revisited at some unspecified time in the future
2182019-10-30T12:15:43 *** aqquadro has quit IRC
2192019-10-30T12:16:14 <setpill> personally prefer terminology like "blocked" to indicate this kind of situation. "future" has prioritization connotations that don't really apply to a project like this where people are welcomed to just pop in and out to contribute whatever they feel like contributing :)
2202019-10-30T12:17:49 <wumpus> but 'blocked' has 'we should first do some other work' connotations (e.g. "blockers" in high priority for review), usually things are blocked on other things that need to be done
2212019-10-30T12:17:50 *** othe1 has joined #bitcoin-core-dev
2222019-10-30T12:18:12 <setpill> ah, fair point
2232019-10-30T12:19:54 <setpill> either is probably fine, before you know it you have 10 different labels for all the subtle variations of this kind of situation
2242019-10-30T12:20:15 <setpill> anyway, closed for now, let's hope i remember to revisit it (:
2252019-10-30T12:22:18 <wumpus> yes, though I'm sure someone will pick it up as soon as systemd starts rejecting the setting :)
2262019-10-30T12:26:29 *** kabaum has joined #bitcoin-core-dev
2272019-10-30T12:30:30 *** sosthene has quit IRC
2282019-10-30T12:40:50 *** jtimon has joined #bitcoin-core-dev
2292019-10-30T12:45:49 <jtimon> I've been rebasing a commit similar to https://github.com/bitcoin/bitcoin/pull/16681 for years (which is a bit annoying as new instances appeared) and people are still complaining because it is not complete and more instances may appear.
2302019-10-30T12:45:49 <jtimon> On the other hand I created https://github.com/bitcoin/bitcoin/pull/17306 and it was merged in 16 hours, being incomplete and with a nit on it.
2312019-10-30T12:45:49 <jtimon> Sometimes I really don't understand the criteria, guys. Not a big deal, but it doesn't seem consistent.
2322019-10-30T12:46:44 *** Highway61 has joined #bitcoin-core-dev
2332019-10-30T12:46:56 <wumpus> I'm sorry for the whitespace nit but I disagree it is 'incomplete', it's a small change that makes sense
2342019-10-30T12:47:50 <wumpus> as I've commented in the PR I think it's a bad idea if you have conceptual and code review on a PR, and two ACKs, to extend the scope, feel free to do the rest in a new PR
2352019-10-30T12:49:32 <wumpus> if you did replace all the other occcurences it could have easily have been drawn out to a PR that takes months, because there would be a discussion about what to change and whatnot
2362019-10-30T12:49:37 <wumpus> in this case there was general agreement
2372019-10-30T12:50:23 *** aqquadro has joined #bitcoin-core-dev
2382019-10-30T12:50:26 <wumpus> maybe you could learn from it and do more small, targeted PRs :)
2392019-10-30T12:53:20 *** Chris_Stewart_5 has quit IRC
2402019-10-30T12:58:38 *** IGHOR has quit IRC
2412019-10-30T13:02:17 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2422019-10-30T13:02:34 *** IGHOR has joined #bitcoin-core-dev
2432019-10-30T13:07:00 *** Guyver2 has quit IRC
2442019-10-30T13:07:37 *** IGHOR has quit IRC
2452019-10-30T13:10:07 *** IGHOR has joined #bitcoin-core-dev
2462019-10-30T13:10:19 *** brianhoffman_ has joined #bitcoin-core-dev
2472019-10-30T13:10:42 *** brianhoffman has quit IRC
2482019-10-30T13:10:42 *** brianhoffman_ is now known as brianhoffman
2492019-10-30T13:17:36 *** emilengler_ has quit IRC
2502019-10-30T13:19:04 *** emilengler has joined #bitcoin-core-dev
2512019-10-30T13:29:34 *** bitcoin-git has joined #bitcoin-core-dev
2522019-10-30T13:29:35 <bitcoin-git> [bitcoin] laanwj opened pull request #17316: refactor: Replace all uses of boost::optional with our own Optional type (master...2019_10_optional) https://github.com/bitcoin/bitcoin/pull/17316
2532019-10-30T13:29:37 *** bitcoin-git has left #bitcoin-core-dev
2542019-10-30T13:36:59 *** IGHOR has quit IRC
2552019-10-30T13:37:07 *** kabaum has quit IRC
2562019-10-30T13:39:32 *** IGHOR has joined #bitcoin-core-dev
2572019-10-30T13:44:40 *** IGHOR has quit IRC
2582019-10-30T13:47:22 *** IGHOR has joined #bitcoin-core-dev
2592019-10-30T13:48:44 *** IGHOR has quit IRC
2602019-10-30T13:49:57 *** Chris_Stewart_5 has quit IRC
2612019-10-30T13:54:19 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2622019-10-30T13:55:10 *** greypw has quit IRC
2632019-10-30T13:55:41 *** greypw has joined #bitcoin-core-dev
2642019-10-30T13:55:51 *** nijynot has quit IRC
2652019-10-30T13:57:20 *** nijynot has joined #bitcoin-core-dev
2662019-10-30T13:58:32 *** rex4539 has quit IRC
2672019-10-30T14:00:23 *** mmgen has joined #bitcoin-core-dev
2682019-10-30T14:05:41 *** nijynot has quit IRC
2692019-10-30T14:06:54 *** bitcoin-git has joined #bitcoin-core-dev
2702019-10-30T14:06:54 <bitcoin-git> [bitcoin] adamjonas opened pull request #17318: replace asserts in RPC code with CHECK_NONFATAL and add linter (master...replace-rpc-asserts-for-CHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17318
2712019-10-30T14:07:05 *** bitcoin-git has left #bitcoin-core-dev
2722019-10-30T14:12:56 *** nosss2 has joined #bitcoin-core-dev
2732019-10-30T14:15:23 *** jb55 has quit IRC
2742019-10-30T14:15:59 *** jb55 has joined #bitcoin-core-dev
2752019-10-30T14:21:39 *** bitcoin-git has joined #bitcoin-core-dev
2762019-10-30T14:21:40 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/edd9d0781b96...341e8d355d1a
2772019-10-30T14:21:40 <bitcoin-git> bitcoin/master d5dbb48 practicalswift: tests: Add fuzzing harness for ISO-8601 related functions
2782019-10-30T14:21:41 <bitcoin-git> bitcoin/master 595cc9b practicalswift: docs: Add undefined to --with-sanitizers=fuzzer,address
2792019-10-30T14:21:41 <bitcoin-git> bitcoin/master 341e8d3 MarcoFalke: Merge #17291: tests: Add fuzzing harness for ISO-8601 related functions
2802019-10-30T14:21:43 *** bitcoin-git has left #bitcoin-core-dev
2812019-10-30T14:21:59 *** bitcoin-git has joined #bitcoin-core-dev
2822019-10-30T14:21:59 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17291: tests: Add fuzzing harness for ISO-8601 related functions (master...fuzzers-parse_iso8601) https://github.com/bitcoin/bitcoin/pull/17291
2832019-10-30T14:22:09 *** bitcoin-git has left #bitcoin-core-dev
2842019-10-30T14:23:23 *** bitcoin-git has joined #bitcoin-core-dev
2852019-10-30T14:23:23 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/341e8d355d1a...cab94cc07489
2862019-10-30T14:23:24 <bitcoin-git> bitcoin/master fa144e6 MarcoFalke: rpc: Add generatetodescriptor
2872019-10-30T14:23:24 <bitcoin-git> bitcoin/master cab94cc Wladimir J. van der Laan: Merge #16943: test: Add generatetodescriptor RPC
2882019-10-30T14:23:26 *** bitcoin-git has left #bitcoin-core-dev
2892019-10-30T14:23:43 *** bitcoin-git has joined #bitcoin-core-dev
2902019-10-30T14:23:43 <bitcoin-git> [bitcoin] laanwj merged pull request #16943: test: Add generatetodescriptor RPC (master...1909-rpcMiningDescriptor) https://github.com/bitcoin/bitcoin/pull/16943
2912019-10-30T14:23:44 *** bitcoin-git has left #bitcoin-core-dev
2922019-10-30T14:36:41 *** mdunnio has joined #bitcoin-core-dev
2932019-10-30T14:38:12 *** bitcoin-git has joined #bitcoin-core-dev
2942019-10-30T14:38:14 <bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/cab94cc07489...3c40bc6726b6
2952019-10-30T14:38:14 <bitcoin-git> bitcoin/master a27a295 John Newbery: [validation] Add CValidationState subclasses
2962019-10-30T14:38:15 <bitcoin-git> bitcoin/master 067981e John Newbery: [validation] Tidy Up ValidationResult class
2972019-10-30T14:38:16 <bitcoin-git> bitcoin/master 1a37de4 John Newbery: [validation] Remove error() calls from Invalid() calls
2982019-10-30T14:38:18 *** bitcoin-git has left #bitcoin-core-dev
2992019-10-30T14:38:52 *** bitcoin-git has joined #bitcoin-core-dev
3002019-10-30T14:38:52 <bitcoin-git> [bitcoin] laanwj merged pull request #15921: validation: Tidy up ValidationState interface (master...2019-04-pr15141-cleanups) https://github.com/bitcoin/bitcoin/pull/15921
3012019-10-30T14:38:53 *** bitcoin-git has left #bitcoin-core-dev
3022019-10-30T14:42:44 *** rex4539 has joined #bitcoin-core-dev
3032019-10-30T14:44:37 *** lightlike has joined #bitcoin-core-dev
3042019-10-30T14:47:38 *** mdunnio has quit IRC
3052019-10-30T14:48:59 *** mdunnio has joined #bitcoin-core-dev
3062019-10-30T14:50:42 *** diogosergio has joined #bitcoin-core-dev
3072019-10-30T14:57:54 *** diogosergio has quit IRC
3082019-10-30T14:58:19 *** bitcoin-git has joined #bitcoin-core-dev
3092019-10-30T14:58:20 <bitcoin-git> [bitcoin] jnewbery opened pull request #17319: Tests: remove bignum module (master...2019-10-bignum) https://github.com/bitcoin/bitcoin/pull/17319
3102019-10-30T14:58:20 *** bitcoin-git has left #bitcoin-core-dev
3112019-10-30T14:59:03 *** diogosergio has joined #bitcoin-core-dev
3122019-10-30T15:00:01 *** othe1 has quit IRC
3132019-10-30T15:08:48 *** IGHOR has joined #bitcoin-core-dev
3142019-10-30T15:13:29 *** ddustin has joined #bitcoin-core-dev
3152019-10-30T15:17:36 *** rex4539 has quit IRC
3162019-10-30T15:20:30 *** Guyver2 has joined #bitcoin-core-dev
3172019-10-30T15:27:04 *** diogosergio has quit IRC
3182019-10-30T15:28:50 *** captjakk has quit IRC
3192019-10-30T15:30:02 *** diogosergio has joined #bitcoin-core-dev
3202019-10-30T15:32:19 *** rex4539 has joined #bitcoin-core-dev
3212019-10-30T15:34:54 *** diogosergio has quit IRC
3222019-10-30T15:34:59 *** diogoser1io has joined #bitcoin-core-dev
3232019-10-30T15:35:00 *** otium has joined #bitcoin-core-dev
3242019-10-30T15:39:31 *** jarthur has joined #bitcoin-core-dev
3252019-10-30T15:41:03 *** davterra has quit IRC
3262019-10-30T15:43:01 *** jarthur has quit IRC
3272019-10-30T15:43:14 *** jarthur has joined #bitcoin-core-dev
3282019-10-30T15:43:22 *** davterra has joined #bitcoin-core-dev
3292019-10-30T15:47:21 <wumpus> rc3 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.19.0/test.rc3/
3302019-10-30T15:48:59 <fanquake> ð
3312019-10-30T15:50:26 *** mdunnio has quit IRC
3322019-10-30T15:52:20 *** mdunnio has joined #bitcoin-core-dev
3332019-10-30T15:55:24 *** rex4539 has quit IRC
3342019-10-30T15:57:30 *** mdunnio_ has joined #bitcoin-core-dev
3352019-10-30T16:00:24 *** mdunnio_ has joined #bitcoin-core-dev
3362019-10-30T16:01:15 *** mdunnio has quit IRC
3372019-10-30T16:05:38 *** owowo has quit IRC
3382019-10-30T16:10:35 *** owowo has joined #bitcoin-core-dev
3392019-10-30T16:11:08 *** bitcoin-git has joined #bitcoin-core-dev
3402019-10-30T16:11:08 <bitcoin-git> [bitcoin] practicalswift opened pull request #17320: Make compiler warn about tautological comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
3412019-10-30T16:11:09 *** bitcoin-git has left #bitcoin-core-dev
3422019-10-30T16:15:11 *** b_b1 has joined #bitcoin-core-dev
3432019-10-30T16:16:19 *** JeremyCrookshank has joined #bitcoin-core-dev
3442019-10-30T16:16:32 <JeremyCrookshank> Hello :)
3452019-10-30T16:16:48 <wumpus> hello !
3462019-10-30T16:17:25 *** AaronvanW has joined #bitcoin-core-dev
3472019-10-30T16:19:07 *** bitcoin-git has joined #bitcoin-core-dev
3482019-10-30T16:19:08 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3c40bc6726b6...a6abc94e9307
3492019-10-30T16:19:08 <bitcoin-git> bitcoin/master 1cf9b35 Wladimir J. van der Laan: doc: Add developer note on c_str()
3502019-10-30T16:19:09 <bitcoin-git> bitcoin/master a6abc94 Wladimir J. van der Laan: Merge #17281: doc: Add developer note on c_str()
3512019-10-30T16:19:11 *** bitcoin-git has left #bitcoin-core-dev
3522019-10-30T16:19:17 <JeremyCrookshank> What is the community's consensus on Core GUI? Changing design ect? I saw a few PR's in the past aimed at improving it
3532019-10-30T16:19:27 *** bitcoin-git has joined #bitcoin-core-dev
3542019-10-30T16:19:28 <bitcoin-git> [bitcoin] laanwj merged pull request #17281: doc: Add developer note on c_str() (master...2019_10_c_str_note) https://github.com/bitcoin/bitcoin/pull/17281
3552019-10-30T16:19:28 *** bitcoin-git has left #bitcoin-core-dev
3562019-10-30T16:19:39 <JeremyCrookshank> or using more advanced QT features?
3572019-10-30T16:22:54 *** arik_ has joined #bitcoin-core-dev
3582019-10-30T16:23:19 <luke-jr> JeremyCrookshank: minimum Qt version needs to be something available on stable releases of major distros (typically RHEL or Debian are the bottlenecks)
3592019-10-30T16:23:43 <luke-jr> and if some people might consider it worse than before, you might have an issue
3602019-10-30T16:24:04 <luke-jr> but otherwise should be same as any other improvement: slow moving, but eventually get in
3612019-10-30T16:24:24 *** captjakk has joined #bitcoin-core-dev
3622019-10-30T16:25:00 <sipa> JeremyCrookshank: hard to discuss without knowing what you're talking about
3632019-10-30T16:25:02 <wumpus> do you have any specific thing you'd like to work on?
3642019-10-30T16:25:42 <wumpus> what kind of more advanced qt features? there's a PR that adds qr code recognition (and would need qtmultimedia), as well as one adding a qml-based GUI for android
3652019-10-30T16:25:55 <wumpus> nothing is ruled out if you have a good reason'
3662019-10-30T16:26:01 <JeremyCrookshank> I don't have specifics but noted the general design hasn't really changed(not a bad thing). I would love to work on the GUI but still a c++ noob :p
3672019-10-30T16:26:19 <luke-jr> I think it's just lack of people focussed on it
3682019-10-30T16:26:42 <luke-jr> although otoh someone recently tried to revamp icons and ended up with all of them removed entirely :/
3692019-10-30T16:26:44 *** Highway61 has quit IRC
3702019-10-30T16:26:46 <JeremyCrookshank> I would love something small to work on on the side on the GUI which would be useful
3712019-10-30T16:26:46 *** captjakk has quit IRC
3722019-10-30T16:26:48 <luke-jr> menu icons*
3732019-10-30T16:26:54 <JeremyCrookshank> Yeah I saw icons went, quite liked them :)
3742019-10-30T16:27:01 *** nijynot has joined #bitcoin-core-dev
3752019-10-30T16:27:41 <wumpus> be careful to not fall into the trap of trying to make a 'cool gui', that's not the point of it, akin to industrial UIs the important thing is that it's hard to make mistakes
3762019-10-30T16:28:28 <wumpus> because payments are inherently irreversible
3772019-10-30T16:28:47 <luke-jr> wumpus: arguably reversible payments could be done, just nobody cares to :p
3782019-10-30T16:29:44 <wumpus> it could be done as a layer on top, but yeah, that's not my point here :)
3792019-10-30T16:29:55 <luke-jr> eg, BIP70-workalike + time locked tx
3802019-10-30T16:31:49 *** ddustin has quit IRC
3812019-10-30T16:32:01 <JeremyCrookshank> wumpus I understand
3822019-10-30T16:33:14 *** nijynot has quit IRC
3832019-10-30T16:33:37 *** mdunnio_ has quit IRC
3842019-10-30T16:38:26 *** mdunnio has joined #bitcoin-core-dev
3852019-10-30T16:39:06 *** bitcoin-git has joined #bitcoin-core-dev
3862019-10-30T16:39:06 <bitcoin-git> [bitcoin] practicalswift closed pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
3872019-10-30T16:39:07 *** bitcoin-git has left #bitcoin-core-dev
3882019-10-30T16:42:09 *** captjakk has joined #bitcoin-core-dev
3892019-10-30T16:48:37 *** mdunnio has quit IRC
3902019-10-30T16:51:07 *** rex4539 has joined #bitcoin-core-dev
3912019-10-30T16:52:12 *** bitcoin-git has joined #bitcoin-core-dev
3922019-10-30T16:52:13 <bitcoin-git> [bitcoin] practicalswift reopened pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
3932019-10-30T16:52:14 *** bitcoin-git has left #bitcoin-core-dev
3942019-10-30T16:55:47 *** ajonas has joined #bitcoin-core-dev
3952019-10-30T16:56:22 *** timothy has quit IRC
3962019-10-30T17:01:24 *** diogoser1io has left #bitcoin-core-dev
3972019-10-30T17:01:47 *** bitcoin-git has joined #bitcoin-core-dev
3982019-10-30T17:01:48 <bitcoin-git> [bitcoin] instagibbs opened pull request #17322: Fix input size assertion in wallet_bumpfee.py (master...w_bp_assert) https://github.com/bitcoin/bitcoin/pull/17322
3992019-10-30T17:01:49 *** bitcoin-git has left #bitcoin-core-dev
4002019-10-30T17:02:09 *** nosss2 has quit IRC
4012019-10-30T17:03:28 <wumpus> the best way to help with the GUI if you're not writing code is probably to help testing open PRs, such as #16966
4022019-10-30T17:03:31 <gribble> https://github.com/bitcoin/bitcoin/issues/16966 | ui: make send a wizard by Sjors · Pull Request #16966 · bitcoin/bitcoin · GitHub
4032019-10-30T17:04:31 *** michaelfolkson has joined #bitcoin-core-dev
4042019-10-30T17:05:14 *** andytoshi has joined #bitcoin-core-dev
4052019-10-30T17:05:15 *** andytoshi has joined #bitcoin-core-dev
4062019-10-30T17:10:07 *** rex4539 has quit IRC
4072019-10-30T17:11:07 *** rex4539 has joined #bitcoin-core-dev
4082019-10-30T17:14:08 *** mmgen has quit IRC
4092019-10-30T17:17:31 *** ddustin has joined #bitcoin-core-dev
4102019-10-30T17:18:51 *** mdunnio has joined #bitcoin-core-dev
4112019-10-30T17:19:03 *** ddustin has joined #bitcoin-core-dev
4122019-10-30T17:20:21 *** mmgen has joined #bitcoin-core-dev
4132019-10-30T17:20:37 *** mdunnio has quit IRC
4142019-10-30T17:20:53 *** mdunnio has joined #bitcoin-core-dev
4152019-10-30T17:21:03 <BlueMatt> dongcarl: lol, stop telling me how to fix build system shit...I dont know what any of your comments mean
4162019-10-30T17:22:11 *** JeremyCrookshank has quit IRC
4172019-10-30T17:22:16 <dongcarl> BlueMatt: Lol they were more for cfields and fanquake than for you (since we decided to work on the build system changes on ur PR instead of a separate one)
4182019-10-30T17:22:18 *** mdunnio has quit IRC
4192019-10-30T17:24:07 <moneyball> I tried to install RC3 but get this message. Anyone else successfully install on Catalina? https://usercontent.irccloud-cdn.com/file/fXdVFAmw/Screen%20Shot%202019-10-30%20at%2010.15.40%20AM.png
4202019-10-30T17:24:09 *** arik_ has quit IRC
4212019-10-30T17:24:32 <BlueMatt> I think that gets fixed during the release process via the signing? cfields?
4222019-10-30T17:26:08 <jtimon> wumpus: fair enough, makes sense to me
4232019-10-30T17:27:28 <moneyball> I've been able to install and run RCs in the past. And, how is a person supposed to test RCs if they cannot run them?
4242019-10-30T17:27:57 <BlueMatt> moneyball: you'll probably have to disable some apple security garbage (maybe by installing xcode?)
4252019-10-30T17:29:35 <moneyball> BlueMatt: thx will try that. i see i haven't reinstalled xcode after my numerous recent hard drive failures
4262019-10-30T17:30:01 <BlueMatt> moneyball: I mean google it first. gotta indicate to some apple subsystem that you're a developer, I'm sure...
4272019-10-30T17:31:58 <moneyball> ok yeah this is a new catalina thing. if you "right click" on the app binary then choose "Open" it will let you run the app
4282019-10-30T17:33:44 <moneyball> fyi in case this is useful to cfields or dongcarl when building the signed release version https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution
4292019-10-30T17:34:23 <wumpus> I think #15774 is related
4302019-10-30T17:34:25 <gribble> https://github.com/bitcoin/bitcoin/issues/15774 | macOS App Notarization · Issue #15774 · bitcoin/bitcoin · GitHub
4312019-10-30T17:36:42 <moneyball> that issue was punted to the next release. at minimum we should test the signed final release of .19 on MacOS
4322019-10-30T17:36:56 *** aqquadro has quit IRC
4332019-10-30T17:38:20 <wumpus> I don't think this is a rc versus final issue, the rcs are signed in the same way as final
4342019-10-30T17:38:39 <wumpus> you might want to post that screenshot in the issue
4352019-10-30T17:38:42 <dongcarl> Yeah my subconscious has been blocking this problem... It seems Apple has gone mad with platform power...
4362019-10-30T17:39:51 <wumpus> one of these days it's just not possible to distribute binaries anymore for open source software
4372019-10-30T17:41:55 *** provoostenator has quit IRC
4382019-10-30T17:43:56 *** provoostenator has joined #bitcoin-core-dev
4392019-10-30T17:45:15 <dongcarl> So, after a cursory glance... It seems like if we don't want to have to tell users to right click > open, we need to use OSX-only tools...
4402019-10-30T17:45:48 <sipa> ugh.
4412019-10-30T17:46:12 *** siom_ has quit IRC
4422019-10-30T17:49:45 <dongcarl> wumpus: I'm not sure if Apple's notarization tools care about reproducibility... So in the worst case it seems we will end up with 2 binary dists for osx: One which is reproducible, but not notarized, and another one which is non-reproducible, but notarized...
4432019-10-30T17:49:52 <wumpus> awesome, that'd rule out cross-platform deterministic builds for OSX
4442019-10-30T17:50:18 <wumpus> I'm unwilling to upload non-reproducible builds to bitcoin(core).org
4452019-10-30T17:50:36 <wumpus> so that's the end of OSX support
4462019-10-30T17:51:40 <dongcarl> wumpus: Perhaps we shall discuss this in the meeting tomorrow?
4472019-10-30T17:51:45 <wumpus> sure
4482019-10-30T17:54:04 *** mdunnio has joined #bitcoin-core-dev
4492019-10-30T17:55:37 <sipa> dongcarl: can we submit our build for notarization? or does the whole building process need to be built inside the Reality Distortion Field?
4502019-10-30T17:56:13 <achow101> I think there's a decent chance that our binaries get rejected by their automatic scanner for being "crypto mining malware"
4512019-10-30T17:56:50 <sipa> won't hurt to try
4522019-10-30T17:57:00 <sipa> worst case it fails, and we ignore it?
4532019-10-30T17:57:09 *** bitcoin-git has joined #bitcoin-core-dev
4542019-10-30T17:57:09 <bitcoin-git> [bitcoin] practicalswift closed pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
4552019-10-30T17:57:19 *** bitcoin-git has left #bitcoin-core-dev
4562019-10-30T17:57:27 *** Highway61 has joined #bitcoin-core-dev
4572019-10-30T17:57:52 <dongcarl> sipa: I'm looking into the process right now... I think we can. ryanofsky mentioned that _if_ we can prove to the users that the output of the notarization process comes from our reproducible build process, then it might be okay, since anyone running a Mac is trusting Apple anyway
4582019-10-30T17:58:26 *** setpill has left #bitcoin-core-dev
4592019-10-30T17:58:28 *** setpill has joined #bitcoin-core-dev
4602019-10-30T17:58:59 <sipa> dongcarl: or have a simple way to strip the notarization out, back to the binary that can be compared to the reproducible buils
4612019-10-30T17:59:27 *** mdunnio has quit IRC
4622019-10-30T18:00:01 *** b_b1 has quit IRC
4632019-10-30T18:02:36 <dongcarl> "After uploading your app, the notarization process typically takes less than an hour."
4642019-10-30T18:04:13 <wumpus> I guess the notarization data itself could be handled in the same way detached signatures are handled now
4652019-10-30T18:04:49 <wumpus> assuming it's like an additional signature of apple
4662019-10-30T18:04:59 <fanquake> Me and Cory have been looking at macOS toolchain issues all day. Can add this to the TODO list..
4672019-10-30T18:05:42 <wumpus> the extra waiting time isn't really ap roblem
4682019-10-30T18:06:24 <dongcarl> Oh it seems like GateKeeper will contact Apple for the notarization if we don't staple it to the app itself
4692019-10-30T18:06:26 <wumpus> (assuming a normal release cycle like this)
4702019-10-30T18:07:04 <dongcarl> We _should_ staple it though, for offline people
4712019-10-30T18:07:08 *** mdunnio has joined #bitcoin-core-dev
4722019-10-30T18:07:26 <wumpus> so getting apple to greenlight the thing is first priority...
4732019-10-30T18:07:46 *** oriondeimos has joined #bitcoin-core-dev
4742019-10-30T18:08:11 <dongcarl> wumpus: yup. Perhaps someone should submit the RC just to see what Apple says?
4752019-10-30T18:11:18 <fanquake> Just discussed with Cory and he said "we'll deal with it tomorrow". Might be something to fix for 0.19.1.
4762019-10-30T18:12:46 <wumpus> I guess people installing the old releases run into the same problem? or is it based on the signing timestamp?
4772019-10-30T18:15:10 *** oriondeimos has quit IRC
4782019-10-30T18:15:28 <dongcarl> It seems like if you notarize old releases then try to run them, Apple will tell you to update to the latest release: https://developer.apple.com/documentation/xcode/notarizing_your_app_before_distribution#3087722
4792019-10-30T18:15:29 <gribble> https://github.com/bitcoin/bitcoin/issues/3087722 | HTTP Error 404: Not Found
4802019-10-30T18:20:41 *** bitcoin-git has joined #bitcoin-core-dev
4812019-10-30T18:20:41 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a6abc94e9307...08e29473126d
4822019-10-30T18:20:42 <bitcoin-git> bitcoin/master d314e8a Wladimir J. van der Laan: refactor: Replace all uses of boost::optional with our own Optional type
4832019-10-30T18:20:43 <bitcoin-git> bitcoin/master 08e2947 fanquake: Merge #17316: refactor: Replace all uses of boost::optional with our own O...
4842019-10-30T18:20:44 *** bitcoin-git has left #bitcoin-core-dev
4852019-10-30T18:21:01 *** bitcoin-git has joined #bitcoin-core-dev
4862019-10-30T18:21:01 <bitcoin-git> [bitcoin] fanquake merged pull request #17316: refactor: Replace all uses of boost::optional with our own Optional type (master...2019_10_optional) https://github.com/bitcoin/bitcoin/pull/17316
4872019-10-30T18:21:04 *** bitcoin-git has left #bitcoin-core-dev
4882019-10-30T18:33:33 *** michaelfolkson has quit IRC
4892019-10-30T18:37:40 *** mdunnio_ has joined #bitcoin-core-dev
4902019-10-30T18:40:49 *** mdunnio has quit IRC
4912019-10-30T18:43:02 *** setpill has quit IRC
4922019-10-30T18:48:00 *** slewis has joined #bitcoin-core-dev
4932019-10-30T18:53:57 *** owowo has quit IRC
4942019-10-30T18:57:49 *** reallll has joined #bitcoin-core-dev
4952019-10-30T19:00:47 *** owowo has joined #bitcoin-core-dev
4962019-10-30T19:00:51 *** belcher has quit IRC
4972019-10-30T19:02:01 *** reallll is now known as belcher
4982019-10-30T19:04:53 *** jonatack has joined #bitcoin-core-dev
4992019-10-30T19:09:33 *** captjakk has quit IRC
5002019-10-30T19:11:31 *** jonatack has quit IRC
5012019-10-30T19:11:56 *** jonatack has joined #bitcoin-core-dev
5022019-10-30T19:14:26 *** ExtraCrispy has quit IRC
5032019-10-30T19:14:27 *** davterra has quit IRC
5042019-10-30T19:15:44 *** davterra has joined #bitcoin-core-dev
5052019-10-30T19:19:19 *** arik_ has joined #bitcoin-core-dev
5062019-10-30T19:34:52 *** andytoshi has quit IRC
5072019-10-30T19:37:04 *** davterra has joined #bitcoin-core-dev
5082019-10-30T19:38:15 *** davterra has quit IRC
5092019-10-30T19:40:34 *** adembudak has joined #bitcoin-core-dev
5102019-10-30T19:41:34 *** bitcoin-git has joined #bitcoin-core-dev
5112019-10-30T19:41:34 <bitcoin-git> [bitcoin] Sjors closed pull request #17301: gui: enable RPC server by default (master...2019/10/gui-server) https://github.com/bitcoin/bitcoin/pull/17301
5122019-10-30T19:41:45 *** bitcoin-git has left #bitcoin-core-dev
5132019-10-30T19:53:06 *** diogosergio has joined #bitcoin-core-dev
5142019-10-30T20:00:05 *** diogosergio has quit IRC
5152019-10-30T20:02:23 *** diogosergio has joined #bitcoin-core-dev
5162019-10-30T20:03:35 <fanquake> https://pastebin.com/2bkRNMbd
5172019-10-30T20:04:05 <fanquake> eh. Wrong window.
5182019-10-30T20:04:45 *** ddustin has quit IRC
5192019-10-30T20:05:31 *** ddustin has joined #bitcoin-core-dev
5202019-10-30T20:05:58 *** diogosergio has quit IRC
5212019-10-30T20:06:13 *** diogosergio has joined #bitcoin-core-dev
5222019-10-30T20:06:42 *** ddustin has joined #bitcoin-core-dev
5232019-10-30T20:09:41 *** ajonas has quit IRC
5242019-10-30T20:11:34 *** jb55 has quit IRC
5252019-10-30T20:12:32 *** jb55 has joined #bitcoin-core-dev
5262019-10-30T20:13:48 *** captjakk has joined #bitcoin-core-dev
5272019-10-30T20:16:10 *** ajonas has joined #bitcoin-core-dev
5282019-10-30T20:26:54 *** bitcoin-git has joined #bitcoin-core-dev
5292019-10-30T20:26:54 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17324: Update univalue subtree (master...1910-updateUnivalue) https://github.com/bitcoin/bitcoin/pull/17324
5302019-10-30T20:26:56 *** bitcoin-git has left #bitcoin-core-dev
5312019-10-30T20:30:34 *** bitcoin-git has joined #bitcoin-core-dev
5322019-10-30T20:30:34 <bitcoin-git> [bitcoin] hebasto opened pull request #17325: log: Fix log message for -par=1 (master...20191030-fix-par-log) https://github.com/bitcoin/bitcoin/pull/17325
5332019-10-30T20:30:45 *** bitcoin-git has left #bitcoin-core-dev
5342019-10-30T20:31:53 *** diogosergio has quit IRC
5352019-10-30T20:32:16 *** diogosergio has joined #bitcoin-core-dev
5362019-10-30T20:40:32 *** harrigan has quit IRC
5372019-10-30T20:44:12 *** harrigan has joined #bitcoin-core-dev
5382019-10-30T20:51:30 *** aqquadro has joined #bitcoin-core-dev
5392019-10-30T20:55:27 *** captjakk_ has joined #bitcoin-core-dev
5402019-10-30T20:59:32 *** captjakk has quit IRC
5412019-10-30T21:00:02 *** slewis has quit IRC
5422019-10-30T21:04:56 *** Chris_Stewart_5 has quit IRC
5432019-10-30T21:08:50 *** Victorsueca has quit IRC
5442019-10-30T21:10:32 *** freedomcode has joined #bitcoin-core-dev
5452019-10-30T21:11:26 *** kristapsk has joined #bitcoin-core-dev
5462019-10-30T21:11:36 *** reardencode has quit IRC
5472019-10-30T21:13:32 *** adembudak has quit IRC
5482019-10-30T21:13:55 *** Victorsueca has joined #bitcoin-core-dev
5492019-10-30T21:16:37 *** alko has quit IRC
5502019-10-30T21:18:02 *** Victorsueca has quit IRC
5512019-10-30T21:18:22 *** ddustin has quit IRC
5522019-10-30T21:18:33 *** alko has joined #bitcoin-core-dev
5532019-10-30T21:18:41 *** ddustin has joined #bitcoin-core-dev
5542019-10-30T21:19:26 *** ddustin has joined #bitcoin-core-dev
5552019-10-30T21:20:16 *** ddustin has joined #bitcoin-core-dev
5562019-10-30T21:21:01 *** ddustin has joined #bitcoin-core-dev
5572019-10-30T21:23:32 *** afk11 has quit IRC
5582019-10-30T21:23:57 *** afk11 has joined #bitcoin-core-dev
5592019-10-30T21:31:35 *** roconnor has quit IRC
5602019-10-30T21:33:40 *** roconnor has joined #bitcoin-core-dev
5612019-10-30T21:35:14 *** davterra has joined #bitcoin-core-dev
5622019-10-30T21:44:56 *** mdunnio_ has quit IRC
5632019-10-30T21:47:47 *** captjakk has joined #bitcoin-core-dev
5642019-10-30T21:48:01 *** Tabmow has joined #bitcoin-core-dev
5652019-10-30T21:48:19 *** mdunnio has joined #bitcoin-core-dev
5662019-10-30T21:48:25 *** Tabmow is now known as Guest18567
5672019-10-30T21:51:03 *** captjakk_ has quit IRC
5682019-10-30T21:52:18 *** captjakk has quit IRC
5692019-10-30T21:53:38 *** mmgen has quit IRC
5702019-10-30T22:03:24 *** kristapsk has quit IRC
5712019-10-30T22:03:53 *** kristapsk has joined #bitcoin-core-dev
5722019-10-30T22:07:39 *** captjakk has joined #bitcoin-core-dev
5732019-10-30T22:15:45 *** captjakk has quit IRC
5742019-10-30T22:21:13 *** kristapsk has quit IRC
5752019-10-30T22:25:08 *** jarthur_ has joined #bitcoin-core-dev
5762019-10-30T22:28:03 <moneyball> wumpus: i just tried installing .18.1 and it installed without an issue. so only the new signed binaries are affected. (also i don't see the google advanced protection warning with .18.1 like i do with .19.* RCs)
5772019-10-30T22:28:17 *** jarthur has quit IRC
5782019-10-30T22:30:05 *** jarthur_ has quit IRC
5792019-10-30T22:32:50 *** kristapsk has joined #bitcoin-core-dev
5802019-10-30T22:35:47 *** mdunnio has quit IRC
5812019-10-30T22:41:40 *** alko has quit IRC
5822019-10-30T22:42:00 *** alko has joined #bitcoin-core-dev
5832019-10-30T22:46:07 *** aqquadro has quit IRC
5842019-10-30T22:48:08 *** Victorsueca has joined #bitcoin-core-dev
5852019-10-30T22:48:16 *** jb55 has quit IRC
5862019-10-30T22:48:49 *** jb55 has joined #bitcoin-core-dev
5872019-10-30T22:56:57 *** Guyver2 has quit IRC
5882019-10-30T23:06:47 *** arik_ has quit IRC
5892019-10-30T23:07:39 *** jtimon has quit IRC
5902019-10-30T23:08:01 *** rh0nj has quit IRC
5912019-10-30T23:08:23 *** diogosergio has quit IRC
5922019-10-30T23:09:08 *** rh0nj has joined #bitcoin-core-dev
5932019-10-30T23:09:28 *** diogosergio has joined #bitcoin-core-dev
5942019-10-30T23:48:13 *** diogosergio has quit IRC
5952019-10-30T23:48:39 *** marcoagner has quit IRC