1 2019-10-30T00:00:01  *** kees1 has quit IRC
  2 2019-10-30T00:06:02  *** freedomcode has quit IRC
  3 2019-10-30T00:06:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  4 2019-10-30T00:16:42  *** Victor_sueca is now known as Victorsueca
  5 2019-10-30T00:17:42  *** milky1 has joined #bitcoin-core-dev
  6 2019-10-30T00:18:32  *** reardencode has joined #bitcoin-core-dev
  7 2019-10-30T00:33:20  *** Chris_Stewart_5 has quit IRC
  8 2019-10-30T00:43:46  *** pinheadmz has quit IRC
  9 2019-10-30T00:47:26  *** AaronvanW has quit IRC
 10 2019-10-30T00:49:39  *** justanotheruser has quit IRC
 11 2019-10-30T00:50:16  *** justanotheruser has joined #bitcoin-core-dev
 12 2019-10-30T01:37:17  *** pinheadmz has joined #bitcoin-core-dev
 13 2019-10-30T01:49:40  *** lightlike has quit IRC
 14 2019-10-30T02:10:14  *** captjakk has joined #bitcoin-core-dev
 15 2019-10-30T02:11:33  *** captjakk_ has joined #bitcoin-core-dev
 16 2019-10-30T02:14:53  *** captjakk has quit IRC
 17 2019-10-30T02:21:35  *** Highway61 has quit IRC
 18 2019-10-30T02:28:21  *** nosss2 has joined #bitcoin-core-dev
 19 2019-10-30T02:30:27  *** ddustin has quit IRC
 20 2019-10-30T02:31:03  *** ddustin has joined #bitcoin-core-dev
 21 2019-10-30T02:35:17  *** ddustin has quit IRC
 22 2019-10-30T02:39:28  *** nosss2 has quit IRC
 23 2019-10-30T02:39:57  *** nosss2 has joined #bitcoin-core-dev
 24 2019-10-30T02:45:08  *** nosss2 has quit IRC
 25 2019-10-30T02:55:50  *** Randolf has joined #bitcoin-core-dev
 26 2019-10-30T03:00:01  *** milky1 has quit IRC
 27 2019-10-30T03:00:01  *** alko89 has quit IRC
 28 2019-10-30T03:00:08  *** alko has joined #bitcoin-core-dev
 29 2019-10-30T03:05:47  *** emilengler_ has joined #bitcoin-core-dev
 30 2019-10-30T03:08:02  *** emilengler has quit IRC
 31 2019-10-30T03:16:48  *** veehexx has joined #bitcoin-core-dev
 32 2019-10-30T03:19:29  *** captjakk_ has quit IRC
 33 2019-10-30T03:19:43  *** captjakk has joined #bitcoin-core-dev
 34 2019-10-30T03:20:31  *** captjakk has joined #bitcoin-core-dev
 35 2019-10-30T03:20:36  *** felixfoertsch23 has joined #bitcoin-core-dev
 36 2019-10-30T03:21:01  *** captjakk has quit IRC
 37 2019-10-30T03:21:15  *** captjakk has joined #bitcoin-core-dev
 38 2019-10-30T03:21:19  *** felixfoertsch has quit IRC
 39 2019-10-30T03:21:48  *** captjakk has quit IRC
 40 2019-10-30T03:22:06  *** captjakk has joined #bitcoin-core-dev
 41 2019-10-30T03:22:51  *** captjakk has joined #bitcoin-core-dev
 42 2019-10-30T04:02:31  *** Randolf has quit IRC
 43 2019-10-30T04:18:26  *** Eagle[TM] has joined #bitcoin-core-dev
 44 2019-10-30T04:19:57  *** EagleTM has quit IRC
 45 2019-10-30T04:19:57  *** soju has joined #bitcoin-core-dev
 46 2019-10-30T05:20:22  *** bitcoin-git has joined #bitcoin-core-dev
 47 2019-10-30T05:20:22  <bitcoin-git> [bitcoin] dodisefti23 opened pull request #17310: Create moneyChangeC++ (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17310
 48 2019-10-30T05:20:23  *** bitcoin-git has left #bitcoin-core-dev
 49 2019-10-30T05:24:40  *** tsujp_ has joined #bitcoin-core-dev
 50 2019-10-30T05:27:11  *** tsujp has quit IRC
 51 2019-10-30T05:31:02  *** hodlen has joined #bitcoin-core-dev
 52 2019-10-30T05:31:45  *** brianhoffman_ has joined #bitcoin-core-dev
 53 2019-10-30T05:34:53  *** brianhoffman has quit IRC
 54 2019-10-30T05:34:54  *** brianhoffman_ is now known as brianhoffman
 55 2019-10-30T05:35:29  *** hodlen has quit IRC
 56 2019-10-30T05:36:59  *** hodlen has joined #bitcoin-core-dev
 57 2019-10-30T05:42:05  *** jarthur has joined #bitcoin-core-dev
 58 2019-10-30T05:45:05  *** EagleTM has joined #bitcoin-core-dev
 59 2019-10-30T05:46:36  *** hodlen has quit IRC
 60 2019-10-30T05:47:14  *** Eagle[TM] has quit IRC
 61 2019-10-30T05:51:47  *** hodlen_caufield has joined #bitcoin-core-dev
 62 2019-10-30T05:59:49  *** Highway61 has joined #bitcoin-core-dev
 63 2019-10-30T06:00:02  *** veehexx has quit IRC
 64 2019-10-30T06:08:19  *** hodlen_caufield has quit IRC
 65 2019-10-30T06:17:37  *** ddustin has joined #bitcoin-core-dev
 66 2019-10-30T06:18:41  *** bitcoin-git has joined #bitcoin-core-dev
 67 2019-10-30T06:18:42  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #17310: Create moneyChangeC++ (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17310
 68 2019-10-30T06:18:42  *** bitcoin-git has left #bitcoin-core-dev
 69 2019-10-30T06:21:41  *** bitcoin-git has joined #bitcoin-core-dev
 70 2019-10-30T06:21:42  <bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17273: build: proper fix for the kerning issue in macOS build fixes  #16836 (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17273
 71 2019-10-30T06:21:43  *** bitcoin-git has left #bitcoin-core-dev
 72 2019-10-30T06:25:18  *** kabaum has quit IRC
 73 2019-10-30T06:32:25  *** arik_ has joined #bitcoin-core-dev
 74 2019-10-30T06:34:02  *** Victorsueca has quit IRC
 75 2019-10-30T06:47:40  *** jarthur has quit IRC
 76 2019-10-30T06:48:10  *** Guest58618 has joined #bitcoin-core-dev
 77 2019-10-30T07:01:29  *** arik_ has quit IRC
 78 2019-10-30T07:02:05  *** arik_ has joined #bitcoin-core-dev
 79 2019-10-30T07:10:09  *** timothy has joined #bitcoin-core-dev
 80 2019-10-30T07:17:29  *** EagleTM has quit IRC
 81 2019-10-30T07:25:38  *** bitcoin-git has joined #bitcoin-core-dev
 82 2019-10-30T07:25:38  <bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17311: build: macOS fix background.svg (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17311
 83 2019-10-30T07:25:41  *** captjakk has joined #bitcoin-core-dev
 84 2019-10-30T07:25:51  *** bitcoin-git has left #bitcoin-core-dev
 85 2019-10-30T07:25:54  *** jungly has joined #bitcoin-core-dev
 86 2019-10-30T07:37:00  *** kabaum has joined #bitcoin-core-dev
 87 2019-10-30T07:53:08  *** IGHOR has quit IRC
 88 2019-10-30T07:54:50  *** arik_ has quit IRC
 89 2019-10-30T07:56:03  *** IGHOR has joined #bitcoin-core-dev
 90 2019-10-30T07:59:11  *** kabaum has quit IRC
 91 2019-10-30T08:09:58  *** AaronvanW has joined #bitcoin-core-dev
 92 2019-10-30T08:12:03  *** kabaum has joined #bitcoin-core-dev
 93 2019-10-30T08:20:02  *** luke-jr has quit IRC
 94 2019-10-30T08:20:10  *** marcoagner has joined #bitcoin-core-dev
 95 2019-10-30T08:22:03  *** jonatack has quit IRC
 96 2019-10-30T08:22:20  *** luke-jr has joined #bitcoin-core-dev
 97 2019-10-30T08:36:10  *** ddustin has quit IRC
 98 2019-10-30T08:36:37  *** kabaum has quit IRC
 99 2019-10-30T08:46:42  *** Bullit has quit IRC
100 2019-10-30T08:47:08  *** Bullit has joined #bitcoin-core-dev
101 2019-10-30T09:00:01  *** Guest58618 has quit IRC
102 2019-10-30T09:08:32  *** jonatack has joined #bitcoin-core-dev
103 2019-10-30T09:10:21  *** Guyver2 has joined #bitcoin-core-dev
104 2019-10-30T09:18:19  *** jbarnette has joined #bitcoin-core-dev
105 2019-10-30T09:19:06  *** bitcoin-git has joined #bitcoin-core-dev
106 2019-10-30T09:19:06  <bitcoin-git> [bitcoin] laanwj opened pull request #17312: Improve tracethread usability and trace loadblk thread (master...2019_10_tracedthread) https://github.com/bitcoin/bitcoin/pull/17312
107 2019-10-30T09:19:07  *** bitcoin-git has left #bitcoin-core-dev
108 2019-10-30T09:21:42  *** kabaum has joined #bitcoin-core-dev
109 2019-10-30T09:23:32  *** jonatack has quit IRC
110 2019-10-30T09:24:15  *** jonatack has joined #bitcoin-core-dev
111 2019-10-30T09:30:05  *** jonatack_ has joined #bitcoin-core-dev
112 2019-10-30T09:30:44  *** jonatack has quit IRC
113 2019-10-30T09:33:50  *** jonatack_ has quit IRC
114 2019-10-30T09:34:07  *** jonatack has joined #bitcoin-core-dev
115 2019-10-30T09:38:22  *** jonatack has quit IRC
116 2019-10-30T09:39:47  <wumpus> argh, how do I pass a const std::string to util::ThreadRename(std::string&& name)? https://github.com/bitcoin/bitcoin/pull/17312#pullrequestreview-309065741
117 2019-10-30T09:40:26  <wumpus> in rust you'd add something like .clone()
118 2019-10-30T09:43:26  *** bitcoin-git has joined #bitcoin-core-dev
119 2019-10-30T09:43:27  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ecad0a8019fb...5728f88d645c
120 2019-10-30T09:43:27  <bitcoin-git> bitcoin/master f3b51eb Wladimir J. van der Laan: Fix occurences of c_str() used with size() to data()
121 2019-10-30T09:43:28  <bitcoin-git> bitcoin/master 5728f88 Wladimir J. van der Laan: Merge #17280: refactor: Change occurences of c_str() used with size() to d...
122 2019-10-30T09:43:29  *** bitcoin-git has left #bitcoin-core-dev
123 2019-10-30T09:43:46  *** bitcoin-git has joined #bitcoin-core-dev
124 2019-10-30T09:43:47  <bitcoin-git> [bitcoin] laanwj merged pull request #17280: refactor: Change occurences of c_str() used with size() to data() (master...2019_10_c_str_size) https://github.com/bitcoin/bitcoin/pull/17280
125 2019-10-30T09:43:48  *** bitcoin-git has left #bitcoin-core-dev
126 2019-10-30T09:44:35  <elichai2> wumpus: you could "clone" it like `std::string str2(str1);` (pretty sure that will clone the data)
127 2019-10-30T09:44:50  <wumpus> there must be a 'proper' way right?
128 2019-10-30T09:45:04  <wumpus> hm maybe just wrapping in std::string(...) would do it
129 2019-10-30T09:45:32  <elichai2> if you ever find a guide for "idiomatic" C++ please tell me :)
130 2019-10-30T09:46:26  <wumpus> point taken
131 2019-10-30T09:47:14  <wumpus> I don't understand why ThreadRename would take a move argument anyhow, it seems a pointless case of over-optimization
132 2019-10-30T09:47:21  <wumpus> but not going to address that here
133 2019-10-30T09:53:13  <elichai2> i like that the rust `.clone()` makes it really easy to see all the allocations going on, while in C++ it's way more subtle
134 2019-10-30T09:54:04  *** siom_ has joined #bitcoin-core-dev
135 2019-10-30T09:54:34  <wumpus> yes, in general rust seems to be better thought out
136 2019-10-30T09:57:14  *** tsujp_ has quit IRC
137 2019-10-30T09:59:18  *** Highway61 has quit IRC
138 2019-10-30T09:59:45  *** Highway61 has joined #bitcoin-core-dev
139 2019-10-30T10:02:38  *** tsujp has joined #bitcoin-core-dev
140 2019-10-30T10:05:14  *** cryptoIndio has quit IRC
141 2019-10-30T10:14:56  *** kabaum has quit IRC
142 2019-10-30T10:15:30  *** Highway61 has quit IRC
143 2019-10-30T10:15:58  *** Highway61 has joined #bitcoin-core-dev
144 2019-10-30T10:24:38  <wumpus> I guess its whole point is to make it harder to make subtle mistakes and avoid all C++'s footguns
145 2019-10-30T10:26:07  *** rh0nj has joined #bitcoin-core-dev
146 2019-10-30T10:27:25  *** kabaum has joined #bitcoin-core-dev
147 2019-10-30T10:30:02  *** Highway61 has quit IRC
148 2019-10-30T10:30:45  *** spinza has quit IRC
149 2019-10-30T10:35:43  *** cryptoIndio has joined #bitcoin-core-dev
150 2019-10-30T10:40:45  *** cryptoIndio has quit IRC
151 2019-10-30T10:42:15  *** DavidMitchell[m] has quit IRC
152 2019-10-30T10:42:16  *** TheFuzzStone[m] has quit IRC
153 2019-10-30T10:42:20  *** awesome-doge has quit IRC
154 2019-10-30T10:42:23  *** kewde[m] has quit IRC
155 2019-10-30T10:42:40  *** electric-sheep[m has quit IRC
156 2019-10-30T10:44:27  *** BlueMatt has quit IRC
157 2019-10-30T10:45:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
158 2019-10-30T10:46:58  *** BlueMatt has joined #bitcoin-core-dev
159 2019-10-30T10:53:55  *** bitcoin-git has joined #bitcoin-core-dev
160 2019-10-30T10:53:56  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5728f88d645c...6daddc449555
161 2019-10-30T10:53:56  <bitcoin-git> bitcoin/master dd94cc4 fanquake: contrib: remove accounts from bash completion
162 2019-10-30T10:53:57  <bitcoin-git> bitcoin/master 6daddc4 Wladimir J. van der Laan: Merge #17282: contrib: remove accounts from bash completion
163 2019-10-30T10:54:05  *** bitcoin-git has left #bitcoin-core-dev
164 2019-10-30T10:54:20  *** bitcoin-git has joined #bitcoin-core-dev
165 2019-10-30T10:54:20  <bitcoin-git> [bitcoin] laanwj merged pull request #17282: contrib: remove accounts from bash completion (master...update_bash_completion) https://github.com/bitcoin/bitcoin/pull/17282
166 2019-10-30T10:54:31  *** bitcoin-git has left #bitcoin-core-dev
167 2019-10-30T11:00:21  *** AaronvanW has quit IRC
168 2019-10-30T11:03:12  *** electric-sheep[m has joined #bitcoin-core-dev
169 2019-10-30T11:09:48  *** cryptoIndio has joined #bitcoin-core-dev
170 2019-10-30T11:10:24  *** DavidMitchell[m] has joined #bitcoin-core-dev
171 2019-10-30T11:10:25  *** kewde[m] has joined #bitcoin-core-dev
172 2019-10-30T11:10:25  *** awesome-doge has joined #bitcoin-core-dev
173 2019-10-30T11:10:25  *** TheFuzzStone[m] has joined #bitcoin-core-dev
174 2019-10-30T11:15:57  *** kabaum has quit IRC
175 2019-10-30T11:23:51  *** bitcoin-git has joined #bitcoin-core-dev
176 2019-10-30T11:23:51  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6daddc449555...f129170b8592
177 2019-10-30T11:23:52  <bitcoin-git> bitcoin/master 37b8475 Jorge Timón: Chainparams: Use name constants in chainparams initialization
178 2019-10-30T11:23:52  <bitcoin-git> bitcoin/master f129170 Wladimir J. van der Laan: Merge #17306: refactor: Use name constants in chainparams initialization
179 2019-10-30T11:23:54  *** bitcoin-git has left #bitcoin-core-dev
180 2019-10-30T11:24:11  *** bitcoin-git has joined #bitcoin-core-dev
181 2019-10-30T11:24:11  <bitcoin-git> [bitcoin] laanwj merged pull request #17306: refactor: Use name constants in chainparams initialization (master...b20-chain-constants) https://github.com/bitcoin/bitcoin/pull/17306
182 2019-10-30T11:24:12  *** bitcoin-git has left #bitcoin-core-dev
183 2019-10-30T11:34:42  *** aqquadro has joined #bitcoin-core-dev
184 2019-10-30T11:36:12  *** bitcoin-git has joined #bitcoin-core-dev
185 2019-10-30T11:36:13  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/f129170b8592...471e5f882907
186 2019-10-30T11:36:14  <bitcoin-git> bitcoin/master 301bd41 Russell Yanofsky: scripted-diff: Rename InitInterfaces to NodeContext
187 2019-10-30T11:36:15  <bitcoin-git> bitcoin/master 4d5448c Russell Yanofsky: MOVEONLY: Move NodeContext struct to node/context.h
188 2019-10-30T11:36:15  <bitcoin-git> bitcoin/master e6f4f89 Russell Yanofsky: Pass NodeContext, ConnMan, BanMan references more places
189 2019-10-30T11:36:17  *** bitcoin-git has left #bitcoin-core-dev
190 2019-10-30T11:36:32  *** bitcoin-git has joined #bitcoin-core-dev
191 2019-10-30T11:36:32  <bitcoin-git> [bitcoin] laanwj merged pull request #16839: Replace Connman and BanMan globals with NodeContext local (master...pr/noglob) https://github.com/bitcoin/bitcoin/pull/16839
192 2019-10-30T11:36:33  *** bitcoin-git has left #bitcoin-core-dev
193 2019-10-30T11:38:54  *** bitcoin-git has joined #bitcoin-core-dev
194 2019-10-30T11:38:55  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/471e5f882907...edd9d0781b96
195 2019-10-30T11:38:55  <bitcoin-git> bitcoin/master 3187934 Wladimir J. van der Laan: cli: Add "headers" and "verificationprogress" to -getinfo
196 2019-10-30T11:38:56  <bitcoin-git> bitcoin/master edd9d07 Wladimir J. van der Laan: Merge #17302: cli: Add "headers" and "verificationprogress" to -getinfo
197 2019-10-30T11:38:58  *** bitcoin-git has left #bitcoin-core-dev
198 2019-10-30T11:39:15  *** bitcoin-git has joined #bitcoin-core-dev
199 2019-10-30T11:39:15  <bitcoin-git> [bitcoin] laanwj merged pull request #17302: cli: Add "headers" and "verificationprogress" to -getinfo (master...2019_10_getinfo) https://github.com/bitcoin/bitcoin/pull/17302
200 2019-10-30T11:39:17  *** bitcoin-git has left #bitcoin-core-dev
201 2019-10-30T11:44:40  *** davterra has joined #bitcoin-core-dev
202 2019-10-30T11:53:18  *** setpill has joined #bitcoin-core-dev
203 2019-10-30T11:53:37  *** nijynot has joined #bitcoin-core-dev
204 2019-10-30T11:59:39  *** Chris_Stewart_5 has quit IRC
205 2019-10-30T12:00:02  *** jbarnette has quit IRC
206 2019-10-30T12:03:53  *** ExtraCrispy has joined #bitcoin-core-dev
207 2019-10-30T12:07:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
208 2019-10-30T12:09:09  *** Victorsueca has joined #bitcoin-core-dev
209 2019-10-30T12:12:05  <setpill> wumpus: re #16994 there is no status label that can be applied to "blocked" or "waiting" PRs? not sure how differentiation between "abandoned" and "will be picked up later again after external issues are resolved" is made if both are closed without label.
210 2019-10-30T12:12:07  <gribble> https://github.com/bitcoin/bitcoin/issues/16994 | contrib: replace deprecated PermissionsStartOnly in systemd init by setpill · Pull Request #16994 · bitcoin/bitcoin · GitHub
211 2019-10-30T12:13:16  <wumpus> no, there's no label for that; I'm asking you to close the PR instead of doing it myself, because then you can open it again when you deem the time is there
212 2019-10-30T12:13:29  <setpill> ack
213 2019-10-30T12:13:54  *** bitcoin-git has joined #bitcoin-core-dev
214 2019-10-30T12:13:55  <bitcoin-git> [bitcoin] setpill closed pull request #16994: contrib: replace deprecated PermissionsStartOnly in systemd init (master...fix-deprecated-permissionsstartonly) https://github.com/bitcoin/bitcoin/pull/16994
215 2019-10-30T12:13:55  *** bitcoin-git has left #bitcoin-core-dev
216 2019-10-30T12:14:02  <wumpus> I guess I can add milestone 'future'
217 2019-10-30T12:15:18  <wumpus> it's the closest thing, it basically means that it should be revisited at some unspecified time in the future
218 2019-10-30T12:15:43  *** aqquadro has quit IRC
219 2019-10-30T12:16:14  <setpill> personally prefer terminology like "blocked" to indicate this kind of situation. "future" has prioritization connotations that don't really apply to a project like this where people are welcomed to just pop in and out to contribute whatever they feel like contributing :)
220 2019-10-30T12:17:49  <wumpus> but 'blocked' has 'we should first do some other work' connotations (e.g. "blockers" in high priority for review), usually things are blocked on other things that need to be done
221 2019-10-30T12:17:50  *** othe1 has joined #bitcoin-core-dev
222 2019-10-30T12:18:12  <setpill> ah, fair point
223 2019-10-30T12:19:54  <setpill> either is probably fine, before you know it you have 10 different labels for all the subtle variations of this kind of situation
224 2019-10-30T12:20:15  <setpill> anyway, closed for now, let's hope i remember to revisit it (:
225 2019-10-30T12:22:18  <wumpus> yes, though I'm sure someone will pick it up as soon as systemd starts rejecting the setting :)
226 2019-10-30T12:26:29  *** kabaum has joined #bitcoin-core-dev
227 2019-10-30T12:30:30  *** sosthene has quit IRC
228 2019-10-30T12:40:50  *** jtimon has joined #bitcoin-core-dev
229 2019-10-30T12:45:49  <jtimon> I've been rebasing a commit similar to https://github.com/bitcoin/bitcoin/pull/16681 for years (which is a bit annoying as new instances appeared) and people are still complaining because it is not complete and more instances may appear.
230 2019-10-30T12:45:49  <jtimon> On the other hand I created https://github.com/bitcoin/bitcoin/pull/17306 and it was merged in 16 hours, being incomplete and with a nit on it.
231 2019-10-30T12:45:49  <jtimon> Sometimes I really don't understand the criteria, guys. Not a big deal, but it doesn't seem consistent.
232 2019-10-30T12:46:44  *** Highway61 has joined #bitcoin-core-dev
233 2019-10-30T12:46:56  <wumpus> I'm sorry for the whitespace nit but I disagree it is  'incomplete', it's a small change that makes sense
234 2019-10-30T12:47:50  <wumpus> as I've commented in the PR I think it's a bad idea if you have conceptual and code review on a PR, and two ACKs, to extend the scope, feel free to do the rest in a new PR
235 2019-10-30T12:49:32  <wumpus> if you did replace all the other occcurences it could have easily have been drawn out to a PR that takes months, because there would be a discussion about what to change and whatnot
236 2019-10-30T12:49:37  <wumpus> in this case there was general agreement
237 2019-10-30T12:50:23  *** aqquadro has joined #bitcoin-core-dev
238 2019-10-30T12:50:26  <wumpus> maybe you could learn from it and do more small, targeted PRs :)
239 2019-10-30T12:53:20  *** Chris_Stewart_5 has quit IRC
240 2019-10-30T12:58:38  *** IGHOR has quit IRC
241 2019-10-30T13:02:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
242 2019-10-30T13:02:34  *** IGHOR has joined #bitcoin-core-dev
243 2019-10-30T13:07:00  *** Guyver2 has quit IRC
244 2019-10-30T13:07:37  *** IGHOR has quit IRC
245 2019-10-30T13:10:07  *** IGHOR has joined #bitcoin-core-dev
246 2019-10-30T13:10:19  *** brianhoffman_ has joined #bitcoin-core-dev
247 2019-10-30T13:10:42  *** brianhoffman has quit IRC
248 2019-10-30T13:10:42  *** brianhoffman_ is now known as brianhoffman
249 2019-10-30T13:17:36  *** emilengler_ has quit IRC
250 2019-10-30T13:19:04  *** emilengler has joined #bitcoin-core-dev
251 2019-10-30T13:29:34  *** bitcoin-git has joined #bitcoin-core-dev
252 2019-10-30T13:29:35  <bitcoin-git> [bitcoin] laanwj opened pull request #17316: refactor: Replace all uses of boost::optional with our own Optional type (master...2019_10_optional) https://github.com/bitcoin/bitcoin/pull/17316
253 2019-10-30T13:29:37  *** bitcoin-git has left #bitcoin-core-dev
254 2019-10-30T13:36:59  *** IGHOR has quit IRC
255 2019-10-30T13:37:07  *** kabaum has quit IRC
256 2019-10-30T13:39:32  *** IGHOR has joined #bitcoin-core-dev
257 2019-10-30T13:44:40  *** IGHOR has quit IRC
258 2019-10-30T13:47:22  *** IGHOR has joined #bitcoin-core-dev
259 2019-10-30T13:48:44  *** IGHOR has quit IRC
260 2019-10-30T13:49:57  *** Chris_Stewart_5 has quit IRC
261 2019-10-30T13:54:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
262 2019-10-30T13:55:10  *** greypw has quit IRC
263 2019-10-30T13:55:41  *** greypw has joined #bitcoin-core-dev
264 2019-10-30T13:55:51  *** nijynot has quit IRC
265 2019-10-30T13:57:20  *** nijynot has joined #bitcoin-core-dev
266 2019-10-30T13:58:32  *** rex4539 has quit IRC
267 2019-10-30T14:00:23  *** mmgen has joined #bitcoin-core-dev
268 2019-10-30T14:05:41  *** nijynot has quit IRC
269 2019-10-30T14:06:54  *** bitcoin-git has joined #bitcoin-core-dev
270 2019-10-30T14:06:54  <bitcoin-git> [bitcoin] adamjonas opened pull request #17318: replace asserts in RPC code with CHECK_NONFATAL and add linter (master...replace-rpc-asserts-for-CHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17318
271 2019-10-30T14:07:05  *** bitcoin-git has left #bitcoin-core-dev
272 2019-10-30T14:12:56  *** nosss2 has joined #bitcoin-core-dev
273 2019-10-30T14:15:23  *** jb55 has quit IRC
274 2019-10-30T14:15:59  *** jb55 has joined #bitcoin-core-dev
275 2019-10-30T14:21:39  *** bitcoin-git has joined #bitcoin-core-dev
276 2019-10-30T14:21:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/edd9d0781b96...341e8d355d1a
277 2019-10-30T14:21:40  <bitcoin-git> bitcoin/master d5dbb48 practicalswift: tests: Add fuzzing harness for ISO-8601 related functions
278 2019-10-30T14:21:41  <bitcoin-git> bitcoin/master 595cc9b practicalswift: docs: Add undefined to --with-sanitizers=fuzzer,address
279 2019-10-30T14:21:41  <bitcoin-git> bitcoin/master 341e8d3 MarcoFalke: Merge #17291: tests: Add fuzzing harness for ISO-8601 related functions
280 2019-10-30T14:21:43  *** bitcoin-git has left #bitcoin-core-dev
281 2019-10-30T14:21:59  *** bitcoin-git has joined #bitcoin-core-dev
282 2019-10-30T14:21:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17291: tests: Add fuzzing harness for ISO-8601 related functions (master...fuzzers-parse_iso8601) https://github.com/bitcoin/bitcoin/pull/17291
283 2019-10-30T14:22:09  *** bitcoin-git has left #bitcoin-core-dev
284 2019-10-30T14:23:23  *** bitcoin-git has joined #bitcoin-core-dev
285 2019-10-30T14:23:23  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/341e8d355d1a...cab94cc07489
286 2019-10-30T14:23:24  <bitcoin-git> bitcoin/master fa144e6 MarcoFalke: rpc: Add generatetodescriptor
287 2019-10-30T14:23:24  <bitcoin-git> bitcoin/master cab94cc Wladimir J. van der Laan: Merge #16943: test: Add generatetodescriptor RPC
288 2019-10-30T14:23:26  *** bitcoin-git has left #bitcoin-core-dev
289 2019-10-30T14:23:43  *** bitcoin-git has joined #bitcoin-core-dev
290 2019-10-30T14:23:43  <bitcoin-git> [bitcoin] laanwj merged pull request #16943: test: Add generatetodescriptor RPC (master...1909-rpcMiningDescriptor) https://github.com/bitcoin/bitcoin/pull/16943
291 2019-10-30T14:23:44  *** bitcoin-git has left #bitcoin-core-dev
292 2019-10-30T14:36:41  *** mdunnio has joined #bitcoin-core-dev
293 2019-10-30T14:38:12  *** bitcoin-git has joined #bitcoin-core-dev
294 2019-10-30T14:38:14  <bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/cab94cc07489...3c40bc6726b6
295 2019-10-30T14:38:14  <bitcoin-git> bitcoin/master a27a295 John Newbery: [validation] Add CValidationState subclasses
296 2019-10-30T14:38:15  <bitcoin-git> bitcoin/master 067981e John Newbery: [validation] Tidy Up ValidationResult class
297 2019-10-30T14:38:16  <bitcoin-git> bitcoin/master 1a37de4 John Newbery: [validation] Remove error() calls from Invalid() calls
298 2019-10-30T14:38:18  *** bitcoin-git has left #bitcoin-core-dev
299 2019-10-30T14:38:52  *** bitcoin-git has joined #bitcoin-core-dev
300 2019-10-30T14:38:52  <bitcoin-git> [bitcoin] laanwj merged pull request #15921: validation: Tidy up ValidationState interface (master...2019-04-pr15141-cleanups) https://github.com/bitcoin/bitcoin/pull/15921
301 2019-10-30T14:38:53  *** bitcoin-git has left #bitcoin-core-dev
302 2019-10-30T14:42:44  *** rex4539 has joined #bitcoin-core-dev
303 2019-10-30T14:44:37  *** lightlike has joined #bitcoin-core-dev
304 2019-10-30T14:47:38  *** mdunnio has quit IRC
305 2019-10-30T14:48:59  *** mdunnio has joined #bitcoin-core-dev
306 2019-10-30T14:50:42  *** diogosergio has joined #bitcoin-core-dev
307 2019-10-30T14:57:54  *** diogosergio has quit IRC
308 2019-10-30T14:58:19  *** bitcoin-git has joined #bitcoin-core-dev
309 2019-10-30T14:58:20  <bitcoin-git> [bitcoin] jnewbery opened pull request #17319: Tests: remove bignum module (master...2019-10-bignum) https://github.com/bitcoin/bitcoin/pull/17319
310 2019-10-30T14:58:20  *** bitcoin-git has left #bitcoin-core-dev
311 2019-10-30T14:59:03  *** diogosergio has joined #bitcoin-core-dev
312 2019-10-30T15:00:01  *** othe1 has quit IRC
313 2019-10-30T15:08:48  *** IGHOR has joined #bitcoin-core-dev
314 2019-10-30T15:13:29  *** ddustin has joined #bitcoin-core-dev
315 2019-10-30T15:17:36  *** rex4539 has quit IRC
316 2019-10-30T15:20:30  *** Guyver2 has joined #bitcoin-core-dev
317 2019-10-30T15:27:04  *** diogosergio has quit IRC
318 2019-10-30T15:28:50  *** captjakk has quit IRC
319 2019-10-30T15:30:02  *** diogosergio has joined #bitcoin-core-dev
320 2019-10-30T15:32:19  *** rex4539 has joined #bitcoin-core-dev
321 2019-10-30T15:34:54  *** diogosergio has quit IRC
322 2019-10-30T15:34:59  *** diogoser1io has joined #bitcoin-core-dev
323 2019-10-30T15:35:00  *** otium has joined #bitcoin-core-dev
324 2019-10-30T15:39:31  *** jarthur has joined #bitcoin-core-dev
325 2019-10-30T15:41:03  *** davterra has quit IRC
326 2019-10-30T15:43:01  *** jarthur has quit IRC
327 2019-10-30T15:43:14  *** jarthur has joined #bitcoin-core-dev
328 2019-10-30T15:43:22  *** davterra has joined #bitcoin-core-dev
329 2019-10-30T15:47:21  <wumpus> rc3 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.19.0/test.rc3/
330 2019-10-30T15:48:59  <fanquake> 🚀
331 2019-10-30T15:50:26  *** mdunnio has quit IRC
332 2019-10-30T15:52:20  *** mdunnio has joined #bitcoin-core-dev
333 2019-10-30T15:55:24  *** rex4539 has quit IRC
334 2019-10-30T15:57:30  *** mdunnio_ has joined #bitcoin-core-dev
335 2019-10-30T16:00:24  *** mdunnio_ has joined #bitcoin-core-dev
336 2019-10-30T16:01:15  *** mdunnio has quit IRC
337 2019-10-30T16:05:38  *** owowo has quit IRC
338 2019-10-30T16:10:35  *** owowo has joined #bitcoin-core-dev
339 2019-10-30T16:11:08  *** bitcoin-git has joined #bitcoin-core-dev
340 2019-10-30T16:11:08  <bitcoin-git> [bitcoin] practicalswift opened pull request #17320: Make compiler warn about tautological comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
341 2019-10-30T16:11:09  *** bitcoin-git has left #bitcoin-core-dev
342 2019-10-30T16:15:11  *** b_b1 has joined #bitcoin-core-dev
343 2019-10-30T16:16:19  *** JeremyCrookshank has joined #bitcoin-core-dev
344 2019-10-30T16:16:32  <JeremyCrookshank> Hello :)
345 2019-10-30T16:16:48  <wumpus> hello !
346 2019-10-30T16:17:25  *** AaronvanW has joined #bitcoin-core-dev
347 2019-10-30T16:19:07  *** bitcoin-git has joined #bitcoin-core-dev
348 2019-10-30T16:19:08  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3c40bc6726b6...a6abc94e9307
349 2019-10-30T16:19:08  <bitcoin-git> bitcoin/master 1cf9b35 Wladimir J. van der Laan: doc: Add developer note on c_str()
350 2019-10-30T16:19:09  <bitcoin-git> bitcoin/master a6abc94 Wladimir J. van der Laan: Merge #17281: doc: Add developer note on c_str()
351 2019-10-30T16:19:11  *** bitcoin-git has left #bitcoin-core-dev
352 2019-10-30T16:19:17  <JeremyCrookshank> What is the community's consensus on Core GUI? Changing design ect? I saw a few PR's in the past aimed at improving it
353 2019-10-30T16:19:27  *** bitcoin-git has joined #bitcoin-core-dev
354 2019-10-30T16:19:28  <bitcoin-git> [bitcoin] laanwj merged pull request #17281: doc: Add developer note on c_str() (master...2019_10_c_str_note) https://github.com/bitcoin/bitcoin/pull/17281
355 2019-10-30T16:19:28  *** bitcoin-git has left #bitcoin-core-dev
356 2019-10-30T16:19:39  <JeremyCrookshank> or using more advanced QT features?
357 2019-10-30T16:22:54  *** arik_ has joined #bitcoin-core-dev
358 2019-10-30T16:23:19  <luke-jr> JeremyCrookshank: minimum Qt version needs to be something available on stable releases of major distros (typically RHEL or Debian are the bottlenecks)
359 2019-10-30T16:23:43  <luke-jr> and if some people might consider it worse than before, you might have an issue
360 2019-10-30T16:24:04  <luke-jr> but otherwise should be same as any other improvement: slow moving, but eventually get in
361 2019-10-30T16:24:24  *** captjakk has joined #bitcoin-core-dev
362 2019-10-30T16:25:00  <sipa> JeremyCrookshank: hard to discuss without knowing what you're talking about
363 2019-10-30T16:25:02  <wumpus> do you have any specific thing you'd like to work on?
364 2019-10-30T16:25:42  <wumpus> what kind of more advanced qt features? there's a PR that adds qr code recognition (and would need qtmultimedia), as well as one adding a qml-based GUI for android
365 2019-10-30T16:25:55  <wumpus> nothing is ruled out if you have a good reason'
366 2019-10-30T16:26:01  <JeremyCrookshank> I don't have specifics but noted the general design hasn't really changed(not a bad thing). I would love to work on the GUI but still a c++ noob :p
367 2019-10-30T16:26:19  <luke-jr> I think it's just lack of people focussed on it
368 2019-10-30T16:26:42  <luke-jr> although otoh someone recently tried to revamp icons and ended up with all of them removed entirely :/
369 2019-10-30T16:26:44  *** Highway61 has quit IRC
370 2019-10-30T16:26:46  <JeremyCrookshank> I would love something small to work on on the side on the GUI which would be useful
371 2019-10-30T16:26:46  *** captjakk has quit IRC
372 2019-10-30T16:26:48  <luke-jr> menu icons*
373 2019-10-30T16:26:54  <JeremyCrookshank> Yeah I saw icons went, quite liked them :)
374 2019-10-30T16:27:01  *** nijynot has joined #bitcoin-core-dev
375 2019-10-30T16:27:41  <wumpus> be careful to not fall into the trap of trying to make a 'cool gui', that's not the point of it, akin to industrial UIs the important thing is that it's hard to make mistakes
376 2019-10-30T16:28:28  <wumpus> because payments are inherently irreversible
377 2019-10-30T16:28:47  <luke-jr> wumpus: arguably reversible payments could be done, just nobody cares to :p
378 2019-10-30T16:29:44  <wumpus> it could be done as a layer on top, but yeah, that's not my point here :)
379 2019-10-30T16:29:55  <luke-jr> eg, BIP70-workalike + time locked tx
380 2019-10-30T16:31:49  *** ddustin has quit IRC
381 2019-10-30T16:32:01  <JeremyCrookshank> wumpus I understand
382 2019-10-30T16:33:14  *** nijynot has quit IRC
383 2019-10-30T16:33:37  *** mdunnio_ has quit IRC
384 2019-10-30T16:38:26  *** mdunnio has joined #bitcoin-core-dev
385 2019-10-30T16:39:06  *** bitcoin-git has joined #bitcoin-core-dev
386 2019-10-30T16:39:06  <bitcoin-git> [bitcoin] practicalswift closed pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
387 2019-10-30T16:39:07  *** bitcoin-git has left #bitcoin-core-dev
388 2019-10-30T16:42:09  *** captjakk has joined #bitcoin-core-dev
389 2019-10-30T16:48:37  *** mdunnio has quit IRC
390 2019-10-30T16:51:07  *** rex4539 has joined #bitcoin-core-dev
391 2019-10-30T16:52:12  *** bitcoin-git has joined #bitcoin-core-dev
392 2019-10-30T16:52:13  <bitcoin-git> [bitcoin] practicalswift reopened pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
393 2019-10-30T16:52:14  *** bitcoin-git has left #bitcoin-core-dev
394 2019-10-30T16:55:47  *** ajonas has joined #bitcoin-core-dev
395 2019-10-30T16:56:22  *** timothy has quit IRC
396 2019-10-30T17:01:24  *** diogoser1io has left #bitcoin-core-dev
397 2019-10-30T17:01:47  *** bitcoin-git has joined #bitcoin-core-dev
398 2019-10-30T17:01:48  <bitcoin-git> [bitcoin] instagibbs opened pull request #17322: Fix input size assertion in wallet_bumpfee.py (master...w_bp_assert) https://github.com/bitcoin/bitcoin/pull/17322
399 2019-10-30T17:01:49  *** bitcoin-git has left #bitcoin-core-dev
400 2019-10-30T17:02:09  *** nosss2 has quit IRC
401 2019-10-30T17:03:28  <wumpus> the best way to help with the GUI if you're not writing code is probably to help testing open PRs, such as #16966
402 2019-10-30T17:03:31  <gribble> https://github.com/bitcoin/bitcoin/issues/16966 | ui: make send a wizard by Sjors · Pull Request #16966 · bitcoin/bitcoin · GitHub
403 2019-10-30T17:04:31  *** michaelfolkson has joined #bitcoin-core-dev
404 2019-10-30T17:05:14  *** andytoshi has joined #bitcoin-core-dev
405 2019-10-30T17:05:15  *** andytoshi has joined #bitcoin-core-dev
406 2019-10-30T17:10:07  *** rex4539 has quit IRC
407 2019-10-30T17:11:07  *** rex4539 has joined #bitcoin-core-dev
408 2019-10-30T17:14:08  *** mmgen has quit IRC
409 2019-10-30T17:17:31  *** ddustin has joined #bitcoin-core-dev
410 2019-10-30T17:18:51  *** mdunnio has joined #bitcoin-core-dev
411 2019-10-30T17:19:03  *** ddustin has joined #bitcoin-core-dev
412 2019-10-30T17:20:21  *** mmgen has joined #bitcoin-core-dev
413 2019-10-30T17:20:37  *** mdunnio has quit IRC
414 2019-10-30T17:20:53  *** mdunnio has joined #bitcoin-core-dev
415 2019-10-30T17:21:03  <BlueMatt> dongcarl: lol, stop telling me how to fix build system shit...I dont know what any of your comments mean
416 2019-10-30T17:22:11  *** JeremyCrookshank has quit IRC
417 2019-10-30T17:22:16  <dongcarl> BlueMatt: Lol they were more for cfields and fanquake than for you (since we decided to work on the build system changes on ur PR instead of a separate one)
418 2019-10-30T17:22:18  *** mdunnio has quit IRC
419 2019-10-30T17:24:07  <moneyball> I tried to install RC3 but get this message. Anyone else successfully install on Catalina? https://usercontent.irccloud-cdn.com/file/fXdVFAmw/Screen%20Shot%202019-10-30%20at%2010.15.40%20AM.png
420 2019-10-30T17:24:09  *** arik_ has quit IRC
421 2019-10-30T17:24:32  <BlueMatt> I think that gets fixed during the release process via the signing? cfields?
422 2019-10-30T17:26:08  <jtimon> wumpus: fair enough, makes sense to me
423 2019-10-30T17:27:28  <moneyball> I've been able to install and run RCs in the past. And, how is a person supposed to test RCs if they cannot run them?
424 2019-10-30T17:27:57  <BlueMatt> moneyball: you'll probably have to disable some apple security garbage (maybe by installing xcode?)
425 2019-10-30T17:29:35  <moneyball> BlueMatt: thx will try that. i see i haven't reinstalled xcode after my numerous recent hard drive failures
426 2019-10-30T17:30:01  <BlueMatt> moneyball: I mean google it first. gotta indicate to some apple subsystem that you're a developer, I'm sure...
427 2019-10-30T17:31:58  <moneyball> ok yeah this is a new catalina thing. if you "right click" on the app binary then choose "Open" it will let you run the app
428 2019-10-30T17:33:44  <moneyball> fyi in case this is useful to cfields or dongcarl when building the signed release version https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution
429 2019-10-30T17:34:23  <wumpus> I think #15774 is related
430 2019-10-30T17:34:25  <gribble> https://github.com/bitcoin/bitcoin/issues/15774 | macOS App Notarization · Issue #15774 · bitcoin/bitcoin · GitHub
431 2019-10-30T17:36:42  <moneyball> that issue was punted to the next release. at minimum we should test the signed final release of .19 on MacOS
432 2019-10-30T17:36:56  *** aqquadro has quit IRC
433 2019-10-30T17:38:20  <wumpus> I don't think this is a rc versus final issue, the rcs are signed in the same way as final
434 2019-10-30T17:38:39  <wumpus> you might want to post that screenshot in the issue
435 2019-10-30T17:38:42  <dongcarl> Yeah my subconscious has been blocking this problem... It seems Apple has gone mad with platform power...
436 2019-10-30T17:39:51  <wumpus> one of these days it's just not possible to distribute binaries anymore for open source software
437 2019-10-30T17:41:55  *** provoostenator has quit IRC
438 2019-10-30T17:43:56  *** provoostenator has joined #bitcoin-core-dev
439 2019-10-30T17:45:15  <dongcarl> So, after a cursory glance... It seems like if we don't want to have to tell users to right click > open, we need to use OSX-only tools...
440 2019-10-30T17:45:48  <sipa> ugh.
441 2019-10-30T17:46:12  *** siom_ has quit IRC
442 2019-10-30T17:49:45  <dongcarl> wumpus: I'm not sure if Apple's notarization tools care about reproducibility... So in the worst case it seems we will end up with 2 binary dists for osx: One which is reproducible, but not notarized, and another one which is non-reproducible, but notarized...
443 2019-10-30T17:49:52  <wumpus> awesome, that'd rule out cross-platform deterministic builds for OSX
444 2019-10-30T17:50:18  <wumpus> I'm unwilling to upload non-reproducible builds to bitcoin(core).org
445 2019-10-30T17:50:36  <wumpus> so that's the end of OSX support
446 2019-10-30T17:51:40  <dongcarl> wumpus: Perhaps we shall discuss this in the meeting tomorrow?
447 2019-10-30T17:51:45  <wumpus> sure
448 2019-10-30T17:54:04  *** mdunnio has joined #bitcoin-core-dev
449 2019-10-30T17:55:37  <sipa> dongcarl: can we submit our build for notarization? or does the whole building process need to be built inside the Reality Distortion Field?
450 2019-10-30T17:56:13  <achow101> I think there's a decent chance that our binaries get rejected by their automatic scanner for being "crypto mining malware"
451 2019-10-30T17:56:50  <sipa> won't hurt to try
452 2019-10-30T17:57:00  <sipa> worst case it fails, and we ignore it?
453 2019-10-30T17:57:09  *** bitcoin-git has joined #bitcoin-core-dev
454 2019-10-30T17:57:09  <bitcoin-git> [bitcoin] practicalswift closed pull request #17320: Make compiler warn about tautological run-time comparisons (master...static_assert) https://github.com/bitcoin/bitcoin/pull/17320
455 2019-10-30T17:57:19  *** bitcoin-git has left #bitcoin-core-dev
456 2019-10-30T17:57:27  *** Highway61 has joined #bitcoin-core-dev
457 2019-10-30T17:57:52  <dongcarl> sipa: I'm looking into the process right now... I think we can. ryanofsky mentioned that _if_ we can prove to the users that the output of the notarization process comes from our reproducible build process, then it might be okay, since anyone running a Mac is trusting Apple anyway
458 2019-10-30T17:58:26  *** setpill has left #bitcoin-core-dev
459 2019-10-30T17:58:28  *** setpill has joined #bitcoin-core-dev
460 2019-10-30T17:58:59  <sipa> dongcarl: or have a simple way to strip the notarization out, back to the binary that can be compared to the reproducible buils
461 2019-10-30T17:59:27  *** mdunnio has quit IRC
462 2019-10-30T18:00:01  *** b_b1 has quit IRC
463 2019-10-30T18:02:36  <dongcarl> "After uploading your app, the notarization process typically takes less than an hour."
464 2019-10-30T18:04:13  <wumpus> I guess the notarization data itself could be handled in the same way detached signatures are handled now
465 2019-10-30T18:04:49  <wumpus> assuming it's like an additional signature of apple
466 2019-10-30T18:04:59  <fanquake> Me and Cory have been looking at macOS toolchain issues all day. Can add this to the TODO list..
467 2019-10-30T18:05:42  <wumpus> the extra waiting time isn't really ap roblem
468 2019-10-30T18:06:24  <dongcarl> Oh it seems like GateKeeper will contact Apple for the notarization if we don't staple it to the app itself
469 2019-10-30T18:06:26  <wumpus> (assuming a normal release cycle like this)
470 2019-10-30T18:07:04  <dongcarl> We _should_ staple it though, for offline people
471 2019-10-30T18:07:08  *** mdunnio has joined #bitcoin-core-dev
472 2019-10-30T18:07:26  <wumpus> so getting apple to greenlight the thing is first priority...
473 2019-10-30T18:07:46  *** oriondeimos has joined #bitcoin-core-dev
474 2019-10-30T18:08:11  <dongcarl> wumpus: yup. Perhaps someone should submit the RC just to see what Apple says?
475 2019-10-30T18:11:18  <fanquake> Just discussed with Cory and he said "we'll deal with it tomorrow". Might be something to fix for 0.19.1.
476 2019-10-30T18:12:46  <wumpus> I guess people installing the old releases run into the same problem? or is it based on the signing timestamp?
477 2019-10-30T18:15:10  *** oriondeimos has quit IRC
478 2019-10-30T18:15:28  <dongcarl> It seems like if you notarize old releases then try to run them, Apple will tell you to update to the latest release: https://developer.apple.com/documentation/xcode/notarizing_your_app_before_distribution#3087722
479 2019-10-30T18:15:29  <gribble> https://github.com/bitcoin/bitcoin/issues/3087722 | HTTP Error 404: Not Found
480 2019-10-30T18:20:41  *** bitcoin-git has joined #bitcoin-core-dev
481 2019-10-30T18:20:41  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a6abc94e9307...08e29473126d
482 2019-10-30T18:20:42  <bitcoin-git> bitcoin/master d314e8a Wladimir J. van der Laan: refactor: Replace all uses of boost::optional with our own Optional type
483 2019-10-30T18:20:43  <bitcoin-git> bitcoin/master 08e2947 fanquake: Merge #17316: refactor: Replace all uses of boost::optional with our own O...
484 2019-10-30T18:20:44  *** bitcoin-git has left #bitcoin-core-dev
485 2019-10-30T18:21:01  *** bitcoin-git has joined #bitcoin-core-dev
486 2019-10-30T18:21:01  <bitcoin-git> [bitcoin] fanquake merged pull request #17316: refactor: Replace all uses of boost::optional with our own Optional type (master...2019_10_optional) https://github.com/bitcoin/bitcoin/pull/17316
487 2019-10-30T18:21:04  *** bitcoin-git has left #bitcoin-core-dev
488 2019-10-30T18:33:33  *** michaelfolkson has quit IRC
489 2019-10-30T18:37:40  *** mdunnio_ has joined #bitcoin-core-dev
490 2019-10-30T18:40:49  *** mdunnio has quit IRC
491 2019-10-30T18:43:02  *** setpill has quit IRC
492 2019-10-30T18:48:00  *** slewis has joined #bitcoin-core-dev
493 2019-10-30T18:53:57  *** owowo has quit IRC
494 2019-10-30T18:57:49  *** reallll has joined #bitcoin-core-dev
495 2019-10-30T19:00:47  *** owowo has joined #bitcoin-core-dev
496 2019-10-30T19:00:51  *** belcher has quit IRC
497 2019-10-30T19:02:01  *** reallll is now known as belcher
498 2019-10-30T19:04:53  *** jonatack has joined #bitcoin-core-dev
499 2019-10-30T19:09:33  *** captjakk has quit IRC
500 2019-10-30T19:11:31  *** jonatack has quit IRC
501 2019-10-30T19:11:56  *** jonatack has joined #bitcoin-core-dev
502 2019-10-30T19:14:26  *** ExtraCrispy has quit IRC
503 2019-10-30T19:14:27  *** davterra has quit IRC
504 2019-10-30T19:15:44  *** davterra has joined #bitcoin-core-dev
505 2019-10-30T19:19:19  *** arik_ has joined #bitcoin-core-dev
506 2019-10-30T19:34:52  *** andytoshi has quit IRC
507 2019-10-30T19:37:04  *** davterra has joined #bitcoin-core-dev
508 2019-10-30T19:38:15  *** davterra has quit IRC
509 2019-10-30T19:40:34  *** adembudak has joined #bitcoin-core-dev
510 2019-10-30T19:41:34  *** bitcoin-git has joined #bitcoin-core-dev
511 2019-10-30T19:41:34  <bitcoin-git> [bitcoin] Sjors closed pull request #17301: gui: enable RPC server by default (master...2019/10/gui-server) https://github.com/bitcoin/bitcoin/pull/17301
512 2019-10-30T19:41:45  *** bitcoin-git has left #bitcoin-core-dev
513 2019-10-30T19:53:06  *** diogosergio has joined #bitcoin-core-dev
514 2019-10-30T20:00:05  *** diogosergio has quit IRC
515 2019-10-30T20:02:23  *** diogosergio has joined #bitcoin-core-dev
516 2019-10-30T20:03:35  <fanquake> https://pastebin.com/2bkRNMbd
517 2019-10-30T20:04:05  <fanquake> eh. Wrong window.
518 2019-10-30T20:04:45  *** ddustin has quit IRC
519 2019-10-30T20:05:31  *** ddustin has joined #bitcoin-core-dev
520 2019-10-30T20:05:58  *** diogosergio has quit IRC
521 2019-10-30T20:06:13  *** diogosergio has joined #bitcoin-core-dev
522 2019-10-30T20:06:42  *** ddustin has joined #bitcoin-core-dev
523 2019-10-30T20:09:41  *** ajonas has quit IRC
524 2019-10-30T20:11:34  *** jb55 has quit IRC
525 2019-10-30T20:12:32  *** jb55 has joined #bitcoin-core-dev
526 2019-10-30T20:13:48  *** captjakk has joined #bitcoin-core-dev
527 2019-10-30T20:16:10  *** ajonas has joined #bitcoin-core-dev
528 2019-10-30T20:26:54  *** bitcoin-git has joined #bitcoin-core-dev
529 2019-10-30T20:26:54  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17324: Update univalue subtree (master...1910-updateUnivalue) https://github.com/bitcoin/bitcoin/pull/17324
530 2019-10-30T20:26:56  *** bitcoin-git has left #bitcoin-core-dev
531 2019-10-30T20:30:34  *** bitcoin-git has joined #bitcoin-core-dev
532 2019-10-30T20:30:34  <bitcoin-git> [bitcoin] hebasto opened pull request #17325: log: Fix log message for -par=1 (master...20191030-fix-par-log) https://github.com/bitcoin/bitcoin/pull/17325
533 2019-10-30T20:30:45  *** bitcoin-git has left #bitcoin-core-dev
534 2019-10-30T20:31:53  *** diogosergio has quit IRC
535 2019-10-30T20:32:16  *** diogosergio has joined #bitcoin-core-dev
536 2019-10-30T20:40:32  *** harrigan has quit IRC
537 2019-10-30T20:44:12  *** harrigan has joined #bitcoin-core-dev
538 2019-10-30T20:51:30  *** aqquadro has joined #bitcoin-core-dev
539 2019-10-30T20:55:27  *** captjakk_ has joined #bitcoin-core-dev
540 2019-10-30T20:59:32  *** captjakk has quit IRC
541 2019-10-30T21:00:02  *** slewis has quit IRC
542 2019-10-30T21:04:56  *** Chris_Stewart_5 has quit IRC
543 2019-10-30T21:08:50  *** Victorsueca has quit IRC
544 2019-10-30T21:10:32  *** freedomcode has joined #bitcoin-core-dev
545 2019-10-30T21:11:26  *** kristapsk has joined #bitcoin-core-dev
546 2019-10-30T21:11:36  *** reardencode has quit IRC
547 2019-10-30T21:13:32  *** adembudak has quit IRC
548 2019-10-30T21:13:55  *** Victorsueca has joined #bitcoin-core-dev
549 2019-10-30T21:16:37  *** alko has quit IRC
550 2019-10-30T21:18:02  *** Victorsueca has quit IRC
551 2019-10-30T21:18:22  *** ddustin has quit IRC
552 2019-10-30T21:18:33  *** alko has joined #bitcoin-core-dev
553 2019-10-30T21:18:41  *** ddustin has joined #bitcoin-core-dev
554 2019-10-30T21:19:26  *** ddustin has joined #bitcoin-core-dev
555 2019-10-30T21:20:16  *** ddustin has joined #bitcoin-core-dev
556 2019-10-30T21:21:01  *** ddustin has joined #bitcoin-core-dev
557 2019-10-30T21:23:32  *** afk11 has quit IRC
558 2019-10-30T21:23:57  *** afk11 has joined #bitcoin-core-dev
559 2019-10-30T21:31:35  *** roconnor has quit IRC
560 2019-10-30T21:33:40  *** roconnor has joined #bitcoin-core-dev
561 2019-10-30T21:35:14  *** davterra has joined #bitcoin-core-dev
562 2019-10-30T21:44:56  *** mdunnio_ has quit IRC
563 2019-10-30T21:47:47  *** captjakk has joined #bitcoin-core-dev
564 2019-10-30T21:48:01  *** Tabmow has joined #bitcoin-core-dev
565 2019-10-30T21:48:19  *** mdunnio has joined #bitcoin-core-dev
566 2019-10-30T21:48:25  *** Tabmow is now known as Guest18567
567 2019-10-30T21:51:03  *** captjakk_ has quit IRC
568 2019-10-30T21:52:18  *** captjakk has quit IRC
569 2019-10-30T21:53:38  *** mmgen has quit IRC
570 2019-10-30T22:03:24  *** kristapsk has quit IRC
571 2019-10-30T22:03:53  *** kristapsk has joined #bitcoin-core-dev
572 2019-10-30T22:07:39  *** captjakk has joined #bitcoin-core-dev
573 2019-10-30T22:15:45  *** captjakk has quit IRC
574 2019-10-30T22:21:13  *** kristapsk has quit IRC
575 2019-10-30T22:25:08  *** jarthur_ has joined #bitcoin-core-dev
576 2019-10-30T22:28:03  <moneyball> wumpus: i just tried installing .18.1 and it installed without an issue. so only the new signed binaries are affected. (also i don't see the google advanced protection warning with .18.1 like i do with .19.* RCs)
577 2019-10-30T22:28:17  *** jarthur has quit IRC
578 2019-10-30T22:30:05  *** jarthur_ has quit IRC
579 2019-10-30T22:32:50  *** kristapsk has joined #bitcoin-core-dev
580 2019-10-30T22:35:47  *** mdunnio has quit IRC
581 2019-10-30T22:41:40  *** alko has quit IRC
582 2019-10-30T22:42:00  *** alko has joined #bitcoin-core-dev
583 2019-10-30T22:46:07  *** aqquadro has quit IRC
584 2019-10-30T22:48:08  *** Victorsueca has joined #bitcoin-core-dev
585 2019-10-30T22:48:16  *** jb55 has quit IRC
586 2019-10-30T22:48:49  *** jb55 has joined #bitcoin-core-dev
587 2019-10-30T22:56:57  *** Guyver2 has quit IRC
588 2019-10-30T23:06:47  *** arik_ has quit IRC
589 2019-10-30T23:07:39  *** jtimon has quit IRC
590 2019-10-30T23:08:01  *** rh0nj has quit IRC
591 2019-10-30T23:08:23  *** diogosergio has quit IRC
592 2019-10-30T23:09:08  *** rh0nj has joined #bitcoin-core-dev
593 2019-10-30T23:09:28  *** diogosergio has joined #bitcoin-core-dev
594 2019-10-30T23:48:13  *** diogosergio has quit IRC
595 2019-10-30T23:48:39  *** marcoagner has quit IRC