12019-11-05T00:00:01 *** Bille has quit IRC
22019-11-05T00:00:02 *** ghost43_ is now known as ghost43
32019-11-05T00:00:42 *** Zenton has quit IRC
42019-11-05T00:12:46 *** millerti has quit IRC
52019-11-05T00:17:44 *** SLNP has joined #bitcoin-core-dev
62019-11-05T00:19:01 *** mariorz has quit IRC
72019-11-05T00:20:29 *** TTT has quit IRC
82019-11-05T00:24:16 *** mariorz has joined #bitcoin-core-dev
92019-11-05T00:26:37 *** Chris_Stewart_5 has quit IRC
102019-11-05T00:30:48 *** bitcoin-git has joined #bitcoin-core-dev
112019-11-05T00:30:48 <bitcoin-git> [bitcoin] JeremyRubin opened pull request #17375: Add asymptotes for benchmarking framework (master...asymptotic-benchmarks) https://github.com/bitcoin/bitcoin/pull/17375
122019-11-05T00:30:49 *** bitcoin-git has left #bitcoin-core-dev
132019-11-05T00:45:57 *** cryptoIndio has joined #bitcoin-core-dev
142019-11-05T00:46:01 *** goatpig_ has quit IRC
152019-11-05T00:48:54 *** mariorz has quit IRC
162019-11-05T00:54:19 *** mariorz has joined #bitcoin-core-dev
172019-11-05T00:58:37 *** goatpig_ has joined #bitcoin-core-dev
182019-11-05T01:04:27 *** goatpig_ has quit IRC
192019-11-05T01:07:00 *** goatpig_ has joined #bitcoin-core-dev
202019-11-05T01:14:09 *** justanotheruser has joined #bitcoin-core-dev
212019-11-05T01:27:59 *** ddustin_ has quit IRC
222019-11-05T01:28:37 *** ddustin has joined #bitcoin-core-dev
232019-11-05T01:33:19 *** ddustin has quit IRC
242019-11-05T01:41:28 *** cryptoIndio has quit IRC
252019-11-05T01:41:43 *** cryptoIndio has joined #bitcoin-core-dev
262019-11-05T01:48:40 *** Highway61 has joined #bitcoin-core-dev
272019-11-05T01:48:44 *** mariorz has quit IRC
282019-11-05T01:54:27 *** mariorz has joined #bitcoin-core-dev
292019-11-05T01:56:04 *** wsm has quit IRC
302019-11-05T02:02:43 *** wsm has joined #bitcoin-core-dev
312019-11-05T02:05:56 *** soju has quit IRC
322019-11-05T02:09:10 *** jarthur has joined #bitcoin-core-dev
332019-11-05T02:13:35 *** arik_ has quit IRC
342019-11-05T02:16:31 *** jpe_ has joined #bitcoin-core-dev
352019-11-05T02:19:15 *** jpe has quit IRC
362019-11-05T02:37:27 *** nosss2 has quit IRC
372019-11-05T02:48:50 *** mariorz has quit IRC
382019-11-05T02:49:35 *** ddustin has joined #bitcoin-core-dev
392019-11-05T02:51:29 *** lightlike has quit IRC
402019-11-05T02:53:55 *** mariorz has joined #bitcoin-core-dev
412019-11-05T03:00:01 *** SLNP has quit IRC
422019-11-05T03:05:15 *** nosss2 has joined #bitcoin-core-dev
432019-11-05T03:05:30 *** justanotheruser has quit IRC
442019-11-05T03:06:11 *** emilengler_ has joined #bitcoin-core-dev
452019-11-05T03:08:02 *** emilengler has quit IRC
462019-11-05T03:08:52 <luke-jr> MarcoFalke: https://github.com/bitcoin/bips/pull/856#issuecomment-549629459 :P
472019-11-05T03:15:21 *** felixfoertsch23 has joined #bitcoin-core-dev
482019-11-05T03:15:29 *** felixfoertsch has quit IRC
492019-11-05T03:17:48 *** feedoo1 has joined #bitcoin-core-dev
502019-11-05T03:24:02 *** justanotheruser has joined #bitcoin-core-dev
512019-11-05T03:30:02 *** justanotheruser has quit IRC
522019-11-05T03:34:45 *** harrigan has quit IRC
532019-11-05T03:35:40 *** harrigan has joined #bitcoin-core-dev
542019-11-05T03:43:28 *** arik_ has joined #bitcoin-core-dev
552019-11-05T03:43:57 *** Highway61 has quit IRC
562019-11-05T03:46:42 *** nosss2 has quit IRC
572019-11-05T03:50:33 *** arik_ has quit IRC
582019-11-05T04:02:38 *** justanotheruser has joined #bitcoin-core-dev
592019-11-05T04:06:01 *** nosss2 has joined #bitcoin-core-dev
602019-11-05T04:11:51 *** justanotheruser has quit IRC
612019-11-05T04:21:38 *** pinheadmz has quit IRC
622019-11-05T04:21:51 *** Eagle[TM] has joined #bitcoin-core-dev
632019-11-05T04:23:56 *** EagleTM has quit IRC
642019-11-05T04:34:34 *** IGHOR has quit IRC
652019-11-05T04:37:30 *** justanotheruser has joined #bitcoin-core-dev
662019-11-05T04:49:33 *** justanotheruser has quit IRC
672019-11-05T04:59:22 *** justanotheruser has joined #bitcoin-core-dev
682019-11-05T05:11:28 *** bitcoin-git has joined #bitcoin-core-dev
692019-11-05T05:11:28 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #17376: Add Parallel P2P Client in Rust (master...2019-10-rusty-p2p) https://github.com/bitcoin/bitcoin/pull/17376
702019-11-05T05:11:30 *** bitcoin-git has left #bitcoin-core-dev
712019-11-05T05:46:02 *** arik_ has joined #bitcoin-core-dev
722019-11-05T05:48:45 *** mariorz has quit IRC
732019-11-05T05:49:03 *** mariorz has joined #bitcoin-core-dev
742019-11-05T05:50:29 *** cryptoIn_ has joined #bitcoin-core-dev
752019-11-05T05:50:29 *** cryptoIndio has quit IRC
762019-11-05T06:00:01 *** feedoo1 has quit IRC
772019-11-05T06:04:47 *** Emcy has quit IRC
782019-11-05T06:05:25 *** nosss2 has quit IRC
792019-11-05T06:07:58 *** arik_ has quit IRC
802019-11-05T06:08:38 *** nosss2 has joined #bitcoin-core-dev
812019-11-05T06:10:12 *** Giszmo has joined #bitcoin-core-dev
822019-11-05T06:12:21 *** Emcy has joined #bitcoin-core-dev
832019-11-05T06:13:10 *** nosss2 has quit IRC
842019-11-05T06:17:15 *** ericbsd has joined #bitcoin-core-dev
852019-11-05T06:28:38 *** ddustin_ has joined #bitcoin-core-dev
862019-11-05T06:30:57 *** Dean_Guss has quit IRC
872019-11-05T06:31:23 *** Dean_Guss has joined #bitcoin-core-dev
882019-11-05T06:31:52 *** ddustin has quit IRC
892019-11-05T06:33:03 *** nosss2 has joined #bitcoin-core-dev
902019-11-05T06:37:38 *** instagibbs has quit IRC
912019-11-05T06:37:54 *** nosss2 has quit IRC
922019-11-05T06:42:28 *** soju has joined #bitcoin-core-dev
932019-11-05T06:43:06 *** nosss2 has joined #bitcoin-core-dev
942019-11-05T06:47:53 *** soju has quit IRC
952019-11-05T06:48:02 *** nosss2 has quit IRC
962019-11-05T06:49:38 *** nosss2 has joined #bitcoin-core-dev
972019-11-05T06:49:41 *** instagibbs has joined #bitcoin-core-dev
982019-11-05T06:50:23 *** soju has joined #bitcoin-core-dev
992019-11-05T06:53:49 *** nosss2 has quit IRC
1002019-11-05T06:54:12 *** nosss2 has joined #bitcoin-core-dev
1012019-11-05T06:58:37 *** nosss2 has quit IRC
1022019-11-05T07:08:02 *** timothy has joined #bitcoin-core-dev
1032019-11-05T07:08:36 *** cryptoIn_ has quit IRC
1042019-11-05T07:12:26 *** nosss2 has joined #bitcoin-core-dev
1052019-11-05T07:13:14 *** Victor_sueca is now known as Victorsueca
1062019-11-05T07:14:50 *** Eagle[TM] has quit IRC
1072019-11-05T07:16:50 *** nosss2 has quit IRC
1082019-11-05T07:22:26 *** nosss2 has joined #bitcoin-core-dev
1092019-11-05T07:27:14 *** nosss2 has quit IRC
1102019-11-05T07:33:15 *** tiendo1011 has joined #bitcoin-core-dev
1112019-11-05T07:33:36 *** nosss2 has joined #bitcoin-core-dev
1122019-11-05T07:34:19 *** tiendo1011 has quit IRC
1132019-11-05T07:38:20 *** nosss2 has quit IRC
1142019-11-05T07:39:33 *** cryptoIndio has joined #bitcoin-core-dev
1152019-11-05T07:44:23 *** soju has quit IRC
1162019-11-05T07:44:57 *** cryptoIndio has quit IRC
1172019-11-05T07:45:31 *** soju has joined #bitcoin-core-dev
1182019-11-05T07:50:43 *** nosss2 has joined #bitcoin-core-dev
1192019-11-05T07:50:45 *** soju has quit IRC
1202019-11-05T07:55:06 *** nosss2 has quit IRC
1212019-11-05T07:58:14 *** harrigan has quit IRC
1222019-11-05T07:59:54 *** harrigan has joined #bitcoin-core-dev
1232019-11-05T08:03:36 *** IGHOR has joined #bitcoin-core-dev
1242019-11-05T08:03:36 *** cryptoIndio has joined #bitcoin-core-dev
1252019-11-05T08:03:41 *** nosss2 has joined #bitcoin-core-dev
1262019-11-05T08:04:03 *** IGHOR has quit IRC
1272019-11-05T08:08:02 *** nosss2 has quit IRC
1282019-11-05T08:17:34 *** nosss2 has joined #bitcoin-core-dev
1292019-11-05T08:20:19 *** marcoagner has joined #bitcoin-core-dev
1302019-11-05T08:21:37 *** justanotheruser has quit IRC
1312019-11-05T08:24:09 *** nosss2 has quit IRC
1322019-11-05T08:27:57 *** ddustin_ has quit IRC
1332019-11-05T08:28:34 *** ddustin has joined #bitcoin-core-dev
1342019-11-05T08:31:02 *** nosss2 has joined #bitcoin-core-dev
1352019-11-05T08:33:03 *** ddustin has quit IRC
1362019-11-05T08:35:18 *** nosss2 has quit IRC
1372019-11-05T08:39:36 *** nijynot has joined #bitcoin-core-dev
1382019-11-05T08:51:27 *** nosss2 has joined #bitcoin-core-dev
1392019-11-05T08:55:37 *** nosss2 has quit IRC
1402019-11-05T08:56:37 *** bitcoin-git has joined #bitcoin-core-dev
1412019-11-05T08:56:38 <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc38bb9a6036...bfc4c896d6d2
1422019-11-05T08:56:38 <bitcoin-git> bitcoin/master 436ad43 Adam Jonas: Fix issue with conflicted mempool tx in listsinceblock
1432019-11-05T08:56:39 <bitcoin-git> bitcoin/master bfc4c89 Samuel Dobson: Merge #17258: Fix issue with conflicted mempool tx in listsinceblock
1442019-11-05T08:56:41 *** bitcoin-git has left #bitcoin-core-dev
1452019-11-05T08:56:52 *** b10c has joined #bitcoin-core-dev
1462019-11-05T08:56:57 *** bitcoin-git has joined #bitcoin-core-dev
1472019-11-05T08:56:57 <bitcoin-git> [bitcoin] meshcollider merged pull request #17258: Fix issue with conflicted mempool tx in listsinceblock (master...listsinceblock-filter-conflicts) https://github.com/bitcoin/bitcoin/pull/17258
1482019-11-05T08:56:59 *** bitcoin-git has left #bitcoin-core-dev
1492019-11-05T08:59:08 *** bitcoin-git has joined #bitcoin-core-dev
1502019-11-05T08:59:09 <bitcoin-git> [bitcoin] meshcollider pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/bfc4c896d6d2...bdda13787890
1512019-11-05T08:59:09 <bitcoin-git> bitcoin/master dce032c Jeremy Rubin: Make IsTrusted scan parents recursively
1522019-11-05T08:59:10 <bitcoin-git> bitcoin/master 595f09d Jeremy Rubin: Cache tx Trust per-call to avoid DoS
1532019-11-05T08:59:10 <bitcoin-git> bitcoin/master 5dd7da4 Jeremy Rubin: Reuse trustedParents in looped calls to IsTrusted
1542019-11-05T08:59:21 *** bitcoin-git has left #bitcoin-core-dev
1552019-11-05T08:59:38 *** bitcoin-git has joined #bitcoin-core-dev
1562019-11-05T08:59:39 <bitcoin-git> [bitcoin] meshcollider merged pull request #16766: wallet: Make IsTrusted scan parents recursively (master...recursive-istrusted) https://github.com/bitcoin/bitcoin/pull/16766
1572019-11-05T08:59:39 *** bitcoin-git has left #bitcoin-core-dev
1582019-11-05T09:00:02 *** ericbsd has quit IRC
1592019-11-05T09:01:07 *** ddustin has joined #bitcoin-core-dev
1602019-11-05T09:02:20 *** nijynot has quit IRC
1612019-11-05T09:03:48 *** timothy has quit IRC
1622019-11-05T09:04:45 *** nosss2 has joined #bitcoin-core-dev
1632019-11-05T09:05:37 *** ddustin has quit IRC
1642019-11-05T09:08:57 *** nosss2 has quit IRC
1652019-11-05T09:09:10 *** timothy has joined #bitcoin-core-dev
1662019-11-05T09:14:55 *** nosss2 has joined #bitcoin-core-dev
1672019-11-05T09:17:56 *** vladan1 has joined #bitcoin-core-dev
1682019-11-05T09:19:44 *** nosss2 has quit IRC
1692019-11-05T09:20:21 *** jarthur has quit IRC
1702019-11-05T09:29:24 *** jungly has quit IRC
1712019-11-05T09:29:46 *** Zenton has joined #bitcoin-core-dev
1722019-11-05T09:30:06 *** jungly has joined #bitcoin-core-dev
1732019-11-05T09:35:11 *** nijynot has joined #bitcoin-core-dev
1742019-11-05T09:42:58 *** nosss2 has joined #bitcoin-core-dev
1752019-11-05T09:47:46 *** nosss2 has quit IRC
1762019-11-05T09:49:02 *** rh0nj has quit IRC
1772019-11-05T09:50:07 *** rh0nj has joined #bitcoin-core-dev
1782019-11-05T09:51:02 *** rh0nj has quit IRC
1792019-11-05T09:52:10 *** rh0nj has joined #bitcoin-core-dev
1802019-11-05T09:57:32 *** nosss2 has joined #bitcoin-core-dev
1812019-11-05T10:06:57 *** nosss2 has quit IRC
1822019-11-05T10:14:12 *** nosss2 has joined #bitcoin-core-dev
1832019-11-05T10:14:53 *** goatpig_ has quit IRC
1842019-11-05T10:19:15 *** nosss2 has quit IRC
1852019-11-05T10:25:46 *** diogosergio has joined #bitcoin-core-dev
1862019-11-05T10:26:34 *** goatpig_ has joined #bitcoin-core-dev
1872019-11-05T10:32:40 *** nosss2 has joined #bitcoin-core-dev
1882019-11-05T10:36:58 *** felixfoertsch23 has quit IRC
1892019-11-05T10:37:15 *** felixfoertsch has joined #bitcoin-core-dev
1902019-11-05T10:37:29 *** nosss2 has quit IRC
1912019-11-05T10:40:02 *** nosss2 has joined #bitcoin-core-dev
1922019-11-05T10:44:02 *** nosss2 has quit IRC
1932019-11-05T10:54:56 *** IGHOR has joined #bitcoin-core-dev
1942019-11-05T10:55:31 *** IGHOR has quit IRC
1952019-11-05T10:59:25 *** nosss2 has joined #bitcoin-core-dev
1962019-11-05T11:03:37 *** nosss2 has quit IRC
1972019-11-05T11:09:51 *** nosss2 has joined #bitcoin-core-dev
1982019-11-05T11:12:20 *** afk11 has quit IRC
1992019-11-05T11:12:56 *** afk11 has joined #bitcoin-core-dev
2002019-11-05T11:19:07 *** nosss2 has quit IRC
2012019-11-05T11:19:48 *** cryptoIndio has quit IRC
2022019-11-05T11:21:35 *** IGHOR has joined #bitcoin-core-dev
2032019-11-05T11:27:51 *** nosss2 has joined #bitcoin-core-dev
2042019-11-05T11:31:28 *** lightlike has joined #bitcoin-core-dev
2052019-11-05T11:32:23 *** nosss2 has quit IRC
2062019-11-05T11:35:01 *** nosss2 has joined #bitcoin-core-dev
2072019-11-05T11:39:21 *** emilengler_ has quit IRC
2082019-11-05T11:39:27 *** nosss2 has quit IRC
2092019-11-05T11:40:15 *** emilengler has joined #bitcoin-core-dev
2102019-11-05T11:44:21 *** nosss2 has joined #bitcoin-core-dev
2112019-11-05T11:44:52 *** felixfoertsch has quit IRC
2122019-11-05T11:45:28 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2132019-11-05T11:46:10 *** felixfoertsch has joined #bitcoin-core-dev
2142019-11-05T11:49:02 *** nosss2 has quit IRC
2152019-11-05T12:00:01 *** vladan1 has quit IRC
2162019-11-05T12:02:07 *** nosss2 has joined #bitcoin-core-dev
2172019-11-05T12:06:47 *** nosss2 has quit IRC
2182019-11-05T12:07:09 *** nosss2 has joined #bitcoin-core-dev
2192019-11-05T12:12:08 *** nosss2 has quit IRC
2202019-11-05T12:17:32 *** bitcoin-git has joined #bitcoin-core-dev
2212019-11-05T12:17:33 <bitcoin-git> [bitcoin] theStack opened pull request #17377: wallet: remove unused variable spk_man in import* RPCs (master...20191105-refactor-remove_unused_variable_spkman) https://github.com/bitcoin/bitcoin/pull/17377
2222019-11-05T12:17:34 *** bitcoin-git has left #bitcoin-core-dev
2232019-11-05T12:17:52 *** kcomandich1 has joined #bitcoin-core-dev
2242019-11-05T12:19:49 *** nosss2 has joined #bitcoin-core-dev
2252019-11-05T12:22:11 *** Highway61 has joined #bitcoin-core-dev
2262019-11-05T12:24:26 *** nosss2 has quit IRC
2272019-11-05T12:39:52 *** nosss2 has joined #bitcoin-core-dev
2282019-11-05T12:44:27 *** nosss2 has quit IRC
2292019-11-05T12:45:54 *** nijynot_ has joined #bitcoin-core-dev
2302019-11-05T12:46:58 *** laptop500 has joined #bitcoin-core-dev
2312019-11-05T12:47:14 *** nijynot has quit IRC
2322019-11-05T12:47:52 *** nosss2 has joined #bitcoin-core-dev
2332019-11-05T12:52:24 *** nosss2 has quit IRC
2342019-11-05T12:57:36 *** Chris_Stewart_5 has quit IRC
2352019-11-05T12:59:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2362019-11-05T12:59:12 *** b10c has quit IRC
2372019-11-05T13:01:24 *** nosss2 has joined #bitcoin-core-dev
2382019-11-05T13:05:43 *** nosss2 has quit IRC
2392019-11-05T13:06:20 *** bitcoin-git has joined #bitcoin-core-dev
2402019-11-05T13:06:20 <bitcoin-git> [bitcoin] jachiang opened pull request #17378: TestShell: Fix typos & implement cleanups (master...2019-11-testshell-followup) https://github.com/bitcoin/bitcoin/pull/17378
2412019-11-05T13:06:31 *** bitcoin-git has left #bitcoin-core-dev
2422019-11-05T13:12:40 *** nosss2 has joined #bitcoin-core-dev
2432019-11-05T13:17:03 *** nosss2 has quit IRC
2442019-11-05T13:17:28 *** nijynot has joined #bitcoin-core-dev
2452019-11-05T13:19:58 *** nijynot_ has quit IRC
2462019-11-05T13:35:59 *** goatpig has joined #bitcoin-core-dev
2472019-11-05T13:36:14 *** goatpig_ has quit IRC
2482019-11-05T13:37:27 *** nosss2 has joined #bitcoin-core-dev
2492019-11-05T13:38:26 *** timothy has quit IRC
2502019-11-05T13:39:17 *** MasterdonX has quit IRC
2512019-11-05T13:40:40 *** MasterdonX has joined #bitcoin-core-dev
2522019-11-05T13:42:44 *** nosss2 has quit IRC
2532019-11-05T13:44:01 *** Highway61 has quit IRC
2542019-11-05T13:52:09 *** IGHOR has quit IRC
2552019-11-05T13:59:07 *** goatpig has quit IRC
2562019-11-05T13:59:17 *** goatpig_ has joined #bitcoin-core-dev
2572019-11-05T14:07:40 *** IGHOR has joined #bitcoin-core-dev
2582019-11-05T14:11:01 *** Guyver2 has joined #bitcoin-core-dev
2592019-11-05T14:15:14 *** IGHOR has joined #bitcoin-core-dev
2602019-11-05T14:15:53 *** IGHOR has quit IRC
2612019-11-05T14:17:14 *** Chris_Stewart_5 has quit IRC
2622019-11-05T14:19:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2632019-11-05T14:25:35 *** timothy has joined #bitcoin-core-dev
2642019-11-05T14:28:06 *** IGHOR has joined #bitcoin-core-dev
2652019-11-05T14:36:52 *** tsujp has quit IRC
2662019-11-05T14:37:25 *** SiAnDoG has quit IRC
2672019-11-05T14:37:39 *** SiAnDoG has joined #bitcoin-core-dev
2682019-11-05T14:39:06 *** tsujp has joined #bitcoin-core-dev
2692019-11-05T14:40:49 *** SiAnDoG has quit IRC
2702019-11-05T14:44:11 *** mmgen has joined #bitcoin-core-dev
2712019-11-05T14:45:42 *** bitcoin-git has joined #bitcoin-core-dev
2722019-11-05T14:45:42 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17365: depends: update README.md with working Android targets and API levels (master...update-android-depends-doc) https://github.com/bitcoin/bitcoin/pull/17365
2732019-11-05T14:45:44 *** bitcoin-git has left #bitcoin-core-dev
2742019-11-05T14:56:02 *** nosss2 has joined #bitcoin-core-dev
2752019-11-05T15:00:01 *** kcomandich1 has quit IRC
2762019-11-05T15:01:51 *** felixweis has joined #bitcoin-core-dev
2772019-11-05T15:11:35 *** IGHOR has quit IRC
2782019-11-05T15:13:12 *** drizztbsd has joined #bitcoin-core-dev
2792019-11-05T15:14:03 *** timothy has quit IRC
2802019-11-05T15:16:26 *** thoragh has joined #bitcoin-core-dev
2812019-11-05T15:17:57 *** JohnONolan has joined #bitcoin-core-dev
2822019-11-05T15:18:26 *** drizztbsd has quit IRC
2832019-11-05T15:32:51 *** pinheadmz has joined #bitcoin-core-dev
2842019-11-05T15:34:03 *** bitcoin-git has joined #bitcoin-core-dev
2852019-11-05T15:34:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bdda13787890...e204dc11b562
2862019-11-05T15:34:04 <bitcoin-git> bitcoin/master aa9b84a Igor Cota: depends: update README.md with working Android targets and API levels
2872019-11-05T15:34:04 <bitcoin-git> bitcoin/master 3fe1aba Igor Cota: depends: move README.md Android instructions to a separate section
2882019-11-05T15:34:05 <bitcoin-git> bitcoin/master e204dc1 MarcoFalke: Merge #17365: depends: update README.md with working Android targets and A...
2892019-11-05T15:34:06 *** bitcoin-git has left #bitcoin-core-dev
2902019-11-05T15:41:23 *** b10c has joined #bitcoin-core-dev
2912019-11-05T15:49:03 *** IGHOR has joined #bitcoin-core-dev
2922019-11-05T15:49:04 *** jb55 has quit IRC
2932019-11-05T15:49:42 *** spaced0ut has quit IRC
2942019-11-05T15:52:03 *** justanotheruser has joined #bitcoin-core-dev
2952019-11-05T15:52:17 *** laptop500 has quit IRC
2962019-11-05T15:52:53 *** jb55 has joined #bitcoin-core-dev
2972019-11-05T15:57:50 *** nijynot has quit IRC
2982019-11-05T15:58:31 *** JBmc has joined #bitcoin-core-dev
2992019-11-05T15:59:29 <emilengler> Where is the actual http implemented?
3002019-11-05T15:59:39 <emilengler> I'm talking about the low level networking
3012019-11-05T15:59:57 <emilengler> httpserver.cpp is probably the wrong place but I might have overseen it
3022019-11-05T16:00:55 *** jungly has quit IRC
3032019-11-05T16:02:04 *** jungly has joined #bitcoin-core-dev
3042019-11-05T16:03:07 <luke-jr> emilengler: libevent?
3052019-11-05T16:04:16 <luke-jr> #17356 is now passing and ready for concept review; in particular, one open question is how to deal with the `echo` JSON-RPC method: https://github.com/bitcoin/bitcoin/pull/17356#issuecomment-549565616
3062019-11-05T16:04:18 <gribble> https://github.com/bitcoin/bitcoin/issues/17356 | RPC: Internal named params by luke-jr · Pull Request #17356 · bitcoin/bitcoin · GitHub
3072019-11-05T16:05:06 *** JBmc has left #bitcoin-core-dev
3082019-11-05T16:05:27 *** arik_ has joined #bitcoin-core-dev
3092019-11-05T16:10:32 *** bitcoin-git has joined #bitcoin-core-dev
3102019-11-05T16:10:32 <bitcoin-git> [bitcoin] ryanofsky opened pull request #17381: LegacyScriptPubKeyMan code cleanups (master...pr/keyman-cleanup2) https://github.com/bitcoin/bitcoin/pull/17381
3112019-11-05T16:10:34 *** bitcoin-git has left #bitcoin-core-dev
3122019-11-05T16:19:27 *** Dean_Guss has quit IRC
3132019-11-05T16:24:32 *** arik__ has joined #bitcoin-core-dev
3142019-11-05T16:25:44 *** arik_ has quit IRC
3152019-11-05T16:26:12 *** arik_ has joined #bitcoin-core-dev
3162019-11-05T16:40:42 *** pinheadmz has quit IRC
3172019-11-05T16:42:02 *** justanotheruser has quit IRC
3182019-11-05T16:46:35 *** bitcoin-git has joined #bitcoin-core-dev
3192019-11-05T16:46:35 <bitcoin-git> [bitcoin] fanquake closed pull request #17377: wallet: remove unused variable spk_man in import* RPCs (master...20191105-refactor-remove_unused_variable_spkman) https://github.com/bitcoin/bitcoin/pull/17377
3202019-11-05T16:46:46 *** bitcoin-git has left #bitcoin-core-dev
3212019-11-05T16:50:33 *** pinheadmz has joined #bitcoin-core-dev
3222019-11-05T16:54:28 *** ddustin has joined #bitcoin-core-dev
3232019-11-05T16:57:12 <fanquake> GitHub emails nice and laggy today.
3242019-11-05T16:57:33 <provoostenator> fanquake: notification tab is lagging too
3252019-11-05T16:57:46 <provoostenator> We're too productive :-)
3262019-11-05T17:01:01 *** justanotheruser has joined #bitcoin-core-dev
3272019-11-05T17:02:12 <luke-jr> I'd add a complaint about Travus, but⦠yeah, it's always bad :P
3282019-11-05T17:06:11 *** thoragh has quit IRC
3292019-11-05T17:06:41 *** pinheadmz has quit IRC
3302019-11-05T17:10:46 <provoostenator> I raise you AppVeyor
3312019-11-05T17:12:05 *** Dean_Guss has joined #bitcoin-core-dev
3322019-11-05T17:12:07 <luke-jr> XD
3332019-11-05T17:12:13 <jonatack> even https://bitcoinbuilds.org seems to be struggling lately
3342019-11-05T17:13:37 *** diogosergio has quit IRC
3352019-11-05T17:19:36 *** pinheadmz has joined #bitcoin-core-dev
3362019-11-05T17:22:19 *** pinheadmz has quit IRC
3372019-11-05T17:25:36 *** pinheadmz has joined #bitcoin-core-dev
3382019-11-05T17:37:35 *** bitcoin-git has joined #bitcoin-core-dev
3392019-11-05T17:37:35 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17378: TestShell: Fix typos & implement cleanups (master...2019-11-testshell-followup) https://github.com/bitcoin/bitcoin/pull/17378
3402019-11-05T17:37:40 *** bitcoin-git has left #bitcoin-core-dev
3412019-11-05T17:37:57 *** thoragh has joined #bitcoin-core-dev
3422019-11-05T17:39:48 *** bitcoin-git has joined #bitcoin-core-dev
3432019-11-05T17:39:49 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/54a337478dfb...c7e6b3b343e8
3442019-11-05T17:39:50 <bitcoin-git> bitcoin/master 4de6303 Amiti Uttarwar: [tools] add PoissonNextSend method that returns mockable time
3452019-11-05T17:39:50 <bitcoin-git> bitcoin/master 1a8f0d5 Amiti Uttarwar: [tools] update nNextInvSend to use mockable time
3462019-11-05T17:39:51 <bitcoin-git> bitcoin/master c7e6b3b MarcoFalke: Merge #17243: p2p: add PoissonNextSend method that returns mockable time
3472019-11-05T17:39:52 *** bitcoin-git has left #bitcoin-core-dev
3482019-11-05T17:40:08 *** bitcoin-git has joined #bitcoin-core-dev
3492019-11-05T17:40:09 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17243: p2p: add PoissonNextSend method that returns mockable time (master...1910-mockable-poisson) https://github.com/bitcoin/bitcoin/pull/17243
3502019-11-05T17:40:10 *** bitcoin-git has left #bitcoin-core-dev
3512019-11-05T17:46:34 *** jarthur has joined #bitcoin-core-dev
3522019-11-05T17:50:54 *** ElectrumWallet has joined #bitcoin-core-dev
3532019-11-05T17:56:23 *** bitcoin-git has joined #bitcoin-core-dev
3542019-11-05T17:56:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17357: tests: Add fuzzing harness for Bech32 encoding/decoding (master...fuzzers-bech32) https://github.com/bitcoin/bitcoin/pull/17357
3552019-11-05T17:56:24 *** bitcoin-git has left #bitcoin-core-dev
3562019-11-05T18:00:02 *** JohnONolan has quit IRC
3572019-11-05T18:01:47 *** ddustin has quit IRC
3582019-11-05T18:03:20 *** DeanWeen has joined #bitcoin-core-dev
3592019-11-05T18:05:48 *** Dean_Guss has quit IRC
3602019-11-05T18:06:03 *** DeanWeen is now known as DeanGuss
3612019-11-05T18:06:57 <luke-jr> GitHub's Merge button is not working either
3622019-11-05T18:09:19 *** pinheadmz has quit IRC
3632019-11-05T18:12:52 <jarthur> If an operator is around, the user ElectrumWallet is impersonating the open source Electrum project.
3642019-11-05T18:13:24 <gwillen> jarthur: unfortunately he's doing it in multiple channels that do not have chanops in common
3652019-11-05T18:13:38 <luke-jr> not sure what it has to do with dev..
3662019-11-05T18:13:58 <jarthur> luke-jr: agreed, except that it's here in the dev channel.
3672019-11-05T18:14:06 *** pinheadmz has joined #bitcoin-core-dev
3682019-11-05T18:14:41 <luke-jr> ah, true
3692019-11-05T18:15:18 *** ChanServ sets mode: +o gwillen
3702019-11-05T18:15:28 *** gwillen sets mode: +b *!*@160.154.130.99
3712019-11-05T18:15:29 *** ElectrumWallet was kicked by gwillen (ElectrumWallet)
3722019-11-05T18:15:32 *** gwillen sets mode: -o gwillen
3732019-11-05T18:17:20 *** nickr has joined #bitcoin-core-dev
3742019-11-05T18:19:39 *** raj_149 has joined #bitcoin-core-dev
3752019-11-05T18:21:33 *** Chris_Stewart_5 has quit IRC
3762019-11-05T18:22:07 *** bitcoin-git has joined #bitcoin-core-dev
3772019-11-05T18:22:07 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17363: test: add "diamond" unit test to MempoolAncestryTests (master...20191104-test-add_diamond_ancestors_unit_test) https://github.com/bitcoin/bitcoin/pull/17363
3782019-11-05T18:22:09 *** bitcoin-git has left #bitcoin-core-dev
3792019-11-05T18:26:04 *** bitcoin-git has joined #bitcoin-core-dev
3802019-11-05T18:26:04 <bitcoin-git> [bitcoin] laanwj merged pull request #17044: init: Remove auto-import of `bootstrap.dat` and associated code (master...pr15954) https://github.com/bitcoin/bitcoin/pull/17044
3812019-11-05T18:26:05 *** bitcoin-git has left #bitcoin-core-dev
3822019-11-05T18:26:24 *** diogosergio has joined #bitcoin-core-dev
3832019-11-05T18:29:00 *** mdunnio has joined #bitcoin-core-dev
3842019-11-05T18:29:19 *** andytoshi has joined #bitcoin-core-dev
3852019-11-05T18:29:36 *** bitcoin-git has joined #bitcoin-core-dev
3862019-11-05T18:29:36 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e204dc11b562...54a337478dfb
3872019-11-05T18:29:37 <bitcoin-git> bitcoin/master d3ed06e James Chiang: TestShell: Fix typo in TestShell warning printout
3882019-11-05T18:29:37 <bitcoin-git> bitcoin/master 9c7806e James Chiang: Doc: Remove backticks in test-shell.md code block
3892019-11-05T18:29:38 <bitcoin-git> bitcoin/master a8dea45 James Chiang: TestShell: Simplify default setting of num_nodes
3902019-11-05T18:29:39 *** bitcoin-git has left #bitcoin-core-dev
3912019-11-05T18:30:04 *** pinheadmz has quit IRC
3922019-11-05T18:31:20 <luke-jr> MarcoFalke: src/crypto/poly1305.cpp
3932019-11-05T18:31:48 *** pinheadmz has joined #bitcoin-core-dev
3942019-11-05T18:32:45 <MarcoFalke> luke-jr: Fine, but we don't use goto in the Bitcoin Core dialect of C++
3952019-11-05T18:33:07 <MarcoFalke> The crypto is mostly written in something that is closer to C
3962019-11-05T18:33:24 <sipa> it's also a direct port of C code
3972019-11-05T18:33:32 <sipa> of the reference C code, almost even
3982019-11-05T18:33:42 *** bitcoin-git has joined #bitcoin-core-dev
3992019-11-05T18:33:43 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c7e6b3b343e8...50591f6ec61b
4002019-11-05T18:33:43 <bitcoin-git> bitcoin/master 85a34b1 practicalswift: tests: Move CaseInsensitiveEqual to test/util/str
4012019-11-05T18:33:44 <bitcoin-git> bitcoin/master b754170 practicalswift: tests: Add fuzzing harness for Bech32 encoding/decoding
4022019-11-05T18:33:44 <bitcoin-git> bitcoin/master 50591f6 MarcoFalke: Merge #17357: tests: Add fuzzing harness for Bech32 encoding/decoding
4032019-11-05T18:33:46 *** bitcoin-git has left #bitcoin-core-dev
4042019-11-05T18:33:46 <MarcoFalke> luke-jr: Why would you want to use goto when a one line C++ function can do the same?
4052019-11-05T18:35:54 <ariard> hey anyone willingly to exchange a review against one on #15931 ?
4062019-11-05T18:35:57 <gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard · Pull Request #15931 · bitcoin/bitcoin · GitHub
4072019-11-05T18:36:32 *** bitcoin-git has joined #bitcoin-core-dev
4082019-11-05T18:36:33 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/50591f6ec61b...22e7eea629e2
4092019-11-05T18:36:34 <bitcoin-git> bitcoin/master b2ff500 Sebastian Falbesoner: test: add "diamond" unit test to MempoolAncestryTests
4102019-11-05T18:36:35 <bitcoin-git> bitcoin/master 22e7eea MarcoFalke: Merge #17363: test: add "diamond" unit test to MempoolAncestryTests
4112019-11-05T18:36:37 *** bitcoin-git has left #bitcoin-core-dev
4122019-11-05T18:37:37 *** bitcoin-git has joined #bitcoin-core-dev
4132019-11-05T18:37:37 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22e7eea629e2...d35b12107e9e
4142019-11-05T18:37:38 <bitcoin-git> bitcoin/master 104f7de tryphe: remove old bootstrap relevant code
4152019-11-05T18:37:39 <bitcoin-git> bitcoin/master d35b121 Wladimir J. van der Laan: Merge #17044: init: Remove auto-import of `bootstrap.dat` and associated c...
4162019-11-05T18:37:40 *** bitcoin-git has left #bitcoin-core-dev
4172019-11-05T18:38:56 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4182019-11-05T18:41:25 *** bitcoin-git has joined #bitcoin-core-dev
4192019-11-05T18:41:25 <bitcoin-git> [bitcoin] laanwj merged pull request #16899: UTXO snapshot creation (dumptxoutset) (master...2019-09-au-dumptxoutset) https://github.com/bitcoin/bitcoin/pull/16899
4202019-11-05T18:41:26 *** bitcoin-git has left #bitcoin-core-dev
4212019-11-05T18:43:49 *** bitcoin-git has joined #bitcoin-core-dev
4222019-11-05T18:43:50 <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/d35b12107e9e...b05b28183c0a
4232019-11-05T18:43:51 <bitcoin-git> bitcoin/master 707fde7 James O'Beirne: add unused SnapshotMetadata class
4242019-11-05T18:43:52 <bitcoin-git> bitcoin/master 92fafb3 James O'Beirne: coinstats: add coins_count
4252019-11-05T18:43:52 <bitcoin-git> bitcoin/master 57cf74c James O'Beirne: rpc: add dumptxoutset
4262019-11-05T18:43:54 *** bitcoin-git has left #bitcoin-core-dev
4272019-11-05T18:44:14 *** kevvkaww has joined #bitcoin-core-dev
4282019-11-05T18:46:36 *** soju has joined #bitcoin-core-dev
4292019-11-05T18:46:47 <luke-jr> MarcoFalke: but UniValue is an upstream dependency, not Bitcoin Core; it shouldn't be bundled at all
4302019-11-05T18:47:34 <MarcoFalke> I feel like this was discussed in the past already
4312019-11-05T18:47:51 <luke-jr> I bet libevent has gotos ;)
4322019-11-05T18:50:18 *** soju has quit IRC
4332019-11-05T18:50:33 *** Zenton has quit IRC
4342019-11-05T18:50:46 <wumpus> gotos in C make a lot of sense, not in C++
4352019-11-05T18:51:08 <wumpus> in C it's often the only sane way to do error handling, this is even used in projects such as the kernel and mesa
4362019-11-05T18:51:45 <sipa> and in C++ they're often unable to be used for that even, because they can't jump over the initializers of new variables
4372019-11-05T18:52:12 <wumpus> modern C++ has no use for them
4382019-11-05T18:52:14 <wumpus> right sipa
4392019-11-05T18:54:00 *** pinheadmz has quit IRC
4402019-11-05T18:56:15 *** pinheadmz has joined #bitcoin-core-dev
4412019-11-05T18:56:16 <jonatack> ariard: i plan to finish review of #15931 tomorrow or thursday latest
4422019-11-05T18:56:19 <gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard · Pull Request #15931 · bitcoin/bitcoin · GitHub
4432019-11-05T18:57:43 *** kevvkaww has quit IRC
4442019-11-05T18:58:35 *** reallll has joined #bitcoin-core-dev
4452019-11-05T19:00:05 *** pinheadmz has quit IRC
4462019-11-05T19:02:32 *** belcher has quit IRC
4472019-11-05T19:04:14 *** ddustin has joined #bitcoin-core-dev
4482019-11-05T19:05:25 *** ddustin has quit IRC
4492019-11-05T19:06:04 *** ddustin has joined #bitcoin-core-dev
4502019-11-05T19:09:32 *** bitcoin-git has joined #bitcoin-core-dev
4512019-11-05T19:09:32 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17382: rpc: Remove unused boost::this_thread::interruption_point (master...1911-noBoostThreadInt) https://github.com/bitcoin/bitcoin/pull/17382
4522019-11-05T19:09:33 *** bitcoin-git has left #bitcoin-core-dev
4532019-11-05T19:09:45 *** pinheadmz has joined #bitcoin-core-dev
4542019-11-05T19:10:06 *** ddustin has quit IRC
4552019-11-05T19:12:27 *** DeanGuss has quit IRC
4562019-11-05T19:16:56 *** jpe_ has quit IRC
4572019-11-05T19:23:50 *** michaelfolkson has joined #bitcoin-core-dev
4582019-11-05T19:26:21 *** laptop500 has joined #bitcoin-core-dev
4592019-11-05T19:27:06 *** reallll is now known as belcher
4602019-11-05T19:29:32 *** soju has joined #bitcoin-core-dev
4612019-11-05T19:36:22 *** bitcoin-git has joined #bitcoin-core-dev
4622019-11-05T19:36:23 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b05b28183c0a...fea532a5f20c
4632019-11-05T19:36:23 <bitcoin-git> bitcoin/master fa1936f MarcoFalke: logging: Add member for arbitrary print callbacks
4642019-11-05T19:36:24 <bitcoin-git> bitcoin/master fa2c44c MarcoFalke: test: Add ASSERT_DEBUG_LOG to unit test framework
4652019-11-05T19:36:24 <bitcoin-git> bitcoin/master fea532a MarcoFalke: Merge #16540: test: Add ASSERT_DEBUG_LOG to unit test framework
4662019-11-05T19:36:26 *** bitcoin-git has left #bitcoin-core-dev
4672019-11-05T19:37:02 *** bitcoin-git has joined #bitcoin-core-dev
4682019-11-05T19:37:03 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16540: test: Add ASSERT_DEBUG_LOG to unit test framework (master...1908-UnitTestAssertDebugLog) https://github.com/bitcoin/bitcoin/pull/16540
4692019-11-05T19:37:04 *** bitcoin-git has left #bitcoin-core-dev
4702019-11-05T19:42:04 *** mdunnio has quit IRC
4712019-11-05T19:42:44 *** nijynot has joined #bitcoin-core-dev
4722019-11-05T19:43:15 *** bitcoin-git has joined #bitcoin-core-dev
4732019-11-05T19:43:15 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fea532a5f20c...d9a45500018f
4742019-11-05T19:43:16 <bitcoin-git> bitcoin/master 1c26c16 Danny-Scott: Improve "Hide" button tool-tip message
4752019-11-05T19:43:16 <bitcoin-git> bitcoin/master d9a4550 Wladimir J. van der Laan: Merge #17360: gui: Improve "Hide" button tool-tip message
4762019-11-05T19:43:26 *** bitcoin-git has left #bitcoin-core-dev
4772019-11-05T19:43:45 *** bitcoin-git has joined #bitcoin-core-dev
4782019-11-05T19:43:45 <bitcoin-git> [bitcoin] laanwj merged pull request #17360: gui: Improve "Hide" button tool-tip message (master...nov-2019-hide-button-tool-tip) https://github.com/bitcoin/bitcoin/pull/17360
4792019-11-05T19:43:50 *** bitcoin-git has left #bitcoin-core-dev
4802019-11-05T19:44:59 *** michaelfolkson has quit IRC
4812019-11-05T19:46:02 *** michaelfolkson has joined #bitcoin-core-dev
4822019-11-05T19:46:59 *** michaelfolkson has quit IRC
4832019-11-05T19:49:20 *** sdaftuar has joined #bitcoin-core-dev
4842019-11-05T19:49:37 *** mdunnio has joined #bitcoin-core-dev
4852019-11-05T19:50:56 *** mdunnio has quit IRC
4862019-11-05T19:51:34 *** mdunnio has joined #bitcoin-core-dev
4872019-11-05T19:55:14 *** Skirmant has joined #bitcoin-core-dev
4882019-11-05T19:55:56 *** mmgen has quit IRC
4892019-11-05T19:57:26 *** pinheadmz has quit IRC
4902019-11-05T20:01:08 *** jarthur_ has joined #bitcoin-core-dev
4912019-11-05T20:03:57 *** jarthur has quit IRC
4922019-11-05T20:03:59 *** jarthur_ is now known as jarthur
4932019-11-05T20:12:59 *** bitcoin-git has joined #bitcoin-core-dev
4942019-11-05T20:12:59 <bitcoin-git> [bitcoin] jnewbery opened pull request #17383: Refactor: Move consts to their correct translation units (master...2019-11-net-processing-consts) https://github.com/bitcoin/bitcoin/pull/17383
4952019-11-05T20:13:02 *** bitcoin-git has left #bitcoin-core-dev
4962019-11-05T20:16:19 *** ddustin has joined #bitcoin-core-dev
4972019-11-05T20:17:56 *** EagleTM has joined #bitcoin-core-dev
4982019-11-05T20:22:01 *** Skirmant has quit IRC
4992019-11-05T20:29:50 *** bitcoin-git has joined #bitcoin-core-dev
5002019-11-05T20:29:50 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17384: test: Create new test library (master...1911-testLib) https://github.com/bitcoin/bitcoin/pull/17384
5012019-11-05T20:29:51 *** bitcoin-git has left #bitcoin-core-dev
5022019-11-05T20:33:38 *** laptop500 has quit IRC
5032019-11-05T20:34:22 *** andytoshi has quit IRC
5042019-11-05T20:36:20 *** jonatack has quit IRC
5052019-11-05T20:37:22 *** owowo has quit IRC
5062019-11-05T20:39:03 *** nijynot has quit IRC
5072019-11-05T20:39:04 *** Zenton has joined #bitcoin-core-dev
5082019-11-05T20:41:57 *** owowo has joined #bitcoin-core-dev
5092019-11-05T20:42:54 *** Zenton has quit IRC
5102019-11-05T20:43:14 *** Zenton has joined #bitcoin-core-dev
5112019-11-05T20:43:47 *** bitcoin-git has joined #bitcoin-core-dev
5122019-11-05T20:43:47 <bitcoin-git> [bitcoin] laanwj opened pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
5132019-11-05T20:43:48 *** bitcoin-git has left #bitcoin-core-dev
5142019-11-05T20:47:11 *** Zenton has quit IRC
5152019-11-05T20:47:51 *** Zenton has joined #bitcoin-core-dev
5162019-11-05T20:51:44 *** Zenton has quit IRC
5172019-11-05T20:52:27 *** Zenton has joined #bitcoin-core-dev
5182019-11-05T20:53:10 *** ddustin has quit IRC
5192019-11-05T20:54:44 *** andytoshi has joined #bitcoin-core-dev
5202019-11-05T20:56:44 *** Zenton has quit IRC
5212019-11-05T20:57:04 *** Zenton has joined #bitcoin-core-dev
5222019-11-05T21:00:01 *** nickr has quit IRC
5232019-11-05T21:01:06 *** jonatack has joined #bitcoin-core-dev
5242019-11-05T21:01:06 *** Zenton has quit IRC
5252019-11-05T21:01:37 *** Zenton has joined #bitcoin-core-dev
5262019-11-05T21:04:21 *** jarthur has quit IRC
5272019-11-05T21:04:57 *** jarthur has joined #bitcoin-core-dev
5282019-11-05T21:08:17 *** ddustin has joined #bitcoin-core-dev
5292019-11-05T21:08:46 *** soju has quit IRC
5302019-11-05T21:09:56 *** diogosergio has quit IRC
5312019-11-05T21:10:16 *** diogosergio has joined #bitcoin-core-dev
5322019-11-05T21:13:11 *** ddustin has quit IRC
5332019-11-05T21:15:26 *** DeanGuss has joined #bitcoin-core-dev
5342019-11-05T21:17:20 *** laxanofido has joined #bitcoin-core-dev
5352019-11-05T21:19:55 *** Zenton has quit IRC
5362019-11-05T21:20:17 *** Zenton has joined #bitcoin-core-dev
5372019-11-05T21:28:09 *** ddustin has joined #bitcoin-core-dev
5382019-11-05T21:38:32 *** Zenton has quit IRC
5392019-11-05T21:38:38 *** Highway61 has joined #bitcoin-core-dev
5402019-11-05T21:38:52 *** Zenton has joined #bitcoin-core-dev
5412019-11-05T21:39:54 *** nijynot has joined #bitcoin-core-dev
5422019-11-05T21:40:17 <meshcollider> ariard: it's on my list to review that this week too :)
5432019-11-05T21:40:41 <wumpus> do we support -notestnet=1 and -noregtest=1 as arguments? I've never seen this before
5442019-11-05T21:40:48 <wumpus> re: https://github.com/bitcoin/bitcoin/pull/17385#issuecomment-550033222
5452019-11-05T21:40:56 <wumpus> it does some really strange things
5462019-11-05T21:41:11 <wumpus> apparently we're testing for this but why?
5472019-11-05T21:41:16 *** laptop500 has joined #bitcoin-core-dev
5482019-11-05T21:41:32 <meshcollider> I didnt think we were allowed to combine "no" with =
5492019-11-05T21:41:48 <wumpus> same
5502019-11-05T21:42:05 <wumpus> I'll remove the =1
5512019-11-05T21:43:17 *** kristapsk has quit IRC
5522019-11-05T21:43:30 <luke-jr> = is necessary in the config file
5532019-11-05T21:43:46 <wumpus> noX is not allowed in the config file
5542019-11-05T21:44:48 *** Highway61 has quit IRC
5552019-11-05T21:44:52 <luke-jr> oh
5562019-11-05T21:44:59 <wumpus> but you're right, it's used with ReadConfigStream
5572019-11-05T21:45:13 <luke-jr> bigger question IMO is how we get to 1testnet=1
5582019-11-05T21:45:36 <luke-jr> that's kind of crazy :P
5592019-11-05T21:45:46 <wumpus> it is
5602019-11-05T21:46:27 <wumpus> this happens to work for atoi because it stops parsing at the first non-digit :')
5612019-11-05T21:47:17 <wumpus> relying on that turn of events is kind of bizarre
5622019-11-05T21:48:04 *** Zenton has quit IRC
5632019-11-05T21:48:28 *** Zenton has joined #bitcoin-core-dev
5642019-11-05T21:51:21 <achow101> anyone want to have a discussion about IsMine (and it's weird behaviors)?
5652019-11-05T21:51:40 * luke-jr suggests replacing it with `return true` /s
5662019-11-05T21:52:25 *** nijynot has quit IRC
5672019-11-05T21:52:34 <instagibbs> achow101, no.
5682019-11-05T21:53:02 *** Zenton has quit IRC
5692019-11-05T21:53:35 *** Zenton has joined #bitcoin-core-dev
5702019-11-05T21:53:37 <achow101> alright then
5712019-11-05T21:53:57 <instagibbs> seriously tho, anything newly weird
5722019-11-05T21:54:23 <achow101> https://github.com/bitcoin/bitcoin/pull/17374#issuecomment-550036931
5732019-11-05T21:55:21 <achow101> The main weird thing was this inconsistency I just noticed where you could import a wpkh() descriptor and still get metadata for the legacy address that shares the same pubkey with it, but that legacy address is ismine_no
5742019-11-05T21:55:57 <instagibbs> that's fun
5752019-11-05T21:56:18 <achow101> and I don't think we can/should retain this behavior in ScriptPubKeyMan, but that's also a breaking change
5762019-11-05T21:56:33 <wumpus> I'm tempted to just drop that commit
5772019-11-05T21:58:28 <wumpus> ryanofsky: testnet=0 is fine, notestnet=1 is not
5782019-11-05T21:58:48 <wumpus> it's the double negation that messes things up
5792019-11-05T21:58:52 <instagibbs> achow101, this is only for pkh detection?
5802019-11-05T21:59:33 <achow101> maybe?
5812019-11-05T21:59:51 <ryanofsky> wumpus, feel free to drop the commit, i can follow up later if needed. anyway i'm going to debug
5822019-11-05T22:00:11 <achow101> probably. I think it might not detect some more esoteric stuff like p2pkh inside of p2sh
5832019-11-05T22:00:29 <instagibbs> right, nested checks
5842019-11-05T22:00:30 <ryanofsky> to be sure though, -notestnet=1 is not double negation, that's just single negation
5852019-11-05T22:01:15 <wumpus> ryanofsky: there's no hurry but if people really insist on keeping the current crazy behavior I'm not going to argue :)
5862019-11-05T22:01:16 <instagibbs> to be clear, you're saying 17374 is a breaking change
5872019-11-05T22:01:46 <achow101> yes. and so is the final ScriptPubKeyMan refactor
5882019-11-05T22:01:46 *** Zenton has quit IRC
5892019-11-05T22:01:48 <wumpus> ryanofsky: right, notestnet=0 would be a double negation
5902019-11-05T22:02:04 *** ddustin_ has joined #bitcoin-core-dev
5912019-11-05T22:02:13 *** Zenton has joined #bitcoin-core-dev
5922019-11-05T22:02:54 <wumpus> I remember support for that was dropped at some point, notestnet=1 probably should just ignore the parameter
5932019-11-05T22:03:02 <instagibbs> achow101, I find this corner case very surprising from our dumb ismine current wallet fwiw
5942019-11-05T22:03:03 <achow101> instagibbs: well breaking in different ways. 17374 is breaking by changing ismine behavior to allow more things. scriptpubkeyman pr would be break getaddressinfo behavior without 17374
5952019-11-05T22:03:25 <instagibbs> ok im just considering 17374.
5962019-11-05T22:03:39 *** ddustin has quit IRC
5972019-11-05T22:05:10 <sipa> achow101: i don't think losing signingprovider info for non-ismine things is a big problem
5982019-11-05T22:05:36 <sipa> worth a mention in release notes
5992019-11-05T22:07:20 <achow101> sipa: right, I'm leaning that way too. the thing that confused me was that we have a few tests that rely on that behavior, probably on accident
6002019-11-05T22:09:06 <wumpus> hehe
6012019-11-05T22:10:16 *** Zenton has quit IRC
6022019-11-05T22:10:23 <instagibbs> ack
6032019-11-05T22:10:44 <wumpus> ryanofsky: looking at it, it's very possible that that test is broken and not the argumet parsing in general
6042019-11-05T22:10:47 *** Zenton has joined #bitcoin-core-dev
6052019-11-05T22:11:52 <ryanofsky> yes, it looks like the multiple config entries created by the test are stuck together
6062019-11-05T22:12:19 <wumpus> right
6072019-11-05T22:13:47 *** bitcoin-git has joined #bitcoin-core-dev
6082019-11-05T22:13:47 <bitcoin-git> [bitcoin] achow101 closed pull request #17374: IsMine: Set state to WATCH_ONLY if we can get the pubkey (master...wallet-box-pr-7) https://github.com/bitcoin/bitcoin/pull/17374
6092019-11-05T22:13:49 *** bitcoin-git has left #bitcoin-core-dev
6102019-11-05T22:14:33 <wumpus> it's not the most easy to understand code
6112019-11-05T22:14:46 *** Guyver2 has quit IRC
6122019-11-05T22:17:48 *** b10c has quit IRC
6132019-11-05T22:18:43 *** bitcoin-git has joined #bitcoin-core-dev
6142019-11-05T22:18:44 <bitcoin-git> [bitcoin] Empact opened pull request #17386: [moveonly] Extract CWallet::CompactDatabase (master...get-db-handle) https://github.com/bitcoin/bitcoin/pull/17386
6152019-11-05T22:18:45 *** bitcoin-git has left #bitcoin-core-dev
6162019-11-05T22:19:21 *** Zenton has quit IRC
6172019-11-05T22:19:33 <wumpus> like using "desc += argstr + 1;" to add to a string, yes you can write C++ code like that, but...
6182019-11-05T22:19:57 *** Zenton has joined #bitcoin-core-dev
6192019-11-05T22:20:12 <luke-jr> lol
6202019-11-05T22:21:32 *** bitcoin-git has joined #bitcoin-core-dev
6212019-11-05T22:21:33 <bitcoin-git> [bitcoin] achow101 opened pull request #17387: wallet_importmulti: use addresses of the same type as being imported (master...tests-fix-getaddrinfo-type-consistency) https://github.com/bitcoin/bitcoin/pull/17387
6222019-11-05T22:21:33 *** bitcoin-git has left #bitcoin-core-dev
6232019-11-05T22:23:23 <wumpus> so I *think* the idea would be to add a new line in between there
6242019-11-05T22:23:38 *** Zenton has quit IRC
6252019-11-05T22:24:03 *** Zenton has joined #bitcoin-core-dev
6262019-11-05T22:25:52 <wumpus> yeh adding conf += "\n"; at the end of that loop stops the 1testnet=1 problem
6272019-11-05T22:26:29 <wumpus> but it causes the test to fail, likely because of a wrong expectation
6282019-11-05T22:27:34 <wumpus> at least it fails in the same way with and without my patch after that :-)
6292019-11-05T22:27:34 *** michaelfolkson has joined #bitcoin-core-dev
6302019-11-05T22:28:01 <ryanofsky> thanks, yeah, pushing a pr in a minute or two, it's unrelated to your pr
6312019-11-05T22:28:52 *** diogosergio has quit IRC
6322019-11-05T22:29:12 <wumpus> -regtest=0 -noregtest=1 testnet=1 regtest=1 || test -> error: Invalid combination of -regtest, -testnet and -chain. Can use at most one.
6332019-11-05T22:29:19 <wumpus> definitely better
6342019-11-05T22:30:01 <wumpus> I don't think anyone reviewed the previous test output ever
6352019-11-05T22:31:05 <wumpus> thanks
6362019-11-05T22:31:33 *** bitcoin-git has joined #bitcoin-core-dev
6372019-11-05T22:31:33 <bitcoin-git> [bitcoin] ryanofsky opened pull request #17388: Add missing newline in util_ChainMerge test (master...pr/chainmerge-nl) https://github.com/bitcoin/bitcoin/pull/17388
6382019-11-05T22:31:34 *** bitcoin-git has left #bitcoin-core-dev
6392019-11-05T22:36:28 *** Zenton has quit IRC
6402019-11-05T22:37:08 *** Zenton has joined #bitcoin-core-dev
6412019-11-05T22:37:21 *** Emcy has quit IRC
6422019-11-05T22:39:47 *** kristapsk has joined #bitcoin-core-dev
6432019-11-05T22:40:51 *** Chris_Stewart_5 has quit IRC
6442019-11-05T22:42:19 <meshcollider> achow101: what kind of tests rely on that behaviour?
6452019-11-05T22:42:43 <achow101> the importmulti ones
6462019-11-05T22:43:18 <achow101> trivial to make them not rely on it, see the pr I just opened
6472019-11-05T22:43:28 <meshcollider> Ok
6482019-11-05T22:45:26 *** Zenton has quit IRC
6492019-11-05T22:45:44 *** Zenton has joined #bitcoin-core-dev
6502019-11-05T22:46:02 *** bitcoin-git has joined #bitcoin-core-dev
6512019-11-05T22:46:03 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d9a45500018f...40b6070ad7e8
6522019-11-05T22:46:04 <bitcoin-git> bitcoin/master 41edaf2 James O'Beirne: logs: add BCLog::Timer and related macros
6532019-11-05T22:46:05 <bitcoin-git> bitcoin/master dcef9a2 James O'Beirne: logs: add timing information to FlushStateToDisk()
6542019-11-05T22:46:05 <bitcoin-git> bitcoin/master 40b6070 Wladimir J. van der Laan: Merge #16805: logs: add timing information to FlushStateToDisk()
6552019-11-05T22:46:07 *** bitcoin-git has left #bitcoin-core-dev
6562019-11-05T22:46:27 *** bitcoin-git has joined #bitcoin-core-dev
6572019-11-05T22:46:27 <bitcoin-git> [bitcoin] laanwj merged pull request #16805: logs: add timing information to FlushStateToDisk() (master...2019-09-flush-logs) https://github.com/bitcoin/bitcoin/pull/16805
6582019-11-05T22:46:28 *** bitcoin-git has left #bitcoin-core-dev
6592019-11-05T22:59:29 *** nosss2 has quit IRC
6602019-11-05T23:04:02 *** jarthur has quit IRC
6612019-11-05T23:04:15 *** mdunnio has quit IRC
6622019-11-05T23:04:21 *** Emcy has joined #bitcoin-core-dev
6632019-11-05T23:05:17 *** bitcoin-git has joined #bitcoin-core-dev
6642019-11-05T23:05:17 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/40b6070ad7e8...45e65376ac9e
6652019-11-05T23:05:18 <bitcoin-git> bitcoin/master fa5facd MarcoFalke: rpc: Remove unused boost::this_thread::interruption_point
6662019-11-05T23:05:18 <bitcoin-git> bitcoin/master 45e6537 Wladimir J. van der Laan: Merge #17382: rpc: Remove unused boost::this_thread::interruption_point
6672019-11-05T23:05:20 *** bitcoin-git has left #bitcoin-core-dev
6682019-11-05T23:05:37 *** bitcoin-git has joined #bitcoin-core-dev
6692019-11-05T23:05:37 <bitcoin-git> [bitcoin] laanwj merged pull request #17382: rpc: Remove unused boost::this_thread::interruption_point (master...1911-noBoostThreadInt) https://github.com/bitcoin/bitcoin/pull/17382
6702019-11-05T23:05:39 *** bitcoin-git has left #bitcoin-core-dev
6712019-11-05T23:10:17 *** Zenton has quit IRC
6722019-11-05T23:10:51 *** marcoagner has quit IRC
6732019-11-05T23:10:53 *** Zenton has joined #bitcoin-core-dev
6742019-11-05T23:15:00 *** ddustin has joined #bitcoin-core-dev
6752019-11-05T23:16:08 *** laptop500 has quit IRC
6762019-11-05T23:16:23 *** Emcy has quit IRC
6772019-11-05T23:17:33 *** ddustin_ has quit IRC
6782019-11-05T23:17:49 *** ddustin_ has joined #bitcoin-core-dev
6792019-11-05T23:20:22 *** bitcoin-git has joined #bitcoin-core-dev
6802019-11-05T23:20:22 <bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17389: build: add background.tiff and .pngs to "make clean" (master...make-clean-tiff) https://github.com/bitcoin/bitcoin/pull/17389
6812019-11-05T23:20:23 *** bitcoin-git has left #bitcoin-core-dev
6822019-11-05T23:21:08 *** ddustin has quit IRC
6832019-11-05T23:26:08 *** Zenton has quit IRC
6842019-11-05T23:26:32 *** Zenton has joined #bitcoin-core-dev
6852019-11-05T23:29:44 *** Zenton has quit IRC
6862019-11-05T23:30:11 *** Zenton has joined #bitcoin-core-dev
6872019-11-05T23:31:24 *** ddustin_ has quit IRC
6882019-11-05T23:33:56 *** Zenton has quit IRC
6892019-11-05T23:34:16 *** Zenton has joined #bitcoin-core-dev
6902019-11-05T23:36:13 *** Highway61 has joined #bitcoin-core-dev
6912019-11-05T23:38:44 <wumpus> it's pretty strange to have a one-time boost::interruption point at the beginning of BerkeleyEnvironment::Open and BerkeleyEnvironment::BerkeleyEnvironment, seems like something the caller could handle if needed
6922019-11-05T23:39:15 <wumpus> these are meant for being able to interrupt long-running operations
6932019-11-05T23:44:34 *** Victor_sueca has joined #bitcoin-core-dev
6942019-11-05T23:44:48 *** Zenton has quit IRC
6952019-11-05T23:45:22 *** Zenton has joined #bitcoin-core-dev
6962019-11-05T23:47:07 *** Victorsueca has quit IRC
6972019-11-05T23:50:31 *** pinheadmz has joined #bitcoin-core-dev
6982019-11-05T23:52:18 *** Emcy has joined #bitcoin-core-dev
6992019-11-05T23:54:15 *** bitcoin-git has joined #bitcoin-core-dev
7002019-11-05T23:54:15 <bitcoin-git> [bitcoin] ryanofsky opened pull request #17390: Add util_ArgParsing test (master...pr/argparse-test) https://github.com/bitcoin/bitcoin/pull/17390
7012019-11-05T23:54:16 *** bitcoin-git has left #bitcoin-core-dev
7022019-11-05T23:54:28 *** jonatack has quit IRC