1 2019-11-05T00:00:01  *** Bille has quit IRC
  2 2019-11-05T00:00:02  *** ghost43_ is now known as ghost43
  3 2019-11-05T00:00:42  *** Zenton has quit IRC
  4 2019-11-05T00:12:46  *** millerti has quit IRC
  5 2019-11-05T00:17:44  *** SLNP has joined #bitcoin-core-dev
  6 2019-11-05T00:19:01  *** mariorz has quit IRC
  7 2019-11-05T00:20:29  *** TTT has quit IRC
  8 2019-11-05T00:24:16  *** mariorz has joined #bitcoin-core-dev
  9 2019-11-05T00:26:37  *** Chris_Stewart_5 has quit IRC
 10 2019-11-05T00:30:48  *** bitcoin-git has joined #bitcoin-core-dev
 11 2019-11-05T00:30:48  <bitcoin-git> [bitcoin] JeremyRubin opened pull request #17375: Add asymptotes for benchmarking framework (master...asymptotic-benchmarks) https://github.com/bitcoin/bitcoin/pull/17375
 12 2019-11-05T00:30:49  *** bitcoin-git has left #bitcoin-core-dev
 13 2019-11-05T00:45:57  *** cryptoIndio has joined #bitcoin-core-dev
 14 2019-11-05T00:46:01  *** goatpig_ has quit IRC
 15 2019-11-05T00:48:54  *** mariorz has quit IRC
 16 2019-11-05T00:54:19  *** mariorz has joined #bitcoin-core-dev
 17 2019-11-05T00:58:37  *** goatpig_ has joined #bitcoin-core-dev
 18 2019-11-05T01:04:27  *** goatpig_ has quit IRC
 19 2019-11-05T01:07:00  *** goatpig_ has joined #bitcoin-core-dev
 20 2019-11-05T01:14:09  *** justanotheruser has joined #bitcoin-core-dev
 21 2019-11-05T01:27:59  *** ddustin_ has quit IRC
 22 2019-11-05T01:28:37  *** ddustin has joined #bitcoin-core-dev
 23 2019-11-05T01:33:19  *** ddustin has quit IRC
 24 2019-11-05T01:41:28  *** cryptoIndio has quit IRC
 25 2019-11-05T01:41:43  *** cryptoIndio has joined #bitcoin-core-dev
 26 2019-11-05T01:48:40  *** Highway61 has joined #bitcoin-core-dev
 27 2019-11-05T01:48:44  *** mariorz has quit IRC
 28 2019-11-05T01:54:27  *** mariorz has joined #bitcoin-core-dev
 29 2019-11-05T01:56:04  *** wsm has quit IRC
 30 2019-11-05T02:02:43  *** wsm has joined #bitcoin-core-dev
 31 2019-11-05T02:05:56  *** soju has quit IRC
 32 2019-11-05T02:09:10  *** jarthur has joined #bitcoin-core-dev
 33 2019-11-05T02:13:35  *** arik_ has quit IRC
 34 2019-11-05T02:16:31  *** jpe_ has joined #bitcoin-core-dev
 35 2019-11-05T02:19:15  *** jpe has quit IRC
 36 2019-11-05T02:37:27  *** nosss2 has quit IRC
 37 2019-11-05T02:48:50  *** mariorz has quit IRC
 38 2019-11-05T02:49:35  *** ddustin has joined #bitcoin-core-dev
 39 2019-11-05T02:51:29  *** lightlike has quit IRC
 40 2019-11-05T02:53:55  *** mariorz has joined #bitcoin-core-dev
 41 2019-11-05T03:00:01  *** SLNP has quit IRC
 42 2019-11-05T03:05:15  *** nosss2 has joined #bitcoin-core-dev
 43 2019-11-05T03:05:30  *** justanotheruser has quit IRC
 44 2019-11-05T03:06:11  *** emilengler_ has joined #bitcoin-core-dev
 45 2019-11-05T03:08:02  *** emilengler has quit IRC
 46 2019-11-05T03:08:52  <luke-jr> MarcoFalke: https://github.com/bitcoin/bips/pull/856#issuecomment-549629459 :P
 47 2019-11-05T03:15:21  *** felixfoertsch23 has joined #bitcoin-core-dev
 48 2019-11-05T03:15:29  *** felixfoertsch has quit IRC
 49 2019-11-05T03:17:48  *** feedoo1 has joined #bitcoin-core-dev
 50 2019-11-05T03:24:02  *** justanotheruser has joined #bitcoin-core-dev
 51 2019-11-05T03:30:02  *** justanotheruser has quit IRC
 52 2019-11-05T03:34:45  *** harrigan has quit IRC
 53 2019-11-05T03:35:40  *** harrigan has joined #bitcoin-core-dev
 54 2019-11-05T03:43:28  *** arik_ has joined #bitcoin-core-dev
 55 2019-11-05T03:43:57  *** Highway61 has quit IRC
 56 2019-11-05T03:46:42  *** nosss2 has quit IRC
 57 2019-11-05T03:50:33  *** arik_ has quit IRC
 58 2019-11-05T04:02:38  *** justanotheruser has joined #bitcoin-core-dev
 59 2019-11-05T04:06:01  *** nosss2 has joined #bitcoin-core-dev
 60 2019-11-05T04:11:51  *** justanotheruser has quit IRC
 61 2019-11-05T04:21:38  *** pinheadmz has quit IRC
 62 2019-11-05T04:21:51  *** Eagle[TM] has joined #bitcoin-core-dev
 63 2019-11-05T04:23:56  *** EagleTM has quit IRC
 64 2019-11-05T04:34:34  *** IGHOR has quit IRC
 65 2019-11-05T04:37:30  *** justanotheruser has joined #bitcoin-core-dev
 66 2019-11-05T04:49:33  *** justanotheruser has quit IRC
 67 2019-11-05T04:59:22  *** justanotheruser has joined #bitcoin-core-dev
 68 2019-11-05T05:11:28  *** bitcoin-git has joined #bitcoin-core-dev
 69 2019-11-05T05:11:28  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #17376: Add Parallel P2P Client in Rust (master...2019-10-rusty-p2p) https://github.com/bitcoin/bitcoin/pull/17376
 70 2019-11-05T05:11:30  *** bitcoin-git has left #bitcoin-core-dev
 71 2019-11-05T05:46:02  *** arik_ has joined #bitcoin-core-dev
 72 2019-11-05T05:48:45  *** mariorz has quit IRC
 73 2019-11-05T05:49:03  *** mariorz has joined #bitcoin-core-dev
 74 2019-11-05T05:50:29  *** cryptoIn_ has joined #bitcoin-core-dev
 75 2019-11-05T05:50:29  *** cryptoIndio has quit IRC
 76 2019-11-05T06:00:01  *** feedoo1 has quit IRC
 77 2019-11-05T06:04:47  *** Emcy has quit IRC
 78 2019-11-05T06:05:25  *** nosss2 has quit IRC
 79 2019-11-05T06:07:58  *** arik_ has quit IRC
 80 2019-11-05T06:08:38  *** nosss2 has joined #bitcoin-core-dev
 81 2019-11-05T06:10:12  *** Giszmo has joined #bitcoin-core-dev
 82 2019-11-05T06:12:21  *** Emcy has joined #bitcoin-core-dev
 83 2019-11-05T06:13:10  *** nosss2 has quit IRC
 84 2019-11-05T06:17:15  *** ericbsd has joined #bitcoin-core-dev
 85 2019-11-05T06:28:38  *** ddustin_ has joined #bitcoin-core-dev
 86 2019-11-05T06:30:57  *** Dean_Guss has quit IRC
 87 2019-11-05T06:31:23  *** Dean_Guss has joined #bitcoin-core-dev
 88 2019-11-05T06:31:52  *** ddustin has quit IRC
 89 2019-11-05T06:33:03  *** nosss2 has joined #bitcoin-core-dev
 90 2019-11-05T06:37:38  *** instagibbs has quit IRC
 91 2019-11-05T06:37:54  *** nosss2 has quit IRC
 92 2019-11-05T06:42:28  *** soju has joined #bitcoin-core-dev
 93 2019-11-05T06:43:06  *** nosss2 has joined #bitcoin-core-dev
 94 2019-11-05T06:47:53  *** soju has quit IRC
 95 2019-11-05T06:48:02  *** nosss2 has quit IRC
 96 2019-11-05T06:49:38  *** nosss2 has joined #bitcoin-core-dev
 97 2019-11-05T06:49:41  *** instagibbs has joined #bitcoin-core-dev
 98 2019-11-05T06:50:23  *** soju has joined #bitcoin-core-dev
 99 2019-11-05T06:53:49  *** nosss2 has quit IRC
100 2019-11-05T06:54:12  *** nosss2 has joined #bitcoin-core-dev
101 2019-11-05T06:58:37  *** nosss2 has quit IRC
102 2019-11-05T07:08:02  *** timothy has joined #bitcoin-core-dev
103 2019-11-05T07:08:36  *** cryptoIn_ has quit IRC
104 2019-11-05T07:12:26  *** nosss2 has joined #bitcoin-core-dev
105 2019-11-05T07:13:14  *** Victor_sueca is now known as Victorsueca
106 2019-11-05T07:14:50  *** Eagle[TM] has quit IRC
107 2019-11-05T07:16:50  *** nosss2 has quit IRC
108 2019-11-05T07:22:26  *** nosss2 has joined #bitcoin-core-dev
109 2019-11-05T07:27:14  *** nosss2 has quit IRC
110 2019-11-05T07:33:15  *** tiendo1011 has joined #bitcoin-core-dev
111 2019-11-05T07:33:36  *** nosss2 has joined #bitcoin-core-dev
112 2019-11-05T07:34:19  *** tiendo1011 has quit IRC
113 2019-11-05T07:38:20  *** nosss2 has quit IRC
114 2019-11-05T07:39:33  *** cryptoIndio has joined #bitcoin-core-dev
115 2019-11-05T07:44:23  *** soju has quit IRC
116 2019-11-05T07:44:57  *** cryptoIndio has quit IRC
117 2019-11-05T07:45:31  *** soju has joined #bitcoin-core-dev
118 2019-11-05T07:50:43  *** nosss2 has joined #bitcoin-core-dev
119 2019-11-05T07:50:45  *** soju has quit IRC
120 2019-11-05T07:55:06  *** nosss2 has quit IRC
121 2019-11-05T07:58:14  *** harrigan has quit IRC
122 2019-11-05T07:59:54  *** harrigan has joined #bitcoin-core-dev
123 2019-11-05T08:03:36  *** IGHOR has joined #bitcoin-core-dev
124 2019-11-05T08:03:36  *** cryptoIndio has joined #bitcoin-core-dev
125 2019-11-05T08:03:41  *** nosss2 has joined #bitcoin-core-dev
126 2019-11-05T08:04:03  *** IGHOR has quit IRC
127 2019-11-05T08:08:02  *** nosss2 has quit IRC
128 2019-11-05T08:17:34  *** nosss2 has joined #bitcoin-core-dev
129 2019-11-05T08:20:19  *** marcoagner has joined #bitcoin-core-dev
130 2019-11-05T08:21:37  *** justanotheruser has quit IRC
131 2019-11-05T08:24:09  *** nosss2 has quit IRC
132 2019-11-05T08:27:57  *** ddustin_ has quit IRC
133 2019-11-05T08:28:34  *** ddustin has joined #bitcoin-core-dev
134 2019-11-05T08:31:02  *** nosss2 has joined #bitcoin-core-dev
135 2019-11-05T08:33:03  *** ddustin has quit IRC
136 2019-11-05T08:35:18  *** nosss2 has quit IRC
137 2019-11-05T08:39:36  *** nijynot has joined #bitcoin-core-dev
138 2019-11-05T08:51:27  *** nosss2 has joined #bitcoin-core-dev
139 2019-11-05T08:55:37  *** nosss2 has quit IRC
140 2019-11-05T08:56:37  *** bitcoin-git has joined #bitcoin-core-dev
141 2019-11-05T08:56:38  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc38bb9a6036...bfc4c896d6d2
142 2019-11-05T08:56:38  <bitcoin-git> bitcoin/master 436ad43 Adam Jonas: Fix issue with conflicted mempool tx in listsinceblock
143 2019-11-05T08:56:39  <bitcoin-git> bitcoin/master bfc4c89 Samuel Dobson: Merge #17258: Fix issue with conflicted mempool tx in listsinceblock
144 2019-11-05T08:56:41  *** bitcoin-git has left #bitcoin-core-dev
145 2019-11-05T08:56:52  *** b10c has joined #bitcoin-core-dev
146 2019-11-05T08:56:57  *** bitcoin-git has joined #bitcoin-core-dev
147 2019-11-05T08:56:57  <bitcoin-git> [bitcoin] meshcollider merged pull request #17258: Fix issue with conflicted mempool tx in listsinceblock (master...listsinceblock-filter-conflicts) https://github.com/bitcoin/bitcoin/pull/17258
148 2019-11-05T08:56:59  *** bitcoin-git has left #bitcoin-core-dev
149 2019-11-05T08:59:08  *** bitcoin-git has joined #bitcoin-core-dev
150 2019-11-05T08:59:09  <bitcoin-git> [bitcoin] meshcollider pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/bfc4c896d6d2...bdda13787890
151 2019-11-05T08:59:09  <bitcoin-git> bitcoin/master dce032c Jeremy Rubin: Make IsTrusted scan parents recursively
152 2019-11-05T08:59:10  <bitcoin-git> bitcoin/master 595f09d Jeremy Rubin: Cache tx Trust per-call to avoid DoS
153 2019-11-05T08:59:10  <bitcoin-git> bitcoin/master 5dd7da4 Jeremy Rubin: Reuse trustedParents in looped calls to IsTrusted
154 2019-11-05T08:59:21  *** bitcoin-git has left #bitcoin-core-dev
155 2019-11-05T08:59:38  *** bitcoin-git has joined #bitcoin-core-dev
156 2019-11-05T08:59:39  <bitcoin-git> [bitcoin] meshcollider merged pull request #16766: wallet: Make IsTrusted scan parents recursively (master...recursive-istrusted) https://github.com/bitcoin/bitcoin/pull/16766
157 2019-11-05T08:59:39  *** bitcoin-git has left #bitcoin-core-dev
158 2019-11-05T09:00:02  *** ericbsd has quit IRC
159 2019-11-05T09:01:07  *** ddustin has joined #bitcoin-core-dev
160 2019-11-05T09:02:20  *** nijynot has quit IRC
161 2019-11-05T09:03:48  *** timothy has quit IRC
162 2019-11-05T09:04:45  *** nosss2 has joined #bitcoin-core-dev
163 2019-11-05T09:05:37  *** ddustin has quit IRC
164 2019-11-05T09:08:57  *** nosss2 has quit IRC
165 2019-11-05T09:09:10  *** timothy has joined #bitcoin-core-dev
166 2019-11-05T09:14:55  *** nosss2 has joined #bitcoin-core-dev
167 2019-11-05T09:17:56  *** vladan1 has joined #bitcoin-core-dev
168 2019-11-05T09:19:44  *** nosss2 has quit IRC
169 2019-11-05T09:20:21  *** jarthur has quit IRC
170 2019-11-05T09:29:24  *** jungly has quit IRC
171 2019-11-05T09:29:46  *** Zenton has joined #bitcoin-core-dev
172 2019-11-05T09:30:06  *** jungly has joined #bitcoin-core-dev
173 2019-11-05T09:35:11  *** nijynot has joined #bitcoin-core-dev
174 2019-11-05T09:42:58  *** nosss2 has joined #bitcoin-core-dev
175 2019-11-05T09:47:46  *** nosss2 has quit IRC
176 2019-11-05T09:49:02  *** rh0nj has quit IRC
177 2019-11-05T09:50:07  *** rh0nj has joined #bitcoin-core-dev
178 2019-11-05T09:51:02  *** rh0nj has quit IRC
179 2019-11-05T09:52:10  *** rh0nj has joined #bitcoin-core-dev
180 2019-11-05T09:57:32  *** nosss2 has joined #bitcoin-core-dev
181 2019-11-05T10:06:57  *** nosss2 has quit IRC
182 2019-11-05T10:14:12  *** nosss2 has joined #bitcoin-core-dev
183 2019-11-05T10:14:53  *** goatpig_ has quit IRC
184 2019-11-05T10:19:15  *** nosss2 has quit IRC
185 2019-11-05T10:25:46  *** diogosergio has joined #bitcoin-core-dev
186 2019-11-05T10:26:34  *** goatpig_ has joined #bitcoin-core-dev
187 2019-11-05T10:32:40  *** nosss2 has joined #bitcoin-core-dev
188 2019-11-05T10:36:58  *** felixfoertsch23 has quit IRC
189 2019-11-05T10:37:15  *** felixfoertsch has joined #bitcoin-core-dev
190 2019-11-05T10:37:29  *** nosss2 has quit IRC
191 2019-11-05T10:40:02  *** nosss2 has joined #bitcoin-core-dev
192 2019-11-05T10:44:02  *** nosss2 has quit IRC
193 2019-11-05T10:54:56  *** IGHOR has joined #bitcoin-core-dev
194 2019-11-05T10:55:31  *** IGHOR has quit IRC
195 2019-11-05T10:59:25  *** nosss2 has joined #bitcoin-core-dev
196 2019-11-05T11:03:37  *** nosss2 has quit IRC
197 2019-11-05T11:09:51  *** nosss2 has joined #bitcoin-core-dev
198 2019-11-05T11:12:20  *** afk11 has quit IRC
199 2019-11-05T11:12:56  *** afk11 has joined #bitcoin-core-dev
200 2019-11-05T11:19:07  *** nosss2 has quit IRC
201 2019-11-05T11:19:48  *** cryptoIndio has quit IRC
202 2019-11-05T11:21:35  *** IGHOR has joined #bitcoin-core-dev
203 2019-11-05T11:27:51  *** nosss2 has joined #bitcoin-core-dev
204 2019-11-05T11:31:28  *** lightlike has joined #bitcoin-core-dev
205 2019-11-05T11:32:23  *** nosss2 has quit IRC
206 2019-11-05T11:35:01  *** nosss2 has joined #bitcoin-core-dev
207 2019-11-05T11:39:21  *** emilengler_ has quit IRC
208 2019-11-05T11:39:27  *** nosss2 has quit IRC
209 2019-11-05T11:40:15  *** emilengler has joined #bitcoin-core-dev
210 2019-11-05T11:44:21  *** nosss2 has joined #bitcoin-core-dev
211 2019-11-05T11:44:52  *** felixfoertsch has quit IRC
212 2019-11-05T11:45:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
213 2019-11-05T11:46:10  *** felixfoertsch has joined #bitcoin-core-dev
214 2019-11-05T11:49:02  *** nosss2 has quit IRC
215 2019-11-05T12:00:01  *** vladan1 has quit IRC
216 2019-11-05T12:02:07  *** nosss2 has joined #bitcoin-core-dev
217 2019-11-05T12:06:47  *** nosss2 has quit IRC
218 2019-11-05T12:07:09  *** nosss2 has joined #bitcoin-core-dev
219 2019-11-05T12:12:08  *** nosss2 has quit IRC
220 2019-11-05T12:17:32  *** bitcoin-git has joined #bitcoin-core-dev
221 2019-11-05T12:17:33  <bitcoin-git> [bitcoin] theStack opened pull request #17377: wallet: remove unused variable spk_man in import* RPCs (master...20191105-refactor-remove_unused_variable_spkman) https://github.com/bitcoin/bitcoin/pull/17377
222 2019-11-05T12:17:34  *** bitcoin-git has left #bitcoin-core-dev
223 2019-11-05T12:17:52  *** kcomandich1 has joined #bitcoin-core-dev
224 2019-11-05T12:19:49  *** nosss2 has joined #bitcoin-core-dev
225 2019-11-05T12:22:11  *** Highway61 has joined #bitcoin-core-dev
226 2019-11-05T12:24:26  *** nosss2 has quit IRC
227 2019-11-05T12:39:52  *** nosss2 has joined #bitcoin-core-dev
228 2019-11-05T12:44:27  *** nosss2 has quit IRC
229 2019-11-05T12:45:54  *** nijynot_ has joined #bitcoin-core-dev
230 2019-11-05T12:46:58  *** laptop500 has joined #bitcoin-core-dev
231 2019-11-05T12:47:14  *** nijynot has quit IRC
232 2019-11-05T12:47:52  *** nosss2 has joined #bitcoin-core-dev
233 2019-11-05T12:52:24  *** nosss2 has quit IRC
234 2019-11-05T12:57:36  *** Chris_Stewart_5 has quit IRC
235 2019-11-05T12:59:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
236 2019-11-05T12:59:12  *** b10c has quit IRC
237 2019-11-05T13:01:24  *** nosss2 has joined #bitcoin-core-dev
238 2019-11-05T13:05:43  *** nosss2 has quit IRC
239 2019-11-05T13:06:20  *** bitcoin-git has joined #bitcoin-core-dev
240 2019-11-05T13:06:20  <bitcoin-git> [bitcoin] jachiang opened pull request #17378: TestShell: Fix typos & implement cleanups (master...2019-11-testshell-followup) https://github.com/bitcoin/bitcoin/pull/17378
241 2019-11-05T13:06:31  *** bitcoin-git has left #bitcoin-core-dev
242 2019-11-05T13:12:40  *** nosss2 has joined #bitcoin-core-dev
243 2019-11-05T13:17:03  *** nosss2 has quit IRC
244 2019-11-05T13:17:28  *** nijynot has joined #bitcoin-core-dev
245 2019-11-05T13:19:58  *** nijynot_ has quit IRC
246 2019-11-05T13:35:59  *** goatpig has joined #bitcoin-core-dev
247 2019-11-05T13:36:14  *** goatpig_ has quit IRC
248 2019-11-05T13:37:27  *** nosss2 has joined #bitcoin-core-dev
249 2019-11-05T13:38:26  *** timothy has quit IRC
250 2019-11-05T13:39:17  *** MasterdonX has quit IRC
251 2019-11-05T13:40:40  *** MasterdonX has joined #bitcoin-core-dev
252 2019-11-05T13:42:44  *** nosss2 has quit IRC
253 2019-11-05T13:44:01  *** Highway61 has quit IRC
254 2019-11-05T13:52:09  *** IGHOR has quit IRC
255 2019-11-05T13:59:07  *** goatpig has quit IRC
256 2019-11-05T13:59:17  *** goatpig_ has joined #bitcoin-core-dev
257 2019-11-05T14:07:40  *** IGHOR has joined #bitcoin-core-dev
258 2019-11-05T14:11:01  *** Guyver2 has joined #bitcoin-core-dev
259 2019-11-05T14:15:14  *** IGHOR has joined #bitcoin-core-dev
260 2019-11-05T14:15:53  *** IGHOR has quit IRC
261 2019-11-05T14:17:14  *** Chris_Stewart_5 has quit IRC
262 2019-11-05T14:19:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
263 2019-11-05T14:25:35  *** timothy has joined #bitcoin-core-dev
264 2019-11-05T14:28:06  *** IGHOR has joined #bitcoin-core-dev
265 2019-11-05T14:36:52  *** tsujp has quit IRC
266 2019-11-05T14:37:25  *** SiAnDoG has quit IRC
267 2019-11-05T14:37:39  *** SiAnDoG has joined #bitcoin-core-dev
268 2019-11-05T14:39:06  *** tsujp has joined #bitcoin-core-dev
269 2019-11-05T14:40:49  *** SiAnDoG has quit IRC
270 2019-11-05T14:44:11  *** mmgen has joined #bitcoin-core-dev
271 2019-11-05T14:45:42  *** bitcoin-git has joined #bitcoin-core-dev
272 2019-11-05T14:45:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17365: depends: update README.md with working Android targets and API levels (master...update-android-depends-doc) https://github.com/bitcoin/bitcoin/pull/17365
273 2019-11-05T14:45:44  *** bitcoin-git has left #bitcoin-core-dev
274 2019-11-05T14:56:02  *** nosss2 has joined #bitcoin-core-dev
275 2019-11-05T15:00:01  *** kcomandich1 has quit IRC
276 2019-11-05T15:01:51  *** felixweis has joined #bitcoin-core-dev
277 2019-11-05T15:11:35  *** IGHOR has quit IRC
278 2019-11-05T15:13:12  *** drizztbsd has joined #bitcoin-core-dev
279 2019-11-05T15:14:03  *** timothy has quit IRC
280 2019-11-05T15:16:26  *** thoragh has joined #bitcoin-core-dev
281 2019-11-05T15:17:57  *** JohnONolan has joined #bitcoin-core-dev
282 2019-11-05T15:18:26  *** drizztbsd has quit IRC
283 2019-11-05T15:32:51  *** pinheadmz has joined #bitcoin-core-dev
284 2019-11-05T15:34:03  *** bitcoin-git has joined #bitcoin-core-dev
285 2019-11-05T15:34:03  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bdda13787890...e204dc11b562
286 2019-11-05T15:34:04  <bitcoin-git> bitcoin/master aa9b84a Igor Cota: depends: update README.md with working Android targets and API levels
287 2019-11-05T15:34:04  <bitcoin-git> bitcoin/master 3fe1aba Igor Cota: depends: move README.md Android instructions to a separate section
288 2019-11-05T15:34:05  <bitcoin-git> bitcoin/master e204dc1 MarcoFalke: Merge #17365: depends: update README.md with working Android targets and A...
289 2019-11-05T15:34:06  *** bitcoin-git has left #bitcoin-core-dev
290 2019-11-05T15:41:23  *** b10c has joined #bitcoin-core-dev
291 2019-11-05T15:49:03  *** IGHOR has joined #bitcoin-core-dev
292 2019-11-05T15:49:04  *** jb55 has quit IRC
293 2019-11-05T15:49:42  *** spaced0ut has quit IRC
294 2019-11-05T15:52:03  *** justanotheruser has joined #bitcoin-core-dev
295 2019-11-05T15:52:17  *** laptop500 has quit IRC
296 2019-11-05T15:52:53  *** jb55 has joined #bitcoin-core-dev
297 2019-11-05T15:57:50  *** nijynot has quit IRC
298 2019-11-05T15:58:31  *** JBmc has joined #bitcoin-core-dev
299 2019-11-05T15:59:29  <emilengler> Where is the actual http implemented?
300 2019-11-05T15:59:39  <emilengler> I'm talking about the low level networking
301 2019-11-05T15:59:57  <emilengler> httpserver.cpp is probably the wrong place but I might have overseen it
302 2019-11-05T16:00:55  *** jungly has quit IRC
303 2019-11-05T16:02:04  *** jungly has joined #bitcoin-core-dev
304 2019-11-05T16:03:07  <luke-jr> emilengler: libevent?
305 2019-11-05T16:04:16  <luke-jr> #17356 is now passing and ready for concept review; in particular, one open question is how to deal with the `echo` JSON-RPC method: https://github.com/bitcoin/bitcoin/pull/17356#issuecomment-549565616
306 2019-11-05T16:04:18  <gribble> https://github.com/bitcoin/bitcoin/issues/17356 | RPC: Internal named params by luke-jr · Pull Request #17356 · bitcoin/bitcoin · GitHub
307 2019-11-05T16:05:06  *** JBmc has left #bitcoin-core-dev
308 2019-11-05T16:05:27  *** arik_ has joined #bitcoin-core-dev
309 2019-11-05T16:10:32  *** bitcoin-git has joined #bitcoin-core-dev
310 2019-11-05T16:10:32  <bitcoin-git> [bitcoin] ryanofsky opened pull request #17381: LegacyScriptPubKeyMan code cleanups (master...pr/keyman-cleanup2) https://github.com/bitcoin/bitcoin/pull/17381
311 2019-11-05T16:10:34  *** bitcoin-git has left #bitcoin-core-dev
312 2019-11-05T16:19:27  *** Dean_Guss has quit IRC
313 2019-11-05T16:24:32  *** arik__ has joined #bitcoin-core-dev
314 2019-11-05T16:25:44  *** arik_ has quit IRC
315 2019-11-05T16:26:12  *** arik_ has joined #bitcoin-core-dev
316 2019-11-05T16:40:42  *** pinheadmz has quit IRC
317 2019-11-05T16:42:02  *** justanotheruser has quit IRC
318 2019-11-05T16:46:35  *** bitcoin-git has joined #bitcoin-core-dev
319 2019-11-05T16:46:35  <bitcoin-git> [bitcoin] fanquake closed pull request #17377: wallet: remove unused variable spk_man in import* RPCs (master...20191105-refactor-remove_unused_variable_spkman) https://github.com/bitcoin/bitcoin/pull/17377
320 2019-11-05T16:46:46  *** bitcoin-git has left #bitcoin-core-dev
321 2019-11-05T16:50:33  *** pinheadmz has joined #bitcoin-core-dev
322 2019-11-05T16:54:28  *** ddustin has joined #bitcoin-core-dev
323 2019-11-05T16:57:12  <fanquake> GitHub emails nice and laggy today.
324 2019-11-05T16:57:33  <provoostenator> fanquake: notification tab is lagging too
325 2019-11-05T16:57:46  <provoostenator> We're too productive :-)
326 2019-11-05T17:01:01  *** justanotheruser has joined #bitcoin-core-dev
327 2019-11-05T17:02:12  <luke-jr> I'd add a complaint about Travus, but… yeah, it's always bad :P
328 2019-11-05T17:06:11  *** thoragh has quit IRC
329 2019-11-05T17:06:41  *** pinheadmz has quit IRC
330 2019-11-05T17:10:46  <provoostenator> I raise you AppVeyor
331 2019-11-05T17:12:05  *** Dean_Guss has joined #bitcoin-core-dev
332 2019-11-05T17:12:07  <luke-jr> XD
333 2019-11-05T17:12:13  <jonatack> even https://bitcoinbuilds.org seems to be struggling lately
334 2019-11-05T17:13:37  *** diogosergio has quit IRC
335 2019-11-05T17:19:36  *** pinheadmz has joined #bitcoin-core-dev
336 2019-11-05T17:22:19  *** pinheadmz has quit IRC
337 2019-11-05T17:25:36  *** pinheadmz has joined #bitcoin-core-dev
338 2019-11-05T17:37:35  *** bitcoin-git has joined #bitcoin-core-dev
339 2019-11-05T17:37:35  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17378: TestShell: Fix typos & implement cleanups (master...2019-11-testshell-followup) https://github.com/bitcoin/bitcoin/pull/17378
340 2019-11-05T17:37:40  *** bitcoin-git has left #bitcoin-core-dev
341 2019-11-05T17:37:57  *** thoragh has joined #bitcoin-core-dev
342 2019-11-05T17:39:48  *** bitcoin-git has joined #bitcoin-core-dev
343 2019-11-05T17:39:49  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/54a337478dfb...c7e6b3b343e8
344 2019-11-05T17:39:50  <bitcoin-git> bitcoin/master 4de6303 Amiti Uttarwar: [tools] add PoissonNextSend method that returns mockable time
345 2019-11-05T17:39:50  <bitcoin-git> bitcoin/master 1a8f0d5 Amiti Uttarwar: [tools] update nNextInvSend to use mockable time
346 2019-11-05T17:39:51  <bitcoin-git> bitcoin/master c7e6b3b MarcoFalke: Merge #17243: p2p: add PoissonNextSend method that returns mockable time
347 2019-11-05T17:39:52  *** bitcoin-git has left #bitcoin-core-dev
348 2019-11-05T17:40:08  *** bitcoin-git has joined #bitcoin-core-dev
349 2019-11-05T17:40:09  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17243: p2p: add PoissonNextSend method that returns mockable time (master...1910-mockable-poisson) https://github.com/bitcoin/bitcoin/pull/17243
350 2019-11-05T17:40:10  *** bitcoin-git has left #bitcoin-core-dev
351 2019-11-05T17:46:34  *** jarthur has joined #bitcoin-core-dev
352 2019-11-05T17:50:54  *** ElectrumWallet has joined #bitcoin-core-dev
353 2019-11-05T17:56:23  *** bitcoin-git has joined #bitcoin-core-dev
354 2019-11-05T17:56:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17357: tests: Add fuzzing harness for Bech32 encoding/decoding (master...fuzzers-bech32) https://github.com/bitcoin/bitcoin/pull/17357
355 2019-11-05T17:56:24  *** bitcoin-git has left #bitcoin-core-dev
356 2019-11-05T18:00:02  *** JohnONolan has quit IRC
357 2019-11-05T18:01:47  *** ddustin has quit IRC
358 2019-11-05T18:03:20  *** DeanWeen has joined #bitcoin-core-dev
359 2019-11-05T18:05:48  *** Dean_Guss has quit IRC
360 2019-11-05T18:06:03  *** DeanWeen is now known as DeanGuss
361 2019-11-05T18:06:57  <luke-jr> GitHub's Merge button is not working either
362 2019-11-05T18:09:19  *** pinheadmz has quit IRC
363 2019-11-05T18:12:52  <jarthur> If an operator is around, the user ElectrumWallet is impersonating the open source Electrum project.
364 2019-11-05T18:13:24  <gwillen> jarthur: unfortunately he's doing it in multiple channels that do not have chanops in common
365 2019-11-05T18:13:38  <luke-jr> not sure what it has to do with dev..
366 2019-11-05T18:13:58  <jarthur> luke-jr: agreed, except that it's here in the dev channel.
367 2019-11-05T18:14:06  *** pinheadmz has joined #bitcoin-core-dev
368 2019-11-05T18:14:41  <luke-jr> ah, true
369 2019-11-05T18:15:18  *** ChanServ sets mode: +o gwillen
370 2019-11-05T18:15:28  *** gwillen sets mode: +b *!*@160.154.130.99
371 2019-11-05T18:15:29  *** ElectrumWallet was kicked by gwillen (ElectrumWallet)
372 2019-11-05T18:15:32  *** gwillen sets mode: -o gwillen
373 2019-11-05T18:17:20  *** nickr has joined #bitcoin-core-dev
374 2019-11-05T18:19:39  *** raj_149 has joined #bitcoin-core-dev
375 2019-11-05T18:21:33  *** Chris_Stewart_5 has quit IRC
376 2019-11-05T18:22:07  *** bitcoin-git has joined #bitcoin-core-dev
377 2019-11-05T18:22:07  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17363: test: add "diamond" unit test to MempoolAncestryTests (master...20191104-test-add_diamond_ancestors_unit_test) https://github.com/bitcoin/bitcoin/pull/17363
378 2019-11-05T18:22:09  *** bitcoin-git has left #bitcoin-core-dev
379 2019-11-05T18:26:04  *** bitcoin-git has joined #bitcoin-core-dev
380 2019-11-05T18:26:04  <bitcoin-git> [bitcoin] laanwj merged pull request #17044: init: Remove auto-import of `bootstrap.dat` and associated code (master...pr15954) https://github.com/bitcoin/bitcoin/pull/17044
381 2019-11-05T18:26:05  *** bitcoin-git has left #bitcoin-core-dev
382 2019-11-05T18:26:24  *** diogosergio has joined #bitcoin-core-dev
383 2019-11-05T18:29:00  *** mdunnio has joined #bitcoin-core-dev
384 2019-11-05T18:29:19  *** andytoshi has joined #bitcoin-core-dev
385 2019-11-05T18:29:36  *** bitcoin-git has joined #bitcoin-core-dev
386 2019-11-05T18:29:36  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e204dc11b562...54a337478dfb
387 2019-11-05T18:29:37  <bitcoin-git> bitcoin/master d3ed06e James Chiang: TestShell: Fix typo in TestShell warning printout
388 2019-11-05T18:29:37  <bitcoin-git> bitcoin/master 9c7806e James Chiang: Doc: Remove backticks in test-shell.md code block
389 2019-11-05T18:29:38  <bitcoin-git> bitcoin/master a8dea45 James Chiang: TestShell: Simplify default setting of num_nodes
390 2019-11-05T18:29:39  *** bitcoin-git has left #bitcoin-core-dev
391 2019-11-05T18:30:04  *** pinheadmz has quit IRC
392 2019-11-05T18:31:20  <luke-jr> MarcoFalke: src/crypto/poly1305.cpp
393 2019-11-05T18:31:48  *** pinheadmz has joined #bitcoin-core-dev
394 2019-11-05T18:32:45  <MarcoFalke> luke-jr: Fine, but we don't use goto in the Bitcoin Core dialect of C++
395 2019-11-05T18:33:07  <MarcoFalke> The crypto is mostly written in something that is closer to C
396 2019-11-05T18:33:24  <sipa> it's also a direct port of C code
397 2019-11-05T18:33:32  <sipa> of the reference C code, almost even
398 2019-11-05T18:33:42  *** bitcoin-git has joined #bitcoin-core-dev
399 2019-11-05T18:33:43  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c7e6b3b343e8...50591f6ec61b
400 2019-11-05T18:33:43  <bitcoin-git> bitcoin/master 85a34b1 practicalswift: tests: Move CaseInsensitiveEqual to test/util/str
401 2019-11-05T18:33:44  <bitcoin-git> bitcoin/master b754170 practicalswift: tests: Add fuzzing harness for Bech32 encoding/decoding
402 2019-11-05T18:33:44  <bitcoin-git> bitcoin/master 50591f6 MarcoFalke: Merge #17357: tests: Add fuzzing harness for Bech32 encoding/decoding
403 2019-11-05T18:33:46  *** bitcoin-git has left #bitcoin-core-dev
404 2019-11-05T18:33:46  <MarcoFalke> luke-jr: Why would you want to use goto when a one line C++ function can do the same?
405 2019-11-05T18:35:54  <ariard> hey anyone willingly to exchange a review against one on #15931 ?
406 2019-11-05T18:35:57  <gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard · Pull Request #15931 · bitcoin/bitcoin · GitHub
407 2019-11-05T18:36:32  *** bitcoin-git has joined #bitcoin-core-dev
408 2019-11-05T18:36:33  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/50591f6ec61b...22e7eea629e2
409 2019-11-05T18:36:34  <bitcoin-git> bitcoin/master b2ff500 Sebastian Falbesoner: test: add "diamond" unit test to MempoolAncestryTests
410 2019-11-05T18:36:35  <bitcoin-git> bitcoin/master 22e7eea MarcoFalke: Merge #17363: test: add "diamond" unit test to MempoolAncestryTests
411 2019-11-05T18:36:37  *** bitcoin-git has left #bitcoin-core-dev
412 2019-11-05T18:37:37  *** bitcoin-git has joined #bitcoin-core-dev
413 2019-11-05T18:37:37  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22e7eea629e2...d35b12107e9e
414 2019-11-05T18:37:38  <bitcoin-git> bitcoin/master 104f7de tryphe: remove old bootstrap relevant code
415 2019-11-05T18:37:39  <bitcoin-git> bitcoin/master d35b121 Wladimir J. van der Laan: Merge #17044: init: Remove auto-import of `bootstrap.dat` and associated c...
416 2019-11-05T18:37:40  *** bitcoin-git has left #bitcoin-core-dev
417 2019-11-05T18:38:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
418 2019-11-05T18:41:25  *** bitcoin-git has joined #bitcoin-core-dev
419 2019-11-05T18:41:25  <bitcoin-git> [bitcoin] laanwj merged pull request #16899: UTXO snapshot creation (dumptxoutset) (master...2019-09-au-dumptxoutset) https://github.com/bitcoin/bitcoin/pull/16899
420 2019-11-05T18:41:26  *** bitcoin-git has left #bitcoin-core-dev
421 2019-11-05T18:43:49  *** bitcoin-git has joined #bitcoin-core-dev
422 2019-11-05T18:43:50  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/d35b12107e9e...b05b28183c0a
423 2019-11-05T18:43:51  <bitcoin-git> bitcoin/master 707fde7 James O'Beirne: add unused SnapshotMetadata class
424 2019-11-05T18:43:52  <bitcoin-git> bitcoin/master 92fafb3 James O'Beirne: coinstats: add coins_count
425 2019-11-05T18:43:52  <bitcoin-git> bitcoin/master 57cf74c James O'Beirne: rpc: add dumptxoutset
426 2019-11-05T18:43:54  *** bitcoin-git has left #bitcoin-core-dev
427 2019-11-05T18:44:14  *** kevvkaww has joined #bitcoin-core-dev
428 2019-11-05T18:46:36  *** soju has joined #bitcoin-core-dev
429 2019-11-05T18:46:47  <luke-jr> MarcoFalke: but UniValue is an upstream dependency, not Bitcoin Core; it shouldn't be bundled at all
430 2019-11-05T18:47:34  <MarcoFalke> I feel like this was discussed in the past already
431 2019-11-05T18:47:51  <luke-jr> I bet libevent has gotos ;)
432 2019-11-05T18:50:18  *** soju has quit IRC
433 2019-11-05T18:50:33  *** Zenton has quit IRC
434 2019-11-05T18:50:46  <wumpus> gotos in C make a lot of sense, not in C++
435 2019-11-05T18:51:08  <wumpus> in C it's often the only sane way to do error handling, this is even used in projects such as the kernel and mesa
436 2019-11-05T18:51:45  <sipa> and in C++ they're often unable to be used for that even, because they can't jump over the initializers of new variables
437 2019-11-05T18:52:12  <wumpus> modern C++ has no use for them
438 2019-11-05T18:52:14  <wumpus> right sipa
439 2019-11-05T18:54:00  *** pinheadmz has quit IRC
440 2019-11-05T18:56:15  *** pinheadmz has joined #bitcoin-core-dev
441 2019-11-05T18:56:16  <jonatack> ariard: i plan to finish review of #15931 tomorrow or thursday latest
442 2019-11-05T18:56:19  <gribble> https://github.com/bitcoin/bitcoin/issues/15931 | Remove GetDepthInMainChain dependency on locked chain interface by ariard · Pull Request #15931 · bitcoin/bitcoin · GitHub
443 2019-11-05T18:57:43  *** kevvkaww has quit IRC
444 2019-11-05T18:58:35  *** reallll has joined #bitcoin-core-dev
445 2019-11-05T19:00:05  *** pinheadmz has quit IRC
446 2019-11-05T19:02:32  *** belcher has quit IRC
447 2019-11-05T19:04:14  *** ddustin has joined #bitcoin-core-dev
448 2019-11-05T19:05:25  *** ddustin has quit IRC
449 2019-11-05T19:06:04  *** ddustin has joined #bitcoin-core-dev
450 2019-11-05T19:09:32  *** bitcoin-git has joined #bitcoin-core-dev
451 2019-11-05T19:09:32  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17382: rpc: Remove unused boost::this_thread::interruption_point (master...1911-noBoostThreadInt) https://github.com/bitcoin/bitcoin/pull/17382
452 2019-11-05T19:09:33  *** bitcoin-git has left #bitcoin-core-dev
453 2019-11-05T19:09:45  *** pinheadmz has joined #bitcoin-core-dev
454 2019-11-05T19:10:06  *** ddustin has quit IRC
455 2019-11-05T19:12:27  *** DeanGuss has quit IRC
456 2019-11-05T19:16:56  *** jpe_ has quit IRC
457 2019-11-05T19:23:50  *** michaelfolkson has joined #bitcoin-core-dev
458 2019-11-05T19:26:21  *** laptop500 has joined #bitcoin-core-dev
459 2019-11-05T19:27:06  *** reallll is now known as belcher
460 2019-11-05T19:29:32  *** soju has joined #bitcoin-core-dev
461 2019-11-05T19:36:22  *** bitcoin-git has joined #bitcoin-core-dev
462 2019-11-05T19:36:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b05b28183c0a...fea532a5f20c
463 2019-11-05T19:36:23  <bitcoin-git> bitcoin/master fa1936f MarcoFalke: logging: Add member for arbitrary print callbacks
464 2019-11-05T19:36:24  <bitcoin-git> bitcoin/master fa2c44c MarcoFalke: test: Add ASSERT_DEBUG_LOG to unit test framework
465 2019-11-05T19:36:24  <bitcoin-git> bitcoin/master fea532a MarcoFalke: Merge #16540: test: Add ASSERT_DEBUG_LOG to unit test framework
466 2019-11-05T19:36:26  *** bitcoin-git has left #bitcoin-core-dev
467 2019-11-05T19:37:02  *** bitcoin-git has joined #bitcoin-core-dev
468 2019-11-05T19:37:03  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16540: test: Add ASSERT_DEBUG_LOG to unit test framework (master...1908-UnitTestAssertDebugLog) https://github.com/bitcoin/bitcoin/pull/16540
469 2019-11-05T19:37:04  *** bitcoin-git has left #bitcoin-core-dev
470 2019-11-05T19:42:04  *** mdunnio has quit IRC
471 2019-11-05T19:42:44  *** nijynot has joined #bitcoin-core-dev
472 2019-11-05T19:43:15  *** bitcoin-git has joined #bitcoin-core-dev
473 2019-11-05T19:43:15  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fea532a5f20c...d9a45500018f
474 2019-11-05T19:43:16  <bitcoin-git> bitcoin/master 1c26c16 Danny-Scott: Improve "Hide" button tool-tip message
475 2019-11-05T19:43:16  <bitcoin-git> bitcoin/master d9a4550 Wladimir J. van der Laan: Merge #17360: gui: Improve "Hide" button tool-tip message
476 2019-11-05T19:43:26  *** bitcoin-git has left #bitcoin-core-dev
477 2019-11-05T19:43:45  *** bitcoin-git has joined #bitcoin-core-dev
478 2019-11-05T19:43:45  <bitcoin-git> [bitcoin] laanwj merged pull request #17360: gui: Improve "Hide" button tool-tip message (master...nov-2019-hide-button-tool-tip) https://github.com/bitcoin/bitcoin/pull/17360
479 2019-11-05T19:43:50  *** bitcoin-git has left #bitcoin-core-dev
480 2019-11-05T19:44:59  *** michaelfolkson has quit IRC
481 2019-11-05T19:46:02  *** michaelfolkson has joined #bitcoin-core-dev
482 2019-11-05T19:46:59  *** michaelfolkson has quit IRC
483 2019-11-05T19:49:20  *** sdaftuar has joined #bitcoin-core-dev
484 2019-11-05T19:49:37  *** mdunnio has joined #bitcoin-core-dev
485 2019-11-05T19:50:56  *** mdunnio has quit IRC
486 2019-11-05T19:51:34  *** mdunnio has joined #bitcoin-core-dev
487 2019-11-05T19:55:14  *** Skirmant has joined #bitcoin-core-dev
488 2019-11-05T19:55:56  *** mmgen has quit IRC
489 2019-11-05T19:57:26  *** pinheadmz has quit IRC
490 2019-11-05T20:01:08  *** jarthur_ has joined #bitcoin-core-dev
491 2019-11-05T20:03:57  *** jarthur has quit IRC
492 2019-11-05T20:03:59  *** jarthur_ is now known as jarthur
493 2019-11-05T20:12:59  *** bitcoin-git has joined #bitcoin-core-dev
494 2019-11-05T20:12:59  <bitcoin-git> [bitcoin] jnewbery opened pull request #17383: Refactor: Move consts to their correct translation units (master...2019-11-net-processing-consts) https://github.com/bitcoin/bitcoin/pull/17383
495 2019-11-05T20:13:02  *** bitcoin-git has left #bitcoin-core-dev
496 2019-11-05T20:16:19  *** ddustin has joined #bitcoin-core-dev
497 2019-11-05T20:17:56  *** EagleTM has joined #bitcoin-core-dev
498 2019-11-05T20:22:01  *** Skirmant has quit IRC
499 2019-11-05T20:29:50  *** bitcoin-git has joined #bitcoin-core-dev
500 2019-11-05T20:29:50  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17384: test: Create new test library (master...1911-testLib) https://github.com/bitcoin/bitcoin/pull/17384
501 2019-11-05T20:29:51  *** bitcoin-git has left #bitcoin-core-dev
502 2019-11-05T20:33:38  *** laptop500 has quit IRC
503 2019-11-05T20:34:22  *** andytoshi has quit IRC
504 2019-11-05T20:36:20  *** jonatack has quit IRC
505 2019-11-05T20:37:22  *** owowo has quit IRC
506 2019-11-05T20:39:03  *** nijynot has quit IRC
507 2019-11-05T20:39:04  *** Zenton has joined #bitcoin-core-dev
508 2019-11-05T20:41:57  *** owowo has joined #bitcoin-core-dev
509 2019-11-05T20:42:54  *** Zenton has quit IRC
510 2019-11-05T20:43:14  *** Zenton has joined #bitcoin-core-dev
511 2019-11-05T20:43:47  *** bitcoin-git has joined #bitcoin-core-dev
512 2019-11-05T20:43:47  <bitcoin-git> [bitcoin] laanwj opened pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
513 2019-11-05T20:43:48  *** bitcoin-git has left #bitcoin-core-dev
514 2019-11-05T20:47:11  *** Zenton has quit IRC
515 2019-11-05T20:47:51  *** Zenton has joined #bitcoin-core-dev
516 2019-11-05T20:51:44  *** Zenton has quit IRC
517 2019-11-05T20:52:27  *** Zenton has joined #bitcoin-core-dev
518 2019-11-05T20:53:10  *** ddustin has quit IRC
519 2019-11-05T20:54:44  *** andytoshi has joined #bitcoin-core-dev
520 2019-11-05T20:56:44  *** Zenton has quit IRC
521 2019-11-05T20:57:04  *** Zenton has joined #bitcoin-core-dev
522 2019-11-05T21:00:01  *** nickr has quit IRC
523 2019-11-05T21:01:06  *** jonatack has joined #bitcoin-core-dev
524 2019-11-05T21:01:06  *** Zenton has quit IRC
525 2019-11-05T21:01:37  *** Zenton has joined #bitcoin-core-dev
526 2019-11-05T21:04:21  *** jarthur has quit IRC
527 2019-11-05T21:04:57  *** jarthur has joined #bitcoin-core-dev
528 2019-11-05T21:08:17  *** ddustin has joined #bitcoin-core-dev
529 2019-11-05T21:08:46  *** soju has quit IRC
530 2019-11-05T21:09:56  *** diogosergio has quit IRC
531 2019-11-05T21:10:16  *** diogosergio has joined #bitcoin-core-dev
532 2019-11-05T21:13:11  *** ddustin has quit IRC
533 2019-11-05T21:15:26  *** DeanGuss has joined #bitcoin-core-dev
534 2019-11-05T21:17:20  *** laxanofido has joined #bitcoin-core-dev
535 2019-11-05T21:19:55  *** Zenton has quit IRC
536 2019-11-05T21:20:17  *** Zenton has joined #bitcoin-core-dev
537 2019-11-05T21:28:09  *** ddustin has joined #bitcoin-core-dev
538 2019-11-05T21:38:32  *** Zenton has quit IRC
539 2019-11-05T21:38:38  *** Highway61 has joined #bitcoin-core-dev
540 2019-11-05T21:38:52  *** Zenton has joined #bitcoin-core-dev
541 2019-11-05T21:39:54  *** nijynot has joined #bitcoin-core-dev
542 2019-11-05T21:40:17  <meshcollider> ariard: it's on my list to review that this week too :)
543 2019-11-05T21:40:41  <wumpus> do we support -notestnet=1 and -noregtest=1 as arguments? I've never seen this before
544 2019-11-05T21:40:48  <wumpus> re: https://github.com/bitcoin/bitcoin/pull/17385#issuecomment-550033222
545 2019-11-05T21:40:56  <wumpus> it does some really strange things
546 2019-11-05T21:41:11  <wumpus> apparently we're testing for this but why?
547 2019-11-05T21:41:16  *** laptop500 has joined #bitcoin-core-dev
548 2019-11-05T21:41:32  <meshcollider> I didnt think we were allowed to combine "no" with =
549 2019-11-05T21:41:48  <wumpus> same
550 2019-11-05T21:42:05  <wumpus> I'll remove the =1
551 2019-11-05T21:43:17  *** kristapsk has quit IRC
552 2019-11-05T21:43:30  <luke-jr> = is necessary in the config file
553 2019-11-05T21:43:46  <wumpus> noX is not allowed in the config file
554 2019-11-05T21:44:48  *** Highway61 has quit IRC
555 2019-11-05T21:44:52  <luke-jr> oh
556 2019-11-05T21:44:59  <wumpus> but you're right, it's used with ReadConfigStream
557 2019-11-05T21:45:13  <luke-jr> bigger question IMO is how we get to 1testnet=1
558 2019-11-05T21:45:36  <luke-jr> that's kind of crazy :P
559 2019-11-05T21:45:46  <wumpus> it is
560 2019-11-05T21:46:27  <wumpus> this happens to work for atoi because it stops parsing at the first non-digit :')
561 2019-11-05T21:47:17  <wumpus> relying on that turn of events is kind of bizarre
562 2019-11-05T21:48:04  *** Zenton has quit IRC
563 2019-11-05T21:48:28  *** Zenton has joined #bitcoin-core-dev
564 2019-11-05T21:51:21  <achow101> anyone want to have a discussion about IsMine (and it's weird behaviors)?
565 2019-11-05T21:51:40  * luke-jr suggests replacing it with `return true` /s
566 2019-11-05T21:52:25  *** nijynot has quit IRC
567 2019-11-05T21:52:34  <instagibbs> achow101, no.
568 2019-11-05T21:53:02  *** Zenton has quit IRC
569 2019-11-05T21:53:35  *** Zenton has joined #bitcoin-core-dev
570 2019-11-05T21:53:37  <achow101> alright then
571 2019-11-05T21:53:57  <instagibbs> seriously tho, anything newly weird
572 2019-11-05T21:54:23  <achow101> https://github.com/bitcoin/bitcoin/pull/17374#issuecomment-550036931
573 2019-11-05T21:55:21  <achow101> The main weird thing was this inconsistency I just noticed where you could import a wpkh() descriptor and still get metadata for the legacy address that shares the same pubkey with it, but that legacy address is ismine_no
574 2019-11-05T21:55:57  <instagibbs> that's fun
575 2019-11-05T21:56:18  <achow101> and I don't think we can/should retain this behavior in ScriptPubKeyMan, but that's also a breaking change
576 2019-11-05T21:56:33  <wumpus> I'm tempted to just drop that commit
577 2019-11-05T21:58:28  <wumpus> ryanofsky: testnet=0 is fine, notestnet=1 is not
578 2019-11-05T21:58:48  <wumpus> it's the double negation that messes things up
579 2019-11-05T21:58:52  <instagibbs> achow101, this is only for pkh detection?
580 2019-11-05T21:59:33  <achow101> maybe?
581 2019-11-05T21:59:51  <ryanofsky> wumpus, feel free to drop the commit, i can follow up later if needed. anyway i'm going to debug
582 2019-11-05T22:00:11  <achow101> probably. I think it might not detect some more esoteric stuff like p2pkh inside of p2sh
583 2019-11-05T22:00:29  <instagibbs> right, nested checks
584 2019-11-05T22:00:30  <ryanofsky> to be sure though, -notestnet=1 is not double negation, that's just single negation
585 2019-11-05T22:01:15  <wumpus> ryanofsky: there's no hurry but if people really insist on keeping the current crazy behavior I'm not going to argue :)
586 2019-11-05T22:01:16  <instagibbs> to be clear, you're saying 17374 is a breaking change
587 2019-11-05T22:01:46  <achow101> yes. and so is the final ScriptPubKeyMan refactor
588 2019-11-05T22:01:46  *** Zenton has quit IRC
589 2019-11-05T22:01:48  <wumpus> ryanofsky: right, notestnet=0 would be a double negation
590 2019-11-05T22:02:04  *** ddustin_ has joined #bitcoin-core-dev
591 2019-11-05T22:02:13  *** Zenton has joined #bitcoin-core-dev
592 2019-11-05T22:02:54  <wumpus> I remember support for that was dropped at some point, notestnet=1 probably should just ignore the parameter
593 2019-11-05T22:03:02  <instagibbs> achow101, I find this corner case very surprising from our dumb ismine current wallet fwiw
594 2019-11-05T22:03:03  <achow101> instagibbs: well breaking in different ways. 17374 is breaking by changing ismine behavior to allow more things. scriptpubkeyman pr would be break getaddressinfo behavior without 17374
595 2019-11-05T22:03:25  <instagibbs> ok im just considering 17374.
596 2019-11-05T22:03:39  *** ddustin has quit IRC
597 2019-11-05T22:05:10  <sipa> achow101: i don't think losing signingprovider info for non-ismine things is a big problem
598 2019-11-05T22:05:36  <sipa> worth a mention in release notes
599 2019-11-05T22:07:20  <achow101> sipa: right, I'm leaning that way too. the thing that confused me was that we have a few tests that rely on that behavior, probably on accident
600 2019-11-05T22:09:06  <wumpus> hehe
601 2019-11-05T22:10:16  *** Zenton has quit IRC
602 2019-11-05T22:10:23  <instagibbs> ack
603 2019-11-05T22:10:44  <wumpus> ryanofsky: looking at it, it's very possible that that test is broken and not the argumet parsing in general
604 2019-11-05T22:10:47  *** Zenton has joined #bitcoin-core-dev
605 2019-11-05T22:11:52  <ryanofsky> yes, it looks like the multiple config entries created by the test are stuck together
606 2019-11-05T22:12:19  <wumpus> right
607 2019-11-05T22:13:47  *** bitcoin-git has joined #bitcoin-core-dev
608 2019-11-05T22:13:47  <bitcoin-git> [bitcoin] achow101 closed pull request #17374: IsMine: Set state to WATCH_ONLY if we can get the pubkey (master...wallet-box-pr-7) https://github.com/bitcoin/bitcoin/pull/17374
609 2019-11-05T22:13:49  *** bitcoin-git has left #bitcoin-core-dev
610 2019-11-05T22:14:33  <wumpus> it's not the most easy to understand code
611 2019-11-05T22:14:46  *** Guyver2 has quit IRC
612 2019-11-05T22:17:48  *** b10c has quit IRC
613 2019-11-05T22:18:43  *** bitcoin-git has joined #bitcoin-core-dev
614 2019-11-05T22:18:44  <bitcoin-git> [bitcoin] Empact opened pull request #17386: [moveonly] Extract CWallet::CompactDatabase (master...get-db-handle) https://github.com/bitcoin/bitcoin/pull/17386
615 2019-11-05T22:18:45  *** bitcoin-git has left #bitcoin-core-dev
616 2019-11-05T22:19:21  *** Zenton has quit IRC
617 2019-11-05T22:19:33  <wumpus> like using "desc += argstr + 1;" to add to a string, yes you can write C++ code like that, but...
618 2019-11-05T22:19:57  *** Zenton has joined #bitcoin-core-dev
619 2019-11-05T22:20:12  <luke-jr> lol
620 2019-11-05T22:21:32  *** bitcoin-git has joined #bitcoin-core-dev
621 2019-11-05T22:21:33  <bitcoin-git> [bitcoin] achow101 opened pull request #17387: wallet_importmulti: use addresses of the same type as being imported (master...tests-fix-getaddrinfo-type-consistency) https://github.com/bitcoin/bitcoin/pull/17387
622 2019-11-05T22:21:33  *** bitcoin-git has left #bitcoin-core-dev
623 2019-11-05T22:23:23  <wumpus> so I *think* the idea would be to add a new line in between there
624 2019-11-05T22:23:38  *** Zenton has quit IRC
625 2019-11-05T22:24:03  *** Zenton has joined #bitcoin-core-dev
626 2019-11-05T22:25:52  <wumpus> yeh adding conf += "\n"; at the end of that loop stops the 1testnet=1 problem
627 2019-11-05T22:26:29  <wumpus> but it causes the test to fail, likely because of a wrong expectation
628 2019-11-05T22:27:34  <wumpus> at least it fails in the same way with and without my patch after that :-)
629 2019-11-05T22:27:34  *** michaelfolkson has joined #bitcoin-core-dev
630 2019-11-05T22:28:01  <ryanofsky> thanks, yeah, pushing a pr in a minute or two, it's unrelated to your pr
631 2019-11-05T22:28:52  *** diogosergio has quit IRC
632 2019-11-05T22:29:12  <wumpus> -regtest=0 -noregtest=1 testnet=1 regtest=1 || test  ->  error: Invalid combination of -regtest, -testnet and -chain. Can use at most one.
633 2019-11-05T22:29:19  <wumpus> definitely better
634 2019-11-05T22:30:01  <wumpus> I don't think anyone reviewed the previous test output ever
635 2019-11-05T22:31:05  <wumpus> thanks
636 2019-11-05T22:31:33  *** bitcoin-git has joined #bitcoin-core-dev
637 2019-11-05T22:31:33  <bitcoin-git> [bitcoin] ryanofsky opened pull request #17388: Add missing newline in util_ChainMerge test (master...pr/chainmerge-nl) https://github.com/bitcoin/bitcoin/pull/17388
638 2019-11-05T22:31:34  *** bitcoin-git has left #bitcoin-core-dev
639 2019-11-05T22:36:28  *** Zenton has quit IRC
640 2019-11-05T22:37:08  *** Zenton has joined #bitcoin-core-dev
641 2019-11-05T22:37:21  *** Emcy has quit IRC
642 2019-11-05T22:39:47  *** kristapsk has joined #bitcoin-core-dev
643 2019-11-05T22:40:51  *** Chris_Stewart_5 has quit IRC
644 2019-11-05T22:42:19  <meshcollider> achow101: what kind of tests rely on that behaviour?
645 2019-11-05T22:42:43  <achow101> the importmulti ones
646 2019-11-05T22:43:18  <achow101> trivial to make them not rely on it, see the pr I just opened
647 2019-11-05T22:43:28  <meshcollider> Ok
648 2019-11-05T22:45:26  *** Zenton has quit IRC
649 2019-11-05T22:45:44  *** Zenton has joined #bitcoin-core-dev
650 2019-11-05T22:46:02  *** bitcoin-git has joined #bitcoin-core-dev
651 2019-11-05T22:46:03  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d9a45500018f...40b6070ad7e8
652 2019-11-05T22:46:04  <bitcoin-git> bitcoin/master 41edaf2 James O'Beirne: logs: add BCLog::Timer and related macros
653 2019-11-05T22:46:05  <bitcoin-git> bitcoin/master dcef9a2 James O'Beirne: logs: add timing information to FlushStateToDisk()
654 2019-11-05T22:46:05  <bitcoin-git> bitcoin/master 40b6070 Wladimir J. van der Laan: Merge #16805: logs: add timing information to FlushStateToDisk()
655 2019-11-05T22:46:07  *** bitcoin-git has left #bitcoin-core-dev
656 2019-11-05T22:46:27  *** bitcoin-git has joined #bitcoin-core-dev
657 2019-11-05T22:46:27  <bitcoin-git> [bitcoin] laanwj merged pull request #16805: logs: add timing information to FlushStateToDisk() (master...2019-09-flush-logs) https://github.com/bitcoin/bitcoin/pull/16805
658 2019-11-05T22:46:28  *** bitcoin-git has left #bitcoin-core-dev
659 2019-11-05T22:59:29  *** nosss2 has quit IRC
660 2019-11-05T23:04:02  *** jarthur has quit IRC
661 2019-11-05T23:04:15  *** mdunnio has quit IRC
662 2019-11-05T23:04:21  *** Emcy has joined #bitcoin-core-dev
663 2019-11-05T23:05:17  *** bitcoin-git has joined #bitcoin-core-dev
664 2019-11-05T23:05:17  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/40b6070ad7e8...45e65376ac9e
665 2019-11-05T23:05:18  <bitcoin-git> bitcoin/master fa5facd MarcoFalke: rpc: Remove unused boost::this_thread::interruption_point
666 2019-11-05T23:05:18  <bitcoin-git> bitcoin/master 45e6537 Wladimir J. van der Laan: Merge #17382: rpc: Remove unused boost::this_thread::interruption_point
667 2019-11-05T23:05:20  *** bitcoin-git has left #bitcoin-core-dev
668 2019-11-05T23:05:37  *** bitcoin-git has joined #bitcoin-core-dev
669 2019-11-05T23:05:37  <bitcoin-git> [bitcoin] laanwj merged pull request #17382: rpc: Remove unused boost::this_thread::interruption_point (master...1911-noBoostThreadInt) https://github.com/bitcoin/bitcoin/pull/17382
670 2019-11-05T23:05:39  *** bitcoin-git has left #bitcoin-core-dev
671 2019-11-05T23:10:17  *** Zenton has quit IRC
672 2019-11-05T23:10:51  *** marcoagner has quit IRC
673 2019-11-05T23:10:53  *** Zenton has joined #bitcoin-core-dev
674 2019-11-05T23:15:00  *** ddustin has joined #bitcoin-core-dev
675 2019-11-05T23:16:08  *** laptop500 has quit IRC
676 2019-11-05T23:16:23  *** Emcy has quit IRC
677 2019-11-05T23:17:33  *** ddustin_ has quit IRC
678 2019-11-05T23:17:49  *** ddustin_ has joined #bitcoin-core-dev
679 2019-11-05T23:20:22  *** bitcoin-git has joined #bitcoin-core-dev
680 2019-11-05T23:20:22  <bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17389: build: add background.tiff and .pngs to "make clean" (master...make-clean-tiff) https://github.com/bitcoin/bitcoin/pull/17389
681 2019-11-05T23:20:23  *** bitcoin-git has left #bitcoin-core-dev
682 2019-11-05T23:21:08  *** ddustin has quit IRC
683 2019-11-05T23:26:08  *** Zenton has quit IRC
684 2019-11-05T23:26:32  *** Zenton has joined #bitcoin-core-dev
685 2019-11-05T23:29:44  *** Zenton has quit IRC
686 2019-11-05T23:30:11  *** Zenton has joined #bitcoin-core-dev
687 2019-11-05T23:31:24  *** ddustin_ has quit IRC
688 2019-11-05T23:33:56  *** Zenton has quit IRC
689 2019-11-05T23:34:16  *** Zenton has joined #bitcoin-core-dev
690 2019-11-05T23:36:13  *** Highway61 has joined #bitcoin-core-dev
691 2019-11-05T23:38:44  <wumpus> it's pretty strange to have a one-time boost::interruption point at the beginning of BerkeleyEnvironment::Open and BerkeleyEnvironment::BerkeleyEnvironment, seems like something the caller could handle if needed
692 2019-11-05T23:39:15  <wumpus> these are meant for being able to interrupt long-running operations
693 2019-11-05T23:44:34  *** Victor_sueca has joined #bitcoin-core-dev
694 2019-11-05T23:44:48  *** Zenton has quit IRC
695 2019-11-05T23:45:22  *** Zenton has joined #bitcoin-core-dev
696 2019-11-05T23:47:07  *** Victorsueca has quit IRC
697 2019-11-05T23:50:31  *** pinheadmz has joined #bitcoin-core-dev
698 2019-11-05T23:52:18  *** Emcy has joined #bitcoin-core-dev
699 2019-11-05T23:54:15  *** bitcoin-git has joined #bitcoin-core-dev
700 2019-11-05T23:54:15  <bitcoin-git> [bitcoin] ryanofsky opened pull request #17390: Add util_ArgParsing test (master...pr/argparse-test) https://github.com/bitcoin/bitcoin/pull/17390
701 2019-11-05T23:54:16  *** bitcoin-git has left #bitcoin-core-dev
702 2019-11-05T23:54:28  *** jonatack has quit IRC