1 2019-11-06T00:00:01  *** laxanofido has quit IRC
  2 2019-11-06T00:02:07  *** Zenton has quit IRC
  3 2019-11-06T00:02:29  *** Zenton has joined #bitcoin-core-dev
  4 2019-11-06T00:05:18  *** Zenton has quit IRC
  5 2019-11-06T00:05:36  *** Zenton has joined #bitcoin-core-dev
  6 2019-11-06T00:07:16  *** ddustin has joined #bitcoin-core-dev
  7 2019-11-06T00:14:19  *** Zenton has quit IRC
  8 2019-11-06T00:14:44  *** Zenton has joined #bitcoin-core-dev
  9 2019-11-06T00:15:10  *** ddustin_ has joined #bitcoin-core-dev
 10 2019-11-06T00:15:36  *** michaelfolkson has quit IRC
 11 2019-11-06T00:17:04  *** chipc has joined #bitcoin-core-dev
 12 2019-11-06T00:17:47  *** Zenton has quit IRC
 13 2019-11-06T00:18:21  *** Zenton has joined #bitcoin-core-dev
 14 2019-11-06T00:18:39  *** ddustin has quit IRC
 15 2019-11-06T00:24:17  *** Zenton has quit IRC
 16 2019-11-06T00:24:58  *** Zenton has joined #bitcoin-core-dev
 17 2019-11-06T00:29:26  *** soju has joined #bitcoin-core-dev
 18 2019-11-06T00:30:50  *** Zenton has quit IRC
 19 2019-11-06T00:31:31  *** alko89 has quit IRC
 20 2019-11-06T00:33:20  *** ddustin_ has quit IRC
 21 2019-11-06T00:34:15  *** soju has quit IRC
 22 2019-11-06T00:38:50  <wumpus> I might close #17385 again, I have only bad ideas lately
 23 2019-11-06T00:38:52  <gribble> https://github.com/bitcoin/bitcoin/issues/17385 | refactor: Use our own integer parsing/formatting everywhere by laanwj · Pull Request #17385 · bitcoin/bitcoin · GitHub
 24 2019-11-06T00:41:53  *** bitcoin-git has joined #bitcoin-core-dev
 25 2019-11-06T00:41:54  <bitcoin-git> [bitcoin] Empact closed pull request #17386: [moveonly] Extract CWallet::CompactDatabase (master...get-db-handle) https://github.com/bitcoin/bitcoin/pull/17386
 26 2019-11-06T00:41:54  *** bitcoin-git has left #bitcoin-core-dev
 27 2019-11-06T00:47:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 28 2019-11-06T00:54:57  *** jb55 has quit IRC
 29 2019-11-06T00:57:25  *** lightlike has quit IRC
 30 2019-11-06T00:59:57  *** Highway61 has quit IRC
 31 2019-11-06T01:03:22  *** Zenton has joined #bitcoin-core-dev
 32 2019-11-06T01:09:41  *** jb55 has joined #bitcoin-core-dev
 33 2019-11-06T01:10:47  *** pinheadmz has quit IRC
 34 2019-11-06T01:10:56  *** Chris_Stewart_5 has quit IRC
 35 2019-11-06T01:15:22  *** bitcoin-git has joined #bitcoin-core-dev
 36 2019-11-06T01:15:22  <bitcoin-git> [bitcoin] MarceloGra opened pull request #17391: 0.8 (master...0.8) https://github.com/bitcoin/bitcoin/pull/17391
 37 2019-11-06T01:15:23  *** bitcoin-git has left #bitcoin-core-dev
 38 2019-11-06T01:16:47  *** bitcoin-git has joined #bitcoin-core-dev
 39 2019-11-06T01:16:47  <bitcoin-git> [bitcoin] MarceloGra closed pull request #17391: 0.8 (master...0.8) https://github.com/bitcoin/bitcoin/pull/17391
 40 2019-11-06T01:16:48  *** bitcoin-git has left #bitcoin-core-dev
 41 2019-11-06T02:07:29  *** Highway61 has joined #bitcoin-core-dev
 42 2019-11-06T02:16:01  *** cryptoIndio has joined #bitcoin-core-dev
 43 2019-11-06T02:19:32  *** cryptoIndio has quit IRC
 44 2019-11-06T02:20:06  *** cryptoIndio has joined #bitcoin-core-dev
 45 2019-11-06T02:32:54  *** kristapsk has quit IRC
 46 2019-11-06T02:32:56  *** kristapsk_ has joined #bitcoin-core-dev
 47 2019-11-06T02:33:27  *** DeanGuss has quit IRC
 48 2019-11-06T02:37:27  *** bitcoin-git has joined #bitcoin-core-dev
 49 2019-11-06T02:37:27  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45e65376ac9e...4e21f72980a7
 50 2019-11-06T02:37:28  <bitcoin-git> bitcoin/master fa7f5a4 MarcoFalke: doc: Update doc/bips.md with recent changes in master
 51 2019-11-06T02:37:28  <bitcoin-git> bitcoin/master 4e21f72 fanquake: Merge #17370: doc: Update doc/bips.md with recent changes in master
 52 2019-11-06T02:37:30  *** bitcoin-git has left #bitcoin-core-dev
 53 2019-11-06T02:37:47  *** bitcoin-git has joined #bitcoin-core-dev
 54 2019-11-06T02:37:47  <bitcoin-git> [bitcoin] fanquake merged pull request #17370: doc: Update doc/bips.md with recent changes in master (master...1911-docBips) https://github.com/bitcoin/bitcoin/pull/17370
 55 2019-11-06T02:37:49  *** bitcoin-git has left #bitcoin-core-dev
 56 2019-11-06T03:00:01  *** chipc has quit IRC
 57 2019-11-06T03:05:24  *** ddustin has joined #bitcoin-core-dev
 58 2019-11-06T03:05:42  *** emilengler_ has joined #bitcoin-core-dev
 59 2019-11-06T03:08:46  *** emilengler has quit IRC
 60 2019-11-06T03:09:44  *** ddustin has quit IRC
 61 2019-11-06T03:11:02  *** nosss2 has joined #bitcoin-core-dev
 62 2019-11-06T03:14:19  *** felixfoertsch23 has joined #bitcoin-core-dev
 63 2019-11-06T03:15:03  *** DeanGuss has joined #bitcoin-core-dev
 64 2019-11-06T03:15:39  *** felixfoertsch has quit IRC
 65 2019-11-06T03:20:56  *** ddustin has joined #bitcoin-core-dev
 66 2019-11-06T03:28:06  *** pinheadmz has joined #bitcoin-core-dev
 67 2019-11-06T03:45:00  *** ddustin has quit IRC
 68 2019-11-06T03:45:38  *** ddustin has joined #bitcoin-core-dev
 69 2019-11-06T03:46:47  *** cryptoIndio has quit IRC
 70 2019-11-06T03:48:30  *** justanotheruser has quit IRC
 71 2019-11-06T03:49:53  *** ddustin has quit IRC
 72 2019-11-06T04:13:45  *** iMast777 has joined #bitcoin-core-dev
 73 2019-11-06T04:17:13  *** Highway61 has quit IRC
 74 2019-11-06T04:20:13  *** Eagle[TM] has joined #bitcoin-core-dev
 75 2019-11-06T04:21:39  *** EagleTM has quit IRC
 76 2019-11-06T04:24:06  *** captjakk has joined #bitcoin-core-dev
 77 2019-11-06T04:28:41  *** cryptoIndio has joined #bitcoin-core-dev
 78 2019-11-06T04:31:07  *** justanotheruser has joined #bitcoin-core-dev
 79 2019-11-06T04:31:28  *** pinheadmz has quit IRC
 80 2019-11-06T05:03:01  *** nosss2 has quit IRC
 81 2019-11-06T05:12:39  *** nosss2 has joined #bitcoin-core-dev
 82 2019-11-06T05:16:51  *** cryptoIn_ has joined #bitcoin-core-dev
 83 2019-11-06T05:16:51  *** cryptoIndio has quit IRC
 84 2019-11-06T05:16:58  *** nosss2 has quit IRC
 85 2019-11-06T05:22:36  *** felixfoertsch23 has quit IRC
 86 2019-11-06T05:22:45  *** felixfoertsch has joined #bitcoin-core-dev
 87 2019-11-06T05:59:01  *** rh0nj has quit IRC
 88 2019-11-06T06:00:01  *** iMast777 has quit IRC
 89 2019-11-06T06:00:09  *** rh0nj has joined #bitcoin-core-dev
 90 2019-11-06T06:01:48  *** CubicEarth has quit IRC
 91 2019-11-06T06:05:56  *** nosss2 has joined #bitcoin-core-dev
 92 2019-11-06T06:06:47  *** gribble has quit IRC
 93 2019-11-06T06:06:59  *** thoragh has quit IRC
 94 2019-11-06T06:10:41  *** nosss2 has quit IRC
 95 2019-11-06T06:15:17  *** nosss2 has joined #bitcoin-core-dev
 96 2019-11-06T06:15:28  *** nhandler1 has joined #bitcoin-core-dev
 97 2019-11-06T06:19:39  *** nosss2 has quit IRC
 98 2019-11-06T06:22:35  *** nosss2 has joined #bitcoin-core-dev
 99 2019-11-06T06:25:49  *** cryptoIn_ has quit IRC
100 2019-11-06T06:27:31  *** nosss2 has quit IRC
101 2019-11-06T06:28:53  *** nosss2 has joined #bitcoin-core-dev
102 2019-11-06T06:31:00  *** gribble has joined #bitcoin-core-dev
103 2019-11-06T06:33:29  *** nosss2 has quit IRC
104 2019-11-06T06:38:30  *** nosss2 has joined #bitcoin-core-dev
105 2019-11-06T06:43:22  *** nosss2 has quit IRC
106 2019-11-06T06:44:29  *** ghost43 has quit IRC
107 2019-11-06T06:47:48  *** ghost43 has joined #bitcoin-core-dev
108 2019-11-06T06:48:35  *** nosss2 has joined #bitcoin-core-dev
109 2019-11-06T06:53:08  *** nosss2 has quit IRC
110 2019-11-06T06:55:01  *** nosss2 has joined #bitcoin-core-dev
111 2019-11-06T06:55:09  *** Karyon has quit IRC
112 2019-11-06T06:55:55  *** alko89 has joined #bitcoin-core-dev
113 2019-11-06T06:59:54  *** nosss2 has quit IRC
114 2019-11-06T07:01:02  *** Deacyde has quit IRC
115 2019-11-06T07:01:30  *** Deacyde has joined #bitcoin-core-dev
116 2019-11-06T07:08:39  *** nosss2 has joined #bitcoin-core-dev
117 2019-11-06T07:13:35  *** nosss2 has quit IRC
118 2019-11-06T07:15:15  *** andytoshi has quit IRC
119 2019-11-06T07:15:26  *** Eagle[TM] has quit IRC
120 2019-11-06T07:17:34  *** nosss2 has joined #bitcoin-core-dev
121 2019-11-06T07:25:06  *** nosss2 has quit IRC
122 2019-11-06T07:31:02  *** Karyon has joined #bitcoin-core-dev
123 2019-11-06T07:39:03  *** nosss2 has joined #bitcoin-core-dev
124 2019-11-06T07:43:14  *** nosss2 has quit IRC
125 2019-11-06T07:56:27  *** tsujp has quit IRC
126 2019-11-06T07:58:06  *** tsujp has joined #bitcoin-core-dev
127 2019-11-06T07:59:04  *** nosss2 has joined #bitcoin-core-dev
128 2019-11-06T08:03:52  *** nosss2 has quit IRC
129 2019-11-06T08:04:26  *** nosss2 has joined #bitcoin-core-dev
130 2019-11-06T08:07:01  *** TheHoliestRoger has quit IRC
131 2019-11-06T08:07:48  *** TheHoliestRoger has joined #bitcoin-core-dev
132 2019-11-06T08:08:30  *** nosss2 has quit IRC
133 2019-11-06T08:13:28  *** nosss2 has joined #bitcoin-core-dev
134 2019-11-06T08:15:16  *** laptop500 has joined #bitcoin-core-dev
135 2019-11-06T08:18:47  *** nosss2 has quit IRC
136 2019-11-06T08:23:27  *** nosss2 has joined #bitcoin-core-dev
137 2019-11-06T08:27:52  *** nosss2 has quit IRC
138 2019-11-06T08:31:10  *** nosss2 has joined #bitcoin-core-dev
139 2019-11-06T08:35:36  *** nosss2 has quit IRC
140 2019-11-06T08:39:51  *** nosss2 has joined #bitcoin-core-dev
141 2019-11-06T08:39:55  *** laptop500 has quit IRC
142 2019-11-06T08:42:38  *** sdaftuar has quit IRC
143 2019-11-06T08:43:01  *** sdaftuar has joined #bitcoin-core-dev
144 2019-11-06T08:43:57  *** nosss2 has quit IRC
145 2019-11-06T08:46:54  *** timothy has joined #bitcoin-core-dev
146 2019-11-06T08:52:43  *** marcoagner has joined #bitcoin-core-dev
147 2019-11-06T08:54:17  *** bitcoin-git has joined #bitcoin-core-dev
148 2019-11-06T08:54:18  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4e21f72980a7...224c19645fa0
149 2019-11-06T08:54:18  <bitcoin-git> bitcoin/master 3645e4c Russell Yanofsky: Add missing newline in util_ChainMerge test
150 2019-11-06T08:54:19  <bitcoin-git> bitcoin/master 224c196 Wladimir J. van der Laan: Merge #17388: Add missing newline in util_ChainMerge test
151 2019-11-06T08:54:23  *** bitcoin-git has left #bitcoin-core-dev
152 2019-11-06T08:54:42  *** bitcoin-git has joined #bitcoin-core-dev
153 2019-11-06T08:54:42  <bitcoin-git> [bitcoin] laanwj merged pull request #17388: Add missing newline in util_ChainMerge test (master...pr/chainmerge-nl) https://github.com/bitcoin/bitcoin/pull/17388
154 2019-11-06T08:54:53  *** bitcoin-git has left #bitcoin-core-dev
155 2019-11-06T08:57:23  *** nosss2 has joined #bitcoin-core-dev
156 2019-11-06T08:59:53  *** b10c has joined #bitcoin-core-dev
157 2019-11-06T09:00:01  *** nhandler1 has quit IRC
158 2019-11-06T09:02:11  *** nosss2 has quit IRC
159 2019-11-06T09:04:07  *** bitcoin-git has joined #bitcoin-core-dev
160 2019-11-06T09:04:07  <bitcoin-git> [bitcoin] laanwj closed pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
161 2019-11-06T09:04:08  *** bitcoin-git has left #bitcoin-core-dev
162 2019-11-06T09:05:56  *** laptop500 has joined #bitcoin-core-dev
163 2019-11-06T09:11:39  *** nosss2 has joined #bitcoin-core-dev
164 2019-11-06T09:12:53  *** IGHOR has quit IRC
165 2019-11-06T09:15:42  *** nosss2 has quit IRC
166 2019-11-06T09:18:01  *** pabelanger1 has joined #bitcoin-core-dev
167 2019-11-06T09:18:22  *** wxss has quit IRC
168 2019-11-06T09:28:15  *** willcl_ark has quit IRC
169 2019-11-06T09:29:09  *** nosss2 has joined #bitcoin-core-dev
170 2019-11-06T09:30:54  *** IGHOR has joined #bitcoin-core-dev
171 2019-11-06T09:33:34  *** nosss2 has quit IRC
172 2019-11-06T09:44:06  *** willcl_ark has joined #bitcoin-core-dev
173 2019-11-06T09:48:17  *** nosss2 has joined #bitcoin-core-dev
174 2019-11-06T09:52:56  *** nosss2 has quit IRC
175 2019-11-06T09:55:09  *** laptop500 has quit IRC
176 2019-11-06T10:01:55  <wumpus> re: leveldb and suggest-override warnings, can we somehow get leveldb upstream to use 'override'
177 2019-11-06T10:02:06  <wumpus> this would be better for them and us
178 2019-11-06T10:02:10  *** nosss2 has joined #bitcoin-core-dev
179 2019-11-06T10:03:14  <wumpus> oh it's already in? https://github.com/google/leveldb/commit/28e6d23
180 2019-11-06T10:05:10  *** bitcoin-git has joined #bitcoin-core-dev
181 2019-11-06T10:05:11  <bitcoin-git> [bitcoin] gr0kchain opened pull request #17393: Updated config file to include regtest (master...patch-2) https://github.com/bitcoin/bitcoin/pull/17393
182 2019-11-06T10:05:11  <wumpus> how does this work, if I wanted to update leveldb to upstream, I guess I first need to update https://github.com/bitcoin-core/leveldb?
183 2019-11-06T10:05:12  *** bitcoin-git has left #bitcoin-core-dev
184 2019-11-06T10:06:57  *** nosss2 has quit IRC
185 2019-11-06T10:07:47  *** bitcoin-git has joined #bitcoin-core-dev
186 2019-11-06T10:07:47  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/224c19645fa0...7967104aee05
187 2019-11-06T10:07:48  <bitcoin-git> bitcoin/master 3d05d33 fanquake: cli: fix -getinfo output when compiled with no wallet
188 2019-11-06T10:07:48  <bitcoin-git> bitcoin/master 7967104 Wladimir J. van der Laan: Merge #17368: cli: fix -getinfo output when compiled with no wallet
189 2019-11-06T10:07:50  *** bitcoin-git has left #bitcoin-core-dev
190 2019-11-06T10:08:07  *** bitcoin-git has joined #bitcoin-core-dev
191 2019-11-06T10:08:07  <bitcoin-git> [bitcoin] laanwj merged pull request #17368: cli: fix -getinfo output when compiled with no wallet (master...fix_getinfo_no_wallet) https://github.com/bitcoin/bitcoin/pull/17368
192 2019-11-06T10:08:08  *** bitcoin-git has left #bitcoin-core-dev
193 2019-11-06T10:09:00  <aj> wumpus: looks like that's how you did it in the past?
194 2019-11-06T10:09:15  *** belcher has quit IRC
195 2019-11-06T10:09:23  <wumpus> oh crap the trees have diverged quite a lot
196 2019-11-06T10:09:34  <wumpus> aj: yes, it seems so! it was long ago
197 2019-11-06T10:10:18  <aj> wumpus: oh, are we maintaining patches on leveldb?
198 2019-11-06T10:11:07  <wumpus> yes for windows support mainly
199 2019-11-06T10:11:52  *** bitcoin-git has joined #bitcoin-core-dev
200 2019-11-06T10:11:53  <bitcoin-git> [bitcoin] sipsorcery closed pull request #17364: Updated appveyor config for VS2019 and Qt5.9.8 (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
201 2019-11-06T10:11:54  *** bitcoin-git has left #bitcoin-core-dev
202 2019-11-06T10:12:38  <wumpus> woohoo, let's create an issue about it
203 2019-11-06T10:21:29  *** bitcoin-git has joined #bitcoin-core-dev
204 2019-11-06T10:21:29  <bitcoin-git> [bitcoin] sipsorcery reopened pull request #17364: Updated appveyor config for VS2019 and Qt5.9.8 (master...vs2019_oct31) https://github.com/bitcoin/bitcoin/pull/17364
205 2019-11-06T10:21:30  *** bitcoin-git has left #bitcoin-core-dev
206 2019-11-06T10:24:24  *** nosss2 has joined #bitcoin-core-dev
207 2019-11-06T10:28:51  *** nosss2 has quit IRC
208 2019-11-06T10:31:26  *** jonatack has joined #bitcoin-core-dev
209 2019-11-06T10:41:35  <wumpus> I wonder if there is a way to disable the github editing interface (so to create patches from the web site) for a repostiory
210 2019-11-06T10:42:20  *** nosss2 has joined #bitcoin-core-dev
211 2019-11-06T10:42:23  <wumpus> seems always to be the people we have to explain how squashing works, or that open a new PR for every change in their change
212 2019-11-06T10:46:26  *** nosss2 has quit IRC
213 2019-11-06T10:51:22  *** nosss2 has joined #bitcoin-core-dev
214 2019-11-06T10:56:12  *** nosss2 has quit IRC
215 2019-11-06T10:57:50  <wumpus> re: leveldb upstream merge https://github.com/bitcoin-core/leveldb/issues/25
216 2019-11-06T11:02:51  <wumpus> is it possible to do git conflict resolution as a series of commits instead of in the merge commit?
217 2019-11-06T11:03:04  *** nosss2 has joined #bitcoin-core-dev
218 2019-11-06T11:05:21  <wumpus> e.g. what is the best way to document the conflict resolution step by step and make it reviewable
219 2019-11-06T11:06:26  *** timothy has quit IRC
220 2019-11-06T11:07:55  *** nosss2 has quit IRC
221 2019-11-06T11:11:17  *** thoragh has joined #bitcoin-core-dev
222 2019-11-06T11:15:52  <wumpus> why is fixing this macos background image giving so much trouble?
223 2019-11-06T11:17:25  *** nosss2 has joined #bitcoin-core-dev
224 2019-11-06T11:21:52  *** nosss2 has quit IRC
225 2019-11-06T11:23:46  *** laptop500 has joined #bitcoin-core-dev
226 2019-11-06T11:25:42  <jonatack> A look in GH help didn't turn up anything wrt disabling the GH editing interface. Agree it would be helpful to be able to.
227 2019-11-06T11:26:02  <wumpus> jonatack: couldn't find it either :(
228 2019-11-06T11:26:03  *** nosss2 has joined #bitcoin-core-dev
229 2019-11-06T11:27:29  *** timothy has joined #bitcoin-core-dev
230 2019-11-06T11:28:04  <wumpus> nosss2: please fix your link, you've been reconnecting constantly over the last few days
231 2019-11-06T11:34:15  *** nosss2 has quit IRC
232 2019-11-06T11:34:32  <wumpus> jonatack: the main issue there is that the github editor pretends to be a user friendly git frontend, but then doesn't provide the tools (such as squashing) to make high-quality PRs
233 2019-11-06T11:35:16  <wumpus> I don't think the idea behind it is wrong, it's just, a typical user trap, and we end up having to explain how to use git to people
234 2019-11-06T11:36:38  <elichai2> I remember there was a specific channel for CIs but anyway, we can potentially use travis to test also arm+arm64! https://blog.travis-ci.com/2019-10-07-multi-cpu-architecture-support
235 2019-11-06T11:36:49  <wumpus> elichai2: we already do!
236 2019-11-06T11:36:58  <elichai2> wumpus: really? lol
237 2019-11-06T11:37:07  <elichai2> I thought this was a really new feature hehe
238 2019-11-06T11:37:17  <wumpus> it is, but MarcoFalke is fast
239 2019-11-06T11:37:21  <elichai2> :)
240 2019-11-06T11:38:23  <wumpus> see e.g. https://travis-ci.org/bitcoin/bitcoin/builds/607861014?utm_source=github_status&utm_medium=notification, the topmost test build is arm64 now
241 2019-11-06T11:39:49  <wumpus> (strictly, it builds for arm32 as that's a slightly more error-prone architecture, but that executes that natively on arm64)
242 2019-11-06T11:44:15  *** IGHOR has quit IRC
243 2019-11-06T11:45:31  <wumpus> is appveyor stuck?
244 2019-11-06T11:45:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
245 2019-11-06T11:46:10  <wumpus> some PRs have been pending since last night
246 2019-11-06T11:53:15  *** real_or_random has quit IRC
247 2019-11-06T11:55:33  *** real_or_random has joined #bitcoin-core-dev
248 2019-11-06T11:57:01  *** nosss2 has joined #bitcoin-core-dev
249 2019-11-06T11:59:30  *** IGHOR has joined #bitcoin-core-dev
250 2019-11-06T12:00:02  *** pabelanger1 has quit IRC
251 2019-11-06T12:01:34  *** nosss2 has quit IRC
252 2019-11-06T12:06:30  *** justanotheruser has quit IRC
253 2019-11-06T12:12:28  *** kljasdfvv has quit IRC
254 2019-11-06T12:12:35  *** nosss2 has joined #bitcoin-core-dev
255 2019-11-06T12:12:52  *** kljasdfvv has joined #bitcoin-core-dev
256 2019-11-06T12:13:08  *** rosseaux1 has joined #bitcoin-core-dev
257 2019-11-06T12:13:58  *** IGHOR has quit IRC
258 2019-11-06T12:16:50  *** nosss2 has quit IRC
259 2019-11-06T12:18:07  *** nosss2 has joined #bitcoin-core-dev
260 2019-11-06T12:18:47  *** laptop500 has quit IRC
261 2019-11-06T12:22:42  *** diogosergio has joined #bitcoin-core-dev
262 2019-11-06T12:23:09  *** nosss2 has quit IRC
263 2019-11-06T12:33:42  *** nosss2 has joined #bitcoin-core-dev
264 2019-11-06T12:37:07  *** Highway61 has joined #bitcoin-core-dev
265 2019-11-06T12:43:00  *** bitcoin-git has joined #bitcoin-core-dev
266 2019-11-06T12:43:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7967104aee05...22a58811d4ee
267 2019-11-06T12:43:02  <bitcoin-git> bitcoin/master 2ad74b7 Hennadii Stepanov: doc: Add ShellCheck to lint tests dependencies
268 2019-11-06T12:43:02  <bitcoin-git> bitcoin/master 80c9e66 Hennadii Stepanov: build: Remove install command samples
269 2019-11-06T12:43:03  <bitcoin-git> bitcoin/master 22a5881 MarcoFalke: Merge #17353: doc: Add ShellCheck to lint tests dependencies
270 2019-11-06T12:43:05  *** bitcoin-git has left #bitcoin-core-dev
271 2019-11-06T12:43:20  *** bitcoin-git has joined #bitcoin-core-dev
272 2019-11-06T12:43:20  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17353: doc: Add ShellCheck to lint tests dependencies (master...20191102-lint-dependencies) https://github.com/bitcoin/bitcoin/pull/17353
273 2019-11-06T12:43:22  *** bitcoin-git has left #bitcoin-core-dev
274 2019-11-06T12:45:57  *** nosss2 has quit IRC
275 2019-11-06T12:54:11  *** Chris_Stewart_5 has quit IRC
276 2019-11-06T12:55:15  *** nosss2 has joined #bitcoin-core-dev
277 2019-11-06T12:59:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
278 2019-11-06T13:00:02  <jonatack> wumpus: appveyor was throwing errors possibly related to merged PR #17357 "bech32_tests.obj : error LNK2001: unresolved external symbol "bool __cdecl CaseInsensitiveEqual"
279 2019-11-06T13:00:04  <gribble> https://github.com/bitcoin/bitcoin/issues/17357 | tests: Add fuzzing harness for Bech32 encoding/decoding by practicalswift · Pull Request #17357 · bitcoin/bitcoin · GitHub
280 2019-11-06T13:00:14  *** nosss2 has quit IRC
281 2019-11-06T13:01:12  *** bitcoin-git has joined #bitcoin-core-dev
282 2019-11-06T13:01:12  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22a58811d4ee...86771d431054
283 2019-11-06T13:01:13  <bitcoin-git> bitcoin/master 7b78b8d Michael Folkson: doc: Add template for good first issues
284 2019-11-06T13:01:13  <bitcoin-git> bitcoin/master 86771d4 Wladimir J. van der Laan: Merge #17339: doc: Add template for good first issues
285 2019-11-06T13:01:15  *** bitcoin-git has left #bitcoin-core-dev
286 2019-11-06T13:01:32  *** bitcoin-git has joined #bitcoin-core-dev
287 2019-11-06T13:01:32  <bitcoin-git> [bitcoin] laanwj merged pull request #17339: doc: Add template for good first issues (master...20191101-first-issue) https://github.com/bitcoin/bitcoin/pull/17339
288 2019-11-06T13:01:33  *** bitcoin-git has left #bitcoin-core-dev
289 2019-11-06T13:01:39  *** nosss2 has joined #bitcoin-core-dev
290 2019-11-06T13:06:16  *** nosss2 has quit IRC
291 2019-11-06T13:07:37  *** jonatack has quit IRC
292 2019-11-06T13:12:08  *** nosss2 has joined #bitcoin-core-dev
293 2019-11-06T13:14:25  <wumpus> nosss2: please fix your connection or I'll have to ban your for now, these constant ping timeouts generate too much noise
294 2019-11-06T13:14:52  *** justanotheruser has joined #bitcoin-core-dev
295 2019-11-06T13:15:31  *** nosss2 has quit IRC
296 2019-11-06T13:16:13  *** nosss2 has joined #bitcoin-core-dev
297 2019-11-06T13:20:17  *** nosss2 has quit IRC
298 2019-11-06T13:28:06  *** nosss2 has joined #bitcoin-core-dev
299 2019-11-06T13:28:20  *** ChanServ sets mode: +o wumpus
300 2019-11-06T13:29:59  *** wumpus sets mode: +b *!*@gateway/vpn/privateinternetaccess/nosss2
301 2019-11-06T13:30:07  *** ChanServ sets mode: -o wumpus
302 2019-11-06T13:30:43  <wumpus> is there any way to add a comment to a ban here? or make it temporary?
303 2019-11-06T13:30:58  *** diogosergio has quit IRC
304 2019-11-06T13:32:50  *** nosss2 has quit IRC
305 2019-11-06T13:44:33  *** Highway61 has quit IRC
306 2019-11-06T13:51:15  *** lightlike has joined #bitcoin-core-dev
307 2019-11-06T14:05:53  *** Chris_Stewart_5 has quit IRC
308 2019-11-06T14:08:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
309 2019-11-06T14:11:54  *** IGHOR has joined #bitcoin-core-dev
310 2019-11-06T14:25:00  *** spaced0ut has joined #bitcoin-core-dev
311 2019-11-06T14:29:55  *** jonatack has joined #bitcoin-core-dev
312 2019-11-06T14:36:02  *** pinheadmz has joined #bitcoin-core-dev
313 2019-11-06T15:00:01  *** rosseaux1 has quit IRC
314 2019-11-06T15:06:45  *** kristapsk_ has quit IRC
315 2019-11-06T15:14:21  <aj> wumpus: think chanserv should be able to make temporary bans, not sure about comments
316 2019-11-06T15:16:46  *** captjakk has quit IRC
317 2019-11-06T15:17:31  *** WiQert has joined #bitcoin-core-dev
318 2019-11-06T15:17:44  <wumpus> aj: thanks, will check the chanserv docs
319 2019-11-06T15:19:46  *** mdunnio has joined #bitcoin-core-dev
320 2019-11-06T15:22:26  <aj> looks like chanserv akick will accept a reason but isn't temporary?
321 2019-11-06T15:26:18  *** SiAnDoG has joined #bitcoin-core-dev
322 2019-11-06T15:26:24  *** mdunnio has quit IRC
323 2019-11-06T15:27:26  <wumpus> looks like it can do both, !T <time> and reason (always the last part) can both be specified
324 2019-11-06T15:27:45  *** mdunnio has joined #bitcoin-core-dev
325 2019-11-06T15:27:52  *** ChanServ sets mode: +o wumpus
326 2019-11-06T15:28:05  *** wumpus sets mode: -b *!*@gateway/vpn/privateinternetaccess/nosss2
327 2019-11-06T15:28:10  *** ChanServ sets mode: -o wumpus
328 2019-11-06T15:34:49  <jb55> wumpus: don't most people filter those? that would drive me insane.
329 2019-11-06T15:41:36  <arapaho> I agree, ignoring joins/parts/quits could help.
330 2019-11-06T15:43:12  *** nosss2 has joined #bitcoin-core-dev
331 2019-11-06T15:43:58  <wumpus> I don't know what most people do tbh
332 2019-11-06T15:45:32  <wumpus> I definitely know how to filter them, if you mean that, but I prefer not to for channels I'm op in, as those messages can be used for spamming and such
333 2019-11-06T15:46:00  *** goatpig_ is now known as goatpig
334 2019-11-06T15:46:02  <jb55> just not sure about banning someone for protocol noise xD
335 2019-11-06T15:46:14  <jb55> unless it's was purposeful spamming of course ...
336 2019-11-06T15:46:17  <wumpus> sigh... do you really want an argument about htat
337 2019-11-06T15:46:22  <jb55> not really
338 2019-11-06T15:47:17  <wumpus> it's not like I do that daily, this was just getting annoying
339 2019-11-06T15:48:11  *** thoragh has quit IRC
340 2019-11-06T15:49:03  *** soju has joined #bitcoin-core-dev
341 2019-11-06T16:02:01  *** bitcoin-git has joined #bitcoin-core-dev
342 2019-11-06T16:02:02  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/86771d431054...6f4e24735791
343 2019-11-06T16:02:02  <bitcoin-git> bitcoin/master 286f197 Russell Yanofsky: Add util_ArgParsing test
344 2019-11-06T16:02:03  <bitcoin-git> bitcoin/master 6f4e247 Wladimir J. van der Laan: Merge #17390: test: Add util_ArgParsing test
345 2019-11-06T16:02:05  *** bitcoin-git has left #bitcoin-core-dev
346 2019-11-06T16:02:21  *** bitcoin-git has joined #bitcoin-core-dev
347 2019-11-06T16:02:21  <bitcoin-git> [bitcoin] laanwj merged pull request #17390: test: Add util_ArgParsing test (master...pr/argparse-test) https://github.com/bitcoin/bitcoin/pull/17390
348 2019-11-06T16:02:22  *** bitcoin-git has left #bitcoin-core-dev
349 2019-11-06T16:04:36  *** thoragh has joined #bitcoin-core-dev
350 2019-11-06T16:05:21  *** captjakk has joined #bitcoin-core-dev
351 2019-11-06T16:06:25  <wumpus> promag: congrats with getting an emoji into a commit message, dunno if it's a first 😃  https://github.com/bitcoin/bitcoin/commit/6f4e2473579168dffd46d54fa1eedd287395200b
352 2019-11-06T16:06:54  <luke-jr> lol
353 2019-11-06T16:07:35  <sipa> Ĺèŧ ţĥę Ữňîĉởďė çöḿḿịŧš bệğịñ!
354 2019-11-06T16:08:42  <wumpus> hehe
355 2019-11-06T16:08:49  <fanquake> 👀
356 2019-11-06T16:09:28  *** thoragh has quit IRC
357 2019-11-06T16:10:30  <fanquake> Thought #13859 might have had one, but no, that may be the first
358 2019-11-06T16:10:32  <gribble> https://github.com/bitcoin/bitcoin/issues/13859 | qa: Add emojis to test_runner path and wallet filename by MarcoFalke · Pull Request #13859 · bitcoin/bitcoin · GitHub
359 2019-11-06T16:10:45  *** pinheadmz has quit IRC
360 2019-11-06T16:10:59  <luke-jr> 😑
361 2019-11-06T16:11:00  *** mdunnio has quit IRC
362 2019-11-06T16:17:32  *** mdunnio has joined #bitcoin-core-dev
363 2019-11-06T16:18:32  *** captjakk_ has joined #bitcoin-core-dev
364 2019-11-06T16:22:01  *** captjakk has quit IRC
365 2019-11-06T16:23:32  *** lowentropy has quit IRC
366 2019-11-06T16:23:47  *** lowentropy has joined #bitcoin-core-dev
367 2019-11-06T16:26:27  *** thoragh has joined #bitcoin-core-dev
368 2019-11-06T16:29:39  *** bitcoin-git has joined #bitcoin-core-dev
369 2019-11-06T16:29:41  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/6f4e24735791...976cc766c428
370 2019-11-06T16:29:42  <bitcoin-git> bitcoin/master b07b07c Russell Yanofsky: Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp
371 2019-11-06T16:29:42  <bitcoin-git> bitcoin/master 4a0abf6 Russell Yanofsky: Pass CTxDestination to ScriptPubKeyMan::GetMetadata
372 2019-11-06T16:29:43  <bitcoin-git> bitcoin/master 491a599 Russell Yanofsky: Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method
373 2019-11-06T16:29:52  *** bitcoin-git has left #bitcoin-core-dev
374 2019-11-06T16:30:09  *** bitcoin-git has joined #bitcoin-core-dev
375 2019-11-06T16:30:10  <bitcoin-git> [bitcoin] laanwj merged pull request #17381: LegacyScriptPubKeyMan code cleanups (master...pr/keyman-cleanup2) https://github.com/bitcoin/bitcoin/pull/17381
376 2019-11-06T16:30:22  *** bitcoin-git has left #bitcoin-core-dev
377 2019-11-06T16:31:26  *** ddustin has joined #bitcoin-core-dev
378 2019-11-06T16:38:50  *** thoragh has left #bitcoin-core-dev
379 2019-11-06T16:39:53  *** michaelfolkson has joined #bitcoin-core-dev
380 2019-11-06T16:43:37  <promag> wumpus: sorry you can push -f to master :P
381 2019-11-06T16:45:21  *** AaronvanW has joined #bitcoin-core-dev
382 2019-11-06T16:46:10  <wumpus> promag: push -😡
383 2019-11-06T16:47:26  <promag> anyway, I'll stop using emojis :trollface:
384 2019-11-06T16:48:34  <wumpus> I didn't mean it as a "don't do this", just thought it was funny
385 2019-11-06T16:50:09  *** diogosergio has joined #bitcoin-core-dev
386 2019-11-06T16:52:35  <instagibbs> ryanofsky, https://github.com/bitcoin/bitcoin/pull/17258 has all the breadcrumbs necessary in the OP, I think that's plenty of credit
387 2019-11-06T16:53:33  <instagibbs> wonder if there's written down policy for this. I recently revived the explicit feerate PR from someone who disappeared, i actually forgot to give myself any credit in the commits... probably only showed up in the merge commit message
388 2019-11-06T16:53:52  <instagibbs> which again would be enough to do some detective work
389 2019-11-06T16:53:53  *** shesek has joined #bitcoin-core-dev
390 2019-11-06T16:53:53  *** shesek has quit IRC
391 2019-11-06T16:53:53  *** shesek has joined #bitcoin-core-dev
392 2019-11-06T16:54:53  *** Emcy has quit IRC
393 2019-11-06T16:56:56  *** emilengler_ has quit IRC
394 2019-11-06T16:59:32  *** Emcy has joined #bitcoin-core-dev
395 2019-11-06T17:00:18  <wumpus> no, there's no policy for that, in general, just give credit where credit is due and don't be a dick about it
396 2019-11-06T17:01:07  <wumpus> better to over-credit than under
397 2019-11-06T17:02:27  *** emilengler has joined #bitcoin-core-dev
398 2019-11-06T17:06:19  *** bitcoin-git has joined #bitcoin-core-dev
399 2019-11-06T17:06:20  <bitcoin-git> [bitcoin] icota opened pull request #17396: build: modest Android improvements (master...2019-11-android-static-libstdc) https://github.com/bitcoin/bitcoin/pull/17396
400 2019-11-06T17:06:32  *** bitcoin-git has left #bitcoin-core-dev
401 2019-11-06T17:06:42  *** soju has quit IRC
402 2019-11-06T17:07:00  *** captjakk_ has quit IRC
403 2019-11-06T17:07:03  *** Highway61 has joined #bitcoin-core-dev
404 2019-11-06T17:07:35  <wumpus> but also not really sure what ryanofsky's point is here, I mean it's definitely possible to give even more credit than mentioning someone's name in the commit metadata and the commit itself, but what then, I think what count here is that adamjonas did his best to credit
405 2019-11-06T17:08:46  <wumpus> should we be angry at him for not crediting enough?
406 2019-11-06T17:08:53  <luke-jr> instagibbs: git does record the committer independently from the author
407 2019-11-06T17:09:00  <ryanofsky> i'm just saying it is possible to give more credit and explanation than was given, and i usually try to do that by writing comments that give credit
408 2019-11-06T17:09:25  <ryanofsky> i have no opinion on "enough". enough credit for me is usually 0, for other people it may be more
409 2019-11-06T17:09:27  <wumpus> I mean it's never enough
410 2019-11-06T17:09:53  <ryanofsky> wumpus, doubt that is true unless the person is imbalanced or something
411 2019-11-06T17:11:05  <wumpus> yes, but your point is basically 'you can always do more'
412 2019-11-06T17:11:06  <wumpus> sure
413 2019-11-06T17:11:25  <ryanofsky> no, my point is in that specific case, more could have been done
414 2019-11-06T17:11:36  <wumpus> yes, it could
415 2019-11-06T17:11:59  <luke-jr> I suspect Diapolo left over credit issues
416 2019-11-06T17:13:38  *** Highway61 has quit IRC
417 2019-11-06T17:19:53  *** captjakk has joined #bitcoin-core-dev
418 2019-11-06T17:20:29  *** captjakk has joined #bitcoin-core-dev
419 2019-11-06T17:20:51  *** CubicEarth has joined #bitcoin-core-dev
420 2019-11-06T17:21:06  <provoostenator> The merge commit could add Reviewed-by or Acked-by tags?
421 2019-11-06T17:21:06  <MarcoFalke> promag: We should be using more emojis
422 2019-11-06T17:21:39  <MarcoFalke> I will adjust my script to do that. emojis will be signed and timestamped, of course
423 2019-11-06T17:22:52  <luke-jr> replace ACKs/NACKs with emoji codes?
424 2019-11-06T17:24:04  <MarcoFalke> 👍
425 2019-11-06T17:25:00  <luke-jr> (on a serious note, I would find that rather annoying)
426 2019-11-06T17:28:08  *** mdunnio has quit IRC
427 2019-11-06T17:29:03  *** mdunnio has joined #bitcoin-core-dev
428 2019-11-06T17:31:25  *** mdunnio has quit IRC
429 2019-11-06T17:33:01  <aj> MarcoFalke: bech32 but with an alphabet of emojis?
430 2019-11-06T17:33:05  *** mdunnio has joined #bitcoin-core-dev
431 2019-11-06T17:37:03  <MarcoFalke> 🤯
432 2019-11-06T17:37:04  <wumpus> there's at least a base1024 encoding with emoji: https://github.com/keith-turner/ecoji
433 2019-11-06T17:44:00  <luke-jr> MarcoFalke: I see nothing there
434 2019-11-06T17:44:43  *** cncr04s has quit IRC
435 2019-11-06T17:47:36  <wumpus> riot.im e2e uses something like that to cross-verify keys (the idea is that a list of emoji+their names is easier to communicate than say, a hex string)
436 2019-11-06T17:47:50  *** cncr04s has joined #bitcoin-core-dev
437 2019-11-06T17:47:57  *** mdunnio has quit IRC
438 2019-11-06T17:59:37  *** bsm1175321 has joined #bitcoin-core-dev
439 2019-11-06T18:00:02  *** WiQert has quit IRC
440 2019-11-06T18:02:50  *** diogosergio has quit IRC
441 2019-11-06T18:08:30  *** andytoshi has joined #bitcoin-core-dev
442 2019-11-06T18:08:30  *** andytoshi has joined #bitcoin-core-dev
443 2019-11-06T18:11:01  *** michaelfolkson has quit IRC
444 2019-11-06T18:18:55  *** thoragh has joined #bitcoin-core-dev
445 2019-11-06T18:20:14  *** captjakk has quit IRC
446 2019-11-06T18:20:48  *** captjakk has joined #bitcoin-core-dev
447 2019-11-06T18:23:04  *** captjakk has quit IRC
448 2019-11-06T18:27:06  *** ddustin has quit IRC
449 2019-11-06T18:30:13  *** mdunnio has joined #bitcoin-core-dev
450 2019-11-06T18:30:18  *** michaelfolkson has joined #bitcoin-core-dev
451 2019-11-06T18:39:13  *** pinheadmz has joined #bitcoin-core-dev
452 2019-11-06T18:42:21  *** timothy has quit IRC
453 2019-11-06T18:46:23  *** netsoundW has joined #bitcoin-core-dev
454 2019-11-06T18:49:11  *** owowo has quit IRC
455 2019-11-06T18:49:18  *** ovovo has joined #bitcoin-core-dev
456 2019-11-06T18:50:16  *** jarthur has joined #bitcoin-core-dev
457 2019-11-06T18:55:11  *** bitcoin-git has joined #bitcoin-core-dev
458 2019-11-06T18:55:12  <bitcoin-git> [bitcoin] laanwj reopened pull request #17385: refactor: Use our own integer parsing/formatting everywhere (master...2019_11_integer_parsing) https://github.com/bitcoin/bitcoin/pull/17385
459 2019-11-06T18:55:13  *** bitcoin-git has left #bitcoin-core-dev
460 2019-11-06T18:55:58  *** justanotheruser has quit IRC
461 2019-11-06T18:56:59  *** justanotheruser has joined #bitcoin-core-dev
462 2019-11-06T19:03:48  *** ddustin has joined #bitcoin-core-dev
463 2019-11-06T19:10:17  *** captjakk has joined #bitcoin-core-dev
464 2019-11-06T19:11:11  *** captjakk has joined #bitcoin-core-dev
465 2019-11-06T19:14:29  *** captjakk has quit IRC
466 2019-11-06T19:21:57  *** b10c has quit IRC
467 2019-11-06T19:22:31  *** PaulTroon has joined #bitcoin-core-dev
468 2019-11-06T19:28:10  *** PaulTroon has quit IRC
469 2019-11-06T19:28:39  *** PaulTroon has joined #bitcoin-core-dev
470 2019-11-06T19:37:19  *** kristapsk has joined #bitcoin-core-dev
471 2019-11-06T19:43:56  *** PaulTroon has quit IRC
472 2019-11-06T19:44:36  *** PaulTroon has joined #bitcoin-core-dev
473 2019-11-06T19:50:35  *** PaulTroon has quit IRC
474 2019-11-06T19:51:46  *** PaulTroon has joined #bitcoin-core-dev
475 2019-11-06T19:54:08  *** PaulTroon has quit IRC
476 2019-11-06T19:55:35  *** bsm1175321 has quit IRC
477 2019-11-06T20:08:56  *** ddustin has quit IRC
478 2019-11-06T20:09:32  *** ddustin has joined #bitcoin-core-dev
479 2019-11-06T20:13:38  *** ddustin has quit IRC
480 2019-11-06T20:20:05  *** bitcoin-git has joined #bitcoin-core-dev
481 2019-11-06T20:20:07  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/976cc766c428...e65b4160e99f
482 2019-11-06T20:20:07  <bitcoin-git> bitcoin/master 646b593 John Newbery: [tests] Speed up rpc_fundrawtransaction.py
483 2019-11-06T20:20:08  <bitcoin-git> bitcoin/master 9a85052 John Newbery: [tests] Use -whitelist in rpc_fundrawtransaction.py
484 2019-11-06T20:20:09  <bitcoin-git> bitcoin/master af7bae7 John Newbery: [tests] Don't stop-start unnecessarily in rpc_fundrawtransaction.py
485 2019-11-06T20:20:11  *** bitcoin-git has left #bitcoin-core-dev
486 2019-11-06T20:20:25  *** bitcoin-git has joined #bitcoin-core-dev
487 2019-11-06T20:20:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17340: Tests: speed up fundrawtransaction test (master...2019-11-speed-up-fundrawtransaction-test) https://github.com/bitcoin/bitcoin/pull/17340
488 2019-11-06T20:20:26  *** bitcoin-git has left #bitcoin-core-dev
489 2019-11-06T20:24:12  <wumpus> oh nice, there's a env_windows.cpp in the new upstream leveldb, we might be able to stop maintaining our own env_win https://github.com/bitcoin-core/leveldb/pull/26  this handles the file functions and such, it will be a lot of work to test/investigate the differences though
490 2019-11-06T20:25:50  <sipa> nice, and it's not a crazy boost based thing like the old windows branch of leveldb had
491 2019-11-06T20:27:14  <wumpus> yup, no boost at all! it's entirely native
492 2019-11-06T20:29:24  <wumpus> ARM crc32c will be nice too
493 2019-11-06T20:31:43  <sipa> wumpus: so... can we just drop our own fork?
494 2019-11-06T20:32:19  <sipa> (for consistency reasons we may not want to actually do that, but equivalently we can just undo all our local modifications?)
495 2019-11-06T20:32:59  <sipa> since we have our own build system overriding leveldb's, the forced-no-snappy thing can be dealt with there
496 2019-11-06T20:35:17  *** andytoshi has quit IRC
497 2019-11-06T20:36:09  <wumpus> there's some changes that I'd like to keep: the GetName on files, used for diagnostics, the "Do not crash if filesystem can't fsync" patch (handle EINVAL on directory sync), but yes, I'm thinking instead of merging, might as well restart with a small patch stack on upstream
498 2019-11-06T20:37:23  <sipa> right.
499 2019-11-06T20:37:39  <sipa> don't we have some local changes to observe memory usage or so?
500 2019-11-06T20:37:47  <sipa> or was that just something i experimented with
501 2019-11-06T20:37:51  <jnewbery> has there ever been an effort to upstream those small patches?
502 2019-11-06T20:38:22  <wumpus> (also possibly the 1000 to 4096 patch, though if we can use the test interface, it seems we don't need that anymore)
503 2019-11-06T20:38:25  <sipa> jnewbery: i don't think so; leveldb used to be very slow in accepting patches, i think maybe that has improved over the past two years
504 2019-11-06T20:38:55  <wumpus> I've never tried at least
505 2019-11-06T20:39:34  <wumpus> another reason to make a patch stack instead
506 2019-11-06T20:39:50  <wumpus> sipa: I don't remember seeing any memory-related changes, let me see
507 2019-11-06T20:40:43  <wumpus> LOL this is a change we have:
508 2019-11-06T20:40:44  <wumpus> -// where enough posix functionality is available.
509 2019-11-06T20:40:46  <wumpus> +// where enough Posix functionality is available.
510 2019-11-06T20:41:58  <wumpus> yes, the no_snappy thing we can deal with in your build system
511 2019-11-06T20:43:29  *** diogosergio has joined #bitcoin-core-dev
512 2019-11-06T20:47:04  <wumpus> HAVE_SNAPPY Define to 1 if you have Google Snappy. -> should be hardwired to 0 for us, obviously
513 2019-11-06T20:50:14  *** mdunnio has quit IRC
514 2019-11-06T20:50:40  *** diogosergio has quit IRC
515 2019-11-06T20:51:19  <sipa> i'll be very happy if we can actually stop relying on our own weird windows port
516 2019-11-06T20:51:23  <wumpus> no, there's no memory related changes
517 2019-11-06T20:51:32  <sipa> ok.
518 2019-11-06T20:52:30  <wumpus> and same :)
519 2019-11-06T20:56:28  <sipa> seems they even have tests for the windows port!
520 2019-11-06T20:56:41  <sipa> s/port/env/
521 2019-11-06T20:58:05  *** michaelfolkson has quit IRC
522 2019-11-06T20:58:54  *** diogosergio has joined #bitcoin-core-dev
523 2019-11-06T20:59:19  <wumpus> even tests that pass, I'd guess (https://github.com/bitcoin-core/leveldb/issues/8)
524 2019-11-06T21:00:01  *** netsoundW has quit IRC
525 2019-11-06T21:02:13  *** mdunnio has joined #bitcoin-core-dev
526 2019-11-06T21:13:48  <roasbeef> what's the name of the IRC bot y'all use for merges now?
527 2019-11-06T21:17:40  *** jhf has joined #bitcoin-core-dev
528 2019-11-06T21:25:14  <wumpus> roasbeef: we run our own instance of https://github.com/gkrizek/ghi
529 2019-11-06T21:33:37  *** diogosergio has quit IRC
530 2019-11-06T21:36:22  *** belcher has joined #bitcoin-core-dev
531 2019-11-06T21:47:39  <wumpus> I could add channels to the bot, if you'd rather not host your own
532 2019-11-06T21:48:41  *** davterra has joined #bitcoin-core-dev
533 2019-11-06T21:54:47  *** PaulTroon has joined #bitcoin-core-dev
534 2019-11-06T21:55:30  <wumpus> is it possible to do a git merge and simply ignore all your own files to replace them with upstream?
535 2019-11-06T21:56:02  <wumpus> so logically it's a merge but it retains nothing of the original code
536 2019-11-06T21:56:39  <gwillen> wumpus: it looks like you can do "git merge -X theirs":https://stackoverflow.com/questions/173919/is-there-a-theirs-version-of-git-merge-s-ours
537 2019-11-06T21:56:46  <gwillen> wit some caveats
538 2019-11-06T21:57:10  *** mdunnio has quit IRC
539 2019-11-06T21:57:23  <sipa> wumpus: yeah, a merge commit is just a commit that has 2 parents
540 2019-11-06T21:57:28  <sipa> it can effectively do anything
541 2019-11-06T21:57:29  <wumpus> (this is just to make the subtree merge easier, I don't think it'll be happy with a rebase in between)
542 2019-11-06T21:57:36  <wumpus> sipa: gwillen  thanks!
543 2019-11-06T21:57:46  <sipa> including replacing everything with a completely unrelated tree
544 2019-11-06T21:57:59  <gwillen> np!
545 2019-11-06T21:58:05  *** vincenzopalazzo has joined #bitcoin-core-dev
546 2019-11-06T22:00:03  *** PaulTroon has quit IRC
547 2019-11-06T22:04:46  *** andytoshi has joined #bitcoin-core-dev
548 2019-11-06T22:04:47  *** andytoshi has joined #bitcoin-core-dev
549 2019-11-06T22:05:45  *** diogosergio has joined #bitcoin-core-dev
550 2019-11-06T22:07:34  *** vincenzopalazzo has quit IRC
551 2019-11-06T22:19:04  *** nosss2 has quit IRC
552 2019-11-06T22:20:21  *** nosss2 has joined #bitcoin-core-dev
553 2019-11-06T22:24:31  *** pinheadmz has quit IRC
554 2019-11-06T22:25:39  <sipa> wumpus: fwiw, git subtree works fine with undoing commits
555 2019-11-06T22:25:42  <sipa> in the subtree
556 2019-11-06T22:26:31  <sipa> i think we could reasonable create a new branch in bitcoin-core/leveldb which is equal to the google/leveldb one + a few patches
557 2019-11-06T22:26:43  <sipa> and then use git subtree to switch our directory to that
558 2019-11-06T22:32:26  <wumpus> ok, will ook at that, for now I managed to change the PR to revert all our changes then re-apply the three that still matter
559 2019-11-06T22:34:38  <sipa> subtree will in this case just produce a squash commit that has message "Delete commit X; Delete commit Y; Add commit Z; ..."
560 2019-11-06T22:35:04  <sipa> the old and the new tree must have a common ancestor, though
561 2019-11-06T22:43:45  *** spaced0ut has quit IRC
562 2019-11-06T22:44:08  <wumpus> it automatically figures that out? that sounds pretty good
563 2019-11-06T22:44:35  *** Chris_Stewart_5 has quit IRC
564 2019-11-06T22:55:49  *** thoragh has quit IRC
565 2019-11-06T22:56:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
566 2019-11-06T23:08:10  *** bitcoin-git has joined #bitcoin-core-dev
567 2019-11-06T23:08:10  <bitcoin-git> [bitcoin] laanwj opened pull request #17398: WIP: Update leveldb to 1.22+ (master...2019_11_leveldb_upstream) https://github.com/bitcoin/bitcoin/pull/17398
568 2019-11-06T23:08:11  *** bitcoin-git has left #bitcoin-core-dev
569 2019-11-06T23:15:08  *** Chris_Stewart_5 has quit IRC
570 2019-11-06T23:19:00  *** soju has joined #bitcoin-core-dev
571 2019-11-06T23:26:59  <promag> MarcoFalke: you could sort includes too in #17384 🍻
572 2019-11-06T23:27:01  <gribble> https://github.com/bitcoin/bitcoin/issues/17384 | test: Create new test library by MarcoFalke · Pull Request #17384 · bitcoin/bitcoin · GitHub
573 2019-11-06T23:29:15  *** nosss2 has quit IRC
574 2019-11-06T23:48:42  *** marcoagner has quit IRC
575 2019-11-06T23:53:51  *** michaelfolkson has joined #bitcoin-core-dev
576 2019-11-06T23:53:57  *** diogosergio has quit IRC
577 2019-11-06T23:56:21  *** PaulTroon has joined #bitcoin-core-dev
578 2019-11-06T23:56:48  *** michaelfolkson has quit IRC
579 2019-11-06T23:57:39  *** diogosergio has joined #bitcoin-core-dev