12019-11-08T00:00:02 *** wltjr1 has quit IRC
22019-11-08T00:03:17 *** marcoagner has quit IRC
32019-11-08T00:04:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
42019-11-08T00:11:14 *** promag has quit IRC
52019-11-08T00:11:57 *** promag has joined #bitcoin-core-dev
62019-11-08T00:16:30 *** promag has quit IRC
72019-11-08T00:16:37 *** spinza has quit IRC
82019-11-08T00:16:47 *** mdunnio has quit IRC
92019-11-08T00:38:50 *** harrigan has quit IRC
102019-11-08T00:40:03 *** bitcoin-git has joined #bitcoin-core-dev
112019-11-08T00:40:03 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17409: build: Avoid hardcoded libfaketime dir in gitian (master...1911-gitianArm64) https://github.com/bitcoin/bitcoin/pull/17409
122019-11-08T00:40:04 *** bitcoin-git has left #bitcoin-core-dev
132019-11-08T00:43:59 *** tronical1 has joined #bitcoin-core-dev
142019-11-08T00:56:37 *** Chris_Stewart_5 has quit IRC
152019-11-08T01:06:12 *** soju has joined #bitcoin-core-dev
162019-11-08T01:07:53 *** harrigan has joined #bitcoin-core-dev
172019-11-08T01:22:32 *** michaelfolkson has joined #bitcoin-core-dev
182019-11-08T01:27:52 *** soju__ has quit IRC
192019-11-08T01:30:33 *** alko89 has quit IRC
202019-11-08T01:32:13 <wumpus> nice, travis is green for leveldb+crc32b
212019-11-08T01:32:22 *** alko89 has joined #bitcoin-core-dev
222019-11-08T01:33:37 <sipa> wumpus: \o/
232019-11-08T01:37:12 *** justanotheruser has quit IRC
242019-11-08T01:55:25 *** michaelfolkson has quit IRC
252019-11-08T02:08:56 *** jb55 has quit IRC
262019-11-08T02:12:38 *** lightlike has quit IRC
272019-11-08T02:26:13 *** ddustin has joined #bitcoin-core-dev
282019-11-08T02:30:18 *** ddustin has quit IRC
292019-11-08T02:36:56 *** spinza has joined #bitcoin-core-dev
302019-11-08T03:00:01 *** tronical1 has quit IRC
312019-11-08T03:12:35 *** felixfoertsch23 has joined #bitcoin-core-dev
322019-11-08T03:13:36 *** felixfoertsch has quit IRC
332019-11-08T03:17:36 *** mkrautz1 has joined #bitcoin-core-dev
342019-11-08T03:18:05 *** AaronvanW has quit IRC
352019-11-08T03:33:58 *** pinheadmz has joined #bitcoin-core-dev
362019-11-08T03:59:02 *** nosss2 has joined #bitcoin-core-dev
372019-11-08T04:18:29 *** Eagle[TM] has joined #bitcoin-core-dev
382019-11-08T04:20:17 *** EagleTM has quit IRC
392019-11-08T04:48:50 *** rachelfish has joined #bitcoin-core-dev
402019-11-08T04:58:47 *** pinheadmz has quit IRC
412019-11-08T05:07:56 *** nosss2 has quit IRC
422019-11-08T05:21:09 *** felixfoertsch23 has quit IRC
432019-11-08T05:21:20 *** felixfoertsch has joined #bitcoin-core-dev
442019-11-08T05:25:05 *** kristapsk has quit IRC
452019-11-08T05:25:28 *** kristapsk has joined #bitcoin-core-dev
462019-11-08T06:00:02 *** mkrautz1 has quit IRC
472019-11-08T06:08:10 *** AaronvanW has joined #bitcoin-core-dev
482019-11-08T06:14:53 *** Karyon has quit IRC
492019-11-08T06:19:38 *** bastion-tester has quit IRC
502019-11-08T06:31:50 *** bastion-tester has joined #bitcoin-core-dev
512019-11-08T06:38:49 *** AaronvanW has quit IRC
522019-11-08T06:39:11 *** Karyon has joined #bitcoin-core-dev
532019-11-08T06:45:59 *** armin76 has joined #bitcoin-core-dev
542019-11-08T07:12:34 *** promag has joined #bitcoin-core-dev
552019-11-08T07:16:58 *** promag has quit IRC
562019-11-08T07:23:01 *** murrayn has quit IRC
572019-11-08T07:29:28 *** bitcoin-git has joined #bitcoin-core-dev
582019-11-08T07:29:29 <bitcoin-git> [bitcoin] laanwj opened pull request #17410: Rename `db` log category to `walletdb` (like `coindb`) (master...2019_11_rename_db_log_category) https://github.com/bitcoin/bitcoin/pull/17410
592019-11-08T07:29:43 *** bitcoin-git has left #bitcoin-core-dev
602019-11-08T07:31:54 *** Eagle[TM] has quit IRC
612019-11-08T08:12:31 *** bitcoin-git has joined #bitcoin-core-dev
622019-11-08T08:12:31 <bitcoin-git> [bitcoin] laanwj opened pull request #17411: doc: Add some better examples for scripted diff (master...2019_11_scripted_diff_examples) https://github.com/bitcoin/bitcoin/pull/17411
632019-11-08T08:12:32 *** bitcoin-git has left #bitcoin-core-dev
642019-11-08T08:17:28 *** chile has joined #bitcoin-core-dev
652019-11-08T08:18:27 *** chile has joined #bitcoin-core-dev
662019-11-08T08:24:53 *** chile has quit IRC
672019-11-08T08:25:06 *** bitcoin-git has joined #bitcoin-core-dev
682019-11-08T08:25:07 <bitcoin-git> [bitcoin] Sjors opened pull request #17412: Add Boost::Process to AppVeyor dependencies (master...2019/11/msvc_boost_process) https://github.com/bitcoin/bitcoin/pull/17412
692019-11-08T08:25:07 *** bitcoin-git has left #bitcoin-core-dev
702019-11-08T08:27:36 *** b10c has joined #bitcoin-core-dev
712019-11-08T08:28:25 *** EagleTM has joined #bitcoin-core-dev
722019-11-08T08:31:07 *** AaronvanW has joined #bitcoin-core-dev
732019-11-08T08:35:22 *** marcoagner has joined #bitcoin-core-dev
742019-11-08T08:57:01 *** murray has joined #bitcoin-core-dev
752019-11-08T08:57:25 *** murray is now known as Guest60388
762019-11-08T08:57:44 *** Guest60388 has left #bitcoin-core-dev
772019-11-08T08:58:09 *** murrayn has joined #bitcoin-core-dev
782019-11-08T09:00:01 *** armin76 has quit IRC
792019-11-08T09:02:03 <wumpus> so yes maybe it's better to sort out the linters instead of moving around things in the tree, trying with "good first issue"... https://github.com/bitcoin/bitcoin/issues/17413
802019-11-08T09:10:28 *** Aaronvan_ has joined #bitcoin-core-dev
812019-11-08T09:12:20 <wumpus> is there a way to see what appveyor is currently doing? I see only 'queued' PRs, even under history
822019-11-08T09:13:19 <wumpus> "Current build" is in queued state too
832019-11-08T09:13:40 *** AaronvanW has quit IRC
842019-11-08T09:24:29 <wumpus> BlueMatt: https://github.com/bitcoin/bitcoin/pull/15382#issuecomment-551451359 kind of reminds me what has bothing me about the rust stuff; I think the build system there also needs to focus on features, not "use rust or not", don't group them on programmings language/dependency; if someone wants to enable a feature that happens to be implemented in rust, request them to install a rust compiler :)
852019-11-08T09:25:32 <wumpus> this is also why we have with-gui, not with-qt
862019-11-08T09:28:53 <wumpus> though admittedly, the default there is auto, which sets it to enabled or not based on whether qt development package is installed, which is used as a proxy for 'is this a headless server or a desktop', I guess ...
872019-11-08T09:29:29 <wumpus> as said I'm somewhat skeptical at those kinds of attempts to detect what the user wants
882019-11-08T09:34:35 *** Zenton has joined #bitcoin-core-dev
892019-11-08T09:42:37 *** promag has joined #bitcoin-core-dev
902019-11-08T09:45:25 *** timothy has joined #bitcoin-core-dev
912019-11-08T09:48:17 *** n3glv1 has joined #bitcoin-core-dev
922019-11-08T10:00:55 *** AaronvanW has joined #bitcoin-core-dev
932019-11-08T10:04:14 *** Aaronvan_ has quit IRC
942019-11-08T10:16:15 *** EagleTM has quit IRC
952019-11-08T10:19:32 <elichai2> wumpus: I actually don't completely on that. for a long time I didn't understood a thing about bitcoin's build system and/or code and I liked that it installed basically everything I could manage (I'm one of those freaks who likes the GUI :) )
962019-11-08T10:19:32 <elichai2> I think currently the build system is bloated with options such that there's no way for a naive user to even *know* what he can enable/disable
972019-11-08T10:20:10 <elichai2> (though maybe auto detection isn't the right answer but splitting features into "normal" and "advanced" is the better answer )
982019-11-08T10:23:53 *** bitcoin-git has joined #bitcoin-core-dev
992019-11-08T10:23:54 <bitcoin-git> [bitcoin] meshcollider pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/2fb6140d585f...99ab3a72c5ff
1002019-11-08T10:23:55 <bitcoin-git> bitcoin/master 10b4729 Antoine Riard: Pass block height in Chain::BlockConnected/Chain::BlockDisconnected
1012019-11-08T10:23:56 <bitcoin-git> bitcoin/master 5aacc3e Antoine Riard: Add m_last_block_processed_height field in CWallet
1022019-11-08T10:23:57 <bitcoin-git> bitcoin/master 9700fcb Antoine Riard: Replace CWalletTx::SetConf by Confirmation initialization list
1032019-11-08T10:23:58 *** bitcoin-git has left #bitcoin-core-dev
1042019-11-08T10:24:29 *** bitcoin-git has joined #bitcoin-core-dev
1052019-11-08T10:24:29 <bitcoin-git> [bitcoin] meshcollider merged pull request #15931: Remove GetDepthInMainChain dependency on locked chain interface (master...2019-04-remove-external-locking) https://github.com/bitcoin/bitcoin/pull/15931
1062019-11-08T10:24:30 *** bitcoin-git has left #bitcoin-core-dev
1072019-11-08T10:25:53 <wumpus> elichai2: sure, but how does features things based on what dependencies you happen to have installed help with that?
1082019-11-08T10:26:00 <wumpus> picking features*
1092019-11-08T10:26:41 <elichai2> wumpus: that you somehow ends up with a lot of features that at least some of them you want? :P
1102019-11-08T10:27:15 <elichai2> (i.e. I remember installing qt and then compiling core so I can get the GUI, and if I didn't get it I knew my QT is missing)
1112019-11-08T10:27:16 <wumpus> like, for example the wallet, we assume someone wants a wallet unless --disable-wallet is provided. I think that is great.
1122019-11-08T10:27:37 <wumpus> wouldn't it be wtf if it was determined based on whether someone has bdb headers installed
1132019-11-08T10:28:05 <wumpus> no, if you don't have bdb headers installed, and don't provide --disable-wallet, you get a clear message
1142019-11-08T10:28:35 <wumpus> so you can choose, you want a wallet and install the headers, or disable it and don't
1152019-11-08T10:30:03 <wumpus> a bloated build system is a different problem, and I agree it wouldn't be great if you would have to do that for 500 different things, but choosing automatically based on the phase of the moon just *hides* that problem
1162019-11-08T10:30:30 <elichai2> yeah but I think for the wallet 90% of users want it. GUI 50%, and then the rest idk (even those this is 100% guess according to users I know heh)
1172019-11-08T10:33:50 <wumpus> for a while I was frustrated that for example, tor wouldn't pass configure unless some documentation building thing is installed, or --no-docs is passed. But I think it makes sense now. Most people (should) want documentation, and having *random documentation generator* not installed doesn't automatically mean you don't.
1182019-11-08T10:35:19 <wumpus> and if you really don't, then tell it...
1192019-11-08T10:35:39 *** davterra has quit IRC
1202019-11-08T10:37:04 *** davterra has joined #bitcoin-core-dev
1212019-11-08T10:38:21 <wumpus> the only thing that makes this behavior somewhat acceptable is the summary at the end of configure :)
1222019-11-08T10:41:34 <wumpus> because at least you see what automatic choices it made, before you start building and conclude you're building a GUI you don't want, for ex.
1232019-11-08T10:48:06 <elichai2> yeah. if you're already venting, I hate that setting CFLAGS/CPPFLAGS/CC/CXX can sometimes break the configure
1242019-11-08T10:49:13 *** afk11 has quit IRC
1252019-11-08T10:49:14 *** kristapsk has quit IRC
1262019-11-08T10:49:35 *** kristapsk has joined #bitcoin-core-dev
1272019-11-08T10:49:38 *** afk11 has joined #bitcoin-core-dev
1282019-11-08T11:08:24 <wumpus> well if you set some insane flags like --no-stdlib that's expected :)
1292019-11-08T11:34:24 *** andytoshi has quit IRC
1302019-11-08T11:52:19 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1312019-11-08T11:57:33 <elichai2> It happened to me a when I tried to switch a linker but ð¤·ââï¸
1322019-11-08T11:58:13 *** lightlike has joined #bitcoin-core-dev
1332019-11-08T11:59:26 *** michaelfolkson has joined #bitcoin-core-dev
1342019-11-08T12:00:02 *** n3glv1 has quit IRC
1352019-11-08T12:05:32 *** michaelfolkson has quit IRC
1362019-11-08T12:08:24 *** michaelfolkson has joined #bitcoin-core-dev
1372019-11-08T12:17:41 *** hmachado has joined #bitcoin-core-dev
1382019-11-08T12:41:22 *** bastion-tester has quit IRC
1392019-11-08T12:43:53 *** bastion-tester has joined #bitcoin-core-dev
1402019-11-08T12:45:30 *** Chris_Stewart_5 has quit IRC
1412019-11-08T12:46:15 *** dviola has joined #bitcoin-core-dev
1422019-11-08T12:55:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1432019-11-08T13:00:42 *** michaelfolkson has quit IRC
1442019-11-08T13:01:25 *** michaelfolkson has joined #bitcoin-core-dev
1452019-11-08T13:13:20 *** pinheadmz has joined #bitcoin-core-dev
1462019-11-08T13:15:28 *** sdaftuar has quit IRC
1472019-11-08T13:15:44 *** dviola has quit IRC
1482019-11-08T13:17:13 *** sdaftuar has joined #bitcoin-core-dev
1492019-11-08T13:31:43 *** pinheadmz has quit IRC
1502019-11-08T13:42:49 *** bitcoin-git has joined #bitcoin-core-dev
1512019-11-08T13:42:49 <bitcoin-git> [bitcoin] sipsorcery opened pull request #17416: Appveyor improvement - adds check for all required vcpkg packages (master...check-missing-vcpkgs) https://github.com/bitcoin/bitcoin/pull/17416
1522019-11-08T13:42:50 *** bitcoin-git has left #bitcoin-core-dev
1532019-11-08T13:45:13 *** bitcoin-git has joined #bitcoin-core-dev
1542019-11-08T13:45:14 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/99ab3a72c5ff...4a3b6f47cd75
1552019-11-08T13:45:14 <bitcoin-git> bitcoin/master 01f45dd João Barbosa: wallet: Avoid recursive lock in CWallet::SetUsedDestinationState
1562019-11-08T13:45:15 <bitcoin-git> bitcoin/master 0b75a7f João Barbosa: wallet: Reuse existing batch in CWallet::SetUsedDestinationState
1572019-11-08T13:45:15 <bitcoin-git> bitcoin/master 4a3b6f4 fanquake: Merge #17354: wallet: Tidy CWallet::SetUsedDestinationState
1582019-11-08T13:45:17 *** bitcoin-git has left #bitcoin-core-dev
1592019-11-08T13:45:33 *** bitcoin-git has joined #bitcoin-core-dev
1602019-11-08T13:45:34 <bitcoin-git> [bitcoin] fanquake merged pull request #17354: wallet: Tidy CWallet::SetUsedDestinationState (master...2019-11-setuseddestinationstate) https://github.com/bitcoin/bitcoin/pull/17354
1612019-11-08T13:45:35 *** bitcoin-git has left #bitcoin-core-dev
1622019-11-08T14:01:34 *** bitcoin-git has joined #bitcoin-core-dev
1632019-11-08T14:01:34 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a3b6f47cd75...8021392b825c
1642019-11-08T14:01:34 <bitcoin-git> bitcoin/master fad1de6 MarcoFalke: wallet: Remove unused boost::this_thread::interruption_point
1652019-11-08T14:01:35 <bitcoin-git> bitcoin/master 8021392 fanquake: Merge #17405: wallet: Remove unused boost::this_thread::interruption_point...
1662019-11-08T14:01:38 *** bitcoin-git has left #bitcoin-core-dev
1672019-11-08T14:01:54 *** bitcoin-git has joined #bitcoin-core-dev
1682019-11-08T14:01:54 <bitcoin-git> [bitcoin] fanquake merged pull request #17405: wallet: Remove unused boost::this_thread::interruption_point (master...1911-walletNoBoost) https://github.com/bitcoin/bitcoin/pull/17405
1692019-11-08T14:01:55 *** bitcoin-git has left #bitcoin-core-dev
1702019-11-08T14:02:27 *** EagleTM has joined #bitcoin-core-dev
1712019-11-08T14:14:53 *** bitcoin-git has joined #bitcoin-core-dev
1722019-11-08T14:14:53 <bitcoin-git> [bitcoin] fanquake opened pull request #17417: [0.19] cli: fix -getinfo output when compiled with no wallet (0.19...backport_17368_019) https://github.com/bitcoin/bitcoin/pull/17417
1732019-11-08T14:14:54 *** bitcoin-git has left #bitcoin-core-dev
1742019-11-08T14:21:18 *** bitcoin-git has joined #bitcoin-core-dev
1752019-11-08T14:21:18 <bitcoin-git> [bitcoin] fanquake closed pull request #17412: Add Boost::Process to AppVeyor dependencies (master...2019/11/msvc_boost_process) https://github.com/bitcoin/bitcoin/pull/17412
1762019-11-08T14:21:20 *** bitcoin-git has left #bitcoin-core-dev
1772019-11-08T14:24:18 *** shesek has quit IRC
1782019-11-08T14:24:23 *** bitcoin-git has joined #bitcoin-core-dev
1792019-11-08T14:24:23 <bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17418: Build: add REPO_SLUG to fix errors in forked builds (master...repo-slug) https://github.com/bitcoin/bitcoin/pull/17418
1802019-11-08T14:24:33 *** bitcoin-git has left #bitcoin-core-dev
1812019-11-08T14:24:47 *** shesek has joined #bitcoin-core-dev
1822019-11-08T14:24:47 *** shesek has joined #bitcoin-core-dev
1832019-11-08T14:27:21 *** diogosergio has joined #bitcoin-core-dev
1842019-11-08T14:32:13 *** nosss2 has joined #bitcoin-core-dev
1852019-11-08T14:47:05 *** emilengler has joined #bitcoin-core-dev
1862019-11-08T14:47:12 *** Sk8M8 has joined #bitcoin-core-dev
1872019-11-08T14:48:45 *** nosss2 has quit IRC
1882019-11-08T14:53:31 <michaelfolkson> With the PR review club we often need to look back on old PRs that have been merged (in some cases years ago). Any thoughts (especially from maintainers, long term contributors) on asking questions or adding links/resources on a closed PR for educational purposes? Or is this too noisy and you'd prefer to not have activity on PRs once merged/closed?
1892019-11-08T14:54:26 <michaelfolkson> An alternative would be to ask a question on StackExchange referring to a particular PR. That would be preferable right?
1902019-11-08T14:55:06 *** SiAnDoG_ has quit IRC
1912019-11-08T14:55:10 *** SiAnDoG__ has joined #bitcoin-core-dev
1922019-11-08T14:58:21 *** nosss2 has joined #bitcoin-core-dev
1932019-11-08T14:59:14 *** diogosergio has quit IRC
1942019-11-08T15:00:03 *** hmachado has quit IRC
1952019-11-08T15:01:47 <emilengler> michaelfolkson: We could create a masterthread issue on the main repo
1962019-11-08T15:01:55 <emilengler> And then we could link older PRs as well
1972019-11-08T15:02:11 <emilengler> If you look the older PR you will se that it got mentioned but IIRC no party will get a notification
1982019-11-08T15:02:25 <emilengler> And it is not counted as activity in that PR as well IIRC
1992019-11-08T15:03:03 *** nosss2 has quit IRC
2002019-11-08T15:06:01 <michaelfolkson> The no notifications sounds good. What is a masterthread issue though? A issue label "masterthread" which doesn't notify anyone? You'd set up a new issue each time you have a question on a PR? Or an issue is set up mapping to one particular PR and then all discussion for that PR is on that one issue?
2012019-11-08T15:09:47 *** mdunnio has joined #bitcoin-core-dev
2022019-11-08T15:14:00 *** mdunnio has quit IRC
2032019-11-08T15:16:00 <michaelfolkson> For anybody who knows about policy language, Miniscript just posted this on Bitcoin StackExchange https://bitcoin.stackexchange.com/questions/91565/what-does-bitcoin-policy-language-offer-the-developer-that-miniscript-doesnt-w
2042019-11-08T15:16:28 <instagibbs> ##miniscript is the place
2052019-11-08T15:17:00 *** mdunnio has joined #bitcoin-core-dev
2062019-11-08T15:17:01 <instagibbs> x-posted the link there
2072019-11-08T15:17:13 <michaelfolkson> Ah cool thanks <instagibbs>
2082019-11-08T15:17:44 *** zleap has joined #bitcoin-core-dev
2092019-11-08T15:19:27 *** jb55 has joined #bitcoin-core-dev
2102019-11-08T15:25:57 *** promag has quit IRC
2112019-11-08T15:30:41 *** ddustin has joined #bitcoin-core-dev
2122019-11-08T15:33:56 *** kljasdfvv has quit IRC
2132019-11-08T15:38:27 *** EagleTM has quit IRC
2142019-11-08T16:15:27 *** DeanGuss has quit IRC
2152019-11-08T16:18:23 *** mdunnio has quit IRC
2162019-11-08T16:20:52 <Bullit> Where Bernstein was a conglomerate in Aberdeen
2172019-11-08T16:20:57 *** diogosergio has joined #bitcoin-core-dev
2182019-11-08T16:26:04 *** diogosergio has quit IRC
2192019-11-08T16:30:27 *** 07IAC4NHA has joined #bitcoin-core-dev
2202019-11-08T16:36:49 *** michaelfolkson has quit IRC
2212019-11-08T16:38:55 *** kljasdfvv has joined #bitcoin-core-dev
2222019-11-08T16:39:43 <BlueMatt> wumpus: hmmm...could do a experimental-anticensorship-features or so, but there was some discussion of doing a gbt replacement in rust, too
2232019-11-08T16:39:46 <BlueMatt> which....
2242019-11-08T16:40:00 <BlueMatt> so, leaves me without a *great* name for it
2252019-11-08T16:40:10 <BlueMatt> but happy to rename it to something else if you have an idea
2262019-11-08T16:40:21 *** kljasdfvv has quit IRC
2272019-11-08T16:44:53 *** michaelfolkson has joined #bitcoin-core-dev
2282019-11-08T16:46:30 *** sipsorcery has joined #bitcoin-core-dev
2292019-11-08T16:48:57 <sipsorcery> @fanquake you around? PR's #17412 and #17416 are a little bit orthogonal.
2302019-11-08T16:48:59 <gribble> https://github.com/bitcoin/bitcoin/issues/17412 | Add Boost::Process to AppVeyor dependencies by Sjors · Pull Request #17412 · bitcoin/bitcoin · GitHub
2312019-11-08T16:49:00 <gribble> https://github.com/bitcoin/bitcoin/issues/17416 | Appveyor improvement - adds check for all required vcpkg packages by sipsorcery · Pull Request #17416 · bitcoin/bitcoin · GitHub
2322019-11-08T16:49:14 <fanquake> sipsorcery: yea
2332019-11-08T16:50:34 <sipsorcery> 17416 is a fix to allow new vcpkg's to be added without needing the appveyor cache to be invalidated.
2342019-11-08T16:50:54 <sipsorcery> 17412 is adding the specific package boost-process to the list of packages.
2352019-11-08T16:51:47 *** jonatack has quit IRC
2362019-11-08T16:52:00 <fanquake> Yes, but isn't the reason 17412 is required because of the issue 17416 is fixing? Otherwise I don't understand why the boost packages need to be added in advance.
2372019-11-08T16:52:28 <sipsorcery> no. at least I don't think so.
2382019-11-08T16:52:29 <fanquake> I'd rather not do that, or modify the build docs until the feature that requires them is actually merged.
2392019-11-08T16:53:49 <fanquake> Right. So does this mean that you can basically smash appveyors global cache and break all other PR builds just buy opening a new PR with a new dependency?
2402019-11-08T16:53:51 <fanquake> *by
2412019-11-08T16:53:56 *** ddustin has joined #bitcoin-core-dev
2422019-11-08T16:55:59 *** jb55 has quit IRC
2432019-11-08T16:56:05 <sipsorcery> actually boost-process is being added in 15382. so 17412 seems to be a pre-emptive add to avoid future cache invalidations.
2442019-11-08T16:56:19 <sipsorcery> i think i understand what you're getting at now.
2452019-11-08T16:57:04 *** jb55 has joined #bitcoin-core-dev
2462019-11-08T16:57:15 <sipsorcery> as far as the appveyor cache goes it's going to get regularly invalidated due to changes to the build
2472019-11-08T16:57:39 <sipsorcery> so it's not something that has to be avoided. it's something to minimise.
2482019-11-08T16:58:41 <sipsorcery> so 17416 will allow new packages to be added without manual intervention and avoid unnecessary vcpkg operations when there are no new packages.
2492019-11-08T16:59:09 <fanquake> That sounds like an improvement
2502019-11-08T16:59:19 <sipsorcery> the addition of boost-process looks like it can wait for 15382.
2512019-11-08T16:59:28 <sipsorcery> and 17412 can stay closed.
2522019-11-08T16:59:32 <sipsorcery> all good now, thx.
2532019-11-08T16:59:34 <fanquake> ð
2542019-11-08T17:02:15 *** EagleTM has joined #bitcoin-core-dev
2552019-11-08T17:04:47 *** Zenton has quit IRC
2562019-11-08T17:08:39 *** andytoshi has joined #bitcoin-core-dev
2572019-11-08T17:08:40 *** andytoshi has quit IRC
2582019-11-08T17:08:40 *** andytoshi has joined #bitcoin-core-dev
2592019-11-08T17:25:14 *** shesek has quit IRC
2602019-11-08T17:25:58 *** shesek has joined #bitcoin-core-dev
2612019-11-08T17:25:58 *** shesek has joined #bitcoin-core-dev
2622019-11-08T17:26:23 *** bitcoin-git has joined #bitcoin-core-dev
2632019-11-08T17:26:24 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #17418: Build: add REPO_SLUG to fix errors in forked builds (master...repo-slug) https://github.com/bitcoin/bitcoin/pull/17418
2642019-11-08T17:26:25 *** bitcoin-git has left #bitcoin-core-dev
2652019-11-08T17:30:50 *** shesek has quit IRC
2662019-11-08T17:31:50 *** bitcoin-git has joined #bitcoin-core-dev
2672019-11-08T17:31:51 <bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17389: build: add background.tiff and .pngs to "make clean" (master...make-clean-tiff) https://github.com/bitcoin/bitcoin/pull/17389
2682019-11-08T17:31:51 *** bitcoin-git has left #bitcoin-core-dev
2692019-11-08T17:35:17 *** sipsorcery has quit IRC
2702019-11-08T17:36:28 *** bitcoin-git has joined #bitcoin-core-dev
2712019-11-08T17:36:29 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17420: travis: Rework CACHE_ERR_MSG (master...1911-docTravis) https://github.com/bitcoin/bitcoin/pull/17420
2722019-11-08T17:36:29 *** bitcoin-git has left #bitcoin-core-dev
2732019-11-08T17:38:09 *** timothy has quit IRC
2742019-11-08T17:40:43 *** bitcoin-git has joined #bitcoin-core-dev
2752019-11-08T17:40:43 <bitcoin-git> [bitcoin] sdaftuar closed pull request #17332: p2p: Proof-of-concept: Improve DoS-resistance to low-work headers chains (master...2019-10-no-checkpoints-cleanedup) https://github.com/bitcoin/bitcoin/pull/17332
2762019-11-08T17:40:45 *** bitcoin-git has left #bitcoin-core-dev
2772019-11-08T17:41:22 *** sipsorcery has joined #bitcoin-core-dev
2782019-11-08T17:51:01 *** 07IAC4NHA has quit IRC
2792019-11-08T17:59:46 *** IGHOR has quit IRC
2802019-11-08T18:00:01 *** zleap has quit IRC
2812019-11-08T18:06:32 *** IGHOR has joined #bitcoin-core-dev
2822019-11-08T18:06:46 *** IGHOR has quit IRC
2832019-11-08T18:08:21 *** b10c has quit IRC
2842019-11-08T18:12:22 *** IGHOR has joined #bitcoin-core-dev
2852019-11-08T18:17:26 *** rex4539 has joined #bitcoin-core-dev
2862019-11-08T18:17:34 *** suriro has joined #bitcoin-core-dev
2872019-11-08T18:17:52 *** IGHOR has joined #bitcoin-core-dev
2882019-11-08T18:20:58 *** rex4539 has quit IRC
2892019-11-08T18:26:20 *** b10c has joined #bitcoin-core-dev
2902019-11-08T18:38:13 *** Sk8M8_ has joined #bitcoin-core-dev
2912019-11-08T18:41:27 *** Sk8M8 has quit IRC
2922019-11-08T18:41:43 *** b10c has quit IRC
2932019-11-08T18:47:17 *** b10c has joined #bitcoin-core-dev
2942019-11-08T18:48:05 *** JamesAU has joined #bitcoin-core-dev
2952019-11-08T18:55:39 *** jonatack has joined #bitcoin-core-dev
2962019-11-08T18:56:20 *** mdunnio has joined #bitcoin-core-dev
2972019-11-08T18:56:52 *** EagleTM has quit IRC
2982019-11-08T18:58:37 *** alko89 has quit IRC
2992019-11-08T18:58:38 *** ddustin has quit IRC
3002019-11-08T18:59:03 *** Zenton has joined #bitcoin-core-dev
3012019-11-08T18:59:15 *** ddustin has joined #bitcoin-core-dev
3022019-11-08T18:59:35 *** Tennis has joined #bitcoin-core-dev
3032019-11-08T19:00:13 <meshcollider> #startmeeting
3042019-11-08T19:00:13 <lightningbot> Meeting started Fri Nov 8 19:00:13 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
3052019-11-08T19:00:13 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3062019-11-08T19:00:19 <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
3072019-11-08T19:00:30 <achow101> hi
3082019-11-08T19:00:31 <jonatack> hi
3092019-11-08T19:00:31 <kanzure> hi
3102019-11-08T19:00:37 <meshcollider> Topics?
3112019-11-08T19:00:47 <jnewbery> hi
3122019-11-08T19:00:59 <achow101> how goes the wallet boxes review?
3132019-11-08T19:01:12 *** ddustin_ has joined #bitcoin-core-dev
3142019-11-08T19:02:09 <jonatack> Suggested topic: deprecating getaddressinfo label in favor of labels, and adding multiple labels associated with an address (currently only one)
3152019-11-08T19:02:13 <phantomcircuit> hi
3162019-11-08T19:03:31 <achow101> jonatack: is it useful to have multiple labels with an address?
3172019-11-08T19:03:31 *** ddustin has quit IRC
3182019-11-08T19:03:57 <meshcollider> #topic deprecating getsddressinfo label (jonatack)
3192019-11-08T19:04:01 <instagibbs> oh yeah, clocks changed
3202019-11-08T19:04:02 <jonatack> achow101: it seems to have been planned to be done
3212019-11-08T19:04:20 <jonatack> being the reason for adding the labels field?
3222019-11-08T19:04:31 <jonatack> in addition to the label field
3232019-11-08T19:04:47 <jonatack> which causes app developer confusion
3242019-11-08T19:04:54 <jonatack> see rationale in https://github.com/bitcoin/bitcoin/pull/17283/
3252019-11-08T19:05:18 <achow101> oh, i see
3262019-11-08T19:05:20 <jonatack> app devs wonder which field should be consumed, label or labels[]
3272019-11-08T19:05:43 *** ddustin_ has quit IRC
3282019-11-08T19:05:54 *** lightlike has quit IRC
3292019-11-08T19:06:16 <sipa> oh
3302019-11-08T19:06:41 <meshcollider> I didn't even notice labels was added
3312019-11-08T19:07:06 <luke-jr> me either
3322019-11-08T19:07:14 <jonatack> was added by jnewbery i believe? https://github.com/bitcoin/bitcoin/pull/12892
3332019-11-08T19:07:38 <jonatack> er, label
3342019-11-08T19:08:07 <jonatack> right, label[] has no tests, so added in 17283
3352019-11-08T19:08:17 <jonatack> labels[]*
3362019-11-08T19:08:43 <achow101> ack deprecating label
3372019-11-08T19:08:48 <sipa> is there a use case for having multiple labels per address?
3382019-11-08T19:09:07 <meshcollider> jnewbery: what use case did you have in mind
3392019-11-08T19:09:09 <sipa> i don't object, but just because we merged an API that is extensible enough to support it doesn't mean it's needed
3402019-11-08T19:09:31 <sipa> as in: support can be added whenever there is a use case for it
3412019-11-08T19:09:32 <jnewbery> meshcollider: just refreshing my memory now!
3422019-11-08T19:10:31 <jnewbery> logically to me, it makes sense to be able to associate multiple labels to an address
3432019-11-08T19:10:51 <jnewbery> From 12892: "labels are
3442019-11-08T19:10:51 <jnewbery> associated with addresses, instead of addresses associated with labels. (unlike
3452019-11-08T19:10:54 <jnewbery> with accounts.)"
3462019-11-08T19:11:27 <jnewbery> I picked up that work from an older wumpus PR, and I can't remember all the details right now
3472019-11-08T19:11:33 <luke-jr> I mean, it makes sense if people want to do short labels like GitHub does for PRs
3482019-11-08T19:11:33 <jonatack> some reasons in https://github.com/bitcoin/bitcoin/pull/12892#issuecomment-379016369
3492019-11-08T19:11:37 <jnewbery> I'll review jonatack's suggested changes in #17283
3502019-11-08T19:11:39 <gribble> https://github.com/bitcoin/bitcoin/issues/17283 | rpc: improve getaddressinfo test coverage, help, code docs by jonatack · Pull Request #17283 · bitcoin/bitcoin · GitHub
3512019-11-08T19:11:46 <meshcollider> Yeah that's true actually
3522019-11-08T19:11:59 *** jarthur has joined #bitcoin-core-dev
3532019-11-08T19:12:04 <luke-jr> when I do my taxes, I take the label and match multiple regexs to extract metadata - having separate labels could simplify it
3542019-11-08T19:12:16 <meshcollider> if it's not an enormous change to support multiple labels then concept ack
3552019-11-08T19:12:25 <luke-jr> that being said, there is always a primary label, so maybe we should keep / should have kept it
3562019-11-08T19:12:41 <jnewbery> There's no concept of a primary label
3572019-11-08T19:12:43 <luke-jr> eg, "bought my pet hamster" isn't likely to have more than one tx
3582019-11-08T19:12:51 <luke-jr> jnewbery: maybe there should be
3592019-11-08T19:13:43 <meshcollider> Depends if label is for categorising or label is for describing I guess
3602019-11-08T19:13:56 *** jb55 has quit IRC
3612019-11-08T19:14:26 <luke-jr> I've always used it for the latter, with the former thrown in
3622019-11-08T19:14:48 <luke-jr> categories without a description has limited usability
3632019-11-08T19:15:23 <luke-jr> I'd suggest instead a "notes" with the description part, but .. we've had label for years
3642019-11-08T19:15:24 <jnewbery> jonatack: I'll take a look at the PR and give concept feedback
3652019-11-08T19:15:36 <jonatack> luke-jr: say, ability to designate one of the labels as a primary, and one only?
3662019-11-08T19:15:38 <achow101> I think having multiple labls would be somewhat invasive due to all of the legacy accounts stuff associated with labels
3672019-11-08T19:15:53 <jonatack> jnewbery: ty
3682019-11-08T19:16:34 <meshcollider> I mean, I don't think it matters if the distinction is in the code. Supporting multiple labels allows the user to do whatever they like with them, I don't think it needs a "primary" one
3692019-11-08T19:17:31 <meshcollider> Ok yeah this can be discussed in the PR
3702019-11-08T19:17:43 <meshcollider> Other topics?
3712019-11-08T19:17:44 <jonatack> a) it seems we should decide re multiple labels before deprecating
3722019-11-08T19:17:56 <luke-jr> jonatack: maybe
3732019-11-08T19:18:06 <luke-jr> achow101: maybe rename "labels" to "tags"?
3742019-11-08T19:18:17 <jonatack> b) back to a) :D
3752019-11-08T19:18:21 <meshcollider> Please not another rename lol
3762019-11-08T19:19:04 <luke-jr> what's the "labels" PR?
3772019-11-08T19:19:14 <sipa> #12892
3782019-11-08T19:19:17 <gribble> https://github.com/bitcoin/bitcoin/issues/12892 | [wallet] [rpc] introduce label API for wallet by jnewbery · Pull Request #12892 · bitcoin/bitcoin · GitHub
3792019-11-08T19:19:58 <luke-jr> PR description doesn't suggest it does that.. :/
3802019-11-08T19:21:33 <achow101> luke-jr: i don't think there's a PR yet
3812019-11-08T19:21:38 <luke-jr> ok, so it adds a "labels" array with only one possible value
3822019-11-08T19:21:53 <jnewbery> next topic?
3832019-11-08T19:22:19 <meshcollider> achow101: is there anything you want to discuss about boxes or just review beg?
3842019-11-08T19:22:30 <achow101> review beg
3852019-11-08T19:22:40 <jonatack> (yes it is indeed https://github.com/bitcoin/bitcoin/pull/12892 despite the PR name)
3862019-11-08T19:23:02 <jonatack> luke-jr: right
3872019-11-08T19:23:28 <meshcollider> #16944 is finally nearly ready too which is nice, hopefully we can get it in after provoostenator rebases
3882019-11-08T19:23:30 <gribble> https://github.com/bitcoin/bitcoin/issues/16944 | gui: create PSBT with watch-only wallet by Sjors · Pull Request #16944 · bitcoin/bitcoin · GitHub
3892019-11-08T19:24:44 <meshcollider> Alright no other topics then :)
3902019-11-08T19:24:49 <meshcollider> #endmeeting
3912019-11-08T19:24:49 <lightningbot> Meeting ended Fri Nov 8 19:24:49 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3922019-11-08T19:24:49 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-08-19.00.html
3932019-11-08T19:24:49 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-08-19.00.txt
3942019-11-08T19:24:49 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-11-08-19.00.log.html
3952019-11-08T19:26:08 <jnewbery> thanks for merging 15931 meshcollider!
3962019-11-08T19:26:26 <jnewbery> next one in that sequence is #16426, which ariard can rebase now
3972019-11-08T19:26:28 <gribble> https://github.com/bitcoin/bitcoin/issues/16426 | Reverse cs_main, cs_wallet lock order and reduce cs_main locking by ariard · Pull Request #16426 · bitcoin/bitcoin · GitHub
3982019-11-08T19:26:53 <jnewbery> it's a really fun change to reverse the cs_main-cs_wallet lock order
3992019-11-08T19:26:56 <jonatack> achow101: review beg for https://github.com/bitcoin/bitcoin/pull/17261 ?
4002019-11-08T19:27:20 <meshcollider> jonatack: review beg for all his open wallet PRs :p
4012019-11-08T19:27:45 <achow101> #17373
4022019-11-08T19:27:47 <gribble> https://github.com/bitcoin/bitcoin/issues/17373 | wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet by achow101 · Pull Request #17373 · bitcoin/bitcoin · GitHub
4032019-11-08T19:28:08 <meshcollider> jnewbery: sounds good, review beg for that too then
4042019-11-08T19:28:21 <jonatack> thanks
4052019-11-08T19:28:36 <achow101> it'd be nice to merge these so I don't have to rebase the same PRs every day
4062019-11-08T19:29:22 *** michaelfolkson has quit IRC
4072019-11-08T19:32:21 *** ddustin has joined #bitcoin-core-dev
4082019-11-08T19:33:03 <ryanofsky> i have never understood what "labels are associated with addresses, instead of addresses associated with labels" means
4092019-11-08T19:33:27 <ryanofsky> "bob is associated with mary, but mary is not associated with bob." huh?
4102019-11-08T19:34:32 <meshcollider> It means it's not bijective, there is no well defined label -> address map
4112019-11-08T19:35:14 <meshcollider> Because multiple addresses can have the same label
4122019-11-08T19:35:31 <sipa> meshcollider: that was the case with accounts too
4132019-11-08T19:35:42 <meshcollider> Yeah
4142019-11-08T19:36:00 <jnewbery> one address couldn't have multiple accounts. It was always intended that one address could have multiple labels
4152019-11-08T19:36:03 <sipa> i always assumed it meant "you should think as labels being the property of an address" rather than "a label is a collection of addresses"
4162019-11-08T19:36:46 <jnewbery> sipa: +1
4172019-11-08T19:38:00 <ryanofsky> so "X is associated with Y" means "a Y can only have one X"
4182019-11-08T19:38:25 <meshcollider> Who knows, associated probably isn't the best word
4192019-11-08T19:38:25 <jnewbery> ryanofsky: if the 'associated with' doesn't make sense for you, just use sipa's definition
4202019-11-08T19:39:47 <ryanofsky> of course, yeah, i was just wondering how that associated thing that i see repeated made sense to anyone
4212019-11-08T19:41:28 <jnewbery> I copied it in my PR descript from wumpus's original PR because it made sense to me, but I don't think it's used in any user-facing documentation
4222019-11-08T19:41:29 <jonatack> I saw it as analogous to relational databases: has one relation vs belongs to relation
4232019-11-08T19:41:35 <jnewbery> release notes are here: https://github.com/bitcoin/bitcoin/blob/8021392b825c74312173f15eb937ba6d4aec3841/doc/release-notes/release-notes-0.17.0.md#L149
4242019-11-08T19:43:23 *** b10c has quit IRC
4252019-11-08T19:43:40 <jamesob> sounds like an indexing thing: you can look up the labels associated with an address easily, but you cannot look up the addresses associated with a label easily (even though in reality it's probably quick to build that index ad hoc depending on the size of the wallet)
4262019-11-08T19:44:00 <luke-jr> jamesob: that's the technical side
4272019-11-08T19:44:16 <luke-jr> on the abstract side, a label isn't a container; it doesn't "have" transactions/addresses
4282019-11-08T19:44:20 <luke-jr> it's a property of those transactions
4292019-11-08T19:44:41 <luke-jr> so you can conceptually search for all transactiosn with a label, but not view the contents of a label
4302019-11-08T19:45:22 <jamesob> curious, what're the contents of a label if not the associated txns?
4312019-11-08T19:45:27 <jnewbery> luke-jr: yep, labels don't have a balance
4322019-11-08T19:45:28 <luke-jr> there are no contents, that's the point
4332019-11-08T19:45:40 <jamesob> gotcha
4342019-11-08T19:45:52 <luke-jr> it's like putting a sticker on something
4352019-11-08T19:46:09 <luke-jr> sure, you can find all objects with the sticker, but asking for the contents of such a sticker is silly
4362019-11-08T19:48:43 <meshcollider> So a sticker is associated with the thing it's stuck on, but the thing it's stuck on isn't associated with the sticker
4372019-11-08T19:54:30 *** Sk8M8 has joined #bitcoin-core-dev
4382019-11-08T19:58:20 *** ddustin has quit IRC
4392019-11-08T19:58:20 *** Sk8M8_ has quit IRC
4402019-11-08T20:12:09 *** bitcoin-git has joined #bitcoin-core-dev
4412019-11-08T20:12:10 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/7358ae6d71cd...84908668a0a8
4422019-11-08T20:12:11 <bitcoin-git> bitcoin/0.19 2a15679 fanquake: doc: reintegrate release notes from wiki
4432019-11-08T20:12:12 <bitcoin-git> bitcoin/0.19 8bca3ce fanquake: doc: add macOS DMG opening note to release notes
4442019-11-08T20:12:13 <bitcoin-git> bitcoin/0.19 8490866 Wladimir J. van der Laan: Merge #17403: doc: reintegrate 0.19.0 release notes
4452019-11-08T20:12:14 *** bitcoin-git has left #bitcoin-core-dev
4462019-11-08T20:12:29 *** bitcoin-git has joined #bitcoin-core-dev
4472019-11-08T20:12:30 <bitcoin-git> [bitcoin] laanwj merged pull request #17403: doc: reintegrate 0.19.0 release notes (0.19...reintegrate_relnotes_019) https://github.com/bitcoin/bitcoin/pull/17403
4482019-11-08T20:12:30 *** bitcoin-git has left #bitcoin-core-dev
4492019-11-08T20:16:55 *** bitcoin-git has joined #bitcoin-core-dev
4502019-11-08T20:16:56 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/84908668a0a8...42414bfd0547
4512019-11-08T20:16:56 <bitcoin-git> bitcoin/0.19 42414bf Wladimir J. van der Laan: build: set CLIENT_VERSION_RC to 0 pre-final
4522019-11-08T20:16:57 *** bitcoin-git has left #bitcoin-core-dev
4532019-11-08T20:17:55 *** pinheadmz has joined #bitcoin-core-dev
4542019-11-08T20:19:37 *** bitcoin-git has joined #bitcoin-core-dev
4552019-11-08T20:19:37 <bitcoin-git> [bitcoin] laanwj pushed tag v0.19.0: https://github.com/bitcoin/bitcoin/compare/v0.19.0
4562019-11-08T20:19:38 *** bitcoin-git has left #bitcoin-core-dev
4572019-11-08T20:20:05 *** Cordia59Bahringe has joined #bitcoin-core-dev
4582019-11-08T20:20:16 <fanquake> ð
4592019-11-08T20:20:18 *** mdunnio has quit IRC
4602019-11-08T20:22:53 <jonatack> \o/
4612019-11-08T20:27:15 *** Cordia59Bahringe has quit IRC
4622019-11-08T20:29:32 *** Casper39Mertz has joined #bitcoin-core-dev
4632019-11-08T20:29:38 *** davterra has quit IRC
4642019-11-08T20:29:58 *** mdunnio has joined #bitcoin-core-dev
4652019-11-08T20:34:47 *** andytoshi has quit IRC
4662019-11-08T20:37:14 *** pinheadmz has quit IRC
4672019-11-08T20:37:20 *** Casper39Mertz has quit IRC
4682019-11-08T20:40:49 *** reallll has joined #bitcoin-core-dev
4692019-11-08T20:44:10 *** belcher has quit IRC
4702019-11-08T20:47:31 *** Tennis has quit IRC
4712019-11-08T20:53:43 *** andytoshi has joined #bitcoin-core-dev
4722019-11-08T20:59:01 *** reallll is now known as belcher
4732019-11-08T21:00:02 *** suriro has quit IRC
4742019-11-08T21:04:19 <MarcoFalke> \o/
4752019-11-08T21:04:22 <MarcoFalke> Could add the release notes to https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.19.0.md ?
4762019-11-08T21:08:15 <wumpus> yes, that's one of the next steps, I usually do that before the uploading the binaries (e.g. after the gitian process), but it doesn't really matter if it's a little sooner I guess
4772019-11-08T21:10:03 *** bitcoin-git has joined #bitcoin-core-dev
4782019-11-08T21:10:03 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8021392b825c...9e0aabe50cbb
4792019-11-08T21:10:04 <bitcoin-git> bitcoin/master fa56bcb MarcoFalke: ci: Run CI_WAIT only on travis
4802019-11-08T21:10:04 <bitcoin-git> bitcoin/master fa8a60b MarcoFalke: ci: Run non-cross-compile builds natively
4812019-11-08T21:10:05 <bitcoin-git> bitcoin/master faf757a MarcoFalke: ci: Guess the native host when not cross compiling
4822019-11-08T21:10:06 *** bitcoin-git has left #bitcoin-core-dev
4832019-11-08T21:10:23 *** bitcoin-git has joined #bitcoin-core-dev
4842019-11-08T21:10:23 <bitcoin-git> [bitcoin] laanwj merged pull request #17367: ci: Run non-cross-compile builds natively (master...1911-ciNative) https://github.com/bitcoin/bitcoin/pull/17367
4852019-11-08T21:10:24 *** bitcoin-git has left #bitcoin-core-dev
4862019-11-08T21:14:51 *** Highway61 has joined #bitcoin-core-dev
4872019-11-08T21:15:44 *** Sk8M8_ has joined #bitcoin-core-dev
4882019-11-08T21:18:37 *** Sk8M8 has quit IRC
4892019-11-08T21:19:20 <fanquake> wumpus I'll save you the trouble
4902019-11-08T21:21:24 *** bitcoin-git has joined #bitcoin-core-dev
4912019-11-08T21:21:24 <bitcoin-git> [bitcoin] fanquake opened pull request #17422: doc: add historical 0.19.0 release notes (master...add_019_relnotes) https://github.com/bitcoin/bitcoin/pull/17422
4922019-11-08T21:21:30 *** bitcoin-git has left #bitcoin-core-dev
4932019-11-08T21:24:37 *** Sk8M8_ has quit IRC
4942019-11-08T21:32:56 <wumpus> fanquake: thanks!
4952019-11-08T21:37:33 *** pinheadmz has joined #bitcoin-core-dev
4962019-11-08T21:44:30 *** StopAndDecrypt has joined #bitcoin-core-dev
4972019-11-08T21:50:00 *** tomatopotato has joined #bitcoin-core-dev
4982019-11-08T21:51:22 *** lightlike has joined #bitcoin-core-dev
4992019-11-08T22:00:15 *** pinheadmz has quit IRC
5002019-11-08T22:02:48 *** pinheadmz has joined #bitcoin-core-dev
5012019-11-08T22:06:01 <jnewbery> wumpus fanquake MarcoFalke: I think #15934 is ready for merge. ACKs on the head commit 083c954 from ariard, jamesob and jnewbery. Also ACKs on previous versions from fjahr and jonatack.
5022019-11-08T22:06:05 <gribble> https://github.com/bitcoin/bitcoin/issues/15934 | Merge settings one place instead of five places by ryanofsky · Pull Request #15934 · bitcoin/bitcoin · GitHub
5032019-11-08T22:09:40 <jamesob> not to mention 15934 is tested to death
5042019-11-08T22:12:51 *** Highway61 has quit IRC
5052019-11-08T22:16:33 *** jtimon has joined #bitcoin-core-dev
5062019-11-08T22:17:14 *** Chris_Stewart_5 has quit IRC
5072019-11-08T22:19:02 *** pinheadmz has quit IRC
5082019-11-08T22:21:23 *** bitcoin-git has joined #bitcoin-core-dev
5092019-11-08T22:21:23 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9e0aabe50cbb...adceca2ba56a
5102019-11-08T22:21:24 <bitcoin-git> bitcoin/master fec230e fanquake: doc: add historical 0.19.0 release notes
5112019-11-08T22:21:24 <bitcoin-git> bitcoin/master adceca2 Wladimir J. van der Laan: Merge #17422: doc: add historical 0.19.0 release notes
5122019-11-08T22:21:26 *** bitcoin-git has left #bitcoin-core-dev
5132019-11-08T22:21:43 *** bitcoin-git has joined #bitcoin-core-dev
5142019-11-08T22:21:43 <bitcoin-git> [bitcoin] laanwj merged pull request #17422: doc: add historical 0.19.0 release notes (master...add_019_relnotes) https://github.com/bitcoin/bitcoin/pull/17422
5152019-11-08T22:21:45 *** bitcoin-git has left #bitcoin-core-dev
5162019-11-08T22:23:37 *** bitcoin-git has joined #bitcoin-core-dev
5172019-11-08T22:23:40 <bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/adceca2ba56a...a7aec7ad9794
5182019-11-08T22:23:40 <bitcoin-git> bitcoin/master dc8e1e7 Russell Yanofsky: Clarify emptyIncludeConf logic
5192019-11-08T22:23:41 <bitcoin-git> bitcoin/master 5a84aa8 Russell Yanofsky: Rename includeconf variables for clarity
5202019-11-08T22:23:43 <bitcoin-git> bitcoin/master e2e37cf Russell Yanofsky: Remove includeconf nested scope
5212019-11-08T22:23:45 *** bitcoin-git has left #bitcoin-core-dev
5222019-11-08T22:24:22 *** bitcoin-git has joined #bitcoin-core-dev
5232019-11-08T22:24:22 <bitcoin-git> [bitcoin] laanwj merged pull request #15934: Merge settings one place instead of five places (master...pr/mergeset) https://github.com/bitcoin/bitcoin/pull/15934
5242019-11-08T22:24:23 *** bitcoin-git has left #bitcoin-core-dev
5252019-11-08T22:26:02 <jnewbery> thanks wumpus!
5262019-11-08T22:28:39 <wumpus> thanks for improving the horror that is bitcoin core option parsing a bit :)
5272019-11-08T22:29:24 <midnight> inb4 option parsing gets its own scripting language
5282019-11-08T22:33:24 <wumpus> midnight: hah, I know you're joking, but I don't think a lack of flexibility was ever the problem, just that the code is a mess and problems are silently ignored... but also we've come a long way from #1044
5292019-11-08T22:33:26 <gribble> https://github.com/bitcoin/bitcoin/issues/1044 | Problems with command-line options silently ignored · Issue #1044 · bitcoin/bitcoin · GitHub
5302019-11-08T22:35:18 * jamesob waits for TheBlueMatt to suggest porting options parsing to rust
5312019-11-08T22:35:39 <wumpus> it's, a good lesson for new projects, get these things designed well in the first release, if not you're going to spend years cleaning up the mess while competing with PRs that add functionality etc
5322019-11-08T22:38:17 <wumpus> jamesob: lol
5332019-11-08T22:39:37 *** bitcoin-git has joined #bitcoin-core-dev
5342019-11-08T22:39:37 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17423: ci: Make ci system read-only on the git work tree (master...1911-ciRo) https://github.com/bitcoin/bitcoin/pull/17423
5352019-11-08T22:39:38 *** bitcoin-git has left #bitcoin-core-dev
5362019-11-08T22:47:57 *** pinheadmz has joined #bitcoin-core-dev
5372019-11-08T22:52:57 *** jarthur has quit IRC
5382019-11-08T22:54:15 *** mdunnio has quit IRC
5392019-11-08T22:55:35 *** mdunnio has joined #bitcoin-core-dev
5402019-11-08T22:56:20 *** mdunnio has quit IRC
5412019-11-08T22:56:23 *** pinheadmz has quit IRC
5422019-11-08T23:01:51 *** murrayn has quit IRC
5432019-11-08T23:05:56 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5442019-11-08T23:11:06 *** Chris_Stewart_5 has quit IRC
5452019-11-08T23:16:51 *** jungly has quit IRC
5462019-11-08T23:26:08 <harding> FYI, BitcoinCore.org isn't updating when new commits are merged. I DM'd BlueMatt a while ago, but I guess he's not around. I'm not sure who else has access to the server to debug it (this happens from time to time, but I'm not sure what can BlueMatt usually kicks to get things restarted).
5472019-11-08T23:33:45 <midnight> wumpus: Only half joking. Complex options are heading that way, it seems to me. At some point *behaviour* of programs with complex options it seems to me might be helpful to be reactive or capable of simple decision-making
5482019-11-08T23:34:30 * midnight shudders at the future
5492019-11-08T23:38:15 <wumpus> harding: strange, I don't have access immediately either but probably we need to poke whatever does updates
5502019-11-08T23:39:58 <emilengler> harding: Btw why is bitcoincore.org not hosted at github
5512019-11-08T23:40:16 <harding> BlueMatt: is looking into it now.
5522019-11-08T23:40:42 <wumpus> emilengler: cuuursed idea
5532019-11-08T23:41:08 <emilengler> What's wrong with GH pages? It adds an extra layer of transparency
5542019-11-08T23:41:18 <emilengler> Well you can't really do server side stuff though
5552019-11-08T23:42:28 <sipa> emilengler: we really don't want to rely on github's security for distribution of binaries
5562019-11-08T23:43:12 <sipa> if anything, the degree to which we depend on github already is scary
5572019-11-08T23:43:16 <wumpus> midnight: I don't know, I dont' think *that* is so bad with bitcoin core. I do have experiences like that with things like printer settings though, where the software tries to 'intelligently' guess what your're trying to do, correcting for some settings, so at some point you need to make second-order guesses so that the software will make the correct guess and eventually send the right value to the
5582019-11-08T23:43:18 <wumpus> hardware
5592019-11-08T23:43:42 <emilengler> sipa: +1 but GH can't fake PGP signatures and if the users aren't verifying it it is pretty much their own fault IMO
5602019-11-08T23:44:27 <sipa> emilengler: whether you like it or not, reality is that very few users verify PGP signatures
5612019-11-08T23:45:35 <harding> emilengler: I don't have any data on BitcoinCore.org, but back when the binaries were exclusively hosted on Bitcoin.org, there was less than 1% as many downloads of SHA256SUMS.asc than there was of the binary files.
5622019-11-08T23:45:44 <wumpus> but no, we're not going to trust github for hosting the website as well as hosting the repository
5632019-11-08T23:45:56 <wumpus> one thing is enough
5642019-11-08T23:46:04 <emilengler> Btw why isn't the repo hosted on the server then
5652019-11-08T23:46:09 <wumpus> probably too much, anyhow, but let's not argue for making things worse
5662019-11-08T23:46:15 <emilengler> ok
5672019-11-08T23:47:03 <wumpus> in a far future I'm imagine we can reduce our dependency on github.com, but we're at least not trying to increase it
5682019-11-08T23:49:24 <wumpus> (and yes, the bitcoincore.org server update verifies GPG signatures on commits independently, so someone compromising the github repository doesn't automatically compromise the website)
5692019-11-08T23:52:52 *** jb55 has joined #bitcoin-core-dev
5702019-11-08T23:56:44 <midnight> neat
5712019-11-08T23:57:15 <midnight> I verify PGP signatures (most of the time!)