1 2019-11-23T00:00:01  *** Antonet has quit IRC
  2 2019-11-23T00:04:47  *** rafalcpp_ has joined #bitcoin-core-dev
  3 2019-11-23T00:04:50  *** rafalcpp has quit IRC
  4 2019-11-23T00:09:25  *** achow101 has quit IRC
  5 2019-11-23T00:11:34  *** rafalcpp has joined #bitcoin-core-dev
  6 2019-11-23T00:12:14  *** rafalcpp_ has quit IRC
  7 2019-11-23T00:17:18  *** FalconKirtaran has joined #bitcoin-core-dev
  8 2019-11-23T00:19:15  *** achow101 has joined #bitcoin-core-dev
  9 2019-11-23T00:19:22  *** rafalcpp_ has joined #bitcoin-core-dev
 10 2019-11-23T00:19:23  *** rafalcpp has quit IRC
 11 2019-11-23T00:27:28  *** Dev has joined #bitcoin-core-dev
 12 2019-11-23T00:28:23  *** rafalcpp has joined #bitcoin-core-dev
 13 2019-11-23T00:28:26  *** rafalcpp_ has quit IRC
 14 2019-11-23T00:32:37  *** rafalcpp has quit IRC
 15 2019-11-23T00:33:12  *** rafalcpp has joined #bitcoin-core-dev
 16 2019-11-23T00:39:43  *** Highway61 has quit IRC
 17 2019-11-23T00:40:36  *** jasonzhouu_ has joined #bitcoin-core-dev
 18 2019-11-23T00:41:57  *** rafalcpp_ has joined #bitcoin-core-dev
 19 2019-11-23T00:42:26  *** rafalcpp has quit IRC
 20 2019-11-23T00:42:57  *** jasonzhouu has quit IRC
 21 2019-11-23T00:43:21  *** jasonzhouu_ is now known as jasonzhouu
 22 2019-11-23T00:45:38  *** AaronvanW has joined #bitcoin-core-dev
 23 2019-11-23T00:50:30  *** AaronvanW has quit IRC
 24 2019-11-23T00:50:42  *** rafalcpp has joined #bitcoin-core-dev
 25 2019-11-23T00:50:57  *** rafalcpp_ has quit IRC
 26 2019-11-23T00:59:34  *** brakmic has quit IRC
 27 2019-11-23T01:04:42  *** marcoagner has quit IRC
 28 2019-11-23T01:06:33  *** molly has joined #bitcoin-core-dev
 29 2019-11-23T01:09:27  *** rafalcpp_ has joined #bitcoin-core-dev
 30 2019-11-23T01:09:38  *** mol has quit IRC
 31 2019-11-23T01:09:50  *** rafalcpp has quit IRC
 32 2019-11-23T01:11:29  *** jonatack has joined #bitcoin-core-dev
 33 2019-11-23T01:11:58  *** SiAnDoG has joined #bitcoin-core-dev
 34 2019-11-23T01:13:29  *** Dev has quit IRC
 35 2019-11-23T01:13:41  *** cryptoIndio has quit IRC
 36 2019-11-23T01:17:13  *** rafalcpp has joined #bitcoin-core-dev
 37 2019-11-23T01:18:03  *** rafalcpp_ has quit IRC
 38 2019-11-23T01:22:50  *** AaronvanW has joined #bitcoin-core-dev
 39 2019-11-23T01:23:20  *** sipsorcery has quit IRC
 40 2019-11-23T01:23:40  *** nosss2 has quit IRC
 41 2019-11-23T01:24:17  *** nosss2 has joined #bitcoin-core-dev
 42 2019-11-23T01:27:25  *** AaronvanW has quit IRC
 43 2019-11-23T01:28:41  *** nosss2 has quit IRC
 44 2019-11-23T01:29:53  *** SiAnDoG has quit IRC
 45 2019-11-23T01:30:04  *** SiAnDoG has joined #bitcoin-core-dev
 46 2019-11-23T01:32:02  *** rafalcpp_ has joined #bitcoin-core-dev
 47 2019-11-23T01:32:26  *** rafalcpp has quit IRC
 48 2019-11-23T01:34:47  *** Dean_Guss has joined #bitcoin-core-dev
 49 2019-11-23T01:40:47  *** rafalcpp has joined #bitcoin-core-dev
 50 2019-11-23T01:41:17  *** rafalcpp_ has quit IRC
 51 2019-11-23T01:55:33  *** AaronvanW has joined #bitcoin-core-dev
 52 2019-11-23T01:56:37  *** rafalcpp_ has joined #bitcoin-core-dev
 53 2019-11-23T01:56:50  *** rafalcpp has quit IRC
 54 2019-11-23T01:59:52  *** jtimon has quit IRC
 55 2019-11-23T02:00:00  *** AaronvanW has quit IRC
 56 2019-11-23T02:08:08  *** bitcoin-git has joined #bitcoin-core-dev
 57 2019-11-23T02:08:08  <bitcoin-git> [bitcoin] fanquake opened pull request #17567: gui: remove macOS start on login code (master...remove_macos_startup_item) https://github.com/bitcoin/bitcoin/pull/17567
 58 2019-11-23T02:08:21  *** bitcoin-git has left #bitcoin-core-dev
 59 2019-11-23T02:10:37  *** emilengler has quit IRC
 60 2019-11-23T02:11:53  *** bitcoin-git has joined #bitcoin-core-dev
 61 2019-11-23T02:11:54  <bitcoin-git> [bitcoin] fanquake closed pull request #16738: gui: Remove needless GCC diagnostic pragma (master...20190827-gcc-pragmas) https://github.com/bitcoin/bitcoin/pull/16738
 62 2019-11-23T02:11:54  *** bitcoin-git has left #bitcoin-core-dev
 63 2019-11-23T02:13:14  *** rafalcpp_ has quit IRC
 64 2019-11-23T02:13:32  *** rafalcpp_ has joined #bitcoin-core-dev
 65 2019-11-23T02:24:25  *** cryptoIndio has joined #bitcoin-core-dev
 66 2019-11-23T02:24:36  *** cryptoIndio has quit IRC
 67 2019-11-23T02:32:13  *** AaronvanW has joined #bitcoin-core-dev
 68 2019-11-23T02:36:30  *** AaronvanW has quit IRC
 69 2019-11-23T02:38:50  *** rafalcpp_ has quit IRC
 70 2019-11-23T02:39:17  *** rafalcpp_ has joined #bitcoin-core-dev
 71 2019-11-23T02:41:47  *** jasonzhouu has quit IRC
 72 2019-11-23T02:42:11  *** jasonzhouu has joined #bitcoin-core-dev
 73 2019-11-23T02:45:16  *** nik-j has joined #bitcoin-core-dev
 74 2019-11-23T02:48:54  *** nik-j has quit IRC
 75 2019-11-23T02:49:31  *** nik-j has joined #bitcoin-core-dev
 76 2019-11-23T02:53:07  *** rafalcpp has joined #bitcoin-core-dev
 77 2019-11-23T02:53:37  *** rafalcpp_ has quit IRC
 78 2019-11-23T03:00:01  *** FalconKirtaran has quit IRC
 79 2019-11-23T03:00:57  *** rafalcpp_ has joined #bitcoin-core-dev
 80 2019-11-23T03:01:29  *** rafalcpp has quit IRC
 81 2019-11-23T03:06:49  *** felixfoertsch has joined #bitcoin-core-dev
 82 2019-11-23T03:07:17  *** rafalcpp_ has quit IRC
 83 2019-11-23T03:08:16  *** rafalcpp_ has joined #bitcoin-core-dev
 84 2019-11-23T03:08:44  *** felixfoertsch23 has quit IRC
 85 2019-11-23T03:11:38  *** AaronvanW has joined #bitcoin-core-dev
 86 2019-11-23T03:16:50  *** AaronvanW has quit IRC
 87 2019-11-23T03:17:19  *** freakofmimsy has joined #bitcoin-core-dev
 88 2019-11-23T03:21:02  *** rafalcpp has joined #bitcoin-core-dev
 89 2019-11-23T03:22:02  *** rafalcpp_ has quit IRC
 90 2019-11-23T03:26:25  *** reallll has joined #bitcoin-core-dev
 91 2019-11-23T03:29:37  *** belcher has quit IRC
 92 2019-11-23T03:35:15  *** bitcoin-git has joined #bitcoin-core-dev
 93 2019-11-23T03:35:16  <bitcoin-git> [bitcoin] achow101 opened pull request #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs (master...fix-bnb-preset-sub) https://github.com/bitcoin/bitcoin/pull/17568
 94 2019-11-23T03:35:17  *** jasonzhouu has quit IRC
 95 2019-11-23T03:35:21  *** bitcoin-git has left #bitcoin-core-dev
 96 2019-11-23T03:35:41  *** deadlysin has quit IRC
 97 2019-11-23T03:44:47  *** rafalcpp_ has joined #bitcoin-core-dev
 98 2019-11-23T03:46:05  *** rafalcpp has quit IRC
 99 2019-11-23T03:49:43  *** AaronvanW has joined #bitcoin-core-dev
100 2019-11-23T03:51:32  *** rafalcpp has joined #bitcoin-core-dev
101 2019-11-23T03:52:35  *** rafalcpp_ has quit IRC
102 2019-11-23T03:54:10  *** AaronvanW has quit IRC
103 2019-11-23T04:08:18  *** rafalcpp_ has joined #bitcoin-core-dev
104 2019-11-23T04:09:09  *** rafalcpp has quit IRC
105 2019-11-23T04:27:07  *** rafalcpp has joined #bitcoin-core-dev
106 2019-11-23T04:27:47  *** dviola has joined #bitcoin-core-dev
107 2019-11-23T04:28:02  *** AaronvanW has joined #bitcoin-core-dev
108 2019-11-23T04:28:29  *** rafalcpp_ has quit IRC
109 2019-11-23T04:32:26  *** AaronvanW has quit IRC
110 2019-11-23T04:39:37  *** rafalcpp has quit IRC
111 2019-11-23T04:40:02  *** rafalcpp has joined #bitcoin-core-dev
112 2019-11-23T04:55:37  *** rafalcpp has quit IRC
113 2019-11-23T04:55:48  *** rafalcpp has joined #bitcoin-core-dev
114 2019-11-23T05:02:58  *** AaronvanW has joined #bitcoin-core-dev
115 2019-11-23T05:04:24  *** felixfoertsch has quit IRC
116 2019-11-23T05:04:35  *** felixfoertsch has joined #bitcoin-core-dev
117 2019-11-23T05:07:59  *** AaronvanW has quit IRC
118 2019-11-23T05:08:37  *** rafalcpp_ has joined #bitcoin-core-dev
119 2019-11-23T05:09:17  *** rafalcpp has quit IRC
120 2019-11-23T05:27:17  *** rafalcpp_ has quit IRC
121 2019-11-23T05:27:24  *** rafalcpp has joined #bitcoin-core-dev
122 2019-11-23T05:27:52  *** dviola has quit IRC
123 2019-11-23T05:28:23  *** nosss2 has joined #bitcoin-core-dev
124 2019-11-23T05:48:12  *** rafalcpp_ has joined #bitcoin-core-dev
125 2019-11-23T05:48:17  *** rafalcpp has quit IRC
126 2019-11-23T05:49:35  *** molly has quit IRC
127 2019-11-23T05:50:33  *** rhavar_ has quit IRC
128 2019-11-23T05:51:51  *** tryphe has quit IRC
129 2019-11-23T05:52:19  *** tryphe has joined #bitcoin-core-dev
130 2019-11-23T05:52:56  *** mol has joined #bitcoin-core-dev
131 2019-11-23T05:57:37  *** rafalcpp_ has quit IRC
132 2019-11-23T05:58:01  *** rafalcpp_ has joined #bitcoin-core-dev
133 2019-11-23T06:00:02  *** freakofmimsy has quit IRC
134 2019-11-23T06:02:57  *** rafalcpp has joined #bitcoin-core-dev
135 2019-11-23T06:03:01  *** rafalcpp_ has quit IRC
136 2019-11-23T06:04:40  *** MrPaz has quit IRC
137 2019-11-23T06:09:52  *** rafalcpp_ has joined #bitcoin-core-dev
138 2019-11-23T06:09:57  *** rafalcpp has quit IRC
139 2019-11-23T06:17:23  *** mmf has joined #bitcoin-core-dev
140 2019-11-23T06:18:55  *** cryptoIndio has joined #bitcoin-core-dev
141 2019-11-23T06:20:33  *** AaronvanW has joined #bitcoin-core-dev
142 2019-11-23T06:20:37  *** rafalcpp has joined #bitcoin-core-dev
143 2019-11-23T06:20:47  *** rafalcpp_ has quit IRC
144 2019-11-23T06:24:00  *** cryptoIndio has quit IRC
145 2019-11-23T06:25:20  *** AaronvanW has quit IRC
146 2019-11-23T06:25:55  *** rabidus has quit IRC
147 2019-11-23T06:27:18  *** rabidus has joined #bitcoin-core-dev
148 2019-11-23T06:31:25  *** rafalcpp_ has joined #bitcoin-core-dev
149 2019-11-23T06:32:29  *** rafalcpp has quit IRC
150 2019-11-23T06:33:44  *** rabidus has quit IRC
151 2019-11-23T06:35:44  *** rabidus has joined #bitcoin-core-dev
152 2019-11-23T06:46:17  *** rabidus has quit IRC
153 2019-11-23T06:48:19  *** rabidus has joined #bitcoin-core-dev
154 2019-11-23T06:49:19  *** provoostenator has quit IRC
155 2019-11-23T06:51:41  *** cryptoIndio has joined #bitcoin-core-dev
156 2019-11-23T06:54:27  *** rafalcpp has joined #bitcoin-core-dev
157 2019-11-23T06:54:38  *** rafalcpp_ has quit IRC
158 2019-11-23T06:57:11  *** cryptoIndio has quit IRC
159 2019-11-23T07:00:05  *** nosss2 has quit IRC
160 2019-11-23T07:01:21  *** provoostenator has joined #bitcoin-core-dev
161 2019-11-23T07:07:34  *** tryphe has quit IRC
162 2019-11-23T07:08:50  *** rafalcpp has quit IRC
163 2019-11-23T07:09:16  *** rafalcpp has joined #bitcoin-core-dev
164 2019-11-23T07:14:57  *** rafalcpp has quit IRC
165 2019-11-23T07:15:12  *** rafalcpp has joined #bitcoin-core-dev
166 2019-11-23T07:21:00  *** rafalcpp_ has joined #bitcoin-core-dev
167 2019-11-23T07:21:17  *** rafalcpp has quit IRC
168 2019-11-23T07:30:50  *** cryptoIndio has joined #bitcoin-core-dev
169 2019-11-23T07:31:52  *** AaronvanW has joined #bitcoin-core-dev
170 2019-11-23T07:32:46  *** rafalcpp_ has quit IRC
171 2019-11-23T07:32:55  *** rafalcpp_ has joined #bitcoin-core-dev
172 2019-11-23T07:34:57  *** cryptoIndio has quit IRC
173 2019-11-23T07:36:17  *** AaronvanW has quit IRC
174 2019-11-23T07:37:04  *** DougieBot5000_ has joined #bitcoin-core-dev
175 2019-11-23T07:40:51  *** DougieBot5000 has quit IRC
176 2019-11-23T07:47:46  *** spinza has quit IRC
177 2019-11-23T08:03:43  *** rafalcpp has joined #bitcoin-core-dev
178 2019-11-23T08:04:08  *** rafalcpp_ has quit IRC
179 2019-11-23T08:05:43  *** AaronvanW has joined #bitcoin-core-dev
180 2019-11-23T08:10:20  *** AaronvanW has quit IRC
181 2019-11-23T08:14:33  *** rafalcpp_ has joined #bitcoin-core-dev
182 2019-11-23T08:14:45  *** rafalcpp has quit IRC
183 2019-11-23T08:15:38  *** AaronvanW has joined #bitcoin-core-dev
184 2019-11-23T08:24:05  *** EagleTM has joined #bitcoin-core-dev
185 2019-11-23T08:27:36  *** Talkless has joined #bitcoin-core-dev
186 2019-11-23T08:28:07  *** tryphe has joined #bitcoin-core-dev
187 2019-11-23T08:28:31  *** Talkless has quit IRC
188 2019-11-23T08:29:17  *** rafalcpp_ has quit IRC
189 2019-11-23T08:29:22  *** rafalcpp has joined #bitcoin-core-dev
190 2019-11-23T08:30:22  *** tryphe has quit IRC
191 2019-11-23T08:30:43  *** tryphe has joined #bitcoin-core-dev
192 2019-11-23T08:34:02  *** rafalcpp has quit IRC
193 2019-11-23T08:34:07  *** rafalcpp_ has joined #bitcoin-core-dev
194 2019-11-23T08:37:31  *** cryptoIndio has joined #bitcoin-core-dev
195 2019-11-23T08:41:02  *** reallll is now known as belcher
196 2019-11-23T08:41:38  *** cryptoIndio has quit IRC
197 2019-11-23T08:41:52  *** rafalcpp has joined #bitcoin-core-dev
198 2019-11-23T08:42:02  *** rafalcpp_ has quit IRC
199 2019-11-23T08:44:13  *** Talkless has joined #bitcoin-core-dev
200 2019-11-23T08:51:52  <meshcollider> achow101: I'm not sure why my test passes but yours doesn't
201 2019-11-23T08:52:10  <meshcollider> I'm sure I've built the right one and running the right test 🤔
202 2019-11-23T08:52:32  <meshcollider> Can someone else test #17568 quickly pls
203 2019-11-23T08:52:34  <gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 · Pull Request #17568 · bitcoin/bitcoin · GitHub
204 2019-11-23T08:55:12  *** sipsorcery has joined #bitcoin-core-dev
205 2019-11-23T08:58:57  *** EagleTM has quit IRC
206 2019-11-23T08:59:37  *** rafalcpp_ has joined #bitcoin-core-dev
207 2019-11-23T09:00:01  *** mmf has quit IRC
208 2019-11-23T09:00:07  *** rafalcpp has quit IRC
209 2019-11-23T09:01:52  *** schmidty has quit IRC
210 2019-11-23T09:03:40  *** midnight has quit IRC
211 2019-11-23T09:04:28  *** schmidty has joined #bitcoin-core-dev
212 2019-11-23T09:10:27  <wumpus> sure i'll test
213 2019-11-23T09:12:23  <wumpus> meshcollider: I get "test_framework.authproxy.JSONRPCException: Fee exceeds maximum configured by -maxtxfee (-4)" on master with the new test
214 2019-11-23T09:13:16  <meshcollider> Hmm ok it must be something on my end then
215 2019-11-23T09:13:39  <wumpus> isn't that what you expected?
216 2019-11-23T09:14:19  <meshcollider> It's what is supposed to happen yeah, but it passed when I ran it lol
217 2019-11-23T09:14:22  *** rafalcpp has joined #bitcoin-core-dev
218 2019-11-23T09:14:31  <wumpus> strange!
219 2019-11-23T09:14:37  *** rafalcpp_ has quit IRC
220 2019-11-23T09:15:57  <wumpus> now tried to run it a few times, it seems reproducible, rpc_fundrawtransaction.py fails every time
221 2019-11-23T09:16:47  *** midnightmagic has joined #bitcoin-core-dev
222 2019-11-23T09:17:30  *** aljungberg has joined #bitcoin-core-dev
223 2019-11-23T09:19:02  <wumpus> after recompiling with #17568 it passes
224 2019-11-23T09:19:04  <gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 · Pull Request #17568 · bitcoin/bitcoin · GitHub
225 2019-11-23T09:19:27  *** AaronvanW has quit IRC
226 2019-11-23T09:23:56  *** nosss2 has joined #bitcoin-core-dev
227 2019-11-23T09:27:08  *** rafalcpp_ has joined #bitcoin-core-dev
228 2019-11-23T09:27:11  *** rafalcpp has quit IRC
229 2019-11-23T09:28:16  *** nosss2 has quit IRC
230 2019-11-23T09:33:01  *** bitcoin-git has joined #bitcoin-core-dev
231 2019-11-23T09:33:01  <bitcoin-git> [bitcoin] laanwj opened pull request #17569: build: Allow export of environ symbols (master...2019_11_environ) https://github.com/bitcoin/bitcoin/pull/17569
232 2019-11-23T09:33:12  *** bitcoin-git has left #bitcoin-core-dev
233 2019-11-23T09:33:59  *** rafalcpp has joined #bitcoin-core-dev
234 2019-11-23T09:34:52  *** rafalcpp_ has quit IRC
235 2019-11-23T09:36:52  <wumpus> fanquake: hopefully #17569 is the last step
236 2019-11-23T09:36:54  <gribble> https://github.com/bitcoin/bitcoin/issues/17569 | build: Allow export of environ symbols by laanwj · Pull Request #17569 · bitcoin/bitcoin · GitHub
237 2019-11-23T09:38:35  *** nosss2 has joined #bitcoin-core-dev
238 2019-11-23T09:38:47  *** rafalcpp_ has joined #bitcoin-core-dev
239 2019-11-23T09:40:00  *** rafalcpp has quit IRC
240 2019-11-23T09:42:48  *** nosss2 has quit IRC
241 2019-11-23T09:49:18  *** nosss2 has joined #bitcoin-core-dev
242 2019-11-23T10:00:55  *** nosss2 has joined #bitcoin-core-dev
243 2019-11-23T10:02:01  *** bitcoin-git has joined #bitcoin-core-dev
244 2019-11-23T10:02:01  <bitcoin-git> [bitcoin] KaanKC opened pull request #17570: test: add unit test for non-standard txs w/ too large tx size (master...test_unit_IsStandardTx_tx-size) https://github.com/bitcoin/bitcoin/pull/17570
245 2019-11-23T10:02:02  *** bitcoin-git has left #bitcoin-core-dev
246 2019-11-23T10:04:38  *** rafalcpp has joined #bitcoin-core-dev
247 2019-11-23T10:04:53  *** rafalcpp_ has quit IRC
248 2019-11-23T10:05:26  *** marcoagner has joined #bitcoin-core-dev
249 2019-11-23T10:05:41  *** nosss2 has quit IRC
250 2019-11-23T10:10:25  *** rafalcpp_ has joined #bitcoin-core-dev
251 2019-11-23T10:10:53  *** rafalcpp has quit IRC
252 2019-11-23T10:12:03  *** nosss2 has joined #bitcoin-core-dev
253 2019-11-23T10:16:18  *** nosss2 has quit IRC
254 2019-11-23T10:19:06  *** rafalcpp_ has quit IRC
255 2019-11-23T10:19:14  *** rafalcpp_ has joined #bitcoin-core-dev
256 2019-11-23T10:22:06  *** spinza has joined #bitcoin-core-dev
257 2019-11-23T10:25:48  *** nosss2 has joined #bitcoin-core-dev
258 2019-11-23T10:26:33  *** emilengler has joined #bitcoin-core-dev
259 2019-11-23T10:27:04  *** rafalcpp has joined #bitcoin-core-dev
260 2019-11-23T10:27:30  *** rafalcpp_ has quit IRC
261 2019-11-23T10:28:14  *** nosss2 has quit IRC
262 2019-11-23T10:29:27  *** mryandao has quit IRC
263 2019-11-23T10:29:33  *** AaronvanW has joined #bitcoin-core-dev
264 2019-11-23T10:30:11  *** mryandao has joined #bitcoin-core-dev
265 2019-11-23T10:31:53  *** rafalcpp_ has joined #bitcoin-core-dev
266 2019-11-23T10:32:02  *** rafalcpp has quit IRC
267 2019-11-23T10:32:09  *** EagleTM has joined #bitcoin-core-dev
268 2019-11-23T10:33:54  *** AaronvanW has quit IRC
269 2019-11-23T10:36:42  *** rafalcpp has joined #bitcoin-core-dev
270 2019-11-23T10:37:17  *** rafalcpp_ has quit IRC
271 2019-11-23T10:37:39  *** nosss2 has joined #bitcoin-core-dev
272 2019-11-23T10:38:30  *** cryptoIndio has joined #bitcoin-core-dev
273 2019-11-23T10:40:21  *** JeremyCrookshank has joined #bitcoin-core-dev
274 2019-11-23T10:41:09  <JeremyCrookshank> Morning, is there a handy guide for developing the GUI using QT? I swear i've seen one but can't find it
275 2019-11-23T10:41:37  *** EagleTM has quit IRC
276 2019-11-23T10:43:23  *** cryptoIndio has quit IRC
277 2019-11-23T10:43:28  <sipsorcery> JeremyCrookshank: only one I've seen is readme at https://github.com/bitcoin/bitcoin/tree/master/src/qt
278 2019-11-23T10:44:12  <sipsorcery> someone else asked the same question here last week.
279 2019-11-23T10:44:32  *** nosss2_ has joined #bitcoin-core-dev
280 2019-11-23T10:44:36  *** nosss2 has quit IRC
281 2019-11-23T10:45:02  <JeremyCrookshank> Perfect cheers
282 2019-11-23T10:45:32  <emilengler> How can I execute multiple tests in one file?
283 2019-11-23T10:45:46  <emilengler> Adding the second class to main does not work :/
284 2019-11-23T10:49:21  *** nosss2_ has quit IRC
285 2019-11-23T10:51:32  *** rafalcpp_ has joined #bitcoin-core-dev
286 2019-11-23T10:51:37  *** rafalcpp has quit IRC
287 2019-11-23T10:56:53  *** nosss2 has joined #bitcoin-core-dev
288 2019-11-23T10:57:31  <wumpus> JeremyCrookshank: there's a lot of documentation on the Qt site, I think you need to be more specific in your question; FWIW, you can open the .ui files in qt designer
289 2019-11-23T10:57:54  <wumpus> emilengler: which kind of tests? unit or functional?
290 2019-11-23T10:58:08  <emilengler> wumpus: Functional
291 2019-11-23T10:59:15  *** cryptoIndio has joined #bitcoin-core-dev
292 2019-11-23T10:59:35  <jonatack> emilengler: did you have a look at test/functional/example_test.py?
293 2019-11-23T11:00:11  <emilengler> jonatack: Sure
294 2019-11-23T11:00:23  <emilengler> In #17536 it was said that it is possible to add multiple *.main() calls to the main function and then execute them
295 2019-11-23T11:00:25  <gribble> https://github.com/bitcoin/bitcoin/issues/17536 | test: Add test for rpc_whitelist by emilengler · Pull Request #17536 · bitcoin/bitcoin · GitHub
296 2019-11-23T11:00:39  <wumpus> emilengler: you should only have one class per implementation file there; I'm not sure why you'd want multiple, some bigger tests do logical separateion of parts by having more methods and calling them in turn
297 2019-11-23T11:00:55  <emilengler> But it does not work, also a "tail test/functional/*" does not show this aprroach for any other file (as far as I looked so far)
298 2019-11-23T11:01:17  <emilengler> wumpus: I need to test two states of a cli arg
299 2019-11-23T11:01:26  *** nosss2 has quit IRC
300 2019-11-23T11:01:27  <emilengler> foo=0 and foo=1
301 2019-11-23T11:01:47  <emilengler> As bitcoind needs a restart for it I thought about doing it in 2 files
302 2019-11-23T11:01:58  <wumpus> you can restart bitcoind from your test, no problem
303 2019-11-23T11:02:00  <emilengler> Or in one file with multiple classes which seem to not work
304 2019-11-23T11:02:14  <emilengler> wumpus: Really? How?
305 2019-11-23T11:02:53  <wumpus> there's plenty of tests that check different argument combinations, the easiest way is to have it spawn multiple bitcoind nodes initially, but if that's too much combinations, you can always start and stop nodes on request
306 2019-11-23T11:03:19  <emilengler> Ok I will try, thanks :)
307 2019-11-23T11:03:24  <wumpus> stop_node, restart_node,..
308 2019-11-23T11:03:36  <jonatack> emilengler: test_framework.py:445:    def restart_node(self, i, extra_args=None):
309 2019-11-23T11:04:35  <jonatack> emilengler: (git grep "def restart")
310 2019-11-23T11:08:37  *** rafalcpp_ has quit IRC
311 2019-11-23T11:09:02  *** rafalcpp_ has joined #bitcoin-core-dev
312 2019-11-23T11:11:21  *** nosss2 has joined #bitcoin-core-dev
313 2019-11-23T11:14:28  *** nosss2_ has joined #bitcoin-core-dev
314 2019-11-23T11:14:33  *** nosss2 has quit IRC
315 2019-11-23T11:16:23  *** emilengler has quit IRC
316 2019-11-23T11:17:14  *** rafalcpp_ has quit IRC
317 2019-11-23T11:17:46  *** rafalcpp_ has joined #bitcoin-core-dev
318 2019-11-23T11:18:50  *** nosss2_ has quit IRC
319 2019-11-23T11:26:50  *** cryptoIndio has quit IRC
320 2019-11-23T11:27:33  *** rafalcpp has joined #bitcoin-core-dev
321 2019-11-23T11:28:01  *** rafalcpp_ has quit IRC
322 2019-11-23T11:29:20  *** emilengler has joined #bitcoin-core-dev
323 2019-11-23T11:32:20  *** rafalcpp_ has joined #bitcoin-core-dev
324 2019-11-23T11:32:22  *** rafalcpp has quit IRC
325 2019-11-23T11:37:01  <wumpus> AppVeyor is failing on "bench_verify_script.obj : error LNK2001: unresolved external symbol "struct CMutableTransaction __cdecl BuildSpendingTransaction(class CScript const &,struct CScriptWitness const &,class CTransaction const &)" (?BuildSpendingTransaction@@YA?AUCMutableTrans"
326 2019-11-23T11:37:09  <wumpus> did anyone forget to update the MSVC build system?
327 2019-11-23T11:37:53  <sipsorcery> wumpus: on master?
328 2019-11-23T11:38:27  <wumpus> I think so, I'm seeing the same error in many PRs, even #17561 which only updates docs
329 2019-11-23T11:38:29  <gribble> https://github.com/bitcoin/bitcoin/issues/17561 | doc: Changed MiniUPnPc link to https in dependencies.md by sandakersmann · Pull Request #17561 · bitcoin/bitcoin · GitHub
330 2019-11-23T11:39:33  <sipsorcery> will check with a local msvc build (otherwise it's a 1hr turn around time for appveyor)
331 2019-11-23T11:39:54  *** rafalcpp_ has quit IRC
332 2019-11-23T11:40:09  *** rafalcpp_ has joined #bitcoin-core-dev
333 2019-11-23T11:41:40  <wumpus> I think #17542 is most likely to have introduced it of recent changes
334 2019-11-23T11:41:43  <gribble> https://github.com/bitcoin/bitcoin/issues/17542 | build: Create test utility library from src/test/util/ by brakmic · Pull Request #17542 · bitcoin/bitcoin · GitHub
335 2019-11-23T11:42:00  *** nosss2 has joined #bitcoin-core-dev
336 2019-11-23T11:43:28  *** AaronvanW has joined #bitcoin-core-dev
337 2019-11-23T11:46:33  *** nosss2 has quit IRC
338 2019-11-23T11:48:19  *** AaronvanW has quit IRC
339 2019-11-23T11:51:12  <sipsorcery> wumpus: yes the msvc build of bench_bitcoin is failing on master. i will investigate.
340 2019-11-23T11:52:47  *** nosss2 has joined #bitcoin-core-dev
341 2019-11-23T11:52:48  *** rafalcpp_ has quit IRC
342 2019-11-23T11:56:21  *** nosss2_ has joined #bitcoin-core-dev
343 2019-11-23T11:56:29  *** nosss2 has quit IRC
344 2019-11-23T11:58:27  *** rafalcpp_ has joined #bitcoin-core-dev
345 2019-11-23T12:00:02  *** aljungberg has quit IRC
346 2019-11-23T12:00:50  *** nosss2_ has quit IRC
347 2019-11-23T12:06:05  *** cryptoIndio has joined #bitcoin-core-dev
348 2019-11-23T12:06:17  *** rafalcpp_ has quit IRC
349 2019-11-23T12:06:17  *** rafalcpp has joined #bitcoin-core-dev
350 2019-11-23T12:08:47  *** SiAnDoG has quit IRC
351 2019-11-23T12:10:01  *** SiAnDoG has joined #bitcoin-core-dev
352 2019-11-23T12:13:28  *** nosss2 has joined #bitcoin-core-dev
353 2019-11-23T12:15:09  *** cryptoIndio has quit IRC
354 2019-11-23T12:15:25  *** cryptoIndio has joined #bitcoin-core-dev
355 2019-11-23T12:16:37  *** mol has quit IRC
356 2019-11-23T12:17:45  *** nosss2 has quit IRC
357 2019-11-23T12:21:56  *** cryptoIndio has quit IRC
358 2019-11-23T12:23:18  *** rafalcpp_ has joined #bitcoin-core-dev
359 2019-11-23T12:23:36  *** rafalcpp has quit IRC
360 2019-11-23T12:23:58  *** AaronvanW has joined #bitcoin-core-dev
361 2019-11-23T12:27:48  *** rafalcpp_ has quit IRC
362 2019-11-23T12:28:07  *** rafalcpp_ has joined #bitcoin-core-dev
363 2019-11-23T12:28:15  *** AaronvanW has quit IRC
364 2019-11-23T12:30:36  *** nosss2 has joined #bitcoin-core-dev
365 2019-11-23T12:30:56  <wumpus> sipsorcery: thanks!
366 2019-11-23T12:32:32  <sipsorcery> wumpus: np. you were correct the new libtest_util lib from #17452 is not part of the msvc build config. i've added and will submit PR imminently.
367 2019-11-23T12:32:35  <gribble> https://github.com/bitcoin/bitcoin/issues/17452 | lib: update fuzz directory in .gitignore by jonatack · Pull Request #17452 · bitcoin/bitcoin · GitHub
368 2019-11-23T12:34:50  *** nosss2 has quit IRC
369 2019-11-23T12:35:07  *** nosss2 has joined #bitcoin-core-dev
370 2019-11-23T12:35:21  <darosior> meshcollider, wumpus, achow101: The test added in #17568 pass on master for me as well..
371 2019-11-23T12:35:23  <gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 · Pull Request #17568 · bitcoin/bitcoin · GitHub
372 2019-11-23T12:39:33  *** rafalcpp_ has quit IRC
373 2019-11-23T12:39:40  *** rafalcpp has joined #bitcoin-core-dev
374 2019-11-23T12:40:23  *** nosss2 has quit IRC
375 2019-11-23T12:42:18  *** EagleTM has joined #bitcoin-core-dev
376 2019-11-23T12:44:09  *** nosss2 has joined #bitcoin-core-dev
377 2019-11-23T12:45:25  *** bitcoin-git has joined #bitcoin-core-dev
378 2019-11-23T12:45:25  <bitcoin-git> [bitcoin] sipsorcery opened pull request #17571: WIP: Add libtest_util library to msvc build configuration (master...msvc_libtestutil) https://github.com/bitcoin/bitcoin/pull/17571
379 2019-11-23T12:45:27  *** bitcoin-git has left #bitcoin-core-dev
380 2019-11-23T12:47:03  *** ButterflyOfFire has joined #bitcoin-core-dev
381 2019-11-23T12:48:26  *** nosss2 has quit IRC
382 2019-11-23T12:48:31  *** cryptoIn_ has joined #bitcoin-core-dev
383 2019-11-23T12:49:35  *** cryptoIn_ has quit IRC
384 2019-11-23T12:54:32  *** rafalcpp has quit IRC
385 2019-11-23T12:54:39  *** nosss2 has joined #bitcoin-core-dev
386 2019-11-23T12:55:00  <JeremyCrookshank> Anyone know why Qt-creator says the Bitcoin form .h files aren't part of the project? Not able to add slots because of it
387 2019-11-23T12:55:09  <JeremyCrookshank> Doesn't do it on the sample project
388 2019-11-23T12:57:55  <wumpus> the .pro isn't a suitable build system for building the project, it simply collects the form files for editing in qt creator / designer, it might be that some advanced functionality doesn't work
389 2019-11-23T12:59:06  *** spinza has quit IRC
390 2019-11-23T12:59:14  *** AaronvanW has joined #bitcoin-core-dev
391 2019-11-23T12:59:16  *** emilengler has quit IRC
392 2019-11-23T12:59:30  *** emilengler has joined #bitcoin-core-dev
393 2019-11-23T12:59:55  *** jonatack_ has joined #bitcoin-core-dev
394 2019-11-23T13:00:23  <JeremyCrookshank> Hmm okay so i'll have to code in slots manually as the qt-creator option doesn't work
395 2019-11-23T13:00:31  *** misterwhatever has joined #bitcoin-core-dev
396 2019-11-23T13:00:36  <wumpus> yes
397 2019-11-23T13:01:02  <JeremyCrookshank> Thats annoying :p
398 2019-11-23T13:01:47  *** nosss2 has quit IRC
399 2019-11-23T13:03:08  *** jonatack has quit IRC
400 2019-11-23T13:03:47  *** AaronvanW has quit IRC
401 2019-11-23T13:04:42  <wumpus> yes it is, but it's also not really worth it to maintain another build system for it, and I think most devs prefer implementing the hooks and such manually to have more control over what happens
402 2019-11-23T13:05:32  *** gelmutshmidt has joined #bitcoin-core-dev
403 2019-11-23T13:05:44  <wumpus> also .pro is very limited as build systems go, I don't think it'd even be possible to use it anymore to build the full project. ofc, your could simply add the .h files to it and see that helps.
404 2019-11-23T13:06:09  <wumpus> if it's just a matter of the IDE needing to find the code
405 2019-11-23T13:06:17  *** gelmutshmidt has quit IRC
406 2019-11-23T13:06:44  *** gelmutshmidt has joined #bitcoin-core-dev
407 2019-11-23T13:08:28  <JeremyCrookshank> Yeah tried that already unfortunately
408 2019-11-23T13:08:45  *** cryptoIndio has joined #bitcoin-core-dev
409 2019-11-23T13:08:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
410 2019-11-23T13:11:16  *** cryptoIndio has quit IRC
411 2019-11-23T13:15:02  *** MrPaz has joined #bitcoin-core-dev
412 2019-11-23T13:19:33  *** nosss2 has joined #bitcoin-core-dev
413 2019-11-23T13:19:42  *** AaronvanW has joined #bitcoin-core-dev
414 2019-11-23T13:20:40  *** misterwhatever has quit IRC
415 2019-11-23T13:23:57  *** nosss2 has quit IRC
416 2019-11-23T13:27:31  *** Highway61 has joined #bitcoin-core-dev
417 2019-11-23T13:28:32  *** spinza has joined #bitcoin-core-dev
418 2019-11-23T13:40:50  *** rex4539 has quit IRC
419 2019-11-23T13:42:04  *** emilengler has quit IRC
420 2019-11-23T13:42:15  *** emilengler has joined #bitcoin-core-dev
421 2019-11-23T13:48:46  *** MrPaz has quit IRC
422 2019-11-23T13:51:38  *** Chris_Stewart_5 has quit IRC
423 2019-11-23T13:57:09  *** Highway62 has joined #bitcoin-core-dev
424 2019-11-23T13:57:14  <fanquake> wumpus hopefully 👍
425 2019-11-23T13:57:14  *** spinza has quit IRC
426 2019-11-23T13:59:18  *** Highway61 has quit IRC
427 2019-11-23T13:59:18  *** Highway62 is now known as Highway61
428 2019-11-23T14:10:58  *** pinheadmz_ has joined #bitcoin-core-dev
429 2019-11-23T14:13:17  *** pinheadmz has quit IRC
430 2019-11-23T14:13:17  *** pinheadmz_ is now known as pinheadmz
431 2019-11-23T14:20:05  *** cryptoIndio has joined #bitcoin-core-dev
432 2019-11-23T14:22:41  *** cryptoIndio has quit IRC
433 2019-11-23T14:25:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
434 2019-11-23T14:26:05  *** cryptoIndio has joined #bitcoin-core-dev
435 2019-11-23T14:28:33  *** cryptoIndio has quit IRC
436 2019-11-23T14:34:00  *** braydonf has quit IRC
437 2019-11-23T14:36:15  <wumpus> at least locally it seems to make the gitian linux build pass again
438 2019-11-23T14:40:38  *** Chris_Stewart_5 has quit IRC
439 2019-11-23T14:47:15  *** braydonf has joined #bitcoin-core-dev
440 2019-11-23T14:47:23  *** Aaronvan_ has joined #bitcoin-core-dev
441 2019-11-23T14:49:57  *** AaronvanW has quit IRC
442 2019-11-23T14:57:02  *** ExtraCrispy has joined #bitcoin-core-dev
443 2019-11-23T14:58:10  *** cryptoIndio has joined #bitcoin-core-dev
444 2019-11-23T15:00:02  *** ButterflyOfFire has quit IRC
445 2019-11-23T15:00:43  *** cryptoIndio has quit IRC
446 2019-11-23T15:01:07  *** JamesAU has joined #bitcoin-core-dev
447 2019-11-23T15:04:17  *** nik-j has quit IRC
448 2019-11-23T15:07:01  *** cryptoIndio has joined #bitcoin-core-dev
449 2019-11-23T15:07:41  *** Aaronvan_ is now known as AaronvanW
450 2019-11-23T15:17:32  *** dvratil has joined #bitcoin-core-dev
451 2019-11-23T15:19:45  *** cryptoIndio has quit IRC
452 2019-11-23T15:20:20  *** AaronvanW has quit IRC
453 2019-11-23T15:28:39  <wumpus> or not, I get a NX failure after "Checking binary security" for RISC-V now, wtf
454 2019-11-23T15:31:57  <wumpus> crap, after a failed build it doesn't cache the dependencies, so it needs to build qt all over again next time...
455 2019-11-23T15:33:31  <fanquake> ugh
456 2019-11-23T15:35:53  <wumpus> I wonder what broke the rv64 build, it might well be another change entirely, or something is messed up here locally
457 2019-11-23T15:36:17  *** rabidus has quit IRC
458 2019-11-23T15:38:24  *** rabidus has joined #bitcoin-core-dev
459 2019-11-23T15:38:30  *** cryptoIndio has joined #bitcoin-core-dev
460 2019-11-23T15:41:10  *** cryptoIndio has quit IRC
461 2019-11-23T15:46:32  *** AaronvanW has joined #bitcoin-core-dev
462 2019-11-23T15:46:35  *** alex911kz has joined #bitcoin-core-dev
463 2019-11-23T15:50:17  *** Highway61 has quit IRC
464 2019-11-23T15:50:56  *** Highway61 has joined #bitcoin-core-dev
465 2019-11-23T15:52:21  *** owowo has quit IRC
466 2019-11-23T15:57:12  *** owowo has joined #bitcoin-core-dev
467 2019-11-23T16:02:05  *** cryptoIndio has joined #bitcoin-core-dev
468 2019-11-23T16:05:06  *** cryptoIndio has quit IRC
469 2019-11-23T16:07:02  *** spinza has joined #bitcoin-core-dev
470 2019-11-23T16:07:51  *** Highway61 has quit IRC
471 2019-11-23T16:10:37  *** spinza has quit IRC
472 2019-11-23T16:12:28  *** jonatack_ has quit IRC
473 2019-11-23T16:13:00  *** nik-j has joined #bitcoin-core-dev
474 2019-11-23T16:13:54  *** jonatack_ has joined #bitcoin-core-dev
475 2019-11-23T16:16:20  *** nik-j has quit IRC
476 2019-11-23T16:22:21  *** pinheadmz_ has joined #bitcoin-core-dev
477 2019-11-23T16:25:33  *** pinheadmz has quit IRC
478 2019-11-23T16:25:33  *** pinheadmz_ is now known as pinheadmz
479 2019-11-23T16:30:41  *** bitcoin-git has joined #bitcoin-core-dev
480 2019-11-23T16:30:41  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0b79caf65801...33c103e2fe67
481 2019-11-23T16:30:42  <bitcoin-git> bitcoin/master 794fe91 Hennadii Stepanov: doc: Update and improve Developer Notes
482 2019-11-23T16:30:42  <bitcoin-git> bitcoin/master 33c103e fanquake: Merge #17539: doc: Update and improve Developer Notes
483 2019-11-23T16:30:44  *** bitcoin-git has left #bitcoin-core-dev
484 2019-11-23T16:31:01  *** bitcoin-git has joined #bitcoin-core-dev
485 2019-11-23T16:31:01  <bitcoin-git> [bitcoin] fanquake merged pull request #17539: doc: Update and improve Developer Notes (master...20191120-developer-notes) https://github.com/bitcoin/bitcoin/pull/17539
486 2019-11-23T16:31:02  *** bitcoin-git has left #bitcoin-core-dev
487 2019-11-23T16:31:18  *** emil__ has joined #bitcoin-core-dev
488 2019-11-23T16:35:02  *** emilengler has quit IRC
489 2019-11-23T16:36:19  *** JamesAU has quit IRC
490 2019-11-23T16:38:11  <achow101> meshcollider: darosior: it consistently fails for me on master
491 2019-11-23T16:38:56  *** adiabat has quit IRC
492 2019-11-23T16:41:48  <wumpus> same here
493 2019-11-23T16:42:39  <cfields> jonasschnelli: Looks like your macos sig is invalid :(
494 2019-11-23T16:42:40  *** spinza has joined #bitcoin-core-dev
495 2019-11-23T16:42:41  <cfields> cory@Macbook:~/dev/bitcoin$ spctl --assess -vv /Volumes/Bitcoin-Core/Bitcoin-Qt.app
496 2019-11-23T16:42:41  <cfields> /Volumes/Bitcoin-Core/Bitcoin-Qt.app: invalid Info.plist (plist or signature have been modified)
497 2019-11-23T16:44:36  <cfields> Oh wait, might be my local problem.
498 2019-11-23T16:47:30  *** nik-j_ has joined #bitcoin-core-dev
499 2019-11-23T16:48:57  *** nosss2 has joined #bitcoin-core-dev
500 2019-11-23T16:50:57  <cfields> Yup, all good.
501 2019-11-23T16:51:08  <fanquake> 🚀
502 2019-11-23T16:51:08  <cfields> Gitian builders: detached sigs for v0.19.0.1 are up
503 2019-11-23T16:51:37  *** nik-j_ has quit IRC
504 2019-11-23T16:51:56  *** bitcoin-git has joined #bitcoin-core-dev
505 2019-11-23T16:51:56  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #17573: Seed RNG with precision timestamps on receipt of net messages. (master...2019-11-rng-netmsg) https://github.com/bitcoin/bitcoin/pull/17573
506 2019-11-23T16:51:57  *** bitcoin-git has left #bitcoin-core-dev
507 2019-11-23T16:52:42  *** jonatack_ has quit IRC
508 2019-11-23T16:52:58  *** jonatack has joined #bitcoin-core-dev
509 2019-11-23T16:53:18  *** nosss2 has quit IRC
510 2019-11-23T17:04:42  *** cryptoIndio has joined #bitcoin-core-dev
511 2019-11-23T17:07:08  *** cryptoIndio has quit IRC
512 2019-11-23T17:11:15  <wumpus> cfields: jonasschnelli: great, thanks!
513 2019-11-23T17:20:30  *** lnostdal has joined #bitcoin-core-dev
514 2019-11-23T17:27:49  *** cryptoIndio has joined #bitcoin-core-dev
515 2019-11-23T17:28:36  *** alex911_kz has joined #bitcoin-core-dev
516 2019-11-23T17:28:40  *** gelmuth_ has joined #bitcoin-core-dev
517 2019-11-23T17:30:17  *** alex911kz has quit IRC
518 2019-11-23T17:30:17  *** gelmutshmidt has quit IRC
519 2019-11-23T17:30:39  *** cryptoIndio has quit IRC
520 2019-11-23T17:33:45  *** nik-j has joined #bitcoin-core-dev
521 2019-11-23T17:38:15  *** nik-j has quit IRC
522 2019-11-23T17:39:39  *** bitcoin-git has joined #bitcoin-core-dev
523 2019-11-23T17:39:39  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/33c103e2fe67...2c98e2024d52
524 2019-11-23T17:39:40  <bitcoin-git> bitcoin/master b509554 Aaron Clauson: Added libtest_util library to msvc build configuration.
525 2019-11-23T17:39:40  <bitcoin-git> bitcoin/master 2c98e20 fanquake: Merge #17571: Add libtest_util library to msvc build configuration
526 2019-11-23T17:39:43  *** bitcoin-git has left #bitcoin-core-dev
527 2019-11-23T17:39:59  *** bitcoin-git has joined #bitcoin-core-dev
528 2019-11-23T17:39:59  <bitcoin-git> [bitcoin] fanquake merged pull request #17571: Add libtest_util library to msvc build configuration (master...msvc_libtestutil) https://github.com/bitcoin/bitcoin/pull/17571
529 2019-11-23T17:40:00  *** bitcoin-git has left #bitcoin-core-dev
530 2019-11-23T17:49:43  *** Highway61 has joined #bitcoin-core-dev
531 2019-11-23T17:54:19  *** jonatack has quit IRC
532 2019-11-23T17:54:25  *** Highway61 has quit IRC
533 2019-11-23T18:00:02  *** dvratil has quit IRC
534 2019-11-23T18:00:19  *** spinza has quit IRC
535 2019-11-23T18:00:28  *** JamesAU has joined #bitcoin-core-dev
536 2019-11-23T18:01:14  *** cryptoIn_ has joined #bitcoin-core-dev
537 2019-11-23T18:10:20  *** nosss2 has joined #bitcoin-core-dev
538 2019-11-23T18:10:32  *** ExtraCrispy has quit IRC
539 2019-11-23T18:16:19  *** spinza has joined #bitcoin-core-dev
540 2019-11-23T18:16:54  *** zone117x1 has joined #bitcoin-core-dev
541 2019-11-23T18:18:55  *** spinza has quit IRC
542 2019-11-23T18:18:56  *** gelmuth_ has quit IRC
543 2019-11-23T18:20:16  *** cryptoIn_ has quit IRC
544 2019-11-23T18:27:31  *** AaronvanW has quit IRC
545 2019-11-23T18:31:04  *** andrewtoth_ has quit IRC
546 2019-11-23T18:31:19  *** spinza has joined #bitcoin-core-dev
547 2019-11-23T18:42:39  *** Victorsueca has quit IRC
548 2019-11-23T18:43:13  *** Victorsueca has joined #bitcoin-core-dev
549 2019-11-23T18:44:26  <provoostenator> ^ rebase time!
550 2019-11-23T18:45:00  *** spinza has quit IRC
551 2019-11-23T18:47:04  *** Tommy19 has joined #bitcoin-core-dev
552 2019-11-23T18:50:45  *** spinza has joined #bitcoin-core-dev
553 2019-11-23T18:57:46  *** nosss2 has quit IRC
554 2019-11-23T18:58:18  *** nosss2 has joined #bitcoin-core-dev
555 2019-11-23T19:02:42  *** JeremyCrookshank has quit IRC
556 2019-11-23T19:02:50  *** nosss2 has quit IRC
557 2019-11-23T19:02:55  *** adiabat has joined #bitcoin-core-dev
558 2019-11-23T19:03:21  *** AaronvanW has joined #bitcoin-core-dev
559 2019-11-23T19:07:58  *** AaronvanW has quit IRC
560 2019-11-23T19:14:31  *** spinza has quit IRC
561 2019-11-23T19:17:37  *** sipsorcery has quit IRC
562 2019-11-23T19:17:38  *** spinza has joined #bitcoin-core-dev
563 2019-11-23T19:22:41  *** fox2p has quit IRC
564 2019-11-23T19:23:08  *** fox2p has joined #bitcoin-core-dev
565 2019-11-23T19:33:17  <wumpus> the gitian RV64 check failure is not caused by #17270, it appears, but some later change, I'm bisecting
566 2019-11-23T19:33:20  <gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa · Pull Request #17270 · bitcoin/bitcoin · GitHub
567 2019-11-23T19:34:43  *** nik-j has joined #bitcoin-core-dev
568 2019-11-23T19:34:46  <sipa> wumpus: strange
569 2019-11-23T19:35:31  *** nik-j_ has joined #bitcoin-core-dev
570 2019-11-23T19:35:54  *** nik-j has quit IRC
571 2019-11-23T19:37:39  *** nik-j_ has quit IRC
572 2019-11-23T19:40:27  <wumpus> i suspect it's some build system change that makes it eat a required flag
573 2019-11-23T19:42:34  *** cino94 has joined #bitcoin-core-dev
574 2019-11-23T19:46:49  *** spinza has quit IRC
575 2019-11-23T19:47:55  *** cino94 has quit IRC
576 2019-11-23T19:49:04  *** llfsdfsdfsfs has joined #bitcoin-core-dev
577 2019-11-23T19:53:54  *** llfsdfsdfsfs has quit IRC
578 2019-11-23T19:58:58  *** cino94 has joined #bitcoin-core-dev
579 2019-11-23T20:03:43  *** cino94 has quit IRC
580 2019-11-23T20:05:45  <fanquake> wumpus maybe it was broken when we removed OpenSSL 🙈
581 2019-11-23T20:07:19  <wumpus> definitely possible !
582 2019-11-23T20:14:52  *** nik-j_ has joined #bitcoin-core-dev
583 2019-11-23T20:19:38  *** nosss2 has joined #bitcoin-core-dev
584 2019-11-23T20:19:39  *** nik-j_ has quit IRC
585 2019-11-23T20:21:43  *** justanotheruser has joined #bitcoin-core-dev
586 2019-11-23T20:26:04  *** justanotheruser has quit IRC
587 2019-11-23T20:27:20  *** dviola has joined #bitcoin-core-dev
588 2019-11-23T20:28:35  *** alex911kz has joined #bitcoin-core-dev
589 2019-11-23T20:31:46  *** alex911_kz has quit IRC
590 2019-11-23T20:33:04  *** nosss2 has quit IRC
591 2019-11-23T20:33:21  <fanquake> "PS this seems to be causing a noise inversely proportional to the complexity of the change" https://github.com/bitcoin/bitcoin/pull/17563#issuecomment-557829862
592 2019-11-23T20:33:33  *** nosss2 has joined #bitcoin-core-dev
593 2019-11-23T20:33:37  *** spinza has joined #bitcoin-core-dev
594 2019-11-23T20:33:49  <fanquake> What else was he expecting when he PR'd an initially poorly explained change to the ifdef hackery inside random.cpp
595 2019-11-23T20:35:49  <wumpus> we're pretty consistent in this, too, I've closed PRs of myself too when 'working around a warning' was just not worth the mess
596 2019-11-23T20:37:38  *** nosss2 has quit IRC
597 2019-11-23T20:37:48  <fanquake> The initial change just felt like a Debian OpenSSL Valgrind scenario
598 2019-11-23T20:40:27  *** justanotheruser has joined #bitcoin-core-dev
599 2019-11-23T20:47:23  *** EagleTM has quit IRC
600 2019-11-23T20:50:27  <wumpus> bisected it to b49b6b0f7090cc15860d815fb0ef306ddfc718ba, so indeed seems that the change has to do with openssl removal, very curious
601 2019-11-23T20:54:01  <fanquake> interesting
602 2019-11-23T20:54:10  <wumpus> it's not even a build system change, just the last change that causes no symbols from openssl to be used anymore
603 2019-11-23T20:54:28  <sipa> heh
604 2019-11-23T20:54:30  *** EagleTM has joined #bitcoin-core-dev
605 2019-11-23T20:54:37  *** DougieBot5000 has joined #bitcoin-core-dev
606 2019-11-23T20:55:40  <wumpus> it looks like we never explicitly pass -Wl,--noexecstack except to openssl
607 2019-11-23T20:56:16  <meshcollider> darosior: thanks for testing, good to know it's not just me haha. I'll try and investigate today
608 2019-11-23T20:56:32  <wumpus> all the other architectures default to it, though, so might as well be an ubuntu compiler issue
609 2019-11-23T20:56:46  *** spinza has quit IRC
610 2019-11-23T20:57:23  *** DougieBot5000_ has quit IRC
611 2019-11-23T20:57:34  *** pinheadmz has quit IRC
612 2019-11-23T20:59:44  <potatoe_face> %
613 2019-11-23T21:00:02  *** zone117x1 has quit IRC
614 2019-11-23T21:01:16  *** spinza has joined #bitcoin-core-dev
615 2019-11-23T21:04:15  *** pinheadmz has joined #bitcoin-core-dev
616 2019-11-23T21:10:06  *** potatoe_face has quit IRC
617 2019-11-23T21:11:38  *** potatoe_face has joined #bitcoin-core-dev
618 2019-11-23T21:16:09  *** potatoe_face has quit IRC
619 2019-11-23T21:16:24  *** potatoe_face has joined #bitcoin-core-dev
620 2019-11-23T21:17:02  *** rh0nj has quit IRC
621 2019-11-23T21:18:08  *** rh0nj has joined #bitcoin-core-dev
622 2019-11-23T21:30:19  *** AaronvanW has joined #bitcoin-core-dev
623 2019-11-23T21:35:20  *** AaronvanW has quit IRC
624 2019-11-23T21:39:55  *** potatoe_face has quit IRC
625 2019-11-23T21:40:16  *** potatoe_face has joined #bitcoin-core-dev
626 2019-11-23T21:40:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
627 2019-11-23T21:42:18  *** justanotheruser has quit IRC
628 2019-11-23T21:43:16  *** potatoe_face has quit IRC
629 2019-11-23T21:43:35  *** potatoe_face has joined #bitcoin-core-dev
630 2019-11-23T21:43:38  *** alex911kz has quit IRC
631 2019-11-23T21:47:51  *** MaddinSM has joined #bitcoin-core-dev
632 2019-11-23T21:48:33  <wumpus> it's good that we have the security check or we'd never have noticed; the workaround of adding  -Wl,-z,noexecstack explicitly on RISC-V in the descriptor seems to work, but I'm still trying to figure out why it doesn't get set automatically there
633 2019-11-23T21:56:08  *** Chris_Stewart_5 has quit IRC
634 2019-11-23T22:02:46  *** justanotheruser has joined #bitcoin-core-dev
635 2019-11-23T22:18:59  *** dviola has quit IRC
636 2019-11-23T22:25:11  <fanquake> wumpus good hunting
637 2019-11-23T22:30:14  <wumpus> thanks! this one was very sneaky; hopefully this was the last problem and we can start using gitian again
638 2019-11-23T22:30:59  *** AaronvanW has joined #bitcoin-core-dev
639 2019-11-23T22:37:08  *** Tommy19 has quit IRC
640 2019-11-23T22:44:32  *** b10c has joined #bitcoin-core-dev
641 2019-11-23T22:54:21  *** jonatack has joined #bitcoin-core-dev
642 2019-11-23T23:01:09  *** cryptoIndio has joined #bitcoin-core-dev
643 2019-11-23T23:04:17  <achow101> meshcollider: are you sure you have an updated master? The issue was only after #17290 was merged
644 2019-11-23T23:04:19  <gribble> https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 · Pull Request #17290 · bitcoin/bitcoin · GitHub
645 2019-11-23T23:08:21  *** nosss2 has joined #bitcoin-core-dev
646 2019-11-23T23:10:47  <meshcollider> well yeah I merged it haha
647 2019-11-23T23:11:07  <achow101> could be an old branch/ different worktree, i dunno
648 2019-11-23T23:11:21  <meshcollider> Yeah I'll double check later and recompile fresh master
649 2019-11-23T23:23:26  *** cryptoIndio has joined #bitcoin-core-dev
650 2019-11-23T23:28:18  *** cryptoIndio has quit IRC
651 2019-11-23T23:32:00  *** AaronvanW has quit IRC
652 2019-11-23T23:32:17  *** AaronvanW has joined #bitcoin-core-dev
653 2019-11-23T23:34:51  *** b10c has quit IRC
654 2019-11-23T23:49:20  *** Giszmo has joined #bitcoin-core-dev
655 2019-11-23T23:51:28  *** emil__ has quit IRC
656 2019-11-23T23:58:32  *** nik-j has joined #bitcoin-core-dev