1 2019-11-25T00:00:01  *** litenull has quit IRC
  2 2019-11-25T00:03:57  *** Chris_Stewart_5 has quit IRC
  3 2019-11-25T00:05:12  *** murray has joined #bitcoin-core-dev
  4 2019-11-25T00:05:35  *** murray is now known as Guest75709
  5 2019-11-25T00:05:58  *** Guest75709 has left #bitcoin-core-dev
  6 2019-11-25T00:06:05  *** cryptoIndio has joined #bitcoin-core-dev
  7 2019-11-25T00:06:42  *** murrayn has joined #bitcoin-core-dev
  8 2019-11-25T00:08:49  *** nosss2 has quit IRC
  9 2019-11-25T00:09:18  *** nosss2 has joined #bitcoin-core-dev
 10 2019-11-25T00:10:31  *** bitcoin-git has joined #bitcoin-core-dev
 11 2019-11-25T00:10:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/746318179884...e6f167bfdfc0
 12 2019-11-25T00:10:33  <bitcoin-git> bitcoin/master f6e4225 Wladimir J. van der Laan: build: Allow export of environ symbols
 13 2019-11-25T00:10:34  <bitcoin-git> bitcoin/master eafd259 Wladimir J. van der Laan: build: Add NX workaround for RV64
 14 2019-11-25T00:10:35  <bitcoin-git> bitcoin/master e6f167b MarcoFalke: Merge #17569: build: Allow export of environ symbols and work around rv64 ...
 15 2019-11-25T00:10:41  *** bitcoin-git has left #bitcoin-core-dev
 16 2019-11-25T00:10:59  *** nosss2 has quit IRC
 17 2019-11-25T00:11:01  *** bitcoin-git has joined #bitcoin-core-dev
 18 2019-11-25T00:11:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17569: build: Allow export of environ symbols and work around rv64 toolchain issue (master...2019_11_environ) https://github.com/bitcoin/bitcoin/pull/17569
 19 2019-11-25T00:11:03  *** bitcoin-git has left #bitcoin-core-dev
 20 2019-11-25T00:13:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 21 2019-11-25T00:14:33  *** nijynot_ has quit IRC
 22 2019-11-25T00:15:10  *** nik-j has joined #bitcoin-core-dev
 23 2019-11-25T00:23:54  *** cryptoIndio has quit IRC
 24 2019-11-25T00:24:26  *** Chris_Stewart_5 has quit IRC
 25 2019-11-25T00:25:49  *** nik-j has quit IRC
 26 2019-11-25T00:26:33  *** trudistrongo has quit IRC
 27 2019-11-25T00:26:51  *** cryptoIndio has joined #bitcoin-core-dev
 28 2019-11-25T00:28:42  *** sipsorcery has joined #bitcoin-core-dev
 29 2019-11-25T00:32:21  *** nik-j has joined #bitcoin-core-dev
 30 2019-11-25T00:32:38  *** cryptoIndio has quit IRC
 31 2019-11-25T00:37:09  *** nik-j has quit IRC
 32 2019-11-25T00:39:06  *** promag has joined #bitcoin-core-dev
 33 2019-11-25T00:40:42  *** rabidus has quit IRC
 34 2019-11-25T00:43:13  *** promag has quit IRC
 35 2019-11-25T00:45:22  *** fox2p has quit IRC
 36 2019-11-25T00:46:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 37 2019-11-25T00:46:50  *** Phace has joined #bitcoin-core-dev
 38 2019-11-25T00:48:01  *** fox2p has joined #bitcoin-core-dev
 39 2019-11-25T00:49:54  *** rabidus has joined #bitcoin-core-dev
 40 2019-11-25T01:00:47  *** davterra has quit IRC
 41 2019-11-25T01:02:17  *** alex911_kz has joined #bitcoin-core-dev
 42 2019-11-25T01:05:00  *** nik-j has joined #bitcoin-core-dev
 43 2019-11-25T01:12:12  *** Fuzzbawl_ has quit IRC
 44 2019-11-25T01:13:39  *** Fuzzbawls has joined #bitcoin-core-dev
 45 2019-11-25T01:14:17  *** nik-j has quit IRC
 46 2019-11-25T01:15:49  *** marcoagner has quit IRC
 47 2019-11-25T01:15:50  *** cryptoIndio has joined #bitcoin-core-dev
 48 2019-11-25T01:24:00  *** AaronvanW has quit IRC
 49 2019-11-25T01:38:21  *** pinheadmz has joined #bitcoin-core-dev
 50 2019-11-25T01:44:43  *** cubancorona has joined #bitcoin-core-dev
 51 2019-11-25T01:47:43  *** Willo__ has quit IRC
 52 2019-11-25T01:56:54  *** bitcoin-git has joined #bitcoin-core-dev
 53 2019-11-25T01:56:54  <bitcoin-git> [bitcoin] jonatack opened pull request #17585: rpc: deprecate getaddressinfo label (master...deprecate-getaddressinfo-label) https://github.com/bitcoin/bitcoin/pull/17585
 54 2019-11-25T01:56:55  *** bitcoin-git has left #bitcoin-core-dev
 55 2019-11-25T02:00:36  *** sdaftuar has quit IRC
 56 2019-11-25T02:01:33  *** sdaftuar has joined #bitcoin-core-dev
 57 2019-11-25T02:03:49  *** cryptoIndio has quit IRC
 58 2019-11-25T02:07:04  *** cryptoIndio has joined #bitcoin-core-dev
 59 2019-11-25T02:08:26  *** Chris_Stewart_5 has quit IRC
 60 2019-11-25T02:29:39  *** nik-j has joined #bitcoin-core-dev
 61 2019-11-25T02:34:44  *** nik-j has quit IRC
 62 2019-11-25T02:43:30  *** nosss2 has joined #bitcoin-core-dev
 63 2019-11-25T02:44:44  *** rex4539 has quit IRC
 64 2019-11-25T02:50:42  *** rex4539 has joined #bitcoin-core-dev
 65 2019-11-25T02:59:27  *** justanotheruser has joined #bitcoin-core-dev
 66 2019-11-25T03:00:02  *** Phace has quit IRC
 67 2019-11-25T03:02:02  *** achow101 has quit IRC
 68 2019-11-25T03:05:33  *** felixfoertsch23 has joined #bitcoin-core-dev
 69 2019-11-25T03:06:35  *** felixfoertsch has quit IRC
 70 2019-11-25T03:12:26  *** achow101 has joined #bitcoin-core-dev
 71 2019-11-25T03:17:20  *** Mlpearc has joined #bitcoin-core-dev
 72 2019-11-25T03:24:00  *** nik-j has joined #bitcoin-core-dev
 73 2019-11-25T03:26:39  *** reallll has joined #bitcoin-core-dev
 74 2019-11-25T03:28:17  *** nik-j has quit IRC
 75 2019-11-25T03:29:37  *** belcher has quit IRC
 76 2019-11-25T03:51:43  *** cryptoIndio has quit IRC
 77 2019-11-25T04:13:33  *** EagleTM has joined #bitcoin-core-dev
 78 2019-11-25T04:14:11  *** Eagle[TM] has quit IRC
 79 2019-11-25T04:29:13  *** Fuzzbawl_ has joined #bitcoin-core-dev
 80 2019-11-25T04:30:20  *** sipsorcery has quit IRC
 81 2019-11-25T04:30:26  *** Fuzzbawls has quit IRC
 82 2019-11-25T04:39:20  *** cryptoIndio has joined #bitcoin-core-dev
 83 2019-11-25T04:54:26  *** nosss2 has quit IRC
 84 2019-11-25T04:54:55  *** nosss2 has joined #bitcoin-core-dev
 85 2019-11-25T04:58:00  *** nosss2 has quit IRC
 86 2019-11-25T04:58:16  *** nik-j has joined #bitcoin-core-dev
 87 2019-11-25T04:58:42  *** nosss2 has joined #bitcoin-core-dev
 88 2019-11-25T04:58:50  *** deadlysin has quit IRC
 89 2019-11-25T05:02:23  *** nik-j has quit IRC
 90 2019-11-25T05:03:14  *** nosss2 has quit IRC
 91 2019-11-25T05:03:22  *** deadlysin has joined #bitcoin-core-dev
 92 2019-11-25T05:07:01  *** nosss2 has joined #bitcoin-core-dev
 93 2019-11-25T05:15:14  *** felixfoertsch23 has quit IRC
 94 2019-11-25T05:15:24  *** felixfoertsch has joined #bitcoin-core-dev
 95 2019-11-25T05:25:05  *** astro has quit IRC
 96 2019-11-25T05:26:07  *** sipsorcery has joined #bitcoin-core-dev
 97 2019-11-25T05:31:54  *** Victor_sueca has joined #bitcoin-core-dev
 98 2019-11-25T05:34:28  *** Victorsueca has quit IRC
 99 2019-11-25T05:35:18  *** astro has joined #bitcoin-core-dev
100 2019-11-25T05:35:30  *** nik-j has joined #bitcoin-core-dev
101 2019-11-25T05:39:37  *** nik-j has quit IRC
102 2019-11-25T05:49:23  *** DeanWeen has joined #bitcoin-core-dev
103 2019-11-25T05:51:24  *** kristapsk_ has joined #bitcoin-core-dev
104 2019-11-25T05:52:04  *** Dean_Guss has quit IRC
105 2019-11-25T05:52:32  *** kristapsk has quit IRC
106 2019-11-25T06:00:01  *** Mlpearc has quit IRC
107 2019-11-25T06:00:10  *** sipsorcery has quit IRC
108 2019-11-25T06:17:21  *** thrig1 has joined #bitcoin-core-dev
109 2019-11-25T06:29:02  *** nik-j has joined #bitcoin-core-dev
110 2019-11-25T06:33:56  *** nik-j has quit IRC
111 2019-11-25T06:38:46  *** nosss2 has quit IRC
112 2019-11-25T06:39:15  *** nosss2 has joined #bitcoin-core-dev
113 2019-11-25T06:43:37  *** nosss2 has quit IRC
114 2019-11-25T06:50:47  *** nosss2 has joined #bitcoin-core-dev
115 2019-11-25T06:55:18  *** nosss2 has quit IRC
116 2019-11-25T06:56:04  *** sipsorcery has joined #bitcoin-core-dev
117 2019-11-25T07:07:42  *** _andrewtoth_ has joined #bitcoin-core-dev
118 2019-11-25T07:09:04  *** andrewtoth_ has quit IRC
119 2019-11-25T07:09:28  *** nik-j has joined #bitcoin-core-dev
120 2019-11-25T07:12:02  *** EagleTM has quit IRC
121 2019-11-25T07:15:42  *** nik-j has quit IRC
122 2019-11-25T07:19:39  *** Guyver2 has joined #bitcoin-core-dev
123 2019-11-25T07:24:08  *** nik-j has joined #bitcoin-core-dev
124 2019-11-25T07:29:51  *** sipsorcery has quit IRC
125 2019-11-25T07:35:14  *** nik-j has quit IRC
126 2019-11-25T07:36:55  *** nik-j has joined #bitcoin-core-dev
127 2019-11-25T07:40:57  *** nik-j has quit IRC
128 2019-11-25T07:41:30  *** nik-j has joined #bitcoin-core-dev
129 2019-11-25T07:42:01  *** rh0nj has quit IRC
130 2019-11-25T07:43:07  *** rh0nj has joined #bitcoin-core-dev
131 2019-11-25T07:46:29  *** reallll is now known as belcher
132 2019-11-25T07:47:38  *** nik-j has quit IRC
133 2019-11-25T07:49:45  *** nik-j has joined #bitcoin-core-dev
134 2019-11-25T07:54:02  *** nik-j has quit IRC
135 2019-11-25T07:55:37  *** DougieBot5000 has quit IRC
136 2019-11-25T08:00:40  *** nik-j has joined #bitcoin-core-dev
137 2019-11-25T08:01:40  *** jonatack_ has joined #bitcoin-core-dev
138 2019-11-25T08:04:10  *** sipsorcery has joined #bitcoin-core-dev
139 2019-11-25T08:04:43  *** jonatack has quit IRC
140 2019-11-25T08:04:57  *** nik-j has quit IRC
141 2019-11-25T08:08:40  *** EagleTM has joined #bitcoin-core-dev
142 2019-11-25T08:11:35  *** nik-j has joined #bitcoin-core-dev
143 2019-11-25T08:11:55  *** promag has joined #bitcoin-core-dev
144 2019-11-25T08:12:51  *** cryptoIndio has quit IRC
145 2019-11-25T08:15:38  *** nik-j has quit IRC
146 2019-11-25T08:15:57  *** promag has quit IRC
147 2019-11-25T08:17:17  *** EagleTM has quit IRC
148 2019-11-25T08:27:15  *** nik-j has joined #bitcoin-core-dev
149 2019-11-25T08:29:03  *** b10c has joined #bitcoin-core-dev
150 2019-11-25T08:34:16  *** DougieBot5000 has joined #bitcoin-core-dev
151 2019-11-25T08:35:17  *** nik-j has quit IRC
152 2019-11-25T08:37:40  *** cryptoIndio has joined #bitcoin-core-dev
153 2019-11-25T08:39:50  *** b10c has quit IRC
154 2019-11-25T08:41:21  *** b10c has joined #bitcoin-core-dev
155 2019-11-25T08:49:25  *** nik-j has joined #bitcoin-core-dev
156 2019-11-25T08:53:51  <wumpus> appveyor failing: "C:\projects\bitcoin\src\httpserver.cpp(373,5): error C3861: 'evthread_use_windows_threads': identifier not found [C:\projects\bitcoin\build_msvc\libbitcoin_server\libbitcoin_server.vcxproj]"
157 2019-11-25T08:54:20  <wumpus> that symbol is definitely supposed to exist on windows libevent
158 2019-11-25T08:56:02  *** nik-j has quit IRC
159 2019-11-25T08:57:17  <meshcollider> when is appveyor *not* failing...
160 2019-11-25T08:58:05  <wumpus> I'm not sure what broke it this time, last time it was clear (someone forgot to update the MSVC buidl system) but this is less apparent
161 2019-11-25T08:59:30  <wumpus> the most recent libevent related change was #17008 but it definitely passed after that, and the depends version shouldn't affect the version used in appveyor
162 2019-11-25T08:59:33  <gribble> https://github.com/bitcoin/bitcoin/issues/17008 | build: bump libevent to 2.1.11 in depends by stefanwouldgo · Pull Request #17008 · bitcoin/bitcoin · GitHub
163 2019-11-25T08:59:54  <meshcollider> perhaps some weird header include thing with #17518 ?
164 2019-11-25T08:59:57  <gribble> https://github.com/bitcoin/bitcoin/issues/17518 | refactor, wallet: Nuke coincontrol circular dependency by hebasto · Pull Request #17518 · bitcoin/bitcoin · GitHub
165 2019-11-25T09:00:01  *** thrig1 has quit IRC
166 2019-11-25T09:00:37  <wumpus> I mean the reason that appveyor breaks all the time is because people ignore appveyor before merging, because it breaks all the time, we kind of need to break that circle *shrug*
167 2019-11-25T09:01:43  *** sipsorcery has quit IRC
168 2019-11-25T09:01:57  *** sipsorcery has joined #bitcoin-core-dev
169 2019-11-25T09:02:32  <wumpus> at least gitian builds work again!
170 2019-11-25T09:03:46  *** kljasdfvv has joined #bitcoin-core-dev
171 2019-11-25T09:07:54  *** marcoagner has joined #bitcoin-core-dev
172 2019-11-25T09:09:15  <meshcollider> true, appveyor has failed on pretty much every single open PR so it kinda just becomes cry-wolf
173 2019-11-25T09:09:23  <meshcollider> we need to fix it and then rebase every PR at once ;)
174 2019-11-25T09:09:32  <hebasto> meshcollider: which include do you mean?
175 2019-11-25T09:09:52  <meshcollider> Not sure, it was just the first PR that was merged after the last appveyor fix and appveyor failed on it
176 2019-11-25T09:09:56  <meshcollider> https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/29078106
177 2019-11-25T09:10:06  *** bitcoin-git has joined #bitcoin-core-dev
178 2019-11-25T09:10:06  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/1bc9988993ee...dd198064b5d9
179 2019-11-25T09:10:06  <bitcoin-git> bitcoin/0.19 dd19806 Wladimir J. van der Laan: doc: Clear out release notes after 0.19.0.1
180 2019-11-25T09:10:17  *** bitcoin-git has left #bitcoin-core-dev
181 2019-11-25T09:10:39  <meshcollider> because when fanquake merged #17571, appveyor actually passed
182 2019-11-25T09:10:40  <wumpus> I don't think the linking error can be caused by an include change
183 2019-11-25T09:10:41  <gribble> https://github.com/bitcoin/bitcoin/issues/17571 | Add libtest_util library to msvc build configuration by sipsorcery · Pull Request #17571 · bitcoin/bitcoin · GitHub
184 2019-11-25T09:11:08  <meshcollider> something must have changed in between those two PRs though right, if it passed on one and failed on the other?
185 2019-11-25T09:11:17  <wumpus> true
186 2019-11-25T09:12:29  <wumpus> though it could also be a change in between when the appveyor test was run on 17571 and merging time, on master
187 2019-11-25T09:14:03  *** nosss2 has joined #bitcoin-core-dev
188 2019-11-25T09:14:18  <meshcollider> it did pass on the merge commit though
189 2019-11-25T09:14:35  <meshcollider> not just sipsorcery's commit
190 2019-11-25T09:14:42  <wumpus> right, it could also be something entirely unrelated, like a dependency/cache change by appveyor itself
191 2019-11-25T09:15:47  <wumpus> we've had similar things with travis at times
192 2019-11-25T09:16:31  *** bitcoin-git has joined #bitcoin-core-dev
193 2019-11-25T09:16:32  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/dd198064b5d9...a284bbbee805
194 2019-11-25T09:16:33  <bitcoin-git> bitcoin/0.19 2aba76c Hennadii Stepanov: qt: Fix missing qRegisterMetaType for size_t
195 2019-11-25T09:16:34  <bitcoin-git> bitcoin/0.19 a284bbb Hennadii Stepanov: refactor: Styling w/ clang-format, comment update
196 2019-11-25T09:16:36  *** bitcoin-git has left #bitcoin-core-dev
197 2019-11-25T09:16:46  <wumpus> the 0.19 branch is free for merging for 0.19.1
198 2019-11-25T09:17:00  *** nijynot_ has joined #bitcoin-core-dev
199 2019-11-25T09:17:04  *** chrippa has joined #bitcoin-core-dev
200 2019-11-25T09:18:32  *** nosss2 has quit IRC
201 2019-11-25T09:18:43  <sipsorcery> for the appveyor job it would be worthwhile to force an update of the vcpkg installed dependencies
202 2019-11-25T09:18:56  <hebasto> appveyor complains about error in httpserver.cpp and warning "boost-system's buildsystem uses very long paths and may fail on your system." They seem related to each other/
203 2019-11-25T09:19:29  <sipsorcery> i don't get the 'evthread_use_windows_threads' compilation error on my own job and the only difference should be the vcpkg state
204 2019-11-25T09:20:03  <sipsorcery> hebasto: that warning has been around for a while and is harmless
205 2019-11-25T09:20:08  <wumpus> hebasto: the boost build warning is standard
206 2019-11-25T09:20:10  <wumpus> right
207 2019-11-25T09:21:57  <sipsorcery> the appveyor job's cache can be triggered to purge by touching the build_msvc\vcpkg-pacakges.txt file, or
208 2019-11-25T09:22:46  <sipsorcery> manually by sending a http request of the form curl -H "Authorization: Bearer $APPVEYOR_TOKEN" -X DELETE https://ci.appveyor.com/api/projects/sipsorcery/bitcoin-72c17/buildcache
209 2019-11-25T09:23:35  <wumpus> ah, something that doesn't involve changing a file in the repository seems preferable
210 2019-11-25T09:23:38  <sipsorcery> the latter method is preferable but it requires access to the APPVEYOR_TOKEN
211 2019-11-25T09:24:02  <wumpus> does not need a specific person's token?
212 2019-11-25T09:24:09  <wumpus> or does it?
213 2019-11-25T09:24:14  *** nosss2 has joined #bitcoin-core-dev
214 2019-11-25T09:24:29  <wumpus> I see mine under "API key"
215 2019-11-25T09:24:30  <sipsorcery> the token needs to be of the account that owns the job
216 2019-11-25T09:25:16  <meshcollider> which would be DrahtBot I believe
217 2019-11-25T09:26:07  <wumpus> right, I get {"message":"Account not found or access denied."}
218 2019-11-25T09:27:06  <wumpus> if it's DrahtBot, let's wait for MarcoFalke
219 2019-11-25T09:27:27  *** jungly has joined #bitcoin-core-dev
220 2019-11-25T09:27:57  *** murrayn has quit IRC
221 2019-11-25T09:28:26  *** nosss2 has quit IRC
222 2019-11-25T09:30:41  <sipsorcery> has anyone use the new github actions for bitcoin core builds?
223 2019-11-25T09:30:54  <sipsorcery> seems they have linux, windows and mac images
224 2019-11-25T09:31:45  <wumpus> I haven't used github actions, as we have our own build process, it doesn't seem particularly useful for us so haven't paid much attention to it
225 2019-11-25T09:31:46  *** cryptoIndio has quit IRC
226 2019-11-25T09:33:24  <sipsorcery> the appveyor build takes over 2x the time it takes on my average machine
227 2019-11-25T09:33:45  <sipsorcery> was wondering if github actions would be faster
228 2019-11-25T09:34:02  <sipsorcery> I'll have a play around
229 2019-11-25T09:35:28  *** nik-j has joined #bitcoin-core-dev
230 2019-11-25T09:36:35  *** marcoagner has quit IRC
231 2019-11-25T09:36:42  <wumpus> not very different from travis :)
232 2019-11-25T09:39:42  *** nik-j has quit IRC
233 2019-11-25T09:45:22  <hebasto> meshcollider: wumpus: I've restored removed header from 17518 - it doesn't help https://ci.appveyor.com/project/hebasto/bitcoin/builds/29095602
234 2019-11-25T09:45:58  <meshcollider> hebasto: oh thanks! Good to know
235 2019-11-25T09:46:56  <wumpus> I managed to get Drahtbot's token (there's a dropdown in the API key page), but unfortunatly, still get the same "Account not found or access denied." error with that curl command
236 2019-11-25T09:48:00  <sipsorcery> you also need to change the owner and project ID to match
237 2019-11-25T09:48:28  <sipsorcery> this bit in the url is specific to my account and job "sipsorcery/bitcoin-72c17"
238 2019-11-25T09:50:19  *** timothy has joined #bitcoin-core-dev
239 2019-11-25T09:51:35  *** nik-j has joined #bitcoin-core-dev
240 2019-11-25T09:52:34  <wumpus> ok, tried it with https://ci.appveyor.com/api/projects/DrahtBot/bitcoin/buildcache, which at least gives me a different permission denied error :-)
241 2019-11-25T09:54:16  <sipsorcery> it won't be DrahtBot/bitcoin
242 2019-11-25T09:54:24  <sipsorcery> it will be DrahtBot/bitcoin-xxxx
243 2019-11-25T09:54:53  *** rex4539 has quit IRC
244 2019-11-25T09:55:01  <sipsorcery> if you open the appveyor project and go to the settings the ID is in the "Project URL slug" field
245 2019-11-25T09:55:37  *** nik-j has quit IRC
246 2019-11-25T09:56:37  *** nosss2 has joined #bitcoin-core-dev
247 2019-11-25T09:58:03  *** promag has joined #bitcoin-core-dev
248 2019-11-25T10:00:57  *** nosss2 has quit IRC
249 2019-11-25T10:02:15  *** nik-j has joined #bitcoin-core-dev
250 2019-11-25T10:05:25  <hebasto> if skip AppVeyor's error in httpserver.cpp it fires another one: torcontrol.cpp(745,5): error C3861: 'evthread_use_windows_threads': identifier not found
251 2019-11-25T10:05:35  *** promag_ has joined #bitcoin-core-dev
252 2019-11-25T10:06:08  *** promag has quit IRC
253 2019-11-25T10:06:13  <hebasto> Interesting that event2/thread.h is included...
254 2019-11-25T10:06:17  *** nik-j has quit IRC
255 2019-11-25T10:09:55  *** nosss2 has joined #bitcoin-core-dev
256 2019-11-25T10:11:20  <sipsorcery> looks like the vcpkg libevent port did change something to do with threads on 25th of Sep, https://bit.ly/2XK3biN
257 2019-11-25T10:11:21  <hebasto> So, AppVeyor build uses Libevent that built without support for evthread_use_windows_threads(); submitting an issue.
258 2019-11-25T10:13:13  <sipsorcery> my appveyor job does build bitcoin core successfully on master and the only difference will be my job has a more recent update of vcpkg
259 2019-11-25T10:13:16  <hebasto> sipsorcery: see #17568
260 2019-11-25T10:13:18  <gribble> https://github.com/bitcoin/bitcoin/issues/17568 | wallet: fix when sufficient preset inputs and subtractFeeFromOutputs by achow101 · Pull Request #17568 · bitcoin/bitcoin · GitHub
261 2019-11-25T10:13:41  <hebasto> Sorry: #17586
262 2019-11-25T10:13:44  <gribble> https://github.com/bitcoin/bitcoin/issues/17586 | build: AppVeyor build uses Libevent that built without support for evthread_use_windows_threads() · Issue #17586 · bitcoin/bitcoin · GitHub
263 2019-11-25T10:14:18  *** promag_ has quit IRC
264 2019-11-25T10:14:26  *** nosss2 has quit IRC
265 2019-11-25T10:17:28  *** goatpig has joined #bitcoin-core-dev
266 2019-11-25T10:18:37  *** nik-j has joined #bitcoin-core-dev
267 2019-11-25T10:21:57  *** nosss2 has joined #bitcoin-core-dev
268 2019-11-25T10:23:06  <sipsorcery> hebasto: thx, i'll try and reproduce
269 2019-11-25T10:23:23  *** nik-j has quit IRC
270 2019-11-25T10:26:22  *** nosss2 has quit IRC
271 2019-11-25T10:29:25  *** promag has joined #bitcoin-core-dev
272 2019-11-25T10:29:48  *** nosss2 has joined #bitcoin-core-dev
273 2019-11-25T10:31:17  *** promag has quit IRC
274 2019-11-25T10:31:35  *** nik-j has joined #bitcoin-core-dev
275 2019-11-25T10:34:17  *** nosss2 has quit IRC
276 2019-11-25T10:35:03  *** nosss2 has joined #bitcoin-core-dev
277 2019-11-25T10:36:29  *** nik-j has quit IRC
278 2019-11-25T10:39:17  *** nosss2 has quit IRC
279 2019-11-25T10:39:26  *** bitcoin-git has joined #bitcoin-core-dev
280 2019-11-25T10:39:26  <bitcoin-git> [bitcoin] Sjors opened pull request #17587: gui: show watch-only balance in send screen  (master...2019/11/send_balance) https://github.com/bitcoin/bitcoin/pull/17587
281 2019-11-25T10:39:27  *** bitcoin-git has left #bitcoin-core-dev
282 2019-11-25T10:43:53  *** Bullit has quit IRC
283 2019-11-25T10:44:25  *** Bullit has joined #bitcoin-core-dev
284 2019-11-25T10:45:21  *** misterwhatever has joined #bitcoin-core-dev
285 2019-11-25T10:45:57  *** rabidus has quit IRC
286 2019-11-25T10:46:42  *** nik-j has joined #bitcoin-core-dev
287 2019-11-25T10:46:58  *** chrippa has quit IRC
288 2019-11-25T10:47:22  *** nosss2 has joined #bitcoin-core-dev
289 2019-11-25T10:47:33  *** promag has joined #bitcoin-core-dev
290 2019-11-25T10:48:05  *** rabidus has joined #bitcoin-core-dev
291 2019-11-25T10:49:47  *** AaronvanW has joined #bitcoin-core-dev
292 2019-11-25T10:51:20  *** nik-j has quit IRC
293 2019-11-25T10:51:59  *** jungly has quit IRC
294 2019-11-25T10:54:09  *** nosss2 has quit IRC
295 2019-11-25T10:57:16  *** misterwhatever has quit IRC
296 2019-11-25T10:58:26  *** rabidus has quit IRC
297 2019-11-25T10:58:50  *** nosss2 has joined #bitcoin-core-dev
298 2019-11-25T11:00:37  *** rabidus has joined #bitcoin-core-dev
299 2019-11-25T11:02:30  *** nik-j has joined #bitcoin-core-dev
300 2019-11-25T11:02:35  *** jcorgan has quit IRC
301 2019-11-25T11:02:57  *** nosss2 has quit IRC
302 2019-11-25T11:04:02  *** rex4539 has joined #bitcoin-core-dev
303 2019-11-25T11:06:14  *** nosss2 has joined #bitcoin-core-dev
304 2019-11-25T11:06:43  *** nik-j has quit IRC
305 2019-11-25T11:11:17  *** nosss2 has quit IRC
306 2019-11-25T11:12:23  *** rabidus has quit IRC
307 2019-11-25T11:12:24  *** subdriven1 has joined #bitcoin-core-dev
308 2019-11-25T11:14:12  *** rabidus has joined #bitcoin-core-dev
309 2019-11-25T11:15:27  *** nosss2 has joined #bitcoin-core-dev
310 2019-11-25T11:15:56  *** jungly has joined #bitcoin-core-dev
311 2019-11-25T11:19:59  *** nosss2 has quit IRC
312 2019-11-25T11:20:12  *** murray has joined #bitcoin-core-dev
313 2019-11-25T11:20:24  *** nik-j has joined #bitcoin-core-dev
314 2019-11-25T11:20:36  *** murray is now known as Guest65112
315 2019-11-25T11:20:42  *** Guest65112 has left #bitcoin-core-dev
316 2019-11-25T11:21:37  *** murrayn has joined #bitcoin-core-dev
317 2019-11-25T11:22:06  *** nosss2 has joined #bitcoin-core-dev
318 2019-11-25T11:24:53  *** nik-j has quit IRC
319 2019-11-25T11:27:14  *** nosss2 has quit IRC
320 2019-11-25T11:31:20  *** nosss2 has joined #bitcoin-core-dev
321 2019-11-25T11:35:12  *** MarcoFal- has joined #bitcoin-core-dev
322 2019-11-25T11:35:45  *** nosss2 has quit IRC
323 2019-11-25T11:38:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
324 2019-11-25T11:39:48  *** MarcoFalke has quit IRC
325 2019-11-25T11:39:48  *** baldur has quit IRC
326 2019-11-25T11:42:19  *** Victorsueca has joined #bitcoin-core-dev
327 2019-11-25T11:42:23  *** nosss2 has joined #bitcoin-core-dev
328 2019-11-25T11:43:54  *** TheRec_ has joined #bitcoin-core-dev
329 2019-11-25T11:44:49  *** baldur has joined #bitcoin-core-dev
330 2019-11-25T11:45:35  *** jungly_ has joined #bitcoin-core-dev
331 2019-11-25T11:45:36  *** cfields_ has joined #bitcoin-core-dev
332 2019-11-25T11:45:45  *** hex17or has joined #bitcoin-core-dev
333 2019-11-25T11:48:32  *** nullptr| has quit IRC
334 2019-11-25T11:48:32  *** TheRec has quit IRC
335 2019-11-25T11:48:33  *** jungly has quit IRC
336 2019-11-25T11:48:33  *** Victor_sueca has quit IRC
337 2019-11-25T11:48:33  *** cfields has quit IRC
338 2019-11-25T11:48:33  *** hex17or_ has quit IRC
339 2019-11-25T11:48:33  *** Murch has quit IRC
340 2019-11-25T11:48:33  *** Zenton has quit IRC
341 2019-11-25T11:48:33  *** jnewbery has quit IRC
342 2019-11-25T11:49:06  *** nosss2 has quit IRC
343 2019-11-25T11:49:48  *** nullptr| has joined #bitcoin-core-dev
344 2019-11-25T11:49:49  *** misterwhatever has joined #bitcoin-core-dev
345 2019-11-25T11:50:58  *** jnewbery has joined #bitcoin-core-dev
346 2019-11-25T11:56:46  *** promag has quit IRC
347 2019-11-25T11:59:53  *** misterwhatever has quit IRC
348 2019-11-25T12:00:02  *** subdriven1 has quit IRC
349 2019-11-25T12:00:04  *** nosss2 has joined #bitcoin-core-dev
350 2019-11-25T12:02:50  *** promag has joined #bitcoin-core-dev
351 2019-11-25T12:04:37  *** nosss2 has quit IRC
352 2019-11-25T12:04:51  <wumpus> provoostenator: btw, for the 0.19.0.1 release I've added your torrent tracker to the trackers
353 2019-11-25T12:06:38  *** vasil has joined #bitcoin-core-dev
354 2019-11-25T12:09:28  *** vasil is now known as vasild
355 2019-11-25T12:12:10  *** nosss2 has joined #bitcoin-core-dev
356 2019-11-25T12:12:30  *** vasild has quit IRC
357 2019-11-25T12:13:50  *** Murch has joined #bitcoin-core-dev
358 2019-11-25T12:15:11  *** kpyke has joined #bitcoin-core-dev
359 2019-11-25T12:16:24  *** misterwhatever has joined #bitcoin-core-dev
360 2019-11-25T12:16:28  *** vasild has joined #bitcoin-core-dev
361 2019-11-25T12:16:29  *** nosss2 has quit IRC
362 2019-11-25T12:18:24  *** AaronvanW has quit IRC
363 2019-11-25T12:19:33  *** nosss2 has joined #bitcoin-core-dev
364 2019-11-25T12:24:16  *** nosss2 has quit IRC
365 2019-11-25T12:27:34  *** misterwhatever has left #bitcoin-core-dev
366 2019-11-25T12:32:46  *** AaronvanW has joined #bitcoin-core-dev
367 2019-11-25T12:33:31  *** nosss2 has joined #bitcoin-core-dev
368 2019-11-25T12:35:12  *** Emcy_ has quit IRC
369 2019-11-25T12:37:28  *** nijynot_ has quit IRC
370 2019-11-25T12:37:46  *** nijynot has joined #bitcoin-core-dev
371 2019-11-25T12:37:48  *** nosss2 has quit IRC
372 2019-11-25T12:40:42  <vasild> jkczyz: What do you think of https://github.com/bitcoin/bitcoin/pull/17577?
373 2019-11-25T12:42:18  <wumpus> sipsorcery: from what I understand from the change in https://github.com/microsoft/vcpkg/pull/8349, "thread" needs to be specified as an explicit feature since that change, e.g. libevent[thread]
374 2019-11-25T12:43:45  <wumpus> I'm somewhat unsure why anyone in almost-2020 would want to default to a non-thread build, but okay, at least it's an explanation
375 2019-11-25T12:45:04  *** nosss2 has joined #bitcoin-core-dev
376 2019-11-25T12:46:11  <sipa> wumpus: perhaps there is a significant performance difference?
377 2019-11-25T12:47:38  *** promag has quit IRC
378 2019-11-25T12:48:25  <sipsorcery> wumpus: ah I see now. I somehow missed "feature packages" being added to vcpkg. I'll test the build again swapping libevent to libevent[thread].
379 2019-11-25T12:48:40  *** AaronvanW has quit IRC
380 2019-11-25T12:49:04  *** Emcy has joined #bitcoin-core-dev
381 2019-11-25T12:49:43  <wumpus> sipa: the threading implementation is pluggable, I don't think there's much overhead on a threading-built libevent with threading not initialized versus one built without threading-- anyhow I definitely hope linux distributions won't do this...
382 2019-11-25T12:50:07  <sipsorcery> the vcpkg PR that disabled threads for libevent didn't give an explanation. I've put a whinge in the PR comments to try and get one.
383 2019-11-25T12:50:45  *** promag has joined #bitcoin-core-dev
384 2019-11-25T12:51:49  *** Chris_Stewart_5 has quit IRC
385 2019-11-25T12:51:56  *** nosss2 has quit IRC
386 2019-11-25T12:53:12  <wumpus> I'm really happy that this got caught on the missing function instead of silently going to thread-unsafe
387 2019-11-25T12:53:23  *** Zenton has joined #bitcoin-core-dev
388 2019-11-25T12:54:39  <wumpus> I remember we had an issue in the beginning (2011? 2012?) where for some reason, bitcoin was linked against a single-threaded standard library on windows and this wasn't caught as a compile time issue, resulting in some really ugly unpredictable crashes
389 2019-11-25T12:54:57  *** promag has quit IRC
390 2019-11-25T12:55:31  *** promag has joined #bitcoin-core-dev
391 2019-11-25T12:56:53  *** nosss2 has joined #bitcoin-core-dev
392 2019-11-25T12:57:14  *** murrayn has quit IRC
393 2019-11-25T12:57:38  *** murray has joined #bitcoin-core-dev
394 2019-11-25T12:58:01  *** murray is now known as Guest53584
395 2019-11-25T12:58:25  <wumpus> which reminds me I recently stumbled on a mechanism called ".gnu.build.attributes" which fedora uses, it allows auditing that an entire binary (and its dependencies) have been compiled with certain build settings and hardening flags, by storing these per address region
396 2019-11-25T12:58:42  <wumpus> this might be something useful for us in the future
397 2019-11-25T13:01:08  *** nosss2 has quit IRC
398 2019-11-25T13:01:38  *** bitcoin-git has joined #bitcoin-core-dev
399 2019-11-25T13:01:38  <bitcoin-git> [bitcoin] muzafa-popo opened pull request #17590: reade (master...master) https://github.com/bitcoin/bitcoin/pull/17590
400 2019-11-25T13:01:39  *** bitcoin-git has left #bitcoin-core-dev
401 2019-11-25T13:01:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
402 2019-11-25T13:02:11  <wumpus> fanquake: that was fast!
403 2019-11-25T13:02:13  *** bitcoin-git has joined #bitcoin-core-dev
404 2019-11-25T13:02:13  <bitcoin-git> [bitcoin] fanquake closed pull request #17590: reade (master...master) https://github.com/bitcoin/bitcoin/pull/17590
405 2019-11-25T13:02:15  *** bitcoin-git has left #bitcoin-core-dev
406 2019-11-25T13:02:32  *** promag has quit IRC
407 2019-11-25T13:03:20  <sipa> "fanquake, faster than his shadow bitcoin-git"
408 2019-11-25T13:03:28  <wumpus> hehehe
409 2019-11-25T13:07:56  *** nosss2 has joined #bitcoin-core-dev
410 2019-11-25T13:09:03  *** bitcoin-git has joined #bitcoin-core-dev
411 2019-11-25T13:09:03  <bitcoin-git> [bitcoin] elichai opened pull request #17591: Testing bitcoin in a Big Endian platform - s390x (master...2019-11-s390x) https://github.com/bitcoin/bitcoin/pull/17591
412 2019-11-25T13:09:04  *** bitcoin-git has left #bitcoin-core-dev
413 2019-11-25T13:11:04  *** daniel has joined #bitcoin-core-dev
414 2019-11-25T13:11:46  *** daniel is now known as Guest54499
415 2019-11-25T13:11:47  *** nosss2 has quit IRC
416 2019-11-25T13:13:24  *** Guyver2 has quit IRC
417 2019-11-25T13:15:13  *** davterra has joined #bitcoin-core-dev
418 2019-11-25T13:20:01  *** deadlysin has quit IRC
419 2019-11-25T13:21:37  *** tryphe has quit IRC
420 2019-11-25T13:21:45  *** nik-j has joined #bitcoin-core-dev
421 2019-11-25T13:22:25  *** nosss2 has joined #bitcoin-core-dev
422 2019-11-25T13:26:57  *** nosss2 has quit IRC
423 2019-11-25T13:28:08  *** bitcoin-git has joined #bitcoin-core-dev
424 2019-11-25T13:28:08  <bitcoin-git> [bitcoin] sipsorcery opened pull request #17592: Appveyor install libevent[thread] vcpkg (master...vcpkg_libevent_thread) https://github.com/bitcoin/bitcoin/pull/17592
425 2019-11-25T13:28:10  *** bitcoin-git has left #bitcoin-core-dev
426 2019-11-25T13:35:19  *** bitcoin-git has joined #bitcoin-core-dev
427 2019-11-25T13:35:19  <bitcoin-git> [bitcoin] mzumsande opened pull request #17593: test: move more utility functions into test utility library (master...201911_test_moveutil) https://github.com/bitcoin/bitcoin/pull/17593
428 2019-11-25T13:35:20  *** bitcoin-git has left #bitcoin-core-dev
429 2019-11-25T13:35:51  *** AaronvanW has joined #bitcoin-core-dev
430 2019-11-25T13:40:20  *** harrigan has quit IRC
431 2019-11-25T13:40:38  *** nik-j has quit IRC
432 2019-11-25T13:53:07  *** Chris_Stewart_5 has quit IRC
433 2019-11-25T13:57:29  *** Heisenberg_Hunte has joined #bitcoin-core-dev
434 2019-11-25T13:58:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
435 2019-11-25T13:59:53  *** Heisenberg_Hunte has quit IRC
436 2019-11-25T14:00:06  *** Heisenberg_Hunte has joined #bitcoin-core-dev
437 2019-11-25T14:10:05  *** promag has joined #bitcoin-core-dev
438 2019-11-25T14:12:31  *** heisenberg-m80 has joined #bitcoin-core-dev
439 2019-11-25T14:13:03  <provoostenator> wumpus: the 0.17.2 seems stuck in limbo?
440 2019-11-25T14:13:27  <wumpus> provoostenator: yes
441 2019-11-25T14:13:36  <provoostenator> What needs to happen?
442 2019-11-25T14:14:26  *** promag has quit IRC
443 2019-11-25T14:14:26  <provoostenator> By the way, I whitelisted the 0.19.0.1  on my tracker (thanks for adding that) and it now has the most seeders of all of the trackers :-)
444 2019-11-25T14:14:33  <provoostenator> *torrent
445 2019-11-25T14:15:01  <wumpus> I don't know, I think 0.17 became EOL while 0.19 was released
446 2019-11-25T14:15:51  *** nijynot has quit IRC
447 2019-11-25T14:16:21  <wumpus> is the gitian build done? is it just a matter of uploading binaries for it? might still do it in that case
448 2019-11-25T14:17:09  <provoostenator> It has 6 signed binaries
449 2019-11-25T14:17:51  <provoostenator> So indeed seems like a matter of releasing it. I'll whitelist that torrent as well.
450 2019-11-25T14:18:39  *** cubancorona has quit IRC
451 2019-11-25T14:19:43  <provoostenator> (looks like we don't link to torrents for old releases anywhere though)
452 2019-11-25T14:19:45  *** Heisenberg_Hunte has left #bitcoin-core-dev
453 2019-11-25T14:20:34  *** heisenberg-m80 has quit IRC
454 2019-11-25T14:21:15  <provoostenator> Might be useful to link those from the release page, because such a link is more likely to survice a .org apocalypse than a binary.
455 2019-11-25T14:21:17  <wumpus> oh, I wonder why not
456 2019-11-25T14:22:37  <wumpus> I suppose the magnet link is still in the yml files for people intent on finding it; it's just not exposed. FWIW I'm still seeding the latest release on 0.17 0.18 0.19 branch
457 2019-11-25T14:22:55  <wumpus> well, 0.17 is not the latest at the moment :)
458 2019-11-25T14:25:21  <fanquake> Speaking of older releases. Review beg for #16617.
459 2019-11-25T14:25:24  <gribble> https://github.com/bitcoin/bitcoin/issues/16617 | [0.18.2] Backports by fanquake · Pull Request #16617 · bitcoin/bitcoin · GitHub
460 2019-11-25T14:27:44  *** sipa has quit IRC
461 2019-11-25T14:27:46  <fanquake> Seems this is our second uninitialized var issue in as many weeks: https://github.com/bitcoin/bitcoin/pull/17568#issuecomment-558026462
462 2019-11-25T14:28:00  *** justanotheruser has quit IRC
463 2019-11-25T14:29:04  <wumpus> fanquake: oh noo
464 2019-11-25T14:29:12  *** nijynot has joined #bitcoin-core-dev
465 2019-11-25T14:33:19  <elichai2> I guess it's time for a valgrind run in the CI 😅
466 2019-11-25T14:35:21  *** harrigan has joined #bitcoin-core-dev
467 2019-11-25T14:43:40  *** nik-j has joined #bitcoin-core-dev
468 2019-11-25T14:48:02  <wumpus> yes, IIRC there's a PR for that
469 2019-11-25T14:48:17  *** nik-j has quit IRC
470 2019-11-25T14:48:53  *** nik-j has joined #bitcoin-core-dev
471 2019-11-25T14:53:47  *** nik-j has quit IRC
472 2019-11-25T14:59:22  *** mdunnio has joined #bitcoin-core-dev
473 2019-11-25T15:00:01  *** kpyke has quit IRC
474 2019-11-25T15:11:37  *** Guyver2 has joined #bitcoin-core-dev
475 2019-11-25T15:17:15  *** retroj1 has joined #bitcoin-core-dev
476 2019-11-25T15:18:29  *** nijynot has quit IRC
477 2019-11-25T15:22:46  *** bitcoin-git has joined #bitcoin-core-dev
478 2019-11-25T15:22:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e6f167bfdfc0...89a1f7a250ef
479 2019-11-25T15:22:47  <bitcoin-git> bitcoin/master f13e274 Aaron Clauson: Appveyor install libevent[thread] vcpkg
480 2019-11-25T15:22:48  <bitcoin-git> bitcoin/master 89a1f7a MarcoFalke: Merge #17592: Appveyor install libevent[thread] vcpkg
481 2019-11-25T15:22:50  *** bitcoin-git has left #bitcoin-core-dev
482 2019-11-25T15:23:05  *** bitcoin-git has joined #bitcoin-core-dev
483 2019-11-25T15:23:05  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17592: Appveyor install libevent[thread] vcpkg (master...vcpkg_libevent_thread) https://github.com/bitcoin/bitcoin/pull/17592
484 2019-11-25T15:23:06  *** bitcoin-git has left #bitcoin-core-dev
485 2019-11-25T15:23:42  *** nijynot has joined #bitcoin-core-dev
486 2019-11-25T15:24:15  *** aqquadro has joined #bitcoin-core-dev
487 2019-11-25T15:30:06  *** goatpig has quit IRC
488 2019-11-25T15:35:06  *** aqquadro has quit IRC
489 2019-11-25T15:41:51  <fanquake> thanks wumpus
490 2019-11-25T15:41:55  *** nik-j has joined #bitcoin-core-dev
491 2019-11-25T15:43:30  *** bitcoin-git has joined #bitcoin-core-dev
492 2019-11-25T15:43:30  <bitcoin-git> [bitcoin] laanwj merged pull request #16617: [0.18.2] Backports (0.18...0_18_2_backports) https://github.com/bitcoin/bitcoin/pull/16617
493 2019-11-25T15:43:31  *** bitcoin-git has left #bitcoin-core-dev
494 2019-11-25T15:44:51  *** nijynot has quit IRC
495 2019-11-25T15:45:06  *** rabidus has quit IRC
496 2019-11-25T15:47:04  *** rabidus has joined #bitcoin-core-dev
497 2019-11-25T15:52:15  *** nosss2 has joined #bitcoin-core-dev
498 2019-11-25T15:54:37  *** nik-j has quit IRC
499 2019-11-25T16:14:12  *** nosss2 has quit IRC
500 2019-11-25T16:14:42  *** nosss2 has joined #bitcoin-core-dev
501 2019-11-25T16:18:57  *** nosss2 has quit IRC
502 2019-11-25T16:20:30  *** bitcoin-git has joined #bitcoin-core-dev
503 2019-11-25T16:20:30  <bitcoin-git> [bitcoin] dongcarl opened pull request #17595: guix: Enable building for `x86_64-w64-mingw32` target (master...2019-09-guix-staging-win-mingw-6.0.0) https://github.com/bitcoin/bitcoin/pull/17595
504 2019-11-25T16:20:31  *** bitcoin-git has left #bitcoin-core-dev
505 2019-11-25T16:20:33  *** Talkless has joined #bitcoin-core-dev
506 2019-11-25T16:21:38  *** Talkless has quit IRC
507 2019-11-25T16:22:25  *** Talkless has joined #bitcoin-core-dev
508 2019-11-25T16:30:24  *** nik-j has joined #bitcoin-core-dev
509 2019-11-25T16:36:20  <instagibbs_> BlueMatt, Is there any larger discussion on what is left that #17573 is solving? Or is this a general "more is better" approach
510 2019-11-25T16:36:22  <gribble> https://github.com/bitcoin/bitcoin/issues/17573 | Seed RNG with precision timestamps on receipt of net messages. by TheBlueMatt · Pull Request #17573 · bitcoin/bitcoin · GitHub
511 2019-11-25T16:36:34  <instagibbs_> without derailing that PR which looks reasonable, hence asking here
512 2019-11-25T16:40:44  *** nik-j has quit IRC
513 2019-11-25T16:43:06  <BlueMatt> instagibbs_: the second
514 2019-11-25T16:43:29  <BlueMatt> more is better, especially more *different types* of entropy is better.
515 2019-11-25T16:43:40  <BlueMatt> just performance data is fine, but...
516 2019-11-25T16:45:46  *** jarthur has joined #bitcoin-core-dev
517 2019-11-25T16:47:57  *** sipa has joined #bitcoin-core-dev
518 2019-11-25T16:50:12  <instagibbs_> thanks
519 2019-11-25T16:52:09  *** AaronvanW has quit IRC
520 2019-11-25T16:55:25  *** AaronvanW has joined #bitcoin-core-dev
521 2019-11-25T16:57:29  *** justanotheruser has joined #bitcoin-core-dev
522 2019-11-25T17:10:53  *** sipsorcery has quit IRC
523 2019-11-25T17:23:50  *** rex4539_ has joined #bitcoin-core-dev
524 2019-11-25T17:26:53  *** sipsorcery has joined #bitcoin-core-dev
525 2019-11-25T17:26:57  *** rex4539 has quit IRC
526 2019-11-25T17:33:45  *** b10c1 has joined #bitcoin-core-dev
527 2019-11-25T17:34:00  *** b10c has quit IRC
528 2019-11-25T17:34:00  *** b10c1 is now known as b10c
529 2019-11-25T17:37:15  *** vasild has quit IRC
530 2019-11-25T17:37:21  *** kristapsk_ has quit IRC
531 2019-11-25T17:37:30  *** vasild has joined #bitcoin-core-dev
532 2019-11-25T17:41:06  *** nik-j has joined #bitcoin-core-dev
533 2019-11-25T17:41:42  *** jonatack_ has quit IRC
534 2019-11-25T17:42:00  *** jonatack has joined #bitcoin-core-dev
535 2019-11-25T17:45:41  *** nik-j has quit IRC
536 2019-11-25T17:46:21  *** nijynot has joined #bitcoin-core-dev
537 2019-11-25T17:52:07  *** rex4539 has joined #bitcoin-core-dev
538 2019-11-25T18:00:01  *** retroj1 has quit IRC
539 2019-11-25T18:02:27  *** marcoagner has joined #bitcoin-core-dev
540 2019-11-25T18:04:37  *** alex911_kz has quit IRC
541 2019-11-25T18:05:13  *** morcos has quit IRC
542 2019-11-25T18:05:30  *** morcos has joined #bitcoin-core-dev
543 2019-11-25T18:09:43  *** kristapsk has joined #bitcoin-core-dev
544 2019-11-25T18:10:16  *** dviola has joined #bitcoin-core-dev
545 2019-11-25T18:10:38  <dviola> hi
546 2019-11-25T18:10:58  <dviola> in bitcoin-qt 0.19.0.1 "Current number of transactions" and "Memory usage" stays at "N/A"
547 2019-11-25T18:11:18  <dviola> any ideas?
548 2019-11-25T18:11:24  <fanquake> dviola see #17576
549 2019-11-25T18:11:26  <gribble> https://github.com/bitcoin/bitcoin/issues/17576 | Mempool fields in Debug Windows show "N/A" · Issue #17576 · bitcoin/bitcoin · GitHub
550 2019-11-25T18:11:33  <fanquake> This is a known issue, and will be fixed in 0.19.1
551 2019-11-25T18:11:54  *** b10c1 has joined #bitcoin-core-dev
552 2019-11-25T18:11:54  <dviola> fanquake: thanks
553 2019-11-25T18:12:02  *** b10c has quit IRC
554 2019-11-25T18:12:03  *** b10c1 is now known as b10c
555 2019-11-25T18:15:22  *** justanotheruser has quit IRC
556 2019-11-25T18:17:33  *** SukhE1 has joined #bitcoin-core-dev
557 2019-11-25T18:19:47  <wumpus> dviola: please help testing the rc next time :) this only came to light after the RC phase
558 2019-11-25T18:20:20  <dviola> wumpus: sure thing
559 2019-11-25T18:23:56  *** bitcoin-git has joined #bitcoin-core-dev
560 2019-11-25T18:23:56  <bitcoin-git> [bitcoin] laanwj opened pull request #17596: doc: Change doxygen URL to doxygen.bitcoincore.org (master...2019_11_doxygen_url) https://github.com/bitcoin/bitcoin/pull/17596
561 2019-11-25T18:23:58  *** bitcoin-git has left #bitcoin-core-dev
562 2019-11-25T18:32:44  *** astro has quit IRC
563 2019-11-25T18:34:31  *** astro has joined #bitcoin-core-dev
564 2019-11-25T18:40:03  *** MarcoFal- has quit IRC
565 2019-11-25T18:40:16  <wumpus> provoostenator: any idea how to do a partial redirect like that in nginx?
566 2019-11-25T18:40:29  *** MarcoFalk has joined #bitcoin-core-dev
567 2019-11-25T18:42:45  <provoostenator> wumpus: not much better than Google...
568 2019-11-25T18:43:01  <wumpus> oh I think I already have it
569 2019-11-25T18:44:02  <wumpus> (you do need to clear your cache first because it remembers the old permanent redirect)
570 2019-11-25T18:45:06  *** MarcoFalke has joined #bitcoin-core-dev
571 2019-11-25T18:45:17  *** nijynot has quit IRC
572 2019-11-25T18:46:29  <MarcoFalke> appveyor is green again, btw
573 2019-11-25T18:46:38  <wumpus> great!
574 2019-11-25T18:54:27  <fanquake> MarcoFalke can you add libevent 2.1.11 to the bots depends fallback
575 2019-11-25T18:54:39  <MarcoFalke> sure
576 2019-11-25T18:54:45  <MarcoFalke> How do you find these so quick?
577 2019-11-25T18:55:56  <fanquake> Just remembered that we'd merged a newer libevent recently
578 2019-11-25T19:00:45  *** nijynot has joined #bitcoin-core-dev
579 2019-11-25T19:05:17  *** nijynot has quit IRC
580 2019-11-25T19:06:42  *** rabidus has quit IRC
581 2019-11-25T19:06:50  <provoostenator> Looks like the redirect worked!
582 2019-11-25T19:07:23  <provoostenator> Try googling a class name, e.g. WalletModelTransaction
583 2019-11-25T19:07:35  <wumpus> provoostenator: thanks for checking
584 2019-11-25T19:08:42  *** rabidus has joined #bitcoin-core-dev
585 2019-11-25T19:10:29  *** harrigan has quit IRC
586 2019-11-25T19:10:56  *** harrigan has joined #bitcoin-core-dev
587 2019-11-25T19:11:53  *** emilengler has joined #bitcoin-core-dev
588 2019-11-25T19:13:41  *** rabidus_ has joined #bitcoin-core-dev
589 2019-11-25T19:15:44  *** rabidus has quit IRC
590 2019-11-25T19:17:16  *** andrewtoth_ has joined #bitcoin-core-dev
591 2019-11-25T19:17:23  <fanquake> wumpus sipa think you might be about to block Dianne120 for spamming
592 2019-11-25T19:17:32  *** _andrewtoth_ has quit IRC
593 2019-11-25T19:18:02  *** dddd has joined #bitcoin-core-dev
594 2019-11-25T19:18:03  *** nik-j has joined #bitcoin-core-dev
595 2019-11-25T19:20:51  *** bitcoin-git has joined #bitcoin-core-dev
596 2019-11-25T19:20:52  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/89a1f7a250ef...12230529e330
597 2019-11-25T19:20:52  <bitcoin-git> bitcoin/master 41d7db0 Wladimir J. van der Laan: doc: Change doxygen URL to doxygen.bitcoincore.org
598 2019-11-25T19:20:53  <bitcoin-git> bitcoin/master 1223052 fanquake: Merge #17596: doc: Change doxygen URL to doxygen.bitcoincore.org
599 2019-11-25T19:20:55  *** bitcoin-git has left #bitcoin-core-dev
600 2019-11-25T19:21:11  *** bitcoin-git has joined #bitcoin-core-dev
601 2019-11-25T19:21:11  <bitcoin-git> [bitcoin] fanquake merged pull request #17596: doc: Change doxygen URL to doxygen.bitcoincore.org (master...2019_11_doxygen_url) https://github.com/bitcoin/bitcoin/pull/17596
602 2019-11-25T19:21:21  *** bitcoin-git has left #bitcoin-core-dev
603 2019-11-25T19:23:01  *** bitcoin-git has joined #bitcoin-core-dev
604 2019-11-25T19:23:01  <bitcoin-git> [bitcoin] hebasto opened pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
605 2019-11-25T19:23:02  *** bitcoin-git has left #bitcoin-core-dev
606 2019-11-25T19:23:45  *** nik-j has quit IRC
607 2019-11-25T19:29:29  <wumpus> fanquake: done
608 2019-11-25T19:30:25  *** nik-j has joined #bitcoin-core-dev
609 2019-11-25T19:30:36  *** andrewtoth_ has quit IRC
610 2019-11-25T19:32:15  <hebasto> if AppVeyor is fixed why do I see red crosses? Timeouts or something else?
611 2019-11-25T19:33:34  <wumpus> hebasto: where?
612 2019-11-25T19:34:07  *** bitcoin-git has joined #bitcoin-core-dev
613 2019-11-25T19:34:07  <bitcoin-git> [bitcoin] hebasto closed pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
614 2019-11-25T19:34:09  *** bitcoin-git has left #bitcoin-core-dev
615 2019-11-25T19:34:48  <sipsorcery> 3rd last appveyor build had a genuine compilation error which looks like it was introduced by the PR
616 2019-11-25T19:35:17  <sipsorcery> 2nd last build failed on the a python test, this is a sporadic issue that needs to be tracked down
617 2019-11-25T19:36:01  <hebasto> sipsorcery: I see, thank you for the fix and clarification
618 2019-11-25T19:38:22  <sipsorcery> last build (backports on 0.18 branch) failed for what looks to be missing vcpkg packages
619 2019-11-25T19:38:52  <fanquake> probably a bunch of stuff that needs to be backported to 0.18 for appveyor
620 2019-11-25T19:42:21  *** rabidus_ has quit IRC
621 2019-11-25T19:44:01  *** rh0nj has quit IRC
622 2019-11-25T19:45:07  *** rh0nj has joined #bitcoin-core-dev
623 2019-11-25T19:50:23  *** bitcoin-git has joined #bitcoin-core-dev
624 2019-11-25T19:50:23  <bitcoin-git> [bitcoin] hebasto reopened pull request #17597: qt: Fix height of QR-less ReceiveRequestDialog (master...20191125-height-without-qr) https://github.com/bitcoin/bitcoin/pull/17597
625 2019-11-25T19:50:25  *** bitcoin-git has left #bitcoin-core-dev
626 2019-11-25T19:50:43  *** bitcoin-git has joined #bitcoin-core-dev
627 2019-11-25T19:50:43  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17598: doc: Update release process with latest changes (master...1911-docRelNotes) https://github.com/bitcoin/bitcoin/pull/17598
628 2019-11-25T19:50:44  *** bitcoin-git has left #bitcoin-core-dev
629 2019-11-25T19:54:21  *** andrewtoth_ has joined #bitcoin-core-dev
630 2019-11-25T19:58:38  *** Talkless has quit IRC
631 2019-11-25T20:00:18  *** bitcoin-git has joined #bitcoin-core-dev
632 2019-11-25T20:00:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/12230529e330...2c1c43754b7a
633 2019-11-25T20:00:19  <bitcoin-git> bitcoin/master 2fa65e0 Elichai Turkel: Add ci script to install on s390x
634 2019-11-25T20:00:20  <bitcoin-git> bitcoin/master da1f153 Elichai Turkel: Add s390x tests to travis
635 2019-11-25T20:00:20  <bitcoin-git> bitcoin/master 2c1c437 MarcoFalke: Merge #17591: ci: Add big endian platform - s390x
636 2019-11-25T20:00:22  *** bitcoin-git has left #bitcoin-core-dev
637 2019-11-25T20:00:38  *** bitcoin-git has joined #bitcoin-core-dev
638 2019-11-25T20:00:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #17591: ci: Add big endian platform - s390x (master...2019-11-s390x) https://github.com/bitcoin/bitcoin/pull/17591
639 2019-11-25T20:00:39  *** bitcoin-git has left #bitcoin-core-dev
640 2019-11-25T20:01:58  *** jonatack_ has joined #bitcoin-core-dev
641 2019-11-25T20:05:02  *** bitcoin-git has joined #bitcoin-core-dev
642 2019-11-25T20:05:02  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #17599: ci: Run functional tests on s390x (master...1911-ciS390x) https://github.com/bitcoin/bitcoin/pull/17599
643 2019-11-25T20:05:03  *** bitcoin-git has left #bitcoin-core-dev
644 2019-11-25T20:05:08  *** jonatack has quit IRC
645 2019-11-25T20:13:04  *** misterwhatever has joined #bitcoin-core-dev
646 2019-11-25T20:27:10  *** promag has joined #bitcoin-core-dev
647 2019-11-25T20:29:35  <fanquake> So the new hardware has already turned up a bug in the functional tests?
648 2019-11-25T20:29:48  <sipa> fanquake: it's a bug in the tests, yes
649 2019-11-25T20:30:45  <sipa> (python code interpreting LE data using struct unpack, marking the data as native)
650 2019-11-25T20:30:51  *** bitcoin-git has joined #bitcoin-core-dev
651 2019-11-25T20:30:51  <bitcoin-git> [bitcoin] hebasto opened pull request #17600: qt: Remove connection for unused accepted() signal in ReceiveRequestDialog (master...20191125-unused-connection) https://github.com/bitcoin/bitcoin/pull/17600
652 2019-11-25T20:30:52  *** bitcoin-git has left #bitcoin-core-dev
653 2019-11-25T20:35:38  *** promag has quit IRC
654 2019-11-25T20:37:31  *** mattcruzz has joined #bitcoin-core-dev
655 2019-11-25T20:37:51  *** bitcoin-git has joined #bitcoin-core-dev
656 2019-11-25T20:37:51  <bitcoin-git> [bitcoin] jnewbery opened pull request #17601: Validation: Move CheckBlock() mutation guard to AcceptBlock() (master...2019-11-checkblock-in-acceptblock) https://github.com/bitcoin/bitcoin/pull/17601
657 2019-11-25T20:37:52  *** bitcoin-git has left #bitcoin-core-dev
658 2019-11-25T20:38:21  *** mattcruzz has left #bitcoin-core-dev
659 2019-11-25T20:46:47  *** belcher has quit IRC
660 2019-11-25T20:48:07  *** tripleslash has quit IRC
661 2019-11-25T20:56:13  *** mattcruzz has joined #bitcoin-core-dev
662 2019-11-25T20:56:58  *** bitcoin-git has joined #bitcoin-core-dev
663 2019-11-25T20:56:58  <bitcoin-git> [bitcoin] dongcarl opened pull request #17602: net: Lower # of IPs learned from a DNS seed (master...2019-11-lower-nMaxIPs) https://github.com/bitcoin/bitcoin/pull/17602
664 2019-11-25T20:56:59  *** bitcoin-git has left #bitcoin-core-dev
665 2019-11-25T20:57:27  *** emilengler has quit IRC
666 2019-11-25T20:58:09  *** mattcruzz has left #bitcoin-core-dev
667 2019-11-25T21:00:01  *** SukhE1 has quit IRC
668 2019-11-25T21:00:57  *** b10c has quit IRC
669 2019-11-25T21:04:34  *** Yakitorifoodie has left #bitcoin-core-dev
670 2019-11-25T21:11:53  *** justanotheruser has joined #bitcoin-core-dev
671 2019-11-25T21:17:29  *** AIM has joined #bitcoin-core-dev
672 2019-11-25T21:26:13  *** dddd has quit IRC
673 2019-11-25T21:36:26  *** lightlike has joined #bitcoin-core-dev
674 2019-11-25T21:37:04  *** vasild_ has joined #bitcoin-core-dev
675 2019-11-25T21:40:18  *** commavir has quit IRC
676 2019-11-25T21:40:48  *** vasild has quit IRC
677 2019-11-25T21:47:21  *** Chris_Stewart_5 has quit IRC
678 2019-11-25T21:47:44  *** commavir has joined #bitcoin-core-dev
679 2019-11-25T22:08:22  *** nosss2 has joined #bitcoin-core-dev
680 2019-11-25T22:11:47  *** promag has joined #bitcoin-core-dev
681 2019-11-25T22:14:51  *** Guyver2 has quit IRC
682 2019-11-25T22:15:43  *** diogosergio has joined #bitcoin-core-dev
683 2019-11-25T22:17:05  *** promag has quit IRC
684 2019-11-25T22:17:49  *** promag has joined #bitcoin-core-dev
685 2019-11-25T22:22:47  *** SiAnDoG has quit IRC
686 2019-11-25T22:23:13  *** SiAnDoG has joined #bitcoin-core-dev
687 2019-11-25T22:31:00  *** benthecarman has joined #bitcoin-core-dev
688 2019-11-25T22:33:48  *** benthecarman has joined #bitcoin-core-dev
689 2019-11-25T22:36:23  *** diogosergio has quit IRC
690 2019-11-25T22:36:53  *** bitcoin-git has joined #bitcoin-core-dev
691 2019-11-25T22:36:53  <bitcoin-git> [bitcoin] fanquake opened pull request #17604: doc: correct ScheduleBatchPriority return value documentation (master...fix_ScheduleBatchPriority_comment) https://github.com/bitcoin/bitcoin/pull/17604
692 2019-11-25T22:36:55  *** bitcoin-git has left #bitcoin-core-dev
693 2019-11-25T23:04:55  *** jarthur has quit IRC
694 2019-11-25T23:06:08  *** diogosergio has joined #bitcoin-core-dev
695 2019-11-25T23:17:24  *** andrewtoth_ has quit IRC
696 2019-11-25T23:21:16  *** mdunnio has quit IRC
697 2019-11-25T23:22:32  *** jb55 has quit IRC
698 2019-11-25T23:23:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
699 2019-11-25T23:26:35  <dviola> the git tags in the bitcoin repo and the releases at bitcoincore.org are the same thing, right?
700 2019-11-25T23:27:02  *** waxwing has quit IRC
701 2019-11-25T23:27:34  *** waxwing has joined #bitcoin-core-dev
702 2019-11-25T23:27:43  <dviola> I'm currently using the release tarballs but I might switch to compiling from the repo, this way I can test RCs too
703 2019-11-25T23:29:15  *** waxwing has quit IRC
704 2019-11-25T23:29:15  *** waxwing has joined #bitcoin-core-dev
705 2019-11-25T23:34:39  *** captjakk has joined #bitcoin-core-dev
706 2019-11-25T23:36:04  *** SiAnDoG has quit IRC
707 2019-11-25T23:37:31  *** lightlike has quit IRC
708 2019-11-25T23:46:15  *** belcher has joined #bitcoin-core-dev
709 2019-11-25T23:46:39  *** jb55 has joined #bitcoin-core-dev
710 2019-11-25T23:48:27  *** sipsorcery has quit IRC
711 2019-11-25T23:48:35  *** promag has quit IRC
712 2019-11-25T23:51:06  <dviola> are rc tarballs also signed?
713 2019-11-25T23:51:48  <achow101> dviola: yes, they are the same. rcs go through the same release process as the final releases so they are signed too
714 2019-11-25T23:53:12  <dviola> I see, thanks
715 2019-11-25T23:54:02  <dviola> I'll keep using the tarballs but I might switch to using git after a while
716 2019-11-25T23:55:26  *** nik-j has quit IRC
717 2019-11-25T23:56:16  *** nik-j has joined #bitcoin-core-dev
718 2019-11-25T23:58:15  <luke-jr> dviola: no tarballs are signed..
719 2019-11-25T23:58:30  <luke-jr> well, except by gitian in separate files
720 2019-11-25T23:58:44  <luke-jr> (ie, git-made tarballs are not)
721 2019-11-25T23:59:53  <dviola> luke-jr: I was talking about the verification process described here: https://bitcoincore.org/en/download/
722 2019-11-25T23:59:59  <dviola> gpg --verify, etc