12020-02-25T00:00:02 *** TheCavalry has quit IRC
22020-02-25T00:00:07 *** MasterdonX has quit IRC
32020-02-25T00:00:51 *** MasterdonX has joined #bitcoin-core-dev
42020-02-25T00:12:15 *** moth has joined #bitcoin-core-dev
52020-02-25T00:19:08 *** justanotheruser has quit IRC
62020-02-25T00:20:58 *** bitcoin-git has joined #bitcoin-core-dev
72020-02-25T00:20:58 <bitcoin-git> [bitcoin] achow101 opened pull request #18204: descriptors: improve descriptor cache and cache xpubs (master...desc-xpub-cache) https://github.com/bitcoin/bitcoin/pull/18204
82020-02-25T00:20:59 *** bitcoin-git has left #bitcoin-core-dev
92020-02-25T00:26:06 *** marcoagner has quit IRC
102020-02-25T00:39:43 *** promag has quit IRC
112020-02-25T00:43:27 *** promag has joined #bitcoin-core-dev
122020-02-25T00:48:17 *** promag has quit IRC
132020-02-25T01:04:18 *** promag has joined #bitcoin-core-dev
142020-02-25T01:08:59 *** promag has quit IRC
152020-02-25T01:19:54 *** learnday20 has joined #bitcoin-core-dev
162020-02-25T01:21:28 *** jb55 has quit IRC
172020-02-25T01:22:53 *** mol has joined #bitcoin-core-dev
182020-02-25T01:25:25 *** molly has quit IRC
192020-02-25T01:29:02 *** jb55 has joined #bitcoin-core-dev
202020-02-25T02:06:29 *** justanotheruser has joined #bitcoin-core-dev
212020-02-25T02:07:11 *** bitcoin-git has joined #bitcoin-core-dev
222020-02-25T02:07:11 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/225aa5d6d519...a674e89d2771
232020-02-25T02:07:11 <bitcoin-git> bitcoin/master 12a2f37 practicalswift: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t ...
242020-02-25T02:07:12 <bitcoin-git> bitcoin/master a674e89 fanquake: Merge #18162: util: Avoid potential uninitialized read in FormatISO8601Dat...
252020-02-25T02:07:13 *** bitcoin-git has left #bitcoin-core-dev
262020-02-25T02:07:26 *** bitcoin-git has joined #bitcoin-core-dev
272020-02-25T02:07:26 <bitcoin-git> [bitcoin] fanquake merged pull request #18162: util: Avoid potential uninitialized read in FormatISO8601DateTime(int64_t) by checking gmtime_s/gmtime_r return value (master...FormatISO8601DateTime-unitialized-read) https://github.com/bitcoin/bitcoin/pull/18162
282020-02-25T02:07:31 *** bitcoin-git has left #bitcoin-core-dev
292020-02-25T02:09:54 *** bitcoin-git has joined #bitcoin-core-dev
302020-02-25T02:09:54 <bitcoin-git> [bitcoin] fanquake closed pull request #16523: Add removemempoolentry RPC to evict transactions from the mempool (master...removemempoolentry) https://github.com/bitcoin/bitcoin/pull/16523
312020-02-25T02:09:55 *** bitcoin-git has left #bitcoin-core-dev
322020-02-25T02:13:29 *** bitcoin-git has joined #bitcoin-core-dev
332020-02-25T02:13:29 <bitcoin-git> [bitcoin] fanquake closed pull request #15873: Rpc removemempoolentry (master...rpc-removemempoolentry) https://github.com/bitcoin/bitcoin/pull/15873
342020-02-25T02:13:30 *** bitcoin-git has left #bitcoin-core-dev
352020-02-25T02:15:25 *** bitcoin-git has joined #bitcoin-core-dev
362020-02-25T02:15:25 <bitcoin-git> [bitcoin] fanquake closed pull request #16486: [consensus] skip bip30 checks when assumevalid is set for the block (master...2019-07-29-fassumevalid-bip34) https://github.com/bitcoin/bitcoin/pull/16486
372020-02-25T02:15:26 *** bitcoin-git has left #bitcoin-core-dev
382020-02-25T02:20:37 *** bitcoin-git has joined #bitcoin-core-dev
392020-02-25T02:20:37 <bitcoin-git> [bitcoin] fanquake closed pull request #13989: add avx512 instrinsic (master...1-avx512) https://github.com/bitcoin/bitcoin/pull/13989
402020-02-25T02:20:38 *** bitcoin-git has left #bitcoin-core-dev
412020-02-25T02:27:52 *** bitcoin-git has joined #bitcoin-core-dev
422020-02-25T02:27:52 <bitcoin-git> [bitcoin] fanquake closed pull request #17815: rpc: Make __cookie__ user immune to rpcwhitelist (master...2019-12-rpc-cookie-user-independence) https://github.com/bitcoin/bitcoin/pull/17815
432020-02-25T02:27:53 *** bitcoin-git has left #bitcoin-core-dev
442020-02-25T02:28:36 <ariard> #17443 has been rebased and is quite simple to review and push forward wallet-node refactoring (though maybe conflicts with other wallet PRs)
452020-02-25T02:28:39 <gribble> https://github.com/bitcoin/bitcoin/issues/17443 | Drop checkFinalTx and use Median Time Past to check finality of wallet transactions by ariard · Pull Request #17443 · bitcoin/bitcoin · GitHub
462020-02-25T02:30:53 *** Highway61 has quit IRC
472020-02-25T03:00:01 *** moth has quit IRC
482020-02-25T03:17:53 *** gac410 has joined #bitcoin-core-dev
492020-02-25T03:18:17 *** gac410 is now known as Guest80845
502020-02-25T03:25:36 *** luke-jr has quit IRC
512020-02-25T03:28:31 *** luke-jr has joined #bitcoin-core-dev
522020-02-25T03:30:47 *** ahmed_ has quit IRC
532020-02-25T03:36:18 <hadjiszs> sipa: MarcoFalke: is there someone working on dandelion++ implementation as for BIP156 ? I am planning to work on top of your #13947
542020-02-25T03:36:22 <gribble> https://github.com/bitcoin/bitcoin/issues/13947 | Dandelion transaction relay (BIP 156) by MarcoFalke · Pull Request #13947 · bitcoin/bitcoin · GitHub
552020-02-25T03:41:44 *** felixfoertsch has joined #bitcoin-core-dev
562020-02-25T03:42:06 *** felixfoertsch23 has quit IRC
572020-02-25T03:49:30 *** DougieBot5000_ has joined #bitcoin-core-dev
582020-02-25T03:49:45 *** DougieBot5000 is now known as Guest92832
592020-02-25T03:49:45 *** DougieBot5000_ is now known as DougieBot5000
602020-02-25T03:49:57 *** Victorsueca has joined #bitcoin-core-dev
612020-02-25T03:50:39 *** stevenro- has quit IRC
622020-02-25T03:50:50 *** dongcarl8 has joined #bitcoin-core-dev
632020-02-25T03:51:39 *** stevenroose has joined #bitcoin-core-dev
642020-02-25T03:52:03 *** CubicEarth has quit IRC
652020-02-25T03:52:04 *** brikk has quit IRC
662020-02-25T03:52:04 *** hex17or has quit IRC
672020-02-25T03:52:31 *** Victor_sueca has quit IRC
682020-02-25T03:52:32 *** dongcarl has quit IRC
692020-02-25T03:52:32 *** commavir has quit IRC
702020-02-25T03:52:32 *** kcalvinalvin has quit IRC
712020-02-25T03:52:34 *** dongcarl8 is now known as dongcarl
722020-02-25T03:52:59 *** sturles has quit IRC
732020-02-25T03:53:00 *** exhoplex has quit IRC
742020-02-25T03:53:24 *** brikk has joined #bitcoin-core-dev
752020-02-25T03:53:25 *** CubicEarth has joined #bitcoin-core-dev
762020-02-25T03:53:57 *** sturles has joined #bitcoin-core-dev
772020-02-25T03:53:57 *** sturles has joined #bitcoin-core-dev
782020-02-25T03:54:15 *** commavir has joined #bitcoin-core-dev
792020-02-25T03:54:44 *** exhoplex has joined #bitcoin-core-dev
802020-02-25T03:54:54 *** kcalvinalvin has joined #bitcoin-core-dev
812020-02-25T03:58:37 *** hex17or has joined #bitcoin-core-dev
822020-02-25T04:00:44 *** kris11 has joined #bitcoin-core-dev
832020-02-25T04:04:39 *** spinny has joined #bitcoin-core-dev
842020-02-25T04:05:58 *** kris11 has quit IRC
852020-02-25T04:18:04 <sipa> hadjiszs: i believe dandelion os a dead end
862020-02-25T04:19:47 <sipa> hadjiszs: https://bitcoin.stackexchange.com/q/81503/208
872020-02-25T04:22:30 <aj> sipa: hmm, i thought that was just "it's a lot more work than we thought" not "it's impossible and not worth further work" ?
882020-02-25T04:26:50 <sipa> i pretty much believe there isn't a reasonable solution that ticks all the boxes
892020-02-25T04:26:50 <sipa> i don't have a strong argument for this, and would be very happy to be convinced otherwise
902020-02-25T04:30:17 *** shapeare has joined #bitcoin-core-dev
912020-02-25T04:35:14 <aj> ok, i'll remain naively optimistic then
922020-02-25T04:37:03 *** sipa has quit IRC
932020-02-25T04:43:02 *** sipa has joined #bitcoin-core-dev
942020-02-25T04:46:21 *** ddustin has joined #bitcoin-core-dev
952020-02-25T04:46:47 *** learnday20 has quit IRC
962020-02-25T04:46:59 *** ddustin has quit IRC
972020-02-25T04:47:48 *** ddustin has joined #bitcoin-core-dev
982020-02-25T05:03:20 *** ddustin has quit IRC
992020-02-25T05:03:26 *** ddustin_ has joined #bitcoin-core-dev
1002020-02-25T05:04:40 *** ddustin_ has quit IRC
1012020-02-25T05:05:15 *** ddustin has joined #bitcoin-core-dev
1022020-02-25T05:09:59 *** ddustin has quit IRC
1032020-02-25T05:40:56 *** promag has joined #bitcoin-core-dev
1042020-02-25T05:42:16 *** spinny has quit IRC
1052020-02-25T05:45:06 *** promag has quit IRC
1062020-02-25T06:00:01 *** Guest80845 has quit IRC
1072020-02-25T06:06:51 *** sipsorcery has quit IRC
1082020-02-25T06:07:07 *** sipsorcery has joined #bitcoin-core-dev
1092020-02-25T06:17:41 *** kermit2 has joined #bitcoin-core-dev
1102020-02-25T06:29:36 *** Kiminuo has joined #bitcoin-core-dev
1112020-02-25T07:14:13 *** manantial has joined #bitcoin-core-dev
1122020-02-25T07:19:56 *** goatpig has joined #bitcoin-core-dev
1132020-02-25T07:22:29 *** Guyver2 has joined #bitcoin-core-dev
1142020-02-25T07:35:33 *** shapeare has quit IRC
1152020-02-25T07:40:32 *** vasild has joined #bitcoin-core-dev
1162020-02-25T07:43:43 *** vasild_ has quit IRC
1172020-02-25T07:52:48 *** bitcoin-git has joined #bitcoin-core-dev
1182020-02-25T07:52:48 <bitcoin-git> [bitcoin] fanquake closed pull request #18116: depends: Use clang for Ubuntu 16.04 (master...20200211-clang-ubuntu) https://github.com/bitcoin/bitcoin/pull/18116
1192020-02-25T07:52:49 *** bitcoin-git has left #bitcoin-core-dev
1202020-02-25T07:57:06 *** jonatack has quit IRC
1212020-02-25T08:03:58 *** EagleTM has joined #bitcoin-core-dev
1222020-02-25T08:05:58 *** Eagle[TM] has joined #bitcoin-core-dev
1232020-02-25T08:08:38 *** EagleTM has quit IRC
1242020-02-25T08:09:29 *** AaronvanW has joined #bitcoin-core-dev
1252020-02-25T08:17:26 *** okeyzc has joined #bitcoin-core-dev
1262020-02-25T08:18:03 *** bitcoin-git has joined #bitcoin-core-dev
1272020-02-25T08:18:03 <bitcoin-git> [bitcoin] practicalswift opened pull request #18206: tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter) (master...fuzzers-bloom_filter) https://github.com/bitcoin/bitcoin/pull/18206
1282020-02-25T08:18:04 *** bitcoin-git has left #bitcoin-core-dev
1292020-02-25T08:33:18 *** jonatack has joined #bitcoin-core-dev
1302020-02-25T08:39:16 *** Eagle[TM] has quit IRC
1312020-02-25T08:51:52 *** sdjkertuz has joined #bitcoin-core-dev
1322020-02-25T08:53:43 *** okeyzc has left #bitcoin-core-dev
1332020-02-25T08:55:27 *** kljasdfvv has quit IRC
1342020-02-25T08:58:40 *** marcoagner has joined #bitcoin-core-dev
1352020-02-25T09:00:02 *** kermit2 has quit IRC
1362020-02-25T09:01:01 *** jonatack has quit IRC
1372020-02-25T09:02:51 *** mol has quit IRC
1382020-02-25T09:03:53 *** rafalcpp has joined #bitcoin-core-dev
1392020-02-25T09:16:02 *** Dieterbe1 has joined #bitcoin-core-dev
1402020-02-25T09:30:34 *** side^effects has joined #bitcoin-core-dev
1412020-02-25T09:38:26 *** promag has joined #bitcoin-core-dev
1422020-02-25T09:42:06 *** timothy has joined #bitcoin-core-dev
1432020-02-25T09:57:00 *** jonatack has joined #bitcoin-core-dev
1442020-02-25T10:01:23 *** ddustin has joined #bitcoin-core-dev
1452020-02-25T10:05:56 *** ddustin has quit IRC
1462020-02-25T10:07:29 *** AaronvanW has quit IRC
1472020-02-25T10:30:41 *** bitcoin-git has joined #bitcoin-core-dev
1482020-02-25T10:30:43 <bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a674e89d2771...03f98b15ad4f
1492020-02-25T10:30:43 <bitcoin-git> bitcoin/master 2ce3447 Vasil Dimov: Deduplicate the message verifying code
1502020-02-25T10:30:44 <bitcoin-git> bitcoin/master f8f0d98 Vasil Dimov: Deduplicate the message signing code
1512020-02-25T10:30:45 <bitcoin-git> bitcoin/master e193a84 Jeffrey Czyz: Refactor message hashing into a utility function
1522020-02-25T10:30:47 *** bitcoin-git has left #bitcoin-core-dev
1532020-02-25T10:31:16 *** bitcoin-git has joined #bitcoin-core-dev
1542020-02-25T10:31:16 <bitcoin-git> [bitcoin] meshcollider merged pull request #17577: refactor: deduplicate the message sign/verify code (master...message-dedup) https://github.com/bitcoin/bitcoin/pull/17577
1552020-02-25T10:31:19 *** bitcoin-git has left #bitcoin-core-dev
1562020-02-25T10:33:15 *** Emcy has quit IRC
1572020-02-25T10:46:03 *** Emcy has joined #bitcoin-core-dev
1582020-02-25T10:51:41 *** bitcoin-git has joined #bitcoin-core-dev
1592020-02-25T10:51:42 <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/03f98b15ad4f...31c0006a6cd5
1602020-02-25T10:51:42 <bitcoin-git> bitcoin/master 29a21c9 Sjors Provoost: [rpc] set default bip32derivs to true for psbt methods
1612020-02-25T10:51:43 <bitcoin-git> bitcoin/master 5bad792 Sjors Provoost: [test] PSBT RPC: check that bip32_derivs are present by default
1622020-02-25T10:51:43 <bitcoin-git> bitcoin/master 31c0006 Samuel Dobson: Merge #17264: rpc: set default bip32derivs to true for psbt methods
1632020-02-25T10:51:45 *** bitcoin-git has left #bitcoin-core-dev
1642020-02-25T10:52:31 *** bitcoin-git has joined #bitcoin-core-dev
1652020-02-25T10:52:31 <bitcoin-git> [bitcoin] meshcollider merged pull request #17264: rpc: set default bip32derivs to true for psbt methods (master...2019/10/bip32_derivs) https://github.com/bitcoin/bitcoin/pull/17264
1662020-02-25T10:52:32 *** bitcoin-git has left #bitcoin-core-dev
1672020-02-25T10:56:42 <provoostenator> AppVeyor is in a bad mood again.
1682020-02-25T11:03:58 *** Keven34Dooley has joined #bitcoin-core-dev
1692020-02-25T11:27:41 *** promag has quit IRC
1702020-02-25T11:32:13 *** AaronvanW has joined #bitcoin-core-dev
1712020-02-25T11:35:38 *** AaronvanW has quit IRC
1722020-02-25T11:37:25 *** Guyver2_ has joined #bitcoin-core-dev
1732020-02-25T11:40:25 *** Guyver2 has quit IRC
1742020-02-25T11:44:47 *** Emcy has quit IRC
1752020-02-25T12:00:01 *** Dieterbe1 has quit IRC
1762020-02-25T12:03:29 *** bitcoin-git has joined #bitcoin-core-dev
1772020-02-25T12:03:29 <bitcoin-git> [bitcoin] sipsorcery opened pull request #18207: WIP: Touch appveyor vcpkg file to force refresh (master...appveyor-force-refresh) https://github.com/bitcoin/bitcoin/pull/18207
1782020-02-25T12:03:30 *** bitcoin-git has left #bitcoin-core-dev
1792020-02-25T12:04:04 *** promag has joined #bitcoin-core-dev
1802020-02-25T12:04:26 <provoostenator> Surprising number of "needs rebase" after #17577, even though most of those PRs built right on top of it.
1812020-02-25T12:04:29 <gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
1822020-02-25T12:07:50 *** Kiminuo has quit IRC
1832020-02-25T12:10:40 *** promag has quit IRC
1842020-02-25T12:29:31 *** rafalcpp has quit IRC
1852020-02-25T12:34:18 *** Kiminuo has joined #bitcoin-core-dev
1862020-02-25T12:36:00 *** rafalcpp has joined #bitcoin-core-dev
1872020-02-25T12:37:02 *** promag has joined #bitcoin-core-dev
1882020-02-25T12:41:43 *** promag has quit IRC
1892020-02-25T12:43:34 *** Ceriand has joined #bitcoin-core-dev
1902020-02-25T12:51:53 *** Emcy has joined #bitcoin-core-dev
1912020-02-25T13:00:02 *** provoostenator has quit IRC
1922020-02-25T13:02:11 *** mol has joined #bitcoin-core-dev
1932020-02-25T13:14:48 *** promag has joined #bitcoin-core-dev
1942020-02-25T13:19:18 *** promag has quit IRC
1952020-02-25T13:20:59 *** belcher has joined #bitcoin-core-dev
1962020-02-25T13:22:46 *** bitcoin-git has joined #bitcoin-core-dev
1972020-02-25T13:22:46 <bitcoin-git> [bitcoin] sipsorcery closed pull request #18207: WIP: Touch appveyor vcpkg file to force refresh (master...appveyor-force-refresh) https://github.com/bitcoin/bitcoin/pull/18207
1982020-02-25T13:22:47 *** bitcoin-git has left #bitcoin-core-dev
1992020-02-25T13:42:23 *** Highway61 has joined #bitcoin-core-dev
2002020-02-25T13:51:07 *** goatpig has quit IRC
2012020-02-25T13:51:43 <instagibbs> yeah annoying, but review should be pretty simply
2022020-02-25T13:51:47 <instagibbs> simple
2032020-02-25T13:58:41 <vasild> I just checked #18115 for example. It is "based" on #17577 but the commit ids are different: https://0bin.net/paste/ZgRPbnAXjrPZvk9Q#KZaaPhwa3QeB34w8wMdr5JVyKwkl+WaVI9rcjfb5H7z
2042020-02-25T13:58:45 <gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
2052020-02-25T13:58:47 <gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
2062020-02-25T13:59:15 <vasild> so, from git perspective #18115 is not based on #17577
2072020-02-25T13:59:17 <gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
2082020-02-25T13:59:19 <gribble> https://github.com/bitcoin/bitcoin/issues/17577 | refactor: deduplicate the message sign/verify code by vasild · Pull Request #17577 · bitcoin/bitcoin · GitHub
2092020-02-25T14:13:35 *** goatpig has joined #bitcoin-core-dev
2102020-02-25T14:19:02 <vasild> I tried to rebase achow101/sign-in-spkman on top of bitcoin/master and got a conflict not related to 17577, but due to #17264 which modified src/wallet/psbtwallet.h (git show 29a21c906 -- src/wallet/psbtwallet.h) and 18115 deleted the file. To resolve, I replayed the change on wallet.h: git rebase bitcoin/master ; git rm src/wallet/psbtwallet.h ; sed -i '' 's/bip32derivs = false/bip32derivs =
2112020-02-25T14:19:05 <gribble> https://github.com/bitcoin/bitcoin/issues/17264 | rpc: set default bip32derivs to true for psbt methods by Sjors · Pull Request #17264 · bitcoin/bitcoin · GitHub
2122020-02-25T14:19:09 <vasild> true/' src/wallet/wallet.h ; git add src/wallet/wallet.h ; git rebase --continue
2132020-02-25T14:19:19 *** goatpig has quit IRC
2142020-02-25T14:26:36 *** Keven34Dooley has quit IRC
2152020-02-25T14:37:14 *** goatpig has joined #bitcoin-core-dev
2162020-02-25T14:37:26 *** provoostenator has joined #bitcoin-core-dev
2172020-02-25T14:37:55 *** Kiminuo has quit IRC
2182020-02-25T15:00:02 *** Ceriand has quit IRC
2192020-02-25T15:14:43 *** Kiminuo has joined #bitcoin-core-dev
2202020-02-25T15:15:23 *** brianhoffman has quit IRC
2212020-02-25T15:15:49 *** NilsHitze has joined #bitcoin-core-dev
2222020-02-25T15:18:02 *** brianhoffman has joined #bitcoin-core-dev
2232020-02-25T15:26:10 *** pinheadmz has quit IRC
2242020-02-25T15:26:35 *** pinheadmz has joined #bitcoin-core-dev
2252020-02-25T15:26:55 *** t420babe has quit IRC
2262020-02-25T15:27:24 *** t420babe has joined #bitcoin-core-dev
2272020-02-25T15:27:31 *** adam3us has quit IRC
2282020-02-25T15:27:54 *** nsh has quit IRC
2292020-02-25T15:29:11 *** adam3us has joined #bitcoin-core-dev
2302020-02-25T15:45:02 *** nsh has joined #bitcoin-core-dev
2312020-02-25T15:47:30 *** mdunnio has joined #bitcoin-core-dev
2322020-02-25T15:49:25 *** AaronvanW has joined #bitcoin-core-dev
2332020-02-25T16:03:26 *** ahmed_ has joined #bitcoin-core-dev
2342020-02-25T16:09:52 *** goatpig has quit IRC
2352020-02-25T16:13:10 <sdaftuar> sipa: around? i was just discussing wtxid-relay with gleb, he brought up that the erlay proposal included a 128-bit wtxid-relay component as well, which made me think that if we wanted to go that route, i should just update my proposal for wtxid-relay to do that
2362020-02-25T16:13:57 <sipa> sdaftuar: yeah, that seems reasonable
2372020-02-25T16:14:00 <sdaftuar> sipa: but that made me wonder if 128-bit commitments are secure enough for transaction relay; seems like in protocols where multiple parties are jointly constructing transactions, you only get 64-bit security against collisions, which could be used to interfere with relay?
2382020-02-25T16:14:20 <sipa> hmm
2392020-02-25T16:16:02 *** ddustin has joined #bitcoin-core-dev
2402020-02-25T16:16:54 *** AaronvanW has quit IRC
2412020-02-25T16:16:56 <sipa> 2^64 is still an enormous amount of work... not "impossible", but it's still several days with a modern ASIC miner
2422020-02-25T16:17:19 <gleb> For the context, there's no real need to use 128-bit in Erlay, it's just an additional bandwidth saving, maybe about 5% of the overall bandwidth a node consumes.
2432020-02-25T16:17:49 <sipa> (assuming an ASIC could even be used for that purpose of course)
2442020-02-25T16:18:09 <sipa> and at those cost levels there are probably easier ways to interfere with relay
2452020-02-25T16:18:28 *** bitcoin-git has joined #bitcoin-core-dev
2462020-02-25T16:18:28 <bitcoin-git> [bitcoin] yusufsahinhamza opened pull request #18208: rpc: Fix RPCExamples (master...fix-rpc-examples) https://github.com/bitcoin/bitcoin/pull/18208
2472020-02-25T16:18:29 *** bitcoin-git has left #bitcoin-core-dev
2482020-02-25T16:18:31 <sdaftuar> right, and maybe protocols today work in such a way to make this not really an issue, just hard for me to reason about it
2492020-02-25T16:19:33 *** bitcoin-git has joined #bitcoin-core-dev
2502020-02-25T16:19:33 <bitcoin-git> [bitcoin] yusufsahinhamza closed pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
2512020-02-25T16:19:34 *** bitcoin-git has left #bitcoin-core-dev
2522020-02-25T16:56:31 <sipa> sdaftuar: like... you could just create a double spend instead
2532020-02-25T16:56:51 *** bitcoin-git has joined #bitcoin-core-dev
2542020-02-25T16:56:51 <bitcoin-git> [bitcoin] yusufsahinhamza reopened pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
2552020-02-25T16:56:52 *** bitcoin-git has left #bitcoin-core-dev
2562020-02-25T16:56:52 <sipa> so i think the goal is making sure relay isn't worse accidentally
2572020-02-25T16:56:57 <sipa> rather tha intentionally
2582020-02-25T16:57:20 *** mol has quit IRC
2592020-02-25T17:03:57 <MarcoFalke> PSA to review locally. GitHub is again serving corrupt pull requests on the website
2602020-02-25T17:07:20 <achow101> vasild: usually when I base a PR on other commits, we just cherry pick those commits and base the whole thing on whatever the master was at that time
2612020-02-25T17:07:42 <achow101> so the commit hashes won't match, but the diffs do
2622020-02-25T17:07:51 <achow101> then during a rebase, those commits can be dropped and the overall diff stays the same
2632020-02-25T17:10:37 <vasild> achow101: I see, github nevertheless, still prints "This branch has conflicts that must be resolved ... src/util/message.h" even though when I tried the rebase there was not a conflict in src/util/message.h
2642020-02-25T17:11:35 <MarcoFalke> vasild: GitHub backend is down or lagging, so that might be the issue
2652020-02-25T17:12:04 <sdaftuar> sipa: not sure i follow... are there protocols where you and i might produce a multisig transaction (signing a shared output i can't double-spend),but where interfering with the relay of that jointly-constructed transaction is beneficial to me somehow?
2662020-02-25T17:12:12 <sdaftuar> ie in lightning
2672020-02-25T17:12:18 <achow101> It's normal for github to say there's a merge conflict when the files that were modified by the base PR gets merged
2682020-02-25T17:12:43 <sdaftuar> this might be easier for me to talk about if i actually had any idea how lightning works, let me ask someone here :)
2692020-02-25T17:14:08 <sipa> sdaftuar: oh good point, let me think more
2702020-02-25T17:15:17 <vasild> achow101: yes, all good
2712020-02-25T17:16:15 *** promag has joined #bitcoin-core-dev
2722020-02-25T17:17:31 <sipa> sdaftuar: somehow i thought a collision would need multiple parties to collaborate; need more caffeine
2732020-02-25T17:19:35 <sdaftuar> i just talked it through with matt and he seems to believe that what i'm saying would be a concern in lightning (at least theoretically -- as a practical matter i have no idea)
2742020-02-25T17:20:21 <sipa> another possibility is just skipping 128-bit wtxid for now, and doing it as a later step (orthogonal to wtxid and erlay)
2752020-02-25T17:20:38 *** promag has quit IRC
2762020-02-25T17:22:38 <sipa> or not
2772020-02-25T17:25:27 *** Emcy has quit IRC
2782020-02-25T17:36:40 *** krvopije has joined #bitcoin-core-dev
2792020-02-25T17:37:06 *** krvopije has quit IRC
2802020-02-25T17:46:01 *** justanotheruser has quit IRC
2812020-02-25T17:50:32 *** Emcy has joined #bitcoin-core-dev
2822020-02-25T17:56:36 <gleb> I'm afraid that means that final potential version will have to support txid, wtxid, and trunc-wtxid, so 3 different filters?
2832020-02-25T18:00:01 *** NilsHitze has quit IRC
2842020-02-25T18:02:33 *** bitcoin-git has joined #bitcoin-core-dev
2852020-02-25T18:02:33 <bitcoin-git> [bitcoin] yusufsahinhamza closed pull request #18197: rpc: update some RPCExamples to bech32 (master...rpc-examples) https://github.com/bitcoin/bitcoin/pull/18197
2862020-02-25T18:02:35 *** bitcoin-git has left #bitcoin-core-dev
2872020-02-25T18:07:06 *** spinny has joined #bitcoin-core-dev
2882020-02-25T18:07:19 <sipa> gleb: at least with ordered indexes, one index suffices for both 128-bit and 256-bit lookups
2892020-02-25T18:07:46 <sipa> ah, but the current mempool index is not ordered
2902020-02-25T18:12:29 *** justanotheruser has joined #bitcoin-core-dev
2912020-02-25T18:16:05 *** StephenS1 has joined #bitcoin-core-dev
2922020-02-25T18:22:14 *** ahmed_ has quit IRC
2932020-02-25T18:34:05 *** theoRem_ has joined #bitcoin-core-dev
2942020-02-25T18:34:11 *** justanotheruser has quit IRC
2952020-02-25T18:34:29 *** theoRem_ is now known as Guest52093
2962020-02-25T18:34:58 <sdaftuar> my instinct is that for a 5% bandwidth savings (once we have erlay), it's not really worth the effort to try to convince ourselves that the truncated hash is safe, but i feel a bit bad being a defeatist
2972020-02-25T18:43:29 *** Guest52093 has quit IRC
2982020-02-25T18:43:43 *** ghost43 has quit IRC
2992020-02-25T18:44:02 *** ghost43 has joined #bitcoin-core-dev
3002020-02-25T18:45:36 *** promag has joined #bitcoin-core-dev
3012020-02-25T18:49:58 *** justanotheruser has joined #bitcoin-core-dev
3022020-02-25T18:55:31 <gleb> Yeah, at this point I'd also prefer to stick with 256-bit ids, for the reason suhas points out. I also bet someone smart would decide to waste their time to write a paper about attacking bitcoin with this thing :)
3032020-02-25T19:02:08 <sipa> maybe that's indeed best
3042020-02-25T19:03:33 *** promag has quit IRC
3052020-02-25T19:07:14 *** captjakk has joined #bitcoin-core-dev
3062020-02-25T19:14:27 *** ghost43 has quit IRC
3072020-02-25T19:15:12 *** ghost43 has joined #bitcoin-core-dev
3082020-02-25T19:15:54 *** bitcoin-git has joined #bitcoin-core-dev
3092020-02-25T19:15:54 <bitcoin-git> [bitcoin] kiminuo opened pull request #18210: Type hints in Python tests (master...feature/type-hint-minimum) https://github.com/bitcoin/bitcoin/pull/18210
3102020-02-25T19:15:55 *** bitcoin-git has left #bitcoin-core-dev
3112020-02-25T19:21:40 <instagibbs> gleb, another way to look at it is including truncated wtxid may slow down erlay, which has asymptotic win, not just %
3122020-02-25T19:21:46 <instagibbs> wrt number of peers
3132020-02-25T19:21:52 <instagibbs> slow down acceptance of erlay*
3142020-02-25T19:22:44 <gleb> instagibbs: Why would it slow down the acceptance of erlay?
3152020-02-25T19:26:31 <instagibbs> another bikeshedding/discussion, just like here :)
3162020-02-25T19:26:46 <instagibbs> maybe I'm wrong, then nevermind me
3172020-02-25T19:27:21 <sipa> instagibbs: that's boring, sure you're not up for a trial by combat to determine who is right?
3182020-02-25T19:28:56 <gleb> instagibbs: In this particular case I was less optimistic about people caring, but yeah, you're right in that sense.
3192020-02-25T19:32:41 *** mk_ has quit IRC
3202020-02-25T19:38:39 *** bitcoin-git has joined #bitcoin-core-dev
3212020-02-25T19:38:39 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/31c0006a6cd5...c3b471592346
3222020-02-25T19:38:40 <bitcoin-git> bitcoin/master 2a6a6ea practicalswift: tests: Add fuzzing harness for bloom filter class CBloomFilter
3232020-02-25T19:38:40 <bitcoin-git> bitcoin/master eabbbe4 practicalswift: tests: Add fuzzing harness for rolling bloom filter class CRollingBloomFil...
3242020-02-25T19:38:41 <bitcoin-git> bitcoin/master c3b4715 MarcoFalke: Merge #18206: tests: Add fuzzing harness for bloom filter classes (CBloomF...
3252020-02-25T19:38:51 *** bitcoin-git has left #bitcoin-core-dev
3262020-02-25T19:39:09 *** bitcoin-git has joined #bitcoin-core-dev
3272020-02-25T19:39:09 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18206: tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter) (master...fuzzers-bloom_filter) https://github.com/bitcoin/bitcoin/pull/18206
3282020-02-25T19:39:10 *** bitcoin-git has left #bitcoin-core-dev
3292020-02-25T19:40:30 *** vasild_ has joined #bitcoin-core-dev
3302020-02-25T19:43:43 *** vasild has quit IRC
3312020-02-25T19:57:14 *** jonatack has quit IRC
3322020-02-25T20:16:26 <sdaftuar> jeremyrubin: around?
3332020-02-25T20:29:29 *** bitcoin-git has joined #bitcoin-core-dev
3342020-02-25T20:29:29 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18211: test: Work around scheduler_tests intermittent failures (take 2) (master...2002-testSchedulerWorkaround) https://github.com/bitcoin/bitcoin/pull/18211
3352020-02-25T20:29:30 *** bitcoin-git has left #bitcoin-core-dev
3362020-02-25T20:32:09 *** guest534543 has joined #bitcoin-core-dev
3372020-02-25T20:35:23 *** Kiminuo has quit IRC
3382020-02-25T20:43:11 *** justanotheruser has quit IRC
3392020-02-25T20:49:14 *** guest534543 has quit IRC
3402020-02-25T20:49:38 *** Kiminuo has joined #bitcoin-core-dev
3412020-02-25T20:52:00 *** promag has joined #bitcoin-core-dev
3422020-02-25T21:00:01 *** StephenS1 has quit IRC
3432020-02-25T21:20:16 *** spinny has quit IRC
3442020-02-25T21:35:14 *** ghost1 has joined #bitcoin-core-dev
3452020-02-25T21:37:16 *** timothy has quit IRC
3462020-02-25T21:39:33 *** manantial has quit IRC
3472020-02-25T21:45:11 *** mikeyman77 has joined #bitcoin-core-dev
3482020-02-25T21:57:16 *** ghost1 has quit IRC
3492020-02-25T22:02:52 *** andrewtoth has joined #bitcoin-core-dev
3502020-02-25T22:04:04 *** captjakk has quit IRC
3512020-02-25T22:13:38 *** justanotheruser has joined #bitcoin-core-dev
3522020-02-25T22:14:36 *** Guyver2_ has quit IRC
3532020-02-25T22:16:15 *** belcher has quit IRC
3542020-02-25T22:16:27 *** Emcy has quit IRC
3552020-02-25T22:29:07 *** Emcy has joined #bitcoin-core-dev
3562020-02-25T22:32:13 *** AaronvanW has joined #bitcoin-core-dev
3572020-02-25T22:40:34 *** djpeen has joined #bitcoin-core-dev
3582020-02-25T22:42:14 *** djpeen_ has joined #bitcoin-core-dev
3592020-02-25T22:43:03 *** djpeen has joined #bitcoin-core-dev
3602020-02-25T22:51:46 *** AaronvanW has quit IRC
3612020-02-25T22:58:24 *** captjakk has joined #bitcoin-core-dev
3622020-02-25T23:00:16 <achow101> what would cause std::map to not find an element that's definitely there?
3632020-02-25T23:00:54 <achow101> examining in gdb tells me the element is there and the key I'm searching with is correct. but it always returns end()
3642020-02-25T23:02:08 *** filchef has joined #bitcoin-core-dev
3652020-02-25T23:03:19 *** filchef has quit IRC
3662020-02-25T23:07:10 <sipa> achow101: was the key elememt modified after inserting?
3672020-02-25T23:07:39 <achow101> no
3682020-02-25T23:07:57 <sipa> what is the key type?
3692020-02-25T23:08:08 <achow101> KeyOriginInfo. I added an operator<
3702020-02-25T23:08:33 <sipa> what pr?
3712020-02-25T23:09:24 <achow101> I haven't pushed it yet. it's supposed to be a modification to #18204
3722020-02-25T23:09:26 <gribble> https://github.com/bitcoin/bitcoin/issues/18204 | descriptors: improve descriptor cache and cache xpubs by achow101 · Pull Request #18204 · bitcoin/bitcoin · GitHub
3732020-02-25T23:09:52 <sipa> ok link to code/branchm
3742020-02-25T23:09:54 <sipa> ?
3752020-02-25T23:09:57 *** mdunnio has quit IRC
3762020-02-25T23:10:57 <achow101> https://github.com/achow101/bitcoin/tree/desc-xpub-cache2
3772020-02-25T23:11:30 <achow101> descriptor_tests fails currently due to that maps thing
3782020-02-25T23:11:41 <sipa> your operator< is inconsistent
3792020-02-25T23:11:48 <achow101> it is?
3802020-02-25T23:12:10 <sipa> if a.fingerprint > b.fingerprint you have to return false
3812020-02-25T23:12:26 <sipa> even if a.path < b.path
3822020-02-25T23:13:14 <achow101> ah
3832020-02-25T23:13:39 <sipa> the general structure of such comparators is something like: if a.x < b.x return true; if a.x > b.x return false; if a.x == b.x fall through to next tie breaker
3842020-02-25T23:15:36 <achow101> I guess that explains why it only failed with the multi descriptors too
3852020-02-25T23:15:47 <achow101> when I had more than one xpub in the map
3862020-02-25T23:16:35 <sipa> right
3872020-02-25T23:19:43 *** captjakk has quit IRC
3882020-02-25T23:21:55 *** AaronvanW has joined #bitcoin-core-dev
3892020-02-25T23:21:59 *** captjakk has joined #bitcoin-core-dev
3902020-02-25T23:24:40 *** promag has quit IRC
3912020-02-25T23:31:27 *** wullon5 has quit IRC
3922020-02-25T23:35:55 *** nullptr| has quit IRC
3932020-02-25T23:49:42 *** captjakk has quit IRC
3942020-02-25T23:50:30 *** nullptr| has joined #bitcoin-core-dev