12020-03-23T00:00:01  *** VitamineD has quit IRC
  22020-03-23T00:03:25  *** justanotheruser has joined #bitcoin-core-dev
  32020-03-23T00:19:02  *** justanotheruser has quit IRC
  42020-03-23T00:21:44  *** zepheiryan has joined #bitcoin-core-dev
  52020-03-23T00:26:36  *** marcoagner has quit IRC
  62020-03-23T00:36:47  *** justanotheruser has joined #bitcoin-core-dev
  72020-03-23T00:37:34  *** Highway61 has quit IRC
  82020-03-23T00:38:48  <kallewoof> sipa: I had the same error yesterday. Tried restarting the job again today and now it seems to be working.
  92020-03-23T00:41:20  *** sipsorcery has quit IRC
 102020-03-23T00:45:21  *** owowo has quit IRC
 112020-03-23T00:50:38  *** owowo has joined #bitcoin-core-dev
 122020-03-23T00:52:10  *** promag has quit IRC
 132020-03-23T00:52:31  *** promag has joined #bitcoin-core-dev
 142020-03-23T00:53:49  *** gleb has joined #bitcoin-core-dev
 152020-03-23T00:57:26  *** promag has quit IRC
 162020-03-23T01:04:15  *** ddustin has quit IRC
 172020-03-23T01:06:49  *** ddustin has joined #bitcoin-core-dev
 182020-03-23T01:08:32  *** promag has joined #bitcoin-core-dev
 192020-03-23T01:11:15  *** ddustin has quit IRC
 202020-03-23T01:12:58  *** promag has quit IRC
 212020-03-23T01:13:12  *** promag has joined #bitcoin-core-dev
 222020-03-23T01:18:25  *** molly has joined #bitcoin-core-dev
 232020-03-23T01:20:54  *** mol has quit IRC
 242020-03-23T01:21:04  <promag> #18160 for 0.20?
 252020-03-23T01:21:06  <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
 262020-03-23T01:24:06  <fanquake> promag: can you clarify if that is a bugfix?
 272020-03-23T01:25:35  <promag> not a bugfix, but rather a GUI improvement
 282020-03-23T01:26:13  <fanquake> ok
 292020-03-23T01:26:49  <promag> #15015
 302020-03-23T01:26:50  <gribble> https://github.com/bitcoin/bitcoin/issues/15015 | slow GUI with large wallets · Issue #15015 · bitcoin/bitcoin · GitHub
 312020-03-23T01:33:26  <promag> fanquake: fwiw it has 4 acks
 322020-03-23T01:34:16  <fanquake> promag: ok, I'll take a look this morning
 332020-03-23T01:34:35  <promag> I also think it could be backport in 0.19.1
 342020-03-23T01:34:42  <promag> thanks
 352020-03-23T01:35:19  *** belcher has quit IRC
 362020-03-23T01:40:00  *** tys0n_ has quit IRC
 372020-03-23T01:40:35  *** promag has quit IRC
 382020-03-23T01:42:29  *** promag has joined #bitcoin-core-dev
 392020-03-23T01:46:53  *** emilengler has quit IRC
 402020-03-23T01:51:10  *** promag_ has joined #bitcoin-core-dev
 412020-03-23T01:55:35  *** ddustin has joined #bitcoin-core-dev
 422020-03-23T01:56:26  *** promag_ has joined #bitcoin-core-dev
 432020-03-23T01:56:43  *** luke-jr has quit IRC
 442020-03-23T01:57:42  *** promag_ has quit IRC
 452020-03-23T01:57:48  *** luke-jr has joined #bitcoin-core-dev
 462020-03-23T01:58:19  *** promag_ has joined #bitcoin-core-dev
 472020-03-23T01:59:41  *** promag_ has joined #bitcoin-core-dev
 482020-03-23T02:01:54  *** promag__ has joined #bitcoin-core-dev
 492020-03-23T02:10:44  *** promag_ has quit IRC
 502020-03-23T02:13:25  *** promag__ has quit IRC
 512020-03-23T02:13:32  *** ddustin has quit IRC
 522020-03-23T02:13:49  *** ddustin has joined #bitcoin-core-dev
 532020-03-23T02:16:10  *** promag_ has joined #bitcoin-core-dev
 542020-03-23T02:18:06  *** promag has quit IRC
 552020-03-23T02:25:14  *** promag_ has quit IRC
 562020-03-23T02:25:34  *** Victorsueca has quit IRC
 572020-03-23T02:28:27  *** Victorsueca has joined #bitcoin-core-dev
 582020-03-23T02:31:20  *** Victor_sueca has joined #bitcoin-core-dev
 592020-03-23T02:34:25  *** Victorsueca has quit IRC
 602020-03-23T02:36:04  *** Victorsueca has joined #bitcoin-core-dev
 612020-03-23T02:38:43  *** Victor_sueca has quit IRC
 622020-03-23T02:46:50  *** bitcoin-git has joined #bitcoin-core-dev
 632020-03-23T02:46:50  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5504703a9f83...57a8fa9c3b44
 642020-03-23T02:46:51  <bitcoin-git> bitcoin/master f0dfac7 Sebastian Falbesoner: test: add executable flag for rpc_estimatefee.py
 652020-03-23T02:46:51  <bitcoin-git> bitcoin/master 57a8fa9 fanquake: Merge #18406: test: add executable flag for rpc_estimatefee.py
 662020-03-23T02:46:53  *** bitcoin-git has left #bitcoin-core-dev
 672020-03-23T02:47:10  *** bitcoin-git has joined #bitcoin-core-dev
 682020-03-23T02:47:10  <bitcoin-git> [bitcoin] fanquake merged pull request #18406: test: add executable flag for rpc_estimatefee.py (master...20200322-test-add-executable-flag-for-rpc-estimatefee) https://github.com/bitcoin/bitcoin/pull/18406
 692020-03-23T02:47:11  *** bitcoin-git has left #bitcoin-core-dev
 702020-03-23T02:59:59  *** ddustin has quit IRC
 712020-03-23T03:00:01  *** zepheiryan has quit IRC
 722020-03-23T03:00:38  *** ddustin has joined #bitcoin-core-dev
 732020-03-23T03:04:55  *** ddustin has quit IRC
 742020-03-23T03:17:50  *** dviola has quit IRC
 752020-03-23T03:18:29  *** promag has joined #bitcoin-core-dev
 762020-03-23T03:20:08  *** andrewtoth has joined #bitcoin-core-dev
 772020-03-23T03:20:25  *** skydrome1 has joined #bitcoin-core-dev
 782020-03-23T03:23:01  *** promag has quit IRC
 792020-03-23T03:26:34  *** kexkey has quit IRC
 802020-03-23T03:30:23  *** felixfoertsch23 has joined #bitcoin-core-dev
 812020-03-23T03:32:53  *** felixfoertsch has quit IRC
 822020-03-23T04:01:51  *** smie has joined #bitcoin-core-dev
 832020-03-23T04:01:55  *** smie has left #bitcoin-core-dev
 842020-03-23T04:02:06  *** Ocheg has joined #bitcoin-core-dev
 852020-03-23T04:02:10  *** Ocheg has left #bitcoin-core-dev
 862020-03-23T04:02:37  *** obeafrae has joined #bitcoin-core-dev
 872020-03-23T04:02:41  *** obeafrae has left #bitcoin-core-dev
 882020-03-23T04:02:51  *** sivi has joined #bitcoin-core-dev
 892020-03-23T04:02:56  *** sivi has left #bitcoin-core-dev
 902020-03-23T04:02:58  *** veefobaxe has joined #bitcoin-core-dev
 912020-03-23T04:03:02  *** veefobaxe has left #bitcoin-core-dev
 922020-03-23T04:03:04  *** Oslasw has joined #bitcoin-core-dev
 932020-03-23T04:08:14  *** morcos has quit IRC
 942020-03-23T04:08:33  *** morcos has joined #bitcoin-core-dev
 952020-03-23T04:19:22  *** promag has joined #bitcoin-core-dev
 962020-03-23T04:19:44  *** promag has joined #bitcoin-core-dev
 972020-03-23T04:28:18  *** bitcoin-git has joined #bitcoin-core-dev
 982020-03-23T04:28:18  <bitcoin-git> [bitcoin] practicalswift opened pull request #18407: tests: Add proof-of-work fuzzing harness (master...fuzzers-proof-of-work) https://github.com/bitcoin/bitcoin/pull/18407
 992020-03-23T04:28:19  *** bitcoin-git has left #bitcoin-core-dev
1002020-03-23T04:35:58  <aj> instagibbs: #13990 if you're bored
1012020-03-23T04:36:00  <gribble> https://github.com/bitcoin/bitcoin/issues/13990 | Allow fee estimation to work with lower fees by ajtowns · Pull Request #13990 · bitcoin/bitcoin · GitHub
1022020-03-23T05:42:07  *** TheHoliestRoger has quit IRC
1032020-03-23T05:44:16  *** TheHoliestRoger has joined #bitcoin-core-dev
1042020-03-23T05:59:25  *** Highway61 has joined #bitcoin-core-dev
1052020-03-23T06:00:02  *** skydrome1 has quit IRC
1062020-03-23T06:21:50  *** gnomus has joined #bitcoin-core-dev
1072020-03-23T06:32:02  *** justanotheruser has quit IRC
1082020-03-23T07:01:23  *** tsujp has joined #bitcoin-core-dev
1092020-03-23T07:02:36  *** Highway61 has quit IRC
1102020-03-23T07:06:05  *** BamBaRay36 has joined #bitcoin-core-dev
1112020-03-23T07:19:46  *** justanotheruser has joined #bitcoin-core-dev
1122020-03-23T07:34:35  *** bitcoin-git has joined #bitcoin-core-dev
1132020-03-23T07:34:35  <bitcoin-git> [bitcoin] hebasto closed pull request #18387: gui: Fix segfault for loading and immediately unloading wallet (master...20200319-fix-modelwallet-segfault) https://github.com/bitcoin/bitcoin/pull/18387
1142020-03-23T07:34:37  *** bitcoin-git has left #bitcoin-core-dev
1152020-03-23T07:41:01  *** vasild_ has joined #bitcoin-core-dev
1162020-03-23T07:44:03  *** vasild has quit IRC
1172020-03-23T07:44:04  *** vasild_ is now known as vasild
1182020-03-23T08:06:38  *** manantial has joined #bitcoin-core-dev
1192020-03-23T08:11:11  *** kristapsk_ has joined #bitcoin-core-dev
1202020-03-23T08:13:22  *** mdunnio has joined #bitcoin-core-dev
1212020-03-23T08:13:23  *** kristapsk has quit IRC
1222020-03-23T08:16:27  *** sipsorcery has joined #bitcoin-core-dev
1232020-03-23T08:17:54  *** mdunnio has quit IRC
1242020-03-23T08:29:52  <vasild> kallewoof: wrt #17994 - I assumed that we should first flush the block file to a persistent storage and afterwards flush the undo file (finalization not being relevant for this). Because in the case of a crash/power outage in between flushing both we could end up with a block on disk without undo, or with undo on disk without a block.
1252020-03-23T08:29:54  <gribble> https://github.com/bitcoin/bitcoin/issues/17994 | validation: flush undo files after last block write by kallewoof · Pull Request #17994 · bitcoin/bitcoin · GitHub
1262020-03-23T08:30:46  <vasild> and I assume we dont want the latter
1272020-03-23T08:31:32  <vasild> but now I can't find anything in the code that would brick if we have undo without a block
1282020-03-23T08:56:44  *** kljasdfvv has joined #bitcoin-core-dev
1292020-03-23T09:00:01  *** gnomus has quit IRC
1302020-03-23T09:09:40  *** Guyver2 has joined #bitcoin-core-dev
1312020-03-23T09:11:44  <vasild> https://github.com/bitcoin/bitcoin/blob/312d27b/src/validation.cpp#L4810 -- this code would get upset if it finds an undo without a block, hmm
1322020-03-23T09:13:25  *** dr-orlovsky has joined #bitcoin-core-dev
1332020-03-23T09:21:56  *** yhsiang has joined #bitcoin-core-dev
1342020-03-23T09:22:03  *** tsujp has quit IRC
1352020-03-23T09:23:14  *** marcoagner has joined #bitcoin-core-dev
1362020-03-23T09:23:40  *** promag_ has joined #bitcoin-core-dev
1372020-03-23T09:30:15  *** AaronvanW has joined #bitcoin-core-dev
1382020-03-23T09:40:14  *** Kiminuo has quit IRC
1392020-03-23T09:42:51  *** tsujp has joined #bitcoin-core-dev
1402020-03-23T09:47:22  *** Kiminuo has joined #bitcoin-core-dev
1412020-03-23T10:08:36  *** timothy has joined #bitcoin-core-dev
1422020-03-23T10:23:59  *** dr-orlovsky has quit IRC
1432020-03-23T10:26:22  *** bitcoin-git has joined #bitcoin-core-dev
1442020-03-23T10:26:22  <bitcoin-git> [bitcoin] vova557 opened pull request #18408: Bitcoin (master...master) https://github.com/bitcoin/bitcoin/pull/18408
1452020-03-23T10:26:25  *** bitcoin-git has left #bitcoin-core-dev
1462020-03-23T10:28:02  *** bitcoin-git has joined #bitcoin-core-dev
1472020-03-23T10:28:02  <bitcoin-git> [bitcoin] fanquake closed pull request #18408: Bitcoin (master...master) https://github.com/bitcoin/bitcoin/pull/18408
1482020-03-23T10:28:03  *** bitcoin-git has left #bitcoin-core-dev
1492020-03-23T10:37:16  *** emilengler has joined #bitcoin-core-dev
1502020-03-23T10:52:48  *** kristapsk_ has quit IRC
1512020-03-23T10:53:13  *** kristapsk_ has joined #bitcoin-core-dev
1522020-03-23T11:03:58  *** Jalen30Runte has joined #bitcoin-core-dev
1532020-03-23T11:15:15  *** AaronvanW has quit IRC
1542020-03-23T11:31:36  *** AaronvanW has joined #bitcoin-core-dev
1552020-03-23T11:36:42  *** Deacyde has quit IRC
1562020-03-23T11:39:31  *** bitcoin-git has joined #bitcoin-core-dev
1572020-03-23T11:39:32  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/57a8fa9c3b44...d478a737dbdd
1582020-03-23T11:39:32  <bitcoin-git> bitcoin/master fa01feb MarcoFalke: test: Remove ci timeout restriction in test_runner
1592020-03-23T11:39:33  <bitcoin-git> bitcoin/master fa92af5 MarcoFalke: ci: Run feature_block and feature_abortnode in valgrind
1602020-03-23T11:39:33  <bitcoin-git> bitcoin/master d478a73 MarcoFalke: Merge #18392: ci: Run feature_block in valgrind
1612020-03-23T11:39:35  *** bitcoin-git has left #bitcoin-core-dev
1622020-03-23T11:39:51  *** bitcoin-git has joined #bitcoin-core-dev
1632020-03-23T11:39:51  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18392: ci: Run feature_block in valgrind (master...2003-ciMoreVal) https://github.com/bitcoin/bitcoin/pull/18392
1642020-03-23T11:39:52  *** bitcoin-git has left #bitcoin-core-dev
1652020-03-23T11:41:01  *** bitcoin-git has joined #bitcoin-core-dev
1662020-03-23T11:41:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d478a737dbdd...97b0687501ce
1672020-03-23T11:41:01  <bitcoin-git> bitcoin/master 7c1ac70 practicalswift: tests: Don't assume presence of __builtin_mul_overflow in MultiplicationOv...
1682020-03-23T11:41:02  <bitcoin-git> bitcoin/master 97b0687 MarcoFalke: Merge #18393: tests: Don't assume presence of __builtin_mul_overflow(…) in...
1692020-03-23T11:41:03  *** bitcoin-git has left #bitcoin-core-dev
1702020-03-23T11:41:21  *** bitcoin-git has joined #bitcoin-core-dev
1712020-03-23T11:41:21  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18393: tests: Don't assume presence of __builtin_mul_overflow(…) in MultiplicationOverflow(…) fuzzing harness (master...multiplication-overflow-fixup) https://github.com/bitcoin/bitcoin/pull/18393
1722020-03-23T11:41:22  *** bitcoin-git has left #bitcoin-core-dev
1732020-03-23T11:47:06  *** Highway61 has joined #bitcoin-core-dev
1742020-03-23T11:53:04  *** bitcoin-git has joined #bitcoin-core-dev
1752020-03-23T11:53:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18380: doc: Remove html comment in PULL_REQUEST_TEMPLATE (master...2003-docGitHubTemplateNoComment) https://github.com/bitcoin/bitcoin/pull/18380
1762020-03-23T11:53:05  *** bitcoin-git has left #bitcoin-core-dev
1772020-03-23T12:00:02  *** yhsiang has quit IRC
1782020-03-23T12:21:14  *** promag_ has quit IRC
1792020-03-23T12:21:59  *** castironpi has joined #bitcoin-core-dev
1802020-03-23T12:39:34  *** Jalen30Runte has quit IRC
1812020-03-23T12:41:36  *** emilengler has quit IRC
1822020-03-23T12:47:07  *** emilengler has joined #bitcoin-core-dev
1832020-03-23T12:47:35  *** promag_ has joined #bitcoin-core-dev
1842020-03-23T12:51:54  *** promag_ has quit IRC
1852020-03-23T12:51:59  *** emilengler has quit IRC
1862020-03-23T12:52:07  *** emilengler has joined #bitcoin-core-dev
1872020-03-23T12:55:24  *** emilengler has quit IRC
1882020-03-23T12:55:31  *** emilengler has joined #bitcoin-core-dev
1892020-03-23T12:57:13  *** emilengler has joined #bitcoin-core-dev
1902020-03-23T13:01:57  *** emilengler has quit IRC
1912020-03-23T13:02:11  *** emilengler has joined #bitcoin-core-dev
1922020-03-23T13:06:56  *** roconnor has joined #bitcoin-core-dev
1932020-03-23T13:22:08  *** promag_ has joined #bitcoin-core-dev
1942020-03-23T13:26:15  *** promag_ has quit IRC
1952020-03-23T13:29:12  <kallewoof> vasild: Damn. I guess having undo without block is bad, even if there weren't any instances of badness happening. I wanted to keep this as simple as possible...
1962020-03-23T13:29:40  <vasild> just composing a comment on gh...
1972020-03-23T13:29:41  <kallewoof> vasild: But wait. We do have the block. It's just that we don't flush the block file. Or am I confused now?
1982020-03-23T13:30:04  <kallewoof> vasild: Block is written when it comes in, and later it is connected to tip and undo data is written.
1992020-03-23T13:31:08  <kallewoof> I guess no flush essentially means no guarantees that block was actually written or not, though...
2002020-03-23T13:31:51  *** mdunnio has joined #bitcoin-core-dev
2012020-03-23T13:32:22  <vasild> posted: https://github.com/bitcoin/bitcoin/pull/17994#discussion_r396451804
2022020-03-23T13:32:27  <vasild> now, lets figure this out :)
2032020-03-23T13:33:53  <kallewoof> Thanks, your comment makes perfect sense.
2042020-03-23T13:35:00  <vasild> so, something like the crude patch in https://github.com/bitcoin/bitcoin/pull/17994/files#r395635091 would restore the order of flushing to blk,undo
2052020-03-23T13:36:47  <vasild> it can be simplified because at the time FlushBlockFile() is called thisUndoNeedsFlushingAndFinalizing == nLastBlockFile, so we can FlushUndoFile(nLastBlockFile, true).
2062020-03-23T13:37:37  <vasild> FlushBlockFile() flushes nLastBlockFile
2072020-03-23T13:41:41  <vasild> hmm
2082020-03-23T13:45:46  <vasild> there is a mutex protecting nLastBlockFile :/
2092020-03-23T13:47:34  <kallewoof> vasild: It feels like you can just use a flag. Kinda like https://github.com/bitcoin/bitcoin/pull/17994/commits/84ed7228b69a03c56dfd77bb0df84b39b77b5cea
2102020-03-23T13:47:52  <kallewoof> vasild: maybe I'm overengineering this
2112020-03-23T13:49:15  <vasild> yes, my thought, exactly!
2122020-03-23T13:49:40  <vasild> ^^ replying to your comment about the flag, not about overengineering ;-)
2132020-03-23T13:50:35  * kallewoof nodnods
2142020-03-23T13:51:18  <vasild> kallewoof: now the patch looks good to me, I will stare at it for some more time and will test it.
2152020-03-23T13:52:21  <kallewoof> Nice! :) I recompiled my running node and running this code on it now.
2162020-03-23T13:55:11  *** promag_ has joined #bitcoin-core-dev
2172020-03-23T13:59:29  *** promag_ has quit IRC
2182020-03-23T14:02:06  *** AaronvanW has quit IRC
2192020-03-23T14:02:55  *** kljasdfvv has quit IRC
2202020-03-23T14:04:03  *** kljasdfvv has joined #bitcoin-core-dev
2212020-03-23T14:11:39  *** kljasdfvv has quit IRC
2222020-03-23T14:12:11  *** apaval has quit IRC
2232020-03-23T14:12:23  *** apaval has joined #bitcoin-core-dev
2242020-03-23T14:13:02  *** kljasdfvv has joined #bitcoin-core-dev
2252020-03-23T14:18:52  *** kljasdfvv has quit IRC
2262020-03-23T14:19:27  *** kljasdfvv has joined #bitcoin-core-dev
2272020-03-23T14:26:01  *** kljasdfvv has quit IRC
2282020-03-23T14:26:25  *** kljasdfvv has joined #bitcoin-core-dev
2292020-03-23T14:27:45  *** promag_ has joined #bitcoin-core-dev
2302020-03-23T14:29:21  <hebasto> promag: mind separating a fix of #18362 from #18338 into its own pr?
2312020-03-23T14:29:23  <gribble> https://github.com/bitcoin/bitcoin/issues/18362 | gui: segfault unloading and immediately reloading wallet with gui · Issue #18362 · bitcoin/bitcoin · GitHub
2322020-03-23T14:29:27  <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
2332020-03-23T14:31:54  *** promag_ has quit IRC
2342020-03-23T14:33:10  *** kljasdfvv has quit IRC
2352020-03-23T14:34:02  *** kljasdfvv has joined #bitcoin-core-dev
2362020-03-23T14:40:14  *** kljasdfvv has quit IRC
2372020-03-23T14:41:30  *** kljasdfvv has joined #bitcoin-core-dev
2382020-03-23T14:48:04  *** kljasdfvv has quit IRC
2392020-03-23T14:48:46  *** AaronvanW has joined #bitcoin-core-dev
2402020-03-23T15:00:01  *** castironpi has quit IRC
2412020-03-23T15:09:42  *** bitcoin-git has joined #bitcoin-core-dev
2422020-03-23T15:09:42  <bitcoin-git> [bitcoin] jnewbery opened pull request #18410: Docs: Improve commenting for coins.cpp|h (master...2020-03-coins-comments) https://github.com/bitcoin/bitcoin/pull/18410
2432020-03-23T15:09:43  *** bitcoin-git has left #bitcoin-core-dev
2442020-03-23T15:12:06  *** kljasdfvv has joined #bitcoin-core-dev
2452020-03-23T15:16:07  *** promag_ has joined #bitcoin-core-dev
2462020-03-23T15:20:05  *** dr-orlovsky has joined #bitcoin-core-dev
2472020-03-23T15:20:46  *** promag_ has quit IRC
2482020-03-23T15:22:21  *** chendo_ has joined #bitcoin-core-dev
2492020-03-23T15:37:04  *** justanotheruser has quit IRC
2502020-03-23T15:38:16  *** berndj has quit IRC
2512020-03-23T15:43:16  *** berndj has joined #bitcoin-core-dev
2522020-03-23T15:44:23  <stevenroose> Are genesis txs included in the txindex?
2532020-03-23T15:44:43  <stevenroose> Is it possible something regarding that changed between 0.17 and 0.18? (I know it's a stretch :p)
2542020-03-23T15:44:49  *** apaval has quit IRC
2552020-03-23T15:45:08  *** apaval has joined #bitcoin-core-dev
2562020-03-23T15:45:13  *** promag has quit IRC
2572020-03-23T15:46:16  *** promag has joined #bitcoin-core-dev
2582020-03-23T15:46:19  *** promag_ has joined #bitcoin-core-dev
2592020-03-23T15:47:58  *** AaronvanW has quit IRC
2602020-03-23T15:48:34  *** captjakk has joined #bitcoin-core-dev
2612020-03-23T15:48:57  *** Kiminuo has quit IRC
2622020-03-23T15:52:54  *** justanotheruser has joined #bitcoin-core-dev
2632020-03-23T15:54:01  <fjahr> stevenroose: You mean the genesis coinbase tx, right? It is not in the utxo set and it should also not be in txindex. It was never indexed by satoshis original software and changing it would be a change in consensus rules, however unlikely it is that that output is spent. So I doubt there were any changes, although I don't know. See also the discussion here: https://github.com/bitcoin/bitcoin/issues/3303
2642020-03-23T15:54:55  <stevenroose> fjahr: k thanks
2652020-03-23T15:55:14  <stevenroose> I know it's not in the UTXO set. But it might have been indexed. But so it appears not.
2662020-03-23T15:58:35  <fjahr> Yeah, it is skipped here: https://github.com/bitcoin/bitcoin/blame/master/src/index/txindex.cpp#L250 The changes you might be referring to are probably the rewrite of the indexing code by jimpo but that should not have changed behavior.
2672020-03-23T16:02:31  <stevenroose> Hmm, ed12d5df1ba52b5ef3dd3799de26bb5e1d3fc654 seems to have introduced that in 2018
2682020-03-23T16:03:23  *** captjakk has quit IRC
2692020-03-23T16:03:41  *** captjakk has joined #bitcoin-core-dev
2702020-03-23T16:04:43  *** roconnor has quit IRC
2712020-03-23T16:05:30  *** shesek has joined #bitcoin-core-dev
2722020-03-23T16:07:00  *** shesek has quit IRC
2732020-03-23T16:07:57  *** shesek has joined #bitcoin-core-dev
2742020-03-23T16:10:41  *** shesek has quit IRC
2752020-03-23T16:10:42  *** shesek has joined #bitcoin-core-dev
2762020-03-23T16:11:03  *** shesek has joined #bitcoin-core-dev
2772020-03-23T16:17:30  *** AaronvanW has joined #bitcoin-core-dev
2782020-03-23T16:18:04  *** captjakk has quit IRC
2792020-03-23T16:18:38  *** captjakk has joined #bitcoin-core-dev
2802020-03-23T16:22:55  *** captjakk has quit IRC
2812020-03-23T16:28:10  *** promag has quit IRC
2822020-03-23T16:29:14  *** bitcoin-git has joined #bitcoin-core-dev
2832020-03-23T16:29:14  <bitcoin-git> [bitcoin] theStack opened pull request #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string (master...20200323-fix-script-err-sig-pushonly-error-message) https://github.com/bitcoin/bitcoin/pull/18412
2842020-03-23T16:29:15  *** bitcoin-git has left #bitcoin-core-dev
2852020-03-23T16:29:57  *** AaronvanW has quit IRC
2862020-03-23T16:37:12  *** promag has joined #bitcoin-core-dev
2872020-03-23T16:41:01  <fjahr> stevenroose: ah, true, interesting. So it was a bug for some amount of time: https://github.com/bitcoin/bitcoin/pull/14085
2882020-03-23T16:42:28  <fjahr> and the blockfilter headers where want made the fix actually get in, TIL
2892020-03-23T16:43:15  <fjahr> s/want/what/
2902020-03-23T16:50:19  *** sipsorcery has quit IRC
2912020-03-23T16:51:06  *** sipsorcery has joined #bitcoin-core-dev
2922020-03-23T16:57:23  *** captjakk has joined #bitcoin-core-dev
2932020-03-23T16:58:58  *** mdunnio has quit IRC
2942020-03-23T16:59:22  *** mdunnio has joined #bitcoin-core-dev
2952020-03-23T16:59:28  *** mdunnio has quit IRC
2962020-03-23T17:00:01  *** mdunnio has joined #bitcoin-core-dev
2972020-03-23T17:04:24  *** mdunnio has quit IRC
2982020-03-23T17:07:52  *** captjakk has quit IRC
2992020-03-23T17:08:15  *** captjakk has joined #bitcoin-core-dev
3002020-03-23T17:12:33  *** captjakk has quit IRC
3012020-03-23T17:12:36  *** AaronvanW has joined #bitcoin-core-dev
3022020-03-23T17:13:15  <gleb> We don't have any shared policy for dns seeder implementations for rate-limiting, do we? There's no expectation that "one client ip will send at most 1 request per minute" or whatever? sipa
3032020-03-23T17:14:50  <sipa> that sounds like a client policy, not a seeder policy.
3042020-03-23T17:15:09  <sipa> as in: the seeder can't prevent people from querying more than once per minite
3052020-03-23T17:15:14  <sipa> *minute
3062020-03-23T17:15:19  *** Kiminuo has joined #bitcoin-core-dev
3072020-03-23T17:15:40  <luke-jr> well, it can ignore floods
3082020-03-23T17:15:47  <luke-jr> no reason for a shared policy on that tho
3092020-03-23T17:16:40  <luke-jr> gleb: also note that clients don't talk to the seed itself; they talk to DNS servers (typically run by their ISP), and that will query and cache from the seed
3102020-03-23T17:17:59  <sipa> honest clienta do :)
3112020-03-23T17:18:08  <gleb> I'm implementing DNS cache invalidation triggering by reachable (thus already known) nodes, and I think it makes sense to query like 10 different services (legacy, segwit, BLOOM), etc.
3122020-03-23T17:18:24  <luke-jr> sipa: you'd need to go out of your way to bypass it and go direct; and there's no benefit in doing so?
3132020-03-23T17:18:45  <gleb> And I was wondering if your seeders would be angry if someone from the same endpoint asks 10 requests at once for different service combinations
3142020-03-23T17:18:55  <sipa> gleb: they wouldn't know
3152020-03-23T17:19:15  <sipa> luke-jr: if you want to DoS attack the seeders, you'd want to connect to them directly i meam
3162020-03-23T17:19:16  <luke-jr> I don't understand why you would do that
3172020-03-23T17:19:20  <luke-jr> sipa: oh, true
3182020-03-23T17:19:58  <gleb> luke-jr: so that private nodes hit early caches more often
3192020-03-23T17:19:58  <sipa> gleb: i don't understanx what you're trying to do, though
3202020-03-23T17:20:11  <gleb> sipa: i think we were discussing this the other day
3212020-03-23T17:20:17  <luke-jr> gleb: I don't get it.
3222020-03-23T17:20:39  <sipa> gleb: DNS seeds should only be queried when addrman is low, as a fallback
3232020-03-23T17:21:24  <sipa> (not as a last resort like hardcoded seeds, but usually nodes shouldn't be contacting them at all if they're run before and have healthy number of connections)
3242020-03-23T17:21:38  <gleb> sipa: or on the first start.
3252020-03-23T17:21:58  <luke-jr> "if they've run before"
3262020-03-23T17:22:30  <sipa> yeah
3272020-03-23T17:23:44  *** emilengler has quit IRC
3282020-03-23T17:24:04  <sipa> i also don't understand why you're querying for multiple services
3292020-03-23T17:24:44  <gleb> sipa: Do you understand why I want to do it in the first place? (ignoring multiple services)
3302020-03-23T17:24:51  <sipa> no
3312020-03-23T17:27:51  *** emilengler has joined #bitcoin-core-dev
3322020-03-23T17:30:25  <gleb> luke-jr Managed to explain this to sipa via quoting greg from that day :)
3332020-03-23T17:30:41  <gleb> "I wonder if listening nodes who are getting incoming connections should randomly query dnsseeds to keep upstream caches primed, but throwing out the results (or comparing to their addrman, logging if there are a bunch of results they don't now about, then throwing away the results).  Those nodes are already not anonymous by virtue of sucessfully
3342020-03-23T17:30:41  <gleb> listening, so they don't gain anything by trying"
3352020-03-23T17:31:14  *** captjakk has joined #bitcoin-core-dev
3362020-03-23T17:32:00  *** Krellan_ has quit IRC
3372020-03-23T17:32:09  <luke-jr> hmm
3382020-03-23T17:32:27  <luke-jr> I don't know if there's actually value to priming caches tho?
3392020-03-23T17:32:41  *** Krellan_ has joined #bitcoin-core-dev
3402020-03-23T17:32:59  <luke-jr> even a few seconds delay querying isn't going to matter..
3412020-03-23T17:33:47  *** emilengler has quit IRC
3422020-03-23T17:34:43  <sipa> luke-jr: it's a privacy gain too, as it means private nodes would reveal less to the seeders, if they're coming from a network with public nodes
3432020-03-23T17:35:39  <gleb> I'd say privacy gain has more value than little latency decrease in this context.
3442020-03-23T17:35:48  *** captjakk has quit IRC
3452020-03-23T17:35:48  <luke-jr> sipa: reveal what?
3462020-03-23T17:35:52  *** mdunnio has joined #bitcoin-core-dev
3472020-03-23T17:36:16  *** molz_ has joined #bitcoin-core-dev
3482020-03-23T17:36:40  <sipa> luke-jr: e.g. the network that the private node is in
3492020-03-23T17:37:01  <sipa> i wouldn't be surprised if more things can be inferred from the DNS query
3502020-03-23T17:37:28  *** Krellan_ has quit IRC
3512020-03-23T17:39:14  *** molly has quit IRC
3522020-03-23T17:40:14  *** mdunnio has quit IRC
3532020-03-23T17:40:42  *** mdunnio has joined #bitcoin-core-dev
3542020-03-23T17:42:04  <luke-jr> sipa: more queries on that same network won't hide it..
3552020-03-23T17:42:26  <sipa> queries from nodes that are already public
3562020-03-23T17:42:52  <luke-jr> the seed doesn't know if they are or aren't..
3572020-03-23T17:45:07  <sipa> ?
3582020-03-23T17:45:20  <sipa> the seed has a database of public IPs already, even when it is honest
3592020-03-23T17:47:08  <luke-jr> what is more queries supposed to do?
3602020-03-23T17:47:56  <sipa> i don't know what there is to explain
3612020-03-23T17:48:02  <sipa> or what you're missing
3622020-03-23T17:48:28  <gleb> sipa: I had the same feeling 10 minute ago with you too :)
3632020-03-23T17:48:40  <luke-jr> the seed knows <DNS server> made a query. <DNS server> serving more clients doesn't tell or conceal from the seed anything
3642020-03-23T17:48:54  <sipa> gleb: well "cache invalidation" was very confusing! there is no cache invalidation going on at all :)
3652020-03-23T17:49:52  <luke-jr> I suppose the querying of more service bit combos might conceal what clients using the DNS server are interested in.. but that's just as easily solved by the client using the DNS seed making multiple queries
3662020-03-23T17:50:04  <luke-jr> (perhaps even more reliably!)
3672020-03-23T17:50:44  <sipa> luke-jr: when a DNS seed sees a query from a DNS server, it has a better than average guess that there is a private node in that DNS server's network
3682020-03-23T17:50:54  *** dr-orlovsky has quit IRC
3692020-03-23T17:51:35  <sipa> if the public nodes in that network keep the cache fresh, that changes to "seeing a query has a high probability of there being either private or public nodes in that network"... but the public nodes are already public
3702020-03-23T17:52:13  <luke-jr> it could already be public or private
3712020-03-23T17:52:36  <luke-jr> oh, except public nodes are already running
3722020-03-23T17:52:58  <luke-jr> not sure that matters actually
3732020-03-23T17:53:04  <sipa> that makes it much stronger (public nodes in general query much less frequently), but I don't think that's actually necessary for the argument
3742020-03-23T17:53:14  <sipa> i think it's still a privacy improvement to private nodes without that
3752020-03-23T17:53:26  <luke-jr> I don't
3762020-03-23T17:54:04  *** captjakk has joined #bitcoin-core-dev
3772020-03-23T17:54:25  <sipa> imagine some networks have just 1 private node; some have just one public node; some have both; right now, assume both query the seed equally frequently
3782020-03-23T17:55:03  <sipa> that means if a seed now sees a query from a DNS server, it has a 50/50 guess about whether there is a private or public node behind it
3792020-03-23T17:55:03  <luke-jr> if there are public nodes on the same DNS-server-network, the seed has no idea if it was one of them already
3802020-03-23T17:55:42  <luke-jr> 50/50 seems like about the best we could hope for?
3812020-03-23T17:55:45  <sipa> if we now change the public nodes to query 10x more frequently, the information the seed gets about whether there is a private node when seeing a query goes down to 10% ish
3822020-03-23T17:55:53  <sipa> luke-jr: no, because the public nodes are already public
3832020-03-23T17:56:08  <sipa> they don't care about hiding their existence
3842020-03-23T17:56:37  <luke-jr> 90/10 means the seed can reliably determine if there is a private node querying..
3852020-03-23T17:56:47  <luke-jr> semi-reliably*
3862020-03-23T17:57:45  *** promag has quit IRC
3872020-03-23T17:57:54  <sipa> how so?
3882020-03-23T17:58:08  *** promag has joined #bitcoin-core-dev
3892020-03-23T17:58:42  *** filchef has joined #bitcoin-core-dev
3902020-03-23T17:59:11  <luke-jr> look at deviations in the query pattern?
3912020-03-23T17:59:52  <luke-jr> and DNS servers without a public node become very obvious
3922020-03-23T18:00:01  *** chendo_ has quit IRC
3932020-03-23T18:01:00  <sipa> sure
3942020-03-23T18:01:09  <sipa> but the ones in a network with public ones are very reliably hidden
3952020-03-23T18:01:30  <luke-jr> hmm, forgot caching is like an hour
3962020-03-23T18:01:57  <luke-jr> I wonder if the private nodes just querying every hour themselves would have the same effect
3972020-03-23T18:02:13  <luke-jr> maybe counter-productive if they're not 24/7 tho
3982020-03-23T18:05:04  *** promag__ has joined #bitcoin-core-dev
3992020-03-23T18:05:04  *** promag_ has quit IRC
4002020-03-23T18:09:40  *** promag has quit IRC
4012020-03-23T18:20:37  *** molz_ has quit IRC
4022020-03-23T18:22:04  *** ski1 has joined #bitcoin-core-dev
4032020-03-23T18:37:12  *** emilengler has joined #bitcoin-core-dev
4042020-03-23T18:42:47  *** Krellan_ has joined #bitcoin-core-dev
4052020-03-23T18:44:09  <moneyball> hi. fyi only 8 people responded "yes" to the survey for still doing a CoreDev virtually. therefore i didn't do any planning around this. obviously if contributors would like to self-organize in small remote groups, by all means.
4062020-03-23T18:48:14  *** owowo has quit IRC
4072020-03-23T18:49:13  *** Krellan_ has quit IRC
4082020-03-23T18:50:54  *** andrewtoth_ has joined #bitcoin-core-dev
4092020-03-23T18:51:23  *** andrewtoth has quit IRC
4102020-03-23T18:53:19  *** owowo has joined #bitcoin-core-dev
4112020-03-23T18:55:18  *** dr-orlovsky has joined #bitcoin-core-dev
4122020-03-23T18:56:23  *** andrewtoth_ has quit IRC
4132020-03-23T19:09:54  *** hajen has joined #bitcoin-core-dev
4142020-03-23T19:11:53  *** promag has joined #bitcoin-core-dev
4152020-03-23T19:18:02  *** promag has quit IRC
4162020-03-23T19:23:12  *** Krellan_ has joined #bitcoin-core-dev
4172020-03-23T19:27:18  *** mol has joined #bitcoin-core-dev
4182020-03-23T19:34:22  *** Krellan_ has quit IRC
4192020-03-23T19:39:39  *** captjakk has quit IRC
4202020-03-23T19:40:06  *** captjakk has joined #bitcoin-core-dev
4212020-03-23T19:40:13  *** hajen has quit IRC
4222020-03-23T19:40:58  *** vasild_ has joined #bitcoin-core-dev
4232020-03-23T19:44:23  *** vasild has quit IRC
4242020-03-23T19:44:24  *** vasild_ is now known as vasild
4252020-03-23T20:07:38  <provoostenator> moneyball: thanks for trying to coordinate! Hopefully we can do an in-person meetup again after the apocalypse.
4262020-03-23T20:15:11  *** sonofhan has joined #bitcoin-core-dev
4272020-03-23T20:15:50  *** Krellan_ has joined #bitcoin-core-dev
4282020-03-23T20:29:17  *** Krellan_ has quit IRC
4292020-03-23T20:33:03  *** bitcoin-git has joined #bitcoin-core-dev
4302020-03-23T20:33:03  <bitcoin-git> [bitcoin] pierreN opened pull request #18413: script: prevent UB when computing abs value for num opcode serialize (master...fix-script-absolute) https://github.com/bitcoin/bitcoin/pull/18413
4312020-03-23T20:33:05  *** bitcoin-git has left #bitcoin-core-dev
4322020-03-23T20:39:18  *** bitcoin-git has joined #bitcoin-core-dev
4332020-03-23T20:39:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/97b0687501ce...ac579ada7e83
4342020-03-23T20:39:20  <bitcoin-git> bitcoin/master 77e4b06 Russell Yanofsky: refactor: Get rid of Wallet::IsWalletFlagSet method
4352020-03-23T20:39:21  <bitcoin-git> bitcoin/master 1c2ab1a Russell Yanofsky: refactor: Rename Node::disconnect methods
4362020-03-23T20:39:22  <bitcoin-git> bitcoin/master 6ceb219 Russell Yanofsky: refactor: Rename Chain::Notifications methods to be consistent with other ...
4372020-03-23T20:39:30  *** bitcoin-git has left #bitcoin-core-dev
4382020-03-23T20:39:48  *** bitcoin-git has joined #bitcoin-core-dev
4392020-03-23T20:39:49  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18278: interfaces: Describe and follow some code conventions (master...pr/ipc-conv) https://github.com/bitcoin/bitcoin/pull/18278
4402020-03-23T20:39:59  *** bitcoin-git has left #bitcoin-core-dev
4412020-03-23T20:44:06  *** roconnor has joined #bitcoin-core-dev
4422020-03-23T20:51:43  *** roconnor has quit IRC
4432020-03-23T20:53:01  *** roconnor has joined #bitcoin-core-dev
4442020-03-23T21:00:01  *** ski1 has quit IRC
4452020-03-23T21:00:35  *** ddustin has joined #bitcoin-core-dev
4462020-03-23T21:05:01  *** ddustin has quit IRC
4472020-03-23T21:14:23  *** BamBaRay36 has quit IRC
4482020-03-23T21:21:50  *** Aaaron1 has joined #bitcoin-core-dev
4492020-03-23T21:27:08  *** emilengler has quit IRC
4502020-03-23T21:27:22  *** emilengler has joined #bitcoin-core-dev
4512020-03-23T21:29:06  *** manantial has quit IRC
4522020-03-23T21:30:22  *** brakmic has joined #bitcoin-core-dev
4532020-03-23T21:36:38  *** Krellan_ has joined #bitcoin-core-dev
4542020-03-23T22:00:42  *** captjakk has quit IRC
4552020-03-23T22:01:26  *** captjakk has joined #bitcoin-core-dev
4562020-03-23T22:12:11  *** timothy has quit IRC
4572020-03-23T22:13:14  *** Krellan_ has quit IRC
4582020-03-23T22:20:00  *** captjakk has quit IRC
4592020-03-23T22:30:04  *** captjakk has joined #bitcoin-core-dev
4602020-03-23T22:30:05  *** Guyver2 has quit IRC
4612020-03-23T22:35:13  *** emilengler has quit IRC
4622020-03-23T22:36:15  *** dr-orlovsky has quit IRC
4632020-03-23T22:40:40  *** mdunnio has quit IRC
4642020-03-23T22:42:16  *** mdunnio has joined #bitcoin-core-dev
4652020-03-23T22:46:41  *** yancy has quit IRC
4662020-03-23T22:47:17  *** mdunnio has quit IRC
4672020-03-23T22:47:19  *** yancy has joined #bitcoin-core-dev
4682020-03-23T22:48:23  *** sonofhan has quit IRC
4692020-03-23T22:50:34  *** Klox has quit IRC
4702020-03-23T22:51:55  *** Klox has joined #bitcoin-core-dev
4712020-03-23T23:00:01  *** apaval has quit IRC
4722020-03-23T23:00:20  *** apaval has joined #bitcoin-core-dev
4732020-03-23T23:03:53  *** filchef has quit IRC
4742020-03-23T23:06:57  *** Emcy has joined #bitcoin-core-dev
4752020-03-23T23:07:42  *** justanotheruser has quit IRC
4762020-03-23T23:08:10  *** lukedashjr has joined #bitcoin-core-dev
4772020-03-23T23:08:14  *** luke-jr has quit IRC
4782020-03-23T23:10:17  *** lukedashjr is now known as luke-jr
4792020-03-23T23:15:39  *** luke-jr has quit IRC
4802020-03-23T23:17:12  *** luke-jr has joined #bitcoin-core-dev
4812020-03-23T23:18:45  *** mdunnio has joined #bitcoin-core-dev
4822020-03-23T23:18:48  *** brakmic_ has joined #bitcoin-core-dev
4832020-03-23T23:21:49  *** brakmic has quit IRC
4842020-03-23T23:23:37  *** mdunnio has quit IRC
4852020-03-23T23:23:57  *** lukedashjr has joined #bitcoin-core-dev
4862020-03-23T23:25:05  *** justanotheruser has joined #bitcoin-core-dev
4872020-03-23T23:25:17  *** luke-jr has quit IRC
4882020-03-23T23:27:05  *** luke-jr has joined #bitcoin-core-dev
4892020-03-23T23:30:34  *** lukedashjr has quit IRC
4902020-03-23T23:31:33  *** lukedashjr has joined #bitcoin-core-dev
4912020-03-23T23:34:28  *** kljasdfvv has quit IRC
4922020-03-23T23:34:46  *** luke-jr- has joined #bitcoin-core-dev
4932020-03-23T23:34:57  *** Chris_Stewart_5 has quit IRC
4942020-03-23T23:35:07  *** kljasdfvv has joined #bitcoin-core-dev
4952020-03-23T23:35:15  *** luke-jr has quit IRC
4962020-03-23T23:38:11  *** luke-jr has joined #bitcoin-core-dev
4972020-03-23T23:38:14  *** lukedashjr has quit IRC
4982020-03-23T23:42:14  *** luke-jr- has quit IRC
4992020-03-23T23:43:06  *** sdaftuar has quit IRC
5002020-03-23T23:43:30  *** sdaftuar has joined #bitcoin-core-dev
5012020-03-23T23:51:50  *** marcoagner has quit IRC
5022020-03-23T23:52:17  *** lukedashjr has joined #bitcoin-core-dev
5032020-03-23T23:54:33  *** mdunnio has joined #bitcoin-core-dev
5042020-03-23T23:55:54  *** luke-jr has quit IRC
5052020-03-23T23:56:33  *** lukedashjr is now known as luke-jr
5062020-03-23T23:59:17  *** mdunnio has quit IRC