12020-04-06T00:00:02 *** kwm1 has quit IRC
22020-04-06T00:12:31 *** ddustin has joined #bitcoin-core-dev
32020-04-06T00:17:47 *** heftig1 has joined #bitcoin-core-dev
42020-04-06T00:25:53 *** paracyst has quit IRC
52020-04-06T00:27:41 *** paracyst has joined #bitcoin-core-dev
62020-04-06T00:51:12 *** TheHoliestRoger has quit IRC
72020-04-06T00:52:03 *** TheHoliestRoger has joined #bitcoin-core-dev
82020-04-06T00:55:50 *** btc4ever has quit IRC
92020-04-06T00:58:12 *** Chris_Stewart_5 has quit IRC
102020-04-06T00:59:19 *** chy has quit IRC
112020-04-06T01:07:59 *** paracyst has quit IRC
122020-04-06T01:11:11 *** paracyst has joined #bitcoin-core-dev
132020-04-06T01:36:33 *** bitcoin-git has joined #bitcoin-core-dev
142020-04-06T01:36:33 <bitcoin-git> [bitcoin] fanquake opened pull request #18534: test: skip backwards compat tests if not compiled with wallet (master...skip_feature_compat_no_wallet) https://github.com/bitcoin/bitcoin/pull/18534
152020-04-06T01:36:44 *** bitcoin-git has left #bitcoin-core-dev
162020-04-06T01:44:02 *** belcher has quit IRC
172020-04-06T01:48:54 *** bitcoin-git has joined #bitcoin-core-dev
182020-04-06T01:48:54 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf21293ef7fd...516ebe8a62de
192020-04-06T01:48:55 <bitcoin-git> bitcoin/master 9e071b0 fanquake: test: remove rapidcheck integration and tests
202020-04-06T01:48:55 <bitcoin-git> bitcoin/master 516ebe8 fanquake: Merge #18514: test: remove rapidcheck integration and tests
212020-04-06T01:48:57 *** bitcoin-git has left #bitcoin-core-dev
222020-04-06T01:49:14 *** bitcoin-git has joined #bitcoin-core-dev
232020-04-06T01:49:14 <bitcoin-git> [bitcoin] fanquake merged pull request #18514: test: remove rapidcheck integration and tests (master...remove_rapidcheck) https://github.com/bitcoin/bitcoin/pull/18514
242020-04-06T01:49:15 *** bitcoin-git has left #bitcoin-core-dev
252020-04-06T01:55:43 *** alec has quit IRC
262020-04-06T01:59:56 *** AaronvanW has quit IRC
272020-04-06T02:10:16 *** captjakk has quit IRC
282020-04-06T02:14:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
292020-04-06T02:18:46 *** meshcollider has quit IRC
302020-04-06T02:23:54 *** Chris_Stewart_5 has quit IRC
312020-04-06T02:24:44 *** meshcollider has joined #bitcoin-core-dev
322020-04-06T02:34:58 *** pinheadmz has quit IRC
332020-04-06T02:46:16 *** pinheadmz has joined #bitcoin-core-dev
342020-04-06T03:00:02 *** heftig1 has quit IRC
352020-04-06T03:18:21 *** freakofmimsy has joined #bitcoin-core-dev
362020-04-06T03:18:44 *** murray_ has quit IRC
372020-04-06T03:21:42 *** AaronvanW has joined #bitcoin-core-dev
382020-04-06T03:34:40 *** EagleTM has joined #bitcoin-core-dev
392020-04-06T03:37:12 *** Eagle[TM] has quit IRC
402020-04-06T03:38:01 *** rjected_ has joined #bitcoin-core-dev
412020-04-06T03:38:02 *** rjected has quit IRC
422020-04-06T03:43:55 *** Guest28075 has joined #bitcoin-core-dev
432020-04-06T03:55:23 *** AaronvanW has quit IRC
442020-04-06T04:07:49 *** justan0theruser is now known as justanotheruser
452020-04-06T04:09:04 *** Guest28075 has quit IRC
462020-04-06T04:20:48 *** captjakk has joined #bitcoin-core-dev
472020-04-06T04:24:35 *** alec has joined #bitcoin-core-dev
482020-04-06T04:25:13 *** luke-jr has quit IRC
492020-04-06T04:25:32 *** captjakk has quit IRC
502020-04-06T04:26:40 *** luke-jr has joined #bitcoin-core-dev
512020-04-06T04:41:38 *** jarthur has joined #bitcoin-core-dev
522020-04-06T04:44:43 *** anditto has joined #bitcoin-core-dev
532020-04-06T05:14:47 *** captjakk has joined #bitcoin-core-dev
542020-04-06T05:19:27 *** captjakk has quit IRC
552020-04-06T05:38:15 *** mryandao has quit IRC
562020-04-06T05:38:55 *** mryandao has joined #bitcoin-core-dev
572020-04-06T05:39:42 *** guest534543 has quit IRC
582020-04-06T05:47:18 *** Kiminuo has joined #bitcoin-core-dev
592020-04-06T05:52:25 *** AaronvanW has joined #bitcoin-core-dev
602020-04-06T05:53:35 *** jarthur has quit IRC
612020-04-06T05:58:09 *** jorijn has quit IRC
622020-04-06T06:00:02 *** freakofmimsy has quit IRC
632020-04-06T06:04:23 *** jorijn has joined #bitcoin-core-dev
642020-04-06T06:12:37 *** shesek has quit IRC
652020-04-06T06:13:02 *** shesek has joined #bitcoin-core-dev
662020-04-06T06:13:02 *** shesek has joined #bitcoin-core-dev
672020-04-06T06:20:51 *** leoburd has joined #bitcoin-core-dev
682020-04-06T06:26:22 *** AaronvanW has quit IRC
692020-04-06T06:41:28 *** mryandao has left #bitcoin-core-dev
702020-04-06T06:42:44 *** anditto has quit IRC
712020-04-06T06:59:09 <fanquake> wumpus / sipa can you block RANDALL-hub
722020-04-06T07:01:59 *** Guyver2 has joined #bitcoin-core-dev
732020-04-06T07:19:49 *** dviola has joined #bitcoin-core-dev
742020-04-06T07:23:06 *** anditto has joined #bitcoin-core-dev
752020-04-06T07:27:45 *** anditto has quit IRC
762020-04-06T07:35:29 *** EagleTM has quit IRC
772020-04-06T07:35:53 *** ddustin_ has joined #bitcoin-core-dev
782020-04-06T07:38:07 *** ddustin has quit IRC
792020-04-06T07:40:11 *** anditto has joined #bitcoin-core-dev
802020-04-06T07:41:05 *** vasild_ has joined #bitcoin-core-dev
812020-04-06T07:42:47 *** manantial has joined #bitcoin-core-dev
822020-04-06T07:44:03 *** vasild has quit IRC
832020-04-06T07:44:04 *** vasild_ is now known as vasild
842020-04-06T07:44:35 *** DeanWeen has quit IRC
852020-04-06T07:45:41 <sipa> fanquake: done
862020-04-06T08:00:34 *** marcoagner has joined #bitcoin-core-dev
872020-04-06T08:01:57 *** bitcoin-git has joined #bitcoin-core-dev
882020-04-06T08:01:57 <bitcoin-git> [bitcoin] fanquake opened pull request #18535: build: remove -Qunused-arguments workaround for clang + ccache (master...dont_quash_unused_driver_arguments) https://github.com/bitcoin/bitcoin/pull/18535
892020-04-06T08:01:58 *** bitcoin-git has left #bitcoin-core-dev
902020-04-06T08:07:18 *** emilengler has joined #bitcoin-core-dev
912020-04-06T08:13:20 *** irc_user826134 has joined #bitcoin-core-dev
922020-04-06T08:23:11 *** AaronvanW has joined #bitcoin-core-dev
932020-04-06T08:28:00 *** kljasdfvv has joined #bitcoin-core-dev
942020-04-06T08:32:25 *** AaronvanW has quit IRC
952020-04-06T08:32:44 *** AaronvanW has joined #bitcoin-core-dev
962020-04-06T08:49:10 *** emilengler has quit IRC
972020-04-06T08:49:28 *** emilengler has joined #bitcoin-core-dev
982020-04-06T08:54:19 *** Talkless has joined #bitcoin-core-dev
992020-04-06T08:57:03 *** sdaftuar_ has quit IRC
1002020-04-06T08:57:28 *** sdaftuar_ has joined #bitcoin-core-dev
1012020-04-06T09:00:01 *** leoburd has quit IRC
1022020-04-06T09:16:36 *** captjakk has joined #bitcoin-core-dev
1032020-04-06T09:17:48 <aj> huh, when trying to reference a pr in github, you can type "#" then some text from the topic and press enter on the one you want, and it'll replace the text you typed with the correct pr number. convenient!
1042020-04-06T09:19:01 <fanquake> very
1052020-04-06T09:20:24 *** feb has joined #bitcoin-core-dev
1062020-04-06T09:20:54 *** captjakk has quit IRC
1072020-04-06T09:21:31 *** dr-orlovsky has joined #bitcoin-core-dev
1082020-04-06T09:33:09 *** anditto has quit IRC
1092020-04-06T09:38:40 *** sonofhan has joined #bitcoin-core-dev
1102020-04-06T09:41:16 *** cajetanp has joined #bitcoin-core-dev
1112020-04-06T09:49:43 *** sdaftuar_ has quit IRC
1122020-04-06T09:50:44 *** sdaftuar_ has joined #bitcoin-core-dev
1132020-04-06T09:52:46 *** cajetanp has quit IRC
1142020-04-06T09:53:52 *** someone235 has joined #bitcoin-core-dev
1152020-04-06T09:56:22 *** hkjn0 has quit IRC
1162020-04-06T10:03:58 *** Miller30Fritsch has joined #bitcoin-core-dev
1172020-04-06T10:11:00 *** anditto has joined #bitcoin-core-dev
1182020-04-06T10:15:37 *** anditto has quit IRC
1192020-04-06T10:27:45 *** midnight has quit IRC
1202020-04-06T10:35:44 *** midnight has joined #bitcoin-core-dev
1212020-04-06T10:35:47 *** sonofhan has quit IRC
1222020-04-06T10:38:16 <wumpus> oh good find!
1232020-04-06T10:47:06 *** midnight has quit IRC
1242020-04-06T10:50:16 *** Miller30Fritsch has quit IRC
1252020-04-06T10:51:16 *** midnight has joined #bitcoin-core-dev
1262020-04-06T10:54:15 *** sipsorcery has joined #bitcoin-core-dev
1272020-04-06T10:57:51 *** timothy has joined #bitcoin-core-dev
1282020-04-06T11:00:00 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1292020-04-06T11:17:22 *** captjakk has joined #bitcoin-core-dev
1302020-04-06T11:22:15 *** captjakk has quit IRC
1312020-04-06T11:28:45 *** dr-orlovsky has quit IRC
1322020-04-06T11:30:15 <wumpus> I guess it's time to branch off and wrap up 0.20.0rc1 today
1332020-04-06T11:31:22 <instagibbs> \o/
1342020-04-06T11:32:26 *** anditto has joined #bitcoin-core-dev
1352020-04-06T11:32:46 *** anditto has quit IRC
1362020-04-06T11:37:09 <luke-jr> wumpus: #18192 has some potential improvements, but also 3 ACKs, so hesitant to touch it - seems better to follow up with the rest in another PR
1372020-04-06T11:37:11 <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
1382020-04-06T11:39:32 *** bitcoin-git has joined #bitcoin-core-dev
1392020-04-06T11:39:33 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/516ebe8a62de...adac12ae73e8
1402020-04-06T11:39:33 <bitcoin-git> bitcoin/master 0eeb046 Wladimir J. van der Laan: net: Hardcoded seeds update for 0.20
1412020-04-06T11:39:34 <bitcoin-git> bitcoin/master adac12a Wladimir J. van der Laan: Merge #18506: net: Hardcoded seeds update for 0.20
1422020-04-06T11:39:36 *** bitcoin-git has left #bitcoin-core-dev
1432020-04-06T11:39:52 *** bitcoin-git has joined #bitcoin-core-dev
1442020-04-06T11:39:52 <bitcoin-git> [bitcoin] laanwj merged pull request #18506: net: Hardcoded seeds update for 0.20 (master...2020_04_hardcoded_seeds) https://github.com/bitcoin/bitcoin/pull/18506
1452020-04-06T11:39:53 *** bitcoin-git has left #bitcoin-core-dev
1462020-04-06T11:41:25 <wumpus> why did #18524 get added to 0.20?
1472020-04-06T11:41:28 <gribble> https://github.com/bitcoin/bitcoin/issues/18524 | refactor: drop boost::signals2 in validationinterface by ryanofsky · Pull Request #18524 · bitcoin/bitcoin · GitHub
1482020-04-06T11:43:00 <wumpus> seems a good change but why do such a (potentialy risky) refactor last-minute before a release
1492020-04-06T11:45:51 <instagibbs> luke-jr, imo adding the test(as new commit) is fine to get merged if 3 acks sans test was enough :)
1502020-04-06T11:51:05 *** ryanofsky_ has left #bitcoin-core-dev
1512020-04-06T11:51:22 *** ryanofsky has joined #bitcoin-core-dev
1522020-04-06T11:51:28 <ryanofsky> wumpus, i don't know if it should be added to 0.20, but it fixes a hang #18517 caused by #18338 that happens with old boost versions
1532020-04-06T11:51:29 <gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
1542020-04-06T11:51:32 <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
1552020-04-06T11:51:33 <ryanofsky> alternative would be to revert #18338
1562020-04-06T11:51:34 <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
1572020-04-06T11:52:38 <wumpus> ryanofsky: let's label it as a bugfix then
1582020-04-06T11:54:31 <ryanofsky> that's fine. it is a refactor with new versions of boost, a bugfix with old versions of boost
1592020-04-06T11:55:09 <wumpus> a fix for a hang caused by a fix for another hang
1602020-04-06T11:55:59 <wumpus> well if it is boost versions that are still supported that's kind of important
1612020-04-06T11:57:28 <wumpus> in any case, independent of that PR, it might be that we don't have enough active reviewers to really do a 0.20 release right now
1622020-04-06T11:58:00 <wumpus> this is what I was afraid of about a month ago
1632020-04-06T11:58:58 <luke-jr> could still spin a rc1
1642020-04-06T11:59:11 <ryanofsky> i would just revert #18517, a bugfix for a rare bug caused a more serious bug, so drop it
1652020-04-06T11:59:12 <gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
1662020-04-06T11:59:28 <ryanofsky> revert #18338 I mean
1672020-04-06T11:59:30 <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
1682020-04-06T12:00:01 *** feb has quit IRC
1692020-04-06T12:00:39 <wumpus> ryanofsky: maybe revert it after the 0.20 branch? then go forward with your PR on master
1702020-04-06T12:02:02 <wumpus> I mean, it still makes sense as a refactor
1712020-04-06T12:02:15 <ryanofsky> i don't know how things are normally done. i'd revert it on master for but some reason bitcoin projects treats reverts as more of a big deal than other projects i've worked on
1722020-04-06T12:03:12 <wumpus> but does your PR solve the original issue that #18338 solved, too?
1732020-04-06T12:03:14 <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
1742020-04-06T12:04:45 <wumpus> it seems that not fixing that issue at all (in master, at least) is strictly worse
1752020-04-06T12:05:17 <ryanofsky> no, my pr is really just a refactor that doesn't change bitcoin behavior. #18338 is an actual bugfix but the implementation relies on behavior only implemented in new boost versions
1762020-04-06T12:05:20 <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
1772020-04-06T12:06:06 <ryanofsky> #18338 is a weird corner case issue that's been around for a few releases, while #18517 is a serious new regression
1782020-04-06T12:06:09 <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
1792020-04-06T12:06:10 <gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
1802020-04-06T12:07:17 <ryanofsky> if you want to fix both reverting won't work, but the issue 18338 fixes is a crash that happens when loading and unloading the same wallet repeatedly in a loop
1812020-04-06T12:08:03 <ryanofsky> the issue 18338 causes is a hang on shutdown with ctrl-c, though only with old boost versions
1822020-04-06T12:09:01 <ryanofsky> reverting might not be appropriate here because we rarely revert
1832020-04-06T12:09:08 <wumpus> yes, so I think reverting the fix for the weird corner case on 0.20 is acceptable to solve the more serious issue there, but if your refactor (which will go into master) solves the ensuing issue I don't see the point of reverting it on master too
1842020-04-06T12:10:19 <wumpus> alternatively we should just merge your PR into 0.20 too
1852020-04-06T12:10:30 <wumpus> I mean it has ACKs, more than some other 0.20-tagged things
1862020-04-06T12:11:18 <ryanofsky> yep, either way is reasonable
1872020-04-06T12:21:55 *** defnordic has joined #bitcoin-core-dev
1882020-04-06T12:33:32 <fanquake> ryanofsky: you donât necessarily need to be loading and unloading in a loop. The wallet crash can happen with just a wallet close/unload.
1892020-04-06T12:35:21 *** dviola has quit IRC
1902020-04-06T12:36:36 *** irc_user826134 has quit IRC
1912020-04-06T12:37:35 *** irc_user826134 has joined #bitcoin-core-dev
1922020-04-06T12:56:51 *** irc_user826134 has quit IRC
1932020-04-06T13:01:15 *** fearbeag has joined #bitcoin-core-dev
1942020-04-06T13:08:40 *** Highway61 has quit IRC
1952020-04-06T13:11:43 *** morcos has quit IRC
1962020-04-06T13:11:52 *** morcos_ has joined #bitcoin-core-dev
1972020-04-06T13:12:17 *** morcos_ is now known as morcos
1982020-04-06T13:15:48 *** Highway61 has joined #bitcoin-core-dev
1992020-04-06T13:25:16 <jonatack> fwiw i'll be reviewing 0
2002020-04-06T13:25:49 <jonatack> prs tagged v0.20 today, priority guidance welcome
2012020-04-06T13:26:08 <jonatack> among the list at https://github.com/bitcoin/bitcoin/milestone/42
2022020-04-06T13:26:11 <luke-jr> zero PRs? :x
2032020-04-06T13:26:29 <jonatack> s/0/0.20/ :x
2042020-04-06T13:28:20 *** promag_ is now known as promag
2052020-04-06T13:29:29 *** bitcoin-git has joined #bitcoin-core-dev
2062020-04-06T13:29:30 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/adac12ae73e8...299544f9c537
2072020-04-06T13:29:30 <bitcoin-git> bitcoin/master c0c43ae fanquake: test: skip backwards compat tests if not compiled with wallet
2082020-04-06T13:29:30 <bitcoin-git> bitcoin/master 299544f MarcoFalke: Merge #18534: test: skip backwards compat tests if not compiled with walle...
2092020-04-06T13:29:31 *** bitcoin-git has left #bitcoin-core-dev
2102020-04-06T13:29:48 *** bitcoin-git has joined #bitcoin-core-dev
2112020-04-06T13:29:49 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18534: test: skip backwards compat tests if not compiled with wallet (master...skip_feature_compat_no_wallet) https://github.com/bitcoin/bitcoin/pull/18534
2122020-04-06T13:29:49 *** bitcoin-git has left #bitcoin-core-dev
2132020-04-06T13:31:05 <jonatack> luke-jr: are you planning to update #18192 (3 acks) with the test addition and review comments?
2142020-04-06T13:31:07 <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
2152020-04-06T13:32:16 <promag> wumpus, ryanofsky: how about updating minimum boost version?
2162020-04-06T13:32:38 <promag> depends uses 1.70.0
2172020-04-06T13:33:05 <luke-jr> jonatack: don't want to lose the ACKs
2182020-04-06T13:33:19 <promag> not against merging ryanofsky refactor
2192020-04-06T13:33:33 <luke-jr> jonatack: feel free to re-ACK the test commit too, though, in case a merge-person wants me to include that
2202020-04-06T13:33:52 <promag> which seems fine btw
2212020-04-06T13:40:59 <fanquake> promag why update minimum boost?
2222020-04-06T13:42:08 <promag> #18517 only happens with boost < 1.59.0
2232020-04-06T13:42:11 <gribble> https://github.com/bitcoin/bitcoin/issues/18517 | [wallet] Node process hangs after SIGINT · Issue #18517 · bitcoin/bitcoin · GitHub
2242020-04-06T13:47:02 *** SiAnDoG_ has quit IRC
2252020-04-06T13:47:24 *** SiAnDoG_ has joined #bitcoin-core-dev
2262020-04-06T13:52:38 <hebasto> promag: #16381
2272020-04-06T13:52:40 <gribble> https://github.com/bitcoin/bitcoin/issues/16381 | Set minimum required Boost to 1.53.0 by hebasto · Pull Request #16381 · bitcoin/bitcoin · GitHub
2282020-04-06T13:54:27 <promag> hebasto: thanks!
2292020-04-06T13:55:51 <hebasto> it seems boost 1.59+ is not a choice for Centos 7 and ubuntu xenial
2302020-04-06T13:56:04 <promag> so from fanquake comment, Jessie, Xenial, Trusty OpenBSD have <1.59 ?
2312020-04-06T13:56:24 <promag> oh and centos7
2322020-04-06T13:57:10 <hebasto> https://packages.ubuntu.com/xenial/libboost-dev
2332020-04-06T13:58:05 *** EagleTM has joined #bitcoin-core-dev
2342020-04-06T13:58:10 <promag> ok ¯\_(ã)_/¯
2352020-04-06T14:08:51 <wumpus> promag: I have a slight preference to solve the problem instead of burying it that way
2362020-04-06T14:10:30 <promag> when you say "solve" you mean ditch boost
2372020-04-06T14:10:55 <wumpus> in the long run but I really meant merging ryanofsky 's refactor/fix
2382020-04-06T14:11:15 <promag> because the problem is solved in boost>1.58
2392020-04-06T14:11:28 <wumpus> but we have that PR already that fixes the problem
2402020-04-06T14:12:17 <promag> yeah, I ack that. just saying that we can hit this problem again in other boost signals2 usage
2412020-04-06T14:12:34 <wumpus> then let's move away from signals2 use
2422020-04-06T14:12:55 <wumpus> I think there's already been movement in that direction in other places
2432020-04-06T14:13:01 <promag> sure sgtm
2442020-04-06T14:14:54 <wumpus> for example, another thing people have een complaining about boost::signals2 is terribly noisy gdb backtraces
2452020-04-06T14:17:04 <wumpus> I only asked why #18524 was added to 0.20 because I was genuinely suprised a refactor was added, that was cleared up quickly, I like the PR itself, I don't particularly think we need an alternative solution
2462020-04-06T14:17:07 <gribble> https://github.com/bitcoin/bitcoin/issues/18524 | refactor: drop boost::signals2 in validationinterface by ryanofsky · Pull Request #18524 · bitcoin/bitcoin · GitHub
2472020-04-06T14:18:41 <promag> yeah, sad behavior change with < 1.59.0
2482020-04-06T14:19:11 *** AaronvanW has quit IRC
2492020-04-06T14:29:31 *** dviola has joined #bitcoin-core-dev
2502020-04-06T14:32:12 *** EagleTM has quit IRC
2512020-04-06T14:38:34 *** Kiminuo has quit IRC
2522020-04-06T14:42:34 *** EagleTM has joined #bitcoin-core-dev
2532020-04-06T14:45:59 *** captjakk has joined #bitcoin-core-dev
2542020-04-06T14:46:43 *** bitcoin-git has joined #bitcoin-core-dev
2552020-04-06T14:46:44 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/299544f9c537...fdeb445a34a9
2562020-04-06T14:46:44 <bitcoin-git> bitcoin/master d6815a2 Russell Yanofsky: refactor: drop boost::signals2 in validationinterface
2572020-04-06T14:46:45 <bitcoin-git> bitcoin/master fdeb445 Wladimir J. van der Laan: Merge #18524: refactor: drop boost::signals2 in validationinterface
2582020-04-06T14:46:47 *** bitcoin-git has left #bitcoin-core-dev
2592020-04-06T14:47:03 *** bitcoin-git has joined #bitcoin-core-dev
2602020-04-06T14:47:03 <bitcoin-git> [bitcoin] laanwj merged pull request #18524: refactor: drop boost::signals2 in validationinterface (master...pr/nosig) https://github.com/bitcoin/bitcoin/pull/18524
2612020-04-06T14:47:04 *** bitcoin-git has left #bitcoin-core-dev
2622020-04-06T14:49:14 *** molly has joined #bitcoin-core-dev
2632020-04-06T14:51:09 <luke-jr> speaking of unnecessary refactors <.<
2642020-04-06T14:51:49 *** EagleTM has quit IRC
2652020-04-06T14:52:25 *** mol has quit IRC
2662020-04-06T14:53:52 *** sdaftuar_ has quit IRC
2672020-04-06T14:54:15 *** sdaftuar_ has joined #bitcoin-core-dev
2682020-04-06T14:55:39 *** jarthur has joined #bitcoin-core-dev
2692020-04-06T14:57:02 *** dr-orlovsky has joined #bitcoin-core-dev
2702020-04-06T14:57:04 <wumpus> this one is necessary, see above discussion
2712020-04-06T14:58:11 *** AaronvanW has joined #bitcoin-core-dev
2722020-04-06T14:58:26 <wumpus> it's a bugfix and should probably have been called that but with so many ACKs it's abad idea to start changing commit messages
2732020-04-06T14:59:17 <luke-jr> ah
2742020-04-06T15:00:00 <luke-jr> I saw that, just didn't make the connection XD
2752020-04-06T15:00:01 *** defnordic has quit IRC
2762020-04-06T15:01:32 *** Aaronvan_ has joined #bitcoin-core-dev
2772020-04-06T15:01:59 *** AaronvanW has quit IRC
2782020-04-06T15:08:18 <ryanofsky> it is a refactor if you're using a new boost version, a change in behavior / bugfix if using an old boost
2792020-04-06T15:10:48 <wumpus> right
2802020-04-06T15:11:13 <wumpus> it's a refactor that moves a potentially buggy dependency out of the way
2812020-04-06T15:20:21 *** jes1 has joined #bitcoin-core-dev
2822020-04-06T15:23:15 *** jarthur has joined #bitcoin-core-dev
2832020-04-06T15:23:47 *** Aaronvan_ is now known as AaronvanW
2842020-04-06T15:28:10 *** molly has quit IRC
2852020-04-06T15:29:13 *** justanotheruser has quit IRC
2862020-04-06T15:37:04 *** bitcoin-git has joined #bitcoin-core-dev
2872020-04-06T15:37:04 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18471: qa: Test shared validation interface (master...2020-03-test-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18471
2882020-04-06T15:37:05 *** bitcoin-git has left #bitcoin-core-dev
2892020-04-06T15:37:24 *** bitcoin-git has joined #bitcoin-core-dev
2902020-04-06T15:37:24 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18471: qa: Test shared validation interface (master...2020-03-test-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18471
2912020-04-06T15:37:25 *** bitcoin-git has left #bitcoin-core-dev
2922020-04-06T15:39:41 *** bitcoin-git has joined #bitcoin-core-dev
2932020-04-06T15:39:42 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fdeb445a34a9...425a7f900ed8
2942020-04-06T15:39:42 <bitcoin-git> bitcoin/master 25e03ba Jon Atack: test: relax bumpfee dust_to_fee txsize an extra vbyte
2952020-04-06T15:39:43 <bitcoin-git> bitcoin/master 425a7f9 MarcoFalke: Merge #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte
2962020-04-06T15:39:45 *** bitcoin-git has left #bitcoin-core-dev
2972020-04-06T15:40:01 *** bitcoin-git has joined #bitcoin-core-dev
2982020-04-06T15:40:01 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18516: test: relax bumpfee dust_to_fee txsize an extra vbyte (master...relax-dust_to_fee-test) https://github.com/bitcoin/bitcoin/pull/18516
2992020-04-06T15:40:02 *** bitcoin-git has left #bitcoin-core-dev
3002020-04-06T15:40:44 *** mol has joined #bitcoin-core-dev
3012020-04-06T15:42:23 *** Pierre25Hilll has joined #bitcoin-core-dev
3022020-04-06T15:48:25 <MarcoFalke> > [04:56] <luke-jr> Is there a reason we don't gitian-sign each individual file in addition to the packaged/tar files?
3032020-04-06T15:48:47 <MarcoFalke> The tar is a concatenation of the individual files, so the signature on it includes the individual files already
3042020-04-06T15:48:57 <MarcoFalke> > [06:25] <luke-jr> right now, we have zero way for users to verify snap installs
3052020-04-06T15:49:01 <MarcoFalke> ^ So this is not true
3062020-04-06T15:49:59 <luke-jr> MarcoFalke: short of redownloading and comparing the tarball binaries..
3072020-04-06T15:50:44 <luke-jr> also see our website
3082020-04-06T15:50:46 <luke-jr> "While the Snap packages use the deterministically generated executables, the Snap tool itself does not provide a streamlined way to reveal the contents of a Snap package. Thus, the Bitcoin Core project does not have the information necessary to help you verify the Bitcoin Core Snap packages."
3092020-04-06T15:51:09 *** bitcoin-git has joined #bitcoin-core-dev
3102020-04-06T15:51:09 <bitcoin-git> [bitcoin] practicalswift opened pull request #18539: Avoid using locale-dependent boost trim functions in RPCAuthorized(â¦) and bitcoin-tx (master...avoid-locale-dependent-trim) https://github.com/bitcoin/bitcoin/pull/18539
3112020-04-06T15:51:10 *** bitcoin-git has left #bitcoin-core-dev
3122020-04-06T15:51:59 *** Pierre25Hilll has quit IRC
3132020-04-06T16:00:49 *** AaronvanW has quit IRC
3142020-04-06T16:04:36 *** setpill has joined #bitcoin-core-dev
3152020-04-06T16:20:46 *** andrewtoth_ has joined #bitcoin-core-dev
3162020-04-06T16:21:23 *** justanotheruser has joined #bitcoin-core-dev
3172020-04-06T16:21:23 *** andrewtoth has quit IRC
3182020-04-06T16:25:36 *** filchef has joined #bitcoin-core-dev
3192020-04-06T16:26:43 *** andrewtoth_ has quit IRC
3202020-04-06T16:34:43 *** Kiminuo has joined #bitcoin-core-dev
3212020-04-06T16:35:08 *** EagleTM has joined #bitcoin-core-dev
3222020-04-06T16:36:50 <wumpus> can we have some more review on #18484 please
3232020-04-06T16:36:51 <gribble> https://github.com/bitcoin/bitcoin/issues/18484 | rpc: Correctly compute redeemScript from witnessScript for signrawtransaction by achow101 · Pull Request #18484 · bitcoin/bitcoin · GitHub
3242020-04-06T16:40:49 *** bitcoin-git has joined #bitcoin-core-dev
3252020-04-06T16:40:49 <bitcoin-git> [bitcoin] jonatack opened pull request #18540: test: wallet_bumpfee assertion fixup (master...bumpfee-test-assertion-fixup) https://github.com/bitcoin/bitcoin/pull/18540
3262020-04-06T16:40:50 *** bitcoin-git has left #bitcoin-core-dev
3272020-04-06T16:49:52 <jonatack> wumpus: thanks, looking at 18484
3282020-04-06T16:55:52 *** AaronvanW has joined #bitcoin-core-dev
3292020-04-06T16:56:03 *** bitcoin-git has joined #bitcoin-core-dev
3302020-04-06T16:56:03 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18541: rpc: Make verifychain default values static, not depend on global args (master...2004-rpcStaticDefaults) https://github.com/bitcoin/bitcoin/pull/18541
3312020-04-06T16:56:04 *** bitcoin-git has left #bitcoin-core-dev
3322020-04-06T16:59:22 <wumpus> thanks! it's a one-line change, apart from test changes
3332020-04-06T17:01:33 *** bitcoin-git has joined #bitcoin-core-dev
3342020-04-06T17:01:34 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/425a7f900ed8...c0b389b33516
3352020-04-06T17:01:34 <bitcoin-git> bitcoin/master cd3b156 Andrew Chow: Correctly compute redeemScript from witnessScript for signrawtransaction
3362020-04-06T17:01:35 <bitcoin-git> bitcoin/master c0b389b MarcoFalke: Merge #18484: rpc: Correctly compute redeemScript from witnessScript for s...
3372020-04-06T17:01:36 *** bitcoin-git has left #bitcoin-core-dev
3382020-04-06T17:01:53 *** bitcoin-git has joined #bitcoin-core-dev
3392020-04-06T17:01:54 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18484: rpc: Correctly compute redeemScript from witnessScript for signrawtransaction (master...signrawtx-p2pkh-p2wsh) https://github.com/bitcoin/bitcoin/pull/18484
3402020-04-06T17:01:55 *** bitcoin-git has left #bitcoin-core-dev
3412020-04-06T17:06:38 *** RubenSomsen_ is now known as RubenSomsen
3422020-04-06T17:07:47 *** andrewtoth has joined #bitcoin-core-dev
3432020-04-06T17:09:31 *** bitcoin-git has joined #bitcoin-core-dev
3442020-04-06T17:09:31 <bitcoin-git> [bitcoin] promag opened pull request #18542: 0.19: gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (0.19...2020-04-backport-18160) https://github.com/bitcoin/bitcoin/pull/18542
3452020-04-06T17:09:32 *** bitcoin-git has left #bitcoin-core-dev
3462020-04-06T17:12:05 <luke-jr> wumpus: how should I wrap up #18192?
3472020-04-06T17:12:08 <gribble> https://github.com/bitcoin/bitcoin/issues/18192 | Bugfix: Wallet: Safely deal with change in the address book by luke-jr · Pull Request #18192 · bitcoin/bitcoin · GitHub
3482020-04-06T17:14:10 *** bitcoin-git has joined #bitcoin-core-dev
3492020-04-06T17:14:10 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18543: test: Properly sync utxo set to avoid race (master...2004-testFixes) https://github.com/bitcoin/bitcoin/pull/18543
3502020-04-06T17:14:11 *** bitcoin-git has left #bitcoin-core-dev
3512020-04-06T17:15:58 *** EagleTM has quit IRC
3522020-04-06T17:16:21 <MarcoFalke> PSA: If you see an (intermittent) test failure, please open a bug report with a link to the log.
3532020-04-06T17:17:19 <MarcoFalke> Just resetting the build will make all intermittent failures accumulate and put the test suite in an unusable state where all failures are ignored and just re-run.
3542020-04-06T17:21:15 <sipa> MarcoFalke: ack
3552020-04-06T17:21:25 <sipa> (i occasionally did reset build failures)
3562020-04-06T17:34:03 *** binarybonanza has joined #bitcoin-core-dev
3572020-04-06T17:48:04 *** modfort has joined #bitcoin-core-dev
3582020-04-06T17:48:10 *** Highway62 has joined #bitcoin-core-dev
3592020-04-06T17:49:07 *** Highway61 has quit IRC
3602020-04-06T17:49:07 *** Highway62 is now known as Highway61
3612020-04-06T17:59:14 *** bitcoin-git has joined #bitcoin-core-dev
3622020-04-06T17:59:15 <bitcoin-git> [bitcoin] theStack opened pull request #18544: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear') (master...20200406-net-limit_bip37_filter_lifetime) https://github.com/bitcoin/bitcoin/pull/18544
3632020-04-06T17:59:16 *** bitcoin-git has left #bitcoin-core-dev
3642020-04-06T18:00:02 *** jes1 has quit IRC
3652020-04-06T18:02:00 *** DeanWeen has joined #bitcoin-core-dev
3662020-04-06T18:05:16 *** wumpus2 has joined #bitcoin-core-dev
3672020-04-06T18:05:17 *** modfort has quit IRC
3682020-04-06T18:06:07 *** nejon_ has joined #bitcoin-core-dev
3692020-04-06T18:07:04 *** timothy has quit IRC
3702020-04-06T18:08:05 *** nejon has quit IRC
3712020-04-06T18:08:05 *** wumpus has quit IRC
3722020-04-06T18:08:05 *** nejon_ is now known as nejon
3732020-04-06T18:08:06 *** wraithm has quit IRC
3742020-04-06T18:08:06 *** jonatack has quit IRC
3752020-04-06T18:08:17 *** jonatack_ has joined #bitcoin-core-dev
3762020-04-06T18:08:55 *** wraithm has joined #bitcoin-core-dev
3772020-04-06T18:16:04 *** DeanWeen has quit IRC
3782020-04-06T18:16:28 *** DeanWeen has joined #bitcoin-core-dev
3792020-04-06T18:22:01 *** FalconKirtaran has joined #bitcoin-core-dev
3802020-04-06T18:23:27 *** bitcoin-git has joined #bitcoin-core-dev
3812020-04-06T18:23:27 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b389b33516...54d5ba3d9cb4
3822020-04-06T18:23:28 <bitcoin-git> bitcoin/master b224b4e Jon Atack: test: wallet_bumpfee assertion fixup
3832020-04-06T18:23:28 <bitcoin-git> bitcoin/master 54d5ba3 MarcoFalke: Merge #18540: test: wallet_bumpfee assertion fixup
3842020-04-06T18:23:30 *** bitcoin-git has left #bitcoin-core-dev
3852020-04-06T18:23:47 *** bitcoin-git has joined #bitcoin-core-dev
3862020-04-06T18:23:47 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18540: test: wallet_bumpfee assertion fixup (master...bumpfee-test-assertion-fixup) https://github.com/bitcoin/bitcoin/pull/18540
3872020-04-06T18:23:49 *** bitcoin-git has left #bitcoin-core-dev
3882020-04-06T18:26:24 *** DeanWeen has quit IRC
3892020-04-06T18:26:45 *** DeanWeen has joined #bitcoin-core-dev
3902020-04-06T18:30:11 *** bitcoin-git has joined #bitcoin-core-dev
3912020-04-06T18:30:11 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54d5ba3d9cb4...75021e80ee44
3922020-04-06T18:30:12 <bitcoin-git> bitcoin/master 7b8e157 João Barbosa: rpc: Fix rpcRunLater race in walletpassphrase
3932020-04-06T18:30:12 <bitcoin-git> bitcoin/master 75021e8 Wladimir J. van der Laan: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase
3942020-04-06T18:30:13 *** bitcoin-git has left #bitcoin-core-dev
3952020-04-06T18:30:31 *** bitcoin-git has joined #bitcoin-core-dev
3962020-04-06T18:30:31 <bitcoin-git> [bitcoin] laanwj merged pull request #18487: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487
3972020-04-06T18:30:32 *** bitcoin-git has left #bitcoin-core-dev
3982020-04-06T18:36:16 *** jarthur has quit IRC
3992020-04-06T18:36:46 *** jarthur has joined #bitcoin-core-dev
4002020-04-06T18:37:34 *** setpill has quit IRC
4012020-04-06T19:01:17 *** EagleTM has joined #bitcoin-core-dev
4022020-04-06T19:03:33 *** captjakk has quit IRC
4032020-04-06T19:04:44 *** dr-orlovsky has quit IRC
4042020-04-06T19:06:51 *** bitcoin-git has joined #bitcoin-core-dev
4052020-04-06T19:06:51 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75021e80ee44...c31bcaf203b5
4062020-04-06T19:06:52 <bitcoin-git> bitcoin/master fa36965 MarcoFalke: net: Add missing cs_vNodes lock
4072020-04-06T19:06:52 <bitcoin-git> bitcoin/master c31bcaf Wladimir J. van der Laan: Merge #18458: net: Add missing cs_vNodes lock
4082020-04-06T19:06:54 *** bitcoin-git has left #bitcoin-core-dev
4092020-04-06T19:07:11 *** bitcoin-git has joined #bitcoin-core-dev
4102020-04-06T19:07:11 <bitcoin-git> [bitcoin] laanwj merged pull request #18458: net: Add missing cs_vNodes lock (master...2003-netLock) https://github.com/bitcoin/bitcoin/pull/18458
4112020-04-06T19:07:12 *** bitcoin-git has left #bitcoin-core-dev
4122020-04-06T19:07:14 *** wumpus2 is now known as wumpus
4132020-04-06T19:09:01 <wumpus> MarcoFalke: I generally do that, unless it's something clearly travis related like a timeout in fetching packages
4142020-04-06T19:13:40 *** bitcoin-git has joined #bitcoin-core-dev
4152020-04-06T19:13:40 <bitcoin-git> [bitcoin] jonatack opened pull request #18545: test: refactor rpc_signrawtransaction and add logging (master...refactor-rpc_signrawtransaction) https://github.com/bitcoin/bitcoin/pull/18545
4162020-04-06T19:13:41 *** bitcoin-git has left #bitcoin-core-dev
4172020-04-06T19:14:54 <wumpus> as it's often is
4182020-04-06T19:15:53 <wumpus> luke-jr: I agree with jnewbery's comment, if there's an actual error return mechanism that's better than asserting
4192020-04-06T19:19:26 <wumpus> I think asserts (and other "crash the program now") should be used in cases the client is really in a unrecoverable, buggy state, I'm not sure that's the case here
4202020-04-06T19:21:27 *** captjakk has joined #bitcoin-core-dev
4212020-04-06T19:27:35 <luke-jr> well, it's a code error if we get there
4222020-04-06T19:32:25 *** captjakk has quit IRC
4232020-04-06T19:40:20 *** jorijn has quit IRC
4242020-04-06T19:40:45 *** jorijn has joined #bitcoin-core-dev
4252020-04-06T19:44:23 *** vasild has quit IRC
4262020-04-06T19:46:16 *** vasild has joined #bitcoin-core-dev
4272020-04-06T19:46:22 *** rjected_ has quit IRC
4282020-04-06T19:47:14 *** rjected has joined #bitcoin-core-dev
4292020-04-06T19:49:00 *** captjakk has joined #bitcoin-core-dev
4302020-04-06T19:50:59 *** jarthur has quit IRC
4312020-04-06T19:52:43 *** bitcoin-git has joined #bitcoin-core-dev
4322020-04-06T19:52:43 <bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/c31bcaf203b5...c5966a87d1fd
4332020-04-06T19:52:44 <bitcoin-git> bitcoin/master b86cd15 Luke Dashjr: scripted-diff: Wallet: Rename mapAddressBook to m_address_book
4342020-04-06T19:52:45 <bitcoin-git> bitcoin/master 144b2f8 Luke Dashjr: Wallet: Require usage of new CAddressBookData::setLabel to change label
4352020-04-06T19:52:45 <bitcoin-git> bitcoin/master 65b6bdc Luke Dashjr: Wallet: Add CAddressBookData::IsChange which returns true iff label has ne...
4362020-04-06T19:52:46 *** bitcoin-git has left #bitcoin-core-dev
4372020-04-06T19:54:17 <luke-jr> doh
4382020-04-06T19:54:32 <luke-jr> I had just done that change >_<
4392020-04-06T19:54:48 *** bitcoin-git has joined #bitcoin-core-dev
4402020-04-06T19:54:48 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18192: Bugfix: Wallet: Safely deal with change in the address book (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18192
4412020-04-06T19:54:49 *** bitcoin-git has left #bitcoin-core-dev
4422020-04-06T19:55:53 <MarcoFalke> Whoopsie
4432020-04-06T19:56:03 <MarcoFalke> Missed the message on IRC
4442020-04-06T19:57:23 <MarcoFalke> At least the three ACKs weren't invalidated ð
4452020-04-06T19:58:30 *** bitcoin-git has joined #bitcoin-core-dev
4462020-04-06T19:58:30 <bitcoin-git> [bitcoin] luke-jr opened pull request #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2] (master...bugfix_addressbook_change) https://github.com/bitcoin/bitcoin/pull/18546
4472020-04-06T19:58:41 *** bitcoin-git has left #bitcoin-core-dev
4482020-04-06T20:02:30 *** jarthur has joined #bitcoin-core-dev
4492020-04-06T20:23:10 *** bitcoin-git has joined #bitcoin-core-dev
4502020-04-06T20:23:10 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c5966a87d1fd...abc145c9a4ae
4512020-04-06T20:23:10 <bitcoin-git> bitcoin/master fa2251d MarcoFalke: test: Use one node to avoid a race due to missing sync in rpc_signrawtrans...
4522020-04-06T20:23:11 <bitcoin-git> bitcoin/master abc145c MarcoFalke: Merge #18543: test: Use one node to avoid a race due to missing sync in rp...
4532020-04-06T20:23:12 *** bitcoin-git has left #bitcoin-core-dev
4542020-04-06T20:23:25 *** bitcoin-git has joined #bitcoin-core-dev
4552020-04-06T20:23:25 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18543: test: Use one node to avoid a race due to missing sync in rpc_signrawtransaction (master...2004-testFixes) https://github.com/bitcoin/bitcoin/pull/18543
4562020-04-06T20:23:26 *** bitcoin-git has left #bitcoin-core-dev
4572020-04-06T20:26:24 *** Krellan_ has quit IRC
4582020-04-06T20:26:27 *** Guyver2 has quit IRC
4592020-04-06T20:26:53 *** Krellan_ has joined #bitcoin-core-dev
4602020-04-06T20:31:36 *** Chris_Stewart_5 has quit IRC
4612020-04-06T20:32:41 *** Krellan_ has quit IRC
4622020-04-06T20:42:03 *** ddustin_ has quit IRC
4632020-04-06T20:42:42 *** ddustin has joined #bitcoin-core-dev
4642020-04-06T20:51:48 *** bitcoin-git has joined #bitcoin-core-dev
4652020-04-06T20:51:48 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18507: test: Check that calling walletpasshprase does not freeze the node (master...2004-qaWalletFreeze) https://github.com/bitcoin/bitcoin/pull/18507
4662020-04-06T20:51:49 *** bitcoin-git has left #bitcoin-core-dev
4672020-04-06T20:54:54 <MarcoFalke> ok, we fixed all bugs! Ship it!?!
4682020-04-06T20:59:48 *** dr-orlovsky has joined #bitcoin-core-dev
4692020-04-06T20:59:54 <sipa> MarcoFalke: do we use -use_value_profile=1 anywhere in fuzzing?
4702020-04-06T21:00:02 *** FalconKirtaran has quit IRC
4712020-04-06T21:02:02 <MarcoFalke> sipa: It is a run-time flag you can enable when searching for seeds. It doesn't help when merely iterating over existing seeds (this is what travis is doing)
4722020-04-06T21:02:17 <sipa> MarcoFalke: sure
4732020-04-06T21:02:43 <sipa> but the seeds we have in in qa-assets directory, are they produced with that option enabled?
4742020-04-06T21:03:18 <MarcoFalke> I didn't know the option exists until you told me about it ;)
4752020-04-06T21:03:31 *** emilengler has quit IRC
4762020-04-06T21:03:36 <sipa> it seems oss-fuzz uses it for a percentage of their runs
4772020-04-06T21:03:43 <sipa> and always when -merge=1'ing
4782020-04-06T21:04:00 <MarcoFalke> oh, hmm
4792020-04-06T21:05:11 <MarcoFalke> We don't so we should maybe fix that: use_value_profile
4802020-04-06T21:05:17 <sipa> with the fuzzer for asmap i've been working on, it seems that without that option, you very quickly converge on a set of seeds where no NEW lines appear anymore (or very rarely)
4812020-04-06T21:06:06 <sipa> my intuition is that for actual testing this option isn't very useful
4822020-04-06T21:06:13 <MarcoFalke> https://github.com/bitcoin/bitcoin/blob/abc145c9a4aef8ec269b7e0a3e9403cff9970fe4/test/fuzz/test_runner.py#L149
4832020-04-06T21:06:20 <MarcoFalke> This is what I wanted to copy-paste
4842020-04-06T21:06:45 <MarcoFalke> For some reason I can only copy one thing with the clipboard and then have to restart :thinking:
4852020-04-06T21:06:55 <sipa> but it may help find "intermediate" fuzzer inputs that have a better chance of being mutated into useful ones
4862020-04-06T21:08:02 *** manantial has quit IRC
4872020-04-06T21:08:39 <MarcoFalke> Yes, I suspect it should help with structs that have state and already full line coverage
4882020-04-06T21:09:28 <sipa> the default feature set tracker (without -use_value_profile) is already much wider than just coverage in the typical sense, i believe
4892020-04-06T21:09:36 <sipa> use_value_profile expands it further
4902020-04-06T21:14:28 <luke-jr> ugh, moving on, I'm beginning to question that address book bugfix (it's still safe/good, but not something we can rely on really)
4912020-04-06T21:16:47 *** jarthur has quit IRC
4922020-04-06T21:18:51 *** jarthur has joined #bitcoin-core-dev
4932020-04-06T21:20:35 <MarcoFalke> Just used use_value_profile on a toy example and it seems to slow down the fuzzing and make it take longer to find my hidden crash. Obviously my toy example isn't representative, but it shouldn't be enabled for all searches.
4942020-04-06T21:21:13 <sipa> agree
4952020-04-06T21:21:31 *** nevada-smith has joined #bitcoin-core-dev
4962020-04-06T21:21:41 *** dr-orlovsky has quit IRC
4972020-04-06T21:28:48 *** jarthur has quit IRC
4982020-04-06T21:34:26 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4992020-04-06T21:40:39 *** jarthur has joined #bitcoin-core-dev
5002020-04-06T21:42:25 *** Krellan_ has joined #bitcoin-core-dev
5012020-04-06T21:42:40 <sipa> ryanofsky: making sure you don't miss this: https://github.com/bitcoin/bitcoin/pull/18524/files#r404395685
5022020-04-06T21:44:26 <ryanofsky> thanks, will fix
5032020-04-06T21:47:31 *** bitcoin-git has joined #bitcoin-core-dev
5042020-04-06T21:47:31 <bitcoin-git> [bitcoin] hebasto opened pull request #18549: qt: Fix Window -> Minimize menu item (master...20200406-fix-minimize) https://github.com/bitcoin/bitcoin/pull/18549
5052020-04-06T21:47:36 *** bitcoin-git has left #bitcoin-core-dev
5062020-04-06T21:48:14 *** Talkless has quit IRC
5072020-04-06T21:48:43 *** sdaftuar_ has quit IRC
5082020-04-06T21:49:12 *** Krellan_ has quit IRC
5092020-04-06T21:49:52 <hebasto> promag: ^
5102020-04-06T21:51:37 *** sdaftuar_ has joined #bitcoin-core-dev
5112020-04-06T21:53:47 *** Chris_Stewart_5 has quit IRC
5122020-04-06T21:59:00 *** filchef has quit IRC
5132020-04-06T22:09:20 *** dviola has quit IRC
5142020-04-06T22:11:13 *** dviola has joined #bitcoin-core-dev
5152020-04-06T22:11:52 *** wullon has quit IRC
5162020-04-06T22:13:28 *** wullon has joined #bitcoin-core-dev
5172020-04-06T22:28:15 *** provoostenator has quit IRC
5182020-04-06T22:28:56 *** provoostenator has joined #bitcoin-core-dev
5192020-04-06T22:35:19 *** Krellan_ has joined #bitcoin-core-dev
5202020-04-06T22:42:17 *** Krellan_ has quit IRC
5212020-04-06T22:56:14 *** justanotheruser has quit IRC
5222020-04-06T22:57:23 *** captjakk has quit IRC
5232020-04-06T23:02:15 *** luke-jr has quit IRC
5242020-04-06T23:02:36 *** luke-jr has joined #bitcoin-core-dev
5252020-04-06T23:06:10 *** captjakk has joined #bitcoin-core-dev
5262020-04-06T23:08:27 *** murray has joined #bitcoin-core-dev
5272020-04-06T23:08:50 *** murray is now known as Guest73993
5282020-04-06T23:10:51 *** SiAnDoG__ has joined #bitcoin-core-dev
5292020-04-06T23:11:20 *** SiAnDoG_ has quit IRC
5302020-04-06T23:12:40 *** owowo has quit IRC
5312020-04-06T23:13:18 *** justanotheruser has joined #bitcoin-core-dev
5322020-04-06T23:14:05 *** Guest73993 has left #bitcoin-core-dev
5332020-04-06T23:14:07 *** Krellan_ has joined #bitcoin-core-dev
5342020-04-06T23:14:40 *** murrayn has joined #bitcoin-core-dev
5352020-04-06T23:18:04 *** owowo has joined #bitcoin-core-dev
5362020-04-06T23:18:04 *** owowo has joined #bitcoin-core-dev
5372020-04-06T23:21:22 *** Krellan_ has quit IRC
5382020-04-06T23:23:04 *** captjakk has quit IRC
5392020-04-06T23:23:18 *** marcoagner has quit IRC
5402020-04-06T23:32:29 *** ddustin has quit IRC
5412020-04-06T23:40:31 *** bitcoin-git has joined #bitcoin-core-dev
5422020-04-06T23:40:31 <bitcoin-git> [bitcoin] luke-jr opened pull request #18550: Store destdata for change in separate key for backward compatibility (master...changedata) https://github.com/bitcoin/bitcoin/pull/18550
5432020-04-06T23:40:44 *** bitcoin-git has left #bitcoin-core-dev
5442020-04-06T23:41:07 <luke-jr> ^ this feels like it really needs tests, but I'm not sure what the best way to do that is, since it's all about compatibility with older versions
5452020-04-06T23:51:25 *** Krellan_ has joined #bitcoin-core-dev