12020-04-17T00:00:01  *** [42]1 has quit IRC
  22020-04-17T00:04:26  *** justanotheruser has quit IRC
  32020-04-17T00:22:19  *** justanotheruser has joined #bitcoin-core-dev
  42020-04-17T00:22:20  *** kbrosnan1 has joined #bitcoin-core-dev
  52020-04-17T00:23:35  *** captjakk has quit IRC
  62020-04-17T00:24:48  *** mol has quit IRC
  72020-04-17T00:37:33  *** shaunsun has quit IRC
  82020-04-17T01:22:33  *** bitdex has quit IRC
  92020-04-17T01:23:10  *** promag has quit IRC
 102020-04-17T01:25:05  *** Chris_Stewart_5 has quit IRC
 112020-04-17T01:27:55  *** mol has joined #bitcoin-core-dev
 122020-04-17T01:33:37  *** promag has joined #bitcoin-core-dev
 132020-04-17T01:38:14  *** promag has quit IRC
 142020-04-17T02:05:23  *** bitdex has joined #bitcoin-core-dev
 152020-04-17T02:33:48  *** jarthur has joined #bitcoin-core-dev
 162020-04-17T02:36:24  *** Highway61 has quit IRC
 172020-04-17T03:00:01  *** kbrosnan1 has quit IRC
 182020-04-17T03:04:56  *** TheHoliestRoger has quit IRC
 192020-04-17T03:07:22  *** TheHoliestRoger has joined #bitcoin-core-dev
 202020-04-17T03:15:41  *** bitcoin-git has joined #bitcoin-core-dev
 212020-04-17T03:15:41  <bitcoin-git> [bitcoin] fanquake closed pull request #18661: Compress PNG images with `zopflipng`. (master...master) https://github.com/bitcoin/bitcoin/pull/18661
 222020-04-17T03:15:42  *** bitcoin-git has left #bitcoin-core-dev
 232020-04-17T03:22:27  *** Fare has joined #bitcoin-core-dev
 242020-04-17T03:22:50  *** Fare is now known as Guest44683
 252020-04-17T03:27:49  *** btc_thc has quit IRC
 262020-04-17T03:29:57  *** btc_thc has joined #bitcoin-core-dev
 272020-04-17T04:09:59  *** tryphe_ has joined #bitcoin-core-dev
 282020-04-17T04:13:13  *** tryphe has quit IRC
 292020-04-17T04:30:28  *** promag__ has quit IRC
 302020-04-17T04:33:45  *** promag has joined #bitcoin-core-dev
 312020-04-17T04:38:11  *** promag has quit IRC
 322020-04-17T04:41:21  *** mol has quit IRC
 332020-04-17T04:55:01  *** Talkless has joined #bitcoin-core-dev
 342020-04-17T04:56:03  *** Talkless has quit IRC
 352020-04-17T05:10:26  *** endogenic has quit IRC
 362020-04-17T05:10:27  *** NicolasDorier has quit IRC
 372020-04-17T05:10:31  *** icota[m] has quit IRC
 382020-04-17T05:10:31  *** mrostecki has quit IRC
 392020-04-17T05:10:32  *** _flow_ has quit IRC
 402020-04-17T05:10:32  *** jkczyz has quit IRC
 412020-04-17T05:10:32  *** akionak_ has quit IRC
 422020-04-17T05:10:32  *** thaumavorio_ has quit IRC
 432020-04-17T05:10:32  *** mr_burdell has quit IRC
 442020-04-17T05:15:04  *** endogenic has joined #bitcoin-core-dev
 452020-04-17T05:15:04  *** NicolasDorier has joined #bitcoin-core-dev
 462020-04-17T05:15:04  *** icota[m] has joined #bitcoin-core-dev
 472020-04-17T05:15:04  *** mrostecki has joined #bitcoin-core-dev
 482020-04-17T05:15:04  *** jkczyz has joined #bitcoin-core-dev
 492020-04-17T05:15:04  *** _flow_ has joined #bitcoin-core-dev
 502020-04-17T05:15:04  *** akionak_ has joined #bitcoin-core-dev
 512020-04-17T05:15:04  *** thaumavorio_ has joined #bitcoin-core-dev
 522020-04-17T05:15:04  *** mr_burdell has joined #bitcoin-core-dev
 532020-04-17T05:18:50  *** CubicEarth has quit IRC
 542020-04-17T05:20:32  *** CubicEarth has joined #bitcoin-core-dev
 552020-04-17T05:23:51  *** Guest44683 has quit IRC
 562020-04-17T05:25:14  *** DeanWeen has quit IRC
 572020-04-17T05:26:19  *** DeanWeen has joined #bitcoin-core-dev
 582020-04-17T05:30:00  *** APrOn has joined #bitcoin-core-dev
 592020-04-17T05:32:06  *** jarthur has quit IRC
 602020-04-17T05:54:10  *** DeanWeen has quit IRC
 612020-04-17T05:54:20  *** DeanWeen has joined #bitcoin-core-dev
 622020-04-17T05:57:04  *** mytwocentimes has quit IRC
 632020-04-17T05:57:20  *** mytwocentimes has joined #bitcoin-core-dev
 642020-04-17T05:59:28  *** Highway61 has joined #bitcoin-core-dev
 652020-04-17T06:00:02  *** APrOn has quit IRC
 662020-04-17T06:19:07  *** sdaftuar has quit IRC
 672020-04-17T06:19:08  *** SiAnDoG_ has quit IRC
 682020-04-17T06:19:28  *** SiAnDoG_ has joined #bitcoin-core-dev
 692020-04-17T06:20:53  *** sdaftuar has joined #bitcoin-core-dev
 702020-04-17T06:21:04  *** alorente has joined #bitcoin-core-dev
 712020-04-17T06:32:03  *** sdaftuar has quit IRC
 722020-04-17T06:37:35  *** sdaftuar has joined #bitcoin-core-dev
 732020-04-17T06:43:17  *** ponrpclog has joined #bitcoin-core-dev
 742020-04-17T06:45:04  *** ponrpclog has quit IRC
 752020-04-17T06:57:38  *** mol has joined #bitcoin-core-dev
 762020-04-17T07:03:31  *** Highway61 has quit IRC
 772020-04-17T07:04:43  *** sdaftuar has quit IRC
 782020-04-17T07:07:01  *** sdaftuar has joined #bitcoin-core-dev
 792020-04-17T07:16:41  *** EagleTM has joined #bitcoin-core-dev
 802020-04-17T07:27:03  *** bitdex has quit IRC
 812020-04-17T07:27:47  *** EagleTM has quit IRC
 822020-04-17T07:29:19  *** bitdex has joined #bitcoin-core-dev
 832020-04-17T07:32:36  *** jarthur has joined #bitcoin-core-dev
 842020-04-17T07:36:23  *** brakmic has joined #bitcoin-core-dev
 852020-04-17T07:36:47  *** SiAnDoG__ has joined #bitcoin-core-dev
 862020-04-17T07:37:00  *** SiAnDoG_ has quit IRC
 872020-04-17T07:37:26  *** jarthur has quit IRC
 882020-04-17T07:41:12  *** vasild_ has joined #bitcoin-core-dev
 892020-04-17T07:44:23  *** vasild has quit IRC
 902020-04-17T07:44:24  *** vasild_ is now known as vasild
 912020-04-17T08:02:45  *** mytwocentimes has quit IRC
 922020-04-17T08:09:13  *** jarthur has joined #bitcoin-core-dev
 932020-04-17T08:12:55  *** promag has joined #bitcoin-core-dev
 942020-04-17T08:13:26  *** jarthur has quit IRC
 952020-04-17T08:25:43  *** marcoagner has joined #bitcoin-core-dev
 962020-04-17T08:36:00  *** timothy has joined #bitcoin-core-dev
 972020-04-17T08:46:30  *** mytwocentimes has joined #bitcoin-core-dev
 982020-04-17T08:58:14  *** mol has quit IRC
 992020-04-17T09:00:02  *** alorente has quit IRC
1002020-04-17T09:01:06  *** unruly247 has quit IRC
1012020-04-17T09:01:25  *** mol has joined #bitcoin-core-dev
1022020-04-17T09:07:04  *** promag_ has joined #bitcoin-core-dev
1032020-04-17T09:09:19  *** jarthur has joined #bitcoin-core-dev
1042020-04-17T09:14:10  *** jarthur has quit IRC
1052020-04-17T09:18:50  *** emilengler has joined #bitcoin-core-dev
1062020-04-17T09:21:27  *** icota[m] has left #bitcoin-core-dev
1072020-04-17T09:22:05  *** jeremybennett has joined #bitcoin-core-dev
1082020-04-17T09:22:07  *** icota[m] has joined #bitcoin-core-dev
1092020-04-17T09:28:48  *** icota[m] has left #bitcoin-core-dev
1102020-04-17T09:29:51  *** icota has joined #bitcoin-core-dev
1112020-04-17T09:33:28  *** unruly247 has joined #bitcoin-core-dev
1122020-04-17T09:42:34  *** kristapsk has quit IRC
1132020-04-17T09:42:45  *** kristapsk has joined #bitcoin-core-dev
1142020-04-17T09:43:59  *** icota has quit IRC
1152020-04-17T09:44:45  *** icota[m] has joined #bitcoin-core-dev
1162020-04-17T10:03:55  *** Eliezer30Halvors has joined #bitcoin-core-dev
1172020-04-17T10:31:10  <hebasto> wumpus: if reasons for minimal libevent version 2.0.22 are unsure, it seems unsafe to allow build against 2.0.21, no?
1182020-04-17T10:32:49  <wumpus> as MarcoFalke says we have already allowed it forever
1192020-04-17T10:32:51  <wumpus> it works
1202020-04-17T10:32:55  *** bitcoin-git has joined #bitcoin-core-dev
1212020-04-17T10:32:56  <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/969ee8549496...0856c1570679
1222020-04-17T10:32:56  <bitcoin-git> bitcoin/master 9b5950d Andrew Chow: bnb: exit selection when best_waste is 0
1232020-04-17T10:32:56  <wumpus> you are breaking it with your PR
1242020-04-17T10:32:57  <bitcoin-git> bitcoin/master 0856c15 Samuel Dobson: Merge #18262: bnb: exit selection when best_waste is 0
1252020-04-17T10:32:58  *** bitcoin-git has left #bitcoin-core-dev
1262020-04-17T10:33:25  *** bitcoin-git has joined #bitcoin-core-dev
1272020-04-17T10:33:25  <bitcoin-git> [bitcoin] meshcollider merged pull request #18262: bnb: exit selection when best_waste is 0 (master...bnb-waste-zero) https://github.com/bitcoin/bitcoin/pull/18262
1282020-04-17T10:33:26  *** bitcoin-git has left #bitcoin-core-dev
1292020-04-17T10:33:28  <wumpus> unless you intend to come up with a reason for that, which none of us really know for sure, that's hard to defend
1302020-04-17T10:33:44  <hebasto> wumpus: ok, going to set minimum to 2.0.21
1312020-04-17T10:34:14  *** Eliezer30Halvors has quit IRC
1322020-04-17T10:34:28  <wumpus> thanks! if the fuzz test really turns out to be a problem to make compatible, you could just #ifdef it out for that version
1332020-04-17T10:35:10  <wumpus> but I don't know the error message they get
1342020-04-17T10:36:03  *** promag has quit IRC
1352020-04-17T10:38:14  *** promag has joined #bitcoin-core-dev
1362020-04-17T10:39:19  *** mytwocentimes has quit IRC
1372020-04-17T10:41:42  <wumpus> so that's why I recommended to enable building the fuzz tests on the xenial travis run so we can see
1382020-04-17T10:42:45  *** mytwocentimes has joined #bitcoin-core-dev
1392020-04-17T10:44:34  <wumpus> I see I still have a xenial VM myself, will try...
1402020-04-17T10:45:23  *** icota has joined #bitcoin-core-dev
1412020-04-17T10:47:06  *** icota has joined #bitcoin-core-dev
1422020-04-17T10:49:25  <icota> has anyone tried compiling libbitcoind.so since https://github.com/bitcoin/bitcoin/pull/5084 ?
1432020-04-17T10:49:48  <icota> i'm trying to use the rdynamic trick
1442020-04-17T10:50:06  <icota> i configure with: LDFLAGS='-rdynamic' --disable-reduce-exports --disable-tests --disable-bench --enable-debug --with-utils=no --with-gui=no --enable-shared
1452020-04-17T10:50:15  <icota> but i can't link my hello world against the resulting binary
1462020-04-17T10:51:05  *** bitcoin-git has joined #bitcoin-core-dev
1472020-04-17T10:51:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0856c1570679...4a71c469058b
1482020-04-17T10:51:06  <bitcoin-git> bitcoin/master 69ffddc Sebastian Falbesoner: refactor: Remove unused methods CBloomFilter::reset()/clear()
1492020-04-17T10:51:07  <bitcoin-git> bitcoin/master 4a71c46 MarcoFalke: Merge #18670: refactor: Remove unused methods CBloomFilter::reset()/clear(...
1502020-04-17T10:51:08  *** bitcoin-git has left #bitcoin-core-dev
1512020-04-17T10:51:15  <theStack> ad libevent 2.0.21: the problem is that the fuzz test http_request calls functions from libevent that are not part from the API, i.e. internal functions: evhttp_parse_firstline_
1522020-04-17T10:51:24  <emilengler> icota: Can you send a link to a pastebin with the error message?
1532020-04-17T10:51:25  *** bitcoin-git has joined #bitcoin-core-dev
1542020-04-17T10:51:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18670: refactor: Remove unused methods CBloomFilter::reset()/clear() (master...20200416-refactor-remove-unused-bloom-filter-reset) https://github.com/bitcoin/bitcoin/pull/18670
1552020-04-17T10:51:26  *** bitcoin-git has left #bitcoin-core-dev
1562020-04-17T10:52:05  <theStack> and those functions are named slightly different on libevent 2.0.21, the last underline is missing (at least on my system, ubuntu xenial)
1572020-04-17T10:52:08  <icota> emilengler: sure thing, https://pastebin.com/EmKEZcuP
1582020-04-17T10:52:20  <icota> it seems to be exporting std::cout amongst other symbols
1592020-04-17T10:52:26  <icota> i'd like to play with this. any clever way to stop it from exporting stdlib symbols?
1602020-04-17T10:53:21  <emilengler> icota: Can you try `LD_RUN_PATH=. g++ test.cpp -l:bitcoind -L.`
1612020-04-17T10:53:53  <icota> emilengler: same error
1622020-04-17T10:53:56  <emilengler> Maybe the problem is the argument order in your g++ invoke
1632020-04-17T10:54:08  <emilengler> `LD_RUN_PATH=. g++ test.cpp -L .-l:bitcoind`
1642020-04-17T10:54:23  <emilengler> Oh, please put a space between the dot before invoking -l
1652020-04-17T10:54:32  <emilengler> Mistake on my side...
1662020-04-17T10:54:53  <emilengler> Also is the colon required? I never saw a colon when invoking -l
1672020-04-17T10:55:00  <icota> no worries
1682020-04-17T10:55:20  <icota> colon is because the binary doesn't have a conventional name
1692020-04-17T10:55:25  <icota> libwhatever.so
1702020-04-17T10:55:31  <icota> it finds it, hence the erro
1712020-04-17T10:55:32  <icota> r
1722020-04-17T10:59:20  <meshcollider> what do we do with changes like #18466 which is API breaking
1732020-04-17T10:59:22  <gribble> https://github.com/bitcoin/bitcoin/issues/18466 | rpc: fix invalid parameter error codes for {sign,verify}message RPCs by theStack · Pull Request #18466 · bitcoin/bitcoin · GitHub
1742020-04-17T11:01:26  <meshcollider> The change looks correct but I also suspect we have to just keep incorrect error codes as-is
1752020-04-17T11:08:25  *** bitcoin-git has joined #bitcoin-core-dev
1762020-04-17T11:08:26  <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4a71c469058b...c189bfd260ca
1772020-04-17T11:08:26  <bitcoin-git> bitcoin/master 1abbdac Fabian Jahr: wallet: Prefer full destination groups in coin selection
1782020-04-17T11:08:27  <bitcoin-git> bitcoin/master a2324e4 Fabian Jahr: test: Improve naming and logging of avoid_reuse tests
1792020-04-17T11:08:28  <bitcoin-git> bitcoin/master c189bfd Samuel Dobson: Merge #17824: wallet: Prefer full destination groups in coin selection
1802020-04-17T11:08:30  *** bitcoin-git has left #bitcoin-core-dev
1812020-04-17T11:09:12  <wumpus> theStack: thanks, that sounds easy to work around with an ifdef at least then :)
1822020-04-17T11:09:15  *** bitcoin-git has joined #bitcoin-core-dev
1832020-04-17T11:09:15  <bitcoin-git> [bitcoin] meshcollider merged pull request #17824: wallet: Prefer full destination groups in coin selection (master...i17603) https://github.com/bitcoin/bitcoin/pull/17824
1842020-04-17T11:09:17  *** bitcoin-git has left #bitcoin-core-dev
1852020-04-17T11:09:40  <wumpus> meshcollider: if it's minor things, just mention it in the release notes
1862020-04-17T11:10:01  *** jarthur has joined #bitcoin-core-dev
1872020-04-17T11:11:34  <wumpus> (and in this case it is, I don't have much of an optinion on the PR itself looks like it slightly improves consistency, though, no one has written strong guidelines when to use what RPC error code)
1882020-04-17T11:12:45  <meshcollider> Yeah, alright
1892020-04-17T11:12:51  <theStack> wumpus: yes, a preprocessor check should solve the problem for libevent 2.0.21
1902020-04-17T11:13:04  <meshcollider> promag: what's the status of #18471
1912020-04-17T11:13:06  <gribble> https://github.com/bitcoin/bitcoin/issues/18471 | qa: Test shared validation interface by promag · Pull Request #18471 · bitcoin/bitcoin · GitHub
1922020-04-17T11:13:31  <meshcollider> You asked for 0.20 milestone a while back, is it still important?
1932020-04-17T11:14:43  *** jarthur has quit IRC
1942020-04-17T11:15:52  <wumpus> I'm really wondering about https://github.com/bitcoin/bitcoin/issues/18652#issuecomment-614646655
1952020-04-17T11:16:42  <wumpus> what in libc was blocking thread-local support, I have been unable to figure this out, compiled a few small C++ programs using __thread but didn't see any libc dependencies appear
1962020-04-17T11:18:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1972020-04-17T11:20:31  *** unruly247 has quit IRC
1982020-04-17T11:21:29  <wumpus> the only tls-related libc function I could find is " __tls_get_addr@GLIBC_2.3", which would suggest libc 2.3
1992020-04-17T11:34:30  *** bitcoin-git has joined #bitcoin-core-dev
2002020-04-17T11:34:30  <bitcoin-git> [bitcoin] laanwj opened pull request #18681: donotmerge: build: Enable thread-local with glibc compat (master...2020_04_thread_local_compat) https://github.com/bitcoin/bitcoin/pull/18681
2012020-04-17T11:34:31  *** bitcoin-git has left #bitcoin-core-dev
2022020-04-17T11:35:50  <fanquake> wumpus: I haven’t gone back to read the old threads, but a gitian build sounds like a good idea
2032020-04-17T11:36:17  <wumpus> right, probably most efficient way to find out :)
2042020-04-17T11:37:41  <fanquake> In regards to libevent 2.0.21. Also tried to find all the old discussion, my gut feeling was bugs that we were trying to avoid, maybe shutdown related. Haven’t got anything conclusive though
2052020-04-17T11:38:39  <fanquake> It's also possible in the mean time that we've done refactorings such that those concerns are no longer relevant.
2062020-04-17T11:39:08  <wumpus> given that everyone with xenial has been building against 2.0.21 and we got, afaik, zero complaints about that (besides the fuzzer build issue), it can't be *that* bad
2072020-04-17T11:40:15  <wumpus> yes, that's possible too
2082020-04-17T11:54:04  <wumpus> it highlights that it's kind of important to document *why* something is the minimum version somewhere, sure, it's always possible to find it between reams of commits and github comments, but for older projects that gets less and less efficient
2092020-04-17T11:54:52  <wumpus> #8639 does that ofcourse for most deps
2102020-04-17T11:54:53  <gribble> https://github.com/bitcoin/bitcoin/issues/8639 | Docs: Minimum required dependencies and current CVEs · Issue #8639 · bitcoin/bitcoin · GitHub
2112020-04-17T11:55:36  <wumpus> and in the case of libevent i'm sure no CVE was involved
2122020-04-17T11:58:05  *** bitcoin-git has joined #bitcoin-core-dev
2132020-04-17T11:58:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c189bfd260ca...c2e53ff064df
2142020-04-17T11:58:07  <bitcoin-git> bitcoin/master bda84a0 Fabian Jahr: rpc: Add documentation for deactivating settxfee
2152020-04-17T11:58:07  <bitcoin-git> bitcoin/master 3867727 Fabian Jahr: rpc: settxfee respects -maxtxfee wallet setting
2162020-04-17T11:58:08  <bitcoin-git> bitcoin/master c2e53ff MarcoFalke: Merge #18467: rpc: Improve documentation and return value of settxfee
2172020-04-17T11:58:18  *** bitcoin-git has left #bitcoin-core-dev
2182020-04-17T11:58:35  *** bitcoin-git has joined #bitcoin-core-dev
2192020-04-17T11:58:36  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18467: rpc: Improve documentation and return value of settxfee (master...txfee0) https://github.com/bitcoin/bitcoin/pull/18467
2202020-04-17T11:58:42  *** bitcoin-git has left #bitcoin-core-dev
2212020-04-17T12:00:01  *** jeremybennett has quit IRC
2222020-04-17T12:00:32  <hebasto> theStack: on xenial trying to replicate compiling bug for fuzzing code. Currently, configure returns error: checking whether C++ compiler accepts -fsanitize=fuzzer,address,undefined... no
2232020-04-17T12:00:48  <hebasto> did you encounter it?
2242020-04-17T12:01:30  <hebasto> having system clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
2252020-04-17T12:07:11  <theStack> hebasto: i only tried with clang-8 so far, where the configure script didn't cause problems
2262020-04-17T12:07:48  <hebasto> theStack: ok, going to upgrade clang :)
2272020-04-17T12:09:05  <wumpus> clang-8 is a xenial package?
2282020-04-17T12:10:16  <theStack> wumpus: yup, seems like that: https://packages.ubuntu.com/search?suite=xenial&keywords=clang-8
2292020-04-17T12:11:26  *** Highway61 has joined #bitcoin-core-dev
2302020-04-17T12:20:43  <theStack> i found out that libevent 2.1.1-alpha was the first release with internal functions renamed with underscore suffix
2312020-04-17T12:20:46  <theStack> see upcoming PR
2322020-04-17T12:21:01  *** cassier has joined #bitcoin-core-dev
2332020-04-17T12:21:11  *** bitcoin-git has joined #bitcoin-core-dev
2342020-04-17T12:21:11  <bitcoin-git> [bitcoin] theStack opened pull request #18682: fuzz: http_request workaround for libevent < 2.1.1 (master...20200417-fuzz-http-req-workaround-for-older-libevent) https://github.com/bitcoin/bitcoin/pull/18682
2352020-04-17T12:21:13  *** bitcoin-git has left #bitcoin-core-dev
2362020-04-17T12:43:03  <hebasto> it seems GH has connection issues. Or just for me?
2372020-04-17T12:55:40  *** icota has quit IRC
2382020-04-17T13:03:45  *** bitcoin-git has joined #bitcoin-core-dev
2392020-04-17T13:03:45  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18683: ci: Disable valgrind functionl tests on forked repos to avoid timeouts (master...2004-ciTravisNoTimeout) https://github.com/bitcoin/bitcoin/pull/18683
2402020-04-17T13:03:46  *** bitcoin-git has left #bitcoin-core-dev
2412020-04-17T13:10:44  *** jarthur has joined #bitcoin-core-dev
2422020-04-17T13:11:36  *** Highway61 has quit IRC
2432020-04-17T13:12:07  *** Highway61 has joined #bitcoin-core-dev
2442020-04-17T13:12:18  *** bitcoin-git has joined #bitcoin-core-dev
2452020-04-17T13:12:18  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2e53ff064df...ecc2e4e363ee
2462020-04-17T13:12:19  <bitcoin-git> bitcoin/master eab7367 Jon Atack: fuzz: fix unused variable compiler warning
2472020-04-17T13:12:19  <bitcoin-git> bitcoin/master ecc2e4e MarcoFalke: Merge #18664: fuzz: fix unused variable compiler warning
2482020-04-17T13:12:21  *** bitcoin-git has left #bitcoin-core-dev
2492020-04-17T13:12:38  *** bitcoin-git has joined #bitcoin-core-dev
2502020-04-17T13:12:38  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18664: fuzz: fix unused variable compiler warning (master...fix-unused-variable-warning) https://github.com/bitcoin/bitcoin/pull/18664
2512020-04-17T13:12:39  *** bitcoin-git has left #bitcoin-core-dev
2522020-04-17T13:14:16  *** Guyver2 has joined #bitcoin-core-dev
2532020-04-17T13:15:21  *** jarthur has quit IRC
2542020-04-17T13:19:27  *** kljasdfvv has quit IRC
2552020-04-17T13:19:29  <hebasto> wow! we have "Needs Guix build" label now. cool :)
2562020-04-17T13:41:35  *** geforce04 has joined #bitcoin-core-dev
2572020-04-17T13:43:10  *** bitcoin-git has joined #bitcoin-core-dev
2582020-04-17T13:43:10  <bitcoin-git> [bitcoin] jnewbery closed pull request #17562: Validation: Remove ConnectTrace and PerBlockConnectTrace (master...2019-11-remove-connect-trace) https://github.com/bitcoin/bitcoin/pull/17562
2592020-04-17T13:43:10  *** hebasto has quit IRC
2602020-04-17T13:43:11  *** bitcoin-git has left #bitcoin-core-dev
2612020-04-17T13:44:48  <promag> meshcollider: thanks for taking a look, needs rebase. don't worry
2622020-04-17T13:47:04  *** hebasto has joined #bitcoin-core-dev
2632020-04-17T13:55:22  *** mol_ has joined #bitcoin-core-dev
2642020-04-17T13:57:33  *** molz_ has joined #bitcoin-core-dev
2652020-04-17T13:58:34  *** mol has quit IRC
2662020-04-17T14:00:03  *** mol_ has quit IRC
2672020-04-17T14:02:24  *** molz_ has quit IRC
2682020-04-17T14:14:38  *** bitcoin-git has joined #bitcoin-core-dev
2692020-04-17T14:14:40  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ecc2e4e363ee...54f812d9d298
2702020-04-17T14:14:40  <bitcoin-git> bitcoin/master fac5c37 MarcoFalke: scripted-diff: Sort test includes
2712020-04-17T14:14:41  <bitcoin-git> bitcoin/master fa488f1 MarcoFalke: scripted-diff: Bump copyright headers
2722020-04-17T14:14:43  <bitcoin-git> bitcoin/master fa4632c MarcoFalke: test: Move boost/stdlib includes last
2732020-04-17T14:14:44  *** bitcoin-git has quit IRC
2742020-04-17T14:14:57  *** bitcoin-git has joined #bitcoin-core-dev
2752020-04-17T14:14:58  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18673: scripted-diff: Sort test includes (master...2004-testSortIncludes) https://github.com/bitcoin/bitcoin/pull/18673
2762020-04-17T14:14:59  *** bitcoin-git has left #bitcoin-core-dev
2772020-04-17T14:26:31  *** sdaftuar has quit IRC
2782020-04-17T14:26:52  *** sdaftuar has joined #bitcoin-core-dev
2792020-04-17T14:32:35  *** Guyver2_ has joined #bitcoin-core-dev
2802020-04-17T14:34:24  *** mdunnio has joined #bitcoin-core-dev
2812020-04-17T14:35:22  *** Guyver2 has quit IRC
2822020-04-17T14:35:42  *** Dean_Guss has joined #bitcoin-core-dev
2832020-04-17T14:36:14  *** DeanWeen has quit IRC
2842020-04-17T14:36:25  <MarcoFalke> Does anyone run the tests locally? Is anyone seeing failures in wallet_dump?
2852020-04-17T14:36:50  <MarcoFalke> via the test_runner.py
2862020-04-17T14:40:04  *** mytwocentimes has quit IRC
2872020-04-17T14:40:32  *** bitcoin-git has joined #bitcoin-core-dev
2882020-04-17T14:40:32  <bitcoin-git> [bitcoin] jnewbery opened pull request #18685: [validation] Simplify ConnectTrace (master...2020-04-connecttrace-simplify) https://github.com/bitcoin/bitcoin/pull/18685
2892020-04-17T14:40:33  *** bitcoin-git has left #bitcoin-core-dev
2902020-04-17T14:40:51  *** mytwocentimes has joined #bitcoin-core-dev
2912020-04-17T14:43:57  *** mytwocentimes has quit IRC
2922020-04-17T14:44:14  *** mytwocentimes has joined #bitcoin-core-dev
2932020-04-17T14:45:45  *** someone235 has joined #bitcoin-core-dev
2942020-04-17T14:51:00  *** grunch__ has joined #bitcoin-core-dev
2952020-04-17T14:51:33  *** Talkless has joined #bitcoin-core-dev
2962020-04-17T14:55:40  <jonatack> MarcoFalke: I run them locally. Rerunning now on master.
2972020-04-17T14:56:54  <MarcoFalke> They reproducibly fail for me, so either no one is running the tests or everyone has horribly slow machines or no one reports test failures
2982020-04-17T14:57:24  <MarcoFalke> They are broken for the last 3 days or so
2992020-04-17T14:57:56  *** jarthur has joined #bitcoin-core-dev
3002020-04-17T15:00:01  *** cassier has quit IRC
3012020-04-17T15:03:48  <jonatack> yup it fails line 161
3022020-04-17T15:04:10  <jonatack> first run both via the runner and directly calling it
3032020-04-17T15:16:14  *** pmuir has joined #bitcoin-core-dev
3042020-04-17T15:25:16  *** Guyver2__ has joined #bitcoin-core-dev
3052020-04-17T15:28:25  *** Guyver2_ has quit IRC
3062020-04-17T15:29:45  *** justanotheruser has quit IRC
3072020-04-17T15:30:37  *** alko89 has quit IRC
3082020-04-17T15:37:51  <MarcoFalke> Anyway, the fix is here: #18641
3092020-04-17T15:37:52  <gribble> https://github.com/bitcoin/bitcoin/issues/18641 | test: Create cached blocks not in the future by MarcoFalke · Pull Request #18641 · bitcoin/bitcoin · GitHub
3102020-04-17T15:43:45  *** grunch__ has quit IRC
3112020-04-17T15:47:26  *** justanotheruser has joined #bitcoin-core-dev
3122020-04-17T16:00:51  *** mol has joined #bitcoin-core-dev
3132020-04-17T16:06:00  *** promag has quit IRC
3142020-04-17T16:07:25  *** setpill has joined #bitcoin-core-dev
3152020-04-17T16:16:26  *** promag has joined #bitcoin-core-dev
3162020-04-17T16:17:55  <hebasto> wumpus: sipa: could block TBAALi-ros on GH ?
3172020-04-17T16:18:55  *** bitcoin-git has joined #bitcoin-core-dev
3182020-04-17T16:18:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/54f812d9d298...244daa482151
3192020-04-17T16:18:56  <bitcoin-git> bitcoin/master fa86a4b MarcoFalke: rpc: Rename first arg of generateblock RPC to "output"
3202020-04-17T16:18:57  <bitcoin-git> bitcoin/master fa5b1f0 MarcoFalke: rpc: Document all aliases for second arg of getblock
3212020-04-17T16:18:57  <bitcoin-git> bitcoin/master fa168d7 MarcoFalke: rpc: Document all aliases for first arg of listtransactions
3222020-04-17T16:18:58  *** bitcoin-git has left #bitcoin-core-dev
3232020-04-17T16:19:15  *** bitcoin-git has joined #bitcoin-core-dev
3242020-04-17T16:19:16  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18607: rpc: Fix named arguments in documentation (master...2004-rpcDoc) https://github.com/bitcoin/bitcoin/pull/18607
3252020-04-17T16:19:16  *** bitcoin-git has left #bitcoin-core-dev
3262020-04-17T16:21:10  *** promag has quit IRC
3272020-04-17T16:26:57  *** promag has joined #bitcoin-core-dev
3282020-04-17T16:34:14  *** promag has quit IRC
3292020-04-17T16:36:56  *** mytwocentimes has quit IRC
3302020-04-17T16:37:22  <dongcarl> Did we ever reach a conclusion about PPA organization?
3312020-04-17T16:42:53  *** _andrewtoth_ has joined #bitcoin-core-dev
3322020-04-17T16:43:23  *** andrewtoth_ has quit IRC
3332020-04-17T16:47:03  *** _andrewtoth_ has quit IRC
3342020-04-17T16:49:28  *** jarthur has quit IRC
3352020-04-17T16:50:01  *** jarthur has joined #bitcoin-core-dev
3362020-04-17T16:51:36  *** mytwocentimes has joined #bitcoin-core-dev
3372020-04-17T16:56:03  *** mytwocentimes has quit IRC
3382020-04-17T16:59:10  *** promag has joined #bitcoin-core-dev
3392020-04-17T17:03:43  *** promag has quit IRC
3402020-04-17T17:03:54  *** kinlo has quit IRC
3412020-04-17T17:06:40  *** Highway61 has quit IRC
3422020-04-17T17:12:26  *** mytwocentimes has joined #bitcoin-core-dev
3432020-04-17T17:14:32  *** grunch__ has joined #bitcoin-core-dev
3442020-04-17T17:14:47  *** bitcoin-git has joined #bitcoin-core-dev
3452020-04-17T17:14:48  <bitcoin-git> [bitcoin] hebasto opened pull request #18686: Fix -Wsign-compare warning on ARM 32-bit (master...200417-arm-sign) https://github.com/bitcoin/bitcoin/pull/18686
3462020-04-17T17:14:57  *** bitcoin-git has left #bitcoin-core-dev
3472020-04-17T17:16:33  *** pinheadmz_ has joined #bitcoin-core-dev
3482020-04-17T17:18:53  *** promag has joined #bitcoin-core-dev
3492020-04-17T17:19:27  *** pinheadmz has quit IRC
3502020-04-17T17:20:38  *** pinheadmz has joined #bitcoin-core-dev
3512020-04-17T17:21:14  *** pinheadmz_ has quit IRC
3522020-04-17T17:22:02  *** bitcoin-git has joined #bitcoin-core-dev
3532020-04-17T17:22:03  <bitcoin-git> [bitcoin] hebasto closed pull request #18686: Fix -Wsign-compare warning on ARM 32-bit (master...200417-arm-sign) https://github.com/bitcoin/bitcoin/pull/18686
3542020-04-17T17:22:14  *** bitcoin-git has left #bitcoin-core-dev
3552020-04-17T17:23:40  *** promag has quit IRC
3562020-04-17T17:26:16  *** Chris_Stewart_5 has quit IRC
3572020-04-17T17:26:26  *** pinheadmz_ has joined #bitcoin-core-dev
3582020-04-17T17:27:04  *** pinheadmz has quit IRC
3592020-04-17T17:27:04  *** pinheadmz_ is now known as pinheadmz
3602020-04-17T17:28:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3612020-04-17T17:40:20  *** Highway61 has joined #bitcoin-core-dev
3622020-04-17T17:48:07  *** setpill has quit IRC
3632020-04-17T17:57:20  *** theStack has quit IRC
3642020-04-17T17:57:59  *** Kiminuo has quit IRC
3652020-04-17T17:58:18  *** Kiminuo has joined #bitcoin-core-dev
3662020-04-17T18:00:02  *** pmuir has quit IRC
3672020-04-17T18:02:16  *** bitcoin-git has joined #bitcoin-core-dev
3682020-04-17T18:02:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/244daa482151...d7bdba460cc0
3692020-04-17T18:02:16  <bitcoin-git> bitcoin/master faceeae MarcoFalke: ci: Disable valgrind functionl tests on forked repos to avoid timeouts
3702020-04-17T18:02:17  <bitcoin-git> bitcoin/master d7bdba4 MarcoFalke: Merge #18683: ci: Disable valgrind functionl tests on forked repos to avoi...
3712020-04-17T18:02:18  *** bitcoin-git has left #bitcoin-core-dev
3722020-04-17T18:02:36  *** bitcoin-git has joined #bitcoin-core-dev
3732020-04-17T18:02:36  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18683: ci: Disable valgrind functionl tests on forked repos to avoid timeouts (master...2004-ciTravisNoTimeout) https://github.com/bitcoin/bitcoin/pull/18683
3742020-04-17T18:02:37  *** bitcoin-git has left #bitcoin-core-dev
3752020-04-17T18:06:41  *** bitcoin-git has joined #bitcoin-core-dev
3762020-04-17T18:06:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7bdba460cc0...c54295c1a206
3772020-04-17T18:06:42  <bitcoin-git> bitcoin/master fa32097 MarcoFalke: test: Create cached blocks not in the future
3782020-04-17T18:06:42  <bitcoin-git> bitcoin/master c54295c MarcoFalke: Merge #18641: test: Create cached blocks not in the future
3792020-04-17T18:06:44  *** bitcoin-git has left #bitcoin-core-dev
3802020-04-17T18:07:01  *** bitcoin-git has joined #bitcoin-core-dev
3812020-04-17T18:07:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18641: test: Create cached blocks not in the future (master...2004-qaNoCacheFuture) https://github.com/bitcoin/bitcoin/pull/18641
3822020-04-17T18:07:02  *** bitcoin-git has left #bitcoin-core-dev
3832020-04-17T18:12:06  *** geforce04 has quit IRC
3842020-04-17T18:15:25  *** commavir has quit IRC
3852020-04-17T18:15:48  *** commavir has joined #bitcoin-core-dev
3862020-04-17T18:27:13  <sipa> fanquake: deleted comments from and blocked jasdeep9899
3872020-04-17T18:40:44  *** Emcy has quit IRC
3882020-04-17T18:41:16  *** Emcy has joined #bitcoin-core-dev
3892020-04-17T18:47:38  *** Seyaryuki has joined #bitcoin-core-dev
3902020-04-17T18:52:15  <midnight> go sipa \o/
3912020-04-17T19:02:17  *** Emcy has quit IRC
3922020-04-17T19:03:25  *** EagleTM has joined #bitcoin-core-dev
3932020-04-17T19:09:05  *** Emcy has joined #bitcoin-core-dev
3942020-04-17T19:38:04  *** bitcoin-git has joined #bitcoin-core-dev
3952020-04-17T19:38:04  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18688: fuzz: Merge in parallel (master...2004-fuzzPar) https://github.com/bitcoin/bitcoin/pull/18688
3962020-04-17T19:38:05  *** bitcoin-git has left #bitcoin-core-dev
3972020-04-17T19:40:58  *** bitcoin-git has joined #bitcoin-core-dev
3982020-04-17T19:40:58  <bitcoin-git> [bitcoin] pierreN opened pull request #18689: rpc: allow dumptxoutset to dump human-readable data (master...feature-utxo-ascii) https://github.com/bitcoin/bitcoin/pull/18689
3992020-04-17T19:40:59  *** bitcoin-git has left #bitcoin-core-dev
4002020-04-17T19:41:12  *** vasild_ has joined #bitcoin-core-dev
4012020-04-17T19:44:23  *** vasild has quit IRC
4022020-04-17T19:44:24  *** vasild_ is now known as vasild
4032020-04-17T20:00:15  *** kinlo has joined #bitcoin-core-dev
4042020-04-17T20:01:54  *** pinheadmz_ has joined #bitcoin-core-dev
4052020-04-17T20:04:56  *** pinheadmz has quit IRC
4062020-04-17T20:04:57  *** pinheadmz_ is now known as pinheadmz
4072020-04-17T20:14:41  *** bitcoin-git has joined #bitcoin-core-dev
4082020-04-17T20:14:41  <bitcoin-git> [bitcoin] robot-visions opened pull request #18690: test: Check object hashes in wait_for_getdata (master...wait-for-getdata) https://github.com/bitcoin/bitcoin/pull/18690
4092020-04-17T20:14:42  *** bitcoin-git has left #bitcoin-core-dev
4102020-04-17T20:37:52  *** bitcoin-git has joined #bitcoin-core-dev
4112020-04-17T20:37:53  <bitcoin-git> [bitcoin] jonatack opened pull request #18691: test: fix intermittent error in interface_bitcoin_cli (master...fix-intermittent-credentials-issue) https://github.com/bitcoin/bitcoin/pull/18691
4122020-04-17T20:37:54  *** bitcoin-git has left #bitcoin-core-dev
4132020-04-17T20:38:44  *** captjakk has joined #bitcoin-core-dev
4142020-04-17T20:41:51  <captjakk> Currently the behavior of Bitcoin Core in a pruned state is to return an RPC error when a block is requested that has been pruned. I was thinking about working on a change that would allow Core to dynamically fetch a block it didn't have, and verify it against the retained headers. This ultimately implies a slight implementation change to the peer protocol, but at first glance this seems harmless and potentially very helpful
4152020-04-17T20:41:51  <captjakk> as we get to larger numbers of applications/protocols that depend on core. Does anyone know of a reason this would be bad?
4162020-04-17T20:43:55  <gwillen> that's kind of interesting. I'm not an expert so you should wait for one of those to chime in, but I expect this sort of thing mostly doesn't exist due to lack of demand?
4172020-04-17T20:44:53  <gwillen> you would need a more complicated scheme for managing pruning if you have random old blocks lying around because an RPC client wanted them, you'd want some kind of cacheing or pinning scheme, presumably you'd need new RPCs to implement that (not just make it implicit, it's too expensive an operation for that I think)
4182020-04-17T20:45:32  <captjakk> Here's why we want it. At Start9 We are building the Embassy which allows you to run a pruned node quite easily. Archives are necessary for some and helpful for everyone, but we want to make it such that running a full node that is usable by various wallets today does not necessitate full archives/txindex
4192020-04-17T20:46:05  <gwillen> I think it's rare to want single old blocks, do you have a specific place that's coming up?
4202020-04-17T20:46:18  <captjakk> Here's the situation
4212020-04-17T20:46:40  <captjakk> say you have a full node synced from genesis but it's pruned to only keep 5GB of data
4222020-04-17T20:47:25  <captjakk> if you want to add a new application, say, c-lightning, you either require a resync or it needs to be able to register itself with core to inform core to retain all blocks newer than a certain height
4232020-04-17T20:47:31  <captjakk> OR
4242020-04-17T20:47:42  <captjakk> it would need to be able to dynamically fetch a block that had been pruned
4252020-04-17T20:48:01  <captjakk> my understanding is that currently pruned nodes keep ALL block headers
4262020-04-17T20:48:09  <captjakk> even if the associated blocks have been long since purged
4272020-04-17T20:48:31  <sipa> <opinionated mode> applications that require access to historical blocks are broken, except for debugging/emergency recovery situations
4282020-04-17T20:48:44  <captjakk> even for new syncs?
4292020-04-17T20:48:59  <gwillen> well "new syncs" are why I asked about "random" blocks specifically
4302020-04-17T20:49:04  <sipa> a new wallet doesn't need access to old blocks, because its keys are new
4312020-04-17T20:49:32  <captjakk> OK so dynamic fetching may be unnecessarily expensive here
4322020-04-17T20:49:33  <gwillen> also, isn't "retain all blocks after a certain height" in fact already supported in RPC
4332020-04-17T20:49:41  <sipa> that said, i see no technical reason why implementing your suggestion would be a problem
4342020-04-17T20:49:44  <gwillen> so you might already have what you need
4352020-04-17T20:49:46  <captjakk> it needs to support it from multiple dependents
4362020-04-17T20:50:19  <captjakk> if I want both C-lightning and wasabi to share a full node, they need a way to deconflict the specification of which old blocks they need
4372020-04-17T20:50:42  <sipa> captjakk: there is a recently opened issue about multiple applications being able to register they need blocks, and letting them individually declare to be done up to block X
4382020-04-17T20:51:04  <captjakk> do you know what number? or the name of the rpc call?
4392020-04-17T20:51:28  <captjakk> (proposed)
4402020-04-17T20:51:30  <gwillen> for reference the mentioned issue is https://github.com/bitcoin/bitcoin/issues/18599
4412020-04-17T20:51:47  <captjakk> This was opened by my brother, I am the other commenter :)
4422020-04-17T20:51:57  <captjakk> captjakk == ProofOfKeags
4432020-04-17T20:52:03  <captjakk> haven't changed my irc handle yet
4442020-04-17T20:52:07  <gwillen> ah! hah.
4452020-04-17T20:52:43  <captjakk> But either way, great!
4462020-04-17T20:52:54  <captjakk> We are more than happy to develop this proposal/code it up
4472020-04-17T20:52:58  <gwillen> this seems like it may be a "patches accepted" situation -- that is, it's probably not too hard to write 'keepheight', but you might have to do it if you want it
4482020-04-17T20:53:14  <captjakk> I just wanted to check in to see if it may be controversial
4492020-04-17T20:53:17  <sipa> gwillen: well there already exists manual pruning mode
4502020-04-17T20:53:26  <sipa> where you need to issue an RPC to prune
4512020-04-17T20:53:35  <sipa> the issue is that this is "single user"
4522020-04-17T20:53:40  <captjakk> correct
4532020-04-17T20:53:48  <gwillen> right, so it seems like modifying it to track multiple "pins" wouldn't be too complex
4542020-04-17T20:53:48  <captjakk> because it pruning is done via positiva
4552020-04-17T20:53:56  <captjakk> great
4562020-04-17T20:54:07  <captjakk> again, we're happy to code it up
4572020-04-17T20:54:21  *** emilengler has quit IRC
4582020-04-17T20:54:36  <sipa> patches welcome, as far as i'm concerned
4592020-04-17T20:54:41  <captjakk> cool!
4602020-04-17T20:56:41  <gwillen> I don't know if you've worked in the bitcoin core tree before, but in addition to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md I highly recommend looking around under /doc/, especially /doc/productivity.md .
4612020-04-17T20:57:20  <captjakk> This will be the first code contributions we've made
4622020-04-17T20:57:44  <captjakk> so yes, any info on how to do this from a process standpoint is appreciated
4632020-04-17T20:58:08  <gwillen> cool, definitely read through CONTRIBUTING.md, whatever links from it look relevant, plus productivity.md, which has some big time-saving tips in it
4642020-04-17T20:58:35  *** captjakk is now known as proofofkeags
4652020-04-17T20:58:49  <jonatack> good tips. also don't miss doc/developer-notes.md
4662020-04-17T20:59:07  <gwillen> honestly the whole 'doc' folder is good to skim for stuff that appears relevant
4672020-04-17T20:59:30  <gwillen> also I would consider fleshing out your proposed RPC interface and detailing it on the issue thread before you start coding too much, so people can comment on the design
4682020-04-17T20:59:40  <proofofkeags> yeah I figured
4692020-04-17T20:59:45  <gwillen> (probably come back here with a link once you have that)
4702020-04-17T21:00:01  *** Seyaryuki has quit IRC
4712020-04-17T21:00:06  <proofofkeags> is this something that should be detailed in the issue, or does it warrant a Bip
4722020-04-17T21:00:17  <proofofkeags> seems that since it's limited to RPC the bip isn't necessary
4732020-04-17T21:00:31  <proofofkeags> but I'm not sure what heuristic is used for bips
4742020-04-17T21:01:27  <sipa> proofofkeags: BIPs == things that require cross-application standards
4752020-04-17T21:01:37  <sipa> i don't think that's applicable here
4762020-04-17T21:02:00  <proofofkeags> cool, makes sense
4772020-04-17T21:02:22  *** drbonez has joined #bitcoin-core-dev
4782020-04-17T21:02:24  <proofofkeags> so any change or addition to the peer protocol or address schemes and the like
4792020-04-17T21:02:46  *** Guyver2__ has quit IRC
4802020-04-17T21:03:41  *** bitcoin-git has joined #bitcoin-core-dev
4812020-04-17T21:03:41  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #18692: test: Bump timeout in wallet_import_rescan (master...2004-qaBumpTimeout) https://github.com/bitcoin/bitcoin/pull/18692
4822020-04-17T21:03:42  <sipa> P2P protocol changes, consensus changes, address formats, but also general things like standard derivation paths for keys, ...
4832020-04-17T21:03:42  *** bitcoin-git has left #bitcoin-core-dev
4842020-04-17T21:03:51  <sipa> there is a BIP for the "bits" denomination
4852020-04-17T21:04:00  <proofofkeags> lol, I suppose that's fair
4862020-04-17T21:04:31  <sipa> changes to the BIP process itself (BIP 1, BIP 2)
4872020-04-17T21:05:54  <proofofkeags> cool, thanks for the input y'all
4882020-04-17T21:07:10  <yevaud> for a rare one, BIP50 is a report, not a change.
4892020-04-17T21:08:06  <sipa> ah, indeed
4902020-04-17T21:08:18  <yevaud> an incorrect report, but one none the less.
4912020-04-17T21:12:06  *** bitdex has quit IRC
4922020-04-17T21:12:36  <proofofkeags> incorrect how?
4932020-04-17T21:13:13  *** proofofkeags has quit IRC
4942020-04-17T21:13:26  *** proofofkeags has joined #bitcoin-core-dev
4952020-04-17T21:16:41  <yevaud> it's conclusion is wrong, fundamentally. it suggests that the correct option was to encourage people to downgrade to 0.7, limit block size to 500KB, and increase the number of locks allowed in berkleydb.
4962020-04-17T21:17:16  <yevaud> simply, no version of Bitcoin before 0.8 was able to maintain consensus even between nodes of the same version. realistically there's no amount of increase in berkeleydb which can allow nodes to operate properly, and the number in that document is well, well below the value required even for the time.
4972020-04-17T21:17:47  *** bitdex has joined #bitcoin-core-dev
4982020-04-17T21:17:52  *** bitdex has quit IRC
4992020-04-17T21:17:55  <sipa> the document does mention "This would be an issue even if the entire network was running version 0.7.2. It is theoretically possible for one 0.7.2 node to create a block that others are unable to validate, or for 0.7.2 nodes to create block re-orgs that peers cannot validate, because the contents of each node's blkindex.dat database is not identical, and the number of locks required depends on the
5002020-04-17T21:18:01  <sipa> exact arrangement of the blkindex.dat on...
5012020-04-17T21:18:04  <sipa> disk (locks are acquired per-page). "
5022020-04-17T21:18:15  *** bitdex has joined #bitcoin-core-dev
5032020-04-17T21:19:50  *** bitcoin-git has joined #bitcoin-core-dev
5042020-04-17T21:19:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c54295c1a206...895c71e53557
5052020-04-17T21:19:51  <bitcoin-git> bitcoin/master 6f8b498 Sebastian Falbesoner: fuzz: http_request workaround for libevent < 2.1.1
5062020-04-17T21:19:52  <bitcoin-git> bitcoin/master 895c71e MarcoFalke: Merge #18682: fuzz: http_request workaround for libevent < 2.1.1
5072020-04-17T21:19:54  *** bitcoin-git has left #bitcoin-core-dev
5082020-04-17T21:19:58  <yevaud> I've seen a few people argue based on BIP50 that if the locks are set to the value described, it is safe.
5092020-04-17T21:20:10  *** bitcoin-git has joined #bitcoin-core-dev
5102020-04-17T21:20:10  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18682: fuzz: http_request workaround for libevent < 2.1.1 (master...20200417-fuzz-http-req-workaround-for-older-libevent) https://github.com/bitcoin/bitcoin/pull/18682
5112020-04-17T21:20:11  *** bitcoin-git has left #bitcoin-core-dev
5122020-04-17T21:20:21  <yevaud> perhaps that's down to interpretation.
5132020-04-17T21:20:50  <sipa> due to the way locks were grabbed for an entire reorg, arguably for any finite value of the lock limits, pre-0.8 was unable to handle arbirarily long reorgs, which is arguably a consensus failure
5142020-04-17T21:21:27  <sipa> then again, i believe there have been plenty of other versions since 0.8 that also weren't practically capable of doing very deep (say 1000s of blocks) reorgs
5152020-04-17T21:21:46  *** ButterflyOfFire has joined #bitcoin-core-dev
5162020-04-17T21:22:54  <yevaud> true. in those versions reverting a UTXO change wrote back into the mempool for every block (or something close), it was excruciatingly slow.
5172020-04-17T21:23:50  <yevaud> I've attempted to sync 0.7 with 2**32 locks, it ends up failing consensus effectively at random. it was never clear exactly why.
5182020-04-17T21:24:05  <sipa> by unable i don't just mean infeasibly slow - i mean it'd go OOM
5192020-04-17T21:25:49  <yevaud> right. it would be an interesting exercise to get 0.7 to sync with the modern network, but it's in the order of months of sync time, even entirely in NVMe cache.
5202020-04-17T21:26:16  <yevaud> I'm not even confident it can process blocks fast enough to stay in sync at the head.
5212020-04-17T21:28:03  <sipa> haha, yes
5222020-04-17T21:28:09  <sipa> that too is arguably a consensus failure...
5232020-04-17T21:29:13  <yevaud> presumably if we had CPUs that were orders of magnitude faster, it would be consensus compatible again. sort of stretching the definition.
5242020-04-17T21:30:31  *** grunch__ has quit IRC
5252020-04-17T21:34:06  <gwillen> ugh, I hate the fact that every time some fucking altcoin brings over a commit that has my name in it, I get pinged
5262020-04-17T21:34:21  <gwillen> if anybody knows a way to prevent that I'd love to hear it
5272020-04-17T21:35:44  <sipa> i think we have some recommendation somewhere not to put @username in commit messages
5282020-04-17T21:35:59  <sipa> someone even suggested having a linter for it
5292020-04-17T21:35:59  <gwillen> welp
5302020-04-17T21:55:04  *** Kiminuo has quit IRC
5312020-04-17T22:11:52  <fanquake> sipa: ok
5322020-04-17T22:12:46  <sipa> fanquake: were you... asleep?
5332020-04-17T22:13:25  <fanquake> Yes I was hah
5342020-04-17T22:13:42  <fanquake> Can you also block amirabbaska
5352020-04-17T22:20:01  <sipa> done
5362020-04-17T22:30:02  *** mdunnio has quit IRC
5372020-04-17T22:30:38  *** promag has joined #bitcoin-core-dev
5382020-04-17T22:33:15  <achow101> fanquake sleeps? that's new :p
5392020-04-17T22:40:26  <sipa> it must be a sporadic activity
5402020-04-17T22:40:49  <dongcarl> achow101: You see, he has a secondary brain directly attached to an X server, which never sleeps
5412020-04-17T22:43:28  <sipa> dongcarl: his computer?
5422020-04-17T22:44:29  <dongcarl> XD
5432020-04-17T22:50:53  <jonatack> :D
5442020-04-17T23:08:33  *** bitcoin-git has joined #bitcoin-core-dev
5452020-04-17T23:08:33  <bitcoin-git> [bitcoin] hebasto opened pull request #18695: test: Replace boost::mutex with std::mutex (master...200417-boost-mu) https://github.com/bitcoin/bitcoin/pull/18695
5462020-04-17T23:08:34  *** bitcoin-git has left #bitcoin-core-dev
5472020-04-17T23:16:47  *** sosthene has quit IRC
5482020-04-17T23:17:02  *** sosthene has joined #bitcoin-core-dev
5492020-04-17T23:24:22  *** justanotheruser has quit IRC
5502020-04-17T23:34:37  *** justanotheruser has joined #bitcoin-core-dev
5512020-04-17T23:36:46  *** marcoagner has quit IRC
5522020-04-17T23:44:01  <hebasto> IIUC, it seems our unit tests ignore the case when g_parallel_script_checks=false. Is it intended?
5532020-04-17T23:45:15  *** luke-jr has quit IRC
5542020-04-17T23:45:42  *** luke-jr has joined #bitcoin-core-dev
5552020-04-17T23:47:15  *** Talkless has quit IRC
5562020-04-17T23:58:56  *** _andrewtoth_ has joined #bitcoin-core-dev