12020-06-01T00:00:01 *** jtk has quit IRC
22020-06-01T00:00:03 *** vasild has quit IRC
32020-06-01T00:00:05 *** bitdex has quit IRC
42020-06-01T00:00:26 *** vasild has joined #bitcoin-core-dev
52020-06-01T00:01:54 *** bitdex has joined #bitcoin-core-dev
62020-06-01T00:20:41 *** SRV_DW20 has joined #bitcoin-core-dev
72020-06-01T00:23:23 *** promag has quit IRC
82020-06-01T00:39:56 *** TheHoliestRoger has quit IRC
92020-06-01T00:40:47 *** TheHoliestRoger has joined #bitcoin-core-dev
102020-06-01T01:20:17 *** promag_ has quit IRC
112020-06-01T01:22:56 *** proofofkeags has joined #bitcoin-core-dev
122020-06-01T02:05:05 *** willcl_ark has quit IRC
132020-06-01T02:07:26 *** AaronvanW has quit IRC
142020-06-01T02:07:33 *** willcl_ark has joined #bitcoin-core-dev
152020-06-01T02:08:16 *** troygiorshev has joined #bitcoin-core-dev
162020-06-01T02:17:31 *** Highway61 has quit IRC
172020-06-01T02:21:13 *** Processus42_ has joined #bitcoin-core-dev
182020-06-01T02:23:58 *** promag has joined #bitcoin-core-dev
192020-06-01T02:28:30 *** Processus42 has quit IRC
202020-06-01T02:28:30 *** Lightsword has quit IRC
212020-06-01T02:28:33 *** moneyball has quit IRC
222020-06-01T02:28:33 *** hugohn has quit IRC
232020-06-01T02:28:33 *** mol has quit IRC
242020-06-01T02:29:07 *** promag has quit IRC
252020-06-01T02:29:12 *** mol has joined #bitcoin-core-dev
262020-06-01T02:31:10 *** Lightsword has joined #bitcoin-core-dev
272020-06-01T02:31:30 *** mol_ has joined #bitcoin-core-dev
282020-06-01T02:31:54 *** icota[m] has quit IRC
292020-06-01T02:32:24 *** mrostecki[m] has quit IRC
302020-06-01T02:32:28 *** TheFuzzStone[m] has quit IRC
312020-06-01T02:34:36 *** mol has quit IRC
322020-06-01T02:44:48 *** troygiorshev has quit IRC
332020-06-01T02:45:48 *** jarthur has joined #bitcoin-core-dev
342020-06-01T02:46:42 *** troygiorshev has joined #bitcoin-core-dev
352020-06-01T02:48:46 *** molz_ has joined #bitcoin-core-dev
362020-06-01T02:51:50 *** mol_ has quit IRC
372020-06-01T02:53:01 *** mol_ has joined #bitcoin-core-dev
382020-06-01T02:55:40 *** molz_ has quit IRC
392020-06-01T02:59:17 *** surja795 has quit IRC
402020-06-01T03:00:02 *** SRV_DW20 has quit IRC
412020-06-01T03:03:02 *** icota[m] has joined #bitcoin-core-dev
422020-06-01T03:04:50 *** AaronvanW has joined #bitcoin-core-dev
432020-06-01T03:15:25 *** TheFuzzStone[m] has joined #bitcoin-core-dev
442020-06-01T03:21:37 *** Kmos has joined #bitcoin-core-dev
452020-06-01T03:22:01 *** Kmos is now known as Guest69505
462020-06-01T03:24:09 *** Relis has quit IRC
472020-06-01T03:24:16 *** Deacyde has quit IRC
482020-06-01T03:31:47 *** Relis has joined #bitcoin-core-dev
492020-06-01T03:43:37 *** troygiorshev has quit IRC
502020-06-01T03:51:40 *** Relis has quit IRC
512020-06-01T03:57:12 *** EagleTM has joined #bitcoin-core-dev
522020-06-01T03:59:14 *** Eagle[TM] has quit IRC
532020-06-01T04:00:15 *** harrigan has quit IRC
542020-06-01T04:00:52 *** harrigan has joined #bitcoin-core-dev
552020-06-01T04:01:03 *** bitdex has quit IRC
562020-06-01T04:01:26 *** bitdex has joined #bitcoin-core-dev
572020-06-01T04:03:49 *** Relis has joined #bitcoin-core-dev
582020-06-01T04:13:25 *** go11111111111 has joined #bitcoin-core-dev
592020-06-01T04:15:49 *** go1111111 has quit IRC
602020-06-01T04:20:26 *** vasild_ has joined #bitcoin-core-dev
612020-06-01T04:23:44 *** vasild has quit IRC
622020-06-01T04:23:44 *** vasild_ is now known as vasild
632020-06-01T04:29:43 *** morcos has quit IRC
642020-06-01T04:29:44 *** bitcoin-git has joined #bitcoin-core-dev
652020-06-01T04:29:44 <bitcoin-git> [bitcoin] ajtowns opened pull request #19130: doc: make it easier to work out size of bloom filter (master...202005-bloom-doc) https://github.com/bitcoin/bitcoin/pull/19130
662020-06-01T04:29:45 *** bitcoin-git has left #bitcoin-core-dev
672020-06-01T04:36:52 *** morcos has joined #bitcoin-core-dev
682020-06-01T04:40:12 *** proofofkeags has quit IRC
692020-06-01T04:41:49 *** dongcarl has quit IRC
702020-06-01T04:45:30 *** Emcy has quit IRC
712020-06-01T04:46:01 *** Emcy has joined #bitcoin-core-dev
722020-06-01T04:53:37 *** Relis has quit IRC
732020-06-01T04:53:51 *** justanotheruser has quit IRC
742020-06-01T04:58:43 *** Relis has joined #bitcoin-core-dev
752020-06-01T05:00:28 *** Relis has quit IRC
762020-06-01T05:06:02 *** jarthur has quit IRC
772020-06-01T05:15:46 *** proofofkeags has joined #bitcoin-core-dev
782020-06-01T05:19:49 *** mol_ has quit IRC
792020-06-01T05:22:57 *** mol has joined #bitcoin-core-dev
802020-06-01T05:23:15 *** proofofkeags has quit IRC
812020-06-01T05:23:32 *** marcoagner has joined #bitcoin-core-dev
822020-06-01T05:25:12 *** justanotheruser has joined #bitcoin-core-dev
832020-06-01T05:49:24 *** jarthur has joined #bitcoin-core-dev
842020-06-01T05:52:13 *** proofofkeags has joined #bitcoin-core-dev
852020-06-01T05:57:18 *** proofofkeags has quit IRC
862020-06-01T06:00:02 *** Guest69505 has quit IRC
872020-06-01T06:21:58 *** SummerNinja has joined #bitcoin-core-dev
882020-06-01T06:29:23 *** sipa has quit IRC
892020-06-01T06:29:54 *** lehnberg has joined #bitcoin-core-dev
902020-06-01T06:32:39 *** sipa has joined #bitcoin-core-dev
912020-06-01T06:40:23 *** mol_ has joined #bitcoin-core-dev
922020-06-01T06:40:33 *** mol_ has quit IRC
932020-06-01T06:40:56 *** mol_ has joined #bitcoin-core-dev
942020-06-01T06:41:30 *** Guyver2 has joined #bitcoin-core-dev
952020-06-01T06:42:26 *** mol has quit IRC
962020-06-01T07:08:25 *** mol_ has quit IRC
972020-06-01T07:31:03 *** jarthur has quit IRC
982020-06-01T07:31:33 *** jarthur has joined #bitcoin-core-dev
992020-06-01T07:39:37 *** bitcoin-git has joined #bitcoin-core-dev
1002020-06-01T07:39:38 <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a65b55fa45d4...a8327fd71f5c
1012020-06-01T07:39:39 <bitcoin-git> bitcoin/master fab893e MarcoFalke: doc: Fix unrelated typos reported by codespell
1022020-06-01T07:39:39 <bitcoin-git> bitcoin/master 100000d MarcoFalke: doc: Add headings to CONTRIBUTING.md
1032020-06-01T07:39:40 <bitcoin-git> bitcoin/master fae2fb2 MarcoFalke: doc: Expand section on Getting Started
1042020-06-01T07:39:42 *** bitcoin-git has left #bitcoin-core-dev
1052020-06-01T07:39:57 *** bitcoin-git has joined #bitcoin-core-dev
1062020-06-01T07:39:57 <bitcoin-git> [bitcoin] fanquake merged pull request #19072: doc: Expand section on Getting Started (master...2005-docContribClarif) https://github.com/bitcoin/bitcoin/pull/19072
1072020-06-01T07:39:58 *** bitcoin-git has left #bitcoin-core-dev
1082020-06-01T07:53:14 *** proofofkeags has joined #bitcoin-core-dev
1092020-06-01T07:57:49 *** proofofkeags has quit IRC
1102020-06-01T08:07:38 *** bitcoin-git has joined #bitcoin-core-dev
1112020-06-01T08:07:39 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a8327fd71f5c...9bc7751cadbd
1122020-06-01T08:07:39 <bitcoin-git> bitcoin/master fa86179 MarcoFalke: doc: Add release notes for 17219
1132020-06-01T08:07:40 <bitcoin-git> bitcoin/master fac0ed1 MarcoFalke: doc: Sync "how to upgrade" with 0.20.0 release notes
1142020-06-01T08:07:40 <bitcoin-git> bitcoin/master 9bc7751 fanquake: Merge #19115: doc: Add release notes for 17219
1152020-06-01T08:07:42 *** bitcoin-git has left #bitcoin-core-dev
1162020-06-01T08:07:58 *** bitcoin-git has joined #bitcoin-core-dev
1172020-06-01T08:07:58 <bitcoin-git> [bitcoin] fanquake merged pull request #19115: doc: Add release notes for 17219 (master...2005-docRel) https://github.com/bitcoin/bitcoin/pull/19115
1182020-06-01T08:07:59 *** bitcoin-git has left #bitcoin-core-dev
1192020-06-01T08:25:01 *** promag has joined #bitcoin-core-dev
1202020-06-01T08:25:58 *** bitcoin-git has joined #bitcoin-core-dev
1212020-06-01T08:25:59 <bitcoin-git> [bitcoin] jonathanschoeller opened pull request #19131: refactor: Fix unreachable code in init arg checks (master...fix-Wunreachable-code-loop-increment) https://github.com/bitcoin/bitcoin/pull/19131
1222020-06-01T08:26:04 *** bitcoin-git has left #bitcoin-core-dev
1232020-06-01T08:27:03 *** dr-orlovsky has joined #bitcoin-core-dev
1242020-06-01T08:29:11 *** promag has quit IRC
1252020-06-01T08:31:44 *** Processus42_ is now known as Processus42
1262020-06-01T08:31:57 *** nullptr_ has quit IRC
1272020-06-01T08:34:46 *** nullptr| has joined #bitcoin-core-dev
1282020-06-01T08:49:13 *** jarthur_ has joined #bitcoin-core-dev
1292020-06-01T08:49:45 *** dr-orlovsky has quit IRC
1302020-06-01T08:50:53 *** jarthur_ has quit IRC
1312020-06-01T08:51:18 *** jarthur has quit IRC
1322020-06-01T08:59:53 *** Yukinochan has joined #bitcoin-core-dev
1332020-06-01T09:00:02 *** SummerNinja has quit IRC
1342020-06-01T09:03:07 *** timothy has joined #bitcoin-core-dev
1352020-06-01T09:09:03 *** timothy has quit IRC
1362020-06-01T09:10:54 *** mol has joined #bitcoin-core-dev
1372020-06-01T09:15:40 *** Pavlenex has joined #bitcoin-core-dev
1382020-06-01T09:18:43 *** timothy has joined #bitcoin-core-dev
1392020-06-01T09:22:03 *** jeremyb has joined #bitcoin-core-dev
1402020-06-01T09:22:27 *** jeremyb is now known as Guest23530
1412020-06-01T09:23:01 *** wullon5 has joined #bitcoin-core-dev
1422020-06-01T09:25:23 *** Pavlenex has quit IRC
1432020-06-01T09:25:43 *** Pavlenex has joined #bitcoin-core-dev
1442020-06-01T09:46:56 *** Pavlenex has quit IRC
1452020-06-01T09:50:30 *** dr-orlov1ky has joined #bitcoin-core-dev
1462020-06-01T09:54:15 *** proofofkeags has joined #bitcoin-core-dev
1472020-06-01T09:55:40 *** timothy has quit IRC
1482020-06-01T09:58:39 *** proofofkeags has quit IRC
1492020-06-01T10:01:25 *** Kiminuo has joined #bitcoin-core-dev
1502020-06-01T10:03:29 *** Matt5Crooks has joined #bitcoin-core-dev
1512020-06-01T10:05:06 *** promag has joined #bitcoin-core-dev
1522020-06-01T10:08:38 *** Matt5Crooks has quit IRC
1532020-06-01T10:09:38 *** promag has quit IRC
1542020-06-01T10:12:38 <fanquake> practicalswift asked for #18288 to be their high-prio PR; so I've added it.
1552020-06-01T10:12:40 <gribble> https://github.com/bitcoin/bitcoin/issues/18288 | build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory by practicalswift · Pull Request #18288 · bitcoin/bitcoin · GitHub
1562020-06-01T10:14:11 *** surja795 has joined #bitcoin-core-dev
1572020-06-01T10:18:42 *** surja795 has quit IRC
1582020-06-01T11:00:44 *** proofofkeags has joined #bitcoin-core-dev
1592020-06-01T11:05:26 *** cltrbreak_MAD2 has quit IRC
1602020-06-01T11:05:52 *** cltrbreak_MAD2 has joined #bitcoin-core-dev
1612020-06-01T11:32:48 <Kiminuo> Hi, can I make my PR https://github.com/bitcoin/bitcoin/pull/18210 more attractive for review somehow? I have just rewritten the first post to articulate more clearly what the PR does.
1622020-06-01T11:45:01 *** Pavlenex has joined #bitcoin-core-dev
1632020-06-01T11:46:35 *** Pavlenex has quit IRC
1642020-06-01T11:49:24 <jonatack> Kiminuo: rebasing promptly helps, and giving review is a good way to (a) to see the review bottleneck and (b) receive review back
1652020-06-01T11:50:32 <jonatack> Kiminuo: because there are more people who open PRs than people who review them
1662020-06-01T11:51:47 *** Yukinochan has quit IRC
1672020-06-01T11:58:11 *** shesek has quit IRC
1682020-06-01T12:00:02 *** Guest23530 has quit IRC
1692020-06-01T12:01:14 *** surja795 has joined #bitcoin-core-dev
1702020-06-01T12:04:05 *** proofofkeags has quit IRC
1712020-06-01T12:05:48 *** surja795 has quit IRC
1722020-06-01T12:15:43 *** surja795 has joined #bitcoin-core-dev
1732020-06-01T12:16:39 *** Relis has joined #bitcoin-core-dev
1742020-06-01T12:22:09 *** defnordic has joined #bitcoin-core-dev
1752020-06-01T12:24:37 *** Relis has quit IRC
1762020-06-01T12:28:19 *** bitcoin-git has joined #bitcoin-core-dev
1772020-06-01T12:28:20 <bitcoin-git> [bitcoin] vasild opened pull request #19132: qt: lock cs_main, m_cached_tip_mutex in that order (master...lock_order_m_cached_tip_mutex) https://github.com/bitcoin/bitcoin/pull/19132
1782020-06-01T12:28:21 *** bitcoin-git has left #bitcoin-core-dev
1792020-06-01T12:33:06 *** bitcoin-git has joined #bitcoin-core-dev
1802020-06-01T12:33:06 <bitcoin-git> [bitcoin] jonatack opened pull request #19133: rpc, cli, test: add bitcoin-cli -generate command (master...cli-generate-command) https://github.com/bitcoin/bitcoin/pull/19133
1812020-06-01T12:33:07 *** bitcoin-git has left #bitcoin-core-dev
1822020-06-01T12:33:50 *** Highway61 has joined #bitcoin-core-dev
1832020-06-01T12:37:37 *** troygiorshev has joined #bitcoin-core-dev
1842020-06-01T12:37:43 *** Evel-Knievel has quit IRC
1852020-06-01T12:40:14 <vasild> Maybe #19132 should be included in the coming release. It fixes a regression since 0.19.
1862020-06-01T12:40:16 <gribble> https://github.com/bitcoin/bitcoin/issues/19132 | qt: lock cs_main, m_cached_tip_mutex in that order by vasild · Pull Request #19132 · bitcoin/bitcoin · GitHub
1872020-06-01T12:42:04 <vasild> Either a deadlock (infinite hang) or a crash if the (possible) deadlock is detected. I am not sure if the deadlock detecting code is always enabled - in release builds and for all compilers?
1882020-06-01T12:42:59 <fanquake> vasild: how is it an issue since 0.19 if the PR that supposedly introduced it (17993), was only merged 3 days ago?
1892020-06-01T12:43:28 <vasild> well, the problem does not exist in 0.19
1902020-06-01T12:43:59 <fanquake> Right. So the issue only currently exists in master?
1912020-06-01T12:44:06 <vasild> yes
1922020-06-01T12:44:09 <fanquake> If so, there is no need to backport anything.
1932020-06-01T12:44:46 <vasild> by "regression since 0.19" I mean that the problem does not exist in 0.19 but would exist in 0.20 (if released without a fix)
1942020-06-01T12:45:01 <vasild> right, I think no need to backport anything
1952020-06-01T12:45:14 <fanquake> I don't see how it can exist in 0.20 if it's only been merged into master
1962020-06-01T12:45:31 <fanquake> It will be fixed in master, and should hopefully never exist in any release.
1972020-06-01T12:47:52 <vasild> It _would_ exist in 0.20 if 0.20 is released without a fix.
1982020-06-01T12:48:54 <vasild> All I am saying is that this is a new problem that IMO should be fixed before the release. If the problem existed in 0.19 (an old one), maybe it would have been less important to get the fix into 0.20.
1992020-06-01T12:50:08 <fanquake> vasild: the 0.20 release is currently based on the 0.20. branch: https://github.com/bitcoin/bitcoin/tree/0.20 (not master), so if the PR introduced the issue (17993) has. only been merged into master, then there is no issue with 0.20.
2002020-06-01T12:50:18 <Kiminuo> jonatack, My PR is buried at this point, so I don't expect anyone to find it really..
2012020-06-01T12:51:15 <Kiminuo> and rebasing also does not make too much sense because it only claims valuable resources for other PRs
2022020-06-01T12:51:33 <Kiminuo> (I don't modify cpp code)
2032020-06-01T12:52:23 <vasild> fanquake: oh, this is my confusion - I assumed that 0.20 is yet to be created from master, sorry. So 0.20 does not have the bug, meaning it should only be fixed before 0.21! :)
2042020-06-01T12:53:43 *** Pavlenex has joined #bitcoin-core-dev
2052020-06-01T12:53:49 <fanquake> vasild: ð
2062020-06-01T13:04:14 <vasild> What about attaching a "lock order" number to each mutex (hardcoded in the source code) and enforce that locking always happens in ascending order?
2072020-06-01T13:09:02 *** Pavlenex has quit IRC
2082020-06-01T13:09:17 *** timothy has joined #bitcoin-core-dev
2092020-06-01T13:11:02 *** Relis has joined #bitcoin-core-dev
2102020-06-01T13:12:44 *** troygiorshev has quit IRC
2112020-06-01T13:13:42 *** troygiorshev has joined #bitcoin-core-dev
2122020-06-01T13:15:26 *** Evel-Knievel has joined #bitcoin-core-dev
2132020-06-01T13:19:44 *** surja795 has quit IRC
2142020-06-01T13:27:35 *** Pavlenex has joined #bitcoin-core-dev
2152020-06-01T13:55:01 *** hebasto has quit IRC
2162020-06-01T13:59:25 *** hebasto has joined #bitcoin-core-dev
2172020-06-01T14:00:42 <hebasto> vasild: maybe some of thread safety annotations could be useful?
2182020-06-01T14:04:40 <vasild> hebasto: you mean for detecting cycles in the waits-for DAG? That would be excellent as I think our deadlock detection mechanism has a deficiency. https://github.com/google/sanitizers/wiki/ThreadSanitizerDeadlockDetector
2192020-06-01T14:04:51 <vasild> is relevant
2202020-06-01T14:06:26 <hebasto> what a deficiency?
2212020-06-01T14:09:05 <vasild> hebasto: https://paste.gg/p/anonymous/4f3dd080b5ef4a09a0cba6a6eaffc6a6 -- if somebody can confirm that this is indeed a problem and I am not delusional, then I will open a bug report about it.
2222020-06-01T14:09:42 <vasild> The push_lock() function is in src/sync.cpp
2232020-06-01T14:18:10 <hebasto> vasild: does TSan detect such deadlock possibilities?
2242020-06-01T14:23:38 *** Kiminuo has quit IRC
2252020-06-01T14:31:42 <vasild> no idea
2262020-06-01T14:35:22 *** jb55 has quit IRC
2272020-06-01T14:35:22 *** ghost43 has quit IRC
2282020-06-01T14:35:40 *** ghost43 has joined #bitcoin-core-dev
2292020-06-01T14:35:55 *** jb55 has joined #bitcoin-core-dev
2302020-06-01T14:50:56 *** bitcoin-git has joined #bitcoin-core-dev
2312020-06-01T14:50:57 <bitcoin-git> [bitcoin] dboures opened pull request #19134: test: Replace global wait_until with mininode.wait_until (master...master) https://github.com/bitcoin/bitcoin/pull/19134
2322020-06-01T14:50:57 *** bitcoin-git has left #bitcoin-core-dev
2332020-06-01T14:54:03 <vasild> hebasto: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#acquired-before-acquired-after is promising, but it is only limited to things that can be detected at compile time.
2342020-06-01T14:54:17 *** sdaftuar has quit IRC
2352020-06-01T14:54:39 *** sdaftuar has joined #bitcoin-core-dev
2362020-06-01T14:54:59 <hebasto> vasild: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#acquired-before-and-acquired-after-are-currently-unimplemented
2372020-06-01T14:55:00 <vasild> I just tried the following on master (which has #19132):
2382020-06-01T14:55:02 <gribble> https://github.com/bitcoin/bitcoin/issues/19132 | qt: lock cs_main, m_cached_tip_mutex in that order by vasild · Pull Request #19132 · bitcoin/bitcoin · GitHub
2392020-06-01T14:55:03 <vasild> - Mutex m_cached_tip_mutex;
2402020-06-01T14:55:03 <vasild> + Mutex m_cached_tip_mutex ACQUIRED_AFTER(cs_main);
2412020-06-01T14:55:50 <vasild> 1. it compiled and 2. it abort()ed at runtime, detecting the deadlock from inside our push_lock()
2422020-06-01T14:56:37 <vasild> oh, are currently unimplemented :(
2432020-06-01T14:57:19 <vasild> but even if they are implemented I doubt it would be possible to detect complicated lock order violations at compile time
2442020-06-01T15:00:02 *** defnordic has quit IRC
2452020-06-01T15:02:24 *** troygiorshev has quit IRC
2462020-06-01T15:03:16 *** troygiorshev has joined #bitcoin-core-dev
2472020-06-01T15:19:08 *** Pavlenex has quit IRC
2482020-06-01T15:22:54 *** Pavlenex has joined #bitcoin-core-dev
2492020-06-01T15:23:18 *** Talkless has joined #bitcoin-core-dev
2502020-06-01T15:24:40 *** Pavlenex has quit IRC
2512020-06-01T15:25:30 *** mol_ has joined #bitcoin-core-dev
2522020-06-01T15:29:02 *** mol has quit IRC
2532020-06-01T15:37:14 *** mol_ has quit IRC
2542020-06-01T15:44:50 *** hugohn has joined #bitcoin-core-dev
2552020-06-01T15:44:51 *** moneyball has joined #bitcoin-core-dev
2562020-06-01T15:50:46 *** Talkless has quit IRC
2572020-06-01T15:56:46 *** kexkey has joined #bitcoin-core-dev
2582020-06-01T16:00:18 *** Talkless has joined #bitcoin-core-dev
2592020-06-01T16:01:33 *** timothy has quit IRC
2602020-06-01T16:01:50 *** mol has joined #bitcoin-core-dev
2612020-06-01T16:04:07 *** justanotheruser has quit IRC
2622020-06-01T16:10:20 *** Emcy has quit IRC
2632020-06-01T16:10:57 *** Emcy has joined #bitcoin-core-dev
2642020-06-01T16:12:45 *** ghost43 has quit IRC
2652020-06-01T16:13:12 *** ghost43 has joined #bitcoin-core-dev
2662020-06-01T16:16:05 *** joerodgers has joined #bitcoin-core-dev
2672020-06-01T16:19:37 *** proofofkeags has joined #bitcoin-core-dev
2682020-06-01T16:19:56 *** justanotheruser has joined #bitcoin-core-dev
2692020-06-01T16:23:23 *** vasild has quit IRC
2702020-06-01T16:25:22 *** vasild has joined #bitcoin-core-dev
2712020-06-01T16:29:14 *** troygiorshev has quit IRC
2722020-06-01T16:33:09 *** troygiorshev has joined #bitcoin-core-dev
2732020-06-01T17:01:14 *** troygiorshev has quit IRC
2742020-06-01T17:02:15 *** Bille has joined #bitcoin-core-dev
2752020-06-01T17:06:43 *** mrostecki has quit IRC
2762020-06-01T17:08:51 *** troygiorshev has joined #bitcoin-core-dev
2772020-06-01T17:13:22 *** mrostecki has joined #bitcoin-core-dev
2782020-06-01T17:14:45 *** Highway61 has quit IRC
2792020-06-01T17:20:05 *** ghost43 has quit IRC
2802020-06-01T17:20:25 *** ghost43 has joined #bitcoin-core-dev
2812020-06-01T17:37:23 *** jarthur has joined #bitcoin-core-dev
2822020-06-01T17:43:08 *** Highway61 has joined #bitcoin-core-dev
2832020-06-01T17:49:38 *** bitcoin-git has joined #bitcoin-core-dev
2842020-06-01T17:49:38 <bitcoin-git> [bitcoin] andersonbr opened pull request #19135: Update bitcoin_pt_BR.ts (master...andersonbr-patch-1) https://github.com/bitcoin/bitcoin/pull/19135
2852020-06-01T17:49:39 *** bitcoin-git has left #bitcoin-core-dev
2862020-06-01T17:57:52 *** shesek has joined #bitcoin-core-dev
2872020-06-01T17:57:52 *** shesek has joined #bitcoin-core-dev
2882020-06-01T18:00:01 *** Bille has quit IRC
2892020-06-01T18:13:04 *** Kiminuo has joined #bitcoin-core-dev
2902020-06-01T18:14:05 *** lehnberg has quit IRC
2912020-06-01T18:21:58 *** bcremer has joined #bitcoin-core-dev
2922020-06-01T18:25:31 *** mol has quit IRC
2932020-06-01T18:35:51 *** TheFuzzStone[m] has quit IRC
2942020-06-01T18:38:05 *** mol has joined #bitcoin-core-dev
2952020-06-01T18:38:51 *** Talkless has quit IRC
2962020-06-01T18:42:00 *** icota[m] has quit IRC
2972020-06-01T18:44:14 *** TheFuzzStone[m] has joined #bitcoin-core-dev
2982020-06-01T18:45:20 *** TheFuzzStone[m] has quit IRC
2992020-06-01T19:08:54 *** mol_ has joined #bitcoin-core-dev
3002020-06-01T19:11:56 *** mol has quit IRC
3012020-06-01T19:13:32 *** Highway61 has quit IRC
3022020-06-01T19:15:59 *** owowo has quit IRC
3032020-06-01T19:16:58 *** icota[m] has joined #bitcoin-core-dev
3042020-06-01T19:17:49 *** Pavlenex has joined #bitcoin-core-dev
3052020-06-01T19:21:10 *** owowo has joined #bitcoin-core-dev
3062020-06-01T19:23:49 *** TheFuzzStone[m] has joined #bitcoin-core-dev
3072020-06-01T19:23:50 *** mrostecki[m] has joined #bitcoin-core-dev
3082020-06-01T19:33:08 *** nullptr| has quit IRC
3092020-06-01T19:34:40 *** proofofkeags has quit IRC
3102020-06-01T19:34:51 *** dr-orlov1ky has quit IRC
3112020-06-01T19:34:54 *** nullptr| has joined #bitcoin-core-dev
3122020-06-01T19:35:07 *** proofofkeags has joined #bitcoin-core-dev
3132020-06-01T19:39:33 *** proofofkeags has quit IRC
3142020-06-01T19:46:13 *** lehnberg has joined #bitcoin-core-dev
3152020-06-01T19:46:36 *** lehnberg has quit IRC
3162020-06-01T19:48:43 *** jorijn has quit IRC
3172020-06-01T19:49:09 *** jorijn has joined #bitcoin-core-dev
3182020-06-01T19:49:53 *** Highway61 has joined #bitcoin-core-dev
3192020-06-01T20:09:14 <gwillen> MarcoFalke: I'm curious what inspired you to fix all the codespell typos a few days ago -- I was never sure if those only show up for me, or for mac users, or what
3202020-06-01T20:09:27 <gwillen> I always assumed they must not be in whatever dictionary Travis uses, or something
3212020-06-01T20:18:34 *** bitcoin-git has joined #bitcoin-core-dev
3222020-06-01T20:18:35 <bitcoin-git> [bitcoin] achow101 opened pull request #19136: wallet: add dumpwalletdescriptor RPC (master...export-descriptor) https://github.com/bitcoin/bitcoin/pull/19136
3232020-06-01T20:18:36 *** bitcoin-git has left #bitcoin-core-dev
3242020-06-01T20:22:24 *** Kiminuo has quit IRC
3252020-06-01T20:24:23 *** proofofkeags has joined #bitcoin-core-dev
3262020-06-01T20:48:56 *** marcoagner has quit IRC
3272020-06-01T20:58:40 *** Eulah89Stracke has joined #bitcoin-core-dev
3282020-06-01T21:00:03 *** bcremer has quit IRC
3292020-06-01T21:00:17 *** surja795 has joined #bitcoin-core-dev
3302020-06-01T21:10:21 *** owowo has quit IRC
3312020-06-01T21:10:24 *** Eulah89Stracke has quit IRC
3322020-06-01T21:12:48 *** Guyver2 has quit IRC
3332020-06-01T21:15:23 *** owowo has joined #bitcoin-core-dev
3342020-06-01T21:22:13 *** chrippa has joined #bitcoin-core-dev
3352020-06-01T21:24:14 *** owowo has quit IRC
3362020-06-01T21:29:24 *** owowo has joined #bitcoin-core-dev
3372020-06-01T21:36:17 *** EagleTM has quit IRC
3382020-06-01T21:45:03 *** surja795 has quit IRC
3392020-06-01T21:45:41 *** dfmb_ has joined #bitcoin-core-dev
3402020-06-01T21:48:01 *** dfmb_ has quit IRC
3412020-06-01T21:49:52 *** surja795 has joined #bitcoin-core-dev
3422020-06-01T21:51:25 *** troygiorshev has quit IRC
3432020-06-01T21:54:26 *** surja795 has quit IRC
3442020-06-01T22:17:34 *** surja795 has joined #bitcoin-core-dev
3452020-06-01T22:18:11 *** promag has joined #bitcoin-core-dev
3462020-06-01T22:20:09 *** surja795 has quit IRC
3472020-06-01T22:25:21 *** surja795 has joined #bitcoin-core-dev
3482020-06-01T22:27:45 *** kexkey has quit IRC
3492020-06-01T22:29:33 *** surja795 has quit IRC
3502020-06-01T22:30:09 *** kexkey has joined #bitcoin-core-dev
3512020-06-01T22:30:23 *** bitcoin-git has joined #bitcoin-core-dev
3522020-06-01T22:30:24 <bitcoin-git> [bitcoin] achow101 opened pull request #19137: wallettool: Add dump and createfromdump commands (master...dumpwalletrecords) https://github.com/bitcoin/bitcoin/pull/19137
3532020-06-01T22:30:25 *** bitcoin-git has left #bitcoin-core-dev
3542020-06-01T22:31:30 *** troygiorshev has joined #bitcoin-core-dev
3552020-06-01T22:36:20 *** kexkey has quit IRC
3562020-06-01T22:56:11 *** troygiorshev has quit IRC
3572020-06-01T22:59:33 *** EagleTM has joined #bitcoin-core-dev
3582020-06-01T23:02:57 *** filchef has joined #bitcoin-core-dev
3592020-06-01T23:02:59 <promag> are there real benefits of rpc batching?
3602020-06-01T23:03:52 *** filchef has quit IRC
3612020-06-01T23:04:35 *** bitcoin-git has joined #bitcoin-core-dev
3622020-06-01T23:04:35 <bitcoin-git> [bitcoin] fanquake closed pull request #19135: qt: Update bitcoin_pt_BR.ts (master...andersonbr-patch-1) https://github.com/bitcoin/bitcoin/pull/19135
3632020-06-01T23:04:36 *** bitcoin-git has left #bitcoin-core-dev
3642020-06-01T23:21:07 *** Cory has quit IRC
3652020-06-01T23:21:16 <jarthur> promag: definitely, at least vs single RPC per HTTP request. A new HTTP request is expensive. From dynamic languages that have an expensive stack like Python and JavaScript, not having to go up and down the stack as much for multiple sends carries a performance benefit. JSON-RPC Pipelining is better on memory usage than batching, just harder to program support for.
3662020-06-01T23:22:23 <promag> at least vs single RPC per HTTP request <- yeah I don't mind in this case
3672020-06-01T23:24:06 <promag> so in the case the connection is established, only saving is on http protocol right?
3682020-06-01T23:25:13 <promag> because for the server batching is actually worse, at least memory wise
3692020-06-01T23:26:20 <promag> s/mind in /mean/
3702020-06-01T23:26:39 <aj> sipa: "after how much time are we okay with attackers knowing everything that was in the mempool at the time?" -- if 99.9% of tx's are relayed to 99.9% of nodes within X seconds, then 2*X seconds? (fsv of 2 and 99.9%)
3712020-06-01T23:27:11 <sipa> aj: maybe that's even to strong a question
3722020-06-01T23:27:43 <sipa> "after how much time beyond the time it takes to send an INV are we ok with attackers knowing our mempool"
3732020-06-01T23:28:10 <sipa> if the answer is: whenever we send an INV, attackers can know our entire mempool before that point... it's very easy
3742020-06-01T23:28:41 <jarthur> promag: right, assuming the server supports pipelining multiple requests on the same connection (like JSON-RPC 2.0 TCP Transport w/ JSON Splitting, Stratum Mining TCP Transport, Stratum Wallet TCP Transport etc), I don't see an advantage batching would have.
3752020-06-01T23:29:30 *** Cory has joined #bitcoin-core-dev
3762020-06-01T23:32:10 <sipa> aj: if so, we'd just keep track of the last timestamp when we sent out a tx INV, and respond to requests for anything that was in the mempool before that point
3772020-06-01T23:32:34 <sipa> we'd still need a relay pool + bloom filter for dealing with things not in the mempool
3782020-06-01T23:32:44 <aj> sipa: "whenever we send an INV, an attacker can know the presence or absence of every tx that entered our mempool prior to the latest tx in that INV" maybe. i don't see a lot of benefit to doing much else, since an attacker could just make more connections to get around it?
3792020-06-01T23:33:03 <sipa> but the latter can go away once fast NOTFOUND handling is widespread on the network
3802020-06-01T23:38:02 <aj> sipa: is this protecting against anything other than tracing transaction sources?
3812020-06-01T23:38:13 <sipa> i don't think so
3822020-06-01T23:42:42 *** justanotheruser has quit IRC
3832020-06-01T23:51:03 <sipa> aj: here is a downside: for a very new connection, by observing the difference between what we actually announce to a peer, and what they can request (after our first INV)... they get an exact point distinguishing transaction we learned right before and right after the connection was created
3842020-06-01T23:54:14 <aj> sipa: ha. could hack around that by not sending the first INV worth of tx's to them?
3852020-06-01T23:55:43 <sipa> does that help?
3862020-06-01T23:56:02 <sipa> right, it does a bit
3872020-06-01T23:56:57 <aj> sipa: it makes it no more leaky than anytime you get an INV after the two prior INVs had less than 100 txids, i think?
3882020-06-01T23:57:29 <aj> wish it was easier to keep all the relay related rules in my head at the same time
3892020-06-01T23:59:16 *** justanotheruser has joined #bitcoin-core-dev