12020-06-02T00:00:03  *** chrippa has quit IRC
  22020-06-02T00:00:32  *** jb55 has quit IRC
  32020-06-02T00:01:33  *** jb55 has joined #bitcoin-core-dev
  42020-06-02T00:04:25  *** proofofkeags has quit IRC
  52020-06-02T00:04:34  <sipa> where does the number 100 come from?
  62020-06-02T00:04:52  *** proofofkeags has joined #bitcoin-core-dev
  72020-06-02T00:09:18  *** proofofkeags has quit IRC
  82020-06-02T00:09:51  *** surja795 has joined #bitcoin-core-dev
  92020-06-02T00:12:06  <aj> sipa: sorry 35 not 100; if you get less than that in a single message, it means you've emptied setInventoryTxToSend
 102020-06-02T00:13:32  <sipa> right
 112020-06-02T00:16:15  <aj> sipa: which brings you back to knowing about a timepoint, but the timepoint's chosen by the victim's poisson schedule, not the attacker's choice of when to connect?
 122020-06-02T00:16:15  *** surja795 has quit IRC
 132020-06-02T00:16:49  *** surja795 has joined #bitcoin-core-dev
 142020-06-02T00:20:09  <phantomcircuit> promag, it depends on which rpc calls you're making
 152020-06-02T00:20:31  <promag> how so?
 162020-06-02T00:21:04  <phantomcircuit> if you're making lots of fast calls it will matter, if you make a few slow calls you won't even notice
 172020-06-02T00:22:34  *** Darki has joined #bitcoin-core-dev
 182020-06-02T00:27:13  *** troygiorshev has joined #bitcoin-core-dev
 192020-06-02T00:32:02  *** troygiorshev has quit IRC
 202020-06-02T00:35:13  <promag> phantomcircuit: #5050
 212020-06-02T00:35:15  <gribble> https://github.com/bitcoin/bitcoin/issues/5050 | contrib: Use batched JSON-RPC in linearize.py for speedup by laanwj · Pull Request #5050 · bitcoin/bitcoin · GitHub
 222020-06-02T00:41:23  <sipa> aj: it feels fragile to rely on that
 232020-06-02T00:42:11  <phantomcircuit> promag, yeah the getblockhash rpc is probably the biggest win for batching, ages ago i implemented a getblockhashes that took a range but it was too craptastic for a pr
 242020-06-02T00:45:15  <aj> sipa: yes, it does
 252020-06-02T00:45:24  <promag> phantomcircuit: right
 262020-06-02T00:49:43  <sipa> aj: so WDYT about relay pool 2 minutes, bloom filter per peer for last (whatever can be relayed in 2 minutes) transactions, things can be requested if they're in the bloom filter OR in mempool and older than 2 minutes OR older than the last BIP35 response; BIP35 responses don't go into the bloom filter
 272020-06-02T00:51:17  <aj> oh, i see, bitcoin does 7tx/second because that's 420tx/minute -- blazing fast
 282020-06-02T00:51:44  <sipa> ?
 292020-06-02T00:52:00  <aj> "420 blaze it" nevermind
 302020-06-02T00:52:16  <phantomcircuit> ok so now i have a keypool problem, i've generated a list of scripPubKeys and can get notified when the keypool changes... but this is in a tight loop and im not sure if the NotifyCanGetAddressesChanged thing is guaranteed to run before anything else
 312020-06-02T00:52:26  <phantomcircuit> also it's kind of ugly to use a callback here
 322020-06-02T00:52:47  <aj> sipa: why not do bip35 via bloom as well?
 332020-06-02T00:53:06  <sipa> aj: it would easily overflow the filter
 342020-06-02T00:53:56  <aj> right, right
 352020-06-02T00:54:22  <sipa> unless the filter is made much larger
 362020-06-02T00:56:26  <aj> yeah, i was thinking of making it so bip35 wouldn't let you see stuff that hadn't made it into the bloom filter, but seems too complicated, esp if we think bip35 is only for trusted-ish peers
 372020-06-02T00:56:50  <sipa> you have to explicitly enable bip37, or whitelist the peer
 382020-06-02T00:56:52  *** promag has quit IRC
 392020-06-02T01:00:35  <aj> so "whatever can be relayed in 2 minutes" ~= 840 tx for inbound, 2110 tx for outbound? i think it'd make sense to be "bloom filter (for whatever can be relayed in 1.5*X minutes) OR in the mempool and older than X minutes" so there's no weird, exploitable gaps?
 402020-06-02T01:06:44  <sipa> hmm, what kind of gaps?
 412020-06-02T01:07:27  <sipa> the rolling bloom filter is already maintaining between 1.5*x and x entries
 422020-06-02T01:07:59  <aj> sipa: as in txs drop out of the bloom filter in <2m, because your poisson timing goes really quick by random chance?
 432020-06-02T01:08:57  <aj> i guess there's 24 intervals in 2minutes, so 1.5x is probably vast overkill
 442020-06-02T01:09:03  <sipa> ah!
 452020-06-02T01:09:13  <sipa> this calls for some statistics
 462020-06-02T01:09:47  *** AaronvanW has quit IRC
 472020-06-02T01:09:54  <aj> (when you said "ah!" i thought, "oh no, a spider??", now i wish it were just that)
 482020-06-02T01:12:37  *** Morton29Crooks has joined #bitcoin-core-dev
 492020-06-02T01:16:08  *** EagleTM has quit IRC
 502020-06-02T01:17:01  <sipa> so this is a poisson distribution with lambda=24 (we expect 24 inv broadcasts in 2 minutes)... there could be up to 50 broadcasts however in 2 minutes, with probability up to 99.9999%
 512020-06-02T01:18:28  <aj> lambda=60 for outbounds, i guess?
 522020-06-02T01:18:50  *** joerodgers has quit IRC
 532020-06-02T01:19:02  <sipa> yup, and there we need to account for up to 95 broadcasts in 2 minutes
 542020-06-02T01:19:11  <sipa> (to have 99.9999% probability)
 552020-06-02T01:23:29  <aj> means about 1800 and 3500 txs for 9.7kB and 19kB filters?
 562020-06-02T01:24:44  *** troygiorshev has joined #bitcoin-core-dev
 572020-06-02T01:24:44  *** Morton29Crooks has quit IRC
 582020-06-02T01:25:24  <sipa> more accurate numbers: 51 and 100
 592020-06-02T01:27:41  <midnight> har har "blazing fast"
 602020-06-02T01:28:40  *** AaronvanW has joined #bitcoin-core-dev
 612020-06-02T01:33:14  <aj> sipa: 52 would stay just under 10kB; 105 would be just under 20kB. so about 1.3M in total with max peers?
 622020-06-02T01:35:00  <sipa> i think anything in the order of 10s of kilobytes per peer is negligable
 632020-06-02T01:39:44  <aj> yeah
 642020-06-02T01:41:28  <sipa> could just go for an even 3500 sized filter for everyone
 652020-06-02T02:44:57  *** mol has joined #bitcoin-core-dev
 662020-06-02T02:46:07  *** troygiorshev has quit IRC
 672020-06-02T02:47:27  *** mol_ has quit IRC
 682020-06-02T03:00:02  *** Darki has quit IRC
 692020-06-02T03:01:14  *** Highway61 has quit IRC
 702020-06-02T03:03:11  *** mol_ has joined #bitcoin-core-dev
 712020-06-02T03:04:09  *** mol has quit IRC
 722020-06-02T03:04:46  *** surja795 has quit IRC
 732020-06-02T03:09:25  *** troygiorshev has joined #bitcoin-core-dev
 742020-06-02T03:10:37  *** mol_ has quit IRC
 752020-06-02T03:15:08  *** troygiorshev has quit IRC
 762020-06-02T03:23:56  *** mol has joined #bitcoin-core-dev
 772020-06-02T03:33:18  *** mol has quit IRC
 782020-06-02T03:37:54  *** mol has joined #bitcoin-core-dev
 792020-06-02T03:51:31  *** jarthur has quit IRC
 802020-06-02T03:56:21  *** ajbiz11 has joined #bitcoin-core-dev
 812020-06-02T04:08:45  *** tylerdmace has quit IRC
 822020-06-02T04:23:23  *** vasild has quit IRC
 832020-06-02T04:24:46  *** Deacyde has joined #bitcoin-core-dev
 842020-06-02T04:25:19  *** vasild has joined #bitcoin-core-dev
 852020-06-02T04:27:58  *** mol_ has joined #bitcoin-core-dev
 862020-06-02T04:31:15  *** mol has quit IRC
 872020-06-02T04:50:30  *** bitcoin-git has joined #bitcoin-core-dev
 882020-06-02T04:50:30  <bitcoin-git> [bitcoin] laanwj opened pull request #19138: doc: Merge 0.20.0 release notes from wiki (0.20...2020_06_0.20_relnot) https://github.com/bitcoin/bitcoin/pull/19138
 892020-06-02T04:50:41  *** bitcoin-git has left #bitcoin-core-dev
 902020-06-02T05:11:07  *** IGHOR has quit IRC
 912020-06-02T05:14:58  *** IGHOR has joined #bitcoin-core-dev
 922020-06-02T05:24:17  *** Guest13 has joined #bitcoin-core-dev
 932020-06-02T05:27:43  *** Guest13 has left #bitcoin-core-dev
 942020-06-02T05:30:18  *** marcoagner has joined #bitcoin-core-dev
 952020-06-02T05:44:41  *** achow101 has quit IRC
 962020-06-02T05:47:57  <hebasto> MarcoFalke: how to preserve travis log with an intermittent error for issue submitting? If I re-run build log pointed by url will be re-written...
 972020-06-02T05:48:02  <hebasto> https://travis-ci.org/github/bitcoin/bitcoin/jobs/692067912
 982020-06-02T05:52:20  *** cncr04s_ has left #bitcoin-core-dev
 992020-06-02T05:53:05  *** cncr04s_ has joined #bitcoin-core-dev
1002020-06-02T05:54:32  *** cncr04s_ has quit IRC
1012020-06-02T05:55:56  *** cncr04s has joined #bitcoin-core-dev
1022020-06-02T05:56:43  *** Kiminuo has joined #bitcoin-core-dev
1032020-06-02T06:00:02  *** ajbiz11 has quit IRC
1042020-06-02T06:01:02  <cncr04s> can any one explain this "[00:47:45] cncr04s #bitcoin-core-dev Cannot change nickname while banned/quieted on channel" I have not spoken on this channel in weeks so...
1052020-06-02T06:03:00  <gwillen> cncr04s: assuming someone doesn't come correct me, and given that you appear not to be banned or quieted now, I would assume it was an accident / collateral damage of some other ban
1062020-06-02T06:03:48  *** achow101 has joined #bitcoin-core-dev
1072020-06-02T06:12:37  *** Guyver2 has joined #bitcoin-core-dev
1082020-06-02T06:14:51  *** bitcoin-git has joined #bitcoin-core-dev
1092020-06-02T06:14:51  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/6f7f94a27687...60e8e74d1085
1102020-06-02T06:14:52  <bitcoin-git> bitcoin/0.20 1dfad42 Wladimir J. van der Laan: doc: Merge 0.20.0 release notes from wiki
1112020-06-02T06:14:52  <bitcoin-git> bitcoin/0.20 60e8e74 fanquake: Merge #19138: doc: Merge 0.20.0 release notes from wiki
1122020-06-02T06:14:54  *** bitcoin-git has left #bitcoin-core-dev
1132020-06-02T06:15:11  *** bitcoin-git has joined #bitcoin-core-dev
1142020-06-02T06:15:11  <bitcoin-git> [bitcoin] fanquake merged pull request #19138: doc: Merge 0.20.0 release notes from wiki (0.20...2020_06_0.20_relnot) https://github.com/bitcoin/bitcoin/pull/19138
1152020-06-02T06:15:12  *** bitcoin-git has left #bitcoin-core-dev
1162020-06-02T06:21:51  *** paulk-collins has joined #bitcoin-core-dev
1172020-06-02T06:36:28  *** kristapsk has quit IRC
1182020-06-02T06:36:51  *** kristapsk has joined #bitcoin-core-dev
1192020-06-02T06:42:05  *** morcos has quit IRC
1202020-06-02T06:48:46  *** bitcoin-git has joined #bitcoin-core-dev
1212020-06-02T06:48:46  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9bc7751cadbd...44307449f758
1222020-06-02T06:48:46  <bitcoin-git> bitcoin/master 4f49d52 João Barbosa: gui, refactor: Register Qt meta types in application constructor
1232020-06-02T06:48:47  <bitcoin-git> bitcoin/master 4430744 Jonas Schnelli: Merge #19104: gui, refactor: Register Qt meta types in application constru...
1242020-06-02T06:48:48  *** bitcoin-git has left #bitcoin-core-dev
1252020-06-02T06:49:05  *** bitcoin-git has joined #bitcoin-core-dev
1262020-06-02T06:49:05  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #19104: gui, refactor: Register Qt meta types in application constructor (master...2020-05-register-metatypes) https://github.com/bitcoin/bitcoin/pull/19104
1272020-06-02T06:49:07  *** bitcoin-git has left #bitcoin-core-dev
1282020-06-02T06:49:30  *** morcos has joined #bitcoin-core-dev
1292020-06-02T07:04:31  *** guest534543 has joined #bitcoin-core-dev
1302020-06-02T07:08:03  *** Kiminuo has quit IRC
1312020-06-02T07:09:27  *** guest534543 has quit IRC
1322020-06-02T07:15:24  *** promag has joined #bitcoin-core-dev
1332020-06-02T07:17:09  *** votesmith has quit IRC
1342020-06-02T07:19:59  *** promag has quit IRC
1352020-06-02T07:30:29  *** promag has joined #bitcoin-core-dev
1362020-06-02T07:34:50  *** promag has quit IRC
1372020-06-02T07:45:40  *** bitcoin-git has joined #bitcoin-core-dev
1382020-06-02T07:45:40  *** EagleTM has joined #bitcoin-core-dev
1392020-06-02T07:45:41  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/60e8e74d1085...a62f0ed64f8b
1402020-06-02T07:45:41  <bitcoin-git> bitcoin/0.20 808c8d1 Wladimir J. van der Laan: build: Set rc to 0 for -final
1412020-06-02T07:45:42  <bitcoin-git> bitcoin/0.20 a62f0ed Wladimir J. van der Laan: doc: Manpages update pre-final
1422020-06-02T07:45:44  *** bitcoin-git has left #bitcoin-core-dev
1432020-06-02T07:46:19  *** bitcoin-git has joined #bitcoin-core-dev
1442020-06-02T07:46:19  <bitcoin-git> [bitcoin] laanwj pushed tag v0.20.0: https://github.com/bitcoin/bitcoin/compare/v0.20.0
1452020-06-02T07:46:30  *** bitcoin-git has left #bitcoin-core-dev
1462020-06-02T07:46:32  <fanquake> 🚀
1472020-06-02T07:47:38  <sipa>     🚀
1482020-06-02T07:47:49  <luke-jr> &nbsp;
1492020-06-02T07:51:43  <wumpus> ^^
1502020-06-02T07:53:48  *** jonatack has quit IRC
1512020-06-02T08:05:23  <CubicEarth> strong work devs!
1522020-06-02T08:13:22  *** kljasdfvv has joined #bitcoin-core-dev
1532020-06-02T08:14:10  *** promag has joined #bitcoin-core-dev
1542020-06-02T08:18:16  *** jonatack has joined #bitcoin-core-dev
1552020-06-02T08:32:03  *** afk11` has quit IRC
1562020-06-02T08:34:40  *** afk11` has joined #bitcoin-core-dev
1572020-06-02T09:00:03  *** paulk-collins has quit IRC
1582020-06-02T09:05:19  *** Guyver2 has quit IRC
1592020-06-02T09:22:23  *** BjarniRunar1 has joined #bitcoin-core-dev
1602020-06-02T09:32:08  <emzy>      🚀
1612020-06-02T09:41:07  *** shesek has quit IRC
1622020-06-02T10:03:22  *** Bettye82Leuschke has joined #bitcoin-core-dev
1632020-06-02T10:13:18  *** surja795 has joined #bitcoin-core-dev
1642020-06-02T10:15:02  *** Bettye82Leuschke has quit IRC
1652020-06-02T10:30:55  *** setpill has joined #bitcoin-core-dev
1662020-06-02T10:34:56  *** bitcoin-git has joined #bitcoin-core-dev
1672020-06-02T10:34:56  <bitcoin-git> [bitcoin] hebasto closed pull request #18731: refactor: Make CCheckQueue RAII-styled (master...200421-queue-raii) https://github.com/bitcoin/bitcoin/pull/18731
1682020-06-02T10:34:57  *** bitcoin-git has left #bitcoin-core-dev
1692020-06-02T10:35:16  *** bitcoin-git has joined #bitcoin-core-dev
1702020-06-02T10:35:17  <bitcoin-git> [bitcoin] hebasto reopened pull request #18731: refactor: Make CCheckQueue RAII-styled (master...200421-queue-raii) https://github.com/bitcoin/bitcoin/pull/18731
1712020-06-02T10:35:18  *** bitcoin-git has left #bitcoin-core-dev
1722020-06-02T10:43:54  *** bitcoin-git has joined #bitcoin-core-dev
1732020-06-02T10:43:55  <bitcoin-git> [bitcoin] hebasto closed pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
1742020-06-02T10:43:55  *** bitcoin-git has left #bitcoin-core-dev
1752020-06-02T10:44:09  *** bitcoin-git has joined #bitcoin-core-dev
1762020-06-02T10:44:10  <bitcoin-git> [bitcoin] hebasto reopened pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
1772020-06-02T10:44:10  *** bitcoin-git has left #bitcoin-core-dev
1782020-06-02T10:47:06  *** bitcoin-git has joined #bitcoin-core-dev
1792020-06-02T10:47:06  <bitcoin-git> [bitcoin] hebasto closed pull request #18896: qt: Reset toolbar after all wallets are closed (master...200506-toolbar) https://github.com/bitcoin/bitcoin/pull/18896
1802020-06-02T10:47:07  *** bitcoin-git has left #bitcoin-core-dev
1812020-06-02T10:47:25  *** bitcoin-git has joined #bitcoin-core-dev
1822020-06-02T10:47:25  <bitcoin-git> [bitcoin] hebasto reopened pull request #18896: qt: Reset toolbar after all wallets are closed (master...200506-toolbar) https://github.com/bitcoin/bitcoin/pull/18896
1832020-06-02T10:47:26  *** bitcoin-git has left #bitcoin-core-dev
1842020-06-02T10:47:51  *** surja795 has quit IRC
1852020-06-02T11:03:38  *** Pavlenex has joined #bitcoin-core-dev
1862020-06-02T11:05:40  *** bitcoin-git has joined #bitcoin-core-dev
1872020-06-02T11:05:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/44307449f758...1f7fe59460db
1882020-06-02T11:05:41  <bitcoin-git> bitcoin/master fa9c675 MarcoFalke: Limit scope of all global std::once_flag
1892020-06-02T11:05:42  <bitcoin-git> bitcoin/master 1f7fe59 MarcoFalke: Merge #19111: Limit scope of all global std::once_flag
1902020-06-02T11:05:43  *** bitcoin-git has left #bitcoin-core-dev
1912020-06-02T11:06:00  *** bitcoin-git has joined #bitcoin-core-dev
1922020-06-02T11:06:01  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19111: Limit scope of all global std::once_flag (master...2005-NoGlobalOnce) https://github.com/bitcoin/bitcoin/pull/19111
1932020-06-02T11:06:05  *** bitcoin-git has left #bitcoin-core-dev
1942020-06-02T11:15:15  *** bitcoin-git has joined #bitcoin-core-dev
1952020-06-02T11:15:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f7fe59460db...45a1489997a5
1962020-06-02T11:15:17  <bitcoin-git> bitcoin/master eeeed51 MarcoFalke: test: pep-8 wallet_hd
1972020-06-02T11:15:17  <bitcoin-git> bitcoin/master fa7d3a8 MarcoFalke: test: Add missing sync_blocks to wallet_hd
1982020-06-02T11:15:18  <bitcoin-git> bitcoin/master 45a1489 MarcoFalke: Merge #19122: test: Add missing sync_blocks to wallet_hd
1992020-06-02T11:15:19  *** bitcoin-git has left #bitcoin-core-dev
2002020-06-02T11:15:40  *** bitcoin-git has joined #bitcoin-core-dev
2012020-06-02T11:15:41  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19122: test: Add missing sync_blocks to wallet_hd (master...2005-testSyncBlocksHd) https://github.com/bitcoin/bitcoin/pull/19122
2022020-06-02T11:15:41  *** bitcoin-git has left #bitcoin-core-dev
2032020-06-02T11:20:49  *** Relis has quit IRC
2042020-06-02T11:32:22  *** jb55 has quit IRC
2052020-06-02T11:33:28  *** bitcoin-git has joined #bitcoin-core-dev
2062020-06-02T11:33:29  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/45a1489997a5...9e8bd217cd2a
2072020-06-02T11:33:30  <bitcoin-git> bitcoin/master 5495fa5 Jeremy Rubin: Add Hash Padding Microbenchmarks
2082020-06-02T11:33:30  <bitcoin-git> bitcoin/master 152e8ba Jeremy Rubin: Use salted hasher instead of nonce in sigcache
2092020-06-02T11:33:31  <bitcoin-git> bitcoin/master 9e8bd21 MarcoFalke: Merge #13204: Faster sigcache nonce
2102020-06-02T11:33:33  *** bitcoin-git has left #bitcoin-core-dev
2112020-06-02T11:35:23  *** bitcoin-git has joined #bitcoin-core-dev
2122020-06-02T11:35:23  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #13204: Faster sigcache nonce (master...faster-sigcache-nonce) https://github.com/bitcoin/bitcoin/pull/13204
2132020-06-02T11:35:25  *** bitcoin-git has left #bitcoin-core-dev
2142020-06-02T11:35:58  *** jb55 has joined #bitcoin-core-dev
2152020-06-02T11:54:37  *** bitcoin-git has joined #bitcoin-core-dev
2162020-06-02T11:54:37  <bitcoin-git> [bitcoin] practicalswift opened pull request #19140: tests: Avoid fuzzer-specific nullptr dereference in libevent when handling PROXY requests (master...fuzzers-libevent-proxy) https://github.com/bitcoin/bitcoin/pull/19140
2172020-06-02T11:54:38  *** bitcoin-git has left #bitcoin-core-dev
2182020-06-02T11:54:56  *** promag has quit IRC
2192020-06-02T12:00:01  *** BjarniRunar1 has quit IRC
2202020-06-02T12:02:25  *** Zenton has quit IRC
2212020-06-02T12:02:56  *** murr4y has quit IRC
2222020-06-02T12:06:56  *** bitcoin-git has joined #bitcoin-core-dev
2232020-06-02T12:06:56  <bitcoin-git> [bitcoin] hebasto closed pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
2242020-06-02T12:06:57  *** bitcoin-git has left #bitcoin-core-dev
2252020-06-02T12:07:16  *** bitcoin-git has joined #bitcoin-core-dev
2262020-06-02T12:07:16  <bitcoin-git> [bitcoin] hebasto reopened pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
2272020-06-02T12:07:17  *** bitcoin-git has left #bitcoin-core-dev
2282020-06-02T12:14:55  *** Relis has joined #bitcoin-core-dev
2292020-06-02T12:21:00  *** Eprom has joined #bitcoin-core-dev
2302020-06-02T12:26:15  *** Pavlenex has quit IRC
2312020-06-02T12:36:03  *** Highway61 has joined #bitcoin-core-dev
2322020-06-02T12:45:14  *** Eprom has quit IRC
2332020-06-02T12:51:44  *** promag has joined #bitcoin-core-dev
2342020-06-02T12:56:43  *** promag has quit IRC
2352020-06-02T12:56:57  *** Zenton has joined #bitcoin-core-dev
2362020-06-02T13:03:48  *** securekim has joined #bitcoin-core-dev
2372020-06-02T13:05:08  *** securekim has quit IRC
2382020-06-02T13:06:51  *** murr4y has joined #bitcoin-core-dev
2392020-06-02T13:12:20  *** cltrbreak_MAD2 has quit IRC
2402020-06-02T13:12:48  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
2412020-06-02T13:26:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2422020-06-02T13:38:06  *** bitcoin-git has joined #bitcoin-core-dev
2432020-06-02T13:38:07  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #18815: bench: Add logging benchmark (master...2004-benchLog) https://github.com/bitcoin/bitcoin/pull/18815
2442020-06-02T13:38:07  *** bitcoin-git has left #bitcoin-core-dev
2452020-06-02T13:38:21  *** bitcoin-git has joined #bitcoin-core-dev
2462020-06-02T13:38:22  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18815: bench: Add logging benchmark (master...2004-benchLog) https://github.com/bitcoin/bitcoin/pull/18815
2472020-06-02T13:38:22  *** bitcoin-git has left #bitcoin-core-dev
2482020-06-02T13:51:07  *** dongcarl has joined #bitcoin-core-dev
2492020-06-02T14:03:39  *** icota[m] has quit IRC
2502020-06-02T14:07:39  *** Guest94234 has joined #bitcoin-core-dev
2512020-06-02T14:12:51  *** dfmb_ has joined #bitcoin-core-dev
2522020-06-02T14:12:57  *** dfmbbtc has joined #bitcoin-core-dev
2532020-06-02T14:13:15  *** dfmbbtc has quit IRC
2542020-06-02T14:20:45  *** dfmb_ has quit IRC
2552020-06-02T14:28:08  *** Guest94234 has quit IRC
2562020-06-02T14:28:30  *** mol_ has quit IRC
2572020-06-02T14:29:30  *** tomkap1 has joined #bitcoin-core-dev
2582020-06-02T14:30:12  <jonasschnelli> I’m macOS code-signing the 0.20 release in a few hours.
2592020-06-02T14:35:32  *** tomkap1 has quit IRC
2602020-06-02T14:35:38  *** bitcoin-git has joined #bitcoin-core-dev
2612020-06-02T14:35:39  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9e8bd217cd2a...5879bfa9a541
2622020-06-02T14:35:39  <bitcoin-git> bitcoin/master 5555d97 MarcoFalke: wallet: Make PeriodicFlush uninterruptible
2632020-06-02T14:35:40  <bitcoin-git> bitcoin/master fa7b885 MarcoFalke: walletdb: Remove unsed boost/thread
2642020-06-02T14:35:40  <bitcoin-git> bitcoin/master fa1c74f MarcoFalke: wallet: Remove unused boost::thread_interrupted
2652020-06-02T14:35:42  *** bitcoin-git has left #bitcoin-core-dev
2662020-06-02T14:36:13  *** bitcoin-git has joined #bitcoin-core-dev
2672020-06-02T14:36:13  <bitcoin-git> [bitcoin] fanquake merged pull request #18792: wallet: Remove boost from PeriodicFlush (master...2004-walletNoBoostPeriodicFlush) https://github.com/bitcoin/bitcoin/pull/18792
2682020-06-02T14:36:24  *** bitcoin-git has left #bitcoin-core-dev
2692020-06-02T14:45:02  *** mol has joined #bitcoin-core-dev
2702020-06-02T14:58:03  *** zalun1 has joined #bitcoin-core-dev
2712020-06-02T15:00:01  *** zalun1 has quit IRC
2722020-06-02T15:06:14  *** mol has quit IRC
2732020-06-02T15:09:37  *** promag has joined #bitcoin-core-dev
2742020-06-02T15:25:05  *** proofofkeags has joined #bitcoin-core-dev
2752020-06-02T15:28:25  *** owowo has quit IRC
2762020-06-02T15:29:18  *** jb55 has quit IRC
2772020-06-02T15:29:19  *** morcos has quit IRC
2782020-06-02T15:29:19  *** ghost43 has quit IRC
2792020-06-02T15:29:19  *** vasild has quit IRC
2802020-06-02T15:29:19  *** sdaftuar has quit IRC
2812020-06-02T15:29:19  *** afk11` has quit IRC
2822020-06-02T15:29:19  *** bitdex has quit IRC
2832020-06-02T15:29:19  *** mrostecki has quit IRC
2842020-06-02T15:29:19  *** sipa has quit IRC
2852020-06-02T15:29:19  *** kristapsk has quit IRC
2862020-06-02T15:29:19  *** SiAnDoG has quit IRC
2872020-06-02T15:32:02  *** jb55 has joined #bitcoin-core-dev
2882020-06-02T15:32:12  *** morcos has joined #bitcoin-core-dev
2892020-06-02T15:32:38  *** ghost43 has joined #bitcoin-core-dev
2902020-06-02T15:33:40  <jonasschnelli> achow101: ping for win 0.20 signatures (macOS are pushed)
2912020-06-02T15:34:20  *** owowo has joined #bitcoin-core-dev
2922020-06-02T15:34:30  *** mrostecki has joined #bitcoin-core-dev
2932020-06-02T15:34:52  <achow101> oh! I just woke up
2942020-06-02T15:34:53  *** afk11` has joined #bitcoin-core-dev
2952020-06-02T15:35:13  *** justanotheruser has quit IRC
2962020-06-02T15:35:18  <achow101> i'll get those done soon
2972020-06-02T15:35:31  *** Talkless has joined #bitcoin-core-dev
2982020-06-02T15:36:29  *** Talkless has joined #bitcoin-core-dev
2992020-06-02T15:39:31  *** vasild has joined #bitcoin-core-dev
3002020-06-02T15:40:28  *** sipa has joined #bitcoin-core-dev
3012020-06-02T15:41:14  *** bitdex has joined #bitcoin-core-dev
3022020-06-02T15:41:44  *** troygiorshev has joined #bitcoin-core-dev
3032020-06-02T15:51:04  *** justanotheruser has joined #bitcoin-core-dev
3042020-06-02T15:51:18  *** rob01 has joined #bitcoin-core-dev
3052020-06-02T15:56:43  *** belcher has quit IRC
3062020-06-02T16:02:03  *** sdaftuar has joined #bitcoin-core-dev
3072020-06-02T16:03:49  *** proofofkeags has quit IRC
3082020-06-02T16:04:12  *** proofofkeags has joined #bitcoin-core-dev
3092020-06-02T16:04:17  *** promag has quit IRC
3102020-06-02T16:05:11  *** icemc has joined #bitcoin-core-dev
3112020-06-02T16:06:42  *** icemc has quit IRC
3122020-06-02T16:20:08  *** jarthur has joined #bitcoin-core-dev
3132020-06-02T16:20:25  *** vasild_ has joined #bitcoin-core-dev
3142020-06-02T16:21:14  *** Pavlenex has joined #bitcoin-core-dev
3152020-06-02T16:23:23  *** vasild has quit IRC
3162020-06-02T16:23:24  *** vasild_ is now known as vasild
3172020-06-02T16:29:34  <stevenroose> Pruned nodes can still provide responses to all `getblockheader` RPCs, right?
3182020-06-02T16:29:46  <sipa> yes
3192020-06-02T16:31:18  <achow101> gitian builders: 0.20.0 sigs are pushed
3202020-06-02T16:40:34  *** Pavlenex has quit IRC
3212020-06-02T16:52:07  *** salim has joined #bitcoin-core-dev
3222020-06-02T16:54:40  *** dfmb_ has joined #bitcoin-core-dev
3232020-06-02T17:03:57  *** setpill has quit IRC
3242020-06-02T17:04:00  *** ghost43 has quit IRC
3252020-06-02T17:04:29  *** ghost43 has joined #bitcoin-core-dev
3262020-06-02T17:06:32  <jonatack> jonasschnelli: achow101: thanks
3272020-06-02T17:09:03  *** mol has joined #bitcoin-core-dev
3282020-06-02T17:11:28  *** dr-orlovsky has joined #bitcoin-core-dev
3292020-06-02T17:12:07  *** troygiorshev has quit IRC
3302020-06-02T17:14:15  *** Guyver2 has joined #bitcoin-core-dev
3312020-06-02T17:15:42  *** kristapsk has joined #bitcoin-core-dev
3322020-06-02T17:26:17  *** promag has joined #bitcoin-core-dev
3332020-06-02T17:28:52  *** justanotheruser has quit IRC
3342020-06-02T17:29:13  *** justanotheruser has joined #bitcoin-core-dev
3352020-06-02T17:30:35  *** promag has quit IRC
3362020-06-02T17:32:39  *** rob01 has quit IRC
3372020-06-02T17:34:19  *** promag has joined #bitcoin-core-dev
3382020-06-02T17:42:11  *** bitcoin-git has joined #bitcoin-core-dev
3392020-06-02T17:42:12  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19142: validation: Make VerifyDB level 4 interruptible (master...2006-valVerifyDbInterrupt4) https://github.com/bitcoin/bitcoin/pull/19142
3402020-06-02T17:42:15  *** bitcoin-git has left #bitcoin-core-dev
3412020-06-02T17:48:31  *** promag has quit IRC
3422020-06-02T17:55:44  *** promag has joined #bitcoin-core-dev
3432020-06-02T17:58:50  *** ironmarx has joined #bitcoin-core-dev
3442020-06-02T18:00:01  *** ironmarx has quit IRC
3452020-06-02T18:15:47  *** justanotheruser has quit IRC
3462020-06-02T18:20:55  *** kierank1 has joined #bitcoin-core-dev
3472020-06-02T18:28:19  *** promag has quit IRC
3482020-06-02T18:36:03  <luke-jr> can someone add #18818 to HPR?
3492020-06-02T18:36:08  <gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
3502020-06-02T18:47:15  *** cltrbreak_MAD2 has quit IRC
3512020-06-02T18:47:40  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
3522020-06-02T18:47:52  *** troygiorshev has joined #bitcoin-core-dev
3532020-06-02T18:51:41  *** justanotheruser has joined #bitcoin-core-dev
3542020-06-02T18:57:17  *** Talkless has quit IRC
3552020-06-02T19:01:30  *** roconnor has joined #bitcoin-core-dev
3562020-06-02T19:02:48  *** promag has joined #bitcoin-core-dev
3572020-06-02T19:06:06  *** proofofkeags has quit IRC
3582020-06-02T19:06:54  *** promag has quit IRC
3592020-06-02T19:08:01  *** proofofkeags has joined #bitcoin-core-dev
3602020-06-02T19:08:02  *** proofofkeags has quit IRC
3612020-06-02T19:08:15  *** proofofkeags has joined #bitcoin-core-dev
3622020-06-02T19:10:54  <phantomcircuit> ok i don't get it how am i supposed to use NotifyCanGetAddressesChanged ?
3632020-06-02T19:11:00  <phantomcircuit> BlueMatt, halp
3642020-06-02T19:11:10  <achow101> phantomcircuit: what are you trying to use it for?
3652020-06-02T19:11:57  <achow101> and how are you trying to use it?
3662020-06-02T19:13:02  <provoostenator> I can also gurantee Blue Matt will not know the answer, unless he's a secret wallet code admirer :-)
3672020-06-02T19:13:13  <BlueMatt> right, that.
3682020-06-02T19:13:33  <phantomcircuit> BlueMatt, hi
3692020-06-02T19:13:42  <BlueMatt> sup.
3702020-06-02T19:14:02  <phantomcircuit> achow101, im just trying to set a flag in CWallet to recalculate a list of script pubkeys for block filter index based rescanning
3712020-06-02T19:15:04  *** bitcoin-git has joined #bitcoin-core-dev
3722020-06-02T19:15:05  <bitcoin-git> [bitcoin] practicalswift opened pull request #19143: tests: Add fuzzing harnesses for CAutoFile, CBufferedFile, LoadExternalBlockFile and other FILE* consumers (master...fuzzers-FILE) https://github.com/bitcoin/bitcoin/pull/19143
3732020-06-02T19:15:13  *** bitcoin-git has left #bitcoin-core-dev
3742020-06-02T19:15:43  <achow101> phantomcircuit: if the list is persistent, can't you just add to it as new scriptpubkeys are generated?
3752020-06-02T19:16:22  *** troygiorshev has quit IRC
3762020-06-02T19:16:44  <phantomcircuit> achow101, there's a bunch of ways for the list to be changed now
3772020-06-02T19:16:59  *** dfmb_ has quit IRC
3782020-06-02T19:16:59  <achow101> NotifyCanGetAddressesChanged does not necessarily mean that a new scriptPubKey has been generated. it's used to indicate whether it's possible to even get a new address
3792020-06-02T19:17:51  <achow101> phantomcircuit: where?
3802020-06-02T19:18:23  <sipa> i think it's pretty much impossible to just incrementally update that list
3812020-06-02T19:18:42  *** marcoagner has quit IRC
3822020-06-02T19:18:47  <sipa> just inserting a new pubkey may cause some indirectly multisig combination with it inside p2sh/p2wsh to become marked IsMine
3832020-06-02T19:20:15  <achow101> but also why is the list persistent? I thought we had discussed previously that you should compute it at rescan time
3842020-06-02T19:20:24  <provoostenator> If someone picks up #15845 it should be significiantly less painful to just rescan the whole wallet history
3852020-06-02T19:20:30  <gribble> https://github.com/bitcoin/bitcoin/issues/15845 | wallet: Fast rescan with BIP157 block filters by MarcoFalke · Pull Request #15845 · bitcoin/bitcoin · GitHub
3862020-06-02T19:20:44  <achow101> provoostenator: I think that's what phantomcircuit is doing
3872020-06-02T19:20:53  <provoostenator> Ah OK, that's good news
3882020-06-02T19:21:26  *** troygiorshev has joined #bitcoin-core-dev
3892020-06-02T19:21:48  <sipa> achow101: i think the problem is that during rescan, new keys may be pulled from the keypool, which would require recomputing the list
3902020-06-02T19:22:10  <provoostenator> That was one of the bugs in the original implementation, at some point anyway, not sure if it was fixed.
3912020-06-02T19:22:12  <achow101> lock cs_wallet *ducks*
3922020-06-02T19:22:36  <phantomcircuit> provoostenator, that's what im doing and why im asking about it
3932020-06-02T19:22:48  <sipa> "this new rescan is super fast; one minor downside is that it deadlocks whenever it finds a new tx"
3942020-06-02T19:22:58  <provoostenator> Or just start the rescan from scratch if you had to expand the keypool :-)
3952020-06-02T19:23:35  <provoostenator> "this rescan runs in circles, but it does so really fast"
3962020-06-02T19:24:29  <phantomcircuit> really i just need a flag that says the keypool has been changed, but it seems like there's multiple places that can happen now so this callback is the thing to use
3972020-06-02T19:24:55  <achow101> provoostenator: and I think that brings us back to the phantomcircuit's original question about NotifyCanGetAddressesChanged as he needs a way to know whether to restart if the keypool changed
3982020-06-02T19:25:37  <achow101> phantomcircuit: NotifyCanGetAddressesChanged is a boost signal. you have to bind and connect to it from elsewhere
3992020-06-02T19:26:24  <phantomcircuit> it's a boost signal for whatever the current pwallet is i guess? it has no parameters
4002020-06-02T19:26:34  <achow101> yes
4012020-06-02T19:26:37  <achow101> it's a CWallet member
4022020-06-02T19:27:09  <achow101> (well ScriptPubKeyMan member too, but these end up in CWallet)
4032020-06-02T19:32:47  <provoostenator> Would it makes sense to have a skpman->keypool_update_at field?
4042020-06-02T19:34:06  *** ghost43 has quit IRC
4052020-06-02T19:34:35  *** ghost43 has joined #bitcoin-core-dev
4062020-06-02T19:36:04  <phantomcircuit> provoostenator, i was going to use an atomic bool flag since it doesn't really matter when it was updated just that it needs to be regenerated
4072020-06-02T19:36:22  <phantomcircuit> achow101, so can i use this-> within the callback? it doesn't seem like i can
4082020-06-02T19:36:56  <achow101> why wouldn't you be able to?
4092020-06-02T19:40:56  <sipa> boost callbacks happen in the same thread
4102020-06-02T19:41:03  <sipa> maybe that's what phantomcircuit is confused about?
4112020-06-02T19:41:58  *** promag has joined #bitcoin-core-dev
4122020-06-02T19:42:58  *** belcher has joined #bitcoin-core-dev
4132020-06-02T19:46:58  *** promag has quit IRC
4142020-06-02T19:53:24  *** promag has joined #bitcoin-core-dev
4152020-06-02T19:55:26  <phantomcircuit> oh right i was trying to use a lambda and i had the syntax very wrong
4162020-06-02T19:59:27  *** promag has quit IRC
4172020-06-02T20:06:14  *** Aliza has joined #bitcoin-core-dev
4182020-06-02T20:06:48  *** Aliza has quit IRC
4192020-06-02T20:16:12  *** SiAnDoG has joined #bitcoin-core-dev
4202020-06-02T20:16:50  *** SiAnDoG has quit IRC
4212020-06-02T20:25:47  *** promag has joined #bitcoin-core-dev
4222020-06-02T20:32:11  *** promag_ has joined #bitcoin-core-dev
4232020-06-02T20:38:38  *** promag_ has quit IRC
4242020-06-02T20:49:37  *** surja795 has joined #bitcoin-core-dev
4252020-06-02T21:00:01  *** kierank1 has quit IRC
4262020-06-02T21:04:03  *** sipa has quit IRC
4272020-06-02T21:04:54  *** Ahmad7Hodkiewicz has joined #bitcoin-core-dev
4282020-06-02T21:07:17  *** filchef has joined #bitcoin-core-dev
4292020-06-02T21:11:26  *** sipa has joined #bitcoin-core-dev
4302020-06-02T21:11:38  *** Chris_Stewart_5 has quit IRC
4312020-06-02T21:12:07  *** Ahmad7Hodkiewicz has quit IRC
4322020-06-02T21:30:48  *** mol_ has joined #bitcoin-core-dev
4332020-06-02T21:32:59  *** bitcoin-git has joined #bitcoin-core-dev
4342020-06-02T21:33:00  <bitcoin-git> [bitcoin] puchu opened pull request #19144: include QPainterPath to fix compile error with Qt 5.15 (0.20...0.20) https://github.com/bitcoin/bitcoin/pull/19144
4352020-06-02T21:33:01  *** bitcoin-git has left #bitcoin-core-dev
4362020-06-02T21:33:21  *** mol has quit IRC
4372020-06-02T21:35:36  <harding> wumpus: PR for the 0.20 release on BitcoinCore.org: https://github.com/bitcoin-core/bitcoincore.org/pull/703
4382020-06-02T21:41:34  *** Luke has joined #bitcoin-core-dev
4392020-06-02T21:46:05  *** surja795 has quit IRC
4402020-06-02T21:47:00  *** surja795 has joined #bitcoin-core-dev
4412020-06-02T21:47:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4422020-06-02T21:51:12  *** Luke has quit IRC
4432020-06-02T21:51:14  *** surja795 has quit IRC
4442020-06-02T21:54:00  *** jacob11 has joined #bitcoin-core-dev
4452020-06-02T21:55:50  *** bitcoin-git has joined #bitcoin-core-dev
4462020-06-02T21:55:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/a62f0ed64f8b...e42c959c1dcc
4472020-06-02T21:55:52  <bitcoin-git> bitcoin/0.20 2abe8cc Luke Dashjr: Bugfix: Include "csv","!segwit" in "rules"
4482020-06-02T21:55:53  <bitcoin-git> bitcoin/0.20 412d5fe Luke Dashjr: QA: feature_segwit: Check that template "rules" includes "!segwit" as appr...
4492020-06-02T21:55:54  <bitcoin-git> bitcoin/0.20 e42c959 MarcoFalke: Merge #19019: [0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key
4502020-06-02T21:55:55  *** bitcoin-git has left #bitcoin-core-dev
4512020-06-02T21:56:10  *** bitcoin-git has joined #bitcoin-core-dev
4522020-06-02T21:56:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19019: [0.20] Fix GBT: Restore "!segwit" and "csv" to "rules" key (0.20...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/19019
4532020-06-02T21:56:17  *** bitcoin-git has left #bitcoin-core-dev
4542020-06-02T21:56:21  *** Guyver2 has quit IRC
4552020-06-02T21:59:51  <promag> #18863 merge ready?
4562020-06-02T21:59:53  <gribble> https://github.com/bitcoin/bitcoin/issues/18863 | refactor: Drop unused CScriptVisitor return type by promag · Pull Request #18863 · bitcoin/bitcoin · GitHub
4572020-06-02T22:00:41  <phantomcircuit> sipa, the false positive rate for this seems really high, searching only for p2pkh on 12k keys none of which have actually been used im seeing a pretty consistent scroll of blocks matching
4582020-06-02T22:06:49  <phantomcircuit> "Empirical analysis also shows that was chosen as these parameters minimize the bandwidth utilized, considering both the expected number of blocks downloaded due to false positives and the size of the filters themselves." - BIP158
4592020-06-02T22:06:59  <phantomcircuit> that must only be true for pretty small filters
4602020-06-02T22:08:00  <achow101> phantomcircuit: are you sure there isn't a bug?
4612020-06-02T22:08:33  *** bitcoin-git has joined #bitcoin-core-dev
4622020-06-02T22:08:33  <bitcoin-git> [bitcoin] fjahr opened pull request #19145: [WIP] Allow hash_type options for gettxoutsetinfo (master...csi-3-muhash-rpc) https://github.com/bitcoin/bitcoin/pull/19145
4632020-06-02T22:08:34  *** bitcoin-git has left #bitcoin-core-dev
4642020-06-02T22:09:09  <phantomcircuit> achow101, pretty sure, it successfully finds all the blocks that do have keys in a regtest example and mostly doesn't false positive since each block only has a coinbase, im now benchmarking against the main chain and to say there's a lot of false positives would be quite the understatement
4652020-06-02T22:10:52  <phantomcircuit> achow101, i just updated #19116 with the exact code im running
4662020-06-02T22:10:54  <gribble> https://github.com/bitcoin/bitcoin/issues/19116 | [WIP] wallet: use BlockFilterIndex in ScanForWalletTransactions by pstratem · Pull Request #19116 · bitcoin/bitcoin · GitHub
4672020-06-02T22:11:10  <achow101> i'm gonna need to brush up on bip158 first
4682020-06-02T22:13:09  *** bitcoin-git has joined #bitcoin-core-dev
4692020-06-02T22:13:10  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5879bfa9a541...3657aee2d25c
4702020-06-02T22:13:11  <bitcoin-git> bitcoin/master b604c5c Russell Yanofsky: wallet: Minimal fix to restore conflicted transaction notifications
4712020-06-02T22:13:12  <bitcoin-git> bitcoin/master 7eaf86d Russell Yanofsky: trivial: Suggested cleanups to surrounding code
4722020-06-02T22:13:13  <bitcoin-git> bitcoin/master 3657aee MarcoFalke: Merge #18982: wallet: Minimal fix to restore conflicted transaction notifi...
4732020-06-02T22:13:14  *** bitcoin-git has left #bitcoin-core-dev
4742020-06-02T22:13:29  *** bitcoin-git has joined #bitcoin-core-dev
4752020-06-02T22:13:29  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18982: wallet: Minimal fix to restore conflicted transaction notifications (master...pr/cblock) https://github.com/bitcoin/bitcoin/pull/18982
4762020-06-02T22:13:30  *** bitcoin-git has left #bitcoin-core-dev
4772020-06-02T22:13:56  <sipa> phantomcircuit: i think bip158 was designed for much smaller sets of keys, yes
4782020-06-02T22:14:12  <sipa> *sets of sPKs
4792020-06-02T22:14:40  <sipa> it has an fprate of 1/784000
4802020-06-02T22:15:42  <sipa> so if you're matching with a set of 120000 sPKs you'd see a match for 120000/784000 = 1.5% of blocks
4812020-06-02T22:15:57  <sipa> i expect that's still a lot better than reading through all blocks
4822020-06-02T22:16:48  <sipa> eh, 12000 sPKs
4832020-06-02T22:17:24  <phantomcircuit> it took 53m using the block filters, currently running without to compare
4842020-06-02T22:17:52  <phantomcircuit> with them it's about equal time between the filter operations and sha256 which i assume is verifying merkle tree roots
4852020-06-02T22:18:08  <phantomcircuit> possibly saving a hash of the entire block in the block index would be a good idea?
4862020-06-02T22:18:17  <achow101> A default legacy wallet has at least 8000 sPKs
4872020-06-02T22:18:32  <achow101> so 12000 sPKs is not unreasonable
4882020-06-02T22:19:40  <phantomcircuit> yeah and im doing this cause i know there's wallets with way more than that
4892020-06-02T22:19:52  <phantomcircuit> i have a testnet wallet with like a million keys, most of which were actually used
4902020-06-02T22:20:35  <sipa> with a million keys the bip158 filter won't help
4912020-06-02T22:20:36  <achow101> phantomcircuit: that sounds like it'd match on the entire testnet chain with a pretty high true positive rate too
4922020-06-02T22:20:45  <sipa> you'd match every block
4932020-06-02T22:20:45  *** bitcoin-git has joined #bitcoin-core-dev
4942020-06-02T22:20:46  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19146: doc: Remove release note fragments of 0.20.1 release, Add release-notes-0.20.0 (master...2006-docRel) https://github.com/bitcoin/bitcoin/pull/19146
4952020-06-02T22:20:46  *** bitcoin-git has left #bitcoin-core-dev
4962020-06-02T22:21:50  <phantomcircuit> sipa, i guess i could add another index with different parameters?
4972020-06-02T22:22:19  <phantomcircuit> the size of the filter is pretty irrelevant if you're not sending it to anybody
4982020-06-02T22:22:40  <phantomcircuit> and im only hashing the wallet contents per block not the block contents
4992020-06-02T22:25:46  <sipa> phantomcircuit: maybe... but is that worth it? i expect that the number of wallets with million of keys is tiny, and when they need a rescan, it's typically a one time thing
5002020-06-02T22:28:49  *** surja795 has joined #bitcoin-core-dev
5012020-06-02T22:29:42  <luke-jr> fwiw, I added pbzx to my Gentoo overlay
5022020-06-02T22:33:23  *** surja795 has quit IRC
5032020-06-02T22:34:34  *** Highway61 has quit IRC
5042020-06-02T22:43:56  *** promag has quit IRC
5052020-06-02T22:48:10  <phantomcircuit> sipa, maybe just as an optional extra index? not something for everybody to be generating for sure
5062020-06-02T22:53:18  <phantomcircuit> yeah without the filter was actually faster
5072020-06-02T22:53:25  <phantomcircuit> 46m vs 53m
5082020-06-02T23:00:07  *** bitcoin-git has joined #bitcoin-core-dev
5092020-06-02T23:00:07  <bitcoin-git> [bitcoin] ariard opened pull request #19147: Document BanMan with regards to malicious exploitation (master...2020-06-doc-banman-infra) https://github.com/bitcoin/bitcoin/pull/19147
5102020-06-02T23:00:08  *** bitcoin-git has left #bitcoin-core-dev
5112020-06-02T23:00:49  *** ghost43 has quit IRC
5122020-06-02T23:01:36  *** ghost43 has joined #bitcoin-core-dev
5132020-06-02T23:08:47  *** surja795 has joined #bitcoin-core-dev
5142020-06-02T23:09:04  *** AaronvanW has quit IRC
5152020-06-02T23:09:23  *** justanotheruser has quit IRC
5162020-06-02T23:09:24  *** jb55 has quit IRC
5172020-06-02T23:13:26  *** surja795 has quit IRC
5182020-06-02T23:17:34  *** Relis has quit IRC
5192020-06-02T23:22:43  *** jb55 has joined #bitcoin-core-dev
5202020-06-02T23:23:44  *** Relis has joined #bitcoin-core-dev
5212020-06-02T23:27:18  <phantomcircuit> ok so the 1 in a billion filter might be too extreme
5222020-06-02T23:28:07  *** justanotheruser has joined #bitcoin-core-dev
5232020-06-02T23:39:44  *** surja795 has joined #bitcoin-core-dev
5242020-06-02T23:40:27  *** AaronvanW has joined #bitcoin-core-dev
5252020-06-02T23:44:02  *** troygiorshev has quit IRC
5262020-06-02T23:45:14  *** AaronvanW has quit IRC
5272020-06-02T23:50:01  *** surja795 has quit IRC