12020-07-31T00:00:02 *** kaimi1 has quit IRC
22020-07-31T00:04:28 *** Dean_Guss has joined #bitcoin-core-dev
32020-07-31T00:06:43 *** DeanWeen has quit IRC
42020-07-31T00:06:46 *** troygiorshev has quit IRC
52020-07-31T00:08:19 *** ghost43 has quit IRC
62020-07-31T00:10:03 *** yanmaani has quit IRC
72020-07-31T00:15:13 *** bitdex has quit IRC
82020-07-31T00:20:08 *** benthecarman has joined #bitcoin-core-dev
92020-07-31T00:21:03 *** srimech1 has joined #bitcoin-core-dev
102020-07-31T00:21:17 *** mdunnio has joined #bitcoin-core-dev
112020-07-31T00:23:01 *** promag has joined #bitcoin-core-dev
122020-07-31T00:24:48 *** proofofkeags has quit IRC
132020-07-31T00:25:22 *** proofofkeags has joined #bitcoin-core-dev
142020-07-31T00:25:58 *** mdunnio has quit IRC
152020-07-31T00:27:01 *** rh0nj has quit IRC
162020-07-31T00:29:23 *** proofofkeags has quit IRC
172020-07-31T00:30:08 *** rh0nj has joined #bitcoin-core-dev
182020-07-31T00:30:38 *** gzhao408 has quit IRC
192020-07-31T00:41:22 *** troygiorshev has joined #bitcoin-core-dev
202020-07-31T00:41:31 *** promag has quit IRC
212020-07-31T00:45:45 *** benthecarman has quit IRC
222020-07-31T00:48:20 *** promag has joined #bitcoin-core-dev
232020-07-31T00:51:00 *** Tralfaz has joined #bitcoin-core-dev
242020-07-31T00:51:01 *** justanotheruser has joined #bitcoin-core-dev
252020-07-31T00:52:35 *** bitcoin-git has joined #bitcoin-core-dev
262020-07-31T00:52:36 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/edec7f7c2542...a4a279b4f368
272020-07-31T00:52:36 <bitcoin-git> bitcoin/master e60ef21 fanquake: doc: Clang 8 or later is required with FORCE_USE_SYSTEM_CLANG
282020-07-31T00:52:37 <bitcoin-git> bitcoin/master a4a279b fanquake: Merge #19617: doc: Clang 8 or later is required with FORCE_USE_SYSTEM_CLAN...
292020-07-31T00:52:38 *** bitcoin-git has left #bitcoin-core-dev
302020-07-31T00:52:55 *** bitcoin-git has joined #bitcoin-core-dev
312020-07-31T00:52:56 <bitcoin-git> [bitcoin] fanquake merged pull request #19617: doc: Clang 8 or later is required with FORCE_USE_SYSTEM_CLANG (master...note_that_clang_8_is_required_with_force_system_clang) https://github.com/bitcoin/bitcoin/pull/19617
322020-07-31T00:52:57 *** bitcoin-git has left #bitcoin-core-dev
332020-07-31T00:53:44 *** Davterra has quit IRC
342020-07-31T00:58:17 *** proofofkeags has joined #bitcoin-core-dev
352020-07-31T01:00:44 *** bitdex has joined #bitcoin-core-dev
362020-07-31T01:00:58 *** promag has quit IRC
372020-07-31T01:01:34 *** promag has joined #bitcoin-core-dev
382020-07-31T01:01:40 *** gzhao408 has joined #bitcoin-core-dev
392020-07-31T01:02:45 *** proofofkeags has quit IRC
402020-07-31T01:06:01 *** promag has quit IRC
412020-07-31T01:16:13 *** arowser_ has quit IRC
422020-07-31T01:16:48 *** arowser_ has joined #bitcoin-core-dev
432020-07-31T01:17:57 *** Dean_Guss has quit IRC
442020-07-31T01:18:01 *** DeanWeen has joined #bitcoin-core-dev
452020-07-31T01:19:02 *** mdunnio has joined #bitcoin-core-dev
462020-07-31T01:21:40 *** gzhao408 has quit IRC
472020-07-31T01:23:25 *** mdunnio has quit IRC
482020-07-31T01:34:53 *** gankmove has joined #bitcoin-core-dev
492020-07-31T01:44:46 *** jb55 has joined #bitcoin-core-dev
502020-07-31T01:50:08 *** bitcoin-git has joined #bitcoin-core-dev
512020-07-31T01:50:08 <bitcoin-git> [bitcoin] Empact opened pull request #19632: test: Catch decimal.InvalidOperation from TestNodeCLI#send_cli (master...2020-07-send_cli-invalid-op) https://github.com/bitcoin/bitcoin/pull/19632
522020-07-31T01:50:09 *** bitcoin-git has left #bitcoin-core-dev
532020-07-31T01:52:48 *** gribble has quit IRC
542020-07-31T02:01:07 *** kristapsk has quit IRC
552020-07-31T02:05:28 *** Victorsueca has joined #bitcoin-core-dev
562020-07-31T02:06:17 *** gribble has joined #bitcoin-core-dev
572020-07-31T02:12:35 *** gzhao408 has joined #bitcoin-core-dev
582020-07-31T02:17:14 *** arowser_ has quit IRC
592020-07-31T02:28:57 *** gzhao408 has quit IRC
602020-07-31T02:32:59 *** jakelgodfrey has joined #bitcoin-core-dev
612020-07-31T02:34:53 *** jakelgodfrey has joined #bitcoin-core-dev
622020-07-31T02:39:36 *** jakelgodfrey has quit IRC
632020-07-31T02:39:38 *** DeanWeen has quit IRC
642020-07-31T02:59:33 *** bitcoin-git has joined #bitcoin-core-dev
652020-07-31T02:59:33 <bitcoin-git> [bitcoin] kallewoof closed pull request #14582: wallet: always do avoid partial spends if fees are within a specified range (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
662020-07-31T02:59:33 *** bitcoin-git has left #bitcoin-core-dev
672020-07-31T03:00:02 *** srimech1 has quit IRC
682020-07-31T03:00:23 *** bitcoin-git has joined #bitcoin-core-dev
692020-07-31T03:00:23 <bitcoin-git> [bitcoin] kallewoof closed pull request #16653: script: add simple signature support (checker/creator) (master...2019-08-genpursigs) https://github.com/bitcoin/bitcoin/pull/16653
702020-07-31T03:00:25 *** bitcoin-git has left #bitcoin-core-dev
712020-07-31T03:06:42 *** justanotheruser has quit IRC
722020-07-31T03:09:54 *** proofofkeags has joined #bitcoin-core-dev
732020-07-31T03:18:50 *** Highway61 has quit IRC
742020-07-31T03:19:54 *** mdunnio has joined #bitcoin-core-dev
752020-07-31T03:20:35 *** Seyaryuki has joined #bitcoin-core-dev
762020-07-31T03:23:18 *** justanotheruser has joined #bitcoin-core-dev
772020-07-31T03:26:50 *** go11111111111 has joined #bitcoin-core-dev
782020-07-31T03:28:26 *** mdunnio has quit IRC
792020-07-31T03:29:38 *** go1111111 has quit IRC
802020-07-31T03:32:46 *** jarthur has quit IRC
812020-07-31T03:33:43 *** vasild has quit IRC
822020-07-31T03:35:32 *** vasild has joined #bitcoin-core-dev
832020-07-31T03:41:37 *** arowser_ has joined #bitcoin-core-dev
842020-07-31T03:44:18 *** gankmove has quit IRC
852020-07-31T04:32:18 *** Talkless has joined #bitcoin-core-dev
862020-07-31T04:34:48 *** proofofkeags has quit IRC
872020-07-31T04:35:21 *** proofofkeags has joined #bitcoin-core-dev
882020-07-31T04:38:07 *** arowser_ has quit IRC
892020-07-31T04:38:33 *** arowser_ has joined #bitcoin-core-dev
902020-07-31T04:39:31 *** proofofkeags has quit IRC
912020-07-31T05:44:45 *** arowser_ has quit IRC
922020-07-31T05:46:11 *** dongcarl has quit IRC
932020-07-31T05:46:27 *** dongcarl has joined #bitcoin-core-dev
942020-07-31T05:53:56 *** bitcoin-git has joined #bitcoin-core-dev
952020-07-31T05:53:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a4a279b4f368...a63a26f04213
962020-07-31T05:53:56 <bitcoin-git> bitcoin/master ae4958b Chris L: rpc: RPCResult Type of MempoolEntryDescription should be OBJ. If multiple ...
972020-07-31T05:53:57 <bitcoin-git> bitcoin/master a63a26f MarcoFalke: Merge #19585: rpc: RPCResult Type of MempoolEntryDescription should be OBJ...
982020-07-31T05:53:57 *** bitcoin-git has left #bitcoin-core-dev
992020-07-31T05:54:16 *** bitcoin-git has joined #bitcoin-core-dev
1002020-07-31T05:54:16 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19585: rpc: RPCResult Type of MempoolEntryDescription should be OBJ. (master...19579) https://github.com/bitcoin/bitcoin/pull/19585
1012020-07-31T05:54:17 *** bitcoin-git has left #bitcoin-core-dev
1022020-07-31T05:56:35 *** mdunnio has joined #bitcoin-core-dev
1032020-07-31T06:00:01 *** Seyaryuki has quit IRC
1042020-07-31T06:01:26 *** mdunnio has quit IRC
1052020-07-31T06:21:53 *** Fiver has joined #bitcoin-core-dev
1062020-07-31T06:28:54 *** mutatrum has joined #bitcoin-core-dev
1072020-07-31T06:33:10 *** mutatrum has quit IRC
1082020-07-31T06:36:39 *** bitdex has quit IRC
1092020-07-31T06:39:29 *** bitcoin-git has joined #bitcoin-core-dev
1102020-07-31T06:39:30 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19098: test: Remove duplicate NodeContext hacks (master...pr/qtx) https://github.com/bitcoin/bitcoin/pull/19098
1112020-07-31T06:39:31 *** bitcoin-git has left #bitcoin-core-dev
1122020-07-31T06:39:49 *** bitcoin-git has joined #bitcoin-core-dev
1132020-07-31T06:39:50 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19098: test: Remove duplicate NodeContext hacks (master...pr/qtx) https://github.com/bitcoin/bitcoin/pull/19098
1142020-07-31T06:39:51 *** bitcoin-git has left #bitcoin-core-dev
1152020-07-31T06:44:25 *** marcoagner has joined #bitcoin-core-dev
1162020-07-31T06:50:17 <MarcoFalke> The meeting could toggle between two times, so everyone could at least attend every other meeting
1172020-07-31T06:54:41 *** AaronvanW has quit IRC
1182020-07-31T07:15:45 *** IGHOR has quit IRC
1192020-07-31T07:20:23 *** vasild has quit IRC
1202020-07-31T07:28:56 *** luke-jr has quit IRC
1212020-07-31T07:30:52 *** vasild has joined #bitcoin-core-dev
1222020-07-31T07:32:17 *** luke-jr has joined #bitcoin-core-dev
1232020-07-31T07:40:27 *** IGHOR has joined #bitcoin-core-dev
1242020-07-31T07:46:21 *** justanotheruser has quit IRC
1252020-07-31T07:57:23 *** mdunnio has joined #bitcoin-core-dev
1262020-07-31T08:01:52 *** mdunnio has quit IRC
1272020-07-31T08:05:52 *** AaronvanW has joined #bitcoin-core-dev
1282020-07-31T08:06:55 *** morcos has quit IRC
1292020-07-31T08:07:32 *** arowser_ has joined #bitcoin-core-dev
1302020-07-31T08:12:50 *** arowser_ has quit IRC
1312020-07-31T08:14:38 *** vincenzopalazzo has joined #bitcoin-core-dev
1322020-07-31T08:21:38 <jonatack> i'm interested in these meetings (core dev weekly, wallet, p2p, review club) but they are currently during sleep hours, which made for grouchy participation and low productivity the next day... i concluded it's best to abstain ;)
1332020-07-31T08:23:42 <jonatack> I like MarcoFalke's suggestion to toggle between two times
1342020-07-31T08:35:04 <jonatack> at any rate, I read the logs to catch up the next day :)
1352020-07-31T08:39:27 *** belcher has joined #bitcoin-core-dev
1362020-07-31T08:57:32 *** jonatack has quit IRC
1372020-07-31T09:00:01 *** Fiver has quit IRC
1382020-07-31T09:01:41 *** davec has quit IRC
1392020-07-31T09:02:07 *** davec has joined #bitcoin-core-dev
1402020-07-31T09:03:59 *** AaronvanW has quit IRC
1412020-07-31T09:05:53 *** arowser_ has joined #bitcoin-core-dev
1422020-07-31T09:21:04 *** belcher has quit IRC
1432020-07-31T09:21:18 *** belcher has joined #bitcoin-core-dev
1442020-07-31T09:21:37 *** jtk has joined #bitcoin-core-dev
1452020-07-31T09:23:40 *** CubicEarth has quit IRC
1462020-07-31T09:27:28 *** CubicEarth has joined #bitcoin-core-dev
1472020-07-31T09:44:43 *** gankmove has joined #bitcoin-core-dev
1482020-07-31T09:58:18 *** mdunnio has joined #bitcoin-core-dev
1492020-07-31T10:00:57 *** Pavlenex has joined #bitcoin-core-dev
1502020-07-31T10:01:28 *** bizmindx has joined #bitcoin-core-dev
1512020-07-31T10:02:09 *** bizmindx has quit IRC
1522020-07-31T10:02:54 *** mdunnio has quit IRC
1532020-07-31T10:03:20 *** Kirsten15Nader has joined #bitcoin-core-dev
1542020-07-31T10:06:43 *** vasild has quit IRC
1552020-07-31T10:13:38 *** vasild has joined #bitcoin-core-dev
1562020-07-31T10:17:05 *** Kirsten15Nader has quit IRC
1572020-07-31T10:40:29 *** EagleTM has joined #bitcoin-core-dev
1582020-07-31T10:42:49 *** davec has quit IRC
1592020-07-31T10:43:12 *** davec has joined #bitcoin-core-dev
1602020-07-31T10:43:47 *** Victorsueca has quit IRC
1612020-07-31T10:54:50 *** Victorsueca has joined #bitcoin-core-dev
1622020-07-31T10:55:36 *** vasild_ has joined #bitcoin-core-dev
1632020-07-31T10:58:23 *** vasild has quit IRC
1642020-07-31T10:58:24 *** vasild_ is now known as vasild
1652020-07-31T11:00:54 *** AaronvanW has joined #bitcoin-core-dev
1662020-07-31T11:02:08 *** arowser_ has quit IRC
1672020-07-31T11:03:12 *** arowser_ has joined #bitcoin-core-dev
1682020-07-31T11:04:59 *** Victorsueca has quit IRC
1692020-07-31T11:05:22 *** arowser_ has quit IRC
1702020-07-31T11:17:05 *** EagleTM has quit IRC
1712020-07-31T11:19:08 *** EagleTM has joined #bitcoin-core-dev
1722020-07-31T11:33:20 *** AaronvanW has quit IRC
1732020-07-31T11:33:37 *** AaronvanW has joined #bitcoin-core-dev
1742020-07-31T11:36:04 *** Highway61 has joined #bitcoin-core-dev
1752020-07-31T11:36:45 *** luke-jr has quit IRC
1762020-07-31T11:39:37 *** luke-jr has joined #bitcoin-core-dev
1772020-07-31T11:42:04 *** EagleTM has quit IRC
1782020-07-31T11:43:17 *** Victorsueca has joined #bitcoin-core-dev
1792020-07-31T11:52:53 *** bitcoin-git has joined #bitcoin-core-dev
1802020-07-31T11:52:54 <bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/a63a26f04213...f7c73b03d975
1812020-07-31T11:52:55 <bitcoin-git> bitcoin/master d362f19 Pieter Wuille: doc: list support for BIP 339 in doc/bips.md
1822020-07-31T11:52:55 <bitcoin-git> bitcoin/master 9efd86a Pieter Wuille: refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic
1832020-07-31T11:52:56 <bitcoin-git> bitcoin/master 900d7f6 Pieter Wuille: p2p: enable fetching of orphans from wtxid peers
1842020-07-31T11:52:57 *** bitcoin-git has left #bitcoin-core-dev
1852020-07-31T11:53:14 *** bitcoin-git has joined #bitcoin-core-dev
1862020-07-31T11:53:14 <bitcoin-git> [bitcoin] fanquake merged pull request #19569: Enable fetching of orphan parents from wtxid peers (master...202007_wtxid_followup) https://github.com/bitcoin/bitcoin/pull/19569
1872020-07-31T11:53:14 *** bitcoin-git has left #bitcoin-core-dev
1882020-07-31T11:55:01 <jnewbery> I'm pretty against having an alternating meeting time for a couple of reasons:
1892020-07-31T11:55:10 <jnewbery> 1) it's confusing. People will inevitably show up at the wrong time on the wrong day or miss meetings and get annoyed.
1902020-07-31T11:55:20 <jnewbery> 2) I'd need to find a host for the opposite time meeting. In my experience from PR review club, people are keen to host one or two and then lose interest.
1912020-07-31T11:57:59 *** arowser_ has joined #bitcoin-core-dev
1922020-07-31T11:59:17 *** mdunnio has joined #bitcoin-core-dev
1932020-07-31T12:00:02 *** jtk has quit IRC
1942020-07-31T12:00:35 *** mdunnio has quit IRC
1952020-07-31T12:05:48 *** bitcoin-git has joined #bitcoin-core-dev
1962020-07-31T12:05:48 <bitcoin-git> [bitcoin] laanwj pushed tag v0.20.1: https://github.com/bitcoin/bitcoin/compare/v0.20.1
1972020-07-31T12:05:49 *** bitcoin-git has left #bitcoin-core-dev
1982020-07-31T12:06:07 <hebasto> \o/
1992020-07-31T12:06:08 *** bitcoin-git has joined #bitcoin-core-dev
2002020-07-31T12:06:08 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/6acb21e724e3...7ff64311bee5
2012020-07-31T12:06:08 <bitcoin-git> bitcoin/0.20 7ff6431 Wladimir J. van der Laan: build: Bump version to 0.20.1-final
2022020-07-31T12:06:10 *** bitcoin-git has left #bitcoin-core-dev
2032020-07-31T12:06:31 <wumpus> yes, I think that's also why the main meeting was never changed to alternating times, even though it was considered a few times
2042020-07-31T12:08:30 <wumpus> btw, we don't even mention the wallet meeting yet on https://bitcoincore.org/en/meetings/, would make sense to do so, or at least have a page that mentions all the meetings in one place
2052020-07-31T12:09:42 <wumpus> could also link to the PR review meetings
2062020-07-31T12:14:48 <wumpus> and the 2018- meeting summaries could move to something like 'historical meeting summaries'
2072020-07-31T12:21:51 *** CjNr11 has joined #bitcoin-core-dev
2082020-07-31T12:23:38 *** Victorsueca has quit IRC
2092020-07-31T12:25:55 *** Pavlenex has quit IRC
2102020-07-31T12:38:34 *** Guyver2 has joined #bitcoin-core-dev
2112020-07-31T12:40:26 *** jonatack has joined #bitcoin-core-dev
2122020-07-31T12:41:57 *** Victorsueca has joined #bitcoin-core-dev
2132020-07-31T12:57:31 <aj> jnewbery: "people will .. miss meetings and get annoyed" oh, look, there's the box i'm in
2142020-07-31T13:01:37 <jonatack> jnewbery: lately there's almost been a surplus of review club hosts? slots backed up, etc, not including others who might be interested in hosting at a different time
2152020-07-31T13:03:41 <jonatack> anyway... in general (not just the review club) it may be worthwhile to try and see if people are confused by alternating slots.
2162020-07-31T13:04:39 <jonatack> the benefit might be a greater diversity of input at the meetings. geographic diversity is interesting. but i won't go on further about it.
2172020-07-31T13:06:09 *** arowser_ has quit IRC
2182020-07-31T13:06:37 *** arowser_ has joined #bitcoin-core-dev
2192020-07-31T13:07:07 *** arowser_ has quit IRC
2202020-07-31T13:07:35 *** arowser_ has joined #bitcoin-core-dev
2212020-07-31T13:09:11 *** arowser_ has quit IRC
2222020-07-31T13:09:40 *** arowser_ has joined #bitcoin-core-dev
2232020-07-31T13:10:12 *** arowser_ has quit IRC
2242020-07-31T13:10:40 *** arowser_ has joined #bitcoin-core-dev
2252020-07-31T13:12:11 *** arowser_ has quit IRC
2262020-07-31T13:12:18 * troygiorshev proposes to randomize the time each week so that people are forced to check when it is
2272020-07-31T13:12:55 *** arowser_ has joined #bitcoin-core-dev
2282020-07-31T13:15:55 <jonatack> :D
2292020-07-31T13:38:15 <provoostenator> hebasto beat me to it by 17 minutes for Gitian signatures. I should automate the PR part...
2302020-07-31T13:38:38 <hebasto> still using LXC :)
2312020-07-31T13:39:16 <provoostenator> Oh it was done much earlier; I just didn't watch the terminal window
2322020-07-31T13:39:33 <hebasto> provoostenator: have you already automate tagging part?
2332020-07-31T13:44:08 *** arowser_ has quit IRC
2342020-07-31T13:44:40 *** arowser_ has joined #bitcoin-core-dev
2352020-07-31T13:45:48 *** mdunnio has joined #bitcoin-core-dev
2362020-07-31T13:50:07 *** promag has joined #bitcoin-core-dev
2372020-07-31T13:57:43 *** proofofkeags has joined #bitcoin-core-dev
2382020-07-31T14:03:12 *** arowser_ has quit IRC
2392020-07-31T14:03:54 *** arowser_ has joined #bitcoin-core-dev
2402020-07-31T14:04:01 <jonatack> If anyone wants to build gitian sigs for the first time for 0.20.1, I just updated this guide: https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md
2412020-07-31T14:07:47 *** andreacab has joined #bitcoin-core-dev
2422020-07-31T14:08:32 *** andreaca_ has joined #bitcoin-core-dev
2432020-07-31T14:12:05 *** andreacab has quit IRC
2442020-07-31T14:14:56 *** mdunnio has quit IRC
2452020-07-31T14:15:09 *** mdunnio has joined #bitcoin-core-dev
2462020-07-31T14:23:07 *** andreaca_ has quit IRC
2472020-07-31T14:28:32 *** andreacab has joined #bitcoin-core-dev
2482020-07-31T14:31:17 *** andreaca_ has joined #bitcoin-core-dev
2492020-07-31T14:32:45 *** andreacab has quit IRC
2502020-07-31T14:38:52 *** onokatio has joined #bitcoin-core-dev
2512020-07-31T14:39:19 *** onokatio has joined #bitcoin-core-dev
2522020-07-31T14:40:57 *** onokatio has quit IRC
2532020-07-31T14:41:15 *** onokatio has joined #bitcoin-core-dev
2542020-07-31T15:00:01 *** CjNr11 has quit IRC
2552020-07-31T15:06:55 <emzy> provoostenator: I had to delete gitian-builder/cache to get the hash of MacOSX10.14.sdk.tar.gz right and compile again. But you are faster anyway.
2562020-07-31T15:14:13 *** gankmove has quit IRC
2572020-07-31T15:20:49 *** tlockney has joined #bitcoin-core-dev
2582020-07-31T15:36:57 <provoostenator> hebasto: no automation, but I highlight "pushed tag" on IRC (ht achow101)
2592020-07-31T15:37:10 <achow101> automation is hard
2602020-07-31T15:37:33 <provoostenator> Also probably not ideal to automate, in case someone kidnaps me just before an evil release
2612020-07-31T15:47:50 *** mutatrum has joined #bitcoin-core-dev
2622020-07-31T15:56:05 *** Talkless has quit IRC
2632020-07-31T16:11:57 <hebasto> provoostenator :D
2642020-07-31T16:13:22 <hebasto> agree, automated gitian builds as well as automated client updates are not for bitcoin
2652020-07-31T16:15:15 <hebasto> anyway kidnapping has no point as an adversary has no ability to *sign* your gitian builds
2662020-07-31T16:19:55 <jnewbery> jonatack: there hasn't been a surplus of review club hosts. I'm always looking for people to volunteer to host.
2672020-07-31T16:20:09 <jnewbery> I think maybe you underestimate the effort required to make sure this thing runs regularly.
2682020-07-31T16:20:59 <jnewbery> I'm very open to other people hosting review club meetings for different time zones. My experience has been that people don't stick with it for very long.
2692020-07-31T16:21:56 <jonatack> jnewbery: indeed, i reckoned i was underestimating that. it may have been a one-off backlog.
2702020-07-31T16:22:42 <jnewbery> It's not a backlog. I schedule hosts in advance to make sure that we always have something lined up
2712020-07-31T16:23:57 <jonatack> jnewbery: i'm not convinced that second meetings are very exciting for people. i don't think alternate times for the main meeting have been tried.
2722020-07-31T16:25:31 <jnewbery> there are many people who join every week at 17:00 UTC on weds because that's part of their schedule. I'm not going to stop holding meetings at that time. I'm very open to you or anyone else holding a meeting at a time that's more suitable for other time zones though.
2732020-07-31T16:26:01 <jonatack> that said, i don't want to be overbearing about mono-meeting times and i'm happy with reading the logs the next day and learning from them.
2742020-07-31T16:26:30 <jnewbery> I think we're offtopic here. If you want to discuss more, let's use #bitcoin-core-pr-reviews
2752020-07-31T16:27:21 <jonatack> my point was about the diversity of input at meetings in general, not only review club.
2762020-07-31T16:28:04 *** Pavlenex has joined #bitcoin-core-dev
2772020-07-31T16:29:11 *** arowser_ has quit IRC
2782020-07-31T16:29:36 *** arowser_ has joined #bitcoin-core-dev
2792020-07-31T16:31:08 <jnewbery> ok. I just wanted to make sure that people in this room didn't think that we have a surplus of hosts. I'm always looking for hosts, and I think everyone who's done it has found it a worthwhile use of their time.
2802020-07-31T16:31:48 <jonatack> +1
2812020-07-31T16:34:42 <jonatack> if anyone is curious, here are the people who have hosted review clubs so far: https://bitcoincore.reviews/meetings-hosts
2822020-07-31T16:35:58 <pinheadmz> thats cool jonatack !
2832020-07-31T16:39:45 <achow101> provoostenator: osx mismatch, did you clear your gitian cache?
2842020-07-31T16:39:55 <achow101> - 61a385c6836240224dafa06f19c0f5b9bea1215852c318fd6bd1e2f7baeb856e bitcoin-0.20.1-osx-unsigned.tar.gz
2852020-07-31T16:39:55 <achow101> + fdffff0e6b956ffa51b0a01f04b9e9cff2a658589116a911c322a94855feeeac bitcoin-0.20.1-osx-unsigned.tar.gz
2862020-07-31T16:40:03 <provoostenator> I didn't, which incantation?
2872020-07-31T16:40:32 <achow101> rm -r gitian-builder/cache
2882020-07-31T16:40:34 <provoostenator> And did my 0.20.1rc1 build also mismatch?
2892020-07-31T16:41:00 <achow101> yes, mismatch for rc1 too
2902020-07-31T16:41:00 <provoostenator> Doing a new build, will make another PR with that.
2912020-07-31T16:41:34 <provoostenator> Did we backport the SDK upgrade?
2922020-07-31T16:41:39 <provoostenator> Or is this an unrelated problem?
2932020-07-31T16:41:52 <achow101> unrelated
2942020-07-31T16:42:01 <jonatack> achow101: when is that spell needed? have never cleared the cache
2952020-07-31T16:42:43 <achow101> jonatack: usually it isn't needed as the cache should clear/not be used when a dependency updates
2962020-07-31T16:43:19 <achow101> but somtimes a dependency's binary will change because some build tooling changes and that makes cached builds vs non-cached builds differ
2972020-07-31T16:43:35 <achow101> so in those cases (like now) it's just easier to ask everyone to clear their cache before building so we all arrive at the same result
2982020-07-31T16:43:46 <jonatack> ok thanks
2992020-07-31T16:47:10 *** mutatrum has quit IRC
3002020-07-31T16:59:18 *** Highway61 has quit IRC
3012020-07-31T16:59:51 *** Highway61 has joined #bitcoin-core-dev
3022020-07-31T17:06:22 <provoostenator> Oh I guess I didn't have to rebuild Linux and Windows...
3032020-07-31T17:16:41 *** proofofkeags has quit IRC
3042020-07-31T17:17:17 *** proofofkeags has joined #bitcoin-core-dev
3052020-07-31T17:22:04 *** proofofkeags has quit IRC
3062020-07-31T17:31:34 *** jarthur has joined #bitcoin-core-dev
3072020-07-31T17:35:42 *** bitcoin-git has joined #bitcoin-core-dev
3082020-07-31T17:35:43 <bitcoin-git> [bitcoin] justinmoon opened pull request #19634: rpc: Document getwalletinfo's unlocked_until field as optional (master...getwalletinfo) https://github.com/bitcoin/bitcoin/pull/19634
3092020-07-31T17:35:44 *** bitcoin-git has left #bitcoin-core-dev
3102020-07-31T17:35:46 *** proofofkeags has joined #bitcoin-core-dev
3112020-07-31T17:45:32 *** justanotheruser has joined #bitcoin-core-dev
3122020-07-31T17:47:30 <jeremyrubin> hebasto: for #18710 do you have a plan to get cross platform testing? It might help to ask some specific people to run benches. But also if you read the article that I shared on boost:: vs std:: it's unclear that our current bench would even capture it...
3132020-07-31T17:47:33 <gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
3142020-07-31T17:48:16 <jeremyrubin> hebasto: I think what you might want to add is a new bench which is just testing different threading primitives out, and show there's no regression there?
3152020-07-31T17:48:51 <jeremyrubin> I can also send the article to martinus and ask if there are any features in nanobench that can help diagnose such a regression
3162020-07-31T17:59:10 *** arowser_ has quit IRC
3172020-07-31T17:59:39 *** arowser_ has joined #bitcoin-core-dev
3182020-07-31T18:00:02 *** tlockney has quit IRC
3192020-07-31T18:11:41 *** Pavlenex has quit IRC
3202020-07-31T18:17:07 <hebasto> jeremyrubin: which threading primitives do you mean for benchmarking?
3212020-07-31T18:17:45 <provoostenator> OTOH wiping the cache changed some linux details too
3222020-07-31T18:17:48 <hebasto> yes, martinus' help would be valuable
3232020-07-31T18:18:43 <provoostenator> (but not the end result)
3242020-07-31T18:19:27 <sipa> figure out how to turn of cpu frequency scaling if you benchmark
3252020-07-31T18:20:07 <sipa> on my laptop's i7 cpu that means booting with intel_pstate=disable on the kernel command line
3262020-07-31T18:20:56 <hebasto> some tools are mentioned here https://wiki.archlinux.org/index.php/CPU_frequency_scaling
3272020-07-31T18:20:57 *** vBm1 has joined #bitcoin-core-dev
3282020-07-31T18:31:36 <jeremyrubin> from martinus:
3292020-07-31T18:31:47 <jeremyrubin> Hi, I think a good way to expose variance is to reduce the number of iterations. Usually nanobench tries to find a reasonable number of iterations depending on clock accuracy, but running many iterations per measurement means that it will become smoothed. So I'd do something like this:
3302020-07-31T18:32:12 <jeremyrubin> ankerl::nanobench::Bench().epochIterations(1).epochs(10000).run(
3312020-07-31T18:32:14 <jeremyrubin> "expose variance", [&] { /* whatever */ });
3322020-07-31T18:32:20 <jeremyrubin> that forces only a single iteration per measurement(epoch), so this maximizes variance. The disadvantage is that time measurements will be less accurate.
3332020-07-31T18:32:36 <jeremyrubin> To visualize the fluctiation you can generate boxplots:
3342020-07-31T18:32:37 <jeremyrubin> std::ofstream html("out.html");
3352020-07-31T18:32:38 <jeremyrubin> bench.render(ankerl::nanobench::templates::htmlBoxplot(), html);
3362020-07-31T18:32:45 <jeremyrubin> its probably best to play a bit with epochIterations() and epochs() argument to get reasonable visualization and result
3372020-07-31T18:33:21 <jeremyrubin> if you look at my comment https://github.com/bitcoin/bitcoin/pull/18710#issuecomment-640095382
3382020-07-31T18:33:51 <jeremyrubin> ^^^ back to non martinus
3392020-07-31T18:33:56 <jeremyrubin> https://codesequoia.wordpress.com/2013/03/27/condition-variables-performance-of-boost-win32-and-the-c11-standard-library/
3402020-07-31T18:34:20 <jeremyrubin> this shows that std's condvar is defective
3412020-07-31T18:34:48 <jeremyrubin> so what im asking to test is that whichever primitive were using is not defective
3422020-07-31T18:36:11 <jeremyrubin> idk if it's an issue in that particular environment
3432020-07-31T18:36:22 <jeremyrubin> or an issue with c++11 generally
3442020-07-31T18:36:53 <jeremyrubin> but the checkqueue would be prett sensitive to something like this, and is perf critical
3452020-07-31T18:37:17 <hebasto> this article did not mention c++ library version
3462020-07-31T18:37:58 <sipa> "Visual Studio 2012 Express"
3472020-07-31T18:38:05 <jeremyrubin> so i'd prefer not leaving unless we have confidence the defect doesnt exist in our supported platforms
3482020-07-31T18:38:09 <sipa> i suspect is the c++ library version :)
3492020-07-31T18:38:16 <jeremyrubin> sipa: correct
3502020-07-31T18:38:51 <jeremyrubin> and the issue isnt avg perf, it's the variance
3512020-07-31T18:39:04 <jeremyrubin> which is why current bench doesnt inform much
3522020-07-31T18:40:06 <hebasto> so the goal is to compare boost:: and std:: condvar performance variances?
3532020-07-31T18:40:16 <jeremyrubin> fwiw there could be a legit reason to prefer the slower one -- maybe it delegates to the OS more and it's a thread priority issue
3542020-07-31T18:40:47 <jeremyrubin> but idk, and i'd be nervous to make a change without being sure
3552020-07-31T18:41:11 <jeremyrubin> hebasto: yes, in addition to actual performance
3562020-07-31T18:41:18 *** Chris_Stewart_5 has quit IRC
3572020-07-31T18:41:21 <hebasto> yes, we must be sure before making changes
3582020-07-31T18:42:34 <dburkett> https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L729-L730
3592020-07-31T18:43:08 <dburkett> If a block is part of the active chain, or we have the data in blk*.dat, in what cases would we not have tx data downloaded?
3602020-07-31T18:43:12 *** mutatrum has joined #bitcoin-core-dev
3612020-07-31T18:43:50 <jeremyrubin> hebasto: this one is just particularly annoying :/ i suspect that this issue has been fixed or doesnt exist on non windows but who knows.
3622020-07-31T18:44:13 <jeremyrubin> if it were only a regression on windows i'd still favor the patch
3632020-07-31T18:44:33 <sipa> dburkett: when it's pruned, i think
3642020-07-31T18:44:46 <jeremyrubin> but with condvars its both a hardware and system issue
3652020-07-31T18:44:52 <sipa> dburkett: ah, no
3662020-07-31T18:45:21 <jeremyrubin> so you should engage e.g. wumpus on what's a reasonable set to test
3672020-07-31T18:45:56 <sipa> dburkett: HaveTxDownloaded() means that a block and _all its parents_ have been downloaded
3682020-07-31T18:47:20 <dburkett> Ah, that makes sense! I knew it wasn't the case of pruned, because the docs specifically state that returning true doesn't mean txs haven't been pruned.
3692020-07-31T18:47:32 <dburkett> I forgot nChainTx is the number of txs in the entire chain up to that point. Makes sense now. Thanks sipa
3702020-07-31T18:49:02 <sipa> HAVE_BLOCK_DATA is unset when a block is pruned
3712020-07-31T18:49:07 <sipa> but nTx/nChainTx remain
3722020-07-31T18:49:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3732020-07-31T18:54:10 <dburkett> Got it. There's a lot of possible states these indices can be in. It's sometimes hard for me to keep track of all of them :)
3742020-07-31T19:00:18 <achow101> wallet meeting?
3752020-07-31T19:01:10 <provoostenator> I'm around
3762020-07-31T19:01:14 <achow101> #startmeeting
3772020-07-31T19:01:14 <lightningbot> Meeting started Fri Jul 31 19:01:14 2020 UTC. The chair is achow101. Information about MeetBot at http://wiki.debian.org/MeetBot.
3782020-07-31T19:01:14 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3792020-07-31T19:01:18 <provoostenator> hi
3802020-07-31T19:01:57 <achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
3812020-07-31T19:02:08 <provoostenator> Review nag for #15382 which is hopefully pretty close
3822020-07-31T19:02:10 <gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add RunCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
3832020-07-31T19:02:24 <achow101> that's on my review queue
3842020-07-31T19:02:54 <achow101> the main sqlite wallet pr is now ready for review
3852020-07-31T19:03:13 <provoostenator> Nice, will move on to that after I'm done with a Taproot excursion
3862020-07-31T19:03:26 <achow101> I was also wondering whether we wanted to do #19619 before it though
3872020-07-31T19:03:28 <gribble> https://github.com/bitcoin/bitcoin/issues/19619 | Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp by ryanofsky · Pull Request #19619 · bitcoin/bitcoin · GitHub
3882020-07-31T19:05:13 <achow101> no topics today?
3892020-07-31T19:05:36 <provoostenator> Not much news from my end
3902020-07-31T19:06:12 <provoostenator> 0.20.1 has the PSBT change, that's all we needed there?
3912020-07-31T19:06:22 <achow101> yes
3922020-07-31T19:06:36 <provoostenator> sipa: when miniscript?
3932020-07-31T19:06:50 <achow101> also #19602 is legacy to descriptor wallet migration
3942020-07-31T19:06:52 <gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub
3952020-07-31T19:07:19 <provoostenator> Shouldn't that go in the wallet tool?
3962020-07-31T19:07:26 <provoostenator> At least until we really insist on an upgrade?
3972020-07-31T19:07:47 <achow101> it could
3982020-07-31T19:08:23 <achow101> i made it a separate RPC, but it could also be rolled into upgradewallet
3992020-07-31T19:08:28 <provoostenator> And even if we insist on an upgrade, only the GUI would need access to this code, client users can use wallettool
4002020-07-31T19:09:27 <achow101> sure
4012020-07-31T19:10:25 <achow101> however it is useful to not have to unload and reload a wallet in order to migrate it
4022020-07-31T19:12:31 <achow101> #endmeeting
4032020-07-31T19:12:31 <lightningbot> Meeting ended Fri Jul 31 19:12:31 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
4042020-07-31T19:12:31 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-31-19.01.html
4052020-07-31T19:12:31 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-31-19.01.txt
4062020-07-31T19:12:31 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-07-31-19.01.log.html
4072020-07-31T19:15:27 *** bitcoin-git has joined #bitcoin-core-dev
4082020-07-31T19:15:28 <bitcoin-git> [bitcoin] Saibato opened pull request #19635: param: add bool parameter -ephemeraltoronion to generate ephemeral tor addreses (master...ephemeral-tor-onion) https://github.com/bitcoin/bitcoin/pull/19635
4092020-07-31T19:15:28 *** bitcoin-git has left #bitcoin-core-dev
4102020-07-31T19:23:26 <jonasschnelli> 0.20.1 detached signatures are up and tagged
4112020-07-31T19:23:51 <achow101> gitian builders ^
4122020-07-31T19:28:03 *** Chris_Stewart_5 has quit IRC
4132020-07-31T19:59:46 *** notmandatory has quit IRC
4142020-07-31T20:00:48 *** arowser_ has quit IRC
4152020-07-31T20:01:04 *** arowser_ has joined #bitcoin-core-dev
4162020-07-31T20:14:42 *** notmandatory has joined #bitcoin-core-dev
4172020-07-31T20:18:41 *** notmandatory has quit IRC
4182020-07-31T20:19:30 *** Guyver2 has quit IRC
4192020-07-31T20:19:41 *** notmandatory has joined #bitcoin-core-dev
4202020-07-31T20:33:48 *** filchef has joined #bitcoin-core-dev
4212020-07-31T20:39:25 *** mutatrum has quit IRC
4222020-07-31T20:48:02 <meshcollider> Oh no totally forgot the meeting this morning! Thanks achow101
4232020-07-31T20:48:19 <meshcollider> Looks like a short one anyway
4242020-07-31T20:49:07 <meshcollider> 12:57 AM <aj> jnewbery: "people will .. miss meetings and get annoyed" oh, look, there's the box i'm in
4252020-07-31T20:49:32 <meshcollider> :)
4262020-07-31T20:55:24 *** promag_ has joined #bitcoin-core-dev
4272020-07-31T21:00:01 *** vBm1 has quit IRC
4282020-07-31T21:09:33 <jeremyrubin> sipa: is this proven: not exists tx tx2. txid(tx) == wtxid(tx2) && tx != tx2
4292020-07-31T21:10:54 <sipa> jeremyrubin: yes, assuming double-sha256 collision resistance that statement is equivalent to ser_without_witness(tx) == ser_with_witness(tx2)
4302020-07-31T21:11:27 <sipa> either both tx and tx2 don't have a witness, and the statement is obviously false
4312020-07-31T21:11:45 <sipa> or tx2 has a witness, in which case the serialization definitely differs, due to the flag byte
4322020-07-31T21:13:08 <jeremyrubin> but it's not possible in tx2 that the flag + marker can be read as the length field for the txins?
4332020-07-31T21:13:32 <jeremyrubin> because a leading 0 byte means it can't be a length right?
4342020-07-31T21:13:59 <jeremyrubin> in which case it would be marker and not flag that guarantees uniqueness?
4352020-07-31T21:15:06 <sipa> a valid transactions cannot have 0 inputs
4362020-07-31T21:15:34 <sipa> the witness serialization is intended to be unambiguously different from the old serialization
4372020-07-31T21:15:58 <sipa> (except that we later discovered that people do pass around transactions with 0 inputs, where things break... but that's not relevant for valid network transactions)(
4382020-07-31T21:17:52 <jeremyrubin> gotcha. and the unambiguity is because it's a compactsize field preceding the vIn
4392020-07-31T21:18:10 <jeremyrubin> so 0 is always read as a 1 byte number in any context
4402020-07-31T21:18:59 *** proofofkeags has quit IRC
4412020-07-31T21:19:14 <sipa> indeed
4422020-07-31T21:21:56 *** alexsuraci has joined #bitcoin-core-dev
4432020-07-31T21:27:22 <harding> wumpus: FYI, 0.20.1 website PR: https://github.com/bitcoin-core/bitcoincore.org/pull/711
4442020-07-31T21:32:28 *** proofofkeags has joined #bitcoin-core-dev
4452020-07-31T21:39:02 *** promag_ has quit IRC
4462020-07-31T21:40:05 *** promag_ has joined #bitcoin-core-dev
4472020-07-31T21:41:56 *** promag_ has quit IRC
4482020-07-31T21:51:44 *** promag_ has joined #bitcoin-core-dev
4492020-07-31T21:55:47 *** promag_ has quit IRC
4502020-07-31T22:02:33 *** promag_ has joined #bitcoin-core-dev
4512020-07-31T22:05:56 *** bitcoin-git has joined #bitcoin-core-dev
4522020-07-31T22:05:56 <bitcoin-git> [bitcoin] achow101 opened pull request #19636: doc: Update 0.20.1 release notes with psbt changes (0.20...0.20.1-psbt-relnotes) https://github.com/bitcoin/bitcoin/pull/19636
4532020-07-31T22:05:57 *** bitcoin-git has left #bitcoin-core-dev
4542020-07-31T22:20:14 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4552020-07-31T22:43:53 *** mdunnio has quit IRC
4562020-07-31T22:44:49 <luke-jr> oops? too late?
4572020-07-31T22:47:51 *** vincenzopalazzo has quit IRC
4582020-07-31T22:49:31 *** proofofkeags has quit IRC
4592020-07-31T22:59:03 *** vasild has quit IRC
4602020-07-31T23:00:30 *** vasild has joined #bitcoin-core-dev
4612020-07-31T23:01:54 *** arowser_ has quit IRC
4622020-07-31T23:02:32 *** arowser_ has joined #bitcoin-core-dev
4632020-07-31T23:09:40 *** kristapsk has joined #bitcoin-core-dev
4642020-07-31T23:17:55 *** promag_ has quit IRC
4652020-07-31T23:25:23 *** Chris_Stewart_5 has quit IRC
4662020-07-31T23:25:26 *** promag_ has joined #bitcoin-core-dev
4672020-07-31T23:25:27 *** proofofkeags has joined #bitcoin-core-dev
4682020-07-31T23:25:58 *** marcoagner has quit IRC
4692020-07-31T23:33:45 *** proofofkeags has quit IRC
4702020-07-31T23:35:11 *** Victorsueca has quit IRC
4712020-07-31T23:36:19 *** Victorsueca has joined #bitcoin-core-dev
4722020-07-31T23:40:01 *** rh0nj has quit IRC
4732020-07-31T23:41:08 *** rh0nj has joined #bitcoin-core-dev
4742020-07-31T23:44:37 *** promag_ has quit IRC