12020-08-26T00:00:01  *** serAphim has quit IRC
  22020-08-26T00:02:01  *** promag has joined #bitcoin-core-dev
  32020-08-26T00:02:39  *** melande has quit IRC
  42020-08-26T00:05:49  *** melande has joined #bitcoin-core-dev
  52020-08-26T00:08:15  *** sipsorcery has quit IRC
  62020-08-26T00:10:39  *** melande has quit IRC
  72020-08-26T00:11:51  *** melande has joined #bitcoin-core-dev
  82020-08-26T00:20:06  *** codestr0m has joined #bitcoin-core-dev
  92020-08-26T00:32:05  *** lnostdal has quit IRC
 102020-08-26T00:33:47  *** rabidus has quit IRC
 112020-08-26T00:34:01  *** rabidus has joined #bitcoin-core-dev
 122020-08-26T00:38:16  *** AaronvanW has quit IRC
 132020-08-26T00:44:52  *** lnostdal has joined #bitcoin-core-dev
 142020-08-26T00:49:06  *** harrigan has quit IRC
 152020-08-26T00:50:49  *** harrigan has joined #bitcoin-core-dev
 162020-08-26T01:00:03  *** Dean_Guss has quit IRC
 172020-08-26T01:02:46  *** promag has quit IRC
 182020-08-26T01:06:42  *** melande has quit IRC
 192020-08-26T01:07:51  *** melande has joined #bitcoin-core-dev
 202020-08-26T01:10:39  *** AaronvanW has joined #bitcoin-core-dev
 212020-08-26T01:14:56  *** AaronvanW has quit IRC
 222020-08-26T01:18:59  *** Eagle[TM] has joined #bitcoin-core-dev
 232020-08-26T01:20:00  *** yanmaani has quit IRC
 242020-08-26T01:20:35  *** EagleTM has quit IRC
 252020-08-26T01:23:39  *** melande has quit IRC
 262020-08-26T01:24:52  *** melande has joined #bitcoin-core-dev
 272020-08-26T01:26:12  *** yanmaani has joined #bitcoin-core-dev
 282020-08-26T01:29:10  *** arowser has quit IRC
 292020-08-26T01:29:51  *** arowser has joined #bitcoin-core-dev
 302020-08-26T01:38:03  *** Dean_Guss has joined #bitcoin-core-dev
 312020-08-26T01:56:38  *** justanotheruser has joined #bitcoin-core-dev
 322020-08-26T01:59:18  *** Highway61 has quit IRC
 332020-08-26T02:02:39  *** melande has quit IRC
 342020-08-26T02:03:39  *** AaronvanW has joined #bitcoin-core-dev
 352020-08-26T02:03:53  *** melande has joined #bitcoin-core-dev
 362020-08-26T02:10:40  *** melande has quit IRC
 372020-08-26T02:11:51  *** melande has joined #bitcoin-core-dev
 382020-08-26T02:19:25  *** davec has quit IRC
 392020-08-26T02:21:13  *** arowser has quit IRC
 402020-08-26T02:21:55  *** arowser has joined #bitcoin-core-dev
 412020-08-26T02:24:58  *** davec has joined #bitcoin-core-dev
 422020-08-26T02:37:25  *** AaronvanW has quit IRC
 432020-08-26T02:46:10  *** proofofkeags has joined #bitcoin-core-dev
 442020-08-26T02:47:15  *** proofofk_ has joined #bitcoin-core-dev
 452020-08-26T02:47:22  *** Davterra has quit IRC
 462020-08-26T02:47:47  *** Davterra has joined #bitcoin-core-dev
 472020-08-26T02:50:27  *** proofofkeags has quit IRC
 482020-08-26T03:00:01  *** codestr0m has quit IRC
 492020-08-26T03:01:40  *** melande has quit IRC
 502020-08-26T03:02:54  *** melande has joined #bitcoin-core-dev
 512020-08-26T03:16:45  *** melande has quit IRC
 522020-08-26T03:17:54  *** melande has joined #bitcoin-core-dev
 532020-08-26T03:22:25  *** shoman94 has joined #bitcoin-core-dev
 542020-08-26T03:50:19  <kallewoof> Signet PR https://github.com/bitcoin/bitcoin/pull/18267 latest commit now has 1 approach ACK, 1 utACK, 2 test ACKs; more if you count older commits. Feels like more is needed for a merge, but good progress. Please review!
 552020-08-26T04:09:12  *** proofofk_ has quit IRC
 562020-08-26T04:20:40  *** melande has quit IRC
 572020-08-26T04:23:52  *** melande has joined #bitcoin-core-dev
 582020-08-26T04:24:45  *** troygiorshev has quit IRC
 592020-08-26T04:26:42  *** Davterra has quit IRC
 602020-08-26T04:27:05  *** Davterra has joined #bitcoin-core-dev
 612020-08-26T04:27:23  *** vasild has quit IRC
 622020-08-26T04:28:03  *** afk11 has quit IRC
 632020-08-26T04:28:05  *** vasild has joined #bitcoin-core-dev
 642020-08-26T04:28:48  *** afk11 has joined #bitcoin-core-dev
 652020-08-26T04:34:14  *** AaronvanW has joined #bitcoin-core-dev
 662020-08-26T05:06:26  *** AaronvanW has quit IRC
 672020-08-26T05:09:41  *** melande has quit IRC
 682020-08-26T05:10:50  *** melande has joined #bitcoin-core-dev
 692020-08-26T05:18:01  *** melande has quit IRC
 702020-08-26T05:18:13  *** bitcoin-git has joined #bitcoin-core-dev
 712020-08-26T05:18:14  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8d6224fefe01...92735e45badf
 722020-08-26T05:18:15  <bitcoin-git> bitcoin/master fa96574 MarcoFalke: test: Move doxygen comment to header
 732020-08-26T05:18:16  <bitcoin-git> bitcoin/master fa11ff2 MarcoFalke: test: Pass empty tx pool to block assembler
 742020-08-26T05:18:17  <bitcoin-git> bitcoin/master fad84b7 MarcoFalke: test: Activate segwit in TestChain100Setup
 752020-08-26T05:18:18  *** bitcoin-git has left #bitcoin-core-dev
 762020-08-26T05:18:34  *** bitcoin-git has joined #bitcoin-core-dev
 772020-08-26T05:18:34  <bitcoin-git> [bitcoin] fanquake merged pull request #19775: test: Activate segwit in TestChain100Setup (master...2008-testSegwit) https://github.com/bitcoin/bitcoin/pull/19775
 782020-08-26T05:18:35  *** bitcoin-git has left #bitcoin-core-dev
 792020-08-26T05:18:48  *** melande has joined #bitcoin-core-dev
 802020-08-26T06:00:02  *** shoman94 has quit IRC
 812020-08-26T06:07:39  *** melande has quit IRC
 822020-08-26T06:08:49  *** melande has joined #bitcoin-core-dev
 832020-08-26T06:22:04  *** WhereIsMySpoon has joined #bitcoin-core-dev
 842020-08-26T06:22:16  *** lnostdal has quit IRC
 852020-08-26T06:26:03  *** hsmiths has quit IRC
 862020-08-26T06:26:20  *** go121212 has joined #bitcoin-core-dev
 872020-08-26T06:28:34  *** Eagle[TM] has quit IRC
 882020-08-26T06:28:35  *** go11111111111 has quit IRC
 892020-08-26T06:31:41  *** melande has quit IRC
 902020-08-26T06:34:49  *** melande has joined #bitcoin-core-dev
 912020-08-26T07:03:51  *** AaronvanW has joined #bitcoin-core-dev
 922020-08-26T07:08:40  *** lnostdal has joined #bitcoin-core-dev
 932020-08-26T07:08:52  *** sipsorcery has joined #bitcoin-core-dev
 942020-08-26T07:19:16  *** bitcoin-git has joined #bitcoin-core-dev
 952020-08-26T07:19:18  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/92735e45badf...6a2ba626852b
 962020-08-26T07:19:18  <bitcoin-git> bitcoin/master fa40017 MarcoFalke: init: Pass reference to ArgsManager around instead of relying on global
 972020-08-26T07:19:19  <bitcoin-git> bitcoin/master fa33bc2 MarcoFalke: init: Capture copy of blocknotify setting for BlockNotifyCallback
 982020-08-26T07:19:20  <bitcoin-git> bitcoin/master fa9d590 MarcoFalke: scripted-diff: gArgs -> args
 992020-08-26T07:19:22  *** bitcoin-git has left #bitcoin-core-dev
1002020-08-26T07:19:36  *** bitcoin-git has joined #bitcoin-core-dev
1012020-08-26T07:19:36  <bitcoin-git> [bitcoin] fanquake merged pull request #19779: Remove gArgs global from init (master...2008-gArgs) https://github.com/bitcoin/bitcoin/pull/19779
1022020-08-26T07:19:37  *** bitcoin-git has left #bitcoin-core-dev
1032020-08-26T07:24:41  *** melande has quit IRC
1042020-08-26T07:25:21  *** marcoagner has joined #bitcoin-core-dev
1052020-08-26T07:25:51  *** melande has joined #bitcoin-core-dev
1062020-08-26T07:26:26  *** Guyver2 has joined #bitcoin-core-dev
1072020-08-26T07:29:05  *** sr_gi has quit IRC
1082020-08-26T07:29:48  *** sr_gi has joined #bitcoin-core-dev
1092020-08-26T07:36:05  *** AaronvanW has quit IRC
1102020-08-26T07:39:25  *** EagleTM has joined #bitcoin-core-dev
1112020-08-26T07:44:08  *** bitcoin-git has joined #bitcoin-core-dev
1122020-08-26T07:44:10  <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/6a2ba626852b...e80e5b3e4f00
1132020-08-26T07:44:11  <bitcoin-git> bitcoin/master 9e2897d John Newbery: scripted-diff: Rename mininode_lock to p2p_lock
1142020-08-26T07:44:12  <bitcoin-git> bitcoin/master 85165d4 John Newbery: scripted-diff: Rename mininode to p2p
1152020-08-26T07:44:14  <bitcoin-git> bitcoin/master 5e8df33 John Newbery: test: resort imports
1162020-08-26T07:44:15  *** bitcoin-git has left #bitcoin-core-dev
1172020-08-26T07:44:33  *** bitcoin-git has joined #bitcoin-core-dev
1182020-08-26T07:44:33  <bitcoin-git> [bitcoin] fanquake merged pull request #19760: test: Remove confusing mininode terminology (master...2020-08-no-mininode) https://github.com/bitcoin/bitcoin/pull/19760
1192020-08-26T07:44:34  *** bitcoin-git has left #bitcoin-core-dev
1202020-08-26T08:00:47  *** AaronvanW has joined #bitcoin-core-dev
1212020-08-26T08:04:37  *** jonatack has quit IRC
1222020-08-26T08:08:57  *** midnight has quit IRC
1232020-08-26T08:10:13  *** sipsorcery has quit IRC
1242020-08-26T08:18:53  *** Talkless has joined #bitcoin-core-dev
1252020-08-26T08:29:17  *** Eagle[TM] has joined #bitcoin-core-dev
1262020-08-26T08:31:47  *** Dean_Guss has quit IRC
1272020-08-26T08:32:10  *** Dean_Guss has joined #bitcoin-core-dev
1282020-08-26T08:32:36  *** EagleTM has quit IRC
1292020-08-26T08:32:43  *** digi_james has quit IRC
1302020-08-26T08:32:43  *** NicolasDorier has quit IRC
1312020-08-26T08:32:53  *** endogenic has quit IRC
1322020-08-26T08:32:57  *** hebasto has quit IRC
1332020-08-26T08:33:12  *** mariorz has quit IRC
1342020-08-26T08:33:58  *** sipsorcery has joined #bitcoin-core-dev
1352020-08-26T08:35:21  *** EagleTM has joined #bitcoin-core-dev
1362020-08-26T08:36:02  *** fjahr has quit IRC
1372020-08-26T08:36:40  *** hebasto has joined #bitcoin-core-dev
1382020-08-26T08:37:24  *** NicolasDorier has joined #bitcoin-core-dev
1392020-08-26T08:37:37  *** CodeShark____ has quit IRC
1402020-08-26T08:38:37  *** Eagle[TM] has quit IRC
1412020-08-26T08:38:50  *** endogenic has joined #bitcoin-core-dev
1422020-08-26T08:39:13  *** digi_james has joined #bitcoin-core-dev
1432020-08-26T08:39:32  *** belcher has joined #bitcoin-core-dev
1442020-08-26T08:39:34  *** fjahr has joined #bitcoin-core-dev
1452020-08-26T08:40:29  *** CodeShark____ has joined #bitcoin-core-dev
1462020-08-26T08:40:32  *** mariorz has joined #bitcoin-core-dev
1472020-08-26T08:44:02  *** Pavlenex has joined #bitcoin-core-dev
1482020-08-26T08:45:35  *** Pavlenex has quit IRC
1492020-08-26T08:48:21  *** AaronvanW has quit IRC
1502020-08-26T08:48:40  *** AaronvanW has joined #bitcoin-core-dev
1512020-08-26T08:49:55  *** kotare has joined #bitcoin-core-dev
1522020-08-26T08:51:43  *** sdaftuar has quit IRC
1532020-08-26T08:54:10  *** sdaftuar has joined #bitcoin-core-dev
1542020-08-26T09:00:01  *** WhereIsMySpoon has quit IRC
1552020-08-26T09:02:20  *** AaronvanW has quit IRC
1562020-08-26T09:03:46  *** jonatack has joined #bitcoin-core-dev
1572020-08-26T09:04:24  *** andreacab has joined #bitcoin-core-dev
1582020-08-26T09:11:23  *** andreacab has quit IRC
1592020-08-26T09:11:49  *** andreacab has joined #bitcoin-core-dev
1602020-08-26T09:16:07  *** andreacab has quit IRC
1612020-08-26T09:20:03  *** andreacab has joined #bitcoin-core-dev
1622020-08-26T09:21:49  *** bugbot1 has joined #bitcoin-core-dev
1632020-08-26T09:30:15  *** arowser has quit IRC
1642020-08-26T09:30:58  *** arowser has joined #bitcoin-core-dev
1652020-08-26T09:33:43  *** AaronvanW has joined #bitcoin-core-dev
1662020-08-26T09:39:14  *** AaronvanW has quit IRC
1672020-08-26T09:54:16  *** andreacab has quit IRC
1682020-08-26T09:54:46  *** andreacab has joined #bitcoin-core-dev
1692020-08-26T09:55:11  *** bitcoin-git has joined #bitcoin-core-dev
1702020-08-26T09:55:12  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e80e5b3e4f00...a12d9e5fd24a
1712020-08-26T09:55:13  <bitcoin-git> bitcoin/master 2bc2071 Sebastian Falbesoner: util: make EncodeBase32 consume Spans
1722020-08-26T09:55:13  <bitcoin-git> bitcoin/master e2aa1a5 Sebastian Falbesoner: util: make EncodeBase64 consume Spans
1732020-08-26T09:55:14  <bitcoin-git> bitcoin/master a12d9e5 MarcoFalke: Merge #19687: refactor: make EncodeBase{32,64} consume Spans
1742020-08-26T09:55:15  *** bitcoin-git has left #bitcoin-core-dev
1752020-08-26T09:55:31  *** bitcoin-git has joined #bitcoin-core-dev
1762020-08-26T09:55:32  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19687: refactor: make EncodeBase{32,64} consume Spans (master...20200807-util-make-encode-base3264-consume-spans) https://github.com/bitcoin/bitcoin/pull/19687
1772020-08-26T09:55:32  *** bitcoin-git has left #bitcoin-core-dev
1782020-08-26T09:59:27  *** andreacab has quit IRC
1792020-08-26T10:07:05  *** Guyver2_ has joined #bitcoin-core-dev
1802020-08-26T10:10:06  *** Guyver2 has quit IRC
1812020-08-26T10:18:24  *** Myrtle84Howell has joined #bitcoin-core-dev
1822020-08-26T10:22:05  *** jonatack has quit IRC
1832020-08-26T10:27:39  *** andreacab has joined #bitcoin-core-dev
1842020-08-26T10:30:11  *** andreacab has quit IRC
1852020-08-26T10:30:17  *** andreacab has joined #bitcoin-core-dev
1862020-08-26T10:35:48  <vasild> What would be the best approach to use SHA3-256 in Bitcoin Core?
1872020-08-26T10:35:51  <vasild> https://en.wikipedia.org/wiki/SHA-3#Implementations
1882020-08-26T10:40:20  *** andreacab has quit IRC
1892020-08-26T10:41:17  *** andreacab has joined #bitcoin-core-dev
1902020-08-26T10:41:31  *** andreacab has joined #bitcoin-core-dev
1912020-08-26T10:41:35  *** Highway61 has joined #bitcoin-core-dev
1922020-08-26T10:42:58  <MarcoFalke> vasild: Why?
1932020-08-26T10:43:24  <vasild> MarcoFalke: it is used in constructing TORv3 addresses
1942020-08-26T10:45:48  *** Myrtle84Howell has quit IRC
1952020-08-26T10:46:07  <MarcoFalke> I'd say it should be a module in our own source code (like src/crypto/sha1.h)
1962020-08-26T10:48:53  <vasild> MarcoFalke: so, copy-paste (steal) some of the implementations and put it in src/crypto/sha3-256.{h,cpp}?
1972020-08-26T10:49:16  *** spikee has joined #bitcoin-core-dev
1982020-08-26T10:50:36  <MarcoFalke> Yes. Though, I am not sure where to steal from. You might want to ask the libsecp ppl ;)
1992020-08-26T10:50:48  <vasild> Preferred over linking to an external library? I guess its source will rarely change, if ever.
2002020-08-26T10:51:51  <vasild> libsecp ppl: ^ ;-)
2012020-08-26T10:52:50  *** hsmiths has joined #bitcoin-core-dev
2022020-08-26T10:53:25  <fanquake> I can't see a reason why we'd need to link an external library for something like that
2032020-08-26T10:55:47  *** vasild_ has joined #bitcoin-core-dev
2042020-08-26T10:56:43  <vasild_> fanquake: a reason could be to avoid copy-pasting a pile of obscure code into src/ (that will be like a black box) and if upstream applies changes - we will likely forget to pick them. But I guess that will not be often.
2052020-08-26T10:58:00  <fanquake> I'm happy for it to join all the other *obscure* code in https://github.com/bitcoin/bitcoin/tree/master/src/crypto
2062020-08-26T10:58:09  <vasild_> for now I will go with copy-pasting in src/ and will see what reviewers have to say
2072020-08-26T10:58:22  <vasild_> :)
2082020-08-26T10:58:43  *** vasild has quit IRC
2092020-08-26T10:58:44  *** vasild_ is now known as vasild
2102020-08-26T11:01:55  <MarcoFalke> see also commit a5bc9c09177420bd1c6a1f9ece9ecfbe80c453fe which replaces ripemd with an in-tree version
2112020-08-26T11:02:07  *** AaronvanW has joined #bitcoin-core-dev
2122020-08-26T11:06:58  *** AaronvanW has quit IRC
2132020-08-26T11:16:51  <vasild> ok
2142020-08-26T11:27:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2152020-08-26T11:30:40  *** andreacab has quit IRC
2162020-08-26T11:31:57  *** andreacab has joined #bitcoin-core-dev
2172020-08-26T11:32:11  *** tryphe_ is now known as tryphe
2182020-08-26T11:36:26  *** andreacab has quit IRC
2192020-08-26T11:52:30  <wumpus> why would we need to construct our own TORv3 addresses?
2202020-08-26T11:52:52  <wumpus> we only need to store them, right?
2212020-08-26T11:53:25  <wumpus> from our point of view they're simply opaque network addresses
2222020-08-26T12:00:02  *** bugbot1 has quit IRC
2232020-08-26T12:03:49  *** andreacab has joined #bitcoin-core-dev
2242020-08-26T12:07:47  *** andreacab has quit IRC
2252020-08-26T12:10:08  *** bitcoin-git has joined #bitcoin-core-dev
2262020-08-26T12:10:08  <bitcoin-git> [bitcoin] hebasto opened pull request #19813: util, ci: Hard code previous release tarball checksums (master...200826-gpg) https://github.com/bitcoin/bitcoin/pull/19813
2272020-08-26T12:10:09  *** bitcoin-git has left #bitcoin-core-dev
2282020-08-26T12:13:09  <vasild> wumpus: https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki#appendix-b-tor-v3-address-encoding
2292020-08-26T12:14:21  <vasild> wumpus: because we only (plan to) send the 32 byte public key, getting the address from that requires calculating a checksum
2302020-08-26T12:14:53  <vasild> "H" is "SHA3-256"
2312020-08-26T12:19:33  *** sr_gi has quit IRC
2322020-08-26T12:21:59  *** gnomus has joined #bitcoin-core-dev
2332020-08-26T12:25:22  *** sr_gi has joined #bitcoin-core-dev
2342020-08-26T12:27:10  *** sr_gi has quit IRC
2352020-08-26T12:27:31  *** sr_gi has joined #bitcoin-core-dev
2362020-08-26T12:35:54  *** AaronvanW has joined #bitcoin-core-dev
2372020-08-26T12:40:55  *** AaronvanW has quit IRC
2382020-08-26T12:44:21  *** troygiorshev has joined #bitcoin-core-dev
2392020-08-26T12:50:46  *** promag has joined #bitcoin-core-dev
2402020-08-26T12:54:38  *** pinheadmz has joined #bitcoin-core-dev
2412020-08-26T12:54:55  *** promag has quit IRC
2422020-08-26T12:57:32  *** Landryl has quit IRC
2432020-08-26T12:57:56  *** pinheadm_ has quit IRC
2442020-08-26T12:58:04  *** Landryl has joined #bitcoin-core-dev
2452020-08-26T13:04:13  *** arowser has quit IRC
2462020-08-26T13:04:56  *** arowser has joined #bitcoin-core-dev
2472020-08-26T13:05:26  *** shesek has quit IRC
2482020-08-26T13:07:12  *** arowser has quit IRC
2492020-08-26T13:07:55  *** arowser has joined #bitcoin-core-dev
2502020-08-26T13:09:12  *** arowser has quit IRC
2512020-08-26T13:09:56  *** arowser has joined #bitcoin-core-dev
2522020-08-26T13:10:12  *** arowser has quit IRC
2532020-08-26T13:10:55  *** arowser has joined #bitcoin-core-dev
2542020-08-26T13:12:13  *** arowser has quit IRC
2552020-08-26T13:12:55  *** arowser has joined #bitcoin-core-dev
2562020-08-26T13:15:20  *** arowser has quit IRC
2572020-08-26T13:16:02  *** arowser has joined #bitcoin-core-dev
2582020-08-26T13:22:22  *** onokatio has joined #bitcoin-core-dev
2592020-08-26T13:22:35  *** fgfgfg has joined #bitcoin-core-dev
2602020-08-26T13:24:20  *** onokatio has quit IRC
2612020-08-26T13:24:41  *** Highway61 has quit IRC
2622020-08-26T13:25:16  *** arowser has quit IRC
2632020-08-26T13:25:58  *** arowser has joined #bitcoin-core-dev
2642020-08-26T13:26:58  *** AaronvanW has joined #bitcoin-core-dev
2652020-08-26T13:27:21  *** fgfgfg has quit IRC
2662020-08-26T13:29:33  *** andreacab has joined #bitcoin-core-dev
2672020-08-26T13:36:42  *** jonatack has joined #bitcoin-core-dev
2682020-08-26T13:38:27  *** midnight has joined #bitcoin-core-dev
2692020-08-26T13:46:28  *** promag has joined #bitcoin-core-dev
2702020-08-26T13:51:04  *** promag has quit IRC
2712020-08-26T13:53:43  *** Guyver2__ has joined #bitcoin-core-dev
2722020-08-26T13:53:44  *** watersnake1 has quit IRC
2732020-08-26T13:56:02  *** Guyver2_ has quit IRC
2742020-08-26T13:58:09  *** Asbestos_Vapor has joined #bitcoin-core-dev
2752020-08-26T13:58:19  *** arowser has quit IRC
2762020-08-26T13:58:40  *** DeanWeen has joined #bitcoin-core-dev
2772020-08-26T13:59:02  *** arowser has joined #bitcoin-core-dev
2782020-08-26T13:59:57  *** spikee has quit IRC
2792020-08-26T14:01:03  *** Dean_Guss has quit IRC
2802020-08-26T14:01:26  *** Mercury_Vapor has quit IRC
2812020-08-26T14:02:05  *** andreacab has quit IRC
2822020-08-26T14:03:56  *** andreacab has joined #bitcoin-core-dev
2832020-08-26T14:08:26  *** andreacab has quit IRC
2842020-08-26T14:14:29  *** andreacab has joined #bitcoin-core-dev
2852020-08-26T14:20:40  *** andreacab has quit IRC
2862020-08-26T14:22:37  *** andreacab has joined #bitcoin-core-dev
2872020-08-26T14:24:32  *** arowser has quit IRC
2882020-08-26T14:26:55  *** andreacab has quit IRC
2892020-08-26T14:35:24  *** bitcoin-git has joined #bitcoin-core-dev
2902020-08-26T14:35:25  <jamesob> argh. so I'm curious about how people want to handle circular deps. The latest assumeutxo PR (#19806) has introduced one (coinstats -> validation -> coinstats).
2912020-08-26T14:35:26  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a12d9e5fd24a...93ab136a33e4
2922020-08-26T14:35:27  <bitcoin-git> bitcoin/master e133631 Russell Yanofsky: gui: Partially revert #10244 gArgs and Params changes
2932020-08-26T14:35:27  <gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
2942020-08-26T14:35:27  <bitcoin-git> bitcoin/master 91aced7 Russell Yanofsky: gui: Remove unused interfaces::Node references
2952020-08-26T14:35:28  <bitcoin-git> bitcoin/master 102abff Russell Yanofsky: gui: Replace interface::Node references with pointers
2962020-08-26T14:35:30  *** bitcoin-git has left #bitcoin-core-dev
2972020-08-26T14:35:38  <jamesob> wow, timing
2982020-08-26T14:36:18  <jamesob> anyway the two options I see are (i) call it what it is and just fold coinstats into validation, or (ii) mangle the coinstats interface so that the validation dependencies are injected via function parameters (which in this case requires the introduction of a single new parameter)
2992020-08-26T14:37:33  *** Talkless has quit IRC
3002020-08-26T14:37:47  <jamesob> the circular dep is due to this block: https://github.com/jamesob/bitcoin/blob/82ad09bd205dfc4d8f21f17f6515ef73729c4a0d/src/node/coinstats.cpp#L67-L70 - so conceivably we could just pass in a `hash_to_height` function param. But this seems contorted. I think I'm more sympathetic to just folding the code into validation, since it'll be security critical under assumeutxo anyway.
3012020-08-26T14:43:13  *** Talkless has joined #bitcoin-core-dev
3022020-08-26T14:44:33  <luke-jr> jamesob: or just add the circular dep and call it okay? :p
3032020-08-26T14:44:41  *** DeanWeen has quit IRC
3042020-08-26T14:44:58  *** DeanWeen has joined #bitcoin-core-dev
3052020-08-26T14:45:29  <luke-jr> LookupBlockIndex seems like something that shouldn't need to be in validation
3062020-08-26T14:47:24  <luke-jr> long-term it looks like moving that to BlockManager, and BlockManager outside validation, might be the right approach
3072020-08-26T14:47:32  <jamesob> luke-jr: our linter now prevents that
3082020-08-26T14:54:32  <luke-jr> jamesob: it has a list of exceptions
3092020-08-26T14:54:51  <luke-jr> just be sure the .h files don't include each other
3102020-08-26T14:56:01  *** gzhao408 has joined #bitcoin-core-dev
3112020-08-26T15:00:02  *** gnomus has quit IRC
3122020-08-26T15:00:32  <jamesob> luke-jr: oh great, thanks
3132020-08-26T15:01:43  *** andreacab has joined #bitcoin-core-dev
3142020-08-26T15:02:19  *** shesek has joined #bitcoin-core-dev
3152020-08-26T15:06:11  *** andreacab has quit IRC
3162020-08-26T15:18:42  *** TallTim has quit IRC
3172020-08-26T15:22:10  *** moth has joined #bitcoin-core-dev
3182020-08-26T15:25:26  *** TallTim has joined #bitcoin-core-dev
3192020-08-26T15:27:26  <wumpus> vasild: you're right, my bad
3202020-08-26T15:37:09  *** fiatjaf1 has left #bitcoin-core-dev
3212020-08-26T15:37:50  *** fiatjaf1 has quit IRC
3222020-08-26T16:03:10  *** Dean_Guss has joined #bitcoin-core-dev
3232020-08-26T16:04:38  *** DeanWeen has quit IRC
3242020-08-26T16:10:33  * luke-jr grumbles at getting a slow Qt mirror
3252020-08-26T16:12:02  *** kexkey has quit IRC
3262020-08-26T16:29:17  *** sipsorcery has quit IRC
3272020-08-26T16:33:17  *** sipsorcery has joined #bitcoin-core-dev
3282020-08-26T16:37:00  *** sr_gi has quit IRC
3292020-08-26T16:37:38  *** sr_gi has joined #bitcoin-core-dev
3302020-08-26T16:37:41  *** Pavlenex has joined #bitcoin-core-dev
3312020-08-26T16:40:05  *** Pavlenex has quit IRC
3322020-08-26T16:47:08  *** rmc7777 has joined #bitcoin-core-dev
3332020-08-26T16:48:20  *** rmc7777 has joined #bitcoin-core-dev
3342020-08-26T16:53:05  *** Pavlenex has joined #bitcoin-core-dev
3352020-08-26T16:57:09  *** Pavlenex has quit IRC
3362020-08-26T17:01:25  *** behradkhodayar has joined #bitcoin-core-dev
3372020-08-26T17:26:12  *** lnostdal has quit IRC
3382020-08-26T17:27:59  *** bitcoin-git has joined #bitcoin-core-dev
3392020-08-26T17:28:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/93ab136a33e4...30568d3f1e23
3402020-08-26T17:28:00  <bitcoin-git> bitcoin/master fa347b2 MarcoFalke: test: Select at least the fee in wallet_bumpfee to avoid negative amounts
3412020-08-26T17:28:01  <bitcoin-git> bitcoin/master fafc9d5 MarcoFalke: test: Fix intermittent issue in wallet_bumpfee
3422020-08-26T17:28:01  <bitcoin-git> bitcoin/master 30568d3 MarcoFalke: Merge #19778: test: Fix intermittent issue in wallet_bumpfee
3432020-08-26T17:28:03  *** bitcoin-git has left #bitcoin-core-dev
3442020-08-26T17:28:19  *** bitcoin-git has joined #bitcoin-core-dev
3452020-08-26T17:28:19  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19778: test: Fix intermittent issue in wallet_bumpfee (master...2008-testFix) https://github.com/bitcoin/bitcoin/pull/19778
3462020-08-26T17:28:21  *** bitcoin-git has left #bitcoin-core-dev
3472020-08-26T17:28:49  *** sipsorcery has quit IRC
3482020-08-26T17:30:36  *** belcher_ has joined #bitcoin-core-dev
3492020-08-26T17:34:05  *** andreacab has joined #bitcoin-core-dev
3502020-08-26T17:34:07  *** belcher has quit IRC
3512020-08-26T17:37:38  *** sipsorcery has joined #bitcoin-core-dev
3522020-08-26T17:38:07  *** andreacab has quit IRC
3532020-08-26T17:49:50  *** promag has joined #bitcoin-core-dev
3542020-08-26T17:51:10  *** watersnake1 has joined #bitcoin-core-dev
3552020-08-26T17:51:20  *** rmc7777 has quit IRC
3562020-08-26T17:56:52  *** watersnake1 has quit IRC
3572020-08-26T18:00:02  *** moth has quit IRC
3582020-08-26T18:02:09  *** behradkhodayar has quit IRC
3592020-08-26T18:04:41  *** troygiorshev has quit IRC
3602020-08-26T18:07:07  *** troygiorshev has joined #bitcoin-core-dev
3612020-08-26T18:09:45  *** lightlike has joined #bitcoin-core-dev
3622020-08-26T18:10:22  *** watersnake1 has joined #bitcoin-core-dev
3632020-08-26T18:13:06  <luke-jr> any determinism experts on?
3642020-08-26T18:13:35  <luke-jr> did a gitian windows build with a ppc64le host/VM; it's *almost* identical, but all the addresses are different :/
3652020-08-26T18:13:43  <luke-jr> (identical to the x86_64 build, that is)
3662020-08-26T18:17:52  *** justanotheruser has quit IRC
3672020-08-26T18:21:16  *** havenwood1 has joined #bitcoin-core-dev
3682020-08-26T18:24:29  *** Guyver2_ has joined #bitcoin-core-dev
3692020-08-26T18:27:08  *** andreacab has joined #bitcoin-core-dev
3702020-08-26T18:27:38  *** Guyver2__ has quit IRC
3712020-08-26T18:32:09  *** andreacab has quit IRC
3722020-08-26T18:32:24  *** dviola has quit IRC
3732020-08-26T18:34:43  *** promag has quit IRC
3742020-08-26T18:35:02  *** promag has joined #bitcoin-core-dev
3752020-08-26T18:36:33  *** promag has quit IRC
3762020-08-26T18:37:06  *** promag has joined #bitcoin-core-dev
3772020-08-26T18:39:02  *** ihufa has joined #bitcoin-core-dev
3782020-08-26T18:41:47  *** promag has quit IRC
3792020-08-26T18:42:58  *** Highway61 has joined #bitcoin-core-dev
3802020-08-26T19:03:56  *** justanotheruser has joined #bitcoin-core-dev
3812020-08-26T19:04:46  *** dviola has joined #bitcoin-core-dev
3822020-08-26T19:11:49  *** ihufa has quit IRC
3832020-08-26T19:24:28  *** ihufa has joined #bitcoin-core-dev
3842020-08-26T19:35:31  *** bitcoin-git has joined #bitcoin-core-dev
3852020-08-26T19:35:32  <bitcoin-git> [bitcoin] practicalswift closed pull request #19074: tests: Use BasicTestingSetup to initialise fuzzing environment (master...fuzzers-2020-05-26) https://github.com/bitcoin/bitcoin/pull/19074
3862020-08-26T19:35:33  *** bitcoin-git has left #bitcoin-core-dev
3872020-08-26T19:36:08  *** andreacab has joined #bitcoin-core-dev
3882020-08-26T19:59:25  *** promag has joined #bitcoin-core-dev
3892020-08-26T20:02:24  *** andreacab has quit IRC
3902020-08-26T20:02:50  *** andreacab has joined #bitcoin-core-dev
3912020-08-26T20:07:48  *** andreacab has quit IRC
3922020-08-26T20:07:55  *** andreacab has joined #bitcoin-core-dev
3932020-08-26T20:18:04  *** owowo has quit IRC
3942020-08-26T20:23:16  *** promag has quit IRC
3952020-08-26T20:23:23  *** owowo has joined #bitcoin-core-dev
3962020-08-26T20:23:48  *** promag has joined #bitcoin-core-dev
3972020-08-26T20:28:22  *** promag has quit IRC
3982020-08-26T20:31:08  *** promag has joined #bitcoin-core-dev
3992020-08-26T20:31:23  *** andreacab has quit IRC
4002020-08-26T20:31:34  *** andreacab has joined #bitcoin-core-dev
4012020-08-26T20:32:30  *** andreacab has joined #bitcoin-core-dev
4022020-08-26T20:33:07  *** watersnake1 has quit IRC
4032020-08-26T20:37:02  *** andreacab has quit IRC
4042020-08-26T20:42:39  *** Talkless has quit IRC
4052020-08-26T20:44:18  *** Dean_Guss has quit IRC
4062020-08-26T21:00:01  *** havenwood1 has quit IRC
4072020-08-26T21:00:11  *** EagleTM has quit IRC
4082020-08-26T21:02:29  *** ihufa has quit IRC
4092020-08-26T21:05:44  *** andreacab has joined #bitcoin-core-dev
4102020-08-26T21:06:03  *** yanmaani has quit IRC
4112020-08-26T21:10:17  *** andreacab has quit IRC
4122020-08-26T21:13:09  *** kexkey has joined #bitcoin-core-dev
4132020-08-26T21:14:26  *** filchef has joined #bitcoin-core-dev
4142020-08-26T21:15:10  *** filchef has quit IRC
4152020-08-26T21:20:19  *** yanmaani has joined #bitcoin-core-dev
4162020-08-26T21:22:09  *** hardaker has joined #bitcoin-core-dev
4172020-08-26T21:22:10  *** bitcoin-git has joined #bitcoin-core-dev
4182020-08-26T21:22:10  <bitcoin-git> [bitcoin] hebasto closed pull request #19471: util: Make default arg values more specific (master...200708-hint) https://github.com/bitcoin/bitcoin/pull/19471
4192020-08-26T21:22:11  *** bitcoin-git has left #bitcoin-core-dev
4202020-08-26T21:22:30  *** bitcoin-git has joined #bitcoin-core-dev
4212020-08-26T21:22:30  <bitcoin-git> [bitcoin] hebasto reopened pull request #19471: util: Make default arg values more specific (master...200708-hint) https://github.com/bitcoin/bitcoin/pull/19471
4222020-08-26T21:22:40  *** bitcoin-git has left #bitcoin-core-dev
4232020-08-26T21:35:12  *** gzhao408 has quit IRC
4242020-08-26T21:36:24  *** Guyver2_ has quit IRC
4252020-08-26T21:38:15  *** promag has quit IRC
4262020-08-26T21:40:37  *** cfields has quit IRC
4272020-08-26T21:41:06  *** cfields has joined #bitcoin-core-dev
4282020-08-26T21:46:50  *** promag has joined #bitcoin-core-dev
4292020-08-26T21:50:25  *** promag has quit IRC
4302020-08-26T21:58:05  *** watersnake1 has joined #bitcoin-core-dev
4312020-08-26T22:01:36  *** lightlike_ has joined #bitcoin-core-dev
4322020-08-26T22:03:57  *** ghost43 has quit IRC
4332020-08-26T22:04:16  *** ghost43 has joined #bitcoin-core-dev
4342020-08-26T22:04:23  *** lightlike has quit IRC
4352020-08-26T22:05:44  *** watersnake1 has quit IRC
4362020-08-26T22:07:24  *** andreacab has joined #bitcoin-core-dev
4372020-08-26T22:11:55  *** watersnake1 has joined #bitcoin-core-dev
4382020-08-26T22:13:11  *** Gideon37Konopels has joined #bitcoin-core-dev
4392020-08-26T22:17:56  *** alko89 has quit IRC
4402020-08-26T22:17:57  *** watersnake1 has quit IRC
4412020-08-26T22:18:05  *** alko89_ has joined #bitcoin-core-dev
4422020-08-26T22:21:05  *** lightlike_ has quit IRC
4432020-08-26T22:25:30  *** promag has joined #bitcoin-core-dev
4442020-08-26T22:25:31  *** andreacab has quit IRC
4452020-08-26T22:26:01  *** andreacab has joined #bitcoin-core-dev
4462020-08-26T22:29:25  *** Gideon37Konopels has quit IRC
4472020-08-26T22:30:48  *** andreacab has quit IRC
4482020-08-26T22:44:13  *** sipsorcery has quit IRC
4492020-08-26T22:55:55  *** vasild_ has joined #bitcoin-core-dev
4502020-08-26T22:55:58  *** Pavlenex has joined #bitcoin-core-dev
4512020-08-26T22:57:17  *** watersnake1 has joined #bitcoin-core-dev
4522020-08-26T22:59:03  *** vasild has quit IRC
4532020-08-26T22:59:04  *** vasild_ is now known as vasild
4542020-08-26T23:08:13  *** watersnake1 has quit IRC
4552020-08-26T23:09:25  *** marcoagner has quit IRC
4562020-08-26T23:14:16  *** opsec_x12 has quit IRC
4572020-08-26T23:21:23  *** yanmaani has quit IRC
4582020-08-26T23:23:02  *** yanmaani has joined #bitcoin-core-dev
4592020-08-26T23:24:44  *** opsec_x12 has joined #bitcoin-core-dev
4602020-08-26T23:46:36  *** sipsorcery has joined #bitcoin-core-dev