12020-08-27T00:00:02  *** hardaker has quit IRC
  22020-08-27T00:00:18  <jeremyrubin> Has anyone been able to build bitcoin on recent amazon linux?
  32020-08-27T00:01:00  <jeremyrubin> i tried recently under clang and gcc and had no luck
  42020-08-27T00:09:09  *** Pavlenex has quit IRC
  52020-08-27T00:22:17  *** Phace has joined #bitcoin-core-dev
  62020-08-27T00:40:52  *** dergoegge has quit IRC
  72020-08-27T00:50:15  *** sipsorcery has quit IRC
  82020-08-27T00:58:26  *** justanotheruser has quit IRC
  92020-08-27T01:19:23  *** dkrm has quit IRC
 102020-08-27T01:40:13  *** justanotheruser has joined #bitcoin-core-dev
 112020-08-27T01:41:29  *** promag has quit IRC
 122020-08-27T01:46:31  *** shesek has quit IRC
 132020-08-27T01:47:43  *** promag has joined #bitcoin-core-dev
 142020-08-27T01:52:14  *** promag has quit IRC
 152020-08-27T01:54:09  *** promag has joined #bitcoin-core-dev
 162020-08-27T01:58:32  *** promag has quit IRC
 172020-08-27T02:21:54  *** arowser has joined #bitcoin-core-dev
 182020-08-27T02:25:56  *** harrigan has quit IRC
 192020-08-27T02:26:48  *** harrigan has joined #bitcoin-core-dev
 202020-08-27T02:26:50  *** promag has joined #bitcoin-core-dev
 212020-08-27T02:26:56  *** davec has quit IRC
 222020-08-27T02:26:56  *** spinza has quit IRC
 232020-08-27T02:27:12  *** davec has joined #bitcoin-core-dev
 242020-08-27T02:31:24  *** spinza has joined #bitcoin-core-dev
 252020-08-27T02:39:12  *** arowser has quit IRC
 262020-08-27T02:39:57  *** arowser has joined #bitcoin-core-dev
 272020-08-27T03:00:02  *** Phace has quit IRC
 282020-08-27T03:16:25  *** troygiorshev has quit IRC
 292020-08-27T03:19:57  *** shesek has joined #bitcoin-core-dev
 302020-08-27T03:20:46  *** harrigan has quit IRC
 312020-08-27T03:20:56  *** harrigan has joined #bitcoin-core-dev
 322020-08-27T03:21:35  *** mathepauker has joined #bitcoin-core-dev
 332020-08-27T03:49:13  *** arowser has quit IRC
 342020-08-27T03:49:57  *** arowser has joined #bitcoin-core-dev
 352020-08-27T04:09:44  <fanquake> jeremyrubin: I've never tried. Want to post the logs/issues somewhere?
 362020-08-27T04:15:27  *** go11111111111 has joined #bitcoin-core-dev
 372020-08-27T04:17:52  *** go121212 has quit IRC
 382020-08-27T04:42:22  *** bitdex has joined #bitcoin-core-dev
 392020-08-27T05:08:03  *** sr_gi has quit IRC
 402020-08-27T05:08:31  *** sr_gi has joined #bitcoin-core-dev
 412020-08-27T05:17:17  *** davec has quit IRC
 422020-08-27T05:18:13  *** davec has joined #bitcoin-core-dev
 432020-08-27T05:39:56  <jeremyrubin> hmm I destroyed the logs... maybe when i have an hour sometime
 442020-08-27T05:39:56  *** opsec_x12 has quit IRC
 452020-08-27T05:58:18  *** promag has quit IRC
 462020-08-27T06:00:01  *** mathepauker has quit IRC
 472020-08-27T06:21:55  *** jdsharp has joined #bitcoin-core-dev
 482020-08-27T06:25:05  *** bitcoin-git has joined #bitcoin-core-dev
 492020-08-27T06:25:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/30568d3f1e23...28f4e53e168f
 502020-08-27T06:25:06  <bitcoin-git> bitcoin/master 1343c86 Seleme Topuz: test: Update wait_until usage in tests not to use the one from utils
 512020-08-27T06:25:07  <bitcoin-git> bitcoin/master d841301 Seleme Topuz: test: Add docstring to wait_until() in util.py to warn about its usage
 522020-08-27T06:25:08  <bitcoin-git> bitcoin/master 28f4e53 MarcoFalke: Merge #19752: test: Update wait_until usage in tests not to use the one fr...
 532020-08-27T06:25:09  *** bitcoin-git has left #bitcoin-core-dev
 542020-08-27T06:25:25  *** bitcoin-git has joined #bitcoin-core-dev
 552020-08-27T06:25:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19752: test: Update wait_until usage in tests not to use the one from utils (master...master) https://github.com/bitcoin/bitcoin/pull/19752
 562020-08-27T06:25:34  *** bitcoin-git has left #bitcoin-core-dev
 572020-08-27T06:26:17  *** promag has joined #bitcoin-core-dev
 582020-08-27T06:30:26  *** promag has quit IRC
 592020-08-27T06:53:08  *** bitcoin-git has joined #bitcoin-core-dev
 602020-08-27T06:53:08  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19816: test: Rename wait until helper to wait_until_helper (master...2008-testWaithelper) https://github.com/bitcoin/bitcoin/pull/19816
 612020-08-27T06:53:10  *** bitcoin-git has left #bitcoin-core-dev
 622020-08-27T06:57:05  *** jdsharp has quit IRC
 632020-08-27T06:59:58  *** sipsorcery has joined #bitcoin-core-dev
 642020-08-27T07:11:29  *** marcoagner has joined #bitcoin-core-dev
 652020-08-27T07:16:26  *** jonatack has quit IRC
 662020-08-27T07:30:52  *** grawity1 has joined #bitcoin-core-dev
 672020-08-27T07:32:02  *** EagleTM has joined #bitcoin-core-dev
 682020-08-27T07:36:14  *** promag has joined #bitcoin-core-dev
 692020-08-27T07:40:35  *** promag has quit IRC
 702020-08-27T07:42:14  *** tripleslash has quit IRC
 712020-08-27T07:46:36  *** promag has joined #bitcoin-core-dev
 722020-08-27T07:46:38  *** tripleslash has joined #bitcoin-core-dev
 732020-08-27T07:48:43  *** promag has quit IRC
 742020-08-27T07:49:15  *** jonatack has joined #bitcoin-core-dev
 752020-08-27T07:49:15  *** promag has joined #bitcoin-core-dev
 762020-08-27T07:53:18  *** jonatack has joined #bitcoin-core-dev
 772020-08-27T07:57:23  *** Guyver2 has joined #bitcoin-core-dev
 782020-08-27T08:02:56  *** Pavlenex has joined #bitcoin-core-dev
 792020-08-27T08:04:22  *** bitcoin-git has joined #bitcoin-core-dev
 802020-08-27T08:04:23  <bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/28f4e53e168f...2562d5d23863
 812020-08-27T08:04:23  <bitcoin-git> bitcoin/master f36140d fanquake: build: use patch rather than sed in bdb package
 822020-08-27T08:04:24  <bitcoin-git> bitcoin/master 335bd7f fanquake: build: use patch rather than sed in Boost package
 832020-08-27T08:04:25  <bitcoin-git> bitcoin/master 865cb23 fanquake: build: use patch rather than sed in fontconfig package
 842020-08-27T08:04:26  *** bitcoin-git has left #bitcoin-core-dev
 852020-08-27T08:04:42  *** bitcoin-git has joined #bitcoin-core-dev
 862020-08-27T08:04:42  <bitcoin-git> [bitcoin] fanquake merged pull request #19761: build: improve sed robustness by not using sed (master...maximum_sed_robustness) https://github.com/bitcoin/bitcoin/pull/19761
 872020-08-27T08:04:43  *** bitcoin-git has left #bitcoin-core-dev
 882020-08-27T08:06:02  *** Talkless has joined #bitcoin-core-dev
 892020-08-27T08:11:55  *** bitcoin-git has joined #bitcoin-core-dev
 902020-08-27T08:11:55  <bitcoin-git> [bitcoin] fanquake opened pull request #19817: build: libtapi 1100.0.11 (master...libtapi_1100011) https://github.com/bitcoin/bitcoin/pull/19817
 912020-08-27T08:11:56  *** bitcoin-git has left #bitcoin-core-dev
 922020-08-27T08:19:01  *** Pavlenex has quit IRC
 932020-08-27T08:25:01  *** promag has quit IRC
 942020-08-27T08:29:37  *** promag has joined #bitcoin-core-dev
 952020-08-27T08:32:47  *** EagleTM has quit IRC
 962020-08-27T08:34:06  *** promag has quit IRC
 972020-08-27T08:34:32  *** promag has joined #bitcoin-core-dev
 982020-08-27T08:34:50  *** Guyver2_ has joined #bitcoin-core-dev
 992020-08-27T08:37:38  *** Guyver2 has quit IRC
1002020-08-27T08:38:37  *** promag has quit IRC
1012020-08-27T08:39:33  *** promag has joined #bitcoin-core-dev
1022020-08-27T08:43:18  *** jeremyrubin has quit IRC
1032020-08-27T08:43:56  *** promag has quit IRC
1042020-08-27T08:46:19  *** Emcy has quit IRC
1052020-08-27T08:46:43  *** Emcy has joined #bitcoin-core-dev
1062020-08-27T09:00:01  *** grawity1 has quit IRC
1072020-08-27T09:01:37  *** thunderbiscuit[m has quit IRC
1082020-08-27T09:04:11  *** kexkey has quit IRC
1092020-08-27T09:08:34  <wumpus> "improve sed robustness by not using sed" is still in the run for best commit message ever
1102020-08-27T09:11:41  *** bitcoin-git has joined #bitcoin-core-dev
1112020-08-27T09:11:41  <bitcoin-git> [bitcoin] jonatack opened pull request #19818: p2p: change `CInv::type` from `int` to `uint32_t`, fix UBSan warning (master...CInv-type-refactoring) https://github.com/bitcoin/bitcoin/pull/19818
1122020-08-27T09:11:42  *** bitcoin-git has left #bitcoin-core-dev
1132020-08-27T09:19:57  *** promag has joined #bitcoin-core-dev
1142020-08-27T09:21:58  *** Zao_ has joined #bitcoin-core-dev
1152020-08-27T09:32:11  *** kristapsk_ has joined #bitcoin-core-dev
1162020-08-27T09:34:23  *** kristapsk has quit IRC
1172020-08-27T09:43:19  *** Zao_ has quit IRC
1182020-08-27T09:43:19  *** jonatack has quit IRC
1192020-08-27T09:47:28  <_0x0ff> did testnet reset recently? none of the txs in mempool seem to be added into new blocks
1202020-08-27T09:52:35  <_0x0ff> did testnet reset recently? none of the txs in mempool seem to be added into new blocks
1212020-08-27T09:53:23  <_0x0ff> my apologies for a double message, wrong window
1222020-08-27T09:56:38  *** elsimio has joined #bitcoin-core-dev
1232020-08-27T10:00:37  *** promag has quit IRC
1242020-08-27T10:01:06  *** andreacab has joined #bitcoin-core-dev
1252020-08-27T10:01:24  *** promag has joined #bitcoin-core-dev
1262020-08-27T10:02:38  *** kristapsk___ has joined #bitcoin-core-dev
1272020-08-27T10:05:03  *** kristapsk_ has quit IRC
1282020-08-27T10:10:09  *** promag has quit IRC
1292020-08-27T10:10:52  *** promag has joined #bitcoin-core-dev
1302020-08-27T10:16:38  *** promag has quit IRC
1312020-08-27T10:17:24  *** promag has joined #bitcoin-core-dev
1322020-08-27T10:18:18  *** Kariane14Kling has joined #bitcoin-core-dev
1332020-08-27T10:25:30  *** andreacab has quit IRC
1342020-08-27T10:25:56  *** andreacab has joined #bitcoin-core-dev
1352020-08-27T10:29:55  *** andreacab has quit IRC
1362020-08-27T10:32:21  *** promag has quit IRC
1372020-08-27T10:33:08  *** promag has joined #bitcoin-core-dev
1382020-08-27T10:37:51  *** promag has quit IRC
1392020-08-27T10:38:35  *** promag has joined #bitcoin-core-dev
1402020-08-27T10:41:56  *** jonatack has joined #bitcoin-core-dev
1412020-08-27T10:43:06  *** promag has quit IRC
1422020-08-27T10:43:19  *** kristapsk___ has quit IRC
1432020-08-27T10:49:31  *** Tennis has joined #bitcoin-core-dev
1442020-08-27T10:55:10  *** Kariane14Kling has quit IRC
1452020-08-27T10:57:22  *** promag has joined #bitcoin-core-dev
1462020-08-27T10:59:03  *** vasild has quit IRC
1472020-08-27T11:00:49  *** vasild has joined #bitcoin-core-dev
1482020-08-27T11:02:30  *** promag has quit IRC
1492020-08-27T11:05:50  *** promag has joined #bitcoin-core-dev
1502020-08-27T11:07:01  <_0x0ff> seems to be working now
1512020-08-27T11:10:26  *** jp-tourist has joined #bitcoin-core-dev
1522020-08-27T11:12:40  <wumpus> testnet can't just 'reset', it's unreliable though sometimes because of flaky miner behavior, this is one of the reasons for signet
1532020-08-27T11:15:34  *** promag has quit IRC
1542020-08-27T11:16:22  *** promag has joined #bitcoin-core-dev
1552020-08-27T11:18:10  *** bitcoin-git has joined #bitcoin-core-dev
1562020-08-27T11:18:10  <bitcoin-git> [bitcoin] S3RK closed pull request #19774: wallet: deactivate descriptor (master...wallet_deactivate_descriptor) https://github.com/bitcoin/bitcoin/pull/19774
1572020-08-27T11:18:11  *** bitcoin-git has left #bitcoin-core-dev
1582020-08-27T11:21:34  *** promag has quit IRC
1592020-08-27T11:31:49  <_0x0ff> wumpus: noted, thanks for clarifying. I needed testnet unfortunatelly, but everything is OK now.
1602020-08-27T11:46:10  *** EagleTM has joined #bitcoin-core-dev
1612020-08-27T11:51:47  *** harrigan has quit IRC
1622020-08-27T11:52:05  *** harrigan has joined #bitcoin-core-dev
1632020-08-27T11:53:05  *** promag has joined #bitcoin-core-dev
1642020-08-27T11:53:11  <vasild> sipa: any advices on which sha3-256 implementation to import in src/crypto/? (sha3-256 is needed to create torv3 addresses from the 32 byte address public key which we are going to be sending and storing)
1652020-08-27T11:59:35  <vasild> https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki#Appendix_B_Tor_v3_address_encoding -- I guess another option would be to send PUBKEY+CHECKSUM instead of just PUBKEY and never calculate the checksum, if adding sha3-256 would be undesirable
1662020-08-27T12:00:00  <vasild> wumpus: ^
1672020-08-27T12:00:02  *** elsimio has quit IRC
1682020-08-27T12:01:50  <wumpus> vasild: I don't really mind adding it; I think the more compact representation is elegant
1692020-08-27T12:02:00  <wumpus> vasild: I had just forgotten about it sorry
1702020-08-27T12:06:45  <sipsorcery> vasild: a year or so ago, when doing some ethereum work, I ran into issues with different sha3 implementations.
1712020-08-27T12:06:47  <vasild> yes, I agree
1722020-08-27T12:07:24  <sipsorcery> I think most of the problem comes from keccak and sha3 being used interchangeably.
1732020-08-27T12:07:41  <vasild> what issues?
1742020-08-27T12:08:11  <sipsorcery> given sha3 is only going to be for tov3 addresses wouldn't the safest issue be to take the sha3 source from the tor code base?
1752020-08-27T12:09:17  <vasild> ah, you mean if our sha3-256 produces different results than the tor's sha3-256?
1762020-08-27T12:09:17  <sipsorcery> All I can recall about the issue is that calling "sha3" from two different code bases gave different hashes.
1772020-08-27T12:09:54  <vasild> one of the libraries I am considering is cryptopp and it contains this comment:
1782020-08-27T12:10:04  <sipsorcery> I think within the keccak family different parameters can be set for the hash function.
1792020-08-27T12:10:05  <wumpus> that's curious, be careful to check against test vectors from the standard
1802020-08-27T12:10:09  <vasild> The Crypto++ implementation conforms to the FIPS 202 version of SHA3 using F1600 with XOF d=0x06
1812020-08-27T12:10:17  <vasild> Previous behavior (XOF d=0x01) is available in Keccak classes.
1822020-08-27T12:10:28  <wumpus> and against tor itself of course
1832020-08-27T12:10:54  <sipsorcery> Part of the issue seems to be that people started calling  keccak derived function sha3 before the nist standard came out
1842020-08-27T12:11:21  <sipsorcery> but i'm no expert, I just recall it being a pain at the time.
1852020-08-27T12:11:34  <wumpus> I suppose in our case as we will only use sha3 for tor, it's okay if it matches just what they happen to call sha3
1862020-08-27T12:12:09  <vasild> I already checked that "openssl sha3-256" produces same hash as the one used in torv3
1872020-08-27T12:12:24  <wumpus> I remember doing a similar experiment with Python
1882020-08-27T12:12:29  <sipsorcery> yes, could always call it tor-sha3 or something if there was likely to be doubt.
1892020-08-27T12:13:48  *** promag has quit IRC
1902020-08-27T12:14:59  *** promag has joined #bitcoin-core-dev
1912020-08-27T12:16:53  *** bitdex has quit IRC
1922020-08-27T12:20:19  *** someone235 has joined #bitcoin-core-dev
1932020-08-27T12:21:55  *** promag has quit IRC
1942020-08-27T12:22:04  *** cprofitt1 has joined #bitcoin-core-dev
1952020-08-27T12:24:21  *** promag has joined #bitcoin-core-dev
1962020-08-27T12:26:57  *** promag has quit IRC
1972020-08-27T12:33:41  *** promag has joined #bitcoin-core-dev
1982020-08-27T12:39:39  *** Tennis has quit IRC
1992020-08-27T12:46:44  *** _flow_ has joined #bitcoin-core-dev
2002020-08-27T12:50:50  *** twistedline has quit IRC
2012020-08-27T12:54:44  *** troygiorshev has joined #bitcoin-core-dev
2022020-08-27T13:02:14  *** promag has joined #bitcoin-core-dev
2032020-08-27T13:05:13  *** arowser has quit IRC
2042020-08-27T13:05:54  *** arowser has joined #bitcoin-core-dev
2052020-08-27T13:07:11  *** arowser has quit IRC
2062020-08-27T13:07:53  *** arowser has joined #bitcoin-core-dev
2072020-08-27T13:08:12  *** arowser has quit IRC
2082020-08-27T13:08:53  *** arowser has joined #bitcoin-core-dev
2092020-08-27T13:08:59  *** promag has quit IRC
2102020-08-27T13:09:35  *** promag has joined #bitcoin-core-dev
2112020-08-27T13:10:15  *** arowser has quit IRC
2122020-08-27T13:10:47  *** promag has quit IRC
2132020-08-27T13:10:57  *** arowser has joined #bitcoin-core-dev
2142020-08-27T13:11:04  *** promag has joined #bitcoin-core-dev
2152020-08-27T13:11:11  *** arowser has quit IRC
2162020-08-27T13:11:53  *** arowser has joined #bitcoin-core-dev
2172020-08-27T13:12:14  *** arowser has quit IRC
2182020-08-27T13:12:56  *** arowser has joined #bitcoin-core-dev
2192020-08-27T13:15:50  *** promag has quit IRC
2202020-08-27T13:16:40  *** Guyver2_ has quit IRC
2212020-08-27T13:18:00  *** Davterra has quit IRC
2222020-08-27T13:27:23  *** sipsorcery has quit IRC
2232020-08-27T13:30:47  *** gzhao408 has joined #bitcoin-core-dev
2242020-08-27T13:32:19  *** melande has quit IRC
2252020-08-27T13:32:27  *** cprofitt1 has quit IRC
2262020-08-27T13:33:31  *** melande has joined #bitcoin-core-dev
2272020-08-27T13:34:02  *** sipsorcery has joined #bitcoin-core-dev
2282020-08-27T13:37:48  *** Pavlenex has joined #bitcoin-core-dev
2292020-08-27T13:42:51  *** harrigan has quit IRC
2302020-08-27T13:42:55  *** Pavlenex has quit IRC
2312020-08-27T13:44:02  *** harrigan has joined #bitcoin-core-dev
2322020-08-27T13:48:09  *** _flow_ has quit IRC
2332020-08-27T13:48:20  *** _flow_ has joined #bitcoin-core-dev
2342020-08-27T13:48:58  *** davterra has joined #bitcoin-core-dev
2352020-08-27T13:51:37  *** Pavlenex has joined #bitcoin-core-dev
2362020-08-27T14:00:00  *** bitcoin-git has joined #bitcoin-core-dev
2372020-08-27T14:00:00  <bitcoin-git> [bitcoin] fanquake closed pull request #19700: wallet: Replace -zapwallettxes with wallet tool command (master...zapwallettxes-wallettool) https://github.com/bitcoin/bitcoin/pull/19700
2382020-08-27T14:00:01  *** bitcoin-git has left #bitcoin-core-dev
2392020-08-27T14:00:20  *** _flow_ has quit IRC
2402020-08-27T14:00:43  *** _flow_ has joined #bitcoin-core-dev
2412020-08-27T14:03:10  *** melande has quit IRC
2422020-08-27T14:03:51  *** melande has joined #bitcoin-core-dev
2432020-08-27T14:04:22  *** gnomus has joined #bitcoin-core-dev
2442020-08-27T14:04:41  *** melande has quit IRC
2452020-08-27T14:05:49  *** _flow_ has quit IRC
2462020-08-27T14:05:51  *** melande has joined #bitcoin-core-dev
2472020-08-27T14:05:58  *** _flow_ has joined #bitcoin-core-dev
2482020-08-27T14:16:23  *** ghost43 has quit IRC
2492020-08-27T14:19:55  *** ghost43 has joined #bitcoin-core-dev
2502020-08-27T14:21:10  *** Pavlenex has joined #bitcoin-core-dev
2512020-08-27T14:21:27  *** davterra has quit IRC
2522020-08-27T14:21:47  *** Pavlenex has quit IRC
2532020-08-27T14:22:27  *** bitcoin-git has joined #bitcoin-core-dev
2542020-08-27T14:22:28  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2562d5d23863...91af7ef831d3
2552020-08-27T14:22:28  <bitcoin-git> bitcoin/master a13cafc João Barbosa: wallet: GetWalletTx requires cs_wallet lock
2562020-08-27T14:22:29  <bitcoin-git> bitcoin/master d8441f3 João Barbosa: wallet: IsMine overloads require cs_wallet lock
2572020-08-27T14:22:29  <bitcoin-git> bitcoin/master b8405b8 João Barbosa: wallet: IsChange requires cs_wallet lock
2582020-08-27T14:22:30  *** bitcoin-git has left #bitcoin-core-dev
2592020-08-27T14:23:02  *** bitcoin-git has joined #bitcoin-core-dev
2602020-08-27T14:23:03  <bitcoin-git> [bitcoin] laanwj merged pull request #19289: wallet: GetWalletTx and IsMine require cs_wallet lock (master...2020-06-wallet-less-locks) https://github.com/bitcoin/bitcoin/pull/19289
2612020-08-27T14:23:03  *** bitcoin-git has left #bitcoin-core-dev
2622020-08-27T14:28:21  *** davterra has joined #bitcoin-core-dev
2632020-08-27T14:30:18  *** _flow_ has quit IRC
2642020-08-27T14:32:26  *** Guyver2 has joined #bitcoin-core-dev
2652020-08-27T14:42:43  *** Pavlenex has joined #bitcoin-core-dev
2662020-08-27T14:44:53  <wumpus> in any case I would be really surprised if Tor would get SHA3 wrong/non-standard :)
2672020-08-27T14:45:05  <wumpus> vasild: do you have a replacement for #19628 in high prio for review?
2682020-08-27T14:45:09  <gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
2692020-08-27T14:48:21  *** arowser has quit IRC
2702020-08-27T14:48:32  *** dergoegge has joined #bitcoin-core-dev
2712020-08-27T14:49:05  *** arowser has joined #bitcoin-core-dev
2722020-08-27T14:50:13  <MarcoFalke> #proposedmeetingtopic Status of 0.19 minor release https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Needs+backport+%280.19%29%22+is%3Aclosed
2732020-08-27T14:50:34  <MarcoFalke> #proposedmeetingtopic Status of signet implementation in Bitcoin Core
2742020-08-27T15:00:01  *** gnomus has quit IRC
2752020-08-27T15:00:48  *** dkrm has joined #bitcoin-core-dev
2762020-08-27T15:04:41  *** melande has quit IRC
2772020-08-27T15:05:50  *** melande has joined #bitcoin-core-dev
2782020-08-27T15:15:32  <elichai2> how does the `version`message work? how does it know my own IP address? (in the eyes of the receiving node)
2792020-08-27T15:16:08  <MarcoFalke> elichai2: It should be all zeros or another constant
2802020-08-27T15:16:36  <elichai2> ohh, and I thought `CService` has some magic I can't figure out lol
2812020-08-27T15:17:44  <MarcoFalke> There certaily is magic, but #8740 changed what is sent
2822020-08-27T15:17:46  <gribble> https://github.com/bitcoin/bitcoin/issues/8740 | net: No longer send local address in addrMe by laanwj · Pull Request #8740 · bitcoin/bitcoin · GitHub
2832020-08-27T15:19:01  *** proofofk_ has joined #bitcoin-core-dev
2842020-08-27T15:20:40  *** proofofk_ has quit IRC
2852020-08-27T15:22:06  *** tomatopotato has joined #bitcoin-core-dev
2862020-08-27T15:22:43  *** melande has quit IRC
2872020-08-27T15:23:47  *** sr_gi has quit IRC
2882020-08-27T15:23:52  *** melande has joined #bitcoin-core-dev
2892020-08-27T15:28:45  *** relocate has joined #bitcoin-core-dev
2902020-08-27T15:31:26  *** alko89_ has quit IRC
2912020-08-27T15:36:03  <sipa> sipsorcery vasild wumpus: ethereum doesn't actually use sha3, but keccak with parameters that were proppsed for sha3 before it was finalized (and changed afterwards)
2922020-08-27T15:36:42  *** alko89 has joined #bitcoin-core-dev
2932020-08-27T15:37:03  *** kexkey has joined #bitcoin-core-dev
2942020-08-27T15:40:12  <sipsorcery> sipa: yes that's what I found out the hard way. it gets called sha3 in lots of places in the ethereum docs and code comments.
2952020-08-27T15:43:43  <sipsorcery> *that should be the C++ geth code base and docs (I didn't look over ALL the ethereum code)
2962020-08-27T15:45:45  *** promag has joined #bitcoin-core-dev
2972020-08-27T15:49:16  *** andreacab has joined #bitcoin-core-dev
2982020-08-27T15:49:45  *** owowo has quit IRC
2992020-08-27T15:50:32  <jonasschnelli> I finally fixed the macOS build on bitcoinbuilds.org, github integration is next (since it was running more or less without troubles for months, except the missing macOS sdk which is a config problem)
3002020-08-27T15:54:09  *** gribble has quit IRC
3012020-08-27T15:55:08  *** owowo has joined #bitcoin-core-dev
3022020-08-27T15:55:40  <hebasto> jonasschnelli: many thanks!
3032020-08-27T15:59:17  *** andreacab has quit IRC
3042020-08-27T15:59:44  *** andreacab has joined #bitcoin-core-dev
3052020-08-27T16:01:49  *** andreacab has quit IRC
3062020-08-27T16:01:55  *** andreacab has joined #bitcoin-core-dev
3072020-08-27T16:03:34  <elichai2> MarcoFalke: ha! thanks :)
3082020-08-27T16:04:53  *** melande has quit IRC
3092020-08-27T16:05:46  *** promag has quit IRC
3102020-08-27T16:05:54  *** melande has joined #bitcoin-core-dev
3112020-08-27T16:09:32  *** gribble has joined #bitcoin-core-dev
3122020-08-27T16:13:56  *** melande has quit IRC
3132020-08-27T16:15:04  <wumpus> jonasschnelli: thank you!
3142020-08-27T16:19:48  *** andreacab has quit IRC
3152020-08-27T16:21:16  *** Bullit has quit IRC
3162020-08-27T16:21:34  *** Pavlenex has quit IRC
3172020-08-27T16:21:54  *** melande has joined #bitcoin-core-dev
3182020-08-27T16:23:23  *** promag has joined #bitcoin-core-dev
3192020-08-27T16:26:43  <jonatack> jonasschnelli: nice one!
3202020-08-27T16:27:41  *** promag has quit IRC
3212020-08-27T16:29:23  *** promag has joined #bitcoin-core-dev
3222020-08-27T16:30:03  *** cato__ has quit IRC
3232020-08-27T16:35:31  *** sipsorcery has quit IRC
3242020-08-27T16:37:22  *** cato_ has joined #bitcoin-core-dev
3252020-08-27T16:40:43  *** Bullit has joined #bitcoin-core-dev
3262020-08-27T16:41:46  *** Bullit has quit IRC
3272020-08-27T16:42:11  *** Bullit has joined #bitcoin-core-dev
3282020-08-27T16:45:10  <Bullit> Bitcoin QT keeps closing at startup, it crashed suddenly during a youtube, i restarted my computer now Bitcoin QT does not proceed further then blockindex
3292020-08-27T16:46:23  *** sipsorcery has joined #bitcoin-core-dev
3302020-08-27T16:47:47  *** Asbestos_Vapor has quit IRC
3312020-08-27T16:48:03  <Bullit> nope Bitcoin QT still fails to load into full blockchain
3322020-08-27T16:48:07  *** Mercury_Vapor has joined #bitcoin-core-dev
3332020-08-27T16:54:16  <luke-jr> vasild: I don't understand why we need to do the SHA3 on our end. Shouldn't we be able to give Tor the private key, and it give us back an address?
3342020-08-27T16:54:39  <wumpus> Bullit: what causes it to shut down? can you upload the last part of debug.log to some pastebin?
3352020-08-27T16:56:11  <wumpus> luke-jr: please read back this discussion; the .onion urls contain a sha-3 hash as checksum, but in addrv2 only the 32 bytes of raw address data is sent (to save bandwidth), not this checksum, so it needs to be computed client side
3362020-08-27T16:56:55  <sipa> right, this is not about computing our onion address, but to convert between the bip155 encoding and onion addresses
3372020-08-27T16:57:22  <sipa> vasild: happy to help find a sha3 implementation, if needed
3382020-08-27T16:57:34  <wumpus> indeed, it's not needed for determining our own address
3392020-08-27T16:58:35  *** jeremyrubin has joined #bitcoin-core-dev
3402020-08-27T16:58:53  *** bitcoin-git has joined #bitcoin-core-dev
3412020-08-27T16:58:53  <bitcoin-git> [bitcoin] dongcarl opened pull request #19822: chain: Fix CChain comparison UB (master...2020-08-chain-comparison-UB) https://github.com/bitcoin/bitcoin/pull/19822
3422020-08-27T16:58:54  *** bitcoin-git has left #bitcoin-core-dev
3432020-08-27T16:59:51  <Bullit> wumpus: I have uploaded the result of the log of a new crash to pastebin, this is the link>https://pastebin.com/embed_iframe/RWbeCz16
3442020-08-27T17:05:54  *** melande has quit IRC
3452020-08-27T17:06:53  *** melande has joined #bitcoin-core-dev
3462020-08-27T17:07:08  *** arowser has quit IRC
3472020-08-27T17:07:13  <luke-jr> wumpus: oh :x
3482020-08-27T17:07:44  *** promag has quit IRC
3492020-08-27T17:07:49  *** arowser has joined #bitcoin-core-dev
3502020-08-27T17:09:34  <wumpus> Bullit: that's really the end of the log? no error message?
3512020-08-27T17:09:42  *** melande has quit IRC
3522020-08-27T17:12:54  *** melande has joined #bitcoin-core-dev
3532020-08-27T17:13:48  <wumpus> Bullit: in any case, the only advice I can give is to reindex using -reindex-chainstate, it's pretty clear thechainstate is currupt due to the sudden crash
3542020-08-27T17:17:06  *** troygiorshev has quit IRC
3552020-08-27T17:26:23  *** pinheadmz has quit IRC
3562020-08-27T17:30:34  *** reallll has joined #bitcoin-core-dev
3572020-08-27T17:33:58  *** belcher_ has quit IRC
3582020-08-27T17:34:44  *** troygiorshev has joined #bitcoin-core-dev
3592020-08-27T17:43:50  *** relocate has quit IRC
3602020-08-27T17:44:34  *** promag has joined #bitcoin-core-dev
3612020-08-27T17:47:52  <stevenroose> Is the coinbase maturity of regtest different than 100?
3622020-08-27T17:49:25  *** promag has quit IRC
3632020-08-27T17:50:48  <Bullit> wumpus: yes the log really ends in that 0% warning. just before the crash my mouse pointer indicates a loading, I register that loading as a normal interval
3642020-08-27T17:50:58  <MarcoFalke> stevenroose: no it should be 100
3652020-08-27T17:51:49  <MarcoFalke> COINBASE_MATURITY isn't even a chain param
3662020-08-27T17:52:34  <stevenroose> k yeah couldn't find it but wasn't sure if I got the name right
3672020-08-27T17:52:40  <stevenroose> MarcoFalke: thanks
3682020-08-27T17:58:49  <jonatack> stevenroose: some explanation in test/functional/interface_bitcoin_cli.py:17: # COINBASE_MATURITY (100) blocks. Therefore, after mining 101 blocks we expect
3692020-08-27T18:00:02  *** tomatopotato has quit IRC
3702020-08-27T18:09:39  *** promag has joined #bitcoin-core-dev
3712020-08-27T18:10:05  *** troygiorshev has quit IRC
3722020-08-27T18:14:34  *** promag has quit IRC
3732020-08-27T18:17:39  <jonasschnelli> Bullit: no error on screen? What OS are you using? What version of Core?
3742020-08-27T18:19:04  <Bullit> jonasschnelli: A small load on my mouse pointer, and sudden crash, no error log, I am using Windows 10 (15 years experience) I have bitcoin QT 0.20, in the log it says QT 5.9.8
3752020-08-27T18:19:35  *** bitcoin-git has joined #bitcoin-core-dev
3762020-08-27T18:19:36  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/91af7ef831d3...b987e657cda9
3772020-08-27T18:19:36  <bitcoin-git> bitcoin/master a99a3c0 pasta: rpc: Validate provided keys for query_options parameter in listunspent
3782020-08-27T18:19:37  <bitcoin-git> bitcoin/master b987e65 MarcoFalke: Merge #19169: rpc: Validate provided keys for query_options parameter in l...
3792020-08-27T18:19:38  *** bitcoin-git has left #bitcoin-core-dev
3802020-08-27T18:19:59  <jonasschnelli> Bullit: have you ran older versions of Core before? Or freshly installed for the first time on your system?
3812020-08-27T18:20:15  *** bitcoin-git has joined #bitcoin-core-dev
3822020-08-27T18:20:16  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19169: rpc: Validate provided keys for query_options parameter in listunspent (master...bitcoin-validate-keys-listunspent) https://github.com/bitcoin/bitcoin/pull/19169
3832020-08-27T18:20:17  *** bitcoin-git has left #bitcoin-core-dev
3842020-08-27T18:20:33  <Bullit> I ran Bitcoin QT 0.18 on a Linux laptop, which failed early august during the heat, I then installed Bitcoin QT 0.20 on this Windows machine
3852020-08-27T18:20:44  *** melande has quit IRC
3862020-08-27T18:21:33  <jonasschnelli> Bullit: you can try to remove the data directory (where the local blocks, wallet, etc. is stored). Gives it kind of a fresh start. ONLY DO THIS IF YOU HAVEN'T USED THE WALLET
3872020-08-27T18:21:36  <jonasschnelli> See: https://en.bitcoin.it/wiki/Data_directory
3882020-08-27T18:21:50  *** melande has joined #bitcoin-core-dev
3892020-08-27T18:21:53  <jonasschnelli> just remove the complete folder
3902020-08-27T18:22:32  *** tonsofpcs1 has joined #bitcoin-core-dev
3912020-08-27T18:22:40  *** melande has quit IRC
3922020-08-27T18:23:50  *** melande has joined #bitcoin-core-dev
3932020-08-27T18:26:54  <Bullit> jonasschneli: the data directory is on my NAS, downloading and verifying of the blocks gave no problem, but in a Heavy Youtube about British Parliament bitcoin suddenly crashed
3942020-08-27T18:28:26  *** justanotheruser has quit IRC
3952020-08-27T18:30:59  <wumpus> it's well known that bitcoin is one of the heaviest things to run and and excellent CPU burn in test, any subpar hardware will fail on it, I'd suggest you get better hardware first
3962020-08-27T18:31:14  <wumpus> otherwise you'll keep having this over and over again
3972020-08-27T18:31:23  <MarcoFalke> Are NAS supported even?
3982020-08-27T18:31:37  <MarcoFalke> I keep hearing corruption issues with remote disks
3992020-08-27T18:32:21  <Bullit> wumpus: my graphix card is from a 2014 litecoin miner, why would the hardware not suffice?
4002020-08-27T18:32:32  <wumpus> it's not a problem in itself depending on the file sytem, sometimes there's file locking problems, but otherwise it should work fine (as long as you don't have power loss or CPU overheats etc ofc but that's always)
4012020-08-27T18:32:54  <wumpus> Bullit: not cooled well enough if it crashes with heat
4022020-08-27T18:33:14  <Bullit> wumpus: watercooling with a i7 intell
4032020-08-27T18:33:26  <wumpus> still it sounds like a hardware issue
4042020-08-27T18:34:00  *** justanotheruser has joined #bitcoin-core-dev
4052020-08-27T18:34:21  <wumpus> in any case: try reindexing, it'll probably make the problem go away until the next time things overheat
4062020-08-27T18:35:14  *** bitcoin-git has joined #bitcoin-core-dev
4072020-08-27T18:35:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b987e657cda9...15886b08aa5f
4082020-08-27T18:35:14  <bitcoin-git> bitcoin/master b6dcc6d Hennadii Stepanov: gui: Clarify block height label
4092020-08-27T18:35:15  <bitcoin-git> bitcoin/master 15886b0 MarcoFalke: Merge bitcoin-core/gui#40: Clarify block height label
4102020-08-27T18:35:16  *** bitcoin-git has left #bitcoin-core-dev
4112020-08-27T18:35:50  <Bullit> wumpus: the Bitcoin QT crashes at startup, I do not see an opportunity to go into console without seeing my wallet first
4122020-08-27T18:36:22  <vasild> wumpus: not yet next PR to review, it would have been the next commit in https://github.com/bitcoin/bitcoin/pull/19031 but when I looked at it again I realized we can't to CNetAddr::ToString() of a TORv3 and this is where the sha3-256 came. I almost integrated some of the files from crypto++, they are in the public domain. I hope to be able to open a PR tomorrow.
4132020-08-27T18:36:44  <vasild> s/can't to/can't do/
4142020-08-27T18:37:15  <wumpus> Bullit: no need for that, you need to pass -reindex on the command line to the executable itself
4152020-08-27T18:40:03  *** someone235 has quit IRC
4162020-08-27T18:40:29  <Bullit> wumpus: I used a shortcut with -reindex, the Client opens and is reindexing, thanks for the advice
4172020-08-27T18:50:53  *** troygiorshev has joined #bitcoin-core-dev
4182020-08-27T18:55:34  *** pinheadmz has joined #bitcoin-core-dev
4192020-08-27T18:56:37  *** bitcoin-git has joined #bitcoin-core-dev
4202020-08-27T18:56:38  <bitcoin-git> [bitcoin] Z5483 opened pull request #19823: WIP: ci: check if scripted diff is using BSD sed syntax (master...master) https://github.com/bitcoin/bitcoin/pull/19823
4212020-08-27T18:56:39  *** bitcoin-git has left #bitcoin-core-dev
4222020-08-27T19:01:33  <meshcollider> meeting?
4232020-08-27T19:01:50  *** Pavlenex has joined #bitcoin-core-dev
4242020-08-27T19:01:51  <MarcoFalke> meeting!
4252020-08-27T19:02:14  <achow101> meetin'?
4262020-08-27T19:02:19  <sipa> meeting¿
4272020-08-27T19:02:39  *** Pavlenex has quit IRC
4282020-08-27T19:03:12  <jonasschnelli> #startmeeting
4292020-08-27T19:03:12  <lightningbot> Meeting started Thu Aug 27 19:03:12 2020 UTC.  The chair is jonasschnelli. Information about MeetBot at http://wiki.debian.org/MeetBot.
4302020-08-27T19:03:12  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4312020-08-27T19:03:14  <jonasschnelli> hi
4322020-08-27T19:03:14  <MarcoFalke> lekker
4332020-08-27T19:03:19  <hebasto> hi
4342020-08-27T19:03:26  <jonatack> hallo
4352020-08-27T19:03:28  <meshcollider> hi
4362020-08-27T19:03:31  <sipa> hi
4372020-08-27T19:03:32  <wumpus> hi
4382020-08-27T19:03:33  <sipsorcery> hi
4392020-08-27T19:03:34  <amiti> hi
4402020-08-27T19:03:38  <MarcoFalke> hi
4412020-08-27T19:03:44  <achow101> hai
4422020-08-27T19:04:02  * MarcoFalke waiting for the mass-ping
4432020-08-27T19:04:08  <jonasschnelli> Am I right that the only proposed topics are form MarcoFalke? (0.19 minor release / signet)?
4442020-08-27T19:04:17  <wumpus> jonasschnelli: correct
4452020-08-27T19:04:41  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
4462020-08-27T19:04:43  <wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
4472020-08-27T19:05:13  <jonasschnelli> #topic High priority for review
4482020-08-27T19:05:24  <jonasschnelli> is there anything you want to add or remove or replace?
4492020-08-27T19:05:37  <wumpus> https://github.com/bitcoin/bitcoin/projects/8
4502020-08-27T19:05:42  <MarcoFalke> add #19717 :)
4512020-08-27T19:05:44  <gribble> https://github.com/bitcoin/bitcoin/issues/19717 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) by MarcoFalke · Pull Request #19717 · bitcoin/bitcoin · GitHub
4522020-08-27T19:06:15  <wumpus> MarcoFalke: replace #19629?
4532020-08-27T19:06:20  <gribble> https://github.com/bitcoin/bitcoin/issues/19629 | refactor: Keep mempool interface in validation by MarcoFalke · Pull Request #19629 · bitcoin/bitcoin · GitHub
4542020-08-27T19:06:23  <MarcoFalke> jup, removed the other
4552020-08-27T19:07:12  <jonasschnelli> done
4562020-08-27T19:07:30  <MarcoFalke> thx
4572020-08-27T19:07:52  <jonasschnelli> currently 10 blockers, 3 chasing concept ACK (same as last week)
4582020-08-27T19:08:42  <jonasschnelli> #topic Status of 0.19 minor release (MarcoFalke)
4592020-08-27T19:08:56  *** Eagle[TM] has joined #bitcoin-core-dev
4602020-08-27T19:09:23  <MarcoFalke> Well, we should probably wrap that up and ship?
4612020-08-27T19:09:25  *** EagleTM has quit IRC
4622020-08-27T19:09:27  <MarcoFalke> https://github.com/bitcoin/bitcoin/milestone/46
4632020-08-27T19:09:51  <wumpus> sounds good to me, I had no idea that was ready?
4642020-08-27T19:09:58  <MarcoFalke> though, there is still some tagged for backport: https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Needs+backport+%280.19%29%22
4652020-08-27T19:10:36  <jonasschnelli> #19681 looks ready for merge
4662020-08-27T19:10:38  <gribble> https://github.com/bitcoin/bitcoin/issues/19681 | 0.19: Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19681 · bitcoin/bitcoin · GitHub
4672020-08-27T19:11:24  <wumpus> agree
4682020-08-27T19:12:03  <wumpus> so does #18284?
4692020-08-27T19:12:04  <gribble> https://github.com/bitcoin/bitcoin/issues/18284 | [0.19] scheduler: Workaround negative nsecs bug in boosts wait_until by luke-jr · Pull Request #18284 · bitcoin/bitcoin · GitHub
4702020-08-27T19:12:42  <MarcoFalke> 18284 isn't a backport, though
4712020-08-27T19:13:02  <jonasschnelli> if we want to have the http race also fixed in 0.19.2, we should mark #19033 0.19.2,... otherwise move 18856
4722020-08-27T19:13:05  <gribble> https://github.com/bitcoin/bitcoin/issues/19033 | http: Release work queue after event base finish by promag · Pull Request #19033 · bitcoin/bitcoin · GitHub
4732020-08-27T19:13:07  <wumpus> it's labeled 0.19.2 and targetted for 0.19 thugh
4742020-08-27T19:13:44  <MarcoFalke> The bug is not a regression in 0.19, so I am not sure if we *need* to fix it
4752020-08-27T19:14:11  <MarcoFalke> and it doesn't happen on servers
4762020-08-27T19:14:30  <wumpus> why didn't you never comment that on the PR?
4772020-08-27T19:14:43  <wumpus> it has only ACKs now
4782020-08-27T19:14:56  <wumpus> so it looks ready to go at least
4792020-08-27T19:14:57  <MarcoFalke> ok, will leave a comment now
4802020-08-27T19:15:40  <wumpus> it's fine with me to not do it at all, but if no one comments that in months that's not very clear to the author
4812020-08-27T19:15:42  <jeremyrubin> it should only happen if you're mocking the time right?
4822020-08-27T19:16:22  <jonasschnelli> #19033 is ready for merge IMO.. a backport to 0.19.2 should be easy to fix 18856
4832020-08-27T19:16:24  <gribble> https://github.com/bitcoin/bitcoin/issues/19033 | http: Release work queue after event base finish by promag · Pull Request #19033 · bitcoin/bitcoin · GitHub
4842020-08-27T19:16:40  *** melande has quit IRC
4852020-08-27T19:17:05  <MarcoFalke> jeremyrubin: No only if you hibernate/suspend
4862020-08-27T19:17:35  <jamesob> Can I have #19806 added?
4872020-08-27T19:17:36  <jeremyrubin> probably fine to fix then
4882020-08-27T19:17:38  <gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
4892020-08-27T19:17:38  *** dviola has quit IRC
4902020-08-27T19:17:47  <jeremyrubin> jamesob: added to 0.19 backport?
4912020-08-27T19:17:50  *** melande has joined #bitcoin-core-dev
4922020-08-27T19:17:55  <MarcoFalke> high prio
4932020-08-27T19:17:57  <wumpus> the code change itself looked ok to me
4942020-08-27T19:17:58  <jonasschnelli> jeremyrubin: sure. Adding...
4952020-08-27T19:18:14  <jamesob> Oops, we're still on highprio right?
4962020-08-27T19:18:21  <wumpus> it's always possible to argue it's not *worth* fixing, but I think it's kind of strange if there is already a patch
4972020-08-27T19:18:45  <wumpus> if it can happen with hiberbate/suspend that seems like a legit issue?
4982020-08-27T19:18:47  <jonasschnelli> jamesob: no. 0.19.2 (but it's fine)
4992020-08-27T19:19:00  <MarcoFalke> wumpus: Jup, the code change looks fine obviously. Though, it is also boost. A previous version of the patch forgot to catch and re-throw boost::thread_interrupted
5002020-08-27T19:19:55  <MarcoFalke> I'd rather have a known bug that is well understood than an newly introduced intermittent unknown bug
5012020-08-27T19:19:57  <wumpus> is there any urgency to do another 0.19 release at all?
5022020-08-27T19:20:12  <jeremyrubin> reject filtering?
5032020-08-27T19:20:22  *** lightlike has joined #bitcoin-core-dev
5042020-08-27T19:20:24  <MarcoFalke> wumpus: Not really. Not sure how urgent the reject filtering needs to go out
5052020-08-27T19:20:25  <jeremyrubin> that was the main motivator iirc?
5062020-08-27T19:20:42  <sipa> i don't think that's urgent
5072020-08-27T19:22:29  <wumpus> not urgent enough to rush and skip other fixes at least
5082020-08-27T19:22:30  <jonasschnelli> Anything to add to 0.19.2? (MarcoFalke)
5092020-08-27T19:23:05  <MarcoFalke> Not really. Everything should be tagged already.
5102020-08-27T19:23:37  <jonasschnelli> #topic Status of signet implementation in Bitcoin Core (MarcoFalke)
5112020-08-27T19:23:41  *** melande has quit IRC
5122020-08-27T19:24:18  <MarcoFalke> Pretty much a short topic. I only wanted to ask if anyone plans to ACK/NACK/review it.
5132020-08-27T19:24:28  <jeremyrubin> i played around with the impl yesterday. It's pretty good but currently lacking the contrib tools
5142020-08-27T19:24:31  <MarcoFalke> From my view it seems close to ready
5152020-08-27T19:24:40  <jeremyrubin> It was hard for me to fully test it without the contrib tooling
5162020-08-27T19:24:52  *** melande has joined #bitcoin-core-dev
5172020-08-27T19:25:10  <MarcoFalke> jeremyrubin: I'd say Bitcoin Core is the wrong place to add contrib tools for the signet maintainers.
5182020-08-27T19:25:21  <MarcoFalke> They can have their own repo
5192020-08-27T19:25:28  <jeremyrubin> MarcoFalke: disagree -- we should be able to produce blocks for signet
5202020-08-27T19:25:32  <wumpus> we have a maintainer tools repo just add it there
5212020-08-27T19:25:42  <jeremyrubin> I don't care where the tools are
5222020-08-27T19:25:51  <wumpus> https://github.com/bitcoin-core/bitcoin-maintainer-tools
5232020-08-27T19:25:53  <jeremyrubin> But I care that I can't test a signet that I created
5242020-08-27T19:26:01  <sipa> i'm not sure it's really a maintainer tool
5252020-08-27T19:26:03  <MarcoFalke> I agree they should be public
5262020-08-27T19:26:24  <jeremyrubin> I'm saying that it's a bit of a merge precondition. I would ACK if I could finish testing it
5272020-08-27T19:26:33  <wumpus> it's pretty much free for all for anything maintainers need, no need to put signet tools anywhere else
5282020-08-27T19:26:42  <sipa> the expectations may be unclear, but i hope that over time various private signets get spun up - it could even replace regtest over time
5292020-08-27T19:26:52  <michaelfolkson> Can't test jeremyrubin? What can't you test exactly?
5302020-08-27T19:27:10  <jeremyrubin> Well I made my own signet script and network
5312020-08-27T19:27:10  <MarcoFalke> michaelfolkson: Mining blocks
5322020-08-27T19:27:15  <jeremyrubin> And i cannot produce blocks
5332020-08-27T19:27:25  <jeremyrubin> So I can't test peering it and seeing that it works
5342020-08-27T19:27:32  <sipa> doesn't mean it needs to be in the repo right now, but i don't think it'd be unreasonable to have the scripts for working/spining up a signet in the main repo
5352020-08-27T19:28:13  <jeremyrubin> https://en.bitcoin.it/wiki/Signet
5362020-08-27T19:28:18  <sipa> at some point
5372020-08-27T19:28:40  <wumpus> no big objection either, but I would say that there need to be tests for them if you'd put them in the main repo, there's already too many quasi-unmaintained tools
5382020-08-27T19:28:54  <sipa> agree
5392020-08-27T19:28:55  <michaelfolkson> Yeah I'm hazy about what should be in Core, what is covered by Core but I'm sure it will become clearer to me over time
5402020-08-27T19:29:18  <jeremyrubin> Yeah the tools could be somewhere, I'm just commenting that I can't finish testing and ACK without having block producing scripts.
5412020-08-27T19:29:18  <sipa> wumpus: yes, let's not merge things that are untested and then go broken without anyone noticing
5422020-08-27T19:29:23  <wumpus> in any case that doesn't seem necessary for the PR that is open now
5432020-08-27T19:29:38  <MarcoFalke> If they get added to the repo, I hope they are not written in bash at least *hides
5442020-08-27T19:29:41  <jeremyrubin> wumpus: one cannot tested ACK the current code
5452020-08-27T19:29:49  <sipa> jeremyrubin: i don't think that's a blocker for signet itself - the tools are available, right?
5462020-08-27T19:29:53  <sipa> just not in the PR
5472020-08-27T19:29:58  <jeremyrubin> I don't think so AFAIK
5482020-08-27T19:30:04  <wumpus> wait, the tools are not  available *at all*?
5492020-08-27T19:30:12  <wumpus> okay, that seems like a blocker
5502020-08-27T19:30:21  <jeremyrubin> I think they are quasi available
5512020-08-27T19:30:30  <wumpus> why not just ask kallewoof for them
5522020-08-27T19:30:31  <jeremyrubin> In that they exist against a prior version of Signet
5532020-08-27T19:30:32  <jonasschnelli> I guess kallewoof is asleep
5542020-08-27T19:30:36  <jonatack> signet is certainly the PR i've spent the most time doing re-reviews of these past 6 months. it would be nice to begin reviewing follow-ups instead of the whole thing every time.
5552020-08-27T19:30:42  <jeremyrubin> I think they're still finishing them
5562020-08-27T19:31:04  <jeremyrubin> And it's fine if we want follow up work to add the full tools
5572020-08-27T19:31:12  <michaelfolkson> Is it a blocker? There will be future Signet related PRs
5582020-08-27T19:31:14  <jeremyrubin> but if people are wondering why I haven't ACKd it
5592020-08-27T19:31:18  <wumpus> in any case, in including the tools in bitcoin core's repo (+tests) should imo not be a requirement for this PR
5602020-08-27T19:31:27  <jeremyrubin> (which is more or less the current topic)
5612020-08-27T19:31:29  <wumpus> but they need to be available somewhere
5622020-08-27T19:31:29  <jeremyrubin> that's why
5632020-08-27T19:31:36  <sipa> jeremyrubin: seems very reasonable
5642020-08-27T19:31:42  <jeremyrubin> wumpus: +1, I'm happy with them being anywhere
5652020-08-27T19:32:20  *** Dean_Guss has joined #bitcoin-core-dev
5662020-08-27T19:32:28  <jonasschnelli> aren't the tools here: https://github.com/kallewoof/bitcoin/commit/50c839e1d91348408b40b3f8a53e0ef1a7f6da72
5672020-08-27T19:32:58  <MarcoFalke> jonasschnelli: There was a previous version that signed the block, not transactions
5682020-08-27T19:33:10  <MarcoFalke> I'd bet the current one would be easier to write from scratch
5692020-08-27T19:33:14  <sipa> i think it would be good if the signet consensus PR included a trivial python based functional test... even if it's a super simple one with just OP_TRUE as script or so
5702020-08-27T19:33:32  <wumpus> yes
5712020-08-27T19:33:59  <sipa> i don't see any actual testing apart from a fuzz test?
5722020-08-27T19:34:20  <MarcoFalke> sipa: I was planning to write some tests as a follow-up
5732020-08-27T19:34:38  <michaelfolkson> There is this too for setting up your own Signet https://github.com/kallewoof/signet-platform
5742020-08-27T19:34:47  <instagibbs> sipa, could have all tests run with --signet, and it handles it in background using generate* aliased? :)
5752020-08-27T19:35:09  <instagibbs> s/all/some/
5762020-08-27T19:35:11  <wumpus> re-running every test seems like overkill
5772020-08-27T19:35:14  <wumpus> right
5782020-08-27T19:35:15  <MarcoFalke> instagibbs: They'd run for years with that POW
5792020-08-27T19:35:24  <sipa> yeah, i just want to make sure the signet code is exercised in tests
5802020-08-27T19:35:30  <sipa> that does not seem to be the case in the current PR
5812020-08-27T19:35:31  <instagibbs> MarcoFalke, sigregtest ... right
5822020-08-27T19:35:59  <MarcoFalke> heh, regtest should already mimic mainnet in most params
5832020-08-27T19:36:05  <jeremyrubin> michaelfolkson: those tools don't seem to be current
5842020-08-27T19:36:32  <MarcoFalke> Jup, anything that was written before august is outdated
5852020-08-27T19:36:37  <instagibbs> aj and kallewoof have the current block keys, for final might be worth having keys in EU/US for timezone arbitrage
5862020-08-27T19:36:57  <michaelfolkson> Volunteering? :)
5872020-08-27T19:37:15  <instagibbs> I'm moving their timezone, probably, so no
5882020-08-27T19:37:15  <instagibbs> lol
5892020-08-27T19:37:32  <instagibbs> voluntelling achow to run a node
5902020-08-27T19:37:37  <MarcoFalke> ack
5912020-08-27T19:37:59  <jeremyrubin> instagibbs: nack
5922020-08-27T19:38:14  <jeremyrubin> I think we shouldn't try to offer signet as any sort of "use the main one thing"
5932020-08-27T19:38:22  <jeremyrubin> let a thousand ships sail ;)
5942020-08-27T19:38:45  <michaelfolkson> Disagree. But I will post on the mailing list and you can disagree with me there
5952020-08-27T19:38:51  <jeremyrubin> ok
5962020-08-27T19:39:52  <achow101> instagibbs: what am I being voluntold to do?
5972020-08-27T19:40:11  <jeremyrubin> also note that for signet there's not ~that much value in the current multisig setup
5982020-08-27T19:40:15  <jeremyrubin> it's 1 of N
5992020-08-27T19:40:18  <michaelfolkson> Third signer on Signet blocks being mined. Congrats achow101
6002020-08-27T19:40:24  <jeremyrubin> there's no M of N cordination
6012020-08-27T19:40:37  <jeremyrubin> so you can literally do a 1 of 1 and send anyone the key
6022020-08-27T19:40:44  <instagibbs> jeremyrubin, right it's less crucial but "hey bump your server"
6032020-08-27T19:41:03  <instagibbs> well, then it becomes 1 of 1 over time, anyways, not a huge deal
6042020-08-27T19:41:39  <achow101> chaincode should run a signet node then
6052020-08-27T19:41:45  <MarcoFalke> I'd presume it is 1 of 2 to protect against power outages
6062020-08-27T19:41:48  <jeremyrubin> it's current 1 of 2, which has no security improvement over 1 of 1 where two people know the 1
6072020-08-27T19:41:49  *** promag has joined #bitcoin-core-dev
6082020-08-27T19:41:59  <instagibbs> it's not security
6092020-08-27T19:42:00  <instagibbs> it's outages
6102020-08-27T19:42:03  <instagibbs> hence timezone comment
6112020-08-27T19:42:06  <instagibbs> not nation :)
6122020-08-27T19:42:07  <jeremyrubin> it has no outages improvement
6132020-08-27T19:42:49  <sipa> i think you guys are talking past each other
6142020-08-27T19:42:50  <jeremyrubin> unless I'm missing something where you want to know which node created the block
6152020-08-27T19:42:58  <michaelfolkson> It does. If one signer is down blocks can still be mined using sigs from the other signer
6162020-08-27T19:43:05  <sipa> yeah, i think the only difference is accountability
6172020-08-27T19:43:07  <instagibbs> "why not" but also "I've stopped caring" :)
6182020-08-27T19:43:08  <sipa> not sure that matters
6192020-08-27T19:43:20  <instagibbs> so I'll concede i appear to care less and relent
6202020-08-27T19:43:33  <jeremyrubin> Yeah I'm not sure how to make my point more clear but I'll cede the balance of my time (too much CSPAN)
6212020-08-27T19:43:59  <instagibbs> you could softfork out on of the keys(haha)
6222020-08-27T19:44:22  <instagibbs> (100% not serious)
6232020-08-27T19:44:27  * jeremyrubin groans
6242020-08-27T19:44:49  *** pinheadmz has quit IRC
6252020-08-27T19:45:17  <MarcoFalke> 1 of 2 also gives debugability. (You'll see which miner didn't produce blocks)
6262020-08-27T19:45:34  <jeremyrubin> you already get that with coinbase message if you want
6272020-08-27T19:45:38  <sipa> MarcoFalke: yeah, that's commonly called accountability
6282020-08-27T19:46:32  <jeremyrubin> there's maybe an edge on debuggable v.s. provably accountable if the miner-id is a unverified message
6292020-08-27T19:47:27  <sipa> i think this is getting off topic
6302020-08-27T19:47:32  <jonasschnelli> any other last minute topics?
6312020-08-27T19:47:41  <jonatack> so, signet is near-mergeable, just needs a sanity check functional test?
6322020-08-27T19:47:45  <jonatack> jonasschnelli: About 0.19.2 backports -- not a bugfix per se but perhaps #19455. It accompanies the cli -generate addition, which was in 0.19.
6332020-08-27T19:47:48  <gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
6342020-08-27T19:48:10  <luke-jr> re 18284 I don't get why we would intentionally *not* merge a bugfix
6352020-08-27T19:48:30  <MarcoFalke> luke-jr: Because of the risk that it introduces new bugs
6362020-08-27T19:48:32  <jonasschnelli> jonatack: 19455 is not really a bugfix?
6372020-08-27T19:48:32  <luke-jr> it's one thing if people don't give it reviews needed, but once it has review, it doesn't make sense to leave it out
6382020-08-27T19:48:46  <jeremyrubin> jonatack: I think one should be able to stand up a net and generate blocks, which might be a subset of that functional test. That's my watermark for tested ACK
6392020-08-27T19:48:51  <wumpus> I don't think it's particularly risky
6402020-08-27T19:49:08  <jonatack> jonasschnelli: it explains to people that run the former RPC generate that it is now CLI -generate instead
6412020-08-27T19:49:16  <wumpus> then again I ACKed it
6422020-08-27T19:50:02  <jonasschnelli> jonatack: I'd say no need to backport this... but no strong opinion.
6432020-08-27T19:50:21  <jonatack> because several tutorials online still mention rpc generate and it might be confusing for them. Yep, no worry, just mentioning.
6442020-08-27T19:50:41  <MarcoFalke> Yeah, I see it has two ACKs
6452020-08-27T19:51:12  <jonasschnelli> jonatack: Yes. That is a good point.
6462020-08-27T19:51:36  <wumpus> jonatack: I doubt meany people following tutorials will use a new 0.19.x
6472020-08-27T19:51:56  <jonasschnelli> yeah,.. that
6482020-08-27T19:51:58  <wumpus> not opposed to backporting it, but, these kind of backport releases tend to be used for old software on servers
6492020-08-27T19:52:14  <sipa> if used at all
6502020-08-27T19:52:33  <luke-jr> well, some end users intentionally hold back on major updates too; but still unlikely they'd be using the old version for something like this
6512020-08-27T19:52:42  <sipa> right
6522020-08-27T19:52:58  <wumpus> they're definitely downloaded looking at torrent seed server stats etc
6532020-08-27T19:53:06  <sipa> wumpus: good to know
6542020-08-27T19:55:02  <jonasschnelli> #endmeeting
6552020-08-27T19:55:02  <lightningbot> Meeting ended Thu Aug 27 19:55:02 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
6562020-08-27T19:55:02  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-27-19.03.html
6572020-08-27T19:55:02  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-27-19.03.txt
6582020-08-27T19:55:02  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-27-19.03.log.html
6592020-08-27T19:55:21  <jonasschnelli> \o
6602020-08-27T19:55:32  <jonatack> o/
6612020-08-27T19:55:59  <sipa> /o\
6622020-08-27T19:56:49  <jonasschnelli> \Ɵ (masks in public space, folks!)
6632020-08-27T19:58:19  * sipa hands jonasschnelli a really big /128 mask
6642020-08-27T19:58:38  <jonasschnelli> heh
6652020-08-27T19:58:45  *** Guyver2_ has joined #bitcoin-core-dev
6662020-08-27T19:59:22  <wumpus> hehe
6672020-08-27T19:59:24  <midnight> o7
6682020-08-27T20:00:40  *** arowser has quit IRC
6692020-08-27T20:00:57  *** arowser has joined #bitcoin-core-dev
6702020-08-27T20:01:36  *** Guyver2 has quit IRC
6712020-08-27T20:01:50  *** melande has quit IRC
6722020-08-27T20:03:00  *** melande has joined #bitcoin-core-dev
6732020-08-27T20:05:32  *** lightlike has quit IRC
6742020-08-27T20:10:03  *** sdaftuar has quit IRC
6752020-08-27T20:12:33  *** sdaftuar has joined #bitcoin-core-dev
6762020-08-27T20:13:51  *** promag has quit IRC
6772020-08-27T20:14:10  <sipa> achow101: 415afcccd3e5583defdb76e3a280f48e98983301 seems pointless
6782020-08-27T20:14:16  <sipa> +    if (m_storage.CanSupportFeature(FEATURE_HD_SPLIT) && CHDChain::VERSION_HD_CHAIN_SPLIT) {
6792020-08-27T20:14:24  <achow101> sipa: indeed
6802020-08-27T20:14:50  *** Guyver2__ has joined #bitcoin-core-dev
6812020-08-27T20:14:57  <sipa> i'm not sure what it's supposed to do
6822020-08-27T20:15:02  <achow101> upgradewallet is slightly broken. see #18836
6832020-08-27T20:15:05  <gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
6842020-08-27T20:15:58  <sipa> ok
6852020-08-27T20:16:00  <achow101> the original goal of that line was to have `m_hd_chain.nVersion <= CHDCHain::VERSION_HD_CHAIN_SPLIT` but I think that doesn't always work as well
6862020-08-27T20:16:23  <achow101> s/<=/<
6872020-08-27T20:17:28  *** Guyver2_ has quit IRC
6882020-08-27T20:21:12  *** melande has quit IRC
6892020-08-27T20:23:50  *** melande has joined #bitcoin-core-dev
6902020-08-27T20:28:03  *** Guyver2_ has joined #bitcoin-core-dev
6912020-08-27T20:30:49  *** Guyver2__ has quit IRC
6922020-08-27T20:43:14  *** balbirs has quit IRC
6932020-08-27T20:43:25  *** balbirs has joined #bitcoin-core-dev
6942020-08-27T20:45:34  *** vincenzopalazzo has quit IRC
6952020-08-27T20:47:36  *** Era76Macejkovic has joined #bitcoin-core-dev
6962020-08-27T20:53:26  *** promag has joined #bitcoin-core-dev
6972020-08-27T20:57:56  *** promag has quit IRC
6982020-08-27T21:00:01  *** tonsofpcs1 has quit IRC
6992020-08-27T21:06:15  *** Talkless has quit IRC
7002020-08-27T21:10:28  *** pinheadmz has joined #bitcoin-core-dev
7012020-08-27T21:11:37  *** Era76Macejkovic has quit IRC
7022020-08-27T21:12:46  *** yanmaani has quit IRC
7032020-08-27T21:13:20  *** yanmaani has joined #bitcoin-core-dev
7042020-08-27T21:18:41  *** Guyver2_ has quit IRC
7052020-08-27T21:20:40  *** melande has quit IRC
7062020-08-27T21:21:28  *** Perlboy has joined #bitcoin-core-dev
7072020-08-27T21:21:51  *** melande has joined #bitcoin-core-dev
7082020-08-27T21:23:18  *** dkrm has quit IRC
7092020-08-27T21:26:48  *** melande has quit IRC
7102020-08-27T21:31:17  *** melande has joined #bitcoin-core-dev
7112020-08-27T21:34:50  *** reallll is now known as belcher
7122020-08-27T21:47:25  *** Eagle[TM] has quit IRC
7132020-08-27T22:12:45  *** sipsorcery has quit IRC
7142020-08-27T22:19:44  *** melande has quit IRC
7152020-08-27T22:23:00  *** melande has joined #bitcoin-core-dev
7162020-08-27T22:33:00  *** sipa has quit IRC
7172020-08-27T22:36:19  *** promag has joined #bitcoin-core-dev
7182020-08-27T22:51:26  *** marcoagner has quit IRC
7192020-08-27T22:55:49  *** vasild_ has joined #bitcoin-core-dev
7202020-08-27T22:57:13  *** troygiorshev has quit IRC
7212020-08-27T22:59:03  *** vasild has quit IRC
7222020-08-27T22:59:04  *** vasild_ is now known as vasild
7232020-08-27T23:05:51  <yanmaani> How do I build bitcoin using depends/ bdb4.8 but system qt / boost / whatever?
7242020-08-27T23:11:51  *** sipsorcery has joined #bitcoin-core-dev
7252020-08-27T23:16:20  *** opsec_x12 has joined #bitcoin-core-dev
7262020-08-27T23:16:40  *** melande has quit IRC
7272020-08-27T23:17:50  *** melande has joined #bitcoin-core-dev
7282020-08-27T23:23:43  *** yanmaani has quit IRC
7292020-08-27T23:26:03  *** yanmaani has joined #bitcoin-core-dev
7302020-08-27T23:40:42  *** melande has quit IRC
7312020-08-27T23:40:58  *** watersnake1 has joined #bitcoin-core-dev
7322020-08-27T23:41:51  *** melande has joined #bitcoin-core-dev
7332020-08-27T23:50:20  *** bitcoin-git has joined #bitcoin-core-dev
7342020-08-27T23:50:20  <bitcoin-git> [bitcoin] dhruv opened pull request #19825: rpc: simplify setban and consolidate BanMan functions (master...consolidate-ban-functions) https://github.com/bitcoin/bitcoin/pull/19825
7352020-08-27T23:50:21  *** bitcoin-git has left #bitcoin-core-dev
7362020-08-27T23:55:21  *** sipsorcery has quit IRC